=== urbanape_ is now known as urbanape
JamesTaitGood morning all!08:06
mandelmorning all!08:56
mandelfagan, buenos dias!08:56
=== mpt_ is now known as mpt
karniGood morning!10:24
gatoxmandel, hi10:29
mandelgatox, hello!10:32
mandelgatox, did you get my number?10:32
gatoxmandel, hi!! you send me a ping10:32
gatoxmandel, yes yes THANKS!10:32
mandelgatox, it was just for that ;)10:32
gatoxmandel, jeje ok!! thanks!!! you will be receiving an awesome phone now! :P10:33
mandelgatox, cool, then if they ever give you a tracking number let me know :)10:33
gatoxmandel, yes10:33
gatoxfacundobatista, buenas10:33
duanedesignmorning all10:35
mandelduanedesign, morning!10:44
gatoxhi nessita!11:04
nessitahello everyone!11:08
gatoxnessita, let me know when you are free..... i have a branch already approved by ralsina11:09
gatoxpending for review11:09
nessitagatox: shoot!11:11
gatoxnessita, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/uninstall/+merge/7240211:12
facundobatistaHola nessita11:14
nessitahola facundobatista11:14
nessitagatox: inside the windows implementation of uninstall, is it needed to ask  if sys.platform == "win32" and ...?11:16
gatoxnessita, sorry win32 part shouldn't be there11:17
nessitagatox: also, I've noticed you tend to write a long lines of code in multiple lines, instead of defining variables. That approach is not wrong at all, but usually makes code a bit harder to read. For example, lines 343-346 in your diff are very hard to parse for new eyes. Examples of how to improve that are http://pastebin.ubuntu.com/673732/11:23
nessitagatox: so, of course you don't need to change anything already done in our code base, but could you improve a bit the uninstall_application?11:24
gatoxnessita, ok, on it... anyway i did it that way to avoid unnecesary assignments11:25
nessitagatox: there is no recommended "official" guideline about this, as far as I know, but I personally think that is better to do assignments that have those long lines, which are hard to follow and match parenthesis11:26
nessitafacundobatista: do you know if there is an official guideline? ^11:26
nessitahum, I'm finding something in pep-811:26
gatoxnessita, what it says?11:27
facundobatistanessita, the official guideline is to let the coder use his/her own style if there's no official guideline :)11:27
facundobatistanessita, that said, which code is it?11:27
facundobatistaah, the mp11:27
nessitafacundobatista: specifically, lines 343-351 https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/uninstall/+merge/7240211:28
facundobatistathat *is* ugly :)11:28
nessitagatox: well, it talks about indenting, but in the examples always uses variable names, not more calls. Another issue is that any call fail, is harder to debug which one, since they are all together in the same "sentence"11:29
nessitafacundobatista: yes, I agree, but I've noticed is ralsina and gatox's style11:29
nessitamaybe is a QT thingy? :-P11:29
gatoxnessita, :P11:29
gatoxnessita, don't worry... i'm changing uninstall implementation11:29
nessitagatox: you follow me about the hardness of reading that (specially matching parenthesis) and the complex of debugging if there is an exception in that line? I mean, thanks for changing it, but I would like to know if you may see the point to it or you just want me to shut up :-D11:30
gatoxnessita, jejeje yes, i see the point, it's easier to read, no doubt there... anyway i prefer always to avoid unnecessary assignments... but not problem11:32
mandelI think is just to make you shut up....11:32
* mandel hides11:32
gatoxmandel, jeje hey!11:32
* mandel is not here11:32
nessitagatox: well, if you think you're using the variable in another call is not unnecessary :-D11:33
faganmandel: you cant hide from nessita11:33
nessitamandel: just the men I was looking for!11:33
facundobatistagatox, also, you're repeating a lot of code!11:33
nessitamandel: so, how is it going with rick's bug?11:33
facundobatistagatox, I'd do this: http://pastebin.ubuntu.com/673740/11:33
facundobatistanessita, ^11:33
gatoxfacundobatista, let me see11:33
nessitafacundobatista: right, minus a syntax issue there, I agree11:34
mandelnessita, I've fixed the quota bug and running the test atm on linux so I can propose and will start looking into that right now, I was going to send that in the report as soon as tests pass :)11:34
gatoxfacundobatista, yes, you are right11:34
facundobatistanessita, ah, yes, I edited it on the fly11:34
nessitamandel: the quota bug? was still there?11:34
nessitagatox: once that's done, we'll talk about the test. Big applause for adding them, but we need to make some adjustments :-)11:35
mandelnessita, yes, this one: https://bugs.launchpad.net/ubuntuone-client/+bug/72739611:35
ubot4Launchpad bug 727396 in ubuntuone-client (Ubuntu Natty) (and 2 other projects) "AttributeError: 'Root' object has no attribute 'subscribed' (affects: 1) (heat: 8)" [Medium,In progress]11:35
mandeloi!!! hal is back!!!! \o/11:36
gatoxnessita, ok!! no problem... i'm applying facundobatista changes right now...11:36
nessitamandel: was it a windows-only bug?11:36
nessitagatox: great!11:36
mandelnessita, nop, linux too11:36
mandelnessita, Root (as in volume_manager.Root) does not have that attribute so I added tests to ensure that the get_share_dict is not called and that we use get_udf_dict, also ensure that it works with root11:37
nessitamandel: nice!11:37
mandelnessita, will be pinging chicharra for a review of that11:37
nessitamandel: please, in particular guillo11:41
gatoxnessita, changes done: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/uninstall/+merge/7240211:46
gatoxnessita, let's talk about tests! :P11:46
nessitagatox: so, you added a test_windows.py that tests the uninstall, which is great, but there is some coupling in that module between the code in utils itself and the gui. So, we should have the utils/tests/test_windows.py only tetsing uninstall_application and nothing else, no calls to GUI whatsoever11:48
nessitaneither imports to gui, nor to any module outside utils that is not standard lib or 3rd party, of course11:48
nessitaso, for utils, you should have a couple of tests asserting:11:49
nessita* sys.frozen is defined -> call uninstall app having the win32api.ShellExecute patches and assert over params11:49
nessita* sys.frozen not defined -> call uninstall app having the win32api.ShellExecute patches and assert over params11:49
gatoxnessita, ok, let me change that.....11:50
nessitagatox: wait!!!11:50
gatoxnessita, yes?11:50
nessitagatox: that's for the utils tests. Then, since we're adding these lines to gui.py11:51
nessita61+        elif self.currentId() == self.LICENSE_PAGE_ID:11:51
nessita62+            if not AreYouSure(self).exec_():11:51
nessita63+                utils.uninstall_application()11:51
nessitawe need to also write tests inside test_gui for this adding11:51
nessitagatox: so, in those tests, you will patch utils.uninstall_application and assert it was called in the proper scenario11:51
nessitayou also need to test that *it was not called* in the other scenario, since this is sensitive11:51
mandelnessita, ping11:52
nessitagatox: makes sense?11:52
nessitamandel: pong11:52
gatoxnessita, yep11:52
nessitagatox: I'll add this to the MP11:52
mandelnessita, do you know which version of sd was rick using?11:53
nessitamandel: no, but is pretty newish11:53
nessitamandel: Thursday installer afaik11:53
mandelnessita, hmm we seem to have fs notification very broken, get_by_path fails when the \\?\ is not present...11:54
mandelnessita, which looks like the fs are adding events with it.. has alecu finished with the fs_notifications code?11:54
nessitamandel: pretty much, yes. Where are you seeing that  get_by_path fails when the \\?\ is not present?11:56
nessitamandel: I would guess that is only True for old metadata11:56
mandelnessita, https://launchpadlibrarian.net/77877394/syncdaemon-exceptions.log11:56
mandelnessita, the first exceptions, which are also very wrong11:56
mandelnessita, since, it should not fail and that path should never be requested...11:57
nessitamandel: this exceptions.KeyError: 'C:\\Users\\Rick McBride\\AppData\\Local\\xdg\\cache\\ubuntuone\\log' does not mean the \\?\ must to be there!11:57
nessitamandel: that means we're injecting events in the system that are not synced by syncdaemon11:57
mandelnessita, yes, you are right11:57
mandelnessita, but it means that the fs_notifications he was using are very very broken....11:57
nessitamandel: so this is a dup of what Chipaca was saying yesterady about the watches being crazy11:57
nessitamandel: seems like that is the case in the Thursday installer. Can you please try to reproduce?11:58
mandelnessita, yes :)11:58
nessitamandel: I guess you need a fresh account and run that installer11:58
nessitamandel: be sure to have no metadata present11:58
mandelnessita, okis11:58
nessitamandel: and use a dummy account, but with an UDF located next to the Ubuntu One folder11:58
mandelnessita, ok12:00
ralsinaI did a new installer last night, you could ask rick to try again. He may have to remove metadata to start cleanly, right?12:00
mandelralsina, yes, that would be the best thing to do12:01
nessitaralsina: anyway, we have a bigger issue here12:01
nessitamandel: can you try the same to reproduce?12:01
ralsinayes, I see you mentioned extra events?12:01
mandelnessita, ralsina what extra events?12:02
nessitaralsina: we're getting watches in the user home which triggers bazilliong of events12:02
ralsinalet me see my logs...12:02
nessitaralsina: which most of them fail, since they are not "valid events" for syncdaemon12:02
ralsinayep, and for extra fun, that means we watch our log folder :-(12:02
nessitaralsina: you need to have a subscribed UDF next to Ubuntu One folder12:03
mandeloh, that yes... very very bad... the add_ancestors_wathces seems to be broken12:03
nessitamandel: maybe. I would love if you can reproduce and reduce the source of the issue12:03
mandelnessita, on it12:03
nessitamandel: get_udf_dict also requests the subscribed member12:07
nessitamandel: why would that fix the error when using Root?12:07
nessita(referring to https://code.launchpad.net/~mandel/ubuntuone-client/missing-subscribed/+merge/72704)12:07
mandelnessita, give me 1 min and I'll get back to you12:08
mandelnessita, it only looks at it if it is present in the __dict__ but it does not use share.subscribed. Look at line 38 of interaction interfaces and line 5812:11
mandelnessita, I think that we should use get_udf_dict for root since it is not a share... also look how the tests use get_udf_dict and do not fail12:12
nessitamandel: Root *is* a share from syncdaemon point of view12:12
nessitamandel: and using get_udf_dict is confusing and sematically wrong, since Root is not and UDF but a Share inside syncdaemon12:13
nessitamandel: we may create a new get_root_dict and re-use that inside the other dicts12:14
nessitaor we can change this:12:14
nessita     38     if 'subscribed' not in share_dict:12:14
nessita     39         share_dict['subscribed'] = share.subscribed12:14
nessitato be12:14
mandelnessita, sure, that seems a reasonable change12:14
nessita     38     if 'subscribed' not in share_dict and getattr(share, 'subscribed', None) is not None:12:14
nessita     39         share_dict['subscribed'] = share.subscribed12:14
mandelnessita, what about getattr(share, 'subscribed', True) since Root is always subscrined?12:15
mandelnessita, or check in the type of the instance12:15
nessitamandel: the first one will not work, since we can have (old) shares without the attr and yet the subscribed should not be True12:17
nessitamandel: and we should not send the subscribed attr for the Rott object12:18
nessitamandel: so, if you don't like the getattr+None, let's define a new method for share, but the change will be bigger (we need to modify all the places where get_share_dict is used)12:18
mandelnessita, ok, I can change the get_share_dict method and add a comment about root12:18
mandelnessita, I don't mind the getattr I was thinking about the results I've seen when running get_udf_dict on a root, that is all12:19
nessitamandel: root is not an udf! :-)12:20
mandelnessita, line 95 in tests/syncdaemon/interaction_interfaces.py12:20
nessita     95     def current_status(self):12:20
nessitaah, tests12:21
mandelnessita, :)12:21
nessitamandel: what's your point?12:21
mandelnessita, that I though we have to provide it because its in the __dict__ that is all12:21
nessitathat test is wrong, Root should not get a subscribed attr12:22
nessitamuch less a suggested_path, and is not getting one by a implementation detail12:22
nessitathat if it gets changed, we'll end up with Root instances with suggested_path attrs12:22
mandelnessita, ok, then I'll change the get_share_dict implementation and will change the test a little12:23
nessitamandel: so, do you follow me that Root is treated like a share, inside syncdaemon?12:23
mandelnessita, I trust that you are right on that, I don't know the exact semantics of those realtions12:24
mandelyou know more about that area, so I'll trust you :)12:24
ralsinanessita, mandel: trivial review -- https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix-setup/+merge/7270712:27
* mandel looks12:28
mandelralsina, ubuntuone_log_dir is not lonver used?12:30
gatoxnessita, all the changes are ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/uninstall/+merge/7240212:30
ralsinamandel: it will stay in u1-client where everyone else expects it to be12:30
ralsinamandel: a previous branch moved the xdg stuff into sso, and that one went long by mistake12:31
nessitagatox: ack12:31
mandelnessita, susbcribed will be present in Root look at the definition od f Volume, line 121 in volume_manager.py12:33
mandelralsina, ok12:33
nessitamandel: looking12:35
=== m_conley_away is now known as m_conley
nessitamandel: right, and subscribed will always be True12:36
nessitamandel: then I don't see the bug in the current code12:36
mandellet me check that12:37
mandelnessita, indeed doint a Root().subscribed states that is present... we can reject the merge and set the bug as invalid, or update the tests to use the correct get_share_dict and have an excuse to add more tests12:39
mandelnessita, as you wish....12:39
nessitamandel: I'm not sure I understood the second option12:39
mandelnessita, more tests where added for a module that has none, lets reject the MP, set bug as invalid and push the tests in a new branch12:40
mandelso that we do not loos the work12:40
mandelralsina, I dont understand one thing ubuntu_sso.xdg_base_directory.py already existed but was not being added in the package?12:40
ralsinamandel: yes12:40
nessitamandel: ok12:41
mandelralsina, weird... and how did the thing work?12:42
ralsinamandel: when was the lst time you actually *installed* sso using setup.py? :-D12:42
mandelralsina, I never use setup.py I was copying the code to my path :P12:44
mandelralsina, does uninstall remove the metadata? it would be nice if it did12:44
ralsinamandel: doesn't and can't12:46
ralsinabecause we are uninstalling from the system, so we don't know which users have metadata12:46
mandelralsina, oh... I wonder what happens when you try to uninstall and is running... does it brake?12:47
ralsinamandel: it probably stops working12:48
ralsinanot the same as breaking ;-)12:48
mandelralsina, but who, sd or the uninstaller? because if it tries to remove a file that is being opened it wont be able, and a running process is using the process file, right?12:50
mandelsolo estoy tocando las bolas ;)12:50
ralsinamandel: I *could* add checks to see if the files are open and then ask for a reboot or something like that.12:50
ralsinamandel: I am not sure12:50
mandelralsina, I'm going to guess that the app we use to create that is smart enought to mark it as remove on reboot, but I dont know... is something to consider...12:51
ralsinamandel: it probably is, but yes, someone should test it12:51
mandelrmcbride, ^ :P12:52
mandelI'm learning to delegate hehehe12:52
faganbad enter button12:55
ralsinafagan alecu mandel nessita dobey gatox: standup in 5'12:56
gatoxralsina, ack12:56
faganralsina: ack ack :)12:56
mandelralsina, gatox, nessita has anyone created a UDF from control panel and seen it in the UI?12:59
ralsinaI have created one from the wizard, which is the same widget12:59
ralsinaand I have seen it on the u1cp UI but had to kill syncdaemon first12:59
mandelralsina, in the last one I'm tryng to create one and I dont get it :(13:00
faganralsina dobey mandel13:00
faganill go13:01
fagan* Read a book13:01
fagan* what ever anyone needs13:01
fagan* No13:01
fagangatox: go13:01
gatoxBranch for Bug #823414 and Bug #824653 should be ready to merge.13:01
gatoxKeep working on: Bug #829652, Bug #82936513:01
ubot4gatox: Bug 823414 on http://launchpad.net/bugs/823414 is private13:01
ubot4Launchpad bug 824653 in ubuntuone-windows-installer "QT UI no graphic UI for the uninstaller (affects: 1) (heat: 8)" [High,In progress] https://launchpad.net/bugs/82465313:01
ubot4gatox: Bug 829652 on http://launchpad.net/bugs/829652 is private13:01
gatoxnessita, go13:01
ubot4gatox: Bug 829365 on http://launchpad.net/bugs/829365 is private13:01
nessitaDONE: bug #831043, bug #81819013:02
nessitaTODO: finish aforementioned bugs, windows side is crashing13:02
nessitaBLOCKED: a little13:02
nessitaNEXT: mandel13:02
ubot4Launchpad bug 831043 in ubuntuone-client (and 1 other project) "Provide a linux implementation for login_email_password (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/83104313:02
ubot4Launchpad bug 818190 in ubuntuone-client "The Qt implementation is not filtering by appname correctly (affects: 1) (heat: 26)" [High,Triaged] https://launchpad.net/bugs/81819013:02
mandelDONE: looked at bug 727396 set as in valid per talk with nessita yet will create a branch with the added tests so work is not lost.Started looking t bug 83163413:02
mandelTODO: 831634 + others. Look at flights tickets for Pycon AR.13:02
mandelBLOCKED: no13:02
mandelralsina, go!13:02
ubot4Launchpad bug 727396 in ubuntuone-client (Ubuntu Natty) (and 2 other projects) "AttributeError: 'Root' object has no attribute 'subscribed' (affects: 1) (heat: 8)" [Medium,Invalid] https://launchpad.net/bugs/72739613:02
ralsinaDONE: started moving xdg to the right places, started fixing the stderr mess on windows, minor installer fixes, calls, administrivia. TODO: finish xdg-moving, finish stderr, fix the opening of folders in u1cp. BLOCKED: no13:02
ubot4Launchpad bug 831634 in ubuntuone-client "ActionQueue - Upload Error running the command: Path u'\\\\?\\c:\\users\\rickmc~1\\appdata\\local\\temp\\tmpkxbjks' should be a bytes sequence (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/83163413:02
nessitamandel: probably13:03
mandelI need to go for lunch or I'll kill myself driving trying to get to the mumble call :)13:03
ralsinaanyone seen alecu?13:03
mandeland I drive like a spaniard :P13:03
* mandel lunch13:03
ralsinanessita: you claimed this one, right? https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix-setup/+merge/7270713:06
nessitayes, queued up for review13:06
ralsinanessita: ok13:06
dobeyλ DONE: jenkins call, nearly finished bug #82819513:07
dobeyλ TODO: finish #828195, installer release/upload13:07
dobeyλ BLCK: None.13:07
ubot4Launchpad bug 828195 in ubuntuone-installer "Wrong text content in installer (affects: 1) (heat: 6)" [Undecided,In progress] https://launchpad.net/bugs/82819513:07
nessitaralsina: needs fixing'd13:07
ralsinanessita: could you set it to approved so I can fix the lint and push it? trunk is broken without this13:07
nessitaralsina: ah, I need to review the code still13:08
nessitahi alecu13:08
ralsinanessita: ok. The good thing is, it only removes code ;-)13:08
faganwow big storm in ireland13:10
faganthunder and lightning going on13:10
faganlots of rain13:11
gatoxnessita, let me know when you have the chance to see the uninstaller branch :P13:11
nessitagatox: before the mumble ideally :-)13:11
gatoxnessita, ok13:12
rmcbrideOK so yea, testing uninstaller on windows, observing whhether or not it's marking as reboot required13:15
rmcbrideralsina: regarding the "does it flag for reboot" question above that mandel referred to me, it does indeed prompt for reboot on windows when uninstalling13:17
ralsinarmcbride: cool, less things to do13:17
nessitaalecu: can we mumble in 5 minutes?13:22
alecunessita, sure13:22
nessitaalecu: I'm getting an abrigo first, I'm freezing13:27
nessitaalecu: I'm there13:30
gatoxlisette, ping13:32
ralsinanessita: I fixed the lint problem in https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix-setup/+merge/7270713:33
=== m_conley is now known as m_conley_away
lisette1gatox: in a meeting for an hour or so, can i ping you afterwards?13:46
gatoxlisette1, yes, no problem!13:47
nessitaalecu: the proposed fix works GREAT! I'm so happy! I've spent hours debugging this13:51
alecunessita, congrats!!!! }13:51
nessitaralsina: looks good. I thought mandel reviewed it too?13:53
nessita(I don't see his vote nor review claim)13:53
nessitagatox: going back to yours now13:54
gatoxnessita, awesome13:54
ralsinanessita: he asked a few things but commented nothing13:55
nessitagatox: was a design decision to have this Agree && continue with a lowercase continue?13:55
nessitaI would expect: Agree && Continue13:55
ralsinanessita: the text came from design, yes13:56
gatoxnessita, yes13:56
ralsinanessita: "Agree && Continue" is capitalization for titles, this is not a title13:56
* ralsina is guessing quite a bit there13:56
gatoxnessita, it's specified in the bug... do you want the link?13:56
nessitagatox: no need, thanks!13:57
nessitagatox: so, the BaseTestCase you're inheriting in test_gui already provides a method called "_set_called"14:00
nessitagatox: that you can use to patch stuff like the uninstall thingy14:01
nessitagatox: and then you can assert over a self._called attribute that the same basetestcase provides14:01
nessitagatox: so there is no need to create yet another fake class. We usually create fakes when we need to track something more than just a call14:01
nessitagatox: so this call14:03
nessita        self.patch(utils, "uninstall_application",14:03
nessita            fake_uninstaller.call_uninstaller)14:03
nessitawould be14:03
nessita        self.patch(utils, "uninstall_application", self._set_called)14:03
nessitaand then you can assert over the self._called attr14:03
gatoxnessita, yes..... i'll change that now14:04
nessitagatox: thanks!14:04
nessitagatox, ralsina, Chipaca: mumble?14:05
ralsinanessita: ack14:05
ralsinachipaca: windows mumble ping?14:08
Chipacaralsina: voy14:09
=== m_conley_away is now known as m_conley
karniI connected via phone's 3G. Man it's striking thunders here!14:36
=== karni_ is now known as karni
mandelnessita, ralsina, gatox, Chipaca, alecu super shitty script that will listen to changes to the given path, just pass the path through the command line14:51
mandelyou will not be able to rename or delete the watch dir14:51
ralsinanessita: if you are talking we can't hear you :-)14:52
mandelChipaca, the only issue I see with that watcher code is how to hook that to twited, atm we use deferToThread14:54
Chipacamandel: you or roberto can ask the guy at his interview14:55
mandelChipaca, we could take a look of how to fix that.. but it uses IOCP and that is complicated code...14:56
mandelChipaca, which interview?14:56
Chipacamandel: to see if we hire him14:56
* nessita is back!14:59
mandelChipaca, ah.. ok I'll ping ralsina about this :P14:59
ralsinamandel: I am currently setting things up in the HR system. Once that is done, we'll contact the fellow ASAP15:00
mandelralsina, ah.. ok :)15:00
mandelralsina, by the way, I cannot get the UDFs to work on IRL, can you try that?15:01
mandelralsina, I'm also not getting the wathers in the parent dir, but ofcourse that is due to the UDFs not being created...15:02
ralsinamandel: not for a while, sorry. But apparently Chipaca couldn't either, so it's broken. What you could try is setting up the account on Linux and then just syncing a UDF?15:02
nessitamandel: you can create a UDF in the web15:02
nessitaor no?15:02
* nessita checks15:02
Chipacaralsina: what udf did you try?15:03
nessitaah no15:03
nessitamandel: forget the last thing I said :-)15:03
ralsinaChipaca: I had one for my mobile pictures15:03
* mandel forgets..15:03
ChipacaI tried "My Documents", but I'm not sure if that's a real folder or not any more15:04
nessitaalecu: this one looks approved! https://code.launchpad.net/~alecu/ubuntuone-client/fix-vbox-weird-clock/+merge/7196515:04
nessitamandel: can you please review? is trivial, but it helped me debug the signals issue https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/better-logging/+merge/7272815:04
mandelnessita, sure!15:06
mandelnessita, you have my plus 115:12
nessitagatox: out of curioisty, any reason to have this cut off in two lines?15:14
nessita        self.patch(utils, "uninstall_application",15:14
nessita            self._set_called)15:14
gatoxnessita, sorry... that was from the previous implementation, when that line was too long...15:15
* gatox fixing.....15:15
nessitagatox: another question, why are you adding the skip decorator to a window specific test?15:15
nessita@skipIfOS('linux2', 'Windows-specific tests.')15:15
nessitagatox: test_windows.py should be ignored in linux (we may need to tweak the test runner)15:15
nessitagatox: look at the ussoc test runner, let me grab the line number15:15
nessitagatox: see run-tests in ussoc trunk, we should have something very similar in installer15:16
gatoxnessita, ok....... i will change that15:17
nessitaalecu, mandel: big one, but final result should make us happier https://code.launchpad.net/~nataliabidart/ubuntuone-client/login-email-password-for-everyone/+merge/72735 :-)15:18
nessitait fixes bugs and improves uglyness15:18
dobeyok, lunch time. bbiab15:25
gatoxnessita, done15:25
nessitagatox: relooking!15:33
mandelnessita, bye bye mocker I suppose :P15:38
nessitamandel: YEAH (at least for that module)15:39
nessitagatox: are tests passing for you in linux for installer?15:41
nessitaI've got FAILED (failures=3, successes=117)15:41
gatoxnessita, let me check again15:42
nessitanot related to your code though15:42
ralsinanessita: when you have a moment, I re-added ubuntuone_log_dir here https://code.launchpad.net/~ralsina/ubuntuone-client/log-betterer/+merge/7259715:52
nessitaralsina: sure!15:53
ralsinaAnd I go have a lunch break15:53
nessitaralsina: question15:53
nessitaralsina: why you removed and re-added tests/platform/test_xdg_base_directory.py? can't we just remove from inside the file what's no longer needed?15:54
nessitawe lost bzr history in the file that way15:54
ralsinanessita: I had removed it first,15:54
ralsinaI can do a revert and re-edit, is that the right way?15:54
nessitaralsina: yes sir, you may have an issue with the new file you added, so maybe you need to either remove that (not sure if that will work) or start a new branch as a last resource15:55
ralsinaok, I'll untangle that don't worry15:55
ralsinagrmbl, looks like a new branch is the easiest way16:02
=== beuno is now known as beuno-lunch
ralsinanessita: pushed a new branch, it's the same as the old one but without breaing history: https://code.launchpad.net/~ralsina/ubuntuone-client/log-betterer/+merge/7274716:30
nessitaralsina: great!16:30
alecunessita, ralsina: we've been discussing a bit on the download nanny with facundo, and we have been doing some tests with mandel, and here are some conclusions we have arrived to: http://piratepad.net/aBJrwCsZOO16:50
nessitagatox: this swicth is not valid for pep816:51
nessita -i "test_linux.py" .16:51
nessitaalecu: read. The nanny is the only one depending on the file_close_{no}write?16:52
alecunessita, apparently yes. I've not digged further, but it makes sense for it to be the one needing the close_nowrite16:53
alecunessita, the close_write is useful for sync though16:53
alecunessita, but that can be in fact simulated with the "updated" event we receive on windows plus a small timeout to see that no more "update" are received immediately.16:55
alecunessita, so that's the high level overview, to be able to assess the risk of not having this working properly.16:56
alecunessita, I think it's a lower risk than we thought, but it's a risk nonetheless16:56
alecuI will dig further into this points, but I wanted to request some comments or ideas on this.16:57
nessitakinda agree, though I would like seen this fixed before the release to the public/press16:57
nessitaalecu: what app do we plan to target to test?16:59
nessitaralsina: I filed bug #833190, found those tests failures while reviewing a branch from gatox16:59
ubot4Launchpad bug 833190 in ubuntuone-windows-installer "Failing tests (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/83319016:59
nessitagatox: did you see the issue with the -i and pep8?17:00
nessitaralsina: you removed the old proposal for log-betterer?17:01
alecunessita, *the* app would be "office"17:01
nessitaalecu: can we also test notepad, and some image editor (ideally the default one)?17:02
gatoxnessita, i'm running it now with the -i included in run-tests or do you mean something else?17:02
nessitagatox: you added a -i to pep8, which is not supported17:02
nessitagatox: pep8 should also check the test_linux17:02
gatoxnessita, yes... i'm fixing that... i added in the wrong place for run-tests.bat17:03
alecunessita, can you please re-review or change the vote on https://code.launchpad.net/~alecu/ubuntuone-client/fix-vbox-weird-clock/+merge/7196517:11
nessitaalecu: does tarmac complains for a needs information? :-/17:11
dobeynessita: yes17:13
nessitadobey: why?17:13
dobeynessita: because it signifies that you need more information to be able to complete the review17:13
nessitaI got my information :-)17:13
dobeynessita: if said information has been provided, you need to change your vote17:13
nessitaanyways, let's vote17:13
nessitaralsina: ping17:13
dobeyeither approve or obstain or needs fixing or something :)17:13
dobeyabstain even17:14
nessitaalecu: did you notice my review request? no to much hurries, but just wanted to be sure is in your radar17:17
alecunessita, will get some lunch and do your review afterwards.17:18
nessitaalecu: great! thanks17:18
=== beuno-lunch is now known as beuno
dobeycan i have a review please? https://code.launchpad.net/~dobey/ubuntuone-installer/new-style/+merge/7276417:36
gatoxnessita, is there any problem with the tests in sso?? i have 33 tests failing and i want to know if it is just me17:41
nessitagatox: remember to STOP the real sso service :-)17:41
gatoxnessita, i'm going to check if it is running in background17:42
gatoxnessita, yep... sso was in background17:43
gatoxnessita, so now i have a very little branch to propose while i'm finishing the other17:44
nessitaralsina: ping?17:45
nessitadobey: I'm leaving in a while, may I ask you a favor?17:45
* beuno whispers "it's a trap"17:46
dobeyit's always a trap17:47
nessitadobey: I don't want to forget to mention to ralsina that we should not delete merge proposal with votes in it, but reject them. This happened with https://code.launchpad.net/~ralsina/ubuntuone-client/log-betterer/+merge/7259717:48
nessitagatox: APPROVE!@:-)17:48
dobeyoh i can yell at ralsina. that's easy :)17:48
gatoxnessita, nice17:48
nessitadobey: no yell needed, I think. As far as I know if the first time we let him know that :-)17:49
dobeyoh that reminds me17:52
gatoxnessita, ralsina a quick review? https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/ui-form/+merge/7276817:56
nessitagatox: sure117:57
dobeythisfred: can you review https://code.launchpad.net/~dobey/ubuntuone-installer/new-style/+merge/72764 ? should be quick and easy :)17:58
nessitagatox: indentation for +    def __init__(self, line_edit, valid_cb=lambda x: False, is not pep-8'd17:58
nessitagatox: see http://www.python.org/dev/peps/pep-0008/, Code lay-out section17:58
dobeyor anyone else ^17:59
nessitasee the Yes and No17:59
nessitadobey: I'll review17:59
dobeynessita: thanks17:59
ralsinagatox: sure!17:59
nessitadobey: why do we have attr starting with dunder?18:00
ralsinaok, won't delete MPs with votes. Why?18:00
dobeynessita: because they're private18:00
nessitadobey: in that case they should have one underscore18:00
ralsina__ is private, mangled18:00
nessitahum, let me confirm18:01
dobey_ is "you really shouldn't touch this, but you can"18:01
thisfreddobey: on it18:02
dobeyalso, it took me a minute to realize what you meant by "dunder"18:02
nessitadobey: you're right18:02
thisfredI don't like underunders either, but if it's a pattern within gtk, I won't object18:03
nessitadobey: I've heard it a lot in python talks, I think I got that from Raymond Hettinger18:03
gatoxnessita, that rule applies too for??:18:04
gatox+            self.clear_label.setPixmap(QApplication.style().standardIcon(18:04
gatox22+                QStyle.SP_MessageBoxWarning).pixmap(16, 16))18:04
nessitaand I loved it18:04
thisfreddobey: __ you can still touch, if you really want to. I usually use _ to signal intent and then if someone poops on the welcome mat, so to speak, they deserve what they get, which is breakage18:04
ralsinanessita: got the needsfixing, I have no idea how that test passes here. I'll fix it right away.18:04
nessitagatox: please use variables in that sentence!!!18:04
nessitaralsina: you run tests in linux?18:04
ralsinanessita: I have no working linux at the moment :-(18:04
dobeythisfred: yes, but you have to mangle your code to do it18:04
nessitaralsina: got the no-delete-proposal-with-votes-please?18:05
ralsinanessita: got it18:05
dobeythisfred: i'd rather it give them the AttributeError18:05
dobeythan say "here you go!"18:05
nessitadobey: so, where are all the tests for that code? :-)18:05
thisfreddobey: I seem to remember __ come with their own set of problems, which is why their use is not encouraged.18:06
dobeynessita: in gtk+?18:06
nessitadobey: no, the tests for your code, the one you're writting18:06
ralsinaOk, I now see why it didn't fail. If I pass two test modules to u1trial, it runs only the first one :-(18:06
nessitadobey: we should be testing all those lines of code18:06
dobeyralsina: hi18:07
dobeyralsina: stop deleting merge proposals! :)18:08
ralsinadobey: got it, got it!18:08
ralsinanessita: pushed with the fix for that and test instructions that actually run the tests18:08
dobeyralsina: also, file a bug against devtools to allow passing multiple modules to u1trial18:09
ralsinadobey: filing!18:09
nessitaralsina: instructions are run 'run-tests.bat' in windows :-)18:09
nessitaand make check in linux18:09
ralsinanessita: no, because it's u1-client and that has lots of failures?18:09
dobeyfor u1client?18:09
ralsinaon linux, maybe, but this code has to be tested on both sides18:10
nessitaralsina: but they are known and we should check no new ones are added18:10
ralsinanessita: known by whom exactly ?18:10
nessitaralsina: how can we ensure we're not breaking anything new then?18:10
nessitaralsina: by anyone that run the suite in trunk\18:10
ralsinanessita: well, that's why we have been fixing tests for the last 6 weeks, I would say :-)18:10
dobeynessita: anyway i have no idea how any unit tests on ubuntuone-installer code would be useful, and actually be unit tests, right now18:10
nessitadobey: just like we're building unit tests for the gtk control panel18:11
nessitadobey: I can help you tomorrow18:11
dobeynessita: this needs to land asap18:11
ralsinanessita: are you sure I see the same test failures you see?18:11
ralsinanessita: known would mean documented to me, in this case.18:11
dobeynessita: UI freeze is in < 6 hrs18:11
nessitaralsina: 95% sure they should be the same. We're not having timing errors, but real failures18:12
ralsinanessita: ok, I will try to document them myself then18:12
nessitaralsina: anyways, if you run the whole suite in trunk and in your branch, you can ensure you're not breaking anything new18:12
nessitaI can share a test run if you'd like18:12
ralsinanessita: don't worry, I will do it18:13
nessitadobey: I will abstain and email the bosses, I disagree with having this code in the CD without backing up tests18:13
nessitadobey: but I will not delay this today18:14
dobeyit's not on the CD yet (or even in main)18:14
nessitawell, we're hoping it to be, no?18:14
dobeyyes, but probably won't be today18:14
dobeyi take that back18:15
dobeyit is in main now :)18:15
gatoxralsina, nessita please review this branch: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/line-edit/+merge/7277218:15
dobeyas of 50 minutes ago anyway :P18:15
nessitagatox: did you fixed the one you linked before that?18:16
gatoxnessita, i had some problems and launchpad get blocked for that branch, so i delete it and resubmit in another one18:16
nessitadobey: is there any test written in that project?18:16
ralsinagatox: shouldn't you hide the label if it's not meant to be seen? Otherwise it will still be there (but maybe with size 0)18:16
nessitagatox: don't delete! :-) resubmit18:16
dobeynessita: yes18:16
gatoxnessita, yes, but it was stuck.... some locking problem (and not in my local branch.... i've tried bzr break-lock)18:17
nessitagatox: and what happened?18:18
gatoxnessita, i delete it and create another branch18:18
gatoxit's this one18:18
nessitagatox: what happened with the bzr break-lock I mean :-)18:18
dobeynessita: i had to change _find_data_file() in that branch, in order to keep them from failing, even :)18:18
gatoxnessita, ahhh...... nothing... i could push code anyway18:19
ralsinagatox: ^^18:19
nessitagatox: ok, next time feel free to ask for help to unblock that18:19
gatoxnessita, ok18:19
gatoxralsina, sorry... i can't find the label..... which line?18:20
gatoxralsina, do you mean setVisible(False)?18:20
ralsinagatox: around line 2018:20
ralsinagatox: yes18:20
ralsinaoh, wait. You are setting it to false. When is it set to true?18:21
nessitadobey: since we have 6 hours to freeze, can't you add tests in the mean time?18:21
ralsinagatox: let's start again ;-)18:21
nessitagatox: what's the new MP link (after the removed one)?18:22
gatoxnessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/line-edit/+merge/7277218:22
ralsinagatox: I meant: if warning_sign is False, it should never be set to visible at all. And I don't see that in the MP diff18:22
dobeynessita: i'd rather not have to work those full 6 hours, no. i do also have personal life things i need to accomplish today after i finish working18:22
nessitadobey: but you have  still 2.5 hours left, if I do the math properly18:23
gatoxralsina, well..... it is set to true when the validation functino says so... but as it is always empty...... i doesn't show anything and keeps being invisible18:23
ralsinagatox: you are counting on the label being width=018:23
gatoxralsina, or we can validate if the label doesn't contain a pixmap18:23
ralsinagatox: that can stop being true by (for example) changing the stylesheet18:23
gatoxralsina, no18:23
gatoxralsina, the label is over the line edit18:24
ralsinagatox: yes. And it may cover the text in the lineeedit if it's set to visible and has any width18:24
dobeynessita: yes, and i also need to put icons in, make the release, update the packaging, get someone to sponsor the upload, etc18:24
dobeynessita: and i'm not trying to avoid tests. i really don't see how any tests could possibly be useful here18:25
dobey(beyond the tests that are already in place)18:26
nessitadobey: every line of code we add is error-prone18:27
nessitaand is very easy to break when adding new code, causing regressions18:27
nessitaanyways, I gotta run to the uni18:28
dobeyas are the tests. anywya18:28
nessitaok, I'm gone18:30
nessitagatox: I'll try to finish your reviews today, otherwise I'll do them tomorrow morning18:30
nessitabye all!18:30
dobeythere is like 0 interactive UI in this app18:30
ralsinadobey: what's the branch in question?18:31
dobeythe next and cancel buttons are pretty much it (and the learn more thing, which opens a browser)18:31
dobeyralsina: https://code.launchpad.net/~dobey/ubuntuone-installer/new-style/+merge/7276418:31
* ralsina looks18:31
dobeyit's all advertising18:31
dobeytext and images, and layout; the cancel/install buttons already get tested, ensuring that the page gets switched to the progress bar page18:32
ralsinadobey: considering the time constraints and that you have been all alone doing this stuff, +1 on your own recongnizance (sp?)18:32
dobeyi don't know what you mean by recognizance :)18:33
dobeythough i do recognize you didn't mean to put an n before the g in it18:34
* ralsina heard that on Law & Order18:34
dobeya bond or obligation of record entered into before a court of record or a magistrate, binding a person to do a particular act.18:34
dobeyi don't think i've had to deal with any bail bondsmen on this branch :)18:35
ralsinaSo, I trust your word that this doesn't break stuff, and if it does, it's your faul ;-)18:35
dobeywell we all know my code is perfect anyway :)18:35
gatoxralsina, ready!! branch updated... i'll submit my other branch later... have to go!18:39
dobeyah, manuel18:41
dobeyralsina: is manuel coming to UDS too?18:42
ralsinadobey: AFAIK no18:42
ralsinadobey: UI freeze means you can still make uploads until the next freeze, right?18:43
ralsinadobey: just no new strings/UI?18:43
dobeyralsina: it means you can't change UI without an exception18:43
dobeyralsina: strings can change. but ui can't18:43
nhainesWell, except it's also beta freeze in 6 hours.18:43
dobeystring freeze is in a couple weeks18:44
dobeynhaines: 5.2518:44
dobeyralsina: is there other stuff we really need to get in ubuntu today?18:45
nhainesdobey: I'm in California, I can't handle UTC math during Daylight Saving time.  :)18:45
ralsinadobey: not that I know of18:45
dobeynhaines: just use UTC for everything. be a force of change :)18:45
dobey"There is only Zulu."18:45
ralsinadobey: answered email about those tests, check response on your own time18:48
nhainesdobey: :)18:53
ralsinaAnd I am gone to pick up my kid from school. Will put more hours later for today's release.19:03
dobeyralsina: haha. "linux team" :)19:21
ralsinadobey: I knew you would appreciate it ;-)19:37
dobeyralsina: https://code.launchpad.net/~dobey/ubuntuone-installer/add-icons/+merge/72780 <- added some icons. review please? :)19:38
ralsinaSo much for the idea that all tests that fail on u1-client fail all the time19:42
ralsinadobey: +1 trivial, just looked at it, so pinky-swear that it works19:45
karniduanedesign: yo my man, still around? (you are crazy if you are! ;)19:52
dobeykarni: why is that crazy? he's like -0200 from me :)19:53
karnidobey: because he starts at 6-7 AM to get more time with european co-workers19:54
duanedesignkarni: :)19:54
karnistill it's like -7h from here probably :D19:54
dobeyrye is probably still around :P19:54
karnidobey: he's always around19:54
dobeyexactly :)19:55
karniduanedesign: sticky please! :) http://ubuntuforums.org/showthread.php?p=11183473#post1118347319:56
karninhaines: http://ubuntuforums.org/showthread.php?t=183228820:12
ralsinadobey: it's just me or comparing full test suite runs is pretty hard? http://diffchecker.com/Jo7wN6820:13
duanedesignkarni: done20:14
karniduanedesign: thanks! :)20:14
dobeyralsina: it is very hard :)20:14
ralsinagood to know I am not just tired20:15
dobeyralsina: adding or removing tests makes it significantly harder, because ordering, etc… can change20:16
ralsinaI love how the number of failures is the same but they are not the same tests20:16
nhaineskarni: great!  The QR code is useful of course.  :D20:40
karninhaines: =)20:41
nhaineskarni: okay, I'll play with it... didn't find any problems with the last one.  :)20:42
karninhaines: Coolio! Much thanks :) (IIRC you already had 1.0.3*, this is hopefully last rc before the Market)20:43
nhaineskarni: yes, and SSO worked great (except one thing) but I had no pretty progress meters.  :)20:44
karninhaines: What was the problem?20:45
nhainesOh, now that I think of it, that one thing is that my Android notification bar always shows the "syncing" icon... I think it might be Ubuntu One.20:45
karninhaines: Ah right! Not only you have progress bars, you can download stuff while uploading as well (and vice versa)20:45
karninhaines: yes, it has been fixed20:45
karninhaines: could you please uninstall U1F20:45
karninhaines: and make sure there is no Ubuntu One in Account Manager20:45
nhainesSure.  I did install the update already though.20:46
karninhaines: once installed, you will no longer see the sync icon. sorry about that.20:46
* karni thinks20:46
karnilet me see20:46
nhainesOkay, uninstalling now.20:46
nhainesUbuntu One is no longer listed in Account Manager.20:47
nhainesHaha, I like the "New Storage Detected" notice.  It's so cheerful.  :D20:48
karninhaines: yes, the sync is disabled during _creation_ of the account, so it's best to uninstal. and since 1.0.3 never made it to the market, only people who used any RC candidate are affected20:48
karninhaines: :)20:48
nhainesAh yes, now sync is off for the U1 account.20:49
karninhaines: you got me thinking. I should let other testes know.20:50
nhainesYeah, probably.  I'm kicking myself for not filing a bug though... it just slipped my mind.20:54
karninhaines: That's OK. It's probably just few people. Thanks for testing!20:54
nhaineskarni: well, I'm just glad you caught it as well.  :)  Maybe some time the sync feature will be useful.20:55
karninhaines: My manager caught it ;) And yes. It's one of the features I'm looking forward to the most. However, not only it has not been given high priority, it's not well supported via REST API either.20:56
karninhaines: If we had it, I think it would be a killer. No dropbox, no sugarsync, just u1f.20:56
* karni just gave examples20:56
nhainesThe app is definitely great!20:57
karniActually, dropbox is a bad example. They have no sync at all, but there are 3rd party apps that provide this feature (in a dumb way, anyway..)20:57
nhaineskarni: It's compelling!  "WD 2go" offers a personal cloud with a My Book Live drive (1 - 3TB) at your home, but you can't really save the files and work with them later.  (Disclaimer: I'm a WD employee)20:59
nhainesSo U1 has less storage but more utility for certain things.  :)20:59
karninhaines: You're WD employee! How awesome is that :)! I got my parents a WD 2TB (RAID 1, 2x1TB) MyStudio book (or something) as a safe storage solution.21:00
karninhaines: What do you mean you cant save files?21:01
nhaineskarni: yup, I'm a technical support auditor, haha.21:01
karninhaines: Hahah I know who to contact if my drive fails ;D21:02
nhainesWith WD 2go's mobile app, you can access any file on your drive but you have to have an app that will work with it first.21:02
nhainesSo for example if I tapped on a video file I'd saved nothing happened.  then when I installed RockViewer, it would download and stream... but I can't save the file permanently to my phone.21:02
karninhaines: Isn't it the same with U1F? U1F uses Android/3rd party apps to open files.21:03
nhaineskarni: sure, but at least the files stay there in the /sdcard/U1 folder21:03
karninhaines: Right, for off-line access.21:03
=== m_conley is now known as m_conley_away
nhaineskarni: or to not destroy your data quota.  :)21:04
karninhaines: I'm looking for a day/opportunity to take on sync. It won't be soon, but man I wish for it.21:09
nhaineskarni: it'll definitely be awesome.  :)21:09
facundobatistadobey, ping21:56
snap-lHmm, having some trouble with a machine and Ubuntu One22:07
snap-l2011-08-24 18:06:44,449 - ubuntuone.SyncDaemon.ActionQueue - WARNING - Connection lost: Connection was closed cleanly.22:07
snap-lThis is on a wirless network22:07
snap-land even on a wired network, it's not working22:11
facundobatistasnap-l, we're having some connectivity issues22:17
snap-lThat would explain it.22:19
facundobatistasnap-l, what about now? it should be solved23:13
snap-lfacundobatista: I believe it's fixed now. Thank you.23:42
=== yofel_ is now known as yofel

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!