[00:00] maybe you have an old yui lying around? [00:00] perhaps make clean will make it show up [00:00] well, i just set up the devel environment just now... [00:01] hmmm. [00:01] when i get a spare moment later i'll try and see what we're missing from the jsbuild target to cause the issue [00:02] ah [00:02] i need to load widget-position-align [00:02] makes sense [00:04] it has to be said, yui3 makes for very nicely greasemonkeyable pages [00:04] yeah, from what i've seen yui3 rocks compared to earlier incarnations [00:05] too bad yui isn't more popular. seems like jquery has all the mindshare? [00:06] yay i can use the lazr widget with my lp changes [00:10] mwhudson: when you say lazr, you mean from the lazr-js tree? for lp, we've stopped using lazr-js separately and pulled all the source in the lp tree and are mainatining it there [00:11] wallyworld: no, i mean, not my hack that's in my greasemonkey script [00:11] ah ok [00:12] wallyworld: ok, i'd like to merge this branch i guess [00:12] wallyworld: if i propose it will you review it? [00:12] i'll run the yui tests if you tell me how :) [00:12] sure. but i'm only a provisional reviewer. i'm being mentored atm [00:13] mwhudson: bin/test --layer=YUITest [00:14] mwhudson: curtis has done an awesome job packaging the yui tests to be able to be run from the command line without requiring a browser [00:15] you can also run individual tests by loading the html page corresponding to the test js file in a browser [00:15] yay [00:15] Ran 44 tests with 0 failures and 0 errors in 1 minutes 8.693 seconds. [00:15] whoot [00:17] hm, seems i don't need the editicon change any more [00:17] think it's still dead code though [00:18] * mwhudson repurposes wallyworld's existing mp [00:20] mwhudson: i did that mp to quickly see the diff :-) i was just about to mention that the change now seems redundant. [00:34] (potentially silly question alert) when running 'testr run', 'make run' should be killed right? [00:35] G: Shouldn't need to be. But it's possible some dodgy tests might require it. [00:36] wgrant: okay thanks [01:19] Project devel build #1,019: STILL FAILING in 3 hr 59 min: https://lpci.wedontsleep.org/job/devel/1019/ [03:17] hi hackers [03:17] how is the long-poll stuff going? [03:18] I've been eagerly awaiting the auto-diff updating [03:18] but it isn't happening :( [03:24] Waiting for red squad to finish derivation, and then they switch to long-poll [03:29] StevenK: isn't the correct repsonse "patches accepted"? [03:30] Damn it. I go on holidays for a week and I forget everything. [03:30] * StevenK books in "re-training" for Monday [03:38] thumper: how's dx? [03:38] digitally extreme :P [03:38] lifeless: you had a kid yet? [03:38] wallyworld: interesting [03:38] yes :) [03:38] * wgrant gives lifeless a few looks of disapproval. [03:38] lifeless: really? [03:38] lifeless: congrats. details please [03:38] It was on G+ and FB hours ago! [03:38] did I miss the announcement? [03:38] Social media, people :P [03:38] g+ 2 minutes ago [03:39] FB hours ago. [03:39] wgrant: i hate social media [03:39] EBUSY. [03:39] lifeless: congrats [03:39] lifeless: so why ffs are you on irc? [03:39] wallyworld: easier than ringing the 100 off folk that Want To Know [03:39] s/off/odd/ [03:40] understood [03:40] Heh [03:40] lifeless: so, for those of us who hate fb, g+ - boy, girl? [03:41] thumper: got my new coffee machine :-D Breville BES900 [03:41] wallyworld: awesome [03:41] wallyworld: so now you never leave home? [03:41] thumper: nope :-) [03:42] thumper: so feature freeze on oneric. everything looking good? [03:42] is the minimise behaviour or global menu stuff fixed? [03:42] please say it is [03:42] wallyworld: Heh, good is not how Ubuntu release cycles ever look until the last two weeks. [03:43] wgrant: understood. i was being optimistic :-) [03:43] wallyworld: no [03:43] thumper: you suck [03:43] :-P [03:43] wallyworld: no, you suck [03:44] sometimes [03:45] wallyworld: answered privately :) [03:45] lifeless: ah, so it is. thanks [03:46] lifeless: love the slogan :-) [04:04] indeed ;) [04:21] $ testr run - 3hrs 20min and counting, is this normal? [04:21] Yes [04:21] Sadly [04:21] on the plus side, I did find a failing test in my changes :) [04:22] A full testsuite run will take approximately 4 hours and change [04:23] * spm quaintly recalls complaining about the 90minute test runs [04:25] (Don't take it for complaining, was just shocked/surprised) [04:25] StevenK, wgrant: I tried an experimental domination run (source only and without judging phase) on dogfood's Debian yesterday. I don't think it did anything because it ran suspiciously fast… I'll have to check. [04:25] G: I complain about it all the time. [04:26] the only real problem I see is the inability to have 'make run' and 'testr run' going at the same time [04:26] That's why we use ec2 for test runs. [04:26] But that can get expensive. [04:26] G: What happens when you try? It should mostly work. [04:27] wgrant: address already in use [04:27] I'm guessing because testr has zope running on the same port that make run starts zope on [04:27] That's meant to not happen any more :( [04:28] wgrant: seems to be happening on my VM that I set up [04:29] Which layer? [04:29] AppServerLayer just started up fine for me. [04:29] and I have a dev appserver running. [04:29] http://pastebin.ubuntu.com/679377/ [04:29] runlaunchpad.start_launchpad() [04:45] StevenK: by the way, thanks for the help last night [04:45] G: I didn't think I helped much, but you're welcome. :-) [04:46] I ended up by solving it by turning the second template into a Macro in the end, but you got me thinking in the right direction === almaisan-away is now known as al-maisan [05:01] Good Morning! [05:04] nigelb: good $localtime [05:04] heh [05:05] testr run just finished [05:05] lots of bzr tests failed hmmm [05:07] G: Which Ubuntu release are you using? [05:07] natty [05:08] I'm guessing that is why [05:08] Possibly. The test suite is only regularly run on Lucid, but it used to work on Maverick and mostly works on Natty. [05:08] And partly on Oneiric. [05:08] Ursinha: Happy Birthday! [05:11] StevenK: I DID IT. [05:11] One branch with TDD :) [05:12] (except now my test doesn't pass) [05:12] nigelb: tut tut tut ;) [05:12] heh [05:19] Project devel build #1,020: STILL FAILING in 3 hr 59 min: https://lpci.wedontsleep.org/job/devel/1020/ [06:03] what time zone is danilos? [06:04] nigelb: LP says UTC+02 [06:05] ah, right. [06:11] How do I compare strings in regular expression [06:11] I'm surpised that I have to ask this at all. [06:16] Someone has thoughts on this? http://pastebin.ubuntu.com/679424/ [06:17] nigelb: It doesn't really look like you want a regular expression match. [06:17] wgrant: I don't,no. [06:17] what do I use instead? [06:18] Does assertIn not do what you wish? [06:18] Oh. === al-maisan is now known as almaisan-away [06:20] Hrm, not sure how I would do that. [06:23] oh no.... [06:23] my make lint was clean, until I modified the pagetests [06:24] That's your first mistake right there. [06:24] heh [06:24] now it includes various 'source has bad indentation' / 'source exceeds 78 characters' [06:24] G: lint checks modified files [06:24] nigelb: yep, get that, just disappointed [06:24] heh [06:25] G: If it's not too huge, you should probably clean the doctest up, so it's not left for the next person to find the same way. [06:25] But if it's a few hundred warnings like they sometimes are, meh. [06:25] should I try and fix it as part of the branch or propose a second merge to fix [06:25] looks /ike 68 errors [06:25] * G takes a look [06:25] Most of them probably just need you to s/^ / / or so. [06:30] who's reviewer today? Technically lifeless I believe? [06:30] * nigelb checks [06:30] Don't give him any ideas. [06:30] I can have a look if nobody else is around. [06:31] aha [06:31] well, not ready yet. [06:31] wgrant: looks like the lint errors are a bit 'yeah right' to me [06:31] G: Oh? [06:32] OMG. [06:32] for instance, I can't see any bad indentation on ./lib/canonical/launchpad/pagetests/basics/notfound-traversals.txt [06:32] (line 7 that is) [06:32] I totally didn't recognize this launchpad feature till now. [06:32] G: The code blocks are meant to be indented by 4 spaces. [06:32] To distinguish them from narrative. [06:32] I was about to say that. [06:32] >>> if foo: [06:33] ... bar [06:33] wgrant: oh.... [06:33] nigelb: Which feature? [06:33] So, if I have a bug number in my branch name [06:33] like foo-1234 [06:33] nigelb: That feature is about a month old. [06:33] HA. [06:33] Its awesome. [06:33] in that case I'd have to re-indent etc the whole file [06:33] G: Yes. It's rather unpleasant. I just ignore it in that case. [06:34] I might do a mass fixup over Christmas or something, when it's less likely to conflict with people. [06:35] .. [06:36] nigelb: oh does it automatically associate the branch w/ the bug? [06:36] I just do 'bzr commit --fixes lp:' [06:37] G: It doesn't. When I click the link to associate the bug, it already has the bug number from the branch [06:37] So it suggests it. [06:37] (well, I often forget to do that :D) [06:37] But doesn't do it automatically. [06:37] oh yeah, I noticed that today too [06:37] which is nice! [06:37] But yah, I agree with wgrant, it needs to be a picker. [06:38] wgrant: how would I use assertThat in this scenario [06:38] https://code.launchpad.net/~nigelbabu/launchpad/specification-validation-59301/+merge/73631 [06:38] L77 [06:40] nigelb: You should probably use assertRaises. [06:41] nigelb: It's normally just used to check the class of the exception, but it also returns the exception object. [06:41] So you can then assertEquals on its content afterwards. [06:41] ha, just got my first buildbot e-mail :) a couple of hours ago [06:42] Wait, why aren't you on Contributors page yet. [06:43] G: FYI - https://dev.launchpad.net/Contributions [06:43] Possibly the wiki upgrade... let me see. [06:43] we're all competing with wgrant. [06:43] I am invincible, nyahaha. [06:44] I can wait :) [06:45] I'm landing 3 branches a week or at least trying to. [06:45] That means about a year until I beat wgrant :D [06:45] hopefully I'll have 2 this week at least [06:47] hrm, I don't understand how to use assertRaises. [06:47] * nigelb greps more [06:47] pondering snatching up bug 410331 tbh [06:47] <_mup_> Bug #410331: PPA: should default to sensible/good name (or give example)

< https://launchpad.net/bugs/410331 > [06:52] nigelb: are you having trouble w/ 59301 ? === _mup__ is now known as _mup_ [06:59] G: I fixed the bug. [06:59] I'm fixing the test. [06:59] I always seem to have some or the other trouble with tests :D [07:00] nigelb: whats the command to run the broken test? [07:00] * G wants to have a look too [07:00] well, you just run the test and you'll see its not passing. [07:01] wgrant: I don't see a good enough example of assertRaises to understand how it works [07:03] nigelb: e = self.assertRaises(SomeException, some_function, some, arguments) [07:03] It will call some_function(some, arguments) [07:03] And assert that it raises a SomeException. [07:04] mmm [07:05] Hello [07:05] Morning mrevell! [07:05] Hey nigelb :) [07:05] nigelb: Contributions page unbroken. [07:05] wgrant: And I can use the 'e' to get the error message for an assertEqual? [07:05] wgrant: Ha, thanks! [07:05] nigelb: Yeah. Use str(e), perhaps. [07:06] Excellent, thanks. [07:08] Woah. [07:08] Heh [07:08] THIS NEEDS CELEBRATION. [07:09] At least we need to give him a certificate - "I purposefully quit IRC for X days" [07:09] spm: ^ [07:23] wgrant: well, I found out why domination on dogfood's debian was so fast. All those active SPPHs for Debian are PENDING, not PUBLISHED. Shouldn't gina set them to PUBLISHED? [07:25] nigelb: haha [07:25] nigelb: tbh, I call lies. [07:25] hehe [07:26] Morning! [07:26] Morning rvba! [07:27] G'day nigelb. [07:27] wgrant: Could you review https://code.launchpad.net/~nigelbabu/launchpad/specification-validation-59301/+merge/73631 [07:27] I'm sure you'll find at least 3 things to be picky about ^-^ [07:29] jtv: Probably, yes. Not sure why it doesn't. [07:30] jtv: Probably a holdover from when it imported Ubuntu. [07:30] It did? Owww [07:30] jtv: They needed to be Pending so the publisher would publish them. [07:30] That's how Ubuntu ended up in LP, yeah :) [07:30] Unless you're playing with it ATM, could one of you guys update DF? [07:30] Feb 2006. [07:31] jtv: I lost your review stamp when I resubitted a MP (added a new pipe so needed to change the dependency branch). Can you click some buttons, and optionally review the nonblocking_readline()? https://code.launchpad.net/~stub/launchpad/branch-rewrite/+merge/73563 [07:31] rvba: I already Q/A'ed your ISD fix. [07:32] jtv: nm. just hit refresh :) [07:32] jtv: I need it for another QA ;) [07:32] nigelb: Could you convince someone else to review? I'm trying to disappear now. [07:32] jtv: but thanks for Q/Aing my fix for ISD. [07:32] wgrant: Ok [07:32] stub: but I already approved that twice! [07:33] jtv: Can I grab your attention for a quick review? :) [07:33] yup. Needed to reload the page. [07:33] stub: ah, you found it. Sorry, fell a little bit behind with 4 simultaneous conversations. :) [07:33] nigelb: welcome, conversation #5! :-) [07:33] heh [07:33] Let me just catch up with the other 4. [07:33] I'll grab lunch meanwhile. Here's the MP - https://code.launchpad.net/~nigelbabu/launchpad/specification-validation-59301/+merge/73631 [07:34] rvba: I tested your ISD fix because I thought we might be able to roll out some critical fixes. But unfortunately it looks like abentley is the remaining blocker. [07:34] rvba: how fresh does dogfood need to be? Because I updated a few hours back. I can easily do it again if you need it though. [07:35] jtv: I tested it and I'm sure my changes are not on DF now. [07:35] wgrant: sorry, got a bit distracted with various other conversations (including phone call from a friend who it turns out is turning back from the brink of death :-) [07:35] It says my revisions where included in db-devel 2 hours ago. [07:35] rvba: ok I'll do that again [07:35] jtv: thank you. [07:36] rvba: it'll take a bit longer than usual (though not as long as when that db patch wouldn't apply!) because I'm currently testing a script. Hence the question. But right after that I'll update & notify. [07:37] wgrant: I'm currently running domination on debian, with the PENDING statuses updated to PUBLISHED. Obviously it's going to be fairly intense. [07:37] jtv: There is no rush for me to QA that /right now/ please take your time. Please just ping me when it's updated. [07:37] rvba: btw is it appserver? script? both? [07:37] jtv: it's an api change so appserver. [07:38] OK [07:38] rvba: Can't you do that on qastaging? [07:38] jtv: Probably. [07:39] wgrant: Oh ... I'm so used to qa things on DF that I did not even think about that ... ;) [07:39] \o/ [07:39] jtv: How does gina currently handle the multiple versions case? I forget if it imports both or just the latest. [07:39] jtv: If it imports all present versions, it's going to be amusing. [07:39] wgrant: urrr… I think it just imports everything it finds. [07:39] jtv: Because each run will create all the old versions, then supersede them all. [07:39] I was shocked the other day to find out I may accidentally have made myself the go-to gina coder. [07:40] nigelb: If you're able to wait for 1 hour an official reviewer will be on duty. [07:40] Then the next run will create them all and supersede them again. [07:40] wgrant: no I do think it skips everything that's already in the db; but if it finds multiple _previously unknown_ versions it imports them all. [07:40] jtv: I know bits of it from 2 years ago, but try to suppress those memories. It's not very relevant to normal LP development, so it gets paged out quickly. [07:40] rvba: Ha, just when I get back from lunch. Excellent. [07:40] jtv: Ew, that would be even worse. [07:41] wgrant: it's like a clever woman I know who, when switching from microbiology to IT and clearly short of relevant experience, still left APL off her CV. “Not getting the job scares me less than being made to work in APL.” [07:41] I told her to chance it. [07:42] Heh. [07:42] But the behaviour you suggest would be very inconsistent, confusing and wrong. [07:42] In what way? I have a feeling we may be talking at cross purposes. [07:42] (QA ok on qastaging \o/) [07:42] OK [07:43] jtv: The dominator and gina will fight, creating and superseding over and over again. [07:43] Why? [07:43] Ah, I see the misunderstanding. [07:43] wgrant: cancel [07:43] If gina imports all versions referenced in Sources, it will import stuff that the dominator has marked as superseded. [07:43] Heh. [07:44] wgrant: When I said “them all,” I was referring to the last bunch that I mentioned—when gina finds multiple previous unknown versions, AIUI it imports _all the unknown versions_. [07:44] jtv: What's "unknown"? [07:44] Because it skips everything that's already in the db. [07:45] I'm not clear on the definition of "in the DB." [07:45] I think the criterion was “not having an SPPH.” [07:45] An active SPPH? [07:45] No, I don't think so. [07:45] But guessing. [07:46] # Create the Publishing entry, with status PENDING so that we [07:46] # can republish this later into a Soyuz archive. [07:46] Heh. [07:46] As I suspected. [07:46] 5 years ago, maybe... [07:47] So… proper behaviour now is to make that PUBLISHED? [07:48] And maybe assert that the distro is debian for good measure, just so we find this spot back if we should ever change that? [07:48] I guess. [07:49] And we'll also need a transitional measure of course. [07:49] It looks like it will create new SPPHs for anything that doesn't already have a matching active SPPH. [07:49] Probably including multiple versions of the same source. [07:49] That would be bad. [07:49] But that needs testing. [07:49] It would be probably correct, but makes use of the dominator difficult. [07:49] Well, it would be bad for my current purpoes. [07:51] The only scenario that springs to mind where it helps to check only for active records is when an old version of a package is made the most recent again. But I'm not sure that should ever happen. [07:52] Well, to check also for inactive records violates everything. [07:53] "Everything" is a little broad… could you narrow it down a little? Let's take it as read that Albanian traffic law is not, as a practical matter, violated whatever gina does here. [07:54] If it's published in the source archive, to say it can't be published in the target archive just because it has been published at some point in the past is a fairly hideous position to take. It causes gina to lose generality, and prevents us from partitioning SPPH. [07:55] And causes gina to give incorrect results for Debian imports. [07:56] So you are saying that we must support Debian re-publishing older package versions. [07:57] I'm saying that to not support that would be limiting gina's usefulness, placing new requirements on our data model... and it's not a large amount of effort to support that. [07:57] So you are saying that we must support Debian re-publishing older package versions. [07:58] As a result of the other constraints. [07:59] wgrant: btw, thanks for my new-found fame on the launchpad wiki :) [08:00] G: You should have been there a while ago, but the upgrade to moin 1.9 broke stuff :( [08:00] wgrant: it only passed QA this afternoon, which I don't class as a while ago :) [08:01] It landed like 12 hours ago. [08:02] guess our definitions of a while ago differ ;) [08:02] wgrant: So apart from the known, pre-existing problem that only one release of a package is considered published per series/archive/component, it sounds like there would be just 1 problem: “if Debian withdraws publication of the most recent version of a package, the previous version is not automatically reactivated.” How serious would that bug be? [08:03] jtv: It also prevents us from reasonably archiving SPPH, which is problematic because it's a huge, slow table that we want to be able to archive. [08:04] I continue to maintain that using the dominator here is an unnecessary complication and an incorrect solution. [08:04] But I must concoct dinner. [08:04] So I shall return later. [08:05] How does it prevent us from reasonably archiving SPPH? [08:07] good morning [08:07] adeuring: good $localtime === almaisan-away is now known as al-maisan [08:38] jtv: We would have to adjust the query to look for both, which is slow and silly. === allenap changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: allenap | Critical bugs: 244 - 0:[#######=]:256 === jtv is now known as jtv-afk [09:05] allenap: Hi, can I add https://code.launchpad.net/~nigelbabu/launchpad/specification-validation-59301/+merge/73631 to your queue? :) [09:06] wgrant: Oh no. He's back. [09:06] nigelb: I know :( [09:16] Project devel build #1,021: STILL FAILING in 3 hr 57 min: https://lpci.wedontsleep.org/job/devel/1021/ [09:21] StevenK: your hudson cert has expired [09:21] ... [09:22] lifeless: We've been plotting ways to keep you away. [09:22] why? [09:22] Because you're "supposed" to be away :) [09:22] Also, how's the baby? [09:24] still in ICU [09:25] I'm about to crash and sleep and then head back in in the morning [09:25] so - gnight. [09:25] nn lifeless. [09:25] g'nite lifeless [09:31] nigelb: Sure, I'll look at that. [09:34] allenap: Thanks :) [09:38] danilos: thanks for the review, updating. [10:21] wgrant: No. [10:24] StevenK: Well, they're certs, and they're free. [10:25] Not sure if IE likes them, but meh. [10:34] danilos: Hi, could you help me quickly with find_tags_by_class? [10:34] I'm just wondering how I would grab the right one :) [10:49] danilos: can I put https://code.launchpad.net/~dev-nigelj/launchpad/bug61428/+merge/73632 in your queue (from our discussion last night) [10:49] *faceplam*, the nigel in that gets me pinged. [10:49] :D [10:50] nigelb: don't worry whenever I see your name in chat, I think it might be poorly addressed to me :) [10:50] nigelb: I think I'll just /nick Nigel ;) [10:50] G: haha, how confusing :D [10:51] if you /nick nigel, everyone who has to talk to both us are going to be surprised :D [10:51] hmmm, you'll get pinged for my test failures. [10:52] oh... Happy Mailman Day :) [10:52] heh, I tweeted that when I woke up. [10:53] nigelb, I can try, but generally, it should be simple to iterate over it and list all the returned items (the fact that you'll get only one should not hold you back from iterating over it) [10:53] danilos: nevermind, trial and error saved the day. [10:53] G: in general, it is good to get more eyes to look at something, so I suggest you go over it with the current OCR, allenap :) [10:54] danilos: okay [10:54] I printed the entire list and grabbed the index of the one I want. I hope that isn't evil. [10:54] allenap: could you please, when you have time, take a look at https://code.launchpad.net/~dev-nigelj/launchpad/bug61428/+merge/73632 for me? [10:54] nigelb, cool [10:56] nigelb: sorry for the ping ;) [10:56] heh [10:56] heh [10:58] I wish bzr didn't throw a huge traceback when I Ctrl+C'd it. [10:58] nigelb: if you use irssi, you could maybe modify https://github.com/nigeljonez/misc-scripts/tree/master/irssi to prevent the highlights on 'nigelj' just a thought [10:59] G: I could, but I don't want to :) === henninge is now known as henninge-lunch [11:00] okay, so I was looking at https://bugs.launchpad.net/launchpad/+bug/810551 how does at the bottom: "Announced: " sound? [11:00] <_mup_> Bug #810551: +announcement/nnn lacks date information < https://launchpad.net/bugs/810551 > [11:01] (like the Updated on: