[07:08] <frewsxcv> with ubuntu one music for android, can i only listen to music i've purchased?
[07:14] <frewsxcv> how do i get music on my android streaming?
[08:19] <JamesTait> Good morning, people! :D
[11:02] <nessita> good morning everyone!
[11:06] <gatox> nessita, hi
[11:06] <nessita> hi gatox
[11:07] <nessita> gatox: wanna list the branches needing review?
[11:07] <gatox> nessita, i'm fixing some things in that branches
[11:07] <nessita> ok\
[11:07] <nessita> gatox: let me know! (no hurries(
[11:07] <nessita> ))
[11:09] <gatox> nessita, ok
[11:27] <gatox> nessita, i have this for review now: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/wizard-sizes/+merge/73804
[11:27] <gatox> that one is important
[11:28] <gatox> nessita, oh wait
[11:28] <nessita> looking
[11:28] <gatox> nessita, let me remove the html
[11:28] <nessita> no looking
[11:28]  * nessita lets
[11:31] <gatox> nessita, in the meanwhile you can take a look at this one: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/prettify/+merge/74219
[11:31] <gatox> :P
[11:32] <nessita> I'm not idle, you know :-P
[11:32] <nessita> I will
[11:33] <gatox> nessita, :P and this one is ready: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/wizard-sizes/+merge/73804
[11:48] <nessita> gatox: you marked this bug as Fix committed https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/836859
[11:48] <nessita> gatox: which was the branch that fixed it?
[11:48]  * gatox looking...
[11:49] <tera___> My two desktops are out of sync and u1sdtool is reporting on both machines nothing waiting how do I kick it back in sync?
[11:49] <gatox> nessita, oh.... that is in progress... is the one of wizard-sizes
[11:49] <gatox> changing it back
[11:49] <nessita> tera___: you can change a file inside the fir you're expecting a sync....
[11:49] <nessita> tera___: what system are you running?
[11:49] <tera___> ubuntu 11.04 on both
[11:50] <nessita> gatox: can you please commit with --fixes so the branch is automatically synced?
[11:50] <gatox> nessita, yep..... i was doing that right now :P
[11:50] <nessita> tera___: in which folder you're expecting changes? is it Ubuntu One or a custom folder?
[11:50] <gatox> nessita, done
[11:50] <tera___> custom
[11:50] <tera___> the desktop
[11:51] <tera___> There is about 4 folders on the one that I moved into my documents almost a week ago now
[11:51] <tera___> on the one = on the desktop
[11:52] <nessita> tera___: can you please paste in paste.ubuntu.com what does u1sdtool -s says? (run that command in a terminal)
[11:53] <nessita> gatox: so, in wizard-sizes the test pass but I'm getting ugly traces, see: bug #843796
[11:54] <tera___> http://paste.ubuntu.com/684330/
[11:54]  * gatox looking..
[11:54] <Chipaca> tera___: can you confirm in the ubuntu one control panel that the folders are set to synchronize on both machines?
[11:54] <nessita> gatox: when you have a spare moment, would you work on that bug?
[11:54] <tera___> I will
[11:54] <Chipaca> tera___: or, pastebin the output of u1sdtool --list-folders
[11:54] <Chipaca> tera___: that might be quicker :)
[11:54] <tera___> k 1 sec
[11:55] <gatox> nessita, yep.... let me finish with another branch i'm working on, and i'll take that one
[11:55] <nessita> gatox: sure!
[11:55] <nessita> gatox: it can be one those branches we do when finishing the day or between large branches
[11:55] <gatox> nessita, ok
[11:56] <tera___> http://paste.ubuntu.com/684333/
[11:56] <tera___> Desktop is the one I'm referring to although I have no way to know if its incorrectly syncing any other files desktop is just so obvious
[11:57] <nessita> tera___: does the file you're trying to sync have some weird pattern in the name? like, it starts with # for example
[11:57] <tera___> Nope
[11:57] <Chipaca> it's beginning to smell like a bug :)
[11:57] <nessita> tera___: can you please file a bug, make it private, and attach your logs from both computers?
[11:58] <tera___> Proposal, park, baposter, and 7908-F Renters Insurance
[11:58] <nessita> tera___: logs are located at:
[11:58] <nessita> ~/.cache/ubuntuone/log
[11:58] <tera___> Sure
[11:58] <nessita> you can zip each folder from each computer and attach those
[11:58] <tera___> both machines logs?
[11:58] <tera___> k
[11:58] <nessita> tera___: yes please
[11:58] <Chipaca> shouldn't we enable debug first?
[11:59] <nessita> Chipaca: well, we could, but I would guess that if we restart syncdaemon this will go away?
[11:59] <Chipaca> hmm... maybe.
[11:59] <Chipaca> yeah
[11:59] <Chipaca> probably notifications backlog. maybe rabbitmq is behind?
[11:59] <nessita> tera___: has this situation been there even after computer restarts?
[11:59] <nessita> Chipaca: good pointer!
[12:00] <nessita> tera___: is the file you're expecting to get synced up-to-date in the web UI?
[12:00] <tera___> I could restart my desktop machine
[12:00] <tera___> I'll check
[12:00] <nessita> thanks!
[12:01] <tera___> Thanks everyone for helping btw
[12:01] <nessita> :-)
[12:01] <tera___> So the web interface is showing the folders as existing
[12:02] <tera___> the master copy (my laptop) does not have those folders
[12:02] <tera___> They were moved to another folder last week
[12:02] <tera___> your next question will be are they in that folder
[12:02] <tera___> I'll check
[12:04] <tera___> Yes they are
[12:05] <nessita> tera___: sorry, but I got lost. What has to be where and where is it instead? :-)
[12:06] <tera___> lol
[12:06] <tera___> Its in both places!
[12:06] <tera___> On my laptop its in one
[12:06] <tera___> in ubuntu one web 2
[12:06] <tera___> and in machine two 2
[12:07] <tera___> It *should* exist in only one location
[12:07] <tera___> On my laptop I moved it from the desktop to docs/pictures/etc... respectively
[12:09] <nessita> tera___: ah! I see now what you mean
[12:09] <nessita> tera___: and I noticed this two sometime in the past
[12:09] <nessita> tera___: you moved a file from folder A to folder B and now is in the 2 locations, right?
[12:09] <tera___> only the computer I didn't move it and the web yes
[12:09] <tera___> The computer I moved it on is spot on
[12:10] <nessita> facundobatista: we have a chicharra bug (I noticed this some time ago and forgot to report)
[12:10] <nessita> tera___: can you please create a bug for this?
[12:10] <tera___> Sure
[12:13] <nessita> Chipaca: I noticed this bug too, I don't think is related to notifications
[12:13] <tera___> It doesn't happen every time because the vast majority of stuff I moved did infact update
[12:13] <tera___> Just these few stragglers
[12:14] <nessita> Chipaca: since when I moved files from an UDF to another, my second client was turned off. The issue is that when I turn it on, syncdaemon did not realize it had to remove some stuff
[12:14] <gatox> nessita, this is my last branch that needs review :P https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setup-button-fix/+merge/74118 (when you have the time)
[12:16] <nessita> gatox: so, the bug that leo reported is not the one you're fixing
[12:16] <nessita> gatox: what leo is asking is that the windows is resizable
[12:16] <nessita> which is not the case, can we have the windows have a size, but let the user make it smaller if he needs to?
[12:16] <gatox> nessita, should we avoid resizing operations in the wizard?
[12:17] <gatox> nessita, no smaller
[12:17] <gatox> bigger.......
[12:17] <gatox> nessita, but has a minimum size at this moment
[12:17] <nessita> gatox: aux le contraire, we need to enable resizing
[12:17] <nessita> gatox: we need to let user resize to small if they want
[12:17] <nessita> gatox: meaning: the wizard should have a default size where all the widgets are visible
[12:18] <nessita> but the user should be able to make the windows smaller, is that diable?
[12:18] <nessita> doable*
[12:18] <gatox> nessita, ahhhhhhh okok
[12:18] <ralsina> good morning!
[12:18] <nessita> hi ralsina
[12:18] <gatox> ralsina, hi
[12:18] <ralsina> smaller than "all widgets are visible"? That's not usually doable
[12:21] <gatox> nessita, , mmm i think ralsina is right.... if we want to make it smaller, we can't assign the sizes that we are assigning now...... and every page in the wizard is going to take the size they want, and WE don't want that
[12:21] <nessita> isn't there a way to setup a 'default' size?
[12:21] <ralsina> unless we did something really ugly like putting everything inside a scrollable frame (yikes)
[12:23] <tera___> I filed a bug do you still want the logs you were talking about earlier?
[12:24] <ralsina> nessita: the default size for the wizard is "the size of the first page + the minimum size for the rest"
[12:25] <nessita> tera___: no need, can you please share with me the link?
[12:25] <ralsina> where "the rest" is the buttons, the side widget, etc.
[12:25] <nessita> ralsina: will that size remain stable among pages?
[12:25] <tera___> https://bugs.launchpad.net/ubuntuone-client/+bug/843818
[12:25] <nessita> tera___: thanks!
[12:25] <tera___> np
[12:26] <ralsina> nessita: no, which is why we are setting the wizard big enough to handle the biggest page. If we made the window smaller, when the page changes, it would grow
[12:26] <nessita> ack
[12:26] <nessita> gatox: your wizard size branch is approved now
[12:26] <gatox> nessita, thanks
[12:26] <ralsina> the alternative is make each page be able to get small, by removing all minimum sizes, but that will probably need lots of testing
[12:29] <nessita> gatox: QGroupBox is still duplicated in prettify
[12:29] <gatox> nessita, let me check
[12:29] <nessita> gatox: you wasted a review! :-D
[12:29] <gatox> nessita, sorry...... :(
[12:29] <nessita> is ok :-)
[12:30] <nessita> ok, I'm oficially coding till noon (mod meetings)
[12:30] <gatox> nessita, mmmmmm i don't see it repeated in launchpad....
[12:30] <gatox> :S
[12:30] <nessita> gatox: hum, I just reloaded and re merged
[12:30] <nessita> let me confirm
[12:31] <facundobatista> nessita, ?
[12:31] <nessita> facundobatista: if you have 2 clients, one turn on, the other turn off, and you move file A from UDF X to UDF y, when you start the second client, the file is copied and not removed from source
[12:32] <nessita> gatox: in the diff there is one, but look the changes with meld
[12:32] <nessita> gatox: and see my review comment
[12:32] <nessita> gatox: in the qss there was *already* a setting for QGroupBox, so you're adding a new one instead of improving the existing one
[12:33] <facundobatista> nessita, don't forget to file a bug about that
[12:33] <gatox> nessita, yes.... i fixed that..... :S
[12:34] <facundobatista> (please)
[12:34] <nessita> facundobatista: bug is filed at bug #843818
[12:34] <facundobatista> nessita, thanks!
[12:34] <nessita> gatox: but is not fixed in the diff
[12:34] <nessita> gatox: did you push?
[12:35] <gatox> nessita, yes..... and i can see it repeated in the diff..... can you tell which line are you looking at?
[12:35] <gatox> i can't i mean
[12:35] <ralsina> gatox: it's not repeated in the diff, it's repeated after you merge :-)
[12:35] <nessita> gatox: in the diff does not appear the repetition
[12:35] <nessita> gatox: in the qss there was already a QGroupBox definition
[12:35] <gatox> ralsina, nessita, ahhhhhhhh
[12:36] <nessita> gatox: you should extend that instead of defining a new one
[12:37] <facundobatista> nessita, do you have the logs for machine 1?
[12:38] <facundobatista> nessita, here you said "file", in the bug report you say "folder"... how big was the tree under that folder?
[12:38] <nessita> facundobatista: I just reproduce it with a folder and a file
[12:38] <nessita> facundobatista: I added instructions to reproduce, should be fair trivial
[12:40] <facundobatista> nessita, don't assign these bugs to me
[12:40] <facundobatista> nessita, and don't put them in "triaged"
[12:40] <nessita> facundobatista: hum, sorry, I thought you were in charge of chicharra
[12:40] <nessita> facundobatista: what status do you want?
[12:40] <nessita> facundobatista: and who should I assign?
[12:40] <facundobatista> nessita, https://wiki.ubuntu.com/UbuntuOne/Bugs/WorkFlow
[12:41] <nessita> facundobatista: what status do you want? and who should I assign? (the varies from team to team)
[12:41] <nessita> that*
[12:42] <facundobatista> nessita, as the bug workflow indicates, set to "confirmed", and assign to "proper team"
[12:48] <nessita> facundobatista: logs attached for a test run
[12:48] <facundobatista> nessita, grosa, mona
[12:57] <ralsina> nessita: have 2' for a wuick mumble?
[12:58] <nessita> ralsina: can we make it afer the standup? if not, sure!
[12:58] <nessita> otherwise I can't write my notes :-D
[12:58] <ralsina> sure
[12:58] <ralsina> Oh notes!
[13:00] <dobey> oh noes!
[13:00] <tera___> nessita, do you have a recommendation on detecting and or correcting this bug?
[13:00] <tera___> I assume they will fix it from happening in the future
[13:00] <dobey> what bug?
[13:00] <nessita> tera___: one second, let me have a minimal meeting and I will answer
[13:00] <dobey> oh
[13:00] <nessita> me
[13:00] <tera___> k
[13:01] <tera___> thanks a bunch
[13:01] <ralsina> me
[13:01] <nessita> alecu, dobey, gatox?
[13:01] <gatox> me
[13:02] <dobey> me
[13:02] <ralsina> alecu seems to be late. nessita go
[13:02] <alecu> me
[13:02] <nessita> DONE: huge amount of reviews and catch up with email/bug reports, uni
[13:02] <nessita> TODO: bug #807021, start bug to refresh folder list in QT-windows-panel
[13:02] <nessita> BLOCKED: nopes
[13:02] <nessita> NEXT: ralsina
[13:02] <ralsina> DONE:
[13:02] <ralsina> * Fixed bug #831945 (installer should say "Installing Ubuntu One")
[13:02] <ralsina> * MAde a release
[13:02] <ralsina> * IRL testing
[13:02] <ralsina> * Reviews
[13:02] <ralsina> * Management call
[13:02] <ralsina> * Merged a pending branch or two (lost bug numbers!)
[13:02] <ralsina> TODO:
[13:02] <ralsina> * Try to merge the rest
[13:03] <ralsina> * Reviews
[13:03] <ralsina> * Make a build
[13:03] <ralsina> * Bug #843835, bug #840178, clean up tests in installer
[13:03] <ralsina> * See where I can help and do it
[13:03] <ralsina> BLOCKED: no
[13:03] <ralsina> gatox!
[13:03] <gatox> DONE:
[13:03] <gatox> Fixed some issues in my branches. Start working in Captcha bug in SSO.
[13:03] <gatox> TODO:
[13:03] <gatox> Keep working in captcha bug and other UI bugs.
[13:03] <gatox> BLOCKED:
[13:03] <gatox> No
[13:03] <gatox> dobey, go
[13:03] <dobey> λ DONE: bug #819955, discovered issues with dependencies keeping stuff on CD
[13:03] <dobey> λ TODO: fix bugs, get stuff off CD
[13:03] <dobey> λ BLCK: None.
[13:03] <dobey> alecu
[13:04] <ralsina> gatox: what captcha bug in SSO????
[13:04] <gatox> ralsina, https://bugs.launchpad.net/ubuntu-sso-client/+bug/814114
[13:04] <alecu> DONE: started cleanup branch for errdict tests (bug #812468)
[13:04] <alecu> TODO: finish errdict branch, work on restart fixes
[13:04] <alecu> BLOCKED: no
[13:04] <nessita> ralsina: if captcha retrieval fails, and you choose to login (not register) you get a error popup
[13:05] <nessita> any comments?
[13:05] <ralsina> no comments
[13:05] <nessita> eom!
[13:05] <nessita> tera___: so, if you confirm you have the files in the places you want, you can safely remove the duplications
[13:06] <tera___> nessita, any good way to detect if this has happened on folders other than my desktop?
[13:07] <nessita> tera___: is very likely it happened with all the files/folders you moved between what we call "user defined folder" (those listed under u1sdtool --list-folders)
[13:07] <dobey> ralsina: oh, maybe should have listed under BLCK, but i have 2 appointments today. but i will just work longer anyway to compensate. :)
[13:07] <ralsina> dobey: no problem
[13:08] <dobey> rodrigo_: ping
[13:08] <tera___> Sure but I have nearly 15 gigs and thousands of files on ubuntu one and went on a cleaning rampage =\
[13:08] <nessita> ralsina: I'm in mumble
[13:08] <nessita> tera___: sorry, I can't think of a better alternative. facundobatista, maybe you have a better advice?
[13:08] <ralsina> nessita: going1
[13:09] <tera___> np
[13:10] <facundobatista> nessita, which bug affected tera___ ?
[13:10] <tera___> 843818
[13:16] <dobey> ah, spanish spam
[13:16] <dobey> "visita nuestra web >>>"
[13:17] <rodrigo_> dobey, pong
[13:18] <dobey> rodrigo_: hey, jderose was saying the desktopcouch issues were beause couchdb doesn't work right with the new erlang in oneiric, but with couchdb 1.1.0 (for which there is a debian sync request) everything works fine.
[13:18] <rodrigo_> dobey, oh, cool!
[13:18] <rodrigo_> dobey, let me know when the new couchdb is in and I'll test it
[13:18] <dobey> rodrigo_: i wonder if we should mark the desktopcouch bugs as dup of the sync request
[13:19]  * nessita -> coding, FINALLY
[13:19] <ralsina> nessita: since we are all in .ar and chipaca is sprinting, let's do our windows-mumble much later today, like at 4:30 PM ART
[13:20] <nessita> ralsina: I'm not here at that time, I leave at 3:30pm
[13:20] <ralsina> ok, then at 3PM
[13:20] <nessita> sure!
[13:22] <dobey> nessita: you didn't want to hear the wonderful idea i had yesterday? :P
[13:22] <alecu> ralsina, ack
[13:22] <nessita> dobey: shoot!
[13:22] <nessita> dobey: (not sure what you're talking about though :-))
[13:23] <dobey> nessita: the idea i had when you linked that bug to the upstream project yesterday, but for which i had no idea why you did.
[13:23] <dobey> right before you left to uni
[13:24] <nessita> dobey: right! I ran away in a very smartly-fashion :-P
[13:24] <dobey> heh
[13:24] <rodrigo_> dobey, yes, all "unauthenticated" bugs are dups
[13:24] <nessita> dobey: so, which one is the idea?
[13:24] <nessita> alecu: was the sso errdict bug a pain?
[13:25] <dobey> nessita: well, i thought maybe you did it because the bug was in nightlies packaging also, so i thought "wouldn't it be great if we had some sort of distribution registered in launchpad for U1, with different series (stable, beta, nightlies), to assign packaging bugs to for our PPA packages
[13:25] <dobey> nessita: but i have no idea how to register a distribution on LP :)
[13:26] <nessita> dobey: sounds good! but I have no idea neither
[13:26] <alecu> nessita, fixing it is not so much trouble, but I'm trying to make comprehensive tests so this won't happen again.
[13:26] <nessita> dobey: maybe one of our LP gurus know?
[13:26] <nessita> alecu: thanks :-)
[13:27] <alecu> nessita, I started by making some needed refactoring, and now I'll be working on the test themselves
[13:27] <nessita> alecu: I can't wait to review that branch ;-)
[13:27] <alecu> ralsina, I'm going to the kinder, so I'll be out for 30' starting about now
[13:27] <alecu> nessita, :-)
[13:32] <alecu> nessita, if you want to review the cleanup branch: https://code.launchpad.net/~alecu/ubuntu-sso-client/refactor-errdict-tests/+merge/74427
[13:32] <alecu> nessita, I think it makes more sense for them to be separated branches
[13:33] <nessita> alecu: queuing that up
[13:33] <alecu> nessita, since this one already is over 1k lines
[13:33] <alecu> nessita, btw: this one is just refactoring
[13:33] <nessita> alecu: ack
[13:34] <gatox> nessita, can you mumble 5 minutes or you are really busy?
[13:35] <alecu> ok, bye all, see you in 30'
[13:35] <nessita> gatox: I can mumble
[13:35] <nessita> let me start it
[14:06] <dobey> i think i'll just remove ubuntuone-control-panel-gtk.desktop
[14:07] <dobey> and make ubuntuone-control-panel-gtk depend on ubuntuone-installer
[14:07] <dobey> nessita: will you hate me for that?
[14:07] <nessita> dobey: not sure what that change is for
[14:08] <nessita> dobey: the unity launcher entry depend on the gtk desktop file, I think
[14:08] <dobey> nessita: the unity launcher entry should be changed to ubuntuone-installer.desktop now. didrocks said he would do that anyway :)
[14:09] <dobey> nessita: because cp won't be installed by default, but we still want u1 icon to be there by default, and let the user install it
[14:09] <nessita> dobey: ok then. what about the messaging menu entry? the same will happen?
[14:10] <dobey> nessita: i guess i will have to change the file we install for that to point to installer.desktop
[14:10] <dobey> or i will just make the control panel one be Hidden=true
[14:10] <dobey> that's probably easier
[14:11]  * dobey tests
[14:11] <nessita> dobey: I will trust you on this one, I'm not very skilled with .desktop files yet
[14:12] <ralsina> gatox: did you start with bug 843796 ? If you didn't, I would like to propose a branch for it
[14:13]  * nessita wants a bot!
[14:13] <gatox> ralsina, do it... i'm with 814114
[14:13] <ralsina> gatox: ok
[14:13] <ralsina> nessita: who provides those?
[14:13] <alecu> ralsina, "us robotics"?
[14:13] <nessita> ralsina: not sure, maybe dobey knows?
[14:14]  * alecu meant USRobotics
[14:14] <ralsina> alecu: I thought you meant susan calvin's US Robots and Mechanical Men, Inc
[14:14] <dobey> nessita: the ubotu?
[14:14] <nessita> right
[14:14] <dobey> no idea
[14:15] <dobey> ubuntu irc council i guess?
[14:17] <alecu> what about running a copy of https://code.launchpad.net/~verterok/lalita/hal ?
[14:18] <ralsina> alecu, gatox: trivialish review -- https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_843796/+merge/74440
[14:18] <gatox> ralsina, on it
[14:19] <dobey> alecu: i'd rather have the normal ubuntu bot which does the logging and everything too
[14:20] <dobey> alecu: so ubuntuone is on irclogs.ubuntu.com
[14:22] <nessita> alecu: approved your refactor branch with a small change request
[14:22] <alecu> dobey, yeah, that's much more useful. But we should have a workaround when that bot is offline, because it's annoying not to get the bugs linked.
[14:22] <alecu> nessita, cool, thanks.
[14:23] <dobey> alecu: well, that bot is in #ubuntu-desktop, so i'm not sure why there isn't one here
[14:24] <nessita> ralsina: that branch solves only one issue, no?
[14:24] <ralsina> nessita: couldn't reproduce the other one
[14:24] <nessita> ralsina: what about the:
[14:24] <nessita>     return os.stat(filename).st_size
[14:24] <nessita> OSError: [Errno 2] No such file or directory: '/tmp/tmp_hLsNb/test_file'
[14:24] <nessita> ralsina: is a timing issue since that is triggered from a thread
[14:24] <nessita> anyways, I think you need to patch os.stat
[14:24] <ralsina> nessita: yes, that's the one I couldn't reproduce
[14:25] <nessita> ralsina: but you can patch os.stat, I would guess
[14:25] <nessita> ralsina: since it will be tricky to reproduce
[14:25] <ralsina> nessita: after this branch lands, I will mark the bug as still open with a comment
[14:34] <gatox> ralsina, +1 (branch)
[14:35] <ralsina> gatox: thanks!
[14:35] <dobey> look, a bot!
[14:35] <dobey> (you're welcome)
[14:35] <dobey> bug #819955
[14:35] <ubot4> Launchpad bug 819955 in ubuntuone-control-panel (Ubuntu) (and 4 other projects) "Join button says you only get 2GB of free storage (affects: 11) (dups: 5) (heat: 70)" [Medium,Confirmed] https://launchpad.net/bugs/819955
[14:35] <dobey> whee
[14:36] <dobey> just like old times
[14:37] <ralsina> thanks dobey!
[14:46] <dobey> ok. time for appt #1 and to get some quick lunch after. bbiab
[15:54] <gatox> ralsina, nessita, alecu when you have a minute i have 2 branches, the one from the installer should be merged before the sso one: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/message-critical/+merge/74464   and   https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/message-critical/+merge/74462
[15:55] <nessita> gatox: installer before sso?
[15:55] <nessita> gatox: test for the installer branch, please :-)
[15:55] <gatox> nessita, to merge in launchpad... because they are related..... but the installer one can work without the sso, sso without installer not
[15:56] <nessita> gatox: I understand
[15:57]  * gatox doing tests for installer....
[16:10] <gatox> nessita, tests added: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/message-critical/+merge/74464
[16:11] <gatox> nessita, the if part was already being tested.
[16:14] <nessita> gatox: ack
[16:18] <dobey> back
[16:21] <dobey> meh
[16:21] <dobey> this problem is harder than i thought :(
[16:24] <nessita> dobey: which one? life? :-)
[16:26] <dobey> well that too
[16:26] <dobey> but the 2 u1 launchers issue
[16:32] <ralsina> nessita, gatox: medium branch for review https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/cloud-to-cloud/+merge/74457
[16:33] <ralsina> it changes the whole computer-to-cloud, cloud-to-computer workflow in the installer
[16:33] <gatox> ralsina, on it
[16:35] <dobey> meh i don't know what to do
[16:36] <gatox> nessita, ralsina, when you have a minute (really trivial): https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/fix-823203/+merge/74471
[16:37] <ralsina> gatox: +1 in the installer branch
[16:37] <gatox> ralsina, thanks
[16:37] <gatox> lunch...... brb!
[16:38] <ralsina> gatox_lunch: approved that one globally
[16:38] <gatox_lunch> ralsina, awesome
[16:41] <nessita> ralsina: in the systray icon test, you just added test_is_visible for the __init__ code?
[16:42] <nessita> or am I missing something?
[16:42] <ralsina> nessita: there are tests for each signal connection
[16:42] <ralsina> and the connected function's behaviour
[16:43] <nessita> ralsina: ah, ok. Can you add a couple for the self.window = None, self.setIcon(QtGui.QIcon(":/u1icon.png")), and at least one checking that the context menu is defined?
[16:43] <ralsina> the self.window = None is just for lint :-)
[16:43] <ralsina> but sure, will add the asserts
[16:44] <nessita> ralsina: thanks!
[16:47] <ralsina> nessita: asserting it's the correct icon is not obvious
[16:47] <ralsina> I can't compare QIcons
[16:48] <ralsina> Ok, I can patch seticon. Will do that
[16:48] <nessita> ralsina: can you at least assert is not None?
[16:48] <nessita> or that! :-)
[16:51] <nessita> ralsina: in cloud-to-cloud, the whole test_gui changed. Any idea why?
[16:51] <ralsina> probably EOLs, let me check
[16:53] <ralsina> nessita: pushed with fixed EOLs
[16:54] <nessita> ralsina: were they all changed to windows'?
[16:54] <ralsina> and pushed with-systray with the two suggested asserts
[16:54] <ralsina> nessita: two files were changed to CR/LF
[16:54] <ralsina> but one was new so it was not visible
[16:55] <nessita> ralsina: 2 asserts? weren't they 3? :-)
[16:55] <ralsina> oh, the context menu
[16:55] <ralsina> sire
[17:00] <ralsina_> nessita: strange thing happened when I patch setIcon
[17:00] <ralsina_> it makes other tests fail!
[17:00] <nessita> ralsina: how are you patching?
[17:00] <ralsina_> self.patch(TrayIcon, "setIcon", self._set_called)
[17:00] <ralsina_> inside one test
[17:04] <nessita> ralsina_: and what kind of failures you get?
[17:05] <nessita> sounds *very* strange
[17:05] <ralsina_> exceptions.TypeError: QSystemTrayIcon.setIcon(QIcon): first argument of unbound method
[17:05] <ralsina_> must have type 'QSystemTrayIcon'
[17:05] <ralsina_> it's like it's not restoring setIcon correctly?
[17:06] <nessita> ralsina_: how did you imported TrayIcon?
[17:06] <nessita> ralsina_: seems like setIcon is a class method (?)
[17:08] <ralsina_> nessita: from ubuntuone.controlpanel.gui.qt.systray import TrayIcon
[17:09] <nessita> ralsina_: I bet setIcon is a classmethod, so is not restored properly
[17:09] <ralsina_> nessita: could be
[17:09] <nessita> ralsina_: just assert the icon is not nione
[17:09] <ralsina_> ok
[17:09] <nessita> is that easily doable?
[17:11] <ralsina_> nessita: yes, easy and done
[17:11] <ralsina_> and pushed
[17:16] <ralsina_> alecu: ping
[17:17] <dobey> nessita: https://code.launchpad.net/~dobey/ubuntuone-control-panel/fix-grammar/+merge/74483 <- fixed the grammar issues for that one bug :)
[17:17] <nessita> dobey: great! looking
[17:17] <alecu> ralsina_, pong
[17:17] <ralsina_> alecu, I see a branch t ix errdit tests. Is there another one for the actual bug, or I missed it :-)
[17:18] <alecu> ralsina_, that's the first one, just with refactoring of the tests. I'm working on the second one.
[17:18] <ralsina_> alecu: oh, ok
[17:21] <alecu> ralsina_, and I have this other branch up for review; it's a server branch so it might not be so easy to review for you or gatox: https://code.launchpad.net/~alecu/ubuntuone-servers/client-delayed-hashing/+merge/74308
[17:21] <ralsina_> alecu: I am clueless re: server branches
[17:23] <alecu> ralsina_, there's a lot of stuff to apt-get in order to review server branches, but it's not so difficult.
[17:24] <ralsina_> alecu: I promise to learn how to do it on monday ;-)
[17:24] <alecu> ralsina_, I can help, but I'm not sure it's worth the time :-)
[17:24] <alecu> ralsina_, exactly.
[17:24] <ralsina_> alecu: can I get a quick one here: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_843796/+merge/74440
[17:24] <alecu> sure
[17:32] <nessita> ralsina_: ./ubuntuone/controlpanel/gui/qt/tests/test_systray.py:104:1: W391 blank line at end of file
[17:32] <nessita> (pep8 issue(
[17:32] <nessita> ))
[17:32]  * ralsina_ looks
[17:33] <ralsina_> nessita: pushed, sorry
[17:34]  * nessita re branches
[17:40] <nessita> ralsina_: no need to change, but is better practice to check against None using "is"/"is not"
[17:40] <ralsina_> nessita: ack
[17:40] <nessita> approved!
[17:42] <ralsina_> nessita: cool, thanks!
[17:45] <nessita> dobey: approved, I'd say go with one review
[17:46] <ralsina_> alecu: +1 on refactor_errdict
[17:48] <dobey> bbiab, appt# 2 time
[17:49] <alecu> ralsina_, cool, thanks.
[17:50] <ralsina_> gatox: you stated on bug #841918 or I can steal it?
[17:50] <ubot4> Launchpad bug 841918 in ubuntuone-windows-installer "Change behavior of License Page related to the uninstall (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/841918
[17:51] <gatox> ralsina_, feel free to do it.... i'm following the list of bugs order by priority that nessita gave me and i haven't reach that one yet
[17:51] <nigelb> aquarius_: ping
[17:51] <ralsina_> gatox: cool, it's mine then
[17:51] <alecu> ralsina_, re: your branch, I was going to say that we are not returning nor yielding the deferred returned by setUp, but checking the inheritance chain, I found that the TestCase in ubuntuone_installer/tests/__init__.py is not calling the parent setUp at all.
[17:52] <alecu> ralsina_, so... it looks like a bug there.
[17:52] <ralsina_> alecu: what branch is that?
[17:52] <aquarius_> nigelb, pong
[17:52] <nigelb> aquarius_: are you using this nick for classroom?
[17:52] <alecu> ralsina_, https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_843796/+merge/74440
[17:53] <alecu> ralsina_, but it's not your branch's fault
[17:53] <ralsina_> alecu: ok
[17:53] <aquarius_> nigelb, I am
[17:53] <alecu> ralsina_, it seems like a bug that's on trunk.
[17:53] <aquarius_> ah, damn, I've got an underscoer
[17:53] <ralsina_> alecu: weird that everything woks though :-)
[17:53] <aquarius_> never mind, I'll live with the underscore :)
[17:53] <alecu> ralsina_, yup, it usually does :-)
[17:53] <alecu> uhm.... wok!
[17:54] <alecu> meesa hungry
[18:02] <nessita> ralsina: are we mumbling? i need to leave at 3:30 sharp
[18:02] <ralsina> nessita, alecu, gatox: mumble!
[18:02] <ralsina> nessita: will be short
[18:03] <gatox> ralsina, oops can you wait 10 mins?
[18:03] <alecu> ralsina, approved.
[18:03] <ralsina> gatox: no we can't :)
[18:03] <ralsina> alecu: yay!
[18:19] <gatox> nessita, https://bugs.launchpad.net/ubuntuone-control-panel/+bug/842816
[18:19] <ubot4> Launchpad bug 842816 in ubuntuone-control-panel "Fix UI styling in GroupBoxes to use Bold font, and some alignments (affects: 1) (heat: 6)" [Medium,In progress]
[18:22] <nessita> ralsina, alecu or gatox? https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/handle-errors/+merge/74490
[18:23] <gatox> ok....... EOD for me now!! have to prepare a class :P
[18:23] <nessita> ralsina: I will finish cloud-to-cloud later, I want to test it IRL, and I don't wanna do it in a hurry
[18:24] <nessita> gatox: good luck!
[18:24] <ralsina> nessita: it's ok
[18:24] <gatox> nessita, thanks! :D
[18:24] <nessita> alecu: I approved the client-server branch
[18:24] <nessita> ok, I'm off
[18:24] <gatox> ah..... if you want send me an e-mail with reviews for tomorrow morning
[18:24] <nessita> bye all!
[18:24] <gatox> nessita, bye
[18:25] <alecu> nessita, thanks
[18:25] <alecu> and bytes!
[19:14] <ralsina> Going to pick up kid from school
[19:24] <dobey> oi
[19:39] <ralsina> and back!
[19:39] <ralsina> dobey, you have access to the canonistack tarmac?
[19:43] <dobey> ralsina: supposedly, if i knew the ip
[19:43] <ralsina> dobey: ok
[20:08] <ralsina> gatox: if you are still around, quick review: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/add_install_option/+merge/74506
[20:08] <ralsina> and if you have any pending now is a good time to ask :-)
[20:09] <gatox> ralsina, on it
[20:09] <gatox> ralsina, and https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/message-critical
[20:09] <gatox> :P
[20:09] <ralsina> gatox: I had seen that one, forgot to approve!
[20:09] <gatox> ralsina, better then! :D
[20:09] <ralsina> gatox: there you go, approved :-)
[20:09] <ralsina> but it seems tarmac is not landing stuff
[20:13] <dobey> maybe the instance died
[20:15] <ralsina> dobey: probably
[20:15] <gatox> ralsina, +1! everything seems to be ok, and the tests are running without problem! :D
[20:16] <dobey> hmm
[20:16] <ralsina> gatox: thanks!
[20:17] <dobey> meh, us.archive is out of sync
[20:17] <ralsina> alecu: do you have 5' for a not-too-big review?  https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/add_install_option/+merge/74506
[20:17] <ralsina> alecu: no need t run the tests, pylint or pep8 in it! ;-)
[20:21] <jbicha> hi I complained last night about this:
[20:21] <jbicha> I have a "Sign up for free" link on https://one.ubuntu.com/account/ that never goes away and doesn't do anything useful
[20:22] <jbicha> I use the free acount
[20:23] <dobey> jbicha: how much storage space does it say you have?
[20:32] <jbicha> dobey: 5.0 GB
[20:33] <jbicha> it says 20th July 2009 start date
[20:33] <beuno> jbicha, could you PM me your email address so I can look at your accoung?
[20:34] <beuno> ok, so nothing wrong with the account
[20:34] <beuno> jbicha, could you file a bug please?  https://bugs.launchpad.net/ubuntuone-servers/+filebug
[20:35] <jbicha> beuno: yes, everything still works, will do
[20:35] <jbicha> partly I wasn't sure where to report it to
[20:35]  * beuno nods
[20:36] <beuno> it may a be a bug on our new accounts page
[20:36] <beuno> jbicha, would be great if you can attach a screenshot to it as well
[20:36] <ralsina> Leaving for a couple of hours to be a parent, will be back late tonight to make another build
[20:43] <jbicha> beuno: ok, done as bug 844271
[20:43] <ubot4> Launchpad bug 844271 in ubuntuone-servers ""Sign up for free" but I'm already signed up for the free plan (affects: 1) (heat: 8)" [Undecided,New] https://launchpad.net/bugs/844271
[20:44] <jbicha> thanks
[20:44] <beuno> jbicha, thank you
[21:21] <jo-erlend> I noticed earlier today that there was an update to ubuntu one. In afterthought, it seems to have said something like dropping secure logins because Ubuntuones couch-service didn't support it?
[21:22] <jo-erlend> can someone explain what this means?
[21:25] <dobey> update to ubuntu one on what platform?
[21:26] <jo-erlend> oneiric.
[21:26] <dobey> i don't know of any updates that would give a message like that. couchdb is broken on oneiric at the moment, and thus desktopcouch doesn't work, but it raises an UnauthorizedError or something like that
[21:28] <jo-erlend> yes, I know, but I am absolutely certain that the message said something like that. I had just woken up when I installed them, so I was somewhat groggy, but it came back to me later, that that didn't seem normal.
[21:29] <dobey> where did you see that message?
[21:30] <dobey> in deja-dup maybe?
[21:30] <jo-erlend> update-manager.
[21:31] <dobey> that's weird
[21:31] <jo-erlend> yes. How do I find those messages?
[21:31] <dobey> i don't know. was it in the console output?
[21:31] <jo-erlend> no, in the changes, I think.
[21:32] <dobey> oh
[21:33] <dobey> https://launchpad.net/ubuntu/+source/ubuntuone-couch/0.3.0-0ubuntu1
[21:33] <dobey> one of those messages?
[21:33] <jo-erlend> I've been paying special attention to everything concerning couch and desktopcouch, since I'm really itching to start working on my app for oneiric, but that one puzzled me.
[21:34] <jo-erlend> no, none of those.
[21:34] <dobey> your description sounds like maybe you misread the changelog entry about dropping a patch that was upstreamed?
[21:35] <dobey> well look in /var/log/dpkg.log to see what package it was
[21:36] <dobey> oh
[21:36] <dobey> https://launchpad.net/ubuntu/+source/ubuntuone-couch/0.2.0-0ubuntu4
[21:36] <dobey> probably that one then
[21:36] <dobey> looks like 0.3.0 isn't actually published yet
[21:38] <jo-erlend> right. That's it:  - Disable SSL validation because it isn't currently working with one.ubuntu.com (LP: #797281)
[21:38] <jo-erlend> what on earth does that mean?
[21:38] <dobey> that description is perhaps a bit misleading
[21:39] <jo-erlend> it sounded a little bit scary to me.
[21:39] <dobey> new versions of httplib2 enable SSL validation by default, but don't do it correctly
[21:39] <dobey> and it basically broke everything that uses httplib2
[21:40] <dobey> so the quick/easy fix is to pass in the option to disable validation
[21:40] <jo-erlend> oh, ok. So it's not like "disable password checks because they often fail"? :)
[21:40] <dobey> it actually has nothing to do with the server
[21:40] <dobey> right
[21:42] <jo-erlend> heh... I had myself a couple of cups of coffee, a cigarette or two, a shower and then I asked myself: "what the hell was that?" :)
[21:43] <jo-erlend> oh, I hope this couch-stuff gets fixed soon. It's really annoying to not be able to work on my app for oneiric.
[21:45] <dobey> jo-erlend: see https://bugs.launchpad.net/ubuntu/+source/couchdb/+bug/817656 ; there are couchdb 1.1.0 packages in novacut dailies at least that should work, and a merge proposal to get 1.1.0 into oneiric, but it apparently needs an FFe and some minor work still.
[21:45] <ubot4> Launchpad bug 817656 in couchdb (Ubuntu) "Please merge couchdb 1.1.0-1 (main) from Debian unstable (main) (affects: 7) (dups: 2) (heat: 42)" [High,In progress]
[21:45] <dobey> jo-erlend: but if you want to test the 1.1.0 packages and provide feedback, it would be quite helpful there
[21:52] <jo-erlend> what is this novacut I keep reading about?
[21:57] <dobey> jo-erlend: a video editor/service project. they're using desktopcouch/couchdb for some of the stuff
[22:11] <dobey> well, have a good evening all. i'm out of here