* gmb lunches | 11:09 | |
danilos | ah, lunch, good idea :) hi gmb btw :) | 11:10 |
---|---|---|
bac | danilos: when you get back let's talk about bug 302449 | 11:50 |
_mup_ | Bug #302449: Uploading a file with the same name triggers a database constraint. <lp-translations> <oops> <Launchpad itself:In Progress by danilo> < https://launchpad.net/bugs/302449 > | 11:50 |
danilos | bac, hey, I am actually working on it right now (still haven't had lunch, though I'll probably drop out for a bit to get some food) | 11:51 |
bac | danilos: ok, i have to eat too | 11:51 |
danilos | cool | 11:51 |
bac | there are a couple of problems. one the tests blow up b/c the objects you get now are security proxied | 11:51 |
bac | that's easy to fix. there is another proble in the call to query to get the list of blocked items is failing and i can't figure out why | 11:52 |
bac | when my dev box comes back up i'll push the branch where i've made some changes | 11:52 |
bac | danilos: ^^ | 11:52 |
danilos | bac, yeah, I am looking at that particular problem right now (the sourcepackagerelease*.txt failure was an easy one to fix) | 11:53 |
bac | ok | 11:53 |
danilos | bac, btw, thanks for looking into it, I appreciate that | 11:53 |
danilos | bac, I really look forward to your changes, so do let me know once you push them up | 11:54 |
bac | ok. | 11:54 |
bac | right now my laptop is not booting. :( | 11:54 |
danilos | bac, should I guess at an oneiric upgrade? :/ | 12:10 |
bac | danilos: nope... it was the other side of my dual boot attempting to install a security patch post-boot | 12:10 |
danilos | bac, btw, my factory change was broken: I removed the entry.status setting completely which caused the test failures here (someone said earlier how we should have tests for factory methods) | 12:12 |
danilos | bac, ah-ha, interesting that mac does that as well | 12:12 |
gary_poster | danilos! you have some news? | 12:17 |
danilos | gary_poster, unfortunately, no, still a student :/ | 12:17 |
gary_poster | danilos oh :-( | 12:17 |
gary_poster | bac benji danilos gmb call in 1-ish | 12:29 |
bac | a-ok | 12:29 |
gary_poster | danilos, skype? | 12:31 |
danilos | gary_poster, I was on, but it seems to have crashed | 12:31 |
danilos | (like a minute ago) | 12:31 |
gary_poster | ack danilos ping me when I should retry | 12:31 |
danilos | gary_poster, please retry | 12:31 |
bac | danilos: my branch is at bzr+ssh://bazaar.launchpad.net/~bac/launchpad/danilo-302449 | 12:37 |
bac | it is really unsurprising, just a sprinkling of rsp where necessary | 12:38 |
danilos | bac, cool, thanks | 12:38 |
bac | danilos: any idea why getBlockableDirectories returns nothing? | 12:40 |
danilos | bac, yeah, that's what I mentioned above: my factory change removed the setting of the entry status field, so it was never set to BLOCKED | 12:44 |
bac | danilos: oh, sorry, didn't see that message | 12:44 |
danilos | bac, btw, I can't seem to get to your branch | 12:46 |
bac | odd | 12:46 |
bac | try this spelling lp:~bac/launchpad/danilo-302449 | 12:47 |
danilos | bac, Launchpad seems to think the same if I look at https://code.launchpad.net/~bac/launchpad | 12:47 |
danilos | bac, I did already | 12:47 |
bac | danilos: my bad. try now. | 12:48 |
danilos | bac, cool, it worked, I've merged your changes now, thanks again | 12:53 |
bac | danilos: np. | 12:56 |
bac | gmb: you have time for a pre-imp about bug 831991 ? | 14:27 |
_mup_ | Bug #831991: When the Janitor autoconfirms a bug, it should explain why <escalated> <ubuntu-qa> <Launchpad itself:In Progress by bac> < https://launchpad.net/bugs/831991 > | 14:27 |
gmb | bac: Certainly. I'll just start skype | 14:27 |
bac | bac: and i'll stop spotify | 14:27 |
* danilos -> out, see ya tomorrow | 15:23 | |
* gary_poster goes to lunch | 15:54 | |
* bac <- food | 17:20 | |
gary_poster | The result of approx 6 hours of blood sweat and tears trying to get some tests to pass: | 19:08 |
gary_poster | bzr diff | wc -l | 19:08 |
gary_poster | 55 | 19:08 |
gary_poster | ...sigh... :-) | 19:08 |
bac | hey gary_poster | 19:38 |
gary_poster | hey bac. sorry, I was in full screen terminal mode | 19:59 |
gary_poster | what's up | 19:59 |
bac | hey i wanted to ask about auto-confirmation of bugs | 19:59 |
bac | bug 831991 implies that having dupes would autoconfirm a bug | 20:00 |
_mup_ | Bug #831991: When the Janitor autoconfirms a bug, it should explain why <escalated> <ubuntu-qa> <Launchpad itself:In Progress by bac> < https://launchpad.net/bugs/831991 > | 20:00 |
bac | but the code shows otherwise | 20:00 |
gary_poster | bac, it is supposed to. Note that "also affects" is affected by dupes | 20:01 |
gary_poster | so perhaps that's what is confusing you? | 20:01 |
bac | it re-evaluates when a bug is duped...but only marks it if affected by >1 peeps | 20:01 |
bac | so just having a dupe does not autoconfirm | 20:01 |
gary_poster | bac, ah true. | 20:01 |
bac | is that correct? | 20:01 |
gary_poster | yes, bac | 20:01 |
bac | and as designed? | 20:01 |
gary_poster | yes, bac. Let me make sure we're clear | 20:02 |
gary_poster | if a bug is duped, then "also affects" is adjusted by the people who are in the new dupe(s) but not already existing | 20:02 |
gary_poster | so if I make a bug | 20:02 |
gary_poster | and then a second | 20:02 |
gary_poster | and I mark the second as a dupe | 20:03 |
gary_poster | then perhaps it is re-evaluated | 20:03 |
gary_poster | but the number will not increase | 20:03 |
gary_poster | however | 20:03 |
gary_poster | if I make a bug | 20:03 |
gary_poster | and then you make a bug | 20:03 |
gary_poster | and I marke yours as a dupe | 20:03 |
gary_poster | then "also affects" will increase by one | 20:03 |
gary_poster | and so the code will be triggered | 20:03 |
bac | ok | 20:04 |
gary_poster | (the same happens in other scenarios, | 20:04 |
gary_poster | like I make a bug | 20:04 |
gary_poster | I make another bug | 20:04 |
gary_poster | the second bug "affects you" | 20:04 |
bac | but, a bug will get autoconfirmed only the number of affected users is > 1 | 20:04 |
gary_poster | and then the second bug is a dupe of the first | 20:04 |
gary_poster | yes bac | 20:04 |
bac | ok, | 20:05 |
bac | i found that surprising due to the comment in the bu | 20:05 |
bac | bug | 20:05 |
bac | thanks for the clarification | 20:05 |
* gary_poster looks at bug... | 20:05 | |
gary_poster | yeah, comment is confusing | 20:05 |
gary_poster | np | 20:05 |
=== benji is now known as Guest95110 | ||
=== benji___ is now known as benji |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!