=== popey_ is now known as popey [07:50] morning all! [07:51] Chipaca, ping [08:06] mandel: pong! [08:07] mandel: morning [08:07] Chipaca, buenos dias! [08:08] mandel: cómo le baila? [08:08] Chipaca, do ou know if there is any how to of how ralsina builds the .exe. I think I know how to make u1 auto-update on windows for today, but I need to know that :( [08:08] Chipaca, everything ok, still lots of boxes to open :) [08:09] mandel: AFAIK it's a branch of his, but I haven't investigated much [08:09] Chipaca, you already know more than I do :) [08:10] Chipaca, I'll look around, but I think eski is the answer for the updating problem :) [08:25] Good morning, all! [09:16] gatox, ping? [09:28] mandel, pong [09:32] mandel, ping? [09:46] mandel, please let me know when you are back..... i have something to ask you [11:19] gatox, ask then :) [11:20] gatox, sorry I was on the vm and I'm running the irc client on the host hehe [11:20] mandel, let me ask you in pm [11:26] ralsina, ping [12:15] hello #ubuntuone! [12:16] alecu, hiiiiiiii [12:17] hi gatox! [12:17] gatox, I'm so anxiously waiting for the PyCon night were we'll get to play the BSG game for the first time!!! [12:17] alecu, JEJEJEJEJE PLEASE INVITE ME!! [12:18] gatox, I THOUGHT YOU WERE INVITED ALREADY! [12:18] alecu, awesome!!!!! [12:18] :-) [12:18] alecu, the other day i bought the complete dvd collection and a replica of the dog tag :P [12:18] of BSG [12:19] the complete DVD collection? awesome! [12:23] mandel: pong [12:30] morning! [12:32] ralsina, morning! [12:32] good morning and pong! [12:32] ralsina, so I was a little block this morning because I don't know how to build a .exe [12:32] oooooooooooooohhhhhhhhhh [12:32] ralsina, and I want to try something very cool called esky [12:33] mandel: get branch lp:~ralsina/ubuntuone-windows-installer/fix_809873, go into scripts and read the README :-) [12:33] mandel: googling esky [12:33] ralsina, so, if you can explain me how to build the .exe I'll test that I have an auto-update windows installer [12:33] The electronic sky, the Edmonton eskimoes, or the helicopter? [12:33] mandel: building exes: ^ [12:34] ralsina, will check for new version against a url (rest api or waht ever) and will update [12:34] ralsina, http://pypi.python.org/pypi/esky/ [12:34] ralsina, not the radio control chiper :) [12:34] helicopter, sorry [12:35] then to build the installer you need InstallBuilder Professional (get the trial, I'll mail you the license key) [12:35] mandel: using esky seems to require changing a lot of paths for everything [12:35] ralsina, I'm just interested in the freezing [12:35] mandel: and I suspect we will break stuff and only find out after release [12:36] and calling the "cleanup" method on seven is going to be *very* tricky [12:36] ralsina, hm? that could happen, I need to go I'll be back in 20 min (having lunch early) [12:36] cool, see you then [12:47] gatox, your branch "broke" my python! [12:47] gatox, somehow the python process segfaulted :P [12:47] alecu, wow!! mandel says the same [12:47] ??? [12:48] alecu, ok...... let me work on that [12:49] gatox, probably it ate a lot of memory... [12:49] what branch is that? [12:49] ralsina, a branch that where i'm migrating mocker test to no mocker test [12:49] Oh, *that* branch [12:50] ralsina, but i can not run the tests.... [12:50] * ralsina suggests not doing that then [12:51] ralsina, the problem is that with some changes in that branch to fix name required bug (critical) i was having some problems with mocker that fails without reason..... and nessita told me to better do that..... because the mocker test was failing [12:52] I see. [12:52] Tricky situation [12:53] If the crash is a segfault, we *may* be hitting on a problem with PyQt. There are reports of bad interaction with gc (removing Qt objects from non-main threads) leading to segfaults. [12:53] And there is a simple, yet ugly solution for that, which I would hate trying to use [12:55] ralsina, which is??..... also i would like to try something in the installer to see if it is related to this crash [12:55] gatox: disabling gc and runnint it manually in a QTimer [12:55] ralsina, the problem in my case is that python doesn't crash for me... but i'm receiving reactor was unclean (unless this is related) [12:56] gatox: usually that means a deferred is not triggered before the test finishes [12:58] ralsina, ok..... i'll finish with the remaining tests... unless write them..... and then move to other things and see how to fix this in parallel..... we should ask nessita what can we do with the "name required" branch... now that the tests are not running for this..... just for a single mocker tests [12:58] if it's a single test, we could skip it and the fix it, if we have really good evidence the tested thing actually works [12:59] +1 [12:59] hello nessita [12:59] good morning! [12:59] * nessita ran [13:00] don't run in class children! [13:01] ralsina, yes! it works.... and it's really crazy.... mocker says that the line is performed more times than expected (just 1), and if i delete that line it says that has an unexpected operation [13:01] me [13:01] me [13:01] gatox: I remember similar mocker madness :-) [13:01] me [13:01] alecu, dobey_, mandel: stand up? [13:02] me [13:02] crap === dobey_ is now known as dobey [13:02] DONE: bug triage and lots of reviews, analysis of bug #846373 with alecu [13:02] TODO: passport update for UDS (just completed), kill bugs! [13:02] BLOCKED: nopes [13:02] NEXT: gatox [13:02] nessita: Error: Bug #846373 not found. [13:02] DONE: [13:02] Not so much [13:02] TODO: [13:02] Finish with the migration of mocker tests. [13:02] BLOCKED: [13:02] By the mocker tests :S [13:02] ralsina go [13:02] me [13:02] DONE: lost my notes, but I am pretty sure I fixed a couple of bugs. Postponed release until late thursday (end of coding) reviews, bug triaging, booked flights for london [13:02] TODO: finish a few more bugs, doctor's appointment, help around, start sprint planning [13:02] BLOCKED: no [13:03] dobey: ? [13:03] λ DONE: got bug #780972 fix uploaded, bug #848067, bug #788532, bug #840072 [13:03] λ TODO: bug #849408, bug #838778, get stuff off CD [13:03] λ BLCK: None. [13:03] alecu: [13:03] DONE: a branch to fix bug #848988, worked on a solution to bug #846373 [13:03] TODO: finish branch for #846373 [13:03] BLOCKED: no [13:03] NEXT: mandel [13:03] Launchpad bug 780972 in couchdb (Ubuntu Oneiric) (and 1 other project) "desktopcouch-service crashed with Unauthorized in request(): ('unauthorized', 'Authentication required.') (affects: 669) (dups: 109) (heat: 3458)" [Critical,Fix released] https://launchpad.net/bugs/780972 [13:03] Launchpad bug 848067 in ubuntuone-dev-tools (Ubuntu Oneiric) (and 2 other projects) "ubuntuone-dev-tools ftbfs in oneiric (affects: 1) (heat: 6)" [High,Confirmed] https://launchpad.net/bugs/848067 [13:03] Launchpad bug 788532 in libubuntuone (Ubuntu Oneiric) (and 6 other projects) "U1 music store plugin severely delays banshee startup (affects: 7) (dups: 1) (heat: 46)" [High,Fix released] https://launchpad.net/bugs/788532 [13:03] Launchpad bug 840072 in ubuntuone-installer (Ubuntu) (and 1 other project) "Installer needs to install more packages (affects: 2) (dups: 1) (heat: 16)" [Medium,Confirmed] https://launchpad.net/bugs/840072 [13:03] Launchpad bug 849408 in ubuntuone-installer (Ubuntu) (and 1 other project) "Installer UI is not translated (affects: 1) (heat: 6)" [Undecided,Confirmed] https://launchpad.net/bugs/849408 [13:03] Launchpad bug 838778 in ubuntuone-control-panel (Ubuntu Oneiric) (and 2 other projects) "After installing Ubuntu One, there are 2 Ubuntu One launchers in System Settings (affects: 41) (dups: 11) (heat: 184)" [High,Triaged] https://launchpad.net/bugs/838778 [13:03] Launchpad bug 848988 in ubuntuone-client "Credentials tokens show up on the logs (affects: 1) (heat: 6)" [Critical,New] https://launchpad.net/bugs/848988 [13:03] alecu: Error: Bug #846373 not found. [13:03] yes, cause it's private. [13:03] DONE: Look at using esky to perform the updates. if that does not work let the user know that there is a new version, code could be very similar. [13:03] TODO: Talk with ralsina about what exactly is needed [13:03] BLOCKED: no, but I need to learn to build the exe [13:03] mandel, esky looks very promising [13:04] alecu, yeah, I think so too :) [13:04] alecu: it means moving a *lot* of stuff around [13:04] * ralsina is nt going to debug that [13:04] oh look a bot, how quaint [13:04] ralsina: moving what? [13:05] ralsina, it uses py2exe let me take a look but I want to know exactly your UI expectations about the link [13:05] alecu: the structure on disk is different [13:05] and yes, that first bug means couchdb should be working in oneiric again [13:05] alecu: which means different registry keys for paths, different paths for launching stuff [13:05] changing a lt of things in the InstallBuilder file [13:05] uh! the doorbell. It must be the new table and chairs. [13:05] * alecu will be back soon [13:05] ralsina, gatox, alecu: wanna share your review request with me? I'll start with that [13:05] nessita: in a moment [13:06] nessita, https://code.launchpad.net/~alecu/ubuntuone-client/dont-log-tokens/+merge/75244 [13:06] AND I said SPRINT people [13:06] ralsina: december? [13:06] December, 5 to 9, Buenos Aires [13:06] ralsina, lets look at it once I'm done with lunch :) [13:06] nessita, i don't have nothing yet... i'm with the no mocker branch :S [13:06] ralsina, I mean the esky thing :P [13:06] ralsina: buenos aires? [13:06] ralsina, fine by me! :P [13:06] simultaneous with ops, web [13:06] ralsina: wans't córdoba? [13:06] ah [13:06] ralsina: sounds good!!! [13:06] nessita: since there's other 2 sprints at the same time in BA... [13:07] right [13:07] is so exciting! [13:07] ralsina: will this time be in capital federal? pretty please? ;-) [13:07] mandel: a bubble in the notification are saying "Dude, there's a new release. Download it", where "Download it" is a link that opens in the browser [13:07] nessita: yes [13:08] ralsina, ok, that is easy then, could be version 1, I need to finish lunch and will get back to this :) [13:08] I will probably stay in the hotel [13:08] mandel: ok, cool [13:08] traveling to capital was not working last time [13:18] ralsina, I'm back! [13:19] mandel: sprint in BA in december, if you missed it ;-) [13:19] ralsina, so, the idea of using esky is that we can update the frozen code and I think we can keep the sctructure that the py2exe uses [13:19] mandel: we already can do that [13:20] mandel: it's what happens when you download and install a new version :_) [13:20] ralsina, oh, coool? the border is going to start looking at me due to the amount ot stamps I have from you guys... [13:20] mandel: I suggest you take a bag or two of powedered milk on the way back, ust for laughs [13:20] ralsina, yeah, but as an auto-update, so we just provide a url with a list with the different versions [13:20] ralsina, mandel: do we have some installer or similar to check if bug #845806 is fixed in my VM? [13:20] Launchpad bug 845806 in ubuntu-sso-client "Windows XP: can't delete current device (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/845806 [13:21] nessita: nope, will have one in a bit [13:21] ralsina: thank you very much! [13:22] dobey: hey, do you know if we have a similar bug report to bug #839718? [13:22] Launchpad bug 839718 in ubuntuone-control-panel (Ubuntu) "ubuntuone control panel icon is not scalable (affects: 2) (heat: 12)" [Undecided,Confirmed] https://launchpad.net/bugs/839718 [13:23] nessita, we did some IRL tests on the build machine from ralsina [13:23] everytime I say this I wish we had a build bot... [13:23] mandel: but not really real [13:23] mandel: right, I would like to tets it as well in my VM [13:24] ralsina, indeed, was more of a test of th lib rather than the full code stack [13:24] nessita: yes i'm sure there is another bug or three about that [13:24] mandel: I did most of what's needed to get tox to create a full development environment in windows in one command. With that, a build bot is "this" close === zyga is now known as zyga-food [13:24] dobey: shall I search or perhaps you have some handy? [13:26] nessita: i don't have any bug #s handy; but i have seen at leat 1 report before [13:26] dobey: thanks, I'll try to find the dupes [13:26] back [13:26] ralsina, haha we could easy write some crazy msi or installer or even better a python script that uses twisted and qt :P [13:27] * alecu 's got a new table and chairs [13:27] mandel: I am trying to do a sane thing ;-) [13:28] alecu: branch looks great! I'm running tests in windows, and then I'll approve [13:29] ralsina, but we do have experience in crazy things.... [13:29] well, I'm back to get cool work done :) [13:29] mandel: yes, but no chihuahua will be harmed in the building of this software (again) [13:30] ralsina, I dont find a README here: lp:~ralsina/ubuntuone-windows-installer/fix_809873 [13:30] ralsina, I might be missing it [13:30] mandel: in scripts [13:30] ok [13:36] mandel: in your response to bug #791888 [13:36] Launchpad bug 791888 in ubuntuone-windows-installer "Change Ubuntu One directory adress in Windows Seven (affects: 1) (heat: 3)" [Undecided,New] https://launchpad.net/bugs/791888 [13:37] mandel: remember the user can't create UDFs outside home, so if his home in under C:, no UDF can be created [13:37] nessita, ah? true [13:37] (in D:_ [13:37] ) [13:38] stupid ? you are nto suppose to be there! [13:38] nessita, I'll add a comment saying I forgot that detail [13:40] mandel: please [13:41] nessita, sorted [13:41] mandel: with quick sort? [13:41] (again? the same bad joke?) [13:41] bubble, always bubble [13:41] :-D [13:41] same answer hehehe [13:41] ralsina: so, when are you going to london? [13:41] nessita, your jokes are getting as bad as mine [13:41] nessita: 10-13 oct [13:41] or so [13:42] ralsina, so, that branch with the fix is that going to land on trunk, just to know if I can base my coe on that [13:42] nessita, dobey, gatox, alecu, mandel sprint page here: https://wiki.canonical.com/OnlineServices/Sprints/U1DesktopDec2011 [13:42] Don't buy tickets yet, though [13:43] mandel: what branch with what fix in the trunk of what? [13:43] ralsina, lp:~ralsina/ubuntuone-windows-installer/fix_809873 [13:43] I hope so! [13:43] ok [13:43] But that branch has no fix for anything, it's just build stuff [13:46] eep a sprint? [13:46] dobey: you are in the sprint, I just mis-copy-pasted your line of the table! [13:46] well at least it's summer there [13:46] well, technically it will be in spring [13:46] true [13:46] You can stay and experience a 30C christmas! [13:46] but BA doesn't have sprint [13:46] err spring [13:46] it has summer, and autumn [13:47] same as where I live, just 6 months off :) [13:47] we have spring! It's next week! (and only next week) [13:48] anyway, meh [13:48] surprise sprint! [13:48] you have 3 months notice! [13:49] but i had no idea you were even thinking about planning a sprint :P [13:49] also [13:49] the reciprocity fee is only good until your passport expires, i believe [13:50] so 10 years if you have a brand new passport, but not so long if it's about to expire :) [13:50] ralsina, in the readme it says that I have to fecth the diff programs, where are does ment to go? same level as the ubuntuone_installer package? [13:50] * ralsina stole that stuff shamelessly from beuno's sprint page [13:50] ah [13:50] mandel: it does it all automatically. I may have to review that README [13:50] mandel: python setup.py fetch [13:51] anyway, i paid it last time, so i'm good for a couple more years [13:51] dobey: cool [13:51] ralsina, oh, cool I though it was manual, nice! [13:51] at least you know you pay and you get in. I had to pay three visas and they are non-refundable if they reject you :-) [13:52] uh, talking about paying.. does anyone know if I need a visa for the USA if my connection flight to BA for PyconAr does a national flight inside the US? [13:54] alecu: approved! [13:54] mandel, probably yes [13:54] nessita, cool, thanks! [13:55] alecu, ouch! [13:55] mandel, do you usually need a visa for the us? [13:55] alecu, yes, but is not hard is just 15 eur, but I hate paper work :P [13:56] mandel, but how long does that take? [13:56] alecu, is on a webpage, so minutes, I'm just agaist giving them 15 eur when I'm not event getting out of the airports... [13:57] ralsina, can you review this: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/err-dict/+merge/75055 (already has nessita approval :D) [13:57] gatox: indíd! [13:58] mandel, they charge argentinians usd 100 (or more!) so consider yourself lucky [13:58] nessita: installer with new keyring -- http://ubuntuone.com/p/1H4I/ [13:58] ralsina: awesome! [13:58] alecu 140 nowadays [13:59] ralsina: double ouch [13:59] mandel: isn't Espana in the VISA Waiver program? [13:59] dobey, yes, but Obama added a new tax for tourists or somthing like that? you bloody comunists! [14:00] alecu, I know I complain for nothing [14:00] ralsina, I'm getting an issue when i do py2exe telling me that qname is not present in the system? why do we need that? and how did you install it? [14:00] qname? [14:01] mandel: can you pastebin it for me? [14:01] ralsina, sure, let me run it again [14:01] mandel: oh right, the entry fee thing [14:02] mandel: anywya, that isn't a visa :) [14:02] that's a tax :P [14:02] ralsina, no worries I go it, PYTHONPATH was wrong [14:02] dobey, that is the one ;) [14:03] mandel: ack [14:03] dobey: "Espana" is not even a word! [14:03] * mandel away for 10 min [14:04] alecu: Espa(n+~)a [14:04] :-) [14:06] dobey: here you go: "ñ". I'm licensing it with CC-BY, so you may make copies and derivatives. [14:07] alecu: make an irssi plug-in that takes (n+~) style strings and transforms them into proper UTF-8 characters :) [14:08] ralsina, we'll be doing the post-pycon mini sprint with mandel at my office, on tue, wed and thu. [14:08] cool, I'll try to be there, unless you guys prefer to be alone ;-) [14:08] ralsina, I'm bringing another desk and chairs so you can join us. [14:09] cool [14:09] when is pyconar? [14:09] dobey: next friday/saturday [14:09] oh [14:14] nessita: updated https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/add_install_option/+merge/74506 with your suggestion of calling the parameter "installing" instead of "installer" [14:15] ralsina: great === zyga-food is now known as zyga === teknico_ is now known as teknico [14:30] ralsina, mandel: device deletion works!!! congrats [14:30] ugh [14:31] nessita: cool! mandel, close the bug with a note to your branch please? [14:31] ralsina: he already did! without asking us! :-D [14:32] nessita: for bug #849494 will you have a branch soon? [14:32] Launchpad bug 849494 in ubuntuone-control-panel (Ubuntu) "Ubuntu One Control Panel still offers Evolution plug-in for contact sync in Oneiric (affects: 1) (heat: 6)" [Medium,Confirmed] https://launchpad.net/bugs/849494 [14:33] nessita: OMG! The NERVE! [14:33] dobey: I still need an answer from Chipaca [14:33] nessita: what answer? which package to install? [14:34] dobey: what we should do about that, we need proper phrasing from r-oberta [14:35] nessita: s/Evolution/Thunderbird/ seems like it is enough for now. problem is string freeze is tomorrow, so we need to get this in today, otherwise we'll need an exception [14:35] nessita: roberta is back [14:35] nessita: so you can ask her :) [14:35] dobey: I agree, I started the pinging already [14:35] ok [14:38] dobey: our plugin does work now with thunderbird *and* evolution, no? since we deal with eds? [14:38] ralsina, sure [14:39] nessita: no; there will be a different thunderbird specific extension for the UI [14:39] dobey: so we have 2 extensions now for contact sync? [14:39] dobey: both are working on O? [14:40] nessita: and evolution-couchdb packaging needs to be split up into two packages still, but the tb extension will pull the right one [14:40] nessita: well 'working' as well as couchdb sync works at the moment. and the tb GUI bits aren't packaged yet [14:40] nessita: so a bit of a mess still :( [14:40] dobey: right, moving this chat next door [14:57] ralsina: ping [14:59] ralsina: when running the installer without the --installer option, I still get the "Congratulations, Ubuntu One is installed!" legend [14:59] ralsina: also, if using the --installer switch, I can't close the window, even if I choose 'yes I want to cancel' [15:00] ralsina: need a screencast? [15:00] lunch, bbiab [15:03] nessita: let me check, maybe merging trunk broke something [15:05] nessita: no screencast needed [15:06] nessita: I had not noticed that page said "ubuntu one is installed" [15:06] I will hide that [15:06] nessita: but you don't get the license page without --installer, right? [15:06] ralsina: I don't [15:07] nessita: ok, I'll fi that [15:07] fix* [15:07] and yes, using --installer from a non-installed thing means cancelling on that first screen is broken [15:07] nessita: since it can't start the uninstaller [15:14] nessita: fixed the message in revno 61, added assert for it [15:20] nessita, please take a look at my comment: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/847796/+merge/75158 [15:20] ack [15:21] ralsina, nessita when you have a minute: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/75172 [15:22] gatox: can you bign the bug report to that branch? [15:23] nessita, yes [15:26] nessita, done [15:28] nessita, ralsina this branch (for a critical bug) is ready: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/name-required/+merge/75366 also i manage to avoid skipping the test and the test don't fail now [15:28] gatox: awesome! [15:28] I have to leave for a doctor's appointment in 30 minutes, should be back in 2 hours and catch up on reviews then [15:33] ralsina, ok, good luck [15:35] nessita, ralsina this branch is ready too: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/err-dict/+merge/75001 [15:35] it feels nice to be unblocked :P [15:36] hehe [15:42] gatox, that's what activia customers say. [15:43] alecu, jejejejejeje [15:43] alecu, good one! [15:43] alecu, mandel, gatox, nessita: (ok, just two of you ;-) https://code.launchpad.net/~ralsina/ubuntuone-control-panel/you-have-two-options/+merge/75371 [15:44] ralsina, on it [15:54] I am off to the doctor, should be back in 90 minutes. gatox, mandel, if you EOD before that, please mail me review requests? [15:54] ralsina, ok [15:55] gatox: and if you EOD before 3 we need to talk ;-) [15:55] ralsina, jejeje [16:09] ack [16:23] oi [16:29] oi oi [16:35] EOD for me, hopefully tom is more productive, laters! [16:37] mandel, bye [17:19] ralsina, nessita more branches for review (this branches are related): https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/845759/+merge/75385 - https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845759/+merge/75384 [17:21] lolpython [17:24] j`ey: ok? [17:40] gatox: did you see the needs fixing here? https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/name-required/+merge/75366 [17:41] nessita, nop...... fixing [17:41] gatox: in err-dict, there is no need to add pass in this line: [17:41] 133+ pass [17:43] nessita, ok..... removing that [17:47] nessita, fixed both branches [17:47] nessita: this is why automated builds of u1client aren't being requested, btw: https://lp-oops.canonical.com/?oopsid=OOPS-2083J68 [17:47] https://lp-oops.canonical.com/oops.py/?oopsid=2083J68 [17:48] dobey: looking [17:49] dobey: limit of what exactly is being exceeded? [17:49] nessita: no idea. and no answer yet on #launchpad-dev :-/ [17:50] dobey: oh ok, let me know :-) [17:51] nessita: maybe there is a cumulative maximum of 1000 build requests for each user? :( [17:56] dobey: that would be... complicated for us [17:56] yeah i hope that isn't it [18:05] EOD for me!! see you tomorrow [18:08] elopio: when you have a chance, can you please re-review https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/name-required/+merge/75366? thanks! [18:15] nessita, done. [18:15] elopio: that was fast! thanks [18:17] nessita, but I just checked the label, I haven't checked that it actually works. I'm currently setting up my development environment on windows to help testing the branches. [18:17] elopio: that's nice :-) [18:17] I will check it works [18:57] finally back! [18:58] damn doctor and his insistence that I have to get "tests" to see if I am "sick" [19:02] ralsina: you can't make the tests pass if you don't first make them fail [19:03] That's what I said! He has TDD completely backwards! [19:03] That's *totally* not going to improve me as a product! [19:03] gatox: reviews! Point me! [19:05] ralsina, wait.... looking... [19:06] lol [19:07] ralsina, jejeeejjeje House MD made TDD... he tried a lot of things, almost destroy the person.... and then....... he cure them jeje [19:07] gatox: nah, that' sloppy hacking [19:07] :P [19:08] gatox: TDD would be: give the patient colchicine. He doesn't improve. Give uric acid to the patient until he develops gout. There, the colchicine cures gout. SUCCESS, test pass! [19:08] jejejeje [19:09] ralsina, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/err-dict/+merge/75055 - https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845759/+merge/75384 - https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/845759/+merge/75385 - (this one is ok the code, i just need to improve some tests): https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/7517 [19:09] 2 - https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/err-dict/+merge/75001 - https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/name-required/+merge/75366 [19:09] ralsina, oh.... one link is broken: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/75172 [19:10] ralsina, Have fun! :P [19:10] gatox: ok! [19:10] ralsina, except one that is just improve some tests, all the need fixing are fixed [19:10] gatox: u1cp has no tests for main [19:11] ralsina: it should have! [19:11] gatox: but +1 on getting in touch with your inner natalia! [19:11] ralsina, jejeje [19:11] ralsina: if we're making that class more complex, we should start adding tests to it [19:11] alecu: can I have a review foe https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/better-setup-account-button/+merge/75403 ? [19:12] ralsina: I agree with gatox, we need tests for those changes. I can help if you need. [19:12] nessita: it's ok, I can do them [19:12] nessita: it's a pain because all the logic is inside a function that installs a reactor, though, so some refactoring will be involved [19:13] ralsina: can't we just patch the reactor with a dummy object? [19:13] self.patch(main.windows, 'qt4reactor', DummyReactor) [19:13] and magic? [19:13] nessita, no because the import is inside main() :-) [19:13] So I will move the import into a function that returns reactor and patch that [19:14] ralsina: we can patch qt2reactor [19:14] ralsina: we can patch qt4reactor [19:14] self.patch(qt4reactor, 'qt4reactor', DummyReactor) [19:14] ? [19:14] nessita: could work [19:14] or passing the reactor as param [19:15] reactor as param means another function that will have the same problems. Don't worry, I'll figure it out, I did the same thing for u1-installer [19:15] don't lie [19:15] u1-windows-installer [19:16] u1-windows installer is one u1-installer. Don't discriminate ;-) [19:18] gatox: +1 on err-dict [19:18] ralsina, thanks [19:25] gatox: err-dict looks good, I will tets it IRL after a reboot the machine (is acting up) [19:25] can i get a review on https://code.launchpad.net/~dobey/ubuntuone-installer/translate/+merge/75408 please? [19:28] ralsina: do you know this place? https://twitter.com/#!/ian_all_over/status/114035403870314497 [19:28] dobey: yes [19:28] dobey: it's nice [19:29] dobey: slightly touristy, but that's normal for Sa Telmo [19:29] ah [19:29] ralsina: do we have hotel yet? [19:29] dobey: yes [19:29] dobey: kinda ;-) [19:29] so no ;) [19:30] I only started putting this together today, but we have a hotel for the other two sprints. If there's no room in it, they promised they have room in another hotel two blocks away [19:31] oh. there are two more sprints at same time in BA? [19:33] dobey: pretty much everyone will be here. web+mobile and ops [19:33] oh [19:34] full on party then [19:34] ahem, serious work! [19:35] planning party of course [19:35] you know, like planning poker [19:35] he [19:36] care to review https://code.launchpad.net/~dobey/ubuntuone-installer/translate/+merge/75408 ? it is pretty trivial, and i need to make an upload/release with it today [19:36] * nessita is back [19:37] dobey: can you please review? https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/evo-thunderbird/+merge/75410 [19:38] nessita: did we get approval for that? i was just switching to evolution to check my bug mail on that :) [19:38] dobey: not yet, I will not land it until we do [19:38] dobey: but I wanted to "buy" some time by having that ready [19:38] dobey: besides, the release team evaluates the patch, when approving, no? [19:38] the "diff" I mean [19:39] nessita: release team looks at uploads to ubuntu, not upstream merge proposals [19:39] true [19:39] dobey: sure [19:39] oh nice [19:40] chris split the evolution-couchdb package [19:40] i'll have to do that for nightlies [19:40] dobey: +1 trivial. Of course it'sup to you to check there are no *other* strings you should mark. [19:40] gatox: +1 on name-required conditional on nessita's needsfixing [19:41] ralsina, great [19:41] ralsina: well the .desktop is already set up for translation, and there's only one .py file, so i think i'm good :) [19:42] dobey: good to know :-) [19:46] gah, stop confirming the fixed bug is fixed. we know it's fixed! [19:48] dobey: we do? [19:48] meh, and i don't need /more/ comments/screenshots showing me the bug that's already filed [19:48] nessita: i am venting. :) [19:48] ah! [19:53] gatox: you still around? [19:54] nessita, yep.... about to go teaching :P but do you need something? [19:54] gatox: no, I just reported a new bug for the wizard... the setup button is enabled even if the passwords dont match [19:54] gatox: will appear in your queue [19:55] nessita, ok..... and weird :S [20:08] alecu: ping [20:08] ugh my shoulder is killing me [20:10] dobey: CALL 911! [20:10] :-D [20:12] ralsina: ping [20:13] nessita: pong [20:13] ralsina: is lp:~ralsina/ubuntuone-windows-installer/add_install_option ready for re-review? can the wizard be closed when looking at the license page now? [20:13] nessita: yes, ready for re-review [20:14] ack, looking [20:14] the not closed when looking at the license page: you are not supposed to do that unless it's installing :-) [20:14] it fails when you try it because it can't find the uninstaller [20:32] where do I get the windows client? [20:35] GTRsdk: it will be available here eventually: https://one.ubuntu.com/downloads/ [20:53] ralsina: still around? care to review https://code.launchpad.net/~dobey/ubuntuone-installer/cache-fallback/+merge/75425 too? :) [20:53] it's easy [20:53] dobey: sure! [20:54] gatox, nessita: https://code.launchpad.net/~ralsina/ubuntuone-control-panel/you-have-two-options/+merge/75371 is ready for review [20:55] I am slightly unhappy about where the start function is located, so I can change that if needed. [20:55] ack [20:58] dobey: +1 [20:59] ralsina: approving install option [20:59] nessita: cool, thx! [21:00] ralsina: I will review the bug queue tomorrow first time [21:00] ralsina: the bug list you asked by email, I mean [21:00] nessita: cool, I think we are in good shape, except I have no idea where manuel is with the updater [21:01] damn damn damn filenames [21:01] ralsina: we should ping him tomorrow early ART... from what I read the work was not that advanced [21:01] :-/ [21:01] ralsina: also, I need to know about alecu [21:01] but I've been pinging him with no luck for now [21:01] weird [21:01] alecu: you around? [21:01] yup [21:01] alecu: I've been pinging you for a while now :-) [21:02] my connection has been up and down for a while now [21:02] alecu: oh, bad luck [21:02] alecu: I was eoding, but I wanted to know about your news/updates [21:02] nessita, ralsina: I'm hitting a lot of rocks with the unicode usernames [21:02] alecu: wanna mumble before I eod? [21:02] I'm interested too [21:03] nessita, ralsina: sure [21:35] * nessita -> eods [22:35] have a good evening all [22:36] dobey: good evening!