| Droopsta915 | Hello. Im trying to create an account but it keeps showing red exclamation points when i enter my email. Any ideas why? | 01:57 |
|---|---|---|
| JamesTait | Bonjour, tout le monde! | 08:32 |
| clem-l | cparrino: Hi Cristian, are you available? | 08:35 |
| * mandel quick coffee | 09:18 | |
| * mandel back | 09:47 | |
| * mandel away due to system updates | 09:49 | |
| ralsina | mandel: ping | 10:10 |
| mandel | ralsina, pong | 10:19 |
| ralsina | hi mandel | 10:19 |
| mandel | ralsina, hola! | 10:19 |
| ralsina | mandel: I am not sure I understand where you are going with the updater | 10:19 |
| mandel | I had to reboot the machine.. I hate updates :P | 10:19 |
| mandel | ralsina, oh, is very simple I'm writing some methods to use the following: http://installbuilder.bitrock.com/docs/installbuilder-userguide/ar01s21.html | 10:20 |
| mandel | ralsina, with that we can check if there is an update or not and later tell InstallBuilder to download and install the update | 10:20 |
| mandel | ralsina, I'm just trying atm to get my head around building the update with InstallBuilder, the code is done | 10:21 |
| ralsina | ok | 10:21 |
| mandel | ralsina, I think i sthe best thing to do, right? that way we do not have to change paths etc.. | 10:22 |
| ralsina | have you seen this working? How does it look? | 10:22 |
| ralsina | mandel: I was aiming for a trivial solution. This looks good, but remember deadline is today :) | 10:22 |
| mandel | ralsina, yes, I'm working as fast as I can to get it for you after my lunch so that we can build it :) | 10:23 |
| ralsina | and this actually is a wizard with multiple steps and stuff. Hopefully the UX is not complicated | 10:23 |
| mandel | ralsina, not in minimal mode? I hope | 10:24 |
| ralsina | ok | 10:24 |
| mandel | that ? was 3 dots puto xchat! | 10:24 |
| ralsina | it's ok, I don't mind the ? :-) | 10:25 |
| ralsina | mandel: ok, good luck and if you need a hand with anything just ping me, I will be working in about 1 hour | 10:28 |
| mandel | ralsina, ok | 10:29 |
| mandel | ralsina, do you know in the IstallerBuild UI how to pass variables to the build process? | 10:35 |
| ralsina | mandel: like what? | 10:35 |
| mandel | ralsina, I'm using a write action in the insall builder operation and I added a var ${update_xml_url} which is the one that point to the xml in ourserver with the updates | 10:36 |
| mandel | ralsina, I dont know how to pass that in the build step :P | 10:36 |
| ralsina | you can just put the URL there, it won't change too often | 10:37 |
| ralsina | or: http://support.bitrock.com/article/how-to-set-variables-at-build-time | 10:38 |
| ralsina | and maybe add a "build installer" step to setup.py so we have things in only one place | 10:39 |
| mandel | ralsina, that sounds like the best option, once I'm done I'll test locally with my local host if it works I'l ping you and beuno on what to do in the servers side | 10:39 |
| mandel | is very simple :) | 10:39 |
| * ralsina is scared, mandel said "simple"! | 10:41 | |
| mandel | ralsina, nah, it means some xml and the files in the same location | 10:58 |
| mandel | ralsina, no more, we can ignore automating it atm | 10:58 |
| ralsina | ok | 10:58 |
| mandel | ralsina, oh, but it has to be written in COBOL :P | 11:00 |
| ralsina | ok, I am going to do dad things now, will be back in one hour | 11:01 |
| mandel | ralsina, I'm of to walk the dog :P | 11:01 |
| nessita | hello crowd! | 11:14 |
| nessita | gatox, mandel: hello, how is it going? | 11:28 |
| gatox | nessita, fine! fixing some tests | 11:29 |
| karni | duanedesign: ping | 11:30 |
| nessita | gatox: so, no need for me to review anything right now? | 11:31 |
| gatox | nessita, yes..... let me give yoy | 11:32 |
| gatox | you | 11:32 |
| duanedesign | hello karni | 11:32 |
| gatox | nessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/err-dict/+merge/75001 - https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/845759/+merge/75385 | 11:33 |
| karni | duanedesign: what do you use to edit audio file tags, easytag? | 11:34 |
| nessita | gatox: errdict approved after your response | 11:35 |
| gatox | nessita, ok! | 11:36 |
| duanedesign | karni: yes easytag or i just use Banshee | 11:36 |
| karni | duanedesign: k tnx | 11:36 |
| karni | :) | 11:36 |
| nessita | mandel: ping | 11:38 |
| duanedesign | karni: https://pastebin.canonical.com/52827/ <--do not know if this helps you at all. This is what I start with if a user needs to edit tags to properly use the music sctreaming | 11:39 |
| duanedesign | streaming* | 11:39 |
| nessita | gatox: did you got my review request? | 11:40 |
| gatox | nessita, did you send it to canonical o gmail? | 11:40 |
| nessita | gatox: canonical, I'm trying to stop sending you work emails to gmail :-) | 11:41 |
| gatox | nessita, here it is | 11:42 |
| karni | duanedesign: right, thanks. by the way, why do we expect all (all?) tag data to be filled. I think that's pretty messy. I would like to stream even files that have no metadata at all (like, a self recorded file, for instance). Do you know any background of the story? | 11:42 |
| * gatox reviewing... | 11:42 | |
| nessita | gatox: no hurry | 11:43 |
| rye | duanedesign, byyy the way, yes, I had a question about this too and beuno said that we stream untagged files too, but they are marked as untitled or something like this | 11:47 |
| nessita | mandel: dude, where is my car? | 11:50 |
| duanedesign | rye: that is the way I understand it. | 11:51 |
| duanedesign | and it seems not all music comes tagged properly | 11:53 |
| rye | checking.... | 11:54 |
| === zyga is now known as zyga-food | ||
| nessita | mandel: can you mumble pliz? | 12:08 |
| ralsina | good morning! | 12:12 |
| nessita | hi ralsina | 12:19 |
| ralsina | hi nessita | 12:19 |
| ralsina | nessita: bug #827465 we have been fixing it in bits and pieces, but a lookaround is needed | 12:20 |
| ubot4 | ralsina: Error: Bug #827465 not found. | 12:20 |
| ralsina | ubot4: you are full of crap | 12:20 |
| ubot4 | ralsina: Error: I am only a bot, please don't think I'm intelligent :) | 12:20 |
| nessita | ralsina: can you do that with a grep or similar? | 12:20 |
| ralsina | nessita: I am not sure I can figure that out of a grep | 12:21 |
| ralsina | specially since on Linux we do use "Control Panel" and such | 12:21 |
| nessita | ralsina: any other idea how to confirm if it's fixed or not? | 12:24 |
| ralsina | nessita: nope, just looking. I will do it starting in 15 minutes | 12:24 |
| nessita | great! | 12:24 |
| ralsina | we *could* check translation strings? | 12:24 |
| ralsina | nessita: the only qt part that is not working on Linux is SSO, right? | 12:25 |
| nessita | ralsina: I'm not sure we mark titles for translation... besides, we need to review the bundle script as well, no? | 12:25 |
| nessita | ralsina: sso-qt + wizard | 12:25 |
| ralsina | yes, but the bundle has little to no UI outside windows-installer | 12:25 |
| ralsina | the wizard should be almost there for linux if sso imported correctly | 12:26 |
| nessita | gatox: 845759 approved | 12:26 |
| gatox | nessita, nice | 12:26 |
| popey | Hullo! | 12:41 |
| popey | Is there some php code I could look at which demonstrates or otherwise shows how to implement a site which uses Ubuntu SSO for auth? | 12:41 |
| popey | the only ones I've seen are python based | 12:41 |
| ralsina | popey: I don't know but I am trying to find out for you :-) | 12:47 |
| popey | thanks | 12:48 |
| === zyga-food is now known as zyga | ||
| nessita | gatox: ping | 12:54 |
| gatox | nessita, this branches are ready too: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845759/+merge/75384 - https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/75172 | 12:54 |
| gatox | nessita, pong | 12:54 |
| nessita | gatox: why did you change the if-if-if in name-required to if-elif-elif..? | 12:54 |
| nessita | gatox: shouldn't we show everything that is incorrect at the same time? | 12:55 |
| gatox | nessita, i thought that was better, or maybe i'm missing something.... | 12:55 |
| nessita | gatox: maybe I'm missing something | 12:55 |
| nessita | :-) | 12:55 |
| gatox | nessita, please can you tell me the line..... to look at it | 12:55 |
| gatox | in which branch...... | 12:55 |
| nessita | ubuntu_sso/qt/controllers.py -> validate_form | 12:56 |
| nessita | gatox: name-required | 12:56 |
| gatox | nessita, well..... if you see the code that was there previously... after calling message_box.critical(...), all of them do: return False, so i though that if-if-if-if was unnecessary | 12:57 |
| gatox | nessita, also, in each call to message_box.critical, the previous message is erased (which in some cases can be a problem) | 12:58 |
| gatox | nessita, i think.. | 12:59 |
| nessita | hum | 12:59 |
| nessita | then we should concatenate all the messages and call a single critical? | 12:59 |
| mandel | me | 13:00 |
| gatox | nessita, now that i read that again...... i'm seeing that: NAME_INVALID, EMAIL_INVALID and EMAIL_MISMATCH...... shouldn't be there..... they should be in the label assistance next to the proper line edit | 13:00 |
| gatox | nessita, and maybe we can concatenate the others | 13:01 |
| nessita | gatox: but that's sso, does that apply there as well? | 13:01 |
| nessita | me | 13:01 |
| gatox | me | 13:01 |
| gatox | nessita, didn't understand the last messate | 13:01 |
| gatox | message | 13:01 |
| nessita | gatox: let's talk after the stdup | 13:02 |
| gatox | nessita, ok | 13:02 |
| nessita | ralsina, dobey, alecu? | 13:02 |
| dobey | que pasa, seniora?! | 13:02 |
| ralsina | me (no notes) | 13:02 |
| dobey | me | 13:02 |
| mandel | shall we start? | 13:03 |
| ralsina | go | 13:03 |
| gatox | mandel, go :P | 13:03 |
| mandel | DONE: Create auto-update branch using the code generated by bitrock, added changes to u1-instaler to check for updates at boot time. | 13:03 |
| mandel | TODO: IRL closely to ensure update works as expected. Add some missing tests. | 13:03 |
| mandel | BLOCKED: no | 13:03 |
| mandel | next: nessita | 13:03 |
| nessita | DONE: more bug triage and bug follow up, tackled bug #850142, bug #849494, reviews, talk with alecu re bug #846373 | 13:04 |
| nessita | TODO: more reviews, team chasing to meat the deadline of second windows release today | 13:04 |
| nessita | BLOCKED: nopes | 13:04 |
| nessita | NEXT: dobey | 13:04 |
| ubot4 | Launchpad bug 850142 in ubuntuone-control-panel (Ubuntu) (and 1 other project) "UI Freeze exception: Remove the Bookmarks section from the Services tab (affects: 1) (heat: 10)" [High,Triaged] https://launchpad.net/bugs/850142 | 13:04 |
| ubot4 | Launchpad bug 849494 in ubuntuone-control-panel (Ubuntu) (and 1 other project) "String freeze exception: still offers Evolution plug-in for contact sync in Oneiric (affects: 1) (heat: 8)" [Medium,Triaged] https://launchpad.net/bugs/849494 | 13:04 |
| ubot4 | nessita: Error: Bug #846373 not found. | 13:04 |
| nessita | sorry, NEXT: gatox | 13:04 |
| gatox | DONE: | 13:04 |
| gatox | Fixed some proposed branches. | 13:04 |
| gatox | TODO: | 13:04 |
| gatox | Finish with some high ui bugs. | 13:04 |
| gatox | BLOCKED: | 13:04 |
| gatox | No | 13:04 |
| gatox | ralsina go | 13:04 |
| ralsina | DONE: reviews, few fixes, IRL testing, bug triaging, doctor appointment, turned 40. TODO: close code for release, send for signing BLOCKED: no | 13:04 |
| alecu | morning... | 13:04 |
| dobey | λ DONE: bug #843002, bug #849308, bug #840072 | 13:04 |
| dobey | λ TODO: FFE for devtools, bug people about TB extension, bug #838778, get stuff off CD | 13:04 |
| ubot4 | Launchpad bug 843002 in ubuntuone-installer (Ubuntu) (and 3 other projects) "Crashes when "For Purchase" apps have been installed (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/843002 | 13:04 |
| dobey | λ BLCK: None. | 13:04 |
| ubot4 | Launchpad bug 849308 in s25rttr/s25client (and 1 other project) "multiplayereinstellung (affects: 1) (heat: 6)" [Undecided,Confirmed] https://launchpad.net/bugs/849308 | 13:04 |
| ubot4 | Launchpad bug 840072 in ubuntuone-installer (Ubuntu) (and 1 other project) "Installer needs to install more packages (affects: 2) (dups: 1) (heat: 14)" [Medium,Confirmed] https://launchpad.net/bugs/840072 | 13:04 |
| ubot4 | Launchpad bug 838778 in ubuntuone-control-panel (Ubuntu Oneiric) (and 2 other projects) "After installing Ubuntu One, there are 2 Ubuntu One launchers in System Settings (affects: 45) (dups: 11) (heat: 202)" [High,Triaged] https://launchpad.net/bugs/838778 | 13:04 |
| dobey | alecu: go | 13:04 |
| alecu | "doctor appointment, turned 40" LOL | 13:04 |
| ralsina | hey, it took me YEARS to turn 40 | 13:05 |
| nessita | alecu: hi there! go when your notes are ready | 13:05 |
| alecu | DONE: got a messy branch running with accented username | 13:05 |
| mandel | ralsina, happy bday, nice passive aggresive DONE hehe | 13:05 |
| alecu | TODO: write some tests and land | 13:06 |
| nessita | alecu: I'm dying to know how the thingy went | 13:06 |
| alecu | BLOCKED: no | 13:06 |
| gatox | ralsina, hey!!!! happy birthday!! | 13:06 |
| * mandel lunch | 13:06 | |
| ralsina | thanks everyone, you are all invited to a b-day party tomorrow. It's easy because only alecu could possibly attend :-) | 13:06 |
| gatox | jejeje | 13:06 |
| nessita | ralsina: happy birthday! | 13:06 |
| nessita | alecu: so, there are 3 bugs reports that your should attach/fix in your branch: | 13:07 |
| nessita | alecu: the known bug #846373 | 13:07 |
| ubot4 | nessita: Error: Bug #846373 not found. | 13:07 |
| dobey | ralsina: feliz cumpleanos | 13:07 |
| nessita | alecu: plus bug #818197 and bug #827435 | 13:07 |
| ubot4 | Launchpad bug 818197 in ubuntuone-client "Handle encoding of the options returned by ConfigGlue (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/818197 | 13:07 |
| ubot4 | Launchpad bug 827435 in ubuntuone-client "Windows: calling os.access with a bytes sequence (affects: 1) (heat: 19)" [High,Triaged] https://launchpad.net/bugs/827435 | 13:07 |
| alecu | dobey, hey, use the ñ! | 13:07 |
| ralsina | is ubot4 broken for private bugs or he just loses random ones? | 13:07 |
| dobey | alecu: what is the hex utf-8 code? | 13:07 |
| ralsina | dobey: yes, use alecu's! | 13:08 |
| ralsina | dobey: copy/paste it :-) | 13:08 |
| nessita | alecu: they are all assigned to you, let me know if that's ok/makes sense | 13:08 |
| beuno | ralsina, it's a public channel, so he doesn't have access to proviate bugs | 13:08 |
| dobey | a(n+~)os | 13:08 |
| ralsina | beuno: he used to say "is private" | 13:08 |
| beuno | ah | 13:08 |
| dobey | ralsina: looks broken | 13:09 |
| alecu | dobey, the hex utf-8 code is "c3 b1" | 13:10 |
| alecu | dobey, but you are probably asking for the hex UNICODE, which is "f1" | 13:10 |
| dobey | 쎱 | 13:10 |
| dobey | no it isn't | 13:10 |
| dobey | ñ | 13:10 |
| alecu | dobey, yes, it is | 13:10 |
| === zyga is now known as zyga-afk | ||
| dobey | oh right | 13:12 |
| dobey | f'n gnome | 13:12 |
| ralsina | and I am pretty sure he failed with a public bug before... bug #827465 | 13:12 |
| ubot4 | ralsina: Error: Bug #827465 not found. | 13:12 |
| nessita | gatox: so, let's talk about name-required | 13:12 |
| dobey | ralsina: i think the bot is not authenticated | 13:13 |
| gatox | nessita, can you mumble for a while about your branch and about name-required too? | 13:13 |
| nessita | gatox: yes! | 13:13 |
| dobey | ralsina: seems private bugs give a 404 for anonymous users | 13:13 |
| ralsina | dobey: that bug is public | 13:13 |
| nessita | gatox: I'm there | 13:13 |
| nessita | alecu: wanna mumble after gatox's to do some follow up on your bugs? | 13:13 |
| dobey | ralsina: if i open https://launchpad.net/bugs/827465 in chrome (where i'm not logged in), i get a 404 | 13:14 |
| ubot4 | dobey: Error: Bug #827465 not found. | 13:14 |
| dobey | ralsina: and it is NOT public | 13:14 |
| ralsina | ugh, right | 13:14 |
| * dobey sees red private bar at top of page | 13:14 | |
| ralsina | was scrolled :-P | 13:14 |
| dobey | it's watermarked! | 13:14 |
| alecu | nessita, sure | 13:14 |
| ralsina | The red bar appears about 15 seconds later than the page here for some reason | 13:15 |
| nessita | alecu: when you're ready, let me know, I'm there | 13:15 |
| dobey | hrmm | 13:16 |
| dobey | it seems the bot in #ubuntu-desktop just doesn't do anything when i pasted the bug # there | 13:16 |
| dobey | ralsina: the bug issue is apparently because LP changed at some point to return a 404 rather than a bug with no real info | 13:25 |
| ralsina | dobey: ack | 13:25 |
| nessita | alecu: ready when you are | 13:26 |
| ralsina | nessita: updated bug 827465 -- right now, the only "wrong" thing is "Ubuntu One client" on the firewall alert. | 13:47 |
| ubot4 | ralsina: Error: Bug #827465 not found. | 13:47 |
| nessita | ralsina: can we fix? | 13:48 |
| ralsina | nessita: I have no idea where that is coming from, am on it | 13:48 |
| * ralsina is guessing syncdaemon | 13:49 | |
| mandel | ralsina, ping | 13:55 |
| ralsina | mandel: pong | 13:55 |
| mandel | ralsina, since when do we have to restart the machine after an uninstall? | 13:55 |
| ralsina | mandel: if the processes are running | 13:55 |
| ralsina | mandel: it's automatic | 13:55 |
| mandel | ralsina, oh, makes sense, ok :) | 13:56 |
| alecu | ralsina, that looks like the .exe metadata that is set in py2exe | 13:56 |
| ralsina | alecu: could be, I am trying to figure out what exe is the one asking for the exception to be sure | 13:56 |
| ralsina | alecu: confirmed, it's setup.py | 13:57 |
| ralsina | gatox, nessita: I really need reviews here, because I have to do another (tiny) branch after this one https://code.launchpad.net/~ralsina/ubuntuone-control-panel/you-have-two-options/+merge/75371 | 14:03 |
| gatox | ralsina, on it | 14:03 |
| ralsina | gatox: thanks | 14:04 |
| nessita | ralsina: branching | 14:05 |
| ralsina | nessita: thanks | 14:06 |
| * mandel hates the fact that he updatd his OS? it does not work at all :( | 14:13 | |
| mandel | ralsina, ping | 14:19 |
| ralsina | mandel: pong | 14:22 |
| nessita | ralsina: ping | 14:23 |
| ralsina | nessita: pong | 14:23 |
| nessita | ralsina: is there any need to have the from ubuntuone.controlpanel.gui.qt.gui import MainWindow inside start()? | 14:23 |
| ralsina | nessita: yes, it installs a reactor | 14:23 |
| gatox | ralsina, +1 | 14:24 |
| nessita | sure? | 14:24 |
| * nessita browses | 14:24 | |
| ralsina | nessita: yep, move it outside and you will see :-) | 14:24 |
| ralsina | I have no idea where it's installed, but it is | 14:24 |
| mandel | ralsina, I'm getting a runtime error (probabyl related with py2exe) with lp:~mandel/ubuntuone-windows-installer/auto_update, do you have time to make a package | 14:24 |
| ralsina | mandel: sure | 14:24 |
| ralsina | mandel: I am actually doing one :-) | 14:24 |
| ralsina | Want me to do it with your branch, of course? | 14:24 |
| nessita | ralsina: can you please remove the 24 from ubuntuone.controlpanel.logger import setup_logging import, the logger definition that is not used, and move the import out? | 14:25 |
| mandel | ralsina, yes :D | 14:25 |
| mandel | ralsina, that would be perfect | 14:25 |
| ralsina | nessita: sure, let me try it | 14:25 |
| ralsina | mandel: in 2' | 14:25 |
| mandel | ralsina, thx, I'm rebuilding mine to see if there was an error in the steps.. | 14:26 |
| ralsina | nessita: sorry, what import is that? It's not on the diff? | 14:27 |
| gatox | ralsina, nessita alecu mandel i've to go to the bank right now... brb (is quick), i have 5 branches for review if anyone has some time... some of them already has nessita's approval | 14:27 |
| nessita | ralsina: nopes, not in the diff | 14:27 |
| ralsina | nessita: what file? | 14:28 |
| nessita | ralsina: in ubuntuone/controlpanel/gui/qt/gui.py | 14:28 |
| ralsina | gatox: will start onthem right after I'm done with mandel | 14:28 |
| gatox | ralsina, thanks | 14:28 |
| ralsina | nessita: with that change I get a circular import | 14:31 |
| ralsina | nessita: let me merge trunk and see if it helps | 14:31 |
| nessita | ralsina: right, I think ytou need to move start to ubuntuone/controlpanel/gui/qt/gui.py | 14:32 |
| nessita | makes more sense? | 14:32 |
| ralsina | sure | 14:32 |
| nessita | ralsina: next question: what's the point in returning the icon and the windows in start()? if I read main() correctly, those are not being used | 14:34 |
| ralsina | nessita: if I don't keep a referencec the garbage collector takes them away | 14:35 |
| ralsina | when they go out of scope | 14:35 |
| nessita | they do? | 14:35 |
| ralsina | yep | 14:35 |
| ralsina | standard behaviour | 14:35 |
| nessita | ralsina: what's the symptom? | 14:35 |
| ralsina | that the window never appears, because the object is deleted when start ends :-) | 14:36 |
| nessita | sounds odd, but I trust you | 14:37 |
| mandel | ralsina, I'm getting the following issue when I run my .exe: http://paste.ubuntu.com/690038/ | 14:37 |
| mandel | :( | 14:37 |
| ralsina | nessita: easy to test, don't keep the reference in main and try to run it | 14:37 |
| nessita | mandel: are you using a clean env? | 14:37 |
| ralsina | mandel: why is it using storage-protocol from the env? it should get its own copy | 14:38 |
| ralsina | mandel: did you run python setup.py prepare? | 14:39 |
| mandel | ralsina, yes, the command I used was: python setup.py fetch prepare py2exe | 14:40 |
| mandel | nessita, in theory the setup.py taks care of that | 14:41 |
| ralsina | mandel: no idea then | 14:41 |
| ralsina | mandel: what were you doing to get that error? | 14:41 |
| mandel | ralsina, ok, let me know if you finished creating the package | 14:41 |
| ralsina | mandel: in a little bit | 14:41 |
| mandel | ralsina, just running ubuntuone-windows-installer-qt and stderr gets that | 14:41 |
| ralsina | mandel: could be just a missing file in your library.zip but the path worries me | 14:42 |
| mandel | ralsina, yes, I have the same feeling | 14:42 |
| mandel | ralsina, lets see if its my env and not the code perse | 14:43 |
| ralsina | ok | 14:43 |
| mandel | although I changed nothing but adding an extra file and 2 functions.. | 14:43 |
| ralsina | mandel: branching, will have something to say in 5 minutes or so | 14:43 |
| mandel | ralsina, superb, I'll be waiting | 14:43 |
| ralsina | mandel: it's your environment | 14:53 |
| mandel | ralsina, cool! | 14:53 |
| ralsina | in mine it works. Building installer now | 14:53 |
| mandel | ralsina, great, please share with me the installer :) | 14:54 |
| mandel | ralsina, did you use the ui or the command line to build it? | 14:54 |
| ralsina | mandel: both, depending on the moment | 14:55 |
| ralsina | mandel: so, I builder-cli build ubuntuone.xml | 14:55 |
| ralsina | mandel: do I have to do something else | 14:55 |
| mandel | ralsina, you have to pass the versionID but dont worry I can manually change the update.ini for the test, not big eal | 14:56 |
| mandel | s/eal/deal | 14:56 |
| ralsina | mandel: tell me what to do then | 14:56 |
| mandel | ralsina, its in the REAME :) | 14:56 |
| mandel | ralsina, but dont worry in excess right now | 14:57 |
| ralsina | mandel: since it takes 30 minutes to upload one, I better do it right the first time! | 14:58 |
| mandel | ralsina, ein? to upload where? | 14:59 |
| ralsina | mandel: anywhere for you to get it | 14:59 |
| mandel | ralsina, really? 30 min | 15:00 |
| mandel | wow! | 15:00 |
| ralsina | mandel: more or less | 15:00 |
| mandel | ralsina, whats your upload limit? | 15:00 |
| ralsina | like 256kbps or 512, I don't know | 15:00 |
| mandel | ok, I'll try to find the issue in my env | 15:01 |
| ralsina | mandel: it tells me I don't have a update.ini | 15:02 |
| mandel | but the update.ini is generted by the installer | 15:02 |
| mandel | ralsina, weird, wich revno do you have? | 15:02 |
| ralsina | mandel: 69 | 15:03 |
| mandel | ralsina, can you look at like 23 of the xml, there is where it creates the ini | 15:03 |
| mandel | ralsina, may I see the error | 15:03 |
| mandel | ?? | 15:03 |
| ralsina | looking | 15:04 |
| ralsina | mandel, it tells me I don'thave a install.ini when I try to build the installer using build-cli, did you try that? | 15:04 |
| ralsina | builder-cli* | 15:05 |
| mandel | ralsina, no, to be hones I used the UI and changed the vars manually... | 15:06 |
| mandel | ralsina, can you try with the UI, if that is an issue I can add the install.ini | 15:06 |
| ralsina | mandel: just fix the variable in the file and push it | 15:07 |
| ralsina | there is no point on that being in the command line | 15:07 |
| mandel | ralsina, ok, but then you will have to do that in each release, is that any good? | 15:07 |
| ralsina | sure | 15:07 |
| ralsina | I already have to do it anyway for versions | 15:07 |
| mandel | ralsina, ok, pushing atm | 15:08 |
| mandel | ralsina, done, revno 70 | 15:08 |
| ralsina | mandel: also add the ini | 15:10 |
| ralsina | it's not being created | 15:10 |
| mandel | ralsina, but it should not be complaining | 15:11 |
| mandel | ralsina, may I see the error please | 15:11 |
| ralsina | mandel: http://pastebin.ubuntu.com/690062/ | 15:11 |
| mandel | ralsina, let me try something, give me 2 min | 15:14 |
| ralsina | mandel: ack | 15:14 |
| mandel | ralsina, please pull it should be fixed | 15:18 |
| mandel | ralsina, there was an error in the xml | 15:18 |
| ralsina | mandel: ack, testing | 15:19 |
| mandel | thx | 15:19 |
| ralsina | nessita: two-options has the changes you suggested, I am not sure if I mentioned it | 15:19 |
| nessita | ralsina: you did not. Did you apply all the comments I added to the MP? | 15:21 |
| ralsina | missed those, let me check | 15:21 |
| ralsina | mandel: installer built and uploading | 15:23 |
| mandel | ralsina, genial! gracias | 15:25 |
| dobey | lunch time, bbiab | 15:27 |
| ralsina | nessita: pushed two-options with all the suggested fixes from the MP | 15:37 |
| nessita | ack | 15:39 |
| ralsina | mandel: http://ubuntuone.com/p/1H4I/ | 15:42 |
| mandel | ralsina, thx | 15:43 |
| mandel | ralsina, I'm getting cmd screens during the setup, is that on purpose? | 15:49 |
| ralsina | mandel: yes | 15:49 |
| ralsina | mandel: I only get rid of them for the actual release | 15:49 |
| ralsina | mandel: this way you can see stderr | 15:49 |
| mandel | ralsina, I love you | 15:49 |
| mandel | :D | 15:49 |
| ralsina | mandel: ooooooooooook | 15:49 |
| * mandel hates the windows updates! | 16:00 | |
| nessita | gatox: ping? | 16:11 |
| ralsina | mandel: did that work? | 16:14 |
| gatox | nessita, pong | 16:14 |
| mandel | ralsina, yes, I just testing the update, I had to wait for some stupid windows updates | 16:14 |
| mandel | ralsina, but the app works perfectly ok | 16:14 |
| ralsina | mandel: neat! Can you do a screencast of it or something so I can see it? | 16:16 |
| mandel | ralsina, sure, let me think of something nice to do | 16:17 |
| ralsina | cool | 16:17 |
| ralsina | so I can show it to people in the UK before they EOD | 16:17 |
| mandel | ralsina, so, during the IRL I've noticed that I need priviledges to check for the updates, should I ask the user before I perform the request? | 16:25 |
| ralsina | you need privileges even to check? | 16:26 |
| ralsina | that totally kills the user experience :-( | 16:26 |
| ralsina | having the app asking once a day or whatever "can I run as admin so I can tell you there is nothing new to download" is awful | 16:27 |
| mandel | ralsina, yes? I think I can get around it, let me check | 16:28 |
| ralsina | ok | 16:28 |
| nessita | ralsina: I got lint issues, added to the MP | 16:31 |
| ralsina | nessita: ok, checking | 16:31 |
| ralsina | nessita: forgot to fix the linux version ;-( | 16:32 |
| nhaines | Question: in oneiric I don't have any sort of U1 extensions in nautilus. | 16:33 |
| nhaines | Is this a known issue by now? :) | 16:34 |
| ralsina | nessita: fixed and pushed | 16:34 |
| nessita | lunchtime! | 16:41 |
| gatox | is this ok?? when the user is in the reset password page, and enter an invalid reset code, the error-dict generated is this: {'errtype': 'NewPasswordError', 'message': 'Piston/0.2.2 (Django 1.3) crash report:'} | 16:45 |
| ralsina | gatox: sure doesn't look ok to me! | 16:46 |
| gatox | ralsina, that's what i thought :P | 16:48 |
| mandel | ralsina, got it fixed, the update will use runas and will create the tool to not require to be root | 16:49 |
| ralsina | mandel: need a new build? | 16:49 |
| mandel | ralsina, let me push the changes, will take 2 min | 16:49 |
| ralsina | mandel: just in case, if for you installbuilder works and py2exe doesn't, you can just use the files from c:\program files\ubuntuone\dist instead of building them with py2exe | 16:50 |
| ralsina | yourself | 16:50 |
| mandel | ralsina, true, that is a good idea | 16:51 |
| mandel | ralsina, but I changed python code :( | 16:51 |
| ralsina | ok then, I'll do it, no problem | 16:51 |
| mandel | ralsina, one little change and I'm done (I hate win32api) | 16:55 |
| ralsina | ack | 16:56 |
| ralsina | mandel: I am about to interview a possible hire, how long before your EOD? | 16:57 |
| nessita | gatox: that's very very bad | 16:58 |
| mandel | ralsina, please do pull the branch | 16:58 |
| mandel | ralsina, I'm goint to be here a little longer :) | 16:59 |
| gatox | nessita, do you know where is that coming from? | 16:59 |
| mandel | ralsina, I want to get this working on your machine and then will go to open boxes... | 16:59 |
| ralsina | mandel: ok, I'll try to at least start the upload before startin the call | 16:59 |
| mandel | ralsina, cool | 16:59 |
| ralsina | mandel: how can I try it? | 16:59 |
| nessita | gatox: yes, let me point you to the file | 16:59 |
| gatox | nessita, ok thanks..... | 17:00 |
| mandel | ralsina, you have to just install it, then kill everything and change update.ini to one I'll give you in pm | 17:00 |
| ralsina | mandel: ack | 17:00 |
| nessita | gatox: in sso, account.py | 17:00 |
| mandel | ralsina, that will point to my server and will say that there is an update and will perform it, but I'll like to test it before you try :) | 17:00 |
| nessita | line 220 | 17:00 |
| nessita | gatox: request_password_reset_token | 17:00 |
| nessita | gatox: apparently, since ISD changed their backend, this no longer works: | 17:01 |
| nessita | 228 raise ResetPasswordTokenError(e.content.split('\n')[0]) | 17:01 |
| ralsina | mandel: ok, uploading starts in 2' maybe you'll want to go open a few boxes until it's done | 17:01 |
| gatox | nessita, ok, i'll take a look at that | 17:01 |
| nessita | gatox: can you please show me full trace? should be logged | 17:01 |
| nessita | gatox: should be in in the log file, I mean | 17:01 |
| nessita | bad news is that is broken for Ubuntu as well | 17:02 |
| mandel | ralsina, can you use tweeter to le me know? | 17:02 |
| mandel | ralsina, I wont be close the the laptop all the time :P | 17:02 |
| ralsina | mandel: sure! | 17:02 |
| gatox | nessita, http://paste.ubuntu.com/690146/ | 17:02 |
| nessita | gatox: confirmed is broken in Ubuntu | 17:03 |
| nessita | gatox: can you please file a bug, Critical, and assign to me,? | 17:04 |
| gatox | nessita, ok | 17:04 |
| === beuno is now known as beuno-lunch | ||
| nessita | ralsina: ^ we'll need to file a string freeze exception for Ubuntu | 17:06 |
| gatox | nessita, done https://bugs.launchpad.net/ubuntu-sso-client/+bug/851094 | 17:07 |
| ubot4 | Launchpad bug 851094 in ubuntu-sso-client "Wrong error representation generated for reset password fails (affects: 1) (heat: 6)" [Critical,New] | 17:07 |
| ralsina | nessita: ok | 17:08 |
| ralsina | nessita: am otp now, so please go ahead | 17:08 |
| * mandel opens boxes | 17:14 | |
| mandel | ralsina, I'm getting an illegla instruction issue.. let me know if you experience the same... | 17:25 |
| ralsina | illegal instruction? Where? | 17:26 |
| mandel | ralsina, when doing the download of the update, the ntvdm encountered an illegal instruction | 17:26 |
| ralsina | ugh | 17:26 |
| mandel | ralsina, I have a filling that my vm is properly fucked | 17:26 |
| ralsina | looks like it. I just finished the interview, let me do a quick try | 17:26 |
| mandel | ralsina, yeah, so let me know when you have the package to take it for a test in my machine | 17:27 |
| ralsina | mandel: it's uploading | 17:27 |
| mandel | ralsina, great! | 17:34 |
| ralsina | mandel: http://ubuntuone.com/p/1H4I/ | 17:34 |
| dobey | thisfred: ping | 17:42 |
| thisfred | dobey: pong | 17:42 |
| dobey | thisfred: is there a method of testing ubuntuone-syncdaemon to force the progress bar to show up, without having to actually upload/download files? | 17:43 |
| thisfred | dobey, I think the tests mock it out. They also mock out the dbus calls to the actual progress bar, but if you hook those up again, you have tests that show the progress bar | 17:44 |
| dobey | hmm, true | 17:44 |
| dobey | i don't think it is working though :( | 17:44 |
| thisfred | I haven't tested it at all on oneiric yet, so that would not surprise me | 17:45 |
| nessita | alecu: ping | 17:46 |
| dobey | thisfred: well it's not working currently on oneiric because of the .desktop file changes | 17:46 |
| dobey | thisfred: but i'm trying to test my fix, and it's still not working :( | 17:46 |
| nessita | ralsina: approved! | 17:46 |
| ralsina | nessita: cool, thx! | 17:47 |
| dobey | fml. | 17:48 |
| thisfred | dobey: we never really got the whole issue with the different processes talking to the launcher solved, so when I was taken off, it was all very much in flux | 17:48 |
| thisfred | if nobody looked at it since, I am not surprised it is broken | 17:49 |
| dobey | which issue with diff processes? the not allowing diff processes to talk to the launcher? | 17:50 |
| dobey | doh | 17:51 |
| dobey | and apparently beta freeze is in a couple hours | 17:51 |
| dobey | really FML. :( | 17:51 |
| nhaines | \o/ | 17:51 |
| nessita | ralsina: could you review a couple of branches from gatox? | 17:52 |
| ralsina | nessita: sure | 17:52 |
| nessita | https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/845759/+merge/75385 and https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/err-dict/+merge/75055 | 17:52 |
| nessita | gatox: ping | 17:53 |
| gatox | nessita, pong | 17:53 |
| thisfred | dobey: I take it we've not managed to migrate to just the shim for oneiric then? | 17:53 |
| thisfred | dobey: anyway, let me know if I can help | 17:53 |
| gatox | nessita, ? | 17:54 |
| nessita | gatox: regarding the changes made to https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/75172, I was hoping we could re-use the properties dict to also keep track of the enabled flag (so we can remove self._enabled) and the polish/unpolish thingy. | 17:54 |
| nessita | gatox: so, you could implement polish as: | 17:54 |
| dobey | thisfred: i don't understand that question. the shim is irreelvant to this problem | 17:54 |
| nessita | self.properties['polish'] = args | 17:54 |
| thisfred | dobey: well if we're not on the cd, does beta freeze affect us? | 17:54 |
| gatox | nessita, ahhhhhh ok, no problem! i didn't know if apply that to that cases too | 17:54 |
| nessita | gatox: and then assert 'polish' is in proerties and the value has len bigger than 0 | 17:55 |
| thisfred | that was the whole point right? | 17:55 |
| nessita | gatox: the simpler and easier to read the fake, the better | 17:55 |
| ralsina | nessita, gatox: +1 on both after a quick IRL | 17:55 |
| dobey | thisfred: beta freeze effects everything in the archive; even universe | 17:55 |
| gatox | ralsina, awesome | 17:55 |
| gatox | nessita, ok! | 17:55 |
| nessita | gatox: but the branch looks much better! | 17:55 |
| gatox | :D | 17:56 |
| nessita | gatox: another question | 17:56 |
| dobey | err, affects | 17:56 |
| gatox | nessita, i'm finishing with the tests for the last high i have | 17:56 |
| thisfred | dobey, well yes, but once it opens up again, can we fix stuff without SRUs? | 17:56 |
| nessita | gatox: you added the new class FakePageUiStyle in both branches? | 17:56 |
| dobey | thisfred: we can't fix things without SRUs once the release is stable, no | 17:56 |
| nessita | both == 845759 and 845750 | 17:56 |
| nessita | gatox: that will conflict, no? | 17:56 |
| thisfred | dobey: then I forget what use the shim idea is | 17:56 |
| gatox | nessita, i don't think so | 17:57 |
| nessita | gatox: can you confirm? I may be wrong, but LP diff shows the class in the 2 mergers | 17:57 |
| thisfred | dobey: anyway, not the most productive use of our time to wonder about this now, sry | 17:57 |
| gatox | nessita, ok, let mme check | 17:57 |
| thisfred | let me know if I can review or if you have questions about the code | 17:57 |
| nessita | gatox: one last needs fixing for https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/name-required/+merge/75366 (I would advice add a test for validate_form to avoid raising a critical when is not needed) | 18:01 |
| gatox | nessita, ok | 18:01 |
| nessita | alecu: ping | 18:02 |
| alecu | nessita, pong | 18:03 |
| nessita | alecu: hi there! 2 questions: 1- would you any ETA for your branches? (so we can estimate when we'll build the final bundle) | 18:04 |
| nessita | 2- ideally we should also land the u1cp branch where we shudown the webclient, can I help with that? | 18:04 |
| alecu | nessita, regarding the u1cp branch where the client shuts down, we need to find why those DelayedCalls are still running on windows | 18:07 |
| alecu | nessita, the weird thing is that on linux the tests pass just fine. | 18:07 |
| nessita | alecu: is there any chance that affects IRL behavior? | 18:07 |
| alecu | nessita, I'm talking about the errors you've found on: https://code.launchpad.net/~alecu/ubuntuone-control-panel/webclient-shutdowns/+merge/74708 | 18:07 |
| nessita | alecu: yes | 18:07 |
| alecu | nessita, I'm not sure if this would affect IRL behaviour. In any case it will trigger an error when stopping | 18:09 |
| alecu | nessita, so the only way it could affect is by writing yet another error when shutting down | 18:09 |
| nessita | right | 18:09 |
| alecu | nessita, so if you want to help get this landed: perhaps we should add a "skipWindows" for this test, and create a bug to fix it. | 18:11 |
| nessita | alecu: I can do that :-) | 18:11 |
| * nessita does | 18:11 | |
| nessita | alecu: what about (1)? | 18:12 |
| alecu | nessita, and regarding the ETA, my guess is that I will be able to finish it today | 18:12 |
| nessita | alecu: have anything to start reviewing informally? | 18:12 |
| alecu | nessita, but it will still need reviews | 18:12 |
| nessita | right | 18:12 |
| gatox | nessita, ralsina this branch is ready too: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/reset-fails/+merge/75599 | 18:13 |
| nessita | alecu: I can start looking at the diff without a MP, and see if I see something odd. And ralsina can include the branch in the installer, I guess, even if is not in trunk | 18:13 |
| alecu | nessita, not in a good shape right now, probably in two hours | 18:13 |
| nessita | alecu: ok, let me know then | 18:13 |
| ralsina | yes I can | 18:13 |
| ralsina | nessita, gatox: trivial review https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/start_right/+merge/75601 | 18:15 |
| ralsina | gatox: got it | 18:15 |
| gatox | ralsina, on it | 18:15 |
| ralsina | gatox: +1 on that | 18:22 |
| === beuno-lunch is now known as beuno | ||
| nessita | gatox: lint issues in reset-fails | 18:31 |
| * gatox looking.... | 18:31 | |
| nessita | alecu: the branch is ready, shall you re-branch and re-propose or shall I? https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/webclient-shutdowns | 18:33 |
| alecu | nessita, no preference | 18:33 |
| nessita | ralsina, alecu: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/webclient-shutdowns/+merge/75609 | 18:35 |
| ralsina | nessita: got it | 18:37 |
| nessita | ralsina: test failure in start_right | 18:37 |
| nessita | (added to the MP) | 18:38 |
| ralsina | ? | 18:38 |
| ralsina | ok | 18:38 |
| ralsina | nessita: that test is patched, chec the diff | 18:40 |
| ralsina | nessita: maybe wrong PYTHONPATH? | 18:40 |
| nessita | ralsina: let me confirm (I did check the diff, I assume platform issues) | 18:40 |
| nessita | ralsina: you sure that works ok in linux too? | 18:40 |
| ralsina | Oh, on linux. Ok | 18:41 |
| nessita | ralsina: and thinking it twice, what PYTHONPATH issue can I have? | 18:41 |
| gatox | ralsina, nessita ok, all the fixes has been applied to my branches... | 18:41 |
| nessita | gatox: re reviewing | 18:41 |
| ralsina | nessita: having older installed ubuntuone-windows-installer in your PYTHONPATH instead of . | 18:41 |
| nessita | ralsina: in linux I'm not installing any package, so is very unlikely | 18:42 |
| ralsina | nessita: didn't know that :-) | 18:42 |
| nessita | ralsina: seems like you also need to fix ubuntuone_installer/gui/qt/utils/linux.py:32: | 18:44 |
| ralsina | no, the behaviour --with-icon makes no sense in linux | 18:45 |
| ralsina | so I am duplicating the test as linux/windows specific | 18:45 |
| ralsina | or rather, it may make sense eventually, in some cases, but we need to think about it | 18:45 |
| nessita | right | 18:45 |
| ralsina | nessita: I can't run the tests on linux because I can't start another VM. Pushed with what should work :-( | 18:46 |
| nessita | ralsina: I see the problem. The tests for gui should not test that Popen was called, but just that utils.start_control_panel was called | 18:56 |
| ralsina | nessita: good one, the tests are older than that function | 18:57 |
| nessita | ralsina: and then, since utils have different implementations for linux and windows, and different test suites, you can safely test one independently from the other | 18:57 |
| nessita | ralsina: in fact, test_utils do not test the start_control_panel function :-/ | 18:57 |
| nessita | ralsina: you think you can fix that? | 18:57 |
| ralsina | nessita: honestly, not today :-( | 18:57 |
| ralsina | nessita: I can file a bug for it though! | 18:58 |
| nessita | ralsina: ok, I'll take that now | 18:58 |
| nessita | ralsina: I'll do it, should be ~ 30 minutes | 18:58 |
| ralsina | ok, sorry, but I have a ton of stuff to test before doing the binaries | 18:58 |
| nessita | is ok | 18:58 |
| nessita | gatox: lint issue in https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/75606 | 18:59 |
| nessita | ralsina: if you have a moment, this needs a second review https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845759/+merge/75605 | 19:02 |
| ralsina | nessita: ok, on it | 19:03 |
| ralsina | nessita, gatox: +1 on https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845759/+merge/75605 | 19:05 |
| ralsina | I have to do a school run, should be back in 20' or so. See you people. | 19:06 |
| nessita | ralsina: you back? | 19:34 |
| ralsina_ | Turns out I have to leave for a while (parents meeting at school). That is hell on schedule :-( | 19:38 |
| ralsina_ | nessita, gatox, alecu: do what you can, send me email with branches that should go on the release | 19:38 |
| ralsina_ | mandel: please send me an explanation about how your branch works | 19:38 |
| nessita | ralsina_: do you have an ETA for coming back? | 19:39 |
| ralsina_ | I will try to put everything together late tonight and upload the binaries for signing | 19:39 |
| ralsina_ | nessita: probably 7:30 PM :-( | 19:39 |
| nessita | guh | 19:39 |
| alecu | ralsina_, ack | 19:39 |
| nessita | ralsina_: ok | 19:39 |
| ralsina_ | yeah, it hit my by surprise but I can not not go | 19:39 |
| nessita | mandel, alecu, gatox: please cc me in that email | 19:39 |
| nessita | alecu: did you have any chance to review the webclientshutdown branch? | 19:40 |
| ralsina_ | so, god luck people. Nessita, I am reachable by phone if something horrible happens | 19:40 |
| nessita | ralsina_: ack | 19:40 |
| alecu | nessita, sorry, no. It's my code, so I would say "looks great!" | 19:41 |
| nessita | gatox: more needs fixing to name-required | 19:41 |
| nessita | alecu: it does! :-D | 19:41 |
| nessita | alecu: ok, I'll approve myself and land, since is your code | 19:41 |
| nessita | ralsina_: did you approved the webclient branch? | 19:41 |
| alecu | nessita, I can run the tests and approve | 19:41 |
| nessita | alecu: please do | 19:41 |
| ralsina_ | nessita: I think so | 19:41 |
| nessita | ralsina_: you mentioned it was +1, but no +1 on LP | 19:41 |
| nessita | ralsina_: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/webclient-shutdowns/+merge/75609 | 19:41 |
| ralsina_ | there | 19:42 |
| ralsina_ | must have not clicked submit or something | 19:42 |
| nessita | ralsina_: I have the start-right ready, do you have time for that review? | 19:42 |
| nessita | or you're leaving right now? | 19:42 |
| ralsina_ | nessita: in 2' or so | 19:42 |
| ralsina_ | I'll try :-) | 19:42 |
| ralsina_ | link? | 19:42 |
| ralsina_ | I can at least read the code | 19:43 |
| nessita | ralsina_: https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/start-right/+merge/75618 | 19:43 |
| nessita | I'm very happy with the code | 19:43 |
| * nessita is such a narcissist | 19:43 | |
| nessita | :-P | 19:43 |
| nessita | dobey: so, shall I package u1cp? | 19:47 |
| nessita | dobey: so we can release before the freeze | 19:47 |
| alecu | nessita, approved | 19:47 |
| nessita | alecu: great! | 19:47 |
| alecu | nessita, (not the start-right, though) | 19:49 |
| nessita | alecu: right | 19:50 |
| ralsina_ | nessita: +1 start_right | 19:50 |
| dobey | nessita: no, i think freeze is in 10 minutes | 19:50 |
| nessita | dobey: LET S RELEASE NOW THEN :-) | 19:51 |
| dobey | why? | 19:51 |
| dobey | will take that long to do a proper release anyway | 19:51 |
| nessita | why? | 19:52 |
| nessita | 15 minutes is all I need | 19:52 |
| dobey | 15 > 10 :) | 19:52 |
| nessita | dobey: I can try in 10. Do you have strong arguments to not try it? | 19:53 |
| dobey | and because milestone/bug triage needs to be done | 19:53 |
| nessita | dobey: that is done automatically by the ubuntu-dev-tools, no | 19:53 |
| nessita | ? | 19:53 |
| dobey | no | 19:53 |
| nessita | dobey: hum, not sure what you mean then. Last time I built a package, no extra effort was needed other than creating a good changelog that will explicit state what bugs were fixed | 19:54 |
| nessita | dobey: did the procedure change at some point? | 19:54 |
| dobey | and anyway, i don't think rushing out a release right on the beta freeze deadline is a good thing, especially if it's only to fix one tiny bug when we have a couple of big ones that we really need to get in asap anyway | 19:55 |
| nessita | dobey: ok, but since I'm trying to get back on track of releasing and pacakging, please let me know when I can build the package for u1cp and ussoc | 19:56 |
| dobey | nessita: we need to manage our own bugs better; not only shoving them in the debian changelog for ubuntu. bugs we fix need to be targeted to the milestone for the release | 19:56 |
| dobey | nessita: i think you picked a poor time to do that. :) | 19:56 |
| nessita | dobey: is that a requirement of the platform team or is a proposal of you? | 19:56 |
| dobey | it is not a requirement of the platform team. it is something we need to do for us | 19:57 |
| nessita | dobey: well, I think we need to discuss that before making it a requirement | 19:57 |
| nessita | dobey: discuss it within the team, I mean | 19:57 |
| nessita | so we all follow the same procedure within desktop at least | 19:57 |
| nessita | dobey: anyways, why would you say is a poor time to do packaging? | 19:58 |
| dobey | nessita: "the team" has been me this whole cycle, and i have been doing it for every release i have made. and i don't want us to stop doing now because you're 'done' with the windows stuff and want to jump back on ubuntu packaging stuff and feel the need to rush out packages :) | 19:58 |
| nessita | dobey: 1- the team is coming back to be everyone is desktop now | 19:59 |
| nessita | 2- I'm not trying to rush packaging, I started the talking about it with you (I could do it without asking you, and I considered that a bad approach) | 20:00 |
| nessita | 3- I'm going back to packaging because is a good thing for me and for the team, and I hope you can help me getting better at it | 20:00 |
| nessita | 4- I'm not saying we stop setting milestones, I'm saying that we need to discuss that in the team | 20:01 |
| dobey | nessita: ok, but my mind is not in the 'working as a team' mindset because i have been the lone ranger the whole cycle, and trying to adjust back to team mode is going to distract me too much. | 20:01 |
| nessita | dobey: I see, let's give you some time to adjust back. I will not package today, but I do want to do it when we're ready for it. | 20:02 |
| nessita | and I'm happy to do the milestoning, I just think that I see no point on setting milestones once the bug is fixed, I think milestones are meant to be used for planning, before fixing the bug itself | 20:03 |
| * alecu pictures dobey with his hat and mask on top of silver, and nessita dressed as an indian next to him | 20:03 | |
| nessita | alecu: what a coincidence! I'm just wearing "trencitas" | 20:03 |
| nessita | a la Pocahontas | 20:03 |
| nessita | :-P | 20:03 |
| nessita | dobey: can you please remind me what bugs are we waiting to get fixed for u1cp? | 20:04 |
| nessita | besides the TB-bookmarks ones | 20:04 |
| dobey | nessita: nessita bug #838778 | 20:05 |
| ubot4 | Launchpad bug 838778 in ubuntuone-control-panel (Ubuntu Oneiric) (and 2 other projects) "After installing Ubuntu One, there are 2 Ubuntu One launchers in System Settings (affects: 46) (dups: 11) (heat: 206)" [High,Triaged] https://launchpad.net/bugs/838778 | 20:05 |
| nessita | dobey: right, you're working on that, is that correct? | 20:05 |
| dobey | yes | 20:06 |
| nessita | is there any other bug? | 20:06 |
| mandel | ralsina_, ping? | 20:06 |
| nessita | mandel: he's gone to a parent's meeting, what do you need? | 20:07 |
| dobey | i don't think so, but i think the TB *contacts* issue, and this one are big enough to wait on, and the "2 gb vs 5 gb" one is small enough that we don't need to rush a release into ubuntu for it | 20:07 |
| mandel | nessita, we where debuggin my branch in his machine, I'll wait until he is back so that we get it in the release, I have a free evening | 20:08 |
| dobey | nessita: and i don't think there are any changes in SSO relating to the linux support since the last release i made (need to check on that); so i wouldn't say we need to urgently make one for it either | 20:08 |
| nessita | dobey: with TB-bookmarks I meant the TB issue and the removing "bookmarks" reference | 20:08 |
| dobey | ah right | 20:08 |
| dobey | yes, i forgot those are 2 bugs | 20:08 |
| dobey | too much going on too quickly :) | 20:08 |
| nessita | dobey: I can take care of checking sso since your last packaging, do not worry about that | 20:09 |
| nessita | mandel: he wanted some things from you, did you read his ping? | 20:10 |
| nessita | (04:38:58 PM) ralsina_: mandel: please send me an explanation about how your branch works | 20:11 |
| nessita | dobey: actually, the 2GB vs 5GB issues will require a string freeze exception now, that we have passed the freeze? | 20:15 |
| nessita | dobey: and for sso we have a tiny string change... so I think I can build that package (will set milestones properly) | 20:16 |
| dobey | nessita: no, because we just removed the label | 20:16 |
| nessita | dobey: you're right | 20:17 |
| dobey | nessita: and it's a separate string from "join now" | 20:17 |
| mandel | nessita, yes, that is why I'm back :) | 20:17 |
| nessita | yes | 20:17 |
| dobey | nessita: what string change is in sso? | 20:17 |
| nessita | mandel: can you please send those instructions cc'ing me? | 20:17 |
| nessita | dobey: leo added a couple of missing periods at the end of some sentences | 20:17 |
| mandel | nessita, sure | 20:18 |
| dobey | nessita: in qt UI or in gtk+? or are they the same in both? | 20:18 |
| mandel | nessita, but I'll wait around here so that I can chat with him, if he is to late I'll send the email | 20:18 |
| nessita | dobey: they are the same in both (though currently the code is duplicated... we'll fix that) | 20:18 |
| nessita | dobey: so he changed both | 20:18 |
| nessita | mandel: is the update thingy working? can I test somehow? | 20:19 |
| nessita | dobey: the branch was https://code.launchpad.net/~elopio/ubuntu-sso-client/typos/+merge/73105 | 20:19 |
| dobey | nessita: oh ok. we will need a freeze exception for that bug. and it needs to be linked to the ubuntu package as well | 20:20 |
| mandel | nessita, he was not able to access the host with the xml, I'm going to test now in my system, I'll ping you when I trust the thing to work so that you can test in your xp vm :) | 20:20 |
| nessita | dobey: will take care of that now then | 20:20 |
| nessita | mandel: yes please, we need that working and "oiled up" | 20:23 |
| mandel | ack | 20:27 |
| dobey | oiled up? | 20:28 |
| dobey | that's what she said? :P | 20:28 |
| nessita | dobey: is that even a word in english? (I just invented it) | 20:30 |
| dobey | oiled? yes. but i do not think it means what you think it means? | 20:31 |
| nessita | dobey: well, I meant 'aceitado', which in spanich means with oil in it, but in figurative speech means something that runs smoothly | 20:31 |
| nessita | so I deduced in english it was 'oiled up' :-D | 20:32 |
| dobey | nessita: i think if you did a google image search for 'oiled up' in the US, you would find it has a very different meaning ;) | 20:33 |
| * nessita googles | 20:33 | |
| nessita | juaz | 20:33 |
| nessita | dobey: well, imagine the an upgrade of the installer oiled up, that would mean what I meant | 20:33 |
| dobey | heh | 20:34 |
| nessita | it just installs and updates, no user interaction | 20:34 |
| nessita | dobey: going back to bug #835054, if I do a branch that adds the dot at the end, outside the translatable string, that will not require an exception, no? | 20:36 |
| ubot4 | Launchpad bug 835054 in ubuntu-sso-client (Ubuntu) (and 1 other project) "[UI Fe] Missing period on the email confirmation screen (affects: 1) (heat: 6)" [Low,Triaged] https://launchpad.net/bugs/835054 | 20:36 |
| mandel | dobey, I though about that too heheh | 20:36 |
| nessita | dobey: I was just thinking is not worth it to ask an exception for a new ending dit | 20:36 |
| nessita | dot* | 20:36 |
| dobey | nessita: adding the period to the end of the string always might break for RTL translations i think | 20:40 |
| nessita | dobey: you sure? | 20:40 |
| nessita | dobey: if so, I think we need to revert that change and apply it again once we make the stable tag. Is not worth it the string FE at this point | 20:42 |
| nhaines | I think the string simply displays RTL, so adding to the end should be fine? | 20:42 |
| nessita | honestly, I'm not sure | 20:42 |
| dobey | nessita: eh, might as well get the freeze exception, i don't see any point in trying to avoid it unless there is some big urgent bug that was fixed since the last release i made (which i doubt there is) | 20:43 |
| dobey | nessita: it will easily be granted anyway | 20:43 |
| nessita | dobey: but that FE will require all the translation teams to translate the string again, I see that as a lot of effort that is not worth it at this point. Likewise, there are still some more sentences that do not end with a dot... | 20:44 |
| dobey | >>> print u'קבל כמונ' + '.' | 20:45 |
| dobey | קבל כמונ. | 20:45 |
| dobey | seems to do the wrong thing :) | 20:45 |
| dobey | nessita: we could sync the translations into trunk and fix them ourselves easily enough | 20:46 |
| nessita | dobey: you think that's worth it? I don't.... considering as well we have more strings in the same situation but not fixed | 20:46 |
| dobey | nessita: i think i don't want to think about it right now, and it's not an urgent thing we need to deal with right now | 20:47 |
| nessita | dobey: ok, I'll take care of this then | 20:47 |
| dobey | ok, am out. have a good evening all | 21:01 |
| mandel | dobey, adios! | 21:07 |
| nessita | alecu: I'm about to EOD, have something for me to look at? (regarding branches ;-)) | 21:10 |
| mandel | ralsina, ping | 21:14 |
| ralsina | mandel: pong | 21:14 |
| alecu | nessita, https://code.launchpad.net/~alecu/ubuntu-sso-client/unicode-usernames | 21:15 |
| alecu | nessita, and https://code.launchpad.net/~alecu/ubuntuone-client/unicode-usernames | 21:15 |
| alecu | nessita, the second branch needs the first | 21:15 |
| nessita | alecu: on them! | 21:16 |
| mandel | ralsina, hola! can I make a push and we try a new one, I've fixed a number of small issues, if the download does not work we can change the text of the dialog and simply provide the url of the update | 21:16 |
| alecu | nessita, another thing: I'm testing control panel with unicode usernames, and it's showing the path with scrambled characters | 21:17 |
| mandel | ralsina, that way we have a first one to do it that uses more or less the same code | 21:17 |
| nessita | alecu: which path where? | 21:17 |
| alecu | nessita, the path on folder lists | 21:17 |
| nessita | alecu: hum, we're calling os.expanduser() | 21:18 |
| mandel | ralsina, I just pushed revno 73, can we try to build a .exe (unless your EOD) | 21:18 |
| nessita | and replacing that | 21:18 |
| nessita | alecu: have a screenshot? | 21:18 |
| ralsina | mandel: if you are not EOD, I am not EOD :-) | 21:19 |
| ralsina | mandel: can we mumble 2' so I can understand how this works? | 21:19 |
| mandel | ralsina, sure, let me start mumble | 21:20 |
| alecu | nessita, http://ubuntuone.com/76C471jhrAuulBQEqKX1Q2 | 21:25 |
| nessita | alecu: thanks | 21:25 |
| nessita | alecu: sso branch looks OK (though I would use unicode paths inside save_config_path instead of native_path). There is a lint issue (I know is not proposed, but the warning is: | 21:27 |
| nessita | ubuntu_sso/logger.py: | 21:27 |
| nessita | 43: [C0103] Invalid name "log_path" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$) | 21:27 |
| nessita | ) | 21:27 |
| nessita | alecu: I'll file a bug for the u1cp unicode madness, I will fix it tomorrow | 21:28 |
| nessita | ralsina: we may need to do the release without proper handling for non-ascii usernames | 21:30 |
| ralsina | nessita: it's ok | 21:30 |
| ralsina | nessita: we'll just put something in the mailing | 21:30 |
| nessita | ralsina: we have more issues than expected | 21:30 |
| ralsina | as long as we get the autoupdater working, the severity of that decreases | 21:30 |
| nessita | right | 21:30 |
| ralsina | mandel: I don't need to build the autoupdater separately anymore, right? | 21:33 |
| mandel | ralsina, waht do you mean? | 21:33 |
| mandel | ralsina, yes, I changed it so that it does not need to be admin to execute | 21:33 |
| mandel | ralsina, also make sure you use revno 74 | 21:33 |
| ralsina | mandel: generating autoupdate-windows | 21:34 |
| ralsina | I now see I do have to, so doing it | 21:34 |
| mandel | ralsina, I had to add a new attr | 21:35 |
| nessita | alecu: in config.py, isn't it "better" to have xdg_config_dir = native_path(xdg_config_dir) to be a syncdaemon path instead, and keep using the os_helper methods? | 21:38 |
| nessita | alecu: the we don't need the native_rename | 21:38 |
| nessita | crap, I need to run to pilates in 10 minutes | 21:39 |
| nessita | ralsina: how's autoupdater going? | 21:39 |
| ralsina | nessita: uploading build to mandel, we figured out something we did wrong | 21:39 |
| nessita | oh | 21:39 |
| nessita | ralsina: are we meeting the deadline with this new issue? | 21:40 |
| ralsina | nessita: well, without autoupdater it's a no, so I may have to work a bit early tomorrow, or late today. I expect we'll make it | 21:40 |
| nessita | alecu: the rest looks good!!! | 21:42 |
| alecu | nessita, for coherence, I think we better use all native functions in that module | 21:43 |
| nessita | alecu: but the rest are not native but from os_helper, that's why I was suggesting keeping consistency | 21:43 |
| alecu | nessita, in that module it's all native | 21:44 |
| alecu | nessita, I explicitly removed "from ubuntuone.platform import path_exists, rename" from that module | 21:44 |
| nessita | alecu: what\ s native? | 21:44 |
| alecu | nessita, os.path.exist and native_rename | 21:45 |
| nessita | alecu: no, I meant, why you say that module was using all native? | 21:45 |
| nessita | alecu: I personally converted it to use from os_helper | 21:45 |
| alecu | nessita, native == the functions that don't take syncdaemon paths | 21:45 |
| nessita | alecu: I know what you mean, but I don't see that in the current code | 21:45 |
| alecu | nessita, that module was using os_helper functions | 21:45 |
| nessita | yes | 21:45 |
| alecu | nessita, I moved it to use native | 21:46 |
| alecu | nessita, because, as the big comment says... | 21:46 |
| nessita | alecu: right, and I say let's keep using os_helper | 21:46 |
| nessita | by not calling native_path but syncdaemon_path | 21:46 |
| alecu | +# We should not use standard functions from os_helper here, | 21:46 |
| alecu | +# because the configglue superclasses do not use them. | 21:46 |
| nessita | alecu: but if you do: | 21:46 |
| nessita | instead of | 21:46 |
| nessita | xdg_config_dir = native_path(xdg_config_dir) | 21:46 |
| nessita | you add: | 21:46 |
| nessita | xdg_config_dir = syncdaemon_path(xdg_config_dir) | 21:47 |
| nessita | and make all calls to configglue return a syncdaemon_path | 21:47 |
| nessita | we isolate in early stages the natives paths | 21:47 |
| alecu | (checking) | 21:48 |
| alecu | nessita, what do you mean by "all calls to configglue"? | 21:50 |
| nessita | in bin/ubuntuone-syncdaemon, when we use options.something | 21:51 |
| nessita | when we access results from: | 21:51 |
| nessita | 89 (parser, options, argv) = config.configglue(file(configs[0]), *configs[1:], | 21:51 |
| nessita | 90 args=args, usage=usage) | 21:51 |
| nessita | so, when we grab the dirs from options, we call right in that point syncdaemon_path | 21:51 |
| nessita | so, instead of: | 21:51 |
| nessita | using options.data_dir directly, we shall use: | 21:52 |
| nessita | syncdaemon_path(options.data_dir) | 21:52 |
| nessita | same for shares_dir a root_dir | 21:52 |
| nessita | but we leave all transforms encapsulated right next to congigglue | 21:52 |
| nessita | so, we can have as invariante: | 21:53 |
| nessita | Main() will always receive syncdamon paths | 21:53 |
| nessita | alecu: I gotta run to pilates!!! leave any message you need | 21:53 |
| nessita | I will read backlog later | 21:53 |
| nessita | ralsina: all my branches are landed, the on;ly pending is https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/webclient-shutdowns/+merge/75609 (depends on tarmac, I just pinged sid-nei about it) | 21:54 |
| ralsina | nessita: cool | 21:54 |
| ralsina | I will merge it manually if it doesn't land | 21:54 |
| gatox | ralsina, nessita maybe i'm too late for a review, but i fixed: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/75606 | 21:56 |
| gatox | and finishing with the last one | 21:57 |
| alecu | hmmm | 21:57 |
| alecu | ConfigGlue woes: The config file is always utf-8, but the cmdline and the env-vars on windows are mbcs. That means that configglue options (config+cmdline) sometimes come as utf8, sometimes as mbcs :-( | 21:59 |
| ralsina | mandel: uploaded http://ubuntuone.com/p/1H4I/ | 21:59 |
| ralsina | mandel: doesn't seem to work for me though | 21:59 |
| mandel | ralsina, cool, let me take a look | 21:59 |
| alecu | ralsina, how comes it does not work? | 21:59 |
| mandel | ralsina, can be the config, let me check in mine | 22:00 |
| ralsina | alecu: I don't get a new version notice when running -installer, only when usint windows-autoupdate | 22:00 |
| ralsina | mandel: make sure that if the XML file is not uploaded/accessible nothing happens :-) | 22:01 |
| alecu | ralsina, since I won't have this branch ready today, and since I'm way tired, I'll be calling this EOD | 22:02 |
| mandel | ralsina, yeah, that should be the case, the auto-update tool should be returning other value but 0 | 22:02 |
| alecu | with a bit of luck my brain will function a bit better tomorrow than it did today. | 22:02 |
| alecu | so, all: bye! | 22:06 |
| * alecu EODs | 22:06 | |
| gatox | alecu, bue | 22:07 |
| gatox | bye | 22:07 |
| mandel | ralsina, I'm making stupid mistakes? the path to autoupdate-windows is wrong... | 22:11 |
| mandel | ralsina, just pushed the correct code to revno 76 | 22:11 |
| mandel | sorry, that would be 75 | 22:11 |
| gatox | mocker i hate you..... :( | 22:19 |
| karni | Good night all! | 22:35 |
| ralsina | mandel: ack | 22:36 |
| mandel | ralsina, let mw know when you are done :) | 22:36 |
| ralsina | mandel: building | 22:37 |
| mandel | cool | 22:40 |
| ralsina | installing | 22:45 |
| ralsina | mandel: I get a popup telling me "no update.ini at c:\program files(x86)\ubuntuone/updte.ini | 22:47 |
| ralsina | because it's in "dist" | 22:47 |
| ralsina | let me patch that... | 22:47 |
| ralsina | ok, no idea where to patch it :-( | 22:48 |
| mandel | ralsina, cool, I guess I messed that up,it should be in the same location of the autoupdate | 22:48 |
| ralsina | it is in the same location | 22:49 |
| mandel | ralsina, you have to place autoupdate-windows insid dist and its fixed :) | 22:49 |
| ralsina | When I run autoupdate-windows manually, I get a Invalid XML syntax error | 22:49 |
| mandel | ein? but it was working before.. | 22:50 |
| ralsina | Because it seems to be geting a 302 from where the XML file should be | 22:50 |
| ralsina | <title>302 file found</title> | 22:50 |
| mandel | ralsina, ah, you have to update the update.ini to point to my server, you are going to a one.ubuntu.com address | 22:50 |
| mandel | ralsina, and then you get the 302 jeje | 22:50 |
| ralsina | ack, fixing that first | 22:50 |
| mandel | ralsina, url: http://themacaque.com/windows_tests/update.xml | 22:50 |
| ralsina | ok, the autoupdate-windows.exe works manually, now let's try the other one | 22:52 |
| mandel | ralsina, could it be that suprocess.call is screwing up the execution | 22:52 |
| ralsina | And there i get the path error for update.ini | 22:52 |
| mandel | ralsina, hm? I guess is the subprocess call that is crewing it up, I wonder if we can pass a parameter with the ini file, let me look | 22:53 |
| ralsina | mandel: leave it as is, I will take it from here, go to sleep :-) | 22:54 |
| ralsina | I may need you to fix it tomorrow morning :-) | 22:54 |
| mandel | ralsina, nah, is personal, I'll find out wtf is going on | 22:54 |
| ralsina | mandel: ok, cool | 22:54 |
| ralsina | but I am not going to be able to do more builds for a little while | 22:55 |
| mandel | ralsina, no worries, can you upload the latests one for me | 22:55 |
| mandel | ralsina, and pastebin the logs from the isntaller | 22:55 |
| ralsina | sure, uploading, should be in the same URL in a few minutes | 22:55 |
| mandel | you know those in xdg | 22:55 |
| ralsina | sorry, I can't do the logs, family is getting impatient :-( | 22:56 |
| ralsina | I'll try to be back in 30 minutes or so | 22:57 |
| mandel | nada, corre | 22:57 |
| === yofel_ is now known as yofel | ||
| mandel | ralsina, I'm going to call EOD please do send me a message with the url of the package to take a look at the issue | 23:03 |
| mandel | ralsina, I'm using bip so should get it | 23:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!