| poolie | wgrant, i kinda hoped for a +1 on my process-one-mail announcement | 01:17 |
|---|---|---|
| poolie | not all that externally exciting but i found it much more comfortable | 01:17 |
| poolie | maybe someone will use it in future | 01:17 |
| poolie | and, traditional email is kind of lacking a cheap non-noisy +1 | 01:17 |
| wgrant | poolie: Sorry, meant to +1 that last night, but was very busy. | 01:17 |
| poolie | np | 01:17 |
| wgrant | And then had far too much mail this morning. | 01:18 |
| poolie | not really fishing :) | 01:18 |
| wgrant | It is a really handy helper. | 01:18 |
| wgrant | Often I avoid testing mail stuff because it's just so awkward :/ | 01:18 |
| wgrant | But not any more! | 01:18 |
| wgrant | Thanks for JFDI. | 01:18 |
| poolie | yeah, for me it was a minor mental breakthrough | 01:18 |
| poolie | "this is so hard to test.... oh, but it doesn't actually inherently have to be" | 01:18 |
| poolie | hello losa? i'd like some help testing email on staging | 01:47 |
| wgrant | poolie: What are you wanting to test? staging processes mail automatically. | 01:48 |
| poolie | oh does it now? | 01:48 |
| poolie | and qas does too? | 01:49 |
| poolie | for some reason i thought it needed to be manually prodded | 01:49 |
| wgrant | Ah, qas, true. It used to do it less frequently than staging, and may no longer do it at all.. | 01:49 |
| wgrant | That's a good point. | 01:49 |
| poolie | hloeung, spm? | 01:50 |
| hloeung | poolie: hi, how can I help you? | 01:50 |
| poolie | also i'm a bit curious what software ends up delivering the mail to lp's mailbox | 01:50 |
| poolie | hloeung, does qas automatically receive and process mail or do i need to get you to thump it | 01:50 |
| poolie | wgrant, re bug 813349, are you reopening it because it's flaky? | 01:51 |
| _mup_ | Bug #813349: hard to get from mp to per-revision diffs <code-review> <javascript> <qa-ok> <ui> <Launchpad itself:In Progress by spiv> < https://launchpad.net/bugs/813349 > | 01:51 |
| poolie | i see the point about it not being done done | 01:51 |
| hloeung | poolie: I'm not too sure | 01:51 |
| wgrant | poolie: It's not done-done, needs more work, and was one of two bugs that were cluttering up my queue. | 01:51 |
| wgrant | poolie: I decided to finally get rid of it. | 01:51 |
| poolie | it would be easier if i just try it | 01:51 |
| wgrant | Now that the queue can be otherwise clear. | 01:51 |
| wgrant | lifeless: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-2084H53 | 01:52 |
| wgrant | lifeless: timeouts now break lazr.restful :/ | 01:52 |
| wgrant | I guess we want to capture sys.exc_info and use that. | 01:53 |
| wgrant | Rather than assuming __traceback__ | 01:53 |
| wgrant | Isn't that new in 2.7/3.0? | 01:53 |
| lifeless | wallyworld_: http://paste.ubuntu.com/690450/ | 01:53 |
| lifeless | wallyworld_: is what I recommend | 01:53 |
| poolie | did ec2 land change so that it no longer detaches from the vm? | 01:53 |
| wgrant | poolie: No. | 01:53 |
| poolie | *intentionally? | 01:54 |
| poolie | because it does seem to be not detaching now | 01:54 |
| wgrant | What's it said? | 01:54 |
| poolie | it's running 'python .... ec2test-remote.py', just printed some bzr hpss counts and now it's just sitting there connected | 01:54 |
| lifeless | wallyworld_: that query will do unstacked branches first | 01:54 |
| poolie | i can see the tests are running | 01:54 |
| wallyworld_ | lifeless: so the change is you added "ORDER BY stacked_on ASC NULLS FIRST" ? | 01:54 |
| poolie | when this happened yesterday, it did eventually complete | 01:54 |
| wgrant | poolie: Ah. It should detach right after ec2test-remote.py | 01:55 |
| wgrant | poolie: I haven't seen that happen in months. | 01:55 |
| wgrant | But when it does you can normally just ctrl+c | 01:55 |
| poolie | that's two out of two so far | 01:55 |
| wgrant | After it starts ec2test-remote.py | 01:55 |
| lifeless | wallyworld_: and then in increasing branch id, which will (except where folk have restacked) keep the depth of recursion low | 01:55 |
| lifeless | wallyworld_: I think thats all I did yes | 01:56 |
| wallyworld_ | lifeless: that change somehow helps the optimiser ? | 01:56 |
| StevenK | sinzui: There is something you can help me with, in fact. | 01:57 |
| wallyworld_ | lifeless: how did you know that's what you needed to do? | 01:57 |
| lifeless | wallyworld_: it doesn't help the optimiser | 01:57 |
| sinzui | StevenK, yes? | 01:57 |
| lifeless | wallyworld_: but it will stop us looping 6 times through | 01:57 |
| wallyworld_ | ah ok. i'll look at the explains in more detail | 01:57 |
| wallyworld_ | they're still a bit hard for me to read | 01:58 |
| lifeless | so we have a branch A->B->C->D->E->F | 01:58 |
| StevenK | sinzui: I'd like a header and prose for the pop-up when the user wants to unsubscribe themselves. | 01:58 |
| wallyworld_ | and grok | 01:58 |
| lifeless | until we update F, anything stacked on any of B,C,D,E,F, will recurse all the way to F | 01:58 |
| lifeless | this tweak makes it be more likely to calculate F before A, as F will be unstacked, E will have a lower branch id than D, in the usual course of htings. | 01:59 |
| sinzui | StevenK, I writing job? I am on it. Header: Hey, I see you are shooting yourself in the foot. I can help | 01:59 |
| lifeless | there is one more step we can take | 01:59 |
| StevenK | Hahaha | 01:59 |
| lifeless | which is to use transitively_private and short circuit when it is set. | 01:59 |
| wallyworld_ | lifeless: but we don't limit the recursive query to take that into account | 01:59 |
| wallyworld_ | yes, so we add the short circuit | 02:00 |
| wallyworld_ | that's a nice optimisation | 02:00 |
| sinzui | stevek prose: By unsubscribing from this bug you are trading lots of exciting spam for 404's Click Oops to stop this. | 02:00 |
| poolie | hloeung, wgrant, it's not obviously responding to my mail, so i think i do need process-mail run by hand | 02:01 |
| poolie | i'm pretty sure this was needed last time too | 02:01 |
| poolie | robert said something abotu it creating too much load to run it automatically | 02:01 |
| wgrant | poolie: We should set up a regular cron job, and bump staging's frequency. | 02:01 |
| wgrant | poolie: Since as of like 12 hours ago we have a new staging scripts server. | 02:01 |
| hloeung | wgrant: file an RT to have that done. In the meantime, I'll run process-mail by hand | 02:02 |
| poolie | so should you file an rt for that or something? | 02:02 |
| poolie | thanks | 02:02 |
| * wgrant RTs | 02:03 | |
| wgrant | #47933 | 02:04 |
| _mup_ | Bug #47933: [Feisty] system requires acpi=off noapic nolapic <cft-2.6.27> <linux-source-2.6.20> <linux (Ubuntu):Won't Fix> <linux-source-2.6.20 (Ubuntu):Won't Fix> < https://launchpad.net/bugs/47933 > | 02:04 |
| hloeung | poolie: ok, done | 02:05 |
| hloeung | wgrant: ta | 02:05 |
| poolie | woo hoo | 02:05 |
| poolie | that's so awesome | 02:06 |
| poolie | thanks | 02:06 |
| wgrant | poolie: Oh, it worked? :/ | 02:06 |
| poolie | only a wry face? | 02:06 |
| wgrant | poolie: gandwana doesn't seem to be able to talk to the mailserver. | 02:06 |
| wgrant | File "/srv/staging.launchpad.net/staging/launchpad/lib/lp/services/mail/mailbox.py", line 119, in open | 02:06 |
| wgrant | raise MailBoxError(str(e)) | 02:06 |
| wgrant | MailBoxError: [Errno 111] Connection refused | 02:06 |
| poolie | it did work | 02:06 |
| poolie | https://bugs.qastaging.launchpad.net/launchpad/+bug/800275 | 02:06 |
| _mup_ | Bug #800275: boot splash not branded <ugr-ebuild:Confirmed for soaringsky> < https://launchpad.net/bugs/800275 > | 02:06 |
| wgrant | hloeung: Did you run it on asuka? | 02:06 |
| poolie | hloeung, can it ever send outgoing mail? | 02:07 |
| hloeung | wgrant: yeah, I ran it on asuka | 02:07 |
| poolie | also, can you tell me what software is involved in delivering the message to lp? | 02:07 |
| wgrant | poolie: We can run send-bug-notifications.py (on asuka, not gandwana yet, or we will be in big trouble) and it will end up in the staging mailbox. | 02:08 |
| wallyworld_ | lifeless: btw, thanks for all the xecellent input on getting that query optimised. i'm really pleased with the result | 02:08 |
| poolie | does it really (as that traceback suggests) read it over pop/imap? | 02:08 |
| wgrant | Yup. POP3. | 02:08 |
| wgrant | Really we should have a handler in the MTA which sticks it in rabbitmq or something. | 02:08 |
| wgrant | Where it's picked up by a daemon. | 02:09 |
| wgrant | Rather than being a */3 cronjob. | 02:09 |
| lifeless | wallyworld_: http://paste.ubuntu.com/690457/ | 02:09 |
| lifeless | wallyworld_: this is more of a rewrite | 02:09 |
| lifeless | wallyworld_: it implements the recursion short circuit when you encounter a calculated transitively private | 02:09 |
| lifeless | wallyworld_: it can do 800 a loop | 02:09 |
| lifeless | in < 2 seconds | 02:09 |
| wallyworld_ | lifeless: i was in the middle of writing something similar myself :-) but you beat me to it | 02:10 |
| lifeless | can't predict behaviour once you're 30/40K in trivially. | 02:10 |
| lifeless | wallyworld_: happy to help | 02:10 |
| lifeless | wallyworld_: I'm satisfied this will do reasonably well; I'm going to leave it here until/unless you ping me again | 02:11 |
| wallyworld_ | lifeless: np. it's all good. i'll check the unit test passes and then do a db-devel branch with the index | 02:12 |
| poolie | hloeung, process-mail again please? | 02:12 |
| hloeung | poolie: sure | 02:12 |
| poolie | and once more? | 02:15 |
| hloeung | poolie: done | 02:16 |
| poolie | super | 02:16 |
| poolie | looks like it all works | 02:16 |
| poolie | thanks very much | 02:17 |
| hloeung | np | 02:17 |
| sinzui | StevenK, http://pastebin.ubuntu.com/690460/ | 02:20 |
| wallyworld_ | hloeung: at some stage, no hurry, there's a new feature flag to go on production documented on LaunchpadProductionStatus | 02:21 |
| StevenK | sinzui: Thank you, that is excellent. | 02:21 |
| hloeung | wallyworld_: added | 02:23 |
| poolie | ok now some more real work | 02:23 |
| wallyworld_ | hloeung: legend! thanks! | 02:24 |
| poolie | what does 'orphaned' mean in the deployment report? that there's another branch for that bug? | 02:54 |
| wgrant | poolie: There is no open bug related to the landing. | 03:10 |
| wgrant | poolie: This could be because it was landed as testfix or a rollback, so has no bug, or the associated bug(s) are closed. | 03:11 |
| lifeless | mwhudson: branch tokens - I think we need to talk about them :) | 03:18 |
| lifeless | mwhudson: I have some fears | 03:19 |
| lifeless | mwhudson: if you can make some time next week, that would be great | 03:19 |
| mwhudson | lifeless: yeah sure | 03:19 |
| mwhudson | lifeless: can you articulate your fears at all? | 03:19 |
| mwhudson | i.e. conceptual problems, security problems, performance...? | 03:19 |
| lifeless | performance impact, user model impact, bzr ui impact | 03:19 |
| lifeless | auditability too | 03:20 |
| lifeless | and long term interaction with oauth/openid for bzr | 03:20 |
| lifeless | (I want to ditch ssh keys altogether in some ways) | 03:20 |
| poolie | really? | 03:21 |
| poolie | tell me more? | 03:21 |
| lifeless | poolie: we've spoken about this before | 03:21 |
| poolie | i have an awful memory | 03:21 |
| poolie | can you prompt it | 03:21 |
| lifeless | poolie: I haven't advanced any plans, but ssh key management is a real headache for new users | 03:21 |
| lifeless | doing an API style login once on the client would be much nicer. | 03:21 |
| poolie | i would certainly agree with making them a lot less manually maintained | 03:22 |
| poolie | right | 03:22 |
| mwhudson | lifeless: would you be less concerned if i just targeted removing the puller? | 03:22 |
| lifeless | mwhudson: I think jelmer will have that done soon anyway :) | 03:22 |
| lifeless | mwhudson: won't he ? | 03:22 |
| mwhudson | lifeless: no | 03:22 |
| wgrant | Still needed for imports. | 03:22 |
| mwhudson | the import puller will still be required | 03:22 |
| lifeless | mwhudson: so, we should talk :) | 03:22 |
| mwhudson | ok | 03:22 |
| mwhudson | lifeless: i suspect your diary is massively more cluttered than mine, feel free to do something involving calendaring applications and michael.hudson@linaro.org | 03:23 |
| lifeless | mwhudson: i'll ping you monday :) | 03:25 |
| mwhudson | lifeless: ok | 03:25 |
| lifeless | lowtek ftw | 03:25 |
| mwhudson | relying on memory << * in my case though :) | 03:28 |
| poolie | kk lunch biab | 03:28 |
| mwhudson | is there a private xml-rpc server method to check for a feature flag? | 03:37 |
| wgrant | No. | 03:37 |
| wgrant | It's not quite trivial, since you'd need some way to work out scopes. | 03:38 |
| mwhudson | what are scopes again? things like projects and teams? | 03:40 |
| wgrant | https://launchpad.net/+feature-info | 03:40 |
| wgrant | " | 03:40 |
| wgrant | Scopes" section | 03:40 |
| mwhudson | ah nice | 03:40 |
| mwhudson | well, as nice as it would be to restrict anonymous ssh logins to members of a team ... :) | 03:42 |
| nigelb | wallyworld_: \o/ landed that branch last evening :-) | 04:33 |
| lifeless | wgrant: mwhudson: pass in a dict of literal scopes you're interested in | 04:37 |
| lifeless | as a first-pass approximation | 04:37 |
| poolie | mwhudson, most obviously you could limit by ip | 04:38 |
| poolie | maybe also ssh client signature | 04:38 |
| lifeless | that will let some obvious ones like page-id be passed in | 04:38 |
| wgrant | lifeless: I considered that. | 04:38 |
| wgrant | Maybe. | 04:38 |
| lifeless | for a v1 lets get unblocked thing | 04:39 |
| lifeless | its fine. | 04:39 |
| lifeless | internal-only. | 04:39 |
| poolie | o/ huwshimi | 04:47 |
| * mwhudson contemplates the fun that is adding xmlrpc methods to lp | 04:47 | |
| huwshimi | poolie: Hey! | 04:47 |
| nigelb | mwhudson: xmlrpc it self is "fun" :-) | 04:48 |
| mwhudson | also true | 04:48 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| lifeless | wgrant: what are the '53' | 05:10 |
| poolie | lifeless, sorry to re-ask something i asked a month or two ago, but | 05:11 |
| lifeless | 42 | 05:11 |
| poolie | once revisions are qa'd on stable, they'll deploy within a few days? | 05:11 |
| lifeless | ideally ;) | 05:11 |
| wgrant | No. | 05:11 |
| wgrant | Ideally within 24 hours. | 05:11 |
| poolie | unless something else fails on production, or fails to qa? | 05:12 |
| lifeless | it all depends on someone putting up a deployment request, other revisions not being in the way etc. | 05:12 |
| wgrant | Unless stuff goes wrong, they're generally out in 24 hours. | 05:12 |
| lifeless | the goal time is < 1 hour from qa | 05:12 |
| lifeless | but we are far from that yet | 05:12 |
| wgrant | lifeless: Ah, that email is mostly directed at Julian. https://devpad.canonical.com/~wgrant/2011/soyuz-expiration-blargh.html is not light reading. | 05:12 |
| wgrant | lifeless: But, in summary, there are 53 BPRs published since hardy that are illegaly expired. | 05:13 |
| wgrant | Because they're still published in the primary archive. | 05:13 |
| lifeless | righto | 05:13 |
| nigelb | Ugh, Tal. | 05:13 |
| wgrant | We need to recover them from the archive. | 05:13 |
| lifeless | I've read it now | 05:14 |
| lifeless | thanks | 05:14 |
| lifeless | jamesh: hi | 05:15 |
| lifeless | jamesh: got 5 ? | 05:15 |
| jamesh | sure. | 05:15 |
| huwshimi | Does anyone here use Identi.ca? I have an issue identical to this post but I don't understand what they're talking about: http://forum.status.net/discussion/873/badge-identica-badge.js-not-working-with-my-statusnet-installation/p1 (I'm asking here because I'm trying to set up something for Launchpad). | 05:15 |
| poolie | i use it but not the badge feature | 05:16 |
| poolie | idnetical how? | 05:16 |
| lifeless | jamesh: so, I think: timeline wsgi injector should be a separate timeline-wsgi project; storm can grow a timeline_factory that timeline-wsgi talks to. python-oops-timeline should exist and have the context -> report code in it. | 05:17 |
| lifeless | jamesh: so 2 new trivial projects, a patch to storm, and we're done | 05:17 |
| huwshimi | poolie: I have the same issue, as in, no posts show up on the badge. That post seems to say something about only friends posts showing up, but I don't understand the identi.ca language enough to know what they're saying | 05:18 |
| poolie | oh you want launchpadstatus's badge to be somewhere? | 05:19 |
| poolie | i thought you were trying to implement lp badges or something | 05:19 |
| jamesh | lifeless: so what would python-oops-timeline hold exactly? Just the code to add the timeline to environ['oops.context'] and some on_create handlers? | 05:19 |
| jamesh | or something more? | 05:19 |
| poolie | o/ jamesh | 05:19 |
| huwshimi | poolie: yeah I'm trying to show it on a status page | 05:19 |
| poolie | huwshimi, i suspect 'friends' is a hippy equivalent of twitter 'following' | 05:20 |
| lifeless | jamesh: oops-timeline would be on_create handlers | 05:20 |
| nigelb | statik: LOVE the reply you got from DEVOPS_BORAT :-) | 05:20 |
| poolie | and launchpadstatus has no friends :) | 05:20 |
| poolie | let's see if that's true | 05:20 |
| jamesh | or I suppose it could do without copying to oops.context, since you could go context['wsgi_environ']['timeline.whatever'] | 05:20 |
| lifeless | jamesh: thats timeline-esgi :) | 05:20 |
| lifeless | *timeline-wsgi* | 05:20 |
| poolie | it's true: no friends | 05:21 |
| lifeless | jamesh: I'm trying to avoid having specific projects have code for sibling projects in them | 05:21 |
| jamesh | lifeless: okay. So the timeline-wsgi module knows about oops-wsgi. That sounds fine. | 05:21 |
| mwhudson | i wonder who DEVOPS_BORAT is | 05:21 |
| jamesh | or alternatively the other way around | 05:21 |
| lifeless | perhaps call it timeline-oops-wsgi; then it clearly can know about oops variables | 05:21 |
| mwhudson | sometimes it feels like it must be someone i know | 05:21 |
| wgrant | mwhudson: Heh, yes. | 05:22 |
| poolie | huwshimi, i wonder what happens if lpstatus follows itself | 05:22 |
| lifeless | jamesh: or as we touched on the other day, environ['timeline.timeline'] could be the dedicated variable | 05:22 |
| huwshimi | poolie: Can we make that happen? | 05:22 |
| jamesh | lifeless: if the only connection is that it does "if 'oops.context' in environ: environ['oops.context']['timeline'] = timeline", then I don't think an extra package is worth it | 05:22 |
| poolie | apparently no | 05:22 |
| lifeless | jamesh: So I've found, when I dig into some java stacks, that having *tiny* packages is actually very useful | 05:23 |
| huwshimi | poolie: OK, I might give up and use the twitter feed instead. | 05:23 |
| lifeless | jamesh: it keeps the dependency chain very lean, when you go to reuse. | 05:23 |
| huwshimi | poolie: Thanks for your help :) | 05:23 |
| poolie | i have an idea | 05:23 |
| lifeless | jamesh: I know storm doesn't do this, but I wish more code did. | 05:23 |
| lifeless | it would be -awesome- if the overhead of doing a single python module (not package) was lighter. | 05:24 |
| lifeless | jamesh: it won't have a practical difference for you though, will it ? | 05:25 |
| poolie | huwshimi, what happens if you just make a copy of the js, and change 'statuses/friends' to 'statuses/user_timeline'? | 05:25 |
| poolie | i reckon there's a fair chance that will work | 05:25 |
| jamesh | lifeless: I guess not. It is one more thing to package though | 05:25 |
| huwshimi | poolie: I can do that (and it will probably work), but I'm trying to limit the number of working parts as this will appear when LP is down. | 05:26 |
| jamesh | [we haven't drunk the buildout kool aid] | 05:26 |
| lifeless | jamesh: time to give pkgme a test drive then :) | 05:32 |
| lifeless | jamesh: these should be ideal cases for fully automated packaging | 05:33 |
| lifeless | wgrant: welcome to the dark side | 05:40 |
| lifeless | stub: yo | 05:40 |
| stub | yo | 05:41 |
| wgrant | lifeless: Heh. | 05:41 |
| lifeless | stub: time for a catchup ? | 05:41 |
| wgrant | I indeed finally gave in :( | 05:41 |
| stub | lifeless: sure. Gimme a sec to boot the lappy | 05:41 |
| stub | and steal my mike back | 05:41 |
| lifeless | you want to be like mike/ | 05:41 |
| lifeless | ? | 05:41 |
| huwshimi | When the database goes down at the moment do we currently display anything? What's involved to put a [new] page there? | 05:48 |
| huwshimi | stub: Matthew said you might know something about this...^ | 05:48 |
| stub | huwshimi: Bug #840098 | 05:50 |
| _mup_ | Bug #840098: Librarian should return 503 pages during database outages <qa-ok> <Launchpad itself:Fix Committed by stub> < https://launchpad.net/bugs/840098 > | 05:50 |
| wgrant | huwshimi: We just display an Oops page now. | 05:50 |
| wgrant | huwshimi: We can put whatever you want there, basically... as long as it doesn't involve DB access, obviously. | 05:50 |
| huwshimi | wgrant: OK, I have (most of) a static HTML page (a little js and some images too) that will go there. Do you know how I can make this work? | 05:52 |
| nigelb | wgrant: dark side? | 05:53 |
| wgrant | nigelb: I created a Twitter account. | 05:53 |
| nigelb | OHMYGOD | 05:53 |
| nigelb | @wgrant? | 05:53 |
| StevenK | wgrant: We can no longer be friends. | 05:53 |
| wgrant | nigelb: I need to try to claim that using the 9 month rule. @wgrant_ for now. | 05:54 |
| wgrant | Nasty common names :( | 05:54 |
| huwshimi | StevenK: No, but you can be followers | 05:54 |
| StevenK | huwshimi: Boo, hiss. | 05:54 |
| nigelb | wgrant: _ is the new style on twitter | 05:54 |
| nigelb | huwshimi++ | 05:54 |
| wgrant | huwshimi: It should ideally use normal LP JS/image infrastructure. | 05:54 |
| wgrant | huwshimi: As it's rendered by LP, like any other view, except without the DB. | 05:54 |
| wgrant | huwshimi: Just like the current OOPS page. | 05:55 |
| mwhudson | poolie: could you look at https://code.launchpad.net/~mwhudson/launchpad/feature-flag-xmlrpc/+merge/75673 briefly? | 05:56 |
| poolie | +"""XXX: Module docstring goes here.""" | 05:57 |
| poolie | or not :) | 05:57 |
| mwhudson | well yes, not that stuff: | 05:57 |
| nigelb | heh | 05:57 |
| mwhudson | """Not ready yet (docstrings need writing etc) but would like feature flag manipulation looked at please :)""" | 05:57 |
| nigelb | wgrant: Can we have a tumblbeast? :) | 05:57 |
| poolie | i know i'm just being snarky | 05:57 |
| poolie | yes, please | 05:58 |
| poolie | or, that's more of huwshimi's department, beasts | 05:58 |
| wgrant | Heh | 05:58 |
| wgrant | Was that the one TheOatmeal created? | 05:58 |
| nigelb | yeah | 05:58 |
| nigelb | its free to use now | 05:58 |
| * mwhudson goes to the pub | 05:59 | |
| poolie | oops | 05:59 |
| poolie | mwhudson, it's not obviously wrong but i don't really understand it | 05:59 |
| mwhudson | poolie: ok, let's talk next week then :) | 05:59 |
| poolie | ok | 05:59 |
| nigelb | I'm having brunch and mwhudson is headed to the pub. | 06:00 |
| poolie | the intention is good | 06:00 |
| nigelb | timezones.sigh. | 06:00 |
| poolie | cheerio mwh | 06:00 |
| StevenK | nigelb: Then move to Australia? | 06:00 |
| nigelb | haa. | 06:00 |
| mwhudson | nigelb: what bothers me is when i'm going to the pub, and my colleague in POLAND hasn't stopped working yet | 06:00 |
| nigelb | heh | 06:01 |
| nigelb | mwhudson: It probably bothers him more :P | 06:01 |
| nigelb | him/her | 06:01 |
| poolie | what bothers me is when i come home from the pub and robert is still working | 06:01 |
| nigelb | StevenK: Only if it were that easy. | 06:01 |
| nigelb | poolie wins | 06:01 |
| huwshimi | poolie: It's only when I'm in another timezone when I realise how many people here work *very* late | 06:02 |
| nigelb | Oh wgrant doesnt have a concept of time. | 06:03 |
| nigelb | Neither does StevenK. | 06:03 |
| wgrant | Last night was particularly bad. | 06:04 |
| wgrant | Since a script I expected to take 3 hours actually took 13 hours. | 06:04 |
| nigelb | Could someone help me with this? http://paste.ubuntu.com/690527/ | 06:05 |
| wgrant | nigelb: You have a tag mismatch somewhere. | 06:06 |
| nigelb | I've been trying to trace it without much luck :( | 06:07 |
| nigelb | http://paste.ubuntu.com/690530/ <-- pt file | 06:09 |
| wgrant | Which table are you trying to close on line 68? | 06:09 |
| wallyworld_ | wgrant: StevenK: do you see an issue with lowering the minimum picker search term length from 3 chars to 2? perhaps if term is < 3 chars do not do fti search, just exact match to lp name | 06:09 |
| wgrant | That table seems to be opened in the previous metal:widgets. | 06:09 |
| wallyworld_ | for bug 768148 | 06:10 |
| _mup_ | Bug #768148: person picker does not handle exact matches well - including not permitting exact matches for usernames < 3 characters long. <person-picker> <Launchpad itself:Triaged> < https://launchpad.net/bugs/768148 > | 06:10 |
| nigelb | the one in line 25 | 06:10 |
| wgrant | nigelb: I think 68 is trying to close the table on 25, but they are in separate macros. | 06:10 |
| nigelb | Oh. I can't do that? | 06:10 |
| wgrant | This is approximately XML. | 06:11 |
| wgrant | It's not text-based like Django markup. | 06:11 |
| nigelb | :D | 06:11 |
| nigelb | You guessed where I'm coming from. | 06:11 |
| nigelb | Argh. Need to ask sinzui for help. | 06:12 |
| nigelb | I'm not sure how to get this workign without it being ugly. | 06:12 |
| wallyworld_ | nigelb: cani help at all? | 06:14 |
| nigelb | wallyworld_: ohai, I'm trying to fix bug 80660 without killing kittens and without it being ugly. | 06:15 |
| _mup_ | Bug #80660: GAIM2.0b5 crashes on quit <gaim (Ubuntu):Invalid> < https://launchpad.net/bugs/80660 > | 06:15 |
| nigelb | err | 06:15 |
| nigelb | 806660 | 06:15 |
| nigelb | bug 806660 | 06:15 |
| _mup_ | Bug #806660: "Add a new address" in e-mail settings does the wrong thing when pressing Enter <easy> <ui> <Launchpad itself:Triaged by nigelbabu> < https://launchpad.net/bugs/806660 > | 06:15 |
| wallyworld_ | but i hate cats. they all must die | 06:15 |
| * wallyworld_ looks at bug | 06:15 | |
| nigelb | wallyworld_: heh, on that you should look at Amber's (Graner) facebook photos (if you are her friend on fb) | 06:16 |
| StevenK | wallyworld_: http://cheezburger.com/kenneystudios/lolz/View/1802695936 | 06:16 |
| wallyworld_ | nigelb: i hate fb more than i hate cats. and i hate twitter too. total waste of time | 06:16 |
| nigelb | heh | 06:16 |
| wallyworld_ | StevenK: don't know where you find this stuff | 06:18 |
| nigelb | StevenK probably has subscription to icanhazcheesburger | 06:18 |
| nigelb | I do as well. BUt to one of their smaller sites. | 06:19 |
| wallyworld_ | nigelb: so did you try splitting the form into two like suggested in the bug report? | 06:24 |
| nigelb | I did. | 06:25 |
| nigelb | It was ugly | 06:25 |
| wallyworld_ | no luck? | 06:25 |
| nigelb | What I did was split the table | 06:25 |
| nigelb | Because semantically, I cannot have one form in another form. | 06:25 |
| nigelb | And a form must either include the entire table or be only in one td. | 06:25 |
| wallyworld_ | yes | 06:26 |
| wallyworld_ | and that didn't work? having two tables? | 06:27 |
| nigelb | It worked! | 06:27 |
| nigelb | BUt it was ugly with lots of padding | 06:27 |
| nigelb | Can we fix that? | 06:27 |
| nigelb | s/padding/margin/ | 06:27 |
| wallyworld_ | can i see what you did? | 06:27 |
| nigelb | sure | 06:27 |
| nigelb | sec, let me restore yesterday's changes | 06:28 |
| nigelb | Oh gah. | 06:28 |
| nigelb | Give me 5 minutes I'll have to do it from scratch. Shoulda commited at safe point. | 06:28 |
| wallyworld_ | ok, just ping me | 06:29 |
| wgrant | Shelve is handy. | 06:29 |
| wgrant | Except when I end up with 60 shelves in devel. | 06:29 |
| wallyworld_ | my ide has shelve built in :-) | 06:29 |
| wgrant | Does PyCharm have juju integration yet? | 06:29 |
| wallyworld_ | nope :-) | 06:29 |
| nigelb | juju? | 06:30 |
| nigelb | ensemble? | 06:30 |
| wallyworld_ | s/ensemble/juju | 06:30 |
| wallyworld_ | they renamed it | 06:30 |
| nigelb | I like ensemble better :P | 06:30 |
| wgrant | Yeah. | 06:30 |
| wallyworld_ | so does everyone else | 06:30 |
| wallyworld_ | when people found out, they wore out the WTF keys | 06:31 |
| wgrant | Ahem. | 06:31 |
| nigelb | lol | 06:32 |
| wgrant | Yay, git branch importing works. | 06:32 |
| wgrant | jelmer: Do you want a bzr bug for http://launchpadlibrarian.net/80061780/wgrant-mochiweb-R12B.log? | 06:34 |
| wgrant | jelmer: I tried to use the original ,somebranch syntax instead of ,branch=somebranch | 06:34 |
| wgrant | jtv: Do you have branches to entirely abolish katie yet? | 06:42 |
| nigelb | branch scanning broken? | 06:44 |
| jtv | wgrant: yes, have a look at lp:launchpad. | 06:44 |
| jtv | wgrant: that's katie gina's buddy, not the other katie. | 06:44 |
| wgrant | jtv: Ah, hadn't checked that in a few hours. | 06:44 |
| wgrant | Nice, thanks. | 06:44 |
| jtv | Tsk. | 06:44 |
| jtv | Way behind the times. | 06:44 |
| jtv | Soooo 07:44 ITC. | 06:45 |
| nigelb | Despite living in the future. | 06:45 |
| wgrant | nigelb: Which branch isn't scanned? | 06:45 |
| nigelb | https://code.launchpad.net/~nigelbabu/launchpad/registry-email-add-806660 | 06:45 |
| nigelb | Its been 8 minutes. Launchpad is faster than that! | 06:46 |
| wgrant | Hmm, 13 minutes. | 06:46 |
| wgrant | That's not good. | 06:46 |
| nigelb | wallyworld_: So, it looks like this -> http://people.ubuntu.com/~nigelbabu/first-try.png | 06:47 |
| * wallyworld_ looks | 06:47 | |
| wgrant | Is that Lucid? | 06:47 |
| wgrant | Possibly Maverick. | 06:47 |
| wgrant | Old, anyway. | 06:47 |
| nigelb | Lucid | 06:47 |
| nigelb | How did you know.... | 06:47 |
| wgrant | The buttons are too brown. | 06:48 |
| * nigelb bows. | 06:48 | |
| nigelb | And here's my diff -> http://paste.ubuntu.com/690552/ | 06:48 |
| nigelb | wgrant: I still haven't come to terms with unity. | 06:48 |
| wallyworld_ | nigelb: there's too much vertical space isn't there | 06:48 |
| nigelb | Yeah | 06:48 |
| nigelb | That's because they're in two different divs. | 06:49 |
| nigelb | I don't know if I can move them into one. | 06:49 |
| nigelb | Since the div itself is constructed from the <metal.. | 06:49 |
| nigelb | (or so I think) | 06:49 |
| wallyworld_ | nigelb: did you check to see if any ccs is in use for any of the div/table/form elements that may be adding the vertical padding | 06:50 |
| wgrant | nigelb: Your branch scanned a couple of minutes after you asked. Still waiting on logs to see what the delay was. | 06:51 |
| huwshimi | So, upgraded to Oneiric, rocketfuel-get, rocketfuel-branch foo, in foo: make schema: 'psycopg2.ProgrammingError: type "debversion" does not exist'. What else do I need to do? | 06:51 |
| huwshimi | ... oh and I'm just assuming this has something to do with the Oneiric upgrade, it may well not be | 06:51 |
| wgrant | huwshimi: Sounds like the launchpad PPA was disabled during the upgrade. | 06:51 |
| wallyworld_ | huwshimi: did you install launchpad-devel-dependencies? | 06:52 |
| huwshimi | wgrant: Oh yeah, I think you're right | 06:52 |
| wgrant | huwshimi: Make sure it's enabled, pointing to oneiric instead of natty, and then reinstall launchpad-developer-dependencies. | 06:52 |
| huwshimi | wgrant: Thanks | 06:52 |
| wgrant | I fixed that debversion issue in the PPA a couple of weeks ago. | 06:52 |
| wgrant | So it should work. | 06:52 |
| nigelb | wallyworld_: So, what's adding the margin is table and form elements | 06:52 |
| nigelb | (fun!) | 06:52 |
| nigelb | wgrant: Excellent! I broke it? :D | 06:52 |
| wallyworld_ | nigelb: are they rendered with a css style? | 06:53 |
| wallyworld_ | a specific css style? | 06:53 |
| nigelb | No. | 06:53 |
| nigelb | table.form | 06:53 |
| nigelb | and form | 06:53 |
| nigelb | generic styles | 06:53 |
| wallyworld_ | so perhaps you could initially try using an inline style with no padding/margins etc and see if that works | 06:54 |
| nigelb | Is that kosher? :-) | 06:54 |
| wallyworld_ | just to see if it works | 06:54 |
| nigelb | ah | 06:54 |
| wallyworld_ | then we can either define a style in the template (like is sometimes done for a one off) or see if there's already one in styles-3.0.css | 06:55 |
| nigelb | You mean a style="margin: 0;" right? | 06:55 |
| wallyworld_ | something liek that | 06:55 |
| nigelb | Can't touch <form> because its created by a macro. | 06:55 |
| wallyworld_ | there is a way, i've seen it used but can't recall where exactly | 06:56 |
| nigelb | let me check the macros. | 06:56 |
| wallyworld_ | nigelb: you may not need the initial form macro. just using a stock <form> may work | 06:57 |
| wallyworld_ | i'd have to experiment a bit | 06:58 |
| nigelb | ok | 06:58 |
| wallyworld_ | nigelb: in the template you are editing is an example of using a standard <form> element rather than the macro | 07:05 |
| nigelb | wallyworld_: worked :) | 07:05 |
| nigelb | I just added the inline styles from firebug. | 07:05 |
| wallyworld_ | excellent! | 07:05 |
| wallyworld_ | nigelb: i have to go out and pick up my wife from downtown | 07:06 |
| === wallyworld_ changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 261 - 0:[########*** stack smashing detected ***: ./lp terminated | ||
| wgrant | Brisbane has a downtown? | 07:07 |
| wallyworld_ | wgrant: i was using the venacular that nigelb would understand as an american :-) | 07:07 |
| wallyworld_ | s/downtown/cbd :-P | 07:07 |
| nigelb | haha | 07:08 |
| nigelb | wallyworld_: I'm not American | 07:08 |
| nigelb | Think East :-) | 07:08 |
| wallyworld_ | east of where? | 07:08 |
| nigelb | I'm from India | 07:08 |
| wgrant | nigelb: East of us is the US :P | 07:08 |
| wallyworld_ | oh, ok. sorry! | 07:08 |
| nigelb | wgrant: HA. | 07:09 |
| nigelb | East of the US! | 07:09 |
| wallyworld_ | what part of india? i've been to Bangalore | 07:09 |
| nigelb | But that was a fail attempt at referring to East India Company | 07:09 |
| nigelb | wallyworld_: I live in Bangalore :-) | 07:09 |
| wallyworld_ | :-) | 07:09 |
| wallyworld_ | Cat Logistics CLSI have an office in Whitexxxxx rd or something like that | 07:10 |
| wallyworld_ | east of the city centre i think | 07:10 |
| nigelb | Whitefield | 07:10 |
| wallyworld_ | yes, that's it | 07:10 |
| wallyworld_ | i was there in 2008 | 07:10 |
| wallyworld_ | when i worked for Caterpillar | 07:10 |
| nigelb | You should visit again! | 07:11 |
| wallyworld_ | i hope so. i really liked it :-) | 07:11 |
| nigelb | Its got a really awesome weather. | 07:11 |
| nigelb | I probably won't leave the city just for that. | 07:11 |
| wallyworld_ | i really liked the food | 07:11 |
| wallyworld_ | nigelb: but i do have to go, to get to the cbd :-) | 07:11 |
| nigelb | :) | 07:12 |
| * wallyworld_ runs away | 07:12 | |
| nigelb | wgrant: You should tweet too. Not just sign up for twitter and follow people ;-) | 07:12 |
| wgrant | Maybe :) | 07:14 |
| Peng | Where's the fun in *that*? | 07:15 |
| * nigelb blinks. | 07:16 | |
| nigelb | Peng: Are we both on another network as well? | 07:16 |
| nigelb | My brain just got horribly confused seeing you in freenode :) | 07:17 |
| Peng | Possibly. And it's not an uncommon nick. | 07:17 |
| stub | huwshimi: On a call before and cited the wrong bug (not that you need the right one as it is assigned to you!) | 07:36 |
| huwshimi | stub: Yeah, all good, I saw that | 07:37 |
| stub | huwshimi: So 1) wording and design of the page, or just wording. 2) Register it as a view on storm.exceptions.DisconnectionError 3) Tests to ensure that when the db is pulled out from under lp's feed, the expected 503 error page is returned | 07:38 |
| stub | huwshimi: I guess do as much of that as you are comfortable then hand off | 07:38 |
| nigelb | Is this the bug about 503 when database is down? | 07:39 |
| stub | huwshimi: I think wgrant or myself were going to do the wiring. | 07:39 |
| stub | nigelb: I hope so, or I'm confusing the wrong issue. | 07:39 |
| huwshimi | stub, nigelb: yeah that's the one | 07:39 |
| nigelb | \o/ | 07:40 |
| huwshimi | stub: Cool. I am working with matthew on 1. I'm just about to head off for the week, but I'll take a look on Monday and get what I can done. | 07:40 |
| stub | huwshimi: I suspect you just want to do 1) and hand it off | 07:40 |
| wgrant | stub: That's why I didn't give him past step 1 :P | 07:41 |
| huwshimi | stub: If that's easier I don't mind. | 07:41 |
| stub | wgrant: You expect me to pay attention to scrollback? Sheesh. | 07:41 |
| nigelb | heh | 07:41 |
| adeuring | good morning | 07:44 |
| wgrant | Morning adeuring. | 07:45 |
| adeuring | hi wgrant | 07:45 |
| jtv | hi adeuring | 07:45 |
| adeuring | hi jtv | 07:46 |
| nigelb | hi adeuring, jtv | 07:46 |
| mrevell | Hello! | 08:06 |
| nigelb | hello! | 08:07 |
| nigelb | Codehosting throws me twisted.internet.error.CannotListenError: Couldn't listen on any:8022: [Errno 98] Address already in use. | 08:33 |
| === adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring| Critical bugs: 261 - 0:[########*** stack smashing detected ***: ./lp terminated | ||
| nigelb | Nevermind. fixed. | 08:35 |
| nigelb | How do I find what port loggerhead wants? | 08:39 |
| nigelb | It seems to be already in use by something else which I want to kill. | 08:39 |
| stub | Dunno, but my money would be another loggerhead process left unterminated. | 08:50 |
| nigelb | I got it. | 08:50 |
| nigelb | it was 8080 | 08:50 |
| nigelb | I had nginx running there. | 08:50 |
| stub | Is Bug #809118 a dupe of Bug #845397 or are these actually separate things? | 08:54 |
| _mup_ | Bug #809118: builddmaster handling of lp-prod/lp-slave db connection interrupts is untested <fastdowntime> <Launchpad itself:Triaged> < https://launchpad.net/bugs/809118 > | 08:54 |
| _mup_ | Bug #845397: buildd-manager needs to survive database outages <fastdowntime-later> <Launchpad itself:Triaged> < https://launchpad.net/bugs/845397 > | 08:54 |
| nigelb | I'm horribly confused with codehosting running locally | 08:56 |
| wgrant | nigelb: Oh? | 08:56 |
| nigelb | http://paste.ubuntu.com/690624/ | 08:56 |
| nigelb | where do I see these OOPS details? | 08:56 |
| wgrant | nigelb: Hmm, you've pushed both branches up? It sounds like one or both might not exist. | 08:57 |
| nigelb | I couldn't parse that :) | 08:57 |
| nigelb | I just pushed one branch | 08:57 |
| nigelb | Something into https://code.launchpad.dev/~landscape-developers/landscape/trunk so I could see commit numbers | 08:58 |
| wgrant | nigelb: It seemed to be trying to scan two branches. | 08:58 |
| wgrant | And generate an MP diff from them. | 08:58 |
| nigelb | AH. | 08:59 |
| nigelb | Delete the MP? | 08:59 |
| wgrant | Not necessary. | 08:59 |
| wgrant | Try pushing another branch up, maybe. | 08:59 |
| wgrant | And rerunning make sync_branches. | 08:59 |
| wgrant | Perhaps it will settle down. | 08:59 |
| nigelb | I just deleted. | 08:59 |
| nigelb | No jobs to run. | 09:00 |
| nigelb | wgrant: http://paste.ubuntu.com/690626/ | 09:02 |
| nigelb | There. | 09:02 |
| wgrant | nigelb: The OOPSes should be in /var/tmp/codehosting.test | 09:03 |
| nigelb | Found em. http://paste.ubuntu.com/690627/ | 09:04 |
| wgrant | nigelb: Hm, apache's notrunning? | 09:05 |
| stub | Are 'fiera' users besides the buildd manager fragile for fastdowntime? | 09:05 |
| wgrant | stub: No, buildd-manager is the only one. | 09:05 |
| stub | ok, I'll remove fiera from the fragile list and just add the new buildd_manager user | 09:05 |
| nigelb | wgrant: It is. I see the web page. | 09:05 |
| wgrant | nigelb: Even on the bazaar.launchpad.dev IP address? | 09:06 |
| nigelb | wgrant: Ah not. | 09:06 |
| nigelb | how do I fix? | 09:06 |
| wgrant | Something must be wrong with your Apache config... it works by default once rocketfuel-setup has runs. | 09:09 |
| nigelb | Hrm. | 09:10 |
| nigelb | Do I run rf-setup again? | 09:10 |
| nigelb | ah | 09:10 |
| nigelb | sudo make install | 09:10 |
| nigelb | Still fail. | 09:11 |
| nigelb | Warning: DocumentRoot [/var/tmp/bazaar.launchpad.dev/static/] does not exist | 09:22 |
| nigelb | There's potential fail there. | 09:22 |
| nigelb | wgrant: still around? :) | 09:23 |
| wgrant | nigelb: That shouldn't be a failure. | 09:24 |
| wgrant | nigelb: It sounds like Apache isn't even listening on 127.0.0.99:80. I'm not sure what could be going on there. | 09:24 |
| nigelb | wgrant: It is listening. | 09:25 |
| nigelb | I see entries in error.log | 09:26 |
| wgrant | Hm, why connection refused, then? :/ | 09:26 |
| nigelb | bazaar.launchpad.dev sounds like loggerhead. | 09:27 |
| nigelb | How can I check if its up? | 09:27 |
| wgrant | bazaar.launchpad.dev:80 is Apache, which forwards some requests to loggerhead. | 09:27 |
| nigelb | :/ | 09:27 |
| nigelb | wgrant: Wait a minute. | 09:28 |
| nigelb | 80? | 09:28 |
| nigelb | I have bazaar.launchpad.dev:443, not 80 | 09:28 |
| nigelb | Well, that's the one that gets logged. | 09:28 |
| wgrant | The branch scanner will want :80 | 09:30 |
| nigelb | So, you're right. | 09:31 |
| nigelb | Something's wrong :/ | 09:31 |
| bigjools | lifeless: are you around? | 09:39 |
| stub | bigjools: https://code.launchpad.net/~stub/launchpad/trivial/+merge/75696 | 10:07 |
| bigjools | stub: why not just fix the config? | 10:09 |
| bigjools | I have a feeling tests depend on it | 10:10 |
| stub | bigjools: Cause then other things that use that config item will also move and continue to use buildd-manager's database user | 10:10 |
| stub | bigjools: database usernames in configs has been a WHUI anyway | 10:11 |
| bigjools | indeed | 10:11 |
| bigjools | are you relying on tests failing then? | 10:11 |
| stub | bigjools: --test=buildd passes, I'll wait on ec2 to inform me of further fallout | 10:11 |
| bigjools | ok | 10:12 |
| bigjools | I'll approve it now | 10:12 |
| stub | bigjools: I don't think tests will fail though, as permissions of fiera and buildd_manager are identical. So if a test is connecting using the config username, it will still work. Not a good thing long run, but lets us solve the immediate issue easily. | 10:13 |
| lifeless | WHUI ? | 10:18 |
| lifeless | bigjools: no, but I can be for short bits | 10:18 |
| bigjools | lifeless: I wanted to catch up about python-oops | 10:19 |
| bigjools | if it's not convenient we can do it Monday | 10:19 |
| wgrant | lifeless: We Haven't Used It, I assume. | 10:29 |
| jml | it's the past tense of YAGNI | 10:32 |
| nigelb | YAGNI? | 10:35 |
| StevenK | You Ain't Gonna Need It | 10:35 |
| nigelb | heh | 10:35 |
| bigjools | GIYF | 10:35 |
| StevenK | Give In, You're Fired? | 10:36 |
| bigjools | Google Is Your Friend | 10:36 |
| StevenK | Mine was better. | 10:36 |
| nigelb | Indeed. | 10:36 |
| bigjools | Google, In Your Face | 10:36 |
| nigelb | Now, who's got a few minutes to help me figure out why bazaar.launchpad.dev:80 isn't working? | 10:37 |
| nigelb | (Actually, its why sync branches isn't working, but wgrant and I've gottten it to that point) | 10:37 |
| lifeless | bigjools: ah | 10:44 |
| lifeless | bigjools: I have no idea if monday will be better, but tonight would be awkward | 10:44 |
| bigjools | lifeless: np, it's Friday night. And I have to go to lunch soon too. | 10:44 |
| lifeless | kk, ciao | 10:45 |
| bigjools | I'll muddle through for a bit | 10:45 |
| bigjools | have a good weekend | 10:45 |
| bigjools | wgrant: have you built the txlongpoll branch lately? | 11:11 |
| wgrant | bigjools: Not for a while. What's the buildout error? | 11:12 |
| bigjools | wgrant: no error, but can't run tests as testresources is not in the path | 11:13 |
| wgrant | bigjools: How are you trying to run the tests? | 11:13 |
| bigjools | bin/test | 11:14 |
| wgrant | :( | 11:14 |
| bigjools | as per the README ;) | 11:14 |
| bigjools | if I run up bin/py, "import testresources" fails | 11:14 |
| wgrant | Yeah, that's meant to work. | 11:14 |
| bigjools | so there's a buildout problem | 11:14 |
| wgrant | Let's see... | 11:14 |
| bigjools | and my ken of buildout is not so good | 11:14 |
| wgrant | I learnt quite enough about it during the Thunderdome... | 11:15 |
| * wgrant waits three forevers for buildout to finish. | 11:15 | |
| bigjools | wgrant: ARGH, it's not in install_requires | 11:21 |
| * bigjools fixes | 11:22 | |
| wgrant | bigjools: It shouldn't be. | 11:22 |
| wgrant | It's a test dep. | 11:22 |
| wgrant | buildout is almost done... | 11:22 |
| wgrant | Generated script '/home/wgrant/Development/txlongpoll/trunk/bin/test'. | 11:23 |
| wgrant | Finally. | 11:23 |
| wgrant | Let's see what happens. | 11:23 |
| bigjools | right, it's in extras_require | 11:24 |
| bigjools | something else is missing | 11:24 |
| wgrant | File "/home/wgrant/Development/txlongpoll/trunk/txlongpoll/testing/client.py", line 4, in <module> | 11:25 |
| wgrant | from testresources import ( | 11:25 |
| wgrant | ImportError: cannot import name FixtureResource | 11:25 |
| wgrant | That? | 11:25 |
| bigjools | yes | 11:25 |
| wgrant | Need a new testresources. | 11:25 |
| wgrant | I think a bzr snapshot is required. | 11:25 |
| bigjools | testresources is not in the pathj | 11:26 |
| wgrant | Not for bin/py, no. | 11:26 |
| wgrant | Check buildout.cfg | 11:27 |
| wgrant | Here's a crash course in the critical bits of buildout for this :) | 11:27 |
| wgrant | Each of those sections specifies a recipe. bin/py is built by the 'interpreter | 11:27 |
| wgrant | ' section | 11:27 |
| wgrant | bin/test by the 'test' section. | 11:28 |
| wgrant | The eggs included in each bin/* script are dictated by the eggs directive in each section. | 11:28 |
| wgrant | It follows deps. | 11:28 |
| wgrant | And you can specify an extra_requires section to use by putting it in square brackets after the egg. | 11:28 |
| wgrant | This way the package itself doesn't require rabbitfixture and all that stuff on production. | 11:29 |
| nigelb | Can someone pastebin their /etc/apache2/ports.conf file? | 11:29 |
| allenap | nigelb: http://paste.ubuntu.com/690715/ | 11:30 |
| bigjools | wgrant: ok thanks | 11:30 |
| nigelb | allenap: thanks! | 11:30 |
| bigjools | wgrant: this is far too much like black magic | 11:30 |
| wgrant | bigjools: Nah, this is Zope :) | 11:30 |
| bigjools | like I said ... | 11:30 |
| nigelb | Magic was one of the problems of Zope wwasn't it? | 11:31 |
| bigjools | how did we end up with the tests needing something not in the testresources egg :/ | 11:31 |
| bigjools | that's a rhetorical question | 11:32 |
| wgrant | I thought that was documented, but maybe not :( | 11:32 |
| nigelb | wgrant: is it "normal" for bazaar.launchpad.dev to be directed to launchpad homepage? | 11:33 |
| bigjools | the testresources in the lp tree is 0.2.4_r58 | 11:33 |
| bigjools | as opposed to 0.2.4 in the txlongpoll tree | 11:33 |
| bigjools | and it has FixtureResource | 11:33 |
| wgrant | bigjools: That is sufficient, I believe. | 11:33 |
| wgrant | Yep. | 11:33 |
| bigjools | so I'll just copy that egg for now | 11:33 |
| wgrant | nigelb: Yes. | 11:33 |
| nigelb | \o/ | 11:34 |
| wgrant | bigjools: You'll probably have to delete the old unpacked egg to make it use the new one. | 11:34 |
| bigjools | yes | 11:34 |
| nigelb | wgrant: \o/ \o/ \o/ | 11:35 |
| nigelb | sync_branches worked! | 11:35 |
| wgrant | nigelb: It works? | 11:35 |
| wgrant | nigelb: What'd you change? | 11:35 |
| bigjools | and on that note, FOOD | 11:35 |
| nigelb | wgrant: apache ports.conf was listenign to 8009. Because I have 3 webservers on thsi box. | 11:35 |
| wgrant | Ah. | 11:35 |
| nigelb | I suspected that, thanks to allenap, confirmed, fixed. | 11:35 |
| * bigjools fixes setup.py | 11:36 | |
| nigelb | However, now I know my code doesn't work :D | 11:36 |
| nigelb | Yak shaving is so much fun. | 11:36 |
| nigelb | (not) | 11:36 |
| jtv | wgrant: I have to leave nowish. Will be back in a few hours, but on a low-bandwidth connection. But perhaps you could review, and if appropriate land, this? https://code.launchpad.net/~jtv/launchpad/bug-851684/+merge/75721 | 11:48 |
| jtv | Anyone else? I'm in a hurry! | 12:01 |
| jtv | adeuring, could you review this one? https://code.launchpad.net/~jtv/launchpad/bug-851684/+merge/75721 | 12:01 |
| jtv | I have to run _now_, but I'll be back in an hour or two. | 12:02 |
| adeuring | jtv: sure | 12:02 |
| jtv | thanks! | 12:02 |
| === Ursinha-afk is now known as Ursinha | ||
| === jtv is now known as jtv-afk | ||
| allenap | wgrant, bigjools: Either of you fancy looking at https://code.launchpad.net/~allenap/rabbitfixture/details-breakage-bug-851813/+merge/75726? | 12:11 |
| === matsubara-afk is now known as matsubara | ||
| danilos | matsubara, hi, fwiw, I've replied to the oops-tools MP, thanks for the review :) | 12:29 |
| matsubara | danilos, cool! I'm going to land and roll that out today. thanks for working on that! :-) | 12:30 |
| danilos | matsubara, you are welcome, it was interesting to dive into it a bit :) | 12:31 |
| danilos | matsubara, btw, I don't have to send it to PQM for landing? (I've noticed ~launchpad-pqm is the trunk branch owner) | 12:40 |
| StevenK | launchpad-developer-dependencies *Depends* on postgresql-8.4-doc? *Seriously*? | 12:56 |
| matsubara | danilos, nope, just set a commit message in the MP and tarmac will take care of landing it on trunk | 12:58 |
| danilos | matsubara, cool, I will do that then | 12:59 |
| allenap | adeuring: Got time for a rabbitfixture branch? https://code.launchpad.net/~allenap/rabbitfixture/details-breakage-bug-851813/+merge/75726 | 13:00 |
| adeuring | allenap: time isn't a problem. But I have no real clue about rabbit... | 13:00 |
| allenap | adeuring: This branch doesn't touch the Rabbit parts, it relates to detail handling in testtools. | 13:02 |
| allenap | Don't be alarmed :) | 13:02 |
| adeuring | allenap: ok, I'll look ;) | 13:02 |
| adeuring | but need a coffee first | 13:02 |
| deryck | Morning, all. | 13:03 |
| adeuring | morning deryck | 13:07 |
| bigjools | allenap: approved | 13:08 |
| allenap | bigjools: Ta. | 13:09 |
| allenap | adeuring: bigjools just +1'ed it :-/ eek, sorry. | 13:09 |
| adeuring | np | 13:09 |
| bigjools | ah sorry didn't see you looking at it adeuring | 13:10 |
| StevenK | mtaylor: Is it just me, or does the Ec2 plugin for Jenkins not love OpenStack? | 13:19 |
| matsubara | danilos, branch failed in the tarmac chroot | 13:23 |
| danilos | matsubara, in what way? how can I fix it? | 13:25 |
| matsubara | danilos, the followlinks parameter for os.walk isn't available and due to the failure temp directories are not being properly cleaned up | 13:26 |
| danilos | matsubara, argh, we are not using 2.6 in there? | 13:28 |
| matsubara | danilos, nope, I filed an RT to get that chroot updated to 2.6 | 13:28 |
| matsubara | looking for the RT number, hang on | 13:28 |
| matsubara | https://rt.admin.canonical.com/Ticket/Display.html?id=47591 | 13:29 |
| matsubara | danilos, ^ | 13:29 |
| deryck | adeuring, abentley, henninge -- let's Skype today please. I'll start a conf call. | 13:30 |
| danilos | matsubara, right, fwiw, I believe followlinks=False is the default value anyway, I just wanted to be explicit, so I'll remove it and try again | 13:30 |
| matsubara | danilos, ok. I think it'll still fail now because of the temp directories that were not cleaned up in the previous run | 13:32 |
| danilos | matsubara, right, how can we fix that then? | 13:32 |
| matsubara | danilos, one way to fix it is to have a losa run bzr clean-tree in the chroot | 13:32 |
| matsubara | danilos, or we could add a bzr clean-tree to the Makefile and it'd be run before make check is run | 13:33 |
| abentley | deryck: audio sadness. rebooting. | 13:33 |
| deryck | abentley, ok, cool. | 13:33 |
| danilos | matsubara, should I do that? | 13:34 |
| matsubara | danilos, bzr clean-tree --unknown --force to clean target should be enough | 13:34 |
| matsubara | danilos, please do | 13:35 |
| danilos | matsubara, ack, https://pastebin.canonical.com/52911/ | 13:35 |
| danilos | matsubara, I can probably remove the rms in there then | 13:36 |
| matsubara | danilos, nope, because those are in the .bzrignore file | 13:36 |
| danilos | matsubara, ah, ok | 13:36 |
| danilos | matsubara, yay, merged :) | 13:53 |
| matsubara | danilos, great! | 13:53 |
| mtaylor | StevenK: probably not just you ... it's on my todo list to finish the jclouds plugin | 13:54 |
| allenap | adeuring: Could you review a little fairly simple branch? https://code.launchpad.net/~allenap/launchpad/config-dir/+merge/75737 | 13:55 |
| adeuring | allenap: sure | 13:55 |
| allenap | adeuring: Thanks :) | 13:56 |
| adeuring | allenap: r=me; minor comment | 14:11 |
| allenap | adeuring: Thanks :) | 14:12 |
| === almaisan-away is now known as al-maisan | ||
| benji | I'm having what appear to be SSL problems on a new oneiric LP setup: http://paste.ubuntu.com/690852/ Anyone have any hints? | 14:38 |
| jelmer | benji: I've seen that as well on Oneiric | 14:44 |
| jelmer | but I haven't figured out what's going wrong exactly | 14:44 |
| jelmer | benji: Ian said changing host to hostnossl in pg_hba.conf fixed the issue for him, but that doesn't work here. | 14:45 |
| jelmer | benji: it's worth a shot though | 14:45 |
| benji | jelmer: thanks, I'll give it a shot | 14:47 |
| nigelb | Can I make a branch, & commit to it in a test? | 14:50 |
| jelmer | nigelb: of course | 14:53 |
| nigelb | \o/ | 14:53 |
| jelmer | nigelb: if you have a testcase class that derives from bzr's TestCaseWithTransport, it should be as easy as: | 14:53 |
| jelmer | tree = self.make_branch_and_tree(path) | 14:53 |
| jelmer | revid = tree.commit("My commit message") | 14:53 |
| nigelb | AH, currently its factory, so create a new class for this I guess. | 14:54 |
| nigelb | let me grep as well. | 14:54 |
| nigelb | Thanks! | 14:54 |
| jelmer | nigelb:If you're not in a bzr TestCaseWithTransport, you should be able to use bzrlib.bzrdir.BzrDir.create_branch_convenience(path) | 14:55 |
| jelmer | but you might have to do some other setup as well (overriding the config, etc) | 14:55 |
| nigelb | I'm now thinking if I want all that for my test. | 14:55 |
| nigelb | I may not. | 14:55 |
| jelmer | I would recommend using TestCaseWithTransport if you reasonably can; it will help with test isolation problems. | 14:59 |
| jelmer | e.g. if somebody has setup their bzr to always gpg sign commits you don't want the Launchpad test suite prompting them. | 15:00 |
| === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring, bac| Critical bugs: 261 - 0:[########*** stack smashing detected ***: ./lp terminated | ||
| jelmer | g'morning Brad | 15:00 |
| bac | hello adeuring. how's the reviewing today? | 15:00 |
| bac | hi jelmer | 15:00 |
| adeuring | bac: quiet :) | 15:00 |
| bac | adeuring: no backlog? | 15:01 |
| * bac looks | 15:01 | |
| adeuring | bac: yes, there was an MP... got distracted... | 15:01 |
| === jtv-afk is now known as jtv | ||
| adeuring | jtv: I have 1.5 questions about your MP, see the email | 15:17 |
| jtv | hi adeuring! Yes, I expected as much. By the way, this is all pretty intensely tested, and functionality doesn't change—that's why so few test changes. Should've explained that. | 15:18 |
| adeuring | jtv: so, you think the 65% memory usage are, let's say, tolerable? | 15:18 |
| jtv | For just this once? Absolutely, as long as the script makes enough progress that the problem gets a little smaller every time. | 15:25 |
| jtv | It's not really a matter of catching up with changes; it's more of a data conversion. | 15:25 |
| jtv | adeuring: answered your questions, I hope. | 15:25 |
| * adeuring is looking | 15:25 | |
| jtv | (Kudos for checking the report. I think I've mentioned this recently, but I appreciate a thorough review. :) | 15:26 |
| jtv | Since the hardest of these packages appears to be only a few hundred records, even if the memory problem stays, we can go through a lot of packages before it becomes a problem again—and those packages will be permanently “done.” | 15:27 |
| adeuring | jtv: ok, sounds good. But I am slightly worried about txn.commit() in conjunction with two script instances running | 15:29 |
| adeuring | I have no clue though if bad things can happen at in this case... | 15:29 |
| jtv | adeuring: I don't think the second script instance gets past the startup-and-lock stage, but if it does, transitional domination leaves the last publication record untouched. | 15:30 |
| jtv | So in the case where there's no intervening Debian import, AFAICS they would just duplicate each other's work with no ill effects. | 15:30 |
| jtv | If there is one, things get a little more complicated. Let me try to figure it out. | 15:31 |
| jtv | (Though as I said, the script does use LaunchpadScript locking so I don't think it would be an issue) | 15:31 |
| adeuring | jtv: OK. The alternative would be that this one run that needs a looong time and tons of memory is started manually, while the crontab entry is disabled | 15:31 |
| jtv | Yes, that's what I had in mind. | 15:32 |
| adeuring | though the losas might not agree to such a fix... | 15:32 |
| jtv | We already mentioned it on #-ops and had no objections. | 15:32 |
| adeuring | jtv: ok, the r=me | 15:32 |
| jtv | It's reassuring that your independent thought processes follow the same lines—means less chance that we missed anything. | 15:33 |
| jtv | Thanks! | 15:33 |
| jtv | hey henninge, what time do you get off work today? | 15:46 |
| henninge | jtv: I don't plan to hang around too long ... | 15:46 |
| nigelb | henninge: Where are you moving to? | 15:47 |
| jtv | henninge: nigelb reminded me that it's almost EOW over there. As discussed, we'll have things to talk about afterwards but I wanted to give you an official goodbye & thanks for working with us! | 15:48 |
| nigelb | :) | 15:49 |
| nigelb | HAHAHA | 15:50 |
| nigelb | http://www.customink.com/lab/?cid=zab0-000k-p2qg | 15:50 |
| henninge | nigelb: hang around *the office* of course ;-) | 15:50 |
| nigelb | henninge: haha :) | 15:51 |
| henninge | jtv: thank you very much! I enjoyed it greatly, too. | 15:51 |
| jtv | henninge: and I'm sure I'm not the first to say it, but if you ever need a reference, no need to ask. :) | 15:52 |
| henninge | jtv: no you are not but I am glad I hear it so much. ;-) | 15:52 |
| jtv | :) | 15:52 |
| jtv | jelmer: if you're still here, sorry to bother you with it on a Friday afternoon but if you could still get bug 850502 q/a'ed today, that could remove the last blocker for a rather important fix. | 15:57 |
| _mup_ | Bug #850502: probing smart http servers doesn't work with pycurl <code-import> <http> <qa-ok> <smart-protocol> <Bazaar Git Plugin:Fix Committed by jelmer> <Launchpad itself:Fix Committed by jelmer> < https://launchpad.net/bugs/850502 > | 15:57 |
| jelmer | jtv: you are reading my mind | 15:57 |
| jtv | Well, it _is_ the same language. :) | 15:57 |
| jtv | Thanks. | 15:57 |
| jelmer | jtv: I literally marked it as qa-ok 15 seconds before you asked. | 15:57 |
| jelmer | :-) | 15:58 |
| jtv | \o/ | 15:58 |
| jtv | I've got one to Q/A, but I can do it on dogfood together with this fix. | 15:58 |
| nigelb | I wonder why my revision isn't ready for QA yet. | 15:59 |
| bigjools | jtv: every time I clear my throat, is that some meaningful statement in Dutch? | 15:59 |
| jtv | bigjools: yes, and probably about the mother of the enormous Hell's Angel you happen to be talking to. | 15:59 |
| jtv | Why do you ask? | 15:59 |
| jtv | nigelb: it takes a while for the qa-tagger script to notice. | 16:00 |
| nigelb | You've heard of click languages right? | 16:00 |
| nigelb | That's means if you don't "chew" carefully, you might be cursing in some language. | 16:00 |
| nigelb | What's the difference between a product and a project? | 16:05 |
| nigelb | Projects have products? | 16:07 |
| nigelb | Is this the way how launchpad project works? with several products in its umbrella? | 16:07 |
| nigelb | jtv: still around? :) | 16:12 |
| jtv | nigelb: yes, just rather busy with a little crisis. | 16:12 |
| nigelb | ah | 16:12 |
| nigelb | nevermind, i'll try and figure it out :) | 16:13 |
| jtv | Project == Project Group. Product == Product. | 16:13 |
| nigelb | ok, so my guess was right. Cool! (also, psql <3) | 16:13 |
| jtv | Left-hand sides are class names, right-hand sides are UI terms. | 16:13 |
| jtv | Yes, psql is great. | 16:13 |
| === deryck is now known as deryck[lunch] | ||
| === al-maisan is now known as almaisan-away | ||
| sinzui | bac: do you have time to review https://code.launchpad.net/~sinzui/launchpad/person-picker-tab-key/+merge/75771 | 16:34 |
| nigelb | sinzui: Hi! I have a first cut branch for that bug. | 16:35 |
| sinzui | fab | 16:35 |
| nigelb | Instead of doing the tal:condition in span, I had to do it in a tal for it to work | 16:35 |
| nigelb | Writing tests now :) | 16:35 |
| sinzui | nigelb, thanks. I see your diff and It looks as I expect | 16:37 |
| nigelb | \o/ | 16:37 |
| nigelb | If I wwant to do something as admin, do I do this? --> with celebrity_logged_in('admin'): | 16:39 |
| nigelb | Not admin, just a user who can see private branches | 16:39 |
| nigelb | Or do I create a user and add that user to this product so they can see the branches | 16:39 |
| sinzui | nigelb, only an admin and the team with the subscribed team/person can see the branch | 16:40 |
| nigelb | hrm, I think I'll use admin. | 16:40 |
| sinzui | I see lp.code.browser.tests.test_product has both a revision count test and a private test | 16:40 |
| sinzui | I think test_committers_count_private_branch needs one more check to verify that the omitted id is not in the page | 16:41 |
| nigelb | argh. | 16:41 |
| === salgado is now known as salgado-lunch | ||
| nigelb | I started writing in lp.code.tests.test_product. | 16:42 |
| nigelb | Let me move it. | 16:42 |
| sinzui | nigelb, no | 16:42 |
| sinzui | there already is a model and a test | 16:42 |
| nigelb | Oh. | 16:42 |
| nigelb | Ah, I see! | 16:43 |
| sinzui | we just need to add an assertion. we can render the view, get the id, and verify it is None | 16:43 |
| sinzui | nigelb, I think i misread the last test. It shows the owner sees the info. We want to verify the id is in the page for that test. We want an extra test for a non subscriber using the same steps as the existing test | 16:45 |
| nigelb | and not seeing the info. | 16:45 |
| nigelb | right. | 16:46 |
| nigelb | I've not broken anything in that test. which is not good. | 16:46 |
| sinzui | nigelb, This is what I imagined, though have not run the actual test http://pastebin.ubuntu.com/690942/ | 16:50 |
| * nigelb looks | 16:50 | |
| sinzui | nigelb, I copied the test comment. I should have changed it | 16:51 |
| nigelb | wit | 16:51 |
| nigelb | wait | 16:51 |
| * nigelb is cnfused | 16:51 | |
| nigelb | ah, nevermind | 16:52 |
| nigelb | I read your diff wrongly :) | 16:52 |
| nigelb | sinzui: Thanks for the tests! I was doing it in a roundabout way :) | 16:54 |
| sinzui | np. I had these test in mind when I suggested the fix. I should have noted them in the bug | 16:58 |
| nigelb | I got two scary tracebacks http://paste.ubuntu.com/690949/ | 16:59 |
| sinzui | nigelb, I think we need to add the principal arg to get the view | 17:01 |
| sinzui | view = create_initialized_view(product, '+code-index', rootsite='code', principal=observer) | 17:02 |
| sinzui | use fsm in the first test. | 17:02 |
| nigelb | Trying again | 17:03 |
| nigelb | sinzui: second test fails with the same error | 17:06 |
| sinzui | but the first test now works? | 17:06 |
| nigelb | yes | 17:06 |
| sinzui | okay | 17:06 |
| nigelb | bigjools: HA, 300 has been crossed. I'm a happy man ;) | 17:08 |
| bigjools | ? | 17:09 |
| bigjools | ah cricket | 17:09 |
| nigelb | :) | 17:09 |
| bigjools | they'll still lose | 17:09 |
| nigelb | And another wide \o/ | 17:09 |
| bigjools | on the line :/ | 17:09 |
| nigelb | The bribes we paid the umpires are paying off | 17:10 |
| * bigjools off, enjoy your weekend | 17:11 | |
| sinzui | nigelb, are you missing the + in +code-index in the second test? | 17:12 |
| nigelb | sinzui: ah,yes! | 17:14 |
| sinzui | The tb shows 'code-index' | 17:14 |
| nigelb | YEah :-) | 17:15 |
| bac | sinzui: which feature flags do i need to set to see picker work? | 17:15 |
| nigelb | And, there was one mistake I think | 17:15 |
| sinzui | bac: sorry. I forgot | 17:15 |
| nigelb | self.assertEqual(view.committer_count, 0) --> shouldn't that be 1? | 17:15 |
| bac | sinzui: np | 17:15 |
| bac | sinzui: just disclosure.picker_expander.enableddefault 0on | 17:16 |
| bac | ? | 17:16 |
| nigelb | wait. No. | 17:16 |
| sinzui | bac, http://pastebin.ubuntu.com/690967/ | 17:16 |
| bac | sinzui: thanks! | 17:17 |
| nigelb | sinzui: Got an interesting assertionError. | 17:17 |
| nigelb | henninge: \o/ Have a fun-filled future ahead :-) | 17:18 |
| sinzui | nigelb, I think I know what you saw. I should have changed the first assert to check branch_count | 17:18 |
| henninge | nigelb: thank you very much! | 17:18 |
| sinzui | henninge, It was great working with you | 17:19 |
| henninge | sinzui: thanks, same here ;-) | 17:19 |
| nigelb | sinzui: I don't understand. Why should it be checking branch count? | 17:20 |
| sinzui | nigelb, because you changed the template: | 17:21 |
| sinzui | <tal:commit-info condition="view/branch_count"> | 17:21 |
| sinzui | when that is zero, the commits section is not rendered | 17:22 |
| nigelb | Right! | 17:22 |
| nigelb | But the count is till 1. | 17:22 |
| nigelb | Ah. | 17:22 |
| sinzui | view.committer_count is 1 view.branch_count is 0 | 17:23 |
| sinzui | I misread it too | 17:23 |
| nigelb | Should I just check branch count and leave it at that? | 17:24 |
| sinzui | nigelb, I think we should check branch_count, revision_count, and the commits node to verify there is something, but we do not want to show it, and we did not show it | 17:28 |
| nigelb | So, we verify branch_count = 0, revision_count =1, and then somehow check the view to make sure only branch_count sentence is there. | 17:29 |
| nigelb | Is that the right thinking? | 17:29 |
| sinzui | yep | 17:31 |
| sinzui | nigelb, the latter is done via commit_section = find_tag_by_id(view.render(), 'commits') | 17:31 |
| sinzui | self.assertIs(None, commit_section) | 17:31 |
| nigelb | Aha | 17:31 |
| nigelb | So just add branch_count check | 17:31 |
| nigelb | and correct the commits count | 17:31 |
| sinzui | nigelb, view() or view.render() generates the markup using the principal as the user | 17:31 |
| sinzui | nigelb, I think so | 17:32 |
| nigelb | \o/ | 17:32 |
| === deryck[lunch] is now known as deryck | ||
| jtv | bac: if you're looking for something to review, I've got one on the queue: https://code.launchpad.net/~jtv/launchpad/bug-613823/+merge/75773 | 17:45 |
| bac | jtv: was just about to claim it | 17:46 |
| jtv | sweet. thanks. | 17:46 |
| === salgado-lunch is now known as salgado | ||
| sinzui | jcsackett, Do you have time to mumble? | 17:55 |
| jcsackett | sinzui, sure. lemme fire up mumble. | 17:56 |
| bac | hi jtv | 18:30 |
| jtv | hi | 18:30 |
| bac | jtv: in the factory, the logic around setting iscurrent is a little confusing | 18:30 |
| bac | jtv: does it default to true when the object is created? | 18:30 |
| jtv | Oh, it's just because iscurrent is True when we create the template. | 18:30 |
| jtv | Yes. | 18:30 |
| bac | oh, ok | 18:31 |
| jtv | I could remove the “if” if you like. | 18:31 |
| bac | might be less confusing to just set it. | 18:31 |
| jtv | OK | 18:31 |
| jtv | bac: pushed the change. | 18:33 |
| bac | jtv: thanks | 18:33 |
| bac | done jtv. nice. | 18:39 |
| jtv | Thanks! | 18:40 |
| barry | flacoste, sinzui and anybody else. i get an error using 'make schema' in my py27 experiment. i don't think it's related to py27 though, since pypi only has ipython 0.11 i think: | 18:51 |
| barry | While: | 18:51 |
| barry | Installing iharness. | 18:51 |
| barry | Getting distribution for 'ipython==0.9.1'. | 18:51 |
| barry | Error: Couldn't install: ipython 0.9.1 | 18:51 |
| barry | 18:51 | |
| flacoste | barry: do you have an up-to-date download-cache? | 18:53 |
| barry | flacoste: i *thought* so since i ran rocketfuel-setup about 2hrs ago :) | 18:54 |
| flacoste | you should have: download-cache/dist/ipython-0.9.1.tar.gz | 18:54 |
| flacoste | in your tree | 18:54 |
| flacoste | barry: did you run link-external-sourcecode? | 18:54 |
| barry | flacoste: hmm, yep, it's there. | 18:54 |
| flacoste | barry: anything after the Error: Couldn't install: ipython 0.9.1? | 18:55 |
| barry | flacoste: ah! how quickly we forget. and i'm not sure the help wiki descript that | 18:55 |
| flacoste | barry: well, if download-cache is in your tree, link-external-source would have done its job | 18:56 |
| barry | flacoste: hmm, okay, let me see | 18:57 |
| sinzui | link-external-sourcecode is now managed by the make file | 18:59 |
| sinzui | make compile will do the necessary buildout | 18:59 |
| barry | i got tripped up on `make PYTHON=python2.7 schema` | 19:00 |
| barry | i'm trying to create a branch of devel now, but the vm's disk i/o kind of sucks | 19:00 |
| nigelb | bac: around? | 19:13 |
| sinzui | nigelb, I can review your branch once gthe diff updates | 19:18 |
| nigelb | sinzui: Ah, thanks :-) | 19:18 |
| nigelb | I thought you left! | 19:18 |
| sinzui | nigelb, The branch is good to land. I will do that now | 19:21 |
| nigelb | sinzui: Thanks! :-) | 19:22 |
| barry | flacoste, sinzui okay, i guess it *is* an issue with py27. a make schema w/o PYTHON=python2.7 seems to be working okay. maybe ipython 0.9.1 isn't compatible with python 2.7? | 19:24 |
| sinzui | huh | 19:24 |
| sinzui | barry, http://ipython.scipy.org/dist/0.9.1/ <- could be true | 19:25 |
| barry | sinzui: yeah | 19:26 |
| barry | sinzui: i'll see if upgrading my local download-cache to 0.11 makes any difference | 19:26 |
| sinzui | ll supports py3. It looks promising | 19:27 |
| nigelb | Oh no. | 19:39 |
| nigelb | Can someone give me the tracback/details for OOPS-2085QASTAGING54 | 19:39 |
| nigelb | sinzui: Could you help wwith ^ | 19:43 |
| * sinzui looks | 19:44 | |
| nigelb | How did that fail QA. I did all the testing :( | 19:44 |
| sinzui | nigelb, the oops is not in the db yet | 19:44 |
| sinzui | nigelb, what were you doing? | 19:44 |
| nigelb | +check-links | 19:44 |
| nigelb | I was QA-ing my fix | 19:45 |
| nigelb | Its mostl likely a QA-bad. But I want to see the traceback to confirm | 19:45 |
| sinzui | nigelb, https://qastaging.launchpad.net/+check-links ? | 19:46 |
| nigelb | Yeah | 19:46 |
| sinzui | I do not get an oops, but I only see {} | 19:46 |
| nigelb | Well, javascript POSTs bug numbers and branches harvested to it | 19:46 |
| barry | sinzui: please remind me. do i need to do anything more than put ipython-0.11.tar.gz in download-cache/dist and update versions.cfg? | 19:46 |
| nigelb | It returns json of stuff that's valid | 19:46 |
| nigelb | I'm QA-ing bug 849121 | 19:47 |
| _mup_ | Bug #849121: Autolinked bugs should also have title attribute with bug title <qa-needstesting> <Launchpad itself:Fix Committed by nigelbabu> < https://launchpad.net/bugs/849121 > | 19:47 |
| sinzui | barry, that is all that is required. deleting old version is optional | 19:47 |
| barry | sinzui: okay thanks. trying it | 19:47 |
| nigelb | I'm trying to see if the title gets updated to the URL for comment #2 in https://bugs.qastaging.launchpad.net/ubuntu/oneiric/+source/phaseshift/+bug/755937 | 19:47 |
| _mup_ | Bug #755937: phaseshift version 0.40-13.2 failed to build on i386 <ftbfs> <natty> <oneiric> <universe> <phaseshift (Ubuntu):Confirmed> <phaseshift (Ubuntu Oneiric):Confirmed> < https://launchpad.net/bugs/755937 > | 19:47 |
| sinzui | nigelb, what url did you use? | 19:50 |
| flacoste | sinzui, barry: actually, you need to update the version number in versions.cfg | 19:50 |
| barry | flacoste: yep | 19:51 |
| flacoste | since we pin version using buildout | 19:51 |
| flacoste | ah | 19:51 |
| nigelb | sinzui: https://bugs.qastaging.launchpad.net/ubuntu/oneiric/+source/phaseshift/+bug/755937 | 19:51 |
| _mup_ | Bug #755937: phaseshift version 0.40-13.2 failed to build on i386 <ftbfs> <natty> <oneiric> <universe> <phaseshift (Ubuntu):Confirmed> <phaseshift (Ubuntu Oneiric):Confirmed> < https://launchpad.net/bugs/755937 > | 19:51 |
| flacoste | barry: i missed the second part "and update versions.cfg' | 19:51 |
| flacoste | sorry for being redundant | 19:51 |
| barry | no worries! | 19:51 |
| barry | flacoste, sinzui: so this should work, right: `make PYTHON=python2.7 schema` | 19:52 |
| flacoste | barry: maybe only in a new branch | 19:52 |
| barry | flacoste: yep, new branch | 19:52 |
| sinzui | nigelb, so you are watching the js console for errors and you see the 500 error for +check-links | 19:52 |
| barry | w/versions.cfg changed | 19:52 |
| flacoste | barry: since i'm pretty sure the Makefile doesn't version on the value of PYTHON env var | 19:53 |
| nigelb | sinzui: Yep | 19:53 |
| nigelb | Looking at firebug | 19:53 |
| flacoste | barry: what I mean is that bootstrap needs to be run with that env | 19:53 |
| barry | flacoste: ah | 19:53 |
| flacoste | barry: but i'm not sure it will do the right thing if it was invoked first with python2.6 | 19:53 |
| barry | right. fresh branch | 19:53 |
| flacoste | barry: you can remove bin/buildout | 19:54 |
| flacoste | and then do a make | 19:54 |
| flacoste | make PYTHON=python2.7 | 19:54 |
| flacoste | that should do the trick | 19:54 |
| flacoste | since bootstrap will be run in that case | 19:54 |
| barry | flacoste: yeah, it still bombs out on ipython 0.11 :/ | 19:54 |
| nigelb | sinzui: I can't reproduce any problems in my dev setup. So, not a clue what's going wrong. | 19:55 |
| flacoste | barry: it fails to build ipython with python2.7? | 19:55 |
| nigelb | I'm guessing there could be a timeout issue for the search. | 19:55 |
| barry | Getting distribution for 'ipython==0.11'. | 19:55 |
| barry | An error occurred when trying to install ipython 0.11. Look above this message for any errors that were output by easy_install. | 19:55 |
| barry | While: | 19:55 |
| barry | Installing iharness. | 19:55 |
| barry | Getting distribution for 'ipython==0.11'. | 19:55 |
| barry | Error: Couldn't install: ipython 0.11 | 19:55 |
| barry | 19:55 | |
| barry | % grep ipython versions.cfg | 19:55 |
| barry | ipython = 0.11 | 19:55 |
| barry | 19:55 | |
| barry | % ls ../download-cache/dist/ipython* | 19:55 |
| barry | ../download-cache/dist/ipython-0.11.tar.gz | 19:55 |
| barry | 19:55 | |
| flacoste | barry: why ../download-cache ? | 19:55 |
| sinzui | nigelb, could be | 19:56 |
| flacoste | barry: i'd expect ./download-cache | 19:56 |
| flacoste | barry: do you a symlink in place? | 19:56 |
| flacoste | ln -s ../download-cache . | 19:56 |
| barry | flacoste: yep, that symlink is there and ./download-cache also has 0.11 | 19:56 |
| nigelb | sinzui: The tests cach all the use cases that I'd expect it to catch. What should I be doing since I can't do a qa-ok with any sort of surety | 19:57 |
| nigelb | *catch | 19:57 |
| flacoste | barry: are you on lucid or oneiric? | 19:57 |
| sinzui | Does staging have the rev yet? It is faster | 19:58 |
| barry | flacoste: this is a lucid vm | 19:58 |
| nigelb | It just got on qastaging. | 19:58 |
| nigelb | I'm not sure eif its not stage | 19:58 |
| * nigelb checks | 19:58 | |
| flacoste | barry: ok, i don't have this setup, but i can try on oneiric to see how far i get | 19:58 |
| barry | flacoste: cool, thanks. i'll keep poking at it too :) | 19:59 |
| nigelb | stage is *old* | 19:59 |
| sinzui | nigelb, I see staging is about 12 hours behind. I just got my work that landed before I woke | 20:01 |
| nigelb | the bottom revision numbers of stage say 10984. Is that wrong? | 20:02 |
| nigelb | sinzui: stage = staging.launchpad.net right? | 20:02 |
| sinzui | nigelb, yes | 20:02 |
| nigelb | or is it something I don't know of. | 20:02 |
| sinzui | nigelb, I am being an idiot. I can paste you the error I see hidden in the browser response | 20:03 |
| nigelb | hah | 20:03 |
| lifeless | flacoste: did you ask henninge about being in the emeritus team? | 20:03 |
| nigelb | Also. 2 days of falling ill. 2 launchpad branches landed. Productive sick time I reckon. | 20:04 |
| flacoste | lifeless: i didn't think about it, but he's still subscribed to launchpad-dev | 20:06 |
| flacoste | so would probably be interested | 20:06 |
| flacoste | barry: it's compiling dependencies over here | 20:06 |
| barry | flacoste: hmm | 20:08 |
| flacoste | barry: it builds cleanly on Oneiric using python2.7 | 20:09 |
| flacoste | barry: no need for ipython 0.11 | 20:09 |
| flacoste | barry: so i suspect a Lucid issue :-/ | 20:10 |
| barry | flacoste: huh. yeah. okay thanks | 20:10 |
| flacoste | barry: do you have anything py2.7 eggs built under eggs? | 20:10 |
| flacoste | just checking that it's really ipython that doesn't work and not all 2.7 deps | 20:11 |
| barry | flacoste: yes, i do have some py27 built eggs in there (e.g. the zope stuff) | 20:11 |
| flacoste | barry: ok, so either a buildout issue on Lucid/2.7 or something in ipython specifically | 20:12 |
| barry | flacoste: nod | 20:13 |
| barry | flacoste: can i get more verbose output out of buildout? | 20:15 |
| sinzui | nigelb, sorry, I was pulled into anther conversation: http://pastebin.ubuntu.com/691043/ shows that there can be a mismatch between the set of ids and what is removed | 20:17 |
| flacoste | barry: you can try running it manually | 20:17 |
| sinzui | nigelb, maybe it is a parsing error | 20:17 |
| nigelb | sinzui: Oh. Checking. | 20:17 |
| sinzui | nigelb, one option is to look before removing the item | 20:17 |
| flacoste | barry: | 20:18 |
| flacoste | PYTHONPATH= $(PYTHON) bootstrap.py\ | 20:18 |
| flacoste | --setup-source=ez_setup.py \ | 20:18 |
| flacoste | --download-base=download-cache/dist --eggs=eggs \ | 20:18 |
| flacoste | --version=1.5.1 | 20:18 |
| flacoste | PYTHONPATH= ./bin/buildout \ | 20:18 |
| flacoste | configuration:instance_name=${LPCONFIG} -c $(BUILDOUT_CFG) | 20:18 |
| flacoste | LPCONFIG=development | 20:18 |
| flacoste | BUILDOUT_CFG=buildout.cfg | 20:19 |
| nigelb | sinzui: *confused* It should be there | 20:19 |
| barry | flacoste: okay, manually as per above still bombs out on ipython. time to pdb i guess ;) | 20:19 |
| nigelb | Because I'm checking in the list that I just sent to search. | 20:19 |
| flacoste | barry: maybe try buildout ipython? | 20:20 |
| flacoste | sorry building | 20:20 |
| flacoste | might be because of missing unrepored dependency | 20:21 |
| barry | flacoste: good idea | 20:21 |
| nigelb | sinzui: Well, it is qa-bad anyway. :( | 20:23 |
| barry | flacoste: well, this seems like a bad sign: | 20:24 |
| barry | @lessons[/tmp/xx/ipython-0.11:258]% python2.7 setup.py build | 20:24 |
| barry | Aborted (core dumped) | 20:24 |
| barry | 20:24 | |
| flacoste | lol | 20:24 |
| flacoste | yeah | 20:24 |
| flacoste | nice euphemism ;-) | 20:24 |
| bac | thanks sinzui! | 20:25 |
| lifeless | flacoste: I will mail him | 20:25 |
| lifeless | flacoste: ah, I only have his canonical address | 20:25 |
| barry | flacoste: okay, i'll shut up now | 20:25 |
| nigelb | lifeless: its in his email to launchpad-dev | 20:26 |
| nigelb | the one about translations | 20:26 |
| flacoste | nigelb: i pm it to lifeless | 20:26 |
| nigelb | :) | 20:26 |
| nigelb | Gah. After python tests and javascript tests I end up with a QA fail. | 20:27 |
| lifeless | mailed him | 20:27 |
| nigelb | Oh. Its a weekend. | 20:30 |
| nigelb | Hrm, does bugtask.search always return a list of unique values? | 20:35 |
| nigelb | Oh. FU. | 20:35 |
| nigelb | No. | 20:35 |
| * nigelb facepalms. | 20:35 | |
| jcsackett | sinzui: took a bit longer to get the MP to work out than expected, but the branch is up for review with you requested as reviewer. :-) | 20:39 |
| cr3 | am I supposed to get a file not found error with launchpadlib for the credentials file when used with desktop integration permissions? | 20:39 |
| cr3 | in unity, is there a shortkey to run a command? I can't access the pannel | 20:45 |
| cr3 | crap, wrong channel :) | 20:45 |
| sinzui | thank you jcsackett | 20:45 |
| nigelb | sinzui: Found the problem. Doing as you suggested. | 20:46 |
| nigelb | I assumed search would return only unique IDs | 20:46 |
| nigelb | I was wrong. | 20:46 |
| nigelb | There can be two bugtasks for a bug. | 20:46 |
| nigelb | *two or more | 20:46 |
| sinzui | nigelb, that is right. we often use a set() object when building a collection to ensure out code sees one one item | 20:52 |
| cr3 | hm, I like this line in launchpadlib: credential_store = credential_store :) | 20:54 |
| nigelb | sinzui: I can't do the set() here because I get a list of bugtasks which are indeed unique. I should have caught this. | 20:55 |
| sinzui | nigelb, correct, but this is case were you want bugs, so your could do bugs = set(bugtask.bug for bugtask in bugtasks) | 20:56 |
| nigelb | ahhh. | 20:57 |
| nigelb | YES | 20:57 |
| nigelb | but that's adding another loop | 20:57 |
| sinzui | nigelb, you may have fixed bug 262545, or you have made it very easy to fix | 20:57 |
| _mup_ | Bug #262545: Milestone listings should show the bugs' titles/descriptions in a tool tip <lp-registry> <milestones> <Launchpad itself:Triaged> < https://launchpad.net/bugs/262545 > | 20:57 |
| nigelb | I'm thinking the if would be less iterations | 20:58 |
| nigelb | oh. looking | 20:58 |
| nigelb | sinzui: are you around long? | 21:04 |
| nigelb | I have a fix for the qa-bad. | 21:04 |
| sinzui | I can linger | 21:04 |
| sinzui | I can review your fix and land it | 21:04 |
| nigelb | excellent. Give me 5 minutes to push it out | 21:05 |
| === matsubara is now known as matsubara-afk | ||
| nigelb | https://code.launchpad.net/~nigelbabu/launchpad/bug-title-regression-849121/+merge/75822 | 21:29 |
| nigelb | Diff shows empty. I'm confused. | 21:29 |
| sinzui | I see | 21:29 |
| nigelb | Delete and submit again? | 21:29 |
| * sinzui looks in loggerhead | 21:29 | |
| sinzui | nigelb, your change and test looks good in loggerhead | 21:31 |
| nigelb | okay \o/ | 21:32 |
| sinzui | nigelb, I resubmitted: In linkchecker, check if the bug ID exists in the list before removing from the list | 21:33 |
| nigelb | Oh, cool. | 21:33 |
| sinzui | and there it is | 21:33 |
| sinzui | I am approving this and landing it now | 21:34 |
| nigelb | Thanks a bunch! | 21:34 |
| nigelb | Could you help me figure out what the other bug is about? | 21:34 |
| sinzui | jcsackett, I approved your branch | 21:41 |
| sinzui | jcsackett, I am sending your branch off to land | 21:43 |
| jcsackett | sinzui: thanks. | 21:48 |
| * jcsackett really needs to sort out his landing issues. | 21:48 | |
| nigelb | sinzui: for the milestone bug, does it mean https://launchpad.net/unity/4.0/4.2.0 page | 21:58 |
| sinzui | nigelb, yes, or its alternate url https://launchpad.net/unity/+milestone/4.2.0 | 21:59 |
| sinzui | The former is a released milestone, the latter always exists | 21:59 |
| * nigelb looks | 21:59 | |
| sinzui | The url maps to the same view | 22:00 |
| nigelb | sinzui: I see that the title of the bug is already there | 22:00 |
| sinzui | It was once truncated | 22:00 |
| sinzui | I think the intent was to load more information on hover, such as full title, description, and bug tags | 22:00 |
| sinzui | I think the tags issue was reported as a separate bug | 22:01 |
| nigelb | Do we have a hover for more info kind of story anywhere else? | 22:01 |
| nigelb | It looks like the +check-links stuff isn't needed here. | 22:02 |
| sinzui | nigelb, I agree it is not in this case, but I think you have laid the foundation to solve a class of bugs | 22:05 |
| nigelb | \o/ | 22:05 |
| sinzui | We want to load extra bug information in an asyc fashion, either after the page loads or on hover. Ideally the first, but hover is okay | 22:06 |
| nigelb | The foundation was there. I slowly extended it | 22:06 |
| nigelb | :) | 22:06 |
| sinzui | Showing the title in a tooltip solves the bug id in test case. Showing part of the description or tags allow users looking a lists of bugs to gain information without traversal | 22:06 |
| nigelb | I think it would be nice if on clicking the URL, it loaded an "overlay" that would display the summary + tags | 22:08 |
| sinzui | nigelb, see bug 401243, bug 1924, bug 86461, bug 262545 | 22:10 |
| sinzui | I bet we can dupe some of those | 22:10 |
| nigelb | I see mpt bugs! | 22:12 |
| nigelb | Those usually cannot be duped ;-) | 22:13 |
| sinzui | They can when code was merged | 22:13 |
| nigelb | I remember seeing 1924. That is a bit of work by itself. | 22:15 |
| nigelb | sinzui: Ooh. bug 262545 looks like fun. | 22:17 |
| _mup_ | Bug #262545: Milestone listings should show the bugs' titles/descriptions in a tool tip <lp-registry> <milestones> <Launchpad itself:Triaged> < https://launchpad.net/bugs/262545 > | 22:17 |
| === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: -| Critical bugs: 261 - 0:[########*** stack smashing detected ***: ./lp terminated | ||
| sinzui | nigelb, We had timeouts trying to show that data. The hope was to solve the issue after page load. We stopped truncating bug titles since then. Release managers still want to see the tags and the description. | 22:19 |
| nigelb | sinzui: We could create a similar interna API to solve this | 22:20 |
| nigelb | It should not be *too* hard | 22:20 |
| sinzui | nigelb, I was thinking the same since you have demonstrated how to do it | 22:20 |
| nigelb | I think I'll pick it up after my current assigned bugs are over | 22:21 |
| nigelb | (2 more) | 22:21 |
| sinzui | nigelb, fab. I agree it is best not to commit to to many bugs. | 22:23 |
| nigelb | :) | 22:25 |
| === jam2 is now known as jam | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
