| ralsina | mandel, I know you are getting this via bip. I am cursing your ancestors. In a nice way though! | 02:53 |
|---|---|---|
| rye | we are currently restarting music streaming so it may not work for some moments | 08:16 |
| rye | And we are back! | 08:19 |
| rye | duanedesign, library cache timeout has been changed for the streaming, now it is 4 minutes | 08:20 |
| gatox | hi everyone | 09:04 |
| mandel | gatox, morning | 09:04 |
| gatox | mandel, how are you? | 09:04 |
| mandel | gatox, doing lots of bug triaggin in the ubuntuone-windows-installer, the are lots from the last beta :( | 09:05 |
| mandel | gatox, and you? | 09:05 |
| gatox | starting my day | 09:06 |
| mandel | gatox, I was going to say, is freaky friday! but it does not apply to either of us :( | 09:07 |
| gatox | mandel, i have to fix one test from one of my brances (grrrrrr mocker) and keep working on medium bugs..... i close all the highs yesterday | 09:07 |
| gatox | mandel, buy the are going to appear again soon | 09:07 |
| gatox | :P | 09:07 |
| mandel | gatox, nice! I'll do some bug cleaning to remove a lot of noise and then will improve the autoupdate | 09:11 |
| mandel | gatox, I might get back to work on my u1 chome extension if I have the time, or a pb json implementation, I dont know :P | 09:12 |
| JamesTait | Happy Friday, folks! | 09:16 |
| karni | Good morning! | 09:43 |
| mandel | ralsina, ping | 10:19 |
| ralsina | mandel: pong | 10:19 |
| mandel | ralsina, buenos dias! | 10:19 |
| mandel | ralsina, thx for looking at the aoutupdate branch :) | 10:19 |
| ralsina | buen dia manuel | 10:19 |
| ralsina | no problem | 10:19 |
| mandel | ralsina, do yo have the changes so I can merge it with mine and change things so that it is nicer | 10:20 |
| ralsina | but we really need to get you making bundles, or it's not going to scale :-) | 10:20 |
| mandel | ralsina, and, just for curiosity, waht did you say about my ancestors? hehe | 10:20 |
| ralsina | I called them old mandels | 10:20 |
| ralsina | mandel: the fixes I did are crap | 10:20 |
| mandel | ralsina, yeah, I'm going to be looking at why py2exe is broken in my env since all the rest seems to work | 10:21 |
| mandel | ralsina, yes, but then I can see the diff and fix them in a nicer way | 10:21 |
| mandel | ralsina, at least, did you see the dialog and all that? | 10:21 |
| * mandel has already decide to not have afreaky friday | 10:21 | |
| ralsina | yeah, I even got to trying to download the new relaease | 10:21 |
| mandel | ralsina, did it get it? | 10:21 |
| ralsina | mandel: one small problem with this solution: did you notice autupdate-windows is 6MB? | 10:22 |
| ralsina | mandel: no | 10:22 |
| ralsina | mandel: but that was probably a bad URL in your XML | 10:22 |
| mandel | ralsina, yes.. the bundle is getting very fat | 10:22 |
| mandel | ralsina, seems reasonable, I'll take a look at that | 10:22 |
| mandel | ralsina, did you push the changes somewherE? | 10:33 |
| ralsina | mandel: let me use a junk branch | 10:38 |
| mandel | ralsina, super! | 10:38 |
| mandel | ralsina, atm I'm just cleaning the bugs in ubuntuone-installer, there are lots from the old beta and I dont like the noise, although I think bug 680348 does apply, what do you thin? | 10:39 |
| ubot4 | Launchpad bug 680348 in ubuntuone-windows-installer "Provide a way to stop Ubuntu One from starting at boot time (affects: 4) (dups: 2) (heat: 7)" [Medium,In progress] https://launchpad.net/bugs/680348 | 10:39 |
| mandel | s/thin/think | 10:39 |
| ralsina | mandel: what's the url for unk? lp:~ralsina/+junk/whatever ? | 10:39 |
| mandel | ralsina, yes, I believe so | 10:40 |
| ralsina | Well, the obvious way is to remove it from autostart like any other program :-) | 10:40 |
| mandel | ralsina, I can give that as an answer and simple set it as wont fix | 10:40 |
| ralsina | I think it's fairly reasonable | 10:40 |
| mandel | ralsina, ok | 10:41 |
| ralsina | We could provide a more detailed answer in the wiki but we would have to do it for N windows | 10:41 |
| mandel | ralsina, well, I'm the one that filed the bug hehehe | 10:42 |
| mandel | ralsina, but we should indeed put that in the wiki | 10:42 |
| ralsina | so if it makes you happy, mark it as fix-released ;-) | 10:42 |
| ralsina | next victim of our wrath should be proxy support I think | 10:43 |
| ralsina | mandel: lp:~ralsina/+junk/autoupdate | 10:43 |
| mandel | ralsina, but that is for ubuntuonoe-client to get done... | 10:43 |
| ralsina | mind you, the changes are really hackish | 10:43 |
| ralsina | mandel: yes | 10:43 |
| ralsina | mandel: ubuntuone-client is slowly becoming ours | 10:43 |
| mandel | ralsina, yes, but they work, I can deal with the issue :) | 10:43 |
| gatox | mandel, do you have a minute? | 10:44 |
| mandel | ralsina, I've noticed? I honestly will like to work on chaing from spread.pb to json so that we can use other langs to talk with syncdaemon | 10:44 |
| mandel | gatox, dime :) | 10:44 |
| mandel | stupid three dot becoming ? stupid schat | 10:45 |
| ralsina | mandel: have you noticed? (just kidding) | 10:45 |
| ralsina | mandel: I am pretty sure that's a plugin | 10:45 |
| mandel | ralsina, yeah, I did notice hehe | 10:45 |
| gatox | mandel, i wanted to ask you something about mocker... i think that it should be something really simple, but i don't know how to do it... in this branch i added the line: 113 (also 111 and 112 to see if that works): https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/name-required/+merge/75366 | 10:46 |
| mandel | ralsina, yeah, I'll fix this during the weekend, I just have to remember not to use ? :P | 10:46 |
| mandel | gatox, ok, so what is the question ;) | 10:47 |
| gatox | mandel, because the funcion validate_form changed and in that case needs to call set_error_message... but always tells me that: self.view.ui.confirm_email_assistance is None... i don't quite understand how to do for self.view.ui.confirm_email_assistance to be valid | 10:47 |
| mandel | gatox, do you mind runing the tests and pastebin the errors? | 10:49 |
| gatox | mandel, no problem! | 10:49 |
| mandel | gatox, thx, know I should run them, but I'm in the midle of something and my context swtich is very expensive hehehe | 10:50 |
| mandel | ralsina, if you have a new pacakage I can make the screen cast for you reagind the autoupdate. | 10:51 |
| ralsina | mandel: yes, it's in the mail! | 10:51 |
| ralsina | Or you are not in that mail? I think you are | 10:51 |
| gatox | mandel, http://paste.ubuntu.com/690692/ | 10:51 |
| mandel | ralsina, soy estupid, perdon! | 10:51 |
| mandel | ralsina, I am, I read it I ignored the fact that there was an installer in it | 10:52 |
| ralsina | mandel: but that's not screencast ready, I think | 10:52 |
| ralsina | Or rather, let's do it so we can see it and decide a process for the upgrade | 10:52 |
| ralsina | I am not really sure bitrock's autoupdater buys us much, and it's huge and not pretty | 10:53 |
| mandel | ralsina, yes, I agree, let me help gatox and I'll get to that | 10:53 |
| mandel | gatox, self.view.ui.confirm_email_assistance is it set? | 10:54 |
| gatox | no... i tried to set that.... but always fails... setting that to a QLabel.... trying to set that to = self.controller.view.ui.confirm_email_assistance or something like that, but it didn't work | 10:55 |
| ralsina | mandel: no rush | 10:55 |
| mandel | gatox, ok, let me brach the code and fis that for you, I'll add some comments explaining wtf is going on :) | 10:55 |
| gatox | mandel, THANKS!!!!! | 10:56 |
| gatox | mandel, i waste a lot of time yesterday trying to fix that :S | 10:56 |
| mandel | gatox, no worries, but I though you were getting rid of mocker? might be a good small work for fridays... | 10:57 |
| ralsina | jajaja "your fun friday project is rewriting all these crappy tests, kid. FUN!" | 10:58 |
| gatox | ralsina, jejej | 10:58 |
| mandel | ralsina, well, I thing fridays is more of 'you are not told what to do' | 10:58 |
| gatox | mandel, yes, i have a branch were i'm migrating mock tests.. but not this one... because the new branch has some issues to be resolved first | 10:59 |
| mandel | ralsina, and in honesty, I hate building more things on top of things I dont like, like I'm writing something to get rid os spread.pb and later will fix all the crap of the IPC :) | 10:59 |
| gatox | that need to be resolved.... | 10:59 |
| ralsina | mandel: I agree jsonrpc is the future | 10:59 |
| ralsina | mandel: just the thought of "hey, I could log the traffic" makes me smile like a justin bieber fan! | 11:00 |
| gatox | ralsina, jejeje | 11:00 |
| mandel | ralsina, yeah, I' writting a lib like spread.pb (even based in the design) so that we just change the imports :) | 11:00 |
| ralsina | and writing a protocol interceptor is trivial, just a sort of logging cat fr namedpipes | 11:01 |
| gatox | ralsina, in the "sign in to ubuntu one" page there is no more "default button"... that's the idea or there is a bug there? | 11:01 |
| ralsina | gatox: there is a bug. That and the "skip tour" button is default | 11:01 |
| ralsina | it only happens on build though, and I have no idea why | 11:01 |
| mandel | ralsina, and in BA I'll like to work with alecu to see what we can fix in the IOCP reactor, maybe we can get pipes back in the equation :) | 11:01 |
| ralsina | the "skip tour" we could just specify it, since now it's done "by default", I think | 11:02 |
| ralsina | but the other? I dunno. | 11:02 |
| gatox | ralsina, ok..... i can fix this one | 11:02 |
| ralsina | mandel: yes, the whole stepping tcp ports based on uid.... creepy | 11:03 |
| * gatox is downloading windows8... want to see if he can made u1 run on win8... hates win, loves the challenge jeje | 11:03 | |
| ralsina | gatox: since it only happens on builds, no you don't unless you build one :-) | 11:03 |
| ralsina | gatox: someone already did, and it works | 11:03 |
| gatox | ralsina, ahhhhok | 11:03 |
| ralsina | mandel, gatox: I will leave now for 30 minutes or so to take the kid to school | 11:03 |
| ralsina | mandel: could you show gatox how to do a build? | 11:04 |
| gatox | ralsina, okk | 11:04 |
| mandel | gatox, yes,arasure | 11:05 |
| ralsina | mandel: make sure you use revno 62 from my packaging branch :-) | 11:05 |
| mandel | gatox, can you let me know which command you were using to run the tests, to make sure I run the same one that you have | 11:06 |
| gatox | run-tests.bat....... or "python path/to/u1trial path/to/test.file --gui --reactor=qt4 | 11:07 |
| mandel | oh, just that.. lame :P | 11:08 |
| nessita | hello everyone! | 11:15 |
| gatox | nessita, hi | 11:15 |
| ralsina | hello nessita | 11:15 |
| * ralsina walks the kid | 11:16 | |
| mandel | gatox, looks like the mock has 3 expectations set and the first has no return value | 11:20 |
| mandel | gatox, I'm looking where is that occurring | 11:20 |
| gatox | mandel, ok, thanks... i can't wait to kill all the mock tests :P | 11:21 |
| mandel | gatox, ha, just found it :) | 11:21 |
| mandel | gatox, selg.controller.view is a mock, right? | 11:21 |
| gatox | yes | 11:22 |
| gatox | mandel, ^ | 11:22 |
| mandel | gatox, I'm pushing a branch with the fix, take a look at the diff | 11:23 |
| gatox | mandel, awesome! | 11:23 |
| mandel | gatox, the issue was that you where using selg.controller.view.etc as the result, so that was setting again the expectation and later you were doing it again, you had 3 expectations set | 11:23 |
| mandel | the first returned none, second one what you wanted, the thrid nont too | 11:24 |
| * gatox needs to look at the code to fully understand :P | 11:24 | |
| mandel | gatox, everything fixed | 11:28 |
| mandel | gatox, at least for that test :P | 11:28 |
| gatox | mandel, awesome! | 11:29 |
| mandel | gatox, merge lp:~mandel/ubuntu-sso-client/name-required and you will see how easy was to fix | 11:29 |
| * gatox merging | 11:29 | |
| mandel | gatox, let me know if it fixes it and then I'll go to walk the dog | 11:29 |
| gatox | mandel, ok..... | 11:30 |
| gatox | mandel, fixed! THANKS YOU VERY MUCH!! :D | 11:31 |
| mandel | gatox, denada :) | 11:31 |
| mandel | gatox, do you understand what was the issue? | 11:32 |
| gatox | mandel, i'm looking at the code right now...... first i ran the test so you can walk the dog :P | 11:32 |
| mandel | gatox, ok, but the issue was 'simple' you set self.controller.view to be a mock, so every time you made a call to that you were setting an expectation, in your setup code of mocker you had one call to self.view and 2 to self.controller.view but they are the same object! | 11:33 |
| mandel | that made mocker record 3 diff expectations, the one you intended in self.view and two that you did not expect self.comtroller.view | 11:34 |
| gatox | mandel, ahhhhhh now is more clear! | 11:34 |
| mandel | then the error was complaining because it was getting None due to the order in which the expectations were set | 11:34 |
| mandel | gatox, so we can say it was a small typo :) | 11:34 |
| gatox | mandel, yep, i understand now! :D | 11:35 |
| mandel | cool, then I walk the dog :) | 11:35 |
| mandel | bbl | 11:35 |
| nessita | gatox: I saw you made my reviews, did the IRL test suceeded? | 11:47 |
| nessita | :-) | 11:47 |
| gatox | nessita, yes, i didn't have any trouble this time | 11:47 |
| nessita | gatox: great! Does the change make sense? (I'm asking since you're way more familiar with that than me) | 11:48 |
| gatox | nessita, but i could find what we talk yesterday... did you implement another solution instead of pageInitialized? | 11:48 |
| nessita | gatox: I removed the set_up_button definition from the sso controller, since it was already being handled in the setupaccountpage in the wizard, so I moved the button "tunning up" there | 11:49 |
| gatox | nessita, ok, great | 11:50 |
| gatox | nessita, also, my 2 remaining branches are ready | 11:50 |
| nessita | gatox: yeah I started with those already | 11:51 |
| gatox | nessita, ok | 11:51 |
| nessita | gatox: last night I was thinking... why do we need the DisabledState property? isn't it enough with having primary/secondary buttons and then apply setEnabled to them? | 11:52 |
| gatox | nessita, nop..... i fought with that during the sprint..... the problem is that we don't have 2 button states..... we have 3 | 11:53 |
| nessita | gatox: which three? | 11:53 |
| gatox | nessita, primary (orange), secondary (white), disabled (gray) | 11:53 |
| nessita | gatox: but disabled (grey) is the same as disabled(secondary) and disabled(orange) | 11:54 |
| gatox | nessita, yes, MAYBE we can delete the style for: disabled(secondary) and disabled(orange), but there was some serious issues trying to use disabled and enabled from primary and not primary..... maybe something change during this time..... but i'm pretty sure that it took some time to have that working... and i needed a third state | 11:56 |
| nessita | gatox: can we use in qss QPushButton:pressed[enabled="false"]? | 11:58 |
| gatox | nessita, yes | 11:59 |
| nessita | gatox: we could use that instead of the DisabledState, no? | 11:59 |
| gatox | nessita, i think that the problem i was having before came from the combination of two properties | 11:59 |
| gatox | nessita, default and enabled..... and that was kind of a mess | 11:59 |
| nessita | weird | 11:59 |
| gatox | nessita, i can give it a try if you want | 12:00 |
| nessita | anyways, I will file a bug to clean that up, but Low priority of course | 12:00 |
| nessita | gatox: no need to do it any time soon, I wa sjust curios | 12:00 |
| gatox | nessita, ok..... but i remember that in the sprint we talk with ralsina about that and finally i finished create a property to avoid conflicts between several states combined | 12:01 |
| gatox | creating* | 12:01 |
| ralsina | yes, the orange buttons only refreshed when hovered, wacky stuff | 12:01 |
| nessita | ralsina: but that is fixed with the polish/unpolish, no? that we're calling the same | 12:02 |
| ralsina | nessita: yes, but without the three states, it refreshed white, or something like that. It was so annoying we grabbed the first thing that worked ;-) | 12:02 |
| nessita | ralsina: my intuition tells me that there is no need for having the DisabledState. But like I said to gatox, it was just curiosity, no need to change anything right now | 12:02 |
| ralsina | yeah, I agree that it seems redundant | 12:03 |
| gatox | nessita, yes, the problem was on hover as ralsina says... the styles get confused | 12:03 |
| nessita | gatox: maybe that can be solved by swapping the order in the qss? | 12:03 |
| nessita | ralsina: btw, I just filed #851810 for the thing that cristian reported as regression (I also send clarification to that email) | 12:04 |
| gatox | nessita, i'll check that later...... but believe me..... i swap everything that day!! jeje | 12:04 |
| nessita | gatox: no need to invest time in that | 12:04 |
| nessita | *really* | 12:04 |
| ralsina | nessita: I think we already have a bug for the empty UDFs: bug #845649 | 12:04 |
| ubot4 | Launchpad bug 845649 in ubuntuone-client "syncdaemon may return an empty UDF list for an account with UDFs (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/845649 | 12:04 |
| nessita | at least not today | 12:05 |
| nessita | ralsina: ah, I looked and failed | 12:05 |
| * mandel back | 12:09 | |
| nessita | ralsina: can I have a review please? https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/setup-button/+merge/75602 | 12:11 |
| ralsina | nessita: Sure. I am in the middle of building the installer for signing, and testing it, so it will take a bit. | 12:11 |
| nessita | ralsina: no problem | 12:11 |
| ralsina | nessita: and agreed I need to clean all those WHATEVER_PAGE_ID things. I was using a naming scheme and then I had to switch to SSO's and I never cleaned it | 12:12 |
| nessita | gatox: this is approved, but has no commit message. And since we're at it, ideally commit message would be something like: | 12:13 |
| nessita | - Fixed foo, bar and baz (LP: #123456) (LP: #654321). | 12:13 |
| nessita | ralsina: FYI, for future branches ^ | 12:13 |
| gatox | nessita, ok! | 12:13 |
| nessita | gatox, ralsina: that shape of commit messages improves and eases the writting of the chnagelog when releasing | 12:13 |
| nessita | gatox: the branch I was referring to is: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/75606 | 12:13 |
| mandel | ralsina, nessita do you know andrews nickname in freenode? | 12:14 |
| ralsina | mandel: should be blajk | 12:14 |
| nessita | blajk: | 12:14 |
| nessita | mandel: ^ | 12:14 |
| mandel | thx! | 12:14 |
| mandel | blajk, ping | 12:14 |
| blajk | mandel, pong | 12:15 |
| mandel | blajk, can you answer https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/670642 for me, I think is a wont fix | 12:15 |
| ubot4 | Launchpad bug 670642 in ubuntuone-windows-installer "Taskbar icon should show offline status (affects: 2) (heat: 1)" [Low,In progress] | 12:15 |
| mandel | blajk, you are the only design person around :) | 12:15 |
| blajk | mandel, I look at it now! | 12:15 |
| mandel | blajk, sorry run ulr, is this: | 12:15 |
| mandel | https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/681881 | 12:16 |
| ubot4 | Launchpad bug 681881 in ubuntu (and 1 other project) "Ubuntu One should use a monochrome icon in Windows 7 (affects: 5) (heat: 4)" [Undecided,Invalid] | 12:16 |
| ralsina | we *may* in a future implement the status as part of the icon, but it's useless on windows 7 since you can't *see* the icon | 12:16 |
| mandel | ralsina, I think one of them is a won fix for sure, dont know about the other | 12:16 |
| mandel | blajk, I'm of to lunch but do get back to me whenever (I love bip! ) | 12:17 |
| * mandel lunch | 12:17 | |
| ralsina | mandel: our icon *is* monochrome | 12:17 |
| ralsina | it's just ORANGE | 12:17 |
| blajk | mandel, ralsina, did you had a look at the screenshot provided (http://ubuntuone.com/p/Qvb/)? Isn't it the wrong icon? On my machine it is replaced with a little U1 logo, that is indeed monochrome. | 12:20 |
| ralsina | that's the oooooooooold code | 12:20 |
| ralsina | so I'll mark it as fix-released | 12:21 |
| blajk | ralsina, cool! | 12:21 |
| ralsina | ok, invalid because I am feeling bitchy | 12:22 |
| ralsina | the other one is wishlist | 12:23 |
| ralsina | alecu, dobey, nessita, gatox: standup in 8' | 12:52 |
| gatox | ralsina, ack | 12:52 |
| nessita | right | 12:52 |
| mandel | ralsina, blajk that bug was an old one from the first beta, so shall I mark it as invalid then? | 12:53 |
| ralsina | mandel: taken care of :-) | 12:54 |
| mandel | ralsina, thx! | 12:54 |
| mandel | ralsina, there are lots of bugs whose status is fix commited, do you know which we can set as fix released? | 12:59 |
| mandel | I'm trying to remove the bug noise | 12:59 |
| mandel | me | 12:59 |
| gatox | me | 12:59 |
| nessita | me | 12:59 |
| ralsina | me | 13:00 |
| nessita | ralsina, alecu, dobey? | 13:00 |
| dobey | me | 13:00 |
| ralsina | mandel: well, I suppose all of them if we count betas as releases | 13:00 |
| ralsina | or none of them if we only count releases as releases :-) | 13:00 |
| ralsina | mandel, go | 13:00 |
| mandel | DONE: Lots of bug triagging. I've removed most of the bugs from the old beta. | 13:00 |
| mandel | TODO: Clean the fixes from the autoupdate from ralsina. Do a screencast of it. | 13:01 |
| mandel | BLOCKED: no | 13:01 |
| mandel | next gatox | 13:01 |
| gatox | DONE: | 13:01 |
| gatox | All the critical and high bugs fixed. Some reviews. | 13:01 |
| gatox | TODO: | 13:01 |
| gatox | Keep working in medium bugs. | 13:01 |
| gatox | BLOCKED: | 13:01 |
| gatox | No | 13:01 |
| gatox | nessita go | 13:01 |
| nessita | DONE: reviews, bug triage, bug assignment, clean up in SSO and installer re: the setup account button, talks with alecu re: non-ascii username bugs | 13:01 |
| nessita | TODO: finish reviews, leave task assignment done for next week | 13:01 |
| nessita | BLOCKED: nopes | 13:01 |
| nessita | NEXT: alecu | 13:01 |
| ralsina | nessita: that won't work :-) | 13:01 |
| ralsina | DONE: fixed small bugs in the installer, several larger ones in the build process, helped manuel with the autouploader, reviews, did release (currently expecting last signing) TODO: since I was working until 2AM last night, and started at 7AM today, probably going to sleep after 12. BLOCKED: I am so sleepy. dobey? | 13:01 |
| nessita | ralsina: yes, sorry | 13:01 |
| nessita | ralsina: brain hole | 13:02 |
| dobey | λ DONE: FFE for devtools, bit of debugging, bit of bugging about TB | 13:02 |
| dobey | λ TODO: bug #838778, hack day? | 13:02 |
| dobey | λ BLCK: None. | 13:02 |
| ubot4 | Launchpad bug 838778 in ubuntuone-control-panel (Ubuntu Oneiric) (and 2 other projects) "After installing Ubuntu One, there are 2 Ubuntu One launchers in System Settings (affects: 47) (dups: 11) (heat: 210)" [High,Triaged] https://launchpad.net/bugs/838778 | 13:02 |
| dobey | alecu | 13:02 |
| mandel | ralsina, that is something to consider? I wonder how are we going to be keeping track of this | 13:02 |
| ralsina | mandel: track of what? | 13:03 |
| mandel | ralsina, of witch bugs for windows are released | 13:03 |
| ralsina | fix-committed is trunk, so once we consider we did a release, they are released | 13:03 |
| nessita | dobey: I decided the string freeze exception for the 'dotted' string is not worth it, so since there has been no changes in the gtk side of ussoc, I'll make the stable tag in the revno before that branch from leo (mostly FYI). | 13:03 |
| ralsina | then we can switch every u1-zomg-windows bug from fix-committed to fix-released | 13:04 |
| mandel | ralsina, ok, then do we consider the betas to be a release? so far we have 175 bugs and most of them are fix commited | 13:04 |
| ralsina | I don't know if there is a policy | 13:04 |
| ralsina | specially when we have betas and no finals | 13:04 |
| mandel | ralsina, I think you and nessita are the ones that call that | 13:04 |
| ralsina | mandel: if there is no previous policy, yes, we are | 13:05 |
| nessita | mandel: fix released when we hit the final 1.0, I'd say | 13:05 |
| alecu | hello | 13:05 |
| ralsina | I don't care. fix-committed is nice enough :-) | 13:05 |
| nessita | hi alecu | 13:05 |
| gatox | alecu, hi | 13:05 |
| ralsina | So on 1.0 it is | 13:05 |
| mandel | ralsina, nessita ok, then I'll leave everything as commited then | 13:05 |
| nessita | mandel: do you have the latest keyring compiled? I would like to have that in my dev box | 13:07 |
| mandel | nessita, yes I do, lt me upload it to a public u1file | 13:07 |
| nessita | thanks! | 13:07 |
| mandel | nessita, if I have some free time during the weekend I'll try to push this to trunk in pykeyring | 13:08 |
| nessita | mandel: that would rock | 13:08 |
| nessita | gatox: can you please confirm this is fixed? https://bugs.launchpad.net/ubuntu-sso-client/+bug/753699 | 13:08 |
| ubot4 | Launchpad bug 753699 in ubuntu-sso-client "The windows ui does not pass the display name to the backend (affects: 1) (heat: 7)" [High,Triaged] | 13:08 |
| nessita | gatox: if not, this is a new Critical for you :-D | 13:08 |
| gatox | nessita, ok | 13:08 |
| nessita | gatox: the display name is the name field | 13:08 |
| nessita | mandel: you can track that in https://bugs.launchpad.net/ubuntu-sso-client/+bug/812512 | 13:09 |
| ubot4 | Launchpad bug 812512 in ubuntu-sso-client "Windows: AttributeError: module has no 'delete_password' (affects: 1) (heat: 11)" [High,Triaged] | 13:09 |
| mandel | nessita, yes | 13:09 |
| gatox | nessita, basically is create an account without a name or something else? | 13:09 |
| nessita | gatox: you can check the code, in ussoc. When the qt calls the backend for register, does the name is passed? | 13:10 |
| gatox | nessita, ahhhhhh okok.... i think it is..... i'll check now | 13:10 |
| nessita | gatox: thanks | 13:10 |
| nessita | ralsina: is the a new bundle (even if it's not signed) so I can give it quick try? | 13:10 |
| ralsina | nessita: it's in your email | 13:11 |
| nessita | mandel: you started working on the migration from old-beta-to-new-beta rhingy? | 13:11 |
| nessita | ralsina: right, I was asking since you mentioned that you were building a new one? | 13:11 |
| nessita | (09:11:43 AM) ralsina: nessita: Sure. I am in the middle of building the installer for signing, and testing it, so it will take a bit. | 13:12 |
| nessita | I was hoping to test that ^ one | 13:12 |
| ralsina | nessita: it should be exactly the same. Let me dig that URL | 13:12 |
| mandel | nessita, here you have the lib: http://ubuntuone.com/6fkY1IvG7LNmvqKjXDFtYL unzip in Lib\site-pacakages | 13:12 |
| ralsina | nessita: http://ubuntuone.com/1gbjdEJkTBY4vwC9FCaxhw | 13:12 |
| ralsina | boy are the new unguessable URLs unguessable | 13:13 |
| nessita | mandel, ralsina: thanks! | 13:13 |
| mandel | nessita, not yet, I wantes to fix the small issues in the autoupdate so that lands nicely in trunk | 13:13 |
| alecu | DONE: worked on unicode usernames, found more unicode brokenness on sd and the cp, also helped facundo with the server branch that fixes delayed hashing | 13:13 |
| alecu | TODO: server changes not being reflected on the windows client | 13:13 |
| alecu | BLOCKED: no | 13:13 |
| nessita | mandel: ack | 13:13 |
| gatox | nessita, yes, register_user is being called with the proper name | 13:13 |
| ralsina | mandel: and ADD TESTS ;-) | 13:13 |
| mandel | ralsina, that is one of them :) | 13:14 |
| nessita | mandel: so you'll start on that next week, and I think that will take 2-3 days, which will cover your week | 13:14 |
| gatox | nessita, should i mark it as fix commited? | 13:14 |
| ralsina | alecu: thanks for the report. I suppose it's the same ugly stuff we have been seeing for the last 2 months, right? | 13:14 |
| mandel | nessita, yes, sounds about right, maybe a little less but not much more | 13:15 |
| mandel | nessita, tests are going to be the hard thing | 13:15 |
| alecu | ralsina, I thought it was my branch... I should try trunk | 13:15 |
| alecu | ralsina, do you have any more info on the "ugly stuff"? | 13:15 |
| ralsina | alecu: I mean the encoding problems and assumptions about paths | 13:16 |
| ralsina | alecu: or is it some new, original unicode brokenness? | 13:16 |
| nessita | gatox: what file is the call in? | 13:16 |
| alecu | ralsina, oh, you mean the encoding problems on the control panel? | 13:17 |
| alecu | ralsina, I thought you were talking about "server changes not being reflected on the windows client" | 13:17 |
| nessita | gatox: I'm looking at controllers.py:478 and the name is not passed... :-/ | 13:17 |
| ralsina | alecu: "unicode brokennes in sd and the cp" :-) | 13:17 |
| nessita | gatox: sorry, I looked wrongly | 13:18 |
| nessita | it's passed! | 13:18 |
| gatox | nessita, this is what i'm looking at: http://paste.ubuntu.com/690780/ | 13:18 |
| * nessita breaths again | 13:18 | |
| nessita | gatox: you are right | 13:18 |
| * popey notes the /topic doesn't mention the windows client | 13:18 | |
| nessita | gatox: I misread the app_name vs the name | 13:18 |
| popey | where can I get it? | 13:18 |
| gatox | nessita, ahhhh....... fix commited? | 13:18 |
| ralsina | popey: it what? | 13:19 |
| popey | 14:18:49 * popey notes the /topic doesn't mention the windows client | 13:19 |
| popey | ^^ that :D | 13:19 |
| nessita | gatox: yes please | 13:19 |
| blajk | threeve, ping | 13:22 |
| mandel | ralsina, in the update branch we start slow because subprocess.call blocks, calling it from a thread should improve that, I need to think that is the best thing to do to ensure that the update occurs before we stop the reactor | 13:22 |
| popey | never mind, found it. | 13:24 |
| popey | Love the look of the new windows client! | 13:24 |
| mandel | popey, \o/ | 13:25 |
| nessita | gatox: added a new comment to https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/848490 | 13:31 |
| ubot4 | Launchpad bug 848490 in ubuntuone-windows-installer "Verification code should be a required field (affects: 1) (heat: 39)" [Medium,In progress] | 13:31 |
| gatox | nessita, ko | 13:31 |
| gatox | ok | 13:31 |
| ralsina | nessita: thanks for the bugs thingy! | 13:34 |
| nessita | ralsina: :-) | 13:34 |
| ralsina | nessita: I'll try to keep code standards not-too-low in your absence :-) | 13:35 |
| nessita | ralsina: please try to keep it high! :-) | 13:35 |
| nessita | the same apply to everyone ^ :-) | 13:36 |
| ralsina | hehe | 13:36 |
| mandel | say what?! | 13:37 |
| mandel | :P | 13:37 |
| ralsina | mandel: we need to think about cleaning up all the build stuff before merging it. Please separate the autoupdater stuff that is in code on a separate branch please | 13:37 |
| mandel | ralsina, hm.. sure but we can have one depend on the other one, right? | 13:37 |
| mandel | ralsina, what is the gain in separating it? | 13:38 |
| ralsina | mandel: I mean all the stuff in "ubuntuone_installer" in one branch. I already merged the script/ stuff into mine | 13:38 |
| ralsina | mandel: that we can merge it first | 13:38 |
| ralsina | since my branch moves a lot | 13:38 |
| mandel | ralsina, I don't understand, so I should not use you branch as the parent, the lp:~ralsina/ubuntuone-windows-installer/fix_809873 | 13:39 |
| mandel | ralsina, is it going to be merge in trunk? | 13:40 |
| ralsina | mandel: it is, but it still needs lots of work :-( | 13:40 |
| ralsina | and I don't want to have to merge the autoupdate code manually | 13:40 |
| mandel | ralsina, oh, dont worry, you fix that branch and I'll fix the merge with that before we go to trunk | 13:41 |
| ralsina | So, I want to land the code first, and keep packaging from my branch | 13:41 |
| nessita | ralsina, gatox: I just reported https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/851885 which is a bug High. There is no clean solution for it, so I've assigned it to myself, to try to tackle when I return from my holidays. | 13:41 |
| ubot4 | Launchpad bug 851885 in ubuntuone-windows-installer "When logging in with an no-yet-validated account, there is no useful message (affects: 1) (heat: 6)" [High,Triaged] | 13:41 |
| ralsina | mandel: pretty please? The code and packaging bits are fairly independent | 13:41 |
| mandel | ralsina, what is packang exactly? | 13:41 |
| ralsina | mandel: everything under scripts | 13:41 |
| gatox | nessita, ack | 13:42 |
| mandel | ralsina, hm.. I can do that, that is easy since I just touch certain python files, but what to do with the ubuntuone.xml and ubuntuone_autoupdate.xml? | 13:42 |
| ralsina | mandel: I already merged that | 13:43 |
| ralsina | if you need to work more on that, start another branch from mine and I'll merge it | 13:43 |
| mandel | ralsina, so, you aleady merged that in scripts, right? so what is missing from scripts? | 13:43 |
| ralsina | mandel: cleaning | 13:43 |
| ralsina | that's why I want a branch with the ubuntuone_installer stuff that we can merge | 13:44 |
| ralsina | and doesn't block on "roberto has to cleanup crap from ubuntuone.xml and setup.py" | 13:44 |
| mandel | ralsina, oh, I can base my branch from trunk, but I'l do that at the end | 13:45 |
| mandel | ralsina, since I want to test building the .exe | 13:45 |
| ralsina | mandel: want to have a 5' mumble so we clarify this? It's easier than you think :-) | 13:46 |
| mandel | ralsina, I think I understand, get a branch with just my changes and nothing in yours | 13:47 |
| mandel | ralsina, right? | 13:47 |
| ralsina | you do a branch from trunk with the changes for ubuntuone_installer folder. Then start with my packaging branch, do fetch, go to sources/ubuntuone-windows-installer, merge your branch, go back to scripts, and do fetch py2exe | 13:48 |
| ralsina | that way you can build an exe with any combination of trunk+branches you want | 13:48 |
| mandel | ralsina, oh, yeah, that I understood :) | 13:48 |
| ralsina | mandel: cool | 13:49 |
| mandel | ralsina, I'm now making changes to the code in ubuntuone_installer and then move from there | 13:49 |
| ralsina | Really, the packaging stuff should be a separate "ubuntuone-windows-bundle" project or something | 13:49 |
| ralsina | or "ubuntuone-windows-installer" but that's taken by the not-an-installer :-) | 13:49 |
| nessita | ralsina: when you finish the installer building, I have one more review needed | 13:52 |
| ralsina | nessita: hit me! | 13:52 |
| nessita | ralsina: the 2 are: https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/setup-button/+merge/75602, https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/better-setup-account-button/+merge/75403 | 13:52 |
| nessita | in that order | 13:52 |
| ralsina | nessita: ack! | 13:53 |
| threeve | blajk1: pong | 14:04 |
| nessita | dobey: do you have an script to set the milestones or do you do it by hand? | 14:17 |
| ralsina | nessita: I am just too tired today because of last night's/early morning work. I am going to take a break, and I have not yet done your reviews :-( | 14:23 |
| ralsina | So, if alecu or mandel can do them, that would be faster | 14:24 |
| nessita | ralsina: is ok, I'll ask mandel | 14:24 |
| nessita | ralsina: get some rest, is there anything pending? | 14:24 |
| mandel | need what? | 14:24 |
| ralsina | I have nothing | 14:24 |
| ralsina | nothing that needs to be done today at least :-) | 14:24 |
| nessita | mandel: a couple of reviews, can you please do them? | 14:24 |
| mandel | nessita, si | 14:24 |
| nessita | mandel: these 2, in this order: https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/setup-button/+merge/75602, https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/better-setup-account-button/+merge/75403 | 14:24 |
| mandel | got it | 14:25 |
| dobey | nessita: i have been doing it by hand | 14:26 |
| nessita | dobey: thanks | 14:26 |
| mandel | nessita, lthe comment of FakeSignal in https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/setup-button/+merge/75602 is wrong, right? line 93 of the diff | 14:27 |
| mandel | nessita, seems the same with the other Fake objects | 14:27 |
| nessita | mandel: let me check (I just moved that code from one file to another, but might as well fix that) | 14:28 |
| mandel | nessita, there are new lines between class definition and doc | 14:28 |
| nessita | mandel: actually that's proper pep8 | 14:28 |
| mandel | is it? ok then | 14:28 |
| nessita | mandel: and ralsina has been trying to enforce that in the installer code | 14:28 |
| nessita | mandel: we should eventually migrate all our class docstrings to that | 14:28 |
| nessita | mandel: please note that only applies to class docstrings (no method's nor function's) | 14:29 |
| mandel | nessita, I though that there was not mean to have a new line.. cool | 14:29 |
| mandel | nessita, why was _ID removed from the names, just curious | 14:34 |
| nessita | mandel: to be consistent, most of the pages ids were called FOO_NAME_PAGE, and there was only one with the suffix )ID | 14:35 |
| nessita | _ID* | 14:35 |
| nessita | mandel: so I decided to make thos consistent with the minimal diff | 14:35 |
| mandel | ok | 14:35 |
| nessita | dobey: want me to do the stable tag/series/etc for protocol? | 14:37 |
| * nessita is happy to do it | 14:38 | |
| dobey | i don't know | 14:39 |
| dobey | i don't think we need to do that right now | 14:39 |
| nessita | dobey: I have the time and I'm doing it for ussoc, I think it can help to reduce your burden | 14:40 |
| nessita | I can confirm with foundations we're not targeting any more bugs for O in the protocol | 14:40 |
| * nessita goes to chicharra | 14:40 | |
| dobey | i don't think it will reduce my burden | 14:41 |
| nessita | dobey: why not? is one thing less for you to do | 14:41 |
| dobey | nessita: it's friday, use the hack day :) | 14:41 |
| nessita | dobey: do you see any reason why not do it today? (since we're paste beta freeze now) | 14:41 |
| nessita | dobey: I'm! I'm investing in packaging, part of my hack day | 14:42 |
| dobey | nessita: i haven't thought about reasons why not to do it, because i haven't been looking at doing it, as i've been concentrating on other stuff, and it's more of a low hanging fruit project at this point. thinking about it right now increases my burden more than putting it off right now | 14:43 |
| nessita | dobey: ok then, do not worry. I wanted to know if you had a known stopped for it, I'll check with foundations and see from there | 14:44 |
| nessita | stopper* | 14:44 |
| dobey | no. main urgent things i am aware of are control panel | 14:45 |
| nessita | dobey: right, let me know if I can help with any of that | 14:46 |
| nessita | dobey: I'm taking vacations next week but I have some spare time today | 14:46 |
| nessita | (will share the vacations schedule with the list in a few minutes) | 14:46 |
| mandel | nessita, in the second branch why chaing #pylint to # pylint? just style? | 14:53 |
| nessita | mandel: yes, always a blank space after # | 14:53 |
| mandel | nessita, line 433, why do you use bool? | 14:54 |
| nessita | mandel: because otherwise we end up passing a unicode to setEnabled | 14:55 |
| nessita | mandel: "foo" and true returns "foo" | 14:55 |
| nessita | instead of True | 14:55 |
| mandel | oh, ok | 14:55 |
| nessita | mandel: actually, I can make that better | 14:56 |
| mandel | nessita, it just look odd, nothing esle. I wanted to know the reason, looks fine otherwise | 14:57 |
| nessita | mandel: I'm pushing a change where I ensure that all the items in the 'and' are bool | 14:58 |
| ralsina | mandel: any chance you can do that screencast of the upgrade thing? | 14:59 |
| mandel | nessita, why do you prefer to use \ over open ( lines 743 and 744 | 14:59 |
| ralsina | mandel: and show it to cparrino? | 14:59 |
| mandel | ralsina, doing reviews and will get to that, but I'll use the .exe you created, is that ok? | 15:00 |
| ralsina | mandel: yes | 15:00 |
| nessita | mandel: it makes the code more readable | 15:00 |
| mandel | nessita, well, I suppose is taste.. I mind the other way nicer, but nothing to stop the branch from being ok | 15:01 |
| mandel | nessita, but I think either we agree on a set of styles (I dont mind too much) or we should respect the style used in the file | 15:02 |
| nessita | mandel: ok, I can revert that | 15:02 |
| mandel | nessita, nah, dont do extra work for stupid things | 15:02 |
| mandel | nessita, code looks ok, running tests now | 15:03 |
| nessita | mandel: pushing those changes now... | 15:03 |
| mandel | nessita, there was no need, but thx! | 15:04 |
| mandel | nessita, is the last revno 788? | 15:09 |
| nessita | mandel: 791 | 15:09 |
| mandel | ok | 15:09 |
| nessita | ralsina: while testing the latest release on XP, I found a High for you: https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/851921 | 15:09 |
| ubot4 | Launchpad bug 851921 in ubuntuone-windows-installer "Windows XP: wizard offers nested folders to sync up to the cloud (affects: 1) (heat: 6)" [High,Triaged] | 15:09 |
| ralsina | nessita: that's ok | 15:10 |
| ralsina | nessita: you can't actually select nested folders | 15:10 |
| ralsina | but you could choose my documents or my music + my pictures | 15:11 |
| nessita | ralsina: what if the user chooses my Documents and My Music? | 15:11 |
| ralsina | It gives an error when clicking next about not being able to sync nested folders | 15:11 |
| nessita | the UI will not prevent that, won't it? | 15:11 |
| nessita | ralsina: which is a very bad user experience.... no? | 15:11 |
| ralsina | yes, but not one I can fix unless I replicate the whole validation logic? | 15:12 |
| nessita | ralsina: well, I was thinking we should filter the suggested folder list in the wizard, being sure we don't offer overlapping folders | 15:13 |
| nessita | ralsina: so in this case, I think the wizard has to offer My Music and My Pictures, only | 15:14 |
| nessita | ralsina: we can take this to blajk1 maybe? | 15:15 |
| ralsina | nessita: maybe disable the nested folders when one is selected, but I think it's overthinking it a bit | 15:15 |
| ralsina | So if you choose my documents, the other two are disabled | 15:16 |
| nessita | ralsina: hum, but the user will no idea why that is hapenning, no? | 15:16 |
| ralsina | Exactly | 15:16 |
| ralsina | And if he wants to add my documents, he will have the same thing he has now | 15:17 |
| ralsina | except with my documents checked, and he still can get in the same mess | 15:17 |
| gatox | nessita, ralsina review please: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/verification-code/+merge/75755 | 15:17 |
| nessita | alecu: ping | 15:18 |
| blajk1 | ralsina, nessita, is it the same for all supported version of windows? On windows 7, pictures and music are not anymore under "documents" isn't it? | 15:18 |
| ralsina | blajk1: yes, they are not there anymore | 15:18 |
| nessita | blajk1: this issue is for XP mainly (maybe Vista as well?) | 15:18 |
| alecu | nessita, pong | 15:18 |
| ralsina | We could show them hierarchically, so when you select one, the rest get selected | 15:19 |
| ralsina | think about it, gotta go | 15:19 |
| nessita | alecu: I was re-reading your TODO, and was a little confused. Did the non-ascii bug is ready for review? is there a bug for your current TODO? | 15:19 |
| blajk1 | ralsina, I think the hierrachical display is indeed a good solution | 15:19 |
| blajk1 | *hierarchical | 15:20 |
| nessita | blajk1: can you please comment on the bug report? | 15:20 |
| nessita | alecu: maybe I did not understand your TODO at all :-) | 15:20 |
| blajk1 | nessita, no pb! | 15:20 |
| alecu | nessita, I found that "server changes" were not being downloaded to the local client, and it's happening on my branch, so it's one more thing to fix | 15:21 |
| alecu | nessita, it's not ready for review, yet | 15:21 |
| nessita | alecu: ah, so is more of the same nonascii stuff | 15:21 |
| nessita | alecu: have any trace I can look at? | 15:21 |
| alecu | nessita, there are no stacktraces :-( | 15:22 |
| alecu | nessita, the thing is that if I upload files or create folders using the web, they are not downloaded till the next time I start syncdaemon. | 15:24 |
| alecu | nessita, but local changes are being uploaded to the server, so it's a first step :P | 15:24 |
| nessita | alecu: you sure is not caused by server slowness? | 15:24 |
| nessita | (I have to ask) | 15:24 |
| nessita | alecu: do you see the SV_NEW_GENERATION message entering syncdaemon's logs? | 15:25 |
| nessita | that's the server notifying of a change in a volume in the server | 15:25 |
| alecu | nessita, well, I tried it on linux, and it works reasonably fast... | 15:25 |
| alecu | nessita, oh, I'll check that event | 15:25 |
| alecu | well, probably my linux must be connected to a different server | 15:26 |
| nessita | alecu: if you want, I can branch your branches and check in my dev win box | 15:27 |
| nessita | mandel: how did the tets running went? | 15:27 |
| dobey | https://code.launchpad.net/~dobey/ubuntuone-control-panel/one-launcher/+merge/75747 | 15:27 |
| mandel | nessita, passed, I've already approved it AFAIK | 15:27 |
| * dobey goes to get lunch, bbiab | 15:27 | |
| nessita | mandel: thanks! | 15:28 |
| nessita | dobey: I'm on it | 15:28 |
| mandel | nessita, np | 15:28 |
| alecu | nessita, good idea, please run it too | 15:28 |
| alecu | nessita, make sure to run it on a user with accents | 15:28 |
| nessita | alecu: can you please remind me the links? | 15:28 |
| alecu | nessita, mine is named "Ñandú" | 15:28 |
| nessita | alecu: I will create a new user, yes | 15:28 |
| nessita | I will be ñoñessita | 15:28 |
| alecu | nessita, https://code.launchpad.net/~alecu/ubuntu-sso-client/unicode-usernames | 15:28 |
| alecu | and https://mail.google.com/mail/u/0/#inbox/13268af052e17d69 | 15:29 |
| alecu | doh | 15:29 |
| nessita | mandel: LP seems to disagree with you https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/better-setup-account-button/+merge/75403 | 15:29 |
| alecu | wrong url | 15:29 |
| alecu | https://code.launchpad.net/~alecu/ubuntuone-client/unicode-usernames | 15:29 |
| mandel | nessita, I'll approve it then | 15:29 |
| nessita | thanks! | 15:29 |
| mandel | nessita, bubble sorted | 15:29 |
| nessita | ack | 15:30 |
| mandel | ralsina, cparrino I'm uploading the screencast right now, shows all the steps until the download fails (I have not uploaded an installer to the server so it goes bannanas) | 15:30 |
| mandel | ralsina, cparrino shows the start of the app and the dialogs for the update | 15:31 |
| gatox | lunch.... back in 20 | 15:47 |
| === gatox is now known as gatox_lunch | ||
| mandel | EOD cu on monday! | 15:47 |
| mandel | and goo weekend | 15:47 |
| === gatox_lunch is now known as gatox | ||
| === yofel_ is now known as yofel | ||
| nessita | lunchtime! | 16:46 |
| dobey | sigh | 16:58 |
| nessita | gatox: Text conflict in ubuntu_sso/qt/tests/test_controllers.py | 17:11 |
| nessita | 1 conflicts encountered. (in https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/verification-code/+merge/75755) | 17:11 |
| gatox | nessita, ok, i'll review it now.. i'm finishing with another branch | 17:11 |
| nessita | alecu: I was getting up to date with tons of stuff, starting your branches test now | 17:15 |
| nessita | alecu: ping | 17:33 |
| dobey | nessita: i don't see any way to test this set_wmclass() | 17:34 |
| nessita | dobey: is that method inherited from gtk? | 17:34 |
| dobey | nessita: yes it is a method on GtkWindow | 17:35 |
| nessita | dobey: let me see... | 17:35 |
| dobey | nessita: but there is no get_wmclass() method | 17:35 |
| nessita | dobey: hum, let me see if I can come up with something | 17:35 |
| nessita | dobey: so, the set_wmclass help recommends not using it but using set_role instead, is there any reason why set_role is no good for this? | 17:37 |
| dobey | yes, because we need to set the wmclass, not the role | 17:38 |
| nessita | dobey: you can use this test http://pastebin.ubuntu.com/690983/ | 17:44 |
| nessita | dobey: you will need to define WMCLASS_NAME and WMCLASS_CLASS as constants in gui.pu | 17:44 |
| nessita | gui.py* | 17:44 |
| nessita | dobey: and fix thew docstring grammar ;-) | 17:44 |
| dobey | eww | 17:44 |
| nessita | ralsina_: you around? | 17:49 |
| ralsina_ | nessita: here | 17:49 |
| nessita | ralsina_: when you have a relax moment, I have a trivial branch that needs review. Is not short but is very dumb: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/no-string-dupes/+merge/75783 | 17:50 |
| dobey | nessita: fixed/pushed | 17:50 |
| ralsina_ | nessita: looking right now then | 17:50 |
| nessita | dobey: looking! (FYI evo-TB branch is fixed and pushed too) | 17:50 |
| ralsina_ | nessita: the beta3 is downloadable now, so I can relax until it explodes on someone's face :-) | 17:51 |
| nessita | it will not! | 17:51 |
| dobey | good thing mandel isn't around | 17:52 |
| nessita | dobey: approving, but there is a lint issue | 17:54 |
| nessita | (added it to the MP) | 17:54 |
| ralsina_ | nessita: the branch seems ok to me | 18:00 |
| nessita | nice | 18:01 |
| gatox | nessita, ralsina_ branch ready: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/verification-code/+merge/75755 | 18:02 |
| nessita | gatox: this shows conflict as well in LP: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/mismatch-password/+merge/75785 (I have not branched it) | 18:02 |
| gatox | nessita, already fix that | 18:03 |
| nessita | ok | 18:03 |
| gatox | nessita, i'm waiting for launchpad to rescan it to give you the link | 18:03 |
| nessita | ah, ok | 18:03 |
| gatox | nessita, ralsina_ and this one is ready too: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/mismatch-password/+merge/75785 | 18:07 |
| gatox | nessita, and the test has been simplified | 18:08 |
| dobey | hmm, we need some resolution on the freeze exceptions | 18:13 |
| nessita | alecu: GREAT NEWS | 18:14 |
| nessita | alecu: I uploaded a file to the web and the notification came thru, and the file was perfectly downloaded | 18:15 |
| nessita | alecu: the whole logs is: http://pastebin.ubuntu.com/691010/ | 18:16 |
| alecu | nessita, great | 18:17 |
| nessita | alecu: look lines 251 in the log | 18:17 |
| alecu | nessita, I tried three times, at different times and I never get that message | 18:17 |
| nessita | alecu: syncdaemon was IDLE, and received a 2011-09-16 15:12:37,329 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: SV_VOLUME_NEW_GENERATION, kwargs: {'generation': 2L, 'volume_id': ''} | 18:17 |
| alecu | nessita, I never get the VOLUME_NEW_GENERATION | 18:18 |
| nessita | alecu: weird | 18:18 |
| nessita | alecu: you sure you're uploading to the Ñandú account? | 18:18 |
| alecu | nessita, I only get changes if syncdaemon gets disconnected or restarted | 18:18 |
| alecu | nessita, I'm sure, because if I create stuff locally it shows up immediately on the web. | 18:19 |
| nessita | alecu: I will try again... can you account have something odd? | 18:19 |
| alecu | hmmm I wonder if there's a newer protocol version | 18:19 |
| nessita | alecu: not newer than weeks agi | 18:19 |
| nessita | ago* | 18:20 |
| alecu | nessita, I'll try creating a new account | 18:20 |
| nessita | alecu: wanna paste the whole log from your attempt? I can try to see if something is odd | 18:20 |
| nessita | bye eyeballing it | 18:20 |
| nessita | by* | 18:20 |
| gatox | EOD... let me know if there is any problem with my branches!! in other case.... see you on monday! :D | 18:21 |
| nessita | gatox: have a great weekend! | 18:21 |
| alecu | nessita, my logs are huge, because I left it running to see if the server was slow; I'll start with a clean account. | 18:23 |
| ralsina_ | bye gatox! | 18:23 |
| nessita | alecu: ack | 18:23 |
| gatox | nessita, you too! and resst like crazy the next week! :P | 18:23 |
| gatox | ralsina_, bye | 18:23 |
| nessita | gatox: I will | 18:24 |
| nessita | alecu: FYI, using you both branches, I can't change the configs, I get this trace http://pastebin.ubuntu.com/691016/ | 18:28 |
| nessita | gatox: lint issue in verifiacation-code... | 18:32 |
| nessita | gatox: this is how you want me to relax next week??? :-D | 18:32 |
| nessita | gatox: added some change request to that branch, please add those before landing (but I approved it anyways) | 18:36 |
| nessita | alecu: on the other hand, I created a malicious UDF in the web and so far the notification hasn't come thru (5 minutos waiting so far) | 18:39 |
| nessita | gatox: I also noted that you resolved conflicts in this branch https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/mismatch-password/+merge/75785 adding some regressions to the code, so I marked as Needs Fixing. When is fixed, please send me an email to gmail and I will happily re-review it, no matter if I'm off. | 18:47 |
| nessita | ralsina_: FYI ^ | 18:47 |
| ralsina_ | nessita: I would prefer if you actually took time off :-) | 18:48 |
| ralsina_ | I promise no conflict, lint issue or pep8 issue will get merged in your absence | 18:49 |
| nessita | ralsina_: the problem is how diego resolved the conflict | 18:49 |
| nessita | ralsina_: I want to be sure he resolves it in the right way | 18:49 |
| nessita | ralsina_: and I'd rather 150% re-review this branch than going into vacations not knowing how that branch will end | 18:50 |
| ralsina_ | nessita: ok | 18:50 |
| dobey | crap | 19:05 |
| dobey | supporting things is hard | 19:05 |
| dobey | i think i need to go get tea | 19:05 |
| dobey | brb, will go get some | 19:06 |
| ralsina_ | off to do evening school run, and probably EOD, since I am just useless for coding today | 19:13 |
| ralsina_ | staring at the ssame line for 15 minutes is not progress | 19:13 |
| ralsina_ | so, EOW, and have a nice one everyone! | 19:14 |
| gatox | ralsina_, bye! have some rest! | 19:16 |
| ralsina_ | gatox: thanks! | 19:16 |
| nessita | gatox: you're back! | 19:16 |
| nessita | bye ralsina_, have a good weekend | 19:17 |
| ralsina_ | nessita: you too, have a nice vacation, see you at pycon! | 19:17 |
| nessita | :-) | 19:17 |
| gatox | nessita, yes, i take a little nap before the gym..... i'll be fixing the branches you mentioned later, is that ok? | 19:18 |
| gatox | nessita, i'm about to leave now | 19:18 |
| alecu | nessita, I can't reach the pastebin web, can you paste it again somewhere else? | 19:20 |
| nessita | alecu: sure | 19:20 |
| nessita | gatox: ack | 19:20 |
| alecu | nessita, nevermind, I just reproduced it | 19:21 |
| gatox | ok, now i'm leaving...... have a great weekend all of you... nessita and enjoy les luthiers if you go too :P | 19:21 |
| nessita | gatox: I am! | 19:21 |
| nessita | gatox: 21:15 I'll be in my seat | 19:21 |
| gatox | Neoti, today?? jeje me too | 19:22 |
| nessita | let's scream "aguante ubuntu one" at 21:29 | 19:22 |
| nessita | let's sync up out watches! | 19:22 |
| gatox | jejejejej | 19:22 |
| nessita | alecu: ack | 19:22 |
| gatox | bye....... nessita i'll be waiting for your scream jejee | 19:22 |
| nessita | gatox: bye! | 19:23 |
| nessita | popey: ping | 19:44 |
| popey | nessita: hello | 19:52 |
| nessita | popey: hey there! are you adam pope? | 19:52 |
| popey | Yes! | 19:52 |
| popey | No. | 19:52 |
| popey | Sorry to get your hopes up there momentarily. | 19:52 |
| nessita | popey: yes or no? I'm confused! :-) | 19:53 |
| popey | No. | 19:53 |
| popey | I am Alan Pope. | 19:53 |
| nessita | popey: I'm asking cuz I saw a bug report from Adam Pope, and I thought it was you | 19:53 |
| nessita | popey: and wanted to debug it, but if he is not you, I'm sorry I pinged you with no real reason :-) | 19:54 |
| popey | Its never a problem. Anytime. | 19:54 |
| nigelb | duanedesign: Would any one else from the team be willing to participate? | 19:57 |
| nessita | alecu: ping | 19:58 |
| nessita | alecu: I will "temporarly" assign bug #851356 to you, in case you ran out of tasks next week (yeah, I know is very unlikely). When I get back, I will probably assign it back to me :-) | 19:59 |
| ubot4 | Launchpad bug 851356 in ubuntuone-control-panel "QT UI: Folder list may show garbage for user homes non-ascii (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/851356 | 19:59 |
| alecu | nessita, pong and ack | 19:59 |
| nessita | ok, I will be eoding soon | 20:10 |
| nessita | see ya all on the 26th! | 20:10 |
| dobey | 27th? | 20:14 |
| dobey | oh, 26th | 20:14 |
| dobey | jane lied! | 20:14 |
| dobey | :) | 20:14 |
| nessita | dobey: you giving me an extra vacation day? :-D | 20:14 |
| dobey | nessita: have a good holiday | 20:14 |
| nessita | thank you, I will try | 20:14 |
| nessita | bye all! | 20:16 |
| karni | Good night #ubuntuone | 21:03 |
| dobey | have a good weekend karni, and all | 21:24 |
| karni | Thank you dobey, you too! | 21:25 |
| Beret | hrm | 22:09 |
| Beret | I just tried ot share a file and I got a blob error | 22:10 |
| Beret | anything broken that I know of? | 22:10 |
| Beret | s/I/you/ | 22:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!