[02:53] mandel, I know you are getting this via bip. I am cursing your ancestors. In a nice way though! [08:16] we are currently restarting music streaming so it may not work for some moments [08:19] And we are back! [08:20] duanedesign, library cache timeout has been changed for the streaming, now it is 4 minutes [09:04] hi everyone [09:04] gatox, morning [09:04] mandel, how are you? [09:05] gatox, doing lots of bug triaggin in the ubuntuone-windows-installer, the are lots from the last beta :( [09:05] gatox, and you? [09:06] starting my day [09:07] gatox, I was going to say, is freaky friday! but it does not apply to either of us :( [09:07] mandel, i have to fix one test from one of my brances (grrrrrr mocker) and keep working on medium bugs..... i close all the highs yesterday [09:07] mandel, buy the are going to appear again soon [09:07] :P [09:11] gatox, nice! I'll do some bug cleaning to remove a lot of noise and then will improve the autoupdate [09:12] gatox, I might get back to work on my u1 chome extension if I have the time, or a pb json implementation, I dont know :P [09:16] Happy Friday, folks! [09:43] Good morning! [10:19] ralsina, ping [10:19] mandel: pong [10:19] ralsina, buenos dias! [10:19] ralsina, thx for looking at the aoutupdate branch :) [10:19] buen dia manuel [10:19] no problem [10:20] ralsina, do yo have the changes so I can merge it with mine and change things so that it is nicer [10:20] but we really need to get you making bundles, or it's not going to scale :-) [10:20] ralsina, and, just for curiosity, waht did you say about my ancestors? hehe [10:20] I called them old mandels [10:20] mandel: the fixes I did are crap [10:21] ralsina, yeah, I'm going to be looking at why py2exe is broken in my env since all the rest seems to work [10:21] ralsina, yes, but then I can see the diff and fix them in a nicer way [10:21] ralsina, at least, did you see the dialog and all that? [10:21] * mandel has already decide to not have afreaky friday [10:21] yeah, I even got to trying to download the new relaease [10:21] ralsina, did it get it? [10:22] mandel: one small problem with this solution: did you notice autupdate-windows is 6MB? [10:22] mandel: no [10:22] mandel: but that was probably a bad URL in your XML [10:22] ralsina, yes.. the bundle is getting very fat [10:22] ralsina, seems reasonable, I'll take a look at that [10:33] ralsina, did you push the changes somewherE? [10:38] mandel: let me use a junk branch [10:38] ralsina, super! [10:39] ralsina, atm I'm just cleaning the bugs in ubuntuone-installer, there are lots from the old beta and I dont like the noise, although I think bug 680348 does apply, what do you thin? [10:39] Launchpad bug 680348 in ubuntuone-windows-installer "Provide a way to stop Ubuntu One from starting at boot time (affects: 4) (dups: 2) (heat: 7)" [Medium,In progress] https://launchpad.net/bugs/680348 [10:39] s/thin/think [10:39] mandel: what's the url for unk? lp:~ralsina/+junk/whatever ? [10:40] ralsina, yes, I believe so [10:40] Well, the obvious way is to remove it from autostart like any other program :-) [10:40] ralsina, I can give that as an answer and simple set it as wont fix [10:40] I think it's fairly reasonable [10:41] ralsina, ok [10:41] We could provide a more detailed answer in the wiki but we would have to do it for N windows [10:42] ralsina, well, I'm the one that filed the bug hehehe [10:42] ralsina, but we should indeed put that in the wiki [10:42] so if it makes you happy, mark it as fix-released ;-) [10:43] next victim of our wrath should be proxy support I think [10:43] mandel: lp:~ralsina/+junk/autoupdate [10:43] ralsina, but that is for ubuntuonoe-client to get done... [10:43] mind you, the changes are really hackish [10:43] mandel: yes [10:43] mandel: ubuntuone-client is slowly becoming ours [10:43] ralsina, yes, but they work, I can deal with the issue :) [10:44] mandel, do you have a minute? [10:44] ralsina, I've noticed? I honestly will like to work on chaing from spread.pb to json so that we can use other langs to talk with syncdaemon [10:44] gatox, dime :) [10:45] stupid three dot becoming ? stupid schat [10:45] mandel: have you noticed? (just kidding) [10:45] mandel: I am pretty sure that's a plugin [10:45] ralsina, yeah, I did notice hehe [10:46] mandel, i wanted to ask you something about mocker... i think that it should be something really simple, but i don't know how to do it... in this branch i added the line: 113 (also 111 and 112 to see if that works): https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/name-required/+merge/75366 [10:46] ralsina, yeah, I'll fix this during the weekend, I just have to remember not to use ? :P [10:47] gatox, ok, so what is the question ;) [10:47] mandel, because the funcion validate_form changed and in that case needs to call set_error_message... but always tells me that: self.view.ui.confirm_email_assistance is None... i don't quite understand how to do for self.view.ui.confirm_email_assistance to be valid [10:49] gatox, do you mind runing the tests and pastebin the errors? [10:49] mandel, no problem! [10:50] gatox, thx, know I should run them, but I'm in the midle of something and my context swtich is very expensive hehehe [10:51] ralsina, if you have a new pacakage I can make the screen cast for you reagind the autoupdate. [10:51] mandel: yes, it's in the mail! [10:51] Or you are not in that mail? I think you are [10:51] mandel, http://paste.ubuntu.com/690692/ [10:51] ralsina, soy estupid, perdon! [10:52] ralsina, I am, I read it I ignored the fact that there was an installer in it [10:52] mandel: but that's not screencast ready, I think [10:52] Or rather, let's do it so we can see it and decide a process for the upgrade [10:53] I am not really sure bitrock's autoupdater buys us much, and it's huge and not pretty [10:53] ralsina, yes, I agree, let me help gatox and I'll get to that [10:54] gatox, self.view.ui.confirm_email_assistance is it set? [10:55] no... i tried to set that.... but always fails... setting that to a QLabel.... trying to set that to = self.controller.view.ui.confirm_email_assistance or something like that, but it didn't work [10:55] mandel: no rush [10:55] gatox, ok, let me brach the code and fis that for you, I'll add some comments explaining wtf is going on :) [10:56] mandel, THANKS!!!!! [10:56] mandel, i waste a lot of time yesterday trying to fix that :S [10:57] gatox, no worries, but I though you were getting rid of mocker? might be a good small work for fridays... [10:58] jajaja "your fun friday project is rewriting all these crappy tests, kid. FUN!" [10:58] ralsina, jejej [10:58] ralsina, well, I thing fridays is more of 'you are not told what to do' [10:59] mandel, yes, i have a branch were i'm migrating mock tests.. but not this one... because the new branch has some issues to be resolved first [10:59] ralsina, and in honesty, I hate building more things on top of things I dont like, like I'm writing something to get rid os spread.pb and later will fix all the crap of the IPC :) [10:59] that need to be resolved.... [10:59] mandel: I agree jsonrpc is the future [11:00] mandel: just the thought of "hey, I could log the traffic" makes me smile like a justin bieber fan! [11:00] ralsina, jejeje [11:00] ralsina, yeah, I' writting a lib like spread.pb (even based in the design) so that we just change the imports :) [11:01] and writing a protocol interceptor is trivial, just a sort of logging cat fr namedpipes [11:01] ralsina, in the "sign in to ubuntu one" page there is no more "default button"... that's the idea or there is a bug there? [11:01] gatox: there is a bug. That and the "skip tour" button is default [11:01] it only happens on build though, and I have no idea why [11:01] ralsina, and in BA I'll like to work with alecu to see what we can fix in the IOCP reactor, maybe we can get pipes back in the equation :) [11:02] the "skip tour" we could just specify it, since now it's done "by default", I think [11:02] but the other? I dunno. [11:02] ralsina, ok..... i can fix this one [11:03] mandel: yes, the whole stepping tcp ports based on uid.... creepy [11:03] * gatox is downloading windows8... want to see if he can made u1 run on win8... hates win, loves the challenge jeje [11:03] gatox: since it only happens on builds, no you don't unless you build one :-) [11:03] gatox: someone already did, and it works [11:03] ralsina, ahhhhok [11:03] mandel, gatox: I will leave now for 30 minutes or so to take the kid to school [11:04] mandel: could you show gatox how to do a build? [11:04] ralsina, okk [11:05] gatox, yes,arasure [11:05] mandel: make sure you use revno 62 from my packaging branch :-) [11:06] gatox, can you let me know which command you were using to run the tests, to make sure I run the same one that you have [11:07] run-tests.bat....... or "python path/to/u1trial path/to/test.file --gui --reactor=qt4 [11:08] oh, just that.. lame :P [11:15] hello everyone! [11:15] nessita, hi [11:15] hello nessita [11:16] * ralsina walks the kid [11:20] gatox, looks like the mock has 3 expectations set and the first has no return value [11:20] gatox, I'm looking where is that occurring [11:21] mandel, ok, thanks... i can't wait to kill all the mock tests :P [11:21] gatox, ha, just found it :) [11:21] gatox, selg.controller.view is a mock, right? [11:22] yes [11:22] mandel, ^ [11:23] gatox, I'm pushing a branch with the fix, take a look at the diff [11:23] mandel, awesome! [11:23] gatox, the issue was that you where using selg.controller.view.etc as the result, so that was setting again the expectation and later you were doing it again, you had 3 expectations set [11:24] the first returned none, second one what you wanted, the thrid nont too [11:24] * gatox needs to look at the code to fully understand :P [11:28] gatox, everything fixed [11:28] gatox, at least for that test :P [11:29] mandel, awesome! [11:29] gatox, merge lp:~mandel/ubuntu-sso-client/name-required and you will see how easy was to fix [11:29] * gatox merging [11:29] gatox, let me know if it fixes it and then I'll go to walk the dog [11:30] mandel, ok..... [11:31] mandel, fixed! THANKS YOU VERY MUCH!! :D [11:31] gatox, denada :) [11:32] gatox, do you understand what was the issue? [11:32] mandel, i'm looking at the code right now...... first i ran the test so you can walk the dog :P [11:33] gatox, ok, but the issue was 'simple' you set self.controller.view to be a mock, so every time you made a call to that you were setting an expectation, in your setup code of mocker you had one call to self.view and 2 to self.controller.view but they are the same object! [11:34] that made mocker record 3 diff expectations, the one you intended in self.view and two that you did not expect self.comtroller.view [11:34] mandel, ahhhhhh now is more clear! [11:34] then the error was complaining because it was getting None due to the order in which the expectations were set [11:34] gatox, so we can say it was a small typo :) [11:35] mandel, yep, i understand now! :D [11:35] cool, then I walk the dog :) [11:35] bbl [11:47] gatox: I saw you made my reviews, did the IRL test suceeded? [11:47] :-) [11:47] nessita, yes, i didn't have any trouble this time [11:48] gatox: great! Does the change make sense? (I'm asking since you're way more familiar with that than me) [11:48] nessita, but i could find what we talk yesterday... did you implement another solution instead of pageInitialized? [11:49] gatox: I removed the set_up_button definition from the sso controller, since it was already being handled in the setupaccountpage in the wizard, so I moved the button "tunning up" there [11:50] nessita, ok, great [11:50] nessita, also, my 2 remaining branches are ready [11:51] gatox: yeah I started with those already [11:51] nessita, ok [11:52] gatox: last night I was thinking... why do we need the DisabledState property? isn't it enough with having primary/secondary buttons and then apply setEnabled to them? [11:53] nessita, nop..... i fought with that during the sprint..... the problem is that we don't have 2 button states..... we have 3 [11:53] gatox: which three? [11:53] nessita, primary (orange), secondary (white), disabled (gray) [11:54] gatox: but disabled (grey) is the same as disabled(secondary) and disabled(orange) [11:56] nessita, yes, MAYBE we can delete the style for: disabled(secondary) and disabled(orange), but there was some serious issues trying to use disabled and enabled from primary and not primary..... maybe something change during this time..... but i'm pretty sure that it took some time to have that working... and i needed a third state [11:58] gatox: can we use in qss QPushButton:pressed[enabled="false"]? [11:59] nessita, yes [11:59] gatox: we could use that instead of the DisabledState, no? [11:59] nessita, i think that the problem i was having before came from the combination of two properties [11:59] nessita, default and enabled..... and that was kind of a mess [11:59] weird [12:00] nessita, i can give it a try if you want [12:00] anyways, I will file a bug to clean that up, but Low priority of course [12:00] gatox: no need to do it any time soon, I wa sjust curios [12:01] nessita, ok..... but i remember that in the sprint we talk with ralsina about that and finally i finished create a property to avoid conflicts between several states combined [12:01] creating* [12:01] yes, the orange buttons only refreshed when hovered, wacky stuff [12:02] ralsina: but that is fixed with the polish/unpolish, no? that we're calling the same [12:02] nessita: yes, but without the three states, it refreshed white, or something like that. It was so annoying we grabbed the first thing that worked ;-) [12:02] ralsina: my intuition tells me that there is no need for having the DisabledState. But like I said to gatox, it was just curiosity, no need to change anything right now [12:03] yeah, I agree that it seems redundant [12:03] nessita, yes, the problem was on hover as ralsina says... the styles get confused [12:03] gatox: maybe that can be solved by swapping the order in the qss? [12:04] ralsina: btw, I just filed #851810 for the thing that cristian reported as regression (I also send clarification to that email) [12:04] nessita, i'll check that later...... but believe me..... i swap everything that day!! jeje [12:04] gatox: no need to invest time in that [12:04] *really* [12:04] nessita: I think we already have a bug for the empty UDFs: bug #845649 [12:04] Launchpad bug 845649 in ubuntuone-client "syncdaemon may return an empty UDF list for an account with UDFs (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/845649 [12:05] at least not today [12:05] ralsina: ah, I looked and failed [12:09] * mandel back [12:11] ralsina: can I have a review please? https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/setup-button/+merge/75602 [12:11] nessita: Sure. I am in the middle of building the installer for signing, and testing it, so it will take a bit. [12:11] ralsina: no problem [12:12] nessita: and agreed I need to clean all those WHATEVER_PAGE_ID things. I was using a naming scheme and then I had to switch to SSO's and I never cleaned it [12:13] gatox: this is approved, but has no commit message. And since we're at it, ideally commit message would be something like: [12:13] - Fixed foo, bar and baz (LP: #123456) (LP: #654321). [12:13] ralsina: FYI, for future branches ^ [12:13] nessita, ok! [12:13] gatox, ralsina: that shape of commit messages improves and eases the writting of the chnagelog when releasing [12:13] gatox: the branch I was referring to is: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/845750/+merge/75606 [12:14] ralsina, nessita do you know andrews nickname in freenode? [12:14] mandel: should be blajk [12:14] blajk: [12:14] mandel: ^ [12:14] thx! [12:14] blajk, ping [12:15] mandel, pong [12:15] blajk, can you answer https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/670642 for me, I think is a wont fix [12:15] Launchpad bug 670642 in ubuntuone-windows-installer "Taskbar icon should show offline status (affects: 2) (heat: 1)" [Low,In progress] [12:15] blajk, you are the only design person around :) [12:15] mandel, I look at it now! [12:15] blajk, sorry run ulr, is this: [12:16] https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/681881 [12:16] Launchpad bug 681881 in ubuntu (and 1 other project) "Ubuntu One should use a monochrome icon in Windows 7 (affects: 5) (heat: 4)" [Undecided,Invalid] [12:16] we *may* in a future implement the status as part of the icon, but it's useless on windows 7 since you can't *see* the icon [12:16] ralsina, I think one of them is a won fix for sure, dont know about the other [12:17] blajk, I'm of to lunch but do get back to me whenever (I love bip! ) [12:17] * mandel lunch [12:17] mandel: our icon *is* monochrome [12:17] it's just ORANGE [12:20] mandel, ralsina, did you had a look at the screenshot provided (http://ubuntuone.com/p/Qvb/)? Isn't it the wrong icon? On my machine it is replaced with a little U1 logo, that is indeed monochrome. [12:20] that's the oooooooooold code [12:21] so I'll mark it as fix-released [12:21] ralsina, cool! [12:22] ok, invalid because I am feeling bitchy [12:23] the other one is wishlist [12:52] alecu, dobey, nessita, gatox: standup in 8' [12:52] ralsina, ack [12:52] right [12:53] ralsina, blajk that bug was an old one from the first beta, so shall I mark it as invalid then? [12:54] mandel: taken care of :-) [12:54] ralsina, thx! [12:59] ralsina, there are lots of bugs whose status is fix commited, do you know which we can set as fix released? [12:59] I'm trying to remove the bug noise [12:59] me [12:59] me [12:59] me [13:00] me [13:00] ralsina, alecu, dobey? [13:00] me [13:00] mandel: well, I suppose all of them if we count betas as releases [13:00] or none of them if we only count releases as releases :-) [13:00] mandel, go [13:00] DONE: Lots of bug triagging. I've removed most of the bugs from the old beta. [13:01] TODO: Clean the fixes from the autoupdate from ralsina. Do a screencast of it. [13:01] BLOCKED: no [13:01] next gatox [13:01] DONE: [13:01] All the critical and high bugs fixed. Some reviews. [13:01] TODO: [13:01] Keep working in medium bugs. [13:01] BLOCKED: [13:01] No [13:01] nessita go [13:01] DONE: reviews, bug triage, bug assignment, clean up in SSO and installer re: the setup account button, talks with alecu re: non-ascii username bugs [13:01] TODO: finish reviews, leave task assignment done for next week [13:01] BLOCKED: nopes [13:01] NEXT: alecu [13:01] nessita: that won't work :-) [13:01] DONE: fixed small bugs in the installer, several larger ones in the build process, helped manuel with the autouploader, reviews, did release (currently expecting last signing) TODO: since I was working until 2AM last night, and started at 7AM today, probably going to sleep after 12. BLOCKED: I am so sleepy. dobey? [13:01] ralsina: yes, sorry [13:02] ralsina: brain hole [13:02] λ DONE: FFE for devtools, bit of debugging, bit of bugging about TB [13:02] λ TODO: bug #838778, hack day? [13:02] λ BLCK: None. [13:02] Launchpad bug 838778 in ubuntuone-control-panel (Ubuntu Oneiric) (and 2 other projects) "After installing Ubuntu One, there are 2 Ubuntu One launchers in System Settings (affects: 47) (dups: 11) (heat: 210)" [High,Triaged] https://launchpad.net/bugs/838778 [13:02] alecu [13:02] ralsina, that is something to consider? I wonder how are we going to be keeping track of this [13:03] mandel: track of what? [13:03] ralsina, of witch bugs for windows are released [13:03] fix-committed is trunk, so once we consider we did a release, they are released [13:03] dobey: I decided the string freeze exception for the 'dotted' string is not worth it, so since there has been no changes in the gtk side of ussoc, I'll make the stable tag in the revno before that branch from leo (mostly FYI). [13:04] then we can switch every u1-zomg-windows bug from fix-committed to fix-released [13:04] ralsina, ok, then do we consider the betas to be a release? so far we have 175 bugs and most of them are fix commited [13:04] I don't know if there is a policy [13:04] specially when we have betas and no finals [13:04] ralsina, I think you and nessita are the ones that call that [13:05] mandel: if there is no previous policy, yes, we are [13:05] mandel: fix released when we hit the final 1.0, I'd say [13:05] hello [13:05] I don't care. fix-committed is nice enough :-) [13:05] hi alecu [13:05] alecu, hi [13:05] So on 1.0 it is [13:05] ralsina, nessita ok, then I'll leave everything as commited then [13:07] mandel: do you have the latest keyring compiled? I would like to have that in my dev box [13:07] nessita, yes I do, lt me upload it to a public u1file [13:07] thanks! [13:08] nessita, if I have some free time during the weekend I'll try to push this to trunk in pykeyring [13:08] mandel: that would rock [13:08] gatox: can you please confirm this is fixed? https://bugs.launchpad.net/ubuntu-sso-client/+bug/753699 [13:08] Launchpad bug 753699 in ubuntu-sso-client "The windows ui does not pass the display name to the backend (affects: 1) (heat: 7)" [High,Triaged] [13:08] gatox: if not, this is a new Critical for you :-D [13:08] nessita, ok [13:08] gatox: the display name is the name field [13:09] mandel: you can track that in https://bugs.launchpad.net/ubuntu-sso-client/+bug/812512 [13:09] Launchpad bug 812512 in ubuntu-sso-client "Windows: AttributeError: module has no 'delete_password' (affects: 1) (heat: 11)" [High,Triaged] [13:09] nessita, yes [13:09] nessita, basically is create an account without a name or something else? [13:10] gatox: you can check the code, in ussoc. When the qt calls the backend for register, does the name is passed? [13:10] nessita, ahhhhhh okok.... i think it is..... i'll check now [13:10] gatox: thanks [13:10] ralsina: is the a new bundle (even if it's not signed) so I can give it quick try? [13:11] nessita: it's in your email [13:11] mandel: you started working on the migration from old-beta-to-new-beta rhingy? [13:11] ralsina: right, I was asking since you mentioned that you were building a new one? [13:12] (09:11:43 AM) ralsina: nessita: Sure. I am in the middle of building the installer for signing, and testing it, so it will take a bit. [13:12] I was hoping to test that ^ one [13:12] nessita: it should be exactly the same. Let me dig that URL [13:12] nessita, here you have the lib: http://ubuntuone.com/6fkY1IvG7LNmvqKjXDFtYL unzip in Lib\site-pacakages [13:12] nessita: http://ubuntuone.com/1gbjdEJkTBY4vwC9FCaxhw [13:13] boy are the new unguessable URLs unguessable [13:13] mandel, ralsina: thanks! [13:13] nessita, not yet, I wantes to fix the small issues in the autoupdate so that lands nicely in trunk [13:13] DONE: worked on unicode usernames, found more unicode brokenness on sd and the cp, also helped facundo with the server branch that fixes delayed hashing [13:13] TODO: server changes not being reflected on the windows client [13:13] BLOCKED: no [13:13] mandel: ack [13:13] nessita, yes, register_user is being called with the proper name [13:13] mandel: and ADD TESTS ;-) [13:14] ralsina, that is one of them :) [13:14] mandel: so you'll start on that next week, and I think that will take 2-3 days, which will cover your week [13:14] nessita, should i mark it as fix commited? [13:14] alecu: thanks for the report. I suppose it's the same ugly stuff we have been seeing for the last 2 months, right? [13:15] nessita, yes, sounds about right, maybe a little less but not much more [13:15] nessita, tests are going to be the hard thing [13:15] ralsina, I thought it was my branch... I should try trunk [13:15] ralsina, do you have any more info on the "ugly stuff"? [13:16] alecu: I mean the encoding problems and assumptions about paths [13:16] alecu: or is it some new, original unicode brokenness? [13:16] gatox: what file is the call in? [13:17] ralsina, oh, you mean the encoding problems on the control panel? [13:17] ralsina, I thought you were talking about "server changes not being reflected on the windows client" [13:17] gatox: I'm looking at controllers.py:478 and the name is not passed... :-/ [13:17] alecu: "unicode brokennes in sd and the cp" :-) [13:18] gatox: sorry, I looked wrongly [13:18] it's passed! [13:18] nessita, this is what i'm looking at: http://paste.ubuntu.com/690780/ [13:18] * nessita breaths again [13:18] gatox: you are right [13:18] * popey notes the /topic doesn't mention the windows client [13:18] gatox: I misread the app_name vs the name [13:18] where can I get it? [13:18] nessita, ahhhh....... fix commited? [13:19] popey: it what? [13:19] 14:18:49 * popey notes the /topic doesn't mention the windows client [13:19] ^^ that :D [13:19] gatox: yes please [13:22] threeve, ping [13:22] ralsina, in the update branch we start slow because subprocess.call blocks, calling it from a thread should improve that, I need to think that is the best thing to do to ensure that the update occurs before we stop the reactor [13:24] never mind, found it. [13:24] Love the look of the new windows client! [13:25] popey, \o/ [13:31] gatox: added a new comment to https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/848490 [13:31] Launchpad bug 848490 in ubuntuone-windows-installer "Verification code should be a required field (affects: 1) (heat: 39)" [Medium,In progress] [13:31] nessita, ko [13:31] ok [13:34] nessita: thanks for the bugs thingy! [13:34] ralsina: :-) [13:35] nessita: I'll try to keep code standards not-too-low in your absence :-) [13:35] ralsina: please try to keep it high! :-) [13:36] the same apply to everyone ^ :-) [13:36] hehe [13:37] say what?! [13:37] :P [13:37] mandel: we need to think about cleaning up all the build stuff before merging it. Please separate the autoupdater stuff that is in code on a separate branch please [13:37] ralsina, hm.. sure but we can have one depend on the other one, right? [13:38] ralsina, what is the gain in separating it? [13:38] mandel: I mean all the stuff in "ubuntuone_installer" in one branch. I already merged the script/ stuff into mine [13:38] mandel: that we can merge it first [13:38] since my branch moves a lot [13:39] ralsina, I don't understand, so I should not use you branch as the parent, the lp:~ralsina/ubuntuone-windows-installer/fix_809873 [13:40] ralsina, is it going to be merge in trunk? [13:40] mandel: it is, but it still needs lots of work :-( [13:40] and I don't want to have to merge the autoupdate code manually [13:41] ralsina, oh, dont worry, you fix that branch and I'll fix the merge with that before we go to trunk [13:41] So, I want to land the code first, and keep packaging from my branch [13:41] ralsina, gatox: I just reported https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/851885 which is a bug High. There is no clean solution for it, so I've assigned it to myself, to try to tackle when I return from my holidays. [13:41] Launchpad bug 851885 in ubuntuone-windows-installer "When logging in with an no-yet-validated account, there is no useful message (affects: 1) (heat: 6)" [High,Triaged] [13:41] mandel: pretty please? The code and packaging bits are fairly independent [13:41] ralsina, what is packang exactly? [13:41] mandel: everything under scripts [13:42] nessita, ack [13:42] ralsina, hm.. I can do that, that is easy since I just touch certain python files, but what to do with the ubuntuone.xml and ubuntuone_autoupdate.xml? [13:43] mandel: I already merged that [13:43] if you need to work more on that, start another branch from mine and I'll merge it [13:43] ralsina, so, you aleady merged that in scripts, right? so what is missing from scripts? [13:43] mandel: cleaning [13:44] that's why I want a branch with the ubuntuone_installer stuff that we can merge [13:44] and doesn't block on "roberto has to cleanup crap from ubuntuone.xml and setup.py" [13:45] ralsina, oh, I can base my branch from trunk, but I'l do that at the end [13:45] ralsina, since I want to test building the .exe [13:46] mandel: want to have a 5' mumble so we clarify this? It's easier than you think :-) [13:47] ralsina, I think I understand, get a branch with just my changes and nothing in yours [13:47] ralsina, right? [13:48] you do a branch from trunk with the changes for ubuntuone_installer folder. Then start with my packaging branch, do fetch, go to sources/ubuntuone-windows-installer, merge your branch, go back to scripts, and do fetch py2exe [13:48]