[03:15] <cjohnston> do be do
=== Ronnie1 is now known as Ronnie
[16:32] <mhall119> nigelb: cjohnston: james_w: https://code.launchpad.net/~mhall119/summit/rest-api/+merge/75859
[16:39] <nigelb> mhall119: heh, just saw that
[16:40] <nigelb> mhall119: Did you see lyz is doing a career day today?
[17:23] <mhall119> nigelb: yeah
[17:26] <mhall119> nigelb: cjohnston: james_w: got another one for you: https://code.launchpad.net/~mhall119/summit/personal-ical/+merge/75860
[17:28] <mhall119> and with that, I'm calling it a day
[17:28] <mhall119> nigelb: would you be able to figure out which bugs we've fixed since last UDS?
[17:29] <nigelb> Yeah
[17:29] <nigelb> mhall119: Can you blog?
[17:29] <nigelb> I'll mail it to ya
[17:33] <mhall119> yeah, I'm going to blog about our summit progress, and I'd like to include that list
[17:47] <mhall119> thanks nigelb
[17:47] <nigelb> :)
[17:50] <mhall119> 33 bug fixes, not bad
[17:50] <mhall119> that doesn't even count the numer of things that we did without a bug #
[17:50] <nigelb> I'm going run a lint.
[17:50] <mhall119> be careful
[17:50] <nigelb> mhall119: check merges as well.
[17:50] <mhall119> lint just might punch you in the face when it sees it
[17:50] <nigelb> haha
[17:50] <nigelb> Entirely possible.
[17:51] <nigelb> Or it might say "LOL"
[17:53] <nigelb> mhall119: OH GOD.
[17:56] <mhall119> I'm guessing it was closer to a punch in the face than "LOL"
[17:56] <nigelb> It punched me.
[17:57] <nigelb> let me do somethign like what launchpad does
[17:57] <nigelb> fix lint for files you modify
[17:57] <nigelb> so, slowly, we'll get there.
[17:59] <nigelb> Hrm. This may be hard.
[18:00] <mhall119> 68 merges
[18:00] <mhall119> yeah, I'm not overly concerned about lint
[18:00] <mhall119> for new files it might be a good requirement
[18:01] <nigelb> mhall119: I'll try and fix them all in an MP.
[18:03] <mhall119> all?
[18:03] <mhall119> I'd suggest one MP per file
[18:03] <mhall119> it'll be easier for us to review
[18:05] <nigelb> one MP per file?
[18:05] <nigelb> woah.
[18:05] <nigelb> that's goign to be hard.
[18:05] <nigelb> I can do one MP per app.
[18:06] <mhall119> there's only 2 apps
[18:06] <nigelb> Yeah :D
[18:06] <mhall119> http://paste.ubuntu.com/691741/ anything else I should mention in my blog?
[18:06] <mhall119> nigelb: I just don't want a 4000 line MP
[18:07] <nigelb> It won't be that long, don't worry :)
[18:07] <nigelb> mhall119: You will clean up the formatting right?
[18:07] <mhall119> I'm betting it'll be close
[18:07] <nigelb> like put it into a table, eetc
[18:07] <mhall119> nigelb: yes, that's just a quick dump of what I want to mention
[18:07] <mhall119> I'm also hoping to be able to mention my 2 new MPs (hint, hint)
[18:08] <nigelb> :)
[18:15] <mhall119> one more MP: https://code.launchpad.net/~mhall119/summit/fix-test-site_root/+merge/75862
[18:16] <mhall119> 63 test cases, and with the above MP they all pass
[18:21] <nigelb> mhall119: I get what you mean
[18:21] <nigelb> this is going to be long lints
[18:21] <nigelb> so I'll fix a few propose an MP. fix a fwe more and propose another MP.
[18:38] <mhall119> sounds good
[18:38] <james_w> mhall119, 237	+ key.update(str(self.pk))
[18:38] <james_w> 238	+ key.update(self.user.username)
[18:39] <james_w> why did you want to have those in the md5?
[18:39] <mhall119> james_w: just to add more to the hash than just a random number
[18:40] <mhall119> overkill?
[18:41] <james_w> I think the only thing it protects against is recycling the RNG seed
[18:42] <james_w> if, say, every request had the same seed then every user would get the same key without that
[18:42] <james_w> but aside from that I don't think it contributes much
[18:42] <james_w> but it doesn't hurt either
[18:42] <nigelb> When does the md5 get generated?
[18:43] <nigelb> Every login?
[18:43] <nigelb> (I just confused after I commented)
[18:43] <mhall119> nigelb: the first time Attendee.get_secret_key is called
[18:43] <james_w> all three approved
[18:43] <nigelb> james_w: You, sir, are courageous. Cleaning up render.py is not an easy task :)
[18:44] <mhall119> james_w: you'll have to update your MP for the Schedule.__init__ cleanup to add the show_private that I added
[18:44] <james_w> yeah
[18:45] <james_w> nigelb, yours is approved as well now
[18:45] <nigelb> Thanks!
[18:45]  * nigelb runs tarmac
[18:48] <james_w> mhall119, merged, and test added
[18:57] <mhall119> http://ec2-50-16-76-22.compute-1.amazonaws.com/ has been updated to trunk
[18:58] <mhall119> the personal ical is going to be much nicer
[18:58] <mhall119> who manages the bots for UDS, anybody know?
[18:58] <nigelb> mhall119: tsimppson
[19:04] <mhall119> now I just need to write API docs
[19:04] <mhall119> nigelb: would it be appropriate to add the API doc to your rtd stuff?
[19:07] <nigelb> mhall119: Yes, please go ahead
[19:11] <nigelb> james_w: what do you think abuot setting up bzr pipes for lint checking? (like launchpad)
[19:11] <james_w> pipes?
[19:12] <nigelb> bzr pipe plugin
[19:19] <mhall119> nigelb: if you make committing dependent on passing a lint test, I swear to god I'm leaving the project
[19:19] <nigelb> mhall119: lol, not commiting.
[19:20] <nigelb> What it does is, lints the files you make changes
[19:20] <nigelb> But only those files
[19:20] <nigelb> So, like our testing infrastructure, we can slowly improve
[19:21] <nigelb> so, if you branch and touch 5 files, it will only lint those. Once you commit and touch one file. Before the next commit it will only lint one file. Onc you commit - all 6 files.
[19:43] <james_w> https://code.launchpad.net/~james-w/summit/test-render.py-2/+merge/75870
=== Ronnie2 is now known as Ronnie