=== SuperHark is now known as MichealH | ||
james_w | going to do the summit update now | 16:07 |
---|---|---|
james_w | done | 16:14 |
james_w | another issue with the url mapping: http://summit.linaro.org/uds-p/track/linaro-hackfest/?edit | 16:18 |
james_w | not caused by that update | 16:18 |
mhall119 | james_w: it's the + sign | 16:21 |
mhall119 | should be easy enough to add to the urlconf regex | 16:21 |
mhall119 | is there a bug # for it? | 16:21 |
james_w | not yet | 16:21 |
james_w | I'm going to fix it right now | 16:22 |
james_w | https://bugs.launchpad.net/summit/+bug/853991 | 16:25 |
ubot4 | Launchpad bug 853991 in summit "Plus sign in meeting name breaks url lookup (affects: 1) (heat: 6)" [Critical,Triaged] | 16:25 |
james_w | https://code.launchpad.net/~james-w/summit/fix-plus-in-meeting-name/+merge/76061 | 16:27 |
mhall119 | james_w: do you think we should go ahead and allow + in room and track as well? | 16:29 |
james_w | probably | 16:29 |
james_w | I can do a followup branch for that if you like | 16:29 |
james_w | assuming the models allow those chars | 16:30 |
james_w | mhall119, does your personal-ical change actually put private sessions in to the ical? | 16:34 |
james_w | I didn't see any code that would actually do that | 16:34 |
mhall119 | james_w: it puts only your private sessions in the ical | 16:37 |
james_w | ah | 16:37 |
james_w | I'll go back and read the branch again :-) | 16:37 |
mhall119 | that was why I had to add the show_private=True into the schedule constructor | 16:39 |
james_w | yeah | 16:39 |
james_w | I just didn't see anywhere passing that | 16:39 |
mhall119 | it was.... | 16:40 |
mhall119 | james_w: line 254 of views.py | 16:41 |
james_w | thanks | 16:41 |
james_w | yeah, don't know how I missed that, sorry | 16:44 |
mhall119 | np | 16:45 |
=== Ronnie1 is now known as Ronnie | ||
mhall119 | james_w: will you let joey know that his top 3 bugs are now Fix Released | 16:54 |
james_w | yep | 16:54 |
james_w | just sent an email about it, and I'll poke him separately | 16:55 |
james_w | mhall119, also pushed another revision to support + elsewhere | 17:04 |
mhall119 | james_w: tarmac had already landed the previous revision, so you'll need a new MP for r186 | 17:07 |
james_w | ah, sorry, missed that you had reviewed | 17:07 |
james_w | thanks :-) | 17:07 |
james_w | https://code.launchpad.net/~james-w/summit/fix-plus-in-meeting-name/+merge/76071 | 17:08 |
james_w | going to rollout that fix straightaway as it is blocking Linaro | 17:09 |
mhall119 | james_w: can it wait 5 minutes? | 17:14 |
mhall119 | or can we do another rollout in 5 minutes? | 17:14 |
mhall119 | I have an emergency fix | 17:15 |
james_w | we can | 17:15 |
james_w | we can do a rollout after every revision now if we want :-) | 17:15 |
james_w | I've done mine already | 17:15 |
james_w | happy to do yours as soon as it lands | 17:15 |
mhall119 | james_w: https://code.launchpad.net/~mhall119/summit/api-hide-secret-key/+merge/76073 | 17:16 |
mhall119 | if you can review, merge and deploy that, I'd appreciate it | 17:16 |
james_w | oops | 17:16 |
james_w | I'm assuming it works, because it certainly looks right | 17:17 |
mhall119 | I tested it manually on my local box | 17:18 |
james_w | mhall119, tarmac doesn't seem to be merging it? | 17:30 |
james_w | I'll do it by hand | 17:31 |
james_w | ah, it's done now | 17:33 |
mhall119 | tarmac runs ever 30 minutes, IIRC | 17:34 |
james_w | ah, ok | 17:34 |
james_w | deployed | 17:35 |
nigelb | Gimme a few days to create a URL to poke to start that. | 17:35 |
nigelb | I just haven't gotten around t it. | 17:35 |
mhall119 | thanks james_w | 17:36 |
james_w | mhall119, we are the only two who have a secret key so far :-) | 17:37 |
james_w | should I delete them? | 17:37 |
mhall119 | that'd be the right thing to do, yeah | 17:39 |
mhall119 | it'll re-create them once we view the page again | 17:39 |
mhall119 | different of course | 17:39 |
james_w | done | 17:40 |
mhall119 | thanks | 17:43 |
=== pace_t_zulu_ is now known as pace_t_zulu | ||
james_w | Ran 100 tests in 1.088s | 21:40 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!