| achiang | hello anyone about? i'd like to figure out the best way to solve this situation. parent folder A contains N subfolders, B, C, D, ... | 04:20 |
|---|---|---|
| achiang | C and D are individually marked to be synced | 04:21 |
| achiang | i would simply like to sync A now, to get all the subfolders | 04:21 |
| achiang | but i can't, at least not via the nautilus interface | 04:21 |
| * achiang tries "stop synchronizing this folder" on the subfolders and then syncing the parent | 04:24 | |
| jo-erlend | hmm. I thought desktopcouch in Oneiric had been fixed? | 07:37 |
| jo-erlend | I still get couchdb.http.Unauthorized: ('unauthorized', 'Authentication required.') when I try to connect to it. | 07:37 |
| jo-erlend | ... or is it just me? I upgraded from Oneiric, and then it stopped working. | 07:51 |
| jo-erlend | from Natty, to Oneiric, I mean. | 07:51 |
| mandel | morning all! | 08:37 |
| JamesTait | Morning all! | 08:51 |
| karni | Hi everyone :) | 09:05 |
| gatox | hi everyone | 09:26 |
| === teknico_ is now known as teknico | ||
| karni | hi gatox \o | 10:12 |
| gatox | karni, hi!! this friday i'm receiving a phone with meego (i told you about a while ago), so i'll be doing (if i can :P) a port of ubuntu one mobile to that phone :D | 10:13 |
| karni | gatox: wo-hooo \o/ sweet! | 10:15 |
| gatox | karni, so i'll be asking you some stuff if i have doubts :P | 10:15 |
| karni | gatox: of course! :) | 10:16 |
| karni | My pleasure to help. | 10:16 |
| Chipaca | gatox: when you think it and you can take it, let us know and we'll tweet about it so you get some extra hands on it :) | 10:22 |
| Chipaca | gatox: (from the Ubuntu One account, which has a bunch of followers) | 10:23 |
| gatox | Chipaca, awesome! thanks!! It also is going to appear in Qt pages, so more publicity there :D | 10:24 |
| Chipaca | :) | 10:25 |
| Chipaca | HLQP, etc :) | 10:25 |
| ralsina | morning! | 10:26 |
| gatox | ralsina, morning! | 10:27 |
| karni | hiya ralsina ! | 10:34 |
| ralsina | hi karni, gatox | 10:37 |
| mandel | gatox, that is assuming I bring the phone with me buahahahahahaha | 11:01 |
| gatox | mandel, jejejejee pleaseeeeeeeeeeeee :P | 11:02 |
| mandel | :p | 11:03 |
| mandel | ralsina, ping | 11:04 |
| gatox | ralsina, can i have a quick review? :P https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/verification-code/+merge/75755 | 11:06 |
| ralsina | mandel: pong | 11:07 |
| ralsina | gatox: sure | 11:07 |
| gatox | ralsina, thanks | 11:07 |
| mandel | ralsina, I have a logistics question, shall I ask for conference days for the days I'm travelling to pyconar? aslo, has alecu mentioned the sprint of sugar labs? | 11:09 |
| ralsina | mandel: conference days for travel, I don't know but I expect yes | 11:11 |
| ralsina | And yes, I know about the sugar labs sprint. Why? | 11:11 |
| ralsina | gotta take the kid to school, I'll be back in 1 hour or so | 11:13 |
| mandel | ralsina, 'cause I was going to take part :P | 11:13 |
| mandel | ralsina, ok, latars! | 11:13 |
| mandel | s/latars/laters | 11:13 |
| ralsina | mandel: ok, you take part. So? ;-) | 11:13 |
| ralsina | ok, really leaving now. See you guys in a bit | 11:14 |
| mandel | ralsina, I dont know, I though I had to let you know hehehe | 11:14 |
| mandel | gatox, can you do me a favour? | 11:29 |
| gatox | mandel, shoot | 11:29 |
| mandel | mandel, can you run the tests on windows for ubuntuone-windows-installer and tell me if you get any failures? | 11:30 |
| mandel | fuck, QEventReactor does not have defer to thread? what the fuck! | 11:31 |
| gatox | mandel, just the last u1 installer in trunk or any branch in particular? | 11:31 |
| mandel | that was no a ? it is a statement, stupid irc client :( | 11:31 |
| mandel | gatox, trunk please :) | 11:31 |
| gatox | mandel, ok...... on iit | 11:32 |
| gatox | mandel, everything is ok here | 11:33 |
| mandel | gatox, ok? I'll see what I screwed up | 11:34 |
| gatox | mandel, do you know where is located this ui?? https://launchpadlibrarian.net/79356411/Screenshot-Create%20Ubuntu%20One%20account.png (it is from gtk) | 11:34 |
| gatox | i can't find it | 11:34 |
| gatox | mandel, i'm trying to look for the strings but it's not working | 11:35 |
| mandel | gatox, let me take a look | 11:37 |
| mandel | gatox, in sso, right? | 11:37 |
| gatox | mandel, i think... | 11:37 |
| mandel | gatox, I'm pulling trunk, but I think I know where it is :) | 11:38 |
| mandel | gatox, ubuntu_sso/utils/ui.py | 11:39 |
| mandel | grep "I agree" ubuntu_sso/ -Rn | 11:39 |
| mandel | hehe | 11:39 |
| mandel | gatox, the app_name is a parameter, that is why you probably did not find it :) | 11:40 |
| gatox | mandel, thanks! | 11:41 |
| mandel | gatox, no worries :) | 11:43 |
| * mandel walking dog | 11:55 | |
| edinny | can I get help with ubuntu one here? | 12:05 |
| edinny | When I try to create a new address book on my new natty machine, ubuntu one is not an option | 12:06 |
| FxIII | hi all | 12:11 |
| FxIII | i'm using python and oauth2 to upload files to the cloud but i have a problem when i create a file | 12:12 |
| FxIII | i got "file upload conflicted with another transaction" | 12:15 |
| beuno | FxIII, hi! that's interesting, we've seen some of those spuriously | 12:33 |
| beuno | FxIII, those this happen consistently? | 12:33 |
| FxIII | I think so | 12:34 |
| beuno | FxIII, are you uploading files in parallel or serially? | 12:35 |
| FxIII | beuno: im on interactive interpreter but for now it will do it over and over | 12:35 |
| FxIII | beuno: one at time | 12:35 |
| FxIII | https://files.one.ubuntu.com/content/~/Ubuntu%20One/test.txt | 12:36 |
| FxIII | i get /content/~/Ubuntu%20One by calling the api | 12:37 |
| FxIII | https://one.ubuntu.com/api/file_storage/v1/~/Ubuntu One | 12:37 |
| FxIII | https://one.ubuntu.com/api/file_storage/v1/~/Ubuntu%20One | 12:37 |
| ralsina | mandel, alecu, gatox: after friday's mailing we are up to over 400 windows users connected | 12:38 |
| gatox | ralsina, wow! awesome! | 12:38 |
| beuno | FxIII, on a call, let me hand you over to vds | 12:38 |
| ralsina | gatox: do you have 30 minutes free today so I can walk you through building an installer? | 12:39 |
| * ralsina wants the project to be bus-proof | 12:39 | |
| gatox | ralsina, jejej yes! also.... i would like to ask you something about the network detection | 12:39 |
| ralsina | gatox: cool | 12:39 |
| gatox | ralsina, and have another really quick review if you have the time cof cof jeje | 12:39 |
| ralsina | gatox: in a few minutes, I haven't done the other one yet | 12:40 |
| gatox | ralsina, ok! | 12:40 |
| FxIII | beuno: vds? | 12:40 |
| * mandel back | 12:42 | |
| mandel | ralsina, how is the release being done? mean, we are sending emails etc... | 12:42 |
| mandel | ralsina, I've been ask by several people about the new client :) | 12:43 |
| ralsina | mandel: joshua has a list of people who used the old beta, and we are mailing them in batches, we are up to 10K now | 12:43 |
| ralsina | mandel: you can't give them the URL but I'd say "google for it" is not a bad advice, and it does work ;-) | 12:43 |
| beuno | FxIII, yes, but he may be at lunch | 12:44 |
| ralsina | gatox: don't remove the blank line in line 88 of the diff. It's PEP-compliant. | 12:44 |
| * gatox looking.... | 12:45 | |
| gatox | ralsina, really?? most of the classes don't have that line | 12:46 |
| FxIII | ah ok beuno i didn't understand | 12:46 |
| FxIII | beuno: if it can be usefull i saw the file are actually stored | 12:46 |
| ralsina | gatox: because they are not PEP-compliant | 12:46 |
| gatox | ralsina, ok, changing it back | 12:47 |
| mandel | ralsina, ah, nice :) | 12:47 |
| ralsina | mandel: quick mumble re: pyconar? | 12:48 |
| mandel | ralsina, so, the 400 uses, how many people are out of the number of email we have sent? | 12:48 |
| mandel | ralsina, ok | 12:48 |
| ralsina | mandel: about 4% | 12:48 |
| mandel | ralsina, out of the sent emails or out of all users... | 12:48 |
| ralsina | mandel: about 4% of the mails sent | 12:48 |
| ralsina | mandel: OTOH, that was sent on friday so I expect it to raise fr a day or two more | 12:49 |
| mandel | ralsina, ok | 12:49 |
| ralsina | OTOOH I ust noticed this is the public channel. OOPS. | 12:49 |
| mandel | me | 12:59 |
| ralsina | me | 12:59 |
| ralsina | alecu, gatox, dobey, standup | 13:00 |
| gatox | me | 13:00 |
| === mandel is now known as standup | ||
| standup | me | 13:01 |
| === standup is now known as mandel | ||
| mandel | hehehe | 13:01 |
| gatox | jeje | 13:01 |
| ralsina | ok, mandel, go | 13:01 |
| mandel | DONE: Improve tests and code for auto-updater. | 13:01 |
| mandel | TODO: Commit those ^ changes and ask for reviews. Create migration script from old beta to new | 13:01 |
| mandel | BLOCKED: no | 13:01 |
| mandel | COMMENTS QEventReactor those not implement deferToThread that is an utter crap | 13:01 |
| * ralsina sends dobey and alecu to the corner | 13:01 | |
| mandel | s/those/does | 13:01 |
| mandel | ups | 13:01 |
| ralsina | DONE: release, packaging, last-minute fixes, bug triaging, IRL testing. TODO: bug triaging, bugfixing, cleanup packaging for merge, reviews. BLOCKED: no | 13:02 |
| ralsina | gatox? | 13:02 |
| gatox | DONE: | 13:02 |
| gatox | Bug #834152, and some fixes in friday branches. | 13:02 |
| gatox | TODO: | 13:02 |
| gatox | More UI bugs. | 13:02 |
| gatox | BLOCKED: | 13:02 |
| gatox | No | 13:02 |
| ubot4 | Launchpad bug 834152 in ubuntu-sso-client "The agreement checkbox shouldn't be checked by default (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/834152 | 13:02 |
| alecu | hello! | 13:02 |
| gatox | alecu, standup! :P | 13:02 |
| ralsina | mandel: but but but we already are using deferToThread with qt4reactor in sso? | 13:02 |
| ralsina | mandel: or is it something else? | 13:02 |
| === teknico_ is now known as teknico | ||
| ralsina | gatox: the agreement box is *not* checked by default! Or is it? | 13:03 |
| gatox | ralsina, not checked | 13:03 |
| alecu | we surely are using deferToThread with qt4reactor | 13:03 |
| ralsina | gatox: can I throw bug #853794 to you as high? | 13:03 |
| ubot4 | Launchpad bug 853794 in ubuntuone-client "Password recovery on Windows client gives error (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/853794 | 13:03 |
| mandel | ralsina, deferToThread, I think we are not? I got that error when trying to run u1trial with eactor=qt4 | 13:03 |
| mandel | reactor* sorry | 13:03 |
| ralsina | gatox: at least triage it, i it's a server error, kick it to web+mobile | 13:03 |
| gatox | ralsina, ok! | 13:03 |
| mandel | ralsina, I'll take a look again, maybe I'm wrong (very possible) | 13:04 |
| ralsina | mandel: let me check. We are using an equivalent at leasr :-) | 13:04 |
| mandel | ralsina, 'cause if it is then we do reactor.deferToThread(subprocess.call, args) | 13:04 |
| mandel | ralsina, that would make everything a lot nicer :D | 13:04 |
| alecu | DONE: worked on unicode fixes on sso and sd | 13:04 |
| alecu | TODO: finish that, and work on unicode fixes in control panel | 13:04 |
| alecu | BLOCKED: no | 13:04 |
| ralsina | mandel: check ubuntu_sso/main/windows.py | 13:05 |
| dobey | λ DONE: bug #838778 | 13:05 |
| dobey | λ TODO: more bugs, freeze exceptions | 13:05 |
| dobey | λ BLCK: None. | 13:05 |
| ubot4 | Launchpad bug 838778 in ubuntuone-control-panel (Ubuntu Oneiric) (and 2 other projects) "After installing Ubuntu One, there are 2 Ubuntu One launchers in System Settings (affects: 51) (dups: 13) (heat: 228)" [High,Triaged] https://launchpad.net/bugs/838778 | 13:05 |
| mandel | ralsina, the worst thing is that I wrote that, hay que joderse! | 13:05 |
| alecu | ubuntu_sso/main/windows.py:from twisted.internet.threads import deferToThread | 13:05 |
| alecu | ubuntu_sso/keyring/windows.py:from twisted.internet.threads import deferToThread | 13:06 |
| alecu | but | 13:06 |
| ralsina | mandel: you should take your morning pills | 13:06 |
| alecu | ubuntu_sso/networkstate/windows.py:from threading import Thread | 13:06 |
| alecu | so, we are using both twisted threads and standard python threads | 13:06 |
| ralsina | alecu: ubuntu_sso is open minded and willing to try everything | 13:06 |
| alecu | ralsina, yeah, sometime it looks like it was coded in the 60's | 13:06 |
| mandel | alecu, I thin using the twisted thread is nicer, right? I think network was writen without knowing that we could use twisted threads | 13:07 |
| mandel | ralsina, hehe I should :P | 13:07 |
| alecu | mandel, yup, but I wouldn't worry too much about that | 13:07 |
| alecu | mandel, unless we are having some issue with it. | 13:08 |
| alecu | are we? | 13:08 |
| mandel | alecu, no, we are not | 13:08 |
| alecu | great | 13:08 |
| mandel | ok, I'm off to lunch and will finish that autoupdate no blocking code :) | 13:08 |
| alecu | mandel, "autoupdate non-blocking code"? | 13:10 |
| * alecu looks for the backlog | 13:10 | |
| dobey | hmm | 13:10 |
| mandel | alecu, the auto-update.exe is the one that performs the check and since we use subprocess.call it blocks, which is crap, so I want to block in a thread and the get the retcode from a deferred | 13:11 |
| alecu | mandel, let's not use threads for that. There's something similar to subprocess in twisted, too. | 13:11 |
| alecu | mandel, let me find it | 13:11 |
| alecu | http://twistedmatrix.com/documents/current/core/howto/process.html | 13:12 |
| mandel | alecu, that I knowm but doing a process protocol just to check if the process returns 0 is a little to much, right? | 13:12 |
| nbf | is ubuntu one ever going to provide an app store like feature | 13:12 |
| gatox | REALLY small review: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/834152/+merge/76026 | 13:13 |
| nbf | what I'd like to see is the ability to "save" certain apps to a list on ubuntu one | 13:13 |
| ralsina | gatox: in verification-code branch, are there tests for the code in lines 48-50? | 13:13 |
| nbf | so you could install ubuntu, log into your ubuntu one account and automatically install your favorite apps with one click | 13:14 |
| mandel | nbf, I think onecon was for that, but I'm not sure | 13:14 |
| nbf | onecon? | 13:14 |
| ralsina | oneconf | 13:14 |
| ralsina | but it's not for that | 13:14 |
| alecu | http://www.omgubuntu.co.uk/2010/06/oneconf-wants-to-reinstall-your-applications-settings-on-a-fresh-ubuntu-install/ | 13:15 |
| nbf | actually it does look similar | 13:15 |
| nbf | awesome thanks guys :) | 13:15 |
| ralsina | that's just for settings, won't install the apps themselves. Or maybe it will, haven't used it myself :-) | 13:15 |
| nbf | "Designed to save a list of installed programs, their settings, configurations and preferences; OneConf aims to synchronize this information with Ubuntu One - Canonical’s cloud storage service." | 13:16 |
| gatox | ralsina, i think not.... | 13:16 |
| nbf | sounds like what I'm asking for | 13:16 |
| alecu | nbf, I saw a lot of work was happening during the Oneiric on OneConf, so you should check it out | 13:16 |
| ralsina | nbf: cool then :-) | 13:16 |
| nbf | oenierc is out in a few weeks isnt it | 13:16 |
| mandel | ralsina, done with the registration, or so I believe, I've used my @canoincal.com email for it | 13:16 |
| === m_conley_away is now known as m_conley | ||
| ralsina | mandel: cool | 13:16 |
| gatox | ralsina, i'll add test for that and fix the pep8 thing | 13:17 |
| gatox | ralsina, now i have to leave for a while....... brb! | 13:17 |
| === gatox is now known as gatox_brb | ||
| alecu | mandel, from what I read, I would implement an empty class that inherits from ProcessProtocol, and that only redefines .processEnded(status): | 13:17 |
| ralsina | how about using subprocess correctly and not doing anything with threads? ;-) | 13:18 |
| mandel | alecu, I'll give it a try to see if it works with the Qt reactor, should be very easy | 13:18 |
| alecu | mandel, sorry: twisted.internet.utils.getProcessValue | 13:18 |
| alecu | mandel, http://twistedmatrix.com/documents/current/core/howto/process.html#auto6 | 13:18 |
| alecu | mandel, "If you only need the final exit code (like commands.getstatusoutput(cmd)[0]), the twisted.internet.utils.getProcessValue function is useful" | 13:19 |
| ralsina | also: if we start u1cp first, this is ust useless | 13:19 |
| ralsina | s/ust/just/ | 13:19 |
| mandel | alecu, superb! | 13:19 |
| mandel | ralsina, and also true :) | 13:19 |
| * ralsina reminds people that while nice code is fun, moving lines around is cheap | 13:19 | |
| mandel | ralsina, alecu I'll go for lunch and will make the code nicer, it should be very easy | 13:19 |
| alecu | ralsina, like "paehc si dnuora senil gnivom" ? | 13:21 |
| ralsina | alecu: lines, not columns | 13:21 |
| alecu | doh | 13:21 |
| ralsina | columns are expensive! | 13:21 |
| ralsina | all the marble, the carved leafs | 13:21 |
| ralsina | alecu: have 5' for a quick mumble? | 13:43 |
| alecu | ralsina, sure. give me a minute | 13:44 |
| ralsina | alecu: cool. Talk loudly when you get there :-) | 13:44 |
| * mandel back | 13:44 | |
| FxIII | i saw that there is the need to have at least the DISPLAY environment variable to use ubuntuone at commandline | 13:51 |
| FxIII | this is a problem if one does not have access to X or does it using SSH | 13:51 |
| ralsina | FxIII: ubuntuone also uses dbus so it's not trivial to get it running over ssh | 13:53 |
| FxIII | ralsina: in ssh an export DISPLAY=:0 works | 13:54 |
| ralsina | FxIII: if you have a session on :0 sure :-) | 13:54 |
| dobey | the cli tools do not need DISPLAY | 13:54 |
| dobey | they need dbus | 13:55 |
| FxIII | the problem arise when there is no session :D | 13:55 |
| FxIII | so ubuntuone cant be used without X? | 13:58 |
| ralsina | FxIII: it should be possible to create a dbus session without X, it's just very very annoying. | 13:58 |
| FxIII | i see | 13:59 |
| dobey | FxIII: it cannot be used without dbus | 13:59 |
| FxIII | the X requirement is quite strong | 13:59 |
| dobey | not really | 14:00 |
| ralsina | You can use Xvfb | 14:00 |
| FxIII | I'm on a arm w/o display at all :D | 14:01 |
| === gatox_brb is now known as gatox | ||
| ralsina | gatox: can you do some IRL testing of bug #851094 please? | 14:24 |
| ubot4 | Launchpad bug 851094 in ubuntu-sso-client (and 1 other project) "When reset password request fails, poor error message is shown (affects: 1) (heat: 6)" [Critical,Triaged] https://launchpad.net/bugs/851094 | 14:24 |
| ralsina | gatox: I have a user reporting it as bug #853794 and he claims he pasted the code correctly and still failed | 14:25 |
| ubot4 | ralsina: Error: Bug #853794 not found. | 14:25 |
| gatox | ralsina, ok, on it | 14:26 |
| ralsina | gatox: are you fixing bugs in gtk now? :-D | 14:26 |
| gatox | ralsina, about building the installer.... can it be before 3pm?? i have to study later | 14:26 |
| ralsina | https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/834152/+merge/76008 | 14:26 |
| gatox | ralsina, just one :P | 14:26 |
| ralsina | gatox: it can be now if you want | 14:26 |
| gatox | ralsina, let me do the IRL testing... and i'll let you now after that, ok? | 14:27 |
| ralsina | gatox: get yourself bitrock installbuilder professional trial installed in the meantime, then ping me | 14:27 |
| ralsina | gatox: +1 on the checkbox branch | 14:29 |
| gatox | ralsina, ok :P | 14:30 |
| gatox | ralsina, the irl testing...... should i do it with the installer.... or can i do it with the code in trunk? | 14:39 |
| ralsina | gatox: trunk should be enough | 14:40 |
| gatox | ralsina, ok | 14:40 |
| ralsina | mandel: can you take a quick pass through these old bugs when you have a minute? https://bugs.launchpad.net/ubuntuone-windows-installer/+bugs?field.assignee=&field.bug_reporter=&field.has_no_package=&field.has_patch=&field.omit_dupes=on&field.searchtext=&field.status%3Alist=CONFIRMED&field.status%3Alist=FIXCOMMITTED&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field. | 14:42 |
| ralsina | status%3Alist=INPROGRESS&field.status%3Alist=NEW&field.status%3Alist=TRIAGED&orderby=-datecreated&search=Search&memo=150&start=150 | 14:42 |
| gatox | ralsina, bug reproduced :S | 14:47 |
| ralsina | gatox: with correct code and everything? Please tell pindonga on #ids | 14:48 |
| gatox | ralsina, yep...... | 14:48 |
| ralsina | and move the bug to "triaged" if it is not | 14:48 |
| ralsina | and add a note about it in the bug | 14:48 |
| mandel | ralsina, of course, give me a few mins and I'll look into that | 14:49 |
| ralsina | mandel: thanks | 14:49 |
| ralsina | mandel: no rush, just some housecleaning when you have a bit of time to relax :-) | 14:49 |
| mandel | ralsina, what do you want me to do, double check that are fixed? | 14:49 |
| ralsina | mandel: if they are for the old beta just say something like "please expect a new release in your email soon" | 14:50 |
| ralsina | mandel: if they are for the new one, we should look into them :-) | 14:50 |
| mandel | ralsina, ok | 14:51 |
| mandel | we should start doing this: http://en.wikipedia.org/wiki/Uberman%27s_sleep_schedule#Uberman.27s_sleep_schedule | 14:58 |
| mandel | it would solve all the schedule problems we have, we just need to agree on when to sleep :P | 14:58 |
| mandel | ralsina, ping | 15:03 |
| ralsina | mandel: pong | 15:03 |
| mandel | ralsina, when running the tests of ubuntuone-windows-installer it gets stuck 'til timeout in test_total_size_udf, do you experience this? | 15:04 |
| ralsina | mandel: didn't last time I checked | 15:04 |
| ralsina | mandel: let me re-check | 15:05 |
| mandel | stupid vm... | 15:05 |
| ralsina | mandel: probably a timing issue on the tests. That code is tricky | 15:05 |
| edinny | is this for developers or users? | 15:06 |
| ralsina | edinny: developers and users. If you need help with anything... we will help you | 15:06 |
| ralsina | mandel: confirmed it's not timing out for me | 15:07 |
| edinny | I have 2 contact related issues | 15:07 |
| mandel | ralsina, dammed, can I push a branch for you to test? | 15:07 |
| edinny | first, I started using ubuntuone without opening an account by name | 15:07 |
| mandel | ralsina, I think it is due to the share_folders from vmware | 15:08 |
| edinny | later I openened and account and added that computer. | 15:08 |
| ralsina | You are running it in one of those? Yes, that doesn't work. | 15:08 |
| edinny | I seem to have lost my addressbook | 15:08 |
| ralsina | mandel: you have to set TMPDIR or something like that | 15:08 |
| edinny | did it replace my old account with the new one? | 15:09 |
| mandel | ralsina, yes, that I have done, you have to set the test_trial in the cmd vars? it happens just with that method in both my branch and trunk, so is the vm, its fucked | 15:09 |
| ralsina | edinny: could be. You can only be logged into one account at a time | 15:10 |
| ralsina | edinny: you could try logging in with the old account to see if things come back | 15:10 |
| edinny | there was no loging with the old site. | 15:11 |
| ralsina | edinny: I am not sure I understand that | 15:11 |
| edinny | if I use ubuntuone and don't sign up for an account, does it get stored on U1? | 15:11 |
| ralsina | edinny: no | 15:12 |
| ralsina | edinny: if you are not signed in, you are not using ubuntu one at all | 15:12 |
| edinny | my other problem is my new natty install. Evo does not have an option for a new addressbook on U1 | 15:13 |
| ralsina | edinny: yes, we have that bug reported and a fix was committed very recently | 15:14 |
| edinny | just "on this computer", ldap, and webdav and google | 15:14 |
| ralsina | edinny: no, wait, I am confused with oneiric | 15:14 |
| edinny | yes? | 15:14 |
| ralsina | edinny: if you don't have it in natty, you are probably missing a package, let me check the name | 15:15 |
| edinny | file>new>addressbook | 15:15 |
| ralsina | dobey: do you remember the name of the package to provide evolution <-> u1 integration? | 15:15 |
| dobey | evolution-couchdb | 15:15 |
| edinny | installing now | 15:16 |
| dobey | ralsina: it's not installed by default since natty, as we pulled the couchdb stack off CD to save space | 15:17 |
| ralsina | dobey: right | 15:17 |
| edinny | do I have to specify the remote couchdb server? | 15:17 |
| edinny | or just give it a name | 15:18 |
| dobey | edinny: if you restart evolution, it should create the Ubuntu One address book automatially | 15:18 |
| dobey | rodrigo_: ^ right? | 15:19 |
| edinny | did not do it | 15:19 |
| edinny | I shut evo, did apt-get, started evo | 15:19 |
| dobey | hrmm | 15:20 |
| dobey | edinny: quit evo, run evolution --force-shutdown from a terminal, then start evolution, perhaps | 15:20 |
| edinny | got it. thanks | 15:21 |
| edinny | Next I have to figure out how to move an old adressbook.db over | 15:21 |
| dobey | you mean inside couchdb? | 15:22 |
| mandel | ralsina, gatox, alecu can I get a review for https://code.launchpad.net/~mandel/ubuntuone-windows-installer/auto-update-python-only/+merge/76047 It just adds the python code so that we later add the xml once ralsina branch has been landed to trunk | 15:22 |
| gatox | mandel, on it | 15:22 |
| ralsina | mandel: will check! | 15:22 |
| mandel | super! thx! | 15:23 |
| mandel | ralsina, shall I make a branch from your that contains just the xml? that way there won't be merge issues | 15:23 |
| ralsina | mandel: yes | 15:24 |
| ralsina | mandel: then I can merge that one with mine, cleanup, and merge to trunk | 15:24 |
| mandel | ralsina, that is the plan :) | 15:24 |
| mandel | ralsina, will do that, then some bug and next the update script, which I shall add in a similar way to the auto-update in the installer | 15:25 |
| ralsina | mandel, alecu: either of you actually understands how oauth+lazr works on sso? | 15:26 |
| mandel | ralsina, I might add some ugly ui for that script | 15:26 |
| ralsina | mandel: cool. You could also add a command to the setup.py t build it | 15:26 |
| rodrigo_ | dobey, yes, right | 15:26 |
| alecu | mandel, I'm reviewing your branch. Q: why the "+def start_control_panel(with_icon=False): | 15:26 |
| alecu | "? | 15:26 |
| ralsina | alecu: That's mine! I need to file a bug and fix it! | 15:27 |
| ralsina | OTOH, the fix is there ;-) | 15:27 |
| mandel | alecu, is that in the diff? I did not do that :P | 15:27 |
| mandel | ein? | 15:27 |
| alecu | mandel, that's what LP shows on the last line of the diff! | 15:27 |
| alecu | https://code.launchpad.net/~mandel/ubuntuone-windows-installer/auto-update-python-only/+merge/76047 | 15:27 |
| ralsina | mandel: you got that because you branched from mine, and I did it there | 15:27 |
| mandel | ralsina, alecu ok, le me fix that, sorry | 15:28 |
| ralsina | I wonder why you didn't get the rest of it, though | 15:28 |
| dobey | rodrigo_: it seems like if e-addressbook-backend is already running when it got installed, it doesn't just work though. :( | 15:28 |
| dobey | anyway, i need to get me some lunch | 15:28 |
| dobey | bbiab | 15:28 |
| rodrigo_ | dobey, the creation of the U1 addressbook is done on an evo plugin, so it's evo that needs to be restarted, not e-a-f | 15:29 |
| mandel | ralsina, 'cause I try to be smart with a diff so I did not base the code in your brache and failid :( | 15:30 |
| ralsina | mandel: ja! | 15:30 |
| dobey | rodrigo_: but it only creates it if the address book is available in the backend right? | 15:30 |
| rodrigo_ | dobey, hmm, maybe | 15:31 |
| ralsina | ARGH, oauth library supports changing timestamps but lazr hides it!!!!! | 15:31 |
| dobey | rodrigo_: in which case the backend also needs to be restarted :-/ | 15:31 |
| * ralsina SMASH | 15:31 | |
| dobey | anyway lunch :) | 15:31 |
| FxIII | bye | 15:35 |
| mandel | ralsina, alecu fixed :) | 15:40 |
| * ralsina is about to find who wrote lazr and send him a strongly worded email | 15:48 | |
| mandel | ralsina, hahaha, add me in the signature of the email ;) | 15:50 |
| ralsina | I just can't find where the frak it's calling the oauth method that adds the timestamp | 15:51 |
| ralsina | it's like it's written using a damn obfuscator. It doesn't do a single import the straight way, everything is in namespaced packages and imported via __import__ | 15:52 |
| ralsina | oauth = __import__('oauth.oauth', {}).oauth mis polainas! | 15:53 |
| mandel | hahahahaha | 15:53 |
| mandel | sorry, but I have to laught :P | 15:53 |
| ralsina | I mean what the heck does that even DO | 15:53 |
| ralsina | Haha! I *think* I found it by grepping for from_consumer_and_token | 15:55 |
| mandel | ralsina, I just did this for you: https://code.launchpad.net/~mandel/ubuntuone-windows-installer/add-updater-xml/+merge/76053 | 15:55 |
| ralsina | mandel: cool, thx | 15:55 |
| * mandel is the first time that he proposes a merge to a branch that is not trunk | 15:55 | |
| ralsina | mandel: did you actually see the diff? ;-) | 15:55 |
| mandel | nop, let me see | 15:56 |
| mandel | ralsina, hahaha, mamon!!! | 15:57 |
| mandel | ralsina, why did you tell me to do it then ;-) | 15:57 |
| ralsina | mandel: reject it, then :-) | 15:57 |
| mandel | I agree hehe | 15:57 |
| ralsina | mandel: I thought you had other stuff in it | 15:57 |
| mandel | ralsina, nah, I'll do that later after bugs and the upgrade script witch is more urgent, right? | 15:58 |
| ralsina | yes | 15:59 |
| gatox | ralsina, do you want to build the installer now?? or you are about to eat? | 16:01 |
| ralsina | gatox: let's do it | 16:01 |
| ralsina | gatox: mumble? | 16:01 |
| ralsina | gatox: please branch lp:~ralsina/ubuntuone-windows-installer/fix_809873 | 16:02 |
| mandel | ok, EOD for me, catch you tom! | 16:02 |
| ralsina | bye mandel! | 16:02 |
| mandel | have a good afternoon/evening! | 16:02 |
| gatox | ralsina, branching | 16:02 |
| gatox | mandel, we have a problem! :P | 16:10 |
| gatox | mandel, ohh...... eod....... sorry | 16:12 |
| mandel | ralsina, ping | 16:14 |
| mandel | gatox, dime! | 16:14 |
| ralsina | mandel: pong | 16:14 |
| mandel | gatox, I'm 'merendand' I guess like is having tea in an eng version hehe | 16:14 |
| gatox | mandel, merendando :P...... your tests are failing: http://paste.ubuntu.com/693147/ | 16:15 |
| mandel | ralsina, this bug https://bugs.launchpad.net/ubuntuone-control-panel/+bug/845659 do they want me to implement this in control panel too? | 16:15 |
| ubot4 | Launchpad bug 845659 in ubuntuone-control-panel "Windows: implement the "there is a new version available" notifications (affects: 1) (heat: 6)" [High,Triaged] | 16:15 |
| ralsina | mandel: the original plan was to do it on u1cp | 16:15 |
| mandel | gatox, hum, que raro, looking | 16:15 |
| ralsina | mandel: since it seems to work well in -installer, I think you should just change the project | 16:15 |
| mandel | ralsina, I'll set it as a duplicate then | 16:16 |
| mandel | gatox, which revno do you have? | 16:17 |
| gatox | mandel, 70 | 16:17 |
| mandel | gatox, look at the diff, line 218 | 16:18 |
| gatox | mandel, yes? | 16:18 |
| gatox | 218+ def debug(self, message, *args, **kwargs): | 16:19 |
| mandel | gatox, and the owner is FakeLogger... | 16:19 |
| gatox | mandel, yes.... | 16:19 |
| mandel | gatox, can you try with Z:\Projects\ubuntuone-windows-installer\auto-update-python-only>python C:\Python | 16:20 |
| mandel | 27\Scripts\u1trial ubuntuone_installer\gui\qt\utils\tests\test_windows.py | 16:20 |
| mandel | gatox, no need to set the reactor in this case since there is no qt in that module | 16:20 |
| gatox | mandel, ahhhhhhhhh ok! | 16:20 |
| gatox | mandel, wait...... | 16:20 |
| gatox | mandel, but i'm running it with. run-tests.py | 16:21 |
| gatox | sorry | 16:21 |
| gatox | run-tests.bat | 16:21 |
| mandel | gatox, ah, I know the issue? let me try to fix it. Looks like a weird import somewhere | 16:22 |
| karni | Any DROID3 users here? | 16:24 |
| ralsina | Ok, so I found how to patch the timestamp. Alecu, can I show you something, and you tell me if it's a very bad idea? | 16:27 |
| dobey | ralsina: are you doing the hack to get the timestamp from the server? | 16:29 |
| ralsina | dobey: yeah | 16:30 |
| ralsina | I am wondering if I can block for a bit inside SSO or need to make it async | 16:30 |
| mandel | gatox, let me finish my food and I'll take a closer look, I'm getting issue with the defers now :( | 16:33 |
| gatox | mandel, obvio!! vaya! | 16:33 |
| gatox | ralsina, can you reproduce this bug? https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/828938 (i can't) | 16:46 |
| ubot4 | Launchpad bug 828938 in ubuntuone-windows-installer "Error on test_forgotten_password_controller_error (affects: 1) (heat: 6)" [Medium,Triaged] | 16:46 |
| * ralsina looks | 16:47 | |
| ralsina | gatox: used to, since I reported it ;-) | 16:47 |
| ralsina | gatox: anyway, that's not urgent, since it only affects tests | 16:47 |
| ralsina | gatox: and doesn't even make the tests fail... | 16:47 |
| gatox | ralsina, ok..... but i think that maybe is fixed already | 16:47 |
| gatox | ralsina, i'll return to network detection | 16:48 |
| ralsina | gatox: if you run the tests and is not there, mark as fix-committed | 16:48 |
| gatox | ralsina, ok | 16:48 |
| gatox | lunch....... brb in 20 min! | 16:52 |
| === gatox is now known as gatox_lunch | ||
| === beuno is now known as beuno-lunch | ||
| ralsina | alecu: ping | 16:56 |
| karni | Anyone with Samsung Galaxy SII ? | 16:57 |
| karni | I suspect it's storing pictures in a folder rooted somewhere else than /mnt/sdcard | 16:57 |
| nhaines | karni: some Android phones also use internal storage. My coworker's Droid Incredible is like that. | 17:02 |
| karni | nhaines: is it DROID3 by any chance? (I don't know all the phones to be honest;) ) | 17:03 |
| karni | nhaines: Yes, SII has internal 16GB | 17:03 |
| nhaines | nhaines: it is a Droid Incredible. :) | 17:04 |
| nhaines | karni: ^^ | 17:04 |
| nhaines | karni: I can find out what folder that one stores pictures in internally, if you like. | 17:04 |
| karni | nhaines: ah ok :) | 17:04 |
| karni | nhaines: That would be great, yes please :) | 17:04 |
| karni | nhaines: Eventually, we should simply let the users pick it. | 17:05 |
| nhaines | karni: okay. It might have to wait a couple hours until lunch. :) | 17:05 |
| karni | nhaines: Whoa, that's still pretty fast! | 17:05 |
| karni | nhaines: I'll be away soon, but please leave me a message, I've got IRC session up. | 17:06 |
| nhaines | karni: will do! | 17:06 |
| karni | nhaines: Thank you :) | 17:06 |
| alecu | ralsina, pong | 17:07 |
| ralsina | alecu: I have a fix for the timestamp problem | 17:07 |
| alecu | ralsina, nice! | 17:07 |
| ralsina | alecu: BUT I don't know if I am doing it right :-) | 17:07 |
| ralsina | alecu: basically, I am doing a blocking call in sso | 17:07 |
| ralsina | alecu: care to take a look at the code and tell me if that's ust bad? | 17:08 |
| alecu | ralsina, sure | 17:08 |
| === gatox_lunch is now known as gatox | ||
| ralsina | alecu: http://pastebin.ubuntu.com/693185/ | 17:08 |
| ralsina | alecu: the AutoStampAuthorizer class | 17:09 |
| ralsina | AutoTimestampAuthorizer | 17:09 |
| ralsina | authorizeRequest is basically the exact same thing as is in lazr, except I pass the oauth_timestamp parameter to the underlying oauth library. But the urllib stuff is blocking | 17:10 |
| alecu | ralsina, I like that solution. And since this is using lazr -which is blocking-, it is already being run in a thread. | 17:15 |
| alecu | ralsina, But I have a couple of questions: | 17:15 |
| ralsina | cool | 17:15 |
| ralsina | ask away :-) | 17:15 |
| alecu | * what about the file sync servers and api calls from the control panel? | 17:16 |
| ralsina | AFAIK, they all sign their request through here | 17:17 |
| ralsina | oh, wait, they don't. I may have to do something similar in ubuntu_sso.utils | 17:18 |
| alecu | * is this only used on is_validated and validate_email? if not, it can be really expensive to do this call each time. | 17:18 |
| ralsina | alecu: I thought about doing a time diff and using that, but then it will break completely if the user *fixes* the time | 17:19 |
| ralsina | I don't see it used elsewhere, though | 17:19 |
| alecu | ralsina, I like that approach. In any case we can cache the "time difference" for some given amount of time, and if the clock is adjusted we would discard the cached value. | 17:21 |
| ralsina | alecu: it gets much more complex that way... | 17:22 |
| alecu | ralsina, right. But the control panel is already slow when doing webservice calls, and if we add a "time" call per each webservice call it would be insanely slow. | 17:23 |
| ralsina | one compromise: we could, on start, use this to validate time.time() (check if there are less than, say, 300 seconds difference). If the difference is too high, we set a flag and use the slow version (and show a warning) | 17:23 |
| alecu | ralsina, sounds like an interesting hack | 17:24 |
| ralsina | and on every call to figure out time, we re-validate the diff, and set/reset the flag | 17:24 |
| ralsina | so, if the local time improves, we stop using the slow version | 17:24 |
| alecu | ralsina, also syncdaemon uses webservice calls to publish files and such... they are not so much time sensitive operations, but anyway | 17:24 |
| ralsina | argh | 17:25 |
| alecu | ralsina, I see that those operations (publish, create shares) are oauth signed in ubuntuone/syncdaemon/action_queue.py | 17:27 |
| alecu | ralsina, but I don't see them using the timestamp | 17:27 |
| ralsina | if they don't pass a timestamp it uses int(time.time()) | 17:28 |
| ralsina | maybe we should monkeypatch oauth.pauth | 17:29 |
| ralsina | oauth.oauth that is | 17:30 |
| ralsina | instead of chasing everywhere we use it | 17:30 |
| alecu | ralsina, they are using oauth.OAuthRequest.from_consumer_and_token | 17:30 |
| ralsina | alecu: yes, that's the one where everything happens :-) | 17:30 |
| ralsina | alecu: and the only place where you can specify the timestamp | 17:30 |
| ralsina | alecu: if we monkeypatch that we fix it for everyone | 17:31 |
| alecu | ralsina, hmmm... it seems oauth.oauth is also used *inside* the storage protocol code. | 17:34 |
| ralsina | alecu: so, I think we can go for the minimalistic solution. On startup, validate time and warn the user that machines with bad time don't work with u1 | 17:35 |
| alecu | ralsina, yeah, and suggest installing http://www.timesynctool.com/ | 17:35 |
| ralsina | alecu: on windows you don't need any tools | 17:35 |
| ralsina | windows 7 has an embedded NTP client | 17:36 |
| alecu | ralsina, well, the default ntp client on windows updates daily | 17:36 |
| ralsina | alecu: or when you click the button | 17:36 |
| alecu | ralsina, right | 17:36 |
| ralsina | if your computer moves more than 15 minutes daily, it's broken :-) | 17:36 |
| alecu | ralsina, well that small tool updates every 15 minutes, and that's what I have running inside vbox, because vbox is so broken! | 17:37 |
| alecu | ralsina, but is the win7 ntp client enabled by default? | 17:37 |
| ralsina | alecu: yes | 17:37 |
| alecu | ralsina, cool. in any case, we may recommend that tool when the user is on a previous version | 17:37 |
| ralsina | right | 17:39 |
| ralsina | I hate this solution though | 17:39 |
| alecu | ralsina, """The Windows Time Service in Windows 7 is also configured by default to not start automatically each time the system is started - the user interface reports that Windows is configured to automatically update the system time, but it doesn't unless the user manually starts the Windows Time Service either through the Services Control Panel applet, or by requesting a manual sync. Unless the user reconfigures the Windows Time Service | 17:39 |
| alecu | to start automatically, it will be effectively disabled every time the system is restarted""" | 17:39 |
| alecu | (from the homepage of that tool) | 17:40 |
| ralsina | hahahahahahaha | 17:40 |
| ralsina | snif snif snif | 17:40 |
| alecu | On the plus side, this timesynctool.exe is developed on sourceforge, and bsd licensed, so we may be able to include it in our installer. | 17:42 |
| ralsina | alecu: how about implementing a subclass of oauth.OAuthRequest that does that whole "validate time / use slow version if it's broken" in ubuntu-sso-client and changing the rest to use that? | 17:44 |
| ralsina | it only will be broken when the time is good at first and later diverges | 17:45 |
| ralsina | but that happens already | 17:45 |
| ralsina | and that fails silently already too | 17:45 |
| alecu | ralsina, afaict oauth.OAuthRequest is used by the storage protocol, and that's twisted code. | 17:46 |
| alecu | ubuntuone/storageprotocol/client.py -> oauth_authenticate() | 17:47 |
| ralsina | oh, crap. How many different ways do we sign rquests? | 17:47 |
| alecu | ralsina, so we should not make oauth_authenticate block on the urllib call | 17:47 |
| alecu | ralsina, that seems to be the only place the storage protocol signs a request, when starting the connection. | 17:48 |
| ralsina | so blocking there is bad? If it's only once... | 17:48 |
| alecu | and the other parts where it signs oauth request are the -dirty- bits where it makes webclient calls we found above: creating a share, publishing a file. | 17:52 |
| alecu | ralsina, it might not be *bad* to block there, but it certainly looks dirty | 17:52 |
| ralsina | since all those fail currently, I would consider fixing it in sso and when starting the connection an improvement | 17:53 |
| alecu | ralsina, perhaps we should ask for facundobatista's input on how this issue may be fixed for SD | 17:53 |
| ralsina | alecu: good idea | 17:54 |
| ralsina | facundobatista: ping | 17:54 |
| facundobatista | ralsina, pong | 17:54 |
| ralsina | facundobatista: I am trying to figure out what needs fixing to handle bad time in the client which makes SSO fail | 17:54 |
| ralsina | or rather oauth fail | 17:54 |
| facundobatista | ralsina, what? | 17:55 |
| ralsina | facundobatista: if the client's time is off by 15 minutes, oauth fails | 17:55 |
| alecu | facundobatista, the thing is that we are finding a lot of windows machines where the time is not set to the right gmt time, so the clocks are different from our servers | 17:55 |
| facundobatista | alecu, ralsina, ok | 17:55 |
| ralsina | facundobatista: so, there are 3 places in u1-client where oauth requests are signed, and would need to be fixed | 17:56 |
| alecu | facundobatista, right now it fails on sso, so the user is not even to create a new account nor sign in with an existing one | 17:56 |
| ralsina | alecu: you go on, you understand it better than I anyway :-() | 17:56 |
| ralsina | :-) | 17:56 |
| facundobatista | ... | 17:57 |
| alecu | facundobatista, the fix that ralsina has found involves doing an http HEAD request to the webserver, and getting the server timestamp, and using that instead of the client's timestamp when signing oauth | 17:57 |
| facundobatista | alecu, ok | 17:58 |
| alecu | facundobatista, we can do it as a blocking url call in the sso and probably in control panel | 17:58 |
| facundobatista | alecu, ok | 17:58 |
| alecu | facundobatista, we might even do it as a blocking call in the webcalls inside syncdaemon (create new share, publish file) | 17:58 |
| alecu | facundobatista, but should we do it as a blocking call before the protocol authenticates? | 17:59 |
| alecu | my guess is "no" | 17:59 |
| karni | alecu: to be precise, do one HEAD request and apply the server-client difference to all following request. | 17:59 |
| alecu | karni, ralsina had some concerns with that | 17:59 |
| karni | ralsina: ↑ ? | 18:00 |
| karni | alecu: you want a HEAD before every request? | 18:00 |
| alecu | karni, ralsina says " it will break completely if the user *fixes* the time" | 18:00 |
| facundobatista | alecu, I don't have a clue about authentication, but why not every time? | 18:00 |
| alecu | facundobatista, from a performance point, I don't like "every time" either. | 18:01 |
| alecu | facundobatista, my question was one of blocking or async web call | 18:01 |
| facundobatista | alecu, but if you don't do it, it will fail, right? | 18:02 |
| karni | alecu: that's why we do HEAD just during every app launch | 18:02 |
| ralsina | karni: difference is, our app runs all the time | 18:02 |
| === beuno-lunch is now known as beuno | ||
| alecu | karni, that sounds bad :-) | 18:02 |
| alecu | karni, "doing head", I mean :-) | 18:03 |
| karni | alecu: hahahh | 18:03 |
| gatox | ok... eod for me... i'll be back when i get bored from studying! bye | 18:03 |
| karni | ralsina: I beleive (and I have no metrics) that it is minority of users who do not turn their computers off | 18:03 |
| alecu | gatox, have fun! | 18:04 |
| ralsina | karni: agreed, but it may be 12 or 16 hours between starts | 18:04 |
| dobey | people turn computers off? | 18:04 |
| alecu | karni, what about suspend? | 18:04 |
| dobey | what is this, the 90s? | 18:04 |
| karni | ralsina: Also, there's another solution. If you receive HTTP UNAUTHORIZED or such* (to be defined), only *then* you get server time, apply the difference, and try again. | 18:04 |
| karni | ralsina: that won't give you 15+minutes of lag | 18:04 |
| alecu | karni, that sounds like the most reasonable solution. It also sounds like a complicated fix right now. | 18:05 |
| ralsina | +1 on complicated, because I need to find every place where a request is done, and add an if | 18:05 |
| karni | alecu: how about doing head (again.. ;D) every few hours then? | 18:05 |
| alecu | karni, that's my proposal: caching the time difference for an hour or so. | 18:06 |
| karni | ralsina: Can't you override an OAuth library method that generates the timestmap? (somewhere "higher" than fixing all the places that sign?) | 18:06 |
| karni | or, actually, lower | 18:06 |
| ralsina | karni: yes, we can | 18:06 |
| karni | alecu++ | 18:06 |
| ralsina | karni: it's somewhat filthy though :-) | 18:07 |
| karni | All your Anroids are belong to filthy karni! | 18:07 |
| karni | androids as well ;d | 18:07 |
| ralsina | also, on Linux we can't patch system libraries. It would have to be a monkeypatch | 18:08 |
| karni | alecu: FYI if someone uses files REST API, they have to use the same fix. | 18:08 |
| ralsina | or inherit that class, and replace it everywhere we use it | 18:08 |
| facundobatista | ralsina, you won't be put blocking code unless you do it in a separate thread, right? | 18:10 |
| ralsina | facundobatista: the idea is not to add any blocking code except on some "initialization" somewhere | 18:10 |
| facundobatista | ralsina, you won't be put blocking code unless you do it in a separate thread, right? | 18:10 |
| ralsina | facundobatista: the idea is not to add any blocking code except on some "initialization" somewhere | 18:10 |
| ralsina | once more and it's a tie in chess :-) | 18:11 |
| facundobatista | ralsina, so, don't do it | 18:11 |
| facundobatista | ralsina, don't add blocking code in the main thread, doesn't matter the stage | 18:11 |
| dobey | ralsina: tie? i think you lost :) | 18:11 |
| ralsina | facundobatista: don't write code that doesn't work for a % of users | 18:12 |
| ralsina | ;-) | 18:12 |
| ralsina | giving orders is fun! ;-) | 18:12 |
| ralsina | Yes, I don't intend to make things block. I also intend to make it work. | 18:13 |
| alecu | facundobatista, ralsina: so, if we do it such as "oauth.OAuthRequest.from_consumer_and_token" will sometimes block, we should fix ubuntuone/storageprotocol/client.py->oauth_authenticate() so it calls "oauth.OAuthRequest.from_consumer_and_token" in a thread | 18:14 |
| ralsina | alecu: if we do it by keeping an offset, it doesn't block | 18:14 |
| alecu | ralsina, that is only if the offset is calculated on startup. If we "cache" the offset, that function *may* block at some point. | 18:15 |
| ralsina | alecu: no, it will fail, not block | 18:15 |
| ralsina | then, we trigger a recalculation of the offset in a thread | 18:15 |
| alecu | ralsina, then it's a more complicated change, because we would be changing the signature of from_consumer_and_token | 18:16 |
| ralsina | alecu: hmmm | 18:17 |
| alecu | ralsina, by adding a new possible exception to that function, that we would have to catch everywhere | 18:17 |
| ralsina | from_consumer_and_token never sees the failures, it just creates headers | 18:18 |
| ralsina | the failure would have to be caught when the request is actually sent | 18:18 |
| alecu | ralsina, probably most places are already handling those errors. I know SD retries on auth failures. But some other places may drop the credentials from the keyring or such | 18:20 |
| alecu | ralsina, because the error is the same | 18:20 |
| ralsina | this is all, of course, much more complicated than expected. | 18:21 |
| alecu | ralsina, My proposal is to make a class that derives from OAuthRequest, where .from_consumer_and_token() or .sign_request() may block, and to make storageprotocol use it inside a thread. | 18:22 |
| alecu | facundobatista, ^ | 18:23 |
| alecu | ralsina, that way all the other places where oauth signatures are done won't need to be changed. | 18:23 |
| ralsina | alecu: it's doable | 18:23 |
| * ralsina is scared to even think of sideeffects | 18:23 | |
| alecu | I'll check the webclient in control panel. | 18:24 |
| facundobatista | alecu, why not issuing the thread inside .from_consumer_and_token ? | 18:24 |
| facundobatista | alecu, other question: are you doing this extra call always? or when you detect (somehow) that the machine's hour is wrong? | 18:25 |
| alecu | facundobatista, because .from_consumer_and_token is not async, so it does not return a deferred | 18:25 |
| facundobatista | alecu, ok | 18:25 |
| alecu | facundobatista, only when it's wrong on startup | 18:25 |
| facundobatista | alecu, ok | 18:26 |
| alecu | ralsina, also we should at some point publish this OAuthRequest derived class on the u1 developers api, because as karni pointed out it will be very useful for devs using our webservices. | 18:27 |
| ralsina | alecu: agreed | 18:27 |
| dobey | alecu: we should fix python-oauth | 18:28 |
| ralsina | dobey: python-oauth is doin the right thing | 18:31 |
| ralsina | dobey: it even lets you pass it a timestamp if you don't want to use the system's | 18:32 |
| dobey | it's not doing the right thing on the server | 18:32 |
| ralsina | dobey: it's within the spec | 18:33 |
| dobey | ralsina: the timeout isn't, is it? | 18:34 |
| ralsina | dobey: yes it is | 18:34 |
| ralsina | dobey: how the server processes the nonces is not spec'ed. Or at least it's not spec'd so much that this is out of spec :-/ | 18:34 |
| dobey | where? | 18:34 |
| dobey | the nonce is not particularly relevant to the issue at hand | 18:36 |
| ralsina | dobey: yes it is. The time window is so that there is no need to keep track of all nonces ever received. | 18:37 |
| ralsina | So, if the timestamp is too old, it just assumes it's a replay attack on an old nonce | 18:37 |
| dobey | that is a matter of convenience, rather than part of the spec though. it is not specified for the server to behave that way | 18:38 |
| ralsina | it's not specified that they shouldn't | 18:38 |
| dobey | no, but python-oauth really shouldn't be implementing any unspecified behavior | 18:39 |
| ralsina | anyway. Alecu: I agree that is the better solution. I will try to start implementing it tomorrow morning, but it's a much better idea if you do it instead :-/ | 18:40 |
| achiang | hello, i uploaded some *.m4a to U1Music yesterday. they appear in the web gui under "files" but not on the android music app | 18:40 |
| achiang | i have refreshed the android music app several times | 18:40 |
| alecu | ralsina, sure. I'll be bugging you with OAuth questions, though :-) | 18:41 |
| ralsina | alecu: happy to help within my limited knowledge of it :-) | 18:41 |
| dobey | achiang: non-DRM files from iTunes? | 18:41 |
| dobey | achiang: or are they DRMed? :) | 18:41 |
| achiang | dobey: yes, aiui, *.m4p are DRM, and *.m4a are non-DRM | 18:42 |
| achiang | <- willing to be corrected, though | 18:42 |
| dobey | achiang: ok; beuno ^^ achiang is having some issues with m4a files too it seems :) | 18:42 |
| achiang | dobey: beuno: let me download a file from the web and make sure banshee can play it | 18:43 |
| achiang | dobey: beuno: verified that banshee can play it | 18:45 |
| beuno | achiang, thanks, this is already on my plate | 18:45 |
| achiang | beuno: sweet, thanks | 18:46 |
| achiang | if only i could sync from an external drive, all my U1 warts would be cured. ;) | 18:46 |
| achiang | as it is, it rocks more and more every day | 18:46 |
| nigelb | duanedesign: Hey, around? | 18:57 |
| ralsina | I have to do my evening school run | 19:06 |
| ralsina | will work a bit more late tonight. Mail me if you need me | 19:07 |
| mandel | if anyone needs me, Im around :P | 20:34 |
| dobey | that's what she said | 20:39 |
| mandel | hehehe | 20:54 |
| === m_conley is now known as m_conley_away | ||
| dobey | later all | 21:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
