[00:52] lifeless, re that query for bugs affecting users [00:52] i'll try it without the subquery [00:52] that sql is being generated by higher level code that asks for a query affects_me=True [00:53] would it be risky, or beneficial, to change the way that's implemented in general? [00:53] so that it always does a join [00:53] or is it likely to be sensitive to the larger query of which it's a part? [01:04] sadly its risky [01:04] however I tried a join and it wasn't substantially better [01:05] backlog in -ops has pastebin / explain for hloeung [01:05] not saying 'do not join', more 'join may not be enough / may be a distraction' [01:21] lifeless: https://code.launchpad.net/~mwhudson/launchpad/introduce-IParticipationWithAnnotations-bug-623199 btw [01:22] (running it through ec2 test now) [01:26] cool [01:59] wallyworld_: I don't have a show desktop in the launcher [02:00] thumper: hmmmm. mine has been there for a while. perhaps it got removed and i still have an old launcher entry which points to nothing [02:01] if it has been removed, how does one show the desktop now? [02:01] wallyworld_: it is in alt-tab [02:02] thumper: so it is. too many keypresses though :-( [02:02] what is the purpose of showing the desktop? [02:02] so i can access icons and shortcuts i have there [02:02] wallyworld_: try super-D [02:03] hitting super brings up the launcher [02:03] and then 'd' has no effect [02:03] wallyworld_: hold down super and press "D" [02:03] works for me [02:03] yehah i tried that too [02:04] wallyworld_: I think your computer just hates you [02:04] i knows i like kde [02:04] it [02:05] generally i don't mind unity except for that key workflows are too inconvenient [02:05] unity --reset? [02:05] * wallyworld_ tries that [02:06] still hates me [02:09] jelmer: https://code.launchpad.net/~guadalinex-members/firstboot/gecos is a bit special. === jtv-afk is now known as jtv [02:20] Can haz review? https://code.launchpad.net/~stevenk/launchpad/fix-search-oops/+merge/77429 [02:44] lifeless: Can we close bug 702188? Since we haven't had read-only mode for a few months now ... [02:44] <_mup_> Bug #702188: librarian 500s during read-only mode < https://launchpad.net/bugs/702188 > [02:49] lifeless, huwshimi, so as a compromise for 'bugs affecting me' perhaps i'll just leave off the count [02:50] it looks a bit odd [02:50] https://bugs.launchpad.net/launchpad/+bug/858618/+attachment/2477988/+files/20110929_001.jpeg [02:50] <_mup_> Bug #858618: hard to find bugs that affect you in a project < https://launchpad.net/bugs/858618 > [02:50] but i think it's still a step forward [02:50] what an awful jpeg [02:50] but you get the idea [02:52] poolie: Is the query too slow or something? [02:52] poolie: I agree it looks a little odd, but I'm not sure we can do anything about it [03:13] We definitely need a psycopg upgrade for what I'm doing. :( [03:25] huwshimi, yes, it is a bit slow [03:25] and robert's reasonably concerned that just adding more to this page will make it worse [03:25] perhaps we can eventually make them fetched asynchronously [03:26] obviously there would still be some db load from it [03:26] huwshimi, so what i'm really wondering is, do you think it's a step forward over all? [03:31] poolie: I would have thought having links to those pages would be super useful (is there currently any other way to view them without doing an advanced search?). I'm not sure I understand how it could make thinks worse. [03:31] i also think it would be super useful, and there is no way other than an advanced search [03:32] and as a consequence the url is risible [03:32] so i think the worse is only in it being a little ugly and people perhaps complaining it's broken [03:32] which we can fix separately [03:32] either through a smarter query or caching or whatever [03:32] perhaps a triggered update of a cache table [03:33] thanks [03:34] poolie: Now that I'm thinking about it again, one think that might be worth considering is putting those links into their own portlet (maybe with a "My bugs" title... or something more appropriate) to make a bit more of a feature out of the fact those links now exist. [03:35] all the per-person links? [03:36] poolie: Yeah, although really this is a different issue... [03:38] indeed [03:38] in fact turning them into toggle filter buttons would be great, i think [03:38] huwshimi: I like your search mockup; have you considered having the search terms visible in the result (like search facets) [03:38] so you can get to 'high', 'open and closed', 'affects me' [03:38] but this is much bigger, i just wanted a bit of a stop gap [03:38] huwshimi: you may have and decided its out of scope, but if you haven't thought about it, I can point you at a number of bugs related to folk doing iterative refinement of searches [03:39] which this could help with [03:39] huwshimi, oh could i see your mockup? [03:40] poolie: What I really would like to do at some point is have a "these are link to the things in this context that apply to me" portlet that is consistent across as much of Launchpad as we can, which would include those links on the bug pages [03:41] yeah [03:41] lifeless: Oh, do you mean the mockups for the bug columns work? [03:41] huwshimi: yes [03:43] lifeless: I think deryck has decided that doing anything to the search is out of scope for the short turn around they have for this feature, except maybe the summary of terms (which I think was in the mockup) [03:46] poolie: Emailed [03:48] huwshimi: no worries [03:48] ah i see what you mean about 'no columns' [03:48] huwshimi: it will be an improvement nevertheless [03:49] * StevenK prods lifeless a little harder. [03:51] [12:44] < StevenK> lifeless: Can we close bug 702188? Since we haven't had read-only mode for a few months now ... [03:51] <_mup_> Bug #702188: librarian 500s during read-only mode < https://launchpad.net/bugs/702188 > [03:53] lifeless: Yeah, I'd really like to see that advanced search stuff turned into filters etc. I did in fact do some basic mockups for that, but at this stage it's out of scope. Hopefully that might turn into a second stage of this work another time. [03:56] StevenK: sure [03:59] * StevenK dithers between Fix Released and Invalid [04:00] Won't Fix [04:01] wgrant: Thanks. Done. [04:03] lifeless: I'm also having trouble making a tarball of Twisted 11.0.0 plus a cherry pick I applied to it, I would love a bit of help if you're able. [04:03] StevenK: what happens? [04:04] lifeless: TBH, I thought I just had to tar up the new bits -- but it still identifies itself as 11.0.0, so buildout loves me not. [04:04] I have no idea how to make a twisted release [04:04] it used to be a Dark Art [04:05] You told me how to do a storm release with setup.py flags, I was wondering if they could be used ... [04:05] possibly [04:06] know, can I remember them... your shell history might be abetter bet ;) [04:06] I tried that yesterday, no dice. [04:07] egg_info might be the key [04:07] egg_info -b-blahsomesuffix sdist? [04:09] * StevenK is concerned the tarball is 700KiB smaller ... [04:10] And is .gz for further hilarity [04:11] No docs. Handy. [04:14] In fact, there is no egg info in the old tarball. [04:15] twisted devs are even less keen on eggs than I [04:18] benji: heh, its probably conflicting with my commit to db-devel. I'll get a new branch ready soonish [04:18] nigelb: cool; just let me know and I'll land it when you're ready [04:31] Using ./setup.py egg_info and tarring up that results in buildout still insisting it's 11.0.0 [04:48] wgrant: It seems you fixed bug 55099 along with your BugTask target work. Do you want to close it? [04:48] <_mup_> Bug #55099: IBugTaskSet.createTask should take a target argument

< https://launchpad.net/bugs/55099 > [04:50] StevenK: Indeed, nice find. [05:06] I need to remove a key from the prod configs before I can rip it out of schema-lazr, right? [05:10] Yes. [05:26] * wgrant hunts for a reviewer for https://code.launchpad.net/~wgrant/launchpad/no-key-oopses/+merge/77447 [05:26] wgrant: I've been looking for a reviewer for 3 hours [05:28] StevenK: Yours is certainly *a* fix, but I don't think it's the right Zopey one. [05:29] Awww [05:50] I've got some time to review right now. [05:51] Ahhh--treating upload errors as user errors. Been wishing for that. === almaisan-away is now known as al-maisan [06:36] wgrant: review done [06:37] MPJs have been going *really* slowly :-/ [06:38] wgrant: hmm, indeed [06:39] jtv: Ah, I keep forgetting we're on 2.6 now. [06:39] Thanks. [06:39] jelmer: There are a couple of others like it. [06:39] wgrant: 2.6? We should move to 2.7 :-P [06:40] You'd think. [07:34] Do I need a bug report to attach to a branch that removes code? I assume it'd be qa-untestable, so doesn't need a bug for QA workflow, right? [07:34] cjwatson, i believe you do not need one [07:36] Thanks. Not ready to submit it yet, waiting for an RT to be resolved so that I can deploy the replacement [07:37] cjwatson: depends on the code being removed. [07:38] cjwatson: e.g. we can verify that some action *doesn't* happen, so there is no intrinsic untestability of removal per se - but some removals may be untestable (as some additions and modifications are untestable) [07:38] Can someone help me QA bug 88545 :) [07:38] <_mup_> Bug #88545: Abolish the "statusexplanation" database field

< https://launchpad.net/bugs/88545 > [07:41] lifeless: it's removing one of the ftpmaster scripts [07:42] so not so much some action doesn't happen, as (about to be) dead code [07:42] cjwatson: for that I would just nuke from orbit with no bug. [07:42] cjwatson: unless you want something to point at an celebrate. [07:42] lol [07:42] hah. ok [07:43] cjwatson: (I'm very keen to remove all archive admin access to the db, you might be able to tell :P) [07:43] I've noticed [07:44] still some way to go, but archive-cruft-check is a fairly easy one to migrate now that I have a full dists/ mirror on lillypilly [07:45] and maybe if I help a bit with it people won't lecture me as much ;-) [07:45] cjwatson: I'm actually fine with stuff still running on coco, just removing the db access and the potential for massive locks and errors there is the key thing :) [07:45] cjwatson: I'm glad you're putting some time into it! [07:47] we fixed all our locally-written out-of-tree db access quite a while back; everything we run that touches the db is in the LP tree now. TBH it mostly amounts to queue, change-override, and lp-remove-package [07:47] nowadays [07:47] though I wouldn't swear to there being nothing else [07:47] oh, and sync-source for the cases that the API method doesn't cover yet [07:48] yeah, but until we nuke *everything* we can't disable the account [07:48] right [07:48] we have quite a few reports to migrate to lillypilly [07:49] but I think that's all unblocked now [07:55] cjwatson: Ah, excellent, always good to remove code. [08:53] could i get a review on https://code.launchpad.net/~mbp/launchpad/323000-affecting-user/+merge/77469 please? [09:03] poolie: Is that a new filter? === rvba changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: rvba* (allenap) | Critical bugs: 261 - 0:[########*** stack smashing detected ***: ./lp terminated [09:05] poolie: Sure. [09:09] nigelb, it's a link to see the bugs that affect you [09:10] poolie: Neat! [09:10] <3 it [09:11] I'm guessing now, people will more aggresively use the affects me [09:11] https://bugs.launchpad.net/launchpad/+bug/323000/+attachment/2478784/+files/20110929_002.png [09:11] <_mup_> Bug #323000: Make "this bug affects me too" bugs visible from user profile < https://launchpad.net/bugs/323000 > [09:12] I saw [09:48] wgrant: https://launchpad.net/~lynxman/+archive/ppa [09:48] rvba, so what did you think of https://code.launchpad.net/~mbp/launchpad/323000-affecting-user/+merge/77469 ? [09:49] poolie: done with the review in just one sec. [09:49] thanks! [09:50] poolie: I know it's just a drive by fix but I confess I *love* the removal of all the "List" in front of every single link ;). [09:51] yeah i do too [09:51] :) [09:51] > LIST AFFECTING BUGS [09:51] it's not cobol [09:52] thanks for the reivew [09:52] rvba i saw robert just closing some tech debt bugs with the comment that someone will fix them when (and only when) they see the code and care about changing it [09:52] and the bug is noise [09:53] and i'm inclined to agree [09:53] poolie: heh, its not COBOL [09:53] poolie: Okay, I understand. [09:53] i believe in cleaning things up, i just doubt the bug will make it happen [09:54] bigjools: We clearly have some differing opinions. I may track him down later. [09:54] wgrant: yes, that's why I pointed it out [09:55] bigjools: Well, this is all based on my packaging from yesterday. [09:55] poolie: True. Especially since the bugs are piling-up quickly I guess. [09:55] But he's done odd stuff like installing the .ez again. [09:55] Instead of linking the package in. [09:55] I wonder if there's a reason for that. [09:55] poolie: but like you said, the duplication in this particular file is really *bad* ;) [09:56] Hmmmmm interesting. [09:56] rvba the main thing that puts me off cleaning it up is that i can see it's using some amount of zope magic but i don't understand it well enough to know if it's tasteful or not [09:56] rabbitmq-management is based on mine, but rabbitmq-management-agent is based on rabbitmq-stomp. [09:56] hm, the duplication perhaps suggests nobody else is comfortable with it either :) [09:56] hehe [09:57] i think actually possibly the whole url structure and ui needs to be reconsidered [09:58] so that these are not just ~6 totally different pages (even with less code duplication) but a generic bug list with some filters [09:58] i guess we could make the bugs./~ page just link to generic bug searches [09:58] That sounds like a good idea. [09:58] hm [09:58] bigjools: I fixed the FatalUploadError OOPSes, btw. [09:58] but there is no generic bug search? [09:58] \o/ [09:59] oh, there is [09:59] like to https://bugs.launchpad.net/bugs/+bugs?field.searchtext=&orderby=-importance&search=Search&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=FIXCOMMITTED&assignee_option=any&field.assignee=&field.bug_reporter=mbp&field.bug_supervisor=&field.bug_commenter=&field [09:59] .subscriber=&field.tag=&field.tags_combinator=ANY&field.status_upstream-empty-marker=1&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on [09:59] like to https://bugs.launchpad.net/bugs/+bugs?field.reporter=mbp [10:00] but, it's a bit harder to navigate from there - you lose the context of coming to it from ~mbp [10:00] Good point ... [10:02] mrevell, speaking (vaguely) of responsive design, have you visited askubuntu.com from a mobile browser? [10:03] it is a thing of beauty [10:04] poolie, I havent; I'll have a look, thanks. [10:19] thanks allenap [10:19] poolie: wow. Its awesome on a mobile. [10:19] yeah [10:20] it even has little unfoldy overlay bits, which [10:20] obviously are possible on webkit [10:20] but, i rarely see sites that both use ajax *and* are mobile specifci [10:20] The firefox input website also has a cool looking mobile UI.' [10:20] mrevell, just one quick thing while i'm tweaking, i'd like to change the 'get the code' in the footer to point to dev.l.n not to the branch contents [10:21] (which are not actually all that useful without instructions) [10:21] we've got past "omg there's actual code" and now we can look for at least some people to really change it [10:24] heh [10:24] So, point it to https://dev.launchpad.net/Getting [10:25] Aside from /Getting being the scariest wiki page I have seen this month, I think that's a great idea. [10:25] that's why i was going to go to the top level [10:25] it's a bit less scary [10:25] including having a "noooo i just want cds" [10:25] poolie, Sounds like a grand plan :) [10:26] Is /Getting that scary? :) [10:26] well, not really ,but it does have "i need help with lp" [10:26] and the top level has an easy "Get the source code" link [10:26] nigelb, I didn't read a single word on that page and I was scared. [10:26] It's a lot of text. [10:26] :) [10:26] haha [10:26] It needs a Usability and Communications Specialist to fix it. [10:27] Barring that, a Product Manager. [10:27] Which needs a product manager to hire one ;) [10:27] :) [10:27] heh [10:27] nigelb, getting there... [10:27] a Brave U&C Specialist [10:27] Brave/Fearless all that [10:27] which makes me think of the Holy Grail [10:28] We should register launchpad.xxx and it should show the list of all XXX comments in the code. [10:28] Just to show the sense of humour we have ::P [10:28] :) [10:28] "Getting the Launchpad source code is fairly simple," and here are 1092 words to tell just how simple. [10:29] Its only one step. [10:29] Get rf and run it. [10:30] Yeah, assuming you want rf to take over your machine. I'm not deliberately sniping at that page; I can, though, see some ways in which it can be better. [10:30] well [10:30] it's getting better [10:30] but it is not trivial [10:30] https://code.launchpad.net/~mbp/launchpad/get-the-code/+merge/77496 [10:30] I did let rf take over my machine. BUt maybe we should have a page with the different ways including that thing wgrant uses [10:30] (containers?) [10:31] i think they're under /Running [10:31] i have used schroots in the past [10:31] I use a VM [10:31] at the moment i'm running it outside because it's slightly easier [10:31] but it's good to know they're there [10:32] Yeah, I think new U&C person and I will need a mini-sprint where we get together for a couple of days to garden the dev wiki. [10:32] I found it less blocking when launchpad was just running on my machine [10:32] that way I wanted to touch the code more often :) [10:33] i wonder, while i'm there, if i should link to the blog too [10:33] it's one of the more interesting bits [10:33] compared to, say, the Terms of Use ;-) [10:34] heh [10:34] Yeah, shouldn't make the footer too wide, right? [10:34] But, then... [10:34] we have "Take the tour" and "Read the guide" just above [10:35] maybe the blog link should go beside those. [10:35] i'd like to unify them too [10:35] it's a little weird with the shaded bar and then the unshaded bar [10:35] and one is left aligned and the other centered [10:35] well, maybe we can [10:39] nigelb: I use LXC (see /Running/LXC). On Oneiric it works really well. [10:40] And it only takes a couple of seconds to start. [10:40] I have a few scripts in ~/bin [10:41] So to start the VM I just run lp-start on the host. lp-sh will SSH in and preserve the working dir, or you can give it a command and it will run that. lp-bounce restarts the appserver quickly. It all works pretty smoothly, and didn't take long to get used to. [10:41] wgrant: Needs Oneiric right? [10:42] I'm not quite ready to part with Lucid :) [10:42] Works OK on Natty, but not Lucid. [10:43] I wonder how important it is to make Launchpad work well on mobile browsers. My gut feeling is that we should do it; I need to get some research to back me up :) [10:44] rvba: O hai, I have two reviews for you -- https://code.launchpad.net/~stevenk/launchpad/kill-+viewstatus/+merge/77460 and https://code.launchpad.net/~stevenk/launchpad/drop-mdzcsv/+merge/77464 [10:44] mrevell: Checkout other codehosting websites as well [10:44] maybe we need a mobile bzr client :P [10:45] * nigelb runs [10:45] Hi StevenK, okay, I'll have a look. [10:55] mrevell, personally i think it's pretty far down the line [10:55] so i mention that more just because i was impressed than that i thought we should do it [10:56] Yeah, it is impressive. We get requests every now and then; Stuart Langridge last night, for example. [10:56] oh for a mobile site? [10:57] i think if we had internal notifications/timelines they would be a good thing to make work well mobile [10:57] so people could check up on things in idle moments [10:59] I'd argue for an app, not a mobile site per se. IMBW. [11:05] http://lpqateam.canonical.com/ does not need OpenID? [11:09] lifeless: ^ [11:16] lifeless, which is kind of to say: apis useful enough someone could make an app [11:17] few roundtrips, maybe notification/activity apis [11:18] If we took the responsive web design approach (basically, you make sure your site renders well on different form factors, mobile, PC, whatever), then it'd be more sustainable, I think, than an app. It would be good to see the API in such a state that it could support a widely used mobile app, though. [11:29] StevenK: r=me&allenap. Nice cleanups ;) [12:23] rvba, allenap: Many thanks for the reviews. :-) [12:24] np === al-maisan is now known as almaisan-away [13:03] Morning, all. === jcsackett changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: rvba* (allenap), jcsackett | Critical bugs: 261 - 0:[########*** stack smashing detected ***: ./lp terminated [13:31] Morning jcsackett! [13:31] morning, rvba. :-) [13:32] abentley, coming for standup. sorry to be running later. [13:32] deryck: s'okay. [14:00] Thanks for the review jcsackett :) [14:01] you're welcome, allenap. :-) === matsubara is now known as matsubara-lunch [14:10] jcsackett: Got time for another one? https://code.launchpad.net/~allenap/txlongpoll/queue-prefix-optional/+merge/77535 [14:10] allenap: sure thing. [14:23] allenap: r=me. [14:27] jcsackett: Thanks :) === bac`` is now known as bac === matsubara-lunch is now known as matsubara [15:06] gary_poster: do you know if we have a convention for versioning eggs where I've backported a revision from upstream's trunk? setup won't let me use a "+" in the version string :( [15:06] bigjools, revision and "-r12345" can't be forced upon the situation somehow? [15:06] that's what I am using [15:07] looks *wrong* as I am used to Debian versions :) [15:07] bigjools :-) I say go with it [15:07] gary_poster: I guess I will, thanks :) [15:07] welcome :-) [15:16] gary_poster: any ideas what's going on here? http://pastebin.ubuntu.com/699159/ [15:17] bigjools, what's that ">" doing in there? :-) if this is versions.cfg, just specify a version [15:17] gary_poster: it's not, it's from setup.py for txlongpoll [15:17] it finds the distro but there's an error, I don;t know what that error means [15:18] I guess it's a problem in the Twisted dist [15:19] yeah,the file is in the original but not in the sdist that setup makes :( [15:21] bigjools, on call will be with you soon [15:25] hello, I wonder if anyone would be interested in landing a launchpadlib mp for me? [15:26] [15:28] allenap perhaps? [15:29] * nigelb waves to mgz :) === rvba changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: jcsackett | Critical bugs: 261 - 0:[########*** stack smashing detected ***: ./lp terminated [15:29] Congrats on the new job! [15:29] ...I did wonde what that syntax was in the on call review field... [15:29] thanks nigelb! [15:30] mgz: Sure, let me take a look. [15:30] mgz: That meant rvba is a trainee reviewer being mentored by allenap :) [15:35] bigjools, I don't know what the story is there. .py files are generally included by default AFAIK. You can mess with MANIFEST.in to try and get it, I guess [15:35] gary_poster: I think it's something to do with how the egg is built [15:36] well, the distribution I mean [15:36] right, the sdist [15:36] gary_poster: it's missing a few setup.py files in the tree. They are there in the tarball in the LP download cache [15:36] so I must be building it wrong [15:36] bigjools, the only thing I would know to look at on the basis of that traceback is MANIFEST.in... [15:37] there's no MANIFEST.in, just a MANIFEST [15:37] hmmm I wonder if I grabbed the wrong source [15:38] bigjools, in your original package you would create a MANIFEST.in. MANIFEST is generated, using MANIFEST.in if it exists and otherwise doing whatever it thinks it ought to do. But, yeah, something like "grabbing the wrong source" would make more sense to me because *.py stuff is always included by default AFAIK, so that really doesn't make a lot of sense to me. [15:39] indeed [15:39] well, there's no MANIFEST* in the download tarball [15:39] so I guess it's generated "doing whatever it thinks it ought to do" [15:40] jml: I reckon you've built custom Twisted distros for LP, do you know the runes to do it right? [15:40] yes, bigjools [15:41] bigjools: IIRC, it's pretty straightforward [15:41] * jml thinks [15:41] jml: I'd just running setup.py sdist, but it's not generating the right MANIFEST by the looks of it, it's missing some setup.py files in the tree [15:41] Hmm. [15:41] s/I'd/I'm/ [15:42] I don't recall that. [15:42] (Maybe I just made a tarball?) [15:42] Hmm. [15:43] Oh, right. [15:43] ./bin/admin/build-tarballs . /tmp/twisted-release/ [15:43] (pilfered from http://twistedmatrix.com/trac/wiki/ReleaseProcess) [15:43] Maybe I did that. [15:44] jcsackett, do you have time to review https://code.launchpad.net/~sinzui/launchpad/ask-question-from-bug/+merge/77562 [15:44] sinzui: sure. [15:44] bigjools: ^ [15:44] jml: thanks - I don't have a bin/admin :( [15:44] bigjools: now that's just weird. It's a checkout of the tree? [15:45] jml: yes [15:45] well, new tarball download [15:45] * jml svn ups [15:45] oh, that might not get included in the release tarballs [15:45] ah [15:45] right. it doesn't. [15:46] (incidentally, can I help get these patches upstream?) [15:46] jml: they are already upstream, just not released [15:46] * deryck lunches offline for daycare pickup [15:46] it's the fix for 638, adds a --logger option [15:46] bigjools: ahh, cool. [15:46] nasty change if you ask me :( [15:47] so I backported the patch anyway, and it all works fine locally. Now I need to package it! [15:47] maybe I should just svn co it [15:48] Twisted's pretty darn stable, I'd recommend just svn co to the latest revno. [15:48] oh, really? [15:48] well, by "recommend", I mean 'consider as an option' [15:48] :) [15:49] mgz: Landed :) [15:49] sinzui: r=me, looks good. [15:49] thank you [15:49] allenap: thanks! [15:50] it's unlikely to break compatibility, the NEWS files will flag any changes that do, and there isn't much QA that happens before turning trunk into a release -- it's all done at commit time. [15:50] but, alternatively, co releases/twisted-11.0 or whatever and apply the patch manually. [15:51] jml: I was taking the conservative option but you fill me with ebullient confidence [15:52]