| === yofel_ is now known as yofel | ||
| rye | mornings | 07:53 |
|---|---|---|
| JamesTait | Morning all! | 08:49 |
| === gatox is now known as gatox_brb_bank | ||
| nessita | hello everyone! | 11:42 |
| mandel | morning all | 12:09 |
| nessita | hi mandel | 12:09 |
| nessita | gatox_brb_bank: you need reviews? | 12:09 |
| ralsina | good morning! | 12:29 |
| mandel | nessita, ralsina morning! | 12:34 |
| ralsina | hello mandel | 12:34 |
| nessita | hi mandel | 12:34 |
| nessita | mandel: is your branch ready for re-review? | 12:35 |
| ralsina | mandel: sorry I couldn't make it to be with you and alecu these days ;-( | 12:35 |
| mandel | nessita, yes, I did the push yesterday, unless you already took a look | 12:36 |
| mandel | nessita, have you? | 12:36 |
| mandel | ralsina, don't worry too much :) | 12:36 |
| nessita | mandel: not yet, looking now! | 12:37 |
| mandel | nessita, cool :) | 12:37 |
| * mandel wonders why his machines is sooooo slow | 12:42 | |
| ralsina | oh, freaking great, my doctor can only see me in 2 hours or not until after I travel | 12:43 |
| mandel | ralsina, are you bleeding? 'cause if you are not, you can travel :P | 12:44 |
| mandel | at least that is my rule of thum | 12:44 |
| ralsina | mandel: I am going to be two weeks in other contintents in the next month. I want to be kinda sure I will not, like, have a heart attack or anything? So I do checkups every 6 months | 12:45 |
| mandel | ralsina, oh, is that necesary? I'm not done a chckup in several years and I'm fine (or so I think) | 12:46 |
| ralsina | mandel: I have a couple of chronical illnesses, so I have to | 12:46 |
| mandel | ralsina, oh! did not know, then go go go | 12:47 |
| nessita | mandel: conflicts: | 12:48 |
| nessita | Text conflict in ubuntuone_installer/gui/qt/main/tests/test_windows.py | 12:48 |
| nessita | Text conflict in ubuntuone_installer/gui/qt/tests/test_gui.py | 12:48 |
| nessita | Text conflict in ubuntuone_installer/gui/qt/utils/__init__.py | 12:48 |
| nessita | 3 conflicts encountered. | 12:48 |
| ralsina | mandel: nothing serious, it will take decades to kill me. Unless I stop getting checked ;-) | 12:48 |
| ralsina | mandel, nessita, gatox_brb_bank: you may want to take a look at http://one.ubuntu.com ;-) | 12:52 |
| === gatox_brb_bank is now known as gatox | ||
| gatox | back | 12:53 |
| ralsina | gatox: ^ | 12:53 |
| mandel | nessita, ag, so there was a merge in trunk, I'll fixing as fast as aI can (as in starting right now) | 12:53 |
| gatox | ralsina, "download ubuntu one for windows"??? :D | 12:54 |
| ralsina | mandel, nessita, gatox, alecu, dobey: standup in 6' | 12:54 |
| ralsina | gatox: yep :-D | 12:54 |
| gatox | ralsina, ack | 12:54 |
| gatox | ralsina, awesome!! :D | 12:54 |
| mandel | ralsina, so it is oficial?! lets see what happens... | 12:56 |
| ralsina | mandel: well, it's officially official in 4 minutes, but close enough | 12:56 |
| mandel | ralsina, oh, well lets hope for the best hehe | 12:58 |
| alecu | hello! | 13:00 |
| gatox | alecu, hi! | 13:00 |
| gatox | me | 13:00 |
| nessita | me | 13:02 |
| alecu | me | 13:02 |
| nessita | ralsina, mandel, dobey? | 13:02 |
| ralsina | me | 13:02 |
| nessita | gatox: go! | 13:03 |
| ralsina | sorry, was busy with champagne in the management room | 13:03 |
| gatox | DONE: | 13:03 |
| gatox | Fixed some branches, Finished Pass Recover branch. | 13:03 |
| gatox | TODO: | 13:03 |
| gatox | Add defer to netword-detect in sso, keep fixing ui bugs. | 13:03 |
| gatox | BLOCKED: | 13:03 |
| gatox | No | 13:03 |
| gatox | nessita, go | 13:03 |
| nessita | DONE: bug #859635, lots of reviews, bug triage | 13:03 |
| nessita | TODO: enterview with win candidate, propose fix for bug #862363 | 13:03 |
| nessita | BLOCKED: nopes | 13:03 |
| nessita | NEXT: alecu | 13:03 |
| ubot4 | Launchpad bug 859635 in ubuntuone-servers (and 2 other projects) "Remove the deprecated DBus iface (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/859635 | 13:03 |
| mandel | me | 13:03 |
| ubot4 | Launchpad bug 862363 in libubuntuone "Should use async calls when requesting credentials (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/862363 | 13:03 |
| alecu | DONE: planned and worked on the SD part of "the secret feature" with mandel | 13:03 |
| alecu | TODO: integration, cleanup, more tests, finish proxies design document | 13:03 |
| alecu | BLOCKED: no | 13:03 |
| alecu | NEXT: ralsina | 13:03 |
| ralsina | DONE: sprint planning, organizing stuff, travel arrangements, some reviews. Officially released windows version. TODO: doctor's appointment, start working on my own bugs, BLOCKED: no | 13:03 |
| ralsina | you guys have secret features? Cool! | 13:04 |
| alecu | NEXT: mandel | 13:04 |
| mandel | DONE: Work on the data migration from old beta. Work on 'the secret feature' with alecu. | 13:04 |
| mandel | TODO: Clean up, swear at windows. Fix conflict from yestereday branches. | 13:04 |
| mandel | BLOCKED: no | 13:04 |
| alecu | NOTE: I'm not working tomorrow | 13:04 |
| ralsina | alecu: you aren't? | 13:05 |
| * ralsina checks canonicaladmin | 13:05 | |
| nessita | alecu: not freaky friday for you/ | 13:06 |
| nessita | ? | 13:06 |
| ralsina | NOTE: freaky fridays are do-what-you-want, but I need to know what you want first, so shoot a mail to me, please? ;-) | 13:06 |
| nessita | gatox: review queue? | 13:12 |
| gatox | nessita, let me check | 13:13 |
| gatox | nessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/pass-recover/+merge/77346 | 13:13 |
| nessita | ack | 13:14 |
| gatox | nessita, you can review this one too (i'm working in network-detect in sso, but no problem) https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 13:14 |
| nessita | gatox: so, we should book tickets to Buenos Aires (we don't have so much hurry as the international travelers have) | 13:14 |
| gatox | nessita, why?? tickets to buenos aires? | 13:15 |
| gatox | when? | 13:15 |
| gatox | i'm lost | 13:15 |
| nessita | gatox: wanna take care of your booking youself or your prefer I handle both? | 13:15 |
| nessita | gatox: you are? | 13:15 |
| gatox | nessita, when are we traveling to buenos aires?? | 13:15 |
| nessita | ralsina: hum, is gatox going to the sprint? | 13:15 |
| nessita | did I just put my leg? :-) | 13:16 |
| ralsina | yes he is | 13:16 |
| nessita | ok | 13:16 |
| nessita | gatox: SPRINT!!! | 13:16 |
| gatox | nessita, ahhhhhh do you mean the sprint!! | 13:16 |
| === m_conley_away is now known as m_conley | ||
| nessita | yes! | 13:16 |
| gatox | nessita, but, isn't that in december?? i get lost with the difference of time | 13:16 |
| nessita | gatox: yes, december, 5th to 9th | 13:16 |
| nessita | gatox: let's do this, I will handle my booking and you, yours, so you can learn how to do it and you can choose when to go and when to come | 13:17 |
| gatox | nessita, ahhhhhhh okok..... can we keep talking about this in pm? | 13:17 |
| nessita | sure | 13:17 |
| dobey | λ DONE: debugging | 13:19 |
| dobey | λ TODO: tickets, more debugging | 13:19 |
| dobey | λ BLCK: None. | 13:19 |
| nessita | dobey: hi there. I decided to take a deep breathe and fix everything that needs fixing about the SSO api change in libsyncdaemon and clients of it, so I may ask you a few things later today, if you have some minutes | 13:24 |
| nessita | dobey: unless you have a better plan :-) | 13:25 |
| dobey | nessita: can we put that on hold? i am happy to help figure that out, but i need to concentrate on this u1ms crasher in banshee for oneiric | 13:25 |
| nessita | dobey: agreed that the u1ms is higher priority. Is ok if I start working on that as long as I don't interrupt you? nothing will land without your approve | 13:26 |
| mandel | nessita, pushing the merge fixes and fixing the branch that depends on this too | 13:27 |
| nessita | dobey: I can put it on hold as well, I was just worried about end-users using nightlies... | 13:27 |
| dobey | nessita: i'd really like to come up with a better plan, because we need to do a lot of work on libsyncdaemon anyway; and i'd rather only have to break the API/ABI only once, so i think putting it on hold | 13:28 |
| nessita | dobey: fair enough. Would you please let me know when we can talk about this? (ie the u1ms is sorted out) | 13:29 |
| dobey | nessita: i think the two best current options for nightlies issue is to either revert the removal of the deprecated api from sso, or make the new api able to work with the dbus synchronous api | 13:29 |
| dobey | nessita: yes of course | 13:29 |
| nessita | dobey: I will try to go with "make the new api able to work with the dbus synchronous api" | 13:29 |
| dobey | nessita: thanks. i very strongly feel that is something we need to fix, regardless of how we change the libsd API :) | 13:31 |
| nessita | dobey: there is no client using the old API now, other than libsyncdaemon | 13:32 |
| dobey | nessita: well, none we know of :) | 13:35 |
| dobey | nessita: and whether there are or not, i think we need to not actively break the semantics of dbus | 13:36 |
| nessita | dobey: right | 13:36 |
| alecu | hey all, I'll be away for 30 minutes, see you then. | 13:45 |
| nessita | gatox: I found a bug I added to the bin\windows-ubuntu-sso-login script while IRL testing your branch, could you please review? https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/typo/+merge/77533 | 13:59 |
| gatox | nessita, yep | 13:59 |
| ralsina | leaving, doctor's appointment! Will be back in 60/90 minutes | 13:59 |
| gatox | nessita, tests?? jeje just kiding | 14:03 |
| gatox | +1 | 14:03 |
| nessita | gatox: I would love to have tests for this bin/scripts... | 14:03 |
| ralsina | nessita: testing scripts is very tricky, but it can be done with some refactoring. If you file me a bug I can do some | 14:06 |
| ralsina | for example, -installer has tests for main() which the other projects don't | 14:06 |
| mandel | nessita, if we reduce as much as possible the scripts we migth be able to do it | 14:12 |
| nessita | ralsina, mandel: I think is not worth it, as long as we add no logic to executable scripts, I think we're fine | 14:13 |
| nessita | gatox: approved pass-recover | 14:15 |
| gatox | nessita, nice | 14:15 |
| gatox | ralsina, now needs your approve :P | 14:16 |
| mandel | nessita, indeed, small scripts should do the trick | 14:16 |
| nessita | mandel: you let me know when your branch conflicts are resolved, no? | 14:16 |
| mandel | nessita, I already did a while back :) | 14:22 |
| nessita | mandel: oh, I missed the message | 14:22 |
| mandel | nessita, no worries :) | 14:23 |
| nessita | mandel: there is a failing test in linux. ALso, I still can't find the test for are_updates_present in the linux side | 14:34 |
| karni | Wo-hooo! Windows U1 release!! CONGRATULATIONS TEAM!!! | 14:35 |
| nessita | thanks karni! | 14:35 |
| gatox | :D | 14:35 |
| karni | nessita: \o/ | 14:35 |
| mandel | nessita, really? what revno do you have? | 14:37 |
| nessita | mandel: just branched | 14:37 |
| mandel | nessita, the tests is there 100% sure because is the one that did not pass | 14:38 |
| nessita | mandel: you run them under linux? | 14:39 |
| mandel | nessita, no, I could not vm is busted, I'm fixing it atm, but I know the issue, I forgot () | 14:39 |
| nessita | mandel: so, test is broken, no? | 14:39 |
| mandel | nessita, yes, good catch :) | 14:40 |
| mandel | nessita, I'm pushng the fix, should be there in few secs/mins | 14:43 |
| mandel | revno 80 should be there by now | 14:43 |
| nessita | mandel: lint issues... | 14:58 |
| nessita | c'mon... :-) | 14:58 |
| nessita | ok, I'll OTP fpr one hour~ people | 14:59 |
| duanedesign | Do you need to remove the Beta before installing the final windows release? | 15:06 |
| dobey | omg this webkit issue is insane | 15:08 |
| duanedesign | mandel: ^^ | 15:18 |
| dobey | ok, webkit is insanely huge and still pulling from svn | 15:26 |
| dobey | i'm going to lunch | 15:26 |
| dobey | bbiab | 15:26 |
| mandel | nessita, ok, I'll try to fix my ubuntu vm to fix those, sorry :( | 15:42 |
| mandel | nessita, I did warn you though :P | 15:42 |
| mandel | duanedesign, you do not need to, yet you should | 15:42 |
| mandel | duanedesign, I'm working on the code that will remove the old and migrate the data, but 'til then it has to be a manual operation | 15:42 |
| akgraner | Congrats y'all on the Ubuntu One official client for Windows release!! | 15:45 |
| nessita | mandel: you fixed the lint issues? | 15:47 |
| nessita | akgraner: thanks! | 15:47 |
| mandel | nessita, not yet, I'm trying to fix the ubuntu vm first so I dont use you as a tarmac | 15:54 |
| mandel | nessita, I think is a waste of your time if I do :( | 15:54 |
| nessita | mandel: is ok | 15:54 |
| nessita | I will run some errands in the mean time | 15:54 |
| * nessita -> quick errands | 15:54 | |
| achiang | hello, dumb question. does the windows U1 client check for updates and offer to update itself? | 15:57 |
| mandel | achiang, yes it does :) | 15:57 |
| achiang | i installed the beta for my mom last week, and would like to get her onto the release version | 15:57 |
| achiang | mandel: great, thanks! | 15:57 |
| mandel | achiang, it will promp you when ever there is an update, but there are none yet to find | 15:57 |
| achiang | mandel: ok, thanks. works for me | 15:58 |
| mandel | achiang, you are welcome | 15:58 |
| duanedesign | thanks mandel | 16:01 |
| mandel | duanedesign, no problems :) | 16:04 |
| mandel | duanedesign, as soon as it lands it will be added to the installer | 16:04 |
| Chipaca | http://askubuntu.com/questions/63581/ubuntu-one-v2-for-windows-doesnt-install-or-run-properly | 16:08 |
| mandel | Chipaca, I'm on it, it loos like a 500 error from the control panel | 16:19 |
| mandel | Chipaca, I'll ask for the logs and to file a bug against ubuntuone-control-panel (it has to be private until we confirm is logs are save) | 16:20 |
| nessita | mandel: is this related to the autoupdater? | 16:27 |
| === beuno is now known as beuno-lunch | ||
| mandel | nessita, no, that is comming from the control panel accessing one.ubuntuon.com | 16:32 |
| mandel | nessita, I think we have two bugs there, one: we should not show that horrible dialog in a release (yet is very useful for us) 2 we need to see why he is getting a 500 error and for which method | 16:33 |
| nessita | mandel: what would you do instead showing the dialog? | 16:33 |
| mandel | nessita, I'd show the dialog, but not with the response, maybe some little robot like the one in the web or what not | 16:33 |
| mandel | nessita, is our debug release (for us) I am very happy with that dialog, you know what I mean | 16:34 |
| mandel | all that for a user is like WTF! | 16:34 |
| nessita | mandel: right, we'd need some design | 16:34 |
| alecu | gatox, ping | 16:34 |
| alecu | gatox, ONLINE, OFFLINE, UNKNOWN... | 16:34 |
| gatox | alecu, pong | 16:34 |
| mandel | nessita, exactly, so we get to talk with design to make somehting preaty that says oops we broke and point to the bug page or something | 16:35 |
| gatox | alecu, yep | 16:35 |
| gatox | ? | 16:35 |
| mandel | nessita, and show the preaty one for users | 16:35 |
| alecu | gatox, what should we return when the state is UNKNOWN? | 16:35 |
| alecu | gatox, is_machine_connected -> True or False???? | 16:35 |
| mandel | nessita, the second bug will need the logs from that user so that we can see the exact requests, do you agree? | 16:35 |
| gatox | alecu, i think that is returning True in this moment | 16:35 |
| nessita | mandel: yes, we need logs | 16:36 |
| mandel | nessita, you can add comments to my reponse in http://askubuntu.com/questions/63581/ubuntu-one-v2-for-windows-doesnt-install-or-run-properly/63590#63590 if you thnk the answer is not clear :) | 16:36 |
| gatox | alecu, i play around with that code..... and in my case, for connection it was returning True for ONLINE and UNKNOWN | 16:38 |
| ralsina | hello again | 16:38 |
| ralsina | gatox: which one needs my approval? | 16:38 |
| gatox | ralsina, this one: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/pass-recover/+merge/77346 | 16:39 |
| ralsina | gatox: got it | 16:39 |
| alecu | gatox, lp:~alecu/ubuntu-sso-client/network-detect | 16:44 |
| alecu | gatox, (have not tested it at all, it's just a mockup) | 16:45 |
| dobey | i hope webkit compiles quickly | 16:45 |
| gatox | alecu, thanks!! i'll check that now!! :D | 16:45 |
| ralsina | dobey: it doesn't, sorry | 16:45 |
| dobey | ralsina: well, at leas i don't have to build it on windows. | 16:46 |
| ralsina | dobey: small blessing! | 16:46 |
| dobey | ralsina: or with qt or wx | 16:46 |
| ralsina | Webki comes with qt already | 16:46 |
| ralsina | no need to build it. OTOH, building Qt is very easy. It just takes a day. | 16:46 |
| dobey | it doesn't build all targets | 16:46 |
| dobey | i mean, webkit source doesn't build the qt target | 16:47 |
| dobey | you have to do the qt build stuff to build it | 16:47 |
| ralsina | dobey: yes, it works the other way around. Qt builds a snapshot of webkit | 16:47 |
| dobey | ralsina: no; qt includes a snapshot of webkit, yes; but it is irrelevant to building webkit itself | 16:48 |
| ralsina | dobey: let me rephrase what I meant: noone uses a version of webkit with qt different than the one that comes with qt :-) | 16:48 |
| dobey | ralsina: when i was working on plug-ins for webkitgtk, i had to compile for gtk+, wx, qt, and windows; just to make sure i didn't break anything :( | 16:48 |
| ralsina | therefore, noone builds webkit for qt | 16:48 |
| ralsina | oh, that sucks | 16:49 |
| dobey | but i am mostly sure this issue only happens in the gtk+ port | 16:49 |
| gatox | alecu, naaaaa..... asi de facil era? :P | 16:51 |
| alecu | gatox, of course! It's much easier done than said. | 16:53 |
| ralsina | gatox: +1 | 17:04 |
| gatox | ralsina, nice | 17:04 |
| === beuno-lunch is now known as beuno | ||
| alecu | ralsina, nessita, gatox: the "goalkeeper" of the building has just announced that we'll be out of power in 15', and for two hours. | 17:41 |
| ralsina | hahaha | 17:41 |
| ralsina | alecu: good one | 17:41 |
| alecu | mandel has lived in the UK and suggested that term. | 17:41 |
| dobey | ugh, and the scrolling bug is not fixed in tip of webkit-1.4 | 17:41 |
| ralsina | ok play battlestar galactica or something | 17:41 |
| nessita | alecu: ack | 17:41 |
| gatox | alecu, ack | 17:42 |
| gatox | alecu, perfect time to learn how to play BG...... true | 17:42 |
| alecu | gatox, I'm 3/4 thru the rules book already :P | 17:42 |
| dobey | nor does it fix the crash :( | 17:42 |
| gatox | alecu, mandel is a cylon.......... no matter what the game says!! ejejeje | 17:43 |
| gatox | an orange cylon | 17:43 |
| mandel | hahaha | 17:43 |
| alecu | gatox, unfortunately not one of the beautiful ones :-( | 17:43 |
| gatox | alecu, nop..... the old guy maybe.... | 17:43 |
| gatox | jeej | 17:43 |
| alecu | gatox, no spoilers, please! | 17:44 |
| gatox | alecu, sorryyyyyyy | 17:44 |
| mandel | gatox, alecu : http://1.bp.blogspot.com/_WcqFP6x3Bps/SXHi1l0rTZI/AAAAAAAAA7c/fkAyAyRQkFQ/s400/cylon.jpg | 17:44 |
| gatox | mandel, jejeje | 17:44 |
| alecu | the orange cylon! | 17:44 |
| ralsina | does alecu have a glow-in-the-dark butt? | 17:44 |
| ralsina | [that's the new cylons, right?] | 17:45 |
| alecu | ralsina, I'm not discussing my hemorrhoids here, sorry. | 17:45 |
| ralsina | waaaaaay TMI | 17:45 |
| gatox | nessita, please let me know if this solution is more appropiate: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/network-detect/+merge/77048 | 18:07 |
| gatox | nessita, i needed to modified one line in the installer too: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 18:07 |
| nessita | gatox: ack | 18:08 |
| zastaph | http://en.wikipedia.org/wiki/Ubuntu_One mentions CouchDB | 18:14 |
| zastaph | is CouchDB already installed on Ubuntu? because I installed it manually | 18:15 |
| gatox | nessita, ralsina i've to go to the university now.... i'll be back later today to check if i any of my branches needs fixing | 18:18 |
| nessita | gatox: enjoy! | 18:18 |
| gatox | :D | 18:18 |
| nhaines | Congrats to everyone on the U1 for Windows release! | 18:39 |
| zastaph | can U1 be installed as a private cloud? on ubuntu-server | 18:41 |
| nhaines | zastaph: no, the U1 server is not available. | 18:42 |
| zastaph | dont know if I dare to store my files in public cloud. not that i dont trust canonical, but when lastpass was hacked etc. | 18:43 |
| nhaines | That's a fair enough concern. :) | 18:45 |
| zastaph | yeah would be cool if could combine private with public, so they were practically just 2 separate folders | 18:51 |
| nhaines | Probably from a monetization point of view, no one would pay for U1 then. | 18:53 |
| zastaph | setting up your own 24/7 available server has quite some expenses too, and the added versatility would also boost the popularity | 18:55 |
| zastaph | so of course users would still prefer a hosted solution | 18:55 |
| zastaph | most users | 18:55 |
| nhaines | I think the "official" answer is that the client is open source and therefore the protocol is available, so have at it. :) | 18:56 |
| zastaph | yes I read something like that too.. that anyone interested could implement it | 18:57 |
| zastaph | been looking for a private cloud dropbox replacement for some time | 18:57 |
| zastaph | U1 is not activated in Ubuntu before you actually sign up right? | 18:58 |
| zastaph | as I understand it, Windows 8 wont work without a cloud account :| | 18:58 |
| beuno | zastaph, right, it's optional | 18:58 |
| beuno | will always be | 18:58 |
| nhaines | zastaph: right, U1 is optional. | 18:58 |
| nhaines | Windows 8 works just fine without a cloud account. | 18:59 |
| zastaph | ok | 18:59 |
| dobey | pretty much any computer is useless without an internet account :) | 19:00 |
| nhaines | dobey: so it seems these days. :) | 19:00 |
| zastaph | but companies sure like their clouds so they can analyze you :p | 19:01 |
| zastaph | target their ads | 19:02 |
| zastaph | new kindle even has ads, and noone has bigger clouds than amazon :) | 19:03 |
| dobey | i don't know. cumulo nimbus are bigger than amazon | 19:04 |
| ralsina | zastaph: the amazon drainage basin is 7,050,000 sq km | 19:10 |
| ralsina | oops, dobey: ^ | 19:10 |
| dobey | ralsina: not that big | 19:12 |
| ralsina | well, it's the world largest | 19:12 |
| ralsina | imagine how many servers you can fit there! | 19:12 |
| dobey | ralsina: less than the potential coverage area of actual clouds | 19:14 |
| ralsina | yes, but are we talking one cloud? ;-) | 19:15 |
| ralsina | I mean, sure, clouds cover all of venus | 19:15 |
| dobey | nessita: can you change your existing proposal to be work-in-progress? | 19:35 |
| nessita | dobey: yes! | 20:02 |
| dobey | nessita: thanks | 20:02 |
| dobey | nessita: how is making sso be able to work synchronously coming along? | 20:14 |
| nessita | dobey: great, a branch is ready, wanna review? | 20:15 |
| dobey | sure, i can look at it | 20:15 |
| nessita | dobey: but I'm also exposing the same sync method in ubuntuone.credentials, so we can directly migrate libsyncdaemon to use the u1 dbus service, and that way we drop the need of using the ping_url, tc_url, etc constants | 20:16 |
| nessita | dobey: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/find_credentials-sync/+merge/77603 | 20:17 |
| dobey | hmm | 20:18 |
| dobey | is ubuntuone.credentials used on windows? | 20:18 |
| nessita | dobey: not the dbus part, of course, but the rest yes | 20:23 |
| nessita | why? | 20:24 |
| dobey | because i don't know what all parts are or aren't used on windows, aside from the things that obviously aren't; and our code is pretty much a mess in that respect. | 20:25 |
| nessita | dobey: when in doubt, assume the code is used in windows | 20:26 |
| nessita | :-) | 20:26 |
| dobey | and i think your synchronous fix is not exactly synchronous | 20:27 |
| nessita | dobey: why not? it does work like the former find_credentials method | 20:31 |
| nessita | dobey: I tried it with d-feet... it returns the credentials synchronously | 20:33 |
| nessita | dobey: to run from the branch: killall ubuntu-sso-login; DEBUG=True PYTHONPATH=. ./bin/ubuntu-sso-login | 20:33 |
| dobey | nessita: and i think you need to call the async_handlers by reply_handler and error_handler, as documented here: http://dbus.freedesktop.org/doc/dbus-python/doc/tutorial.html#making-asynchronous-calls | 20:35 |
| nessita | dobey: ah, maybe, I used the same implementation that we had in the deprecated SSOCredentials (but yes, maybe that was buggy) | 20:35 |
| dobey | huh | 20:36 |
| dobey | nessita: needsfixinged for that; it seems to work from d-feet, though i have no idea how, so once you fix that i'll approve | 20:48 |
| nessita | dobey: thanks, I'm running tests now | 20:49 |
| nessita | (for the change) | 20:49 |
| nessita | dobey: Pushed up to revision 799. | 20:51 |
| nessita | dobey: I think you can name your async params as you want (in the server object), as long as you map those to the reply and erro handler using the async_callbacks parameter | 20:53 |
| dobey | i think d-feet calls everything with the async callbacks though | 20:54 |
| nessita | dobey: confirmed the "async_callbacks" can name the parameters as you like (from http://dbus.freedesktop.org/doc/dbus-python/api/dbus.decorators-module.html) | 20:55 |
| dobey | alright, i am out. have a good evening! | 21:07 |
| === m_conley is now known as m_conley_away | ||
| nessita | bye dobey | 21:11 |
| * nessita -> eods | 21:21 | |
| nessita | bye all! | 21:21 |
| === anders_ is now known as AJenbo | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
