mandel | morning! | 08:27 |
---|---|---|
nhaines | mandel: morning! | 08:28 |
ralsina | good morning! | 08:31 |
gord | hi all, is there a project to file bugs against the u1ms specifically? feels kinda weird to file it against u1 itself, its a problem with the web u1ms thingy through banshee | 08:38 |
ralsina | gord: let me check | 08:39 |
ralsina | gord: if it's not the client code, but server code, it may be https://launchpad.net/ubuntuone-music-store | 08:40 |
gord | ralsina, yeah thats what i'm looking for, great, thanks! | 08:41 |
ralsina | gord: you're welcome! | 08:41 |
nhaines | Just installed U1 for Windows... now I'll see how it works. :) | 08:45 |
gord | https://bugs.launchpad.net/ubuntuone-music-store/+bug/865145 if anyone is interested :) | 08:51 |
ubot4 | Launchpad bug 865145 in ubuntuone-music-store "Your Downloads page can't show all pages when you have lots of files (affects: 1) (heat: 6)" [Undecided,New] | 08:51 |
ralsina | gord: I am sure someone will pick it up :-) | 08:53 |
ralsina | nhaines: good luck! :-D | 08:53 |
mandel | nhaines, any issues let us know, either ralsina or me should be able to fix it | 08:56 |
mandel | ralsina, I've got a question about the autoupdate regarding the control panel | 08:56 |
ralsina | mandel: sure! | 08:56 |
mandel | ralsina, what do you want to do with that? do we want to be cecking every x minutes or what? (looping call comes to mind) | 08:57 |
ralsina | mandel:I was thinking like once a day | 08:57 |
mandel | ralsina, also, do we have the app indicator, I know it is hidden by the OS, but that is the path we should that in my opinion | 08:57 |
nhaines | mandel: thank you, I'll keep that in mind. | 08:57 |
ralsina | mandel: but we need two more things: 1) A way to check manually (there is a bug) 2) a way to let the user disable it | 08:57 |
ralsina | mandel: we do | 08:57 |
ralsina | mandel: I mean we do have the app indicator | 08:58 |
mandel | ralsina, oh, cool, so its a matter to have an api for that, seems reasonable | 08:58 |
mandel | ralsina, I'll do the following, will fix the issues with the branches that update from the laste beta and will move to that, does that sound reasonable? | 08:58 |
ralsina | mandel: yes | 08:59 |
mandel | ralsina, I'll posposne the work in the secret project for later in the afternoon or tom | 08:59 |
ralsina | mandel: if I knew what the secret project was, maybe I would tell you not to ;-) | 08:59 |
mandel | ralsina, just told you via pm :P | 08:59 |
ralsina | got it :-) | 09:00 |
mandel | ralsina, can you asign me the bugs then? or do I need to create them? | 09:06 |
ralsina | mandel: I'll assign | 09:06 |
mandel | ralsina, superb, thx! | 09:06 |
ralsina | mandel: bug #852125 | 09:09 |
ubot4 | Launchpad bug 852125 in ubuntuone-client "Windows: Offer a feature to check for an updated copy of the software (affects: 2) (heat: 12)" [Medium,Triaged] https://launchpad.net/bugs/852125 | 09:09 |
ralsina | mandel: and bug #845659 that was already yours | 09:09 |
ubot4 | Launchpad bug 845659 in ubuntuone-windows-installer "Windows: implement the "there is a new version available" notifications (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/845659 | 09:09 |
mandel | ralsina, for https://bugs.launchpad.net/ubuntuone-client/+bug/852125 it would be nice to get seomt feed back from design, where should we put this etc.. | 09:12 |
ubot4 | Launchpad bug 852125 in ubuntuone-client "Windows: Offer a feature to check for an updated copy of the software (affects: 2) (heat: 12)" [Medium,Triaged] | 09:12 |
mandel | ralsina, I dont want to get the UI worse by adding extra buttons etc | 09:13 |
ralsina | mandel: I was thinking just a simple "There is a new version of this software" [] Stop checking for updates [Update] [Remind me later] | 09:14 |
ralsina | three rows: label / checkbox / buttons | 09:14 |
ralsina | Oh, wait | 09:14 |
ralsina | I would put that in the menu onthe indicator, and in the start menu | 09:14 |
mandel | ralsina, where? | 09:14 |
mandel | ralsina, ah, that was my question, but I think that we should also centralize all UI elements for condiguration | 09:15 |
mandel | ralsina, without adding extra clutter ofcourse | 09:15 |
ralsina | mandel: the indicator menu is good enough. This is not exactly a frequently used thing | 09:15 |
mandel | ralsina, hmmm lets adding it there and wait for the bug reports :P | 09:16 |
ralsina | bug #932250 "NEEDS MORE COWBELL" | 09:16 |
ubot4 | ralsina: Error: Bug #932250 not found. | 09:16 |
ralsina | yet, ubot4, yet | 09:16 |
mandel | ralsina, hehe | 09:17 |
mandel | ralsina, by the way, we should consider allowing people to set ~ to point somewhere else, I have seen lots of people (like 4 hehe) complaining about this because they have a ssd | 09:18 |
mandel | which makes sens since on linux they can set $HOME as a diff partition in a diff hd, but not on windows | 09:18 |
ralsina | mandel: yes, I even did a thread about that in ubunet-discuss | 09:18 |
ralsina | got the "it's HARD" standard response | 09:18 |
mandel | ralsina, yeah, I read it.. I did respond about the symlinks | 09:19 |
ralsina | however, I suspect the only "real" problem with moving ~ is not having two users overlapping | 09:19 |
ralsina | or rather "making sure two users don't overlap" | 09:19 |
mandel | ralsina, exactly, I was thinking the same, and if to users overlap, what happens? | 09:19 |
mandel | does it go bannanas? | 09:19 |
ralsina | mandel: syncdaemon pingpong | 09:20 |
ralsina | or worse, metadata pingpong | 09:20 |
ralsina | BTW: we should make it impossible to add ~/Appdata as a UDF | 09:20 |
ralsina | or anything that contains ~/Appdata | 09:20 |
karni | Good morning! | 09:21 |
ralsina | mornig karni! | 09:21 |
mandel | ralsina, there is a config that tells you what regexp should be ignored in the sync files, we could use that | 09:21 |
mandel | ralsina, we might need to trick it since we have to expand ~ | 09:21 |
mandel | ralsina, or, expand ~ when we write the config files, something like that, but less hacky :P | 09:22 |
mandel | karni, buenos dias! | 09:22 |
* mandel O machines just went crazy | 09:22 | |
karni | ralsina: mandel: buenos dias! ^_^ | 09:22 |
ralsina | I think a config that says what ~ means should be enough | 09:22 |
ralsina | Since we only should be using paths relative to ~ anywhere | 09:22 |
ralsina | In fact... setting HOME should do the trick! | 09:23 |
ralsina | since os.expanduser uses that even on windows | 09:23 |
mandel | ralsina, I'm 100% sure we use ~ everywhere | 09:23 |
ralsina | mandel: are you willing to see what happens if you set HOME ;-) | 09:24 |
mandel | ralsina, if you are talkinga bout assigning that bug to me, feel free :) | 09:25 |
ralsina | mandel: I am talking about trying it out and seeing what explodes :-) | 09:25 |
ralsina | mandel: then, if it works, declaring it a feature ;-) | 09:26 |
mandel | ralsina, ok, Ill take a look | 09:27 |
mandel | ralsina, ok, I'll add it to my todo | 09:28 |
mandel | ralsina, now, coffee break for me :) | 09:28 |
ralsina | mandel: cool, see you later! | 09:28 |
JamesTait | Morning all! | 09:35 |
ralsina | good morning JamesTait! | 09:40 |
* mandel back! | 10:08 | |
mandel | ralsina, ping | 10:25 |
ralsina | mandel: pong | 10:25 |
mandel | ralsina, the runtests from ubuntuone-windows-installer gives me an error on Linux, do you have the same issue? | 10:27 |
ralsina | mandel: haven't tried that in a while | 10:27 |
mandel | ralsina, I have an import error with ubuntuone.controlpanel.gui.qt.ui | 10:27 |
mandel | ralsina, does that make sense? | 10:27 |
ralsina | mandel: you need to set PYTHONPATH correctly or the tests won't work | 10:28 |
ralsina | it must have u1-client u1cp and ussoc in it | 10:28 |
mandel | ralsina, but I have ubuntuone-control-panel installed from trunk | 10:28 |
mandel | ralsina, so I'm surprised.. | 10:28 |
ralsina | remember that we don't install the Qt bits on linux | 10:28 |
mandel | ralsina, la puta! | 10:29 |
mandel | ralsina, ok, mea culpa | 10:29 |
mandel | jesus! how longs does pylint take! | 10:44 |
ralsina | mandel: on a VM, semi-forever | 10:45 |
mandel | ralsina, yes, I need to just change like 3 lines and the process of doing it is a PITA | 10:45 |
mandel | ralsina, dammed! | 10:45 |
mandel | ralsina, do you have any trick in your bag to make u1lint faster? this is just plain stupid :( | 10:50 |
ralsina | mandel: yes, run it on linux | 10:57 |
ralsina | or on macos, or whatever is not a VM ;-) | 10:57 |
mandel | ralsina, I hate multiplatform programming.. vms are suppose to solve this! | 11:00 |
ralsina | mandel: pylint is extremely disk-intensive | 11:00 |
* mandel is embarrassed about his os, had to do sudo port install wget | 11:10 | |
nessita | good morning everyone! | 11:11 |
mandel | nessita, buenos dias1 | 11:11 |
nessita | hello mandel! | 11:12 |
nessita | did you have a safe trip home? | 11:12 |
mandel | nessita, yes, it was very long but everything went perfectly ok :) | 11:12 |
mandel | ralsina, what is up with this bug: https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/863582 ? | 11:14 |
ubot4 | Launchpad bug 863582 in ubuntuone-windows-installer "Wrong upgrade detection (affects: 1) (heat: 6)" [Medium,Triaged] | 11:14 |
mandel | ralsina, I think we should try to remove the autoupdate code from install builder and do it in python, even change the xml to be a json and just do a wget of the installer and execute it | 11:15 |
* mandel walks dog | 11:16 | |
ralsina | mandel: that one is my fault | 11:18 |
ralsina | mandel: there are two ways to do it according to the manual, and I chose the bad one ;-) | 11:18 |
* ralsina walks the kid (to school, be back in 1 hour) | 11:19 | |
mandel | ralsina, ok, I don't see many problems with it, I just wanted to know if we either used the current code or just re-do it in python | 11:56 |
* mandel back | 11:58 | |
* mandel is happy that u1-tdev-tools is trully multiplatform, running u1lint on mac os x | 12:04 | |
nessita | mandel: is the branch ready for re-review? | 12:05 |
nessita | (just checking) | 12:06 |
mandel | nessita, nearly done, let me 2 mins to do a push | 12:06 |
mandel | nessita, turns out that u1lint/pylint is unusuable on a VM | 12:06 |
mandel | nessita, takes for ever to finish (as in hours) | 12:07 |
mandel | nessita, I'd conider this as high: https://bugs.launchpad.net/ubuntuone-client/+bug/865279 | 12:13 |
ubot4 | Launchpad bug 865279 in ubuntuone-client "Windows System tray icon doesn't return after re-opening Ubuntu One (affects: 1) (heat: 6)" [Undecided,New] | 12:13 |
mandel | nessita, if we can reproduce it, that is | 12:14 |
mandel | also, pushed revno 81 | 12:14 |
nessita | mandel: I would go with a medium or low, the user does have the controlpanel opened every time, just the systrey icon is missing | 12:14 |
nessita | mandel: I will assign to ralsina | 12:15 |
mandel | nessita, I find this an issue: The process ubuntuone-control-panel-qt.exe keeps running. | 12:15 |
mandel | and this There is no way of closing old instances but killing them from the Windows Task Manager. | 12:15 |
nessita | mandel: that's another issue... we have a bug in the u1cp about it | 12:16 |
mandel | nessita, ok, if you give be the bug number and I'll point the user to that one and will edit the bug a little | 12:16 |
nessita | mandel: the bug title is correct, no? | 12:17 |
mandel | nessita, yes, the explanation is the one I'd clean | 12:17 |
mandel | nessita, add say that we should remove the task manager mentions and just say it does not longer appear | 12:17 |
mandel | nessita, I need to go for 5 min, I'll be back (machine reboot) | 12:18 |
nessita | mandel: what do you mean with "remove the task manager mentions"? | 12:18 |
mandel | nessita, clean this: 1.- The process ubuntuone-control-panel-qt.exe keeps running. No icon in the windows system tray. If I relaunch it again, a new instance of ubuntu-one-control-panel-qt.exe is launched. There is no way of closing old instances but killing them from the Windows Task Manager. | 12:18 |
mandel | nessita, arg, reboot, I'll be back asap | 12:18 |
mandel | puto mac! | 12:18 |
mandel | nessita, waht I was thinking is to remove the sentece and say: 1. No systray icon appears. This might be related to bug number #blah | 12:29 |
nessita | mandel: hum | 12:30 |
nessita | mandel: I think they are separated issues | 12:30 |
nessita | mandel: I think one issue is that the systray does not appear, and another that the former process does not finish | 12:30 |
mandel | nessita, I have the same gut feeling, but in my case is just gut. That is why I think we should solve the process one first and then see what is going on with the systray | 12:31 |
nessita | mandel: the process one is not close to be solved, we don't even know what's going on | 12:31 |
nessita | mandel: something is not good between the qt4reactor and twisted | 12:32 |
mandel | nessita, ok.. that is bad :( | 12:32 |
mandel | nessita, what I think if might be happening is that the systray of the second process is not created because there is already one, yet hidden/closed but I'm just syaing random though, I have no prove for my statement | 12:32 |
ralsina | nonono | 12:33 |
ralsina | the systray icon is not created because you have to use --with-icon to create it | 12:33 |
ralsina | and the default is "no icon" because having many icons is worse | 12:33 |
mandel | ralsina, oh, nice so no issues :) | 12:33 |
nessita | ralsina: we're talking about bug #865279 | 12:33 |
ubot4 | Launchpad bug 865279 in ubuntuone-windows-installer "Windows System tray icon doesn't return after re-opening Ubuntu One (dup-of: 862997)" [Undecided,New] https://launchpad.net/bugs/865279 | 12:33 |
ubot4 | Launchpad bug 862997 in ubuntuone-control-panel "It's possible to open ubuntu one twice (affects: 2) (dups: 1) (heat: 161)" [Medium,Triaged] https://launchpad.net/bugs/862997 | 12:34 |
mandel | I mean, no bad issues :P | 12:34 |
ralsina | once we have a "unique app" thing, that is trivial to fix (make --with-icon the default) | 12:34 |
ralsina | nessita: I know, I answered it | 12:34 |
mandel | ralsina, what is a 'unique app'? | 12:34 |
mandel | you mean single process? | 12:34 |
ralsina | mandel: an app that only can be started once | 12:34 |
ralsina | mandel: and that if you start it again, it activates the ld instance's window instead | 12:35 |
ralsina | mandel: like u1cp is on Linux (but that's done using DBUS) | 12:35 |
mandel | ralsina, sometimes dbus makes things too easy, I hate it for being that good :( | 12:35 |
ralsina | mandel: don't be a geek ;-) | 12:36 |
ralsina | doing it on windows using QLocalServer is not terribly hard. I have C++ code for it | 12:36 |
ralsina | I just need to translate it | 12:37 |
ralsina | In fact, I think I will | 12:37 |
nessita | ralsina: the only problem may be that the controlpanel something does not finishes :-/ | 12:41 |
ralsina | nessita: since we have the notification area icon, not finishing is not a big problem | 12:41 |
ralsina | unless of course, it leaves the localsocket open | 12:41 |
nessita | ralsina: probably it does, but I have no way of confirming it (just a intuition) | 12:42 |
ralsina | we can always make it kill itself to ensure it really, really, really ends | 12:42 |
gatox | hi everyone! | 12:44 |
nessita | hi gatox | 12:45 |
mandel | gatox, morning! | 12:45 |
nessita | gatox: how is it going? | 12:45 |
gatox | nessita, fine... in a bunker in KGB (cafe)... didn't finish the branch about no mocker in the weekend (or friday), because i was moving to a new apartment.. and i don't have internet there until tomorrow | 12:46 |
nessita | gatox: ok, so, you plan on finishing it today? | 12:47 |
mandel | gatox, I've been there before.. is a paint to move all utilities to a new place | 12:47 |
mandel | gatox, will the walls be orange? | 12:47 |
gatox | mandel, of course | 12:47 |
gatox | nessita, i will try... i think it's possible | 12:48 |
mandel | gatox, http://www.youtube.com/watch?v=bT_Jr3vasOo | 12:48 |
gatox | mandel, jeje | 12:49 |
ralsina | gatox, nessita, mandel, alecu, dobey: standip in 9' | 12:51 |
gatox | ralsina, ack | 12:51 |
mandel | ralsina, gatox I have a question about the ubuntuone-windows-installer. Why is utils under ubuntuone_installer/gui/qt? why not ubuntuone_installer/utils? I know we will be always using qt, but it just looks funny | 12:52 |
ralsina | mandel: no reason | 12:53 |
mandel | ralsina, oh, so could we later move it up? or will it be a terrible idea? | 12:54 |
mandel | nessita, ping | 12:54 |
nessita | mandel: pong | 12:54 |
ralsina | mandel: without a better reason than "looks funny" I vote +1 on terrible idea ;-) | 12:54 |
mandel | nessita, I need some small help with a stupid function. I want to find the path to the root folder of ubuntu one (~/Ubuntu One) and I don't want to hard code the code with os.path.join(~ Ubuntu One). Do you know any api from sd that I can use for that? | 12:55 |
mandel | ralsina, :*( | 12:55 |
mandel | ralsina, I hate to type that long to get a file (yes, I use tab completion) | 12:56 |
nessita | mandel: SyncDaemonTool.get_root() | 12:56 |
mandel | nessita, me loves you! | 12:56 |
mandel | as in thx, nothing weird :P | 12:56 |
nessita | mandel: :-) | 12:56 |
gatox | ralsina, review please: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/local-folders-get_info-fail/+merge/77718 | 12:58 |
ralsina | gatox: ack | 12:58 |
* mandel tests funny things with sd | 12:59 | |
mandel | me | 13:00 |
gatox | me | 13:00 |
nessita | me | 13:00 |
nessita | alecu, dobey, ralsina? | 13:01 |
ralsina | me | 13:01 |
dobey | me | 13:01 |
nessita | mandel: go! | 13:01 |
mandel | DONE: Fixed pylint issues for lp:~mandel/ubuntuone-windows-installer/check-old-app and lp:~mandel/ubuntuone-windows-installer/uninstall-old-app | 13:01 |
mandel | TODO bug #852125 and bug #852125. Set up real Linux box so that I can run pylint natively (can you believe that, no VM! WTF?) | 13:01 |
mandel | BLOCKED: no | 13:01 |
mandel | COMMENTS: will try to do some secret feature code later in the evening | 13:01 |
mandel | next gatox!!! | 13:01 |
ubot4 | Launchpad bug 852125 in ubuntuone-client "Windows: Offer a feature to check for an updated copy of the software (affects: 2) (heat: 12)" [Medium,Triaged] https://launchpad.net/bugs/852125 | 13:01 |
gatox | DONE: | 13:01 |
gatox | Some personal errands, finish local folders get info fails | 13:01 |
gatox | TODO: | 13:01 |
gatox | Fix some tests for Network Detection, work on no mocker branch. | 13:01 |
gatox | BLOCKED: | 13:01 |
gatox | No | 13:01 |
gatox | nessita, go | 13:01 |
nessita | DONE: first freaky friday :-D! made a little more of bug #859635, bug triage, and magicicada | 13:02 |
nessita | TODO: finish bug #859635, bug #862991, bug #862540 | 13:02 |
nessita | BLOCKED: nopes | 13:02 |
nessita | NEXT: ralsina | 13:02 |
nessita | COMMENT: will leave early to present the TDD talk at the uni | 13:02 |
ubot4 | Launchpad bug 859635 in ubuntuone-servers (and 2 other projects) "Remove the deprecated ApplicationCredentials SSO DBus iface (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/859635 | 13:02 |
ubot4 | Launchpad bug 862991 in ubuntuone-control-panel "Set a better title for the error dialogs (affects: 1) (heat: 6)" [Low,In progress] https://launchpad.net/bugs/862991 | 13:02 |
ubot4 | Launchpad bug 862540 in ubuntuone-control-panel "Do provide a nice error message when there are issues (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/862540 | 13:02 |
ralsina | DONE: took friday off b/c personal issue, bug triaging, some reviews. TODO: fix bug #862997 BLOCKED: no | 13:02 |
ubot4 | Launchpad bug 862997 in ubuntuone-control-panel "It's possible to open ubuntu one twice (affects: 2) (dups: 1) (heat: 165)" [Medium,Triaged] https://launchpad.net/bugs/862997 | 13:02 |
ralsina | whoever is next? :-) | 13:02 |
alecu | me | 13:02 |
nessita | dobey: | 13:02 |
dobey | λ DONE: tickets, fixed ftbfs, mulled over issues/planning | 13:02 |
dobey | λ TODO: bug #865105 | 13:02 |
dobey | λ BLCK: None. | 13:02 |
ubot4 | Launchpad bug 865105 in ubuntuone-client-gnome (Ubuntu) (and 1 other project) "nautilus crashed with SIGSEGV in g_variant_unref() in any folder with Ubuntu One location widget (affects: 24) (dups: 1) (heat: 118)" [Critical,Confirmed] https://launchpad.net/bugs/865105 | 13:02 |
dobey | alecu | 13:02 |
alecu | DONE: minisprint with mandel: worked on a prototype of emblems for windows file explorer, discussed proxy options | 13:02 |
alecu | TODO: get back to server-time synchronization branches | 13:02 |
alecu | BLOCKED: no | 13:02 |
nessita | alecu: hi there! | 13:02 |
ralsina | alecu: I want to add to your TODO: fix tests on unicode usernames branch so it merges | 13:02 |
alecu | +TODO: fix tests on unicode usernames branch so it merges | 13:03 |
nessita | alecu: can you please, as a top priority, fix the unicode username branch? since it wasn't in trunk, it did not end up in the installer we released :-/ | 13:03 |
nessita | alecu: ah, what ralsina said :-) | 13:03 |
nessita | nessita[TODO].append('Send interview feedback to bosses') | 13:04 |
* ralsina is not going to manually merge anything in a release ever again | 13:04 | |
ralsina | Oh, also DONE: "got interviewed" | 13:04 |
alecu | ralsina, sounds like a reasonable branch | 13:04 |
mandel | eod? I need to have lunch | 13:05 |
alecu | mandel, eom perhaps! | 13:05 |
ralsina | mandel: you mean EOM? | 13:05 |
ralsina | eom! | 13:06 |
dobey | you know how the spanish are | 13:06 |
ralsina | NOTE: we are up to about 2300 concurrent users on windows now | 13:06 |
mandel | yes, that hehe | 13:06 |
dobey | lunch, siesta, beer, futbol, dinner | 13:06 |
mandel | that is the same numbers that microsoft have about windows running achine heheh | 13:08 |
* mandel lunch | 13:09 | |
nessita | ralsina: got interviewed? who interviewed you? | 13:11 |
ralsina | nessita: same interview series as chipac-a | 13:11 |
dobey | nessita: akgraner i guess | 13:12 |
ralsina | shouldbe out tomorrow | 13:12 |
nessita | dobey, ralsina: ah :-) | 13:12 |
ralsina | gatox: +1 on your branch | 13:13 |
ralsina | Anyone else has reviews pending? | 13:14 |
gatox | ralsina, great | 13:14 |
nessita | dobey: I will be re-proposing the update-sso branch. I googled for the marshaller thing, and I read that you need to register a custom marshall if there is no builtin one for the signal signature you're connecting to. Since the signals we want to handle send either no params (auth denied, creds not found) or a string-string array (creds found, creds error), I just register a custom marshall for _syncdaemon_marshal_VOID__POINTER | 13:15 |
nessita | dobey: when you have some spare time, would you review https://code.launchpad.net/~nataliabidart/ubuntuone-client/update-sso/+merge/77370 ? | 13:15 |
dobey | sure | 13:16 |
dobey | fixing this critical first :) | 13:16 |
akgraner | nessita, yep - for the Ubuntu One series on my Ubuntu User - You-In-Ubuntu blog - I'll post it tomorrow - Tuesday are for Canonical/Ubuntu interviews - Monday's are for UWN and Leadership stuffs for me | 13:16 |
akgraner | dobey, thanks for catch the mbp for me..I can't believe I did that...:-/ | 13:18 |
akgraner | s/catch/catching - dang it - yep it's Monday.... | 13:18 |
dobey | akgraner: no problem. :) | 13:19 |
=== m_conley_away is now known as m_conley | ||
* mandel back! | 13:25 | |
mandel | lisette, ping | 13:37 |
lisette | mandel: pong | 13:37 |
mandel | lisette, I'm looking at fixing https://bugs.launchpad.net/ubuntuone-client/+bug/852125 and I was wondering if I can get any input from the design team. | 13:38 |
ubot4 | Launchpad bug 852125 in ubuntuone-client "Windows: Offer a feature to check for an updated copy of the software (affects: 2) (heat: 12)" [Medium,Triaged] | 13:38 |
mandel | lisette, I wonder were to put the UI and old that :P | 13:38 |
lisette | mandel: ummm..? | 13:39 |
mandel | lisette, the one way we though of was to add it in the context menu of the systray icon | 13:39 |
ralsina | dobey, nessita: we can't include code licensed under GPLv2 into u1, right? | 13:39 |
ralsina | GPLv2 or later that is | 13:39 |
mandel | ralsina, we are gpl. right? | 13:39 |
dobey | GPLv2 or later means we can license it as GPLv3, if you want to put it in something of ours that is GPLv3 | 13:39 |
nessita | ralsina: license wise, we can (is compatible), but we need to hold the copyright as far as I know | 13:39 |
ralsina | mandel: yes we are, but "contributor's agreement"? | 13:39 |
lisette | mandel: i am not 100% sure what you mean with where to put the UI? | 13:40 |
dobey | and there is the contrib agreement thing | 13:40 |
ralsina | right. So, I'll reimplement from a BSD source instead | 13:40 |
ralsina | pity | 13:40 |
dobey | uhm | 13:40 |
dobey | using BSD doesn't solve the problem either :) | 13:40 |
ralsina | dobey: there's not going to be anything left of the code. The original is C++ ;-) | 13:41 |
dobey | ralsina: what are you trying to do anyway? | 13:41 |
mandel | lisette, have to add an option to check that there are updates and we do not have a tools bar (file, edit etc) so either I do not show it in the control panel ui at all, or I put it somewhere | 13:41 |
ralsina | dobey: I need an implementation of "unique application" that wrks on qt + windows | 13:41 |
ralsina | dobey: there are several, but of course we have not written them ;-) | 13:42 |
dobey | oh | 13:42 |
mandel | ralsina, find a university student and tell him to plagarize it :P | 13:42 |
ralsina | mandel, lisette: I think putting that in the panel UI is not a good idea | 13:42 |
dobey | that is trivial | 13:42 |
ralsina | dobey: it's trivial on Linux (and most apps did it wrong for years anyway) | 13:42 |
lisette | mandel: can we check in the background on startup and give a popup like VLC does? | 13:42 |
mandel | ralsina, that is why I'm asking the design team, I prefer not to make this type of decitons ;) | 13:42 |
dobey | ralsina: aren't we already using our magical IPC thing? | 13:42 |
ralsina | dobey: u1cp is not a "magical IPC server" | 13:43 |
mandel | lisette, we have that, matt wants also an explicit check | 13:43 |
ralsina | dobey: and having to assign another port to it for this is a huge overkill | 13:43 |
lisette | mandel: aha. i think with VLC there are some boxes to check to allow the program to check for updates | 13:43 |
dobey | ralsina: does Qt not have something like XAtoms on Windows? | 13:44 |
nessita | mandel, lisette: since we're aming to have the QT controlpanel to be multiplatform, I will not put the setting in the control panel itself | 13:44 |
lisette | mandel: which could logically put it under program settings | 13:44 |
ralsina | dobey: since it's for windows, I could just add this as a developer dependency: http://websvn.pardus.org.tr/uludag/trunk/pds/pds/quniqueapp.py?revision=37802&view=markup | 13:44 |
ralsina | dobey: there isn't AFAIK. The popular way is to do it using a socket, so you can actually tell the running instance to open a window | 13:45 |
dobey | ralsina: doesn't that "open another port just for this" ? :P | 13:45 |
ralsina | dobey: nope. A localsocket (like a unix socket) | 13:46 |
ralsina | we are using TCP for our IPC | 13:46 |
dobey | oh | 13:46 |
dobey | why are we using TCP? | 13:46 |
ralsina | dobey: long story? | 13:46 |
dobey | and i thought Qt already had a unique app API? | 13:47 |
ralsina | dobey: short version: twisted is tricky. | 13:47 |
ralsina | dobey: they do in C++: http://qt.gitorious.org/qt-solutions/qt-solutions/blobs/master/qtsingleapplication/src/qtsingleapplication.cpp | 13:47 |
ralsina | dobey: but it's not part of Qt proper | 13:47 |
dobey | oh | 13:47 |
mandel | ralsina, I agree with lisette that we should be adding it in the settings tabs, and we can think a way to add extra widgets acording to the platform | 13:47 |
dobey | uhm | 13:48 |
mandel | ralsina, lisette and we also have the systray icon, so my questions is more in terms of the usuability of app. Do we want to make it easy to discover how to check for updates? if we do not care, we can go for systray only, otherwise.. | 13:48 |
ralsina | mandel: I am -0 on that | 13:48 |
lisette | mandel: it is pretty full in there already :( | 13:49 |
dobey | ralsina: so why not just package that quniqueapp.py as a dependency in the bundle? | 13:49 |
lisette | mandel: sys tray would be very unlogical | 13:49 |
ralsina | mandel: I don't think we care all that much. If we can put it somewhere visible it's good | 13:49 |
mandel | lisette, ryes, that is why I'm asking :P | 13:49 |
ralsina | lisette: how about in the start menu, next to Ubuntu One? | 13:49 |
mandel | ralsina, we can ask matt waht he wants | 13:49 |
ralsina | dobey: on Linux we don't need it at all | 13:50 |
ralsina | dobey: so there's no need to package it, I think | 13:50 |
lisette | ralsina: what start menu? | 13:50 |
ralsina | lisette: windows's | 13:50 |
mandel | lisette, in the start menu of windows (bottom left) | 13:50 |
mandel | ralsina, I think that is a great idea! | 13:50 |
gatox | nessita, i've improved the tests of this branch as you told me, can you review it when you have a moment? https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/network-detect/+merge/77048 | 13:50 |
lisette | ralsina: aha. hmm. again, not a logical way to look for it, specially cos it starts automatically | 13:51 |
dobey | ralsina: uhm, the thing we ship on windows for people to download and run, is a "package" :) | 13:51 |
ralsina | dobey: ha | 13:51 |
dobey | ralsina: i wasn't talking about linux, only windows | 13:51 |
ralsina | dobey: no it isn't, you linux geek ;-) | 13:51 |
mandel | lisette, there is an automatic check, then matt was a manual check and they also want a looping check | 13:51 |
lisette | ralsina, mandel: do we need permission from a user to look for updates? | 13:51 |
mandel | lisette, to just look, no | 13:51 |
* ralsina wishes bzr had svn:externals | 13:52 | |
mandel | lisette, if I went to a doctor for a prostatic test as many times as they want to check for updates it would be called anal sex and not a medical exam | 13:52 |
* ralsina smacks mandel with the employee manual | 13:53 | |
ralsina | sit mandel, sit! | 13:53 |
lisette | mandel :D | 13:53 |
mandel | ralsina, what!! my metaphor was completelly correct! | 13:53 |
lisette | mandel, ralsina, could we slap a button under settings that says ´Check for program updates´ or similar? I can mock this. | 13:54 |
nessita | gatox: sure | 13:54 |
gatox | nessita, thanks | 13:55 |
ralsina | lisette: if you can mock it, we can take a look and decide if it's worth it. | 13:55 |
ralsina | lisette: that page looks scary enough already :-( | 13:55 |
gatox | nessita, i've to make a little modification in another branch, and i'll be completely dedicated to no mocker branch | 13:55 |
lisette | ralsina: cool | 13:55 |
lisette | or gatox: even better :) | 13:55 |
lisette | gatox, ralsina: although.... | 13:56 |
mandel | lisette, yes, I mean, mock it and it looks ok, I'll do it :) | 13:56 |
lisette | mandel, ralsina: could we add something to the right hand side of the panel? | 13:56 |
ralsina | lisette: you mean, outside the tabs? | 13:57 |
lisette | ralsina: no | 13:57 |
lisette | ralsina: right from bandwidth and file sync settings | 13:57 |
mandel | lisette, ralsina I think at this point is were some quick wireframes with ideas would make things easier :) | 13:57 |
ralsina | lisette: indeed! | 13:57 |
lisette | ralsina, mandel, ok | 13:58 |
gatox | ralsina, what about a corner widget in the QTabWidget for that? | 13:58 |
gatox | ralsina, obviusly tuned | 13:58 |
ralsina | gatox: scary? ;-) | 13:58 |
ralsina | it's giving a rearely-used thing a way too visible place | 13:58 |
gatox | ralsina, ahhhhhhhhh ok then | 13:59 |
ralsina | I mean, most users should never have to actually click that | 13:59 |
gatox | ralsina, i understand | 13:59 |
mandel | ralsina, can I get a review for https://code.launchpad.net/~mandel/ubuntuone-windows-installer/check-old-app/+merge/76867 | 14:06 |
ralsina | mandel: sure | 14:06 |
mandel | ralsina, thx! | 14:06 |
ralsina | mandel: have you actually TRIED it with the old beta installed? | 14:09 |
ralsina | mandel: just curious here ;-) | 14:09 |
mandel | ralsina, yes :) | 14:10 |
ralsina | mandel: cool | 14:10 |
mandel | ralsina, checks if the uid is that and returns the correct value :) | 14:10 |
ralsina | mandel: pep8 problems | 14:11 |
ralsina | mandel: adding to MP | 14:12 |
mandel | ralsina, ok, thx! | 14:16 |
mandel | ralsina, I really need to set up a real machine for running this things.. agg this is so annoying | 14:16 |
ralsina | nessita: how do you feel about adding a source dependency ont his for windows: http://websvn.pardus.org.tr/uludag/trunk/pds/pds/quniqueapp.py?view=log | 14:20 |
nessita | ralsina: looking | 14:21 |
nessita | ralsina: can't we implement that ourselves? | 14:22 |
mandel | ralsina, pep8 issues fixed.. I cannot believe it complained about a wait space at the end of a comment, that is a little too much | 14:22 |
ralsina | nessita: honestly, there is only one way to do it, and that's pretty much it | 14:22 |
nessita | ralsina: if doable, I would recommend doing that ourselves instead of depending on that code | 14:22 |
nessita | ralsina: will this dep will be for both, linux and windows?> | 14:23 |
ralsina | nessita: on linux we can use dbus | 14:23 |
nessita | ralsina: can't we do something like the dbus part on linux, but in windows? I mean, have the control panel listening in a port, using the same code we have for ussoc and u1client, and check if it's in that address? | 14:24 |
ralsina | nessita: that means using yet another TCP port | 14:25 |
ralsina | and making u1cp require another firewall exception | 14:25 |
ralsina | (not really sure about the last thing I said) | 14:25 |
nessita | ralsina: when running u1client I'm asked for only one exception, not two (ussoc and u1client). But I get your point about another tcp port. | 14:26 |
lisette | ralsina, mandel: emailed you | 14:27 |
ralsina | lisette: replied ;-) | 14:27 |
lisette | ralsina: i saw, and snap :D | 14:28 |
ralsina | haha | 14:28 |
ralsina | lisette: posting screenshot to see if there is room or not :-) | 14:29 |
lisette | ralsina: cool | 14:29 |
ralsina | lisette: ok, yes, there seems to be enough room for a button | 14:30 |
ralsina | lisette: but it's starting to get crowded in there | 14:30 |
lisette | ralsina: absolutely | 14:30 |
ralsina | lisette: I am not really happy with adding that. It smells of adding UI for UIs sake | 14:31 |
mandel | ralsina, well, they asked to have a button for that, we can always say no :P | 14:31 |
lisette | ralsina: but hiding it somewhere unfindable is a bit pointless too | 14:31 |
nessita | lisette: can I see the mock as well? | 14:31 |
mandel | ralsina, lisette we also have to remember that we will be checking for updates automatically, and as soon as we add we will get a request of how to disable that | 14:32 |
lisette | ralsina: it can also live in a separate box thingy on the RHS | 14:32 |
lisette | mandel: CAN i disable it? | 14:32 |
mandel | lisette, there will be a way I suppose.. not atm | 14:32 |
lisette | mandel: so is your worry about making it easy to find that that will be the next question? | 14:34 |
lisette | mandel: because we could make a separate box with updates, that has a check box ´automatically check for updates´ | 14:34 |
mandel | lisette, yes, that they will see it check for updates every x minutes and will want to disable that or change the how often it checks that | 14:34 |
* mandel hates options soooooo much | 14:35 | |
nessita | lisette: thanks for the forward, but I see not attachment in that email :-) | 14:35 |
lisette | nessita: didn´t that happen with you last time? weird. will resend | 14:35 |
mandel | ralsina, lisette I fear that we will start adding more and more options that will add very little value | 14:35 |
mandel | ralsina, lisette I'd prefer to speak with matt and try to set that bug as a wont fix and just at a config for the automatic check | 14:35 |
lisette | mandel: so what is wrong with not having a button and checking automatically? | 14:36 |
mandel | lisette, I think we said the same at more or less the same time :) | 14:36 |
lisette | heh | 14:36 |
mandel | ralsina, lisette for me, not button + auto check settings and try to avoid adding any other config options | 14:37 |
lisette | nessita: i did send the wrong one, sent again now | 14:37 |
lisette | mandel: i agree as long as users have no additional control over updating the app | 14:38 |
ralsina | mandel: if we offer "don't bother me" then we need to offer "please bother me" or "check for new versions" somewhere | 14:38 |
nessita | lisette: thanks | 14:38 |
mandel | ralsina, ignoring the ui style, I don't like the idea of too may cnfig settings, the more you add the less the important ones are used | 14:39 |
ralsina | mandel: you can't have a feature go away forever because of a user decision :-) | 14:40 |
ralsina | mandel: any disable needs to offer a way to enable it back. | 14:40 |
ralsina | So, if we can't offer a way to re-enable or to check manually, I would not offer to disable | 14:41 |
ralsina | and if I can't offer a way to disable, I would not offer periodical checks | 14:41 |
nessita | ralsina, lisette: you should consider that the settings being displayed in the settings tab are all file sync related. And we store and retrieve that info via syncdaemon. So, we should not be adding a non-syncdaemon related setting to the syncdaemo configs. If we want to store this auto-check-update setting, we need to implement config management for the controlpanel | 14:41 |
ralsina | nessita: +1 | 14:41 |
nessita | ralsina, lisette: and that is more complex, but diable, since currently we have no config management for the controlpanel | 14:41 |
ralsina | nessita: OTOH, this is a windows-specific feature, right? | 14:42 |
nessita | ralsina: well, it depends | 14:42 |
nessita | ralsina: we can offer that in linux, with different implementation | 14:42 |
ralsina | on linux, we assume the user has a package manager | 14:42 |
nessita | ralsina: but is certainly something the ubuntuone-installer project should handle | 14:42 |
nessita | (in both cases, I would say) | 14:42 |
ralsina | nessita: really? u1-installer adds a PPA. apt handles it from there, right? | 14:43 |
nessita | ralsina, lisette: I will recommend going, for now, only with the 'Check for udpates' button | 14:43 |
ralsina | nessita: adding that button for linux too? | 14:43 |
nessita | ralsina: no, only for windows (but in another location) | 14:43 |
ralsina | nessita: we don't have windows-specific UI yet either :-/ | 14:44 |
nessita | ralsina: yeah, but we can do multiplatform implementation, and maybe have a platform specific tab | 14:44 |
nessita | ralsina: we have linux-specific stuff that we'd need to add as well, no? | 14:45 |
nessita | when we consider going full with QT on every platform | 14:45 |
mandel | nessita, +1 for the platform specific tab, seems cleaner | 14:45 |
ralsina | and what would be in that tab? | 14:45 |
nessita | lisette: what do you think? ^ | 14:45 |
nessita | ralsina: in which OS? | 14:45 |
ralsina | and what would we call it "other settings?" :-) | 14:45 |
ralsina | nessita: on each OS. I only know of this button so far | 14:46 |
nessita | ralsina: the name is up to design crowd :-D But, if not a a tab, we have have a multiplaform widget | 14:46 |
nessita | and embed that in an existent tab (though all tabs are pretty crowded) | 14:46 |
mandel | nessita, ralsina, well, here we will have this button plus the seeting for auto-checking | 14:46 |
=== rodrigo__ is now known as rodrigo_ | ||
ralsina | we can have the widget in the design and hide it n Linux, that's not very difficult | 14:46 |
nessita | ralsina: is not difficult but is dirty :-) | 14:47 |
ralsina | nessita: there are worse things. I really don't like the idea of a whole new tab for such rarely used stuff | 14:47 |
nessita | ralsina: let's have as a goal to avoid "if sys.platform == 'win32'" in places other than a module/__init__.py | 14:47 |
nessita | ralsina: we can have a multiplatform widget, instead of a tab | 14:48 |
mandel | nessita, you can do, from config import os_config_tab | 14:48 |
nessita | ralsina: agains, not sure where that will be displayed... | 14:48 |
ralsina | nessita: I am not sure I understand what you mean by that. Implement this for Linux? | 14:48 |
mandel | nessita, or something like that | 14:48 |
mandel | and on linux get none and not add it | 14:48 |
nessita | ralsina: no, have multiplatform widgets with paltform specific settings | 14:48 |
nessita | ralsina: that widget can be a tab or a frame | 14:48 |
ralsina | ok | 14:49 |
nessita | or a button | 14:49 |
ralsina | so, keep it in settings, and make it appear only on windows ;-) | 14:49 |
nessita | ralsina: no, no keeping in settings, the tab is crowded already and shows only file sync config | 14:49 |
ralsina | nessita: so, not there, not in a new tab? Where? | 14:49 |
nessita | ralsina: I would recommend a new tab (but what I said before is that not necessarily has to be a new tab) | 14:50 |
nessita | or the account tab, is the less crowded tab | 14:50 |
nessita | account info* tab I meant | 14:50 |
nessita | or, for example, what about the button in the footer area? | 14:51 |
ralsina | nessita: account info tab: even less related than sync settings. Button in footer area: too prominent? | 14:51 |
mandel | that one is also quite full | 14:51 |
mandel | I mean the footer | 14:51 |
nessita | ralsina: yeah, maybe. A new tab sounds more appealing... do we have any other windows specific stuff we can offer there? | 14:52 |
ralsina | nessita: none comes to mind | 14:52 |
* alecu needs to be afk for a some minutes. | 14:52 | |
ralsina | which is why I am not convinced offering this at all is a good idea | 14:53 |
mandel | ralsina, I think we should ask matt, he requested it, but that does not mean it has to me done | 14:53 |
ralsina | mandel: exactly | 14:53 |
ralsina | matt doesn't seem to be around today though. So I say we stop until tomorrow | 14:53 |
nessita | ralsina: +1 | 14:54 |
mandel | ralsina, smae thing with autoupdate settings, no config by default, we can add the feature but do not add the config for it | 14:54 |
mandel | there are lots of apps that do not do it and no one complains | 14:54 |
mandel | ralsina, nessita last shot in the dark I have, we could add a tools dir in the start menu with small commands like this Check Update etc.. | 14:55 |
ralsina | mandel: if we don't bother the user too often, and/or we do it in an unobtrusive manner, I think it's ok to add the periodical check. But let's talk about it tomorrow | 14:55 |
nessita | mandel: -1 to that (but let's keep talking tomorrow) | 14:56 |
mandel | nessita, ralsina ok.. I'll move to other things (like setting a real ubuntu machine for pylint, and running tests for u1-client) | 14:57 |
ralsina | mandel: have fun :-) | 14:57 |
mandel | and some work on the feature alecu and I were working | 14:58 |
ralsina | mandel: except for the pep8 errors I mentioned, check-old-app looks ok to me | 14:58 |
mandel | ralsina, great \o/ | 14:59 |
mandel | ralsina, I already fixed them by the way | 15:01 |
ralsina | mandel: +1ing then | 15:01 |
mandel | ralsina, bien! | 15:02 |
gatox | nessita, ralsina this branch is ready too (improves in the code and tests.... with this all my branches are up to date and i can move on to work on no mocker branch): https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 15:03 |
nessita | gatox: ack | 15:03 |
lisette | mandel, ralsina: i was away so may be not 100% up to speed with your thinking, but i think file sync settings are really program settings, so if anything i would like to group them with any other program settings | 15:03 |
ralsina | gatox: queuing you | 15:03 |
gatox | nessita, brb....... leave the coffee shop for a while to eat | 15:03 |
gatox | ralsina, ^ | 15:04 |
ralsina | lisette: I think we need to think a bit about how we really want this feature to work | 15:04 |
mandel | lisette, we are going to talk with matt and try to remove all that hehe | 15:04 |
lisette | ralsina: i agree, and not put it in a random place if we need it in there at all | 15:04 |
mandel | ralsina, nessita since matt is more in your area, shall I send an email to start the conversation to ubunet? | 15:05 |
ralsina | mandel: yes, describe the issue and ask for opinions | 15:06 |
mandel | ralsina, do you remember the other bug you assigned me today, I copied the wrong bug number :( | 15:17 |
* mandel is stupid | 15:17 | |
ralsina | mandel: let me check the backlog | 15:18 |
mandel | thx | 15:18 |
ralsina | mandel: 845659 and 852125 | 15:19 |
mandel | ralsina, gracias! | 15:19 |
mandel | ralsina, message sent, I'll me away setting the linux machine to get thing done properly with lint | 15:34 |
ralsina | mandel: cool, thx | 15:34 |
mandel | so kinda EOD for me | 15:34 |
alecu | mandel, ping | 15:37 |
mandel | alecu, pong | 15:40 |
alecu | mandel, two things: | 15:43 |
dobey | lunch time, bbiab | 15:43 |
alecu | 1) I just found a light gray laptop sleeve, with *orange* interior. | 15:43 |
alecu | is it yours? or perhaps it's diego's! | 15:43 |
mandel | alecu, that is mine, hehe | 15:44 |
mandel | alecu, although the orange does fit gatox hahaha | 15:44 |
alecu | yeah, hahaha | 15:44 |
ralsina | argh: "On Windows two local servers can listen to the same pipe at the same time, but any connections will go to one of the servers." | 15:44 |
alecu | mandel, well, I'll give it you back on december, since I suspect shipping would be more expensive than the sleeve itself. | 15:45 |
ralsina | mandel: for the 2.0 version of our talk ^^ | 15:45 |
alecu | mandel, 2) I've got some more ideas on the "mystery project" | 15:45 |
alecu | mandel, were you able to make some progress on it? | 15:45 |
mandel | ralsina, hahah that is classic, worst thing, I'm not surprised | 15:45 |
ralsina | mandel: it's like "let's see how we can make this maximally confusing!" | 15:46 |
mandel | alecu, yes, I have some code in C, but I want to port it to b using the tor** lib :) | 15:46 |
alecu | mandel, that sounded "maximally mysterious" | 15:47 |
mandel | ralsina, I had a nice chat about or talk while waiting for the bus, tunrns out the tried to use pyinotify recursivelly and then were amazed that 'el gallego tenia razon!!!' hehe | 15:47 |
mandel | alecu, I did my best :P | 15:47 |
alecu | mandel, I was thinking of adding the three methods that you need to the jsonrpc interface, so we would initially get three calls per file to that interface, so the C or C++ code (or b!) is smaller. | 15:49 |
alecu | mandel, and then if there are performance issues we can optimize it later. | 15:50 |
mandel | alecu, sounds good | 15:53 |
mandel | alecu, b == be :P | 15:53 |
mandel | alecu, young cool kids like me use this, hehe | 15:53 |
alecu | mandel, oh, cool. And what's the tor** lib? | 15:53 |
mandel | alecu, some missing * hehe | 15:54 |
mandel | alecu, I need to go for some time to try and set a machine with linux, will be here in a couple of hours | 15:55 |
nessita | mandel: still pep8 issues for: https://code.launchpad.net/~mandel/ubuntuone-windows-installer/check-old-app/+merge/76867 | 15:56 |
mandel | nessita, ok, will fix ones I have the linux machine, dammed I need to sort out the way I work to loose less time :( | 15:59 |
mandel | will be back in a couple of hours | 15:59 |
nessita | mandel: ack | 15:59 |
gatox | back! | 16:10 |
ralsina | nessita: I have a "don't start u1cp twice" branch ready. I am not sure on how to add tests to a piece of it, though, could you give me a hand? | 16:42 |
nessita | lunchtime! | 16:42 |
ralsina | nessita: or go have lunch :-) | 16:42 |
nessita | ralsina: sure, show it to me | 16:42 |
ralsina | nessita: https://code.launchpad.net/~ralsina/ubuntuone-control-panel/unique_snowflake/+merge/77976 | 16:42 |
ralsina | nessita: if it says there is a new diff, ignore it, that's just changing EOLs | 16:42 |
ralsina | nessita: the untested part is the UniqueApplication class | 16:44 |
ralsina | which is most of the branch, of course ;-) | 16:44 |
nessita | ralsina: as a side note, I will not add "Deprecated, this is now the default behaviour." to the option, since we're using the same -qt executable for both plaftforms | 16:45 |
ralsina | nessita: hmmmm I just want to keep that option there | 16:46 |
ralsina | nessita: because of things like start menu entries from older versions, etc | 16:46 |
nessita | ralsina: not sure what you mean | 16:47 |
nessita | ralsina: what I'm saying is that I don't think you should remove that code... | 16:47 |
ralsina | nessita: hmmmm | 16:47 |
ralsina | but now, it makes no sense, on windows, to start it without the icon | 16:47 |
nessita | ralsina: start() should not alwats start iconofied, think in the lunux | 16:47 |
nessita | ralsina: but in linus it does | 16:47 |
nessita | linux* | 16:48 |
ralsina | nessita: it starts with the icon on notification area, not iconified | 16:48 |
ralsina | for iconified you use --minimized | 16:48 |
nessita | ralsina: on l;inux, the control panel should not add an icon to the systray | 16:48 |
nessita | ralsina: another project will add it (ubuntuone-installer) | 16:48 |
ralsina | nessita: then it should not have the option either :-) | 16:48 |
dobey | nessita: we will what? | 16:49 |
dobey | we are not putting any icons in any notification are on linux, thank you very much | 16:49 |
ralsina | exactly | 16:49 |
nessita | ralsina: my point exactly, control panel should not create a icon = TrayIcon(window=window) in every platform | 16:50 |
ralsina | if we should never put it there on linux, and we should always put it on Linux, then there should not be an option | 16:50 |
nessita | ralsina: so, the start() method, that is multiplatform, should not call TrayIcon() all the time, but only when an option is passed | 16:51 |
ralsina | the second "linux" there is windows ;-) | 16:51 |
nessita | ralsina: and I think you meant WIndows in the second Linux | 16:51 |
nessita | right | 16:51 |
dobey | nessita: only when on windows, not when an option is passed | 16:51 |
nessita | dobey: I meant messaging entry | 16:51 |
nessita | dobey: start() is multiplatform, so it needs an option (named parameter) | 16:51 |
nessita | ralsina: you can safely remove the option from the bin/script though | 16:52 |
nessita | and from the main()'s | 16:52 |
ralsina | nessita: no, I can't remove it from the script | 16:53 |
dobey | nessita: i don't think so. i think we should make a platform-specific start() that does platform-specific stuff, and multiplatform start() should always call the platform-specific start() for the platform it's running on, and platform-specific bits should be done within it | 16:53 |
nessita | ralsina: why not? | 16:53 |
ralsina | nessita: because it's used by start menu options on previous release | 16:53 |
ralsina | nessita: that's why I deprecate it and turn it into a no-op | 16:53 |
nessita | ralsina: ok. But the start() method should not create a systray icon always | 16:54 |
ralsina | +1 on making start platform-specific | 16:54 |
nessita | ralsina: you can move that code in start() back to main(), but last time you complained about not being able to test it, remember? will that be a probolem for you again? | 16:55 |
ralsina | nessita: pretty much, yes | 16:55 |
ralsina | nessita: but I will make it work | 16:56 |
nessita | ralsina: ok. So, going back to your question: | 16:56 |
nessita | ralsina: what's the issue you're having with testing the UniqueApplication class? | 16:56 |
ralsina | nessita: that I don't know how to do meaningful tests for it | 16:57 |
Fury1306 | Hi! Will there any significant changes to contact sync with oneiric (Will it start working again?). I just saw, the status page was updated, but the saying is just the same as before (End of August). Currently working on Hardware Upgrades and client changes. | 16:57 |
nessita | ralsina: well, we certainly can't build test that uses the real QtNetwork stuff, so we need to patch all that. And you may need to patch the QApplication as well, otherwise I think you will not be able to run the test and creating an instance of UniqueApplication | 16:58 |
dobey | Fury1306: the problem with the client changes is we have to get SRUs approved for older versions of ubuntu, and everyone has to install the update and restart their desktopcouch | 16:58 |
ralsina | nessita: right | 16:58 |
ralsina | and that means all that's run is an if | 16:58 |
nessita | ralsina: so, create fakes for QtGui.QApplication, QtNetwork.QLocalServer and QtNetwork.QLocalSocket | 16:59 |
nessita | ralsina: why is an if? | 16:59 |
dobey | Fury1306: so it should get better but we can't really guarantee any sort of time frame for people actually installing the update unfortunately | 16:59 |
ralsina | nessita: ok, I can check that aboutToQuit is connected, and what happens if waitFrConencted succeeds/fails | 16:59 |
ralsina | I have to patch sys too, I guess? | 16:59 |
nessita | ralsina: yeap. You should also test: that cleanup removes the key, that if socket.waitForConnected returns True, exit is called, if not, start listening, and the returned value from listen is the one used for self.server.removeServer | 17:01 |
ralsina | nessita: thx | 17:02 |
nessita | ralsina: also, add tests for socket.connectToServer properly called, self.server.newConnection.connect properly called (by properly I mean proper params are passed) | 17:02 |
ralsina | nessita, dobey: a reason to add a notification icon n Linux -- http://agateau.wordpress.com/2011/07/19/statusnotifieritem-for-qt-applications/ | 17:10 |
dobey | ralsina: no. | 17:11 |
nessita | ralsina: I think we need to distinguish when installing on KDE from gnome | 17:11 |
nessita | ralsina: we certainly don't want soimething in the systray in gnome | 17:11 |
ralsina | nessita: read the link, it's short ;-) | 17:11 |
dobey | nessita: we don't need to do that at all | 17:11 |
nessita | dobey: no? | 17:11 |
dobey | nessita: unity is neither gnome nore kde, but is our main target | 17:12 |
nessita | ralsina: can you please summarize it for me? I'm having lunch, and triaging tons of bugs (I'd like to finish triaging before leaving) | 17:12 |
ralsina | starting in Oneiric, Qt's QSystray app creates appindicators | 17:12 |
nessita | dobey: right, by gnome I meant unity and/or ubunt classic desktop | 17:12 |
dobey | also, if people want an indicator for status of u1, there is one already | 17:12 |
dobey | nessita: ubuntu classic is unity 2d now; so "unity" :) | 17:13 |
nessita | ok then | 17:13 |
ralsina | And transparently, that works correctly on KDE (which uses the same protocol as app indicators) | 17:13 |
dobey | nessita: and indicators don't work in gnome-shell afaik | 17:13 |
ralsina | The fix is done at a Qt level, so the app just uses QSystrayIcon | 17:13 |
dobey | wow windows 7 is completely stupid | 17:17 |
ralsina | Hey, we are in ars technica! http://arstechnica.com/open-source/news/2011/10/hands-on-new-ubuntu-one-cloud-storage-client-for-windows.ars?utm_source=rss&utm_medium=rss&utm_campaign=rss | 17:19 |
=== beuno is now known as beuno-lunch | ||
=== gatox_ is now known as gatox | ||
=== beuno-lunch is now known as beuno | ||
gatox_ | nessita, ralsina mandel alecu it seems i'm having some serious issues with the connection at this bar.... if i'm not responding to the chat, please send me an e-mail to gmail (i'm connected with the phone with 3G there) | 18:25 |
ralsina | gatox_: ack | 18:26 |
alecu | gatox_, the problem with bars is usually the alcohol, not the connections! | 18:26 |
nessita | gatox_: ack | 18:26 |
alecu | gatox_, don't drink and code! | 18:26 |
gatox_ | alecu, jejejej i'm an orange juice drinker only | 18:26 |
alecu | hahahaha | 18:26 |
dobey | alecu: s/alcohol/concoctions/ | 18:26 |
nessita | all: I'm leaving to the university, I was invited to give the TDD talk to the students of Software Engineering | 18:27 |
alecu | no conconut for me, sir. | 18:27 |
nessita | anyone need anything before I go? | 18:27 |
gatox_ | nessita, no thanks! | 18:27 |
gatox_ | nessita, go and evangeliza! :P | 18:27 |
nessita | gatox_: YEAH | 18:28 |
nessita | ok, bye all! | 18:28 |
ralsina | gatox_, alecu: feel free to review this one https://code.launchpad.net/~ralsina/ubuntuone-control-panel/unique_snowflake/+merge/77992 | 19:12 |
ralsina | keeping in mind it's somewhat arguable whether I am doing the right thing or not ;-) | 19:12 |
gatox_ | ralsina, ok, on it | 19:12 |
ralsina | gatox_: I mailed explaining the idea behind the branch so we don't block or approve it for bad reasons | 19:16 |
gatox_ | ralsina, ok! | 19:18 |
ralsina | gatox_: hold on, I missed a push :-/ | 19:19 |
ralsina | grmbl | 19:20 |
gatox_ | ralsina, ok:P | 19:20 |
alecu | ralsina, a small typo on: "Remve the socket when we die." | 19:41 |
ralsina | alecu: thx | 19:43 |
alecu | ralsina, testing IRL on linux, I get two opened control panels. | 19:47 |
ralsina | alecu: there was a missing push :-( | 19:47 |
ralsina | alecu: are you on revno 236? | 19:48 |
joumetal | u1 lucid lightlies has connection problems. is it a known issue? | 19:48 |
alecu | ralsina, I rebranched less than 5 minutes ago, after seeing your comment on the missing push | 19:48 |
ralsina | alecu: hmmmm let me check then | 19:49 |
ralsina | alecu: confirmed | 19:49 |
ralsina | alecu: I'll fix it | 19:49 |
ralsina | alecu: was not using the UniqueApplication on linux. Will have a fix in a bit | 19:50 |
ralsina | Oh, great this implementation doesn't work on Linux for some reason. Crap | 19:59 |
alecu | ralsina, I think we should defer the linux implementation to a different branch. | 20:00 |
ralsina | alecu: yes, and do it using dbus just like in gtk | 20:00 |
alecu | ralsina, I'm testing it on windows and it works fine. | 20:00 |
ralsina | yes, windows works fine | 20:00 |
alecu | ralsina, one issue, probably there before your branch: | 20:01 |
ralsina | the fun part is I had a first implementation that worked on linux and nt on windows :-) | 20:01 |
alecu | when the control panel is minimized (as opposed to closed), clicking in the tray icon does not restore it. | 20:01 |
alecu | ralsina, ^ | 20:01 |
ralsina | alecu: yes, that is pre-branch | 20:01 |
alecu | ralsina, but if it's closed, it works as expected. | 20:01 |
alecu | ralsina, oh, ok. | 20:01 |
ralsina | I could make it so minimizing minimizes to tray, or make it restore the window if it's minimized | 20:02 |
alecu | ralsina, that bit me because I minimized the control panel, and expected that starting another instance would restore the new one. (and perhaps bring it to front if it was just on the background) | 20:03 |
alecu | sorry, "the new one" -> "the old one" | 20:03 |
ralsina | alecu: bringing to front is bound not to work because of focus stealing policies | 20:03 |
alecu | ralsina, how so? | 20:04 |
ralsina | alecu: you can't just pop a window to the front, because then you start typing in it | 20:05 |
ralsina | alecu: so the window managers don't let you do it | 20:05 |
ralsina | alecu: http://en.wikipedia.org/wiki/Focus_stealing#Testing_whether_a_window_manager_allows_focus_stealing | 20:06 |
alecu | ralsina, probably not *every* wm, but some do. | 20:06 |
alecu | ralsina, for instance, I'm typing on xchat. I click on the unity icon of thunderbird. | 20:06 |
ralsina | alecu: let's say "most wms we care about prevent focus stealing". Including metacity, compiz+whatever, kwin and windows :-) | 20:07 |
ralsina | alecu: that's different | 20:07 |
alecu | ralsina, and since TB is already started, it's brought to the front. | 20:07 |
ralsina | alecu: it's done by unity, not by thunderbird | 20:07 |
alecu | ralsina, yes, you are right. But anyway, the wm/launcher combo still notifies me of the app wanting my input. | 20:08 |
ralsina | alecu: yes | 20:09 |
alecu | ralsina, "sleep 5; thunderbird" ends up with the blue triangle on the unity launcher | 20:09 |
alecu | ralsina, and I suspect I would get the blinking task item on windows | 20:09 |
ralsina | alecu: probably | 20:09 |
ralsina | alecu: could you file a bug for it? | 20:09 |
duanedesign | does the windows client create a link to the Ubuntu One folder under All Users on a multi log-in PC? | 20:09 |
ralsina | assign to me | 20:09 |
alecu | sure! | 20:10 |
ralsina | duanedesign: shouldn't | 20:10 |
duanedesign | ralsina: ok, what i thought but wanted to be sure before i responded :) | 20:10 |
ralsina | duanedesign: :-) | 20:11 |
* joumetal just uses old nightlies version in lucid and wheezy | 20:12 | |
alecu | ralsina, I've approved your branch, but just noticed a few lint errors on it. | 20:24 |
alecu | ralsina, also, here's the bug for the focus thieves: bug #865688 | 20:24 |
ubot4 | Launchpad bug 865688 in ubuntuone-control-panel "Minimized window not restored (but yes if closed) (affects: 1) (heat: 6)" [Low,New] https://launchpad.net/bugs/865688 | 20:24 |
ralsina | alecu: yes, remove your vote, I am doing some rather large changes because of the "doesn't work on linux" bit ;-) | 20:24 |
ralsina | alecu: thanks! | 20:24 |
ralsina | alecu: I switched it back to WIP | 20:25 |
* alecu does the kinder-run | 20:34 | |
ralsina | EOD for me | 20:34 |
ralsina | see you all tomorrow | 20:34 |
=== m_conley is now known as m_conley_away | ||
dobey | later all | 21:57 |
DanRabbit | urbanape: hey dude, just got the files app in test flight. I'm glad the Facebook-like design didn't land. This looks nice and simple. Is there any assets I can help you guys with for the visual style or anything? | 22:11 |
=== adorilson is now known as eu | ||
=== eu is now known as Guest24773 | ||
=== Guest24773 is now known as adorilson | ||
karni | Night guys o/ | 23:33 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!