| gary_poster | benji danilos gmb, call in 2 | 12:28 |
|---|---|---|
| gmb | ok | 12:28 |
| danilos | ack | 12:29 |
| gary_poster | taking kids to school and going to vote in about 5 or 10 minutes | 12:45 |
| gary_poster | gmb, yay, LEP moving along! Cool. | 13:22 |
| gmb | gary_poster: Indeed. Matthew's happy with it, and I've said that I'm happy to consult in an almost-but-not-quite-Shuttleworth way. | 13:22 |
| gary_poster | lol, gmb | 13:22 |
| gmb | (The $500M being the not quite) | 13:23 |
| benji | well, I figured out why it's happening; now to figure out what to do about it | 13:57 |
| gary_poster | gmb, you up for a small lazr.restful branch? https://code.launchpad.net/~gary/lazr.restful/bug871944/+merge/78976 . The one liner LP integration follow-up branch is https://code.launchpad.net/~gary/launchpad/bug871944/+merge/78977 | 14:11 |
| gmb | gary_poster: I'm going to grab a late lunch but then I'll be happy to take a look | 14:12 |
| gary_poster | cool thanks gmb | 14:12 |
| gmb | gary_poster: approved. | 15:24 |
| gary_poster | thank you gmb | 15:25 |
| gmb | danilos, benji, gary_poster: Do any of you chaps have time to take a look at https://code.launchpad.net/~gmb/launchpad/do-it-by-default-bug-872225/+merge/78948 for me? | 15:27 |
| gmb | (The cobbler's children and all that) | 15:27 |
| gary_poster | :-) gmb a review seems wellin line with me having to hold a baby for a few minutes before my wife returns. I'll be hapy to do it | 15:28 |
| gary_poster | happy even | 15:28 |
| gmb | gary_poster: Thanks :) | 15:29 |
| gmb | (This is how it starts; muttering about JS to the baby) | 15:29 |
| danilos | "now looky-look, here's some crappy JS code by Graham, what do you say, we puke on it?" | 15:30 |
| gary_poster | lol | 15:31 |
| gary_poster | gmb, it looks fine. I have a few random thoughts. typing is slow with one hand. that was one of them. another is that I wonder if the "load all comments" links ought to disappear or gray out or change to (all comments loaded) on success, but that might already happen, and is probably something to do as another branch, if at all. Similarly, we have a nice little yui integration test story that you could use, but | 15:38 |
| gary_poster | but anyway, appriving as is | 15:38 |
| gary_poster | o | 15:38 |
| gmb | gary_poster: The links already disappear on success. I think I'll do the integration tests in a separate branch to go with removing the feature flag. | 15:39 |
| gary_poster | cool gmb, approved | 15:39 |
| gmb | Thanks. | 15:39 |
| benji | gary_poster: care to review my bug 846163 branch? https://code.launchpad.net/~benji/launchpad/bug-846163/+merge/79013 | 17:38 |
| _mup_ | Bug #846163: bug filing notice is removed before the user can read it <regression> <ubuntu-qa> <Launchpad itself:In Progress by benji> < https://launchpad.net/bugs/846163 > | 17:38 |
| gary_poster | ok benji | 17:39 |
| benji | cool | 17:39 |
| gary_poster | benji, nice fix. | 17:48 |
| gary_poster | (1) have you clicked around other places where there are notifications (I'm not sure of other examples, but I'm sure there are some) just to make sure things seem ok there too? | 17:48 |
| gary_poster | (2) Your cover letter says that "notifications are only removed if an explicitly specified empty list of notifications is returned in a response," but the code seems to say the opposite: you always return a list in the .py file, presumably not clearing the notifications, and this code seems to indicate that "null" is the marker. | 17:49 |
| gary_poster | 31+ if (notificaxns !== null) { | 17:49 |
| gary_poster | 32+ module.display_notifications(notificaxns); | 17:49 |
| gary_poster | 33+ } | 17:49 |
| gary_poster | Am I misunderstanding? | 17:49 |
| benji | gary_poster: (2) the function to get a header returns null if there was no header, so that's actually checking to see that no header was specified, the other check is for the string "null" (JSON) | 17:50 |
| benji | (1) nope, that's a good idea, I'll do that | 17:51 |
| gary_poster | benji, #2: ah! Right. That's a subtler and nicer fix than I realized. OK, approving. | 17:53 |
| gary_poster | benji, approved. | 17:56 |
| benji | cool, thanks | 17:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!