/srv/irclogs.ubuntu.com/2011/10/11/#ubuntu-mozillateam.txt

micahgjoelesko: unfortunately, I'm out of time to do a proper review for your branch and iterate, but I will give you credit for whatever you've done for the upload, I"ll also comment on what changes I made05:41
micahgjoelesko: we'll get into a routine for P, it's this initial huge merge that's been why I've pushed it off, future merges should be much simpler to review05:42
micahgjoelesko: I"m even happy to have you track the beta channel if you like until we get close to the end05:44
micahgchrisccoulson: FYI, I just pushed up a new seamonkey head branch to be the new lp:seamonkey08:31
micahgchrisccoulson: you around?09:13
chrisccoulsonmicahg, yeah, i'm around now09:13
micahgchrisccoulson: so, I just want to confirm about seamonkey, we're switching to a single binary package with upstream defaults for bundled libs09:14
chrisccoulsonmicahg, yeah, makes sense09:14
micahgok, lintian's unhappy, but not fatally so with the package, I guess we can fix that for P09:14
micahgI pulled in the 4 patches from thunderbird for various build failures, I hope I got them all09:15
micahgchrisccoulson: does your new tarball build system use /tmp?  I had that when creating the seamonkey tarball09:33
chrisccoulsonmicahg, no, it doesn't use that09:38
micahghmm...why did the seamonkey tarball use /tmp then?09:38
chrisccoulsonmicahg, does the new seamonkey drop the patch which renamed the binary to seamonkey2?09:38
micahgwe never had such a patch in the distro09:38
chrisccoulsonmicahg, we did. i'm not sure why we did though09:39
micahgyou mean the upstream binary? yes09:39
chrisccoulsonmicahg, http://bazaar.launchpad.net/~mozillateam/seamonkey/seamonkey.head/view/246/debian/patches/seamonkey-fsh.patch09:42
chrisccoulsonthat patch has gone now, which is good (it shouldn't really have ever been there)09:42
chrisccoulsonbut it means that the profile location moves09:42
micahgchrisccoulson: oh :(09:43
micahgchrisccoulson: is there a quick fix? (I can get the upload rejected)09:43
chrisccoulsonmicahg, yeah, you just need to check if ~/.mozilla/seamonkey-2.0 exists, and move it to ~/.mozilla/seamonkey if it does09:44
chrisccoulson(and if ~/.mozilla/seamonkey already exists, just move it to ~/.mozilla/seamonkey.old or something)09:44
micahgchrisccoulson: do we still need LD_LIBRARY_PATH hacks with this version?09:45
chrisccoulsonmicahg, not sure if seamonkey has been updated to use the glue to load libxul09:46
chrisccoulsonif it has, then you don't need it. if it hasn't, then you do09:47
micahgok, will leave it for now09:47
chrisccoulsonthunderbird needs it still09:47
micahgchrisccoulson: hmm, the old version seems to be using the seamonkey dir as well09:59
micahgchrisccoulson: hmm, the old version seems to be using the seamonkey dir as well10:10
chrisccoulsonhmm, i'm a bit surprised about that10:10
micahgme too, I thought that's why we changed that in the first place10:11
chrisccoulsonmicahg, what about lucid -> natty?10:12
micahgchrisccoulson: don't know10:12
chrisccoulsoni know we have some releases where it's been renamed to seamonkey-2.0, as i keep seeing it in bug reports10:12
micahgyeah, I can check that later10:13
micahgthe binary is renamed, but uses the seamonkey profile dir in oneiric10:14
micahgI guess if there's an upgrade issue, I can push out an SRU10:14
chrisccoulsonmicahg, oh, yeah, i see now10:15
chrisccoulsonok, that's a bit weird10:15
chrisccoulsonfirefox uses the app name as the profile folder name too10:15
chrisccoulsonso we're ok there10:15
chrisccoulsonsorry about the noise ;)10:15
micahgheh, ok, will ask for review/acceptance then...10:16
micahgchrisccoulson: wasn't planning on sleeping before sunrise anyways I guess :)10:16
micahgchrisccoulson: so, when I was generating the tarball, it couldn't find the tag for 2.4.1 in the l10n repos10:27
chrisccoulsonfor any specific locales?10:28
micahgall10:28
chrisccoulsonhmmm, i just grabbed en-GB, and it's there10:28
micahg:(, maybe I should have the tarball rejected and try to regenerate?10:28
chrisccoulsonpossibly10:28
chrisccoulsonalso, debian/config/branch.mk should be fixed to set CHANNEL to "release", and drop "NO_AUTO_REFRESH_LOCALES = 1"10:30
chrisccoulsonthe latter is used on nightlies to prevent the list of shipped translations being auto refreshed10:30
chrisccoulsonif you remove that, you should get a warning about the list of translations being out-of-date10:31
micahgchrisccoulson: I just ran ./debian/rules get-orig-source DEBIAN_TAG=SEAMONKEY_2_4_1_RELEASE and I got no warning10:33
chrisccoulsonah, you get it when you try to build the source package (as it checks in the clean target)10:33
micahgah, ok, so I need to build the source first?10:34
chrisccoulsonyeah10:35
chrisccoulsoni'm just trying it here as well10:35
micahgNo description for be at debian/build/refresh-supported-locales line 145, <$file> line 1.10:35
chrisccoulsonmicahg, yeah, this is because it doesn't yet have a list of languages :)10:36
chrisccoulsonit will helpfully get locale decriptions from langpack-o-matic though :)10:37
chrisccoulsonoh, you're right about only having the nightly branding10:40
chrisccoulsoni never knew that before ;)10:40
micahgyeah, that's one reason I didn't care so much about non-bundled libs before10:41
micahgchrisccoulson: still not sure how to regenerate the locale list10:42
chrisccoulsonmicahg, debian/rules refresh-supported-locales TARBALL=/path/to/tarball LANGPACK_O_MATIC=/path/to/langpack-o-matic should do it10:43
chrisccoulsonwhich you can get from lp:langpack-o-matic10:43
chrisccoulsonmicahg, i just found another issue with the tarball though10:44
chrisccoulsoncreate-tarball needs this - http://bazaar.launchpad.net/~mozillateam/thunderbird/thunderbird-trunk.head/revision/457?remember=455&compare_revid=45510:44
chrisccoulsoni wish i had time to review this too :)10:44
micahghmm, well, it seemed to build the mail files as well, but I can regenerate and see what happens10:46
micahgah, but it might have pulled the tip instead of the tag of the branch...10:46
chrisccoulsonyeah, that's what it's doing here10:47
micahgchrisccoulson: so, I need to redo the tarball before redoing the locales?10:50
chrisccoulsonmicahg, yeah, i think so. what does suite/config/version.txt contain in your tarball?10:51
chrisccoulsonif it's 2.4.1, then it's ok10:51
chrisccoulsonbut i've got 2.4 here, which is the current tip10:51
chrisccoulsonmicahg, actually10:52
micahgit's 2.4.110:52
chrisccoulsonit has updated to the correct version here now10:52
chrisccoulsonperhaps --comm-rev isn't actually needed?10:53
chrisccoulsoni got the impression that client.py just did a "hg update" without that10:53
micahgI think it's the default maybe?10:53
chrisccoulsonok, that's ok for now, but we should pass --comm-rev in future builds, just to make sure we really do get the right version :)10:53
micahgok, I'll include that change in the upload10:54
chrisccoulsonthanks10:57
chrisccoulsonyeah, i think it might have been a stroke of luck that we got the right version :)10:57
chrisccoulsonit does just do "hg update -r default"10:58
chrisccoulsonmicahg, ok i managed to create a tarball here with all the translations in it10:58
micahgchrisccoulson: so, I need a new tarball?10:59
chrisccoulsonmicahg, if they're not in the current one10:59
chrisccoulsonperhaps we can leave this until the next version though10:59
chrisccoulsonseeing as it's already accepted anyway10:59
micahgyeah, they seem to be there, so I think we're ok10:59
micahgI'm testing a build now to make sure that the langpack binaries aren't empty, then I'll upload11:00
chrisccoulsondid you manage to generate everything ok?11:00
micahgyeah11:00
* micahg adds a README.Source note11:01
chrisccoulsonmicahg, yeah, i also changed this in firefox recently to make it all a single step - http://bazaar.launchpad.net/~mozillateam/firefox/firefox-trunk.head/revision/100211:03
micahgI'll have to fix that later11:04
chrisccoulsonso now, running debian/rules refresh-supported-locales will update the control file too11:04
* micahg wishes Firefox 4+ supported -jX11:18
micahgchrisccoulson: build failed :( *** No rule to make target `/run/shm/seamonkey-2.4.1/build-tree/mozilla/l10n/be/suite/installer/unix/README11:37
chrisccoulsonmicahg, ah, you'll need to leave that off for now then11:38
micahgwhich?11:38
chrisccoulsonthe problem is that the EXCLUDE list in create-tarball hasn't been updated for seamonkey11:38
chrisccoulsonso it's missing the suite/ folder for each locale11:38
micahgah, ok, well, we'll fix for P11:39
* micahg -> zzz11:47
micahgBTW, thunderbird isn't happy moving 20k messages between IMAP folders...12:22
micahg23006 micah     20   0 9337m 4.6g  15m S    0 29.6 182:01.85 thunderbird-bin12:22
=== m_conley_away is now known as m_conley
m_conleychrisccoulson: ping13:18
FernandoMiguelanyone reproduces this https://code.google.com/p/chromium/issues/detail?id=99835&thanks=99835&ts=131833961513:28
joeleskomicahg: that's great news and I understand about the merge.14:27
joeleskomicahg: what do you mean 'track the beta channel'. I would like to learn and help.14:28
chrisccoulsonhi m_conley14:31
chrisccoulsonhi joelesko14:31
chrisccoulsonthanks for helping out with seamonkey :)14:31
m_conleychrisccoulson: hey!  How was your weekend?14:31
chrisccoulsonm_conley, yeah, not too bad thanks14:31
chrisccoulsonand you?14:31
joeleskoyour welcome. Thanks for the advice and providing the initial package.14:31
m_conleychrisccoulson: it was good!  Thanksgiving in Canada - so lots of feasting.  Ate way too much.14:31
chrisccoulsonheh :)14:32
m_conleychrisccoulson: Just wanted to let you know that I've got a newer version of my EDS contacts add-on ready:  0.3.7a14:32
m_conleychrisccoulson: fixes an annoying authentication loop problem14:32
chrisccoulsonm_conley, excellent. does it work with 8.0? :)14:32
chrisccoulsoni was going to ping you about that14:32
chrisccoulsoni need to update it in our beta PPA :)14:32
m_conleychrisccoulson: yes, it should - I'll need to bump compatibility though, hang on...14:33
chrisccoulsonthanks14:33
m_conleychrisccoulson: k, compatibility bumped.14:35
chrisccoulsonthanks14:36
TheOpenSourcererSo, am atrting to test my TB extension on TB8 Beta1. But the linux builds from Mozilla don't seem to work with libnotify. Are these built differently to the PPA? If so is there a comm-aurora, beta and central PPA anywhere? Am specifically interested in TB not FF15:03
TheOpenSourcerers/atrting/starting15:03
micahgjoelesko: each upstream beta release (like 2.5.0 beta 2), we could upload to the next release once it opens if you like19:08
* micahg wonders why people don't stick around long enough to get an answer...19:19
=== chrisccoulson_ is now known as chrisccoulson
=== m_conley is now known as m_conley_away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!