[05:41] <micahg> joelesko: unfortunately, I'm out of time to do a proper review for your branch and iterate, but I will give you credit for whatever you've done for the upload, I"ll also comment on what changes I made
[05:42] <micahg> joelesko: we'll get into a routine for P, it's this initial huge merge that's been why I've pushed it off, future merges should be much simpler to review
[05:44] <micahg> joelesko: I"m even happy to have you track the beta channel if you like until we get close to the end
[08:31] <micahg> chrisccoulson: FYI, I just pushed up a new seamonkey head branch to be the new lp:seamonkey
[09:13] <micahg> chrisccoulson: you around?
[09:13] <chrisccoulson> micahg, yeah, i'm around now
[09:14] <micahg> chrisccoulson: so, I just want to confirm about seamonkey, we're switching to a single binary package with upstream defaults for bundled libs
[09:14] <chrisccoulson> micahg, yeah, makes sense
[09:14] <micahg> ok, lintian's unhappy, but not fatally so with the package, I guess we can fix that for P
[09:15] <micahg> I pulled in the 4 patches from thunderbird for various build failures, I hope I got them all
[09:33] <micahg> chrisccoulson: does your new tarball build system use /tmp?  I had that when creating the seamonkey tarball
[09:38] <chrisccoulson> micahg, no, it doesn't use that
[09:38] <micahg> hmm...why did the seamonkey tarball use /tmp then?
[09:38] <chrisccoulson> micahg, does the new seamonkey drop the patch which renamed the binary to seamonkey2?
[09:38] <micahg> we never had such a patch in the distro
[09:39] <chrisccoulson> micahg, we did. i'm not sure why we did though
[09:39] <micahg> you mean the upstream binary? yes
[09:42] <chrisccoulson> micahg, http://bazaar.launchpad.net/~mozillateam/seamonkey/seamonkey.head/view/246/debian/patches/seamonkey-fsh.patch
[09:42] <chrisccoulson> that patch has gone now, which is good (it shouldn't really have ever been there)
[09:42] <chrisccoulson> but it means that the profile location moves
[09:43] <micahg> chrisccoulson: oh :(
[09:43] <micahg> chrisccoulson: is there a quick fix? (I can get the upload rejected)
[09:44] <chrisccoulson> micahg, yeah, you just need to check if ~/.mozilla/seamonkey-2.0 exists, and move it to ~/.mozilla/seamonkey if it does
[09:44] <chrisccoulson> (and if ~/.mozilla/seamonkey already exists, just move it to ~/.mozilla/seamonkey.old or something)
[09:45] <micahg> chrisccoulson: do we still need LD_LIBRARY_PATH hacks with this version?
[09:46] <chrisccoulson> micahg, not sure if seamonkey has been updated to use the glue to load libxul
[09:47] <chrisccoulson> if it has, then you don't need it. if it hasn't, then you do
[09:47] <micahg> ok, will leave it for now
[09:47] <chrisccoulson> thunderbird needs it still
[09:59] <micahg> chrisccoulson: hmm, the old version seems to be using the seamonkey dir as well
[10:10] <micahg> chrisccoulson: hmm, the old version seems to be using the seamonkey dir as well
[10:10] <chrisccoulson> hmm, i'm a bit surprised about that
[10:11] <micahg> me too, I thought that's why we changed that in the first place
[10:12] <chrisccoulson> micahg, what about lucid -> natty?
[10:12] <micahg> chrisccoulson: don't know
[10:12] <chrisccoulson> i know we have some releases where it's been renamed to seamonkey-2.0, as i keep seeing it in bug reports
[10:13] <micahg> yeah, I can check that later
[10:14] <micahg> the binary is renamed, but uses the seamonkey profile dir in oneiric
[10:14] <micahg> I guess if there's an upgrade issue, I can push out an SRU
[10:15] <chrisccoulson> micahg, oh, yeah, i see now
[10:15] <chrisccoulson> ok, that's a bit weird
[10:15] <chrisccoulson> firefox uses the app name as the profile folder name too
[10:15] <chrisccoulson> so we're ok there
[10:15] <chrisccoulson> sorry about the noise ;)
[10:16] <micahg> heh, ok, will ask for review/acceptance then...
[10:16] <micahg> chrisccoulson: wasn't planning on sleeping before sunrise anyways I guess :)
[10:27] <micahg> chrisccoulson: so, when I was generating the tarball, it couldn't find the tag for 2.4.1 in the l10n repos
[10:28] <chrisccoulson> for any specific locales?
[10:28] <micahg> all
[10:28] <chrisccoulson> hmmm, i just grabbed en-GB, and it's there
[10:28] <micahg> :(, maybe I should have the tarball rejected and try to regenerate?
[10:28] <chrisccoulson> possibly
[10:30] <chrisccoulson> also, debian/config/branch.mk should be fixed to set CHANNEL to "release", and drop "NO_AUTO_REFRESH_LOCALES = 1"
[10:30] <chrisccoulson> the latter is used on nightlies to prevent the list of shipped translations being auto refreshed
[10:31] <chrisccoulson> if you remove that, you should get a warning about the list of translations being out-of-date
[10:33] <micahg> chrisccoulson: I just ran ./debian/rules get-orig-source DEBIAN_TAG=SEAMONKEY_2_4_1_RELEASE and I got no warning
[10:33] <chrisccoulson> ah, you get it when you try to build the source package (as it checks in the clean target)
[10:34] <micahg> ah, ok, so I need to build the source first?
[10:35] <chrisccoulson> yeah
[10:35] <chrisccoulson> i'm just trying it here as well
[10:35] <micahg> No description for be at debian/build/refresh-supported-locales line 145, <$file> line 1.
[10:36] <chrisccoulson> micahg, yeah, this is because it doesn't yet have a list of languages :)
[10:37] <chrisccoulson> it will helpfully get locale decriptions from langpack-o-matic though :)
[10:40] <chrisccoulson> oh, you're right about only having the nightly branding
[10:40] <chrisccoulson> i never knew that before ;)
[10:41] <micahg> yeah, that's one reason I didn't care so much about non-bundled libs before
[10:42] <micahg> chrisccoulson: still not sure how to regenerate the locale list
[10:43] <chrisccoulson> micahg, debian/rules refresh-supported-locales TARBALL=/path/to/tarball LANGPACK_O_MATIC=/path/to/langpack-o-matic should do it
[10:43] <chrisccoulson> which you can get from lp:langpack-o-matic
[10:44] <chrisccoulson> micahg, i just found another issue with the tarball though
[10:44] <chrisccoulson> create-tarball needs this - http://bazaar.launchpad.net/~mozillateam/thunderbird/thunderbird-trunk.head/revision/457?remember=455&compare_revid=455
[10:44] <chrisccoulson> i wish i had time to review this too :)
[10:46] <micahg> hmm, well, it seemed to build the mail files as well, but I can regenerate and see what happens
[10:46] <micahg> ah, but it might have pulled the tip instead of the tag of the branch...
[10:47] <chrisccoulson> yeah, that's what it's doing here
[10:50] <micahg> chrisccoulson: so, I need to redo the tarball before redoing the locales?
[10:51] <chrisccoulson> micahg, yeah, i think so. what does suite/config/version.txt contain in your tarball?
[10:51] <chrisccoulson> if it's 2.4.1, then it's ok
[10:51] <chrisccoulson> but i've got 2.4 here, which is the current tip
[10:52] <chrisccoulson> micahg, actually
[10:52] <micahg> it's 2.4.1
[10:52] <chrisccoulson> it has updated to the correct version here now
[10:53] <chrisccoulson> perhaps --comm-rev isn't actually needed?
[10:53] <chrisccoulson> i got the impression that client.py just did a "hg update" without that
[10:53] <micahg> I think it's the default maybe?
[10:53] <chrisccoulson> ok, that's ok for now, but we should pass --comm-rev in future builds, just to make sure we really do get the right version :)
[10:54] <micahg> ok, I'll include that change in the upload
[10:57] <chrisccoulson> thanks
[10:57] <chrisccoulson> yeah, i think it might have been a stroke of luck that we got the right version :)
[10:58] <chrisccoulson> it does just do "hg update -r default"
[10:58] <chrisccoulson> micahg, ok i managed to create a tarball here with all the translations in it
[10:59] <micahg> chrisccoulson: so, I need a new tarball?
[10:59] <chrisccoulson> micahg, if they're not in the current one
[10:59] <chrisccoulson> perhaps we can leave this until the next version though
[10:59] <chrisccoulson> seeing as it's already accepted anyway
[10:59] <micahg> yeah, they seem to be there, so I think we're ok
[11:00] <micahg> I'm testing a build now to make sure that the langpack binaries aren't empty, then I'll upload
[11:00] <chrisccoulson> did you manage to generate everything ok?
[11:00] <micahg> yeah
[11:01]  * micahg adds a README.Source note
[11:03] <chrisccoulson> micahg, yeah, i also changed this in firefox recently to make it all a single step - http://bazaar.launchpad.net/~mozillateam/firefox/firefox-trunk.head/revision/1002
[11:04] <micahg> I'll have to fix that later
[11:04] <chrisccoulson> so now, running debian/rules refresh-supported-locales will update the control file too
[11:18]  * micahg wishes Firefox 4+ supported -jX
[11:37] <micahg> chrisccoulson: build failed :( *** No rule to make target `/run/shm/seamonkey-2.4.1/build-tree/mozilla/l10n/be/suite/installer/unix/README
[11:38] <chrisccoulson> micahg, ah, you'll need to leave that off for now then
[11:38] <micahg> which?
[11:38] <chrisccoulson> the problem is that the EXCLUDE list in create-tarball hasn't been updated for seamonkey
[11:38] <chrisccoulson> so it's missing the suite/ folder for each locale
[11:39] <micahg> ah, ok, well, we'll fix for P
[11:47]  * micahg -> zzz
[12:22] <micahg> BTW, thunderbird isn't happy moving 20k messages between IMAP folders...
[12:22] <micahg> 23006 micah     20   0 9337m 4.6g  15m S    0 29.6 182:01.85 thunderbird-bin
[13:18] <m_conley> chrisccoulson: ping
[13:28] <FernandoMiguel> anyone reproduces this https://code.google.com/p/chromium/issues/detail?id=99835&thanks=99835&ts=1318339615
[14:27] <joelesko> micahg: that's great news and I understand about the merge.
[14:28] <joelesko> micahg: what do you mean 'track the beta channel'. I would like to learn and help.
[14:31] <chrisccoulson> hi m_conley
[14:31] <chrisccoulson> hi joelesko
[14:31] <chrisccoulson> thanks for helping out with seamonkey :)
[14:31] <m_conley> chrisccoulson: hey!  How was your weekend?
[14:31] <chrisccoulson> m_conley, yeah, not too bad thanks
[14:31] <chrisccoulson> and you?
[14:31] <joelesko> your welcome. Thanks for the advice and providing the initial package.
[14:31] <m_conley> chrisccoulson: it was good!  Thanksgiving in Canada - so lots of feasting.  Ate way too much.
[14:32] <chrisccoulson> heh :)
[14:32] <m_conley> chrisccoulson: Just wanted to let you know that I've got a newer version of my EDS contacts add-on ready:  0.3.7a
[14:32] <m_conley> chrisccoulson: fixes an annoying authentication loop problem
[14:32] <chrisccoulson> m_conley, excellent. does it work with 8.0? :)
[14:32] <chrisccoulson> i was going to ping you about that
[14:32] <chrisccoulson> i need to update it in our beta PPA :)
[14:33] <m_conley> chrisccoulson: yes, it should - I'll need to bump compatibility though, hang on...
[14:33] <chrisccoulson> thanks
[14:35] <m_conley> chrisccoulson: k, compatibility bumped.
[14:36] <chrisccoulson> thanks
[15:03] <TheOpenSourcerer> So, am atrting to test my TB extension on TB8 Beta1. But the linux builds from Mozilla don't seem to work with libnotify. Are these built differently to the PPA? If so is there a comm-aurora, beta and central PPA anywhere? Am specifically interested in TB not FF
[15:03] <TheOpenSourcerer> s/atrting/starting
[19:08] <micahg> joelesko: each upstream beta release (like 2.5.0 beta 2), we could upload to the next release once it opens if you like
[19:19]  * micahg wonders why people don't stick around long enough to get an answer...