| === m_conley is now known as m_conley_away | ||
| mandel | good mognin all!!! | 07:54 |
|---|---|---|
| karni | Good morning :) | 08:00 |
| rye | morning | 08:19 |
| JamesTait | Happy Monday, everyone! :) | 08:35 |
| mrfree | morning all | 09:04 |
| czajkowski | aloha | 09:05 |
| Chipaca | mandel: s/brozen/frozen/, and (probably) s/linux/ubuntu/, in your blag :) | 09:36 |
| Chipaca | czajkowski: greetings! | 09:36 |
| Chipaca | greetings all, in fact :) | 09:36 |
| czajkowski | Chipaca: hello again :) | 09:41 |
| mandel | Chipaca, ups, thx :) | 09:52 |
| gatox | hi everyone | 10:09 |
| karni | hi gatox | 10:14 |
| gatox | karni, hi, how are you? | 10:15 |
| karni | gatox: hiya, pretty good. we're working on one issue though, that worries me. see oops summaries e-mail if you want. | 10:15 |
| karni | gatox: how's it going? | 10:16 |
| gatox | karni, fine... starting the week :P | 10:16 |
| karni | gatox: hehe. had a good weekend? | 10:16 |
| gatox | karni, yes, movies, relax and programming... but it's always short :P | 10:17 |
| karni | gatox: days are too short. weekends are too short. I hate that :d | 10:17 |
| gatox | yep | 10:17 |
| gatox | jeje | 10:17 |
| * mandel goes out more that thw two young guys from the team.. gatox and karni should be embarrased | 10:25 | |
| gatox | mandel, jejejeje yes, i've seen your twits jeje | 10:25 |
| mandel | gatox, and played rugby.. I've got to say, I'm to old for that sport, I have pain everywhere.. | 10:26 |
| karni | mandel: tell me you have an old dog you have to walk 5 times a day xD (though, really short walks. she's *REALLY* old) | 10:26 |
| mandel | karni, I have a young one that walks 3/4 hours per day.. I would not mind and old one to be honest ;) | 10:27 |
| karni | mandel: :D | 10:27 |
| mandel | gatox, ping | 10:57 |
| gatox | mandel, pong | 10:57 |
| mandel | gatox, in lp:ubuntuone-control-panel, if I add a new package, where do I place the platform dependent tests? | 10:57 |
| mandel | gatox, do they all go to tests? what is the rules used in that project? | 10:58 |
| gatox | mandel, yes, all of them go to tests, you just create test_windows, etc if you need | 10:59 |
| mandel | gatox, insie ubuntuone.controlpanel.tests, right? | 11:00 |
| gatox | mandel, no, if you added a new package, you need to create a test folder inside that package, and place the tests there | 11:01 |
| gatox | ubuntuone.controlpanel.mypackage.tests | 11:01 |
| mandel | gatox, ok, that is how I did it, but I'm looking at the run-tests.sh and it does not ignore a single package for windows, where is that tested? | 11:02 |
| mandel | gatox, do we have any special tests for windows in that project? | 11:02 |
| mandel | looks like we just ignores tests on windows.. weird | 11:03 |
| gatox | mandel, yes, they are not the same (win and linux), i think that is wrong | 11:03 |
| gatox | we are just ignoriing gtk or qt tests it seems | 11:04 |
| mandel | gatox, ok, I'll update the run-tests to ignore test_windows.py and will be similar to the installer | 11:06 |
| duanedesign | mandel: isn't this the useername/ascii bug that was fixed? http://twitter.com/#!/exiper/status/125622417799393282/photo/1 | 11:06 |
| mandel | duanedesign, that is what gatox waas working on, cofigglue does not use unicode so you get that horrible thing in the control panel | 11:07 |
| gatox | mandel, duanedesign i have a branch that fix that, but reviewing that with alecu, we decide to talk about that branch today with mandel and nessita because there are more issues involved | 11:08 |
| Chipaca | mandel: configglue does not use unicode, wut? | 11:09 |
| gatox | Chipaca, there is a problem with the encoding and decoding of the paths | 11:11 |
| Chipaca | gatox: if they should be unicode, tell configglue that and it should just work | 11:11 |
| mandel | Chipaca, that seems to be the issue since the root_path is taking from a config file | 11:12 |
| mandel | gatox, may I see the branch, 'cause I have though of a way to fix that.. | 11:12 |
| gatox | Chipaca, for latin encodings its fixed, but it seems to be an issue for japanese chars, that windows is storing strange chars in the variables from the beginning, so we need to take that values from another place... that's what we talk about today with alecu | 11:12 |
| gatox | Chipaca, utf-8 i mean | 11:13 |
| Chipaca | gatox: mandel: I guess you know this, but the problem is in home_dir_parser apparently | 11:13 |
| gatox | mandel, https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/unicode-issues/+merge/79429 | 11:13 |
| mandel | Chipaca, yes, that is the fix I was thinking of :) | 11:14 |
| mandel | is clearly the simplest way to fix it, and have a diff parse per os | 11:14 |
| Chipaca | we need to move syncdaemon to an updated configglue sometime :) | 11:14 |
| Chipaca | ssh, ssh, que ahi viene | 11:14 |
| mandel | hehe | 11:15 |
| gatox | mandel, look at the branch, it was an easy fix... the problem appear in some other place when i tried with all the tests with unicode paths | 11:15 |
| gatox | mandel, and alecu wasn't convinced that this solved the problem for japanese chars | 11:16 |
| mandel | gatox, from my point of view the best way to fix this is to go to ubuntuone.syncdaemon.config, like 89 and fix that | 11:17 |
| mandel | gatox, move that to platform, and in line 145 set the correct one | 11:18 |
| mandel | gatox, more or less like 20 lines diff + tests | 11:18 |
| mandel | Chipaca, that makes sense ^, right? | 11:18 |
| Chipaca | if the only difference is the encoding, then people on ubuntu can get into trouble too | 11:19 |
| mandel | Chipaca, I think the problem is not using unicode, and we have been lucky so far because str + unicode = unicode | 11:20 |
| Chipaca | i'm not sure why that assert is there | 11:20 |
| gatox | mandel, i'm not sure that the problem is just not using unicode | 11:20 |
| Chipaca | i thought all paths were unicode inside syncdaemon :) | 11:20 |
| Chipaca | further, I think sys.getfilesystemencoding() would be a good way to make it just work | 11:21 |
| gatox | Chipaca, agree | 11:21 |
| mandel | Chipaca, me too.. we can ask nessita, according to bzr blame she owns that line | 11:22 |
| mandel | and alecu.. I think that should be platform specific to solve this kind of issues, but I migth be terribly wrong :( | 11:22 |
| mandel | gatox, why do you think is not a unicode problem? | 11:24 |
| gatox | mandel, with alecu, we tried to cast the path from configglue with unicode and we were receiving weird chars from there... that's way alecu says that windows is storing the information already modified in some variables.... maybe i'm wrong and we should re test it | 11:26 |
| mandel | gatox, may I know how you tested it? | 11:29 |
| gatox | mandel, we were trying to force the function to return unicode | 11:29 |
| mandel | gatox, which function? | 11:30 |
| mandel | and how were you forcing it? | 11:31 |
| gatox | mandel, let me look for that...... | 11:31 |
| mandel | gatox, ok, let me walk the dog and we can continue with that | 11:32 |
| * mandel walks dog | 11:32 | |
| nessita | good morning everyone | 11:53 |
| gatox | nessita, hi | 11:54 |
| nessita | hi gatox, how is it going? | 11:55 |
| nessita | gatox: wanna give me your pending reviews? | 11:55 |
| gatox | nessita, yep | 11:55 |
| gatox | nessita, take a look at this one if you can first: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/pep8-fixes/+merge/79438 | 11:57 |
| ralsina | good morning! | 12:17 |
| gatox | ralsina, hi | 12:17 |
| ralsina | hola gatox | 12:19 |
| nessita | gatox: did you talk with rodney about bug #873266 | 12:21 |
| ubot4 | Launchpad bug 873266 in ubuntuone-client "Ignoring PYTHONPATH (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/873266 | 12:21 |
| nessita | ? | 12:21 |
| gatox | nessita, no, i understand that was an invalid bug | 12:22 |
| nessita | gatox: ah, ok, in that case would you update its status? | 12:22 |
| gatox | nessita, ok | 12:22 |
| nessita | gatox: I'm getting these errors from a branch from mandel: | 12:35 |
| nessita | ubuntuone_installer/gui/qt/gui.py: | 12:35 |
| nessita | 230: [W0201, SuccessPage.initializePage] Attribute 'finish_button' defined outside __init__ | 12:35 |
| nessita | 231: [W0201, SuccessPage.initializePage] Attribute 'next_button' defined outside __init__ | 12:35 |
| nessita | can they be "yours"? | 12:35 |
| gatox | nessita, probably | 12:35 |
| mandel | nessita, looks like that since I did not touch that | 12:35 |
| gatox | nessita, all my branches are up to date.... i'll give you the links now | 12:36 |
| gatox | nessita, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 - https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/network-detect/+merge/77048 - https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/no-mocker2/+merge/78943 | 12:36 |
| gatox | nessita, ahhhhhh i remember that change | 12:36 |
| gatox | nessita, do you want me to propose a small branch that fix that? | 12:37 |
| nessita | gatox: that is too much... mandel, can you please add that fix in your migrate-data, please? | 12:38 |
| gatox | mandel, you should set that variables to None in the __init__ | 12:39 |
| gatox | just that | 12:39 |
| mandel | gatox, nessita ok, no problem :) | 12:49 |
| * mandel lunch | 12:49 | |
| nessita | me | 13:01 |
| gatox | me | 13:01 |
| mandel | me | 13:03 |
| mandel | nessita, stand up? | 13:04 |
| nessita | mandel: I already said me | 13:04 |
| dobey | meh | 13:05 |
| mandel | oh, sorry :) | 13:05 |
| nessita | DONE: day off | 13:05 |
| nessita | TODO: catch up, debug syncdaemon not working on windows | 13:05 |
| nessita | BLOCKED: nopes | 13:05 |
| nessita | NEXT: gatox | 13:05 |
| ralsina | sorry! | 13:05 |
| ralsina | me | 13:05 |
| gatox | DONE: | 13:05 |
| gatox | Bug #851356 Fixed, Proposed a branch that fix PEP8 issues in ubuntuone-client. | 13:05 |
| gatox | TODO: | 13:05 |
| gatox | Keep fixing bugs (first mediums): Bug #852085, Bug #859711, Bug #859743, see if netword-detect branches get merge. | 13:05 |
| gatox | BLOCKED: | 13:05 |
| ubot4 | Launchpad bug 851356 in ubuntuone-control-panel "QT UI: Folder list may show garbage for user homes non-ascii (affects: 1) (heat: 21)" [High,In progress] https://launchpad.net/bugs/851356 | 13:05 |
| gatox | No | 13:05 |
| ubot4 | Launchpad bug 852085 in ubuntuone-windows-installer "Should call self.backend.connect_files as soon as valid credentials are created (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/852085 | 13:05 |
| gatox | mandel, go | 13:05 |
| ubot4 | Launchpad bug 859711 in ubuntuone-windows-installer (and 1 other project) "congratulations page (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/859711 | 13:05 |
| ubot4 | Launchpad bug 859743 in ubuntuone-control-panel "process finished successfully (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/859743 | 13:05 |
| ralsina | DONE: mgmt sprint, travel, day off TODO: catchup with email, people, putting the roadmap together, schedule weekly 1-1s with every one of you, hiring, other stuff BLOCKED: no | 13:06 |
| ralsina | ok, that one was totally out of order. Sorry! | 13:06 |
| ralsina | next mandel? | 13:07 |
| mandel | done: worked on autoupdate in control panel | 13:07 |
| mandel | todo, catch up with MPs , find why I cannot paste I'm in mobile | 13:07 |
| mandel | blocked, no | 13:07 |
| dobey | λ DONE: finished fight with banshee/bzr-bd, set up P nightlies, libu1 part of #872972 | 13:08 |
| dobey | λ TODO: finish bug #872972, bug #467397, schedule holiday | 13:08 |
| ubot4 | Launchpad bug 872972 in libubuntuone (Ubuntu) (and 2 other projects) "Store URLs have to wait for main page to load (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/872972 | 13:08 |
| dobey | λ BLCK: None. | 13:08 |
| ubot4 | Launchpad bug 467397 in python2.6 (Ubuntu) (and 6 other projects) "KeyError: 'ROUND_CEiLiNG' when using turkish locale (affects: 16) (dups: 9) (heat: 108)" [Undecided,Confirmed] https://launchpad.net/bugs/467397 | 13:08 |
| nessita | mandel: why are you on mobile? have any tech issues? | 13:08 |
| nessita | any comments anyone? | 13:08 |
| ralsina | eom I suppose | 13:09 |
| mandel | nessita, no, I wanted to do the standup while having luncj | 13:09 |
| alecu | hello! | 13:09 |
| gatox | alecu, hi | 13:09 |
| * alecu is writing notes | 13:09 | |
| mandel | I does not work, nessita ill move to the laptop for tom, sorry | 13:09 |
| dobey | anyone care to review https://code.launchpad.net/~dobey/libubuntuone/faster-u1ms-pages/+merge/79443 ? :) | 13:12 |
| dobey | ralsina: btw, when are we going to have that planning-fo-p call? | 13:13 |
| ralsina | dobey: wednesday | 13:13 |
| ralsina | dobey: I have to gather sprint notes, and talk to a few ppl before the call | 13:14 |
| dobey | ok | 13:14 |
| nessita | mandel: is ok | 13:14 |
| alecu | DONE: setup a testing VM with Windows Server 2003, as a PDC and with ISA 2004 working | 13:15 |
| alecu | TODO: finish proxy support design document, discuss different proxy approaches with the team | 13:15 |
| alecu | BLOCKED: no | 13:15 |
| alecu | NOTE: I'll probably take tue and wed off for moving the old apartment/office | 13:15 |
| nessita | alecu: I would need you to pause the proxy support work for a little while... we're having a High issue with ussoc that I would like you to take care of | 13:17 |
| nessita | alecu: bug is bug #875331 | 13:17 |
| ubot4 | Launchpad bug 875331 in ubuntuone-windows-installer (and 1 other project) "SSO Client does not work with non-ascii hostnames (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/875331 | 13:17 |
| alecu | nessita, ack. looking. | 13:17 |
| nessita | gatox: old lint issues still present in https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/network-detect/+merge/77048 | 13:29 |
| gatox | nessita, on it | 13:30 |
| === m_conley_away is now known as m_conley | ||
| nessita | alecu: need to mumble about the bug? | 13:39 |
| alecu | nessita, not yet. I'm following the code, and I'd like to test it a bit on my vm | 13:40 |
| ralsina | dobey: any clues about bug #876501 ? | 13:40 |
| ubot4 | Launchpad bug 876501 in ubuntuone-client "Can't start Ubuntuone on Oneiric (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/876501 | 13:40 |
| nessita | alecu: let me know if I can help | 13:40 |
| gatox | alecu, should we discuss about the unicode bug from yesterday? | 13:40 |
| alecu | gatox, yesterday? | 13:40 |
| gatox | alecu, jeje sorry....... friday | 13:40 |
| alecu | gatox, cool! let's discuss, my mind turned into a blank during the weekend | 13:41 |
| gatox | alecu, are you free now?? should we include mandel and nessita? | 13:41 |
| nessita | gatox: include me, yes! | 13:42 |
| * gatox remembers that he didn't setup mumble after reinstalling ubuntu.... | 13:42 | |
| dobey | ralsina: that backtrace screams "my python is completely hosed" | 13:42 |
| ralsina | dobey: ha | 13:42 |
| nessita | dobey: which backtrace where | 13:45 |
| nessita | ? :-) | 13:45 |
| alecu | gatox, I've just refreshed my memory. It was the os.expanduser issue what we discussed on fri, and how it applied to a branch of yours | 13:45 |
| gatox | alecu, yep | 13:45 |
| dobey | nessita: ^^ the bug ralsina asked me about | 13:45 |
| dobey | platform/credentials/__init__.py", line 33, in <module> from ubuntuone.logger import ( | 13:46 |
| dobey | ValueError: bad marshal data (unknown type code) | 13:46 |
| dobey | nessita: ^^ that :) | 13:46 |
| ralsina | that actually means "delete the .pyc files" | 13:46 |
| ralsina | I think | 13:46 |
| === teknico_ is now known as teknico | ||
| dobey | ralsina: which an upgrade would/should have done | 13:46 |
| dobey | ralsina: unless there was *already* a problem, at least | 13:47 |
| ralsina | dobey: yeah. Still, hosed, like you said. | 13:47 |
| nessita | dobey: smeels like old .pyc were not regenerated | 13:50 |
| gatox | alecu, mumble is ready | 13:51 |
| alecu | rye, ping | 13:51 |
| gatox | alecu, let me know when you are free | 13:51 |
| dobey | nessita: sure, like "something broke during upgrade" :) | 13:52 |
| nessita | gatox, alecu: I'm there | 13:52 |
| alecu | rye, I'm trying to reproduce the bug you pasted, but windows 7 is not letting me name the computer with non-ascii characters | 13:52 |
| nessita | alecu: out of curiosity, how are you trying? | 13:52 |
| alecu | rye, are you using some other version of windows? | 13:52 |
| alecu | nessita, changing the "computer name" in "system properties" | 13:53 |
| nessita | alecu: I get a warning, but it lets me | 13:54 |
| alecu | nessita, but when I try pasting non-ascii characters they get turned into underscores | 13:54 |
| dobey | alecu: do you have english version of windows? | 13:54 |
| alecu | dobey, yes | 13:54 |
| rye | alecu, Russian Win7 | 13:54 |
| dobey | alecu: that's why | 13:54 |
| rye | alecu, what was the default hostname? | 13:54 |
| alecu | rye, it was "siete" | 13:55 |
| nessita | alecu: I have the english version, and I could set the computer name to "ñandu" | 13:55 |
| dobey | alecu: are you trying to replicate the SSO bug? | 13:55 |
| alecu | dobey, yup | 13:55 |
| alecu | nessita, are you typing it or pasting it? | 13:55 |
| dobey | alecu: the same problem happens on linux | 13:55 |
| nessita | alecu: typing it | 13:56 |
| alecu | dobey, nice | 13:56 |
| dobey | alecu: let me see if i can find the bug # | 13:56 |
| nessita | alecu: I got a warning about that name being "bad" for microsoft DNS server, but it let me change it | 13:57 |
| dobey | alecu: just make a call to sso in d-feet, using a non-ascii app name, and you should see the same bug | 13:59 |
| alecu | dobey, good point, thanks. | 14:00 |
| mandel | gatox, have you done the talk about the unicode issue already? | 14:00 |
| dobey | alecu: or write a simple python script which does the same thing on windows :) | 14:00 |
| alecu | nessita, I was able to change it to Ñandu by changing the keyboard layout | 14:00 |
| nessita | alecu: je | 14:00 |
| gatox | mandel, not yet | 14:00 |
| alecu | dobey, I much rather debug this on linux, so thanks for the info :-) | 14:01 |
| nessita | mandel: trivial needs fixing added to https://code.launchpad.net/~mandel/ubuntuone-client/improve-fs-notifications-logging/+merge/79243 | 14:01 |
| dobey | alecu: am pretty sure there was a bug for it, but i can't find it :( | 14:01 |
| nessita | mandel: please note that cleanup stuff has to be added with addCleanup, otherwise they are not called if something explodes in between | 14:02 |
| * alecu switches the linux user. See you all laters | 14:02 | |
| mandel | nessita, just read them, will do this before the migration branch since its more urgent | 14:03 |
| mandel | gatox, let me know when you do it :) | 14:03 |
| gatox | mandel, ok | 14:03 |
| === rodrigo__ is now known as rodrigo_ | ||
| dobey | anyone reviewing my branch? https://code.launchpad.net/~dobey/libubuntuone/faster-u1ms-pages/+merge/79443 | 14:24 |
| mandel | dobey, I'm waiting for tests to finish, so I can :) | 14:31 |
| mandel | dobey, puffff, that is a huge MP!!! | 14:31 |
| dobey | heh | 14:31 |
| mandel | dobey, there is a typo: padge | 14:32 |
| mandel | or so I think :P | 14:32 |
| dobey | doh! yes it is a typo. thanks | 14:33 |
| mandel | dobey, I think I more or less understand what is going on, but can you give me a little of context for the fix? | 14:35 |
| mandel | I understand the bug, but is 10 seconds enough? etc.. | 14:36 |
| mandel | I'd like to know what is going on :) | 14:36 |
| dobey | mandel: currently, the banshee extension has to wait for the main page to load, before loading a u1ms URL, otherwise the album page will load, and then the main page will load after it, automatically | 14:36 |
| dobey | mandel: so this change makes it so that any active/pending page loads are told to stop before loading the u1ms:// link | 14:37 |
| dobey | mandel: this is only part of the whole fix (the other part is in banshee), but this makes the banshee part possible to fix | 14:38 |
| mandel | dobey, ok, and that is done via webkit_web_view_stop_loading, right? | 14:38 |
| mandel | dobey, makes sense, how do you want me to test it? | 14:38 |
| dobey | right. it's really hard to test as it is, because banshee needs fixed to be able to visually see the test :) | 14:39 |
| alecu | nessita, dobey: here's the smallest way of reproducing the problem: http://pastebin.ubuntu.com/711002/ | 14:40 |
| alecu | I'm working on a branch to fix it now. | 14:40 |
| nessita | alecu: looking | 14:41 |
| alecu | nessita, the thing is that "get_token_name" is always being called with a "utf8 bytes" app name | 14:41 |
| mandel | nessita, fixed code according to your input: https://code.launchpad.net/~mandel/ubuntuone-client/improve-fs-notifications-logging/+merge/79243 | 14:42 |
| dobey | mandel: just want to get it landed so i can make the banshee fix upstream which depends on it :) | 14:42 |
| alecu | nessita, but get_token_name assumes that some of it will be passed "type unicode" | 14:42 |
| mandel | dobey, ok, I think the code looks good, I'll give a +1 stating it was code reviw :) | 14:42 |
| dobey | mandel: and it's good you caught the typo :) | 14:42 |
| mandel | dobey, hehe | 14:43 |
| nessita | alecu: bu | 14:44 |
| mandel | nessita, regarding https://code.launchpad.net/~mandel/ubuntuone-windows-installer/migrate-data/+merge/78387, what was the issue, it was some lint regarding the ui, right? | 14:59 |
| * mandel looks in the back log | 14:59 | |
| nessita | mandel: yeah, just run u1lint and you'll get them | 15:00 |
| mandel | nessita, ok | 15:00 |
| mandel | nessita, lint issues fixed for https://code.launchpad.net/~mandel/ubuntuone-windows-installer/migrate-data/+merge/78387 revno 92, it seems that lp is slow today picking changes | 15:14 |
| nessita | mandel: ack! | 15:15 |
| mandel | alecu, ping | 15:15 |
| alecu | mandel, pong | 15:16 |
| mandel | alecu, hello, I was wondering if you could give me a hand with twisted | 15:16 |
| mandel | do you have the time? | 15:17 |
| alecu | mandel, sure! | 15:17 |
| mandel | alecu, so, I was thinking about the check for the new version, we want to check every x secs/mins for new versions. This sounds like a good thing to do with a looping call, but I wonder what are the things to consider before doing so | 15:18 |
| mandel | alecu, and if there is a better way to do it (aka no looping call) | 15:18 |
| alecu | mandel, in this case, it sounds perfect to do it with a looping call | 15:19 |
| alecu | mandel, the previous issue with the looping call, was that it was being used to do "just one call". And it that case, a "reactor.callLater" is a much better fit. | 15:20 |
| mandel | alecu, ok, one more thing, do I have to worry about calling stop when we close the control panel? | 15:21 |
| mandel | alecu, or reactor.stop will work ok? | 15:21 |
| alecu | mandel, probably stop is not really needed when stopping the reactor, but you'll surely need it during the tests | 15:22 |
| alecu | mandel, so: make sure to call it :-) | 15:22 |
| gatox | lunch........ brb | 15:23 |
| mandel | alecu, ok, so I don't worry for real live code, I do worry about the tests so that the reactor is not dirty, right? | 15:25 |
| alecu | mandel, not sure... I'm looking at the twisted source, and it's using callLater internally, so we better call stop always (tests and live code), so the logs don't get polluted. | 15:28 |
| mandel | alecu, ok, I though so but due to pure ignorance.. I though it would be safer :P | 15:29 |
| alecu | mandel, if you are looking in the twisted APIs, like in http://twistedmatrix.com/documents/current/api/twisted.internet.task.LoopingCall.html | 15:30 |
| alecu | mandel, you'll see a link that says "View source" | 15:30 |
| alecu | mandel, it's much safer than any guess :-) | 15:31 |
| mandel | alecu, yeah, I should do, but you are faster hehe | 15:32 |
| mandel | and I'm lazy :P | 15:32 |
| alecu | mandel, remember me next time we met that the next "twisted" I should do is your neck! | 15:33 |
| mandel | alecu, you are too small, and I'm back to rugby + gim 2 hours a day :P | 15:33 |
| alecu | :-) | 15:33 |
| mandel | alecu, only one in you family that might convince me agains my will to something is amelia :P | 15:34 |
| alecu | hahahah | 15:34 |
| dobey | lunch, bbiab | 15:37 |
| nessita | mandel: for future references, this is not valid pep8 styling for lists: ['Music', 'Photos', 'Personal', ] it should be ['Music', 'Photos', 'Personal'] | 16:02 |
| mandel | nessita, the problem is the last ',' right? | 16:03 |
| nessita | mandel: and the last space | 16:03 |
| nessita | so, the exta ", " should not be there | 16:03 |
| mandel | nessita, I always do because I've had bad experiences with ('Music') | 16:04 |
| mandel | nessita, so is a habit, I can remove it from my brain, but it will take me some time :) | 16:04 |
| nessita | mandel: that's because ('Music') != ('Music',) | 16:04 |
| nessita | but ['Music'] == ['Music', ] | 16:05 |
| nessita | mandel: understand the difference? | 16:05 |
| mandel | nessita, I know, and that is why I always add the , | 16:05 |
| mandel | nessita, yes, precisely becaus eI know the diff I always add it, I don't want someone later changing [] for () and braking things, is like my little personal guard :P | 16:05 |
| mandel | nessita, but if it is not pep8 I can remove it, no problem what so ever | 16:06 |
| nessita | mandel: thanks | 16:06 |
| nessita | mandel: and not sure where we are with this import: | 16:07 |
| nessita | from ubuntuone.platform.windows import tools | 16:07 |
| nessita | I mentioned you should not import from windows but from: | 16:07 |
| nessita | from ubuntuone.platform import tools | 16:07 |
| mandel | nessita, where is that? in the migrate data branch? | 16:07 |
| nessita | mandel: yeap | 16:08 |
| mandel | nessita, please cna you add it in the MP and I'll make sure is fixed tom early in the morning | 16:08 |
| nessita | mandel: sure! | 16:08 |
| nessita | mandel: I'll approve it and add the comment, so please do not land until that' fixed, yes? :-) | 16:09 |
| mandel | nessita, ofcourse!!! I would never do that (on pourpose at least!) | 16:11 |
| nessita | :-) | 16:11 |
| mandel | ok, EOD for me, I'll see you all tom morning!! have a great afternoon/evening | 16:12 |
| nessita | mandel: bye! | 16:14 |
| nessita | mandel: all fixes requests added to MP's | 16:21 |
| gatox | nessita, let me know if you have the time to review sso-network-detect today before your eod... the lint issues has been fixed | 16:22 |
| nessita | gatox: yes, I have | 16:23 |
| nessita | gatox: shoot! | 16:23 |
| gatox | nessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/network-detect/+merge/77048 | 16:23 |
| gatox | nessita, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 16:24 |
| * alecu gets some lunch | 16:44 | |
| nessita | gatox: sso network-detected branch | 17:07 |
| nessita | ubuntu_sso/networkstate/windows.py: | 17:07 |
| nessita | 184: [W0702, is_machine_connected] No exception type(s) specified | 17:07 |
| gatox | nessita, :S checking.... | 17:08 |
| === beuno is now known as beuno-lunch | ||
| === ralsina_ is now known as ralsina-lunch | ||
| gatox | brb | 17:39 |
| ralsina | is irc.canonical.com down or is it just me? | 17:49 |
| ralsina | and it seems to be up again anyway | 17:49 |
| === zyga is now known as zyga-afk | ||
| nessita | dobey: when you have some spare time, could you please do some triaging on bug #875091? | 18:09 |
| ubot4 | Launchpad bug 875091 in ubuntuone-client (Ubuntu) "ubuntu one does not install - no interface available (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/875091 | 18:09 |
| ralsina | nessita: the autoupdate bug is vista-specific (at least noone not-on-vista has complained) | 18:10 |
| ralsina | nessita: so, mandel has the problem of not having vista | 18:10 |
| dobey | ralsina: suppose, though not sure what to do with it exactly | 18:10 |
| nessita | ralsina: he has a msdn subscription, right? | 18:10 |
| ralsina | nessita: I am not sure he does | 18:10 |
| nessita | ralsina: I'm pretty sure he does | 18:11 |
| ralsina | nessita: cool then | 18:11 |
| ralsina | "pretty sure" >> "not sure" :-) | 18:11 |
| === beuno-lunch is now known as beuno | ||
| dobey | ralsina: TypeError :) | 18:12 |
| ralsina | dobey: that's math, not code :-) | 18:12 |
| alecu | nessita, dobey: https://code.launchpad.net/~alecu/ubuntu-sso-client/fix-get-token-name/+merge/79594 | 18:30 |
| alecu | nessita, dobey: I just tested that branch irl on the windows machine with ukranian hostname, and it works fine. | 18:31 |
| alecu | sorry, not ukranian, but a hostname with Ñ | 18:31 |
| alecu | it's my linux host that has an ukranian name now. :-) | 18:32 |
| * ralsina starts a poll on "where are we going to break because of a non-ascii character next" | 18:33 | |
| ralsina | I am betting "domains with non-ascii characters somehow made it into syncdaemon" :-) | 18:33 |
| alecu | ralsina, my bet is on "unicode characters in timestamps!" | 18:34 |
| ralsina | alecu: "17/íí/20íí" | 18:35 |
| dobey | MMMMMMMXCVI | 18:35 |
| alecu | gatox, sorry, I rushed to finish the "unicode on hostnames" bug, and I totally forgot that we had to mumble. | 18:46 |
| gatox | alecu, jeje no problem, we can do it tomorrow if you want... i'm close to my eod..... and i'm fighting with a reactor was unclean now :S | 18:47 |
| alecu | gatox, ok. But I'll probably be taking the day off tomorrow | 18:47 |
| alecu | though I need to talk about it with the boss first | 18:48 |
| gatox | alecu, ok.... so let me finish with this then and we'll mumble | 18:48 |
| alecu | gatox, let me know if you need help with the unclean reactor | 18:48 |
| gatox | alecu, yep... let me try something and if it doesn't work i'll ping you | 18:49 |
| alecu | gatox, sure | 18:49 |
| dobey | grr, banshee | 18:52 |
| gatox | brb........ need to restart | 18:57 |
| ralsina | I am taking a break for a while, will be back in 1 hour or so. See you all later! | 19:03 |
| gatox | alecu, do you want to review this branch? it only contains pep8 fixes, doesn't touch any code: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/pep8-fixes/+merge/79438 | 19:48 |
| gatox | nessita, alecu review please: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/connect-files/+merge/79611 (launchpad didn't update it yet) | 19:49 |
| gatox | now is updated | 19:49 |
| alecu | gatox, looking. | 19:50 |
| gatox | alecu, now i'm free to mumble when you want | 19:50 |
| alecu | gatox, I'll trade for this: https://code.launchpad.net/~alecu/ubuntu-sso-client/fix-get-token-name/+merge/79594 | 19:50 |
| alecu | gatox, you can do it tomorrow | 19:50 |
| gatox | alecu, ok :P | 19:50 |
| alecu | gatox, already on mumble | 19:50 |
| alecu | gatox, let's see if nessita can join us in the mumble | 19:50 |
| nessita | alecu: sure! | 19:53 |
| dobey | brb, gotta run to post office to mail something off, and grab something for snacking | 19:54 |
| jo-erlend | I've read this post and it seemed to me that it was only the Firefox plugin that was being cancelled, but now people are telling me that there will be no CouchDB sync at all anymore? | 20:13 |
| === zyga-afk is now known as zyga | ||
| alecu | nessita, gatox: http://pastebin.ubuntu.com/711304/ | 20:23 |
| nessita | alecu: mumble kicked me | 20:25 |
| nessita | @ping | 20:25 |
| ubot4 | pong | 20:25 |
| gatox | nessita, me too | 20:25 |
| alecu | me too | 20:25 |
| nessita | mumble died! | 20:25 |
| alecu | me three | 20:25 |
| alecu | yay! | 20:25 |
| gatox | nessita, i can't login again | 20:25 |
| nessita | run for your life! | 20:25 |
| gatox | jejej | 20:26 |
| nessita | neither can I | 20:26 |
| nessita | ok, so, summary: | 20:26 |
| nessita | alecu: I was saying: if you could dedicate a couple of mins to evaluate if we (gatox) can implement a multiplatform expanduser | 20:26 |
| nessita | alecu: we can do some sort of mentoring from you to gatox to guide him how to add this "feature(ish)" | 20:27 |
| nessita | @ping | 20:27 |
| ubot4 | pong | 20:27 |
| gatox | nessita, asck | 20:27 |
| gatox | ack | 20:27 |
| nessita | alecu, gatox: mumble is back | 20:27 |
| dobey | blah | 20:36 |
| dobey | the pretzel store was closed :( | 20:37 |
| ralsina | howdy again! | 20:42 |
| nessita | hi ra | 20:46 |
| nessita | hi ralsina* | 20:47 |
| === yofel_ is now known as yofel | ||
| === m_conley is now known as m_conley_away | ||
| === zyga is now known as zyga-break | ||
| dobey | have a good evening all | 21:41 |
| ralsina | bye dobey! | 21:41 |
| * nessita -> eod | 21:56 | |
| nessita | pilates time! | 21:56 |
| * nessita runs | 21:56 | |
| === gatox is now known as gatox_away | ||
| === zyga-break is now known as zyga | ||
| === gatox_away is now known as gatox | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!