| davidcalle | mhall119, are you around? | 11:46 |
|---|---|---|
| mhall119 | davidcalle: I am now | 12:03 |
| mhall119 | let's get you set up | 12:03 |
| davidcalle | mhall119, in fact I'd like to talk about a particular bug. | 12:03 |
| mhall119 | ok | 12:03 |
| davidcalle | https://bugs.launchpad.net/summit/+bug/642132 This one, I'm concerned about it and I'd like to know if I can fix or help fixing it. (Nevertheless, I'd be more than happy to work on other bugs :) ) | 12:05 |
| ubot4 | Launchpad bug 642132 in summit (and 2 other projects) "openid nickname changes aren't handled (affects: 11) (dups: 6) (heat: 76)" [Undecided,In progress] | 12:05 |
| mhall119 | davidcalle: oh that one is easy now | 12:06 |
| mhall119 | we had to get an upgraded django-openid-auth package installed on the box, but it's there now, so we just need to add a couple variables to our settings.py | 12:06 |
| davidcalle | Great! | 12:07 |
| mhall119 | in fact, it looks like the variables are already in the code, let me see what's in production | 12:07 |
| mhall119 | ok, looks like we just need to deploy the latest summit code | 12:08 |
| davidcalle | Well, in this case... Which bugs on Summit need a hand? | 12:09 |
| mhall119 | our most important ones now are bug #865378 and bug #855810 | 12:12 |
| ubot4 | Launchpad bug 865378 in summit "Support pagination (affects: 1) (heat: 6)" [Critical,Confirmed] https://launchpad.net/bugs/865378 | 12:12 |
| ubot4 | Launchpad bug 855810 in summit "Error if meeting scheduled in two slots (affects: 2) (dups: 1) (heat: 11)" [Critical,Triaged] https://launchpad.net/bugs/855810 | 12:12 |
| davidcalle | Ok, I'd like to give a try at 855810 | 12:14 |
| james_w | I caused that one, so I can help :-) | 12:14 |
| james_w | I think it just needs to catch that exception in the except block after the line of code in the traceback, but I'd want to look at the code around there and see if it should do something other than ignore the exception | 12:16 |
| davidcalle | *trying to understand the code* | 12:21 |
| james_w | yeah, it's not the easiest bit of code, hence me causing the bug in the first place :-) | 12:27 |
| davidcalle | :-) | 12:29 |
| davidcalle | I'm not really experienced with Django, I'm trying to figure out how every bits relate with the real world website ;-) | 12:30 |
| james_w | so this particular code is running to create the html for one of the little boxes on the track schedule | 12:32 |
| james_w | those boxes on the track schedule contain the room name, and this particular code is trying to create that bit | 12:32 |
| james_w | it's crashing when a session is scheduled in two places | 12:32 |
| james_w | so one option would be to spot that problem and not put the room on there, as there may be two rooms | 12:33 |
| james_w | another would be to pick the room for that particular slot and use that one, but I'd have to check the caching first to see if that would work | 12:33 |
| davidcalle | Ok, good clarification. | 12:34 |
| james_w | so, at the top of that method you can see it getting things out of the cache | 12:35 |
| james_w | the cache is only based on the meeting id | 12:35 |
| james_w | so it would be the same cache for both times if the meeting was scheduled twice | 12:36 |
| james_w | so if the rooms were different it would be wrong on one of those times | 12:37 |
| james_w | so I think that the simplest fix is the best one for now | 12:37 |
| james_w | which is to just catch MultipleObjectsReturned and ignore it, like it does for ObjectDoesNotExist | 12:38 |
| davidcalle | I was trying to find the name of the relevant exception. :-) | 12:39 |
| james_w | did you see the duplicate bug? https://bugs.launchpad.net/summit/+bug/860741 | 12:40 |
| ubot4 | Launchpad bug 860741 in summit "http://summit.ubuntu.com/uds-o/track/foundations/ traceback (dup-of: 855810)" [Undecided,New] | 12:40 |
| ubot4 | Launchpad bug 855810 in summit "Error if meeting scheduled in two slots (affects: 2) (dups: 1) (heat: 11)" [Critical,Triaged] | 12:40 |
| mhall119 | AlanBell: ping | 12:40 |
| davidcalle | james_w, no, I didn't | 12:41 |
| james_w | davidcalle, oh, sorry, should have pointed that out earlier, it has the traceback which may have helped | 12:41 |
| mhall119 | james_w: when you have a chance: https://code.launchpad.net/~mhall119/summit/schedule-specific-rooms/+merge/79681 | 12:43 |
| AlanBell | hi mhall119 | 12:50 |
| mhall119 | AlanBell: hey, I'm sorry to say I had to disapprove your MP for summit | 12:53 |
| mhall119 | you had the right idea, but ended up doing way more work that was needed | 12:53 |
| AlanBell | ok | 12:53 |
| mhall119 | I took some of what you had and worked it into a separate MP though | 12:54 |
| mhall119 | ended up being much smaller, and should be easier to maintain | 12:54 |
| AlanBell | great | 12:54 |
| mhall119 | I just didn't want you to think that I rejected yours out of some NIH syndrome or something | 12:54 |
| AlanBell | thats fine | 12:54 |
| mhall119 | cause I really appreciate having you as a contributor | 12:55 |
| AlanBell | I could see there was "rooms" handling code in the track area, I kind of started from the show "one room" type of schedule | 12:55 |
| AlanBell | so yeah, not surprised there was a better way to do it | 12:55 |
| AlanBell | what is the URL structure you went for? | 12:56 |
| AlanBell | oh, I see :) | 12:58 |
| davidcalle | james_w, https://code.launchpad.net/~davidc3/summit/855810/+merge/79683 It's really a quick fix, thanks to you, but I will get started on other bugs asap. :) | 13:07 |
| mhall119 | james_w: in david's MP above, do we want to skip showing the room name in the meeting div if there are more than one? | 13:12 |
| nigelb | mhall119: But we know you have NIH :P | 13:12 |
| mhall119 | I do, actually, and I have to make concious efforts not to let it adversely affect me | 13:13 |
| mhall119 | I used to be much, much worse with NIH | 13:13 |
| james_w | davidcalle, great, thanks | 13:42 |
| james_w | it would be great to have a test for it, but I don't know how much work it would be in this case | 13:42 |
| james_w | mhall119, I thought that's what it was doing, but are you asking if it is the right thing to do? | 13:43 |
| mhall119 | james_w: I'm asking if it's the right thing to do | 13:49 |
| james_w | mhall119, I think it is due to the caching | 13:49 |
| mhall119 | james_w: still, most likely both agenda items will be for the same room, so not displaying the room seems wrong | 13:51 |
| james_w | well, they may be different rooms | 13:51 |
| mhall119 | instead of .get, can we do [0] and catch an IndexError? | 13:51 |
| james_w | it could check | 13:51 |
| mhall119 | that way we can at least display the first room | 13:51 |
| james_w | but that's more work, so I suggested this | 13:51 |
| mhall119 | my suggestion is the same amount of work | 13:52 |
| mhall119 | just a suggestion, I'm not sure how often people are going to care about the room name for a multi-hour meeting on the track-view schedule | 13:53 |
| james_w | but will put the wrong room on the schedule some times | 13:53 |
| james_w | it's not multi-hour | 13:53 |
| james_w | it's one session with two agendas | 13:54 |
| james_w | so they may be on different days in different rooms | 13:54 |
| mhall119 | oh, not sequential? | 13:54 |
| mhall119 | consecutive I mean | 13:54 |
| james_w | yeah, it's not slots > 1 | 13:54 |
| mhall119 | ok | 13:54 |
| mhall119 | I misunderstood then | 13:54 |
| james_w | if it was I would totally agree | 13:54 |
| mhall119 | in that case, david's solution probably is best | 13:54 |
| mhall119 | btw, I added a test case to my MP | 13:55 |
| james_w | cool | 13:56 |
| james_w | just on a call, I'll review them afterwards | 13:57 |
| mhall119 | ok | 14:04 |
| daker | mhall119, cjohnston nigelb do we have a BP for this UDS ? | 15:19 |
| nigelb | yep | 15:19 |
| nigelb | want me to link you? | 15:19 |
| daker | yep | 15:19 |
| nigelb | https://blueprints.launchpad.net/ubuntu/+spec/community-p-summit | 15:20 |
| nigelb | https://blueprints.launchpad.net/ubuntu/+spec/community-p-ltp | 15:20 |
| daker | that's all we have for LTP | 15:21 |
| daker | [chrisjohnston] Rename from LoCo Directory to LoCo Team Portal: TODO | 15:21 |
| nigelb | oh don't wworry | 15:22 |
| nigelb | we'll end up with pppleeenty | 15:22 |
| daker | mhall119, | 15:30 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!