=== eu is now known as Guest73896 | ||
=== Guest73896 is now known as adorilson | ||
notKlaatu | anybody know what this kind of error might mean: http://ubuntuone.com/0fUscV451225ulVILAFYqs | 02:49 |
---|---|---|
notKlaatu | "Could not locate object" | 02:50 |
notKlaatu | after trying to publish a picture to the web on a brand new trial ubuntu one account. | 02:50 |
=== zyga is now known as zyga-afk | ||
mandel | morning all | 07:31 |
JamesTait | Happy Friday, world! | 08:29 |
matti | JamesTait: ;) | 08:41 |
JamesTait | matti: o/ | 08:42 |
karni | Hi everyone! | 08:53 |
matti | :) | 08:56 |
gatox | hi | 10:04 |
mandel | gatox, buenas! | 10:05 |
gatox | mandel, how aree you? | 10:05 |
mandel | gatox, what are you planning to do in your freaky friday? | 10:06 |
mandel | gatox, good, in pain from rugby, but good :P | 10:06 |
gatox | mandel, in the morning i'm going to keep working in the expand_user path actually.... and then after lunch, i'm going to work in a branch to use pyqt api2 | 10:07 |
mandel | gatox, cool, I'm trying to fix that same issue in python directyl :P | 10:07 |
gatox | mandel, that would be even better! :P | 10:08 |
mandel | gatox, I'll be sending a patch in a few mins to python that uses the correct C API to expanduser, and I already sent one to fix listdir when using \\?\ | 10:08 |
mandel | :D | 10:08 |
gatox | groso! | 10:08 |
mandel | gatox, who said that canonical did not contribute upstream ;) | 10:09 |
gatox | mandel, :D | 10:09 |
mandel | gatox, is amazing how slow is vs2008 compiling big pojects :( | 10:10 |
mandel | gatox, I don't know how you would work with that.. | 10:10 |
gatox | mandel, which language? | 10:10 |
gatox | mandel, i used to work with vs2010 in c++ in my previouus job..... and it literally disconnect me from internet and hung up my machine when it was compiling because it use all the resouurces it seems :P (i wasn't the only one) | 10:12 |
mandel | gatox, is C, I'm compiling python with all the extra libs to see if my changes work as expected.. | 10:13 |
mandel | gatox, so far vs2008 has chrashed twice | 10:13 |
gatox | mandel, ahhh yep.... same situation | 10:13 |
gatox | mandel, vs works fine..... if you use it for .net...... everything else is horrible!! | 10:14 |
mandel | gatox, I do have good memories with it on .Net, but is ofcourse due to the way in which Intellisense works | 10:15 |
gatox | mandel, the debugger is quite good too....... and i hate vs, so...... it's good jjeje | 10:15 |
mandel | haha | 10:16 |
nessita | hello crowd! | 11:31 |
mandel | nessita, good morning and happy freaky friday ;) | 11:32 |
nessita | mandel: hey there! I will do the reactor-import review soon | 11:32 |
gatox | nessita, hi | 11:33 |
mandel | nessita, no worries, atm for the freaky friday I'm trying to send patches to python itself for os.listdir (so it works with \\?\) and for the expanduser issue (unicode) | 11:33 |
nessita | gatox: hi there! | 11:33 |
mandel | nessita, so hopefully we can remove those hacks from our code :) | 11:34 |
mandel | ok, the dog needs me, bbl | 11:35 |
gatox | nessita, i'm finishing expand_user branch in the morning.... and then work on my freaky friday project :D | 11:35 |
nessita | gatox: what would be your freaky friday project? | 11:35 |
gatox | nessita, look how to migrate u1 to use pyqt api2.... so it will use python string instead of qstring, python object instead of qvariant and some other stuffs.... also it will be compatible with pyside api.... so with 4 lines of code we could change from pyqt to pyside and use any of that frameworks | 11:37 |
nessita | gatox: nice! | 11:37 |
gatox | nessita, it seems really interesting.... solve some problems | 11:38 |
gatox | nessita, because the api2 is more compatible with python3 | 11:38 |
gatox | too | 11:38 |
nessita | mandel: broken tests in reactor-import | 11:52 |
nessita | mandel: plus a tiny change in a fake | 11:52 |
nessita | gatox: added a comment on sso's network-detect | 12:13 |
gatox | nessita, ok | 12:13 |
nessita | gatox: also, tests are broken on windows, but I guess it was alecu's branch. I file bug #879407 assigned to him | 12:15 |
ubot4 | Launchpad bug 879407 in ubuntu-sso-client "Test failure after token name change (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/879407 | 12:15 |
nessita | brb, I need to run some quick errands | 12:16 |
gatox | nessita, ok, i'll be check that in a while | 12:16 |
ralsina | morning! | 12:25 |
gatox | ralsina, hi | 12:29 |
mandel | nessita, ok, I'll take a look after lunch | 12:40 |
mandel | ralsina, https://answers.launchpad.net/ubuntuone-client/+question/175530 | 12:41 |
* mandel lunch | 12:43 | |
=== txwikinger2 is now known as txwikinger | ||
nessita | gatox: ping | 12:54 |
ralsina | mandel: yes, so? :-) | 12:56 |
* mandel back for stand up | 12:59 | |
ralsina | mandel, alecu, nessita, dobey, gatox: standup in 1' | 12:59 |
ralsina | Don't say I don't give previous notice ;-) | 12:59 |
nessita | gatox: in https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/connect-files/+merge/79611, did you fix the last lint warning I pasted? ( 41: [E0611] No name 'tools' in module 'ubuntuone.platform' )? | 13:00 |
mandel | me | 13:00 |
nessita | me | 13:00 |
nessita | ralsina: you forgot to give notice to yourelf :-P | 13:01 |
nessita | gatox, alecu, dobey, ralsina? | 13:01 |
ralsina | me | 13:01 |
dobey | meh | 13:02 |
nessita | mandel: go! | 13:02 |
alecu | me | 13:02 |
gatox | me | 13:02 |
gatox | nessita, pong | 13:03 |
nessita | mandel: can you go please? | 13:03 |
mandel | http://bugs.python.org/issue13207 | 13:03 |
mandel | one sec | 13:03 |
nessita | mandel: you can catch up at the end | 13:04 |
nessita | DONE: 1-1 with ralsina, reviews (still lots pending!), monkey coder | 13:04 |
nessita | TODO: magiciada, try to wrap up the epic branch. Almos there! | 13:04 |
nessita | BLOCKED: nopes | 13:04 |
nessita | NEXT: ralsina | 13:04 |
ralsina | DONE: nessita 1-1, administrative stuff, started expense report, preparing for trip TODO: finish starting the resourcing, arrange missing 1-1s, finish expense report, more trip preparations, BLOCKED: feels like it, but no, NOTE: I will not work next week's thursday and friday (Disneyworld!) | 13:04 |
ralsina | dobey! | 13:04 |
dobey | λ DONE: commited banshee fix upstream, process e-mail | 13:04 |
dobey | λ TODO: banshee/libu1 SRUs, hack day? | 13:04 |
dobey | λ BLCK: No. | 13:04 |
dobey | alecu | 13:04 |
alecu | DONE: moved the office | 13:04 |
alecu | TODO: work on proxy support design document | 13:04 |
alecu | BLOCKED: no. | 13:04 |
alecu | NOTE: all my body aches now..! I should exercise more often. Or move once a week. | 13:04 |
alecu | NEXT: gatox | 13:04 |
gatox | DONE: | 13:04 |
gatox | Some branch fixing. Improves in expand user. | 13:04 |
gatox | TODO: | 13:04 |
gatox | Finish expand user, work on freaky friday project | 13:04 |
gatox | BLOCKED: | 13:04 |
gatox | No | 13:04 |
gatox | mandel, go | 13:04 |
mandel | DONE: sent patch for http://bugs.python.org/issue13234 and written patch for http://bugs.python.org/issue13207. TODO: 1 on 1 with ralsina. Fix mp for fix-reactor-import branch following nessitas review. Propose. Edge of delete password to pykeyring upstream. BLOCK: no | 13:05 |
nessita | gatox: got my message for the pong? | 13:05 |
gatox | nessita, yep | 13:05 |
nessita | gatox: great! | 13:05 |
nessita | gatox: have an answer? lint is complaining about that for me | 13:05 |
nessita | comments? eom? | 13:06 |
gatox | nessita, ahhh i forgot to disabled to the lint issue about tools.... | 13:06 |
gatox | nessita, doing it right now | 13:06 |
nessita | gatox: ack | 13:06 |
mandel | DONE: sent patch for http://bugs.python.org/issue13234 and written patch for http://bugs.python.org/issue13207. TODO: 1 on 1 with ralsina. Fix mp for fix-reactor-import branch following nessitas review. Propose. Edge of delete password to pykeyring upstream. BLOCK: no | 13:07 |
nessita | mandel: we got it the first time.... | 13:07 |
mandel | did you guys get my last message? | 13:07 |
ralsina | mandel: both messages today :-) | 13:07 |
nessita | mandel: yeap, twice :-) | 13:07 |
* mandel hates irc at times.. | 13:08 | |
nessita | mandel: you mean IRC in your mobile? | 13:08 |
nessita | :-P | 13:08 |
mandel | ralsina, can we have the 1on1 in 30 mins? | 13:08 |
ralsina | mandel: sure! | 13:08 |
gatox | mandel, cool about the proposal to python! :D | 13:09 |
=== m_conley_away is now known as m_conley | ||
ralsina | mandel, if you are trying to tell me something somewhere in IRC, I am *not* seing it. Just ping me after lunch ok ;-) | 13:15 |
gatox | nessita, done | 13:15 |
mandel | ralsina, ok.. | 13:19 |
mandel | I'll ping ASAP... mierda de irc | 13:19 |
nessita | alecu: ping | 13:29 |
alecu | nessita, pong | 13:30 |
nessita | alecu: hi there! I think this new test failure from sso in windows has been added from your latest branch: bug #879407 | 13:30 |
ubot4 | Launchpad bug 879407 in ubuntu-sso-client "Test failure after token name change (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/879407 | 13:30 |
mandel | nessita, e | 13:37 |
mandel | nessita, I meant to say yes.. stupid finger | 13:37 |
nessita | mandel: yes to what? :-) I'm lost | 13:38 |
mandel | nessita, nothing, I think that I'm not a human being between 2 and 3 pm.. | 13:38 |
mandel | nessita, ralsina, dobey, alecu, gatox would it be a huge PITA if we moved the standup 30 mins? | 13:39 |
alecu | mandel, earlier? | 13:39 |
mandel | later, since it would be better for you | 13:39 |
alecu | mandel, \o/ | 13:39 |
gatox | mandel, no problem for me.... | 13:39 |
nessita | +1 for me, but may be too early for dobey | 13:39 |
mandel | I'm trying to have lunch for free (mum cooking) and I'm failing to do the stand up at the same time | 13:40 |
ralsina | +1 | 13:40 |
mandel | nessita, I meant later, so it should be better for dobey, right? | 13:40 |
ralsina | if it's to may your mommy happy, agreed | 13:40 |
dobey | later | 13:40 |
mandel | hurray!!! | 13:41 |
mandel | ralsina, is mainly for my wallet and my stomach, my mother does not care :P | 13:41 |
mandel | ralsina, 1 on 1, mumble? | 13:42 |
ralsina | mandel: in 1' | 13:42 |
dobey | native american flute lullabies is probably not the best hacking music | 13:44 |
nessita | dobey: would you have a couple of mins to see a backtrace and see if you know what's going on? is gi related | 13:45 |
dobey | sure | 13:45 |
nessita | generating... | 13:45 |
nessita | dobey: I'm think is related to ssl... if that is even possible | 13:46 |
dobey | is it coming from u1trial? | 13:46 |
nessita | http://pastebin.ubuntu.com/715127/ | 13:46 |
nessita | dobey: nopes, when running syncdaemon in a branch of mine | 13:46 |
nessita | dobey: I made some refactoring, and the syncdaemon is working perfectly on windows. The whole test suite is fully green on both OSs | 13:47 |
nessita | dobey: but syncdaemon gets that trace when transitioning to CHECK_VERSION | 13:47 |
nessita | dobey: if I never connect the syncdaemon, I don't get the trace | 13:47 |
dobey | it has nothing to do with ssl | 13:47 |
nessita | dobey: ok... any clues? | 13:48 |
dobey | it seems Notify is being imported from gi, after pynotify has already been imported | 13:49 |
nessita | dobey: the trace is making syncdaemon completely die, it does not even respond to CTRL-C.... does that concur with your theory? | 13:50 |
dobey | is there some way in python to see exactly when things get imported? | 13:50 |
nessita | dobey: not that I know of, but I never really looked | 13:51 |
dobey | nessita: well, gi + static bindings can cause lots of problems, but the freeze could be unrelated | 13:51 |
nessita | dobey: so, in ubuntuone/platform/linux/notification.py (code I never touched in this branch) has the conditional import for Notify | 13:52 |
dobey | yes | 13:52 |
nessita | I can't see how that can be importing the same from 2 different sources | 13:53 |
nessita | and grepping gives no other Notify import | 13:53 |
dobey | nessita: something is probably importing notification, then importing launcher, then notification gets imported again | 13:53 |
nessita | dobey: so, a quick test would be to comment out one of the branches of the import. IN natty I can try using only the Nofity from pynotify, right? | 13:54 |
nessita | dobey: indeed, that solved the freeze | 13:55 |
dobey | nessita: well, the gi import will never work, until twisted is fixed and we switch reactors | 13:55 |
nessita | dobey: right | 13:55 |
nessita | it works now!!! | 13:56 |
nessita | now I have to see how I can solve this | 13:56 |
dobey | and this is also why we don't have a progress bar on launcher in oneiric | 13:58 |
nessita | dobey: any suggestion, before I start doing wild guesses and tests? :-) | 13:58 |
dobey | trace the import of ubuntuone.platform.notification up until you find some reason it would be imported multiple times (probably something getting imported within a function) | 14:00 |
nessita | dobey: multiple imports is "easy".... if you import from ubuntuone.platform.notification import Notify you get one import, and import ubuntuone.platform.notification gets you another | 14:01 |
nessita | dobey: I mean, importing the same module but using different "ways" ("paths") will make the module be imported several times (and not reused) | 14:02 |
nessita | dobey: I'll track this down, thanks!!! | 14:02 |
dobey | nessita: right grep notification|grep import | 14:02 |
nessita | yeap | 14:02 |
nessita | alecu: great news! | 14:02 |
nessita | alecu: btw, did you see my ping question? | 14:02 |
alecu | nessita, great news? | 14:05 |
nessita | alecu: my branch is 30 minutes away to be ready :-) | 14:05 |
nessita | alecu: is working almost perfectly on both OSs... | 14:05 |
* alecu books the afternoon for a review. | 14:05 | |
nessita | alecu: I saw you disconnected, did you happen to see my comment re: a test failure in windows sso? | 14:06 |
alecu | nessita, yes, I saw it, and I've been trying to resurrect my windows vm, because it seems to be damaged | 14:06 |
nessita | alecu: I can help debugging if you need | 14:07 |
alecu | nessita, so now I'm setting up the desktop computer that's disassembled in the middle of the living room | 14:07 |
nessita | heh | 14:07 |
nessita | good luck | 14:07 |
alecu | (with the other thousand bags of crap from the move) | 14:07 |
alecu | nessita, so, as soon as I have a working vm I'll test it, to see what I broke. | 14:08 |
nessita | alecu: no rush, just wanted the ack | 14:09 |
nessita | alecu: quick question, does a call to bus.request_name() starts the service? | 14:31 |
nessita | the service under the name being requested | 14:31 |
alecu | nessita, I usually do bus.get_object(), and that surely starts the service if not started. | 14:33 |
nessita | alecu: right, I'm trying to *not* start the service | 14:33 |
alecu | nessita, why? | 14:33 |
nessita | alecu: so I was wondering if request_name starts it or not.... I'm finding 2 implementations for is_running() | 14:33 |
nessita | alecu: in linux, we have 2 different implementations (is_already_running and is_running) | 14:34 |
nessita | alecu: in windows, we have 2 definitions of those methods, the former is implemented, the latter is not! | 14:34 |
nessita | alecu: so, SDTool is using the latter, and ergo, in windows we certainly start serveral instances of syncdaemon | 14:35 |
nessita | several | 14:35 |
ralsina | nessita: this user is complaining ob things "not uploading" https://launchpadlibrarian.net/83394886/syncdaemon.log.report My current guess is "he added a whole lot of files at once (queue at 70K) and they are hidden files (.cache.noindex/whatever) and that's why he's not seeing uploads yet". OTOH, he says it keeps changing from "syncing" to "disconnected" | 14:35 |
dobey | nessita: request_name() will either tell you the name is already taken, or give you ownership of it, iirc | 14:35 |
nessita | alecu: I'm trying to have only one implementation for each OS, and ideally, the correct one :-) | 14:35 |
nessita | dobey: hum... | 14:36 |
nessita | dobey: in u1client we have these 2 ways of checking is u1client is running http://pastebin.ubuntu.com/715154/ | 14:38 |
nessita | bin/ubuntuone-syncdaemon uses the first one | 14:38 |
nessita | SyncDaemonTool uses the second | 14:38 |
nessita | we're clearly failing on windows to check, from SDTool, if sd is running, so we're starting it multiple times | 14:38 |
dobey | nessita: is_running seems wrong. should just change everything to use the is_already_running() method | 14:40 |
nessita | dobey: I concur. But we need to be certain that is_already_running will not start SD if not running | 14:41 |
dobey | nessita: it shouldn't, but is easy to test. shut everything down, and call it from python shell | 14:42 |
nessita | dobey: you're so clever! and always making *me* work :-D | 14:42 |
dobey | nessita: but i'm pretty certain it doesn't | 14:42 |
nessita | dobey: I guess so, otherwise we would be starting u1 in current releases | 14:43 |
dobey | nessita: dbus.bus.NAME_FLAG_DO_NOT_QUEUE means "don't give the name to me if it doesn't exist" iirc | 14:43 |
nessita | nice, testing IRL now | 14:43 |
nessita | dobey: confirmed what you said | 14:44 |
nessita | ok, sticking to is_already_running | 14:44 |
nessita | alecu: just FYI for when you review the branch ^ | 14:45 |
nessita | ralsina: sorry, I think I missed a ping from you | 14:56 |
nessita | ralsina: what bug report is that? | 14:57 |
dobey | nessita, ralsina: as well he shouldn't be syncing files, being offline and all | 14:58 |
dobey | 2011-10-21 15:14:37,435 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - emitting state changed: SET_CAPABILITIES (error=False connected=True online=False) Queue: WORKING Connection: With User With Network | 14:58 |
ralsina | how can he be offline with network? | 14:59 |
dobey | ralsina: ^^ he's probably constantly getting connection dropped from server as some people apparently still are | 14:59 |
ralsina | dobey: makes sense | 14:59 |
alecu | nessita, so, are you adding the clean up for the activation functions to your megabranch too? | 14:59 |
nessita | alecu: yeah! is definitely part of the refactor (quit and start are unified now between OSs) | 15:00 |
alecu | nessita, so, are you keeping is_already_running and ditching is_running? | 15:01 |
nessita | alecu: yes sir | 15:01 |
alecu | great | 15:01 |
nessita | alecu: we should no longer have 2 syncdqaemon instances on windows (which we could easily have now) | 15:01 |
alecu | nessita, cool | 15:03 |
* mandel wonders wich OS is most used in japan.. can't be windows | 15:03 | |
nessita | dobey: question, why did pitti added the conditional imports for loading from gi if none of our twisted code works with gi? | 15:03 |
dobey | nessita: because before the switch to the new gobject which broke the gi+static stuff, our stuff did work | 15:05 |
dobey | nessita: the conditional isn't the problem you're hitting though. it just exposes the problem :) | 15:06 |
nessita | dobey: gah | 15:07 |
dobey | nessita: since it happens only in your branch, and not in oneiric proper, perhaps something you change, altered the timing of some imports, causing the issue? | 15:08 |
nessita | dobey: yes, for sure | 15:10 |
nessita | dobey: I've cleaned up a lot of code, among those, import clauses | 15:10 |
nessita | dobey: I'm trying to find the cleaner solution for this, now | 15:10 |
nessita | to do so I was trying to understand why we need the conditional import (besides looking for the "double" import, which so far I can't find) | 15:11 |
dobey | nessita: we'll probably need the conditional to support both old and new Ubuntus, going forward | 15:11 |
nessita | dobey: right, but right now we support nothing "new" since twisted will not work | 15:12 |
dobey | nessita: but we have to fix that. and we do support it (on 11.04 at least, where it still works right) | 15:14 |
dobey | nessita: and we don't want to have it break when we do get twisted fixed | 15:18 |
nessita | dobey: right | 15:18 |
dobey | nessita: did you move some imports into the functions that use stuff from them? | 15:19 |
nessita | dobey: not really... but I think I found it | 15:20 |
dobey | ok. i'm going to get lunch :) | 15:21 |
dobey | bbiab | 15:21 |
nessita | dobey: thanks!!! | 15:21 |
mandel | nessita, https://code.launchpad.net/~mandel/ubuntuone-windows-installer/fix-reactor-import/+merge/79842 is ready for re-review, I update the tests in main since they did not make sense any longer and wrote tests for | 15:52 |
mandel | succes and error_cb | 15:52 |
mandel | gatox, ping | 15:52 |
gatox | mandel, pong | 15:53 |
mandel | gatox, did you mentioned the bug about your evil username? | 15:53 |
gatox | mandel, yep | 15:53 |
mandel | gatox, cool | 15:53 |
gatox | mandel, no..... not so cool | 15:54 |
gatox | jejej | 15:54 |
mandel | gatox, well, you know, cool that you found it | 15:55 |
gatox | jeje | 15:55 |
* mandel hates haveing to write ctypes code.. | 16:00 | |
alecu | nessita, a fix for the broken test: https://code.launchpad.net/~alecu/ubuntu-sso-client/fix-test-appname/+merge/80084 | 16:09 |
nessita | alecu: looking! | 16:10 |
alecu | and everybody else: trivialish review above | 16:10 |
mandel | alecu, I hate when people use '' and "" in the same line ;) | 16:13 |
Chipaca | mandel: what about people who use " and """ on the same line? | 16:17 |
Chipaca | mandel: "like this""" | 16:17 |
mandel | Chipaca, that I don't mind as much, is always the same char :) | 16:19 |
mandel | nessita, FYI I have just updated https://bitbucket.org/mandel/pykeyring-delete-password/overview to use the same code as the trunk from pykeyring, I'll be proposing it for merge so that we can depend on trunk and not that fork | 16:23 |
nessita | mandel: great news! | 16:25 |
gatox | lunch..... i'm starving....... brb! | 16:25 |
nessita | alecu: approved | 16:41 |
mandel | ok, EOD for me have a great weekend | 16:41 |
mandel | nessita, if you give a +1 to https://code.launchpad.net/~mandel/ubuntuone-windows-installer/fix-reactor-import/+merge/79842 feel free to add the aproval since is a critical bug | 16:42 |
nessita | mandel: ack | 16:42 |
mandel | everyone, adios! | 16:43 |
nessita | bye mandel | 16:43 |
nessita | alecu: branch proposed! https://code.launchpad.net/~nataliabidart/ubuntuone-client/u1sdtool-multiplatform/+merge/80088 | 17:18 |
nessita | no alecu? oh | 17:18 |
nessita | lunchtime then | 17:18 |
rye | duanedesign, i have an idea | 17:34 |
rye | duanedesign, that's not gnome 3 issue | 17:34 |
duanedesign | oh really | 17:34 |
rye | duanedesign, that's gnome-keyring-daemon erroring-out with unrelated error and sso or anything else simply fallbacks to the code that queries the old interface and therefore failing | 17:35 |
rye | we need to get the original exception | 17:35 |
rye | duanedesign, i will be back in 30 minutes and will start poking the gnome-keyring-daemon | 17:35 |
rye | duanedesign, we may get some info out of user's .xsession-errors, searching for e.g. keyring | 17:36 |
duanedesign | great thank again sir | 17:37 |
rye | duanedesign, i will create updated sso package and we'll ask the users to test | 17:38 |
nessita | alecu: hey there! | 17:40 |
nessita | alecu: the branch is now proposed at https://code.launchpad.net/~nataliabidart/ubuntuone-client/u1sdtool-multiplatform/+merge/80088 | 17:40 |
alecu | nessita, nice! | 17:40 |
nessita | alecu: I reported most of the bug things I fixed, and linked the bugs to it | 17:41 |
nessita | alecu: you can start looking at it, I will write some guide notes in the MP itself | 17:41 |
alecu | nessita, 22498 lines (+6824/-12688) 32 files modified!!!!! | 17:42 |
nessita | alecu: that's a lit | 17:42 |
nessita | lie* | 17:42 |
alecu | I love that it removes a lot more than it adds :-) | 17:42 |
nessita | alecu: you will *love* how stdool implementation turned out | 17:43 |
nessita | alecu: 90% of the code is shared multiplatform | 17:43 |
nessita | alecu: and the ipc interfaces are modified so is trivial replacing them with something better (a generator maybe) | 17:44 |
nessita | and I removed tons of mocker tests, adding regular tests instead | 17:44 |
alecu | ultra-mega-cool | 17:44 |
ralsina | congratulations on the branch nessita | 17:51 |
nessita | ralsina: thanks! some weird issues will be fixed from now on | 17:52 |
ralsina | yeah, quick scan, I like much more the green parts than the red ones! ;-) | 17:52 |
dobey | the red parts are more fun | 17:53 |
nessita | ralsina, alecu: I made some heavy testing on both OSes, but anyways, once landed, we need to test it a lot before releasing | 17:53 |
nessita | always | 17:53 |
* ralsina thinks dobey is thinking of budapest or something like that, and backs away slowly | 17:54 | |
dobey | lol | 17:55 |
nessita | alecu: commit message added, and some detailed description as well (mainly to run u1sdtool) | 18:01 |
nessita | dobey: I will make the windows stable branch next week, I want to play a bit with magicicada now :-) | 18:14 |
dobey | heh | 18:16 |
alecu | nessita, I did a first part of the review, and added some notes. | 19:12 |
* alecu needs to run some errands now | 19:12 | |
nessita | alecu: looking! | 19:13 |
gatox | EOD for me.... see you on monday | 19:41 |
=== yofel_ is now known as yofel | ||
dobey | have a good weekend all! | 21:14 |
=== gatox is now known as gatox_away | ||
=== m_conley is now known as m_conley_away | ||
=== caravone_ is now known as caravone | ||
nessita | ok, I'm done | 21:27 |
nessita | (for the day and the week) | 21:27 |
=== gatox_away is now known as gatox | ||
=== edvm is now known as x-ip |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!