| danilos | nigelb, cjohnston, mhall119: actual running instance of summit has been reverted to lp:summit/production r148 because of the rendering issues with my changes; I believe r149 included another text change unrelated to my branch that has been reverted, I am looking into fixing whatever is wrong with my code so we can try to get the fix out | 09:08 |
|---|---|---|
| nigelb | danilos: what went wrong? :( | 09:09 |
| danilos | nigelb, sessions seemed to have been displayed as being in the wrong room (right to the left of the real room), so some positioning changes seem to be wrong | 09:20 |
| nigelb | danilos: ah! | 09:20 |
| nigelb | drat, I should've caught them in review | 09:21 |
| nigelb | I was too busy making sure things didn't explode | 09:21 |
| danilos | nigelb, well, it seems it doesn't happen all the time, since it looked fine and correct for me, but this kind of change is not a good initiation branch :/ | 09:22 |
| nigelb | danilos: Don't worry, summit is known to be weird :) | 09:22 |
| nigelb | danilos: When in doubht, blame Scott and move on :P | 09:23 |
| danilos | nigelb, heh, right, the problem is we really want to get multiple plenaries this time around | 09:26 |
| nigelb | I'll see if I can take another poke at your branch | 09:26 |
| danilos | nigelb, thanks, I am trying to debug it myself, but I am getting a lot of distractions so it's going very slowly :/ | 10:06 |
| nigelb | heh | 10:07 |
| cjohnston | nigelb: can you please revert danilos change out of production, and merge the header change back in and poke IS to update | 10:33 |
| cjohnston | the header needs to be changed yesterday | 10:34 |
| nigelb | cjohnston: yeah. | 10:34 |
| cjohnston | ty | 10:34 |
| cjohnston | nigelb: | 10:34 |
| danilos | fwiw, my change might be affecting only the summit.linaro.org view and not the summit.ubuntu.com view, but it's hard to find the corner cases like this without proper sample data | 10:35 |
| nigelb | I wonder if we can get the data for the schedule app. | 10:37 |
| YoBoY | morning | 10:52 |
| nigelb | Hey YoBoY | 11:05 |
| danilos | nigelb, the problem is that I can't even get the local django admin commands to work (eg. dumpdata), so I wouldn't feel comfortable asking for that to be run on the production instance | 11:08 |
| nigelb | Ouch, okay | 11:09 |
| nigelb | danilos: I reverted the last change and merged back cjohnston's change into production. Could you request that production move to r151? | 11:10 |
| nigelb | dumpdata seems to work for me. | 11:10 |
| nigelb | I just checked | 11:10 |
| danilos | nigelb, interesting | 11:15 |
| mhall119 | danilos: do you have a screenshot or anything so we can see what was going wrong? | 11:26 |
| mhall119 | it'll be helpful in re-creating it so we can write a proper test case | 11:26 |
| danilos | mhall119, unfortunately not, I was hoping I'd be able to get a dump of the data from the production instance instead while limiting the exposure, but basically, summit.ubuntu.com was not showing the ubuntu plenary at all (only the first on Monday and last on Friday seemed to be missing, others around lunch were there) to try to reproduce it locally | 11:40 |
| danilos | mhall119, and a all sessions on summit.linaro.org were mis-placed (looked like a one-off error since they were in the adjacent room in the schedule) | 11:41 |
| danilos | mhall119, I am not sure if it was only visual problem (i.e. I guess everything was there, but was just incorrectly positioned or perhaps hidden due to bad z-index or something) | 11:41 |
| nigelb | YoBoY: Alerady in Orlando? | 11:46 |
| mhall119 | danilos: you should be able to ask IS for a dump of the schedule_* tables | 12:17 |
| mhall119 | well, you'll want schedule_* django_* and auth_* tables | 12:18 |
| mhall119 | they may not give you all of it though | 12:19 |
| danilos | mhall119, right, thanks | 12:32 |
| danilos | mhall119, nigelb: I'll need a very short review once the diff shows up | 17:16 |
| nigelb | sure | 17:16 |
| nigelb | I'm up for about another hour | 17:16 |
| danilos | nigelb, cool, will you be able to help with the landing on production as well? | 17:16 |
| nigelb | sure! | 17:17 |
| danilos | mhall119, nigelb: there was a very interesting problem that our changes uncovered: first plenary "Introduction and Keynote" was scheduled for the 'grand ballroom' room in... Budapest; it showed up because the old code was not going by the rooms, but by the slots :/ | 17:17 |
| * nigelb looks | 17:17 | |
| nigelb | \o/ WIN. | 17:18 |
| danilos | I didn't fix that problem, but I did fix the data on summit.ubuntu.com at least | 17:19 |
| nigelb | I'll file a bug for that. | 17:19 |
| danilos | nigelb, this fix is basically only for the linaroschedule | 17:19 |
| danilos | nigelb, thanks | 17:19 |
| nigelb | Also, this means I get to blame jcastro :P | 17:20 |
| danilos | nigelb, yeah :) | 17:27 |
| danilos | nigelb, basically, none of has seen the problem in testing because there was no problem at all | 17:27 |
| danilos | nigelb, at least not with the code | 17:27 |
| nigelb | heh | 17:28 |
| nigelb | true | 17:28 |
| nigelb | danilos: so now the linaro plenary doesn't show up in the Ubuntu at all right? | 17:28 |
| danilos | nigelb, right, except when editing, I thought that was saner | 17:29 |
| nigelb | Good point :) | 17:29 |
| danilos | nigelb, fwiw, even the previous revision didn't show it, but I had it reverted because of the ubuntu plenaries problem mostly (linaro schedule was our problem and I would have left that online for debugging) | 17:30 |
| nigelb | danilos: why is line 26 - 32 removed? | 17:30 |
| danilos | nigelb, the condition was too broad and ended up in removing empty rooms ((room, None)) when it shouldn't, so that was moved into the if above which basically does the same except it doesn't use "del" but meetings.remove() | 17:32 |
| danilos | nigelb, the provided test fails without those changes | 17:32 |
| nigelb | cool, ok. | 17:33 |
| nigelb | the code looks alright | 17:33 |
| nigelb | I'll quickly run it to confirm all is well. | 17:33 |
| danilos | nigelb, cool, thanks | 17:35 |
| danilos | nigelb, note that you'll have to unrevert the previous fix in lp:summit/production (mine is proposed against trunk where it was not reverted) | 17:35 |
| nigelb | ahhh | 17:35 |
| nigelb | Hrm | 17:36 |
| nigelb | oh that's fine | 17:36 |
| nigelb | trunk gets merged into production | 17:36 |
| nigelb | hoepfully, that should just work. | 17:36 |
| danilos | right, but I think that will not remerge the previous fix (bzr is "smart" like that sometimes) | 17:36 |
| danilos | nigelb, you can do a "bzr diff" before commit and if it's short, it didn't work :) | 17:37 |
| danilos | though more likely you'll get conflicts or such | 17:37 |
| nigelb | urgh | 17:37 |
| danilos | nigelb, the easy path is: "cd production; bzr merge -r150..149 .; bzr ci -m 'Remerge previous fix.'; bzr merge lp:summit; bzr ci -m 'Merge trunk.' | 17:38 |
| nigelb | Aha, thanks. | 17:39 |
| nigelb | danilos: when I look at Monday's schedule, I see both plenaries side by side. Expected? | 17:39 |
| danilos | nigelb, one of them has to have 'linaro-*' track to be considered Linaro | 17:40 |
| danilos | basically, we now allow multiple plenaries for UDS as well, but don't make them and all is fine :) | 17:40 |
| nigelb | ugh, right. | 17:40 |
| nigelb | what the.. | 17:43 |
| nigelb | I just set LINARO_ONLY = True | 17:43 |
| nigelb | And it still shows me summit. | 17:43 |
| nigelb | I mean ubuntu theme | 17:43 |
| nigelb | danilos: Is there anything more you had to do to get linaro only? | 17:44 |
| danilos | I ran it with SUMMIT_LINARO=1 make run and it worked fine | 17:44 |
| danilos | nigelb, the theme stays the same for me as well, but the selection of plenaries/sessions changes (only linaro stuff gets shown) | 17:45 |
| nigelb | ah | 17:45 |
| nigelb | Right. | 17:45 |
| nigelb | It works :) | 17:45 |
| nigelb | Why didn't I look there :D | 17:45 |
| nigelb | approved! | 17:47 |
| danilos | nigelb, thanks | 17:47 |
| * nigelb kicks off tarmac | 17:47 | |
| danilos | nigelb, let me knows when it ends up in production so I can try to get a deployment (even though it's late now) | 17:51 |
| nigelb | danilos: I belive it already has. I'm verifying everything came in :) | 17:53 |
| nigelb | Yep, all done from me :) | 17:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!