/srv/irclogs.ubuntu.com/2011/11/01/#launchpad-dev.txt

StevenKwgrant: I was going to do my own QA first.00:00
lifelesswgrant: one per person in the team00:00
wgrantlifeless: No.00:01
wgrantlifeless: TeamParticipation.person is constrained to me. And Person is contrained to TeamParticipation.team00:01
wgrantSo it's finding all of my teams that have subscriptions00:01
lifelessto bug 123400:02
_mup_Bug #1234: Gina is an unmaintainable mess of command line options, environment variables and shell scripts <lp-foundations> <Launchpad itself:Fix Released by debonzi> < https://launchpad.net/bugs/1234 >00:02
wgrantRight.00:02
lifelessnested loop on TP though, which is a nuisance00:02
lifelessif we're right00:02
lifelesscan teams have multiple subscriptions ?00:06
lifelessah it sthe order by00:07
lifelesswgrant: will 8ms do ?00:10
wgrantlifeless: Nah.00:11
wgrantWhat'd you change?00:11
lifelesscouple of things00:11
lifelessCTE00:11
wgrantsrsly?00:11
lifelessplus narrower distinct by nested tables00:11
wgrantFor TP again?00:11
lifelesshttps://pastebin.canonical.com/55155/00:11
lifelessjust checking on wildcherry00:11
lifeless28 and 1100:12
lifelesschecking old query00:12
lifelessold query is 130ms on wildcherry consistently00:12
lifeless11ms new00:13
lifelessconsistently00:13
lifelesswgrant: anyhow, context switching if you're finished with me ?00:16
wgrantThat indeed looks better. Odd.00:16
wgrantThanks.00:16
lifelesshttps://pastebin.canonical.com/55156/00:17
lifelessis the new plan00:17
lifelesswgrant: I'm not sure the distinct is needed00:18
lifelesswgrant: unless teams can have multiple subscriptions to a bug00:19
wgrantI'm not sure.00:20
lifelesswgrant: the reason for the CTE is the 105 teams all did table walks on TP00:20
wgrantHah00:20
lifelessif you look at the original plan00:20
wgrantBut we have to guess at what's expensive. And I can't test fixes :(00:26
wgrantBecause00:26
wgrant Total runtime: 0.693 ms00:26
lifelesswho is reviewin today ?02:12
lifelessStevenK: could you spare time to do a review?02:15
lifelesshttps://code.launchpad.net/~lifeless/python-oops-datedir-repo/less-rsync/+merge/8086102:16
StevenKlifeless: Can do -- I was noming, sorry03:01
lifelessStevenK: food? zomg NOOOOOOO03:01
lifeless[thanks]03:01
StevenKlifeless: r=me03:03
lifelessthanks03:04
lifelessI have another in a sec :)03:04
StevenKlifeless: And wgrant is OCR today, but there is some silly horse race on.03:04
lifelessyeah, wiki was down when I asked03:04
lifelessStevenK: https://code.launchpad.net/~lifeless/python-oops-tools/amqp-polish/+merge/80864 in a minute or two03:08
lifelessStevenK: and thanks!03:08
lifelessStevenK: diff is up03:12
StevenKI've already read it, just thinking03:13
lifelessI can do a test for the upper if you want03:17
lifelessthough its one of those things that isn't going to break once its done03:17
StevenKThat's not my concern03:17
lifeless:)03:17
StevenKMy concern is if there is a neater way to do it03:18
lifelesswe could reindex the 27M oops ids in the db with a functional index on upper()03:18
StevenKEw03:19
StevenKApprovinated03:19
lifelessthanks!03:19
lifelesshave you had an instant-oops yet ?03:20
StevenKI've seen the new ids03:20
lifelessheh, close :)03:20
StevenKPersonally, I think lp-oops.c.c needs to be better before I stop ssh'ing into carob to see OOPSes03:21
lifelessits pleasant to hack on now03:21
lifeless6s test suite03:21
lifelessetc03:21
StevenKlifeless: Can I take output from subunit-ls and say to bin/test please run those03:22
lifelessStevenK: yes03:22
lifelessthats what testr run --failing does03:22
lifelessthe machinery is:03:22
lifelesssubunit-ls > list-file03:22
lifelessbin/test --load-list list-file03:22
StevenKI wonder if bin/test will like /dev/stdin as a list file03:22
lifelessStevenK: it might, but ewww ;)03:23
lifelessStevenK: you know you're reinventing testr by hand, right (AFAICT)03:23
* StevenK tries it, just to make lifeless a little greener03:23
StevenKYeah, maybe I should just testr init, testr load, etc03:23
lifelessok, so thats deployed out; next thing, the workarounds for oops-amqp03:33
lifelessalmost need a fixed-amqplib03:33
lifelessbut I'm not quite there yet03:33
StevenKArgh, model code updated by triggers03:40
* StevenK claws his eyes out03:40
lifelessStevenK: bug heat ?03:40
StevenKlifeless: Branch.unique_name03:40
* StevenK waits for his branch to stop WADLing03:41
lifelessquack quack03:42
* StevenK grumbles.03:56
StevenKI suspect this branch is impossible with FDT.03:56
StevenKjtv: O hai, can you QA r14202?03:57
jtvHi StevenK03:57
jtvI'll get to it in a moment03:58
wgrantStevenK: Are you still trying to rename +junk without talking to mrevell and others?04:00
poolieStevenK: i would like to be involved in planning what happens there04:09
wgrantRenaming it is technically trivial.04:09
wgrantEvery other aspect of it is not trivial.04:09
lifelessmostly trivial04:09
lifelessdepending on the new name +  backward compat desires04:09
pooliei think we ought to at least think about the larger story of how projects get started and grow04:10
pooliesome things in junk are purely personal04:10
lifelesspoolie: I think that hinders the local improvement04:10
lifelesspoolie: of just having a better na,e04:10
poolieothers are nascent larger projects04:10
wgrantA local improvement should be hindered.04:10
nigelbHey, can SSO grab from lp if a person is remote or not?04:10
wgrantBecause it is a large backwards-compatibility burden.04:11
nigelb(for a sprint)04:11
lifelesswgrant: only if it breaks +junk04:11
poolielifeless: thinking about it does not hinder it04:11
lifelesswgrant: which isn't presumed04:11
wgrantlifeless: We now have to support +junk forever.04:11
poolieit's been like this for ~5 years04:11
wgrantlifeless: Adding a new name means we have to support the new name forever too.04:11
lifelessI shouldn't have said anything. I have work to do :)04:11
pooliecongratulations on getting realtime oopses done04:12
pooliebtw04:12
lifelessthanks04:13
lifelessStevenK: care to do https://code.launchpad.net/~lifeless/python-oops-amqp/0.0.4/+merge/80865 as well ?04:13
lifelessStevenK: diff is there04:16
StevenKwgrant: So its apparently pointless to do, then?04:20
StevenKpoolie: Involved how?04:20
poolieStevenK: when lp changes things like this that affect bzr, i'd appreciate being told beforehand04:22
nigelb+junk is going away?04:24
StevenKIt is not.04:24
lifelessno04:24
nigelbOr going to be called something "better"04:24
lifelessbut there is broad consensus that its a horrible name04:24
pooliei'm heartily in favour of improving it and of looking for a small change that will improve it04:24
pooliewhat are you planning to do?04:24
nigelbheh, agreed.04:24
StevenKpoolie: I'm planning on changing the code to return +personal by default, but accepting both +junk and +personal.04:24
poolieStevenK, we write documentation about launchpad and we answer a lot of questions about how to use it04:24
poolieand we make design decisions that work with launchpad04:25
StevenKHowever, I'm not even sure if it's landable04:25
poolieso i think it's reasonable not to be surprised by changes there04:25
StevenKSince there is a trigger involved.04:25
poolieok04:25
poolieis this in an mp? i don't see any mail about it04:26
lifelessStevenK: some care needed to check interactions with e.g. the apache rewrite map04:26
lifelessStevenK: I think that uses that column04:26
StevenKIt's local only at this point.04:26
pooliethat sounds like a good step though04:26
pooliea great step in fact04:26
lifelessI think we should have a brief discussion with mrevell about the new url component04:27
lifelessI'm in favour of something like 'p'04:27
lifelessmay as well make it not fugly04:27
StevenK+p ?04:27
lifelessno04:27
lifelessp04:27
StevenKWe don't allow single character projects, do we?04:28
lifelessexactly.04:28
StevenKI'm not sure about p, TBH04:28
lifelessp might be better reserved for project branches or something, but you get the idea04:28
lifelessreal-short-and-simple04:28
lifelessI don't think + makes for a nice UI, never have.04:29
pooliei think according to https://dev.launchpad.net/LaunchpadEnhancementProposalProcess you need to write a lep for it04:30
lifelessStevenK: https://code.launchpad.net/~lifeless/python-oops-amqp/0.0.4/+merge/8086504:30
StevenKSo sinzui said on the call that +personal seems to be the prefered name, and that I can have a free rs=sinzui so he copes the flak and I don't. :-P04:30
StevenKlifeless: Shall I just wait on IRC for your next MP?04:30
lifelessStevenK: please04:30
lifelessStevenK: that would be awesome04:30
StevenKlifeless: Your timing the last two times has been impeccable04:31
lifelessStevenK: blame your squadmate :)04:31
StevenKI just swap my own work back in and I get pinged again.04:31
StevenKI think I'll blame Melbourne.04:31
lifelessStevenK: hey, I pinged this one 17 m back, but you were distracted :)04:31
StevenKOh, that one.04:32
StevenKI already had it open, I was thinking.04:32
StevenKlifeless: Approved, with a comment.04:34
poolie:/04:34
StevenKpoolie?04:34
lifelesspoolie: I think you're asking for more from LP devs than they ask from bzr here, and I don't understand why.04:34
lifelesspoolie: both project cooperate, have a reasonable understanding of the other (at least at team mgmt levels) so they ask when they see impact, and don't when they don't.04:35
poolieyeah my unhappiness is basically that they don't ask when they see an impact04:36
poolieor perhaps they don't see an impact04:36
StevenKpoolie: How does the personal namespace impact on bzr?04:36
pooliefor instance, we have documentation that refers to +junk04:37
lifelessSo, imagine that we accept +personal and +junk, and advertise +personal. That obviously needs to be socialised amongst everyone doing support, and all our useres.04:37
lifelessbut its compatible; any docs won't be invalidated, they will keep working.04:37
poolieyeah04:37
StevenKExactly04:37
pooliei guess that seems a bit pedantic to me04:37
poolieand it would be easy and more courteous to just say 'we're going to change this' in advance04:37
StevenKpoolie: Er, so I didn't even know if it was *possible* to change it until 4pm yesterday.04:38
StevenKTo be brutually honest, what I have is a play branch04:38
lifelesswould you tell LP if you added a new verb with no particularly surprising semantics in it, that was backwards compatible with old clients etc?04:38
* StevenK throws his Dell laptop out the window04:39
lifelessStevenK: how will you play WoW ? Oh right ...04:39
* StevenK has removed that from his machines04:39
StevenKBesides, I hated playing WoW with a trackpad04:40
poolielifeless: i guess that example means "that had no changes that are likely to impact lp"04:40
pooliethe difference is that changes to lp's ui/user model do impact us, because we document and support it04:40
poolieStevenK: np, i don't really mind this case (and again, i'm happy to see it improved) it just seemed like a bit of a pattern04:41
lifelesspoolie: what data points are on this pattern? Last time we spoke about this feeling you were hard put to pin it down.04:42
lifelesspoolie: it *seemed*, as I remember it, to be mainly feeling that LP did stuff without talking about it : but when we compared notes team bzr wasn't communicating (in advance) any more fully04:42
pooliei don't think it's about who's doing better or worse04:43
lifelesspoolie: I don't mean to frame this as what you do vs what lp does, though it seems I'm taking it that way04:43
pooliebut rather, which things are useful to communicate about04:43
poolieif lp changes the namespace for branches that is the kind of thing i'd like to hear about04:43
StevenKlifeless: Can we have a quick skype?04:44
lifelessStevenK: sure04:44
poolieif there's any thing we're changing that you wish you'd heard about earlier, let me know04:45
lifelesspoolie: I trust that (I track what you are doing enough, and that you make good decisions) to the extent that whatever falls through the cracks, falls through the cracks.04:46
poolieyeah i normally do too04:48
pooliei was surprised by this because i didn't see anything about it on a bug or mp04:48
nigelbHi, so +temp-meeting-export will not give a subscription information if someone is not registered for a sprint. Is there a chance I can remove that check?04:51
jtvStevenK: I need to make dogfood or staging go through the motions of notifying about a package sync or upload…  I can't sync Ubuntu packages on dogfood any more; what would I need to do to elicit an email notification from an upload?04:51
StevenKjtv: OTP04:52
jtvok04:52
lifelessnigelb: I believe summit is the only user, so sure, though the data size can be pretty big on popular blueprints04:52
nigelblifeless: It has always been big. we hit issues with the 2 sprints thing this time.04:53
nigelbSome BPs were only registered to LDS.04:54
nigelbI'll change it after UDS, lest people murder me.04:54
lifelessStevenK:         result = store.find(04:56
lifeless            (Branch.id, Branch.unique_name),04:56
lifeless            Branch.unique_name.is_in(prefixes),04:56
lifeless            Branch.transitively_private == False).one()04:56
nigelbOh.04:59
nigelbI just noticed rf-* is symblinked to the binary in devel.05:01
jtvStevenK, wgrant: mind if I upgrade dogfood?05:04
pooliewhen are builds deleted? like https://code.launchpad.net/~neon/+recipe/project-neon-kdesdk/+build/1243705:09
poolieare they gc'd a while after they complete?05:09
wgrantjtv: No.05:11
jtvThanks.05:11
wgrantpoolie: they're meant to never be deleted.05:11
wgrantAnd I think I convinced code that deleting them was not going to work.05:12
poolieso the user must have deleted them?05:12
wgrantSo IIRC they shouldn't ever be deleted.05:12
poolieor the urls are just wrong05:12
wgrantWhat linked to that?05:12
pooliehttps://bugs.launchpad.net/launchpad-buildd/+bug/69352405:12
_mup_Bug #693524: Daily builds fail because of insufficient memory <escalated> <linaro> <recipe> <Launchpad Auto Build System:Triaged> < https://launchpad.net/bugs/693524 >05:12
wgrantPerhaps they renamed the recipe?05:13
wgrantD:05:13
wgrantSPRB.destroySelf exists.05:13
* wgrant goes stabbity stab.05:13
wgrant        for release in releases:05:13
wgrant            release.source_package_recipe_build = None05:13
wgranttergjkeriogjeroigteriogjioergioernjegkl05:13
wgrant23FTRWE89HGN A9PRGHERIUHGER05:13
wgrantYes that's right let's just erase the auditing information05:14
wgrantWHY NOT05:14
poolie:)05:16
pooliewgrant: what would be the most practical way for me to get the versions of bzr and bzr-builder in to the build log file05:19
poolieto make bzr-builder print them?05:19
wgrantI'm not sure.05:20
wgrantI would hesitate to suggest that a bzr-builder upgrade would be the easiest thing.05:20
pooliemeaning "it probably is, but only slightly" or "it's probably not?"05:24
wgrantI would have said it was, until we ran into this recent trouble.05:24
wgrantNow it's possibly easier and safer to fix lp-buildd.05:24
lifelessftr this is the bug - https://bugs.launchpad.net/launchpad/+bug/14740705:41
_mup_Bug #147407: Junk sounds too harsh <lp-code> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/147407 >05:41
poolieftr my bit is https://bugs.launchpad.net/launchpad/+bug/88409205:51
_mup_Bug #884092: source recipe build logs should mention versions used <Launchpad itself:Triaged> < https://launchpad.net/bugs/884092 >05:51
jtvStevenK: not having much luck testing that revision.  Can't even upload a deb to dogfood.  :(  Since my branch doesn't change any functionality, I think I'll go with "qa-untestable."07:08
jtv(The upload failure is something I've seen before — worth chasing down, but probably not worth holding up landings for)07:09
=== jtv is now known as jtv-eat
poolieso does buildd/buildrecipe somehow get copied to buildrecipe.py, which seemsto be the name that isactually run?07:13
poolieok https://code.launchpad.net/~mbp/launchpad/884092-buildd-versions/+merge/8087007:21
pooliestevenk, wrgant, how could i usefully locally test a change to buildrecipe?07:22
lifelesspoolie: there is a makefile in buildd, or a debian.rules - something07:24
poolieyeah, even some documentation07:24
nigelbwgrant: OCR-ing today?07:36
wgrantnigelb: Public holiday.07:36
wgrantSo I'm mostly not here.07:36
nigelbwgrant: HA, what's the holiday for? (its holiday for us too)07:36
wgrantMelbourne Cup07:37
wgrantBecause horse races are awesome, apparently.07:37
nigelbHorse race?07:37
nigelblol07:37
nigelbOurs is slightly more reasonable. State formation anniversary thingie.07:37
nigelbwgrant: Do you get holidays for cricket matches as well? ;)07:41
wgrantNope.07:41
nigelbSad.07:41
nigelbThat obviously meant more hlidays.07:41
nigelbNo more make lint?07:42
* nigelb moves to right folder.07:43
nigelbUgh, http://paste.ubuntu.com/725049/07:51
nigelbTried out +temp-meeting-export locally.07:51
nigelbAh, that was my fail :)07:52
* wallyworld_ off to see Cold Chisel :-)07:57
=== jtv-eat is now known as jtv
nigelbEw. This was done very badly.08:05
nigelbFor the meeting export, it gets all the sprint attendees and then gets people from it.08:05
=== jtv is now known as jtv-afk
nigelbCould someone give some guidance on potential perfomance?08:21
nigelbCurrently, the meeting export fetches all the attendees for a summit and filters the people attending from that.08:21
lifelessyup08:21
nigelbso, the meeting export page is sort of fast.08:22
lifelessthis is an important characteristic08:22
nigelbBut the chnage I want kinda screws it up.08:22
nigelbAnd I'm hesitant to do that :)08:22
lifelessfair enough too :)08:23
nigelbI wondering if we could add people to list as I find them08:23
nigelbwith the details I want08:23
lifelesswhats the big picture here08:23
nigelband build the list of people based on the people subscribed to the BPs in the sprint.08:23
nigelbThe big picture is we want all the people subscribed to a blueprint.08:23
lifelessso the export should be 3 queries08:24
lifeless-> sprint08:24
lifeless-> blueprints08:24
lifeless-> people08:24
lifelessand then some glue08:24
nigelbheh08:24
nigelbYeah08:24
nigelbMy idea is this08:24
nigelbWe do this currently08:24
nigelb        people_by_id = dict((person.id, person) for person in08:24
nigelb            getUtility(IPersonSet).getPrecachedPersonsFromIDs(attendee_set))08:24
nigelband then we look into that dict to find a person's ID and whether they are required.08:25
lifelessand \o/ instant oopses on staging as well08:25
nigelbheh08:25
nigelbI'm running it locally :)08:25
rvbalifeless: congrats!08:25
=== jtv-afk is now known as jtv
lifelessrvba: thanks :)08:25
nigelblifeless: \o/ Nice :)08:26
lifelessrvba: allenap: btw - you might like the last commit on oops-amqp - more errors amqplib throws up when rabbits are restsarted08:26
* rvba looks.08:26
nigelblifeless: Ideally, I'd like to look if a person exists in a dict I create as I go, if not lookup each person I find on a BP, and find their ID, name, required status and put into that dict.  I'll be quering more on launchpad, but only once person.  Is that too much of a perf drop?08:27
lifelessnigelb: thats about as bad as it gets08:28
nigelbI was afraid of that :)08:28
nigelbAlternatively, can I look up subscribers to a BP instead?08:28
lifelessnigelb: step back08:28
lifelessnigelb: you need three queries:08:29
lifelesssprint08:29
lifelessblueprints08:29
lifelesspeple08:29
lifelessand then glue08:29
lifelessthe glue is mostly done - jus tneeds shuffling08:29
nigelbI get all the people in launchpad?08:29
lifelessyou can't work with the object model for doing queries though: the object model is intrinsically hostile to performance08:29
lifelessnigelb: no, you get all the people relevant to the blueprints08:29
lifelessone query.08:30
nigelbI can do that?08:30
* nigelb didn't know.08:30
lifelesswell, you'll need to put the bits in the right order, but yes.08:30
lifelessthats what the current code does (but it selects all attendees, not all subscribers-or-attendees)08:30
lifeless[caveat, I haven' tlooked at that code in ~ 9 months, bzr annotate will tell you precisely when)08:31
nigelbIs there code to do that or do you suggest I write it? :)08:31
lifelessI don't know how much will need assembling and how much is pre canned08:31
lifelessthis is bread-and-butter to changing something in LP though, its not at all unordinary08:32
nigelbExcellent. I'll look at the model and see if I can figure something out :)08:32
nigelbI may need lots of help.08:32
lifelessis this desirable? Won't the summit UI explode ?08:34
nigelbNo.08:34
nigelbSummit was always doing this.08:34
nigelbShowing all the subscribers to a BP.08:34
nigelbIt helps people hide the ones they aer not subscribed to.08:34
nigelbAnd setup personal icals.08:35
lifelessok08:35
lifelessso how is that data not present ?08:35
nigelball those break since some subscriptions don't get sycned thanks to two summits.08:35
lifelessI don't understand the failure mode08:35
nigelbWe're using 2 launchpad sprints.08:35
nigelbsome Bps proposed to uds-p, some to lds08:35
nigelb(Eventually, all blame goes to linaro :P)08:35
lifelessbut if you're using temp-meeting-export, that means you're not getting all subscriptions08:35
nigelbwe query both08:36
nigelbso we get all subscriptions08:36
nigelbBut we don't get all the people08:36
nigelbsome people are registered for uds, some for lds.08:36
lifelessI don't understand08:36
lifelessneither export includes non-attendees08:36
lifelesshow are you getting 'all subscriberes to a BP'08:36
nigelbIts from the export08:37
nigelbI need to find out how james set this up.08:37
lifelessso the export includes all subscribers irrespective of attendees ?08:37
nigelb(at the summit end)08:37
nigelbexport does not.08:37
lifelessthen how is summit showing all subscribers ?08:37
nigelbexport includes only subscribers who are attendees.08:37
nigelbSummit isn't showing all subscribers, which is what I'm digging for.08:38
lifelessbut you said 'summit was always doing this'08:38
nigelbWe always had one sprint.08:38
lifeless21:34 < lifeless> is this desirable? Won't the summit UI explode ?08:38
lifeless21:34 < nigelb> No.08:38
lifeless21:34 < nigelb> Summit was always doing this.08:38
lifeless21:34 < nigelb> Showing all the subscribers to a BP.08:38
nigelbso, this was never a problem.08:38
lifelessnigelb: one sprint doesn't mean showing all subscriberes08:38
lifelessnigelb: the statements are not at all equivalent08:38
nigelblifeless: I'll rephrase.08:38
nigelbUntil now, we never noticed the impact.08:39
nigelbMost Ubuntu folks were attendees.08:39
lifelessright, and thats why I'm asking.08:39
lifelessWon't the summit UI explode ?08:39
nigelbexplode in what sense?08:39
lifeless600 attendees08:41
nigelbwe don't show all attendees in one place.08:41
nigelbBut we show all subscribers to a BP.08:41
lifelessbear with me08:41
nigelbYeah, I'm misunderstanding soething :)08:41
nigelbWould skyping help?08:42
lifelessok, 597 subscribers across all bp;s08:47
lifelesspeaks is 4608:48
lifelessthats probably tolerable08:48
lifeless(on a single spec)08:48
nigelbhah, that.08:48
nigelbYeah.08:48
nigelbWe do occasionally have UI explosion for big and famous sessions08:48
nigelbBut its only if you mouse over.08:49
nigelblifeless: You just made me realize I need to dig deeper into summit for this.08:52
nigelbBecause with both the meetings, we should get all the subscriberes, but we're not.08:52
lifelessnigelb: consider the more permanent solution :)08:52
nigelblifeless: I like what's currently there for its performance :)08:53
nigelbI probably only wold add a warning when subscribing that "You aren't markd as attending for this sprint" or osmething.08:53
allenaplifeless: Yes, tip top, thanks.09:20
lifelessallenap: also the current catch IOError in LP is too broad09:21
lifelessallenap: (again, see oops-amqp for better handling of that)09:21
allenaplifeless: rvba has been working on that, but is suffering badly from a Heisenbug around OOPSes. I suspect the big OOPS landing yesterday might help.09:22
rvbaallenap: I tried to use the new oops thing yesterday and land it again, but I've been suffering from the perf problem lifeless mentioned in his email and I killed it after 6 hours in ec2.09:23
lifelessrvba: its fixed now :)09:24
rvbalifeless: \o/.  I shall try to land it again then. Thanks for the heads up.09:24
lifelessif it takes that long its your change :P09:24
* rvba tries to land it again.09:25
=== jtv is now known as jtv-afk
=== jtv-afk is now known as jtv
=== gmb changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: gmb | Critical bugtasks: 266
bigjoolsgmb: can I bother thee for a review please11:32
gmbbigjools: Sure. I'll take a look as soon as I've done with rvba's.11:32
bigjoolsthanks11:32
bigjoolsgmb: heh, good point with the comments12:28
gmb:)12:28
bigjoolsI only even added those ones as an afterthought - never a good idea12:28
deryckMorning, all.12:58
danhgHi Everyone, if you're a Launchpad user, please get in touch if you'd like to do some usability testing today.13:16
lifelessdanhg: I suggest trying in #ubuntu-uds13:19
danhgthanks lifeless13:19
lifelessdanhg: folk here probably don't qualify for such tests :P13:19
danhgI've posted there too13:20
lifelessdanhg: I don't see you in that channel ?13:20
danhgI'm in it now13:20
danhgI'm on Colloquy. It likes to mess around.13:21
lifelessindeed, you are too13:21
rvbalifeless: Your new oopses code fixed my Heisenbug.  Thank you for that!14:24
lifeless\o/14:25
lifelesshow?14:25
rvbaI don't know (hence the Heisenbug), but I was able to land my code without a problem once I've refactored it to use the new oops code.14:26
rvbaI had this weird 'test hung' failure.14:26
rvbaThat I could not reproduce locally.14:26
rvbalifeless: If you're really interested, you have all the details about the Heisenbug in my email "Help with a hung test" to the mailing list.14:32
Beretlifeless, thought you were going to bed? :)14:33
lifelessI was14:34
lifelessI am too :P14:34
lifelessrvba: were you using getLastOops ?14:34
rvbalifeless: yes.14:34
lifelessthen you were seeing an oops from the test before, in all probability14:34
lifelessbecause it was a terrrrrible API (though probably not obviously so at the time it was written)14:35
lifelessrvba: I'm glad its working for you14:35
lifelessand with that, I really am halt()ing state14:35
rvbaGood night lifeless!14:35
=== jtv is now known as jtv-afk
rvbagmb: I've got a tiny review for you if you're up for it ;). https://code.launchpad.net/~rvb/launchpad/combinator-bug-881144/+merge/8091114:42
gmbrvba: I'm OTP and then am going to be grabbing a late lunch, but I'll come to it soon thereafter.14:42
rvbagmb: sure. Thank you!14:43
deryckabentley, should we do a late standup now, while I wait on staging update?15:04
abentleyderyck: sure.15:04
deryckabentley, http://pastebin.ubuntu.com/725330/15:08
deryckabentley, we will need to get a loading spinner of some sort working when changing the ordering.15:25
deryckabentley, but I think we'll need to rethink our current spinner approach since a whole section of the page changes.15:25
abentleyderyck: We haven't implemented precaching yet :-)  Well, I guess we should add a spinner anyhow.15:25
deryckabentley, yeah, just to be safe.15:26
deryckmrevell, staging is working now.  https://bugs.staging.launchpad.net/launchpad/+bugs15:26
mrevellWoooo! Thanks deryck15:26
deryckmrevell, np.15:26
deryckmrevell, some minor issues still, like needing a loading symbol to indicate we're getting results, but overall, the resorting is pretty darn cool.15:27
deryckbut after the initial load, it's super fast.15:27
mrevellderyck, Cool :) What team do I need to be in the thing?15:27
mrevellSorry, that made little sense.15:28
deryckmrevell, I think matsubara added the product team to the feature flag rule.15:28
mrevellI'm not seeing the new listings so I'll hunt him down and ask him to pop me in the relevant team. Cheers.15:28
deryckmrevell, cool.  cheers.15:29
abentleyderyck: very nice.15:29
deryckthanks, abentley!15:30
jmlmrevell: in this ask ubuntu session, you'd be amazed at how much people are talking about 'reputation' (their karma equiv.) as a desirable commodity and a motivator for actions.15:57
=== beuno is now known as beuno-lunch
gmbrvba: I haven't had chance to review your branch yet, but I will do before I EoD.16:45
=== gmb changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugtasks: 266
rvbagmb: Great, it's not urgent so if you don't have the time today that's fine, I'll get it reviewed tomorrow.16:46
gmbrvba: Okay, thanks. I'll do my best though. Interviews are sucking up a lot of time for team Yellow this week.16:47
=== beuno-lunch is now known as beuno
=== Pendulum_ is now known as Pendulum
mrevellhey huwshimi21:18
thumperhi mrevell21:18
huwshimimrevell: Morning!21:18
thumpermrevell: you in orlando?21:18
thumpermrevell: is sinzui there with you?21:20
thumperI'd like to talk privacy with him21:21
mrevellthumper, sinzui is here, he arrived today21:21
mrevellthumper, and "hello" :)21:21
mrevellhuwshimi, Hey, do you want to have a catch-up call?21:21
mrevellthumper, I'm not sure where he is right now but I can let him know you want to talk.21:22
thumpermrevell: that'd be cool21:22
huwshimimrevell: Sure21:22
thumpermrevell: I'm back home now though, so it would have to be afternoon for him21:22
huwshimimrevell: 5 mins?21:22
mrevellthumper, Okeydoke. I'll let him know to contact you when I see him.21:23
mrevellhuwshimi, Sure.21:23
lifelessmrevell: allo21:23
mrevellhello lifeless21:23
jelmerhi launchpadders21:25
lifelessmrevell: have you seen the new LessJunk LEP? I haven't read it yet but given that the implementation is pretty shallow it would be worth us working through the questions I expect it raises.21:27
huwshimimrevell: Ready when you are21:29
mrevelllifeless, I've seen that it exists but not yet read it; it's been pretty full on today and yesterday. I'll take a look tonight or tomorrow morning and perhaps we can have a call tomorrow.21:29
mrevellhuwshimi, Cool. Is Skype okay?21:30
huwshimimrevell: yup21:30
lifelessmrevell: sweet21:30
huwshimimrevell: I'm getting nothing21:33
mrevellhuwshimi, Oh, weird. It was ringing for me. I'll try again21:34
huwshimimrevell: It rang and I answered, but no sound21:34
huwshimimrevell: Oh, looks like skype crashed21:34
huwshimimrevell: Try again?21:36
lifelessflacoste: dunno if you saw, but wgrant shaved a second off of ubuntu bug searches21:41
lifelessflacoste: maybe more in fact - poor behaviour on the TeamParticipation table21:42
lifelessflacoste: I going to ask stub to look into some pg innards relating to this21:42
flacostelifeless: i saw mention of a performance related feature flag earlier21:42
flacostedidn't know the details21:42
flacostebut that's excellent21:42
lifelessits a bit worrying, but good we have a workaround - I suspect table and index bloat on the table21:42
lifelessflacoste: also \o/ \o/ \o/ I'm so happy the major part of the oops arc is complete.21:44
flacosteyes, this is also awesome news!21:48
lifelessI know I mentioned it yesterday, but I'm still bouncy from it ;)21:48
poolieflacoste, all21:54
flacostehi poolie21:54
pooliehi huwshimi?22:59
poolielifeless, huw, i wonder if there should be some kind of systematic answer to whether to provide counts of objects from the thing that links to them23:37
poolielike rvb's recent bug 82793523:37
_mup_Bug #827935: Person:+branches timeouts <regression> <timeout> <Launchpad itself:In Progress by rvb> < https://launchpad.net/bugs/827935 >23:37
poolieperhaps it's just simply: do it if it's useful but not if it's too expensive23:37
lifelessI think it depends a lot on context23:43
lifelessfor instance, a dashboard telling you what things need doing it much more useful if you don't need to click through23:43
lifelessthe portlet showing high/critical/untriaged/my bugs for instance - the first three tell you things you need to action, the last one is more 'canned search' - if you see what I mean23:44
wgrantlifeless: Is lp-oops missing its 500.html again?23:48
lifelesswgrant: it hasn't been added ever23:48
lifelesswgrant: its barfing on the index page?23:48
wgrantYes.23:48
wgrantAnd all other pages.23:48
wgrantAh, no, some OOPSes work.23:48
lifelessshould wire it up with oops reporting23:49
wgrantHeh23:49
lifeless./src/oopstools/settings.py:INDEX_TEMPLATE = "index-launchpad.html"23:50
poolielifeless: yeah i like the new/high/critical things23:50
StevenKAnd then if the OOPS reporting causes an OOPS while reporting an OOPS, we reboot Launchpad.23:50
lifelesswgrant: should be fixed23:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!