| === duanedes1gn is now known as M0hi | ||
| === M0hi is now known as Guest96191 | ||
| === Guest96191 is now known as duanedesign | ||
| === lifeless is now known as subunit | ||
| === subunit is now known as lifeless | ||
| === zyga-afk is now known as zyga-really-afk | ||
| mwhudson | does u1 do some kind of checksum lookup before uploading a file? | 04:36 |
|---|---|---|
| karni | Hola! | 08:05 |
| karni | mwhudson: yes it does. it first checks if the file isn't already uploaded to U1. | 08:06 |
| mandel | morning all! | 09:21 |
| JamesTait | "What a beautiful day, hey hey, what a beautiful day!" Good morning all! :) | 09:35 |
| mandel | JamesTait, you are not allowed to be that happy in the morning.. | 09:54 |
| JamesTait | mandel: At 6:45 this morning, I wasn't. :-P | 09:55 |
| mandel | JamesTait, you are not allowed to be awake that early in the morning :P | 09:55 |
| JamesTait | mandel: At 6:45 this morning, I wasn't. :-D | 09:55 |
| mandel | hahaha | 09:56 |
| * mandel coffee | 10:15 | |
| === zyga is now known as zyga-afk | ||
| * mandel back | 10:46 | |
| gatox | hi | 10:56 |
| mandel | gatox, hola | 11:04 |
| gatox | mandel, como va? | 11:04 |
| mandel | gatox, ok, but remember, we have to use eng here.. at least until we conquer the world, then we can switch to spanish :) | 11:05 |
| gatox | jejej | 11:05 |
| mandel | gatox, on, I hate Mac Os X lion, worst thing EVER | 11:07 |
| mandel | my laptop has been acting funny since I upgraded :( | 11:08 |
| gatox | mandel, really???? i'm not a mac fan... but those things tend to work fine | 11:08 |
| gatox | mandel, i think you have problems with the universe jejjej | 11:09 |
| gatox | :P | 11:09 |
| mandel | gatox, nah, terrible, is the stupid mac | 11:10 |
| gatox | mandel, buy an alienware! :P | 11:10 |
| mandel | gatox, I have a one already until you pay me back hehe | 11:10 |
| gatox | jejjeej true | 11:11 |
| mandel | gatox, I think my main issues is the lack of main memory this machine has and how vmware-vmx does things.. 4gb or RAM is not enough | 11:13 |
| mandel | gatox, on my desktop running ubuntu I can have 5 vms running with 8gb of RAM and 16 for SWAP in an SSD and I have no issues | 11:13 |
| gatox | mandel, yes.... have 4gb too and that's part of my problems | 11:13 |
| gatox | that's why i needed to bought another notebook | 11:13 |
| mandel | gatox, If 3 years ago you said that I would not believe it.. | 11:15 |
| mandel | gatox, our main issues are the stupid vms | 11:15 |
| gatox | mandel, yes.... | 11:15 |
| rye | Hi all, anybody here with Nexus One? | 11:53 |
| * Chipaca points at beuno | 12:07 | |
| ralsina__ | good morning! | 12:33 |
| beuno | rye, yes, me, nexus one | 12:36 |
| rye | beuno, ah, u1f works for you :) | 12:37 |
| * mandel wants to puch the twited reator in the face! | 12:41 | |
| beuno | rye, it does :) | 12:46 |
| gatox | mandel, i think i found where the problem in the test might be!!! :D i couldn't be happier (unless i'm wrong...... so i'm going to be really depress) jeejeje | 13:30 |
| mandel | gatox, lucky you! I got them fixed with the first u1trial version I just installed trunk on windows and they fail | 13:31 |
| mandel | stupid dirty reactor! | 13:31 |
| gatox | mandel, :S crap! | 13:31 |
| * mandel lunch | 13:47 | |
| nessita | hello all | 13:57 |
| alecu | hola nessita! | 13:57 |
| dobey | hola nessita | 13:58 |
| nessita | hey guys, I'm not feeling that well, I feel a ball stucked in my throat and it hurts a lot when I swallow | 13:58 |
| nessita | I will be here closing some stuff and in the meeting, of course (but in mute-mode) | 13:59 |
| nessita | dobey: what you wanna release today? I'm happy to help | 14:00 |
| gatox | nessita, hi | 14:00 |
| dobey | nessita: stuff for precise | 14:01 |
| nessita | dobey: ok, what shall I tackle? | 14:01 |
| nessita | what project, I mean | 14:02 |
| dobey | nessita: actually; let's work out milestone/release scheduling for the cycle, and set up all the milestones first; almost forgot that we should do that :) | 14:03 |
| nessita | dobey: you mean for "future" bugs, right? not already solved ones? | 14:03 |
| dobey | nessita: i mean for stable-3-0; currently solved bugs should also get targeted to stable-3-0 and the 3.0.0 milestone, if they're in stable-3-0 already | 14:05 |
| nessita | right | 14:06 |
| nessita | dobey: for already committed bugs, I have a script to do that | 14:06 |
| dobey | also, i guess i should write up an e-mail to the list about all the stable branches and how people should go about proposing fixes from now on | 14:06 |
| nessita | dobey: yes, though I started that conversation already with ralsina and Chipaca, let me see if they answered | 14:06 |
| dobey | oh | 14:07 |
| Chipaca | dobey: it's a conversation coming your way rsn | 14:07 |
| nessita | dobey: we wanted to have a first proposal for the team | 14:07 |
| nessita | dobey: right, so we can have your feedback on that | 14:07 |
| nessita | Chipaca: any news on that front? | 14:07 |
| dobey | Chipaca: sure; i'd expect an "ask dobey" response to that question anyway :) | 14:08 |
| joshuahoover | rye: do you think you can add to the description of bug #874501 justification for the sru? i think you're probably the most knowledgeable about that particular bug at this point :) | 14:10 |
| ubot4 | Launchpad bug 874501 in gnome-keyring (Ubuntu Oneiric) (and 2 other projects) "couldn't prepare to write out keyring (affects: 4) (dups: 1) (heat: 28)" [High,Confirmed] https://launchpad.net/bugs/874501 | 14:10 |
| Chipaca | nessita: it was in view of your email that i asked roberto and phil to have the "QA abuse prevention" meeting yesterday | 14:11 |
| Chipaca | nessita: still waiting to hear back from that | 14:12 |
| nessita | Chipaca: wasn't aware of that, thanks for the update | 14:12 |
| pfibiger | we started it and roberto had internet troubles | 14:12 |
| pfibiger | continuing today | 14:12 |
| Chipaca | ugh, ok | 14:12 |
| dobey | does google calendar not support custom recurrance? | 14:13 |
| Chipaca | nessita: not much of an update. trying to get clarity around the more handwavy "and QA does this" steps | 14:13 |
| Chipaca | dobey: it does | 14:13 |
| dobey | Chipaca: i don't see how to do mon-fri, but NOT thurs | 14:13 |
| Chipaca | dobey: although it's not as nifty as my internet provider's billing recurrence options | 14:13 |
| Chipaca | ("the third day after the full moon") | 14:14 |
| dobey | heh | 14:14 |
| Chipaca | dobey: set it to "weekly", and you'll get checkboxes for the days | 14:14 |
| dobey | ah | 14:14 |
| rye | wooot? NO SRU YET? | 14:15 |
| nessita | rye: for what? | 14:15 |
| Chipaca | dobey: not particularly obvious, unless you think about it in a particular way :) | 14:15 |
| dobey | rye: for valueerror? it's in oneiric-proposed | 14:15 |
| dobey | Chipaca: i'll try to think more like a google UXer more often in my daily life | 14:16 |
| alecu | Chipaca, if they charge you by moons that means they'll be charging you an extra month every 3 years! | 14:16 |
| Chipaca | alecu: they charge me based on used, alone | 14:17 |
| Chipaca | usage* | 14:17 |
| rye | dobey, no, for gnome-keyring overflowing due to random number generator used | 14:17 |
| Chipaca | alecu: in fact, they charge me based on how much i download. I can upload for free. | 14:17 |
| dobey | rye: oh, nice | 14:17 |
| rye | joshuahoover, hm, I see ther update sent to precise, there is nothing about SRU for Oneiric? | 14:17 |
| dobey | sigh, google calendar. you are such complete fail | 14:18 |
| joshuahoover | rye: see the last comment on the bug...it's not going into proposed until we get address the potential for regressions caused by the fix...need a justification that takes that into account | 14:18 |
| rye | joshuahoover, aha, i understand what to do | 14:18 |
| joshuahoover | rye: :) | 14:19 |
| rye | joshuahoover, well, for oneiric we need only one fix (well, at least until somebody else wants more fixes) | 14:19 |
| Chipaca | dobey: now what? | 14:19 |
| joshuahoover | rye: not sure what that means...is there more than one fix in that patch? | 14:20 |
| rye | joshuahoover, duanedesign, by the way - if user claims a note was deleted but it is still present as "Notename deleted" in recent items on /notes/ then yes - we can recover it, when on beautyberry - then with l0sa help, when on other hosts - the users can do that themselves with ubuntuone-couchdb-undelete | 14:20 |
| rye | joshuahoover, in that patch - no. But the one ken proposed to precise - lots of other | 14:21 |
| joshuahoover | rye: ah, i see | 14:21 |
| Chipaca | rye: the ability to do it themselves will go away soon | 14:21 |
| nessita | dobey: any idea why the stable-3-0 are not landing yet? do we need to 'restart' something for the config to work? | 14:21 |
| dobey | Chipaca: editing another event that should recur, but which does not; however i see no way to make it recurring | 14:22 |
| dobey | nessita: maybe sidnei didn't redeploy the client tarmac instances? | 14:22 |
| nessita | dobey: sounds like it | 14:22 |
| ralsina | good morning everyone, sorry about being late, my internet at home is dead, am at a bar | 14:23 |
| Chipaca | dobey: checkbox that says [ ] Repeat... ? | 14:23 |
| dobey | Chipaca: also, it seems the one i successfully edidted and removed thursday from, still occurs on thursdays :( | 14:23 |
| Chipaca | dobey: belo title and from/to fields | 14:23 |
| dobey | Chipaca: i see no such checkbox | 14:23 |
| dobey | there is only an all day checkbox there | 14:24 |
| nessita | ralsina_: hola | 14:24 |
| Chipaca | dobey: repeat should be next to it | 14:24 |
| Chipaca | dobey: maybe you're using gtkhtml :) | 14:24 |
| dobey | Chipaca: right. it's not :) | 14:24 |
| dobey | no, firefox | 14:24 |
| dobey | gtkhtml, i probably wouldn't even be looking at google calendar :) | 14:25 |
| ralsina | alecu: ping, sorry I missed 1-1, was internet-less. Could we reschedule? | 14:29 |
| rye | Chipaca, that is schrödinger to know. | 14:29 |
| alecu | ralsina: sure | 14:29 |
| dobey | oh the other one says (Still saving changes...) | 14:29 |
| dobey | how efficient of you, google | 14:29 |
| dobey | delete and recreate let me make a recurring event though | 14:30 |
| joshuahoover | rye: can you work out that sru (874501) with kenvandine to figure out what we need to do to get the fix in for oneiric? sounds like maybe we need less to go in for o for the fix | 14:30 |
| mandel | alecu, ping | 14:50 |
| alecu | mandel, pong | 14:51 |
| mandel | alecu, do you have the time to give me a hand with some failing tests in sso | 14:52 |
| alecu | mandel, we are about to have our team meeting, right? | 14:52 |
| alecu | mandel, can we do it after that? | 14:52 |
| alecu | mandel, anyway, if you point me at the branch I can take a look | 14:52 |
| mandel | alecu, we have standup at 4 and team meeting at 4:30 so its sounds good to do it after that | 14:53 |
| mandel | alecu, I'll push it and we can take a look after | 14:53 |
| ralsina | we can skip standup today | 14:53 |
| alecu | mandel, we don't have standup today: just team meeting | 14:53 |
| ralsina | the idea was that on weekly meeting day there is no standup | 14:53 |
| alecu | mandel, it's at the same time. | 14:53 |
| mandel | alecu, really, cool :D | 14:53 |
| mandel | I was going to say that having both was stupid hehe | 14:54 |
| alecu | mandel, we have only team meeting, at 4pm your time. So, in 5 minutes! | 14:54 |
| mandel | oh, getting in mumble then | 14:55 |
| dobey | ah it is nigh time eh | 14:56 |
| ralsina | I just dropped half a glass of sprite on the keyboard. Seems to be working though! | 14:59 |
| dobey | ralsina: after the meeting you are going to want a new keyboard. | 15:01 |
| ralsina | dobey: it's my notebook's keyboard :-/ | 15:01 |
| dobey | sticky-keys ftl | 15:01 |
| dobey | nessita: mumble? | 15:02 |
| nessita | dobey: yes, going! | 15:02 |
| nessita | :-) | 15:02 |
| dobey | :) | 15:02 |
| duanedesign | someone ping me? | 15:06 |
| duanedesign | <.< >.> | 15:06 |
| nessita | duanedesign: ping | 15:11 |
| nuffigel | hey everyone, whats the default way to install an ubuntu one client on an X-less gentoo machine? There is a gentoo-ubuntu-one overlay, but it ships only the gui version that requires nautilus and, thereby, all of gnome | 15:11 |
| nessita | duanedesign: you wanted a ping? :-) | 15:11 |
| duanedesign | :) | 15:12 |
| duanedesign | nuffigel: well you can just not install ubuntuone-gnome and you will not have to install nautilus | 15:13 |
| duanedesign | then run Ubuntu One from the command line with u1sdtool | 15:13 |
| nuffigel | duanedesign: hmm, apparently, this is not supported by the overlay, guess I'll have to compile by hand? | 15:15 |
| nuffigel | duanedesign: well, thanks so far, it gets me on the way i suppose :] | 15:19 |
| duanedesign | nuffigel: Chipaca might be able to help more. I think he had dome this before | 15:23 |
| Chipaca | me? nevah! | 15:23 |
| * Chipaca reads | 15:23 | |
| duanedesign | this == install U1 on an X-less box | 15:23 |
| Chipaca | ah. no. | 15:23 |
| Chipaca | I did something different, which doesn't count as installing ubuntu one | 15:24 |
| duanedesign | oop. I was mistaken. Not the first time :) | 15:24 |
| Chipaca | nuffigel: you can get the bzr bits, and pass in the needed keys and such as commandline args (or config options) so that dbus isn't necessary, and you're set | 15:24 |
| Chipaca | nuffigel: it's not rocket science, but it is probably comparable to the more boring parts of material science | 15:25 |
| Chipaca | materials* | 15:25 |
| duanedesign | :) | 15:25 |
| ralsina | mandel: fumón! | 15:33 |
| dobey | Chipaca: dbus is necessary, but keyring isn't (if you already have a token and shove it in the config file instead) | 15:33 |
| ralsina | nuffigel: ubuntu one doesn't really work without X | 15:34 |
| mandel | alecu, got time? | 15:34 |
| ralsina | nuffigel: it requires gnome-keyring, so you won't be able to authenticate without X. Sorry. | 15:34 |
| mandel | alecu, I have a very first small question, the tearDown from unittest.trial.TestCase it returns a deferred, right? cause in our tests on windows is not (twisted 11.0.0) | 15:35 |
| dobey | mandel: no. but it expects anything deriving from it to probably return a deferred, if overriding tearDown | 15:40 |
| dobey | mandel: but the new u1trial should catch all the cases where that is an issue | 15:40 |
| mandel | hm.. | 15:41 |
| alecu | mandel, you should return a deferred from a tearDown (probably the one returned from super().tearDown) | 15:49 |
| alecu | mandel, or decorate your tearDown with @inlineCallbacks and yield on the deferred returned by super().tearDown | 15:50 |
| alecu | mandel, the same goes for setUp | 15:51 |
| dobey | you need to inlinecallbacks and yield the super; but like i said, u1trial complains about that now :) | 15:51 |
| mandel | alecu, I'm doing that and in theory it should be removing the selectables but aint working, let me paste you the setup and teardown | 15:51 |
| alecu | mandel, great | 15:51 |
| alecu | dobey, that sounds very useful. How are you doing it? | 15:52 |
| mandel | dobey, alecu take a look: http://paste.ubuntu.com/741300/ | 15:52 |
| alecu | dobey, is it just complaining when tearDown does not return a deferred? | 15:52 |
| mandel | alecu, we inspect the testsuit to check if you do call the suer etc.. | 15:53 |
| alecu | mandel, can you paste the error too? | 15:53 |
| mandel | alecu, dirty reactor, but sure | 15:53 |
| mandel | alecu, with example error: http://paste.ubuntu.com/741302/ | 15:54 |
| alecu | mandel, the that's not disconnected is self.client_factory | 15:55 |
| alecu | mandel, and the one that's being disconnected in tearDown is self.server_factory | 15:55 |
| alecu | mandel, the key point is here: 'twisted.internet.tcp.Client'> | 15:56 |
| mandel | alecu, but in line 17 there is and addCleanup | 15:56 |
| mandel | alecu, that should be taking care of the TcpClient (I actually moved it from the tearDown to the cleanup to see if it helped) | 15:58 |
| alecu | mandel, http://mumak.net/stuff/twisted-disconnect.html | 15:58 |
| alecu | "In order to clean up a test that connects a client to a server, you need to wait on three Deferreds: one for the listening port, one for the server protocol and one for the client protocol." | 15:58 |
| alecu | mandel, it has bitten me a few times, and I worked around it. But I just found this link that explains it very clearly. | 15:59 |
| mandel | alecu, that is the link I read yesterday, aint working :( | 16:00 |
| mandel | alecu, our current implementation follows the save protocol implementation found int he twisted.pb test cases to tearDown | 16:00 |
| mandel | alecu, but we have bug 885342 | 16:01 |
| ubot4 | Launchpad bug 885342 in ubuntu-sso-client "Tests failing in SSO (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/885342 | 16:01 |
| alecu | looking | 16:01 |
| joshuahoover | nessita, rye, dobey, duanedesign: i tested the sru for bug #872924 and it looks good, changed the tag to verification-done | 16:01 |
| ubot4 | Launchpad bug 872924 in ubuntuone-client (Ubuntu Precise) (and 5 other projects) "Resuming a failed upload crashes with ValueError: I/O operation on closed file (affects: 24) (dups: 3) (heat: 136)" [Critical,Fix released] https://launchpad.net/bugs/872924 | 16:01 |
| mandel | alecu, take a look at trunk and you will se the implementation that fails, is very very similar except for the SaveProtocol stuff | 16:02 |
| dobey | alecu: it should afaik | 16:02 |
| duanedesign | joshuahoover: awesome | 16:03 |
| rye | (?P<oopsprefix>[a-z]+|[a-z]+\d+[a-z]+) | 16:05 |
| rye | GRRRR! | 16:05 |
| mandel | alecu, in those tests we also have a diff but where we d not call mocker.restore() but has nothing to do with that issue | 16:05 |
| rye | i am stupid | 16:07 |
| mandel | alecu, run of the tests and example code: http://paste.ubuntu.com/741310/ | 16:07 |
| mandel | alecu, some of them fail some do not due to a dirty reactor, which I don't understand, if the reactor is dirty it should happend for all of them, right? | 16:08 |
| rye | OOPS-ID- is wrong, it is OOPS- | 16:08 |
| ubot4 | https://lp-oops.canonical.com/oops.py/?oopsid=ID | 16:08 |
| alecu | mandel, not really | 16:08 |
| alecu | mandel, trial makes sure the reactor is clean after each test run. | 16:09 |
| alecu | mandel, that way you can be sure you are not leaking *other* stuff in the reactor. | 16:09 |
| mandel | alecu, and the teardown executes after every test.. so either the tests that fail are broken of the tearDown should be doing the job correctly | 16:10 |
| nessita | ok guys, I'm off to the bed | 16:14 |
| dobey | nessita: get well | 16:15 |
| nessita | please talk to ralsina anything you need from me, I tried to gave him all the details about all the pending stuff | 16:15 |
| mandel | nessita, mejorate! | 16:15 |
| nessita | gatox: please make sure alecu review your unicode branch, since he was the last one working on this :-) | 16:15 |
| nessita | mandel: thanks! | 16:15 |
| gatox | nessita, yes... get better! | 16:15 |
| nessita | ok, see ya all on Nov, 30th, though I will be stepping by tomorrow to answer any question/pending stugg | 16:16 |
| alecu | nessita, get well | 16:16 |
| nessita | stuff* | 16:16 |
| nessita | bye! | 16:16 |
| alecu | bye! | 16:16 |
| mandel | alecu, we have the same issue in the tcpactivation tests which might be easier to debug | 16:17 |
| alecu | mandel, have you read the last example in the article on mumak's blog? | 16:21 |
| gatox | luncch! brb | 16:21 |
| mandel | alecu, you mean the one with TestDisconnect, yes | 16:22 |
| alecu | mandel, I think that if we apply that pattern to every test where we connect a client to a server we could get rid of many of the timing issues in tests | 16:22 |
| alecu | mandel, well, looking at your example, it's missing a few things that are done on that last example. | 16:23 |
| mandel | alecu, yes, I did not follow the exact code.. I give a try with that | 16:23 |
| * mandel gets to it | 16:23 | |
| alecu | mandel, the thing to remember is that there are *three* deferreds we should be waiting on... that's why it uses gatherResults | 16:24 |
| alecu | mandel, we should yield once on a gatherResults of three other functions. | 16:25 |
| alecu | mandel, also we should try to come up with a shorter way of all this that can be used in every other test | 16:27 |
| alecu | mandel, I'm thinking of something that's used like: | 16:27 |
| alecu | cleanupDisconnection(testcase, server, client) | 16:28 |
| alecu | mandel, and that it automatically monkeypatches the "connectionMade" and "connectionLost" methods, and uses addCleanup on the testcase. | 16:29 |
| mandel | alecu, and add it as a method for the base test case class, makes sense | 16:30 |
| mandel | alecu, although that would have to be done in the test case from u1-dev-tools, right? so that we can use it everywhere | 16:30 |
| alecu | mandel, perhaps. I'm still not sure what object would "client" and "server" be, and if we should pass some other stuff too. | 16:31 |
| mandel | alecu, lets first fix this guys, if it works lets chat with natalia to add it everywhere, ok? | 16:31 |
| alecu | mandel, right | 16:32 |
| alecu | ok, it's lunchtime for me too! | 16:32 |
| alecu | bbl | 16:32 |
| mandel | I'm going to call it a 20 min early EOD, catch you all tom | 16:36 |
| ralsina | lunch! | 16:48 |
| dobey | lunch, bbiab | 18:12 |
| alecu | gatox, ralsina: can I get trivial reviews on the two branches in this bug? | 18:26 |
| alecu | https://bugs.launchpad.net/ubuntu-sso-client/+bug/891644 | 18:26 |
| ubot4 | Launchpad bug 891644 in ubuntuone-storage-protocol (and 1 other project) "Use /api/time to do the timesync (affects: 1) (heat: 6)" [Low,In progress] | 18:26 |
| gatox | alecu, on it | 18:26 |
| ralsina_ | alecu: sure | 18:27 |
| gatox | FINALLY!!! my unicode fixes branch is ready! | 18:36 |
| alecu | gatox, congratx! | 18:37 |
| gatox | alecu, thanks..... i couldn't be happier :P | 18:37 |
| gatox | alecu, but probably this is not the end jeje | 18:38 |
| gatox | alecu, i'm reviewing your branches..... i don't know where to began! jeejje | 18:45 |
| gatox | +1 on both :P | 18:45 |
| alecu | gatox, very complicated branches, right? | 18:46 |
| alecu | :-) | 18:46 |
| gatox | alecu, i'll have a present for you...... wait..... i'm waiting for launchpad to rescan this branch :P | 18:47 |
| * alecu covers his head with both hands! | 18:47 | |
| alecu | please no unicode branches this week!!! | 18:47 |
| gatox | alecu, emmmmm...... i'm seeing unicode branches for the last 2 weeks almost jejeje | 18:48 |
| alecu | gatox, yes, I know. And you are suffering them DAILY! | 18:48 |
| ralsina_ | alecu: trivial, setting to approved | 18:49 |
| gatox | alecu, true true...... but ALSO i get the chance to read and understand a lottttttt of the code in u1-client.. | 18:49 |
| alecu | gatox, cool! | 18:49 |
| gatox | ralsina, alecu unicode review please: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/unicode-issues/+merge/82586 | 18:49 |
| gatox | :D | 18:49 |
| alecu | ralsina_, thanks! | 18:49 |
| ralsina_ | gatox: I don t have any slots today, need to prep the release for tomorrow :-/ | 18:50 |
| gatox | ralsina, no problem! | 18:50 |
| gatox | alecu, when you review it, you will find that some lines are just pep8 fixes..... it was stronger than me :P..... i'll propose another branch later fixing pep8 issues in u1-client again and added the pep8 checker to the test..... i talked about that with nessita | 18:52 |
| alecu | gatox, sounds like a great time to add these kinds of checks | 18:52 |
| alecu | gatox, but I'll tell you the same that I tell nessita about these kind of fixes: please do a separate branch for it. | 18:53 |
| alecu | gatox, so we don't mix functionality with style fixes | 18:53 |
| gatox | alecu, yes obviusly!! now some pep8 fixes get mix with this branch..... but the idea is to make a new branch for that fix | 18:53 |
| alecu | gatox, ok, great. | 18:53 |
| alecu | gatox, why did you comment the method "test_upgrade_None_to_last_phantom_share_path" in test_vm.py ??? | 19:16 |
| gatox | alecu, uhhhhhhhhhhhhh sorry, that was for testing! | 19:16 |
| gatox | reverting... | 19:16 |
| alecu | it looked like :-) | 19:16 |
| alecu | gatox, a typo repeated a few times in test_os_helper: "funcion" (it should be "function") | 19:19 |
| gatox | alecu, fixed commented code | 19:19 |
| * gatox looking at typo | 19:20 | |
| alecu | gatox, also, test_expand_user_fails_if_not_bytes and the one below it have no docstring | 19:20 |
| * gatox fixing... | 19:21 | |
| nuffigel | soo, i installed ubuntuone-client from source and it says "ImportError: No module named ubuntuone.platform.linux.tools" - guess the configure script is somehow broken (it should check for the python module, shouldn't it?). Anyways, where can I get this python module? Oh, I'm running gentoo x64 | 19:21 |
| dobey | nuffigel: that module is from ubuntuone-client | 19:23 |
| nuffigel | weird, then something must be wrong with my install i guess, thanks | 19:23 |
| dobey | nuffigel: so likely, an installation issue :) | 19:23 |
| nuffigel | dobey: do you know what file? | 19:24 |
| dobey | it's probably not a single file, but a general issue | 19:25 |
| gatox | alecu, all fixed | 19:25 |
| dobey | knowing how it was built/installed exactly (commands used), would probably be helpful though | 19:25 |
| dobey | also, i have no idea what python gentoo uses by default | 19:26 |
| dobey | that could also be an issue | 19:26 |
| alecu | gatox, the body of MetadataTestCase.check_version is commented and there's only a "pass" | 19:26 |
| nuffigel | I think i got it, installed in /usr/local instead of /usr - stupid mistake of me | 19:26 |
| nuffigel | dobey: yeah, that was it, its now asking for "ubuntu_sso.xdg_base_directory" | 19:27 |
| gatox | alecu, done..... sorry.... all the test are ok anyhow.... i re-tested everything | 19:28 |
| alecu | gatox, the piece of code used to set the USER_SID might look better in it's own function. | 19:31 |
| alecu | and it might even get some tests | 19:31 |
| alecu | it's -> its | 19:31 |
| gatox | alecu, okkkkkk, refactoring that | 19:32 |
| alecu | gatox, does it makes sense? | 19:32 |
| dobey | nuffigel: you need ubuntuone-storage-protocol and ubuntu-sso-client also | 19:32 |
| gatox | alecu, yes, i know what you mean | 19:32 |
| nuffigel | dobey: yeah I got storage-prot but sso-client has a strange install thingy | 19:33 |
| alecu | gatox, and also we are not leaving variables like process_handler and security_info in the os_helper namespace | 19:33 |
| dobey | nuffigel: strange how? | 19:34 |
| nuffigel | dobey: there is just a setup.py and it needs some more modules (mocker and pythoncom) | 19:35 |
| === JanC_ is now known as JanC | ||
| alecu | gatox, other than that, the branch looks great. I've just finished reviewing it. | 19:35 |
| nuffigel | dobey: I'm kinda spoiled by automake i guess ^^ | 19:35 |
| dobey | nuffigel: it doesn't need those. it does need python-distutils-extra | 19:36 |
| gatox | alecu, great!! thanks!!..... with: "and also we are not leaving variables like process_handler and security_info in the os_helper namespace" you mean if we put everything inside a function, right? | 19:36 |
| nuffigel | dobey: I have python-distutils-extra version 2.23 installed | 19:36 |
| dobey | nuffigel: then ./setup.py install should work fine as normally would | 19:37 |
| dobey | nuffigel: mocker is needed to run tests; and pythoncom is needed on windows only | 19:37 |
| nuffigel | dobey: hmm but it does say "ERROR: Python module mocker not found" and "ERROR: Python module pythoncom not found" and then exits with some really weird trace finishing up with the well-known "ValueError: _type_ 'v' not supported" :] | 19:38 |
| nuffigel | ill give you a paste... | 19:38 |
| nuffigel | dobey: http://paste.pocoo.org/show/509375/ | 19:40 |
| dobey | nuffigel: hrmm, i think maybe you need a newer distutils-extra | 19:45 |
| nuffigel | getting 2.31 right now... | 19:46 |
| dobey | nuffigel: there was some bug similar to that which i fixed (it may even have been that exact bug actually) :) | 19:48 |
| nuffigel | ah that would be nice :] | 19:49 |
| nuffigel | dobey: yeah, the ubuntu-sso-client setup runs now, great work - gentoo guys need to update their python-distutils-extra... | 19:52 |
| nuffigel | urgs, more problems... | 19:53 |
| nuffigel | "ImportError: No module named PyQt4.uic.Compiler" | 19:53 |
| dobey | oh | 19:53 |
| nuffigel | sounds like Qt (but no X, remember) | 19:53 |
| dobey | yeah, you'll need to install pyqt also | 19:53 |
| nuffigel | I hope it doesnt depend on Qt | 19:53 |
| dobey | if you want to run the qt ui it does (and so we need some pyqt bits at build time to generate ui) | 19:54 |
| nuffigel | dobey: hmm maybe I can disable the Qt-UI in the setup then... | 19:54 |
| alecu | gatox, yes... if we put everything in a function then we don't have those variables scattered in the file. | 19:55 |
| gatox | alecu, yep!! i'll do that as soon as i finish with this trivial branch that i'm going to propose in a few minutes | 19:56 |
| dobey | well, the ubuntu_sso.xdg_base_directory bit will be going away soon | 19:56 |
| alecu | gatox, ok. I'll wait for that change before running tests on this . | 19:56 |
| dobey | then you won't really need it to use ubuntuone-client | 19:56 |
| gatox | alecu, ok | 19:56 |
| nuffigel | dobey: ye, I'm trying to go with ./setup.py install_lib | 19:58 |
| gatox | alecu, ralsina (when you have a moment today or tomorrow) really trivial branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/congratulations-page/+merge/82596 | 20:08 |
| nuffigel | dobey: hmm, when running ./setup build_py it says http://paste.pocoo.org/show/509386/ - did it build now or not? (warnings aren't errors, right?) | 20:08 |
| alecu | gatox, trivial like mine? | 20:08 |
| gatox | alecu, jejeje not so much...... but close | 20:08 |
| alecu | gatox, 108 lines (+23/-19) 3 files modified | 20:08 |
| alecu | gatox, not even close! | 20:09 |
| gatox | alecu, but one file is .ui, and the other .qss | 20:09 |
| gatox | ah no..... not .qss | 20:09 |
| dobey | nuffigel: none of those are actually errors | 20:10 |
| dobey | nuffigel: that output is basically normal | 20:10 |
| alecu | gatox, the docstring on test_congratulations_page_title looks like copypasta | 20:12 |
| gatox | alecu, mmmmm...... do you think? | 20:12 |
| gatox | :P | 20:12 |
| nuffigel | dobey: ah i see, there is a "--verbose" flag :] | 20:12 |
| gatox | alecu, fixed | 20:14 |
| nuffigel | dobey: hmm, running u1sdtool it still backs out with http://paste.pocoo.org/show/509387/ although xdg_base_directory seems to be installed okay | 20:14 |
| gatox | ok...... eod for me! | 20:15 |
| gatox | see you tomorrow!! :D | 20:15 |
| gatox | bye alecu | 20:15 |
| alecu | bye gatox! | 20:15 |
| dobey | nuffigel: where is ubuntu_sso installed to? | 20:21 |
| nuffigel | /usr/lib64/python2.7/site-packages/ubuntu-sso-client/ubuntu_sso/ | 20:22 |
| dobey | nuffigel: is there an ubuntu-sso-client.pth file in the site-packages directory as well? | 20:23 |
| nuffigel | dobey: nope, nowhere to be found | 20:24 |
| dobey | nuffigel: that's your problem then :) | 20:25 |
| nuffigel | dobey: there is, however: /usr/lib64/python2.7/site-packages/ubuntuone-client.pth | 20:25 |
| nuffigel | dobey: ah good to know :] | 20:25 |
| dobey | nuffigel: you did install_lib which didn't install everything i guess | 20:25 |
| dobey | nuffigel: you can copy it over from the ubuntu-sso-client source directory though | 20:25 |
| nuffigel | sounds good | 20:26 |
| nuffigel | if it was there, that is | 20:26 |
| nuffigel | ~/src/ubuntu-sso-client-1.3.3 $ find -iname "*.pth" <-- returns nothin | 20:26 |
| dobey | 1.3.3? | 20:27 |
| nuffigel | that a problem? | 20:27 |
| dobey | well it's not the latest release | 20:27 |
| nuffigel | according to https://launchpad.net/ubuntu-sso-client it is | 20:27 |
| dobey | though i'm pretty sure the pth was added before 1.3.3 | 20:27 |
| dobey | nuffigel: launchpad is unfortunately not very smart about showing releases :( | 20:28 |
| nuffigel | ah okay, my expectancies are just too high :] | 20:29 |
| dobey | https://launchpad.net/ubuntu-sso-client/stable-1-4 shows something else, for example :) | 20:29 |
| nuffigel | tar -tf ubuntu-sso-client-1.3.3.tar.gz | grep pth <-- returns nothin btw | 20:29 |
| nuffigel | getting the 1.4 version then... | 20:30 |
| dobey | nuffigel: it's not there; but the problem is because you did install_lib instead of install | 20:31 |
| dobey | nuffigel: you can just echo "ubuntu-sso-client" > ubuntu-sso-client.pth and put that in your site-packages dir | 20:32 |
| nuffigel | kk will do that | 20:32 |
| nuffigel | dobey: I'm sorry to bother you this much... | 20:33 |
| nuffigel | dobey: here's your output of u1sdtool now: http://paste.pocoo.org/show/509395/ | 20:33 |
| dobey | nuffigel: do you not have twisted installed? | 20:34 |
| nuffigel | I got twisted in version 11.0.0 and twisted-conch also | 20:35 |
| dobey | nuffigel: you need twisted-names | 20:35 |
| dobey | i just realized it's a different source | 20:35 |
| nuffigel | ah alright, installing right now | 20:35 |
| nuffigel | hmm http://paste.pocoo.org/show/509398/ | 20:37 |
| dobey | apparently you didn't install ubuntuone-storage-protocol | 20:44 |
| nuffigel | dobey: hmm I did, but i guess its also an old version | 20:44 |
| nuffigel | dobey: its 1.1.3 | 20:44 |
| dobey | yes, every old version | 20:45 |
| nuffigel | getting 2.0.0 | 20:45 |
| dobey | nuffigel: if you're installing from source anyway, any reason to not just build from bzr branches? | 20:45 |
| nuffigel | i don't have bzr installed | 20:45 |
| nuffigel | :P | 20:46 |
| nuffigel | I didnt think it was worth the hassle until now... | 20:46 |
| nuffigel | whoa | 20:48 |
| nuffigel | u1sdtool seems to run now | 20:49 |
| dobey | cool | 20:50 |
| nuffigel | wow, you're da man, dobey - next project: teach python to check for the libs it needs and tell the user what it wants when he runs this setup.py - automake can do it :] | 20:50 |
| nuffigel | no really, thanks alot for the help | 20:50 |
| dobey | sure | 20:54 |
| nuffigel | bye guys | 21:27 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!