| huwshimi | poolie: Bug tag list is live :D | 00:19 |
|---|---|---|
| huwshimi | poolie: I know you've only been waiting 10 months for me to do it :) | 00:20 |
| rick_h_ | lol, congrat huwshimi | 00:22 |
| rick_h_ | where can I see huwshimi ? | 00:22 |
| huwshimi | rick_h_: heh, thanks :) | 00:23 |
| huwshimi | rick_h_: https://bugs.launchpad.net/launchpad/ | 00:23 |
| rick_h_ | is it the tag list on the right? | 00:23 |
| rick_h_ | with the counts? | 00:23 |
| huwshimi | rick_h_: Yeah | 00:23 |
| poolie | huwshimi, that's awesome | 00:23 |
| poolie | it doesn't look like a cat threw up :) | 00:23 |
| huwshimi | rick_h_: Not sure if you noticed, but they used to look like the left version of this: https://launchpadlibrarian.net/62993362/tag_cloud.png | 00:24 |
| rick_h_ | ah, ouch | 00:24 |
| wgrant | Hmm. | 00:24 |
| wgrant | Interesting. The sizes were meant to scale more than that. | 00:25 |
| wgrant | But it shows them all as identical... | 00:25 |
| poolie | wgrant, in the 'current'? | 00:25 |
| poolie | they did scale | 00:25 |
| wgrant | That's what I thought. | 00:25 |
| rick_h_ | huwshimi: now what about client side filtering box? :) | 00:25 |
| poolie | it did not work well because ... | 00:25 |
| poolie | well for a bunch of reasons | 00:25 |
| huwshimi | wgrant: They did scale, but the top tags were all a similar size | 00:25 |
| rick_h_ | yea, those types of tag clouds never lookd great, especially with large phrases for tags | 00:26 |
| poolie | one of them being the words are so wide relative to the portal | 00:26 |
| poolie | mm | 00:26 |
| poolie | keeping the same size and varying intensity would be better | 00:26 |
| poolie | would have been | 00:26 |
| wgrant | Yeah. | 00:26 |
| poolie | just showing the number is pretty good though | 00:26 |
| poolie | so huw while you're here | 00:26 |
| wgrant | https://code.launchpad.net/ has another odd (and woefully inconsistent with the rest of the site) cloud. | 00:26 |
| huwshimi | rick_h_: Doing the tag filter would be nice, but this was an easier win as a first stage | 00:26 |
| huwshimi | wgrant: Yeah, from memory all those landing pages have something similar | 00:27 |
| rick_h_ | huwshimi: oh yea, just helping you with stage 2 :) | 00:27 |
| poolie | wgrant, i wonder if we should just redirect that to the top home page | 00:27 |
| wgrant | Amusingly enough it also doesn't include distributions, so Ubuntu doesn't show up. | 00:27 |
| wgrant | huwshimi: No, that's the worst bit. Only code does. | 00:27 |
| poolie | maybe look at the logs to see if it is used | 00:27 |
| huwshimi | wgrant: Oh really? | 00:27 |
| poolie | i think the idea was that it would show activity | 00:27 |
| poolie | well, that was the idea | 00:27 |
| poolie | it was my idea | 00:27 |
| poolie | it is not actually doing the job very well | 00:28 |
| poolie | :/ | 00:28 |
| rick_h_ | poolie: needs a color scale as well as size maybe? | 00:28 |
| poolie | there are two mismatched shades of blue on that page too | 00:28 |
| wgrant | Some of them used to be green. | 00:28 |
| wgrant | IIRC those that didn't use codehosting officially. | 00:28 |
| huwshimi | wgrant: it seems you're right | 00:28 |
| wgrant | Can't quite recall, though. | 00:28 |
| wgrant | https://code.launchpad.net/ also has the 1.0 buttons. | 00:28 |
| wgrant | Ew | 00:28 |
| wgrant | Tempting to remove the subdomains tomorrow, but that might be a bit controversial. | 00:29 |
| rick_h_ | heh, #03a and blue | 00:29 |
| huwshimi | wgrant: yeah a few of the landing pages have those buttons | 00:29 |
| lifeless | wgrant: on a saturday? yes, 'might' be | 00:29 |
| rick_h_ | hey, it's friday | 00:30 |
| huwshimi | wgrant: Actually all but bugs do | 00:30 |
| rick_h_ | always good to change right before the weekend and then hide | 00:30 |
| StevenK | rick_h_: O hai. You haz QA. | 00:30 |
| rick_h_ | StevenK: yep, am I holding up anything? Been afk for the holiday today. | 00:31 |
| huwshimi | wgrant: I'm definitely buy a beer for anyone who removes subdomains | 00:31 |
| StevenK | rick_h_: There's only three revisions, in the queue. | 00:31 |
| StevenK | s/,// | 00:31 |
| wgrant | The only sticking point is the breadcrumbs. | 00:31 |
| StevenK | rick_h_: So I don't care much. | 00:31 |
| rick_h_ | StevenK: ok if I get it in the morning then? | 00:31 |
| wgrant | Everything else is mostly a matter of deleting code. | 00:31 |
| rick_h_ | StevenK: ok awesome, will hit it up first thing | 00:32 |
| StevenK | rick_h_: If you're at work on your Friday, that sounds great. | 00:32 |
| rick_h_ | StevenK: yep, will be. New guys don't have all that banked vaca :) | 00:32 |
| StevenK | Haha | 00:32 |
| poolie | wgrant, getting everything on one domain so that it can run from a single ip without /etc/hosts futzing would be awesome | 00:32 |
| rick_h_ | wgrant: you know, I've used LP on and off for years and only *just* noticed the breadcrumbs the other day | 00:32 |
| wgrant | The breadcrumbs have been through a few iterations. | 00:33 |
| rick_h_ | caught me totally out of the blue | 00:33 |
| wgrant | This last variety has been in place for nearly 2.5 years, and is extremely subtle. | 00:33 |
| wgrant | And confusing to an extent. | 00:33 |
| wgrant | poolie: Indeed. | 00:33 |
| StevenK | That requires ripping out vostok | 00:34 |
| StevenK | Which might make mwhudson sad. | 00:34 |
| wgrant | There's a branch for that.™ | 00:34 |
| rick_h_ | <3 I think I have a new email sig | 00:34 |
| * huwshimi contemplates pie incentive to have subdomains removed by Budapest, or the end of Budapest | 00:34 | |
| lifeless | StevenK: vostok can be deleted | 00:34 |
| poolie | what's a vostok? | 00:35 |
| wgrant | vostok is Linaro's aborted attempt at making a standlone Soyuz. | 00:35 |
| lifeless | poolie: we can't run on one domain safely, ever. But we can shrink the number :) | 00:35 |
| * rick_h_ is grepping around too, I know I've run into that | 00:35 | |
| wgrant | lifeless: Well. | 00:35 |
| lifeless | StevenK: I was discussing nuking vostok with mwhudson the other day. | 00:35 |
| poolie | lifeless, you're talking about librarians, ppas, etc? | 00:35 |
| wgrant | lifeless: The webapp can be on a single domain. | 00:35 |
| lifeless | wgrant: launchpadlibrarian | 00:35 |
| wgrant | And that's the main thing. | 00:35 |
| poolie | ok | 00:35 |
| wgrant | launchpadlibrarian is not user-facing. | 00:35 |
| wgrant | In the important sense. | 00:35 |
| lifeless | wgrant: internalxmlrp | 00:35 |
| poolie | perhaps for demo purposes it would be ok to have it on the same domain | 00:35 |
| lifeless | wgrant: and the public xmlrpc too | 00:36 |
| lifeless | wgrant: and apis | 00:36 |
| poolie | if there is no untrusted or important data | 00:36 |
| poolie | huwshimi, while i've got you | 00:36 |
| huwshimi | poolie: Yup, here | 00:36 |
| wgrant | In dev I imagine they would just run on different ports. | 00:36 |
| poolie | some time i'm going to land the initial markdown thing | 00:36 |
| poolie | for people and products | 00:36 |
| poolie | i guess i feel i want a thumbs up/down from you | 00:36 |
| lifeless | wgrant: perhaps; I'd be keen for dev to just use ip addresses for all the services. | 00:37 |
| wgrant | lifeless: Sure, but that requires lots of config unless you run everything on loopback. | 00:37 |
| wgrant | Which is limiting. | 00:37 |
| huwshimi | poolie: A massive thumbs up for the spirit of it, is there anything in particular you want validation on? | 00:37 |
| lifeless | wgrant: why ? | 00:37 |
| wgrant | lifeless: My machine has one non-loopback IPv4 address. | 00:37 |
| wgrant | My VMs, too. | 00:37 |
| poolie | just that the list of 'do later' things on the bug and mp are ok | 00:37 |
| lifeless | wgrant: ...and ? | 00:37 |
| wgrant | lifeless: We can't run services on separate IP addresses if there's only one IP address. | 00:38 |
| rick_h_ | StevenK: where do you go to see the pending QA and such? | 00:38 |
| poolie | huwshimi, the other thing is | 00:38 |
| StevenK | rick_h_: The deployment report. | 00:38 |
| lifeless | wgrant: I didn't intend to imply separate ip addresses | 00:38 |
| StevenK | rick_h_: http://lpqateam.canonical.com/qa-reports/deployment-stable.html | 00:38 |
| StevenK | rick_h_: Know it, love it. | 00:38 |
| poolie | i was contemplating, when my current lp discretionary hacks are finished, doing a really cheap timeline that just shows all the comments on bugs i'm subscribed to | 00:38 |
| wgrant | lifeless: Ah, so separate ports, like I said. Sounds good, and is what I had planned. | 00:38 |
| poolie | in reverse chronological order | 00:39 |
| lifeless | wgrant: and no domains | 00:39 |
| poolie | this seems | 00:39 |
| wgrant | Sure. | 00:39 |
| lifeless | wgrant: so an ip address on ec2 just works. | 00:39 |
| poolie | possibly useful | 00:39 |
| rick_h_ | StevenK: thanks, bookmarked | 00:39 |
| wgrant | I have 5 branches here relating to cleaning up the vhost machinery and config. | 00:39 |
| poolie | a toe in the water; and doesn't require db or infrastructure changes | 00:39 |
| lifeless | poolie: timelines.... thanks for reminding me. I want notification to be done as a service. | 00:39 |
| StevenK | rick_h_: There is also db-stable.html for database stuff | 00:39 |
| wgrant | I should probably merge and land them at some point. | 00:39 |
| wgrant | IIRC one of them destroys vostok. | 00:39 |
| poolie | lifeless, that sounds good but what exactly do you mean | 00:40 |
| lifeless | poolie: I'm not 100% sure what I mean yet :). | 00:40 |
| wgrant | blah | 00:41 |
| poolie | lifeless, ok :) | 00:46 |
| poolie | so like i say this seemed like a place to start | 00:46 |
| mwhudson | lifeless, StevenK: sure, rip out vostok if it's causing any problems | 00:50 |
| huwshimi | poolie: What happens when you dump all different types of content (headings etc) into a description, does it come out looking alright? | 00:52 |
| abentley | wallyworld_: what particular spinner did you have in mind in your review? | 00:53 |
| wallyworld_ | abentley: there isn't any additional spinner on the page right now, but there could be one added later and it could cause problems. so the suggestion is just to make the code more robust | 00:54 |
| wallyworld_ | but if you don't think it's required, i can just +1 it | 00:55 |
| wallyworld_ | it seemed worth making the change thogu, given it's just a slightly longer select expression | 00:56 |
| abentley | wallyworld_: There won't be a later. Deryck is working on a different spinner that will replace this one. | 00:56 |
| wallyworld_ | ah, ok. in that case i'll just +1 it | 00:56 |
| poolie | huwshimi, in markdown? | 00:58 |
| poolie | it looks ok | 00:58 |
| abentley | wallyworld_: thanks. | 00:58 |
| wallyworld_ | abentley: done, sorry for the confusion on my part | 00:58 |
| huwshimi | poolie: Yeah, ok great | 00:58 |
| poolie | obviously if people start putting lots of h1s it will look a bit weird but it doesn't spoil things | 00:58 |
| poolie | ... i don't think we're going to allow the animated gif background tag :) | 00:59 |
| huwshimi | poolie: Great, in that case I'm happy to go with what you have | 00:59 |
| huwshimi | poolie: Awww | 00:59 |
| poolie | rupert murdoch can buy lp for $580M | 00:59 |
| huwshimi | poolie: With the cloud on the code page I wonder if we can turn that into an activity wall of sortts | 01:03 |
| huwshimi | *sorts | 01:03 |
| wgrant | That page is probably the walliest thing in LP right now. | 01:04 |
| wgrant | It has the registered/changed branch feeds at the bottom. | 01:04 |
| wgrant | And the cloud showing activity levels. | 01:04 |
| poolie | huwshimi, i don't know if you have time but if you want to do a sketch of a general activity wall , version 0 | 01:04 |
| poolie | i might try to implement it | 01:04 |
| huwshimi | poolie: I started working on this a long time ago: http://people.canonical.com/~huwshimi/profile_01.png | 01:06 |
| huwshimi | poolie: But I'm happy to work on this a bit with you | 01:07 |
| huwshimi | poolie: It would give us a chance to try a few thigns | 01:07 |
| huwshimi | *things | 01:07 |
| huwshimi | poolie: I'm just running your markdown branch, I've enabled the feature flag ("markdown.enabled default 1 true"), but I'm not getting the markdown rendered. What else might I need to do? | 01:15 |
| huwshimi | poolie: Oh, all I did was grab a new lp branch, and merged your changes | 01:15 |
| lifeless | poolie: so I think what I mean is a few things that all intersect | 01:19 |
| lifeless | poolie: notification / walls / timelines all belong outside the main lp codebase: it requires a rather different view of the data than our main tables are structured for | 01:20 |
| lifeless | poolie: it also has no requirement to be carefully modelled - in fact it has a requirement to be agile and loosely modelled, to easily be updated as other things change | 01:21 |
| poolie | huwshimi, did you work it out with md? | 01:35 |
| huwshimi | poolie: erm, no I got distracted by other things :) | 01:35 |
| poolie | huwshimi, i don't know, that should be all you need to do | 01:36 |
| poolie | nb it only works on eg person descriptions, not on all text yet | 01:36 |
| poolie | lifeless, i agree with those as an ultimate goal | 01:36 |
| poolie | mm, not quite sure about why it ought to be outside the main codebase though | 01:36 |
| poolie | except in as much as perhaps it would be nice to have a less monolithic codebase generally | 01:36 |
| huwshimi | poolie: Oh, I misunderstood (I thought it worked on bug descriptions too). Yes it's working perfectly | 01:37 |
| poolie | just being (perhaps over) cautious | 01:40 |
| poolie | also deferring making it work with edit widgets | 01:40 |
| poolie | http://people.canonical.com/~huwshimi/profile_01.png looks good | 01:40 |
| poolie | i will try for something like that | 01:40 |
| lifeless | poolie: multiple services will need to talk to notifications; its easier to work on small codebases; nosql may well be much easier to work with; all new things should be built with SOA in mind | 01:43 |
| poolie | k | 01:44 |
| lifeless | notification/walls/timelines are greenfield, making them 5-10 times harder by working within the big curly DB we have would be a costly choice IMNSHO | 01:45 |
| poolie | ! | 01:45 |
| poolie | interesting | 01:45 |
| lifeless | [email notifications clearly aren't greenfield, the rest are] | 01:45 |
| poolie | if they were done externally, how would the web content be visible to the user | 01:46 |
| lifeless | in LP you would have a thin shim which makes API calls | 01:46 |
| lifeless | same as e.g. talking to memcached, but without the potatoes. | 01:46 |
| poolie | wall_service.get_wall_html('mbp')? | 01:49 |
| lifeless | for instance. | 01:49 |
| lifeless | UI and rendering is in LP | 01:49 |
| poolie | ah, so more like | 01:49 |
| lifeless | storage, graph traversal, summary snippets and a pointer back to the source document are in the service | 01:49 |
| poolie | the view object makes a call to get structured machinereadable data from the wall service? | 01:50 |
| lifeless | yup | 01:50 |
| wgrant | Privacy is a bit of a challenge, but not insurmountable. | 01:50 |
| lifeless | all modern sensible stuff and isolated from insane http headers | 01:50 |
| lifeless | so json blob | 01:50 |
| poolie | right, it will need to get it on behalf of the current interaction user | 01:50 |
| lifeless | some implementation choices around whether the summary snippets are served as is or privacy-checked on the LP side etc | 01:50 |
| poolie | mm | 01:51 |
| poolie | i feel like i would like to do this in a way that for version 0 talks to the lp database | 01:51 |
| poolie | but with a view to eventually pointing to something else | 01:51 |
| lifeless | you're welcome to scrach that locally. | 01:51 |
| lifeless | but | 01:51 |
| poolie | quite isolated | 01:51 |
| lifeless | I'm going to reject landing anything in this space in lp proper | 01:51 |
| poolie | :( really? | 01:51 |
| lifeless | I realise this provides a barrier to entry, but I think its better overall | 01:52 |
| lifeless | yes, really. | 01:52 |
| lifeless | the cost of setting up a microservice is fairly modest | 01:52 |
| wgrant | lol | 01:52 |
| poolie | ok | 01:52 |
| wgrant | We are yet to have a single microservice running. | 01:52 |
| poolie | maybe i'll test that | 01:52 |
| wgrant | (but I agree it needs to be done as one) | 01:52 |
| lifeless | wgrant: not true; we have 3 running so far - txlongpoll, oops-tools and arguably rabbit | 01:52 |
| wgrant | txlongpoll and rabbit are not running. | 01:53 |
| lifeless | wgrant: txlongpoll only needs the rabbit config switched on in LP, and thats waiting for red to put the MP forward | 01:53 |
| wgrant | They're somewhat close. | 01:53 |
| wgrant | But they're not running. | 01:53 |
| poolie | so every lp action that does a wall-related activity will post it to the microservice? | 01:53 |
| lifeless | rabbit is | 01:53 |
| poolie | and they'll be stored redundantly there? | 01:53 |
| wgrant | lifeless: It's not being used for anything. | 01:53 |
| lifeless | graphs and nagios are in place for prod rabbit | 01:53 |
| lifeless | poolie: yes | 01:53 |
| lifeless | poolie: for whatever depth of history we want to support | 01:53 |
| poolie | hm | 01:53 |
| poolie | obviously there are consistency things about | 01:54 |
| poolie | comments being deleted or hidden | 01:54 |
| poolie | for instance | 01:54 |
| lifeless | this is covered under the question 'some implementation choices around whether the summary snippets are served as is or privacy-checked on the LP side etc' | 01:54 |
| lifeless | but yes | 01:54 |
| lifeless | there are | 01:54 |
| poolie | hm | 01:57 |
| poolie | i think a soa would be better | 01:57 |
| poolie | it seems a shame to block changes that give better presentation of data that is already in the db | 01:57 |
| poolie | perhaps it is necessary if things are ever going to improve | 01:57 |
| lifeless | so, you mentioned, for instance, listing all your own comments on bugs, in date order; this requires joining all messages from $user, across to all bugs, then checking for privact | 01:58 |
| lifeless | a few users have > 100K messages | 01:58 |
| lifeless | I can pretty much guarantee you'll have timeout issues in any first-draft implementation on e.g. ~janitor | 01:59 |
| poolie | sure | 01:59 |
| poolie | but https://bugs.launchpad.net/~pitti/ eg times out today | 01:59 |
| lifeless | this isn't a reason not to do it, but its a demonstration of how our schema is not arranged to meet the needs of that project | 01:59 |
| poolie | most bug list pages are timing out | 01:59 |
| lifeless | garh | 02:00 |
| lifeless | we fixed ~pitti | 02:00 |
| lifeless | thats a regression | 02:00 |
| poolie | ~mbp times out | 02:00 |
| poolie | so | 02:00 |
| poolie | i don't want to add more timing out pages | 02:00 |
| lifeless | great! :) | 02:00 |
| poolie | but i guess, | 02:00 |
| poolie | lp does have to have a general answer to "do simple select/sort queries across the bug db" | 02:01 |
| poolie | which is all this would need | 02:01 |
| poolie | i'm not really confident that bringing up a separate db that will scale to that size will be easy | 02:02 |
| wgrant | poolie: Did you really prefer a 6 digit bug to a 4 digit one? | 02:02 |
| poolie | (even if it's allowed to throw stuff away) | 02:02 |
| poolie | yes, becaues it has a better description | 02:02 |
| poolie | but i don't care if you reverse it and update stuff | 02:02 |
| poolie | lifeless, anyhow it's kind of blue sky now | 02:03 |
| poolie | so i don't want to distract us with it | 02:03 |
| poolie | i support soaization | 02:03 |
| poolie | i don't want to add more timeouts | 02:03 |
| poolie | i do want to take a small step towards timelines | 02:03 |
| poolie | when i get to it i'll see if i can resolve those things | 02:03 |
| wgrant | Launchpad is fixed! | 02:12 |
| wgrant | * 14 Exceptions | 02:12 |
| wgrant | * 2 Time Outs | 02:12 |
| wgrant | Our work is done. | 02:12 |
| poolie | ? | 02:12 |
| wgrant | lifeless broke oops-tools, so the OOPS reports aren't as depressing as usual today. | 02:13 |
| lifeless | well there is certainly *something* odd ;( | 02:13 |
| poolie | hi, could i get a quick scan of https://code.launchpad.net/~mbp/loggerhead/240580-tarball/+merge/83364 from someone? | 02:44 |
| poolie | thanks lifeless | 02:55 |
| lifeless | jtv: you dropped off | 02:56 |
| lifeless | poolie: got some time for bouncing ideas around ? | 03:07 |
| poolie | lifeless, sure | 03:10 |
| poolie | can i have some lunch first? | 03:10 |
| lifeless | sure | 03:10 |
| poolie | rabbit just failed again; i'm glad i fixed the feature :) | 03:15 |
| poolie | psa | 03:15 |
| StevenK | Grumble, storm validators suck | 03:29 |
| StevenK | wgrant: Can haz help? | 03:35 |
| lifeless | whats up | 03:35 |
| StevenK | IProduct.{_owner,security_contact} both have a storm_validator of validate_person_or_closed_team. | 03:36 |
| StevenK | Setting the owner to an open team results in an error of "Constraint not satisfied", but setting the security contact to an open team gives "You must choose a valid person or team to be the security contact for <project>" | 03:37 |
| StevenK | And both validators are the same, so I'm not sure what is going on. | 03:38 |
| lifeless | is there a try:except: around the other case ? | 03:41 |
| poolie | lifeless, hi, now? | 03:41 |
| mwhudson | ah i remember trying to figure out where constraint not satisfied came from | 03:42 |
| lifeless | sure | 03:42 |
| poolie | pots? | 03:42 |
| StevenK | lifeless: They're both in the same view, neither are checked in the view's validate() | 03:43 |
| mwhudson | StevenK: storm_validator is in the model code, i bet _owner has something funky in the zope.schema/interface side | 03:44 |
| StevenK | mwhudson: There's a owner setter/getter, do you think that is interferring? | 03:45 |
| mwhudson | StevenK: no, i think the error is probably coming 'before' that | 03:46 |
| mwhudson | although owner is just an Attribute? | 03:46 |
| StevenK | It's a PersonChoice | 03:47 |
| mwhudson | ah yeah | 03:47 |
| mwhudson | vocabulary='ValidPillarOwner', | 03:47 |
| StevenK | mwhudson: The error isn't coming from the vocab, though | 03:47 |
| mwhudson | and i see security_contact is the same anyway | 03:48 |
| mwhudson | StevenK: only difference i see is PublicPersonChoice vs PersonChoice ? | 03:48 |
| StevenK | Oh, which is done via IHasSecurityContact | 03:49 |
| mwhudson | StevenK: constraint not satisfied is raised in the form validation code in some frustrating way that blocks you from finding out why | 03:49 |
| mwhudson | yeah | 03:50 |
| mwhudson | if value not in vocabulary: | 03:50 |
| mwhudson | raise ConstraintNotSatisfied(value) | 03:50 |
| StevenK | Ah ha | 03:50 |
| StevenK | Is that in zope guts? | 03:50 |
| mwhudson | zope.schema-3.5.4-py2.6.egg/zope/schema/_field.py | 03:50 |
| StevenK | RARGH | 03:50 |
| StevenK | STEVE SMASH | 03:51 |
| StevenK | mwhudson: I don't like the idea of rummaging around in self.errors in the view's validate() just for a better error. | 03:52 |
| mwhudson | StevenK: i can't remember what i did last time i got angry about this | 03:52 |
| mwhudson | StevenK: i'll notice that security_contact gives a nice error, maybe you can see why? :) | 03:53 |
| mwhudson | oh | 03:53 |
| mwhudson | well, slightly nicer | 03:53 |
| mwhudson | one that's from the launchpad tree at least :) | 03:53 |
| StevenK | mwhudson: That's what I'm trying to figure out! :-) | 03:53 |
| mwhudson | StevenK: heh | 03:54 |
| mwhudson | StevenK: i hope this pointer helped a bit at least | 03:54 |
| StevenK | The ConstraintNotSatisfied exception is in self.errors for owner when it's an open team | 03:54 |
| StevenK | Right, there is a bunch of machinery around security contact | 04:01 |
| StevenK | Whereas there is none around owner | 04:01 |
| StevenK | mwhudson: I've added a block before the OMG-Zope-gave-us-errors-must-return section and that works. | 04:11 |
| mwhudson | StevenK: i'm not sure what that means, but i'm glad it works :) | 04:16 |
| StevenK | mwhudson: http://pastebin.ubuntu.com/748928/ | 04:17 |
| mwhudson | StevenK: ah | 04:18 |
| * StevenK shakes fist at NameAlreadyTaken | 04:20 | |
| huwshimi | wallyworld_: Hey mate, would you be around in about an hour to have a chat about getting the manage-disclosure mockups ready for testing? | 04:33 |
| wallyworld_ | huwshimi: i have to go to the post office quickly after school pickup so i'll be a little later than normal getting home. i'll be back around 4:45 AEDT | 04:35 |
| huwshimi | wallyworld_: Sure, that's fine | 04:35 |
| wallyworld_ | excellent. i'll ping you | 04:36 |
| huwshimi | wallyworld_: Cheers | 04:36 |
| wallyworld_ | huwshimi: ping :-) | 05:37 |
| huwshimi | wallyworld_: Hey, mumble? | 05:46 |
| wallyworld_ | huwshimi: yep, assuming it starts this time without locking up :-( | 05:46 |
| huwshimi | wallyworld_: skype, phone etc. are fine too if need be | 05:47 |
| poolie | why is lp.dev giving me a sad face? | 05:49 |
| poolie | oh ok now | 05:50 |
| poolie | i'm going to send through the update to loggerhead in the lp tree | 06:05 |
| === wallyworld_ changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugtasks: 292 | ||
| poolie | huwshimi, i wonder if we could usefully autosave in progress typing into local html5 storage | 07:26 |
| poolie | perhaps if your browser crashes it will be lost anyhow | 07:26 |
| poolie | i don't know | 07:26 |
| poolie | maybe it's the browser's job not to crash :) | 07:27 |
| jtv | wgrant: help, I'm stuck! | 07:28 |
| jtv | wgrant: remember bug 876594? | 07:28 |
| _mup_ | Bug #876594: rejected builds for synced packages send mail to Debian maintainer <derivation> <qa-untestable> <regression> <Launchpad itself:In Progress by jtv> < https://launchpad.net/bugs/876594 > | 07:28 |
| jtv | I'm trying to reproduce the problem in a test, but I need something like 4 layers of objects that we don't have LaunchpadObjectFactory methods for. | 07:29 |
| jtv | Or 5. | 07:33 |
| poolie | add em? | 07:33 |
| nigelb | Yak shaving weekend? :) | 07:33 |
| poolie | personally i'm doing all the bzr reviews | 07:34 |
| poolie | is there a tasteful place to hold an object for the duration of the current request? | 08:01 |
| wgrant | jtv: SoyuzTestPublisher | 08:21 |
| wgrant | poolie: No, but there are some distasteful ones. What do you want to store? | 08:21 |
| poolie | re https://code.launchpad.net/~mbp/launchpad/391780-markdown/+merge/82832 i was going to cache the markdown converter object for later reuse | 08:21 |
| poolie | but, it turns out not to be all that expensive to just make a new one each time its wanted | 08:22 |
| poolie | so, nm | 08:22 |
| wgrant | Ah | 08:24 |
| poolie | how does the 'incremental fix' thing work? | 08:28 |
| nigelb | multiple fixes for the same bug. I think the flag is --incremental for ec2land | 08:28 |
| poolie | yep | 08:28 |
| nigelb | The bug isn't set Fix Committed. | 08:28 |
| nigelb | but you get the qa tags on it. | 08:28 |
| poolie | that sounds like just what i want then | 08:29 |
| poolie | i'm sending up the markdown branch as a limited beta | 08:29 |
| nigelb | ahh. Nice. | 08:29 |
| nigelb | Also, the new Beta thing is pretty cool. | 08:29 |
| jtv | wgrant: that's the answer I feared… I hope SoyuzTestPublisher gives me a say over the changes file. | 08:30 |
| mrevell | Hello | 09:12 |
| === almaisan-away is now known as al-maisan | ||
| lifeless | nigelb: poolie: actually, thats not what happens | 09:41 |
| lifeless | the qa process wiki page covers it I think; your revision will be skipped | 09:42 |
| poolie | is qas not updating or something? | 09:42 |
| poolie | i have something landed a while ago that's not on http://lpqateam.canonical.com/qa-reports/deployment-stable.html | 09:42 |
| wgrant | poolie: A while ago? | 09:54 |
| wgrant | poolie: Has it been through buildbot yet? | 09:54 |
| allenap | poolie: Thanks for looking at https://bugs.launchpad.net/launchpad/+bug/894045. I was on quite the wrong tack! | 09:56 |
| _mup_ | Bug #894045: sending pgp inline in plain text causes apparent crc errors <confusing-ui> <email> <gpg> <Launchpad itself:Triaged> < https://launchpad.net/bugs/894045 > | 09:56 |
| jtv | Where did the statuses on the translations-import-queue pages go? | 10:03 |
| poolie | allenap, you're welcome, thanks for the tip about rabbit | 10:07 |
| poolie | i hit the same error case today and i got a useful message | 10:07 |
| poolie | wgrant, 3.5h ago | 10:07 |
| poolie | where is the buildbot again? | 10:08 |
| StevenK | lpbuildbot.c.c | 10:09 |
| allenap | poolie: Ah, the service details stuff? You rule for sorting that out. | 10:10 |
| poolie | :) | 10:10 |
| jtv | dpm: do you still see the status of entries on the import-queue pages? They no longer show up for me. | 10:12 |
| dpm | jtv, on which distro/project? | 10:12 |
| jtv | Any. | 10:12 |
| dpm | jtv, oh, I don't see them either :( | 10:13 |
| jtv | That's pretty shocking. I'm filing a bug. | 10:13 |
| dpm | jtv, could you please subscribe me to it when you do? | 10:14 |
| jtv | OK | 10:14 |
| nigelb | lifeless: Oh. Ew. Sorry for the misinformation! | 10:14 |
| jtv | dpm: bug 894690 | 10:21 |
| _mup_ | Bug #894690: Translations import queue pages no longer show statuses <critical> <regression> <rosetta-imports> <Launchpad itself:Triaged> <Ubuntu Translations:Triaged> < https://launchpad.net/bugs/894690 > | 10:21 |
| jtv | You're subscribed. | 10:21 |
| dpm | jtv, got the e-mail, thanks | 10:21 |
| wgrant | poolie: buildbot takes 4-6 hours | 10:22 |
| jtv | dpm: the information is still there, but it's hidden. Maybe it's a simple mistake in the HTML template. I'll see what changed. | 10:23 |
| dpm | ok, cool, thanks jtv | 10:25 |
| poolie | ah ok | 10:25 |
| rvba | Just checking: If I have a branch visible by user a, I can be sure that all the branches in the chain of branches on which this branch is stacked on is also visible by user a right? | 10:34 |
| jtv | huwshimi: I see you replaced a class="hidden" with a style="display:none" in the translations import queue macros. Are you quite sure we don't have something in the code that removes the "hidden" class to make it visible? Now it stays hidden, which is a bit of a problem. | 10:35 |
| jtv | rvba: it sounds dubious… AIUI Launchpad doesn't even really notice the stacking — it's purely internal to bzr. | 10:36 |
| jtv | But poolie will know more. | 10:37 |
| poolie | the access control is all on the lp side | 10:37 |
| rvba | I'm pretty sure branch.visibleByUser goes up the stacked on chain. | 10:38 |
| rvba | jtv: Unless I'm mistaken Huw changed a bunch of "display:none" into class="hidden" and not the other way around. | 10:40 |
| jtv | Hmm | 10:40 |
| rvba | https://code.launchpad.net/~huwshimi/launchpad/style-removal-one/+merge/82096 | 10:40 |
| * rvba wonders why the preview diff is empty on this page… | 10:40 | |
| jtv | Ah yes, it's "hidden" know. | 10:40 |
| jtv | I think sometimes the diff for the latest update happens to get computed after the merge. | 10:41 |
| jtv | Annnd the javascript does a setStyle('display', ''). | 10:42 |
| rvba | poolie: so, if I have a branch that user a can see, can I be sure that all the branches on which this one is stacked on are also visible by user a ? (I want to prefetch the chain of stacked on branches for a list a branches but I don't want to fetch non visible branches). | 10:42 |
| rvba | jtv: a bug it is then. | 10:43 |
| jtv | The probable cause of bug 894690. | 10:43 |
| _mup_ | Bug #894690: Translations import queue pages no longer show statuses <critical> <regression> <rosetta-imports> <Launchpad itself:Triaged> <Ubuntu Translations:Triaged> < https://launchpad.net/bugs/894690 > | 10:43 |
| rvba | Very probable indeed. | 10:44 |
| rvba | Also means that a test is missing. | 10:44 |
| jtv | That's the nasty part. This kind of change is hard to predict, so it's easy to write a decent unit test that passes. And a full-on browser test would be overkill. | 10:45 |
| === matsubara-afk is now known as matsubara | ||
| rick_h_ | morning | 11:48 |
| rick_h_ | does anyone have an IE browser handy for a quick QA thing? | 12:21 |
| nigelb | hah. | 12:28 |
| jml | rick_h_: I wish. | 12:29 |
| jml | hey, what tag should I use to file bugs on the new bug listing thingummy? | 12:29 |
| rick_h_ | heh, thanks | 12:29 |
| rick_h_ | hmm, good question. sec. | 12:30 |
| rick_h_ | wjat | 12:30 |
| rick_h_ | what's the bug? | 12:30 |
| rick_h_ | probably just buglistign | 12:30 |
| rick_h_ | errr, buglisting | 12:30 |
| jml | rick_h_: I have a few different ones, actually :) | 12:30 |
| rick_h_ | jml: heh, ok | 12:30 |
| rick_h_ | jml: nvm, looks like it's bug-columns that everyone is using | 12:41 |
| rick_h_ | https://bugs.launchpad.net/launchpad/+bugs?field.tag=bug-columns | 12:41 |
| jml | rick_h_: yeah, thanks. Found that due to post-filing editing | 12:41 |
| jml | really should fix that bug about tags not auto-completing on filing | 12:41 |
| jml | would save everyone a heap of time | 12:41 |
| * jml makes a note to dig that up | 12:41 | |
| jml | mrevell, rvba, matsubara: I think I'm done with my bug filing spree. | 13:23 |
| nigelb | lol, spammer :P | 13:23 |
| mrevell | jml, Thanks, much appreciated :) I'm leaving some comments | 13:23 |
| === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: bac | Critical bugtasks: 292 | ||
| jml | it's a very exciting feature | 13:25 |
| jml | and I like the direction that the new look is taking | 13:25 |
| nigelb | When I saw the Beta "bar", it almost looked modern. | 13:28 |
| nigelb | I'm hoping with some of the features mrevell was talking about at UDS, Launchpad will be much much much better ;) | 13:29 |
| mrevell | nigelb, Well, it's a slow march. | 13:29 |
| mrevell | jml, I believe the new bug listing look came out of your discussions with Huw, right? | 13:30 |
| nigelb | :) | 13:30 |
| jml | mrevell: did it really? I can't recall. | 13:30 |
| matsubara | jml, some of the bugs you filed I found out during ET and told Deryck about. Developers are aware of those issues. Thanks for filing those bugs! | 13:30 |
| mrevell | jml, That's what Huw said :) | 13:30 |
| mrevell | jml, I hate to ask, because it's a hard one to answer, but do you have a suggestion for how we can make the "Edit your visible info" cog more prominent? Originally, we had a "Edit visible information" link but it was kinda ugly and still not that noticeable. | 13:31 |
| rick_h_ | I was just looking at that one, the problem is that you don't use it much right? | 13:32 |
| rick_h_ | you'd set your preference and not need it again | 13:32 |
| jml | well, that's not quite right, actually | 13:32 |
| rick_h_ | so making it more prominent just gets distracting after first use? | 13:32 |
| jml | because different projects have different listing needs | 13:32 |
| jml | and I haven't really explored the personal listing pages yet | 13:32 |
| jml | mrevell: tbh, I'd just make it more high-contrast | 13:32 |
| matsubara | mrevell, maybe make it a bit darker would help? | 13:33 |
| mrevell | Yeah and something we deemed out of scope for now was the ability to save multiple listings. | 13:33 |
| mrevell | Two people saying the same thing; I take that as meaning it is the truth. | 13:33 |
| matsubara | jml, personal listings don't have the sorting widget or the cog | 13:33 |
| matsubara | don't have yet, I meant :-) | 13:33 |
| mrevell | matsubara, It's a bug. | 13:33 |
| matsubara | yep, I know. I filed it | 13:33 |
| jml | mrevell: maybe make it a little bigger, and make the grey a shade darker? *shrug* | 13:33 |
| mrevell | bug 894437 | 13:33 |
| mrevell | jml, Sounds about right | 13:33 |
| mrevell | matsubara, heh, right | 13:34 |
| jml | mrevell: can't we just punt that to Huw? :P | 13:34 |
| mrevell | jml, Sure :) | 13:34 |
| jml | also, one of your earlier comments reminded me of this quote | 13:34 |
| matsubara | mrevell, stand up? | 13:34 |
| mrevell | Is a cog obvious enough | 13:34 |
| mrevell | matsubara, Yus, Skype okay? | 13:34 |
| mrevell | Ekiga hates me atm | 13:35 |
| matsubara | mrevell, sure. logging in | 13:35 |
| jml | (It's about the waters of a fictional heavenly river) "When you have drunk of it you forget forever all proprietorship in your own works. You enjoy them just as if they were someone else's: without pride and without modesty." | 13:35 |
| mrevell | Excellent :) | 13:35 |
| jml | I think a cog icon is a fine metaphor | 13:39 |
| jml | I'm surprised Huw hasn't replaced the edit icon in a fit of whim & fancy yet :) | 13:39 |
| mrevell | jml, We've been talking about it; he'd like to wait until the rebrand, so he doesn't have to do two versions. | 13:40 |
| jml | OK | 13:40 |
| rick_h_ | heh, it took me forever to figure out that was edit | 13:44 |
| rick_h_ | looked like an exclamation point, I kept thinking "hmm, this is important" | 13:45 |
| flacoste | morning | 14:11 |
| mrevell | Morning flacoste! | 14:11 |
| rick_h_ | morning | 14:12 |
| rick_h_ | anyone know if I'm going to break anything if I just change the dev apache config virtualhost all to *:80/443 vs the set up 127.0.0.88 and such? | 14:22 |
| flacoste | rvba: i'd suggest you make all bugs on the bugs-columns feature 'High' | 14:23 |
| flacoste | rvba: remember that we use High for feature work to indicate bugs we'd like to fix before release | 14:23 |
| flacoste | rvba: when we need to reduce scope, we review the HIgh list | 14:24 |
| flacoste | whereas we are less likely to review the Low list | 14:24 |
| flacoste | not a big deal, but a little time-saver | 14:24 |
| rvba | flacoste: ok, thanks for the heads up. | 14:26 |
| flacoste | rvba: thanks for doing triaging! | 14:26 |
| mrevell | Hey abentley, bug 887232: the sort order widget and cog don't appear on person/team pages. Do you know what's causing that bug? | 14:33 |
| abentley | mrevell: OTP | 14:36 |
| rick_h_ | abentley: http://sorescode.com/2010/09/12/benchmarks.html | 14:40 |
| abentley | mrevell: It looks like the ajaxification is completely broken on those pages. | 14:45 |
| abentley | mrevell: may be related to bug #887214 | 14:46 |
| mrevell | abentley, Okay, thanks. Is it something the Orangery are working on? | 14:47 |
| abentley | mrevell: it wasn't, but it looks like it warrants it. I think the pages will still be usable, just in non-ajax mode. | 14:48 |
| mrevell | abentley, Is it not fixable so that the ajax works? | 14:48 |
| abentley | mrevell: I mean until we fix it, it should be usable in non-ajax mode. | 14:49 |
| mrevell | abentley, I'm not sure I understand. Does that mean there's some way I can see a non-ajax version of the sort ordering and cog widgets on personal bug pages? | 14:51 |
| abentley | mrevell: No, there's no non-ajax version of the sort ordering and cog widgets. I was talking about the basic batch navigation. | 14:52 |
| mrevell | Okay, thanks for clarifying. | 14:52 |
| abentley | mrevell: FWICT, the Person bug pages are not even trying to ajaxify the listings, so it's probably an easy fix. | 14:55 |
| mrevell | That's good to hear :) | 14:55 |
| gmb | bac: I have a simple one for you, if you've got the time: https://code.launchpad.net/~gmb/launchpad/archive-subscriptions-bug-823473/+merge/83407 | 15:12 |
| bac | gmb: sure | 15:30 |
| gmb | Thanks | 15:31 |
| === al-maisan is now known as almaisan-away | ||
| bac | gmb: done | 15:40 |
| gmb | Thanks | 15:40 |
| rvba | Hi bac, could you please have a look at https://code.launchpad.net/~rvb/launchpad/activereviews-bug-867941-eagerload3/+merge/83389 ? | 16:05 |
| bac | rvba: will do | 16:05 |
| rvba | Thank you. | 16:05 |
| bac | nice branch rvba | 16:27 |
| rvba | Thanks for the review bac! | 16:29 |
| abentley | bac: could you please review https://code.launchpad.net/~abentley/launchpad/person-bug-listings/+merge/83418 ? | 17:01 |
| abentley | bac: nm. hold on. | 17:02 |
| abentley | bac: okay, https://code.launchpad.net/~abentley/launchpad/person-bug-listings/+merge/83418 is ready for review. | 17:16 |
| mrevell | Night all. I shall be retiring for the weekend. | 17:57 |
| bac | abentley: yes, i can now | 18:10 |
| abentley | bac: excellent. I'm just back from lunch. | 18:11 |
| bac | abentley: me too :) | 18:11 |
| bac | hope yours was as good | 18:11 |
| abentley | It was nice. | 18:11 |
| bac | abentley: is custom bug listing enabled in production only for some projects? | 18:12 |
| abentley | bac: No, it's enabled for all projects, but at their "+bugs" view, not their home page. | 18:12 |
| bac | ah, gotcha | 18:12 |
| abentley | bac: But for project *groups*, the +bugs view *is* the home page. | 18:13 |
| cr3 | why do launchpad tests run with xvfb? | 19:54 |
| bac | cr3: was needed when we used windmill | 19:57 |
| rick_h_ | guessing at some point we use a headless browser from the cmd line, like phantomjs type of thing that requires that to run | 19:57 |
| rick_h_ | or like windmill :) | 19:57 |
| flacoste | bac: still needed | 19:58 |
| cr3 | bac: thanks, I know about sinzui's html5-browser but curious to know if there are still signs of windmill in launchpad. has it all been migrated? | 19:58 |
| flacoste | for the JS tests | 19:58 |
| flacoste | webkit requires a display | 19:59 |
| bac | flacoste: i suspected so. didn't mean to say it was no longer needed. | 19:59 |
| flacoste | cr3: windmill has been gone for a couple of months | 19:59 |
| flacoste | but the xvfb is still needed for html5-browser | 19:59 |
| cr3 | flacoste: thanks, I've been running my tests interactively but now I know what to do for ec2 :) | 20:00 |
| flacoste | cr3: yes, we only use xvfb when running in ec2 | 20:00 |
| flacoste | or other simlar headless environment | 20:00 |
| flacoste | it shouldn't be needed on a local workstation | 20:00 |
| flacoste | unless you are one of those crazy developpers who have emacs as their init program | 20:01 |
| cr3 | flacoste: I don't use the emacs operating system myself :) | 20:01 |
| flacoste | good for you :-) | 20:02 |
| === matsubara is now known as matsubara-afk | ||
| abentley | bac: could you please review https://code.launchpad.net/~abentley/launchpad/mandatory-bug-title/+merge/83446 ? | 21:23 |
| bac | abentley: shirley | 21:23 |
| === Ursinha is now known as Ursinha-afk | ||
| bac | abentley: done | 21:32 |
| abentley | bac: thanks. | 21:37 |
| === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugtasks: 292 | ||
| poolie | well now | 22:00 |
| poolie | https://code.launchpad.net/~mbp/launchpad/798412-plusone/+merge/83449 | 22:00 |
| mtaylor | hey all - I'm having odd problems with ppa uploads | 22:46 |
| mtaylor | https://jenkins.openstack.org/job/glance-ppa/label=build,series=lucid/273/console for instance | 22:46 |
| mtaylor | the files are, in fact, being signed by the gpg key that is on the account of that user in launchpad | 22:46 |
| mtaylor | so wtf? | 22:46 |
| lifeless | bug 798957 perhaps ? | 22:48 |
| mtaylor | lifeless: ah. so potentially clock skew... that would be reasonable given the machines... lemme see if I can fix | 22:49 |
| lifeless | mtaylor: its a server side glitch | 22:51 |
| lifeless | mtaylor: cosmetic,t he uploads are still processed | 22:51 |
| lifeless | mtaylor: freaking annoying to reproduce / fix | 22:51 |
| mtaylor | lifeless: ah. lovely | 22:51 |
| lifeless | works for days, then boom stops. | 22:52 |
| mtaylor | lifeless: well, fwiw, it seems to be hitting all of our ppa uploads from openstack's jenkins | 22:52 |
| mtaylor | awesome | 22:52 |
| lifeless | restart the service. Works. | 22:52 |
| mtaylor | beautiful | 22:52 |
| mtaylor | so - for now I should just "dput blah || echo true" to avoid it looking like all of my uploads are failing? | 22:53 |
| lifeless | :9 | 22:57 |
| lifeless | :( | 22:57 |
| lifeless | yes | 22:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
