lifeless | wgrant: can you check in one of your lucid lxc's, is /var/run a tmpfs, or a naked dir ? | 19:02 |
---|---|---|
nigelb | Morning lifeless | 19:04 |
lifeless | morning nigelb | 19:44 |
nigelb | :) | 19:45 |
lifeless | question for the floor - I need a sanity check - set_session_pkg_data() takes parameters that need obfuscating? | 19:45 |
=== micahg_ is now known as micahg | ||
poolie | lifeless, thanks for the partial review | 21:28 |
lifeless | no probs | 21:29 |
wgrant | lifeless: Obfuscating how? | 21:47 |
lifeless | wgrant: have a look at OOPS-3cbd11de34ca8a70afaf668853adc17e in bad-oops on carob | 21:48 |
lifeless | wondering if we should be preventing query param substition | 21:48 |
wgrant | Oh, in query logs, I see. | 21:48 |
wgrant | lifeless: Where is bad-oops? | 21:49 |
lifeless | lpoops/ | 21:49 |
wgrant | That's not a directory. | 21:49 |
wgrant | Ah, there, I see. | 21:50 |
lifeless | wgrant: its a sidestraction from https://bugs.launchpad.net/python-oops-datedir-repo/+bug/896959 | 21:50 |
wgrant | That probably is somewhat sensitive, yeah. | 21:51 |
lifeless | I happened to notice it ;) | 21:53 |
lifeless | wgrant: I propose to monkey patch update-db to handle unicodedecode error until the fix is deployed. | 21:55 |
wgrant | lifeless: That would be my suggestion. | 21:56 |
lifeless | done | 21:56 |
poolie | anyhow thanks again for the prompt review, i replied | 21:59 |
poolie | incidentally the button is already hidden on private bmps | 21:59 |
wgrant | Heh | 22:09 |
lifeless | poolie: how is it hidden? | 22:10 |
wgrant | Bug 896968, bug 896691 | 22:10 |
lifeless | poolie: I didn't see a clause fo rit | 22:10 |
poolie | line 132 of the diff | 22:10 |
poolie | + tal:condition="not:view/is_private" | 22:10 |
poolie | on the macros that insert the buttons | 22:10 |
poolie | i was quite pleased with that | 22:11 |
poolie | but maybe there's a better way | 22:11 |
poolie | much better than counting on every template getting it right | 22:11 |
poolie | lifeless, i was hoping you'd say "oh that's nice" :) | 22:28 |
lifeless | poolie: heh, sorry. | 22:29 |
lifeless | uhm | 22:29 |
lifeless | thats probably reasonable | 22:30 |
poolie | lifeless, i was hoping you'd say "oh that's nice" :) | 22:30 |
poolie | oops | 22:30 |
lifeless | deja vue | 22:31 |
poolie | typo, not trying to be whiny | 22:31 |
wgrant | I'm saying that your second-latest comment is spreading common misunderstandings. | 22:51 |
lifeless | feel free to note that | 22:51 |
lifeless | both aaron and I were spreading it | 22:51 |
lifeless | however we don't have -any- bug.datecreated search in bugtask.py | 22:51 |
lifeless | so while its true that the bug datecreated field can be different | 22:51 |
lifeless | its not relevant to the bug | 22:51 |
wgrant | bugtask.datecreated will be similarly different. | 22:52 |
wgrant | Or at least should be. | 22:52 |
lifeless | yes | 22:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!