| bschaefer | thumper: ping | 00:05 |
|---|---|---|
| thumper | bschaefer: hi | 00:05 |
| bschaefer | thumper: hey, so i found why the SetKeyFocus in ShowDash was not working | 00:06 |
| thumper | that's awesome... | 00:06 |
| thumper | and the answer it? | 00:06 |
| bschaefer | thumper: it was getting called before which was causing it to just return | 00:06 |
| bschaefer | thumper: i pushed it to the branch a few days ago but still need to to figure out how to test | 00:06 |
| thumper | bschaefer: it may well be that we need to write some autopilot tests for them | 00:07 |
| bschaefer | autopilot meaning have a program that opens up the dash then trys to send a key event? | 00:07 |
| bschaefer | https://code.launchpad.net/~brandontschaefer/unity/fix-860805 branch if you want to take a look | 00:09 |
| thumper | bschaefer: yes | 00:11 |
| bschaefer | thumper: alright, that sounds interesting to do... | 00:15 |
| thumper | bschaefer: however we aren't in a situation to write that right now | 00:15 |
| bschaefer | thumper: also should I propose a merge for right now? or wait for a test | 00:15 |
| thumper | I just proposed it as work in progress so I could see the diff :) | 00:16 |
| thumper | ok, can you explain in the description of the merge proposal as to why this fix works? | 00:16 |
| thumper | please? | 00:16 |
| bschaefer | thanks, and yeah. I want to test a few things to make sure it is why | 00:17 |
| bschaefer | it looks like it is getting called to early | 00:17 |
| bschaefer | (but want to double check something) | 00:17 |
| bschaefer | so when it gets called the first time it sets a focus_area so then it will == area which makes it return before setting the PathToKeyFocus | 00:18 |
| thumper | what causes it not to get to PathToKeyFocus? | 00:20 |
| thumper | the first time.. | 00:20 |
| bschaefer | in DashView, line 683 is the first time SetKeyFocus is called | 00:20 |
| bschaefer | and when it gets to ShowDash in DashController calling SetKeyFocus just returns right away | 00:21 |
| bschaefer | so when it is called the first time on line 683 that is where it SetPathToKeyFocus gets called | 00:21 |
| bschaefer | so it is not getting there in DashController::ShowDash | 00:21 |
| thumper | so why doesn't it work? | 00:22 |
| bschaefer | which looks like isn't set up or ready before the first call which is why it works the second time. | 00:22 |
| bschaefer | i am looking into what isn't setup at the time of that call. Using the debugger I saw that SetPathToKeyFocus was only getting called for the DashView | 00:23 |
| bschaefer | so that is why I commented it out and then ShowDash calls it now and it works :) | 00:24 |
| thumper | :) | 00:24 |
| thumper | so... we aren't entirely clear why it fixes it, but it appears to? | 00:24 |
| bschaefer | thumper: somewhat, it really seems like it just gets called to soon to early which some input area doesn't exit at that time | 00:26 |
| thumper | is it getting called before the layout is set? | 00:26 |
| bschaefer | so when you call SetPathToKeyFocus that object isn't there so it can't find it but the second time around everything is set up | 00:26 |
| bschaefer | thumper: I checked some things last week but forgot to write what I found down. | 00:28 |
| bschaefer | I moved that SetKeyFocus around in ShowDash which didnt effect anything so I am going to have to see what exactly isn't setup | 00:29 |
| bschaefer | making the DashView fail | 00:30 |
| thumper | :) | 00:32 |
| * thumper goes to get lunch | 00:36 | |
| Andy80 | Trevinho: successfully built and installed in /opt/qt5 :) | 01:19 |
| bschaefer | thumper: when you get back figure out the case | 01:51 |
| thumper | bschaefer: for autopilot? | 02:18 |
| bschaefer | thumper: no for why it isn't working the firs time through | 02:23 |
| thumper | :) | 02:24 |
| bschaefer | it is calling the SetKeyFocus before window->SetLayout(layout) | 02:24 |
| thumper | that'll do it | 02:24 |
| bschaefer | there is longer explanation on the merge thing | 02:25 |
| thumper | ok | 02:25 |
| thumper | bschaefer: merge trunk in and add a manual test, see manual-test/ReadMe.txt | 02:25 |
| thumper | bschaefer: as autopilot isn't yet ready | 02:26 |
| bschaefer | thumper: alright sounds good! | 02:26 |
| bschaefer | thumper: so there are no manual test at the moment? | 02:34 |
| bschaefer | as the dir is empty | 02:34 |
| bschaefer | besides the reame | 02:34 |
| thumper | aye, it is new | 02:34 |
| bschaefer | readme* | 02:34 |
| thumper | add launcher.txt | 02:34 |
| bschaefer | alright, it will look very close the example you used | 02:35 |
| bschaefer | thumper: alright just pushed the manual test | 02:51 |
| bschaefer | along with merging trunk | 02:56 |
| hrw | http://marcin.juszkiewicz.com.pl/~hrw/shots/howmanychromiums.jpg - unity launcher suggests more then one chromium window but only one is present | 08:42 |
| === MacSlow is now known as MacSlow|lunch | ||
| === MacSlow|lunch is now known as MacSlow | ||
| djosefsson | Hi, | 14:06 |
| djosefsson | I'm sitting and trying out the launcher and creating my own Desktop entries, but a thing that I can't get a grip on is search paths for icons. | 14:13 |
| djosefsson | How do I enable Icon=applicationname? | 14:13 |
| djosefsson | I have copied my icon to /usr/share/icons/hicolor/32x32/applicationname.png. Is it neccesary to have a icon in each YYxZZ folder? It works well when I hard code the icon address into the desktop entry. | 14:13 |
| djosefsson | Ops, the shift+enter to get a new line did not work that well. Sorry for that. | 14:14 |
| === hyperair is now known as Guest43903 | ||
| === Amaranth__ is now known as Amaranth | ||
| === Amaranth__ is now known as Amaranth | ||
| === m_conley_away is now known as m_conley | ||
| Andy80 | hi guys | 15:55 |
| Andy80 | suppose I've another Qt installation in /opt/qtX, ho do I tell cmake to use that version insted that the default one to compile Unity-2D? Thanks | 15:56 |
| Andy80 | resolved.... now I got a compilation problem, but I think it's related to my Qt5 build, I'll try to investigate. | 16:38 |
| === chrisccoulson_ is now known as chrisccoulson | ||
| === elopio_ is now known as elopio | ||
| fbdystang | Hi! I have the 3d cube working in unity but how can I get the experimental plugins like atlantis? Thanks | 18:56 |
| === m_conley is now known as m_conley_away | ||
| tbf | mdeslaur: about LP#897545 - sure, some bad luck must come together to cause that situation, but if it happens for http://security.ubuntu.com/ubuntu, users won't get any further security fixes | 20:43 |
| tbf | mdeslaur: not getting security updates definitely is a security issue IMHO | 20:44 |
| mdeslaur | tbf: I understand, but it's not triggered by an attacker. We don't usually consider any package management bugs to be security issues. | 20:45 |
| tbf | mdeslaur: 'k | 20:46 |
| === ronoc is now known as ronoc|break | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
