| duanedesign | ulidtko: looks like the only workaround is to quit the syncdaemon - u1sdtool -q . Delete old metadata - rm -rf ~/.local/share/ubuntuone/ start syncdaemon - u1sdtool -q | 00:05 |
|---|---|---|
| duanedesign | ulidtko: shouldnt have any issues but i would recommend a back up if you are going to do that | 00:06 |
| ulidtko | ok, good idea | 00:07 |
| duanedesign | hi am going to step out to eat dinner. Email or leave me a message in here if you need anything at all. | 00:08 |
| dobey | duanedesign: you don't need to delete the metadata afaik | 00:31 |
| dobey | that wouldn't be a fix if you did | 00:31 |
| kamidi | hello. i'd be very grateful if someone could tell me why most mp3s in cloud are recognized as "unknown artist/unknown album" by Ubuntu One Music Streaming app (android) | 08:27 |
| kamidi | i've searched web like crazy but haven't found answer... i don't want to cancel my subscription but android app for streaming music is basically useless for me atm | 08:29 |
| karni | kamidi: Hello. We are aware of the issue, I apologize. This most probably is due to our media scanners on the server not resolving metadata properly, we are looking into it. | 09:22 |
| kamidi | ok, thank you karni. | 09:22 |
| karni | kamidi: In few hours our support guys should be around, they may know more. | 09:22 |
| kamidi | i'm glad that it's something that is being fixed. this has been very frustrating... tried to convert files to mp3s oggs and so on. do you have any idea why some of the files are scanned properly but others are not? | 09:29 |
| mandel | morning all! | 09:30 |
| karni | kamidi: No idea. We have users report they are still getting "unknowns" for some tracks, and only subset of them, our support team has already been looking into such files (which look correct). I hope we fix this soon, as it is frustrating for paying users (which makes us all sad pandas). | 09:31 |
| karni | mandel: morning o/ | 09:31 |
| mandel | karni, hello :) | 09:35 |
| lisettte | rtgrant, patricia, can you guys still make the call at 10? | 09:46 |
| JamesTait | Hello, hello! :) | 09:51 |
| mandel | ralsina, ping? | 10:38 |
| ralsina | mandel: pong | 10:39 |
| ralsina | mandel: if it's about the rooms, I am trying to see what happened :-) | 10:39 |
| mandel | ralsina, no idea about what happened with the rooms, what occurred? | 10:39 |
| mandel | ralsina, I wanted a review for https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-tests/+merge/83267 | 10:39 |
| mandel | ralsina, you just have to run the tests on windows and see them go green :) | 10:39 |
| ralsina | mandel: ok, but I have to do the school run. I'll get it started | 10:40 |
| mandel | ralsina, sure, is jsut that I have lots of branches blocked and I don't want to start with new bugs until they are done | 10:40 |
| ralsina | mandel: ack, branching/merging right now | 10:41 |
| mandel | ralsina, superb, thx! | 10:41 |
| gatox | hi! | 11:05 |
| mandel | gatox, hola! | 11:09 |
| ralsina | mandel: I think this is because I need to update devtools, right? https://pastebin.canonical.com/56535/ | 11:14 |
| * mandel looks | 11:14 | |
| mandel | ralsina, is that from the ubuntuone-dev-tools branch? | 11:15 |
| mandel | ralsina, did you use ./run-tests.bat? | 11:15 |
| mandel | ralsina, sorry, I mean, is the sso one, right? | 11:16 |
| mandel | then you have to update devtools | 11:16 |
| ralsina | yes, ok, updating | 11:20 |
| === ralsina is now known as ralsina_schoolru | ||
| mandel | gatox, can I have a review: https://code.launchpad.net/~mandel/ubuntuone-client/fix-817582/+merge/83925 | 11:50 |
| gatox | mandel, on it | 11:50 |
| mandel | gatox, should be very simple, I just added the errno to fix the bug and a test :P | 11:52 |
| nessita | hello everyone! | 11:55 |
| gatox | nessita, hi | 11:57 |
| nessita | hi gatox, how are things going? | 11:57 |
| mandel | nessita, morning! how was the holidays! | 11:57 |
| mandel | ??? | 11:57 |
| gatox | nessita, fine! you?? | 11:57 |
| nessita | mandel: awesome :-) | 11:57 |
| nessita | gatox: all good, ready to read thousands of emails! | 11:58 |
| mandel | nessita, cool, I hope you have energy for reviews hehe :) | 11:58 |
| gatox | nessita, jejeje | 11:58 |
| nessita | mandel: I have, yes :-) | 11:58 |
| mandel | nessita, sweet! let me know when you are done with the email and we can start trying landing all those control panel branches I have :) | 11:58 |
| nessita | mandel: let's do this: give me the 3 most important branches for review and I'll do them while reading email | 11:59 |
| mandel | nessita, sure, let me check | 11:59 |
| mandel | nessita, https://code.launchpad.net/~mandel/ubuntuone-control-panel/auto-update-functions/+merge/80237 https://code.launchpad.net/~mandel/ubuntuone-control-panel/auto-update-looping-call/+merge/81015 https://code.launchpad.net/~mandel/ubuntuone-windows-installer/put-migration-together/+merge/78995 | 12:00 |
| mandel | nessita, they are the oldest ones and I want to land them asap before they get conflicts | 12:01 |
| nessita | mandel: ack! | 12:01 |
| mandel | nessita, also, just because I know you will like to see it https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-tests/+merge/83267 fixes the sso tests that broke on windows with the new u1devtools | 12:01 |
| nessita | mandel: nice! | 12:02 |
| === eu is now known as Guest39654 | ||
| gatox | mandel, there is a lint issue in u1-client | 12:06 |
| gatox | ./tests/platform/windows/test_os_helper.py: | 12:07 |
| gatox | 285: undefined name 'WindowsError' | 12:07 |
| mandel | gatox, oh, due to running lint on linux | 12:08 |
| mandel | gatox, I'll add the disable comment, sorry | 12:08 |
| gatox | np | 12:08 |
| jdobrien | mandel: do you develop for windows in a VM? | 12:10 |
| mandel | hm.. nessita how you disable an error with pyflakes? | 12:10 |
| mandel | jdobrien, yes | 12:10 |
| nessita | mandel: afaik, you can't | 12:11 |
| nessita | mandel: you need to "fix" it | 12:11 |
| jdobrien | mandel: what do you prefer to run your vm with? | 12:11 |
| mandel | jdobrien, at the moment I'm using kvm on a main board that supports it, it does not have any fancy things like copy pasteing between os etc.. but I trade that for performance | 12:12 |
| mandel | jdobrien, virtual box is the option choosen by nessita and alecu AFAIK | 12:12 |
| mandel | nessita, weird.. because we already used WindowsError in the code and now we get the issue... | 12:13 |
| nessita | mandel: I would guess we're missing something... | 12:13 |
| nessita | mandel: what branch? | 12:13 |
| mandel | nessita, MP with the diff: https://code.launchpad.net/~mandel/ubuntuone-client/fix-817582/+merge/83925 | 12:14 |
| gatox | mandel, let me know when you update your branch | 12:17 |
| mandel | gatox, sure.. although to be hones, I don't know why we did not get the error before.. | 12:18 |
| mandel | gatox, if you look at the diff we already used the windows error | 12:18 |
| gatox | weird | 12:18 |
| nessita | mandel: sa far as I can see, WindowsErrors is not imported :-/ | 12:19 |
| nessita | as* | 12:19 |
| mandel | nessita, is not because is part of the stdlib, is like OSError | 12:20 |
| nessita | mandel: well, but on linux is not defined, so you get the lint issue | 12:20 |
| mandel | nessita, what I can do is to just use an OSError: http://docs.python.org/library/exceptions.html#exception-hierarchy | 12:20 |
| mandel | nessita, is less precise, but if it solves the issue.. | 12:21 |
| nessita | mandel: well, it makes sense as well, I'd say | 12:21 |
| mandel | nessita, ok, lets go with OSError and I'll add a comment about the reason :) | 12:22 |
| mandel | nessita, gatox, oh!!! I found something very interesting, look at line 64 of ubuntuone/platform/windows/os_helper.py | 12:23 |
| gatox | mandel, nessita i found that this branch needs reviews :P (when you have the time): https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/misaligned-icons/+merge/83620 | 12:24 |
| * gatox looking... | 12:24 | |
| nessita | gatox: ack | 12:24 |
| mandel | nessita, gatox and I are running O and tarmac is on N, there might be a diff in the pyflakes version | 12:24 |
| mandel | gatox, on it | 12:24 |
| gatox | cuack! | 12:24 |
| nessita | mandel: we can't run tarmac on O, since twisted and trial does not work with gi | 12:25 |
| mandel | nessita, ok, so I guess we can let it as it is, right? | 12:26 |
| * mandel launches N vm to test | 12:26 | |
| nessita | mandel: with the lint issue? no we can't | 12:27 |
| nessita | mandel: tests has to pass clean in all platform, up to lucid | 12:27 |
| mandel | nessita, all pass then on pre-O releases.. the issue is with O, I guess I can fix all the use of the WindowsError and use OSError, but we are loosing meaning in or exceptions :( | 12:29 |
| gatox | mandel, also, if you have a moment (really trivial) review (i thought that this branch has landed): https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/not-validated-account/+merge/83054 | 12:29 |
| nessita | mandel: or you can do the trick about defining WIndowsError to a dummy value within a try exceot clause (you already have done this, I recall) | 12:29 |
| mandel | nessita, true, I'll add that to the test file and we will be done with it! :) | 12:31 |
| gatox | mandel, if you are going to test it IRL, you will need the sso branch that you already approved | 12:31 |
| mandel | gatox, ok | 12:32 |
| ralsina | good morning again! | 12:36 |
| gatox | ralsina, hi!! how are you? | 12:37 |
| ralsina | gatox: hi, I'm ok! | 12:37 |
| nessita | hello ralsina! | 12:40 |
| ralsina | hi nessita: had a nice vacation? | 12:40 |
| nessita | ralsina: one of the bests :-) I realized I needed the rest more than I thought | 12:40 |
| ralsina | nessita: cool :-) | 12:41 |
| ralsina | cool that you had a nice vacation, not that you were exhausted ;-) | 12:41 |
| nessita | ralsina: heh | 12:41 |
| mandel | gatox, I just updated the branch to fix the pyflakes issue | 12:45 |
| gatox | mandel, reviewing.... | 12:45 |
| mandel | gatox, thx | 12:47 |
| gatox | mandel, +1 to your branch | 13:00 |
| mandel | gatox, thx! | 13:00 |
| duanedesign | clear | 13:07 |
| ralsina | mandel: still can't run your branch with latest devtools, it is not able to import the reactor | 13:13 |
| nessita | ralsina: did you install the reactor using the .deb I sent? | 13:13 |
| ralsina | nessita: on windows | 13:13 |
| ralsina | nessita: reactor installed using setup.py as you said | 13:14 |
| nessita | ah... does import qt4reactor work in a python terminal? | 13:14 |
| nessita | ralsina: perhpas you did not remove the old reactor? | 13:14 |
| ralsina | yes it works | 13:14 |
| ralsina | nessita: deleting all of them and installing again | 13:15 |
| mandel | ralsina, please look at how the setup.py of ubuntuone-dev-tools installed the code | 13:15 |
| ralsina | mandel: I have no idea what that means ;-) | 13:16 |
| mandel | ralsina, that setup.py does not work correctly on widows, double check that there is no ubuntuone-dev-tools in C:\Python27\Lib\site-pacakges | 13:16 |
| ralsina | mandel: oooooook | 13:16 |
| mandel | ralsina, if there is, look inside and move the code to the correct place.. I have to look at what is going on with auto in distutils extra | 13:17 |
| ralsina | mandel: I have a ubuntuone-dev-tools there. Fixing it | 13:17 |
| mandel | ralsina, I though so.. I need to fix dist utils extra on windows :( | 13:20 |
| ralsina | argh | 13:32 |
| ralsina | __import__('ubuntuone.devtools.reactors.qt4',None, None,['']) works | 13:32 |
| ralsina | but when run-tests.bat calls u1trial, that line fails :-( | 13:32 |
| nessita | mandel: can you please have alecu finishing the review for https://code.launchpad.net/~mandel/ubuntuone-control-panel/auto-update-looping-call/+merge/81015 before I tackle that? | 13:40 |
| mandel | nessita, certainly | 13:40 |
| nessita | mandel: anyways, since I started it, I added 2 simple fixes request that I saw while quickly browsing the diff | 13:42 |
| mandel | nessita, ok, no proble, will be fixing them after lunch | 13:42 |
| nessita | nice! | 13:42 |
| * mandel lunch | 13:45 | |
| rye | j0nr, re: songs rescan - yes, we are still working. I have reproduced this on my data which is not reproducible in development environment, I am very sorry for such long investigation | 13:59 |
| nessita | mandel: https://code.launchpad.net/~mandel/ubuntuone-windows-installer/put-migration-together/+merge/78995 has a couple of lint issues | 14:29 |
| dobey | hola nessita | 14:39 |
| nessita | hi dobey! how is it going? | 14:40 |
| dobey | eh ok | 14:40 |
| dobey | "with great power comes great awesome" or something i guess | 14:47 |
| gatox | oh crap.... i can't runn tests on windows..... | 14:48 |
| gatox | mandel, did you figure it out what it's going on with dev-tools? | 14:48 |
| gatox | or i should start trying to fix my machine? | 14:49 |
| * mandel back | 14:51 | |
| mandel | nessita, looking | 14:51 |
| mandel | gatox, ralsina had a similar issue, ralsina did you fix it? | 14:51 |
| dobey | hrmm | 14:51 |
| gatox | i'm algo having issues with the qtreactor..... nessita is there any new .deb or with the one you sent should work? | 14:52 |
| nessita | gatox: what issue? | 14:52 |
| gatox | cannot import | 14:52 |
| gatox | let me show you the trace | 14:53 |
| ralsina | mandel: not yet | 14:53 |
| gatox | http://paste.ubuntu.com/754954/ | 14:53 |
| gatox | nessita, ^^ | 14:53 |
| nessita | gatox: that's an old devtools? did you updated and reinstalled? | 14:54 |
| gatox | yes....... i will try again | 14:54 |
| dobey | nessita: did the installation of qtreactor get updated on windows also? | 14:57 |
| nessita | dobey: not sure what you mean... at what code level/project? | 14:57 |
| dobey | nessita: packaging i guess. i am not sure how we were using it on windows before, but changing all the imports means it would need to be located somewhere else there also, no? | 14:58 |
| nessita | dobey: in windows we just need to ./setup.py install it | 14:59 |
| dobey | although i guess that was changed | 14:59 |
| dobey | nessita: right, but it didn't have a setup.py before :) | 14:59 |
| nessita | dobey: it does now! :-) | 14:59 |
| dobey | right, ok | 15:00 |
| mandel | me | 15:00 |
| gatox | nessita, yep..... dev-tools wasn't up to date | 15:01 |
| nessita | me | 15:01 |
| ralsina | me | 15:03 |
| gatox | me | 15:03 |
| nessita | dobey: say me please? | 15:04 |
| dobey | meh | 15:04 |
| nessita | mandel: go! | 15:04 |
| mandel | DONE: Fixes for bug 817582, bug 881186. Updated branches lp:~mandel/ubuntu-sso-client/fix-tests, lp:~mandel/ubuntuone-dev-tools/proxy-testcase and lp:~mandel/ubuntuone-windows-installer/put-migration-together | 15:04 |
| mandel | TODO: Ensure that lp:~mandel/ubuntuone-windows-installer/put-migration-together, lp:~mandel/ubuntuone-control-panel/auto-update-looping-call and lp:~mandel/ubuntuone-dev-tools/proxy-testcase get reviewed and landed. | 15:04 |
| mandel | BLOCKED: no | 15:04 |
| mandel | nessita, welcome back, and go! | 15:04 |
| ubot4 | Launchpad bug 817582 in ubuntuone-client "Windows: _set_file_attributes should raise a more specific error when the path does not exist (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/817582 | 15:04 |
| ubot4 | Launchpad bug 881186 in ubuntuone-client "Windows: SyncDaemonTool is not robust (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/881186 | 15:04 |
| nessita | DONE: vacations!!! | 15:04 |
| nessita | TODO: catch up, 1-1 with ralsina | 15:04 |
| nessita | BLOCKED: nopes | 15:04 |
| nessita | NEXT: ralsina | 15:04 |
| ralsina | writing notes, will be done in 1' | 15:04 |
| ralsina | DONE: build for QA, finished release (took two weeks!), calls calls calls, art! (http://www.flickr.com/photos/ralsina/6430541415/in/photostream), misc administrivia, canonicaladmin | 15:05 |
| ralsina | TODO: more of the same, ensure you all have a place to sleep | 15:05 |
| ralsina | BLOCKED: no | 15:05 |
| gatox | me? | 15:05 |
| ralsina | gato, yes, sorry | 15:06 |
| gatox | DONE: | 15:06 |
| gatox | Bug #856362, Bug #862403, Fixed Not Validate Account installer-sso flow, More alecu's reviews, yesterday: swap day. | 15:06 |
| gatox | TODO: | 15:06 |
| gatox | Fix some UI bugs. | 15:06 |
| gatox | BLOCKED: | 15:06 |
| gatox | No | 15:06 |
| ubot4 | Launchpad bug 856362 in ubuntuone-control-panel " On the devices tab in u1cp, the icons are misaligned (affects: 1) (heat: 11)" [Low,In progress] https://launchpad.net/bugs/856362 | 15:06 |
| ubot4 | Launchpad bug 862403 in ubuntu-sso-client "Fix double back navigation in SSO reset code page (affects: 1) (heat: 10)" [Low,New] https://launchpad.net/bugs/862403 | 15:06 |
| gatox | dobey, go | 15:06 |
| dobey | λ DONE: holidays, got a mostly working gir-based reactor working, started rbox dailies work | 15:06 |
| dobey | λ TODO: deal with reactor upstream stuff and weird gir bug, finish rbox dailies, move some stuff around, make some awesome | 15:06 |
| dobey | λ BLCK: No. | 15:06 |
| nessita | dobey: YEY! ->"got a mostly working gir-based reactor working" | 15:07 |
| mandel | +1 to that! | 15:07 |
| nessita | dobey: what's left to have it fully working? | 15:08 |
| nessita | NOTE: next week, during the sprints, besides coding we\ ll have some dedicated sessions. ralsina and I will be updating the agenda today and tomorrow | 15:08 |
| dobey | nessita: fixing glib/pygobject stuff, getting the more "proper" implementation fixed up, and getting it tested/reviewed/landed | 15:09 |
| dobey | nessita: and then fixing our tests and stuff that are broken because of it | 15:09 |
| nessita | dobey: ack | 15:10 |
| nessita | any comments anyone? | 15:10 |
| mandel | nessita, I think that the issues we have with ubuntuone-dev-tools can be fixed by looking at what distuitls extra is doing wrong on windows, we might as well fix the issue there | 15:11 |
| mandel | nessita, I know gatox lost a lot of time fighting with that | 15:11 |
| nessita | mandel: what issue we're having with udevtools? | 15:12 |
| mandel | nessita, also, there is a bug that states that u1 (specially make_link) does not working with window x64, would be nice to look into that since it might mean building to packages (I hope not) | 15:12 |
| mandel | nessita, the setup.py on windows installs the code under C:\Python27\Lib\site-pacakages\ubuntuone-dev-tools which makes python on windows get confused | 15:13 |
| dobey | hmm | 15:13 |
| nessita | mandel: why it gets confused? | 15:13 |
| mandel | s/to pacakges/two packages | 15:13 |
| mandel | nessita, I think it has to do with the egg info, but I have not looked into it, I know that if you manually put devtools under ubuntuone it works | 15:14 |
| nessita | mandel: what's the problem/error in particular? I have no issues in my windows install | 15:14 |
| mandel | nessita, I'm saying conjectures.. but what is for sure is that setup.py is doing something funny | 15:14 |
| mandel | nessita, unless I'm wrong when ralsina did python setup.py install it placed the pacakge under ubuntuone-dev-tools and the import was using the old one, ralsina am I right? | 15:15 |
| ralsina | mandel: yes, but fixing that doesn't fix it | 15:15 |
| mandel | ralsina, :( | 15:15 |
| mandel | so we do have a problem there... | 15:16 |
| nessita | ralsina, mandel: do you have a trace about the issue you're having? | 15:16 |
| ralsina | nessita: not a trace because it's in a try/except | 15:16 |
| mandel | nessita, I have no issues, we have to get the trace and setup form ralsina and gatox | 15:16 |
| ralsina | I will get one now | 15:16 |
| nessita | mandel: I still can't understand what's the specific error. I would guess people is having mixed versions of devtools.... | 15:17 |
| nessita | gatox: are you still having this issue? | 15:17 |
| mandel | nessita, seems reasonable, I just mean that we should look into the issue so that people do not waste time with that the next time there is an update | 15:18 |
| ralsina | nessita, mandel: if I change u1trial so that it doesn't catch the importerror, I get this: https://pastebin.canonical.com/56547/ | 15:19 |
| ralsina | nessita, mandel: it seems to be trying to import the wrong reactor | 15:19 |
| nessita | ralsina: have you updated udevtools in your windows install? | 15:20 |
| mandel | ralsina, nessita I know we changed the way u1trial handles the options, we might have a small regression there, ralsina can you paste the code of u1trial? | 15:20 |
| ralsina | nessita: yes | 15:20 |
| mandel | ralsina, if it uses optparse it is old | 15:20 |
| nessita | ralsina: ah, perhaps is not related to the qt4reactor but to that change mandel is talking about? | 15:21 |
| ralsina | mandel: no optparse that I can see | 15:21 |
| ralsina | mandel: u1trial --> https://pastebin.canonical.com/56548/ | 15:22 |
| mandel | nessita, ralsina I'm not an expert on u1trial Options parsing.. we should look if is opt_reactor is actually executed or if it is leaving options['reactor'] = 'glib' which could explain the issue | 15:25 |
| ralsina | mandel, nessita: I'll check | 15:25 |
| dobey | mandel: eh? | 15:26 |
| mandel | dobey, look at https://pastebin.canonical.com/56547/ | 15:26 |
| dobey | mandel: yes, i know the code | 15:26 |
| dobey | i just wrote it like last week | 15:26 |
| mandel | dobey, that is not the code, that is the trace ;)_ | 15:27 |
| ralsina | mandel, nessita, dobey: it seems to be getting glib as config['reactor'] | 15:27 |
| dobey | right; why are you using the default reactor? | 15:27 |
| ralsina | I am not, I am calling it with --reactor=qt4 | 15:27 |
| dobey | ralsina: you need to move the path argument to the last one | 15:27 |
| mandel | dobey, he is not, look at the first line | 15:27 |
| ralsina | mandel: what dobey said | 15:27 |
| dobey | ralsina: move ubuntu_sso to the end | 15:27 |
| mandel | dobey, what?! does that make a diff? | 15:28 |
| dobey | yes | 15:28 |
| dobey | i don't know why yet though | 15:28 |
| dobey | trial's option parsing is apparently doing something odd | 15:28 |
| mandel | dobey, oh, well is an easy fix so not big deal, we just have to change all run-tests :P | 15:29 |
| mandel | boring, yet doable hehe | 15:29 |
| dobey | yes, we do | 15:29 |
| dobey | sorry; i didn't realize it was broken until one branch failed because of it; and then i didn't think that maybe other things need to change the order too | 15:30 |
| mandel | dobey, bah, is not a big deal :) | 15:30 |
| mandel | dobey, I'll add that change to my sso branch :) | 15:31 |
| ralsina | dobey: just pretend it's a BSD-style CLI | 15:33 |
| ralsina | dobey: and you did it on purpose as a late hommage to Dennis Ritchie | 15:33 |
| dobey | i'll just blame twisted | 15:33 |
| mandel | it is twisted hehe lame joke | 15:33 |
| dobey | i think i will severely lower my coding standards | 15:34 |
| dobey | because i am so tired of trying to do things the correct way, and having the platform be so broken | 15:34 |
| mandel | ralsina, gatox I pushed a new version of lp:~mandel/ubuntu-sso-client/fix-tests with the parameters correctly ordered, can you take a look | 15:36 |
| mandel | pleeeeease | 15:36 |
| gatox | mandel, on it | 15:36 |
| mandel | dobey, well, as long as we remember all this little things we are fine.. the problem is wasting time on things like this :( | 15:36 |
| ralsina | mandel: trying | 15:37 |
| dobey | mandel: ah, but this trial arguments issue *is* tiny; i'm talking about other things that are wasting my time | 15:38 |
| ralsina | mandel: green light! | 15:38 |
| mandel | dobey, I suppose.. clearly if parsing args is broken and is a problem solved in other places for ages there most be other problems too :) | 15:38 |
| mandel | ralsina, \o/ | 15:38 |
| ralsina | mandel: but you have a needs fixing | 15:39 |
| mandel | ralsina, from alecu, I know | 15:39 |
| mandel | ralsina, is he in 2day? | 15:39 |
| dobey | i think i'll just give up and make this reactor use the mysterious API that's not supposed to be there, but is | 15:40 |
| ralsina | mandel: not today | 15:40 |
| mandel | ralsina, well, then it will land tom | 15:40 |
| ralsina | dobey: he | 15:40 |
| dobey | at least it will work, even if it may randomly break sometime in the future | 15:41 |
| ralsina | dobey: the trick is, if you use it, they can't make it go away later | 15:41 |
| dobey | ralsina: i'm pretty sure that's not true | 15:41 |
| ralsina | dobey: well, it's true in some cases. In others it's completely the opposite of true. | 15:41 |
| dobey | ralsina: i don't trust upstream to not break it | 15:42 |
| dobey | ralsina: in fact, i was going to break it today | 15:42 |
| dobey | ralsina: and make the API that should be used, actually be exposed in the gobject-introspection stuff | 15:43 |
| ralsina | makes sense | 15:43 |
| dobey | ralsina: but now, i am just tired of upstream :( | 15:43 |
| ralsina | then again, it looks like a lot of work just to clean after others | 15:43 |
| dobey | it's a good thing i am getting a massage this afternoon | 15:44 |
| gatox | mandel, +1 | 15:45 |
| dobey | man, all that work i did yesterday, and my lp karma went down 50 points | 15:46 |
| mandel | gatox, thx! | 15:46 |
| mandel | dobey, haha karma does not matter :P | 15:46 |
| nessita | dobey: why would karma go down? | 15:46 |
| mandel | ralsina, dobey one quick question, do you guys know what bloody daemon keeps re-writing /etc/resolve.conf on ubuntu? | 15:47 |
| dobey | nessita: if you don't maintain velocity, it goes down | 15:47 |
| nessita | dobey: bu | 15:47 |
| dobey | mandel: network manager | 15:47 |
| dobey | and it's resolv.conf | 15:47 |
| dobey | mandel: it says it in the first line of the file :) | 15:48 |
| dobey | # Generated by NetworkManager | 15:48 |
| mandel | dobey, the one I deleted ages ago ;) | 15:48 |
| mandel | dobey, is there a way to tell it to add a search and name server lines? | 15:48 |
| dobey | mandel: it does that automatically | 15:49 |
| dobey | mandel: does your dhcp server not send DNS info when a machine gets an ip from it? | 15:49 |
| mandel | dobey, no.. I guess I have to look at that.. | 15:50 |
| mandel | I'll do it later then | 15:50 |
| dobey | mandel: you can configure it manually in the UI though | 15:50 |
| ralsina | mandel: also, your DHCP server is broken ;-) | 15:50 |
| dobey | mandel: right-click on the panel icon and choose "Edit connections" | 15:50 |
| dobey | mandel: and configure dns manually for the connection | 15:51 |
| dobey | also, fix your dhcp server | 15:51 |
| mandel | ralsina, dobey I'll fix the DHCP then :) | 15:51 |
| mandel | nessita, lp:~mandel/ubuntuone-windows-installer/put-migration-together fixed with no more lint issues | 15:51 |
| nessita | mandel: ack! | 15:52 |
| mandel | gatox, can I have a review for this guy too: https://code.launchpad.net/~mandel/ubuntuone-client/fix-881186/+merge/83957 | 15:59 |
| mandel | ralsina, can I have one for this: https://code.launchpad.net/~mandel/ubuntuone-client/fix-817582/+merge/83925 | 15:59 |
| gatox | mandel, yep..... i'll do it in a sec..... i'm finishing with a branch | 15:59 |
| mandel | gatox, sure thx, I'm be doing yours know | 16:00 |
| IAmNotThatGuy | mohidevilzzzzzz | 16:00 |
| mandel | gatox, that is ugly: self.ui.ui.blah I wont ask you to change it, but a ui inside a ui :P | 16:01 |
| gatox | mandel, where? | 16:01 |
| mandel | https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/misaligned-icons/+merge/83620 line 127 :) | 16:02 |
| mandel | gatox, ^ but don't worry too much hehe | 16:02 |
| gatox | mandel, mmmmm yes..... looks messy.... | 16:02 |
| alecu | hello all! | 16:03 |
| alecu | mandel, ping | 16:03 |
| IAmNotThatGuy | Whoops! wrong window. Pardon me | 16:03 |
| mandel | gatox, yeah, it would be nice to have it more normal | 16:03 |
| dobey | hi alecu | 16:03 |
| gatox | mandel, let me change it..... it'll avoid curses in the future :P | 16:03 |
| mandel | alecu, ponga! | 16:03 |
| gatox | alecu, hi! | 16:03 |
| mandel | gatox, sure :) | 16:03 |
| alecu | mandel, I'm not supposed to be here today, but I wanted to relay this bit: | 16:03 |
| mandel | alecu, go ahead! | 16:04 |
| alecu | mandel, I've got a webclient branch that uses your u1-dev proxy branch, but the authenticated stuff seems to not work | 16:04 |
| alecu | mandel, https://code.launchpad.net/~alecu/ubuntu-sso-client/proxy-integration-tests | 16:04 |
| mandel | alecu, hum.. I'll look into it and will make sure is ready for whenever you are back, does nonauth work? | 16:05 |
| alecu | mandel, nonauth works just fine! | 16:05 |
| alecu | mandel, I'm running my branch pointing at yours, like this: | 16:05 |
| alecu | TRIAL_TEMP_DIR=~/temp/trial_temp_dir PYTHONPATH=~/canonical/ubuntuone-dev-tools/review_proxy-testcase/ PATH=$PATH:~/canonical/ubuntuone-dev-tools/review_proxy-testcase/bin/ ./run-tests -qt ubuntu_sso/utils/tests/test_webclient.py | 16:05 |
| mandel | alecu, i'll add some urllib2 tests with basic auth to see what is going on | 16:05 |
| alecu | mandel, I even tried with a "import pdb; pdb.set_trace()" after your branch starts squid, and configuring firefox to use the proxy that your branch starts | 16:06 |
| mandel | alecu, does firefox work? | 16:06 |
| alecu | mandel, but squid keeps saying "407: unauthorized" | 16:06 |
| mandel | alecu, 'cause I did that and was working for me | 16:06 |
| * dobey looks at this squid insanity branch again | 16:06 | |
| mandel | alecu, hm.. I'll take a look | 16:06 |
| dobey | mandel: ugh; your commit message sucks :) | 16:07 |
| alecu | mandel, even after entering the right password... | 16:07 |
| mandel | dobey, ofcourse they do,! | 16:07 |
| mandel | alecu, ok, I'll take a look asap (I have few bugs in my hands :) ) | 16:07 |
| alecu | mandel, no problem | 16:08 |
| mandel | alecu, at least I won't dealy you much, or so I hope | 16:08 |
| alecu | mandel, btw: ncsa_auth works fine for me: I start it with the path of the file that holds the passwords, then I type "user:pass", and it says "OK" | 16:09 |
| alecu | mandel, so it looks like something on my squid conf | 16:09 |
| mandel | alecu, before you go, can you run the tests for https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-tests/+merge/83267 | 16:10 |
| mandel | alecu, yeah, it might be the acls, they force you to use the right port and have the auth | 16:11 |
| alecu | mandel, sorry, I really need to run. I'll do it first thing in the morning tomorrow. | 16:11 |
| mandel | if you use the other port it fails, but I probably got that wrong | 16:11 |
| mandel | alecu, sure, disfruta! a2 | 16:11 |
| === beuno is now known as beuno-lunch | ||
| alecu | adeus! | 16:11 |
| mandel | ralsina, nessita what the hell do i do with bug 626903 | 16:14 |
| ubot4 | Launchpad bug 626903 in ubuntuone-windows-installer "UbuntuOne installer should be tested against the Windows Logo Program software requirements (affects: 1)" [Medium,Triaged] https://launchpad.net/bugs/626903 | 16:14 |
| mandel | ?? | 16:14 |
| ralsina | wishlist? | 16:14 |
| mandel | ralsina, nessita and bug 696185 | 16:14 |
| ubot4 | Launchpad bug 696185 in ubuntuone-windows-installer "AVG Identify Protection detects Ubuntu One Client.exe as malware (affects: 2)" [Low,Triaged] https://launchpad.net/bugs/696185 | 16:14 |
| ralsina | mandel: that one is fixed, or a duplicate of it was at least | 16:15 |
| mandel | ralsina, sweet! | 16:15 |
| ralsina | mandel: I contacted avg myself | 16:15 |
| ralsina | there | 16:15 |
| ralsina | fix-released ;-) | 16:15 |
| mandel | ralsina, thx :) | 16:15 |
| nessita | mandel: I have no idea about bug 626903... you assigned to yourself :-) | 16:16 |
| ubot4 | Launchpad bug 626903 in ubuntuone-windows-installer "UbuntuOne installer should be tested against the Windows Logo Program software requirements (affects: 1)" [Medium,Triaged] https://launchpad.net/bugs/626903 | 16:16 |
| mandel | nessita, yeah.. I was hoping you would say give it to ralsina heheh :P | 16:16 |
| nessita | mandel: did you ask to elliot about it when you assigned to yourself? | 16:16 |
| mandel | nessita, yeah, we have to run some tests and if we pass them we get to put a nicce windows logo in or installer :P | 16:17 |
| nessita | mandel: not sure we want to do that, at least in the short term | 16:18 |
| ralsina | mandel: I somehow doubt that we *want* to have a windows logo? ;-) | 16:18 |
| mandel | ok, so wishlist :) | 16:18 |
| ralsina | mandel: keep it at low, or downgrade to wishlist | 16:18 |
| nessita | mandel: and yes, I think that decision has to be made by ralsina/higher in the bosses chain? | 16:18 |
| ralsina | nessita: consider it decided ;-) | 16:18 |
| nessita | heh | 16:18 |
| ralsina | as in "I have decided not to care" and remind me in three months | 16:19 |
| gatox | ralsina, nessita mandel (anyone of you, if you can) easy review: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/fix-double-navigation/+merge/83973 | 16:21 |
| gatox | mandel, reviewing yours now | 16:21 |
| === Guest39654 is now known as adorilson | ||
| === beuno-lunch is now known as beuno | ||
| ralsina | gatox: looking! | 16:24 |
| ralsina | gatox: +1 nice fix on the back() | 16:25 |
| gatox | ralsina, :D | 16:26 |
| ralsina | gatox: it may make sense to have a generic go_to(id) that does the smart thing | 16:28 |
| ralsina | gatox: but that's just wishful thinking | 16:28 |
| gatox | ralsina, yes, it has perfect sense, it is easy to implement..... do you want me to change it to use something like that? | 16:29 |
| mandel | gatox, no tests? | 16:29 |
| gatox | mandel, hey!! it has tests | 16:30 |
| ralsina | gatox: if we did implement it, then we would have to use it ;-) | 16:30 |
| gatox | mandel, more tests adding right now! :P | 16:30 |
| gatox | ralsina, jejee true :P | 16:30 |
| mandel | gatox, I was going to say.. if there are already tests and it was not failig.. there was a problem :) | 16:30 |
| ralsina | there is coverage for that part, isn't there? It just changes how the back() is done | 16:30 |
| ralsina | yes, the test needs to be changed so it fails without the fix :-) | 16:31 |
| gatox | ralsina, i should test too if the id it not in the visitedPages i think | 16:31 |
| gatox | i've modified the tests....... | 16:31 |
| * gatox lookiing... | 16:31 | |
| gatox | ah there is no need to modified the tests that was testing that code..... just adding the visitedPages to the Fake works just fine | 16:32 |
| gatox | test the same thing | 16:32 |
| gatox | but i'll add a test for the case when the id is not in the visitedPages | 16:33 |
| gatox | but.... after lunch..... brb!! :D | 16:34 |
| gatox | but before lunch, +1 to mandel branch (https://code.launchpad.net/~mandel/ubuntuone-client/fix-881186/+merge/83957) | 16:35 |
| mandel | gatox, sweet! thx | 16:35 |
| dobey | well i am sure mandel won't like my review | 16:35 |
| mandel | dobey, why won't I? | 16:36 |
| mandel | did you mention my mum? | 16:36 |
| dobey | i voted disapprove | 16:37 |
| mandel | dobey, oh well, you have the right ;) | 16:37 |
| dobey | mandel: only in reference to tentacles | 16:37 |
| dobey | mandel: but at least you aren't telling me i should understand python well enough to be able to debug your broken ass python script that requires a module from the same project to be installed to the system in some weird place, yet won't run from the locally built version by default | 16:39 |
| mandel | dobey, so, lets see step by step: get_arbitrary_port => there is no other simple way, sorry I know is ugly | 16:39 |
| mandel | dobey, get_default_tempdir => I just moved that out of the dbus service so that the code is shared, I think a refactoring so that it gets passed is a far better way to do it (which you mentioned) | 16:40 |
| mandel | dobey, 'squid tests won't work on ipv6 configurations' => why? | 16:41 |
| mandel | dobey, and I don't think squid is a system level service as much as i don't think apache is a system level one too, specially if squid is ran with -N which just makes it a normal process listening to a port (or two for that matter) | 16:42 |
| mandel | dobey, nevertheless we can wait 'til thrusdays mumble to get everyones input :) | 16:43 |
| mandel | nessita, can you think of a way to test for the fix of bug 881193, I'd need to be able to change the hosts file, which is a major pita and would require the user to run as root | 16:44 |
| ubot4 | Launchpad bug 881193 in ubuntuone-client "Windows: LOCALHOST constant may need improvement (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/881193 | 16:44 |
| nessita | mandel: looking | 16:45 |
| mandel | nessita, thx | 16:45 |
| nessita | mandel: please explain to me what the fix would be, because I'm not sure how we want to calculate LOCALHOST now... as far as I recall alecu mentioned we should use 127.0.0.1? | 16:47 |
| dobey | mandel: actually, i need to go get lunch, but would love to discuss it :) | 16:48 |
| mandel | dobey, sure I should be here for a little longer :) | 16:49 |
| mandel | nessita, we should not use 127.0.0.1 because people can change the ip of the local host editing the hosts files.. although is no a very common situation | 16:49 |
| mandel | nessita, let me get you some info about the hosts file | 16:49 |
| dobey | ok, bbiab; lunch | 16:49 |
| nessita | mandel: I honestly don't think this needs further work on our end, other than changing "localhost" by 127.0.0.1 | 16:50 |
| mandel | nessita, then is already solved and I'll set the bug as invalid :) | 16:50 |
| mandel | ok | 16:50 |
| mandel | ?? | 16:51 |
| nessita | mandel: but shouldn't we change "localhost" by 127.0.0.1 | 16:51 |
| nessita | ? | 16:51 |
| mandel | nessita, is already done in trunk | 16:51 |
| nessita | mandel: ok then, Invalid +1 | 16:52 |
| mandel | nessita, ralsina may I have another review for: https://code.launchpad.net/~mandel/ubuntuone-client/fix-817582/+merge/83925 | 16:53 |
| ralsina | mandel: doesn't pylint complain that you are raising a non-Exception? | 16:54 |
| mandel | ralsina, nope | 16:55 |
| mandel | ralsina, and is pyflakes | 16:55 |
| ralsina | or calling None as a function? :-/ | 16:55 |
| mandel | ralsina, nope | 16:55 |
| * ralsina bets pylint would complain | 16:55 | |
| mandel | ralsina, flakes does not, I can make it callable using a lambda, but is already ugly to be having to create a WindowError so that it does not complain :P | 16:56 |
| ralsina | mandel: you could use Exception instead of None | 16:56 |
| mandel | ralsina, also, let me do that | 16:56 |
| ralsina | mandel: I know it's nitpicking but it's a bit eye-hurting using None there | 16:57 |
| ralsina | mandel: so, sorry, and I'll pay for that change in beer | 16:57 |
| mandel | ralsina, nah, no worries :) | 16:57 |
| mandel | ralsina, done, let me run the tests just incase hehe | 16:58 |
| ralsina | hehe | 16:58 |
| nessita | mandel: put migration together: ./ubuntuone_installer/gui/qt/utils/windows.py:72:1: E302 expected 2 blank lines, found 1 | 16:59 |
| mandel | nessita, ahg, I did not get that, le me fix it, I'm terribly sorry | 16:59 |
| nessita | mandel: let me know when is fixed :-) | 17:00 |
| mandel | ok | 17:01 |
| === m_conley_away is now known as m_conley | ||
| mandel | nessita, which revno is that? | 17:03 |
| nessita | mandel: latest, I just branched | 17:04 |
| nessita | mandel: under linux | 17:04 |
| nessita | Branched 92 revision(s). | 17:04 |
| nessita | no, sorry | 17:04 |
| mandel | nessita, I'm doing pep8 ubuntuone_installer/gui/qt/utils/windows.py --repeat and I get nothing :( | 17:04 |
| nessita | mandel: did you try pep8 --repeat ubuntuone_installer/gui/qt/utils/ | 17:05 |
| nessita | ? | 17:05 |
| mandel | nessita, I have revno 107 | 17:05 |
| nessita | mandel: the thing is when I merged against trunk I have no revno | 17:05 |
| nessita | mandel: branching again | 17:05 |
| mandel | nessita, just did pep8 --repeat ubuntuone_installer/gui/qt/utils/ just incase on my branch without trunk and is ok | 17:06 |
| nessita | mandel: what OS? | 17:06 |
| nessita | and version | 17:06 |
| mandel | nessita, Ubuntu O | 17:06 |
| mandel | pep8 version 0.6.1 | 17:07 |
| nessita | mandel: latest thing pushed, has the following: | 17:07 |
| nessita | 70 AUTO_UPDATE_EXE = 'autoupdate-windows.exe' | 17:07 |
| nessita | 71 | 17:07 |
| nessita | 72 class UninstallException(Exception): | 17:07 |
| nessita | so a line is indeed missing | 17:07 |
| nessita | mandel: what do you have there? | 17:07 |
| mandel | nessita, ah, it happens when you do a merge with trunk.. funny | 17:08 |
| mandel | nessita, I'll merge with trunk, fix the issue and will push | 17:09 |
| nessita | mandel: ack | 17:09 |
| mandel | ralsina, updated: https://code.launchpad.net/~mandel/ubuntuone-client/fix-817582/+merge/83925 | 17:15 |
| nessita | lunchtime!!! | 17:17 |
| mandel | nessita, lp:~mandel/ubuntuone-windows-installer/put-migration-together updated with a merge to trunk and pep8 fixes | 17:18 |
| mandel | nessita, que aproveche! | 17:18 |
| mandel | ralsina, can I have another review for https://code.launchpad.net/~mandel/ubuntuone-client/fix-881186/+merge/83957 is also another very easy branch | 17:21 |
| ralsina | mandel: looking | 17:21 |
| mandel | ralsina, thx :) | 17:21 |
| ralsina | dobey, mandel, gatox, nessita, thatfred: check your emails :-) | 17:24 |
| duanedesign | nessita: is their a windows bug having to do with syncing the Documents folder? | 17:24 |
| ralsina | duanedesign: there is no specific bug about the Documents folder, except that if you add it as a UDF and you have a lot of stuff there, you will probably cause sd to reach the 2GB memory limit and fail | 17:25 |
| duanedesign | ok thanks | 17:26 |
| gatox | ralsina, :D thanks! | 17:29 |
| ralsina | gatox: you're welcome :-) | 17:30 |
| mandel | ralsina, I must say it in public too, thx!!! | 17:31 |
| ralsina | mandel: you're welcome too :-) | 17:32 |
| === davidcalle_ is now known as davidcalle | ||
| nessita | ralsina: thanks! :-) | 17:40 |
| ralsina | nessita: buy books for the kindle :-) | 17:41 |
| nessita | ralsina: I certainly will :-) | 17:41 |
| ralsina | nessita: which one are you getting? | 17:42 |
| nessita | ralsina: kindle touch :-) | 17:42 |
| nessita | I can't wait to have it in my hands! | 17:42 |
| ralsina | nessita: dobey has mine ;-) | 17:42 |
| nessita | eric has mine... | 17:42 |
| beuno | jdo has mine | 17:43 |
| mandel | haha guys, move out of argentina, just for the gadgets | 17:45 |
| mandel | I have gatox laptop :P | 17:45 |
| gatox | jejejejjej | 17:45 |
| ralsina | mandel: it's ok, we have mules | 17:47 |
| ralsina | but yes, we live in the no-gadget-zone | 17:47 |
| mandel | ralsina, If half of the team does not get in the country, don't be surprised! | 17:48 |
| beuno | it's ok, you have gadgets to use a bribes | 17:48 |
| dobey | ralsina: muy gracias ralsina | 17:50 |
| ralsina | dobey: my pleasure :-) | 17:51 |
| dobey | mandel: squid not working on ipv6 means that all the config i see in the squid.conf.in, only has ipv4 addresses | 17:52 |
| mandel | dobey, ok, makes sense, but we can set that as a bug for the testcase, I mean, lets start step by step (also, I don't know how it works with ipv6) | 17:53 |
| dobey | mandel: of course; there are bigger problems to deal with :) | 17:54 |
| mandel | dobey, yeah | 17:54 |
| dobey | "Spam not delivered" | 17:59 |
| dobey | then why is it in my mailbox! | 17:59 |
| mandel | hehe | 18:02 |
| === zyga is now known as zyga-afk | ||
| mandel | ok, EOD for me today see you all tom | 18:10 |
| dobey | cheers | 18:10 |
| mandel | dobey, we talk tom about the branch during the mumble, ok? | 18:10 |
| dobey | sorry i hate your branch, but it's not your fault :) | 18:10 |
| mandel | dobey, I never take thins things personally hehe | 18:10 |
| mandel | dobey, is part of the job :D | 18:10 |
| dobey | mandel: it's like playing golf | 18:11 |
| mandel | dobey, exactly, pub golf hehe :) | 18:11 |
| nessita | gatox: misaligned-icons approved | 18:13 |
| gatox | nessita, great!! i saw your e-mail..... was globally approved too? | 18:14 |
| gatox | i'm fixing one small bug.... and then go back to an unicode issue :P | 18:14 |
| gatox | but simpler | 18:14 |
| nessita | ok, I'm back | 18:25 |
| nessita | USB went nuts | 18:25 |
| duanedesign | what does this error mean on the windows client? WebClientError '400' 'Invalid consumer.' | 18:25 |
| nessita | gatox: you were saying? | 18:25 |
| gatox | nessita, abous misaligned-icons | 18:25 |
| gatox | <gatox> nessita, great!! i saw your e-mail..... was globally approved too? | 18:25 |
| gatox | <gatox> i'm fixing one small bug.... and then go back to an unicode issue :P | 18:25 |
| gatox | <gatox> but simpler | 18:25 |
| nessita | gatox: no globally approved, so you can seek a second review ;-) | 18:26 |
| dobey | duanedesign: the consumer token is invalid, most likely? | 18:26 |
| gatox | nessita, ok...... roger that | 18:26 |
| ralsina | duanedesign: that error means an account that is not validated | 18:27 |
| ralsina | duanedesign: and should never ever ever happen :-) | 18:27 |
| duanedesign | ralsina: do you know if their is an easy workaround for a user? | 18:28 |
| ralsina | duanedesign: delete the token from windows, then re-login | 18:28 |
| ralsina | duanedesign: the steps to delete the token change depending on windows version, though | 18:29 |
| duanedesign | ugh, let me see | 18:29 |
| duanedesign | ralsina: this case happens to be XP | 18:30 |
| ralsina | duanedesign: of course | 18:30 |
| ralsina | duanedesign: in that case, the token is in the registry, but I don'thave the exact path handy :-( | 18:30 |
| duanedesign | no worries I can find it. thank you. been a gret help | 18:31 |
| nessita | duanedesign: that error means the user is using credentials he has revoked on the web *or* he has the time wrong | 18:33 |
| nessita | ralsina: I don't think it has to do with validation... we don't let the U1 app move on if the user is not validated (ie we don't store the credentials in the keyring if the user is not validated) | 18:34 |
| nessita | ralsina: did you had any prior experience where we allow an unvalidated user use the U1 app? | 18:34 |
| nessita | gatox, ralsina_: any reason why this is marked as Invalid? https://bugs.launchpad.net/ubuntuone-control-panel/+bug/894438 | 18:54 |
| ubot4 | Launchpad bug 894438 in ubuntuone-control-panel "The --minimized option is ignored on windows (affects: 1) (heat: 6)" [Medium,Invalid] | 18:54 |
| ralsina_ | nessita: yes, because the bug was in my own head | 18:55 |
| ralsina_ | nessita: I have a branch that I merge with releases (but I cleaned up and am proposing it tomorrow ;-) which caused the problem | 18:55 |
| gatox | true story :P | 18:55 |
| * ralsina_ forbids gatox from reading 9gag | 18:56 | |
| nessita | ralsina_: ah! so I did not break controlpanel with the refactor? | 18:57 |
| ralsina_ | nessita: no you didn't | 18:57 |
| gatox | ralsina_, jeje what?? didn't understood... :( | 18:57 |
| ralsina_ | I apoogized to alecu last week, now I apologize to you ;-) | 18:57 |
| ralsina_ | gatox: let me find an example | 18:57 |
| nessita | ralsina_: great news! I felt bad about that | 18:58 |
| nessita | dobey: ping | 19:02 |
| dobey | nessita: yes? | 19:02 |
| nessita | dobey: I'm having this error on windows when trying to run the client test suite: http://pastebin.ubuntu.com/755240/ | 19:02 |
| nessita | dobey: did something changed on devtools? did you revert the sso dependency? | 19:02 |
| nessita | or is this related to the optparse thingy? | 19:03 |
| dobey | nessita: you probably need to change the ordering of the arguments | 19:03 |
| nessita | dobey: checking | 19:03 |
| dobey | nessita: since that trace suggest it's loading dbus stuff | 19:03 |
| nessita | yeap | 19:03 |
| nessita | dobey: no change, I'm running this commnad: | 19:04 |
| nessita | command: | 19:04 |
| nessita | "%PYTHONEXEPATH%\python.exe" "%PYTHONEXEPATH%\Scripts\u1trial" --reactor=twisted -p tests\platform\linux -c tests %* | 19:04 |
| dobey | nessita: what is that %*? | 19:05 |
| nessita | dobey: it grabs every parameter passed to the .bat script and put it there, i can remove it to keep testing | 19:05 |
| nessita | dobey: did you remove the sso adding for devtools? | 19:05 |
| dobey | no | 19:06 |
| dobey | nessita: put that %* before 'tests' i think, and it should work | 19:06 |
| dobey | nessita: the sso change you made was in bin/u1lint, which is not what you're currently running | 19:07 |
| nessita | dobey: is not helping, I narrowed down the command line to a simple one and it still fails: http://pastebin.ubuntu.com/755253/ | 19:07 |
| nessita | dobey: the change I made was stop using xdg... as far as I recall, let me grab the branch | 19:08 |
| dobey | nessita: yes; but it was in u1lint | 19:08 |
| dobey | https://code.launchpad.net/~nataliabidart/ubuntuone-dev-tools/no-xdg-on-windows/+merge/81889 | 19:08 |
| dobey | nessita: it wasn't changed in the dbus service runner | 19:08 |
| dobey | nessita: you're looking at the wrong problem | 19:09 |
| nessita | dobey: you're right about the branch, seems like my grep-foo failed that time | 19:09 |
| dobey | nessita: the problem is that something is requiring dbus | 19:09 |
| dobey | nessita: i don't think there's any need to make that change in the dbus service runner; since it should only run on linux anyway | 19:10 |
| dobey | nessita: and we will change them all to use dirspec soon eneough | 19:10 |
| nessita | dobey: did you see the trace? | 19:10 |
| dobey | nessita: yes | 19:10 |
| nessita | dobey: the thing is that | 19:11 |
| nessita | from ubuntuone.devtools.testcase import skipIfOS | 19:11 |
| nessita | is bringing: | 19:11 |
| nessita | File "C:\Python27\lib\site-packages\ubuntuone-dev-tools\ubuntuone\devtools\tes | 19:11 |
| nessita | tcase.py", line 25, in <module> | 19:11 |
| nessita | from ubuntuone.devtools.testcases.dbus import * | 19:11 |
| dobey | nessita: so the problem is mandel's change | 19:12 |
| dobey | i thought he also updated u1client though | 19:12 |
| nessita | seems like he has not... will add that to this branch I'm reviewing | 19:13 |
| dobey | nessita: hmm, i don't see how this wasn't failing before though | 19:16 |
| nessita | dobey: well, is tricky. I intentionally removed python-xdg from my windows install, since in windows we don't depend on it | 19:17 |
| nessita | dobey: the rest may still have it (seems like configglue pulls it on install) | 19:17 |
| dobey | configglue uses it also, yes | 19:17 |
| nessita | dobey: but you can remove it and configglue works the same. Anyways, our code should not depend on it | 19:18 |
| dobey | no, our code should depend on dirspec; but i need to get the tests written, and code in it, and get it released | 19:19 |
| ralsina_ | nessita: does configglue work exactly the same? I know we once had trouble finding the config files on windows | 19:19 |
| dobey | ralsina_: no, it doesn't | 19:19 |
| nessita | ralsina_: configglue does not look for config files, as far4 as I know | 19:19 |
| nessita | as far as I've seen in u1client code I mean | 19:19 |
| nessita | we do all the hunting | 19:19 |
| ralsina_ | nessita: hmmmm ok, then it was the main() of syncdaemon, I suppose | 19:20 |
| nessita | ralsina_: given that xdg on windows does not return useful paths, is proven that we don't depend on it :-P | 19:20 |
| ralsina_ | hahaha | 19:20 |
| dobey | well, we probably aren't using configglue.app.base.App | 19:21 |
| dobey | so configglue as we're using it probably works the same | 19:21 |
| nessita | dobey: probably | 19:22 |
| nessita | dobey: do you know how can I fix devtools properly | 19:23 |
| nessita | ? | 19:23 |
| nessita | I can think of fixes but I wnat to sync up with your first | 19:23 |
| dobey | nessita: the fix for this specific issue, is to fix contrib/testing/testcase.py in u1client | 19:23 |
| nessita | dobey: to import from testcases? | 19:23 |
| nessita | (Instead) | 19:23 |
| dobey | nessita: yep | 19:24 |
| nessita | dobey: building a branch now then | 19:24 |
| nessita | dobey: would you please? https://code.launchpad.net/~nataliabidart/ubuntuone-client/use-devtools-testcases/+merge/83999 | 19:38 |
| dobey | nessita: needs fixing for chained imports | 19:49 |
| nessita | looking | 19:49 |
| nessita | dobey: I think exactly the opposite :-) but I can see your point, fiixng | 19:50 |
| nessita | dobey: fixed and pushed to revno 1163 | 19:55 |
| dobey | ok | 19:58 |
| nessita | ralsina_: were you aware of bug #883926? (I was not) | 20:00 |
| ubot4 | Launchpad bug 883926 in ubuntuone-client "[windows] Breaks on system directories My Music, My Videos dirs in ~\Documents folder on Win7 (affects: 3) (heat: 30)" [High,Confirmed] https://launchpad.net/bugs/883926 | 20:00 |
| ralsina_ | nessita: looking | 20:01 |
| ralsina_ | nessita: I talked about it with roman but it slipped my mind | 20:02 |
| ralsina_ | nessita: I remember there being some trick there, I will try to reproduce tomorrow | 20:02 |
| nessita | ralsina_: ack | 20:03 |
| gatox | eod...... see you tomorrow!! :D | 20:04 |
| === gatox is now known as gatox_away | ||
| dobey | hmm, i hope tarmac instance is up to date | 20:10 |
| nessita | dobey: we'll see! | 20:13 |
| joshuahoover | dobey: i'm doing some bug clean up and came across bug #872972 which looks like it still needs verified, which i can do...one question, where does one find a u1ms:// link at? :) | 20:34 |
| ubot4 | Launchpad bug 872972 in libubuntuone (Ubuntu Precise) (and 7 other projects) "Store URLs have to wait for main page to load (affects: 1) (heat: 11)" [High,In progress] https://launchpad.net/bugs/872972 | 20:34 |
| dobey | https://one.ubuntu.com/music/l/3575523/0 | 20:35 |
| joshuahoover | dobey: thanks | 20:36 |
| dobey | joshuahoover: i don't think that one needs verified though | 20:36 |
| joshuahoover | dobey: hmmm...i read through the comments and see the tag is still "verification-needed" | 20:36 |
| dobey | joshuahoover: so that bug is actually fixed already; but the newer upload from hyperair didn't have the bug # in the changelog i guess :( | 20:38 |
| joshuahoover | dobey: ah, ok | 20:38 |
| dobey | joshuahoover: hrmm, oh wait | 20:38 |
| dobey | crap it does still need verified (the libubuntuone update) | 20:39 |
| dobey | grr | 20:39 |
| dobey | wtf | 20:39 |
| dobey | joshuahoover: well, now it's verification-done | 20:40 |
| joshuahoover | dobey: heh | 20:40 |
| dobey | of course, all of my banshee changes didn't get copied into the banshee update, but blah | 20:41 |
| dobey | well hopefully it will get pushed out soon | 20:48 |
| dobey | at least ubuntuone-client got pushed out today it looks like | 20:48 |
| joshuahoover | dobey: yeah, saw that...i'd like to talk to you about how we might be able to streamline sru's...it's no fun for anyone involved | 20:50 |
| joshuahoover | dobey: talk next week, in person | 20:50 |
| joshuahoover | :) | 20:50 |
| dobey | joshuahoover: oh, you are going to ba? | 20:52 |
| joshuahoover | dobey: i am | 20:52 |
| dobey | cool | 20:52 |
| dobey | well, SRUs for our own stuff aren't too bad | 20:52 |
| dobey | things that aren't ours though, can be a pain (because there can be upload conflicts) | 20:52 |
| joshuahoover | yeah | 20:53 |
| nessita | ralsina_: can I have 2 trivialisimas reviews? https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/proper-u1trial-args/+merge/84013 and https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/proper-u1trial-args/+merge/84014 | 20:58 |
| === gatox_away is now known as gatox | ||
| nessita | ok, I'm off everyone! | 21:13 |
| nessita | see ya all tomorrow | 21:13 |
| nessita | bye! | 21:13 |
| duanedesign | irssi | 21:13 |
| duanedesign | exit | 21:14 |
| duanedesign | logout | 21:14 |
| duanedesign | quit | 21:14 |
| duanedesign | notify | 21:14 |
| dobey | gotta go, later | 21:24 |
| === gatox is now known as gatox_gym | ||
| === zyga-afk is now known as zyga | ||
| === m_conley is now known as m_conley_away | ||
| === gatox_gym is now known as gatox | ||
| === gatox is now known as gatox_xbox | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!