=== gatox_xbox is now known as gatox === eu is now known as Guest87301 [09:33] I can't believe it's that time already, but Happy December everyone! :) [09:46] rye: re. yesterday 14:01 that's Ok, just happy its being looked at. Glad to have found a bug! [10:11] morning all! [10:12] dobey, I though I did change all of the, I grep in ubuntuone tests returns all imports from testcases and not testcase... [10:43] * mandel reboots === yofel_ is now known as yofel [10:58] good morning! [11:07] * mandel back [11:07] good morning mandel [11:07] ralsina, morning! [11:08] ralsina, hi! [11:08] mandel, hello [11:08] gatox, hello [11:09] mandel, can you believe that i was using unity3d when unity2d was all the time the love of my life????? jejejeje [11:09] unity2d rocks! [11:10] ralsina, trueeeeeeeee!!!!!! [11:10] ralsina, gatox yeah, unity2d is the oly one that works with my two screens... [11:10] I mean, it *works*! ;-) [11:11] hahaha [11:11] ralsina, and it's fastttttttt...... believe..... my machine wasn't working very well..... and now is really something different...... it doesn't has all the compiz effects.... i think that help :P [11:11] ralsina, may I have a review for https://code.launchpad.net/~mandel/ubuntuone-client/fix-817582/+merge/83925 [11:11] gatox: nothing is free [11:11] mandel: on it [11:12] ralsina, thx [11:12] ralsina, well..... but i didn't want compiz..... so..... WIN-WIN :P [11:20] ralsina, do you know how to configure the number of desktop in unity2d?? i'm not being able to find it with dconf and gconf-editor [11:20] gatox: no idea, I am a 1-dsktop guy [11:20] ralsina, ahhhhh...... ok...... i always need to have 6 :P [11:20] I tend to have everything maximized except editors (usually side-by-side) [11:21] so desktops don't buy me much [11:22] ralsina, oh, but I use vsplit in vim that does the same with diff buffers :) [11:23] gatox, you need to install the funny compiz settings tool to do it, which is not included by default, I think is called ccmanager [11:23] mmmmm compizconfig-settings-manager? [11:24] gatox, that is the one [11:24] mandel, i have that..... but that allows me to configure desktops in unity3d.... not 2d [11:24] gatox: isn't unity2d using metacity? [11:24] gatox, oh, in 2d I have no idea.. [11:25] ralsina, yes [11:25] gatox: in which case, maybe this helps: http://superuser.com/questions/276372/multi-row-layout-for-workspaces-in-metacity [11:31] ralsina, crap.... i don't have that key [11:32] gatox: maybe you have to install desktop switcher? [11:32] ralsina, maybe..... i'll take a look into that later [11:32] but i like unity2d! :D [11:46] mandel, can you review this branch please: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/fix-double-navigation/+merge/83973 [11:46] easy one [11:49] gatox, sure, you give me one yesterday and I forgot, do you remember which? [11:50] mandel, nop.... but you can start with that :P [11:50] jeje [11:50] gatox, ok [11:51] stupid question, but I read a comment in a review and I'm doubting myself, x of False == x, right? [11:51] mandel, a review about my branch? [11:51] * gatox is lost [11:52] gatox, no, about one of mine [11:52] gatox, so, x or False == x, right? [11:53] mandel: not guaranteed [11:53] ralsina, ein? [11:53] ralsina, why? [11:53] [] or False da False [11:53] x or False == x if and only if x is "true" [11:54] so it fails for '' [] {} and a bunch of other stuff [11:55] ralsina, ok, the correct statements should have been x or False == bool(x) [11:55] hmmmmmm [11:55] ralsina, which has the same meaning in an if.. [11:55] maybe [11:55] ralsina, since the or operatior will do bool(x) or False == bool(x) [11:55] it depends on how you are using it in an IF [11:56] but yes, that one seems to be true [11:56] ralsina, for example mocker gives errors when you do if object because bool() is called and you did not expected it.. stupid mocker.. [11:56] mandel: well, mocker is right :-) [11:56] hello everyone! [11:56] mandel: and without the bool, it may or may not have the same result in the if depending on how you use that thing [11:57] hello nessita [11:57] ralsina, yeah.. true, but I don't want all of use to be writing if bool(blah) when python does it for you :P [11:57] nessita, buenos dias! [11:57] mandel: for example: if x is None is nto the same as if x or False is None :-) [11:57] nessita, all the branches where you added the a needs fixing have been updated [11:58] nessita, and sorry for yesterday, I though I did change the ubuntuone-client tests, what was the issue? [11:58] mandel: maybe I am not getting the idea of *why* you are doing "x or False" in the first place [11:58] mandel: regarding u1client tests in windows vs udevtools? [11:58] ralsina, you where doing it: https://code.launchpad.net/~mandel/ubuntuone-control-panel/auto-update-looping-call/+merge/81015 [11:58] nessita, yes [11:59] mandel: they were not running if you don't have pyxdg installed in windows [11:59] nessita, I though I did remaplace testcase for testcases everywhere.. I suppose I forgot about that project.. [12:00] mandel: yeah, is fixed now :-) [12:00] nessita, cool, nevertheless sorry :) [12:01] ralsina, do you want to make a ui review?? https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/misaligned-icons/+merge/83620 [12:01] nessita, by the way is this list correct: https://bugs.launchpad.net/ubuntuone/+bugs?field.searchtext=&orderby=-importance&search=Search&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=choose&field.assignee=mandel&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field. [12:01] subscriber=&field.tag=&field.tags_combinator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on [12:01] nessita, ouch, sorry let me get you a smaller url [12:01] gatox: yay, fun! [12:01] gatox: does it have pretty pictures? [12:02] ralsina, mmmmmm nop..... do you want me to add it?? .P [12:02] :P [12:02] nessita, this: http://tinyurl.com/c7nyqhq I'm working with that as the list of bugs I have to tackle, is it correct? [12:02] mandel: looking... [12:02] gatox: usually it's a good idea, because it's hard to see before/after [12:02] AAAAHHHH what happened to launchpad?!?!?! [12:02] gatox, in https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/fix-double-navigation/+merge/83973 can we use %r for the logging? [12:02] nessita: new bug list UI? [12:02] ralsina, ok..... give me just a sec [12:02] nessita, yeah, is ugly [12:03] nessita, it looks like a web 2.0 now :( [12:03] :-/ [12:04] mandel, ok..... changing that [12:04] gatox, also, in the test you have things like self.assertEqual(self.controller.view.count_back, 4) what does that 4 mean? can we have it as visitedPages()[0] or something like that? [12:05] gatox, mainly so that variable name gives some information of what is being asserted :) [12:05] mandel, ok, i'll made: times_visited = 4 [12:05] gatox, much nicer :) [12:06] gatox, same for self.patch(self.controller.view, "current_user_page_id", 20) [12:07] mandel, great..... on it [12:07] nessita, I believe that bug 806701 after your SDToolProxy refactoring, am I right? [12:07] Launchpad bug 806701 in ubuntuone-client "Windows: if SyncDaemonTool fails, the error is not propagated to the caller (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/806701 [12:07] mandel: indeed, sorry I got distracted buy a private ping, one sec [12:08] no worries :) [12:10] ralsina, now it has pretty pictures: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/misaligned-icons/+merge/83620 :D [12:11] mandel: that's the list I also have, I will add more items soon, seems like you're running out of them? :-) [12:11] nessita, I've been working hard :) [12:11] nice! [12:12] mandel: there is one issue I would need you to debug, there are a couple of reports of people saying that U1 will not work as non-admin user [12:12] mandel: is there any chance you install U1 using the latest installer, and then on a non-admin account you try to set it up, using the wizard and all? [12:12] nessita, do you remember the branch in which you did the refactoring of SDToolProxy, I'd like to link bug 806701 to that one so we keep track of it [12:12] Launchpad bug 806701 in ubuntuone-client "Windows: if SyncDaemonTool fails, the error is not propagated to the caller (affects: 1) (heat: 6)" [Medium,Fix released] https://launchpad.net/bugs/806701 [12:13] nessita, sure, I have vms ready for that, give me the bug and I'll work with it [12:13] mandel: sure! go ahead. The name was, I think, u1sdtool-multiplatform [12:13] nessita, thx [12:15] mandel, you caan re-review this one now: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/fix-double-navigation/+merge/83973 [12:15] gatox, on it! [12:20] mandel: 2 things: 1- what do you mean in the last comment of https://code.launchpad.net/~mandel/ubuntuone-control-panel/auto-update-looping-call/+merge/81015 ? minimized is a parameter so it can be either true or false, and we can't assume it will be one specific [12:21] nessita, I agree with that statement, but just before that line we have a 'if not minimized:' [12:21] looking [12:21] nessita, so, for use to go inside the if we must have a bool(minimized) == False, right? [12:22] mandel: never ever use bool() on something [12:22] that indicates API dirtiness [12:22] nessita, I was saying that we have a minimized == False [12:22] nessita, what is a API dirtiness? [12:22] mandel: you're right, that logic is messed up :-) [12:23] mandel: when you allow people passing anything and treating that as a bool [12:23] nessita, oh, true :) [12:23] nessita, If you want I can put it back, but I though it was cleaner without the or.. [12:24] no no [12:24] let me see the context, you're right [12:24] o/ [12:25] mandel: while I see that, the next thing is that I asked you to change the args in https://code.launchpad.net/~mandel/ubuntuone-windows-installer/put-migration-together/+merge/78995 but then I proposed a branch when I was eoding yesterday because I needed that working for something else [12:25] mandel: so is likely you'll have a conflict if you merge trunk in... but a simple one [12:25] nessita, ok, let me merge and see if it brakes :) [12:28] nessita, just did the merge with trunk and pushed it, revno 111 [12:34] mandel: your change to controlpanel re: minimized looks good, and makes sense, sorry for missing the context (I was just looking a diffed lines) [12:34] nessita, no problem, happens to all of use :) [12:35] mandel: question, why do you do "icon.auto_update_lc = auto_update_lc" [12:36] nessita, let me look [12:37] nessita, to have access to the looping call from the object in case i want to stop it, I could have done that in a single line [12:37] in line 59 [12:37] nessita, I'll change that [12:37] is ugly like that [12:39] nessita, I have to have an early lunch so I'm off now, please can you write any comments and I'll fix them before the weekly meeting [12:39] mandel: yeah, anyways I will wait for alecu to finish the review first [12:39] nessita, ok [12:41] * mandel lunch === Guest87301 is now known as adorilson [13:29] hello! [13:29] mandel, ping: was this the branch that needed reviews? https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-tests/+merge/83267 [13:30] HOLA alecu! [13:30] HOLA nessita! how were your vacations??? [13:30] alecu: THE AWESOMEST OF AWESOME [13:31] nessita, ultramegacool! [13:31] * alecu can't wait for his vacations. They won't be as awesomest for sure, but can't wait anyway. [13:31] alecu: when are you taking them? [13:32] nessita, starting Dec 16th, till January 1st [13:46] alecu, this branch needs a re-review from you: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/not-validated-account :P [13:47] gatox, thanks, looking. [13:53] have a puzzling situation here [13:53] gatox, I'm getting an error running the tests on that branch: [13:53] gatox, I've pasted it in the proposal: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/not-validated-account/+merge/83055 [13:53] mandel: https://code.launchpad.net/~mandel/ubuntuone-windows-installer/put-migration-together/+merge/78995 is approved but it needs some cleanup before you land it, ok? [13:53] alecu, :S checking.... [14:05] nessita, ralsina: I'm taking Amelia to kinder, will be back before our team meeting. [14:05] alecu: ack! [14:12] gatox: is this still opened for some reason? https://bugs.launchpad.net/ubuntuone-client/+bug/890990 [14:12] Launchpad bug 890990 in ubuntuone-client "Error: UnicodeDecodeError ascii (affects: 16) (dups: 9) (heat: 84)" [Critical,In progress] [14:13] ralsina: quick question, did you manage to fix installer suite on husdon? [14:13] hudson? [14:13] husdon? [14:13] nessita, sorry..... i didn't see it in my queue: https://bugs.launchpad.net/~diegosarmentero/+assignedbugs?field.searchtext=&orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.subscriber=&field.tag=u1- [14:13] zomg-windows&field.tags_combinator=ANY&field.status_upstream-empty-marker=1&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on&search=Search [14:14] gatox: weird, it should be [14:14] let me check my gatox's queue link :-) [14:19] gatox: this is the queue I have for you: goo.gl/aXzLb [14:19] nessita, new one? [14:19] gatox: no the same one I always had... [14:19] gatox: perhaps you're still filtering for u1-zomg-windows? [14:20] nessita, this is the last one i have: http://is.gd/ZaEsDa [14:20] saving the new one now [14:20] gatox: oh, yes, that's filtering for zomg-windows [14:20] gatox: perhpas I created it and forgot to give you the link? [14:21] nessita, ok..... i'll check that bug once i fix a branch i have for review.. [14:22] gatox: sure, the bug perhpas just needs closing [14:22] nessita, yes.... [14:22] nessita, but i'll test it before [14:37] * mandel back [14:44] alecu, ping [14:56] mandel, pong [14:56] alecu, lets talk after the weekly call :) [14:56] * alecu runs to fetch the laptop to start mumble for the team meeting. [14:57] nessita, done the cleaning and approved, thx for eh reviews! [14:57] mandel: ack! [14:57] team call in 3'! [15:02] nessita, alecu, dobey, mumble! [15:02] ralsina: can you hear me? (I can't hear you) [15:03] I haven't said anything :-) [15:03] nessita, did you try to say something? I could just see the red lips [15:03] mandel: can you hear me? [15:03] nessita, no :( [15:03] nessita, yo te escucho, no te oigo jejeje [15:04] * mandel has a terrible sense of humor.. [15:05] alecu, https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-tests/+merge/83267 fixed :) [15:30] dobey: is there anything outside of u1 that's blocking us in p right now? (prepping a weekly ubuntu release report) [15:30] joshuahoover: twisted reactor; but i'm working on it [15:31] dobey: thx [15:59] ralsina: you left? :-) [15:59] going back then :-) [16:00] was the fix for - Web Client Error 400 'Invalid consumer.' - removing the token from the windows box? [16:03] * gatox lunch...... brb [16:09] ralsina: 1:1 in ~22 min right? [16:09] dobey: yes [16:09] ok; stupid google [16:13] dobey: I seem to not have it scheduled (again) [16:14] ralsina: google tells me it is at 9:30 AM [16:14] dobey: it's just not n my calendar [16:14] ralsina: it's in the online services calendar, no? [16:15] sigh, and the dual sign-in thing is dumb [16:16] why is it in the online services calendar? none of the other 1:1s are :P [16:24] alecu, dobey: telnet miku.acm.uiuc.edu [16:24] * mandel is back at the non-stop nym cat ... [16:24] mandel, lol!!!! [16:25] eh [16:36] nessita: hrmm, i think we need to change the version on all the stable-3-0 branches to 2.99; otherwise all the releases will have to be 3.0.x [16:39] dobey: what's the problem with releasing 3.0.x? [16:41] few minutes; 1:1 now [16:43] dobey: sure! [16:45] @ping [16:45] pong [16:49] nessita: well, releasing it as 3.0.x implies it's already finished and we're only fixing bugs in it :) [16:52] dobey: I see. Let me think about that a couploe of minutes [16:53] dobey: so, since the numbering is a convention, can't we ship new features the same on 3.0.x versions? [16:54] nessita: technically we can do whatever we want, yes; but that's not the convention [16:55] nessita: it feels weird for me to move code from one project to another, in a 3.0.x release, for example :) [16:56] dobey: what do you mean exactly with moving code from one project to another? between stable branches? [16:56] nessita: yes; i want to move libsyncdaemon into libubuntuone for example (as well as refactor it to be more async and easier to use) [16:57] so moving code, breaking abi, changing UI, etc… all feels weird [16:57] dobey: ok, let's downgrade then, makes sense [16:58] nessita: should i do them all, or do you want to do some of them too? [16:59] dobey: I can do some :-), wanna split the list? [17:00] nessita: if you wish; doesn't matter. they are trivial changes, so i can do them all if you have other stuff to do [17:00] dobey: ok then, let's do that [17:01] so I can finish setting up all these VMs [17:01] ok [17:09] * mandel needs to learn how to cache the windows updates so that all his vms get updated fast.. [17:23] bbiab, lunch and appointment [17:25] lunchtime! [17:36] ok, EOD for me [17:36] mandel, ok..... bye mandel! [17:36] gatox, we do alcus reviews tom and work on FF then? [17:36] see you tomorrow on FF [17:36] :P [17:36] gatox, I want to release it tom if we can :) [17:36] mandel, roger that [17:36] :D [17:36] mandel, yes we can! :D [17:37] mandel, hey! do you want me to get up earlier so we have more time to work together tomorrow? [17:37] it's not trouble for me [17:40] gatox, nah, don't worry :) [17:40] gatox, I'll do reviews in the morning for alecu [17:41] mandel, ok === beuno is now known as beuno-lunch [18:05] alecu: ping 1-1 when you are ready [18:05] ralsina, pong [18:05] alecu: in mumble? [18:07] alecu: lost you! [18:07] ralsina, do we have in the calendar our 1-1 yet?? i don't remember if you create it [18:07] ralsina, I don't see it connecting at all... [18:07] gatox: I should have, let me check [18:07] alecu: you appear and diappear quickly === beuno-lunch is now known as beuno [19:33] who do I owe reviews to? [19:35] nessita, i have a branch for review about a bug you mentioned once if you want [19:36] it's short [19:36] gatox: shot! [19:36] nessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/fix-double-navigation/+merge/83973 [19:36] before you tell me: TESTSSSSS!!!..jejje with a little modification in the fake... the previous test works fine [19:37] i wrote the previous test too [19:37] gatox: the simple fact you start with a disclaimer makes me doubt :D [19:37] and added one more test now [19:37] nessita, jejeje trust me.... i'm telling you to avoid stress [19:38] jejee [19:38] lol [19:39] in soviet russia, test runs you! [19:39] jejjee [19:48] nessita: ok, i think all the stable-3-0 branches are version 2.99 now :) [19:49] dobey: great, thanks! [20:16] EOD..... see you tomorrow!! :D [20:21] bye gatox! [20:21] bye gatox [20:21] gatox, I'll re-review your branch, see you tomorrow. [20:22] alecu, ok.... let me know if the change has sense for you [20:28] ralsina: What's the gastronomic adventure :D? [20:32] karni: exotic food [20:32] dobey: sounds exciting. and scary ;) [20:40] brb; gotta run to post [20:54] back [20:55] dobey: can I have a quick review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/package-utils/+merge/84173 ?> [20:55] dobey: I will update the packaging dailes after that [20:56] meh, the trac for twisted is so slow no [20:56] now [21:03] nessita: +1 [21:03] thanks! [21:17] ok, I'm off [21:17] bye all! === gatox is now known as gatox_away === gatox is now known as gatox_away