| wgrant | Trivial review for someone: https://code.launchpad.net/~wgrant/launchpad/prettier-private-build/+merge/84415 | 00:56 |
|---|---|---|
| huwshimi | wgrant: Btw, this fixed my lp-land issues: https://lists.launchpad.net/launchpad-dev/msg07986.html | 01:05 |
| huwshimi | A trivial review for someone: https://code.launchpad.net/~huwshimi/launchpad/expired-status-colour/+merge/84417 | 01:06 |
| wgrant | huwshimi: Thanks, approved. | 01:08 |
| huwshimi | wgrant: :) | 01:08 |
| wgrant | huwshimi: I'm not a huge fan of the importance colour scheme, but apart from that the new listings are awesome. | 01:08 |
| huwshimi | wgrant: Thanks for noticing | 01:08 |
| huwshimi | wgrant: Yeah, it's really hard with the status colours being so bright I was trying to find a way to not make the colours fight too much. Any suggestions on how to improve them? | 01:09 |
| wgrant | Not really, no :/ | 01:10 |
| wgrant | The status colours are pretty nice. | 01:10 |
| wgrant | huwshimi: You're on your two bit of QA? | 01:34 |
| huwshimi | wgrant: Ah right, thanks I'll do that now | 01:34 |
| huwshimi | strange, must have missed those emails | 01:34 |
| wgrant | Thanks. | 01:34 |
| huwshimi | wgrant: Done | 01:39 |
| wgrant | lifeless: Could you review https://code.launchpad.net/~wgrant/launchpad/prettier-private-build/+merge/84415? You are the only other reviewer in APAC this week. | 02:08 |
| lifeless | this is very much a self review candidate... | 02:11 |
| lifeless | theres no possible way a review could improve this :) | 02:12 |
| wgrant | Reasonable point. | 02:13 |
| huwshimi | A small css/js review for someone: https://code.launchpad.net/~huwshimi/launchpad/order-arrows-894535/+merge/84432 | 04:36 |
| wgrant | huwshimi: What's wrong with the current importance direction? | 04:41 |
| wgrant | eg. if I order by size descending in Nautilus, the arrow points up. | 04:42 |
| wgrant | If I order by importance descending on Launchpad.net, the arrow points up. | 04:42 |
| huwshimi | wgrant: Are you sure | 04:44 |
| huwshimi | ? | 04:45 |
| huwshimi | wgrant: I guess it depends what ascending descending means for the importance | 04:46 |
| wgrant | http://people.canonical.com/~wgrant/launchpad/nautilus-sort.png | 04:47 |
| huwshimi | wgrant: Yeah, that's how my branch makes the arrows work in Launchpad. The problem I believe is in how Launchpad interprets how to ascend or descend | 04:49 |
| wgrant | Seems to work that way for id/status/importance at least already. | 04:50 |
| huwshimi | wgrant: Something is very wrong then. All the js presentation code that talks about ascending/descending is doing the right thing now, whatever is telling the js what order the items are in must be wrong | 04:54 |
| huwshimi | I think | 04:54 |
| wgrant | Heh | 04:54 |
| huwshimi | I'm just reviewing now | 04:54 |
| huwshimi | wgrant: Hmm... so there's a attribute that's passed to the ordering controls which looks like it might be statically set to "sort_order: 'desc'" which, if not updated might be wrong depending on what these queries default to | 04:58 |
| wgrant | huwshimi: That would be quite amusing. | 04:59 |
| huwshimi | wgrant: I might be wrong, but I can't see what else might be doing it | 05:02 |
| huwshimi | wgrant: Although there does seem to be a bug which is causing my branch not to work perfectly too | 05:03 |
| huwshimi | it defaults to descending for everything, so I guess it could be connected | 05:03 |
| huwshimi | wgrant: So I fixed my issue | 05:20 |
| huwshimi | wgrant: And it looks like the definition of a few things is off | 05:21 |
| huwshimi | wgrant: But I'm very confused as to what | 05:22 |
| wgrant | huwshimi: Howso? | 05:27 |
| huwshimi | wgrant: I don't know, I'm confused :) | 05:27 |
| nigelb | Morning Launchpaders | 05:28 |
| wgrant | Heh | 05:28 |
| wgrant | Morning nigelb. | 05:28 |
| nigelb | Sig, yet another Monday. | 05:29 |
| nigelb | *Sigh. | 05:29 |
| huwshimi | wgrant: For one I don't know how the arrows point in the correct direction for some ordering when the presentation code says it shouldn't | 05:32 |
| huwshimi | wgrant: My guess is it's back to everything default to 'desc' | 05:33 |
| huwshimi | wgrant: Oh I see it wasn't actually following the ordering label. The actual direction of the arrow was based on what direction the arrow was pointing previously | 05:35 |
| wgrant | Hah | 05:35 |
| huwshimi | wgrant: My branch incidentally fixes | 05:35 |
| huwshimi | *fixes that | 05:35 |
| huwshimi | (as I determine the direction with ".hasClass") | 05:37 |
| huwshimi | Another trivial html review: https://code.launchpad.net/~huwshimi/launchpad/checkbox-label-labels-894209/+merge/84437 | 06:10 |
| wgrant | huwshimi: That's not going to create duplicate IDs? | 06:12 |
| huwshimi | wgrant: The same identifier is being used for the checkbox name property. The properties for that have to be unique so I assume it will be fine | 06:14 |
| wgrant | Well, IDs are meant to be document-wide, but I guess it'll do. | 06:16 |
| huwshimi | wgrant: I see what you mean | 06:17 |
| huwshimi | wgrant: What do we normally do to namespace our forms? | 06:17 |
| wgrant | lol | 06:18 |
| huwshimi | wgrant: I see :( | 06:18 |
| wgrant | But if you're unconcerned, then I shall approve. | 06:19 |
| huwshimi | wgrant: I'm a little concerned | 06:20 |
| huwshimi | wgrant: Both name and id should be namespaced on a form, I kind of assumed that would have already been taken care of, but maybe I need to add something | 06:21 |
| huwshimi | wgrant: I don't want to mess with the name as that will have larger ramifications so I might just append "_id" to the ids. I think we do that elsewhere | 06:24 |
| lifeless | I don't think we have currently; we certainly have some forms that have special casing to deal with the form being reused on one page (specifically batching facilities( | 06:24 |
| huwshimi | wgrant: OK, I've pushed that change | 06:27 |
| wgrant | huwshimi: Approved, thanks. | 06:31 |
| huwshimi | wgrant: :D | 06:31 |
| wgrant | huwshimi: In your arrow branch, the last hunk duplicates the HTML. Is that deliberate? | 06:33 |
| huwshimi | wgrant: Erm, let me check | 06:33 |
| huwshimi | wgrant: Oh, no that's not deliberate. I had intended to go back and fix that. Actually I didn't know where to store that html. | 06:35 |
| huwshimi | wgrant: This is the file: http://bazaar.launchpad.net/~huwshimi/launchpad/order-arrows-894535/view/head:/lib/lp/app/javascript/ordering/ordering.js | 06:39 |
| huwshimi | wgrant: And the html needs to be used by the renderUI and _updateSortArrows methods. Any suggestions? | 06:40 |
| wgrant | huwshimi: Store it in a constant like LI_TEMPLATE, maybe? | 06:41 |
| wgrant | I don't know if we have any conventions for this sort of thing. | 06:41 |
| huwshimi | wgrant: That would work | 06:41 |
| wgrant | huwshimi: The margin around the icon is also pretty huge here. | 06:49 |
| wgrant | Looks a lot better with margin-left: 3px instead of 5px, and padding: 0 0 0 12px instead of 0 0 0 18px. | 06:50 |
| huwshimi | wgrant: I'll fiddle with that a bit | 06:51 |
| wgrant | Ah, the 18px is from the normal sprite styles, I see. | 06:51 |
| huwshimi | wgrant: Yeah, I was balancing that out | 06:52 |
| huwshimi | wgrant: but I should fix it up a little | 06:52 |
| huwshimi | wgrant: OK, just pushed those changes | 07:01 |
| wgrant | huwshimi: That's much better, thanks. | 07:07 |
| huwshimi | wgrant: No problems. Thank you! | 07:07 |
| wgrant | Approved. | 07:08 |
| huwshimi | wgrant: Cheers | 07:08 |
| * huwshimi will be back later | 07:11 | |
| adeuring | good morning | 08:44 |
| danhg | Morning | 08:54 |
| mrevell | Morning development squadrons! | 09:09 |
| nigelb | Morning mrevell! | 09:09 |
| === Guest37602 is now known as jpds | ||
| mrevell | Everyone, I'd like to introduce frankban, who has joined the Launchpad team at Canonical. | 09:15 |
| nigelb | Hi frankban! | 09:17 |
| nigelb | Is he the new danilos? ;) | 09:17 |
| wgrant | Welcome frankban! | 09:17 |
| frankban | Hi all! | 09:18 |
| mrevell | nigelb, Kinda | 09:18 |
| nigelb | mrevell: heh | 09:18 |
| mrevell | If we ever add a kanban-style feature to Launchpad, perhaps we should call it frankban's kanban. | 09:28 |
| nigelb | haha | 09:29 |
| frankban | :-) | 09:30 |
| bigjools | welcome to the team frankban | 09:45 |
| frankban | bigjools, thanks! | 09:48 |
| allenap | frankban: Hello! Welcome to Launchpad :) | 09:50 |
| cjwatson | wgrant: mawson> is this something I can reasonably ask people to do, or should I be looking to QA germinate changes some other way? | 09:55 |
| wgrant | cjwatson: We could do it this weekend. | 09:55 |
| wgrant | bigjools is probably the person to talk to. | 09:56 |
| bigjools | mawson is the only place | 09:56 |
| frankban | allenap, good morning and thank you! | 09:56 |
| cjwatson | Well, by some other way, I mean perhaps without a DB restore | 09:57 |
| cjwatson | I don't know quite how old and crufty mawson is right now; perhaps it's recent enough not to matter | 09:58 |
| cjwatson | as long as I can run cron.germinate and have it succeed | 09:58 |
| bigjools | its dump is from just before precise opened | 09:58 |
| wgrant | It's from September 22, with a locally initialised Precise, IIRC. | 09:58 |
| cjwatson | Oh, that's not so bad. That would be fine for this testing then. | 10:01 |
| cjwatson | I was confused by the last cron.germinate run saying natty. | 10:01 |
| === almaisan-away is now known as al-maisan | ||
| jtv1 | Anyone willing to pick up a near-trivial review? https://code.launchpad.net/~jtv/launchpad/bug-884599/+merge/84400 | 10:29 |
| jtv1 | adeuring, I don't suppose I could trouble you for yet another one? | 10:32 |
| === jtv1 is now known as jtv | ||
| adeuring | jtv: I'll look | 10:32 |
| jtv | Great, thanks | 10:32 |
| adeuring | jtv: r=me | 10:38 |
| jtv | thanks adeuring! | 10:38 |
| huwshimi | hmm... ec2 test errors I can safely ignore? http://paste.ubuntu.com/760285/ | 10:54 |
| wgrant | huwshimi: That's a new one... but not your fault, clearly | 10:55 |
| wgrant | Ignore. | 10:55 |
| huwshimi | wgrant: Thanks. I'm never sure if it's something that means that my branch hasn't been fully tested or something | 10:55 |
| wgrant | huwshimi: It used to mean that sometimes, but it's reliable nowadays. | 10:58 |
| wgrant | The test time and count at the top are a good indication. | 10:58 |
| wgrant | They both increase over time :/ | 10:58 |
| huwshimi | wgrant: OK sure, I guess I'm find ignore things that aren't errors the look like they related to my branches then? | 10:59 |
| wgrant | Pretty much. | 10:59 |
| huwshimi | wgrant: Great :) | 11:00 |
| huwshimi | ec2 list, why are you hanging? | 11:00 |
| StevenK | huwshimi: An instance has probably just terminated and it's trying to ssh into it. | 11:03 |
| StevenK | strace it | 11:03 |
| huwshimi | StevenK: Oh, how do I do that? | 11:04 |
| StevenK | huwshimi: 'which strace', first of all | 11:04 |
| huwshimi | StevenK: '/usr/bin/strace' | 11:05 |
| StevenK | huwshimi: Okay, run 'strace bin/ec2 list' | 11:05 |
| StevenK | That will produce a *LOT* of output | 11:05 |
| StevenK | It should hang near a connect() line | 11:05 |
| StevenK | That will tell you if it is trying to connect to a downed instance | 11:05 |
| huwshimi | StevenK: It doesn't seem to have hung | 11:07 |
| StevenK | huwshimi: It has exit(0) or something similar at the end? | 11:07 |
| huwshimi | StevenK: It sporadically adds more output on the end, but not terminating | 11:08 |
| StevenK | huwshimi: Can you pastebin the last screen full? | 11:08 |
| StevenK | Adding a --debug flag to bin/ec2 would be awesome | 11:08 |
| huwshimi | StevenK: http://paste.ubuntu.com/760295/ | 11:09 |
| StevenK | huwshimi: That last line is attempting to connect to an ec2 instance on port 80 | 11:15 |
| huwshimi | StevenK: Is that normal? | 11:16 |
| StevenK | huwshimi: Yes, that's the magic that ec2 list does in the background. | 11:17 |
| StevenK | huwshimi: However, the magic isn't working since Amazon still lists the instance as terminating (I guess), but ec2 list still wants to talk to it. Wait about ten minutes and try again without the strace. | 11:18 |
| huwshimi | StevenK: Sure, thanks :) | 11:18 |
| huwshimi | ah, working now | 11:24 |
| rick_h_ | morning | 11:42 |
| nigelb | Morning rick_h_ | 11:42 |
| === matsubara_ is now known as matsubara | ||
| bigjools | jelmer: any idea what's going on here? http://launchpadlibrarian.net/85989025/nvervelle-jmol-12.2.log | 11:51 |
| bigjools | all imports fail https://code.launchpad.net/~nvervelle/jmol/12.2 | 11:51 |
| jelmer | bigjools: sourceforge's SVN server isn't very reliable, so it randomly hangs up on us | 11:52 |
| bigjools | hurray | 11:52 |
| jelmer | bigjools: there's an open bug about it, trying to find it.. | 11:52 |
| bigjools | ah ok thanks | 11:52 |
| jelmer | bug 891887 | 11:53 |
| _mup_ | Bug #891887: sourceforge imports fail due to connection hangup <code-import> <Bazaar Subversion Plugin:Triaged by jelmer> <Launchpad itself:Triaged> < https://launchpad.net/bugs/891887 > | 11:53 |
| jelmer | the associated branch reduces the number of revisions we process in each batch, which will hopefully reduce the effect of the hangups | 11:53 |
| bigjools | jelmer: ok thanks | 11:56 |
| bigjools | jelmer: any idea with this one too? https://code.launchpad.net/~vcs-imports/xine-lib/trunk | 12:03 |
| jelmer | bigjools: mercurial imports unfortunately aren't very reliable yet - bug 889530 | 12:15 |
| _mup_ | Bug #889530: mercurial imports should be marked 'beta' <code-import> <ui> <Launchpad itself:In Progress by jelmer> < https://launchpad.net/bugs/889530 > | 12:15 |
| bigjools | jelmer: thanks agin | 12:17 |
| bigjools | again | 12:17 |
| === al-maisan is now known as almaisan-away | ||
| === almaisan-away is now known as al-maisan | ||
| === benji changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: benji | Critical bugtasks: 3*10^2 | ||
| allenap | gary_poster: Hi Gary. frankban had no questions for me, so I assume either the wiki pages are keeping him busy, or his broadband is down. | 14:06 |
| allenap | gary_poster: I wondered if you would be up for reviewing a change to LaunchpadSecurityPolicy, following on from Raphael's work last week. I have taken a much different approach to his. Even if you don't have time for a full review, you might be interested in looking at it. https://code.launchpad.net/~allenap/launchpad/delegated-permission-caching-bug-890927/+merge/84473 | 14:07 |
| gary_poster | allenap, hi. yeah, wiki pages kept him busy, and he doesn't have accounts & his new dev box shows up at about 1400 UTC. Thank you | 14:10 |
| gary_poster | allenap, I'd be happy and interested in reviewing it thanks. I'll start in 5 min | 14:11 |
| allenap | gary_poster: Thank you! | 14:15 |
| gary_poster | of course :-) | 14:15 |
| sinzui | benji, do you have time to review https://code.launchpad.net/~sinzui/launchpad/bug-supervisor-labels/+merge/84343 | 14:16 |
| benji | sinzui: gladly | 14:17 |
| cjwatson | I'm writing test code for my new germinate runner, and (for the time being; fixing this is future work) some of the tests are going to need to have a published archive to work with, at least the dists/ part. Should I just run the PublishFTPMaster script to arrange for this, or is there something a bit more targeted I could be using instead? | 14:25 |
| bigjools | cjwatson: you want published packages in a test? | 14:27 |
| === matsubara is now known as matsubara-lunch | ||
| bigjools | or is this just for playing around | 14:28 |
| deryck | rick_h_, ping for standup | 14:31 |
| gary_poster | allenap, yay, this is nice. I like IRC reviews, so you can tell mw when I'm wrong more quickly. :-) is that ok with you, and if so, may I start now? | 14:33 |
| cjwatson | bigjools: in a test | 14:36 |
| cjwatson | I at least need Packages and Sources files; the pool doesn't matter | 14:36 |
| cjwatson | But I'd rather generate those by publishing rather than manual test data if possible | 14:36 |
| bigjools | cjwatson: ok, I'd recommend generating some data in the tree | 14:36 |
| cjwatson | You mean hand-writing Packages and Sources files? | 14:37 |
| bigjools | it's too slow to publish for unit tests | 14:37 |
| cjwatson | ah, OK | 14:37 |
| bigjools | generating :) | 14:37 |
| * cjwatson fixes his reading comprehension | 14:37 | |
| bigjools | there may be some helpers around | 14:37 |
| bigjools | under lib/lp/archivepublisher/tests/ | 14:38 |
| cjwatson | yeah, I was just looking | 14:38 |
| cjwatson | otherwise I guess I'll write my own | 14:38 |
| cjwatson | I don't see any | 14:38 |
| bigjools | some of the tests generate these files already but it's just single packages IIRC | 14:38 |
| allenap | gary_poster: Yes, that's fine. I'll put my headphones on though so that I hear pings :) | 14:38 |
| gary_poster | allenap, heh ok | 14:38 |
| gary_poster | allenap, I'll start with what I expect to require the least discussion and work up from there. | 14:39 |
| gary_poster | easy one: authorization.py: "breath-first" -> "breadth-first" | 14:39 |
| allenap | Hehe, oops. | 14:39 |
| gary_poster | :-) | 14:39 |
| bigjools | cjwatson: lib/lp/archivepublisher/tests/apt-data/ contains some static data already, I'd recommend adding to it | 14:39 |
| cjwatson | bigjools: How about the getPubSource stuff in lib/lp/soyuz/tests/test_publishing.py? Would that be fast enough? | 14:40 |
| gary_poster | allenap, this is a micro-optimization of pre-existing code, but I want us to rip out those two setdefault usages in authorization.py (lines 21 and 25 in diff). The current code makes us always create a weakkey dictionary every time, even if it is thrown away. We can easily make an idiomatic and readable version that performs better, so I suggest we go ahead and do it for such a central piece of code. | 14:40 |
| deryck | adeuring, you lost sound? | 14:40 |
| deryck | adeuring, ok, we hear you. | 14:41 |
| bigjools | cjwatson: that just adds to the database | 14:41 |
| bigjools | it is fast-ish | 14:41 |
| cjwatson | It has a getIndexStanza which a couple of tests use | 14:41 |
| deryck | adeuring, we're wrapping up, so no worries. did you have anything else? | 14:41 |
| bigjools | but doesn't write files | 14:41 |
| * bigjools looks | 14:41 | |
| cjwatson | or rather it returns an spph which has that | 14:42 |
| allenap | gary_poster: Strangely enough, I tried doing that, and got an error that a weakref could not be created in one of the tests I ran. I couldn't figure out why. | 14:42 |
| cjwatson | would save actually hand-coding the rfc822 data | 14:42 |
| gary_poster | allenap, eek. | 14:42 |
| cjwatson | Maybe it's too complicated for this though, I'm not sure | 14:43 |
| gary_poster | allenap, I have no idea. I guess I'll back off on it then. | 14:43 |
| bigjools | cjwatson: yes you can use that. In fact it would be quicker to call factory.makeSourcePackagePublishingHistory() although that cuts a lot of corners | 14:43 |
| cjwatson | aha | 14:43 |
| bigjools | the Test Publisher does it "right" but it's slower | 14:43 |
| cjwatson | That sounds perfect actually; I'll look into that (and corresponding BPPH) | 14:43 |
| bigjools | because it doesn't add librarian files | 14:44 |
| deryck | rick_h_, ping me when you have a screenshot of that issue. | 14:44 |
| bigjools | does, even | 14:44 |
| gary_poster | allenap, in authorization.py, why only leaf-node cacheing? What's the argument? If you keep that, I'd suggest changing the description: I wasn't quite sure what you meant until I read the code. | 14:44 |
| rick_h_ | deryck: will do, getting back from the reboot. | 14:44 |
| cjwatson | bigjools: thanks, that saved me a lot of time | 14:45 |
| bigjools | cjwatson: my pleasure | 14:45 |
| cjwatson | when I get round to teaching this to suck pre-apt-ftparchive data straight out of the database, it will probably fit that model better too, since I'd need [SB]PPHs for that as well | 14:47 |
| allenap | gary_poster: The first reason is that my implementation didn't make it easy to cache the non-leaf results. But I also realised that I was uncomfortable doing it; too broad a result to cache. | 14:47 |
| gary_poster | allenap, you should only cache the top, right? | 14:47 |
| gary_poster | allenap, I mean in addition to the leaf | 14:47 |
| gary_poster | well, no | 14:47 |
| allenap | gary_poster: I could add that, but it doesn't right now. | 14:47 |
| gary_poster | allenap, I don't agree with the discomfort. I'm ok with practically putting it aside for now. | 14:48 |
| rick_h_ | deryck: http://uploads.mitechie.com/lp/ppa_inline_edit_current.png http://uploads.mitechie.com/lp/ppa_inline_current_second_line.png and http://uploads.mitechie.com/lp/ppa_using_resizing.png | 14:48 |
| rick_h_ | deryck: so the first shot is the 1em "start" style in effect, and then it gets over ridden on any resize event after that. | 14:49 |
| allenap | gary_poster: Okay. I am worried that we could end up with cached permissions based on 10s or even 100s of delegated permissions. | 14:49 |
| deryck | rick_h_, let's jump back to mumble, cool? | 14:49 |
| rick_h_ | sure | 14:50 |
| gary_poster | allenap, it would be trivial to also cache the checked object's permissions | 14:52 |
| gary_poster | allenap and that would alleviate your explosion concerns | 14:52 |
| gary_poster | (which I don't think are going to happen for us, but understand in theory) | 14:53 |
| gary_poster | allenap, and that would mirror the existing behavior | 14:53 |
| allenap | gary_poster: Do you mean the top-level object, objecttoauthorize? | 14:53 |
| gary_poster | allenap, yes | 14:53 |
| allenap | gary_poster: Okay, I can do that. | 14:53 |
| gary_poster | cool allenap | 14:54 |
| gary_poster | thx | 14:54 |
| gary_poster | allenap, you write "# XXX: GavinPanella 2011-12-03 bug=???: Surely for delegated checks...". I don't think this is pertinent. The security machinery calls into this code, after already having done a lot of this stuff--especially zope.Public, for instance. Can you elaborate on your concern? | 14:57 |
| allenap | gary_poster: When checking delegated permissions, should we not check if it's requesting zope.Public? That's a silly example... I'm more worried about the block of code that calls LSP.checkPrivacy(). Should we do that for each delegated check? | 15:00 |
| allenap | jelmer: http://launchpadlibrarian.net/86683207/vcs-imports-xine-lib-trunk.log is a known bug that, iirc, you're working on, right? | 15:02 |
| gary_poster | allenap, mm, ok. I want to dig into this. So, I'm familiar with the zope.Public check so I'll start there. Your thought there is "what if checkAccountAuthenticated returns (something, zope.Public)?" right? | 15:03 |
| allenap | gary_poster: Yes. | 15:03 |
| gary_poster | I see | 15:03 |
| allenap | That seems like a daft thing to do, but it might happen. | 15:03 |
| gary_poster | yeah, that one seems daft; I won't worry about it too much. I'm more interested in LSP.checkPrivacy. I'm not sure how that works, and that seems like it might be more serious. Lemme take a look (unless you already know the details and can get me up to speed quickly here or on a call) | 15:04 |
| gary_poster | allenap ^^ | 15:04 |
| jelmer | allenap: hi | 15:05 |
| jelmer | allenap: yeah, the hg imports aren't very reliable yet | 15:05 |
| allenap | gary_poster: No, I don't know the details; I have skimmed the code and it looks serious :) | 15:05 |
| allenap | jelmer: Okay. I'm answering https://answers.launchpad.net/launchpad/+question/178945. Shall I just say that, or is there a bug I can point him to? | 15:06 |
| gary_poster | allenap, ok :-) I'll look and report back | 15:06 |
| allenap | gary_poster: Thank you :) | 15:07 |
| jelmer | allenap: I'd suggest just saying that, I don't think linking a particular bug is useful | 15:07 |
| allenap | jelmer: Okay, cool. Thank you! | 15:07 |
| bigjools | allenap: I beat you to it I think | 15:08 |
| allenap | bigjools: Ah ha :) | 15:08 |
| bigjools | allenap: I shall leave you to it and finish my branch :) | 15:09 |
| flacoste | benji, gary_poster: have you seen bug 899388? | 15:15 |
| _mup_ | Bug #899388: Some translation statistics are not up to date <regression> <Launchpad itself:Triaged> < https://launchpad.net/bugs/899388 > | 15:15 |
| benji | flacoste: I have ("Reported by Benji York on 2011-12-02") ;) | 15:17 |
| gary_poster | Hm, there may be a dupe there | 15:17 |
| flacoste | benji: yeah, just saw that :-) | 15:18 |
| flacoste | sorry for the noise | 15:18 |
| flacoste | i got confused by the email | 15:18 |
| benji | flacoste: no worries | 15:18 |
| flacoste | i thought it was reported by a user, but it was only follow-ups comments | 15:18 |
| benji | yep; I'm really confused by the behavior and don't think it's related to the recent changes in the way statistics are updated (but I could be wrong) | 15:19 |
| gary_poster | oh...so this is different from the "jobs are not working" bug benji? | 15:19 |
| gary_poster | which you closed | 15:20 |
| gary_poster | right | 15:20 |
| benji | gary_poster: yep; I believe the job is working (because statistics are being updated) but the bug is that the statistics aren't right | 15:20 |
| gary_poster | Oh, I see :-( | 15:20 |
| flacoste | that's inconvenient! | 15:21 |
| benji | the only changes we (intended) to make were to change the timing of the calculations, not the calculations themselves, so we shouldn't have introduced any new behavior | 15:21 |
| benji | indeed | 15:21 |
| gary_poster | benji, so the user comments indicate that the workaround you describe is insufficient? | 15:22 |
| benji | gary_poster: yep, and it indicates that the statistics are indeed being updated (presumably by the cron job) | 15:23 |
| gary_poster | benji, I see | 15:23 |
| gary_poster | benji, if you want pairing from somebody, ask | 15:24 |
| benji | gary_poster: will do | 15:24 |
| === salgado is now known as salgado-lunch | ||
| benji | sinzui: https://code.launchpad.net/~sinzui/launchpad/bug-supervisor-labels/+merge/84343 looks good | 15:37 |
| sinzui | thank you benji | 15:37 |
| benji | my pleasure | 15:38 |
| === al-maisan is now known as almaisan-away | ||
| gary_poster | allenap, I had other stuff to quickly review but now I am back. I'll look more at that LSP.checkPrivacy stuff later today but I want to make sure to bring up the other questions I had for you while we still overlap. I have three more things, only one of which probably requires much discussion. | 15:59 |
| gary_poster | 1) isinstance(result, Iterable) does not strike me as a good pattern for checking | 15:59 |
| gary_poster | oh wait, that was the one we had to talk about :-P | 15:59 |
| allenap | gary_poster: ? | 16:00 |
| gary_poster | So try that again: 1) lib/lp/app/interfaces/security.py: In docstrings, please specify that all delegated results must be True in order for it to be considered True. | 16:00 |
| gary_poster | allenap ^^ | 16:01 |
| allenap | Okay. | 16:01 |
| gary_poster | allenap, 2) Am I correct that there are no tests for this change? Is that because there are no tests for this generally? | 16:01 |
| gary_poster | I see the tests for the new behavior in the authorization | 16:04 |
| allenap | gary_poster: There are no tests for the new caching behaviour. All the existing tests pass unmodified, but I ought to test for caching of delegated auths. Fwiw, a follow-on branch from this does check (indirectly) that delegated auths are cached, so they're working. | 16:10 |
| gary_poster | allenap, I was going to be concerned about isinstance(.., Iterable) but I see it is an ABC, so nm. :-) | 16:14 |
| gary_poster | (and I see it experientially works for what I would want it to in the common case) | 16:14 |
| allenap | gary_poster: Yeah. It's not great from a micro-optimization standpoint, but it'll do for now :) | 16:14 |
| gary_poster | yeah, cool | 16:14 |
| bigjools | benji: hi - can I bother you with a review please? | 16:15 |
| benji | bigjools: absolutely | 16:16 |
| gary_poster | allenap, ok cool. So, this is conditionally approved with the comments I've given, and with some reading I intend to do today on checkPrivacy. I'll plan to approve this today, probably after your EoD | 16:16 |
| bigjools | benji: it's https://code.launchpad.net/~julian-edwards/launchpad/sponsor-syncs-bug-827555/+merge/84287 | 16:16 |
| bigjools | thanks | 16:16 |
| allenap | gary_poster: Woohoo \o/ thank you :) | 16:16 |
| gary_poster | allenap, btw, I really like your approach. Thanks for pulling this along to the finish line in such a nice way. | 16:17 |
| allenap | gary_poster: Thanks, I appreciate that. | 16:18 |
| === mtaylor_ is now known as mtaylor | ||
| benji | bigjools: I added a comment to https://code.launchpad.net/~julian-edwards/launchpad/sponsor-syncs-bug-827555/+merge/84287 that I couldn't phrase well for IRC, but you might want to discuss it here | 16:33 |
| bigjools | benji: my docstring is correct | 16:34 |
| benji | in other words, I misunderstand? | 16:34 |
| bigjools | the sponsored person overrides the requesting user | 16:34 |
| bigjools | benji: yes, but must not have been clear enough for that to happen | 16:35 |
| benji | oh! you're considering the requesting use as the sponsor | 16:35 |
| bigjools | with an "I" in there somewhere | 16:35 |
| bigjools | yep | 16:35 |
| benji | gotcha, yeah, if you add a statement to that fact, I think it'll clear it up | 16:35 |
| bigjools | righto | 16:36 |
| === salgado-lunch is now known as salgado | ||
| lifeless | morning | 16:59 |
| sinzui | flacoste, ping. Do you have time to talk about users, team, interfaces, and security? | 17:01 |
| flacoste | sinzui: sure | 17:02 |
| flacoste | skype me | 17:02 |
| bigjools | benji: thanks for the approval | 17:06 |
| benji | bigjools: my pleasure | 17:06 |
| === deryck is now known as deryck[lunch] | ||
| lifeless | allenap: sinzui is da god of series, but AIUI downloads show 'newest' full stop, and latest series is done by a built in sort. Probably need to check the code to be sure. | 17:12 |
| allenap | lifeless: Ta, I'll take a look. Looks like you got woken early :) | 17:15 |
| lifeless | apparently ;) | 17:16 |
| sinzui | allenap, lifeless the downloads page is a mess. we show the released for current development series at the top or the page (current development series is pulled out of naming sequence and shown first). Backport releases are show with their respective series series, but may fall off the page because of batching. | 17:22 |
| lifeless | sinzui: https://answers.launchpad.net/launchpad/+question/180693 | 17:22 |
| sinzui | allenap, lifeless downloads exists to let packagers see the latest releases, but 7 people muddled the page to serve users and developers, which make it impossible to do the right thing | 17:23 |
| lifeless | thumper: can you please list the queues on production ? | 17:23 |
| lifeless | bah | 17:24 |
| lifeless | ECHANNEL | 17:24 |
| sinzui | ahh the downloads portlet | 17:24 |
| sinzui | allenap, lifeless :that too is very ignorant of reality and we have too community of equal weight in contention. Let me find the bugs for that mess | 17:25 |
| allenap | sinzui: I have to go now to collect kids, but I'll be back later. Are you happy to answer that question in the meantime, or would you prefer me to do it later? | 17:27 |
| sinzui | allenap, bug 419733 and bug 669668 describe the fact that Lp really guess at what to show and users fight over what is the correct behaviour. I report the latter bug as a suggestion from UDS...which mightg addess the issue | 17:27 |
| _mup_ | Bug #419733: new Downloads portlet should show latest stable release as well as latest <lp-registry> <product-release-finder> <releases> <Launchpad itself:Triaged> < https://launchpad.net/bugs/419733 > | 17:27 |
| _mup_ | Bug #669668: permit projects to specify the series that current release are made from <lp-registry> <releases> <Launchpad itself:Triaged> < https://launchpad.net/bugs/669668 > | 17:27 |
| lifeless | \o/ instant OOPSes on production. | 17:28 |
| * lifeless dances the happy dance of a plan coming together | 17:29 | |
| allenap | Awesome! | 17:30 |
| jcsackett | sinzui: you free to mumble? i'm trying to figure out what needs tackling the most on our board. | 17:35 |
| sinzui | okay | 17:35 |
| sinzui | allenap, I answered the question | 17:39 |
| sinzui | jcsackett, I think I am mistaken about the pre-req bugs. There are several bugs about editing project/distro information inline, but none about the roles. I suspect the bug was rewritten to solve one use case. I think you should report bugs are you need to make pillar roles editable in the page via ajax | 18:04 |
| mrevell | G'night all | 18:06 |
| lifeless | statik: I have a CT scan on thursday thats going to play havoc with the day; we're booked for that morning for catchup- can we reschedule ? | 18:09 |
| abentley | benji: could you please review https://code.launchpad.net/~abentley/launchpad/remove-hot-bugs/+merge/84503 ? | 18:09 |
| === deryck[lunch] is now known as deryck | ||
| benji | abentley: I was eating lunch; looking now | 18:19 |
| abentley | benji: thanks. | 18:19 |
| benji | abentley: https://code.launchpad.net/~abentley/launchpad/remove-hot-bugs/+merge/84503 looks good, I had one idea for simplyfying a template, but that's it | 18:28 |
| statik | lifeless: sure, rescheduling is fine with me, my calendar is pretty accurate for open slots | 18:32 |
| abentley | benji: cool, thanks for the suggestion. | 18:32 |
| benji | abentley: my pleasure | 18:32 |
| lifeless | statik: how about later today after I catch up with flacoste? | 18:36 |
| lifeless | flacoste: also, we can call anytime, I am awake and around :) | 18:36 |
| flacoste | lifeless: i'll have to postpone a bit, i hurt my back yesterday and have an appointment for it in 1h | 18:37 |
| lifeless | flacoste: ow! | 18:37 |
| lifeless | flacoste: ping me anytime | 18:37 |
| lifeless | statik: how about now then ? | 18:41 |
| === matsubara is now known as matsubara-afk | ||
| lifeless | hmm, no gary | 19:02 |
| lifeless | allenap: this is the thing I was looking at previously - https://code.launchpad.net/~lifeless/storm/bug-618019/+merge/34715 | 19:27 |
| lifeless | allenap: (centering around whether we ever pay network / db server latency for result set rows) | 19:27 |
| benji | lifeless: I'm doing some reviews and noticed that https://code.launchpad.net/~mbp/launchpad/show-timeline/+merge/80166 looks like it wants a comment from you before I review it | 19:50 |
| thumper | lifeless: I'm assuming that message wasn't really for me? | 19:56 |
| SpamapS | So.. in working on the juju charm distro .. I'd like to open up a new series and copy all the contents of the old one into the new one.. | 20:06 |
| SpamapS | I was hoping this would do that | 20:06 |
| SpamapS | https://launchpad.net/charm/precise/+initseries | 20:06 |
| SpamapS | But apparently thats some of the ubuntu-only magic. | 20:06 |
| lifeless | thumper: it wasn't | 20:06 |
| SpamapS | I'll write up an email but wondering if anybody can shed some light on how this is supposed to work? | 20:07 |
| lifeless | thumper: failed tabcomplete for thedac who isn't lurking here | 20:07 |
| lifeless | SpamapS: make a new series, and probably run the branch-new-distro script should do it fo ryou | 20:07 |
| SpamapS | lifeless: in what package/bzr tree/multiverse does branch-new-distro reside? | 20:08 |
| lifeless | lp source I think | 20:08 |
| lifeless | it's only ever been run against ubuntu, so you'll want to eyeball it | 20:08 |
| SpamapS | Yeah I'll give it a look | 20:08 |
| lifeless | also IIRC it gets run by sysadmins | 20:09 |
| SpamapS | I'm not quite ready to do it anyway.. since our branches will likely be copied backward to older releases quite a bit more than in Ubuntu. | 20:09 |
| lifeless | abentley: around? | 20:38 |
| abentley | lifeless: hi. | 20:38 |
| lifeless | abentley: I was just looking at the update to https://bugs.launchpad.net/launchpad/+bug/899675 | 20:38 |
| _mup_ | Bug #899675: When no bugs are available in a dynamic listing, the ordering controls are positioned above the search widget <bug-columns> <Launchpad itself:Triaged> < https://launchpad.net/bugs/899675 > | 20:38 |
| lifeless | abentley: when I click on the link through to tag=madness, the page seems to hang | 20:38 |
| abentley | lifeless: Not for me on Firefox. | 20:39 |
| lifeless | abentley: by which I mean the top shows 'loading' for an extended period (several minutes so far) and the bug counts beside 'New' etc are not being filled in. | 20:39 |
| lifeless | abentley: I'm on FF 8 | 20:39 |
| lifeless | https://bugs.launchpad.net/unity/+bugs?field.tag=madness is the url | 20:39 |
| * lifeless tries a ctrl-refress | 20:39 | |
| abentley | lifeless: This is on production, not qastaging? | 20:40 |
| lifeless | yes | 20:40 |
| * lifeless tries qastaging | 20:40 | |
| lifeless | ah, I'm not in the team on qastaging | 20:41 |
| abentley | lifeless: qastaging may be worse. | 20:41 |
| abentley | lifeless: we've already got issues with the spinner on qastaging. | 20:41 |
| lifeless | so this sounds similar/related? | 20:41 |
| lifeless | abentley: would you like a new bug report from me for this? | 20:42 |
| abentley | lifeless: yes, a report of pages hanging would be new. | 20:42 |
| lifeless | roger wilco | 20:42 |
| abentley | lifeless: I'm on FF8, too. I don't understand why you're seeing something different. | 20:43 |
| rick_h_ | lifeless: ctrl-shift-del will bring up hard cache clearing form | 20:44 |
| rick_h_ | lifeless: as a "just in case" it's a bit more reliable than ctrl-reload | 20:44 |
| abentley | lifeless: This "hanging" is shown via the native FF progress indicator or one of our spinners? | 20:45 |
| lifeless | abentley: neither, lack of ajax post-render updates | 20:45 |
| lifeless | bug | 20:46 |
| lifeless | https://bugs.launchpad.net/launchpad/+bug/900480 | 20:46 |
| _mup_ | Bug #900480: +bugs 'hanging' when no bugs found <bug-columns> <Launchpad itself:Triaged> < https://launchpad.net/bugs/900480 > | 20:46 |
| lifeless | screenshot in a sec | 20:46 |
| abentley | lifeless: Oh. Yes, I can reproduce that, then. | 20:46 |
| abentley | lifeless: I'm not sure what puts that there. | 20:46 |
| abentley | lifeless: I can see the pathology, though. An unconditional reference to an optional node. | 20:48 |
| lifeless | cool | 20:48 |
| lifeless | screenshot is up | 20:48 |
| lifeless | rick_h_: thanks | 20:48 |
| * lifeless tries statik: again | 20:54 | |
| === salgado is now known as salgado-afk | ||
| statik | lifeless: sure, i can talk in 5 | 21:03 |
| lifeless | statik: ok, lets do this :) | 21:07 |
| === jcsackett|afk is now known as jcsackett | ||
| === benji changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugtasks: 3*10^2 | ||
| === mwhudson_ is now known as mwhudson | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
