| bschaefer | thumper: so when the panel starts it changes the color of the top panel to match the dash | 00:31 |
|---|---|---|
| bschaefer | i mean when the dash opens it changes the panel color to match | 00:31 |
| bschaefer | thumper: i just started up again let me take a quick look at the code again to refresh... | 00:31 |
| bschaefer | Trevinho: what have you done/found on the blur panel bug? | 00:34 |
| Trevinho | bschaefer: I've started sudying the thing and done many tests | 00:34 |
| thumper | Trevinho: would it be worth off loading the findings and looking at bamf? | 00:35 |
| Trevinho | hovever it's quite hard since there are many layers mixing.... | 00:35 |
| Trevinho | Ok | 00:35 |
| bschaefer | Trevinho, that is what I have been doing, what I found is under PanelView::UpdateBackground is where it changes the panel to just the color if _dash_is_open | 00:35 |
| Trevinho | by the way my findings aren't that much things... I just moved the panel below the blur, but then the blending doesn't work as expected | 00:35 |
| Trevinho | yep | 00:36 |
| Trevinho | however bschaefer you need to work on DrawContent and on Draw | 00:36 |
| Trevinho | more than there | 00:36 |
| Trevinho | I actually just commended the code in the if {} (keeping only the else part)... and doing tests only with Draw(Content) | 00:36 |
| bschaefer | Trevinho, I was looking at those and just made _dash_is_open to false and it wasn't do much to the effects of the panel. What I am thinking is an if statement in UpdateBackground | 00:36 |
| bschaefer | if (_dash_is_open && (_menu_view->GetMaximizedWindow() == 0)) | 00:37 |
| bschaefer | that will be if the window is maxed, and then an else if (_dash_is_open_) then an else | 00:37 |
| bschaefer | Trevinho, there is still a lot of stuff I need to look into, but since the Dash doesn't cover the panel view we can't rely on that | 00:38 |
| bschaefer | color to change something we put there, so it seems like we are going to have to maybe use 2 layers one with the color that shows the background and one to keep something behind it | 00:39 |
| Trevinho | bschaefer: the blur effect is not done by the dash on the panel | 00:40 |
| Trevinho | but by the panel itself | 00:40 |
| bschaefer | Trevinho, yeah, which is annoying | 00:40 |
| Trevinho | Yep, but there's no other way to get that | 00:40 |
| Trevinho | since they're two different windows | 00:40 |
| Trevinho | however, before of focusing on the UpdateBackground logics (that maybe is also unneeded as that could have been done not drawing the bg_layer on DrawContent, without regenerating it at every step) | 00:41 |
| bschaefer | hmm, yeah if the dash covered the panel this would be an easy fix!! So now I wonder if we can keep the panel there and put the color it gets changed to over it | 00:41 |
| Trevinho | that is easy | 00:41 |
| Trevinho | the main issue is blending the layers on draw and drawcontent | 00:41 |
| Trevinho | bschaefer: have you seen the desired effect that JohnLea has posted on the bug today? | 00:42 |
| bschaefer | Trevinho, have not, let me take a look | 00:42 |
| Trevinho | that's what he wants... So basically you need to draw the background layer under the layer that applies the blur | 00:43 |
| bschaefer | yeah, that is something I had imagine he wanted | 00:43 |
| Trevinho | the problem here is mixing them correcly | 00:44 |
| Trevinho | but on this jaytaoko can help | 00:44 |
| Trevinho | I contacted him yesterday about this | 00:44 |
| Trevinho | but he told me he should have looked into that more | 00:44 |
| bschaefer | Trevinho, cool hopefully he gets that ping otherwise I can contact him also. | 00:45 |
| bschaefer | have you talked to macslow at all about this? | 00:45 |
| Trevinho | no | 00:45 |
| Trevinho | I was planning to do that, but since I've looked at that issue only on late nights, he wasn't there :) | 00:46 |
| bschaefer | it might be worth while to send him an email since he was working on it before. I can send him an email later when I find more stuff out | 00:46 |
| bschaefer | Trevinho, doesn't the background layer normally get applied under the blur layer? | 00:47 |
| * bschaefer hasn't looked into that part as much | 00:48 | |
| bschaefer | Trevinho, so are you saying apply the blur then apply the background so it doesn't get the background on the blur? | 00:49 |
| Trevinho | the background layer is actually the layer with the standard panel color, and generally is applied over the blur | 00:49 |
| Trevinho | however the blur is drawn only when the dash is opened | 00:50 |
| Trevinho | and it uses no blending, so it goes over the background in fact | 00:50 |
| bschaefer | Trevinho, so that would be why it shows the background | 00:50 |
| Trevinho | Well... The blur layer has the colors of the background | 00:51 |
| Trevinho | (where with background I mean the wallpaper) | 00:51 |
| bschaefer | yeah that is what I ment also. So if the background layer has the standard color of the panel...ie put the blur over it so it blurs | 00:52 |
| Trevinho | eh, yep | 00:53 |
| Trevinho | that's theory | 00:53 |
| Trevinho | but it doesn't work as I expected | 00:53 |
| bschaefer | which is what you said, that looks like a good approach haha :) | 00:53 |
| bschaefer | what happened? | 00:53 |
| Trevinho | The blending is not enabled by default for the blur layer, so it just doesn't consider what's below | 00:54 |
| Trevinho | enabling the blending you can get something working, but not well | 00:54 |
| Trevinho | i.e. result: http://ubuntuone.com/7Mo4ntSpgC6Gqa3zQidsnL (dark theme), http://ubuntuone.com/0esZCMee6pzPAWBPG4pTkB (bright theme) | 00:55 |
| bschaefer | Trevinho, looks like the right track though | 00:55 |
| bschaefer | Trevinho, do you have a branch or ppa I could look at? Or is it small changes you did? | 00:57 |
| bschaefer | Trevinho, as I was looking more at the UpdateBackground part and less at the draw content | 00:57 |
| Trevinho | bschaefer: no, I've nothing online | 00:58 |
| Trevinho | bschaefer: look if this helps http://paste.ubuntu.com/763336/ | 01:00 |
| bschaefer | Trevinho, sweet thanks! Ill also try to get a hold of jay on this along with sending an email to macslow later. | 01:02 |
| Trevinho | yw | 01:02 |
| nobodyspecial | hello | 02:31 |
| nobodyspecial | anybody online? | 02:31 |
| nobodyspecial | unity sucks balls. Just wanted to make that clear to you guys. What a disaster. | 02:32 |
| nobodyspecial | bye | 02:32 |
| Trevinho | bschaefer: did you found something? | 03:33 |
| === zyga__ is now known as zyga-afk | ||
| bschaefer | Trevinho, not anything worthwhile as it seems so close to just looking right | 03:52 |
| Trevinho | The problem is also with bright themes | 03:52 |
| Trevinho | try with Ambiance | 03:52 |
| bschaefer | Trevinho, I am scanning through other rop blending options also | 03:52 |
| bschaefer | Trevinho, alright let me re compile. so far this two are looking the closest, rop.SrcBlend = GL_DST_COLOR; rop.DstBlend = GL_ONE; | 03:54 |
| bschaefer | Trevinho, which you had already | 03:54 |
| Trevinho | :/ | 03:55 |
| bschaefer | Trevinho, did you play around with Draw at all? | 03:56 |
| Trevinho | yes... | 03:56 |
| Trevinho | However, drawcontent manages what should be there | 03:56 |
| Trevinho | draw only pushes it | 03:56 |
| Trevinho | afik | 03:56 |
| bschaefer | Trevinho, it just seems to need to blend better with the dash, the line is very hard...with ambiance | 03:57 |
| bschaefer | Trevinho, i mean with radiance, the white one | 04:00 |
| Trevinho | yep | 04:00 |
| bschaefer | Trevinho, I am also thinking that the bar is going to be constant, since he doesn't want the background behind it | 04:19 |
| bschaefer | ie no matter whats on the screen if its full screen it will look the same depending on the theme | 04:19 |
| Trevinho | yes | 04:19 |
| Trevinho | that should be happen... | 04:19 |
| Trevinho | I also thought to that, and using a workaround | 04:20 |
| Trevinho | but I'm sure that the clean solution can be done correctly using nux | 04:20 |
| bschaefer | Trevinho, yeah, this is my first time messing with nux and its blending so I am still trying to get use to that haha | 04:21 |
| bschaefer | Trevinho, messing with the front end part that is | 04:21 |
| Trevinho | I know what you mean... I've spent more than 4 hours looking to that | 04:21 |
| bschaefer | Trevinho, yeah haha that is what I have been doing also now | 04:22 |
| bschaefer | jaytaoko, ping! | 04:22 |
| bschaefer | I think jay would be able to help out, not sure what his timezone is though | 04:22 |
| Trevinho | it could be late for him | 04:23 |
| Trevinho | I know he's Canadian | 04:23 |
| Trevinho | but I don't know his TZ | 04:23 |
| Trevinho | That doesn't explain why I'm Italian and I'm still UP by the way :D | 04:23 |
| bschaefer | Trevinho, haha I was about to ask you your time zone | 04:23 |
| bschaefer | Trevinho, it is only 8:30 pm here | 04:24 |
| Trevinho | 5:30 here... | 04:24 |
| Trevinho | am | 04:24 |
| Trevinho | of course... | 04:24 |
| bschaefer | Trevinho, well dam...that is pretty early/late | 04:24 |
| Trevinho | yep | 04:24 |
| Trevinho | damned branches... .I've too much code waiting to be landed to be maintened | 04:24 |
| bschaefer | Trevinho, haha, yeah merging trunk? | 04:25 |
| Trevinho | they should | 04:25 |
| Trevinho | but they're missing few tests or they needs some cleanups | 04:25 |
| Trevinho | so I've to rework them | 04:25 |
| Trevinho | and this take time by the way | 04:26 |
| bschaefer | haha that sounds very time consuming | 04:27 |
| Trevinho | a lot | 04:27 |
| bschaefer | it is 11:30 jays time | 04:28 |
| bschaefer | I missed him then, he is USA east coast time | 04:29 |
| bschaefer | Trevinho, did you look into this function at all? SetPremultipliedBlend | 04:31 |
| bschaefer | I am trying to find what else could possibly be changed in the DrawContent that would be helpful... | 04:32 |
| Trevinho | bschaefer: I guess that is used when pushing layers | 04:32 |
| Trevinho | is the default blending | 04:33 |
| bschaefer | Trevinho, I see, should have copied the whole line of code. GfxContext.GetRenderStates().SetPremultipliedBlend(nux::SRC_OVER); | 04:33 |
| jaytaoko | Trevinho: hello | 05:14 |
| Trevinho | hi jaytaoko | 05:14 |
| Trevinho | jaytaoko: bschaefer is now working on that bug we were discussing yesterday | 05:15 |
| Trevinho | I hope you could help him | 05:15 |
| jaytaoko | Trevinho: ok | 05:15 |
| Trevinho | it's time to go to bed for me now | 05:15 |
| Trevinho | (it's 6:15 am here :/) | 05:15 |
| Trevinho | see you guys! | 05:15 |
| jaytaoko | Trevinho: indeed have a good night/day | 05:15 |
| Trevinho | :) | 05:15 |
| jaytaoko | bschaefer: hello | 05:16 |
| jaytaoko | bschaefer: I have to reboot my system, feel free to send me an update by email regarding the blending effect. cheers | 05:17 |
| bschaefer | Trevinho, night! | 05:19 |
| === jibel_ is now known as jibel | ||
| davidcalle | andyrock, the BFB quicklist is awesome! | 09:25 |
| andyrock | davidcalle, thx, if you've any suggestions... | 09:25 |
| davidcalle | andyrock, no suggestions, it looks great. I was curious if lenses not supposed to be visible would show up here, but it handles them well. | 09:29 |
| andyrock | yeah, later we can do something like this | 09:30 |
| andyrock | Application Lense | 09:30 |
| andyrock | Files & Folder Lens | 09:30 |
| andyrock | ... | 09:30 |
| andyrock | *Lens | 09:31 |
| === MacSlow is now known as MacSlow|macslow | ||
| === MacSlow|macslow is now known as MacSlow|lunch | ||
| === MacSlow|lunch is now known as MacSlow | ||
| === yofel_ is now known as yofel | ||
| === m_conley_away is now known as m_conley | ||
| om26er | hyperair, andyrock is wondering if the patch in bug 888636 is for trunk or 4.0 ? | 17:11 |
| ubot5 | Launchpad bug 888636 in unity (Ubuntu) "Alt+Tab default delay of 150ms is too long" [Undecided,Incomplete] https://launchpad.net/bugs/888636 | 17:11 |
| andyrock | hyperair, hi | 17:11 |
| hyperair | om26er: it's against oneiric's unity package, because i'm too lazy to build a newer one. | 17:11 |
| hyperair | andyrock: hi. | 17:11 |
| andyrock | hyperair, ok... but i don't think that this can be merged in unity 4.0 | 17:12 |
| andyrock | hyperair, in unity trunk i can review and eventually approve it, but you should update it :) | 17:13 |
| hyperair | andyrock: mm it doesn't apply? | 17:14 |
| andyrock | no... | 17:15 |
| hyperair | i see. | 17:15 |
| * hyperair sighs. | 17:15 | |
| * hyperair isn't really interested in bzr cloning.. | 17:15 | |
| andyrock | and yes, use bazaar please :) | 17:15 |
| hyperair | but but | 17:16 |
| hyperair | i really *hate* bzr. | 17:16 |
| andyrock | hyperair, git right? :) | 17:17 |
| hyperair | yes. | 17:18 |
| hyperair | it's easy enough when you have a an apt mirror really close by (within walking distance) | 17:18 |
| hyperair | and can apt-get source stuff | 17:18 |
| hyperair | and git import-dsc | 17:18 |
| hyperair | \o/ | 17:18 |
| hyperair | not so fun when you need to clone lp:unity over a connection that consistently fails. | 17:18 |
| andyrock | oki oki | 17:19 |
| andyrock | push the new diff so... | 17:20 |
| andyrock | we'll do it for you | 17:20 |
| hyperair | hyperair@thinkpwn:~/src/unity% patch -i ~/src/debian/unity/unity/0001-Add-alt_tab_delay-option-to-configure-alt-tab-delay.patch -p1 [ 1:24AM] | 17:24 |
| hyperair | patching file plugins/unityshell/src/unityshell.cpp | 17:24 |
| hyperair | Hunk #1 succeeded at 256 (offset 3 lines). | 17:24 |
| hyperair | Hunk #2 succeeded at 2069 with fuzz 2 (offset 15 lines). | 17:24 |
| hyperair | patching file plugins/unityshell/unityshell.xml.in | 17:24 |
| hyperair | ... | 17:24 |
| hyperair | IT APPLIES DAMNIT. | 17:24 |
| hyperair | http://paste.debian.net/148619/ | 17:25 |
| hyperair | there. new patch. | 17:25 |
| hyperair | andyrock: ^ | 17:25 |
| andyrock | hyperair, i'm sorry but in trunk it doesn't apply :) | 17:29 |
| hyperair | still?! | 17:29 |
| hyperair | andyrock: i just did that bzr diff from trunk! | 17:30 |
| hyperair | it's lp:unity right? | 17:30 |
| andyrock | hyperair, you should do switcher_controller_-> | 17:30 |
| andyrock | not switcherController-> | 17:30 |
| andyrock | try to build it, and you will get an error ;) | 17:31 |
| hyperair | ..that's very straneg | 17:31 |
| hyperair | i built it.. | 17:31 |
| hyperair | oh. | 17:31 |
| hyperair | i built it on the *old* unity. | 17:31 |
| hyperair | i guess things changed since then | 17:31 |
| hyperair | well i'm not really interested in figuring out how to build unity from trunk, so could you just fix that up pretty please? :-) | 17:31 |
| andyrock | hyperair, ok... adding to my TODO list | 17:33 |
| andyrock | thanks | 17:33 |
| andyrock | :) | 17:34 |
| hyperair | it's just a one-liner change, isn't it? | 17:34 |
| hyperair | the one you mentioned.. | 17:34 |
| andyrock | yeah... | 17:34 |
| andyrock | maybe the fixme | 17:34 |
| andyrock | in the description option | 17:34 |
| hyperair | afaik they're *all* fixmes | 17:34 |
| andyrock | but we can do it | 17:34 |
| andyrock | yeah but we don't want another fixme :) | 17:34 |
| * hyperair facepalms | 17:35 | |
| hyperair | i was just trying to be standard. | 17:35 |
| hyperair | andyrock: https://paste.debian.net/148624/ | 17:37 |
| hyperair | there you go. | 17:37 |
| === m_conley is now known as m_conley_away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!