| === eu is now known as Guest64484 | ||
| === kocolosk is now known as kocolosk|away | ||
| mandel | morning all! | 09:07 |
|---|---|---|
| JamesTait | Morning all! :) | 09:29 |
| === eu is now known as Guest53996 | ||
| gatox | good morning! | 11:03 |
| gatox | mandel, ping | 11:16 |
| mandel | gatox, pong! | 11:16 |
| gatox | mandel, hi! do you have time for 2 reviews? | 11:17 |
| mandel | gatox, sure, shoot | 11:17 |
| mandel | gatox, I'm block fighting with twisted :P | 11:17 |
| gatox | mandel, https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/misaligned-icons - https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/not-validated-account/+merge/83054 | 11:18 |
| gatox | mandel, ohhhh... always a nassty fight :P | 11:18 |
| mandel | gatox, yeah. I'm getting a 400 and I don't know why :( | 11:20 |
| mandel | gatox, why are you doing this: self.wizard()._next_id | 11:30 |
| mandel | gatox, I mean, if the _next_id has a leading _ is for a reason, if not, just rename it to next_id :P | 11:30 |
| gatox | mandel, can you tell me where? | 11:30 |
| mandel | gatox, it looks funny if it is not in a test class | 11:31 |
| mandel | gatox, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/not-validated-account/+merge/83054 | 11:31 |
| mandel | gatox, line 10 in the diff | 11:31 |
| gatox | mandel, ah...... that's because i need to clean the _next_id in backwards navigation in that case | 11:32 |
| mandel | gatox, it would be nicer to either make it public or use a property | 11:33 |
| mandel | gatox, I know that python lets you access those private variables, but we should be clean about the use of them, if we need to use it in a diff class, lets make it public | 11:34 |
| gatox | i see that it's being use in several places, so we should rename it, but i'll create another bug for that, to not mix a refactor with this branch | 11:34 |
| mandel | gatox, ok, I'll add a comment about it, then you answer back with the bug report :) | 11:34 |
| gatox | ok | 11:34 |
| mandel | gatox, also, I think it should be cleanup_page, so, using the python naming convention, but that is only my opinion | 11:39 |
| gatox | mandel, it's a qt method | 11:40 |
| mandel | gatox, oh, ok | 11:40 |
| mandel | gatox, one last question, can you explain the registration_incomplete method, what does it change the id, call next, and then change the id again? | 11:42 |
| * gatox looking.... | 11:42 | |
| gatox | mandel, that is a slot, that is executed when the registrationIncomplete signal is emitted.... and works this way: set up the _next_id value (which will contain the id of the next page), then call next() that will check with the current page what to do, so i need the _next_id to be setted in order to allow the page to take that value.... and then i set the next page again to establish the proper flow | 11:45 |
| mandel | gatox, what I dont undestand is the following, so next is comming from the Wizard, is that correct? | 11:46 |
| gatox | yes | 11:46 |
| mandel | gatox, so, you set the WizardPage nextId which points to the page following that WizardPage id, then you tell the wizard to move foward (although you do not know for sure that your page is the current page in the wizard) and then once the wizard has moved, you set a new id, is that correct? | 11:48 |
| gatox | mandel, nop..... i know which page is goinng to be there, because it's the only page that throw the registrationIncomplete signal..... but that it's in the sso branch | 11:49 |
| mandel | gatox, yikes! that is very fragile.. but ok, lets assume that is ok, the second step is to add a new next id, I suppose that is because you are going back to this page, right? | 11:50 |
| gatox | mandel, nop...... that 's because the flow of the wizard is not linear, so you need to tell it which page is going to be the next one | 11:51 |
| gatox | in some cases | 11:51 |
| gatox | the wizard not always follow the next page added | 11:52 |
| mandel | gatox, so, what I think is that such logic should be present in the nextId method from the WizardPage and that cleanUp should so something like, self._registration_incomplete = True, self.next() | 11:54 |
| mandel | gatox, so that all the logix regarding the move to the next page is present in the nextId method, which is the reason for that method to exists | 11:55 |
| mandel | gatox, at least, it would match the docs of the method better :) | 11:55 |
| mandel | do I make sense? | 11:55 |
| ralsina | mandel: that involves moving logic from all over the place into nextId() | 11:55 |
| ralsina | mandel: you can either have the wizard decide, or the pages decide. I don't mind either, but it is what it is ;-) | 11:56 |
| gatox | also..... nextId never execute the page transition...... i think THAT would be a mess | 11:56 |
| mandel | ralsina, gatox but that is the theory, that all flow logic should be implemented in the nextId method | 11:56 |
| gatox | the page transition, i think, should be executed in the wizard...... nextId only returns which should be the next id | 11:56 |
| gatox | and integer | 11:56 |
| mandel | gatox, exactly, so, nextId returns the id of the page, I'm not syaing to move the next call there | 11:57 |
| ralsina | mandel: welll.... not really. We sometimes need to go back non-linearly, and there nextId() doesn't help | 11:57 |
| mandel | gatox, but that all flow logic should be there, that is, all the different paths should be determined by the nextId method, otherwise the only use of the nextId method is to do a return self.next_id which is super lame | 11:58 |
| ralsina | mandel: according to the docs, we would need to hack page.nextId() yes: http://doc.qt.nokia.com/4.7/qwizard.html#creating-non-linear-wizards | 11:58 |
| gatox | mandel, i really don't think that the flow logic should be there...... because from my point of view, that it's assume that all the pages know the others | 11:59 |
| mandel | ralsina, that is how I've always though about it.. | 11:59 |
| ralsina | mandel: OTOH, what's there works, and fixing it this way may break it, and adds days of work | 11:59 |
| mandel | gatox, it will mean that a page know where to go according to what happened in the page, and the wizard just knows about how to handle that | 12:00 |
| mandel | ralsina, I'm just being a purist here in this case, I just want to know what is the actual reason for not following the normal way, if the reason is valid I'll give a plus one :) | 12:00 |
| ralsina | mandel: it's how it's donein the ret of the code ;-) | 12:01 |
| mandel | ralsina, gatox I wont block a branch from landing due to such an implementation detail... | 12:01 |
| mandel | ralsina, ah.. you are not allowed to play the consistency card here! that is cheating! | 12:01 |
| nessita | hello everyone! | 12:01 |
| gatox | nessita, hi | 12:01 |
| ralsina | hello nessita | 12:02 |
| mandel | nessita, morning! | 12:02 |
| nessita | hi gatox, ralsina, mandel | 12:02 |
| gatox | mandel, well....... maybe i'm wrong...... but i think that it's more qt-ish | 12:02 |
| mandel | gatox, qt-is would be doing like in the docs that ralsina pointed out: http://doc.qt.nokia.com/4.7/qwizard.html#creating-non-linear-wizards | 12:02 |
| ralsina | mandel, gatox: in any case,I am all for opening a new bug for this, and/or doing it "right" for this branch, but honestly, implementing nextId or setting _next_id is pretty much the same thing :-) | 12:02 |
| mandel | gatox, ralsina lets add a +1 since is not a terrible thing | 12:03 |
| nessita | ralsina: may I ask what's the issue? | 12:03 |
| ralsina | nessita: on the wizard, we are doing page flow in a non-standard manner | 12:03 |
| mandel | nessita, me being a purist in a small qt detail :P | 12:03 |
| nessita | mandel: what would be the standard manner? | 12:03 |
| ralsina | nessita: it works, but the docs say it should be done in a different way. So, while I would like to change it, it may break all the wizard workflow :-) | 12:04 |
| ralsina | nessita: http://doc.qt.nokia.com/4.7/qwizard.html#creating-non-linear-wizards | 12:04 |
| mandel | nessita, flow logis should be found in a single method which is the nextId onw | 12:04 |
| mandel | s/onw/one | 12:04 |
| nessita | mandel: what about when going bacwards? | 12:04 |
| mandel | nessita, what do you mean, using the back button or moving the wizard to a page already shown? | 12:05 |
| ralsina | mandel: the second | 12:05 |
| ralsina | (back button should just work) | 12:05 |
| mandel | nextId, is control flow | 12:05 |
| nessita | mandel: using the back button to show a page already shown, but may not be the last visited page | 12:05 |
| mandel | ralsina, just what I was going to say | 12:05 |
| ralsina | nessita: I don't think we do that | 12:06 |
| mandel | nessita, what? the back button should always point to the last page we visited, would be confusing to do it other way | 12:06 |
| nessita | ralsina: yeah, in the method where you had to had two .back() calls... no? | 12:06 |
| nessita | had to add* | 12:06 |
| gatox | nessita, that was fixed | 12:06 |
| ralsina | nessita: hmmmm good point, I don't remember | 12:06 |
| gatox | anyway..... you can't change the back id | 12:07 |
| nessita | gatox: right, but we were taking the user 2 pages back | 12:07 |
| gatox | nessita, yes | 12:07 |
| ralsina | nessita: IIRC, it's done that way because you can't "next" to a visited page :-/ | 12:07 |
| nessita | ok, looking at the doc now, it wasn't loading | 12:07 |
| mandel | anyway, I HATE getting in phylosofical arguments when the implementation works ans is done everywhere, so i'm giving a +1 | 12:07 |
| gatox | nessita, yep, you can not move forward to a visited page, so we needed to use back | 12:07 |
| nessita | mandel: +1 to approving and filing a bug | 12:08 |
| nessita | ralsina, gatox: ^ | 12:08 |
| nessita | mandel: anyways, what's the branch? | 12:08 |
| ralsina | me too | 12:08 |
| gatox | +1 | 12:08 |
| ralsina | the bug can even be done in stages, just removing _next_id from one page at a time | 12:08 |
| ralsina | so it can be tested reasonably | 12:08 |
| mandel | gatox, ralsina , nessita I've approved the branch, gatox do you want me to create a bug? | 12:10 |
| gatox | mandel, please | 12:10 |
| mandel | gatox, on it | 12:10 |
| mandel | ralsina, nessita so, on P or package (ubuntuone-client) brakes P by looking at bug 903483 | 12:10 |
| ubot4 | Launchpad bug 903483 in ubuntuone-client-gnome (Ubuntu) "gnome-settings-daemon crashed with signal 5 in g_object_newv() (affects: 2) (heat: 14)" [Medium,Confirmed] https://launchpad.net/bugs/903483 | 12:10 |
| mandel | JamesTait, and mandel had the issue and had to revert to an old package to fix the issue | 12:11 |
| ralsina | signal 5? SIGTRAP???? | 12:11 |
| mandel | ralsina, nessita more of: GLib-GIO-ERROR **: Settings schema 'org.gnome.nautilus.nautlius.extensions.ubuntuone' is not installed | 12:12 |
| nessita | mandel: ah, there is a branch proposed by pitti for that, no? | 12:12 |
| ralsina | name."nautlius" hahaha | 12:12 |
| mandel | nessita, AFAIK there is not | 12:13 |
| mandel | ralsina, yeah, so in O we did not crash anything by luck, so only god knows how long we have had that | 12:13 |
| ralsina | well, bzr blame can tell you ;-) | 12:13 |
| JamesTait | ralsina: pitti said it's caused by glib being more strict in its schema checks in this release - there's an assertion in there that wasn't there before I think. | 12:14 |
| mandel | nessita, ralsina, gatox FYI bug 903682 | 12:15 |
| ubot4 | Launchpad bug 903682 in ubuntuone-windows-installer "Follow the standard programming for control flow of QWizardPages (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/903682 | 12:15 |
| ralsina | mandel: ack! | 12:15 |
| ralsina | reacting to a schema bug by crashing seems slightly intolerant to me, but hey, it found a bug | 12:16 |
| mandel | ralsina, I guess is just for alphas etc.. | 12:16 |
| nessita | mandel: I will triage the glib error and assign to rodney | 12:19 |
| mandel | nessita, cool, I was tempted to do it but I though it would be better if you did :) | 12:20 |
| nessita | mandel: :-) | 12:22 |
| mandel | ralsina, I'm a little stuck with a twisted thing, so, do you want me to look first and the issue we had with windows? | 12:23 |
| nessita | mandel: ah, BTW, alecu and I made a ouple of reviews for you, there are some things to fix in both | 12:24 |
| mandel | nessita, ok, on them as soon as I finish with gatox | 12:25 |
| nessita | ack | 12:25 |
| mandel | gatox, one question, regarding this text = device_info["name"] on mp https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/misaligned-icons/+merge/83620 | 12:26 |
| gatox | mandel, yep? | 12:26 |
| mandel | gatox, what happens if the key is missing, does it crash? | 12:26 |
| gatox | mandel, yep..... probably..... maybe i should use a default text, or ignore that cases | 12:27 |
| mandel | gatox, well, if the info comes from a json from the server it might be a good idea to make sure that we can deal with those issues | 12:27 |
| ralsina | mandel: sure, why not | 12:27 |
| mandel | gatox, I mean, lets not trust the server ;) | 12:28 |
| gatox | mandel, ok...... can you mark it as need fixing? | 12:28 |
| mandel | gatox, sure | 12:28 |
| gatox | mandel, thanks | 12:28 |
| mandel | gatox, also, I really really hate the self.ui.ui but I know you cannot change it :) | 12:30 |
| gatox | mandel, yep...... the second ui...... it's ok because the ui itself it's being used like that in the proper class..... and first one, involve a major refactoring in all the tests | 12:31 |
| mandel | gatox, I know, I know.. | 12:31 |
| nessita | gatox, mandel: they key in the dict will be there, that is ensured why our backend | 12:31 |
| nessita | gatox, mandel: so no need to handle that gracefully | 12:31 |
| mandel | nessita, cool, then add that as a reply and I approve :) | 12:31 |
| mandel | or gatox for that matter :P | 12:31 |
| nessita | mandel: sure! | 12:31 |
| nessita | mandel: comment added | 12:36 |
| mandel | nessita, sweet, approving then | 12:37 |
| mandel | gatox, you have 2 * +1 for https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/misaligned-icons/+merge/83620 | 12:37 |
| gatox | mandel, great | 12:38 |
| gatox | aprroving.... | 12:38 |
| mandel | nessita, regarding the comment for https://code.launchpad.net/~mandel/ubuntuone-client/ignore-system-folders/+merge/84848 only the system can create system folders :( | 12:44 |
| nessita | mandel: really? | 12:45 |
| mandel | nessita, let me double check but AFAIK you cannot | 12:47 |
| * mandel looks in msdn | 12:47 | |
| rye | mandel, really? you should be able to - that's attrib something | 12:47 |
| gatox | brb | 12:48 |
| mandel | nessita, rye sorry I was wrong, I can use the SetFileAttributes and pass x04 as a flag | 12:49 |
| nessita | mandel: ack | 12:49 |
| mandel | nessita, will add a test with that and will remove the useless methods | 12:49 |
| nessita | mandel: awesome | 12:49 |
| nessita | mandel: be sure to add cleanup to remove those | 12:49 |
| mandel | nessita, yep otherwise trial wont be able to delete the tests files | 12:50 |
| mandel | nessita, actually, is there a reason for me to add a cleanup remogin the file since the TEstCase does remove _trial_temp, right? | 12:50 |
| nessita | mandel: _trial_temp is not removed, since is needed to debug in case of failure | 12:52 |
| mandel | nessita, so I should leave the files there, right? in case the test fails | 12:53 |
| nessita | mandel: no no, a test should never leave anything | 12:53 |
| mandel | ok | 12:53 |
| nessita | mandel: what we leave are logs and related | 12:53 |
| gatox | back | 13:02 |
| alecu | hello #ubuntuone! | 13:04 |
| gatox | alecu, hi | 13:09 |
| mandel | alecu, morning | 13:09 |
| alecu | nessita, ping | 13:12 |
| nessita | alecu: pong | 13:12 |
| nessita | alecu: I'm doing the last 3 reviews for you, re: timestamp autofix | 13:13 |
| alecu | nessita, cool. But, two branches landed with just one review: | 13:13 |
| alecu | • https://code.launchpad.net/~alecu/ubuntuone-storage-protocol/timestamp-autofix-1-6/+merge/81791 | 13:13 |
| alecu | • https://code.launchpad.net/~alecu/ubuntu-sso-client/timestamp-autofix-1-2/+merge/82685 | 13:13 |
| nessita | alecu: and that's fine... | 13:13 |
| alecu | nessita, ok. just checking. | 13:13 |
| alecu | nessita, is it ok for backports to just land with one review? | 13:14 |
| nessita | alecu: minimal requirement is one review (for any branch), we usually do two, but in this case we hardly can get one | 13:14 |
| mandel | yeah, that is something I wanted to ask, I have seen several branches doing that... | 13:14 |
| nessita | alecu: so I'd say yes, we can land with one if IRL testing was performed, and tests run in every platform | 13:15 |
| nessita | mandel: I would advice not going with one review in general, this is a particular case | 13:15 |
| mandel | ok, I was just curios 'cause I have seen it several times (not in alecus branches but other cases) and I was confused | 13:15 |
| alecu | nessita, mandel: since it's taking too long to get just one review, then you can bet I'm supportive of this change | 13:16 |
| nessita | mandel: well, we talked about this in a meeting, remember? we said 2 reviews in general, unless trivial branches or specific exceptions | 13:17 |
| mandel | alecu, yeah, I don't mind too much, mere curiosity | 13:17 |
| nessita | mandel: yeah, I understand the confusion | 13:17 |
| mandel | nessita, I have bad memory :) | 13:17 |
| alecu | You have a problem with authority, Mr. Mandel. You believe you are special, that somehow the rules do not apply to you. Obviously, you are mistaken | 13:18 |
| nessita | mandel: but these branches have almost a month now :-/ | 13:18 |
| mandel | alecu, nah, stupid matrix! | 13:18 |
| alecu | :-) | 13:18 |
| mandel | nessita, yikes, do you guys want me to take a look at some of them, I'm fixing my mps but I guess this is more urgent | 13:19 |
| nessita | mandel: is ok, there are only 3 left and I'm hadling them | 13:19 |
| nessita | I already have the 3 needed VMs | 13:19 |
| nessita | mandel: but thanks! | 13:19 |
| mandel | nessita, ok, if you need a hand let me know | 13:19 |
| nessita | alecu: look! https://launchpad.net/ubuntu/precise/+source/qt4reactor :-) | 13:20 |
| alecu | nessita, nice!!! | 13:21 |
| nessita | alecu: you may hate me for asking this, but.. any reason for the branches for controlpanel on bug #692597 for stable-2-0 and stable-1-0 are not done? | 13:37 |
| ubot4 | Launchpad bug 692597 in ubuntuone-storage-protocol (Ubuntu) (and 22 other projects) "If the user has the date/time/timezone wrong, connection fails (Expired timestamp error) (affects: 18) (dups: 6) (heat: 144)" [Undecided,New] https://launchpad.net/bugs/692597 | 13:37 |
| mandel | ok, lunch time for me! | 13:41 |
| * mandel lunch | 13:41 | |
| alecu | nessita, the reason those branches are not done is that I haven't gotten to work on them just yet | 13:53 |
| alecu | nessita, and they depend on the whole other branches landing | 13:53 |
| nessita | alecu: perfect, thanks | 13:53 |
| nessita | alecu: no rush, I just wanted to know we're in synch | 13:54 |
| alecu | and now it's the time of the day where I do the kinder run | 14:01 |
| * alecu bbls | 14:01 | |
| nessita | alecu: ping | 14:21 |
| nessita | alecu: when you get back, would you please add a tiny fix to your ~alecu/ubuntuone-client/timestamp-autofix-1-6/+merge/82754 branch? | 14:21 |
| nessita | alecu: you need to fix the Makefile so the -p is passed before the dir to be targeted for running tests | 14:23 |
| nessita | alecu: all branches approved, some need some tweak so they pass thru tarmac | 14:41 |
| * mandel back | 14:47 | |
| === yofel_ is now known as yofel | ||
| mandel | me | 15:00 |
| mandel | nessita, gatox, ralsina, alecu, dobey stand up? | 15:00 |
| gatox | me | 15:00 |
| ralsina | sorry, mgmt call | 15:01 |
| nessita | me | 15:01 |
| nessita | mandel: rodney is on swap day, so, go! | 15:02 |
| mandel | DONE: Swap day yesterday (I arrived to spain ar noon). Upgraded to P and found with JamesTait bug 903483. Reviewed 2 of gatox branches and added bug regarding the way we do the control flow in the installer. Updated the branch regarding the system paths (I need to psuh the changes). | 15:02 |
| mandel | TODO: Fix the other MP, look at issue with Windows and keep working on the Proxy tests using the twisted web client. | 15:02 |
| mandel | BLOCKED: I need some more time with the twisted stuff, I'm getting a 400 and I don't know really why. | 15:02 |
| mandel | COMMETS: python madrid is today so I've been working from my 9am 'til my 6a,. (that will me 2 more hours from me today.) | 15:02 |
| ubot4 | Launchpad bug 903483 in ubuntuone-client-gnome (Ubuntu) (and 1 other project) "gnome-settings-daemon crashed with signal 5 in g_object_newv() (affects: 2) (heat: 14)" [Medium,Confirmed] https://launchpad.net/bugs/903483 | 15:02 |
| mandel | gatox, gogogo | 15:02 |
| gatox | DONE: | 15:02 |
| gatox | Fixed some branches, get_home_dir implementation in u1-client. | 15:02 |
| gatox | TODO: | 15:02 |
| gatox | Keep working on link creation, and then another bugs. | 15:02 |
| gatox | BLOCKED: | 15:02 |
| gatox | No | 15:02 |
| gatox | nessita, go | 15:02 |
| nessita | DONE: Done tons of reviews, teach lead meeting, bug triage catch up | 15:02 |
| nessita | TODO: finish timestamp-autofix reviews, precise install, start designing sso refactor to fix the registration failure on windows installer | 15:02 |
| nessita | BLOCKED: nopes | 15:02 |
| nessita | NEXT: alecu | 15:02 |
| nessita | or NEXT: ralsina, whoever can paste his notes :-) | 15:03 |
| nessita | gatox: you have any pending branches from me for review? | 15:03 |
| gatox | nessita, nop..... i only have the network detection branch, that was delayed because it wasn't to be included in the release..... | 15:04 |
| gatox | and i'm pretty sure that it has conflicts now | 15:05 |
| nessita | gatox: but I approved that one, right? | 15:05 |
| nessita | gatox: and I know alecu asked some minimal fixes | 15:05 |
| gatox | nessita, one of them was approved | 15:05 |
| gatox | by you | 15:05 |
| nessita | gatox: ah right, the installer one is still pending | 15:05 |
| gatox | nessita, yes | 15:05 |
| ralsina | DONE: setting up lots and lots of VMs, working on debugging the syncdaemon-doesn-start-right bug on windows on a clean VM, hiring (one done!) canonicaladmin, bug triaging TODO: askubuntu, bug triaging, finish VM setups, research windws 8 metro UI requirements BLOCKED: well, school is out, nanny situation is difficult, so it's not really easy | 15:05 |
| nessita | gatox: but I would like the sso one to be merged first | 15:05 |
| gatox | nessita, ok | 15:05 |
| nessita | gatox: and then the installer one be updated | 15:06 |
| nessita | gatox: let me know when both things happens, please :-) | 15:06 |
| ralsina | also DONE: tech leads call, mgmt call (in progress) | 15:06 |
| mandel | ralsina, regarding windows 8, I look at it during the weekend, we could chat later if you want :) | 15:06 |
| gatox | nessita, i'm with links now..... when i have some free time, i'll update that branches | 15:06 |
| nessita | gatox: no rush on this end | 15:06 |
| ralsina | mandel: sounds like fun, let's talk about it on 54 minutes, or so ok? | 15:07 |
| mandel | ok | 15:07 |
| gatox | lunch for gatox | 15:08 |
| === gatox is now known as gatox_lunch | ||
| alecu | me | 15:08 |
| ralsina | DAMN, windows XP starts playing music while installing. NOT COOL. | 15:08 |
| nessita | alecu: go! | 15:08 |
| alecu | DONE: started a branch to use devtools testscases for the proxy integration tests | 15:10 |
| alecu | TODO: keep working on the proxy branches | 15:10 |
| alecu | BLOCKED: no | 15:10 |
| nessita | alecu: got my messages re your timestampautofix branches? | 15:14 |
| nessita | alecu: summary: all approved, a couple need a tweak on the Makefile since latest u1trial requires the dir to be tested to be at the end of the command line | 15:15 |
| alecu | nessita, cool, looking. | 15:15 |
| mandel | nessita, regarding that, how is the process of leaving ubuntuone-client as just python? there was somehting going on about that, right? | 15:16 |
| nessita | alecu: now doing proxy-web-client which so far looks good (will add some fixes request for some style minor thingies) | 15:16 |
| nessita | mandel: rodney started that process, but we still have some C bits in it | 15:16 |
| mandel | nessita, cool :) | 15:17 |
| nessita | mandel: not sure he will finish that this cycle, since no roadmap room for it | 15:17 |
| mandel | nessita, well, at least we are trying :) | 15:17 |
| mandel | nessita, P comes with python£ ? | 15:37 |
| mandel | that is python3, sorry .. | 15:37 |
| nessita | mandel: nopes (just tested IRL on a P fresh install) | 15:38 |
| nessita | mandel: but you will certainly have it in main | 15:38 |
| mandel | nessita, ah, ok I just saw an update for python3.2 and i was glady surprised :) | 15:38 |
| nessita | mandel: perhpas on an update? I have a fresh install, upgrade is ongoing (ie not finished yet) | 15:39 |
| mandel | nessita, maybe, I know the python3 is there.. | 15:41 |
| nessita | everyone: I will start moving SSO wizard pages from installer to sso, so be careful when merging/starting branches | 15:41 |
| mandel | not that we are going to use it :( | 15:41 |
| mandel | nessita, ack | 15:41 |
| nessita | gatox_lunch: ^ | 15:41 |
| mandel | nessita, if you have nightlies in P you might want to force the system to use ubuntuone-client-gnome=2.0.1-0ubuntu3 | 15:42 |
| mandel | nessita, doing that you will not get a broken theme until we fix our code | 15:42 |
| nessita | mandel: why? because of the crash? | 15:42 |
| mandel | nessita, yes | 15:43 |
| mandel | nessita, if you revert to the one use in O you will be fine, that one does not crash because is missing the sassertion | 15:43 |
| nessita | mandel: we'll ping rodney tomorrow about this, he may have a fix soon | 15:43 |
| === gatox_lunch is now known as gatox | ||
| mandel | nessita, is a typo, so it should be easy to fix, but for the time being is good to know that we can just roll back to the old package | 15:44 |
| gatox | nessita, are you starting with that? | 15:44 |
| nessita | gatox: yeap, will investigate how terrible/easy is | 15:44 |
| nessita | gatox: any suggestions/advices? | 15:44 |
| gatox | nessita, ok... mmmmm not now..... i should take a look too to see it better | 15:45 |
| gatox | nessita, let me know if i can do something | 15:45 |
| nessita | gatox: I will, no worries | 15:46 |
| mandel | aghg I'm running all the u1-client tests by accident :( | 15:51 |
| alecu | nessita, it seems that the u1-client megabug branches are failing to land because the sso they are using is not yet the latest revision. | 15:52 |
| nessita | alecu: right, but I think that's only one branch... | 15:53 |
| nessita | alecu: the rest need the u1trial sentence tweaked on Makefile | 15:53 |
| alecu | I see | 15:53 |
| nessita | alecu: the failure ImportError: No module named windows.network_manager means that u1trial is acting up | 15:54 |
| nessita | alecu: so, instead of having u1trial tests -p something | 15:54 |
| nessita | we need: u1trial -p something tests | 15:54 |
| nessita | alecu: can you please add that twek to your branches? | 15:54 |
| nessita | mandel, gatox: the latest branch that landed from gatox has lint issues... did you run the suite on linux? | 15:55 |
| alecu | sure | 15:55 |
| mandel | nessita, not on linux, no | 15:56 |
| gatox | nessita, which one? | 15:56 |
| nessita | gatox: the one that landed today | 15:56 |
| nessita | now trunk has these errors: | 15:56 |
| nessita | ubuntuone_installer/gui/qt/tests/test_gui.py: | 15:56 |
| nessita | 362: [W0212, MainWindowTestCase.test_current_user_sign_in_page_clenaup] Access to a protected member _next_id of a client class | 15:56 |
| nessita | 374: [W0212, MainWindowTestCase.test_registration_incomplete] Access to a protected member _next_id of a client class | 15:56 |
| nessita | alecu: also, I see that the pep8 issue I reported on your branch, is on trunk as well :-/ | 15:56 |
| nessita | ./ubuntu_sso/main/__init__.py:111:37: E202 whitespace before '}' | 15:56 |
| mandel | nessita, how did in land if it has lin issues? | 15:56 |
| nessita | mandel: tarmac does not run installer tests, it need the qt4reactor | 15:57 |
| nessita | mandel: that's why our reviews have to be very thoughtful | 15:57 |
| mandel | nessita, ahhh mea culpa then, I though that tarmac would catch any of those things.. | 15:57 |
| gatox | nessita, i'll propose a branch to fix that now | 15:57 |
| nessita | mandel: non of the QT suites are run by tarmac | 15:57 |
| nessita | gatox: please :-) | 15:57 |
| nessita | gatox: same for ussoc? | 15:58 |
| nessita | gatox: ./ubuntu_sso/main/__init__.py:111:37: E202 whitespace before '}' | 15:58 |
| gatox | ok | 15:58 |
| mandel | nessita, ack, I did not know that, i though that dobey did install the qt reactor | 15:59 |
| nessita | mandel: I'm trying to fix that, but first I need to backport qt4reactor, which is now available to precise, to older releases | 15:59 |
| nessita | mandel: nopes, we did not have a package for it | 15:59 |
| mandel | nessita, I guess my info was wrong :( | 15:59 |
| mandel | alecu, with addCleanup what is the order of the calls done, first added first executed? | 16:02 |
| alecu | mandel, lifo | 16:02 |
| alecu | mandel, lafc | 16:03 |
| alecu | "last added first called" | 16:03 |
| alecu | mandel, I *think* | 16:03 |
| mandel | alecu, lifo and no fifo.. I would have expected the fifo.. wear.. | 16:03 |
| nessita | alecu: yes, that's correct | 16:03 |
| mandel | s/wear/weird :P | 16:03 |
| nessita | mandel: you just add a addCleanup call as soon as you perform the action that dirties the env | 16:03 |
| nessita | mandel: so, as soon as you create a file, add the addCleanup to remove it | 16:04 |
| nessita | since the queue is a LIFO, that will always work | 16:04 |
| nessita | and actually, if it was a FIFO, that will not work and the code will be messy | 16:04 |
| gatox | nessita, i can't find the pep8 issue in sso | 16:15 |
| gatox | at least running pep8 --repeat . | 16:16 |
| nessita | gatox: I think is the new code you added for user not validated, let me show you | 16:16 |
| nessita | nessita@dali:~/canonical/ussoc/trunk$ pep8 --repeat . | 16:16 |
| nessita | ./ubuntu_sso/main/__init__.py:111:37: E202 whitespace before '}' | 16:16 |
| nessita | this dict: | 16:16 |
| nessita | 109 error_dict = { | 16:16 |
| nessita | 110 'errtype': 'UserNotValidated', | 16:16 |
| nessita | 111 'message': email | 16:16 |
| nessita | 112 } | 16:16 |
| nessita | has to be: | 16:16 |
| nessita | 109 error_dict = { | 16:17 |
| nessita | 110 'errtype': 'UserNotValidated', | 16:17 |
| nessita | 111 'message': email, | 16:17 |
| nessita | 112 } | 16:17 |
| nessita | (add a comman after email) | 16:17 |
| nessita | gatox: si? | 16:17 |
| gatox | nessita, yep..... i can see it now..... but pep8 --repeat . is not showing me anything...... weird | 16:17 |
| nessita | are you running it on trunk? | 16:18 |
| gatox | nessita, i updated trunk, then branch it.... and i'm running it there...... and i can see that the code is not right.... but pep8 don't complatin | 16:18 |
| gatox | complain | 16:18 |
| nessita | gatox: what about if you do pep8 ubuntu_sso/main/__init__.py | 16:19 |
| gatox | nessita, nop.... | 16:19 |
| gatox | that's weird...... pep8 used to work fine here | 16:20 |
| gatox | nessita, this is the branch of the lint issues: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/lint-fix/+merge/85513 | 16:20 |
| gatox | nessita, and this is the one to fix the pep8 issue: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/pep8-fix/+merge/85514 | 16:22 |
| * mandel hates win32 api | 16:23 | |
| nessita | gatox: both globally approved as trivial | 16:26 |
| gatox | brb | 16:37 |
| * awilkins also hates win32 api | 16:37 | |
| mandel | who ever wrote win32 api was on crack.. | 16:37 |
| mandel | jesus.. | 16:37 |
| awilkins | Is it an impertinent question to ask if you chaps know anything about the Ubuntu One client job being advertised on Canonical jobs? | 16:41 |
| awilkins | Having lurked here I suspect that the most talkative people in here already work for Canonical :-] | 16:42 |
| mandel | awilkins, AFAIK there was one/two advertised in the canonical jobs page | 16:45 |
| awilkins | mandel, Yeah, there's a Mac oriented one and a Windows oriented one | 16:46 |
| mandel | awilkins, yep, that is what I remembered | 16:47 |
| awilkins | mandel, They've just been reposted today, I applied for the Windows one at the end of November but I've not heard back, hence the blatant fishing | 16:47 |
| mandel | awilkins, uhm, where they? I did not know about that.. but I'm not the best one to tell, I'm just a code monkey :P | 16:48 |
| awilkins | http://www.canonical.com/about-canonical/careers # They are in the feed column on the right | 16:49 |
| awilkins | I know the feeling... my place are sending out job adverts for people who report to me but I've had no input into the job description.. | 16:50 |
| awilkins | I suspect I won't even get to pick a list of interviewees... | 16:50 |
| mandel | awilkins, is more that I usually don't track those things hehe | 16:51 |
| Chipaca | awilkins: talk with ralsina :) | 16:52 |
| * Chipaca throws ralsina under the bus | 16:52 | |
| ralsina | awilkins indeed talk to me :-) | 16:53 |
| * mandel ralsina y, quieres hablar sobre windows 8 ahora o lo dejamos para manana? | 16:54 | |
| mandel | herb, I'm stupid :P | 16:55 |
| ralsina | mandel: mañana a la mañana, estoy tratando de entender el problema de windows 7 primero ;-) | 16:55 |
| mandel | ralsina, sound good :P | 16:55 |
| === awilkins is now known as dr_barnowl | ||
| === dr_barnowl is now known as awilkins | ||
| mandel | nessita, https://code.launchpad.net/~mandel/ubuntuone-client/ignore-system-folders/+merge/84848 has been updated with your comments, also added some tests with GetFileAttrs patched and using real files | 17:13 |
| nessita | mandel: awesome | 17:13 |
| mandel | nessita, uh, I forgot to run lint on windows, give me some mins for that, sorry! | 17:14 |
| nessita | mandel: ack | 17:15 |
| === kocolosk|away is now known as kocolosk | ||
| beuno | nessita, o/ | 17:17 |
| beuno | te presento a luchomax | 17:17 |
| luchomax | buenas | 17:17 |
| luchomax | okis | 17:17 |
| beuno | que no puede loguearse a U1 desde 11.10 | 17:17 |
| luchomax | :P | 17:17 |
| beuno | nessita, le podes dar una mano? | 17:18 |
| nessita | beuno: I was about going to have lunch, but yes, certainly | 17:18 |
| luchomax | ok | 17:18 |
| nessita | luchomax: hi there! what problem are you having, specifically? | 17:18 |
| * beuno hugs nessita | 17:18 | |
| nessita | luchomax: do you speak english? | 17:18 |
| luchomax | si nessita | 17:18 |
| luchomax | yes so so | 17:18 |
| luchomax | but i think i can explane me | 17:18 |
| luchomax | i want to logme in ubuntu one | 17:19 |
| luchomax | but i cant | 17:19 |
| nessita | luchomax: right, and you using the app under the messaging menu (below the envelope, at the top right corner)? | 17:19 |
| luchomax | yes | 17:20 |
| luchomax | i tryed | 17:20 |
| nessita | luchomax: and are you having some error? or how can you tell you can't login? :-) | 17:20 |
| luchomax | even i unistalled | 17:20 |
| luchomax | no message | 17:21 |
| nessita | luchomax: what happens when you click on "I already have an account"? | 17:21 |
| luchomax | it is thinking all the time without final message | 17:21 |
| nessita | luchomax: ok, do you know how to use a terminal? | 17:21 |
| luchomax | it permit me to put my keys but no answers | 17:21 |
| luchomax | yes | 17:22 |
| luchomax | just tell me what to tipe | 17:22 |
| luchomax | sorry, what to write | 17:22 |
| nessita | luchomax: I see. So, please open a terminal, and please paste in paste.ubuntu.com the content of running the following command: | 17:22 |
| mandel | nessita, here are no lint issues :) | 17:22 |
| nessita | luchomax: let's better do something else, please email to natalia.bidart@canonical.com all the files located at ~/.cache/sso/ | 17:23 |
| luchomax | ok | 17:23 |
| nessita | luchomax: can you wait for 15-20 minutes? my lunch is here :-/ | 17:25 |
| luchomax | yes no problem | 17:25 |
| luchomax | enjoy it | 17:25 |
| nessita | luchomax: brb! | 17:25 |
| godzy | hi all | 17:28 |
| alecu | hi there | 17:29 |
| alecu | nessita, I don't get the error: "./ubuntu_sso/main/__init__.py:111:37: E202 whitespace before '}'" | 17:31 |
| alecu | nessita, are you running some other check besides "./run-tests" ? | 17:31 |
| alecu | I'm talking about this MP: https://code.launchpad.net/~alecu/ubuntu-sso-client/proxy-web-client/+merge/85135 | 17:31 |
| alecu | nessita, perhaps it refers to line 654 in the merge proposal | 17:33 |
| alecu | I correct myself: that's a different file | 17:34 |
| alecu | hmmm... I'm missing some trunk revisions. Let's see now... | 17:35 |
| mandel | nessita, ok, I'm off for lunch, I'll finish the other MP laters tonight or tom early morning | 17:37 |
| alecu | mandel, good luck with the python madrid! | 17:37 |
| mandel | nessita, let me know if there are any other issues :) | 17:37 |
| mandel | alecu, thx! we are getting bigger and bigger and we might have some multi lang conf in the future where we can push python foward in spain, is goign to be fun :) | 17:38 |
| alecu | nice! | 17:38 |
| * alecu starts saving to go to that conf | 17:39 | |
| * ralsina wants to stab windows installer (the one that installs windows) | 17:43 | |
| mandel | alecu, if wont be great 'til 2 years or so, but should be fun :) | 17:43 |
| nessita | alecu: the pep8 issue was added in a branch before that, and gatox already fixed it | 17:58 |
| nessita | alecu: so no need to fix anything extra | 17:58 |
| alecu | nessita, that's what I suspected | 17:58 |
| nessita | luchomax: I'm back | 17:58 |
| nessita | luchomax: are you behind a proxy? | 17:58 |
| nessita | luchomax: looks like your internet connection is timing out | 17:58 |
| alecu | nessita, I wrote that on the proposal page; you may re-review when you can. | 17:58 |
| nessita | I see this in the log file: | 17:58 |
| nessita | File "/usr/lib/python2.7/dist-packages/httplib2/__init__.py", line 925, in connect | 17:59 |
| nessita | raise socket.error, msg | 17:59 |
| nessita | error: [Errno 110] Expiró el tiempo de conexión | 17:59 |
| nessita | alecu: does this ring any bell to you? http://pastebin.ubuntu.com/769217/ | 17:59 |
| alecu | looking | 17:59 |
| nessita | alecu: besides a proxy blocking that request, any other ideas? | 18:00 |
| alecu | nessita, yup, only network issues can mean that | 18:01 |
| nessita | alecu: thanks! | 18:01 |
| nessita | luchomax: let me know when you're back | 18:01 |
| nessita | beuno: would you know if luchomax is behind a proxy? | 18:01 |
| beuno | nessita, I don't know, no | 18:02 |
| nessita | beuno: thanks - I think he has networks timeouts at "socket" level | 18:02 |
| nessita | brb, rebooting router which gone crazy after power outage | 18:06 |
| * nessita is back | 18:08 | |
| nessita | alecu: you did not change any of the """Use one webclient per application.""" docstrings? | 18:10 |
| nessita | alecu: I added a comment saying that they don't look, at least from my POV, very descriptive regarding what the class does/provides | 18:10 |
| alecu | doh | 18:11 |
| nessita | alecu: I also think that you may have left this debugging thingy by mistake? | 18:11 |
| nessita | 397+import twisted.internet.base | 18:11 |
| nessita | 398+twisted.internet.base.DelayedCall.debug = True | 18:11 |
| alecu | nessita, and that's definitely a mistake | 18:11 |
| alecu | nessita, I think that the "DelayedCall.debug = True" is something we should add to u1trial | 18:16 |
| alecu | nessita, fixes pushed. Sorry I missed the docstrings. | 18:17 |
| nessita | alecu: I'm not sure, perhaps using an extra option? because otherwise the traces get eally difficult to read when that is enabled | 18:17 |
| alecu | nessita, btw: try running the tests with -qt too | 18:17 |
| nessita | (regarding the delayed.debug setting) | 18:17 |
| alecu | nessita, yes, I was thinking of an extra option for sure. | 18:18 |
| nessita | alecu: I always, always run the qt suite :-) | 18:18 |
| alecu | cool | 18:18 |
| nessita | alecu: what revno has the latest fixes? I think LP does nopt have them yet | 18:22 |
| luchomax | hola nessita | 18:33 |
| luchomax | sorry for the absent | 18:33 |
| nessita | luchomax: no problem :-) | 18:33 |
| luchomax | yes i'm behind a proxy | 18:33 |
| nessita | luchomax: so, are you behind a proxy? | 18:34 |
| luchomax | but i putted in the configuration of the system | 18:34 |
| luchomax | yes | 18:34 |
| nessita | luchomax: right, we don't support proxy yet, sorry :-/ | 18:34 |
| luchomax | ok | 18:34 |
| luchomax | :'( | 18:34 |
| luchomax | jajaja | 18:34 |
| nessita | luchomax: we're working on that, and we're planning to have it ready for Precise | 18:34 |
| luchomax | oks | 18:35 |
| luchomax | thanks | 18:35 |
| luchomax | a lot | 18:35 |
| gatox | EOD for me!! see you tomorrow! :D | 20:05 |
| * alecu runs back to kinder | 20:07 | |
| ralsina | EOD for me too. See you all tomorrow-ish | 20:28 |
| nessita | ok, EOD | 21:47 |
| nessita | bye all | 21:47 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!