[00:43] poolie: :-( You have two revisions that are marked needstesting [00:44] StevenK, is that bad? [00:46] poolie: Means we can't deploy unless you or someone else does the QA. [00:51] StevenK, fixed [00:51] jtv's is untestable, and wallyworld's is wallyworld_'s. [00:51] and that should be it. [00:51] Finally. [00:52] I think now-ish is as late as I want to deploy. [00:52] Given that it's like 40 revs, yeah [00:52] i'm just finishing something for landing and will then do my qa [00:53] Bleh [00:53] jelmer has marked the bug qa-ok, but my bad-commit tag is hurting the tagger [00:54] I suck [00:54] I didn't realize I had to remove the tag, sorry [00:54] jelmer: It's more the tagger sucks [00:54] Since it landed as bad, was rolled back and now is fine [00:54] You should never remove bad-commit tags. But it is sometimes necessary when the rollbacks are complex or untagged. [00:54] that was my thought.. if somebody becomes qa-ok later, you still don't want to deploy just the old commit. [00:55] The problem is that we have an interlinked chain of rollbacks here, which qa-tagger doesn't handle well. [00:56] And the tagger wasn't tracking some of them due to missing rollback tags [00:58] And my no-configure-codehosting branch doesn't work on qas [00:58] But is it bad? [00:58] No, it doesn't break. [00:58] It just doesn't hide the link. [01:00] * StevenK waits for the tagger [01:02] sinzui: fyi, that inTeam issue was trivially fixed for the merge proposal view which was failing. i've done a dependent branch, cancelled the ec2 landing of the original, and will land the downstream one [01:02] https://code.launchpad.net/~wallyworld/launchpad/protect-inTeam-against-misuse/+merge/85977 [01:04] * wallyworld_ shakes fist at ec2 - using ElasticFox to cancel my ec2 run show 4 running instances from november WTF??!! [01:04] * wallyworld_ is now scared to look at credit card bill :-( [01:16] wallyworld_: There's an ec2 kill command [01:22] StevenK: i would have used it if i had known they were still running. i don't know how they stayed active when all my ec2 land commands completed etc [01:23] so i had no suspicion anything was wrong [01:23] wallyworld_: You know about 'bin/ec2 ls' right? [01:24] StevenK: yeah, but because everything completed ok i had no incling that anything was wrong [01:25] wallyworld_: rvb has a cron job that runs bin/ec2 ls at midnight and mails him if something is running [01:25] StevenK: that's a brilliant idea [01:25] i must ask him for a copy [01:26] wgrant: The tagger insists that r14491 is undeployable still :-( [01:26] * StevenK goes back to qa-bad bad-commit- [01:28] StevenK: 14519 [01:34] Right, setting qa-bad bad-commit-14491 gets us to r14521 [01:34] But r14522 and r14523 are deployable too. Not sure how to convince the tagger otherwise. [01:41] StevenK: HOpefully fixed. [01:42] There we are. [01:42] Indeed [01:42] Writing a deployment request [01:44] https://code.launchpad.net/~cjwatson/launchpad/soyuz-test-mail-ordering/+merge/85979 should fix the i386-specific test breakage we noted the other night [01:47] wgrant: The NDT removes the need for cowboys on germanium/cesium? [01:48] StevenK: not deploying to cocoplum as well? [01:49] I guess that has to be in a downtime window [01:49] cjwatson: Right. [01:49] Do we have one of those later today? [01:49] We can do, I think. [01:52] I think the ftpmaster-relevant stuff is basically just Julian's poppy fix and my cron.germinate rewrite, so if anything goes wrong it'll be in UK time. [01:57] Well, except for cocoplum being all the way back on 14263 right now ... [02:07] StevenK: Hopefully, but it needs to be watched carefully. [02:07] StevenK: It has fixes for all three rollbacks, but ppa/ftpmaster can only be deployed with downtime. [03:30] StevenK: should db_devel bb be forced? [03:30] looks like it lost connection for some reason [03:32] * wallyworld_ stabs it [03:50] A small review for someone: https://code.launchpad.net/~huwshimi/launchpad/gear-icon-visibility-894729/+merge/85986 [04:07] wallyworld_: Doing it wrong [04:08] release-critical is a review tag [04:08] ah ok. i wanted to force the merge to ensure the regression was fixed asap and %@!$%$%! dbdevel bb was busted :-( [04:09] That's [testfix] [04:09] Or just force the build and wait ten minutes [04:09] but it wasn't a testfix for devel [04:09] oh, so i could have just waited? [04:09] We'll be in testfix if either branch has failed [04:10] wallyworld_: Thanks for the review :) [04:10] Yes, the buildbot-poller runs every ten minutes, and looks at the state of buildbot. [04:10] StevenK: i thought testfix was for a checkin to fix an issue with the specific builder that was broken [04:10] huwshimi: np [04:11] anyways, i'll just wait next time [04:11] wallyworld_: You seem to be a little unclear. I can explain this in about 40 seconds via voice [04:11] ok, let's mumble [04:34] A review for the faint-hearted (+1/-0): https://code.launchpad.net/~huwshimi/launchpad/order-button-heights-904751/+merge/85987 [04:34] Haha [05:47] wallyworld_: https://code.launchpad.net/~huwshimi/launchpad/one-bug-breakage-887571/+merge/85989 [05:48] * wallyworld_ looks [05:48] wallyworld_: (+1/-0) again :) [05:48] i'm getting the hard ones today [05:48] wallyworld_: I'm keeping you busy [05:48] wallyworld_: Distracting you from the cricket [05:50] huwshimi: i wish there were cricket. i'm fighting with storm and it's stupid non-verbose error reporting [05:50] huwshimi: all approved [05:51] wallyworld_: Well there was cricket... [05:51] wallyworld_: which did not end well [05:51] hmmm... how can I create a bunch of bugs for dev (enough to test paging)? [05:51] don't remind me :-( [05:51] huwshimi: there's a harness you can run [05:51] wallyworld_: That's why I'm keeping you busy :) [05:51] bin/harness [05:52] product = self.factory.makeProduct() [05:52] print product.name [05:52] for i in range(150): self.factory.makeBug(product=product) [05:52] transaction.commit() [05:52] s/self.// [05:53] wallyworld_: ^ That was I meant on the call yesterday, too [05:53] StevenK: yeah, i already had a look at it [05:55] wallyworld_: Should creating the bugs take a while? [05:55] Yes :/ [05:55] The factory is slow as hell. [05:56] wgrant: :( [05:56] huwshimi: you can also dick with the config to reduce the batch size [05:56] in devel the batch sizes are small anyway [05:57] wallyworld_: This seems to be working for now, I'll wait for it to finish and see if I need to do anything else [05:57] ok [06:07] * wallyworld_ is off to a surpise 75th birthday party. I have the defibrillator and ambulance on standby === wallyworld_ changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugtasks: 3*10^2 [06:08] hah! it was hung [06:08] ok that was very quick [06:40] A review for someone: https://code.launchpad.net/~huwshimi/launchpad/bug-listing-spinner-position-904416/+merge/85997 [06:42] "14527 revisions were removed from the branch." [06:42] what happened there? :) [06:44] mwhudson: Wait, you're not talking about my MP are you? [06:44] ah [06:44] [r=stevenk][rollback=14502] Revert r14502. It causes issues with [06:44] scanner speed and branch mail. [06:44] huwshimi: no [06:45] mwhudson: Good, I was a little worried for a second there :) [06:47] mwhudson: Yeah, that was the very email that alerted me to the issue. [06:47] wgrant: when i read it i was scared that i would have 14527 emails ... [06:49] mwhudson: Yeees. [06:49] I still don't know what the actual problem is. [06:51] It does seem to be iterating over the revisions in reverse order, but that doesn't explain what appears to be the null revision appearing. [08:49] good morning [08:57] Bonjour [09:12] Morning [09:23] Does anyone know if Launchpad development works with Precise? [09:27] allenap: Sort of. [09:27] allenap: But your best bet is to use LXC [09:27] Which works pretty well in Oneiric onwards. [09:28] https://dev.launchpad.net/Running/LXC [09:28] Things go a bit wrong running it natively on oneiric/precise, because the default python is 2.7. [09:28] schroot works too if you didn't need the matching network services in your host system [09:29] Indeed. [09:29] Unlike LXC it doesn't take over your TTYs occasionally either :/ [09:29] Hm, is anyone working on fixing it for 2.7? I thought that had already been done [09:29] If it's just a matter of fixing tests ... === almaisan-away is now known as al-maisan [09:29] Most stuff works. I think I have an unlanded branch with some more fixes. [09:29] But timeout.txt hangs. [09:30] And there are a couple of others that I never got to the bottom of. [09:30] How appropriate [09:30] Haha. [09:30] Ah, indeed, a 4.5-month-old unlanded branch. [09:30] * wgrant sends it off to ec2. [09:31] wgrant, cjwatson: So, would running running Precise and using an <=Oneric schoot/lxc be sensible, or vice-versa? [09:31] Although some of these are in code that I deleted months ago... [09:32] allenap: I use a lucid container on precise [09:32] allenap: I run precise and do drive-by LP development in a lucid schroot. But I'm not really an LP developer :-) [09:33] (And I already had schroot set up for other things.) [09:35] gmb: Don't know if you saw, but I supplied QA instructions on https://code.launchpad.net/~mvo/launchpad/maintenance-check-precise/+merge/82125 [09:37] cjwatson: I hadn't seen but I'll take a look today. Thank you. [10:13] is there a way to turn off the dynamic bug listings without leaving the beta-testers team? I'm getting bitten by JS errors [10:13] ajmitch: There aren't known errors left, AFAIK. Have you filed a bug? [10:14] yeah, just filed bug 905228 [10:14] <_mup_> Bug #905228: Cannot use pagination links on bug listings < https://launchpad.net/bugs/905228 > [10:14] There's no way to disable them without leaving the team. [10:14] ok [10:16] I'll check that bug in firefox, but it's a bit annoying not being able to see more than 75 bugs in chromium === adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring | Firefighting: - | Critical bugtasks: 3*10^2 === matsubara-afk is now known as matsubara === al-maisan is now known as almaisan-away [11:14] morning [11:15] Morning rick_h__ :)# [11:15] s/#/ [12:36] adeuring: can you peek at this once it loads, it's causing broken buglisting for chrome users on prod and I want to get moving asap please https://code.launchpad.net/~rharding/launchpad/pagination_905228/+merge/86033 [12:36] rick_h__: sure [12:37] adeuring: ty sir [12:38] rick_h__: r=me [12:38] adeuring: ty === almaisan-away is now known as al-maisan [13:21] adeuring: could you please have a look at https://code.launchpad.net/~rvb/launchpad/builders-timeout-903827/+merge/86029 ? [13:22] rvba: sure [13:22] thx === matsubara_ is now known as matsubara [13:35] rvba: in line 112/113 of the diff, a loop can be terminated early. Is this correct, or "return" be replaced with a "continue"? [13:35] good spot adeuring, it needs to be a "continue". [13:36] * rvba fixes it. [13:36] rvba: cool, thanks! [14:00] rvba: very nice branch, r=me [14:00] adeuring: ping, hey I had a MP that was approved and went into QA. [14:00] rick_h__: yes? [14:00] adeuring: in QA found an issue, so marked it qa-bad [14:00] Thanks a lot adeuring. [14:01] adeuring: so now that I've pushed a fix, do I run a new MP? update the old one that's already marked 'merged'? [14:01] rick_h__: A new MP is fine, I think [14:02] adeuring: ok, thanks [14:11] adeuring: ok, we're going to keep you busy this morning :) https://code.launchpad.net/~rharding/launchpad/link_tags_894726/+merge/86045 [14:11] adeuring: when you get a second please [14:11] rick_h__: sure, I'll you ;) [14:19] rick_h__: r=me [14:19] adeuring: ty [14:45] rick_h__: if you can qa revision 14526, we can roll-out a bunch of issues for the new custom bugs listing [14:45] rick_h__: sorry, i just saw that it was marked bad [14:45] rick_h__: it needs a rollback? [14:46] flacoste: yes sorry, I've got a second MP landing that fixes it [14:46] ok, we should roll-out 14525 then [14:46] as it fixes an annoying bug [14:46] and we won't be able to roll-out your change today [14:46] anyway [14:47] flacoste: ok, looking, is 14525 the chrome bug? [14:47] rick_h__: no, it's the sort buttons for advanced search sort order [14:48] flacoste: ah ok. We'll want to get the chrome bug fix rolled out asap as well since it breaks it for all chrome users [14:48] rick_h__: is it landed yet? [14:48] flacoste: was going to bring it up on the stand up but deryck is behind. [14:49] flacoste: no, in process of going through ec2 land [14:49] rick_h__: that will be deployed next week then [14:49] flacoste: bug just came up a few hours ago [14:49] as until the rollback/fix of 14526 is blessed, we can't roll anything after it [14:49] https://bugs.launchpad.net/launchpad/+bug/905228 [14:49] <_mup_> Bug #905228: Cannot use pagination links on bug listings < https://launchpad.net/bugs/905228 > [14:49] and it's not going to be blessed until this afternoon [14:49] which is too late for deployment [14:50] flacoste: ok [14:50] rick_h__: why is it bad? (there is no comment on the bug) [14:51] flacoste: the JS is broken for all chrome users so no paging/sorting can occur [14:51] it's the same issue we had a couple of weeks ago that we paused the beta for [14:51] ah ok [14:54] rick_h__: just that to clarify, the "chrome bug fix rolled out asap" you were talking, it's the problem with your qa-bad revision? [14:54] no [14:55] flacoste: seperate issues [14:55] ah, ok [14:55] so there is an existing chrome issue live in prod now [14:55] flacoste: I was more thinking since we'll have to roll out the chrome issue my qa-bad might get fixed in a hurry anyway since they're landing so close together hopefully [14:56] right [14:56] but given the delays with buildbot [14:56] flacoste: yes, in prod now [14:56] we won't be able to deploy today [14:56] flacoste: ok [14:56] because we don't deploy on Friday late afternoon, when everybody is going away [14:56] flacoste: understand, still learning the schedules and such...and I completely forgot today is fridayu [14:57] i guess that's a good thing ;-) [14:57] well groggy morning when I see my bad qa issue, broken js on production, so been a bit hectic this morning fixing things :) [15:14] sinzui, There are currently two Person/EmailAddress combos in the production DB where Person.account and EmailAddress.account don't match. I want to make this problem go away before landing my constraint patch to prevent it from happening again. Which should I use as the canonical source for .account? EmailAddress.account or Person.account? [15:14] (Sodomy non sapiens is a valid answer here) [15:18] is that the gmb translation of bugger off? [15:18] bigjools, Means I'm buggered if I know :) [15:18] (In pig latin) [15:18] adeuring: I could use review of https://code.launchpad.net/~cjwatson/launchpad/weaken-xz-dpkg-requirement/+merge/86056 and https://code.launchpad.net/~cjwatson/launchpad/background-scandium/+merge/86058, if you get a chance [15:19] (actually I have six branches in the review queue at the moment but those are the two most urgent ...) [15:19] cjwatson: I'll look [15:19] thanks [15:21] gah, I suck today. adeuring, rick_h__ Hi! Standup in 10 ok? [15:21] deryck: ok [15:21] deryck: we've got a checkpoint call at 11? is that CST? [15:22] rick_h__, I thought it was 10 CST. [15:23] deryck: nvm...stand up "in 10" not at "10" [15:23] rick_h__, right :) [15:23] deryck: ignore me...all good [15:23] ok [15:35] rick_h__, http://lpqateam.canonical.com/qa-reports/deployment-stable.html [15:36] hi benji, can I bug you about lazr.restful, I've got some hassles [15:36] rick_h__, https://dev.launchpad.net/QA/ [15:36] bigjools: sure, what's up? [15:37] benji: thanks! I am amending an existing method, IArchive.getAllPublishedBinaries() and noticed that its tests are specifically using "beta" [15:37] I am adding a new parameter, which ought to be "devel" [15:39] benji: is it supposed to default to devel? [15:39] the tests don't pass if they use it [15:39] and there's no explicit declaration in the interface [15:41] we've tried to transition away from defaults, I don't remember what the default is now, if it's even possible to have a default; I think most have an explicit version [15:41] let me see if I can find one for that [15:42] bigjools: I think line 715 of lib/canonical/launchpad/interfaces/_schema_circular_imports.py is where the beta is coming from [15:43] ! [15:43] that explains a lot [15:45] benji: I want to do something like this http://pastebin.ubuntu.com/772320/ [15:45] mrevell, just me and rick_h__ joining for Orange for the upcoming checkpoint. [15:45] thanks deryck [15:46] benji: and declare two signatures, one for beta and one for devel [15:46] someone recently added a new one to "beta" which I think is wrong [15:47] bigjools: "a new one" being "signature"? If it has a default, then it might not be totally wrong, but I agree that not touching beta would be more hygenic. [15:47] benji: sorry I meant a new parameter [15:48] it's tainted beta, it needs to be on devel [15:48] I guess it doesn't *really* matter, but ... [15:48] then your approach sounds perfect [15:49] benji: do you know why schema_circular_imports.py has got that line it it when we have decorators@ [15:49] ? [15:50] I can remove it from circ_imports anyway, and do it in the decorators [15:54] bigjools: since we were bad about using as_of (and it might not have even existed in early versions of lazr.restful, I can't remember), that line sets the default for the entry. as_of is preferred now and the patch_entry_explicit_version call could be removed if all the methods were given explicit versions [15:54] benji: ah makes sense, thanks [15:56] mrevell, flacoste -- high and criticals for the feature: http://tinyurl.com/79opoad [15:57] Just FYI for the checkpoint [15:57] thanks deryck [16:00] flacoste, deryck, rick_h__, danhg, matsubara: I'm about to start the Skype conference. [16:01] firing up Skype now [16:01] mrevell: go ahead [16:01] mrevell, i'm online [16:01] gmb, sorry, I did not see your question. I think the email address must honour the account to get a proper login. [16:01] cjwatson: r=me (both MPs) [16:02] adeuring: thanks! I'm not in ~launchpad - would you be able to send them to EC2 for me? [16:02] cjwatson: sure [16:02] ta [16:03] sinzui: Ah, perfect. Thankyou. [16:03] mrevell, can you send a link to the bug listing? [16:03] https://bugs.launchpad.net/launchpad/+bugs?field.searchtext=&orderby=-importance&search=Search&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=FIXCOMMITTED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.importance%3Alist=CRITICAL&field.importance%3Alist=HIGH&assignee_option=any&f [16:03] ield.assignee=&field.bug_reporter=&field.bug_commenter=&field.subscriber=&field.structural_subscriber=&field.tag=bug-columns&field.tags_combinator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.h [16:04] as_no_blueprints.used=&field.has_no_blueprints=on [16:04] Oh, I have no sound from IRC, that is why I missed the message [16:04] * sinzui fixes sound [16:11] adeuring, the beta banner will go away magically when we turn the flag on for "default" right? (i.e. for everyone) [16:11] deryck: yes [16:11] adeuring, ok, thanks [16:13] benji: one more problem! all my tests work apart from the ones specifying the beta api, which complain that there's no IEntry for the beta version. Do you know how I can work around this? I tried removing the as_of but it complains it's required. [16:14] bigjools: is that with or without the patch_entry_explicit_version call? [16:14] benji: same either way [16:14] I removed it in favour of as_of [16:15] but was the same before [16:15] adeuring: I've got two tiny MP up for reviews if you still have time: https://code.launchpad.net/~rvb/launchpad/builder-history-bug-890326/+merge/86050 https://code.launchpad.net/~rvb/launchpad/builder-history-lfa/+merge/86071 [16:15] rvba: sure [16:15] are "my tests" new tests? [16:16] benji: nearly, one of them is new, one of them I moved from beta to devel [16:16] adeuring: ta [16:16] the one left using beta is failing [16:17] hmm, it sounds like something (the IArchive entry itself maybe?) isn't represented in the beta version any more [16:17] maybe a diff would help me [16:18] that's what I figured too. I thought I'd ask in case it's a bug [16:18] sure, one sec [16:19] benji: partial diff: http://pastebin.ubuntu.com/772367/ and the whole branch is here: lp:~julian-edwards/launchpad/unordered-getpubbin-bug-904344 === salgado is now known as salgado-lunch [16:29] bigjools: I can't see anything wrong with the diff. I'll try building the branch. What test invocation will show the failures? [16:30] benji: bin/test -cvv test_archive_webservice TestgetPublishedBinaries [16:30] thanks for looking [16:30] np === salgado-lunch is now known as salgado === al-maisan is now known as almaisan-away [16:37] rvba: r=me * 2 [16:37] Thanks adeuring. [16:41] bigjools, could you answer https://answers.launchpad.net/launchpad/+question/182085 or tell me how to? [16:42] gary_poster: yup, let me loolk [16:42] thank you [16:43] gary_poster: hmm that was affecting bzr earlier too [16:43] bigjools: heh, those tests pass for me [16:43] benji: argh! [16:43] I'll rebuild the wadl [16:43] bigjools, ok I'll check with him to see if it still a problem [16:44] gary_poster: I answered already [16:44] cool thanks bigjools [16:44] np [16:49] benji: it still fails here.... this is weird [16:49] bigjools: maybe try a fresh checkout/build? [16:50] benji: did you merge my diff? [16:50] it's not pushed up [16:50] bigjools: nope, just checked out the branch; oh!, that's probably it [16:51] * benji patches. [16:51] I am not going mad then.... well just a bit [16:52] benji: ah it complains at the wadl-making stage [16:57] adeuring, can you comment on https://code.launchpad.net/~deryck/launchpad/avoid-extra-buglist-count-901124/+merge/85940 before you EOD? [16:57] deryck: ah, sure, sorry, I forgot... [16:58] np [17:21] bigjools: I've found that if I remove the self.ws_version = 'beta' line from test_getPublishedBinaries, it passes [17:22] benji: did you re-generate the wadl? [17:22] nope, let me try again after doing that [17:22] it passes because it's in devel [17:22] * bigjools wonders how IHasBugs does this [17:24] it has the same thing I am doing here [17:26] bigjools: I get an UnknownEntryAdapter, which is probably what you get [17:26] benji: yup [17:26] bigjools: the "Encountered as a result of the entry interface None, field ''." bit looks funny [17:26] benji: I wonder if it's the @operation_returns_collection_of(Interface) [17:26] being in two entries? [17:27] [17:27] lib/lp/bugs/interfaces/bugtarget.py / IHasBugs is doing this exact same thing. I must be missing something but .... trees for woods :( [17:32] bigjools: I really need to get some lunch, but I think the "interface None, field ''" thing is a clue; maybe one of the Interface references isn't being correctly patch to the right interface in a circular import module [17:32] benji: yes, I suspect it's to do with the multiple versions as well === adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugtasks: 3*10^2 [17:32] thanks for your help so far === salgado is now known as salgado-lunch [18:05] Night all === salgado-lunch is now known as salgado === matsubara is now known as matsubara-afk [20:46] hi folks