=== M0hi is now known as IAmNotThatGuy === yofel_ is now known as yofel [08:33] morning === pedronis__ is now known as pedronis [12:18] good morning! [12:19] ralsina, good morning! [12:19] hello gatox [12:20] ralsina, how are you? how do you spend your weekend? relaxing? [12:20] I slept! [12:21] Actually deactivated the alarm! [12:22] jeje good! [13:07] need to restart [13:15] back [13:44] brb [14:21] buenos días! [14:22] nessita, buenas [14:22] downtown is crazy today, I had to run some errands and that took more than expected [14:23] buenas nessita [14:23] hola dobey [14:41] nessita: should we bug ralsina? or after standup? [14:44] dobey: after standup? so we can all organize [14:44] ralsina: can we have a talk with dobey about stable/trunk relationship after standup? [14:45] nessita: sure [14:48] big TODO list today [14:50] nessita: do we need an MIR for qt4reactor btw? [14:51] dobey: nopes, wanna do it? :-) [14:51] nessita: i think you misread the question? i asked if we need one, not if we have one :) [14:52] dobey: ah yes, I misread. Yes, I think we need one, since we want our qt packages on the main repo along with the rest [14:53] nessita: but control panel doesn't use qt4reactor does it, except for tests? [14:53] dobey: nopes, the qt controlpanel uses it to run. And so will use it the qt sso dialog. [14:54] i thought it used the plain twisted reactor [14:54] in the backend, and the gui doesn't use a reactor [14:55] dobey: the qt version does not access the backend thru dbus, it just imports it and use it. And to "mix" a twisted reactor and qt, we use at4reactor [14:55] qt* [14:55] oh, ugh [14:55] so the deps are all wrong [14:57] dobey: FYI, I just confirm the qt controlpanel works (but yes, I have all the needed deps already installed) [15:00] me [15:00] me [15:01] nessita: everything works right and it's not broken at all? [15:01] me [15:01] dobey: in my env, yes [15:01] dobey: but again, I have all the needed deps because I develop here [15:01] ralsina: standup? [15:02] DONE: started fixing all the test suites for bug #834730 [15:02] TODO: try to finish the aforementioned bug, talk with dobey and ralsina re: stable-vs-trunk, teach leads call [15:02] BLOCKED: nopes [15:02] NEXT: gatox [15:02] Launchpad bug 834730 in ubuntuone-client (and 1 other project) "Use SignalBroadcaster and RemoteMeta from ubuntu sso client (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/834730 [15:02] DONE: [15:02] Figure it out how to solve the windows shortcut problem, modify make_link in u1-client. [15:02] TODO: [15:02] Fix 4 broken tests, add some tests to check the link creation. [15:02] BLOCKED: [15:02] No [15:02] dobey, go [15:02] λ DONE: hack day, dirspec initial code for xdg base dirs spec [15:02] λ TODO: discuss stable v trunk, call congress, expenses, dirspec nightlies, make devtools use dirspec, some initial music store fixups for P, backport some stuff to stable-3-0 branches, release prep, fixes in gireactor for twisted review [15:02] λ BLCK: No. [15:02] ralsina [15:03] nessita: with or without -gtk installed? [15:03] DONE: vacation, windows release. TODO: arrange hiring interviews, tech leads call, XML file for autoupdate,talk with nessita&dobey BLOCKED: nopes [15:03] dobey: with [15:03] nessita: can you try without please? [15:03] dobey: sure [15:03] any comments anyone? [15:03] nop [15:03] no comments [15:04] ok, eom! [15:04] ralsina, dobey, shall we mumble? or do you guys prefer something else? [15:04] * gatox lunch === gatox is now known as gatox_lunch [15:04] i like irc; but whatever is fine [15:05] either works for me [15:06] nessita: pick [15:09] oops, net issues === nessita1 is now known as nessita [15:09] nessita: you pick :) [15:09] dobey: mumble, so we expedite the thing :-) [15:10] ok [15:10] you better not have net issues ;) === gatox_lunch is now known as gatox [15:56] nessita, ralsina: can you review https://code.launchpad.net/~dobey/dirspec/add-tests/+merge/86130 please? :) [15:57] dobey: sure! [16:00] dobey: on it! [16:38] alright, need to get lunch; bbiab [17:27] brb [17:39] lunchtime! [18:05] dobey: is dirspec meant to be used in windows as well? [18:07] nessita: yes [18:08] nessita: and it should work in windows, as-is [18:09] dobey: tests are not running for me... [18:09] C:\Python27\\python.exe: can't open file 'C:\Python27\\Scripts\trial': [Errno 2] [18:09] No such file or directory [18:09] dobey: I do have a trial.py in Scripts [18:09] ah [18:10] nessita: ok, i didn't know that it wasn't just "trial" on windows [18:10] i'll fix that [18:10] dobey: now, if I change the run-tests.bat to use trial.py, no failure but no test is ran [18:11] dobey: http://pastebin.ubuntu.com/775539/ [18:11] huh [18:12] nessita: what version of twisted is this btw? [18:12] dobey: let me confirm [18:12] dobey: 11.0.0 [18:13] weird [18:15] nessita: how do you set the python include path on windows? (ie PYTHONPATH=. on linux) [18:15] dobey: set PYTHONPATH-. [18:15] sorry [18:15] set PYTHONPATH=. [18:15] dobey: which I did not run on this branch :-) good catch! [18:16] nessita: well %PYTHONPATH% in run-tests.bat is that path to where python is installed, afaict, so i guess we can't just set it to that? [18:16] dobey: right, I just set it by hand and test ran [18:16] (and we set it by hand to every project) [18:16] so we can't set it inside run-tests.bat? [18:17] dobey: well, we usually set the env with other name, PYTHONPATH is not the happiest name [18:17] it should be PYTHON_EXEC_PATH [18:17] or something like that [18:17] nessita: you mean what is currently in run-tests.bat should be that instead? [18:18] dobey: yes, see for example the run-tests.bar of ussoc [18:19] it's weird that trial behaves different on windows than on linux though :-/ === nessita1 is now known as nessita [18:22] nessita: so change that to PYTHONEXECPATH and add SET PYTHONPATH=. in run-tests.bat should work? [18:22] dobey: yeap, plus using trial.py [18:22] right [18:23] dobey: you use trial and not u1trial to not depend on udevtoools, right? [18:24] right, to avoid the circular dep, since devtools will need to depend on dirspec [18:25] also why i'm running pyflakes instead of u1lint [18:25] it /is/ just "pyflakes" on windows right? not pyflakes.py or .exe or something? [18:26] dobey: yes, just pyflakes [18:27] yay [18:27] nessita: pushed the fix; can you update and try run-tests.bat without adding to the env yourself? :) [18:29] dobey: of curse [18:29] dobey: but give a couple of minutes [18:29] nessita: sure; thanks for testing it on windows :) [18:30] :-) [18:40] dobey: this is what I'm getting now http://pastebin.ubuntu.com/775566/ [18:41] and I do have a python installed, under C:\Python27 [18:41] nessita: humm; did i screw up the s/PYTHONPATH/PYTHONEXECPATH/g bit somehow? [18:42] ah, yes i missed a bit [18:43] dobey: the wow thingy? [18:43] nessita: fixed/pushed [18:44] nessita: the bit that checks the registry key was setting PYTHONPATH still [18:44] nessita: fixed it to be PYTHONEXECPATH also [18:44] ah [18:45] so should work now :) [18:53] testing [18:56] dobey: unseting the PYTHONPATH on the terminal before running the suite ends up in no test being run [18:57] nessita: :( [18:57] nessita: run-tests.bat has SET PYTHONPATH=.; so it should work afaik [18:58] does it have to be quoted? [18:58] dobey: honestly, no idea :-/ [18:58] dobey: weren't you a windows dev? :-P [18:58] no :) [18:59] nessita: well you have to set it before doing run-tests.bat for all the other projects right? [18:59] dobey: yeap [18:59] nessita: so i say let's figure it out later :) [18:59] dobey: +1 [19:00] need to get it packaged up and in ubuntu with the releases tomorrow [19:01] nessita: all the tests pass without skipping any, on windows, right? [19:01] dobey: yesir [19:02] then i am very happy with the current state of dirspec, with that branch :) [19:02] No, doesn't need to be quoted [19:02] dobey: nice! [19:02] dobey: question, how shall I use bzr to merge trunk into stable but without a specific commit? [19:03] mostly, on windows, you have to set PYTHONPATH maually for all the other projects too [19:03] only one of the tests actually needs windows; and we just skip it on ubuntu :) [19:03] nessita: you can specify a range of commits with -r [19:04] dobey: and so I need to do 2 merges, right? [19:04] nessita: for? [19:04] you can do -r 1..3,5 to skip 4, i think [19:04] dobey: ah! [19:05] bzr revision specs can be quite complicated [19:05] bzr help revspec iirc [19:06] or not [19:06] oh, but 1..3 doesn't include 1 [19:07] oh, but it might screw up the history [19:09] dobey: so? :-D [19:09] dobey: I'm lost what I should run [19:10] nessita: finish the review of the dirspec branch, and i'll help you with the specifics [19:11] dobey: you're not choosing your battles wisely :-P [19:12] i just set up nightlies recipe for dirspec and it would be nice to have it building in the background :) [19:13] blah i don't even know who my congress people are :-/ [19:19] dobey: review finished [19:21] bah :( [19:22] oh well, so what are you trying to merge from trunk to stable exactly? [19:23] dobey: to start with the stable-3-0 process, I'm updating ussoc. My idea is to have everything except the revno 821 [19:23] dobey: which brokes sso linux [19:23] I checked the rest [19:26] so nightlies are broken on linux? [19:26] dobey: yes for a specific (and not common) use case [19:26] dobey: I'm working on a fix, will not be ready before tomorrow [19:30] dobey: bzr merge -r 813..820,821..824 lp:ubuntu-sso-client definitely does not work [19:30] (nor bzr merge -r 813..820,822..824 lp:ubuntu-sso-client) [19:31] * nessita will try 2-step update [19:32] for some reason it is merging r821 anyway [19:33] you don't want r814 included [19:33] there's already a separate commit for that in stable-3-0 [19:33] dobey: you're right [19:33] also, for some reason it seems to be pulling in the different setup.py :( [19:33] dobey: is not doing that for me... [19:33] dobey: what difference do you see? [19:34] bzr merge -r 814..820,822..824 shows a conflict in setup.py, and bzr st -v shows r 821 included [19:34] dobey: the conflict is easy, is the version number (as you predicted) [19:35] hrmm [19:35] i don't think bzr likes M,N [19:36] dobey: I'm doing two merges, and presto [19:36] if you do 814..820 [19:36] commit, then do 821..824, i think it works ok [19:36] dobey: indeed [19:36] and doesn't pull in the setup.py change either [19:37] make sure 821 doesn't show up in the second merge though, by checkint bzr st -v [19:38] since it likes to collapses the messages it seems [19:38] hrmm, actually it seems like it may not even keep the history in that case [19:39] blah [19:39] oh well [19:41] dobey: so, -r 821..824 does bring 821 :-/, so I had to do 822..824 [19:41] I checked the diff against trunk and is correct [19:41] huh [19:41] the only missing bits are the 821 revno [19:41] 821..824 shouldn't. i guess the docs are wrong in bzr :( [19:42] dobey: right (I read the same as you) [19:47] nessita, ping [19:47] gatox: pong [19:47] nessita, can you do me a favor? [19:47] nessita: is __setitem__ better to use than just set? [19:48] nessita, can you open volume_manager in u1/syncdaemon/volume_manager [19:48] nessita: or using a lambda instead perhaps? [19:48] nessita, line 1495...... _guess_metadata_version and tell me if that IF has sense to you? [19:48] dobey: I personally prefer __setitem__, the cleaner solution is using operator [19:49] dobey: from operator import setiten [19:49] setitem* [19:49] dobey: so, the addCleanup would be: [19:49] self.addCleanup(setitem, os.environ, var_name, old_value) [19:49] gatox: looking [19:51] gatox: yes, it does make sense. Some migration happens from user not having that dir [19:51] gatox: why? [19:51] nessita, this is what i see: [19:51] if path_exists(self._shares_md_dir) \ [19:51] and path_exists(self._shared_md_dir): [19:51] ahhhhhhhhhhhhhhhhh [19:51] gatox: me too [19:51] :P [19:51] shares..... shared [19:51] not so good at this hour [19:51] gatox: ah, yes, that too (yes is confusing) [19:52] sorry [19:52] is ok :-) [19:53] ralsina, dobey: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/stable-3-0-update/+merge/86283 [19:54] nessita: I won't finish that review today... [19:55] ralsina: is there any chance you do it later today or tom morning? [19:55] tomorrow morning sure [19:55] ralsina: so we can release tomorrow. It does not need to be a code review in detail, since all that code has been reviewed already [19:55] I can try to do a IRL test at least [19:55] ralsina: yes please, on windows ideally (I made it on Ubuntu) [19:56] nessita: ack, I'll have it done before beginning of workday tomorrow [19:57] nessita: canonical e-mail addresses [19:57] i will yell at mandel tomorrow :) [19:57] dobey: ok, I'll change it in the MP [19:58] i wish bzr handled history properly [19:59] meh, i also have to review mandel's devtools branch still :( [19:59] it makes me sad [20:00] dobey: cheer up, you learnt about operator today :-) (when I did I was thrilled!) [20:00] nessita: can you give me a really really trivial review here? https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/quote_autostart/+merge/84952 [20:00] ralsina: looking [20:01] nessita: just in case, that did get a IRL test from QA as part of the latest release [20:01] ralsina: well, that branch is not exactly trunk [20:01] ralsina: I can not merge a branch from gatox that breaks linux when user is not validated [20:01] nessita: I mean my little branch ;-) [20:01] ralsina: ah! [20:02] nessita, sorry...... which branch? [20:03] gatox: the change you made to user_validated_cb (I already mentioned this, so nothing new) [20:03] nessita, ah yes...... [20:03] gatox: but we can't release that to Ubuntu [20:10] ok....... eod for me! see you tomorrow [20:11] ralsina: approved [20:11] nessita: cool, thx [20:11] nessita: I am leaving the stable branch syncing, will eod and give the review late tonight [20:13] nessita: refactored the environment modifying tests [20:29] dobey: ack. [20:46] dobey: tweak_env looks great, and replied to your comment [20:50] ralsina, dobey: https://code.launchpad.net/~nataliabidart/ubuntuone-client/stable-3-0-update/+merge/86289 (test pass on all OS, IRL tested on Ubuntu) [20:53] ralsina, dobey: MP resubmitted, I did not choose stable-3-0 as target https://code.launchpad.net/~nataliabidart/ubuntuone-client/stable-3-0-update/+merge/86294 [21:06] ah ok [21:07] oh, other project [21:07] dobey: hum? [21:07] i didn't realize you did one for u1client also [21:09] dobey: yes, and I'm about to have the controlpanel one [21:10] bah it's already 16:10 :( [21:12] dobey: still 2 more hours to go! :-) [21:13] what? [21:17] dobey: right, from 9am to 6pm [21:17] no? [21:18] 9+8 = 17 [21:24] dobey: as far as I was told, we work from 9am to 6 pm having one hour~ for lunch [21:26] gah, stupid congressional contact web forms; why do they all require a stupid prefix [21:26] i think i will put "GOD" as my prefix [21:27] hrmm, i guess i am not getting my truck back today either [21:27] meh [21:29] dobey: one more... when you can: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/stable-3-0-update/+merge/86296 [21:35] dobey: last one, at least for today: https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/stable-3-0-update/+merge/86297 [21:36] a bunch of the windows fixes also need backported to stable-2-0 don't they? [21:36] (in all the projects that is) [21:41] dobey: yeap -- but since on Feb we'll try to have stable-3-0 on stable-2-0, that will do it [21:49] bye all! be back later [21:54] … [22:15] dobey, still here? [22:16] hi mandel [22:18] mandel: how long is the train from madrid to malaga? :) [22:19] dobey, hm.. depends on which train you take, if the speed train goes there, 2 hours else 4 or something like that, why? [22:19] mandel: was pondering this: http://gstreamer.freedesktop.org/wiki/GStreamerHackfest2012 [22:19] dobey, if that was the reason why you wanted to yell at me, I'm happy :) [22:20] dobey, hm.. that is super tempting! [22:20] no; i wanted to yell at you because apparently you used your personal e-mail in some commits :) [22:20] dobey, oh, bullocks!!! where? [22:21] http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntu-sso-client/trunk/revision/816.2.13 [22:22] http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntu-sso-client/trunk/revision/816.1.1 [22:22] dobey, hm... I know that was the email I used to use when I was out from canonical.. [22:22] yes [22:23] dobey, maybe the machine I used is badly configured... is there a way I can help you with thaT? [22:23] ups, capital T :P [22:23] mandel: and your devtools branch [22:23] mandel: i don't think it's easy to go through and edit all the commits; but you can fix your config so you use your canonical e-mail on the canonical projects :) [22:24] dobey, certainly!!! sorry for that, I guess I used the desktop to edit those.. sorry :( [22:24] dobey, did anything interesting happened today? [22:25] mandel: for instance, i have this in my ~/.bzr/locations.conf : https://pastebin.canonical.com/57413/ [22:25] mandel: and i manage all the canonical projects under ~/Projects/canonical/ :) [22:25] makes things easy [22:26] nothing particularly interesting, no [22:26] dobey, I have the same, a ~/Projects/Canonical, I guess that I screwed up on of the machines at some point and did not notice.. [22:26] i totally failed to get all the things done today, that i wanted to do, and really need to get done for tomorrow, though :( [22:27] dobey, ok, I'll be working tom so if you need any help let me know and I do my best (for example, fixing my desktop bzr config :P ) [22:28] dobey, and regarding malaga, if you go, I'll join you :) [22:28] dobey, and you are more than welcome to spend some day here in madrid :) [22:29] i probably won't go [22:29] am a bit tired of travel, at the moment :) [22:29] dobey, ha, tell me about it! [22:30] ugh, and i'm pretty tired in general right now [22:31] dobey, well, I'm going to bed, I just opened this to check if anything bad/good happened, I'll see you tom here (its 11:30 pm CET :P) [22:33] buenos noches [22:35] dobey, good night to you too :) [22:35] * mandel watches tv [23:05] need to get some food