| wallyworld_ | huwshimi: you 100% sure we can't use another colour besides grey for the links? since we use grey for disabled links elsewhere, users will be confused and assume these links are also disabled | 00:54 |
|---|---|---|
| huwshimi | wallyworld_: Where do we use grey for disabled links? | 00:55 |
| huwshimi | we use grey for our breadcrumb links | 00:55 |
| wallyworld_ | huwshimi: one example, if one enters text for a comment comment or elsewhere, and the text contains "bug xxx", the "bug xxx" is linked and if it is not a valid link, is rendered grey | 00:56 |
| wallyworld_ | s/comment comment/bug comment | 00:56 |
| wallyworld_ | the breadcrumbs are sort of self contained, not mixed in with general content | 00:57 |
| wallyworld_ | but if there's no good alternative..... | 00:57 |
| huwshimi | hmmm... I can't reproduce the bug comment links in .dev | 00:58 |
| wallyworld_ | a very light blue perhaps? like the tags that are rendered in the bug details page? | 00:58 |
| wallyworld_ | ah, ok. you mention light blue looks like disabled | 00:59 |
| wallyworld_ | huwshimi: i'll find an example on qas | 00:59 |
| huwshimi | wallyworld_: cheers :) | 00:59 |
| wallyworld_ | it is a light shade of grey btw | 01:00 |
| wallyworld_ | huwshimi: https://bugs.qastaging.launchpad.net/ubuntu/+source/aptdaemon/+bug/696954 | 01:02 |
| _mup_ | Bug #696954: Maintainers cannot specify who is in an access policy <disclosure> <Launchpad itself:Triaged> < https://launchpad.net/bugs/696954 > | 01:02 |
| wallyworld_ | huwshimi: i thought i entered a valid bug for one example, but it is also invalid | 01:02 |
| wallyworld_ | huwshimi: the valid links are the same shade of blue as the other links | 01:02 |
| wallyworld_ | huwshimi: brb | 01:03 |
| huwshimi | np | 01:03 |
| huwshimi | Oh I see they only become grey links after a page refresh | 01:05 |
| wallyworld_ | huwshimi: yes, there's a background call which does the validity checking. the fact that it doesn't run when a comment is first entered is a bug | 01:11 |
| huwshimi | wallyworld_: Ah I see | 01:11 |
| wallyworld_ | which i only just realised happens | 01:12 |
| * wallyworld_ files a bug | 01:12 | |
| wallyworld_ | huwshimi: if i recall correctly, there's a css style for disabled links which is used | 01:12 |
| wallyworld_ | and the style specifies that shade of grey | 01:13 |
| huwshimi | wallyworld_: I'm inclined to land this with the links this colour and wait to see if there's feedback. | 01:19 |
| wallyworld_ | huwshimi: ok. sorry to be a pain rtc. i wanted to be sure we did want to go with those colours given the potential for confusion | 01:20 |
| huwshimi | wallyworld_: No that's ok. I understand where you're coming from, but I think this might be the best option for now | 01:21 |
| wallyworld_ | huwshimi: r=me :-) | 01:23 |
| huwshimi | wallyworld_: Cheers mate | 01:23 |
| wallyworld_ | np. how was the cricket? | 01:23 |
| poolie | huwshimi, wallyworld_, re grey links, fwiw | 01:24 |
| wallyworld_ | hi poolie | 01:24 |
| poolie | 1- other people use them and it's fine; i don't think there is a general style that they have to be blue or underlined anymore (though generally a hover of some kind is good) | 01:24 |
| poolie | 2- ideally i think we would be steering towards a new general style (i guess you are) rather than doing it one by one | 01:25 |
| huwshimi | wallyworld_: It was great fun, nice to have a second win too, | 01:25 |
| wallyworld_ | poolie: point 2 holds a bit of sway with me. i personally would like to see a consistent colour for disabled across the board, so a user never has to guess if a link is active or not depending on the context | 01:26 |
| wallyworld_ | which is sort of what they need to do now | 01:26 |
| wgrant | huwshimi: The bug listings are now arranged pretty strangely: http://people.canonical.com/~wgrant/launchpad/misarranged.png | 01:29 |
| huwshimi | wgrant: Yeah, there's some issues there with consistent column widths | 01:31 |
| wgrant | huwshimi: It also looks like the vertical text alignment in the status/importance labels is off now. | 01:33 |
| wgrant | I thought it used to be centered, but now the text is too high. | 01:33 |
| huwshimi | wgrant: Are you using Firefox? | 01:34 |
| wgrant | huwshimi: Yeah, this is Precise's Firefox. | 01:34 |
| wgrant | Some 9.0 prerelease. | 01:34 |
| huwshimi | wgrant: In Chromium the text is actually too close to the bottom :) | 01:34 |
| wgrant | Yay :) | 01:34 |
| micahg | 9.0 beta 6 in precise, 10.0 beta 1 will come soon | 01:36 |
| wgrant | huwshimi: Heh, so it is. | 01:36 |
| huwshimi | wgrant: I love web typography | 01:36 |
| cjwatson | and Tags is about a pixel lower than the bug title text in that screenshot | 01:36 |
| poolie | wallyworld_, i agree, a consistent style for 'disabled' would be nice | 01:51 |
| poolie | i think they can both be grey as long as the intensity is markedly different | 01:51 |
| wallyworld_ | which they are | 01:51 |
| wallyworld_ | disabled is a lighter shade | 01:51 |
| wallyworld_ | poolie: it seems that a feature flag i'm trying to use in a test via "with FeatureFixture(xxxx)" isn't being found when I try and access it from inside a zope security adaptor. have you come across this before? | 03:14 |
| poolie | wallyworld_, ah, i can believe you but i don't have an easy answer sorry | 03:15 |
| poolie | i don't understand the zope magic enormously well | 03:15 |
| wallyworld_ | np | 03:15 |
| poolie | suggest you thrash around until it works, then document that | 03:15 |
| poolie | :} | 03:15 |
| wallyworld_ | yeah, i've been thrashing alright. more like drowning | 03:15 |
| wallyworld_ | poolie: found it. i am a dickhead. cut'n'paste error. one char difference | 03:24 |
| * StevenK ponders quoting wallyworld_'s first two sentences out of context. | 03:33 | |
| wallyworld_ | StevenK: lol | 03:33 |
| wgrant | Hm | 04:49 |
| wgrant | I think jtv's megalint and sinzui's apocalypse have conflicted. | 04:49 |
| StevenK | What did sinzui apocalypse? | 04:50 |
| wgrant | interfaces and scripts | 04:50 |
| wgrant | jtv reordered lots of imports. | 04:50 |
| wgrant | Some of which sinzui moved. | 04:50 |
| wgrant | and now the test suite complains on startup. | 04:50 |
| wgrant | Let' | 04:50 |
| wgrant | s see how bad it is. | 04:50 |
| wgrant | May just be the one import. | 04:51 |
| wgrant | And fixed. | 04:55 |
| wgrant | Hopefully buildbot hasn't finished recently. | 04:56 |
| StevenK | wgrant: It still has 90 minutes. | 05:11 |
| === lifeless_ is now known as lifeless | ||
| huwshimi | OK, that's EOY for me. Have a good Christmas/New Years everyone. | 06:35 |
| StevenK | huwshimi: You too! | 06:35 |
| Ursinha | can anyone explain why I can see a bug has 50 activities but trying to index them fails as out of range? | 07:46 |
| Ursinha | In [215]: len(lp.bugs[736661].activity) | 07:47 |
| Ursinha | Out[215]: 50 | 07:47 |
| Ursinha | In [216]: lp.bugs[736661].activity[0] | 07:47 |
| Ursinha | IndexError: list index out of range | 07:48 |
| wgrant | Ursinha: Interesting -- it works for me. | 07:50 |
| wgrant | I wonder if you have a broken cache. | 07:50 |
| wgrant | Which version of launchpadlib are you using? | 07:50 |
| Ursinha | wgrant: interesting thing is that is working for me as well -- problem was reported by someone else | 07:51 |
| wgrant | Hah | 07:51 |
| Ursinha | I wonder if he trying to do that anonymously changes that | 07:51 |
| Ursinha | it shouldn't, right? | 07:51 |
| wgrant | Ah. | 07:52 |
| wgrant | It should, but it often does. | 07:52 |
| Ursinha | hehe | 07:52 |
| Ursinha | why? | 07:52 |
| wgrant | 'tis a bug. | 07:52 |
| wgrant | Any authenticated user can see them. | 07:52 |
| wgrant | But anonymous ones cannot. | 07:52 |
| Ursinha | right | 07:52 |
| wgrant | Can you file a bug? | 07:52 |
| Ursinha | that's reported, I presume | 07:52 |
| Ursinha | ah, sure | 07:52 |
| Ursinha | :) | 07:52 |
| wgrant | Not that I know of. | 07:52 |
| wgrant | But we have had many similar situations. | 07:53 |
| Ursinha | I'll file a bug | 07:53 |
| Ursinha | thanks wgrant :) | 07:53 |
| wgrant | np | 07:53 |
| === almaisan-away is now known as al-maisan | ||
| bigjools | morning all | 09:14 |
| nigelb | Morning bigjools | 09:14 |
| StevenK | bigjools: Did you pick up Portal? :-) | 09:16 |
| bigjools | StevenK: no, not sure I will | 09:18 |
| bigjools | hmmm only 50 attemps to ssh into my server yesterday | 09:18 |
| bigjools | spammers are getting around fail2ban | 09:18 |
| nigelb | how long is your ban time? | 09:21 |
| nigelb | I used to have it as 24 hours :) | 09:21 |
| bigjools | default, whatever it is | 09:22 |
| * bigjools is fixing the db-devel conflict | 10:46 | |
| bigjools | now why does pqm say only one conflict when locally I get 132 | 10:51 |
| wgrant | bigjools: You're probably merging devel, rather than stable? | 10:55 |
| wgrant | (132!?!?!( | 10:55 |
| wgrant | ) | 10:55 |
| bigjools | nope | 11:10 |
| bigjools | can someone else try? | 11:10 |
| bigjools | down to 39 with --lca | 11:11 |
| bigjools | ok, out of date checkout it seems | 11:12 |
| bigjools | gah, 7 ".moved" conflicts | 11:13 |
| wgrant | Yeah, deleted dirs do that, because of all the pycs inside :/ | 11:14 |
| wgrant | It'll work better if you have clean trees. | 11:14 |
| bigjools | no, it's an added dir | 11:14 |
| bigjools | I use a checkout as a sandbox | 11:14 |
| StevenK | wgrant: I'm so tempted to patch rf-get to run 'make clean' before pulling | 12:06 |
| wgrant | That would be very slow... | 12:07 |
| bigjools | and I will shoot you | 12:36 |
| === al-maisan is now known as almaisan-away | ||
| rick_h__ | anyone able to review https://code.launchpad.net/~rharding/launchpad/back_sort_buttons_907376/+merge/86701 for me please? | 13:37 |
| rick_h__ | backing out fix for bug 907376 so I can refix :/ | 13:37 |
| _mup_ | Bug #907376: Order By Bar "buttons" do not appear on page load <bug-columns> <qa-bad> <regression> <Launchpad itself:Fix Committed by rharding> < https://launchpad.net/bugs/907376 > | 13:37 |
| gary_poster | Is anyone working on resolving db_devel? bigjools, you happen to know? If not I can try to do it before my next call | 14:18 |
| sinzui | gary_poster, I can fix the text conflict if you have not already. | 14:23 |
| gary_poster | sinzui, I just did a merge and was about to look at it. If you are farther along feel free | 14:23 |
| sinzui | I have done nothing. I expect import conflicts between jtv and the four horseman of the apocalypse | 14:24 |
| gary_poster | sinzui :-) ok I'll proceed and ask if I have questions. thank you | 14:25 |
| bigjools | gary_poster: I did it already | 14:34 |
| gary_poster | bigjools, :-P | 14:34 |
| gary_poster | ok that wasted time :-) thank you though | 14:34 |
| bigjools | gary_poster: however, PQM hated me | 14:34 |
| bigjools | argh | 14:35 |
| bigjools | gary_poster: did you submit anything yet? | 14:35 |
| bigjools | I messed up my commit line | 14:35 |
| flacoste | gary_poster, bac, gmb, danilos, benji: lp2kanban got some publicity: http://blog.leankitkanban.com/2011/12/leankit-kanban-api-wrappers/ | 15:34 |
| benji | cool | 15:35 |
| danilos | yeah, cool | 15:38 |
| bigjools | allenap: I can has review pls? https://code.launchpad.net/~julian-edwards/launchpad/get-incomplete-ppa-copy-jobs/+merge/86726 | 16:04 |
| allenap | bigjools: Sure. | 16:05 |
| bac | flacoste: yay | 16:27 |
| bigjools | jelmer: mind if I assign you a question about java memory limits when building recipes? | 17:48 |
| bigjools | actually I think the java bit is a red herring | 17:48 |
| jelmer | bigjools: can you perhaps link it to a bug? | 17:49 |
| bigjools | jelmer: sure, which one? | 17:49 |
| jelmer | bigjools: I suspect it's this one: bug 693524 | 17:49 |
| _mup_ | Bug #693524: Daily builds of Java packages fail: "Could not reserve enough space for object heap" <recipe> <Launchpad Auto Build System:Triaged> < https://launchpad.net/bugs/693524 > | 17:49 |
| bigjools | jelmer: https://answers.launchpad.net/launchpad/+question/182645 is the question | 17:49 |
| bigjools | thanks, I'll tell him to follow the bug | 17:50 |
| * deryck goes offline for lunch, back soon | 18:26 | |
| rick_h__ | deryck: if you get a sec can you let me know if I'm missing a step with the rollback? | 19:09 |
| deryck | rick_h__, sure, something makes you think you've missed a step? Or something not working? | 19:10 |
| rick_h__ | deryck: well it's just not updating and I ran the bzr lp-land --rollback=14569 this morning | 19:10 |
| rick_h__ | so before EOD wanted to make sure I was waiting on pqm and it's not waiting on me | 19:10 |
| deryck | rick_h__, what's not updating? the bug? | 19:10 |
| rick_h__ | deryck: right http://lpqateam.canonical.com/qa-reports/deployment-stable.html and the bug | 19:10 |
| rick_h__ | https://dev.launchpad.net/QA/QAForContinuousRollouts says that the bug should be updated and all qa-* tags removed | 19:11 |
| deryck | rick_h__, has it finished playing in buildnot yet? | 19:11 |
| rick_h__ | deryck: ah, problably not. I thought I had skipped that step | 19:11 |
| rick_h__ | deryck: but right, I only skipped my ec2 tests, not buildbot | 19:11 |
| deryck | rick_h__, no, you may have skipped ec2, but you still have to pass buildnot to get merged from devel to stable.... | 19:12 |
| deryck | rick_h__, once it merges to stable the bug will be updated. | 19:12 |
| rick_h__ | deryck: ok, I'll hold tight then. Thanks. | 19:12 |
| rick_h__ | deryck: diff topic, is there a good bit of JS code dealing with ajax that's a good template for testing/doing ajax stuff in our "way"? | 19:12 |
| deryck | rick_h__, well any of the order by bar or visible info widget stuff we just worked on is pretty typical. | 19:13 |
| rick_h__ | deryck: doh true. Was looking through app/javascript | 19:14 |
| deryck | rick_h__, heh, yeah, np. | 19:16 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
