[03:18] anyone around tonight? [03:18] could really use a review at https://code.launchpad.net/~rharding/launchpad/sort_buttons_907376_fix/+merge/86710 so I can start the landing process over night [03:19] it's basically the same as this with a fix https://code.launchpad.net/~rharding/launchpad/sort_buttons_907376 but I can't self review [04:58] lifeless: everything okay there after the quake? [05:02] what quake? was there another one? [05:03] oh, so there was :-( [05:08] Yeah :( [05:21] Yeah ;-( [05:21] s/;/:/ [05:29] at least it doesn't seem as bad as last time === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away [11:55] morning === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: bac | Firefighting: - | Critical bugtasks: 3*10^2 [14:40] allenap: writeToDatabaseAndCommit claims to return a token but doesn't. is the code wrong or the docstring? [14:41] bac: I'd better fix that. I don't think call-sites care about it, but it's worth getting it right. [14:48] allenap: good [14:49] Wait, you guys are working today? [14:49] nigelb: of course! [14:50] bac: I applaud your dedication! I hope Moday is off? [14:50] nigelb: yep [14:50] :) [14:51] yea, fun stuff [14:51] anyone seen lately that bzr pqm submit ignores the email in locations.conf? [14:55] rick_h__: which one? pqm has its own pqm_email [14:55] rick_h__: I haven't seen that :-/ I have: [14:55] pqm_email = Canonical PQM [14:56] rick_h__: Do `bzr config` in the branch which you're trying to submit to see if it's picking up your config. [14:58] allenap: done [14:58] bac: Thanks! [14:59] bac: Indeed, it was mind-numbing to write :) [14:59] i'm sure of that === almaisan-away is now known as al-maisan [15:08] allenap: thanks, yea that affirms my config is there [15:09] but when I tried to do a bzr pqm-submit it ended up pulling up a gpg key for my personal email address and of course pqm then failed with me not auth'd to submit [15:10] rick_h__: Ah, okay, I thought you were talking about the submission address. Let me see what I've got... [15:12] rick_h__: Look at the diff in https://bugs.launchpad.net/bzr/+bug/257637 [15:12] <_mup_> Bug #257637: bzr uses wrong key for signing < https://launchpad.net/bugs/257637 > [15:13] rick_h__: I think you can set a gpg_signing_key to choose the key you want to use. (I'm still using the workaround mentioned in the comments.) [15:13] Although it does say it should default to what bzr whoami reports :-/ [15:14] allenap: ah, thanks. perfect [15:19] allenap: awesome thanks, that seems to have worked. Now I can kill this ec2 land run to submit this === al-maisan is now known as almaisan-away === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugtasks: 3*10^2