[05:41] <burrito_> ubuntuone-client-gnome isn't in any of my menus and i can't seem to cough up the correct terminal command to run the app
[11:57] <gatox> good morning!
[12:04] <ralsina> Hola gatox
[12:04] <ralsina> Que tal las vacaciones?
[12:09] <gatox> ralsina, good!!!! lot of relax!! :D
[12:09] <gatox> ralsina, yours?
[12:11] <gatox> ralsina, ahhhhhh you didn't have vacation, sorry...... how was the week alone?
[12:11] <ralsina> gatox: fun!
[12:11] <ralsina> ;-)
[12:16] <gatox> :P
[12:18] <czajkowski> aloha
[12:19] <ralsina> hello czajkowski!
[12:20] <czajkowski> ralsina: ello, I've a question and wondering is this normal
[12:20] <ralsina> czajkowski: shoot!
[12:20] <czajkowski> using banshee I'm re downloading my purchased music to  a new laptop
[12:20] <czajkowski> I've gone to page 2 of my music and clicked download
[12:20] <czajkowski> it puts be back to page one
[12:20] <czajkowski> every single time
[12:20] <czajkowski> kinda annoying
[12:21] <czajkowski> as it only shows 10  songs per page
[12:22] <ralsina> czajkowski: I suppose it's a bug
[12:22] <ralsina> czajkowski: ask dobey when he appears
[12:23] <czajkowski> will do thanks
[12:23] <czajkowski> I assume he;s not working today due to it being a bank holiday ?
[12:23] <ralsina> czajkowski: is it a holiday in the US?
[12:23]  * ralsina has not checked yet
[12:24]  * czajkowski is in the Uk
[12:24] <czajkowski> aye tis
[12:25] <ralsina> then tomorrow I guess :-)
[12:26] <czajkowski> grand job thanks
[12:59] <alecu> EOV :-(
[13:00] <alecu> and.... hello #ubuntuone!
[13:00] <ralsina> hello alecu
[13:00] <alecu> hola jefe!
[13:00] <ralsina> alecu: admit you missed it
[13:00] <ralsina> ;-)
[13:00] <alecu> that would be so.... masochistic
[13:00] <alecu> so: yes.
[13:01] <gatox> alecu, hi!
[13:01] <alecu> hola gatox!
[13:05] <alecu> my thunderbird is about to implode
[13:19] <alecu> boy I hate IMAP
[13:21] <ralsina> alecu, gatox: would it be a bad idea to make the bin/whatever scripts really really trivial and move all the logic into the packages? It would save about 4-8 hours in the windows release process
[13:22] <alecu> ralsina, probably it would be a good thing, since then we'd be forced to add tests whenever we add code to those scripts
[13:22] <ralsina> alecu: yes, that too
[13:22] <ralsina> I will file a bug
[13:22] <gatox> ralsina, productivity++
[13:23] <ralsina> alecu, gatox: I need reviews here -- https://code.launchpad.net/~ralsina/ubuntuone-client/fix_904300/+merge/87073 and here https://code.launchpad.net/~ralsina/ubuntuone-control-panel/even_more_unique_than_the_other_snowflake/+merge/86912
[13:24] <gatox> ralsina, on it
[13:27] <gatox> ralsina, is_root has tests? (don't hit me)
[13:27] <ralsina> gatox: I don't know. Does the linux one have tests? ;-)
[13:28] <gatox> ralsina, nop
[13:28] <ralsina> gatox: and I have no idea how to test that. It will return False on every possible situation unless you run the tests as admin with elevated privileges :-)
[13:28] <gatox> ralsina, true...
[13:28] <gatox> just asking....
[13:28] <ralsina> and if I fake it, then...
[13:28] <ralsina> gatox: I know. I honestly didn't know how to test that
[13:29] <gatox> ralsina, but what you are saying make sense....
[13:29] <ralsina> gatox: I could add a test to say "we have a test" where I test a fake function that returns what I want to get ;-)
[13:35] <gatox> ralsina, about unique application....... wouldn't be better to use qsharedmemory instead of sockets?? I think it's more clean.....
[13:36] <ralsina> gatox: hmmmm could be
[13:36] <gatox> ralsina, it's really easy..... less code...... and i think it's faster
[13:36] <ralsina> gatox: local sockets is what all the implementations I found used
[13:37] <gatox> ralsina, i can show you an example with qsharedmemory if you want.......
[13:37] <gatox> ralsina, local socket i used (from my pov) if you want to send any information to the process already running
[13:37] <ralsina> gatox: in the future we may want to use it
[13:37] <gatox> if you only want to detect is another process is running... i think qsharedmemory is better
[13:38] <ralsina> gatox: for instance, to send notification/progress info to u1cp
[13:38] <gatox> ralsina, so.... not now?? i review this one just the way it is?
[13:38] <ralsina> gatox: or to make it show a specific tab. But yes, not now.
[13:38] <ralsina> gatox: but if we are later goig to do it, it makes no sense to use shared memory now
[13:38] <gatox> ralsina, in an application i use both.... qsharedmemory to check if another process is running.... and if that is the case, so open the socket to send info if it's needed
[13:39] <ralsina> gatox: that sounds weird
[13:39] <gatox> ralsina, i found several examples doing that...... (that doesn't mean that the examples were right :P)
[13:40] <ralsina> gatox: I would like to see the example with sharedmemory if you have it handy :-)
[13:40] <gatox> ralsina, yep.....
[13:40]  * gatox searching...
[13:40] <gatox> ralsina, https://github.com/ninja-ide/ninja-ide/blob/master/ninja_ide/core/ipc.py#L63
[13:42] <ralsina> gatox: missing bit using qsharedmemory: the "running" instance doesn't know the other one pinged it
[13:43] <gatox> ralsina, yes..... i use qsharedmemory to see if an instance is running.... if i need to pinged it, then i use the socket
[13:43] <ralsina> gatox: so that solution is actually more code
[13:44] <gatox> ralsina, if you want to ping the already running instance: YES..... i thought that maybe you only wanted to avoid to reopen the application....
[13:45] <ralsina> gatox: this branch also pings
[13:45] <gatox> ralsina, ahhhhhhh ok..... my bad
[13:45] <ralsina> gatox: so that if you start a second instance, the first one pops
[13:46] <ralsina> have to feed to kid, bbiab
[13:46] <gatox> ralsina, there are some missing docstrings in: https://code.launchpad.net/~ralsina/ubuntuone-control-panel/even_more_unique_than_the_other_snowflake/+merge/86912
[13:47] <ralsina> gatox: freaking pylint not working on windows and I forgetting to run it on linux
[13:47]  * gatox start the year in nessita mode
[13:47] <ralsina> gatox: and thanks ;-)
[13:47] <gatox> jejejee
[14:29] <ralsina> gatox: fixed lint problems in snowflake
[14:29] <gatox> ralsina, ok
[14:36] <ralsina> gatox, alecu: and for when you are with a bit of time (say a day or two? ;-): https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_809873/+merge/67911
[14:38] <gatox> ralsina, added to bookmarks :P.... i'll review it after i finish with one of my branches
[14:58] <ralsina> gatox: apparently there is still a unicode bug somewhere: bug #910535 do you think it's a duplicate of some other one?
[14:58] <ubot4> Launchpad bug 910535 in ubuntuone-control-panel "Windows client - error in Folder view (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/910535
[14:58] <alecu> ralsina, I've taken a look at python-requests.org, and I've replied you on the u1-discuss list
[14:58] <gatox> ralsina, i'm fixing that right now
[14:59] <ralsina> alecu: cool
[14:59] <gatox> ralsina, also... i'm having some problems to test u1-coontrol-panel on windows..... not only your branch.... but trunk too.... i'm getting reactor was unclean.... so i can't run the test right now.... i'm looking what might be the reason
[14:59] <ralsina> alecu: thanks for looking at it. Too bad it won't work, the API is so cool.
[14:59] <ralsina> gatox: ack
[15:00] <ralsina> gatox: may be because of something I merged there last week, in which case I am sorry
[15:03] <ralsina> gatox: can you try running the tests in revno 247? If that works, then it's my fault
[15:03] <gatox> ralsina, ok... i'll try that
[15:05] <mandel> ralsina, hello
[15:05] <mandel> gatox, alecu, hola!
[15:05] <ralsina> hello mandel!
[15:05] <gatox> mandel, hi
[15:06] <mandel> ralsina, sorry I was late, I had to deal with taxes :(
[15:06] <ralsina> mandel: ready for a moster review to start 2012? :-D
[15:06] <mandel> ralsina, sure :)
[15:06] <mandel> ralsina, do we have a stand up?
[15:06] <ralsina> mandel: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_809873/+merge/67911
[15:06] <ralsina> let's stand up!
[15:06] <ralsina> me
[15:06] <mandel> me
[15:07] <ralsina> gatox, alecu: standup please
[15:07] <gatox> me
[15:07] <alecu> me
[15:08] <ralsina> DONE: worked, you lazy people! fixed a bunch of bugs, cleaned up and finally proposed the windows packaging scripts branch TODO: work! maybe tech leads call, try to merge my proposed branches BLOCKED: no
[15:08] <ralsina> mandel: ?
[15:08] <mandel> DONE: Holidays, had to deal with taxes paperwork so my day starts.. now!
[15:08] <mandel> TODO: mails, ralsina reviews, proxy
[15:08] <mandel> BLOCKED: no
[15:08] <mandel> gatox, go
[15:08] <gatox> DONE:
[15:08] <gatox> Vacations, ralsina review, added some test to u1-client branch
[15:08] <gatox> TODO:
[15:08] <gatox> Fix tests on linux, review my task queue.
[15:08] <gatox> BLOCKED:
[15:08] <gatox> No
[15:08] <gatox> alecu, go
[15:08] <alecu> DONE: vacations
[15:08] <alecu> TODO: catch up with email, proxy support
[15:08] <alecu> BLOCKED: no
[15:08] <alecu> NEXT: none?
[15:09] <ralsina> alecu: none indeed
[15:09] <mandel> is a holiday in the USA, right?
[15:09] <ralsina> holiday in the US and UK, nessita on holiday
[15:09] <verterok> ralsina: there is a critical bug in ubuntu-sso-client (it's completely broken in Precise), I proposed a fix on friday: https://code.launchpad.net/~verterok/ubuntu-sso-client/fix-910163/+merge/87160
[15:10] <ralsina> verterok: ack, reviewing
[15:11] <ralsina> verterok: damn, I had seen this on friday, forgot to review it
[15:11] <ralsina> verterok: there you go
[15:11] <verterok> ralsina: np, I know you're relocating on friday :)
[15:12] <mandel> who is relocating?
[15:12] <ralsina> verterok: worse, by my notes I had actually reviewed it and never got to put the comment because internet didn't work
[15:12] <mandel> win?
[15:12] <ralsina> mandel: I am at the beach
[15:12] <mandel> ralsina, ah..
[15:12] <ralsina> mandel: and I changed appartments on friday
[15:12] <verterok> ralsina: heh, it happens :)
[15:13] <mandel> ups, closed the wrong window :)
[15:13] <mandel> ralsina, but you guys got my email from this morning, right?
[15:13] <ralsina> mandel: yes, got it
[15:14] <mandel> ok :)
[15:14] <mandel> ralsina, anything interesting has happened since I was on holidays, besides the icon thing?
[15:15] <ralsina> mandel: I proposed the packaging branch
[15:15] <ralsina> mandel: I fixed a few bugs
[15:15] <ralsina> mandel: the mayans recanted their 2012 profecy, said they meant 2011 and sorry about that
[15:15] <mandel> ralsina, hehe
[15:16] <mandel> ralsina, in that branch, you have a +1 from shane, what should we do about that?
[15:16] <ralsina> mandel: ignore it?
[15:16] <mandel> ralsina, so we need an extra +1, right?
[15:16] <ralsina> mandel: I would like 2
[15:16] <alecu> mandel, that +1 from shane is from 6 months ago.
[15:16] <ralsina> OTOH, consider the branch "IRL tested" since it's what's on the release ;-)
[15:16] <ralsina> mostly
[15:16] <mandel> alecu, ralsina I say an extra +1 since I'm already doing a review :)
[15:17] <ralsina> with mandel and another I would be happy
[15:17] <gatox> ralsina, 247 is working fine..... i'm going to compare the changes now and propose a branch to fix the problem
[15:18] <ralsina> gatox: I knew my change was a bit fishy
[15:23] <mandel> ralsina, why do we do this: Get the VistaLib32.dll and VistaLib64.dll and put them in dist.
[15:24] <ralsina> mandel: that's the solution for the "wizard-runs-as-admin" problem
[15:24] <ralsina> mandel: those DLLs implement a privilege de-escalation
[15:24] <mandel> ralsina, and we need both, x64 and 32?
[15:24] <ralsina> mandel: yes, the 32-bit doesn't work as admin in 64-bit systems
[15:25] <mandel> menuda mierda... ok
[15:25] <ralsina> mandel: indeed
[15:25] <mandel> ralsina, and this guy: "lp:~ralsina/ubuntuone-windows-installer/register_plus_login" ?
[15:25] <mandel> we are still using him?
[15:25] <ralsina> mandel: yes, nessita is working on the proper fix
[15:29] <mandel> ralsina, I would not use glob on windows.. but is not something I have a valid reason to complain about
[15:30] <dobey> czajkowski: yes, it's a bug, in the server.
[15:30] <ralsina> mandel: that code is yours ;-)
[15:32] <mandel> ralsina, he, I must be becoming a better programmer :)
[15:32] <ralsina> mandel: hehe
[15:33] <mandel> ralsina, since that code is just going to be used on windows, I'd use FindNextFile, what do you think?
[15:33] <ralsina> mandel: I don't quite care ;-)
[15:34] <mandel> ralsina, hm.. does that mean we are using FindNextFile? :P
[15:34] <ralsina> mandel: ok, I will do it.
[15:34] <mandel> ralsina, cool :)
[15:34] <ralsina> mandel: wait, you mean this Findnextfile? DONE: worked, you lazy people! fixed a bunch of bugs, cleaned up and finally proposed the windows packaging scripts branch TODO: work! maybe tech leads call, try to merge my proposed branches BLOCKED: no
[15:35] <ralsina> oops
[15:35] <ralsina> mandel: wait, you mean this Findnextfile? http://www.google.com.ar/url?sa=t&rct=j&q=findnextfile&source=web&cd=1&ved=0CB8QFjAA&url=http%3A%2F%2Fmsdn.microsoft.com%2Fen-us%2Flibrary%2Fwindows%2Fdesktop%2Faa364428(v%3Dvs.85).aspx&ei=i84BT_DjM8nbtgf-7Z3QBg&usg=AFQjCNG-eZr5AIhnTwM8nxgFow9m1AUReg&sig2=NQLfL3FxgoagoAzY0pWYGw
[15:35] <ralsina> argh!
[15:35] <ralsina> mandel: FindNextFile is ugly
[15:36] <mandel> ralsina, yes, but it work on windows.. which is what os.listdir does in the code of python
[15:36] <ralsina> mandel: this does work. On windows.
[15:36] <mandel> ralsina, yes, but is fragile
[15:37] <ralsina> mandel: ok, what breaks it? (just curious)
[15:37] <mandel> path ends with \
[15:37] <mandel> ralsina, ^ for example
[15:37] <mandel> ralsina, other is \\?\
[15:37] <ralsina> mandel: we are not going to have a path that ends that way. Or a literal path
[15:38] <ralsina> mandel: this is not syncdaemon (thank $DEITY)
[15:39] <mandel> ralsina, hehe
[15:39] <ralsina> mandel: it's just to copy a bunch of files from lazr. You are thinking too much ;-)
[15:39] <mandel> ralsina, ok, then I'm sure that we can use os.listdir, right?
[15:39] <ralsina> and if we ever adapt this to mac, findfile won't work
[15:39] <mandel> ralsina, I'm bac with energies :)
[15:40] <ralsina> mandel: hehe
[15:40] <mandel> ralsina, listdir is a better option the, right?
[15:40] <ralsina> yes, and this is using the wrong path separator, to boot
[15:40] <ralsina> so, doing via listdir
[15:41] <mandel> ralsina, cool, let me know whenever you are done and I'll do a second pass :)
[15:42]  * gatox lunch
[15:44] <mandel> ok, I need to reboot for updates
[15:44]  * mandel reboots
[16:24] <gatox> ralsina, ping
[16:26] <mandel> alecu, ralsina, gatox crazy question, do you have problem logging on your ubuntu p machine?
[16:27] <mandel> I can ssh with the username and password, but ligthdm ain't working for me :(
[16:27] <alecu> mandel, you've probably forgotten your password due to the hangover from the holidays!
[16:27] <gatox> alecu, mandel has gone
[16:27] <alecu> doh
[16:28] <alecu> that's what hangover is doing to me :-)
[16:28] <gatox> alecu, jejejee
[16:30] <gatox> alecu, a complicated new year?
[16:35] <gatox> ralsina, let me know when you are back please
[16:35] <gatox> alecu, do you have a minute?
[16:36] <gatox> mandel, nop... i'm not having that problem
[16:36] <mandel> gatox, dammed.. stupid Alpha testing..
[16:36] <gatox> mandel, ahhhhhhh but i'm in O
[16:36] <gatox> not P
[16:38] <mandel> gatox, now I managd to loging but unty does not longer work...
[16:38] <mandel> puto puto puto
[16:38] <gatox> jejej
[16:38] <gatox> mandel, sorry... but is good to know when i'm not the only one with problems jejeje
[16:39] <mandel> gatox, you donn't have problem, you are just?  'special' :P
[16:39] <gatox> jejejeje
[16:45] <mandel> buagh.. segmentation fault in unity..
[16:56] <gatox> mandel,  durisimo
[16:57] <mandel> Agghg stupid updates!
[17:04] <mandel> gatox, ralsina I'm off to walk the dog and try to fix my machine..
[17:04] <mandel> what a start of the year :(
[17:04] <gatox> mandel, relax
[17:05] <mandel> gatox, I'm relaxed, is just that when I have energy I sound angry :P
[17:05] <mandel> but I'm not, I'm just hungry..
[17:05] <mandel> hehehe bad joke :P
[17:05] <dobey> damn cylons
[17:06] <mandel> dobey!
[17:06] <mandel> dobey, are you running p? have problem with unity?
[17:08] <mandel> ok, I'm off trying to fix the machine
[17:08] <dobey> i have it on one laptop, and installing it on another right now
[17:09] <dobey> but i haven't noticed any problems beyond my normal issues with it, no
[17:17] <ralsina> gatox: I am back
[17:17] <ralsina> mandel: when your computer is working again, the branch is ready to re-review
[17:17] <gatox> ralsina, look at this: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/fix-reactor/+merge/87267
[17:18] <gatox> first..... it seems that the end of line is different :P
[17:18] <gatox> ralsina, then...... i remove the @inlineCallbacks from test_stop_sd....... does this have any sense to you? that fix the problem with the dirty reactor
[17:18] <ralsina> gatox: right, freaking EOL
[17:19] <ralsina> gatox: if it's not inlineCallbacks, you can't yield
[17:19] <ralsina> gatox: were your problems running the tests on windows or linux?
[17:19] <gatox> ralsina, yes...... that was what i thought...... but it was working without that......
[17:19] <gatox> ralsina, windows
[17:20] <ralsina> gatox: it's probably never reaching the assert
[17:20] <gatox> ralsina, i can't run the controlpanel tests on linux
[17:21] <gatox> ralsina, i approve your branch...... i ran the tests commenting that line
[17:21] <gatox> #@inlineCallbacks
[17:22] <ralsina> gatox: we should ask someone that knows more about deferreds than us
[17:22] <gatox> ralsina, uhhhh alecu is not here :(
[17:22] <ralsina> gatox: that was my first thought :-)
[17:22] <gatox> :P
[17:23] <ralsina> so, let's keep that branch on hold until he's back
[17:23] <gatox> ralsina, yep
[17:27]  * ralsina goes back to sprint planning
[17:37] <czajkowski> dobey: ah is it a known bug ?
[17:38] <dobey> czajkowski: i don't think i've seen that one filed
[17:39] <czajkowski> want me to file it
[17:39] <czajkowski> damn annoying when I've 10 pages to do :)
[17:41] <ralsina> hi dobey! Thought it was holiday over there
[17:42] <dobey> it is
[17:45] <czajkowski> dobey: where do I file a bug on lp for U1
[17:46] <dobey> czajkowski: that bug would belong in https://bugs.launchpad.net/ubuntuone-music-store
[17:48] <czajkowski> dobey: thanks
[17:55] <gatox> brb
[18:11] <ralsina> hahaha, nessita just gave me a needsreview from vacations!
[18:12] <gatox> ralsina, jejeje she is everywhere
[18:32] <ralsina> running u1-client tests on windows takes FOREVER
[18:36] <dobey> s/on windows//
[18:37] <ralsina> dobey: takes about 75% longer on windows here
[18:37] <ralsina> So 1.75 forevers
[18:55] <ralsina> alecu:  gatox and I have a doubt about deferreds
[18:55] <alecu> ralsina, tell me!
[18:56] <ralsina> alecu: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/fix-reactor/+merge/87267 (just look at the test_stop_sd function)
[18:56] <ralsina> my version (in red) breaks, but I say gatox's version (in green) makes no sense ;-)
[18:57] <gatox> alecu, only one line change...... the @inlineCallbacks for stop_sd was removed
[18:57] <gatox> i don't say that my version makes sense either :P..... i just don't know why that fix.... or seems to fix the error
[18:58] <alecu> gatox, ralsina: removing the inlineCallbacks is wrong
[18:59] <alecu> gatox, it allows the test to pass, because the function suddenly looks like a generator to the test runner
[18:59] <gatox> alecu, do you know why the code with the @inlineCallbacks can be generating a dirty reactor?
[18:59] <gatox> ahhhh
[18:59] <alecu> gatox, and so it's not *fully* executed.
[18:59] <alecu> gatox, I'm not sure why it's generating a dirty reactor, looking.
[18:59] <ralsina> maybe something is broken in stop()
[19:00] <alecu> ralsina, right.
[19:00] <alecu> gatox, a dirty reactor usually means that something was added to the reactor by some of the code, and it was not removed before the test ends
[19:01] <alecu> usually it's a "reactor.callLater" that's not reached nor removed. Or a tcp connection that's started but not finished.
[19:04] <alecu> gatox, ralsina: does that^ make sense?
[19:04] <ralsina> alecu: maybe, but I don't know what it could be
[19:05] <ralsina> alecu: the problem was introduced by this: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-control-panel/trunk/revision/248
[19:09] <ralsina> gatox: the first docstring is wrongin https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/default-agree/+merge/87282
[19:13] <gatox> ralsina, ahhhhhh probably :P
[19:14] <gatox> ralsina, you didn't give me the time to add the pritty pictures!
[19:14] <gatox> ralsina, i'm doing that
[19:14] <gatox> ralsina, pictures added....... fixing docstring....
[19:14] <ralsina> hahaha
[19:15] <ralsina> +1 on pretty pictures
[19:15] <gatox> :P
[19:15] <gatox> s/pritty/pretty........ pritty is the drink :P
[19:18] <ralsina> gatox: nice, but the bug description doesn't match what the branch does
[19:19] <gatox> ralsina, true..... should i close that issue as "fix commited" or something and create a new one for this?
[19:19] <gatox> ralsina, i take that one to fix license buttons
[19:20] <ralsina> gatox: yes please, for a cleaner changelog
[19:20] <gatox> ok.... removing the bug
[19:20] <ralsina> gatox: sorry about the extra work
[19:20] <alecu> ralsina, gatox: I'm also getting "twisted.internet.error.ReactorNotRestartable".... weird.
[19:20] <alecu> in the fix-reactor branch
[19:20] <ralsina> alecu: that may be because stop() is calling reactor.stop()?
[19:21] <gatox> alecu, ralsina jeejje that happens to let me test the branch.... i'm the king of the bugs and corner cases!
[19:21] <ralsina> That's what happens when the manager codes. The devs suffer.
[19:21] <alecu> ralsina, looks like it, but I can't find the piece of code that does that.
[19:22] <alecu> damn. there it is. I was looking at the branch diff
[19:23] <ralsina> alecu: right, two lines lower than the diff
[19:24] <alecu> ralsina, ok. Then we should be faking the reactor.stop in the tests
[19:25] <alecu> gatox, ralsina: we can't use reactor.stop inside tests, because the reactor is used by trial too
[19:25] <gatox> ahhhhhhh
[19:25] <ralsina> alecu: right,so we need to patch it
[19:25]  * alecu will be back in 5 minutes
[19:25] <gatox> ralsina, updated: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/default-agree/+merge/87282
[19:26] <ralsina> gatox: on it!
[19:27] <gatox> ralsina, do you want me to add the patch for that and update the already proposed branch?
[19:27] <ralsina> gatox: please
[19:27] <gatox> ralsina, on it
[19:28] <alecu> back
[19:28] <ralsina> gatox: thanks
[19:30] <alecu> ralsina, gatox: it seems that just patching "reactor.stop" with a no-op makes the test pass
[19:31] <gatox> alecu, cool
[19:33] <afeijo> hi guys, I have u1 installed here in my ubuntu 11.04 but I cant find the icon to open it. Can I open the app thru alt+f2 ?
[19:34] <beuno> afeijo, sure
[19:34] <beuno> it should be ubuntuone-client
[19:35] <afeijo> beuno, that does not exists, but I found it under ubuntuone-control-panel-gtk, thanks
[19:36] <afeijo> karni, hey! How are you? I sold my old phone the one that had this nasty date bug, remember? now I've got a great Atrix :D
[19:36] <beuno> ah, right, it changed  :)
[19:37] <karni> afeijo: coolio :) hi there, I'm good. How are you :)
[19:37] <afeijo> weird, it is loading but does not finish it
[19:37] <afeijo> karni, I'm good, spent the christmas and new year at home with family, I have 2 small girls, it was fun :)
[19:37] <afeijo> and you?
[19:38] <karni> afeijo: I spent Christmas with my family in my hometown, it was nice. Sadly, we had to say goodbyes to our 16 year old dog. I came back to Warsaw just before new year to spend some that evening with friends.
[19:39] <gatox> ralsina, alecu review: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/fix-reactor/+merge/87267
[19:39] <karni> afeijo: Happy 2012 :)
[19:39] <afeijo> karni, sorry about the dog, but 16 years is a lot !
[19:40] <karni> afeijo: yes, she had a good life. it aws time for her to go, she was a great dog.
[19:41] <afeijo> karni, what race?
[19:42] <afeijo> ops, I dont think I translated it right
[19:42] <karni> afeijo: gordon seter
[19:42] <karni> http://en.wikipedia.org/wiki/Gordon_Setter
[19:42] <afeijo> builtiful one
[19:43] <afeijo> once I had a big dog too, one of the bigest kind, Pirineus, do you know that one?
[19:44] <afeijo> http://en.wikipedia.org/wiki/Great_Pyrenees
[19:45] <karni> afeijo: It looks fantastic :)! I'll have to excuse you and focus back on work for a little longer :)
[19:45] <afeijo> same here! c'ya karni
[19:45] <karni> afeijo: Nice to hear from you :)
[19:46] <beuno> ralsina, are you running precise?
[19:47] <gatox> alecu, when you have a moment, please: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-links/+merge/86605
[19:52] <ralsina> beuno: sometimes. Have a VM though!
[19:53] <beuno> ralsina, u1sdtools complains about gtp and pixmap
[19:54] <ralsina> beuno: checking in 5'
[19:54] <beuno> ralsina, no rush, just wanted to make sure we didn't ship P with this  :)
[19:55] <ralsina> beuno: hahaha
[19:56] <dobey> beuno: it's known. and i have no idea why it does that when DISPLAY isn't set
[19:56] <beuno> cool
[19:56] <beuno> also
[19:56] <beuno> bug #907631
[19:56] <ubot4> Launchpad bug 907631 in ubuntuone-client (Ubuntu) (and 1 other project) "gnome-settings-daemon crashed with SIGSEGV in got_public_files_cb() (affects: 12) (dups: 7) (heat: 100)" [Critical,Confirmed] https://launchpad.net/bugs/907631
[19:56] <beuno> I get that a bazillion times a day
[19:57] <beuno> can't really use nautilus for any U1-watched folder
[19:59] <dobey> yeah it will be fixed tomorrow
[19:59] <beuno> yay
[19:59] <beuno> thanks dobey
[20:02] <dobey> sure
[20:05] <ralsina> gatox: +1 on fix-reactor
[20:05] <gatox> ralsina, :D
[20:05] <gatox> trivial? or should i look for a second review?
[20:07] <gatox> ralsina, ^
[20:07] <ralsina> I say get another +1
[20:07] <gatox> ralsina, ok
[20:07] <gatox> alecu, need your review :P
[20:13]  * alecu reviews
[20:18] <alecu> gatox, why is run-tests.bat showing up as different? meld says it's the same file. Probably you've changed some line endings???
[20:18] <gatox> alecu, yes..... i think the previous version contain some platform dependent eol or something
[20:18] <ralsina> alecu: yes, that's EOLs
[20:19] <alecu> gatox: there are no changes in that file other than the EOLs, so perhaps you can revert that change?
[20:19] <gatox> alecu, which file?
[20:19] <alecu> gatox, also: I've found many prints in u1/platform/tools/linux.py
[20:20] <gatox> alecu, sorry..... which branch are you reviewing?
[20:20] <alecu> gatox, review_fix-links ?
[20:20] <alecu> https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-links/+merge/86605
[20:20] <gatox> alecu, ahhhhhh ok, i thought you were with fix-reactor
[20:20] <ralsina> gatox: remember that run-tests.bat needs to have windows EOLs
[20:21] <alecu> ah, doh!
[20:21] <alecu> gatox, I saw that link on the backlog
[20:21] <gatox> i'll revert that now
[20:22] <gatox> alecu, also i didn't submit the updates for that branch
[20:22] <ralsina> alecu, gatox, dobey: I kinda sorta have a buildout thing working (at least on windows) for our whole stack. Would that be interesting, or should I keep it for myself? ;-)
[20:22] <gatox> alecu, this was the other one: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/fix-reactor/+merge/87267
[20:23] <alecu> ralsina, I think a buildout thingy running on windows is a great thing
[20:23]  * ralsina hopes that, with buildout + virtualenv, setting up a windows dev env is going to be long but hands-free
[20:23] <alecu> ralsina, it should help a lot for people to review our stuff, or for us too to run it on clean vms
[20:23] <ralsina> alecu: that was the idea. Needs lots of work still but I may have it done this week
[20:24] <alecu> one has to love having a free hand to scratch at stuff
[20:24] <ralsina> alecu: :-)
[20:25] <alecu> gatox, so, my review for the fix-links branch is just the two things above (EOLs and prints)
[20:25] <alecu> gatox, I'm on the fix-reactor one now
[20:26] <gatox> alecu, yes, i've removed that right now
[20:26] <gatox> i'm submitting the changes
[20:30] <ralsina> gotta go for a bit
[20:30] <alecu> gatox, approved the fix-reactor branch
[20:39] <gatox> great :D
[21:03] <ralsina> Llegó mi vieja, EOD for me :-)
[21:04] <beuno> puf, re estricta!
[21:05] <gatox> eod for me!