/srv/irclogs.ubuntu.com/2012/01/04/#ubuntuone.txt

gatoxralsina, ping..... just one question if you are still around00:00
ralsinagatox: sure00:00
gatoxralsina, the script python bootstrap.py...... never ends?? just to know... because it stay at: "Generated script .... buildout"00:00
ralsinagatox: it seems to go to background00:01
ralsinagatox: after a bit, see if you have a bin\buildout.exe and that means it's finished :-)00:01
gatoxok thanks00:01
ralsinagatox: ok, ese error es que para instalar twisted se necesita Visual Studio. Parece que voy a tener que hacer el egg primero00:31
ralsinagatox: maƱana la seguimos ;-)00:31
gatoxralsina, okas! no te jodi por aca porque crei que ya no estabas00:32
ralsinano estoy ;-)00:33
n2diyIf I delete something locally, will Ubuntuone delete it too?05:15
n2diy!delete05:21
ubot4Factoid 'delete' not found05:21
lifelessn2diy: yes05:53
n2diyOk, so it isn't a good idea to keep my backup box and this box synced to Ubuntuone, if I mess up this one, so goes the backup box!?05:56
n2diylifeless, thanks for being the only concious and alert life form on this channel! :)05:57
lifelessyes, keeping in sync is u1's story :)06:01
n2diylifeless, roger that. I'm using it as an offsite  backup, so... I need to understand how to play with it.06:21
=== eu is now known as Guest108
mandelmorning all!10:08
ralsinagood morning mandel!11:01
mandelralsina, morning!11:01
mandelralsina, I'm finishing your review right now, I have some small comments but most of it looks great :)11:01
ralsinamandel: awesome11:01
ralsinamandel: it's big enough that everything can' be right :-)11:02
ralsinacan't11:02
mandelralsina, + I wrote some ot if hehehe11:02
mandelugh, that is new, I swap letters between words..11:03
mandelralsina, done, comments written, let me know if all of them are clear and if you agree/disagree :)11:04
ralsinamandel: the replace of @FOO@ is so it works like on linux11:06
ralsina+1 on removing the glob import11:06
ralsinaor rather, let me work a bit on it and give a full answer11:06
mandelralsina, sure, I also did this: https://code.launchpad.net/~ralsina/ubuntuone-control-panel/even_more_unique_than_the_other_snowflake/+merge/8691211:08
mandelralsina, that one is approve, yet you have to remove your name from the header since it was greed to do that in all files..11:08
mandelalthough I miss seeing my name everywhere :(11:08
ralsinamandel: yes, I am removing it, must have missed some11:08
mandelralsina, just two of the, not much work :)11:08
mandelralsina, and it is approve so you can approve the merge as soon as you removed those :)11:09
ralsinamandel: cool :-)11:09
mandelralsina, one question, do you know what is  dirspec.basedir ?11:10
ralsinamandel: dobey's relacement for a bit of xdg11:10
ralsinamandel: s we can remove that crap from sso11:10
mandelralsina, ah, superb, can it be replaced everywhere, I'm looking at https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-links/+merge/86605 and Basedir is there11:11
ralsinamandel: can I ask you a favour? Can you check if all the files in snowflake have the right EOLs? Something like find . -exec file {} \; | grep CRLF11:11
ralsinamandel: we'll do it eventually, I suppose11:12
mandelralsina, sure11:12
mandelralsina, one question, do you know how to config squi3 not to use http1.1 ?11:13
mandelIs keeping the connections alive and I'm getting dirty reactor issues :(11:13
ralsinamandel: want to not have keepalive?11:13
ralsinamandel: I have a vague notion, give me 1' to check11:13
mandelralsina, thx!11:13
ralsinakeepalive=1,1,1 (that should close any connection in about 2 seconds)11:14
ralsinaand tcpkeepalive=1,1,111:15
mandelralsina, where do I put that?11:15
ralsinain squid.conf11:15
mandelralsina, anywhere? cool, let me try :)11:15
ralsinano wait11:15
gatoxgood morning11:15
ralsinaat the end of the http_port11:15
ralsinalike this, mandel: http_port 3128 keepalive=1,1,111:16
ralsinahi gatox!11:16
gatoxralsina, hi11:16
mandelgatox, morning!11:17
mandelgatox, feeling better?11:17
mandel gatox, I did some of your reviews, please check the branches11:17
gatoxmandel, ok.... yep, much better11:17
mandelralsina, I'm getting the following:11:18
mandelFATAL: Bungled squid.conf line 73: http_port 58557 keepalive=1,1,111:18
ralsinamandel: well, it's in the docs: http://www.squid-cache.org/Doc/config/http_port/11:19
mandelralsina, he, stupid docs, in one part it says keepalive in other it says tcpkeepalive11:21
mandelralsina, is the later..11:21
ralsinamandel: it happens11:22
gatoxmandel, sorry..... didn't understand this comment: "One question, can the xdg from sso be replaced by  dirspec.basedir?"12:01
nessitagood morning everyone!12:03
gatoxnessita, hi12:03
mandelgatox, so, apparently there is a pacakge implemented by dobey that has some oof the functions from xdg and is called dirspec.basedir so that we do not all depend on sso12:03
mandelgatox, I'm wondering if we can use that instead12:04
mandelnessita, morning!12:04
nessitahello mandel, gatox12:04
gatoxmandel, any reference to that package to take a look if it can be useful in this case?12:04
mandelgatox, AFAIK is in the nightlies ppa already12:04
gatoxmandel, i mean..... do you have a link or something to take look into the code or how to use it?12:05
mandelgatox, hm.. no idea of the name of the project, ralsina do you know the lp project for dirspec?12:06
ralsinamandel: python-dirspec I think12:06
mandelgatox,  ^12:10
gatoxmandel, yep..... i'm looking at the code12:10
ralsinamandel, gatox: when you have a minute to try it, no priority, I have a new and improved buildout at http://u1.to/ralsina/O/build.zip12:19
gatoxralsina, ok.... i'll try it now...... now i can open 2 vms at the same time (gatox cry)12:20
mandelralsina, I'm fighting with twisted at the moment (and winning) I'll be on that asap :)12:20
mandelgatox, but you only have one monitor!12:20
mandelbuahahahaha12:20
gatoxmandel, you always have to ruin the moment!12:20
gatoxjejjee12:20
mandelgatox, that is what she said ;)12:20
duanedesign'lo all12:24
nessitahello again! (/me had internet issues)12:24
ralsinagatox: Virtualbox has an awesome mode called "stretch mode". You can have two large VM screens visible at the same time if you don't mind that they look like crap :-)12:25
ralsinahello nessita, duanedesign!12:25
gatoxralsina, na, i prefer to use one desktop for each of them12:25
nessitahello ralsina12:26
nessitamandel, gatox: I just saw your comment in gatox's branch, re replacing xdg with dirspec12:27
nessitamandel, gatox: we're not doing that for now, we will migrate everything to use it in separated branches12:27
nessitamandel, gatox: specially because the package is not available in the ubuntu repos (yet)12:28
gatoxnessita, ok...... not looking at dirspec anymore12:28
mandelnessita, ok12:28
nessitagatox: you can look, but please do not make the change for now12:28
ralsinamandel: did the keepalive change i squid make a difference?12:29
gatoxnessita, question..... is this really necessary??  "Can you please add tests to os_helper to reflect the changes you have made to path_exists, make_link and read_link?"......12:30
gatoxnessita it was TDD we already have the tests.... i change the code and keep working :P jeje12:30
mandelralsina, no, but I found a way to fix the issue, I implemented the HttpChannel protocol in twisted so that it kept a reference to the instance currently used, during the cleanup I force the timeout of the connection directly from the protocol12:30
ralsinamandel: ok12:31
nessitagatox: that's the problem, you changed the code without adding a test first that fails12:31
mandelralsina, that cleans everything and lets the reactor clean12:31
nessitagatox: so, the first step would have been adding a test where you assert that path_exists(some_link_without_lnk) will give True12:31
mandelralsina, the good/bad things is that the issue was just happening in P because we have squid3 :)12:31
nessitagatox: and that would fail, and just then you can modify the code12:31
ralsinamandel: shouldn't those be cleared if you delete the instances that open them? as part of gc?12:31
gatoxnessita, you mean "windows/os_helper", don't you?12:32
mandelralsina, yes, but then we have an unclean reactor exception from trial12:32
ralsinamandel: oh12:32
nessitagatox: no? (maybe I'm not understanding you?)12:32
mandelralsina, we want to have no selectables of delay callbacks in the reactor since it make the next tests to work in an unclean env12:33
ralsinamandel: makes sense12:33
mandelralsina, do you remember the sso test that where failing? it is a very similar issues12:34
gatoxnessita, if the test should be for test_os_helper for windows only, or the platform independent version...... because the changes were for windows only... if it is for windows only i can test better the changes i think12:34
nessitagatox: no, the test should be multiplatform, and in linux that test will pass, since os.path.exists will return True for links in linux12:35
gatoxok12:35
ralsinamandel: fix_809873 ready for another pass, comments answered12:53
mandelralsina, ok, give me some mins and I'll get to it :)12:53
ralsinamandel: no rush :)12:56
mandelnessita, ralsina do I have to test that the proxy tests work for versions earlier than N?13:01
nessitamandel: they should, yes13:02
mandelok13:02
ralsinamandel: not M13:02
ralsinamandel: but yes L13:02
ralsinaAlthough M should be no problem13:02
nessitamandel: if they don't work, we should have a clear understanding of why they don't, so we can fix after feature freeze13:02
mandelnessita, I'm making sure they work with squid2 and squid3, I'll run the tests on the previous releases to check what happens13:03
nessitamandel: awesome13:03
NickLHi, a quick ubuntu one question, I'm running out of disk space on my PC, but have loads of room in U1, if I delete a synced folder from my PC, will it delete from my U1 account too?13:13
NickLrye, can you help with this ^13:16
beunoNickL, if you first make it stop syncing from your desktop, and then delete it, it will become a cloud-only folder13:18
beunothat is, only if the folder isn't under ~/Ubuntu One/13:18
ryeNickL, yes, unsubscribe the folder locally13:18
NickLawesome. Thanks beuno, rye.13:18
ryeNickL, using ubuntuone-control-panel-gtk13:18
mandelnessita, ralsina FYI the branch that was blocking alecu has passed all the tests in NMO and P, looking at L and will propose for re-review13:20
* mandel is waiting for his L machine to update13:20
gatoxmandel, nessita when you have a minute, please, re-review this: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-links/+merge/8660513:20
mandelsure13:21
ralsinamandel: cool13:22
gatoxralsina, i'm getting this error now: http://paste.ubuntu.com/792688/13:22
ralsinagatox: more eggs that need VS to build. I can fix it!13:25
mandelalecu, ping?13:35
mandelhm.. I'm off to lunch13:36
mandellets hope they see this:13:36
mandelalecu, dobey I updated https://code.launchpad.net/~mandel/ubuntuone-dev-tools/proxy-testcase/+merge/85019 to work on P with squid3, I have ran the tests from L to P and passes in all platform, may I have a re-review (including running the tests)13:37
* mandel lucnk13:37
* mandel lunch13:37
=== mandel is now known as mandel_afk
alecuhello all!13:41
dobeymeh13:43
ralsinahola alecu, dobey13:43
ralsinakid's up, I gonna be a dad for half an hour13:43
alecumandel_afk, great news; re-reviewing.13:44
nessitahola alecu!13:52
gatoxnessita, ping14:12
nessitagatox: pong14:15
gatoxnessita, question..... tihs issue is only for gtk: https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/865176 ..... am i right?14:16
ubot4Launchpad bug 865176 in ubuntuone-windows-installer "Handle errors more gracefully, show user friendly message and hide technical details (affects: 1) (heat: 2)" [Medium,In progress]14:16
gatoxnessita, sorry14:16
gatoxthis one: https://bugs.launchpad.net/ubuntuone-control-panel/+bug/87027014:16
ubot4Launchpad bug 870270 in ubuntuone-control-panel "Windows tool tip doesn't display if "&" is in the folder name (affects: 1) (heat: 6)" [Medium,In progress]14:17
nessitagatox: yes14:17
gatoxnessita, ok14:18
gatoxjust to be sure14:18
nessitagatox: but what is the question?14:18
nessitagatox: I said "yes" meaning "I see the bug report"14:18
gatoxahhhhh14:19
gatoxnessita, if it's only valid for gtk14:19
gatoxit seems14:19
nessitagatox: have you tried in the QT control panel?14:20
gatoxnessita, i was looking at the description of the bug (and it's looks like controlpanel in linux).... i couldn't add a folder in windows.... i'm trying14:22
nessitagatox: you can try using the qt control panel on linux14:24
nessita@ping14:31
ubot4pong14:31
nessitainternet connection is acting up, apparently14:32
nessitaralsina: shall we skype?14:32
ralsinanessita: it's a bit noisy here, but let's try14:33
nessitaralsina: you still in mdq?14:33
ralsinanessita: yes14:34
ralsinanessita: I see you as offline on skype14:35
dobeygatox: that bug is about the gtk control panel, yes14:35
nessitaralsina: calling you14:35
ralsinanessita: ca you hear me?14:35
nessitaralsina: yes14:35
nessitaralsina: can you hear me?14:35
ralsinathen I can't hear you14:35
nessitaralsina: give one sec14:36
nessitaralsina: can you please call me?14:36
ralsinasure14:36
nessitaralsina: you can hear me?14:37
ralsinano14:37
ralsina:-(14:37
ralsinawill you have mumble later?14:37
nessitaralsina: one sec, will install padevchooser14:37
ralsinaok14:37
nessitaralsina: not in this machine :-(14:37
gatoxdobey, thanks14:37
beunoralsina, bug #911792 is for you!14:38
ubot4Launchpad bug 911792 in ubuntuone-client "Messaging menu turns blue when I get a share, can't do anything about it (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/91179214:38
ralsinabeuno: thanks!14:38
beuno(has been happening for a while, but thought it was time to file it to fix it for P!)14:39
nessitaralsina: I have no idea why audio input is not working, will try a little bit longer t fix14:39
ralsinanessita, alecu, mandel, dobey, gatox: very very very trivial branch: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_911784/+merge/8748314:40
ralsinanessita: no rush14:40
gatoxralsina, on it14:40
nessitaralsina: restarting skype made it work14:42
nessitaralsina: calling you, if you're available14:43
ralsinanessita: sure, go ahead14:43
alecuralsina, +114:44
=== mandel_afk is now known as mandel
gatoxralsina, +114:45
* mandel back14:45
mandelalecu, so, the way i fixed was to implement a version of the HTTPChannel and force a timeout of the connection, how do you see that?14:46
mandelalecu, does it sound hacky?14:46
alecumandel, yup.14:47
mandelalecu, whenever you take a look let me know, but is the only way I found how to solve the issue in a reliable manner with squid314:51
mandelalecu, I'm moving to other proxy bugs, from this: https://bugs.launchpad.net/ubuntu-sso-client/+bugs?field.tag=u1-proxy which ones do you have?14:51
alecumandel, sorry, where did you put the timeout?14:54
alecumandel, I see that you've added a teardown_client_server, and that looks good.14:55
duanedesignmandel: hello14:57
mandelalecu, grep for self.site.protocol.protocolInstance.timeoutConnection()14:57
alecuahhh, cool. Looking.14:57
duanedesignmandel: I have a user that gets this error https://pastebin.canonical.com/57717/14:57
mandelalecu, I think that is ok, but I'm not 100% sure and you are the twisted guy :)14:57
mandelduanedesign, hello! long time no see14:57
mandelduanedesign, let me check14:57
duanedesignmandel: i saw a bug you worked on that appears to be this issue14:57
mandelduanedesign, which package is he using?14:58
alecumandel, that's perfectly fine: you are forcing the mock webserver to timeout when closing. (I understand a different thing)14:58
mandelduanedesign, he is missing the pem file from ubuntuone storage protocol, which are in the storage protocol trunk14:58
alecumandel, in fact, it's a lovely solution.14:58
mandelalecu, yes, that is what I meant to say :)14:58
duanedesignmandel: would this cause the sync to get to 'stuck'. And possibly produce the "DeadReferenceError 'Calling Stale Broker'" error?14:59
alecumandel, I think you've said it right the first time, I understood cualquiera.14:59
mandelalecu, I'm glad to hear that, I though I was being stupid, which is common lately :P14:59
mandelduanedesign, hm.. it could possible mean that, is he getting the Stale Broker error from control panel?15:00
mandelduanedesign, that error usually means that the is a reference of the IPC in one of the UI applications, and sd gc that object15:00
gatoxme15:00
alecumandel, two small needsfixing, but the branch looks great!15:00
mandelme15:00
alecuhttps://code.launchpad.net/~mandel/ubuntuone-dev-tools/proxy-testcase/+merge/8501915:00
mandelalecu, superb!15:00
nessitame15:00
nessita@ping15:01
ubot4pong15:01
alecume too15:01
alecunessita, what's with all the @pinging?15:01
alecuok!15:02
duanedesignmandel: Not sure what version they are running. Should updating to the latest version fix the missing pem file?15:02
nessitame15:02
alecunessita, what's with all the @pinging?15:02
gatoxralsina, dobey standup?15:02
ralsiname15:02
alecunessita, I saw the first "me" before you disconnected.15:02
nessitaalecu: my internet connection is not working right today, so I don't know when I'm off IRC (cuz pidgin shows me online the same)15:02
mandelduanedesign, should, also, we need to know which one he is using and find out why the pems are not there...15:02
duanedesignkk, thanks15:03
dobeymeh15:03
gatoxDONE:15:03
gatoxAdded some tests to my branches, investigating some issues.15:03
gatoxTODO:15:03
gatoxBug #865176, Bug #870270, and several more.15:03
gatoxBLOCKED:15:03
gatoxNo15:03
ubot4Launchpad bug 865176 in ubuntuone-windows-installer "Handle errors more gracefully, show user friendly message and hide technical details (affects: 1) (heat: 2)" [Medium,In progress] https://launchpad.net/bugs/86517615:03
ubot4Launchpad bug 870270 in ubuntuone-control-panel "Windows tool tip doesn't display if "&" is in the folder name (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/87027015:03
gatoxmandel, go15:03
mandelduanedesign, let me know if you need a hand15:03
mandelDONE: Finally found a nice wayt to use localhost address to test the proxy testcases so that the reactor is cleaned if we use http 1.1 with squid3. A number of reviews for gatox and ralsina.15:03
mandelTODO: Fix the comments inthe proxy test case from alecu. Move to next proxy bug.15:03
mandelBLOCKED: no15:03
mandelnessita, go15:03
nessitaDONE: lots of reviews, releases, catch up15:03
nessitaTODO: keep fixing the tests for bug #83473015:03
nessitaBLOCKED: nopes15:03
nessitaNEXT: ralsina15:03
ubot4Launchpad bug 834730 in ubuntuone-client (and 1 other project) "Use SignalBroadcaster and RemoteMeta from ubuntu sso client (affects: 1) (heat: 8)" [High,In progress] https://launchpad.net/bugs/83473015:03
ralsinaDONE: kept on pushing the windows packaging branch, first attempt at buildout-thingy, fixed minor string bug, reviews, 1-1 natalia TODO: fix more buildout, fix more bugs, some bug triaging sprint planning BLOCKED: no NEXT dobey15:03
dobeyĪ» DONE: fix crashers in P, releases15:04
dobeyĪ» TODO: uploads, fixes for gireactor from review, initial music store work15:04
dobeyĪ» BLCK: No.15:04
nessitacomments anyone?15:04
dobeyoh15:04
nessitagatox: are you feeling better?15:04
dobeynessita skipped alecu15:04
dobeyalecu: go :)15:04
nessitaoh, sorry, I missed that me15:04
gatoxnessita, yep......15:04
alecuDONE: gave two hands debugging, worked on gsettings+qt, reviews15:05
alecuTODO: land proxy integration branch, a bit more on gsettings parser15:05
alecuBLOCKED: on mandel's branch that's coming real soon now.15:05
ralsinaEOD?15:05
gatoxnessita, i'm trying to track some bugs..... it should be an easy fix..... but the tracking part is kind of confusing...15:05
ralsinaoops EOM? ;-)15:05
nessitagatox: what do you mean?15:05
mandelralsina, I don't mind EOD :P15:06
nessitagatox: did you see my comment re: testing the qt control panel in linux?15:06
gatoxnessita, yep..... but i'm with another one before that one15:06
gatoxok..... i need to go to the bank right now to hit some people..... i'll be back in a while15:07
dobeynessita: the bug that was about, was specifically for the gtk control panel though.15:09
mandelalecu, I just pushed the changes to the branch with the comments of the review15:09
nessitadobey: right, but before closing, I want to be sure it works right on linux as well15:09
mandelalecu, can you let me know which bugs from the proxy tag are free for me to tackle15:09
dobeynessita: also, it's filed about 2.0.0, so we might need to fix it in SRUs for older versions as well anyway15:10
nessitadobey: unless we backport the qt control panel :-D15:10
dobeynessita: though perhaps a lower priority. i don't think closing it as "well we have a qt panel now" is the answer15:10
dobeyi don't even want to imagine thinking about backporting the qt panel yet :(15:10
dobeyand i don't have to think about that sort of stuff until march anyway, i think15:12
=== gatox is now known as gatox_away
mandelalecu, are you working on this guy: bug 88497515:16
ubot4Launchpad bug 884975 in ubuntu-sso-client "replace urllib2.urlopen with common web-client (affects: 1) (heat: 9)" [Undecided,New] https://launchpad.net/bugs/88497515:16
dobeyoh, i guess i should have had "TODO: File MIR for dirspec" also15:16
alecumandel, bug #884972 and bug #88497515:17
ubot4Launchpad bug 884972 in ubuntu-sso-client "replace urllib2.Request with common web-client (affects: 1) (heat: 9)" [Undecided,New] https://launchpad.net/bugs/88497215:17
ubot4Launchpad bug 884975 in ubuntu-sso-client "replace urllib2.urlopen with common web-client (affects: 1) (heat: 9)" [Undecided,New] https://launchpad.net/bugs/88497515:17
ralsinaI wonder what would happen if I file a bug that in the title says bug #thesamebug15:18
ralsinaand then mention it here15:18
alecumandel, I'll tackle bug #884973 next, since I already did some stuff to replace lazr.15:19
ubot4Launchpad bug 884973 in ubuntu-sso-client "replace lazr.restfulclient with common web-client (affects: 1) (dups: 1) (heat: 12)" [Undecided,New] https://launchpad.net/bugs/88497315:19
alecuralsina, a black hole?15:20
mandelalecu, so I can move to bug #884972 and bug #884975, right?15:20
ubot4Launchpad bug 884972 in ubuntu-sso-client "replace urllib2.Request with common web-client (affects: 1) (heat: 9)" [Undecided,New] https://launchpad.net/bugs/88497215:20
ubot4Launchpad bug 884975 in ubuntu-sso-client "replace urllib2.urlopen with common web-client (affects: 1) (heat: 9)" [Undecided,New] https://launchpad.net/bugs/88497515:20
alecumandel, yay!15:21
lee_hi15:21
lee_with ubuntu one can i have 5 people all accessing the same logon account15:21
mandelalecu, superb, I'll move to them now, let me know if you see any other issues with the test case after revno 8015:21
mandeldobey, can you please review the proxy-testcase branch whenever you have the time :)15:22
dobeymandel: yes, and when the insanely cold weather stops affecting neuron transmission :)15:23
lee_hi15:23
dobeyuh, bye then15:24
mandeldobey, ok :)15:26
mandeldobey, and thx15:26
dobeyit is not supposed to be this cold here15:26
alecumandel, I found this lint error: http://pastebin.ubuntu.com/792779/15:29
alecumandel, but it's also present on u1-devtools trunk, so it's not caused by your branch15:29
alecudobey: any idea if the above lint error will cause any problem?15:29
dobeyalecu: no. that is supposed to be there. it makes sure that u1lint doesn't exit non-zero for XXX/FIXME/TODO comments in code15:31
alecudobey: cool, thanks.15:31
dobeyalecu: which is why the comment is "test this doesn't fail" :)15:31
mandeldobey, I could have not explain it better :P15:33
alecumandel, I've not run the tests on my P vm, because I still have to install more stuff, but I've run the tests on O, so I'm approving15:34
mandelalecu, superb, dobey you do have a P machine, right?15:36
dobeyyes15:36
mandeldobey, would you run the tests in the P machine then, it works on in my P, but is better that in is ran in a diff env15:36
dobeywhen i get to the review :)15:37
dobeyi have a bunch of ubuntu uploads to do first15:37
mandeldobey, yeah, no preasure, I just wanted you to know we needed a P15:39
=== yofel_ is now known as yofel
mandelalecu, the webclient_factory, does it take any *args or **kwargs?15:41
nessitabrb15:51
mandeldobey, I keep forgetting that module that needed to be installed to run the sso tests so that you do not see the ui, do you mind refreshing my mind and tell me stupid at the same time? :D15:52
dobeyxvfb15:53
gatox_awayback15:53
=== gatox_away is now known as gatox
mandeldobey, thx15:54
mandelnessita, alecu why is the sso ping url unicode?16:02
nessitamandel: why or where?16:02
gatoxalecu, please..... when you have a moment, please re-review this old branch: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/network-detect/+merge/77048 (only need your approval)16:04
mandelnessita, in ubuntu_sso/tests/tests_credentials.py, line 430 for example, the current webclient throws this: TypeError: url must be str, not unicode16:05
nessitamandel: what was your original question?  why or where is the ping url code?16:07
dobeynessita: why is it unicode instead of str; not where is the code16:09
mandelnessita, why is the ping url unicode?16:11
nessitadobey, mandel: ah, misundertood the question16:13
mandelnessita, np :)16:13
nessitamandel: is unicode up to the point where we actually send it16:13
nessitamandel: so we can add to it any variable with any unicode value we need (since we append specific t to store in our servers)16:14
mandelnessita, hm.. have we ever tried that code with a funny char?16:16
mandelnessita, I might not understand the docs from here: http://docs.python.org/library/urllib2.html#urllib2.Request16:17
nessitamandel: if I recall correctly, we have tests for that16:17
nessitamandel: why?16:17
nessitamandel: why do you need to do, exactly?16:17
mandelnessita, I read that is must be a str, not unicode, and my brain is confused16:17
nessitamandel: yeap, that is correct. If you see the sso code, it will encode the url before using it16:18
nessitamandel: see utils.oauth_headers, it calls:16:18
nessita     99     url = url.encode('utf-8')16:18
nessitamandel: so, what do you need to do? I may help you16:19
mandelnessita, I was just wondering, I wanted to make sure that I indeed needed to do the .encode('utf-8') and that it was no error16:20
mandelalecu, ping16:20
mandelnessita, also, I think that if we do that, it should be in webclient, right?16:20
nessitamandel: yes16:20
dobeyok. need to get lunch. bbiab.16:21
nessitamandel: in the line of code closer to doing the actual web request16:21
alecugatox, it seems that the last NeedsFixing in that branch was not fixed16:23
gatoxalecu, no??16:23
gatoxlet me check again16:23
mandelnessita, does this make sense then: #91184416:23
mandelalecu, nessita bug 91184416:23
ubot4Launchpad bug 911844 in ubuntu-sso-client "Teh common webclient should be able to handle urls that are unicode and not str (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/91184416:23
nessitamandel: besides the typo, I would say we should agree on an API where the webclient only accepts unicode urls16:24
nessitaalecu: ^16:24
gatoxalecu, ahhhh sorry..... didn't see that one16:24
mandelnessita, fixed the typo hehe16:24
alecunessita, mandel: a url is not unicode, its bytes16:24
alecuhmmm16:25
nessitaalecu: is bytes before sending it thru the wire16:25
* alecu is not sure of the thing he just said16:25
* alecu googles.16:25
nessitaalecu: I meant, is bytes right before sending it thru the wire, with some encoding. Before that, I would advice having it as unicode16:25
mandelnessita, alecu is a matter of agreeing, and how to make it so that it gets as bytes in the diff implementations, doing the decode in every diff implementation is a PITA16:29
alecuok, now I understand it.16:33
alecuURLs cannot have unicode characters in them. They should be percent encoded16:34
alecuIRIs on the other hand can have unicode characters:16:34
alecuhttp://stackoverflow.com/a/2744184/109819916:34
alecu"While URIs are limited to a subset of the ASCII character set, IRIs may contain characters from [Unicode]"16:35
alecuhttp://en.wikipedia.org/wiki/Internationalized_Resource_Identifier16:35
aleculet me rephrase the first part:16:36
alecuURLs cannot have unicode characters in them. Any unicode characters in an IRI should be encoded with Punycode if they are part of the hostname, or percent encoded if part of the path, query string or fragment id.16:39
alecunessita, mandel: ^16:40
alecunessita, mandel: my opinion is that if we allow unicodes in URLs we should call them URIs and *only* allow unicodes to be used.16:41
mandelalecu, yep, got it, therefore, in ourcase we just have to worry about the percent encoded because the hostname is coming from us, at least for sso16:41
mandelalecu, the unicode bits may come from the APP_NAME for example16:41
alecumandel, at least for sso. We should check the rest.16:41
alecudamn. I got the last sentence wrong, again:16:42
alecunessita, mandel: my opinion is that if we allow unicodes in URLs we should call them *IRIs* and *only* allow unicodes to be used16:42
mandelalecu, then we will have issues with some implementations since they will expect a str and not a unicode, I've already seen that error16:42
alecumandel, implementations of what? webclients?16:43
alecumandel, like the qt or gnome webclient?16:43
alecu(by gnome I really mean libsoup)16:44
mandelalecu, yes :)16:44
karniHow fancy, Sun Java is gone. yay Open JDK =_=` @$@#$%16:45
mandelkarni, sorry, I don't drink coffee :P16:46
karnimandel: I guess you drink ice(d)tea16:47
alecumandel, well, our webclient layer will receive python unicode IRIs, and it will translate to whatever the underlying webclient expects (probably URLs expressed as bytes in most cases)16:47
mandelalecu, exactly, so we need to add some extra code in common.py to work around that, right?16:47
alecumandel, the thing I want to make sure is that our webclient layer *always* receives unicode IRIs16:47
alecumandel, probably. Let's check what's the best place to put this.16:48
karnimandel: (I hope you got the joke ;) )16:49
mandelkarni, its as bad as mine :P16:49
karnimandel: hehe16:49
karnimandel: no it's not, but are so-Java ;d16:49
mandelalecu, ideally, common should be exposed to unicode, I think we can achieve that with inheritance, don't you think?16:50
gatoxalecu, this branch is ready for review: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/network-detect/+merge/7704816:50
gatoxnessita, alecu and this one too: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/7704916:50
alecumandel, well, it depends on the backend16:51
alecumandel, for instance, QUrl already handles unicode: http://developer.qt.nokia.com/doc/qt-4.8/qurl.html16:52
nessitaalecu, mandel: sorry I was heating my lunch. I agree with alecu, let's force unicode like we're doing it now16:52
nessitaright now we have an assert isinstance(url, unicode)16:52
nessitawe can rename the variable name, of course16:52
nessitaalecu, mandel: and I agree to have that bit of logic in the webclient layer16:52
alecunessita, exactly * 216:52
mandelalecu, we can provide a help function in common that does the transformation, and the implementation decides if it is needed16:53
mandelnessita, ^16:53
alecumandel, let me check if libsoup needs it.16:53
ralsinagatox: new buildout.cfg to launch when you have a minute: https://pastebin.canonical.com/57736/16:55
* gatox testing....16:55
alecumandel, libsoup has no mention of unicode, so we'll probably need to do it in the python layer: http://developer.gnome.org/libsoup/stable/SoupURI.html16:55
mandelalecu, well, I called the default webclient_factory and got an error, so we do need that16:56
mandelalecu, I'll go for a coffee and I can take of writting such a function, ok?16:58
alecumandel, I can probably add that on my proxy-integration-tests branch16:58
alecumandel, what error did you get?16:59
mandelalecu, TypeError: url must be str, not unicode16:59
gatoxralsina, http://paste.ubuntu.com/792871/17:06
nessitalunchtime!17:06
ralsinagatox: we sure depend on a lot of C code :-)17:06
gatoxralsina, it seems :P jeje17:07
mandelI'm out 10 mins, I need to go to the cash machine, will be back very soon17:07
* mandel cash point17:09
ralsinagatox: another one, but don't stop doing anything else for this https://pastebin.canonical.com/57738/17:12
gatoxralsina, no.... i leave it running.... and check later17:12
ralsinagatox: sorry I make you do this, but installing *another* windows for this makes me cray a little17:13
ralsinacry*17:13
gatoxralsina, jeje no problem17:13
alecugatox, branch approved.17:16
gatoxalecu, grosoooooo!!!!!17:16
gatoxralsina, i'm not being able to reproduce this bug: https://bugs.launchpad.net/ubuntuone-control-panel/+bug/904551 //cc elopio17:18
ubot4Launchpad bug 904551 in ubuntuone-control-panel "two remove buttons (affects: 1) (heat: 42)" [Medium,Triaged]17:18
ralsinagatox: neither can I17:19
gatoxralsina, invalid?17:19
ralsinagatox, elopio: that's why I think it's a repaint bug specific to elopio's box17:19
ralsinagatox: ask elopio to re-check then we decide17:19
gatoxralsina, ok17:19
gatoxelopio, ping17:19
elopioralsina, gatox, windows is "Installing update 1 of 2" ...17:20
ralsinaelopio: see you tomorrow ;-)17:20
elopiowhich installer should I use?17:20
gatoxelopio, jeje fraking updates :P17:20
ralsinaelopio: last time I had one of those, it asked to reboot and it took 45 minutes17:20
ralsinaelopio: 2.0.317:20
nessitagatox: can you try a test to reproduce that?17:21
gatoxnessita, reproduce what?17:21
nessitagatox: remove the current device, and re-login from the control panel, and do to devices tab again, without closing the controlpanel windows ever17:21
nessitagatox: the double remove button17:21
gatoxnessita, ahhhh.... ok17:22
j0nrhey folks, I see the scanning of music has improved17:22
gatoxnessita, AJA! you were right!17:24
nessitagatox: :-)17:26
gatoxnessita, thanks17:26
nessitayw!17:26
mandelalecu, then, getting back to the conversation, do you take care of the fact that we accept unicode in the external interface of webclient?17:28
mandelalecu, at the moment the two bug I assigned muy self in sso would be blocked until that lands17:29
alecumandel, yes, I can work on that on my current branch, since there are a few more changes to the webclients in it17:30
mandelalecu, ok, then I'll move to something else in the mean time17:36
mandelnessita, do you know if bug 907511 is still happening?17:37
ubot4Launchpad bug 907511 in ubuntuone-client "Windows: events from directories where no watch has been added should be ignored (affects: 1) (heat: 69)" [High,Triaged] https://launchpad.net/bugs/90751117:37
ralsinamandel: look at this: https://pastebin.canonical.com/57743/17:37
ralsinamandel: I think I just found ANOTHER corner case we need to handle in filenames17:38
nessitamandel: not sure, I would advice testing IRL17:38
mandelnessita, ok17:38
mandelralsina, jesus christ!17:38
ralsinamandel: indeed17:38
mandelralsina, so what is what you are doing there?17:39
alecuralsina, "con" is a reserved device name on DOS17:39
alecumandel, ^17:39
ralsinamandel: files called CON.whatever are not visible to some windows tools17:39
ralsinaalecu: yes, but it also affects files called CON.extension17:40
gatoxralsina, the script ends at: "getting distribution for coverage"??17:40
mandelralsina, alecu oh, but that does not occur if you have \\?\ :)17:40
alecuralsina, right, it's a piece of crap.17:40
ralsinagatox: that should not be the end ;-)17:40
gatoxralsina, it's still running..... but i don't know if it doesn't return the cursor or something else17:40
gatoxralsina, ah ok..... it has been there for a whileeeee17:40
ralsinagatox: some things take a while17:40
alecumandel, http://digitalpbk.blogspot.com/2006/11/why-cant-folder-be-named-con-or-lpt1-in.html17:41
gatoxralsina, ok.... just checking.17:41
ralsinamandel, alecu: but you can create CON.svg. You just don't seeit with dir :-)17:41
mandelalecu, ralsina so, first thing, add a test case and lets see if it happens, then fix it17:42
alecuralsina, can you try with "dir \\?\con.svg" ?17:43
ralsinamandel: file not found17:43
alecuralsina, probably the full path needs to be put before the filename17:44
ralsinaalecu: yep, did that17:44
mandelralsina, alecu let me try f ReadDirectoryChangesW gets the events, ok?17:44
ralsinaI will do further tests later, but once more the crappiness shines17:44
alecuralsina, has any user actually reported this?17:44
mandelralsina, alecu if it does not, then we are happy, we don't see then in any case, otherwise we have to find out if os.listdir which relies in FindNextFile works correctly or no17:45
ralsinaalecu: nope, thought about it because of a tweet by felipelerena17:45
nessitaralsina: what does dropdox do? :-)17:45
ralsinamandel: but if I have a con.svg on linux and sync it to windows, it will be there but invisible17:45
ralsinanessita: I have no idea yet :-)17:45
mandelnessita, ralsina dropbox ignores all those anoying file names, in their case, the went from Windows to Linux, so they already blocked you from doing all that17:46
mandelI guess we can say they took the easy path, we decided to go in a more interesting way..17:46
mandelnessita, AFAIk by looking at the code bug 907511 is still there, I'll be working on this then17:53
ubot4Launchpad bug 907511 in ubuntuone-client "Windows: events from directories where no watch has been added should be ignored (affects: 1) (heat: 69)" [High,Triaged] https://launchpad.net/bugs/90751117:53
nessitamandel: nice, thanks. Do you need further explanation?17:55
nessitais not trivial to solve17:55
mandelnessita, no, I understood it, the add_watch on Windows is recursive, therefore we are adding a watch in foo, and events in foo/bar are raised, this should not be propagated until the sd did ask for that17:56
mandelnessita, I guess I need to be smart in the way we know that we can listen all of the paths etc...17:56
nessitamandel: right, until the caller explictly request a watch in foo/bar17:56
mandelnessita, ack, will have it before friday for sure17:57
mandelok, I need to walk the dog, I'll be back here for an extra hour or so after :)17:57
mandellaters!17:57
* mandel walks dog17:57
gatoxralsina, ping18:30
gatoxralsina, reallyyyy reallyyyy trivial review please: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/remove-button/+merge/8752118:31
ralsinagatox: close()? shouldn't that be hide()?18:40
gatoxralsina, i don't think so..... when you remove the widget the session close, and when you re-login everything is created again18:41
ralsinagatox: but close() for widgets with parents doesn't remove them18:42
ralsinagatox: for that you have to delete them18:42
ralsinawidget.deleteLater() maybe18:42
gatoxralsina, that could be too.... If the widget has the Qt::WA_DeleteOnClose flag, the widget is also deleted.18:43
ralsinagatox: but does it have the flag? I don't know :-)18:43
gatoxralsina, well... in this case it has the flag...... but i'll try with deleteLater() that should be more appropiate18:44
dobeyman, i wish these city guys would come use their gigantic leaf vacuum on my whole yard18:47
nessitagatox: please make sure to add a test for that fix18:51
nessita:-)18:51
gatoxnessita, i didn't skip the test part just to avoid it :P i did it because i'm not quite sure how to do it.... because i should check for some object which i don't have a reference...... or should i check just that the "deleteLater"method is called?18:53
dobeyalso, this ~$140 portable-ish usb scanner is one of the best investments i ever made18:53
nessitagatox: I would love if you could check that displyaing the tab, deleting the device, and going to the tab again, shows only one button18:53
dobeyok, i think i am /almost/ ready to look at mandel's branch again19:06
* mandel back19:06
dobeyneed to make a couple phone calls first19:06
mandeldobey, :)19:07
dobeythat will hopefully not take too long. the fact that i have to make the calls is annoying19:07
mandeldobey, no worries I'll be here for long enough19:08
mandel@ping19:29
ubot4pong19:29
nessita@ping19:30
ubot4pong19:30
dobeyok19:38
mandeldammed? I'm stupid I was offline and I did not know.. :(19:39
dobeyeh?19:39
ralsinaEOD for me, I was early today. See you all tomorrow!19:41
mandeldobey, nah, I though I was online but I was not..19:43
dobeymandel: i don't see where you weren't on-line, but whatever :)19:44
dobeymandel: ugh; we can't have one conf file for both versions of squid?19:46
ralsinagatox: maybe I missed it, did the last buildout work?19:48
gatoxralsina, it ends.... i'm going to try to run something now19:48
ralsinagatox: cool! :-)19:49
mandeldobey, there are some very annoying small diffs between squid2 and squid3 :(19:49
mandel@ping19:50
ubot4pong19:50
dobeyfml19:59
* elopio building out...19:59
dobeymouse stopped working on my laptop :(19:59
beunodobey, after un/pluggin in a monitor>19:59
beuno?20:00
* beuno has filed bug #91025320:00
ubot4Launchpad bug 910253 in unity (Ubuntu) (and 1 other project) "Unity (or compiz?) crashed, mouse stopped working (affects: 1) (heat: 6)" [Undecided,Invalid] https://launchpad.net/bugs/91025320:00
dobeybeuno: no. i opened the lid from suspend, clicked on the terminal icon in the unity launcher panel, typed some stuff in the terminal, and went to move the mouse and it wouldn't move20:00
beunonice20:01
dobeyyeah, i think it's unity grabbing the mouse20:03
beunoI've had that happened when pluggin and unpluggin, and once when nautilus crashed20:03
gatoxnessita, test added, please review: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/remove-button20:06
=== jono is now known as Guest4459
nessitagatox: sure20:07
* mandel EOD, cu tom!20:13
gatoxralsina, ping20:16
gatoxralsina, i think it didn't work..... at least i can't run the projects because the imports for: qt4reactor, oauth and twisted fails20:21
gatoxEOD for me...... ralsina if you go back..... ping me... i'll be around20:22
gatoxralsina, if you need anything to fix the script20:22
=== M0hi is now known as IAmNotThatGuy
ralsinagatox: hmmm are you using the python from bin?20:54
gatoxralsina, ahhh no.....i'm using the installed python20:54
* gatox opening vm20:55
ralsinagatox: anyway I think oauth will be missing20:55
gatoxralsina, the python in bin is: py.exe?20:55
gatoxyep20:56
gatoxis that one20:56
gatoxi'll try with that one now20:56
dobeyhrmm21:02
gatoxralsina, i'm getting this with sso: http://paste.ubuntu.com/793125/21:02
gatoxusing the py.exe inside bin21:02
dobeyhow can we make squid3 not spew the warning about ::/0?21:02
gatoxralsina, i've to go to buy something.... i'll read the log when i get back.... let me know if you know what might be going on21:06
=== gatox is now known as gatox_away
ralsinagatox_away, gatox: missing registry key/21:08
gatox_awayralsina, not away yet.... how can i fix that?21:09
ralsinagatox_away: you have to setup the .reg file mentioned in the wiki page21:09
ralsinagatox_away: or someday we can fix it so it doesn't crash when the key is not there ;-)21:09
gatox_awayralsina, ahhhhh ok.... i'll do that when i get back in a couple of minutes21:09
gatox_awayralsina, that too :P21:09
ralsinagatox_away: take your time, I am not touching it tonight21:10
dobeyralsina: do you know how to get rid of the warning about "::/0" when "all" is included in the "acl all" in the config file?21:10
gatox_awayralsina, ok..... i'll let you know later...... brb21:10
ralsinadobey: you don't need to define the acl all in squid 3, IIRC21:10
ralsinadobey: it's builtin21:10
dobeyralsina: right, but you do in squid 2; so i'm wondering how to include it, but make the warning not appear21:11
dobeymaybe i should just make mandel fix the code to output STDOUT/STDERR to a log instead21:12
dobeythe squid3.conf appears to work just fine for squid 2, as long as the "all" is included in the "acl all"21:13
* nessita -> eod22:00
dobeylater22:01
=== m_conley is now known as m_conley_away
BWV1041hello. can anyone help me with a ubuntu one sync problem?23:04
BWV1041i have ubuntu lucid lynx and ubuntu one doesn't start the sync, it says 0.0 Kb used (0.0%), it seems to be connecting and disconnecting intermittently.23:06
=== gatox_away is now known as gatox
=== Guest108 is now known as adorilson
=== gatox is now known as gatox_away
czajkowskidobey: I logged that bug #91092123:56
ubot4Launchpad bug 910921 in ubuntuone-music-store "downloading users paid music from system keeps bringing you back to page 1 (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/91092123:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!