| StevenK | wgrant: Sorry, was breakfasting | 00:02 |
|---|---|---|
| StevenK | wgrant: Gah, it's been so long since I've updated mawson. bzr pull in devel and then ../rocketfuel-get.sh ? | 00:13 |
| wgrant | StevenK: ~/bin/upgrade-dogfood-launchpad or so | 00:15 |
| wgrant | Does it all. | 00:15 |
| StevenK | 2012-01-06 00:40:09 INFO Upload was rejected: | 00:40 |
| StevenK | 2012-01-06 00:40:09 INFO Invalid Maintainer. | 00:40 |
| StevenK | wgrant: Shall I put up a NDT? | 00:52 |
| jtv | wgrant, maybe you could have a look at this as well? I feel entirely unqualified to assess or Q/A this, so the more eyes the merrier. https://code.launchpad.net/~jtv/launchpad/bug-876594/+merge/87624 | 04:18 |
| wgrant | jtv: What does TestSyncNotification.makeUploader do that Archive.newComponentUploader doesn't? | 04:29 |
| wgrant | jtv: I think signingkey should be preferred to SPPH.creator | 04:36 |
| wgrant | But it probably doesn't matter too much. | 04:36 |
| wgrant | It also looks like it's Changed-By that gets spammed, not Maintainer. | 04:37 |
| jtv | Possibly. And if so, it'll be a lot harder to hammer out of notify() without risking unforeseen consequences. | 04:37 |
| wgrant | Hm? | 04:37 |
| wgrant | This should suppress Changed-By, not Maintainer. | 04:38 |
| wgrant | I don't see how this can suppress Maintainer. | 04:38 |
| wgrant | if blamer is None: | 04:38 |
| wgrant | debug( | 04:38 |
| wgrant | logger, "Changes file is unsigned; adding changer as recipient.") | 04:38 |
| wgrant | candidate_recipients.append(changer) | 04:38 |
| * lifeless whispers statemachine | 04:40 | |
| jtv | Changing notify() terrifies me. | 04:41 |
| wgrant | I'm not saying you need to. | 04:42 |
| wgrant | I'm saying that the this isn't doing what your test says it does. | 04:42 |
| wgrant | The problem may have been misinterpreted, and this will fix it anyway. | 04:42 |
| jtv | I think I'll add a changer to the test. | 04:46 |
| jtv | wgrant: my eye now falls on a detail that I had hitherto ignored — is_valid_uploader. | 04:58 |
| wgrant | jtv: Right. | 04:59 |
| wgrant | jtv: That projects the only Maintainer usage that I can see. | 04:59 |
| jtv | My branch replaces the paragraph you just quoted with one that also adds the changer, but only if the changer is an uploader. | 04:59 |
| wgrant | s/rpojects/protects/ | 04:59 |
| jtv | No match. | 04:59 |
| jtv | :-P | 04:59 |
| wgrant | Your branch doesn't seem to touch notifications.py | 04:59 |
| jtv | That's right. | 05:00 |
| jtv | Who would want to? | 05:00 |
| StevenK | Thanks ever so. | 05:00 |
| wgrant | The paragraph I quoted is from notifications.py | 05:00 |
| wgrant | notification.py, sorry | 05:00 |
| wgrant | So if your branch doesn't touch that file, it probably didn't replace the paragraph that I quoted. | 05:00 |
| jtv | StevenK: Nothing personal. For context, I've been saying I don't want to change it because I can't oversee the consequences. | 05:00 |
| jtv | StevenK: If I change the logic in notifications.py, it may affect lots of other things. That's why I don't think anybody would want to touch notifications.py to change just one particular behaviour. | 05:02 |
| jtv | wgrant: I didn't mean that my branch replaces it textually; it replaces it dynamically by going through a different code path. | 05:03 |
| jtv | wgrant: the bit you quoted is for the case where blamer is None, and it adds changer to the recipients list unconditionally. | 05:03 |
| lifeless | hmm, notification looks roughly the right place to build up from to get a clean notification api | 05:04 |
| wgrant | jtv: Right, that's what I meant. | 05:04 |
| wgrant | jtv: It changes Changed-By from unconditional to conditional. | 05:04 |
| jtv | By supplying a non-None blamer, I make it go through a different clause that also adds the changer — but only if the changer is an uploader. | 05:04 |
| jtv | Right. | 05:04 |
| wgrant | But doesn't change Maintainer unless they are an uploader. | 05:04 |
| wgrant | Which in this case they aren't. | 05:04 |
| wgrant | So it doesn't change the Maintainer case. | 05:04 |
| jtv | Change Maintainer? | 05:05 |
| jtv | You mean add? | 05:05 |
| wgrant | So either the problem is misstated and your test is wrong, or your fix is wrong. | 05:05 |
| wgrant | Right. | 05:05 |
| jtv | The maintainer also gets added only if it's an uploader. | 05:05 |
| wgrant | Right. | 05:06 |
| jtv | But you're right that the test needs re-stating. | 05:06 |
| wgrant | Which they're clearly not. | 05:06 |
| wgrant | This change can only make it more likely that the maintainer is notified. | 05:06 |
| wgrant | It makes it less likely that Changed-By is notified. | 05:06 |
| jtv | Yes. That sucks, but that's where we get into the internals of notification.py. :( | 05:07 |
| lifeless | I realise you don't want to upscope this - but is the basic model I proposed for a notification service useful (even in-app) for trying to make this easier to reason about ? | 05:07 |
| wgrant | No. | 05:07 |
| wgrant | The problem is not notifying people. It's working out from our terrible data model who to notify and when and how to avoid breaking things. | 05:08 |
| wgrant | And rewriting the whole thing is not a good way to not break things :) | 05:08 |
| lifeless | I didn't actually suggest that | 05:08 |
| lifeless | but, breaking it into two problems - even conceptually: | 05:08 |
| lifeless | - who is involved [build the sets of involved folk, including how they are involved] | 05:08 |
| wgrant | That's exactly the problem. | 05:09 |
| lifeless | - notify | 05:09 |
| wgrant | That's how it is now. | 05:09 |
| lifeless | but it sounds to me that you're examining conditional code that takes the event into account when determining who is involved | 05:09 |
| wgrant | I'm not entirely sure how one can determine the involved people without knowing context... | 05:10 |
| lifeless | perhaps I misunderstand the issue you're wending your way through | 05:11 |
| lifeless | I have to wrap up some stuff, so I will get out of your hair :) | 05:11 |
| lifeless | I may come back if you're still bloodying up the wall in a while | 05:11 |
| jtv | lifeless: for the record, I started out by strengthening that separation, pulling the "identify recipients" into the call site. It didn't help this case. | 05:11 |
| lifeless | jtv: identify recipients is actually against my point, its not equivalent to identifying roles, if you get my drift (Again, terminology, I probably misunderstand) | 05:12 |
| jtv | Potato, potato. | 05:12 |
| jtv | wgrant: I suppose the immediate question is whether it's okay to notify changers who are uploaders. | 05:18 |
| jtv | Sorry, no: maintainers who are uploaders. | 05:18 |
| jtv | wgrant: I don't suppose it's likely to be too problematic for a maintainer or change author to be notified about builds in archives they are uploaders for? | 05:26 |
| wgrant | jtv: I would argue that it's pointless. But it has precedent. | 05:26 |
| wgrant | And it's not harmful. | 05:26 |
| jtv | Looking on the bright side, it's something they're involved in and can do something about, right? | 05:26 |
| wgrant | "harmful" for Soyuz is roughly defined as "pissing off Debian developers who aren't involved in Ubuntu" | 05:27 |
| jtv | Or its derived distros. | 05:30 |
| wgrant | That's not really an issue. | 05:30 |
| wgrant | Distros derived from us are less likely to want to kill us. | 05:31 |
| jtv | Not meant to annoy you; just wondering if there might be non-obvious scenarios where a Debian maintainer might be made an uploader through indirect membership, or to work around some completely unrelated problem. | 05:31 |
| wgrant | It's unlikely. | 05:32 |
| wgrant | Ideally we would entirely ignore Maintainer and Changed-By, just notifier signer/requester + sponsoree | 05:32 |
| wgrant | But we don't have that modelled sufficiently at present. | 05:32 |
| jtv | Clutching at the straws of negativity, any chance that we might generate unacceptable mail volume for someone out there? | 05:32 |
| wgrant | Aren't we just returning to the previous behaviour here? | 05:33 |
| wgrant | Mm, although Changed-By was changed. | 05:33 |
| wgrant | Anyway, I suspect it's Good Enough for Now™ | 05:34 |
| jtv | I'm inclined to feel the same, for what little that's worth; but good to have this sanity chat. | 05:35 |
| jtv | The Changed-By author is only affected in the direction of less chance of getting notified. | 05:35 |
| wgrant | Yes | 05:37 |
| jtv | wgrant: so… shall I just land it then? I just added the changed-by author to the test (and they do not get notified). | 05:39 |
| wgrant | jtv: I'd like to see the test failing with the rest of the code reverted, at least. | 05:39 |
| jtv | My word that that's what happened before I wrote the fix is not good enough? :) | 05:40 |
| wgrant | The test was wrong before, so no :) | 05:40 |
| jtv | Not wrong; it failed in exactly the expected ways. It was just incomplete. Okay, I'll run that. | 05:41 |
| wgrant | Hmm, that's shouldn't have failed, though. | 05:41 |
| wgrant | Maintainer shouldn't have been notified before. | 05:42 |
| jtv | Hmm | 05:43 |
| jtv | wgrant: is it because I made the maintainer sign the changes file? | 05:49 |
| wgrant | jtv: That sounds bad. | 05:50 |
| jtv | Yeah. The maintainer is no longer notified (by the old code) when I change that. | 05:52 |
| wgrant | Hm, does your test actually use a build at all? | 05:53 |
| wgrant | If not, it's probably not using your code at all. | 05:53 |
| jtv | But then how could it fail without my change and pass with my change? | 05:56 |
| wgrant | An extremely good question. | 05:56 |
| wgrant | Oh, you hide a build in makeNascentUpload | 05:56 |
| wgrant | That makes more sense. | 05:56 |
| wgrant | Anyway, I need to wander off for a while and prepare stuff for BUD. | 05:57 |
| jtv | Thanks greatly for your help so far. | 05:57 |
| wgrant | Thanks for trying to understand and fix this madness :/ | 05:58 |
| jtv | Understand? Fix? Julian told me what to do and we gradually discover how the change works around it. :) | 06:02 |
| lifeless | stub: yo | 07:53 |
| lifeless | stub: could you rebuild the bug search indices? If they are bloated (what are the odds... :P) | 07:54 |
| stub | k | 07:54 |
| stub | And number one on the bloated index list is... bug_fti | 07:55 |
| lifeless | I'm shocked. | 07:56 |
| stub | Hmmm... wonder if I should try that new script to rebuild indexes live... | 07:56 |
| stub | losas have a script from (isd or u1?) that should rebuild any index live | 08:00 |
| stub | But not deployed on our boxes yet so I'll use my canned statements | 08:01 |
| stub | Master is done | 08:04 |
| stub | Sometimes wonder if this should be an automated, daily rebuild like data warehouse sites do. But they don't have to do it live... | 08:05 |
| lifeless | heh, uhm, like rebooting windows servers daily. | 08:05 |
| lifeless | I sure hope we can do better :) | 08:05 |
| lifeless | statik was very keen to hear of your new-db-tech interest btw | 08:06 |
| stub | Interesting stuff there is going to be U1 with the primary backend to U1DB | 08:07 |
| stub | Stats are saying with current usage we need to rebuild bug_fti every two weeks | 08:11 |
| wgrant | May change with bug heat changes, though. | 08:14 |
| stub | Yes, but I can schedule myself to check that now :) | 08:17 |
| lifeless | stub: are langpack exports in BAD_USERS or whatnot ? | 08:31 |
| lifeless | stub: https://bugs.launchpad.net/launchpad/+bug/684664 | 08:31 |
| lifeless | wgrant: q for you on https://bugs.launchpad.net/launchpad/+bug/685076 | 08:35 |
| _mup_ | Bug #685076: PPA deletion leaves unremoved publications <lp-soyuz> <soyuz-publish> <Launchpad itself:Triaged> < https://launchpad.net/bugs/685076 > | 08:35 |
| stub | lifeless: yes, got landed yesterday in fact. | 08:44 |
| lifeless | stub: I'm guessing there is a duplicate bug then ? | 08:45 |
| stub | lifeless: its a different bug | 08:45 |
| lifeless | stub: k | 08:46 |
| mrevell | Hey | 08:46 |
| lifeless | mrevell: hey, FWIW stub has reset the fti index | 08:46 |
| lifeless | mrevell: so, that should help with fti searches | 08:46 |
| mrevell | That's good to hear. | 08:46 |
| stub | And scheduled a recurring check every two weeks | 08:46 |
| === almaisan-away is now known as al-maisan | ||
| lifeless | stub: FYI - work in progress only - bzr+ssh://bazaar.launchpad.net/~lifeless/launchpad/use-lazr-postgresql and bzr+ssh://bazaar.launchpad.net/~canonical-launchpad-branches/lazr-postgresql/trunk/ | 09:09 |
| adeuring | good morning | 09:10 |
| stub | lifeless: I'll have a look next week probably. Ta. | 09:11 |
| wgrant | lifeless: Probably very negligible. | 09:19 |
| lifeless | anyone have an opinion on ?https://bugs.launchpad.net/launchpad/+bug/668381 | 09:28 |
| _mup_ | Bug #668381: start_codebrowse invokes "make build" unnecessarily <canonical-losa-lp> <lp-code> <Launchpad itself:Triaged> < https://launchpad.net/bugs/668381 > | 09:28 |
| wgrant | lifeless: Pretty sure we can just use compile. | 09:30 |
| StevenK | allenap: How do you propose to QA r14641, given it has been rolled back three times? | 09:30 |
| StevenK | allenap: If you say "Wait until next week and beg myself and wgrant" I may be forced to pack a cricket bat. :-P | 09:31 |
| allenap | StevenK: Ha. Hahaha. HAhahahahahfahfahahah. | 09:31 |
| wgrant | On the list of bad times to roll out an infamously explosive change, I would rank sprints where the whole team is in a single timezone fairly highly :) | 09:31 |
| allenap | StevenK: If you're offering, that would be most kind, thank you. | 09:31 |
| StevenK | allenap: Do I look insane? :-P | 09:32 |
| allenap | StevenK: Do you really want me to answer that? | 09:33 |
| bigjools | do you really need a reply to that? | 09:33 |
| rvba | ? | 09:33 |
| StevenK | Now I remember why I was happy moving from Red to Teal/Purple. :-P | 09:33 |
| wgrant | StevenK: You were never truly Red! | 09:33 |
| lifeless | gmb: oh hi; there was a bug - one you unassigned, where in the bug you said 'testing xyz needs to be done' -> I'm curious if you did said testing or not, to aid handoff | 09:34 |
| lifeless | ok; haltingish. See you guys in buda | 09:34 |
| wgrant | Night lifeless. | 09:34 |
| StevenK | lifeless: Have safe flights. | 09:35 |
| StevenK | wgrant: And note I said QA. I didn't say anything about deployment. :-) | 09:39 |
| === al-maisan is now known as almaisan-away | ||
| adeuring | https://dev.launchpad.net/ | On call reviewer: adeuring | Firefighting: - | Critical bugtasks: 3*10^2 | 10:13 |
| === jtv is now known as jtv-afk | ||
| cjwatson | Bug 911943 - rollback or fix? (garbo jobs that raise an exception don't actually break anything particularly, but ...) | 11:42 |
| _mup_ | Bug #911943: gina imports SourcePackageRelease.dsc_binaries incorrectly <qa-bad> <Launchpad itself:Fix Committed by cjwatson> < https://launchpad.net/bugs/911943 > | 11:42 |
| cjwatson | If it needs to be rolled back, I'll need somebody to do that for me | 11:43 |
| rick_h__ | adeuring: can you look this over when you get a chance please? https://code.launchpad.net/~rharding/launchpad/oops_912178/+merge/87675 | 11:44 |
| adeuring | rick_h__: sure | 11:44 |
| rick_h__ | adeuring: ty | 11:45 |
| cjwatson | Oh, and can I push the fix to the same branch and remerge, or does it need to be a separate branch? | 11:46 |
| wgrant | cjwatson: It's not overly critical, and the fix seems trivial, so might as well just fix it. | 11:48 |
| wgrant | Same branch is OK if you want. | 11:48 |
| cjwatson | Add "chunk_size = int(chunk_size + 0.5)", yes? | 11:49 |
| cjwatson | And I'm going to *document this* | 11:50 |
| wgrant | I suppose so :/ | 11:50 |
| cjwatson | Fixed. Re-review/landing would be lovely. | 11:52 |
| * cjwatson idly notes that there's already a garbo job that shoots itself in the face on dogfood: http://paste.ubuntu.com/794772/ | 11:53 | |
| wgrant | Yeah, but that's just DF being itself :) | 11:53 |
| cjwatson | Ah, unique to DF? OK | 11:53 |
| wgrant | cjwatson: Can you create a new MP quickly? | 11:53 |
| wgrant | Yeah, that table has existed on prod for a yearish now. | 11:54 |
| cjwatson | wgrant: https://code.launchpad.net/~cjwatson/launchpad/gina-dsc-binaries/+merge/87732 | 11:55 |
| wgrant | timeout ftw | 11:56 |
| adeuring | rick_h__: the changes look good. But I think the JS code needs a test | 11:56 |
| rick_h__ | adeuring: ok | 11:57 |
| wgrant | cjwatson: It breaks test_SourcePackageReleaseDscBinariesUpdater_updates_incorrect | 12:03 |
| cjwatson | Really? I ran that test here and didn't see it | 12:04 |
| wgrant | File "/home/wgrant/launchpad/lp-branches/gina-dsc-binaries/lib/lp/scripts/garbo.py", line 1084, in main | 12:04 |
| wgrant | raise SilentLaunchpadScriptFailure(self.failure_count) | 12:04 |
| wgrant | SilentLaunchpadScriptFailure: 1 | 12:04 |
| cjwatson | make schema | 12:04 |
| wgrant | Ah, you changed sampledata? | 12:04 |
| cjwatson | there's a security.cfg change | 12:04 |
| wgrant | Oh | 12:04 |
| wgrant | Of course. | 12:04 |
| cjwatson | (public.sourcepackagerelease += UPDATE) | 12:05 |
| danilos | flacoste, hi, do you happen to have a minute? | 12:44 |
| === adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring | Firefighting: - | Critical bugtasks: 3*10^2 | ||
| === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring, bac | Firefighting: - | Critical bugtasks: 3*10^2 | ||
| rick_h__ | adeuring: ping, updated with test if you get another look please https://code.launchpad.net/~rharding/launchpad/oops_912178/+merge/87675 | 13:28 |
| adeuring | rick_h__: cool | 13:28 |
| adeuring | rick_h__: r=me thanks for adding the test and the additional changes! | 13:32 |
| rick_h__ | adeuring yep, thanks for pushing me on it. :) | 13:33 |
| === almaisan-away is now known as al-maisan | ||
| flacoste | hi danilos | 14:13 |
| danilos | flacoste, heya, up for short skyping? | 14:15 |
| flacoste | danilos: sure, i have another call in 15 mins | 14:16 |
| danilos | flacoste, ack, that should be more than enough | 14:17 |
| === matsubara is now known as matsubara-lunch | ||
| === jtv-afk is now known as jtv | ||
| * deryck will be back online shortly, changing work locations | 15:27 | |
| === al-maisan is now known as almaisan-away | ||
| sinzui | jcsackett, I think you are missing a test | 16:22 |
| jcsackett | sinzui: you are correct. i'll add the proposed-membership test and switch to the set-based recommendation. | 16:27 |
| jcsackett | thanks. | 16:27 |
| sinzui | fab | 16:27 |
| === matsubara-lunch is now known as matsubara | ||
| abentley | deryck: chat? | 16:50 |
| deryck | abentley, 10-15 minutes and I'll be ready. cool? | 16:51 |
| abentley | deryck: sure. | 16:51 |
| deryck | abentley, great, thanks! I'll ping shortly. | 16:51 |
| === salgado is now known as salgado-lunch | ||
| sinzui | bac, will you have time to review https://code.launchpad.net/~sinzui/launchpad/unassign-bugs-0/+merge/87785 today | 17:28 |
| === deryck is now known as deryck[lunch] | ||
| jcsackett | sinzui: got sidetracked for a bit with thunderdome prep, but changes have been pushed. | 17:36 |
| sinzui | jcsackett, thanks | 17:36 |
| sinzui | jcsackett, r=me | 17:44 |
| bac | sinzui: i may in a bit | 17:45 |
| gary_poster | bac, if you have time, this should be very straightforward (doc changes only): https://code.launchpad.net/~gary/launchpad/bug578854/+merge/87787 | 17:48 |
| gary_poster | (I see others are ahead of me in line :-) ) | 17:48 |
| sinzui | gary_poster, I will review your branch | 17:54 |
| gary_poster | thank you sinzui! | 17:54 |
| gary_poster | sinzui, if bac doesn't get to your branch in a bit, I can take yours. Trying to wrap a few things up for now, and will take lunch sometime too | 17:55 |
| bac | gary_poster, sinzui: i'll be available in a few minutes | 17:55 |
| gary_poster | cool | 17:55 |
| === salgado-lunch is now known as salgado | ||
| sinzui | gary_poster, r=me | 17:59 |
| gary_poster | thanks sinzui | 17:59 |
| bac | sinzui: looking at your branch now. sorry about the delay. | 18:29 |
| sinzui | thats okay | 18:29 |
| === deryck[lunch] is now known as deryck | ||
| sinzui | bac, I claimed your branch for review, but is the proposed merge right? | 18:36 |
| bac | sinzui: no, it is not | 18:37 |
| bac | sinzui: i forgot to specify the pre-req branch. let me redo it | 18:37 |
| sinzui | oaky | 18:37 |
| bac | sinzui: this one should be more better: https://code.launchpad.net/~bac/launchpad/904335-milestone-edit/+merge/87796 | 18:39 |
| sinzui | thank you | 18:39 |
| * bac afk for a bit | 18:41 | |
| sinzui | bac r=me with a suggestion | 19:08 |
| bac | sinzui: thanks | 19:11 |
| bac | sinzui: excellent suggestions, especially the second | 19:12 |
| bac | b/c you're right, i always have to scratch my head over the other syntax | 19:12 |
| === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: [] | Firefighting: - | Critical bugtasks: 3*10^2 | ||
| === matsubara is now known as matsubara-afk | ||
| abentley | deryck: are you up for a review? https://code.launchpad.net/~abentley/launchpad/bugcomment-interface/+merge/87808 | 20:42 |
| deryck | abentley, I don't mind doing it, but just about to step out for day. Can I do it through tonight/travel, or do you need it today? | 20:42 |
| abentley | deryck: No rush. | 20:42 |
| deryck | abentley, ok, cool. I'll claim it then. | 20:43 |
| abentley | deryck: thanks | 20:43 |
| deryck | abentley, np! | 20:43 |
| lifeless | bdmurray: small request for you; we find it works better for bugs for them to description the situation, not the desire | 23:08 |
| lifeless | e.g. "cannot search on bugs 'left_closed_since' via the API" | 23:09 |
| bdmurray | lifeless: okay | 23:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!