Kike | hello | 04:09 |
---|---|---|
=== AlanChicken is now known as AlanBell | ||
mandel | morning all! | 09:36 |
JamesTait | Happy Monday, everyone! :D | 10:11 |
* mandel short coffee making break | 10:17 | |
* mandel back | 10:41 | |
gatox | good morning! | 11:04 |
mandel | gatox, hola! | 11:11 |
torpor | hello | 11:28 |
torpor | is there any way to get the verification code for a new Ubuntu One account re-sent? | 11:28 |
torpor | it appears i have not received the verification code because the account was not set up before ubuntu tried to send it - but i have now set up the account and it works. | 11:29 |
gatox | mandel, do you have time for some reviews? | 11:36 |
mandel | gatox, sure, I'm a little block while updating the windows vm | 11:36 |
gatox | mandel, thanks.... first this one: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-links/+merge/86605 | 11:36 |
gatox | mandel, and then this one that is incredibly trivial :P https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/remove-network-detect/+merge/87795 | 11:37 |
mandel | gatox, oh, by the way, path_exists will brake all the metadata methods if the user decided to create a lnk there with the same name as the folders used by the metadata | 11:37 |
mandel | gatox, is the fault of the user to do that.. yet it could happen | 11:37 |
gatox | mandel, yep.... we talk about that prroblems..... | 11:38 |
mandel | gatox, what was the conclusion? | 11:39 |
gatox | mandel, documentation.... we know that happend.... until there isn't a better solution, we are going to document what the problems might be | 11:40 |
gatox | if i understand correctly...... ralsina ^ | 11:41 |
mandel | gatox, ah, ok.. | 11:41 |
mandel | gatox, why this: 'Remove network detect from sso.' ? | 11:46 |
mandel | gatox, was it a bug? | 11:46 |
gatox | mandel, because we decideed to change the implementation of network detect in the installer, to not depend in sso..... is related to this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 11:49 |
mandel | gatox, I think you can do a lot better for test_links_target_without_lnk_extension and test_links_target_with_lnk_extension to write less code, both tests do the same and only change the destination path, what about reusing the code? | 11:49 |
mandel | gatox, write an _assert_read_link(self, target) and pass the target accordingly | 11:50 |
gatox | mandel, yep.... right.... changinng that | 11:52 |
mandel | gatox, also, instead of exists = os.path.exists(path) or is_link(path) and later do return exists | 11:52 |
mandel | just do return os.path.exists(path) or is_link(path) :) | 11:52 |
mandel | gatox, do I make sense? | 11:53 |
gatox | mandel, yes yes | 11:55 |
ralsina | mandel, gatox: yes that was the conclusion | 11:59 |
ralsina | mandel, gatox: sorry about the delay, was buying groceries | 11:59 |
gatox | ralsina, no problem! | 11:59 |
mandel | ralsina, np :) | 12:00 |
mandel | ralsina, did you get me milk? | 12:00 |
ralsina | mandel: I did | 12:00 |
ralsina | mandel: and blueberry jam and bread | 12:01 |
mandel | ralsina, thx ;) | 12:01 |
nessita | hello everyone! | 12:01 |
ralsina | hello nessita! | 12:01 |
=== teknico is now known as teknico_away | ||
mandel | nessita, morning! | 12:01 |
mandel | ralsina, oh, question, none of us is in the desktop rally, right? | 12:01 |
nessita | hello ralsina, mandel! | 12:01 |
gatox | nessita, hi | 12:02 |
mandel | gatox, this guy is approved: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/remove-network-detect/+merge/87795 | 12:02 |
gatox | mandel, great.... i'm updating the other one | 12:03 |
ralsina | mandel, gatox, nessita: anyone needs reviews? (must be less than 6500 lines ;-) | 12:03 |
mandel | gatox, ok, let me know since I'm wasting a little time waiting for the stupid windows vm to update... | 12:03 |
gatox | i need a review from nessita :P https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 12:03 |
gatox | for IRL it should use this sso: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/remove-network-detect/+merge/87795 | 12:04 |
nessita | gatox: I will do both I owe you (inclidung fix-links) | 12:08 |
gatox | nessita, thanks! :D | 12:08 |
mandel | herb, what I bloody irony, couchdb creator leaves the project and wants to port more and more of the code from erlang to c/c++ .. | 12:10 |
ralsina | mandel: it's not called irony, it's called finding the right medication | 12:11 |
mandel | ralsina, hehe true :) | 12:11 |
mandel | ralsina, at least we ran away on time | 12:12 |
ralsina | mandel: no we didn't. But anyway, I'll get back to coding a bit. | 12:12 |
herb | mandel: hi | 12:12 |
mandel | I'll get back to check wtf is windows doing :) | 12:12 |
mandel | herb, hello | 12:12 |
herb | oh sorry. I just saw the hilight. didn't read that it was about couchdb and not directed at me. | 12:13 |
mandel | herb, haha sorry, I did not know that my funny sound was a nickname :P | 12:14 |
herb | or, you know, my real name too. :) | 12:14 |
mandel | herb, yeah, it was more of a spanish onomatopoeia that anything else :) | 12:15 |
mandel | sorry :) | 12:15 |
herb | no worries | 12:15 |
* mandel hates windows updates... | 12:37 | |
ralsina | gatox: answer this question if you can: http://askubuntu.com/questions/93458/ubuntu-one-not-work-in-windows-7-russian-edition (no rush) | 12:40 |
* gatox checking.... | 12:41 | |
nessita | @ping | 12:46 |
ubot4 | pong | 12:46 |
ralsina | mandel: if you can take a look at https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_809873/+merge/67911 again... | 12:48 |
mandel | ralsina, right on it! | 12:48 |
mandel | ralsina, in line 300 of the diff, is that needed? | 12:55 |
mandel | finalize_options == pass ? | 12:56 |
ralsina | mandel: yes | 12:56 |
ralsina | mandel: if it's not defined, it throws an exception | 12:56 |
ralsina | mandel: and the parent class doesn't define it. No idea why | 12:56 |
mandel | ralsina, we are still using os.system to call python rather than subprocess... | 12:57 |
mandel | 357 is an example | 12:58 |
ralsina | mandel: let me look. Must confess I didn't search for it... | 12:58 |
mandel | ralsina, not big deal :) | 12:58 |
mandel | ralsina, is just not to have two diff ways to do something in the same code, is confusing to a new comer | 12:58 |
ralsina | mandel: but subprocess [way, to, call, things] is ugly! ;-) | 12:59 |
mandel | ralsina, I know... but is what we have.. | 13:00 |
ralsina | mandel: let it pass, please | 13:00 |
ralsina | mandel: I am too bored of that branch ;-) | 13:01 |
mandel | ralsina, If you give me a bug number for it I'll let it pass :) | 13:01 |
ralsina | mandel: file at will ;-) | 13:01 |
* ralsina assigns bug to mandel | 13:01 | |
mandel | ralsina, ok.. | 13:01 |
mandel | ralsina, FYI bug 913765 is assigned to you, feel free to manage it and give it to someone else :) | 13:03 |
ubot4 | Launchpad bug 913765 in ubuntuone-windows-installer "Be consistent in the use of subprocess and os.system (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/913765 | 13:03 |
ralsina | mandel: it's ok, I promise to fix it myself | 13:03 |
ralsina | mandel: I want this to go away :-) | 13:03 |
mandel | ralsina, I understand, one question, the vista dll, is it needed in all the diff versions of windows, or just vista? | 13:05 |
ralsina | mandel: needed for vista an 7, is a noop on xp | 13:05 |
mandel | ralsina, ok.. I was wondering if we could be smart and tell the installer not to copy it to the system when is not needed, is it possible? | 13:06 |
ralsina | mandel: we can even delete it after install | 13:06 |
mandel | ralsina, I think it will be nice to do so, so that we just use the really needed stuff, I'll file a diff bug for it :) | 13:06 |
ralsina | mandel: it's just that wizard can't do it (because it's not running as admin) and installbuilder can't do it (because it's finished ;-) | 13:07 |
ralsina | mandel: maybe put it in a temporary location so it deletes itself eventually | 13:07 |
mandel | ralsina, in temp or there is a way to tell the system to delete a file in the next reboot | 13:07 |
mandel | ralsina, I'll just add the bug so that we can land this | 13:07 |
ralsina | mandel: right | 13:08 |
ralsina | mandel: in any case, it's less than 100KB | 13:08 |
mandel | ralsina, I'll say is more completeness than anything else, it can be flagged as a minimun bug or even not fixing, is just to keep track of this things | 13:09 |
ralsina | mandel: cool | 13:09 |
alecu | hello all! | 13:10 |
gatox | alecu, hi | 13:10 |
mandel | ralsina, how come there are paths that use the linux separator in the xml, example: <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon> | 13:10 |
nessita | gatox: several tests in the windows-installer branch are failing... will I be missing something? | 13:10 |
mandel | ralsina, line 565 | 13:10 |
nessita | hola alecu! | 13:10 |
mandel | alecu, buenos dias! | 13:10 |
ralsina | mandel: it's what InstallBuilder expects | 13:10 |
gatox | nessita, mmmmmmmm let me check again..... but it shouldn't | 13:10 |
nessita | gatox: on linux this is | 13:10 |
mandel | ralsina, and then we have this: <windowsExec>${installdir}\dist\ubuntuone-installer-qt.exe</windowsExec> | 13:11 |
alecu | hey guys, today I'm at the in-laws, and with a shitty wi-fi | 13:11 |
nessita | gatox: also, | 13:11 |
nessita | ubuntuone_installer/gui/qt/tests/__init__.py: | 13:11 |
nessita | 178: [C0111, FakeWizardButtonStyle] Missing docstring | 13:11 |
mandel | ralsina, if it is like that.. WTF installBuider! | 13:11 |
ralsina | mandel: hmmmm both work,I can make them more consistent. Some of those I added editing XML (have \), some were added by the GUI (have /) | 13:11 |
mandel | ralsina, it just got my attention that we are using both | 13:12 |
nessita | gatox: the lint issue comes from trunk, if you could fix it, if qould be great | 13:12 |
nessita | would* | 13:12 |
gatox | nessita, yep... i'm checking..... because i had fix that one...... | 13:12 |
ralsina | nessita, dobey: looks like we don't have lint checks on tarmac on windows-installer, can we add that? | 13:12 |
nessita | ralsina, mandel, alecu, gatox: remember that tarmac is still not running any verify_command for windows installer, so please, when doing reviews, run the installer tests in windows and linux. Thanks! (ATM we have a lint issue in trunk) | 13:13 |
ralsina | nessita: ack | 13:13 |
nessita | ralsina: ah, just see what I pasted ^ :-) | 13:13 |
mandel | nessita, ok | 13:13 |
alecu | nessita, ack | 13:13 |
mandel | ralsina, regarding line 399, can we add that text in a const var, it will look nicer, right? | 13:14 |
nessita | gatox: pasted test errors in the MP so you can tell me if I'm missing something | 13:15 |
ralsina | mandel: 399? os.path.join("data", "revnos.txt") ? | 13:15 |
gatox | nessita, ok | 13:15 |
mandel | ralsina, yes, what is written inside the with statement | 13:15 |
ralsina | mandel: the revnos are obtained a few lines before, and only used there | 13:15 |
mandel | ralsina, also, I think it will be nice to look at clientdefs.py.in and try to generate that too, rather than a copy of the windows folder | 13:16 |
mandel | ralsina, I mean, REVNO_TEXT = 'ubuntu-sso-client:%s' | 13:16 |
ralsina | mandel: good idea. File one for that too :-) | 13:16 |
mandel | ralsina, ok | 13:17 |
ralsina | mandel: I meant file one for the clientdefs | 13:17 |
mandel | ralsina, I suppose you are talking about the clientdefs.py.in :) | 13:17 |
mandel | ack | 13:17 |
ralsina | mandel: I don't quite like the constant for that, it just seems verbose | 13:17 |
mandel | ralsina, well, we can leave it like that then | 13:17 |
ralsina | mandel: let's ask for a third opinion to break the tie :-) | 13:17 |
mandel | ralsina, nah, es una majaderia, it is more a personal style thing than anything else :) | 13:18 |
ralsina | mandel: ack | 13:18 |
mandel | ralsina, FYI bug 913772 | 13:19 |
ubot4 | Launchpad bug 913772 in ubuntuone-windows-installer "Generate clientdefs.py in the package like it is done on linux (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/913772 | 13:19 |
ralsina | mandel: thanks | 13:19 |
ralsina | mandel: you know that's generated by autotools, right? ;) | 13:20 |
mandel | ralsina, we do this: "..", "..", "installed", "Lib", "site-packages", a lot, I think in this case we should store that in a var | 13:20 |
mandel | ralsina, yes, I know, is not an easy task, but we should unify that process a little | 13:20 |
ralsina | mandel: looks like just a dumb template so it should be doable. I do it already for logging.conf | 13:21 |
mandel | ralsina, yeah, I though so, I do remember a little how the file looks like | 13:22 |
nessita | alecu: were you able to move forward with the review, on last Fri? | 13:22 |
ralsina | mandel: agreed about making that a variable | 13:22 |
mandel | ralsina, is not something for now, but I think in the long term is worth doing it, right? | 13:22 |
ralsina | mandel: please put a needs fixing for that | 13:22 |
mandel | ralsina, sure | 13:22 |
ralsina | mandel: well, I would prefer not making ubuntuone-client's python stuff need automake, but we are not having that discussion yet ;-) | 13:23 |
mandel | ralsina, I know, it is a recurrent comment we have hehehe | 13:24 |
ralsina | mandel: fixed the repeated path | 13:29 |
mandel | sweet | 13:30 |
gatox | nessita, mmmmmmm something doesn't have any sense..... the lint issue.... if you look at the code.... the docstring iis there.... you can see it in the diff | 13:30 |
alecu | nessita, no, I didn't got to the big review it on friday, I'll be doing it today | 13:30 |
mandel | ralsina, did you push it? | 13:31 |
ralsina | mandel: wait, push failed | 13:32 |
ralsina | mandel: damn pageant that doesn't open on start | 13:32 |
ralsina | mandel: pushed | 13:32 |
mandel | ralsina, ok | 13:33 |
mandel | ralsina, my typing is contagious -> borked | 13:35 |
ralsina | ? | 13:35 |
mandel | ralsina, in the branch mp :) | 13:36 |
ralsina | looking... | 13:36 |
ralsina | mandel: I don't see any new comments | 13:37 |
mandel | ralsina, oh, do you want me to add it in the needs fixing? | 13:37 |
mandel | sure | 13:37 |
ralsina | mandel: I don'tknow what you are talking about :-) | 13:38 |
mandel | ralsina, line 379 | 13:38 |
mandel | ralsina, -> # Copying by hand because the install is borked | 13:38 |
nessita | gatox: ping | 13:38 |
ralsina | oh, "borked" is a real word ;-) | 13:38 |
mandel | borked :) | 13:38 |
gatox | nessita, pong | 13:38 |
gatox | nessita, did you get my mmessage? | 13:38 |
ralsina | mandel: http://www.urbandictionary.com/define.php?term=borked | 13:38 |
nessita | gatox: no | 13:38 |
nessita | gatox: can you please repeat? | 13:39 |
gatox | <gatox> nessita, mmmmmmm something doesn't have any sense..... the lint issue.... if you look at the code.... the docstring iis there.... you can see it in the diff | 13:39 |
ralsina | mandel: borked "Specifically used to describe technology that is broken." | 13:39 |
mandel | ralsina, ah.. did not know that :) | 13:39 |
ralsina | mandel: you have been typing correctly all along ;-) | 13:39 |
nessita | gatox: I will re branch and re test. Re the fix-links branch: the new make_link impl has an except for AttributeError | 13:39 |
nessita | gatox: why did you leave that there? | 13:39 |
* gatox checckiing.... | 13:40 | |
mandel | ralsina, new years goal :) | 13:40 |
nessita | gatox: you removed the comment that says "This try-except is required at least for the current..." but the except should have be removed as well, I think | 13:40 |
gatox | nessita, ahhh sorry | 13:41 |
nessita | gatox: but you tell me if leaving that there makes sense :-) | 13:42 |
mandel | ralsina, rest look perfectly ok, I'll go for lunch and will run the lint checks against it as nessita recommended and will approve then, is that ok? | 13:42 |
gatox | nessita, checking.. | 13:42 |
ralsina | mandel: pylint is probably going to have a seizure with this code | 13:42 |
ralsina | mandel: pep8 likes it though ;-) | 13:42 |
gatox | nessita, nop.... no sense | 13:42 |
gatox | removing.... | 13:42 |
mandel | ralsina, ok, we will take a look, hopefully is not much :) | 13:42 |
nessita | ralsina: we run u1lint over windows-installer in linux, so you can do that | 13:43 |
nessita | ralsina: or I can run it for you and pass you the output | 13:43 |
ralsina | nessita: I can do it, np | 13:43 |
mandel | ok, lunch for me | 13:43 |
* mandel lunch | 13:43 | |
ralsina | nessita: it complained about weird stuff last I checked (like, importing classes with too many methods) | 13:44 |
nessita | ralsina: on windows or linux? | 13:44 |
ralsina | nessita: on windows, but it was correct ;-) | 13:44 |
nessita | ralsina: in my env, u1lint will work fine for windows-installer. On windows, may not be using the correct pylintrc? | 13:44 |
ralsina | nessita: I can run it on linux too and do a lint-check pass there | 13:45 |
ralsina | nessita: these are new files, so | 13:45 |
nessita | ralsina: so...? (am I oflfine again :-)) | 13:46 |
ralsina | nessita: so it's new problems :-) | 13:47 |
nessita | gatox: ah, the lint issue appears only in trunk, you're right. The thing is that I also run the tests there to confirm the errors from your branch were new | 13:49 |
gatox | nessita, ok..... fixing that | 13:50 |
nessita | gatox: but the test failures are still there | 13:50 |
nessita | gatox: fixing what? :-) | 13:50 |
gatox | nessita, the test | 13:50 |
nessita | gatox: ack, let me know | 13:50 |
gatox | nessita, ok! | 13:51 |
nessita | @ping | 13:55 |
ubot4 | pong | 13:55 |
gatox | nessita, still network issues? | 13:55 |
nessita | gatox: is wireless adapter issues... seems like the wireless driver sucks bug time | 13:56 |
gatox | ahhhhh | 13:56 |
nessita | gatox: it just hangs and I have to rmmod + modprobe it | 13:56 |
gatox | :S | 13:56 |
nessita | gatox: which is a much nicer workaround that rebooting | 13:56 |
gatox | yep | 13:57 |
nessita | gatox: I run u1lint directly on your windows-installer branch and got what I added as last comment in https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 13:58 |
ralsina | come on, pylint, "f" for a file is perfectly reasonable and traditional! | 13:59 |
gatox | nessita, :S ok.... | 13:59 |
ralsina | nessita: u1lint is failing for me (https://pastebin.canonical.com/57879/), but I am getting 10.0 score from pylint on setup.py of branch https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_809873/+merge/67911 could you do a quick pass? | 14:04 |
ralsina | nessita: mind you, that would be scripts/setup.py | 14:04 |
nessita | ralsina: sure! | 14:06 |
nessita | ralsina: and the naming convention are setting we put ion pylintrc | 14:06 |
ralsina | nessita: it's ok, I put reasonable meaningful names now, was just venting ;-) | 14:06 |
alecu | nessita, I'm having the same issue with my wi-fi driver in P. | 14:07 |
nessita | ralsina: :-) | 14:07 |
alecu | but that's the main complain with P actually, so it's not such a big deal. | 14:07 |
nessita | ralsina: u1lint will not take arguments, FYI | 14:07 |
ralsina | nessita: ok, that explains it | 14:07 |
nessita | alecu: is it also a realtek driver? | 14:07 |
nessita | alecu: this will "fix" it for me: sudo rmmod r8192se_pci && sudo modprobe r8192se_pci | 14:08 |
alecu | nessita, the weird thing is that the *ethernet* driver malfunctions similarly too. | 14:08 |
alecu | nessita, :-) | 14:08 |
nessita | alecu: FYI, I'm still in natty in the laptop | 14:08 |
nessita | but seems like realtek driver are not good, no matter what version :-P | 14:08 |
alecu | nessita, the driver that P is using is rtl8192se, but probably it was renamed in the kernel. | 14:09 |
alecu | nessita, lspci identifies my wi-fi like this: | 14:09 |
alecu | 03:00.0 Network controller: Realtek Semiconductor Co., Ltd. RTL8191SEvB Wireless LAN Controller (rev 10) | 14:10 |
nessita | 02:00.0 Network controller: Realtek Semiconductor Co., Ltd. RTL8191SEvB Wireless LAN Controller (rev 10) | 14:10 |
nessita | the same s***ty one! | 14:10 |
nessita | :-P | 14:10 |
alecu | fu**ing cheap*$$es lenovo! | 14:10 |
nessita | alecu: got my question re: my sso branch? | 14:13 |
alecu | nessita, yes, and I answered it, and looking in the logs it seems like you disconnected just after it. | 14:14 |
nessita | alecu: very likely :-/ | 14:14 |
alecu | nessita, <alecu> nessita, no, I didn't got to the big review it on friday, I'll be doing it today | 14:14 |
nessita | awesome, thanks! | 14:15 |
alecu | nessita, I'll probably trade that review for one or two of mine :-) | 14:15 |
nessita | alecu: shoot! | 14:15 |
ralsina | nessita, alecu: I think I have a reliable USB wifi dongle somewhere. I could send it to one of you :-) | 14:16 |
nessita | ralsina: actually, I have 2, I should try that | 14:16 |
nessita | ralsina: so feel free to send to alecu :-) | 14:16 |
* alecu had one usb dongle that got broken of carrying it in the backpack | 14:17 | |
ralsina | nessita, alecu: well, it's in buenos aires, so I can send it next saturday ;) | 14:18 |
nessita | gatox: can you please add to the fix-link MP instructions to install the new dependency? | 14:19 |
gatox | nessita, i added that to the wiki..... should i include the link of the wiki? | 14:19 |
nessita | gatox: just the new dependency in the MP, please | 14:19 |
gatox | nessita, okas | 14:19 |
nessita | ralsina: (valid) lint issues for your branch http://pastebin.ubuntu.com/798237/ | 14:21 |
alecu | nessita, the first branch I need reviews on is this: https://code.launchpad.net/~alecu/ubuntu-sso-client/proxy-integration-tests/+merge/87538 | 14:21 |
ralsina | nessita: thanks! | 14:22 |
nessita | alecu: looking | 14:22 |
alecu | nessita, you may need to put devtools trunk in PYTHONPATH | 14:22 |
nessita | alecu: what revno? | 14:22 |
alecu | nessita, I have revno 52 here. It's the one where the branch mentioned in the MP was merged. | 14:23 |
nessita | I have 3.1+r52-14~natty1 | 14:23 |
nessita | (installed) | 14:23 |
nessita | so seems like I should not need devtools trunk, no? | 14:23 |
alecu | nessita, cool. I don't have nightlies in this P | 14:23 |
alecu | nessita, right | 14:24 |
ralsina | nessita: I am disabling W0404 because it's a false positive (I am not importing anything in line 35, it's a def) | 14:27 |
ralsina | nessita: pushed revno 95 for another try when you have a minute (no rush) | 14:28 |
=== m_conley_away is now known as m_conley | ||
dobey | hrmm | 14:33 |
nessita | ralsina: you should also disable the following so we get a clean run on linux too: | 14:33 |
nessita | 100: [F0401, get_py2exe_extension] Unable to import 'py2exe.mf' | 14:33 |
nessita | 103: [F0401, get_py2exe_extension] Unable to import 'win32com' | 14:33 |
ralsina | nessita: sure | 14:33 |
dobey | ralsina: we can add the lint checks to tarmac, but i suspect it will be a massive bucket of failures on linux, without all the win32 libs we need | 14:34 |
ralsina | dobey: right. But everything windows-specific is on files called windows.py :-) | 14:34 |
nessita | dobey: actually no, I run that all the time in linux, is not failing | 14:34 |
nessita | dobey: we have the proper disables in place | 14:35 |
dobey | ralsina: lint doesn't care if they're called os2.py :) | 14:35 |
ralsina | dobey: but we can ignore them | 14:35 |
dobey | nessita: ah, ok | 14:35 |
nessita | gatox: you added the instructions to the MP so I can use that? | 14:35 |
gatox | nessita, yep | 14:35 |
nessita | dobey: hello, btw :-) | 14:35 |
dobey | hola nessita | 14:35 |
nessita | gatox: where? | 14:36 |
gatox | nessita, in the description | 14:36 |
nessita | gatox: all I have is "To test in real life, you need to execute the installer with the "--installer param. | 14:36 |
nessita | And configure the VM enabling the net adaptar for the traditional flow and then disabling the net adapter to see the Network Detection page." | 14:36 |
ralsina | nessita: pushed that ignore | 14:36 |
dobey | mandel: you need to fix your bzr config to use the long e-mail address, or add the short one to launchpad :) | 14:37 |
ralsina | dobey: fixed that this morning :-) | 14:38 |
nessita | gatox: so? :-) | 14:38 |
nessita | (am I missing messages?) | 14:38 |
gatox | nessita, here: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-links/+merge/86605 | 14:39 |
gatox | the description of the change | 14:39 |
nessita | gatox: oh, you're right, I was reloading the network-detect proposal :-P | 14:39 |
gatox | :P | 14:39 |
nessita | alecu: ./ubuntu_sso/utils/webclient/tests/test_gsettings.py:56:17: E202 whitespace before ')' | 14:40 |
nessita | gatox: I have 5 tabs with MP in them :-D | 14:40 |
gatox | nessita, fun morning! :P | 14:40 |
nessita | you say fun, I say... | 14:41 |
nessita | :p | 14:41 |
gatox | fun was sarcastic :P | 14:41 |
nessita | gatox: ;-). One tiny note: you don't need to duplicate the same thing you put as commit message to be also merge description. You can either leave the merge descritpion empty, or add relevant info to test IRL, for example | 14:42 |
nessita | but the field can be empty | 14:42 |
gatox | nessita, ahhhh ok | 14:42 |
nessita | ralsina: seems clean re: u1lint your branch now | 14:43 |
ralsina | nessita: cool | 14:44 |
ralsina | nessita: thanks! | 14:44 |
alecu | nessita, gatox: I've been always copying merge description and commit message.... should we only put commit message? | 14:44 |
gatox | alecu, the same here | 14:45 |
ralsina | alecu, nessita, gatox me too (when I put long IRL explanations, manuel complains, BTW ;-) | 14:47 |
nessita | alecu, ralsina: from my POV, there is no gain into duplicating the commit message... no? | 14:48 |
nessita | the field can be empty, so I don't see why putting the same as commit message | 14:48 |
ralsina | nessita: well, the empty space on the page makes me feel guilty? ;-) | 14:48 |
nessita | and I'm +1 to IRL tetsing instructions, almost always! :-) | 14:48 |
nessita | (except for trivial branches) | 14:49 |
ralsina | +1 on using it for IRL instructions, if they are unusual ("run it and see that the bug is not there" is not unusual) | 14:49 |
nessita | gatox: can't install comtypes, I'm getting "The filename, directory name, or volume label syntax is incorrect. Could not open archive" | 14:51 |
nessita | gatox: that's when running the .exe | 14:51 |
gatox | nessita, :S weird...... can you try with the .zip? | 14:51 |
nessita | gatox: did you install it from your weird-unicode-username account? | 14:51 |
nessita | gatox: is an .exe | 14:51 |
nessita | gatox: ah, the zip, will try | 14:52 |
gatox | nessita, there is also the .zip in the linux instruction.... can you try that on windows.... | 14:52 |
gatox | nessita, if that work, i'll remove the .exe reference..... and leave only the zip instruction | 14:52 |
mandel | dobey, I've done both | 14:55 |
mandel | dobey, ralsina told me that I made you loose some time, sorry | 14:55 |
mandel | /me back | 14:55 |
mandel | ralsina, did you run lint on the branch for the installer? | 14:55 |
ralsina | mandel: yes, should be lint-clean on windows and linux | 14:56 |
ralsina | mandel: verified by nessita | 14:56 |
mandel | ralsina, cool, I'll quickly run it in my system and will approve then :) | 14:57 |
ralsina | mandel: awesome! | 14:57 |
dobey | mandel: thanks | 14:58 |
nessita | ralsina: un clon de qué en dónde? | 14:58 |
ralsina | nessita: un clonazepam... para el panico ;-) | 14:59 |
mandel | dobey, sorry again, I did not noticed that I used the short version | 14:59 |
nessita | ralsina: lol | 14:59 |
nessita | ralsina: this laptop has no cdrom :-P | 14:59 |
mandel | dobey, on p, is there a new lint version? | 15:00 |
dobey | http://www.japansubculture.com/2012/01/its-no-ordinary-sale-its-a-fuckin-sale/ | 15:00 |
dobey | mandel: there is a new pylint it seems, yes | 15:00 |
mandel | puto puto puto | 15:00 |
dobey | we need to switch to pyflakes only :) | 15:01 |
mandel | ralsina, nessita I'll have to trust you regarding the lint state of this lp:~ralsina/ubuntuone-windows-installer/fix_809873 and approve, is that ok? | 15:01 |
nessita | me | 15:01 |
nessita | mandel: yes | 15:01 |
mandel | me | 15:01 |
ralsina | me | 15:02 |
dobey | me | 15:02 |
nessita | alecu, gatox: standup? | 15:02 |
gatox | me | 15:03 |
nessita | DONE: freaky friday: continued removing markers from u1client, proposed for merging the branch for fixing IPC in sso | 15:03 |
nessita | TODO: reviews, apparently a lot :-D, help new hire brian get tickets to sprit | 15:03 |
nessita | BLOCKED: nopes | 15:03 |
nessita | NEXT: mandel | 15:03 |
mandel | DONE: Reyes Magos on Friday. Fixed my brz whoami to avoid annoying other team members, sorry again. Done reviews for ralsina and gatox. Work on bug 907511. Had to fight a little with vmware and windows. | 15:03 |
mandel | TODO: run tests for fix of 907511 and hopefully propose it. Sync with alecu regarding which proxy bugs I can tackle. | 15:03 |
mandel | BLOCKED: no | 15:03 |
ubot4 | Launchpad bug 907511 in ubuntuone-client "Windows: events from directories where no watch has been added should be ignored (affects: 1) (heat: 31)" [High,In progress] https://launchpad.net/bugs/907511 | 15:03 |
mandel | ralsina, please | 15:04 |
ralsina | DONE: finished with the windows packaging branch! sprint details finished (so far), canonicaladmin, working some more on the buildout (almost there), general VM housecleaning TODO: propose buildout for merging after packaging branch, bug triage, hiring, etc. BLOCKED: no | 15:04 |
ralsina | dobey? | 15:04 |
dobey | λ DONE: hackday, some gireactor work | 15:04 |
dobey | λ TODO: write proposal for u1 packageset, finish gireactor work, start music store/libsyncdaemon work | 15:04 |
dobey | λ BLCK: No. | 15:04 |
dobey | gatox: | 15:04 |
gatox | DONE: | 15:04 |
gatox | Reimplement network detect in the installer an sso. Review some of the bugs in my queue. | 15:04 |
gatox | TODO: | 15:04 |
gatox | Fix several test in linux for the installer branch | 15:04 |
gatox | BLOCKED: | 15:04 |
gatox | No | 15:04 |
gatox | alecu, go | 15:04 |
ralsina | gatox: another duplicate for your unicode homedir branch, I think: https://bugs.launchpad.net/bugs/913507 | 15:04 |
ubot4 | Launchpad bug 913507 in ubuntuone-client "ubuntu one-windows crahes (affects: 1) (heat: 6)" [Undecided,New] | 15:04 |
nessita | comments anyone? | 15:05 |
gatox | ralsina, roget that | 15:05 |
ralsina | EOM? | 15:05 |
nessita | eom! (I guess alecu will paste his standup when he sees this) | 15:05 |
gatox | ralsina, can i assign that to me? | 15:06 |
ralsina | gatox: of course | 15:06 |
alecu | damn | 15:06 |
ralsina | gatox: but maybe you should just mark it duplicate | 15:06 |
alecu | my irc beep is not working at all | 15:06 |
gatox | ralsina, ah ok | 15:06 |
alecu | @ping | 15:06 |
ubot4 | pong | 15:06 |
alecu | ubot4, ping | 15:06 |
ubot4 | pong | 15:06 |
ubot4 | another contentless ping... sigh... | 15:06 |
mandel | ubot4, ping | 15:07 |
ubot4 | pong | 15:07 |
mandel | ubot4, puto? | 15:07 |
ubot4 | Factoid 'puto?' not found | 15:07 |
mandel | hehe | 15:07 |
mandel | EOM? | 15:08 |
alecu | DONE: worked on restful client replacement, and on another branch to use it | 15:11 |
alecu | TODO: fix restful on P, do reviews | 15:11 |
alecu | BLOCKED: no | 15:11 |
alecu | mandel, I need your review on this branch: https://code.launchpad.net/~alecu/ubuntu-sso-client/proxy-integration-tests/+merge/87538 | 15:13 |
mandel | alecu, on it | 15:13 |
alecu | mandel, and probably this one too: https://code.launchpad.net/~alecu/ubuntu-sso-client/silence-dbus-logger | 15:14 |
* mandel looks | 15:14 | |
nessita | gatox: I was taking to you a lot, and realized my connection was stuck :-) | 15:15 |
nessita | I was saying: | 15:15 |
nessita | (12:06:36 PM) nessita: gatox: why not mark it as duplicate of the master bug? | 15:16 |
nessita | (12:09:28 PM) nessita: gatox: in fix-links, you're modifying run-tests.bat | 15:16 |
nessita | (12:09:32 PM) nessita: gatox: any idea why? | 15:16 |
nessita | (12:10:34 PM) nessita: gatox: (in fact, that change makes running test fail on windows) | 15:16 |
gatox | nessita, i already mark it as duplicate | 15:16 |
nessita | great | 15:16 |
gatox | nessita, i don't recall exactly the reason...... i think that maybe mandel or dobey knows..... but it was failing in the other way.... i'll test it again | 15:17 |
gatox | nessita, about run-tests.bat ^^ | 15:18 |
dobey | huh? | 15:18 |
mandel | nessita, when ubuntu-one-dev tools was changed to use the twisted option parser for some reason we don't know we had to make that change, right dobey ? | 15:18 |
dobey | mandel: oh, the argument ordering? | 15:19 |
mandel | dobey, yes | 15:19 |
nessita | gatox: but your branch is "reverting" the change needed to run properly | 15:19 |
nessita | gatox: the directory with tests should be at the end of the test command line | 15:19 |
dobey | mandel: yeah, it only became obvious after we landed those changes | 15:19 |
gatox | nessita, ok.... i'll change that now | 15:19 |
nessita | gatox: and your branch is moving it back to the middle | 15:19 |
gatox | nessita, reverted | 15:21 |
nessita | gatox: added a needs fixing with several tets failures I got in that branch | 15:21 |
nessita | gatox: I ran the suite under my complex-unicode-username account | 15:21 |
gatox | brb.... need to pay some bills! | 15:21 |
=== gatox is now known as gatox_brb | ||
mandel | alecu, are this two the same? 'parsed_value = True if value == 'true' else False' and 'parsed_value = value == 'true' | 15:22 |
mandel | alecu, line 93 of https://code.launchpad.net/~alecu/ubuntu-sso-client/proxy-integration-tests/+merge/87538 | 15:22 |
alecu | mandel, yes, it's the same construct. I think the former looks nicer, though. | 15:25 |
mandel | alecu, may I know why? just curious :P | 15:26 |
alecu | mandel, "looks nicer" is a purely subjective appreciation. | 15:26 |
alecu | mandel, for instance, you mom may say you "look nice", but most people would disagree. | 15:27 |
mandel | alecu, ah, but you must have a reason, this car looks nicer that the other because I like convertibles instead of sub | 15:27 |
mandel | alecu, same with the mother, I look nicer because I'm her son :) | 15:27 |
alecu | mandel, I don't like " x = y == z" | 15:28 |
alecu | mandel, too many equals together | 15:28 |
mandel | alecu, ah, see, you had a reason :) | 15:29 |
alecu | mandel, I made that reason up just now! | 15:29 |
alecu | mandel, like with all "nicer" stuff, it's just gut feeling | 15:30 |
mandel | alecu, I don't care about the timing ;) | 15:30 |
alecu | mandel, so, I may change it if you still think = == looks nicer. | 15:30 |
mandel | alecu, I have no preference, I was wondering why typing more, that is all | 15:30 |
alecu | mandel, let's ask the team: | 15:31 |
alecu | hey all | 15:31 |
alecu | what do you prefer? | 15:31 |
alecu | + parsed_value = True if value == 'true' else False | 15:31 |
alecu | or | 15:31 |
alecu | + parsed_value = value == 'true' | 15:31 |
alecu | nessita, gatox_brb, ralsina, dobey ^ | 15:32 |
nessita | alecu: definitely the second | 15:32 |
ralsina | alecu: a needle in my left eye? ;-) | 15:32 |
ralsina | the second, with () around the comparison | 15:32 |
dobey | alecu: i prefer foo = bar == 'true' ? True : False | 15:32 |
dobey | but alas | 15:32 |
alecu | dobey, lol | 15:32 |
ralsina | parsed_value = (value =='True') | 15:32 |
nessita | alecu: in the university, we chop off students hands when they do: | 15:33 |
nessita | if (something == true) { ...} | 15:33 |
nessita | which kinda applies to this case | 15:33 |
dobey | but what ralsina said | 15:33 |
alecu | yup, I like the version with parenthesis the most too. | 15:34 |
alecu | mandel, I'm fixing that. | 15:34 |
mandel | ack | 15:34 |
alecu | mandel, damn: the tests in that branch are now failing with squid3 | 15:36 |
alecu | mandel, (I used to ran those tests in Oneiric) | 15:36 |
mandel | alecu, I was going to mention that, but we know hot to fix that :) | 15:37 |
mandel | alecu, it has landed in ubuntuone-dev-tools and I think we should provide MockWebserver for the tests | 15:37 |
alecu | yay, got accepted! http://wiki.qt-project.org/QtonPi/Device_program/Accepted | 15:41 |
mandel | alecu, what is that project for? | 15:42 |
ralsina | alecu: Qt on the raspberry pi? Cool! :-) | 15:45 |
ralsina | alecu: didn't know you were such a big Qt fan! ;-) | 15:45 |
alecu | ralsina, in fact, I'm a huge fan of cheap fanless hardware. | 15:46 |
alecu | "User:alecu (Alejandro J. Cura), port Ubuntu One to Raspberry Pi. I work on the client side of Ubuntu One, and I'd like to see these small devices have access to all kinds of big files stored in the cloud. So I'm proposing to make the Ubuntu One Qt based client work with the Raspberry Pi." | 15:46 |
dobey | i still haven't even turned this i.mx53 board on | 15:46 |
=== gatox_brb is now known as gatox | ||
gatox | back | 15:46 |
elopio | gatox: is there an open bug for ascii issues on windows? | 15:49 |
gatox | elopio, ascii no.... for unicode you have this: https://bugs.launchpad.net/ubuntuone-control-panel/+bug/851356 | 15:50 |
ubot4 | Launchpad bug 851356 in ubuntuone-control-panel "QT UI: Folder list may show garbage for user homes non-ascii (affects: 2) (dups: 1) (heat: 15)" [High,In progress] | 15:50 |
gatox | among others..... all related | 15:50 |
elopio | right, that's what I meant :p | 15:51 |
elopio | gatox: thanks for the link | 15:51 |
gatox | elopio, np | 15:51 |
ralsina | alecu: the pi has very limited storage, so syncing is not going to be useful, unless I am missing something | 15:52 |
alecu | ralsina, perhaps not running a full syncdaemon, but probably will make sense using the storage api | 15:52 |
ralsina | alecu: hopefully you can figure out something cool :-) | 15:53 |
dobey | well, you can add storage to it easily | 15:53 |
dobey | i see USB ports :) | 15:53 |
ralsina | Off for lunch! | 16:07 |
mandel | alecu, I'm going to the pharmacy to buy some drugs I need, I'll be back in 10' if you need me | 16:09 |
alecu | mandel, great, thanks. | 16:09 |
mandel | alecu, I'm back | 16:25 |
nessita | need to reboot | 16:26 |
nessita | will have lunch in the mean time | 16:26 |
alecu | mandel, I think we should remove this: | 16:27 |
alecu | """ # we disable the timeout in the tests, we will deal with it manually. | 16:27 |
alecu | self.timeOut = None""" | 16:27 |
dobey | lunch time, bbiab | 16:27 |
mandel | alecu, sure, does it work without setting the timeout to None? | 16:27 |
alecu | mandel, I think it should, because one is the timeout we force of the server socket, while the other is... | 16:31 |
alecu | mandel, nevermind :P | 16:32 |
mandel | alecu, looping call thingy? | 16:32 |
alecu | mandel, no, I thought that you were disabling the timeout of the tests, but it's just the timeout of the "Site" object, whatever that is. | 16:33 |
alecu | mandel, so don't worry about removing that timeout, my mistake. | 16:33 |
mandel | alecu, yes, it has nothing to do with the tests timeouts, is to prevent some __timeout looping call used in the Site which is used unless you set it to None which then de-activates it | 16:34 |
alecu | mandel, that's right, cool. | 16:34 |
alecu | mandel, so we should keep it. | 16:34 |
gatox | somethinggggggg is really weird with this tests..... :S | 16:36 |
mandel | gatox, they pass:? | 16:36 |
alecu | "I want to shoot... The whole day down, down, down... Shoot it all down!" | 16:36 |
gatox | mandel, no.... they dont..... and all the code is commented.... the function only has the docstring | 16:36 |
gatox | something with some defer...... really weird...... | 16:37 |
* gatox debugging | 16:37 | |
mandel | gatox, may I see the code? | 16:45 |
gatox | mandel, here is the paste of the error: http://pastebin.ubuntu.com/798185/ | 16:46 |
gatox | mandel, this is the branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 16:46 |
gatox | mandel, the last error in the paste | 16:46 |
gatox | mandel, for some reason a defer is failing or somehitng | 16:46 |
gatox | mandel, i'm looking of what might be wrong...... in windows works | 16:47 |
mandel | gatox, so it fails on ubuntu? | 16:47 |
mandel | gatox, which version? | 16:47 |
gatox | mandel, O | 16:47 |
mandel | gatox, I'm getting: RuntimeError('To make asynchronous calls, receive signals or export objects, D-Bus connections must be attached to a main loop by passing mainloop=... to the constructor or calling dbus.set_default_main_loop(...)',) | 16:54 |
gatox | :S | 16:54 |
mandel | gatox, from here: /usr/local/lib/python2.7/dist-packages/ubuntu-sso-client/ubuntu_sso/networkstate/linux.py(129)find_online_state() | 16:54 |
mandel | gatox, know the issue, or at least how it looks to me, is that the dbus mainloop is not set up for it to work correctly, now, I have not look at the code, but I'd take a look if, first you are using a test that suports dbus | 16:55 |
mandel | gatox, that is, DBusTestCase should be the base of it so that the dbus service gets started | 16:55 |
mandel | gatox, but before you get down to all that work, use dbus.set_default_main_loop(...) in the test and test if it works correctly | 16:56 |
gatox | mandel, ok! thanks | 16:57 |
mandel | gatox, try with something like this: http://pastebin.ubuntu.com/798388/ | 16:58 |
gatox | mandel, in the test? | 16:58 |
nessita | mandel: how are you trying to run that? gatox should not be needing to set any dbus loop as default | 16:58 |
dobey | no | 16:58 |
mandel | wait, waith | 16:59 |
dobey | the DBusTestCase needs to be used | 16:59 |
mandel | I'm telling him to see if the main loop is running for dbus to work, because it is not | 16:59 |
gatox | nessita, u1trial --gui --reactor=qt4 -t test_check_connection_with ubuntuone_installer/gui/qt/tests/test_gui.p | 16:59 |
mandel | dobey, I mentioned that already a few mins ago | 16:59 |
gatox | nessita, with export PYTHONPATH:=..... | 16:59 |
gatox | windows-installer | 16:59 |
nessita | mandel: that code should not be used in modules that are libraries, only in executale scripts | 17:00 |
nessita | mandel: what's the problem specifically? | 17:00 |
nessita | gatox: ^ | 17:00 |
nessita | @ping | 17:00 |
ubot4 | pong | 17:00 |
gatox | nessita, the errors in your paste: http://pastebin.ubuntu.com/798185/ | 17:00 |
gatox | the last one that involves a lot of tests | 17:01 |
mandel | nessita, the problem is that his tests are failing because when it calls the sd to ask for the network state it fails, the exact failure is from /usr/local/lib/python2.7/dist-packages/ubuntu-sso-client/ubuntu_sso/networkstate/linux.py(129)find_online_state() | 17:01 |
dobey | why is ubuntuone-windows-installer using dbus anyway? | 17:01 |
mandel | dobey, good question.. | 17:01 |
nessita | gatox: you should patch that, no? | 17:01 |
mandel | dobey, is using sso to know the network state, which uses dbus | 17:01 |
dobey | on linux, right; hrmm | 17:01 |
nessita | mandel: the problem is that gatox should patch that in the windows-installer test | 17:01 |
nessita | dobey: the network_state is a multiplatform method that will use dbus in linux, and something else on windows | 17:02 |
dobey | yeah, patch it | 17:02 |
mandel | nessita, yes, sounds like that | 17:02 |
gatox | i see...... | 17:02 |
gatox | ok..... patching it | 17:02 |
nessita | mandel: remember to never set the main loop default unless you're building a script that starts a dbus service, or that connects to a dbus service | 17:02 |
mandel | nessita, it was for debugging, not a solution | 17:03 |
mandel | nessita, mainly, it was, set it, does it work, bingo you know the issue, now, fix it | 17:03 |
nessita | mandel: but even if for debugging, let's suppose it worked with that... what to do next? :-) | 17:03 |
mandel | nessita, use the DBusTestCase that tell u1trial to start dbus for you, and mock the object on the other side of dbus, or patch the original call and just state is called | 17:04 |
nessita | gatox: understand the problem? your installer branch is querying the real network service :-) | 17:04 |
gatox | nessita, yep.... i see it now also with a print | 17:05 |
nessita | mandel: right, but since we're building multiplatform code, using DBustestCase is not an option | 17:05 |
nessita | because the multiplatform specifics are already isolated in sso | 17:05 |
mandel | nessita, uh, you are right, I forgot about that detail, sorry, but it was just a way to point gatox in the right direction | 17:05 |
nessita | mandel: thanks... I must confess I got scared when I saw you advising that :-P | 17:06 |
mandel | nessita, I understand, out of context it does sound terrible :) | 17:06 |
gatox | nessita, mandel thanks! now i have more idea what is going on | 17:06 |
dobey | nessita: me too :) | 17:07 |
nessita | @ping | 17:33 |
ubot4 | pong | 17:33 |
mandel | ralsina, nessita, gatox, dobey so we lost alecu due to energy issues | 17:51 |
nessita | oh | 17:51 |
gatox | yep | 17:51 |
nessita | I'm about to be next | 17:51 |
gatox | or he wanted just to take the day off | 17:51 |
gatox | jejeje | 17:52 |
nessita | (very likely, temperature is almost 40C) | 17:52 |
gatox | nessita, yep.... | 17:52 |
gatox | :S | 17:52 |
gatox | imposible to go outside | 17:52 |
ralsina | oh, right "my notebook is overheating" <quit> ;-) | 17:52 |
dobey | nessita: get a block of ice for your computer | 17:52 |
gatox | ralsina, :P | 17:52 |
nessita | epec will shutdown the power any minute now :-) | 17:52 |
nessita | dobey: I'm with the AA on, but the power supplier usually explodes when th whole city uses it | 17:53 |
nessita | dobey: and given the current C, I bet energy will go out any minute now | 17:53 |
* beuno cranks the A/C down to 16 deg just un case that happens here | 17:53 | |
gatox | nessita, move to nueva cordoba | 17:54 |
gatox | nessita, we always have power | 17:54 |
dobey | nessita: solar panels :) | 17:54 |
dobey | beuno: *brilliant* | 17:54 |
nessita | gatox: my mean side is hoping that epec will leave *you* without any A/C | 17:54 |
nessita | :-D | 17:54 |
gatox | nessita, jeje | 17:56 |
gatox | nessita, it was an honest suggestion mine.... not to make you angry | 17:56 |
beuno | gatox, FIGHT! | 17:56 |
nessita | gatox: the power supplier should provide the same "quality" service to the whole city | 17:57 |
gatox | nessita, obviusly!!.... but we live in argentina :P | 17:57 |
nessita | heh | 17:57 |
ralsina | elopio: in general, bugs < 500000 are not very useful because we are not using that code anymore ;-) | 17:57 |
mandel | nessita, gatox that is the same in spain, plus they cut the water in some areas | 17:58 |
mandel | which is annoying when you need to use the loo | 17:59 |
gatox | no water...... and to hot because there is no power for fan or air conditionar...... | 17:59 |
gatox | mmmmmmm complicated situation | 17:59 |
gatox | jeje | 17:59 |
elopio | ralsina: I agree, but more than 500 bugs open is not manageable. If we are not going to fix some of those bugs, please mark them as "Won't fix". | 17:59 |
ralsina | elopio: cool | 18:00 |
ralsina | elopio: most of them are "that thing doesn't exist anymore" :-) | 18:00 |
ralsina | mandel: check last comment on https://bugs.launchpad.net/bugs/883926 | 18:00 |
ubot4 | Launchpad bug 883926 in ubuntuone-client "[windows] Breaks on system directories My Music, My Videos dirs in ~\Documents folder on Win7 (affects: 7) (dups: 3) (heat: 46)" [Critical,Fix released] | 18:00 |
elopio | ralsina: yes, invalid sounds even better :D | 18:00 |
mandel | ralsina, elopio if does are u1 windows related, send them to me :) | 18:00 |
ralsina | mandel: I think I already closed all the first-beta bugs | 18:01 |
mandel | ralsina, which revno is the release he is talking about? | 18:01 |
elopio | mandel, ralsina, I'm not sure where to start. Today I'll focus on lucid. | 18:01 |
gatox | brb....... need to buy citric :P | 18:01 |
elopio | Windows is on wednesday, because if I start using windows on mondays, by thursday I'll quit. | 18:02 |
ralsina | elopio: evything you find pre-lucid, mark as invalid | 18:02 |
mandel | ralsina, 2.0.3 release... I have no idea which code was sent there | 18:02 |
mandel | elopio, reasonable ;) | 18:02 |
ralsina | mandel: I can tell you the revnos in a minute | 18:02 |
mandel | ralsina, please | 18:02 |
ralsina | mandel: well, I have to install it first ;-) | 18:03 |
ralsina | mandel: it's revno 1169 of ubuntuone-client | 18:10 |
mandel | ralsina, it should be fix... AFAIK | 18:11 |
mandel | ralsina, we need to get the logs, I'll take care of it | 18:11 |
ralsina | mandel: what I thought | 18:11 |
ralsina | mandel: could be he is still running 2.0.2 after upgrading becuase it doesn't restart itself | 18:11 |
mandel | ralsina, sounds possible | 18:12 |
mandel | ralsina, but It will be very very strange | 18:14 |
ralsina | mandel: not really. Aslong as the user doesn't logout, it will keep running the old version | 18:15 |
ralsina | mandel: and I log out about once a week. | 18:15 |
gatox | nessita, branch updated: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 18:22 |
nessita | ack | 18:22 |
elopio | hey ralsina, should we have a separate master bug for CPU usage? | 18:24 |
ralsina | elopio: could be. | 18:25 |
ralsina | elopio: yes | 18:25 |
dobey | whee | 18:25 |
elopio | ralsina: I'll open one and try to send as duplicate all the bugs I find. | 18:25 |
dobey | dirspec MIR filed. | 18:25 |
ralsina | elopio: cool | 18:25 |
nessita | dobey: wanna do a 2x2 and file the qt4reactor MIR? ;-) | 18:26 |
dobey | nessita: i thought you were going to do that one | 18:26 |
nessita | dobey: yeap, I was, but tons of other sutff came up | 18:26 |
dobey | i really want to get the gi reactor stuff finished today | 18:27 |
mandel | ralsina, nessita, dobey, gatoxok, EOD for me, I'll be around later on irc doing other things yet feel free to ping me | 18:27 |
nessita | dobey: sure, it makes sense. Is there any chance you queue that up for after that? | 18:27 |
dobey | which i can hopefully finish in within the next hour or so. and then start working on the libsyncdaemon/libu1/musicstore mess | 18:28 |
dobey | nessita: maybe. qt4reactor scares me :) | 18:28 |
dobey | because i basically know nothing about it | 18:28 |
nessita | heh, why? :-) | 18:28 |
dobey | i've never talked to upstream. i don't know if there is a release schedule or what. or what the maintenance requirements of it might or might not be. | 18:29 |
ralsina | mandel: did you approve my branch? | 18:29 |
nessita | dobey: hum, none of us know that | 18:30 |
dobey | so it's not simple, like dirspec is | 18:30 |
dobey | nessita: right, and that's a problem for an MIR :) | 18:30 |
nessita | yes | 18:30 |
mandel | ralsina, I think I did, let me check | 18:30 |
nessita | ralsina: how can we move forward with the qtreactor MIR given that? ^ | 18:30 |
dobey | also, i really don't like qt :) | 18:30 |
ralsina | nessita: well, we can contact upstream | 18:31 |
nessita | dobey: that's orthogonal | 18:31 |
dobey | yes | 18:31 |
dobey | but i had to say it :) | 18:31 |
dobey | it's in a contract | 18:31 |
ralsina | dobey: felt good? ;-) | 18:31 |
mandel | ralsina, ha, I wrote the comment but I did not hit save | 18:31 |
mandel | ralsina, should be approved now | 18:31 |
ralsina | mandel: awesome! thanks! | 18:31 |
ralsina | nessita: we have the big branch for windows packaging with +1 from diego and manuel.Approve or you want to take a look? It's really not fun to look at ;-) | 18:32 |
nessita | ralsina: go ahead. Did you got the MIR question? | 18:33 |
mandel | dobey, so... you are not pushing the qt reactor base on Pyside upstream... common you are the only one that has pushed a reactor already! | 18:33 |
dobey | http://www.youtube.com/watch?feature=player_detailpage&v=5A0-u85aAYg#t=157s | 18:33 |
ralsina | nessita: got it and answered it | 18:33 |
dobey | mandel: huh? | 18:33 |
ralsina | mandel: we are not even using PYside | 18:33 |
nessita | ralsina: ah, sorry, missed that. Upstream was contacted when we did the packaging, and they basically answered "I won't be maintaining this anymore" | 18:34 |
ralsina | nessita: then I say we package it and support it as well as we can, since we have nothing else | 18:34 |
ralsina | nessita: in any case, it's temporary because we are moving to a replacement IIRC what you and mandel mentioned a while ago, right? | 18:34 |
ralsina | mandel: the branch still has a needs fixing from you | 18:35 |
dobey | gtk+? | 18:35 |
nessita | ralsina: no... no replacement for at4reactor as far as I know | 18:35 |
mandel | is just to make dobey work on qt :) | 18:35 |
ralsina | nessita: ok, then we have to live with it, and support it if noone else does | 18:35 |
nessita | ralsina: so, we need to write a MIR for qt4reactor, and I'm not sure that with the sentence "we'll support it as well as we can" we're gonna get it :-/ | 18:36 |
mandel | ralsina, here: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_809873/+merge/67911 | 18:36 |
nessita | ralsina: you familiar with what a MIR is? perhaps I'm assuming you're and that's a mistake from me | 18:36 |
dobey | we can make a gtk3 cp for linux ;) | 18:36 |
ralsina | main inclusion request? | 18:37 |
nessita | yes | 18:37 |
ralsina | we can say we own it now and are the new upstream | 18:37 |
ralsina | ans set it up on launchpad | 18:37 |
nessita | ralsina: would you do that? (JIC, https://wiki.ubuntu.com/MainInclusionProcess) | 18:37 |
ralsina | nessita: sure, but not today, I started at 6:30 AM :-P | 18:38 |
nessita | ralsina: sure, I wasn't meaning today :-) | 18:38 |
ralsina | nessita: ok, added to my todo list | 18:38 |
nessita | ralsina: awesome :-) | 18:38 |
Surlent777 | hello; would someone be able to attempt to help me with an issue re: Tomboy and Ubuntu One? | 18:38 |
dobey | nessita: btw, i worked around the precise breakage in nightlies, so you can install new u1client on precise now | 18:39 |
nessita | nice | 18:39 |
Surlent777 | basically, I have a fresh Kubuntu 11.10 installation here, and Tomboy will download notes, but never upload, and as such local changes are overwritten. Yet, on my other computer running 11.10, it all works fine. What can I do to attempt to fix this? | 18:43 |
dobey | joshuahoover, duanedesign, rye: ^^ any ideas for Surlent777's issue with tomboy? | 18:45 |
duanedesign | hi Surlent777 | 18:45 |
Surlent777 | hi; if it helps, I already made a debug log dump, as per a certain forum post, and I could throw it up on pastebin if that would be any help | 18:48 |
duanedesign | Surlent777: I was just about to send you this link :) http://pastebin.com/yiubL41U | 18:49 |
duanedesign | might be what you already did | 18:49 |
Surlent777 | duanedesign: yep; http://pastebin.com/JA2eacEV, set to expire in an hour, as I don't want to be one of Those Guys that leave useless crap on there for eternity | 18:53 |
dobey | ah the "New Note Template" issue | 18:54 |
duanedesign | You will need to delete the New Note Template | 18:55 |
Surlent777 | okay; it's not listed in the main collection of notes. How would I do that? | 18:56 |
duanedesign | ok | 18:57 |
duanedesign | i think what you do is create the note | 18:58 |
Surlent777 | huh, just noticed that not all of my notes seem to have downloaded, judging from what I have on one.ubuntu.com | 18:58 |
Surlent777 | anyway, so make a note entitled "New Note Template", I assume, then what? try to sync, delete, sync again? | 18:59 |
duanedesign | bug #848250 | 19:00 |
ubot4 | Launchpad bug 848250 in tomboy (Ubuntu) (and 1 other project) "Tomboy sync fails on Oneiric, New Note Template already exists (affects: 33) (dups: 1) (heat: 177)" [Undecided,Confirmed] https://launchpad.net/bugs/848250 | 19:00 |
duanedesign | create note "New Note Template" then sync and rename the local note | 19:01 |
duanedesign | Surlent777: comment 10 in the above bug. That seems to do the trick for most users | 19:01 |
ralsina | nessita: th only requirement forMIR that's shaky for qtreactor is " To support a package, we must be reasonably convinced that upstream supports and cares for the package". As a tech lead,do you think we can be the upstream? Because if we can't we need to rethink things ;-) | 19:03 |
nessita | ralsina: exactly my point. I personally don't think we can be upstream of this, which is an issue, yes | 19:04 |
nessita | ralsina: personally but as teach lead. I don't think we have the expertise to maintain a twisted reactor | 19:04 |
nessita | ralsina: nor the time in the roadmap | 19:05 |
nessita | ralsina: what do you think? | 19:05 |
ralsina | nessita: ack | 19:05 |
ralsina | nessita: well, I don't know how much maintenance this would need | 19:05 |
ralsina | nessita: don't have the knowledge to have an informed opinion | 19:05 |
nessita | ralsina: me neither, and I think we both don't know because we don't understand it that much :-) | 19:06 |
ralsina | nessita: agreed | 19:06 |
Surlent777 | duanedesign: I used the "create the note on u1's site" variant, and that seems to have done the trick. Thank you very much; I had no idea that template had anything to do with it | 19:06 |
duanedesign | Surlent777: great! | 19:06 |
ralsina | gatox: does this log look like a unicode bug to you? | 19:08 |
ralsina | gatox: https://bugs.launchpad.net/ubuntuone-client/+bug/883926/+attachment/2664809/+files/syncdaemon.log | 19:08 |
ubot4 | Launchpad bug 883926 in ubuntuone-client "[windows] Breaks on system directories My Music, My Videos dirs in ~\Documents folder on Win7 (affects: 7) (dups: 3) (heat: 50)" [Critical,Fix released] | 19:08 |
* gatox looking.... | 19:08 | |
gatox | ralsina, yep..... it's looks like it | 19:10 |
ralsina | gatox: could you reply to him and point him to the right bug? | 19:10 |
gatox | ralsina, ok..... only because "unicode" is my middle name | 19:10 |
gatox | jejeje | 19:10 |
ralsina | hehe | 19:11 |
ralsina | I see unicode, I think of you, Diego! | 19:11 |
gatox | jejjej | 19:11 |
alecu | mandel, nessita: I've pushed some fixes to the branch you guys were reviewing: https://code.launchpad.net/~alecu/ubuntu-sso-client/proxy-integration-tests/+merge/87538 | 19:21 |
nessita | alecu: ack! | 19:24 |
nessita | ralsina: so, I'm thinking in background about the qt4reactor MIR | 19:25 |
ralsina | nessita: yes? | 19:25 |
nessita | ralsina: and I remembered what you suggested about us talking about the possibility of not depending on it on linux | 19:25 |
nessita | ralsina: and we *could* not depend on it once we use the webclient alecu and mandel are working on, but I'm not 100% sure, so | 19:26 |
nessita | ralsina: is alecu attending to the sprint, at least a couple of days? I would love to analyze this in depth with him | 19:26 |
ralsina | nessita: yes, he is at least 2 or 3 days | 19:26 |
ralsina | nessita: we can move it to a full week if it's ok with him, too | 19:27 |
nessita | ralsina: well, then I would put on hold the qt4reactor MIR until he and I analyze this and put a plan together to remove that dep in linux | 19:27 |
nessita | ralsina: how does that sound? | 19:27 |
ralsina | nessita: cool. Timing scares me a bit | 19:27 |
nessita | ralsina: to me too | 19:27 |
nessita | alecu: what do you think? | 19:27 |
nessita | ralsina: do you know brian IRC nickname? | 19:29 |
nessita | @ping | 19:29 |
ubot4 | pong | 19:29 |
alecu | nessita, ralsina: I think it's feasible to get rid of the qt3.99reactor on linux, but we need to check around to make sure. | 19:29 |
* nessita is afraid to loose connection any time | 19:29 | |
ralsina | nessita: nope. You have his email though :-) | 19:29 |
nessita | ralsina: yes, but I'd need better throughput than that, just for now that we're coordinating his plane ticket | 19:29 |
ralsina | nessita: I meant, I don't, but we can ask him ;-) | 19:30 |
nessita | ralsina: yeah, but seems like he's not onto his gmail email while at work | 19:30 |
nessita | (how dare he? :-P) | 19:30 |
ralsina | nessita: probably a slightly more fascist work environment than ours ;-) | 19:31 |
ralsina | OK, goota run. I may be slightly late tomorrow. Mail me if you need anything early. | 19:45 |
gatox | ralsina, ack! | 19:51 |
dobey | yay, almost done | 19:56 |
dobey | sigh :( | 20:08 |
gatox | EOD!!! see you tomorrow!! | 20:10 |
gatox | alecu, ahhhhhhh you are here..... maybe you would enjoy to review this: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 20:11 |
* gatox run... | 20:12 | |
gatox | jejej | 20:12 |
alecu | gatox, run away! I'm reviewing a 7k-line branch by naty | 20:12 |
gatox | alecu, :S ok...... i'm not going to bother you....... | 20:13 |
alecu | gatox, I may review it tomorrow... sorry! | 20:13 |
gatox | alecu, no problem!! i'm in eod..... | 20:13 |
gatox | alecu, tell nessita that she is not thinking in your mental health :P | 20:14 |
nessita | gatox: aux le contraire! | 20:14 |
gatox | :P | 20:15 |
dobey | gah, this sucks. twisted hates me. | 20:26 |
beuno | dobey, don't worry, it hates everybody | 20:28 |
dobey | yes, but *i* have to figure out what broke, and is causing it to infinite loop and eat all my ram. | 20:41 |
alecu | dobey, mandel: do you have any idea why this is happening??? | 21:00 |
alecu | https://bugs.launchpad.net/ubuntuone-dev-tools/+bug/913968 | 21:00 |
ubot4 | Launchpad bug 913968 in ubuntuone-dev-tools "Could not locate suitable squid.conf.in (affects: 1) (heat: 6)" [High,New] | 21:00 |
dobey | doh | 21:02 |
dobey | setup.py | 21:02 |
dobey | alecu: https://code.launchpad.net/~dobey/ubuntuone-dev-tools/fix-913968/+merge/87983 | 21:06 |
alecu | dobey, +1 | 21:15 |
alecu | nessita, if you are still around, can you please review the trivial branch above by dobey? | 21:16 |
=== JanC_ is now known as JanC | ||
nessita | alecu: sure! | 21:16 |
dobey | not necessary | 21:17 |
dobey | i already set it to approved :) | 21:17 |
alecu | nessita, ^ | 21:17 |
nessita | ack! | 21:17 |
dobey | it might take a while for the nightlies to get built once it lands though. i saw earlier in #launchpad that apparently PPA builders are pretty backed up :( | 21:18 |
alecu | dobey, :-( | 21:19 |
dobey | well that's not as bad as my luck with twisted is right now, anyway | 21:20 |
=== yofel_ is now known as yofel | ||
alecu | dobey, what's the problem now with it? | 21:22 |
dobey | the test suite is hitting an infinite loop and eating all my ram, it seems, with my latest changes to refactor gireactor/gtk2reactor into a single base class that both use instead | 21:25 |
alecu | dobey, do you want me to take a look at that branch? | 21:25 |
dobey | if you want. i'm not sure what i could have changed to cause it :( | 21:26 |
dobey | lp:~dobey/twisted/gi-support | 21:26 |
dobey | alecu: "PYTHONPATH=. bin/trial -r gi twisted" will show the problem when it gets to the manhole tests | 21:29 |
=== gatox is now known as gatox_away | ||
mandel | alecu, I was going to review dobey branch.. I suppose is not longer needed :P | 21:39 |
mandel | alecu, if you don't mind, I'll finish your review tom | 21:40 |
* mandel reboots | 21:40 | |
nessita | so, I'm of | 21:43 |
nessita | off* | 21:43 |
nessita | will do fixed reviews tomorrow | 21:43 |
dobey | my brain hurts and i am upset that this isn't working :-/ | 21:51 |
alecu | dobey, I've started commenting all the testcases that hang up, and most of them have "Stdio" in their names | 21:54 |
alecu | well, not everyone: | 21:54 |
alecu | SystemEventTestsBuilder_GIReactor.test_callWhenRunningOrder | 21:55 |
dobey | testClassDefinition doesn't have "Stdio" in it :) | 21:57 |
dobey | well, so the tests all worked fine in the previous revision :( | 21:57 |
alecu | right, I see that they are working fine in the previous revision after a "merge from trunk" | 21:59 |
dobey | well they were working fine before the merge from trunk as well | 22:00 |
alecu | well, it's a non-trivial branch by far, so I'm not understanding it at this time. | 22:07 |
alecu | dobey, I'll take another look tomorrow. | 22:07 |
dobey | alecu: ok, thanks | 22:09 |
dobey | alecu: it's not super trivial, but it's not terribly complicated either. it is large though, because of having to keep the gi/gobject bits separate | 22:10 |
dobey | if there was some way to simplify the diff view, it would probably look a lot more trivial than it does now :) | 22:11 |
=== m_conley is now known as m_conley_away | ||
aquarius_at_conf | ralsina, ping | 22:29 |
aquarius_at_conf | rye, ping | 22:29 |
aquarius_at_conf | duanedesign: ping | 22:30 |
duanedesign | hello aquarius_at_conf | 22:30 |
qwebirc716586 | duanedesign: hey | 22:32 |
=== qwebirc716586 is now known as aquariusatconf | ||
dobey | heh | 22:32 |
aquariusatconf | :) | 22:32 |
dobey | hi aquariusatconf | 22:32 |
duanedesign | o/ | 22:33 |
dobey | aquariusatconf: what do you need? | 22:33 |
dobey | you're obviously not at pub, so you're either sick, or you need something :) | 22:34 |
dobey | i bet he timed out | 22:36 |
aquarius_atconf | grrr | 22:36 |
dobey | indeed | 22:36 |
aquarius_atconf | duanedesign: having a problem with u1 for Windows | 22:36 |
aquarius_atconf | duanedesign: File Sync error: local and server roots are different (ROOT_MISMATCH) | 22:36 |
aquarius_atconf | what's that? how do I fix it? | 22:37 |
duanedesign | hmm, ok | 22:37 |
dobey | aquarius_atconf: someone logged in with one account, and then a different one | 22:37 |
duanedesign | aquarius_atconf: two accounts have been used on the same machine | 22:37 |
duanedesign | aquarius_atconf: need to delete the metadata | 22:37 |
duanedesign | which version of windows? | 22:37 |
aquarius_atconf | okokok | 22:37 |
aquarius_atconf | k | 22:37 |
aquarius_atconf | heh, sorry, browser probs too :) | 22:38 |
aquarius_atconf | ok, so... | 22:38 |
aquarius_atconf | how do I fix it? | 22:38 |
aquarius_atconf | am happy to wipe the account details and sign in again | 22:38 |
aquarius_atconf | but I don't knoiw how | 22:38 |
dobey | delete the metadata. or just ignore it, and make a new user on the system to use instead :) | 22:38 |
dobey | (if that's feasible to do anyway) | 22:38 |
dobey | windows 7? | 22:39 |
dobey | i guess yes | 22:39 |
duanedesign | aquarius_atconf: https://pastebin.canonical.com/57909/ | 22:40 |
duanedesign | aquarius_atconf: that should do it^ | 22:41 |
* dobey bets he got dropped again | 22:42 | |
duanedesign | o.O | 22:43 |
duanedesign | dobey sees the future :) | 22:43 |
dobey | heh | 22:43 |
dobey | indeed | 22:43 |
dobey | and i am off | 22:43 |
dobey | later :) | 22:43 |
duanedesign | o/ | 22:43 |
aq_at_conf_2 | foir crying out l.oud | 22:44 |
aq_at_conf_2 | grr | 22:44 |
duanedesign | https://pastebin.canonical.com/57909/ | 22:44 |
aq_at_conf_2 | dobey, duanedesign, sorry, if you said something I missed it | 22:44 |
duanedesign | that was the link i posted if you did not get it :) | 22:44 |
aq_at_conf_2 | cheers | 22:44 |
aq_at_conf_2 | can you paste it to paste.ubutnu.com | 22:44 |
aq_at_conf_2 | am not on my own laptop | 22:44 |
duanedesign | yep | 22:45 |
duanedesign | aq_at_conf_2: http://paste.ubuntu.com/798746/ | 22:45 |
aq_at_conf_2 | duanedesign: ok doing that cheers | 22:51 |
=== gatox_away is now known as gatox | ||
=== gatox is now known as gatox_swim |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!