| === gatox_away is now known as gatox | ||
| === eu is now known as Guest34592 | ||
| o0o0o | File Sync error. (auth failed (AUTH_FAILED)) | 05:52 |
|---|---|---|
| o0o0o | where can i fix that in my ubuntu installation | 05:53 |
| o0o0o | btw i love ubuntuone and lots of my friends an employees use it couse i tell them | 05:53 |
| o0o0o | The information could not be retrieved. Maybe your internet connection is down? | 06:00 |
| o0o0o | well, its not, right? | 06:00 |
| rye | morning | 09:20 |
| rye | o0o0o, hello | 09:21 |
| JamesTait | Good morning, everyone! :D | 09:32 |
| === zyga_ is now known as zyga | ||
| mandel | morning! | 09:54 |
| czajkowski | aloha | 10:11 |
| mandel | czajkowski, hello, how are you recovering from the surgery? | 10:59 |
| czajkowski | mandel: good thanks, catching up on readin | 11:02 |
| mandel | czajkowski, reading is always good in those cases... | 11:07 |
| mandel | czajkowski, I remember when I spent 10 days in hospital back in the day when tv worked by the hour with coins.. | 11:07 |
| mandel | czajkowski, so I kinda know the pain | 11:07 |
| czajkowski | at least I'm at home | 11:07 |
| czajkowski | just not allowed/able to sit for more than 20 mins | 11:08 |
| czajkowski | really not good at doing nothing | 11:08 |
| mandel | czajkowski, can you walk properly? | 11:10 |
| mandel | czajkowski, I saw the pictures.. did not look good to be honest | 11:10 |
| czajkowski | thanks :) | 11:10 |
| czajkowski | mandel: yup I can walk, just slowly and as long as nobody bumbs into me I'm good | 11:11 |
| czajkowski | getting there slowly will take some physio as well to help the nerves in my back get back working | 11:11 |
| mandel | czajkowski, in all this things the physio and the work afterwards is usually one of the most important parts | 11:17 |
| czajkowski | mandel: true, in my case I've been leaning toward the right for the last 6 months so a bit lob sided, so need to retrain my back to stand straight | 11:17 |
| mandel | czajkowski, well, I hope it works out well, I'm sure it will | 11:21 |
| czajkowski | mandel: thanks | 11:21 |
| czajkowski | mandel: not working so loads of time to get better | 11:21 |
| czajkowski | and a weekend in brussels in 3 weeks time :D | 11:23 |
| ralsina | good morning ubuntuoners! | 11:25 |
| mandel | ralsina, morning! | 11:25 |
| mandel | ralsina, hard day with the internet connection, right? | 11:26 |
| ralsina | mandel: oh yes | 11:26 |
| ralsina | I have a 3g dongle that doesn't work, and I can't connect to the bar's wifi for some reason | 11:26 |
| ralsina | But I am staying for the coffee | 11:26 |
| ralsina | I can't drink it but it smells great | 11:26 |
| mandel | ralsina, he, that is unlucky.. | 11:27 |
| ralsina | mandel: tethering is legal in argentina. Specially when they don't know what phone you have ;-) | 11:28 |
| mandel | ralsina, same here, but as soon as the phone company finds out the limit the bandwidth | 11:29 |
| ralsina | hey, the phone can connect to the wifi??? WTF! Tethering to wifi now! | 11:29 |
| mandel | ralsina, that makes much more sense! | 11:30 |
| ralsina | mandel: except the part where the notebook can't connect to the wifi by itself | 11:31 |
| mandel | ralsina, which os?> | 11:31 |
| ralsina | mandel: windows. I tried linux yesterday. Got a whole 92minutes of battery life (it's impoving!) | 11:31 |
| mandel | ralsina, they are working on it | 11:32 |
| ralsina | mandel: I know | 11:32 |
| mandel | ralsina, don't use twisted, it makes it last less :P | 11:32 |
| ralsina | mandel: using windows is driving me nuts | 11:32 |
| mandel | cygwin and vim :) | 11:33 |
| mandel | and a ubuntu vm | 11:33 |
| mandel | or archlinux, your choice | 11:33 |
| ralsina | using VMs forces the CPU to run multicore all the time and cuts battery in half | 11:34 |
| ralsina | in fact, I think that's the problem with linux, it's not throttling the CPU right | 11:34 |
| mandel | ralsina, important question, can you run the ubuntuone-client tests on windows? | 11:34 |
| ralsina | mandel: of course | 11:34 |
| mandel | ralsina, in my machine I have tests failing :( | 11:34 |
| gatox | good morning | 11:34 |
| ralsina | mandel: yikes. Trunk? | 11:35 |
| mandel | ralsina, yes, clean trunk check out | 11:35 |
| mandel | gatox, buenos dias! | 11:35 |
| ralsina | mandel: there were some proplems 2 weeks ago where test file paths were too long, but verterok fixed it | 11:35 |
| ralsina | mandel: running them as soon as the pull finishes | 11:35 |
| gatox | mandel, i propose a branch for u1-client yesterday with new tests, merged with trunk and the tests were ok | 11:35 |
| mandel | gatox, I have broken tests with a clean install, I fear we broke something at some point | 11:36 |
| ralsina | mandel: quick question: if you go here, what's the captcha for you? https://autogestion.personal.com.ar/individuos/CambioClavePaso1.aspx?Login=false | 11:36 |
| mandel | ralsina, PAAIR5 | 11:37 |
| ralsina | mandel: interesting. I get the same captcha every time. Damn proxies. | 11:37 |
| mandel | ralsina, ah, I love proxies.. they are soooo much fun ;) | 11:37 |
| ralsina | at least it respects Shoft-F5 | 11:38 |
| gatox | mandel, try this one if you want.... it's synchronized with trunk and tests are ok: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-links | 11:39 |
| gatox | mandel, i think i fix a test that was broken in trunk there | 11:40 |
| ralsina | Interesting: you can't branch from launchpad without ssh keys anymore | 11:40 |
| mandel | gatox, ok, let me wait 'til the other tests are done and I'll try your branch | 11:42 |
| mandel | ralsina, weird, did you setup the launchpad-login? | 11:42 |
| ralsina | mandel: yes I did | 11:42 |
| mandel | ralsina, might be that | 11:43 |
| mandel | ralsina, if you do not give the lp id to bzr it does not care | 11:45 |
| mandel | ralsina, otherwise it cries | 11:45 |
| ralsina | mandel: ack | 11:45 |
| mandel | gatox, I see that we have a new dep with comtypes, I suppose that there are no issues with py2exe, right? | 11:49 |
| mandel | @ping | 11:56 |
| ubot4 | pong | 11:56 |
| mandel | gatox, I'm getting a few issues with the filesystem notifications, yet I suppose is my vm | 11:56 |
| mandel | ralsina, ha, I found the issues! | 11:59 |
| mandel | and they are easy to solve | 11:59 |
| ralsina | mandel: should I stop the tests? ;-) | 11:59 |
| mandel | ralsina, paste.ubuntu.com/800485 | 12:00 |
| mandel | ralsina, wait 'til the end | 12:01 |
| ralsina | mandel: ok, waiting | 12:01 |
| ralsina | mandel: that looks like a path that is way too long | 12:02 |
| gatox | mandel, it shouldn't be any problem with py2exe.... it's just a python library that uses ctypes | 12:02 |
| ralsina | yes, comtypes should be no problem. Of course now gatox can try it for himself ;-) | 12:02 |
| nessita | hello everyone! | 12:04 |
| gatox | nessita, hi | 12:04 |
| mandel | ralsina, yes, so I have 'broken' tests because tritcask is not using \\?\ | 12:04 |
| mandel | nessita, morning! | 12:04 |
| mandel | gatox, oks | 12:04 |
| gatox | ralsina, yes of course.... can you point me to the branch or something were it was the necessary to build an installer? | 12:05 |
| ralsina | mandel: yes. However, verterok did a branch 2 weeks ago to limit path length. But I suppose it can still go too long | 12:05 |
| mandel | ralsina, and no one got those errors because 'til now we all had set the temp dir of trial to C:\Temp or something of the type hehe | 12:05 |
| nessita | hola gatox, mandel, ralsina | 12:05 |
| ralsina | gatox: it's in trunk now! | 12:05 |
| mandel | ralsina, is due to the test using the trial _temp_dir | 12:05 |
| ralsina | gatox: in ubuntuone-windows-installer, you need to go to scripts and read the README | 12:05 |
| gatox | ralsina, ahhhh it's already merged! great | 12:06 |
| mandel | ralsina, so, shall we consider that a problem? | 12:06 |
| ralsina | buen dia nessita | 12:06 |
| ralsina | mandel: well, it is a problem because tests fail "randomly" | 12:06 |
| ralsina | mandel: if changing it to use literal paths is trivial, go ahead | 12:06 |
| mandel | ralsina, ok, then I'll file a bug then | 12:07 |
| nessita | mandel: saw my email re: the review? | 12:15 |
| mandel | nessita, yeah, let me file a bug and run some tests and will get to it right now | 12:19 |
| mandel | nessita, you will have it before I go for lunch for sure | 12:19 |
| ralsina | mandel: all tests pass for me, except one that didn't stop in time, but may be because the notebook is kinda slow today | 12:21 |
| nessita | mandel: nice! | 12:22 |
| ralsina | mandel: that would be tests.platform.test_filesystem_notifications.MutedSignalsTests.test_file_moved_from_partial | 12:22 |
| mandel | ralsina, yeah, I had the same issue with my vm... | 12:22 |
| mandel | ralsina, I'll look closer into that since I have a branch I wanted to land that won't because of that :( | 12:23 |
| ralsina | mandel: hmmm then maybe that one is really broken | 12:23 |
| mandel | nessita, from ubuntu_sso.main import SSOLogin installs the reactor, right? | 12:23 |
| mandel | ralsina, I sure hope they are not.. | 12:23 |
| mandel | ralsina, I'll run them in the mac where they did pass | 12:23 |
| ralsina | mandel: ack | 12:23 |
| nessita | mandel: it should't. If it does, is a bug | 12:23 |
| ralsina | but anyway, having a tet that only works on fast machines is not great | 12:24 |
| nessita | mandel: the import is there because that code is a tremendous hack and will fly away soon | 12:24 |
| mandel | nessita, ah.. ok | 12:24 |
| mandel | ralsina, nessita FYI: bug 914732 | 12:26 |
| ubot4 | Launchpad bug 914732 in ubuntuone-client "Tritcask tests are broken on Windows (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/914732 | 12:26 |
| nessita | mandel: hum, weird, they run ok in my computer. Timing issue?> | 12:26 |
| nessita | mandel: is this failing in trunk too? | 12:27 |
| mandel | nessita, yes, but they work in your machine because you did set up TRIAL_TEMP_DIR | 12:28 |
| mandel | nessita, so that they work in the vm, remember? | 12:28 |
| nessita | mandel: yes... and how that fix the issue? | 12:28 |
| mandel | turns out that tritcask is not using \\?\ and when you set it the paths are shorter :) | 12:28 |
| mandel | nessita, ^ | 12:28 |
| mandel | nessita, the technical def 'suerte de narices' jeje | 12:29 |
| nessita | mandel: right, and tritcask will never use \\?\ as per what we have talked with guillermo... | 12:29 |
| mandel | nessita, exactly, so we need to do something smart about that | 12:29 |
| nessita | mandel: can you please edit the bug description so it reflects the real problem, please? | 12:30 |
| mandel | nessita, it states the issue AFAIK | 12:30 |
| mandel | nessita, but in the long comment and not the title | 12:30 |
| mandel | from the bug report: 'The following occurs when running the tests on Windows if the TRIAL_TEMP_DIR was not set to a location that will ensure that the paths are not longer than 256:' | 12:30 |
| mandel | and 'In the above error we have a 257 path length.' | 12:31 |
| nessita | right, but as how you present it this looks that could be an issue in real life? | 12:31 |
| mandel | nessita, ok, I'll edit the title then | 12:31 |
| nessita | thanks! | 12:31 |
| ralsina | nessita: it could be a problem only if a username was over 128 characters in length or so | 12:31 |
| nessita | ralsina: yes | 12:31 |
| ralsina | nessita: which I think we can safely ignore | 12:32 |
| nessita | ralsina: well, if we make something smart for the test, that will also fix that case IRL, no? | 12:32 |
| ralsina | nessita: it's only annoying for testing. To which I say "set TRIAL_TEMP_DIR", if fixing it takes more than 20 minutes | 12:32 |
| ralsina | nessita: the IRL is ignorable, and the tests are workaroundable. So I wouldn't spend all that much time in it, unless it's an easy fix | 12:33 |
| ralsina | I mean, mandel could do his checkouts one folder level up and it would work ;-) | 12:33 |
| mandel | nessita, updated bug 914732 | 12:33 |
| ubot4 | Launchpad bug 914732 in ubuntuone-client "Tritcask tests are broken on Windows when the test paths are longer than 256 chars (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/914732 | 12:33 |
| nessita | mandel: awesome, thanks | 12:34 |
| mandel | ralsina, or set TRIAL_TEMP_DIR and forget about it hehe | 12:34 |
| nessita | ralsina: + to not dedicate time in the short term | 12:34 |
| nessita | +1 | 12:34 |
| ralsina | mandel, nessita: verterok did something to limit test path lengths, maybe it's just making a constant lower | 12:34 |
| ralsina | he set it to 32, maybe set it to 20 | 12:34 |
| mandel | ralsina, that is not really a way to solve it, someone stupid (me) could check them out in a deeper folder | 12:35 |
| mandel | ralsina, nessita lets leave it as a known issue, focus on important things and later revisit it | 12:35 |
| ralsina | mandel: any smart solution can be broken by just checking out in a path that's 200-char long :-) | 12:35 |
| mandel | the bug report tells you how to solve it, set TRIAL_TEMP_DIR | 12:35 |
| ralsina | mandel: good, moving on then ;-) | 12:36 |
| mandel | ralsina, no, those would be average solutions, a smart one will allow it to always work :) | 12:36 |
| mandel | but is a blah bug, so lets move on hehe | 12:36 |
| ralsina | mandel: a smart solution would operate a robot hand and smack you for using 200-char paths ;-) | 12:36 |
| mandel | ralsina, I'm more worried about the event tests failing | 12:36 |
| ralsina | mandel: yes, if it's really timing dependent it's broken | 12:37 |
| mandel | nessita, can you please run the windows tests from trunk? ralsina and I are seeing problems | 12:37 |
| nessita | mandel: sure | 12:37 |
| mandel | thx | 12:37 |
| mandel | nessita, in your branch, when sending a signal for an error we are doing error_dict = except_to_errdict(error) yet we are logging the error, do you forsee that as a problem? | 12:39 |
| nessita | mandel: not really... do you? | 12:39 |
| nessita | mandel: you would like to log the dict? | 12:40 |
| mandel | nessita, no, but since we are sending the dict and not the error.. I wanted to double check | 12:41 |
| nessita | mandel: we're sending the dict to the "IPC" layers | 12:41 |
| mandel | nessita, ok | 12:42 |
| mandel | nessita, what is the reasoning for 'len(credentials) > 0:' in line 636 of the diff | 12:43 |
| mandel | nessita, do we ever get '' ? | 12:43 |
| nessita | mandel: we may get {} | 12:45 |
| mandel | nessita, ok | 12:46 |
| mandel | nessita, another question, addCallbacks is not used due to readability, right? | 12:46 |
| nessita | mandel: addCallbacks with 's' to the end? | 12:47 |
| nessita | mandel: or you meant addCallback? | 12:47 |
| nessita | mandel, ralsina: my test run was OK (the only failing test is caused because my username is a very-weird-unicode-one and the fix-links branch has not landed yet) http://pastebin.ubuntu.com/800512/ | 12:48 |
| ralsina | nessita: ok, so there is a test that fails intermittently :-/ | 12:48 |
| nessita | ralsina: can I see your failures? | 12:48 |
| mandel | nessita, with an 's' at the end, the method that adds the callback and the errback: http://twistedmatrix.com/documents/8.2.0/api/twisted.internet.defer.Deferred.html#addCallbacks | 12:48 |
| mandel | nessita, ralsina hm.. that is bad, having tests that fail like that is a PITA.. specially when they happen in my vm.. | 12:49 |
| nessita | mandel: right, I know the methof, but wanted to be sure what you were meatning. The thing is that d.addCallback(f); d.addErrback(g) != d.addCallbacks(f, g) | 12:49 |
| nessita | mandel: do you understand that? ^ | 12:50 |
| nessita | I can explain further | 12:50 |
| ralsina | nessita: lost the log... it was tests.platform.test_filesystem_notifications.MutedSignalsTests.test_file_moved_from_partial and it said "is still running after 8 seconds" IIRC | 12:50 |
| mandel | nessita, please explain it futher, it can be that I don't understand the method | 12:51 |
| nessita | ralsina: that may be cause if you computer is kinda slow or was too overloaded at that moment. Though not good, I would separate timeouts from errors | 12:51 |
| ralsina | nessita: yes, it felt overloaded, so I sort of ignored it. | 12:52 |
| ralsina | nessita: the thing is, if it can't run practically on a VM we are in trouble for testing on windows | 12:52 |
| nessita | ralsina: I run the suite in a vm with windows 7 and 1024 of ram | 12:52 |
| ralsina | nessita: it used to work but now that I am on battery it didn't so it may be because my CPU is throttled | 12:52 |
| nessita | ralsina: right | 12:53 |
| nessita | mandel: looking the drawing in the web, one sec | 12:53 |
| ralsina | nessita: which means it's close to not running :-) | 12:53 |
| ralsina | nessita, mandel: but yes, let's ignore this timeout, at least for now | 12:53 |
| mandel | ralsina, nessita lets add a bug nevertheless.. I've seend the windows trunk going down to hell and it was painful. Keeping track is at least a good practice | 12:54 |
| nessita | mandel: a bug for what exactly? sorry I got lost | 12:55 |
| mandel | nessita, for the fact that some of the tests will be errors in slow machines | 12:55 |
| ralsina | mandel: I wouldn't know what to put in those tests. "tests on windows are slower"? | 12:55 |
| ralsina | mandel: that is not a bug, that's life :-) | 12:55 |
| nessita | mandel: I would avoid having yet another bug for this... since is not likely that we'll fix it any time soon :-/ | 12:56 |
| nessita | mandel: in http://twistedmatrix.com/documents/current/core/howto/defer.html, go to the section "Basic Callback Functions" | 12:57 |
| mandel | nessita, ralsina if they fail due to time, there is something wrong.. at least if we consider them unittest, but I'm not going to argue :) | 12:57 |
| nessita | mandel: see how addCallbacks reads: | 12:57 |
| nessita | It adds a pair of callbacks parallel to each other | 12:57 |
| nessita | mandel: if you go to the schema it references, you can see that | 12:57 |
| nessita | mandel: instead, calling a addCallback and after that an addErrback, will put the callback in one level, and the errback in the level below | 12:58 |
| nessita | mandel: so in the second case (d.addCallback(f); d.addErrback(g)), g will be run either if d failed or if f failed | 12:59 |
| nessita | mandel: makes sense now? | 12:59 |
| alecu | hello #ubuntuone! | 13:00 |
| gatox | alecu, hi | 13:01 |
| nessita | mandel: ping? | 13:01 |
| nessita | hola alecu! | 13:01 |
| mandel | nessita, let me think about it.. | 13:01 |
| mandel | nessita, ok, got you, I just did a small script to get it clear | 13:03 |
| alecu | mandel, it's the second graph in this page: http://twistedmatrix.com/documents/current/core/howto/defer.html | 13:03 |
| ralsina | My notebook must be german, because it's now hungry for power! | 13:03 |
| ralsina | I will have to go hunt for a socket to feed it, will be back ASAP | 13:03 |
| nessita | imagine you have a queue of callbacks and errbacks: | 13:04 |
| nessita | | callbacks | errbacks | | 13:04 |
| nessita | | ... | ... | | 13:04 |
| nessita | calling addCallbacks(f, g) will result the queues to be: | 13:04 |
| nessita | | callbacks | errbacks | | 13:04 |
| nessita | | f | g | | 13:04 |
| nessita | calling addCallback(f) and then addErrback(g) will result in: | 13:04 |
| nessita | | callbacks | errbacks | | 13:04 |
| nessita | | f | no_op | | 13:04 |
| nessita | | no_op | g | | 13:04 |
| nessita | mandel: ^ | 13:04 |
| nessita | yes, enjoy my ascii not-art | 13:05 |
| nessita | :-P | 13:05 |
| mandel | nessita, hahaha is not that bad, and I got it :) | 13:05 |
| nessita | nice! | 13:05 |
| mandel | nessita, shall we start using 2012 in the copyright? | 13:09 |
| gatox | mandel, i did | 13:10 |
| nessita | mandel: I did too | 13:11 |
| mandel | nessita, ubuntu_sso/main/tests/test_clients.py in the branch, not that I would block a branch for such a stupid stupid thing :) | 13:12 |
| mandel | I think I'm more picky with other people branches than mine.. I feel like an asshole | 13:12 |
| nessita | mandel: will change it asap | 13:15 |
| mandel | nessita, don't worry to much, as I said, is stupid | 13:15 |
| mandel | nessita, FYI running tests on linux and widows, if they pass I'll approve :) | 13:16 |
| nessita | nice! | 13:16 |
| nessita | oh no, a windows update broke my VM! | 13:19 |
| alecu | damn wifi | 13:21 |
| alecu | nessita, mandel: can I have a re-review on this branch? https://code.launchpad.net/~alecu/ubuntu-sso-client/proxy-integration-tests/+merge/87538 | 13:22 |
| nessita | alecu: my windows VM just got broken due to a windows update. Were you able to fix the tests? | 13:22 |
| alecu | nessita, yes, I changed "localhost" for "127.0.0.1" and then windows tests stopped timeouting | 13:23 |
| mandel | alecu, windows is stupid.. | 13:24 |
| mandel | I cannot believe tests failed due to that.. | 13:24 |
| alecu | mandel, it just took a bit of time | 13:24 |
| alecu | mandel, my first solution was increasing the timeout of the tests, and it started working | 13:25 |
| alecu | mandel, but it was an ugly solution, and it made the tests slower | 13:25 |
| nessita | alecu: perhaps it was resolving localhost using a "real" dns? | 13:25 |
| alecu | nessita, it certainly looked like that. | 13:26 |
| nessita | alecu: anyways, I will re-review | 13:26 |
| alecu | I'm not sure if it's windows or Qtnetwork | 13:26 |
| ralsina | Hello again! | 13:26 |
| alecu | hello ralsina! | 13:26 |
| alecu | mandel, nessita: did you guys saw this link I pasted before dropping out? http://twistedmatrix.com/documents/current/core/howto/defer.html | 13:27 |
| alecu | ^ specifically the second graph | 13:28 |
| mandel | got that page open already | 13:28 |
| nessita | alecu: yes | 13:28 |
| mandel | nessita, why two steps: 271+ result = f(instance, *a, **kw) | 13:29 |
| mandel | 272+ return result | 13:29 |
| mandel | ? | 13:29 |
| nessita | mandel: I like it better, is easier to put a print in between when needed. But I don't feel that strong about that | 13:29 |
| mandel | nessita, meh, my neither.. python should be smart enough to deal with it | 13:30 |
| mandel | nessita, I'm approving, tests passed everywhere and I've read carefully the code and can't find anything wrong besides style differences between our coding :) | 13:32 |
| mandel | +1!!! | 13:32 |
| mandel | adios mega-branch! | 13:32 |
| nessita | mandel: thanks! | 13:32 |
| mandel | ok, my lunch break is due | 13:41 |
| nessita | alecu: I'm setting up another VM, will run your tests shortly | 14:09 |
| alecu | nessita, btw: pylint on P is complaining about all this, both on your branch and on trunk: http://pastebin.ubuntu.com/800608/ | 14:24 |
| nessita | alecu: we need a tweaked pylint | 14:24 |
| nessita | alecu: which I need to build from source | 14:24 |
| alecu | oh, right. | 14:24 |
| dobey | morning | 14:25 |
| nessita | alecu: if you "eye" confirm it, you can see all those are not True | 14:25 |
| dobey | nessita: logilab issue? | 14:25 |
| alecu | nessita, yes, I know. pylint gets "bitchy" with each passing release. | 14:26 |
| nessita | dobey: yes, I did not built the patched package yet | 14:26 |
| nessita | alecu: now, this is a pythonpath issue | 14:26 |
| nessita | alecu: is an "old" issue -- pylint does not understand namespaces | 14:26 |
| nessita | dobey: would you have the diff patch handy? I'm not sure I have it anymore | 14:26 |
| ralsina | alecu: if a lint checker detected fewer things on a new release, all users that fixed them on the previous one would feel stupid. It's bad marketing. | 14:27 |
| dobey | nessita: it's in the source package for the older versions in the PPA | 14:27 |
| nessita | dobey: great, thanks! | 14:27 |
| alecu | ralsina, that's good marketing, for sure. But we are talking about pylint, a tool known for its bitchiness | 14:27 |
| ralsina | alecu: being nitchy is its job description | 14:28 |
| ralsina | s/nit/bit/ | 14:28 |
| gatox | brb! | 14:28 |
| === gatox is now known as gatox_brb | ||
| alecu | ralsina, well, if with each upgrade I get lots of false positives on code I already sprinkled with pylint "disables", then it's past the useful spot. | 14:29 |
| ralsina | alecu: which is why dobey wants us to use pyflakes ;-) | 14:29 |
| alecu | right! and I could not agree more. | 14:29 |
| nessita | alecu, ralsina: thought is true that we have some false positives with pylint, this is not a new issue | 14:30 |
| nessita | pylint can't handle the .pth files, so we patch it on every release | 14:30 |
| ralsina | the problem is, pyflakes is not nearly bitchy enough | 14:30 |
| ralsina | it misses things like useless imports, which even have performance impact | 14:30 |
| nessita | alecu: branch approved | 14:31 |
| dobey | yay pyflakes! | 14:31 |
| dobey | ralsina: pyflakes complains about unused imports | 14:31 |
| ralsina | dobey: bad example then ;-) | 14:32 |
| dobey | it also has a reasonable upstream, and isn't unreasonably complex itself | 14:32 |
| nessita | ralsina: 1-1! | 14:34 |
| ralsina | nessita: can't mumble because of ambient noise. IRC? | 14:34 |
| nessita | ralsina: oh I was looking forward to mumble/talk | 14:35 |
| ralsina | nessita: I can do mumble in maybe 30 minutes | 14:35 |
| nessita | ralsina: we have standup in 30 minutes... | 14:35 |
| ralsina | nessita: then I am right on time :-D | 14:35 |
| ralsina | nessita: after standup | 14:35 |
| nessita | gatox_brb: I still have test failures on windows for fix-links | 14:45 |
| nessita | added the traces to the MP | 14:46 |
| dobey | alecu: did you get a chance to look at my branch again? i can't seem to find anything obvious. :( | 14:46 |
| === gatox_brb is now known as gatox | ||
| gatox | nessita, really | 14:49 |
| gatox | ?? | 14:49 |
| alecu | dobey, not today, I'll take another look after the stdup | 14:49 |
| dobey | seems to be a timing issue :( | 14:49 |
| dobey | ok | 14:49 |
| dobey | thanks | 14:49 |
| alecu | dobey, what I saw was that all tests passed when I ran it on my laptop with P. | 14:49 |
| dobey | huh | 14:50 |
| alecu | dobey, both with the gi and the gtk3 reactors | 14:50 |
| dobey | i wonder if gtk3 gir is broken somehow on oneiric then. i should try it on P too | 14:50 |
| alecu | nessita, I'm getting some timeouts on your branch when running under windows | 14:50 |
| nessita | alecu: in tcpativation tests? | 14:50 |
| nessita | alecu: I'm getting those in trunk as well (timeouts in tcpactivation)... and I changed nothing re: tcpactivation... | 14:51 |
| * mandel back | 14:52 | |
| alecu | nessita, I'm getting some of those in test_clients, and on many random places too | 14:52 |
| mandel | alecu, nessita I ran it on windows before a a windows update and all passed | 14:53 |
| nessita | alecu: can I see a trace please? | 14:53 |
| alecu | nessita, here are some: http://pastebin.ubuntu.com/800629/ | 14:53 |
| dobey | alecu: odd. they are indeed passing on P for me as well | 14:53 |
| alecu | nessita, I'm running the whole tests now, and I'll send you the whole output | 14:53 |
| nessita | alecu: can you try increasing the timeout from 5 to higher? | 14:53 |
| alecu | nessita, I tried increasing the timeout of the first failing testcase to 20, and it failed too. | 14:54 |
| nessita | ack then | 14:54 |
| alecu | nessita, after it finishes, I'll try by rebooting my VM | 14:56 |
| mandel | alecu, nessita I'll run the tests again just in case.. | 14:57 |
| mandel | nessita, 'cause the timeouts are for the unify branch, right? | 14:57 |
| gatox | nessita, yes.... i have some failures too.... but it was working yesterday.. i'll check that.... also.. some of the failures are from network problems :S | 14:58 |
| gatox | me | 15:00 |
| ralsina | me | 15:00 |
| dobey | not me | 15:01 |
| nessita | me | 15:01 |
| alecu | me | 15:01 |
| gatox | mandel, ? | 15:02 |
| nessita | mandel: me? | 15:02 |
| ralsina | mandel is last, gatox, go! | 15:02 |
| gatox | DONE: | 15:02 |
| gatox | Fixed some branches, changing u1-client to use u1-sso-client NetworkManagerState (i'm making some changes to use the network_detection module more properly because we have some mixed uses in the way of use it). | 15:02 |
| gatox | TODO: | 15:02 |
| gatox | Finish with network detection. | 15:02 |
| gatox | BLOCKED: | 15:02 |
| gatox | No | 15:02 |
| gatox | ralsina, go | 15:02 |
| ralsina | DONE: reviews, trying to automate windows build further (looking good), mgmt call, fought for the internet and won (but it took me all day), shot the sheriff TODO: finish windows build automation, start interviewing mac devs, set goals and stuff for scope contractor, administrivia, shoot the deputy BLOCKED: no, as long as 3G keeps working NEXT: not dobey | 15:02 |
| dobey | λ DONE: gireactor upon the brink of greatness | 15:02 |
| dobey | λ TODO: write proposal for u1 packageset, finish gireactor work, start music store/libsyncdaemon work | 15:02 |
| dobey | nessita | 15:02 |
| dobey | λ BLCK: No. | 15:02 |
| nessita | DONE: reviews, chase reviewers for unify-signal-broadcaster branch, more on bug #839877 | 15:03 |
| nessita | TODO: exactly the same as above :-), plus 1-1 with ralsina | 15:03 |
| nessita | BLOCKED: nopes | 15:03 |
| nessita | NEXT: alecu | 15:03 |
| ubot4 | Launchpad bug 839877 in ubuntuone-windows-installer (and 2 other projects) "When creating a new account, the credentials stored are invalid. (affects: 1) (heat: 7)" [Critical,In progress] https://launchpad.net/bugs/839877 | 15:03 |
| mandel | me | 15:03 |
| alecu | DONE: review for nessita, some debugging with dobey, fixes for my branch being reviewed | 15:03 |
| alecu | TODO: get reviews, push restful-client branch, get back to use-restful-client branch | 15:03 |
| alecu | BLOCKED: no | 15:03 |
| alecu | NEXT: mandel | 15:03 |
| mandel | DONE: Work on 907511, got fix yet tests where failing in my vm. Re-reviewd nessitas branhc. re-reviwed alecus branch | 15:04 |
| mandel | TODO: more on the above bug 907511. Fix tests to work without a time dependence. | 15:04 |
| ubot4 | Launchpad bug 907511 in ubuntuone-client "Windows: events from directories where no watch has been added should be ignored (affects: 1) (heat: 31)" [High,In progress] https://launchpad.net/bugs/907511 | 15:04 |
| mandel | BLOCKED: no | 15:04 |
| mandel | alecu, nessita after the windows update the tests get blocked in test_get_port_if_service_already_started, this is in a Windows 7 x64 under kvm | 15:05 |
| nessita | mandel: run the tests again | 15:06 |
| gatox | ralsina, please let me know when you " shoot the deputy" :P LOL | 15:06 |
| ralsina | gatox: he deserves it | 15:06 |
| gatox | jejee | 15:06 |
| dobey | hrmm | 15:06 |
| dobey | should i get a second monitor | 15:06 |
| ralsina | dobey: yes | 15:07 |
| dobey | 4096x1152 is a lot of pixels. | 15:07 |
| ralsina | dobey: larger/multiple monitors are the single most significant factor in increased programmer productivity, says study | 15:07 |
| ralsina | dobey: or in your case, more powerful microscopes | 15:07 |
| mandel | nessita, ok | 15:07 |
| dobey | heh | 15:08 |
| dobey | a new desk would certainly be helpful right now | 15:08 |
| nessita | mandel: I'm getting the same symptom but in trunk as well | 15:08 |
| mandel | nessita, in the second run, from the unify branch (will run trunk next) I got a couple of timeouts like alecu yet it did not get stuck | 15:10 |
| dobey | hrmm, no. that was the wrong monitor :( | 15:10 |
| ralsina | nessita: mumble when you are ready | 15:10 |
| nessita | mandel: try trunk... run a couple of times | 15:10 |
| mandel | nessita, on it | 15:10 |
| mandel | nessita, alecu I ran trunk 5 times and I got the time outs in one of the runs | 15:15 |
| * gatox lunch....... FYI: my parents came to visit me... just in case having lunch take me more than 1 hour | 15:16 | |
| === gatox is now known as gatox_lunch | ||
| nessita | mandel: that's trunk? | 15:19 |
| dobey | oh wow :( | 15:20 |
| mandel | nessita, yes, trunk failed 1 out of 5 with a timeout issue like the ones reported by alecu | 15:20 |
| dobey | firefox appears to have locked up X hard on my workstation | 15:20 |
| mandel | dobey, where you looking at X ? | 15:20 |
| mandel | hehehe | 15:20 |
| dobey | zombie X | 15:20 |
| dobey | the machine won't even reboot correctly | 15:21 |
| dobey | all i wanted was a second monitor :( | 15:21 |
| dobey | blah | 15:26 |
| dobey | oh | 15:26 |
| mandel | dobey, Ha ha ha ha ha | 15:27 |
| mandel | yofel_, I'll tell you what I want, what I really, really want | 15:27 |
| mandel | So tell me what you want, what you really, really want | 15:27 |
| mandel | I'll tell you what I want, what I really, really want | 15:27 |
| mandel | So tell me what you want, what you really, really want | 15:27 |
| mandel | I wanna, (ha) I wanna, (ha) I wanna, (ha) I wanna, (ha) | 15:27 |
| mandel | I wanna really, really, really wanna zigazig ah | 15:27 |
| dobey | alecu: btw, your dbus logging branch caused the tests to break on maverick and lucid | 15:27 |
| mandel | dobey, at monitor somewhere there.. | 15:27 |
| dobey | grr, firefox crashed again, immediately after restoring the session :( | 15:27 |
| dobey | alecu: https://launchpadlibrarian.net/89535265/buildlog_ubuntu-maverick-i386.ubuntu-sso-client_3.1%2Br829-29~maverick1_FAILEDTOBUILD.txt.gz | 15:28 |
| karni | mandel: I could almost hear the music in my head when I read these words ;] | 15:29 |
| dobey | man, firefox on oneiric really hates life | 15:33 |
| dobey | and i'm running 9.0.1 even | 15:33 |
| mandel | karni, lol | 15:36 |
| mandel | karni, I did when I read dobey :P | 15:36 |
| alecu | damn | 15:36 |
| * karni hasn't noticed dobey's signing ;) | 15:37 | |
| nessita | alecu: did you see mandel's comment re: trunk timeouts? | 15:37 |
| dobey | i sign all the time. singing not so much though | 15:37 |
| dobey | most of the signing is automated though. yay bzr+gpg | 15:38 |
| alecu | nessita, the "1 out of 5", right? | 15:39 |
| karni | dobey: don't make fun of a foreigner ;d typos happen. | 15:41 |
| dobey | hehe | 15:41 |
| nessita | alecu: seems like it | 15:41 |
| mandel | dobey, we are majority... | 15:41 |
| karni | dobey: I've done too much around Single _Sign_ On recently, I guess ;) | 15:41 |
| mandel | alecu, nessita I can write a script on the windows vm to run it a large number of times, shall I? | 15:42 |
| mandel | alecu, nessita I need to finish some work first | 15:42 |
| nessita | mandel: no need :-) | 15:42 |
| mandel | ack | 15:42 |
| nessita | mandel: thanks, really | 15:42 |
| alecu | nessita, mandel: so, after rebooting the windows vm, all tests now pass... I'll try running them 5 times. | 15:47 |
| nessita | alecu: can you also try trunk, if you get timeouts? I would like to confirm if my branch is adding those or not | 15:48 |
| dobey | oi, already 11:00 :-/ | 15:53 |
| dobey | maybe i should upgrade my workstation to precise today | 15:53 |
| dobey | alecu: you don't need to bug with my twisted branch any more btw. seems like an issue with gtk+ gir on oneiric :-/ | 15:59 |
| dobey | alecu: thanks for helping debug though | 16:00 |
| alecu | dobey, cool! | 16:00 |
| alecu | dobey, anytime. | 16:01 |
| nessita | well, the precise installation in my laptop is stuck in "removing conflicting operating system files" | 16:04 |
| nessita | what shall I do? | 16:04 |
| * nessita better asks in #ubuntu-desktop | 16:04 | |
| ralsina | nessita: nothing moving in the other terminals? | 16:07 |
| nessita | ralsina: "other" terminals? | 16:07 |
| ralsina | nessita: ctrl+alt+Fwhatever | 16:07 |
| ralsina | nessita: there you can see what the installer is actually doing | 16:07 |
| nessita | nothing on those screens, just a login | 16:07 |
| nessita | ralsina: top shows no activity | 16:08 |
| ralsina | nessita: no idea then | 16:09 |
| nessita | dobey: ping | 16:13 |
| nessita | dobey: how can I confirm if we still need the "DEB_BUILD_OPTIONS := nocheck" in the rules file for logilab-common? I see you put in the changelog "to avoid running broken tests" but I debuild the package without that and have no errors | 16:15 |
| dobey | nessita: it was probably only needed on oneiric, and may even be fine on oneiric now. but the tests were broken when i fixed the package for oneiric, so i added that in. if it works without on precise, leave it out. | 16:17 |
| nessita | dobey: ack | 16:18 |
| dobey | well, re-proposed the gireactor for twisted. hopefully it will get approved/landed this time | 16:22 |
| alecu | dobey, \o/ | 16:23 |
| dobey | and now, lunch :) | 16:23 |
| nessita | gatox_lunch: network-detetc branch has more than 2 lint issues :-) | 16:23 |
| dobey | bbiab | 16:23 |
| nessita | which are no false positives! | 16:24 |
| alecu | nessita, after rebooting the windows VM, I've ran the tests a few more times, and it passed every time. | 16:31 |
| alecu | nessita, I'm approving the megabranch. | 16:31 |
| nessita | alecu: you rock :-) | 16:31 |
| nessita | alecu: and, the patched pylint is building right now in our ppa for precise, so it can handle namespaces properly | 16:31 |
| nessita | alecu: so it will be available for you (and all) in a few minutes | 16:32 |
| alecu | great | 16:32 |
| === gatox_lunch is now known as gatox | ||
| gatox | nessita, ok.... i'll check that | 16:33 |
| nessita | gatox: you running precise? | 16:33 |
| gatox | nessita, no.... O | 16:33 |
| nessita | gatox: ah, ok, then you don't need what I'm building | 16:34 |
| nessita | alecu, mandel: now that you reviewed the mega branch, this is also needed for u1client nitgthlies to keep working. Is really small: https://code.launchpad.net/~nataliabidart/ubuntuone-client/make-it-work/+merge/87767 | 16:42 |
| mandel | nessita, cool, let me do a 5/10 mins errand (give food to the dog) and I'm on it | 16:42 |
| nessita | mandel: sure | 16:43 |
| mandel | alecu, nessita the first 3 lines are hurtful hehehe | 16:43 |
| nessita | juaz | 16:43 |
| alecu | mandel, please also try to finish the review of my branch | 16:43 |
| nessita | mandel: I'm just doing that in every file I modify (and that I remember) | 16:43 |
| mandel | alecu, uh, sorry I just have to run the tests on windows | 16:44 |
| alecu | mandel, cool | 16:44 |
| mandel | nessita, I know, it was a joke hehe | 16:44 |
| nessita | ok, lunchtime for me!!! | 16:44 |
| mandel | ok, I'll be back in 5 min | 16:44 |
| nessita | alecu: does this also depend on your proxy branch? https://code.launchpad.net/~alecu/ubuntu-sso-client/restful-client/+merge/88230 | 16:45 |
| alecu | nessita, yes, right :-) | 16:45 |
| alecu | I'm adding that to the MP | 16:46 |
| nessita | alecu: can I delay the review until that is merged? should be shortly, no? | 16:47 |
| nessita | second precise fresh install attempt is also stuck! | 16:50 |
| nessita | damn | 16:50 |
| nessita | ok, will have lunhc before re-trying | 16:50 |
| mandel | alecu, FYI running tests on Windows if they pass I'll approve the branch | 16:54 |
| alecu | cyclon! | 16:54 |
| alecu | cylon! | 16:54 |
| nessita | my laptop grub is now busted! | 16:55 |
| nessita | grrrrr | 16:55 |
| mandel | alecu, +1 | 16:55 |
| alecu | mandel, yay! | 16:58 |
| mandel | alecu, that means that with that landing I can move to proxy again :) | 16:58 |
| mandel | alecu, let me finish today the filesystem watcher fix (some of the corner cases are giving me issues) and I'll work on it tom :) | 16:59 |
| alecu | nessita, after upgrading my laptop to P a few things were broken all around. suspend didn't work fine, gsd kept crashing so some icons were missing from the unity toolbar, other stuff broken too. I ended up reinstalling, and everything works fine now (minus the usual rmmod+modprobe on the wifi) | 17:00 |
| alecu | mandel, great | 17:00 |
| nessita | alecu: in my case I can not move forward on the install... it freezes | 17:02 |
| nessita | on the step "removing conflicting operating system files..." | 17:02 |
| nessita | even though the partition I marked to be used as / is clean | 17:02 |
| alecu | nessita, oh, I had an issue too while installing from scratch: you should keep *unchecked* both "install mp3 and other stuff" and "download updates while installing" | 17:03 |
| nessita | alecu: those were unchecked as well... | 17:04 |
| nessita | anyways, will have lunch now :-) | 17:04 |
| * alecu should have lunch too | 17:04 | |
| nessita | alecu: python-logilbab-common is now available on precise (0.57.1-1ubuntu1~precise1) | 17:05 |
| alecu | nessita, is that on the nightlies, or main? | 17:05 |
| nessita | alecu: nigthlies | 17:06 |
| alecu | great | 17:06 |
| mandel | ok, while you guys are lunch I'm going to have a cup of coffee :) | 17:06 |
| * mandel => coffee | 17:07 | |
| === m_conley_away is now known as m_conley | ||
| dobey | whee | 17:25 |
| ralsina | dobey: give me good news! | 17:27 |
| dobey | i hath consumed lunch | 17:28 |
| dobey | will poke at the CD image manifest and deps for a little bit, to see what we can get pulled off the CD; then finally on to the libsyncdaemon move | 17:29 |
| ralsina | dobey: thanks about the manifest work | 17:31 |
| dobey | sure | 17:34 |
| dobey | nessita: does ubuntu-sso-client use a twisted reactor for the UI? | 17:39 |
| nessita | dobey: nopes, uses the glib+dbus mainloop | 17:39 |
| dobey | ok, cool | 17:40 |
| nessita | dobey: that may change after the branch I'm building | 17:40 |
| nessita | dobey: the dbus service will use a "basic" reactor and the UI will be opened as a different process, and then the UI can use the toolkit specific mainloop | 17:41 |
| dobey | nessita: but the UI *will* be a separate process, right? | 17:43 |
| dobey | well, it doesn't matter as much once, the new reactor lands. but for now it matters :) | 17:43 |
| nessita | dobey: in that case, yes. The goal is to not need qt4reactor in linux | 17:43 |
| dobey | nessita: well the gtk+ ui wouldn't use qt4reactor anyway | 17:44 |
| dobey | nessita: or have you hashed some new scheme to get rid of gtk+ in sso as well? | 17:44 |
| nessita | dobey: oh no, we need to keep the gtk sso UI... for software center *at least*. And yes, we need to migrate it to gtk3 | 17:44 |
| nessita | dobey: the qt ui would need the qt4reactor if we run it inside sso service, but that's not the idea | 17:46 |
| dobey | right | 17:46 |
| dobey | but that's irrelevant to pulling webkit gtk2 off the cd :) | 17:46 |
| dobey | so it appears to be us, gwibber, and shotwell, that are keeping webkit on the cd | 17:49 |
| nessita | dobey: and shotwell nor gwibber are not going away, no? | 17:49 |
| dobey | i don't know what the plans are for them | 17:50 |
| nessita | dobey: what aboue gtkmm, that you mentioned yesterday? | 17:50 |
| dobey | and everyone is in budapest this week, so asking on irc isn't the quickest thing :) | 17:51 |
| nessita | right | 17:51 |
| dobey | the gtkmm .deb is only 997K :( | 17:52 |
| dobey | so not really helpful | 17:53 |
| nessita | bu :-/ | 17:53 |
| nessita | how much is webkit? | 17:53 |
| dobey | what all does pyqt pull in that totals 13MB exactly? | 17:53 |
| nessita | dobey: no idea how to check, that was info from pitti | 17:54 |
| nessita | dobey: would you teach me? | 17:54 |
| gatox | people.... i'll be back around 18 ART (parents at home).... see you later | 17:57 |
| dobey | hrmm, more qt libs | 18:03 |
| dobey | nessita: apt-cache depends <binary_package_name> | 18:03 |
| dobey | nessita: you'd have to manually weed out the ones that aren't already on the CD, which may or may not be easy | 18:04 |
| alecu | nessita, remember that the sso backend will either use libsoup or qtnetwork, so the gi reactor work is very much needed | 18:04 |
| nessita | dobey: how can I know the weight of each one? | 18:04 |
| nessita | alecu: I was talking about qt4reactor, not the gi reactor | 18:04 |
| dobey | nessita: apt-cache show <package_name>|grep "^Size:" | 18:04 |
| nessita | ah... | 18:05 |
| dobey | ugh | 18:06 |
| dobey | why are the pyqt4 bits not split up into separate packages :( | 18:06 |
| alecu | nessita, I heard you say "the dbus service will use a "basic" reactor"... so I was assuming you meant the standard twisted reactor as opposed to the glib reactor. | 18:06 |
| nessita | alecu: sorry, I mean a reactor provided by twisted itself | 18:07 |
| alecu | ok | 18:07 |
| dobey | alecu: hrmm, with your proxy integration tests branch, sso has a lint error when qt4reactor isn't installed now | 18:10 |
| alecu_ | dobey, do you have a paste? | 18:11 |
| === alecu_ is now known as alecu | ||
| dobey | https://launchpadlibrarian.net/89589377/buildlog_ubuntu-precise-i386.ubuntu-sso-client_3.1%2Br831-29~precise1_FAILEDTOBUILD.txt.gz | 18:11 |
| dobey | in ubuntu_sso/utils/webclient/tests/webclient_demo.py | 18:12 |
| dobey | 23: [F0401] Unable to import 'qt4reactor' | 18:12 |
| nessita | hum, that's a demo | 18:12 |
| nessita | alecu: can you remove that, or make it conditional? | 18:13 |
| nessita | alecu: since qt4reactor is not in the main repo | 18:13 |
| alecu | nessita, dobey: I'm removing that file since it's a demo script to test the webclient module IRL | 18:14 |
| alecu | I'm doing it in my next branch, that will fix the filter issues on maverick and lucid | 18:14 |
| dobey | alecu: great, thanks! | 18:16 |
| alecu | nessita, dobey: https://code.launchpad.net/~alecu/ubuntu-sso-client/textfilter-quacks/+merge/88248 | 18:23 |
| nessita | alecu: why you removed the call to __init__? | 18:23 |
| dobey | nessita: so i'm counting about 9.5MB but perhaps those dependencies pull in a couple others that add the other 3MB | 18:23 |
| dobey | nessita: because he changed it to a plain object | 18:24 |
| alecu | nessita, is it really needed to call __init__ in classes that inherit from object? | 18:24 |
| nessita | dobey: so what? __init__ has to be called the same | 18:24 |
| nessita | alecu: you should... | 18:24 |
| nessita | is not mandatory as in it will work the same | 18:24 |
| nessita | dobey: and ack to the size thingy... would you please add all that to the email with thye summary? | 18:25 |
| alecu | nessita, stackoverflow says: "You don't need to initialize object; its __init__ is a no-op. It's still good practice, though, as you might want to introduce an intermediate class in the hierarchy later on" | 18:25 |
| dobey | well, pyqt can be made smaller | 18:26 |
| alecu | nessita, so, I can restore it if you request. | 18:26 |
| nessita | alecu: if it's not that much trouble for you, yes please | 18:26 |
| dobey | ah. i am dumb | 18:26 |
| dobey | forgot to also include size of python-qt4 itself :) | 18:26 |
| dobey | that makes it 12.15 MB | 18:26 |
| nessita | alecu: I used to have an example of multiple inheritance that is busted if you don't call super() for classs inheriting directly from object... let me find it, is interesting | 18:27 |
| nessita | dobey: nice! (not) | 18:27 |
| dobey | or 12.74 using 1000 instead of 1024 | 18:27 |
| dobey | but python-qt4 can definitely be split up into separate packages | 18:28 |
| dobey | i wonder why debian doesn't do that already, actually | 18:28 |
| nessita | dobey: what else is inside it, in order to be split? | 18:28 |
| dobey | nessita: so qt itself already has lots of functionality split into separate packages (libqt4-dbus, libqt4-opengl, libqt4-network, etc…); but in python-qt4, the bindings for all of those are included in the one package, though they are actually built as separate extensions to python | 18:29 |
| dobey | i don't know how much of kubuntu depends on pyqt though, so there is a potential migration issue | 18:30 |
| dobey | having to have them all be Recommends: after splitting them out, won't really help much :) | 18:30 |
| dobey | but it is something we can discuss | 18:30 |
| alecu | dobey, so, does that mean that by depending on pyqt, you end up depending on libqt4-opengl and such, or is that optional? | 18:31 |
| nessita | dobey: sounds doable for not for P, with a quick overview | 18:31 |
| dobey | alecu: that currently isn't optional | 18:31 |
| nessita | alecu: I have the exmaple for you! is really interesting | 18:31 |
| nessita | alecu: http://pastebin.ubuntu.com/800883/ | 18:32 |
| nessita | alecu: run the alecu.py script with and without the super() calls in A and B | 18:32 |
| dobey | nessita: i think that is doable for P, depending on the circumstances. like i said, it is worth discussing as an option. and in fact, we had to do something similar for couchdb/erlang to get them on the CD back in the day :) | 18:32 |
| alecu | nessita, oh, right: multi-inheritance. I hate that. | 18:33 |
| nessita | dobey: but, do you think/see a way to have python-qt4 splitted in a way that we fit in the CD | 18:33 |
| nessita | ? | 18:34 |
| dobey | nessita: combined with other changes, yes. by itself, no. | 18:34 |
| nessita | alecu: the thing is that even if you are sure you're not using multi-inheritance, other clients may use your class to do so | 18:34 |
| * alecu hopes "the way of the couch" is not in our packages' future. | 18:34 | |
| dobey | nessita: if we split the package, then we don't need to find 13MB any more. we might need to find 1-2MB instead. | 18:34 |
| nessita | alecu: and if your __init__ does not call super(), you'll bust your client __init__ | 18:34 |
| nessita | dobey: 1-2 counting the already free'd 6M? | 18:35 |
| alecu | nessita, don't worry, I already got that, and I'm already running the tests for this chane. | 18:35 |
| alecu | *change | 18:35 |
| dobey | nessita: what already freed 6M? | 18:35 |
| nessita | alecu: is ok, I; m just amazed by that (like the time I found it) | 18:35 |
| nessita | dobey: mono and such? | 18:35 |
| dobey | nessita: i think that 6MB has already been subsumed by something else. the current images are already 705M | 18:36 |
| dobey | well, except for ppc, which is 716M currently | 18:36 |
| nessita | dobey: well, but we need to fight for those 6M since we released them no? | 18:37 |
| * dobey wonders what the hard limit there *actually* is | 18:37 | |
| nessita | those are "ours" :-P | 18:37 |
| dobey | well, *we* didn't release them | 18:37 |
| * nessita will fight for 6M in the CD | 18:37 | |
| nessita | dobey: no? you break my heart | 18:37 |
| * nessita cries | 18:37 | |
| dobey | and there is other stuff we should get rid of | 18:37 |
| dobey | or push to get off the cd anyway | 18:37 |
| nessita | such as? | 18:38 |
| alecu | nessita, super change pushed. | 18:40 |
| nessita | so seems like the daily build of P has the installer busted, because i'm now using the alpha1 image and it will progress | 18:40 |
| nessita | alecu: approved | 18:40 |
| alecu | thanks! | 18:40 |
| alecu | dobey, btw: I was unable to test said branch on lucid to see if it fixed the problem, since I'm not near my lucid vm | 18:41 |
| mandel | allu2, EOD for me, laters! | 18:43 |
| dobey | alecu: i think the problem was with logging.Filter, so changing to object *should* fix it, i think | 18:43 |
| dobey | have a quick appointment, so be back shortly | 18:52 |
| nessita | todo el mundo se va? | 18:58 |
| * nessita piensa esto es un caos! :-P | 18:58 | |
| ralsina | nessita: pilates! ;-) | 18:58 |
| nessita | ralsina: I don't have pilates until next week, I on withdrawal | 18:59 |
| nessita | so I'm bitchier than usual | 18:59 |
| nessita | alecu: my trackpad does not work on precise... does that happened to you? | 19:00 |
| alecu | nessita, all of it works | 19:04 |
| nessita | bu | 19:05 |
| alecu | nessita, Xorg.0.log says: [ 69759.586] (--) SynPS/2 Synaptics TouchPad: touchpad found | 19:06 |
| nessita | alecu: is it listed on lspci? | 19:06 |
| alecu | nessita, it's connected to the PS/2 bus, so it should not show up on lspci | 19:07 |
| alecu | nor on lsusb | 19:07 |
| nessita | alecu: ah... well Xorg log for me has that line too | 19:07 |
| * alecu is tempted to ask "is your clit still working?" | 19:07 | |
| nessita | alecu: it's, thanks for asking :-) | 19:07 |
| nessita | alecu: I just commented on that in u1-internal :-P | 19:08 |
| nessita | sadly facundobatista was not there to confirm | 19:08 |
| nessita | :-D | 19:08 |
| alecu | lol | 19:08 |
| alecu | my irc client is not connecting to the internal irc.... | 19:09 |
| * alecu will be back soon | 19:09 | |
| alecu | nessita, have you tried playing with the fn-key to enable it? it's Fn+F8 in this one | 19:10 |
| alecu | damn | 19:10 |
| nessita | alecu: yes, and looked at dmesg while doing it, to see if something changed | 19:10 |
| alecu | nessita, I did Fn+F8, it got disabled (and I got the desktop notification bubble about that). | 19:11 |
| nessita | alecu: me too, and another bubble when enabling | 19:11 |
| alecu | I tried again, to enable it, and the bubble popped up... | 19:11 |
| alecu | but it's not working anymore!!!!! | 19:11 |
| alecu | bu! | 19:11 |
| * alecu hates the clit on the lenovo | 19:12 | |
| alecu | I want my touchpad back! | 19:12 |
| alecu | nessita, even the two bottoms below the touchpad are useless now | 19:12 |
| nessita | alecu: those work for me... | 19:13 |
| alecu | well, I'm rebooting | 19:14 |
| alecu | or restarting X | 19:14 |
| alecu | bye | 19:14 |
| dobey | back | 19:26 |
| nessita | dobey: would you help me understand why given this http://pastebin.ubuntu.com/800943/ | 19:27 |
| nessita | dobey: apt will not install the 0.57.1-1ubuntu1~precise1? | 19:27 |
| nessita | dobey: as far as I know 0.57.1-1ubuntu1~precise1>0.57.1-1ubuntu1 | 19:27 |
| dobey | nessita: 1~foo < 1 | 19:27 |
| dobey | nessita: you need to make it 1ubuntu2~precise1 | 19:27 |
| nessita | dobey: oh, I see... bu | 19:27 |
| nessita | dobey: I will change that then :-/. Thanks | 19:28 |
| nessita | dobey: would you please explain the rationale behind 1~foo < 1? | 19:28 |
| dobey | nessita: https://help.launchpad.net/Packaging/PPA/BuildingASourcePackage#Snapshots | 19:29 |
| nessita | thanks | 19:29 |
| dobey | although maybe that isn't very clear :) | 19:30 |
| dobey | yeah, just read through that, and it's confusing | 19:30 |
| nessita | dobey: I thought that the versioning was considering > when comparing the strings with > will give truw | 19:30 |
| nessita | true* | 19:30 |
| dobey | nessita: dpkg --compare-versions | 19:31 |
| dobey | nessita: comparing strings directly isn't how it works. :) | 19:32 |
| nessita | dobey: ok, I learn something new today. Thanks! | 19:33 |
| dobey | sure :) | 19:33 |
| nessita | dputting logilab-common_0.57.1-1ubuntu2~precise1 now... | 19:34 |
| alecu | nessita, I just found something that may interest you: | 19:50 |
| nessita | alecu: show! | 19:51 |
| nessita | icecream! | 19:51 |
| nessita | tutucas! | 19:51 |
| nessita | CHOCOLATE CAKE! | 19:51 |
| alecu | nessita, I'm sharing the syncdaemon folders from the host linux with the guest windows inside virtualbox | 19:51 |
| * nessita drools | 19:51 | |
| alecu | nessita, and it kept throwing some weird errors | 19:51 |
| alecu | nessita, stop, it's not cake! | 19:51 |
| nessita | oh | 19:51 |
| alecu | nessita, so the way I found to make it work, was to remove all *.pyc | 19:51 |
| alecu | and now it works. | 19:51 |
| nessita | alecu: not sure what you mean exactly ... what thing does not work if you don't remove the pycs? | 19:52 |
| alecu | the errors were weird, like: "WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect: '"c:'" | 19:52 |
| alecu | nessita, it gave those kind of errors while running run-tests in u1-client inside windwos | 19:53 |
| alecu | nessita, it didn't happen before, it seems to be happening after the move to P | 19:53 |
| alecu | nessita, so, if it happens, that's something to try. | 19:53 |
| nessita | alecu: ah, I'm not getting those... but will keep an eye on it. Thanks! | 19:53 |
| dobey | so gtk2 is definitely not coming off the CD i guess | 19:55 |
| nessita | dobey: :-( | 19:57 |
| alecu | nessita, it's too hot to be reviewing u1-client branches! My laptop going to your make-it-work branch is heating the room! | 19:57 |
| nessita | alecu: but is a very small branch! | 19:57 |
| * alecu votes to only keep developing -sso while the summer lasts | 19:57 | |
| nessita | lol | 19:58 |
| nessita | ok, I'm gone, need to go to the dentist | 20:31 |
| nessita | see ya tomorrow! | 20:31 |
| alecu | gatox, ralsina, dobey: if anyone of you want to do a small review... https://code.launchpad.net/~alecu/ubuntu-sso-client/textfilter-quacks/+merge/88248 | 20:40 |
| dobey | alecu: +1 | 20:41 |
| alecu | great, thanks! | 20:41 |
| dobey | oh shotwell. what a fickle thing you are | 20:43 |
| ralsina | alecu: I am EODing, sorry | 20:45 |
| alecu | ralsina, don't worry, dobey already reviewed it | 20:45 |
| gatox | back!!! finally | 20:46 |
| gatox | alecu, i'll review it now | 20:46 |
| gatox | alecu, ohhhh.... it's already approved | 20:47 |
| gatox | but.... good for you :P | 20:47 |
| alecu | :-) | 20:47 |
| dobey | VERSION = 0.11.91+trunk | 20:47 |
| dobey | insanity :( | 20:47 |
| alecu | what's that version? | 20:48 |
| dobey | shotwell git master | 20:49 |
| dobey | and their daily builds are versioned as 0.11.6+trunk+$revno | 20:50 |
| dobey | and they include debian/ dir inside the git tree | 20:50 |
| dobey | so i'll just forgo the whole "build a snapshot of git master for precise" for now | 20:51 |
| gatox | alecu, are you still working? | 21:48 |
| alecu | I am! | 21:48 |
| alecu | gatox, want to do a review? https://code.launchpad.net/~alecu/ubuntu-sso-client/restful-client/+merge/88230 | 21:48 |
| gatox | alecu, trade! | 21:48 |
| alecu | damn! | 21:49 |
| alecu | gatox, throw it here | 21:49 |
| gatox | alecu, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 21:49 |
| * alecu spent the past two days reviewing or fixing reviews | 21:49 | |
| gatox | alecu, oh...... sorry | 21:49 |
| gatox | alecu, you can leave it for tomorrow if you want | 21:49 |
| alecu | gatox, no prob :-) We had a lot of backlog, and we need to push code forward :-) | 21:49 |
| gatox | alecu, i'll review yours now! | 21:50 |
| alecu | gatox, oh, I already reviewed this branch... like an age ago! | 21:51 |
| alecu | I guess I should start with a clean review now :-) | 21:51 |
| gatox | alecu, yap! that's why i need you :P | 21:51 |
| alecu | gatox, self.setButtonText(QtGui.QWizard.CustomButton1, _("Agree && continue")) | 21:55 |
| alecu | gatox, is "CustomButton1" a good name? | 21:56 |
| gatox | alecu, que pasa con eso? | 21:56 |
| gatox | alecu, it's from qt...... | 21:56 |
| gatox | alecu, i can try to change they mind..... but.... maybe is going to take a while :P | 21:56 |
| gatox | jejeje | 21:56 |
| alecu | gatox, oh, right. Well, it's an ugly API for sure :-) | 21:57 |
| alecu | gatox, nevermind then. | 21:57 |
| gatox | alecu, no..... :( | 21:57 |
| gatox | it's not ugly | 21:57 |
| gatox | jeje | 21:57 |
| alecu | gatox, I thought it was the default name that qtdesigner put for our buttons. | 21:57 |
| gatox | alecu, nono, in the wizard you have NextButton, BackButton (or something like that), Finish, CustomButton1, CustomButton2, CustomButton3 | 21:58 |
| gatox | and maybe something else | 21:58 |
| alecu | well, it makes sense now. | 21:58 |
| alecu | gatox, thanks! | 21:58 |
| gatox | i don't recall exactly.... but thats the idea | 21:58 |
| alecu | gatox, d = yield networkstate.is_machine_connected() | 22:02 |
| alecu | gatox, usually the variable "d" is reserved to hold a deferred | 22:02 |
| alecu | gatox, but since you are already doing yield, it's a result, not a deferred. | 22:03 |
| gatox | alecu, ahhhhh you are right | 22:03 |
| alecu | gatox, so perhaps "connected = yield networkstate.is_machine_connected()" may be a better fit | 22:03 |
| gatox | alecu, i'll change that..... do you want to stop the review?? or check if you find another problems with deferred? | 22:03 |
| gatox | alecu, yep | 22:03 |
| alecu | gatox, no, I'll keep going, since it's not a problem but it's just a naming thing | 22:04 |
| gatox | alecu, ok, thanks | 22:04 |
| alecu | gatox, another smallish thing: I'm not sure showing in the UI the error text is the right thing | 22:06 |
| gatox | alecu, can you point me to the line? | 22:07 |
| alecu | gatox, by error I mean, the error that's coming from the network detect exception | 22:07 |
| alecu | gatox, sure, just a sec | 22:07 |
| gatox | alecu, i have a conflict in your branch | 22:07 |
| gatox | i branch sso | 22:07 |
| gatox | merge with nessita's | 22:08 |
| gatox | and then yours..... | 22:08 |
| gatox | and a conflict appear there | 22:08 |
| alecu | oh, I thought nessita's branch was already merged | 22:08 |
| alecu | gatox, I'll take a look in a minute, thanks for noticing | 22:08 |
| gatox | alecu, ok.... let me know when that is done and i'll review it | 22:08 |
| alecu | gatox, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 | 22:09 |
| alecu | gatox, line 140 | 22:09 |
| alecu | gatox, so, unless the message in that exception is already i18n, I don't think we should show it. | 22:10 |
| gatox | alecu, mmmmmm i know what you mean.... the problem is that the message is for the case when the detection of the connection fails with an exception, so we don't know if we had connection or don't.... just that something were wrong...... | 22:11 |
| gatox | do you think that we just can avoid that message? | 22:11 |
| alecu | gatox, I think we should have a generic/custom error message that's translatable in the U1-win-installer code itself; something like "Cannot get network state" and log the exact reason. | 22:11 |
| gatox | alecu, good idea | 22:11 |
| gatox | can you add that with a need fixing please? | 22:12 |
| alecu | gatox, we should ask design if we should show the message that comes in the exception (my gut feeling is: NO), but in any case it will not be translated. | 22:12 |
| alecu | sure | 22:12 |
| gatox | alecu, thanks! | 22:13 |
| gatox | alecu, probably not..... that's why we have a method in sso to convert that kind of errors to a human readable message | 22:13 |
| alecu | gatox, added NF to the MP | 22:15 |
| gatox | alecu, thanks | 22:15 |
| alecu | gatox, oh, cool. Then we should be either using that method or even better: throwing that human readable message too in the exception from sso | 22:16 |
| gatox | alecu, yes.... but we probably need to twick a little that method for this situation..... but it's a valid solution | 22:16 |
| alecu | right | 22:17 |
| === m_conley is now known as m_conley_away | ||
| gatox | brb!!! | 22:26 |
| alecu | gatox, if you are still around, I've fixed the conflict and pushed the changes. | 22:39 |
| gatox | back | 22:47 |
| gatox | alecu, ok...... reviewing... | 22:47 |
| alecu | gatox, I'm EODing | 22:58 |
| alecu | gatox, bye! | 22:58 |
| gatox | alecu, ok | 23:01 |
| dobey | later all | 23:46 |
| === eu is now known as Guest5160 | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!