| StevenK | steven@liquified:~/launchpad/lp-branches/kill-launchbag-with-fire% bzr grep ILaunchBag | wc -l | 00:01 |
|---|---|---|
| StevenK | 555 | 00:01 |
| StevenK | :-( | 00:01 |
| StevenK | wgrant: QA done | 00:01 |
| wgrant | StevenK: Thankyou sir. | 00:02 |
| StevenK | sinzui: XMLRPC is implicated, which concerns me | 00:02 |
| sinzui | skip it then. change the ones that keep slowing us down | 00:02 |
| sinzui | StevenK, I looked at the template that makes the bug links | 00:03 |
| StevenK | lib/lp/xmlrpc/application.py: caller = getUtility(ILaunchBag).user | 00:03 |
| sinzui | I think the view's .unofficial_tags and .official_tags could make make sane links instead of the template. That would be easier to test | 00:04 |
| StevenK | lib/lp/app/browser/launchpad.py: self.user = getUtility(ILaunchBag).user | 00:04 |
| StevenK | Bah | 00:05 |
| sinzui | StevenK, just focus on bugtask and maybe bugnomination | 00:05 |
| sinzui | StevenK, the bag is not 100% 20% is useful. We get stuck when it is used instead of the context information. | 00:05 |
| StevenK | BugTasksAndNominationsView.current_bugtask == return getUtility(ILaunchBag).bugtask | 00:07 |
| StevenK | sinzui: http://pastebin.ubuntu.com/808023/ | 00:14 |
| wallyworld | StevenK: could you "bin/ec2 land" this for me? my precise system is borked https://code.launchpad.net/~wallyworld/launchpad/subscription-policy-text-912159/+merge/88808 | 00:19 |
| sinzui | StevenK, I think it needs some checking. For example I see in configure.zcml that IBugNomination is the thing that is passed to some the nomination views | 00:20 |
| sinzui | StevenK, and why would get_assignee_vocabulary_info have self.user, it is an 8 line function | 00:24 |
| sinzui | StevenK, the two callsites of get_assignee_vocabulary_info are Lp views and do know the user, so they should pass the user with the context | 00:25 |
| StevenK | sinzui: Right, which I just did. | 00:25 |
| StevenK | sinzui: http://pastebin.ubuntu.com/808035/ is a updated diff | 00:25 |
| sinzui | StevenK, BugListingBatchNavigator is not an Lp view. it I think we could use request.user though | 00:29 |
| StevenK | wallyworld: It has been tossed at ec2. | 00:30 |
| wallyworld | StevenK: thanks. looking at your use-combo branch now | 00:31 |
| StevenK | use-*convoy* | 00:31 |
| sinzui | StevenK, the other option is the make some of the classes inherit from UserAttributeCache which provides .user to lp views | 00:31 |
| wallyworld | yeah, typo | 00:31 |
| StevenK | sinzui: Using request.user sounds fine to me | 00:31 |
| StevenK | I thought after create_initialized_view(), you could call view() to get the actual HTML out? | 00:36 |
| StevenK | sinzui: If you think my launchbag diff is good I can commit, push and create an MP | 00:37 |
| === StevenK changed the topic of #launchpad-dev to: devel broken until r14681 | https://dev.launchpad.net/ | On call reviewer: StevenK | Firefighting: - | Critical bugtasks: 3*10^2 | ||
| sinzui | StevenK, I think the bug nomination changes will break the bugtask ones might work | 00:37 |
| StevenK | cjwatson: r=me for https://code.launchpad.net/~cjwatson/launchpad/archive-copy-packages-source-series/+merge/87942 , shall I land it for you? | 00:40 |
| wallyworld | StevenK: use-convoy doesn't load the yui stuff properly for me, looking to find out why | 00:42 |
| StevenK | wallyworld: Did you 'make clean' and 'make'? | 00:43 |
| wallyworld | StevenK: yep | 00:43 |
| wallyworld | it appears the bootstrap yui.js file is not loaded because of a wrong url | 00:44 |
| lifeless | wgrant: I'd be happier if authenticateUsingBasicAuth wasn't *called* outside the test runner | 00:44 |
| StevenK | wallyworld: Which wrong URL? | 00:44 |
| StevenK | wallyworld: OH! | 00:44 |
| StevenK | wallyworld: You to run sudo make copy-apache-config | 00:44 |
| wgrant | lifeless: It isn't | 00:44 |
| wgrant | lifeless: Which is why it crashes. | 00:44 |
| wallyworld | StevenK: right, i'll do that | 00:45 |
| wgrant | lifeless: See the next hunk, which adds an config.isTestRunner() check to the call | 00:45 |
| lifeless | wgrant: ok, so uhm, comment there that it shouldn't be called | 00:45 |
| cjwatson | StevenK: yes please, thanks | 00:45 |
| wgrant | Sure. | 00:45 |
| lifeless | I was thinking we could put something in the test runner zcml | 00:45 |
| lifeless | but I see its not componentised | 00:45 |
| wgrant | I considered that, but it would need a bit of refactoring. | 00:46 |
| wallyworld | StevenK: apache restart fails with: Invalid command 'WSGIScriptAlias' | 00:47 |
| wallyworld | missing module | 00:47 |
| StevenK | wallyworld: Install libapache2-mod-wsgi | 00:48 |
| * wallyworld does that | 00:49 | |
| === wgrant changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: StevenK | Firefighting: - | Critical bugtasks: 3*10^2 | ||
| StevenK | cjwatson: Right, I've reviewed all four of your branches, I'll toss them all at ec2. | 00:49 |
| cjwatson | StevenK: neat, thanks | 00:52 |
| wallyworld | StevenK: still issues, trying make clean again | 00:52 |
| lifeless | wgrant: anyhow, I don't have anything significant to say | 00:53 |
| lifeless | obviously there is a risk | 00:53 |
| wallyworld | StevenK: i assume we need to include the libapache2-mod-wsgi package as a launchpad dep now | 00:53 |
| StevenK | wallyworld: That can be done at the same time we add convoy | 00:54 |
| rick_h | wallyworld: I don't think so | 00:54 |
| rick_h | it'll be a convoy dep | 00:54 |
| StevenK | Mmmmm | 00:54 |
| wgrant | I don't think convoy should depend on it. | 00:54 |
| wgrant | It can be run in any WSGI server... | 00:54 |
| rick_h | ah, right. and we're serving out of the same apache anyway | 00:55 |
| wgrant | lifeless: I think we should eliminate it eventually, but there are so many tests to migrate. | 00:55 |
| wgrant | And it's not clear what's best to migrate to. | 00:55 |
| wallyworld | StevenK: so, still broken. i'll see if there's anything in the apache logs | 00:55 |
| StevenK | wallyworld: What does wget --no-check-certificate https://launchpad.dev/combo?yui/yui/yui-min.js give you? | 00:57 |
| wgrant | +combo, please | 00:57 |
| wallyworld | StevenK: will try that. btw, saw this in apache error log | 00:57 |
| wallyworld | Traceback (most recent call last): | 00:57 |
| wallyworld | File "/home/ian/projects/lp-branches/devel-sandbox/scripts/branch-rewrite.py", line 15, in <module> | 00:57 |
| wallyworld | import _pythonpath | 00:57 |
| wallyworld | ImportError: No module named _pythonpath | 00:57 |
| * StevenK stabs wgrant | 00:57 | |
| StevenK | wallyworld: Unrelated | 00:57 |
| rick_h | wgrant: I'm going to start working on the convoy parsing the path tomorrow. I'll see if I can get the +combo going. I want to try to keep consistant somewhat with the other teams using it | 00:59 |
| wallyworld | StevenK: it gets me a file containing | 00:59 |
| wgrant | rick_h: Right. | 00:59 |
| wgrant | rick_h: LP is sort of special, though, in that our top-level namespace is user-controlled. | 00:59 |
| StevenK | rick_h: I can switch to +combo pretty easily | 00:59 |
| wallyworld | StevenK: https://pastebin.canonical.com/58279/ | 01:00 |
| rick_h | wgrant: yea, I need to look into the best way to parse the url our to split on host/$disk_path/$ignoreme_or_something | 01:00 |
| rick_h | wallyworld: ok that means that it can't find the files on disk you asked for | 01:00 |
| StevenK | wallyworld: find /var/tmp/convoy -type f | 01:01 |
| wallyworld | rick_h: yeah, figured as much | 01:01 |
| rick_h | wallyworld: but that means it did get served via the combo loader application | 01:01 |
| rick_h | so yay for partial success | 01:01 |
| StevenK | Sucessful failure! | 01:02 |
| rick_h | lol, that's what we decided to call it wasn't it | 01:02 |
| wallyworld | rick_h: StevenK: i suspect the yui tarball is not being unpacked correctly. i think my/deryck's last buildout mods are missing, looking now | 01:03 |
| StevenK | wallyworld: We do that ourselves | 01:03 |
| StevenK | wallyworld: Using bin/combo-rootdir | 01:04 |
| wallyworld | ah ok. our buildout mods are for the legacy launchpad.js then | 01:04 |
| StevenK | Yes. | 01:04 |
| StevenK | And therefore pointless | 01:04 |
| StevenK | Since LP has no hope to build against 3.4.1 | 01:04 |
| StevenK | rick_h: /+combo changes pushed | 01:05 |
| wallyworld | StevenK: rick_h: so here's what's under /var/tmp/convoy/yui: https://pastebin.canonical.com/58280/ | 01:05 |
| wallyworld | StevenK: the idea was that we would just unpack from the tarball the yui build dir | 01:06 |
| wallyworld | which is all the combo loader needs IIUC | 01:06 |
| wallyworld | ie we don't want to copy across all the src etc | 01:06 |
| wallyworld | so we may have a slight disconnect here | 01:06 |
| wallyworld | since what is under /var/tmp/convoy now is not what i was expecting to see | 01:07 |
| wallyworld | /var/tmp/convoy/yui i mean | 01:07 |
| StevenK | wallyworld: Well, everytime I tried to get involved, deryck told me to shush | 01:07 |
| wallyworld | he did didn't he | 01:08 |
| StevenK | wallyworld: bin/combo-rootdir is built from a buildout template, and it will unpack the yui in versions.cfg | 01:08 |
| StevenK | wallyworld: Oh, and be careful running bin/combo-rootdir | 01:08 |
| StevenK | If you run it with no arguments, it will attempt to remove /* | 01:09 |
| wallyworld | StevenK: so, why that script and not a buildout recipe? | 01:09 |
| StevenK | wallyworld: Because buildout recipes are a pox | 01:09 |
| wallyworld | but we have one that works | 01:09 |
| wallyworld | that we were expecting to be used | 01:09 |
| wallyworld | that unpacks the yui files in downlaod cache - the versions we wan tto switch between | 01:10 |
| StevenK | wallyworld: Then you and deryck made lovely assumptions | 01:10 |
| wallyworld | so we can use the feature flag to switch between yui versions on the fly | 01:10 |
| StevenK | And now you get to keep both pieces | 01:10 |
| wallyworld | StevenK: we talked with rick_h about it, and i thought you as well? | 01:11 |
| lifeless | wgrant: I have a suggestion | 01:11 |
| StevenK | wallyworld: I think that work is premature -- we can't switch to 3.4.1 until we are using the combo loader anyway | 01:11 |
| lifeless | wgrant: in BaseLayer set a global variable somewhere. | 01:12 |
| wallyworld | StevenK: exactly, that's what we were prepping for | 01:12 |
| lifeless | wgrant: on nmodule load have it initialize to None | 01:12 |
| lifeless | wgrant: IFF it is set, it is the basic password | 01:12 |
| lifeless | wgrant: if it is not set, basic auth cannot work | 01:12 |
| rick_h | honestly wallyworld, I don't think StevenK and I "got" what you guys were headed towards at the time | 01:12 |
| StevenK | wallyworld: In either case, you need to debug what bin/combo-rootdir is doing | 01:12 |
| wgrant | lifeless: I don't think that will work for testrunner-appserver | 01:13 |
| rick_h | wallyworld: since we were honestly figuring out things ourselves as far as the plan for the on disk layout/setup | 01:13 |
| StevenK | rick_h: Given deryck kept shushing me, I kept my opinions to myself. | 01:13 |
| lifeless | wgrant: well, set it in the config then | 01:13 |
| lifeless | wgrant: *that* will work using the same thing we do for transient rabbit etc | 01:13 |
| wallyworld | StevenK: rick_h: ok. i'll debug it. seems like there was a communications fail there | 01:13 |
| rick_h | wallyworld: definitely | 01:13 |
| rick_h | wallyworld: sorry about that | 01:13 |
| wallyworld | rick_h: no need to apologise - it was a collective failure | 01:14 |
| rick_h | wallyworld: I had hoped to get that stuff merged in to "see" what it was up to while we were together but ran out of time | 01:14 |
| wallyworld | rick_h: StevenK: although, i'm trying the use-convoy branch "out of the box" and it's still failing | 01:14 |
| wallyworld | ie it should work as is | 01:14 |
| StevenK | It can't, so far | 01:15 |
| wallyworld | but i'll find out what's happening in the process of trying to fit the other stuff in | 01:15 |
| StevenK | It needs changes to lp-meta-deps | 01:15 |
| lifeless | wgrant: this then does not depend on the config name, it only depends on us not setting the global basic password in production configs | 01:15 |
| lifeless | something I think we can manage | 01:15 |
| wallyworld | StevenK: what changes? so far, i've installed tne missing deb and updated the apache configs, other than that, it's the vanilla use-convoy branch | 01:16 |
| StevenK | wallyworld: It's *very* rough, currently | 01:16 |
| wgrant | lifeless: Right, but then we depend on lazr.config's somewhat ambiguous behaviour of mapping 'none' -> None | 01:16 |
| wgrant | But I guess | 01:16 |
| wgrant | (I still don't know how that works) | 01:16 |
| StevenK | wallyworld: And installed mod-wsgi | 01:16 |
| lifeless | wgrant: you don't want to. | 01:16 |
| wallyworld | StevenK: yes, that's the deb i was referring to | 01:17 |
| lifeless | wgrant: you can check 'if basic_password and basic_password.upper() != 'NONE':' | 01:17 |
| rick_h | wallyworld: yea, something is up with your paths for the yui files that got unpacked. I don't think "yui-yui3-f332140/src/" should be in the path | 01:17 |
| StevenK | wallyworld: There's two -- convoy and mod-wsgi | 01:17 |
| lifeless | wgrant: if you want less reliance | 01:17 |
| wgrant | lifeless: That's what I was planning. | 01:17 |
| wgrant | But still, ew. | 01:17 |
| rick_h | StevenK: he's getting successful requests from convoy via apache | 01:17 |
| wallyworld | StevenK: ah right, sorry. that's what i meant | 01:17 |
| rick_h | StevenK: it's just saying that it can't find the .js files | 01:17 |
| wallyworld | rick_h: yes, the unpacking of the tarball appears wrong, or incompatible with what the combo loader expects | 01:18 |
| StevenK | rick_h, wallyworld: I've pushed a small change to bin/combo-rootdir that will blow up if you run it with no arguments, rather than attempting to remove /* | 01:18 |
| rick_h | wallyworld: the lp and the yui2 directoryes look right from that pastebin | 01:18 |
| wallyworld | rick_h: yes, agreed | 01:19 |
| wallyworld | StevenK: thanks | 01:19 |
| rick_h | wallyworld: but the yui3 isn't correct, I'm not sure why off the top of my head. I've not pulled StevenK's latest stuff yet. On the docket for tomorrow | 01:19 |
| StevenK | I'm not looking forward to merging devel | 01:19 |
| wallyworld | rick_h: StevenK: so, the buildout recipe unpacks the yui tarballs to build/js/yui | 01:19 |
| rick_h | wallyworld: right, which should now be /var/tmp/convoy/yui | 01:20 |
| wallyworld | and then i expect this will be what's copied over to /var/tmp/convoy | 01:20 |
| StevenK | All tarballs? | 01:20 |
| wallyworld | StevenK: yes, so we can switch between them | 01:20 |
| wallyworld | using the js.yui-version feature flag | 01:20 |
| StevenK | At the moment, we don't deal with multiple yui versions in our use of the combo loader | 01:20 |
| StevenK | This is why I said it's premature | 01:20 |
| StevenK | We haven't even figured out all the pieces and stuff is moving out from under us | 01:21 |
| wallyworld | ok, for now we just need to get it working with the expected version for prod | 01:21 |
| wallyworld | but one of the value props here is the ability to easily test qastaging against another yui version for example | 01:21 |
| StevenK | Sure | 01:22 |
| wallyworld | or locally as well of course | 01:22 |
| StevenK | But let's get the combo loader working first before we start changing other stuff | 01:22 |
| wallyworld | that was my plan for now :-) | 01:22 |
| rick_h | and a fine plan that is | 01:23 |
| rick_h | wallyworld StevenK, I'm going to head offline in a bit for the night. Shoot me an email with where things are so I can pick them up tomorrow. I've got a call with deryck to go over the details on where to head from here | 01:24 |
| wallyworld | rick_h: StevenK: so, i don't think i'll have to do much - just take the tarball unpacking out of combo-rootdir and replace with a copy from the buildout stuff | 01:24 |
| wallyworld | rick_h: np. goodnight. thanks | 01:24 |
| rick_h | wallyworld: ok, let me know where that's at once working and I'll make sure to pull that in locally as well | 01:25 |
| rick_h | wallyworld: or get StevenK to update his branch with it before EOD for you guys | 01:25 |
| StevenK | wallyworld: build/js/yui/yui-3.3.0 is empty for me | 01:25 |
| wallyworld | rick_h: will do. | 01:25 |
| wallyworld | StevenK: let me poke a bit on my disk to have a look | 01:25 |
| wallyworld | StevenK: my dir has all the expect yui stuff. try rm .installed.cfg and rerun buildout | 01:27 |
| StevenK | wallyworld: make clean and make results in the jsbuild stuff being unable to find lib/canonical/launchpad/icing/yui/yui/yui.js | 01:31 |
| * wallyworld scratches head | 01:32 | |
| wallyworld | StevenK: did you rm .installed.cfg to force buildout to run from scratch? | 01:32 |
| StevenK | wallyworld: Yes | 01:32 |
| wallyworld | StevenK: maybe try manually rm the yui dir in icing? | 01:33 |
| wallyworld | i'm not sure what's happening to be honest. i'm running directly off the use-convoy branch | 01:34 |
| StevenK | wallyworld: lib/canonical/launchpad/icing/yui links to build/js/yui/yui-3.3.0 which is empty | 01:36 |
| wallyworld | StevenK: is your download cahce up to date? | 01:36 |
| wallyworld | StevenK: the tarball has been renamed | 01:37 |
| StevenK | Which was a pointless renaming | 01:38 |
| wallyworld | there's a yui-3.3.tar.gz and also a yui-3.3.0.tar.gz the 3.3.0 version is new | 01:38 |
| wallyworld | StevenK: no, not pointless. the contents are different | 01:38 |
| wallyworld | the 3.30 version is hand packed to contain just the yui build files | 01:38 |
| wallyworld | the 3.3 version i mean | 01:38 |
| wgrant | ಠ_ಠ | 01:38 |
| wgrant | ಠ_ಠ | 01:38 |
| wgrant | ಠ_ಠ | 01:38 |
| wgrant | ಠ_ಠ | 01:38 |
| wallyworld | the 3.3.0 version is a direct download off github and the untar cmd is modified | 01:38 |
| wgrant | ಠ_ಠ | 01:39 |
| StevenK | wallyworld: Which is why bin/combo-rootdir is broken | 01:39 |
| wallyworld | ah, that makes sense | 01:39 |
| StevenK | So you changed all this stuff out from under me, complains when it breaks, and you didn't tell me any of this? | 01:40 |
| wallyworld | StevenK: so we wanted to eliminate the need for a manual packaging step. better to just download straight of github | 01:40 |
| wallyworld | StevenK: no, it would have worked if your download cache was up to date | 01:40 |
| wallyworld | i think? | 01:40 |
| wallyworld | or maybe not | 01:40 |
| StevenK | The make would have worked. | 01:40 |
| wallyworld | this was done last thing friday and we ran out of time for a proper wrap up :-( | 01:40 |
| StevenK | But then my convoy rootdir would be wrong, like what you see. | 01:40 |
| wallyworld | if we had not lost 5 hours on thursday..... | 01:41 |
| StevenK | wallyworld: What annoys me is that you didn't tell me anything | 01:41 |
| wallyworld | all this is a symptom of rushing to get stuff done right at the end :-( | 01:41 |
| StevenK | Right, I finally have a test case | 01:41 |
| wallyworld | StevenK: it wasn't deliberate | 01:41 |
| StevenK | We really don't handle tags with a + in them | 01:42 |
| wallyworld | we really needed to have another few hours on the day | 01:42 |
| StevenK | wallyworld: Anyway, I'm looking | 01:42 |
| wallyworld | StevenK: i don't mind hacking on it | 01:43 |
| wallyworld | i can get it work with the buildout stuff | 01:43 |
| StevenK | steven@liquified:~/launchpad/lp-branches/devel% bin/ec2 ls | tail -n 1 | 01:43 |
| StevenK | Summary: running: 5 | 01:43 |
| wallyworld | if you want | 01:43 |
| StevenK | wallyworld: Just waiting for my download-cache, and I'll push | 01:43 |
| wallyworld | ok | 01:43 |
| wallyworld | sorry about the confusion | 01:44 |
| StevenK | wgrant: So my test fails, we do just spit out unencoded tag names and slap it into a generated URL in TAL. | 01:50 |
| wgrant | StevenK: Of course :) | 01:51 |
| StevenK | wgrant: ${tag} => ${tag/fmt:url} ? | 01:52 |
| wgrant | It's not an fmt:url. | 01:52 |
| StevenK | wgrant: Or am I better off doing this in the view? | 01:53 |
| wgrant | lifeless: It's all in the config now. | 01:53 |
| wgrant | StevenK: Probably the view. | 01:53 |
| StevenK | wgrant: cgi.escape, or will that make you kill me? | 01:54 |
| wgrant | It won't even do what you want :) | 01:56 |
| StevenK | wgrant: urllib.urlencode? Or is that wrong too? | 01:57 |
| wgrant | That sounds more likely. | 01:58 |
| wgrant | Or urllib.quote if you just want to use it to generate the value, not the full k-v list | 01:58 |
| lifeless | wgrant: great | 02:08 |
| * wgrant stabs postgres in the eye. | 02:16 | |
| nigelb | Morn[B24 | 02:17 |
| nigelb | err | 02:17 |
| nigelb | Morning! | 02:17 |
| nigelb | Clearly, I need coffee. | 02:17 |
| StevenK | wallyworld: use-convoy fixed | 02:19 |
| wallyworld | StevenK: i'm just about to push a change to fix it also | 02:19 |
| wallyworld | using the new buildout stuff | 02:19 |
| wallyworld | StevenK: how about i push my change and you have a look | 02:19 |
| wallyworld | StevenK: there's a few issues in the console logs i was looking at | 02:20 |
| wallyworld | the sorttable js is not being loaded | 02:20 |
| wallyworld | nor are some of the lazr-js assets | 02:20 |
| wallyworld | StevenK: lp:~wallyworld/launchpad/use-convoy https://pastebin.canonical.com/58281/ | 02:23 |
| StevenK | wallyworld: You can't use ln | 02:28 |
| wallyworld | ? | 02:28 |
| wallyworld | works for me | 02:28 |
| StevenK | Oh, I see what you've done | 02:28 |
| StevenK | I shall ponder that | 02:29 |
| wallyworld | it's sort of an interim step, till we support specifying the yui version | 02:29 |
| wallyworld | not sure why the sorttable stuff isn't getting found | 02:29 |
| wallyworld | that's under lp | 02:30 |
| wallyworld | and i think we're missing copying some of the lazr-js stuff across | 02:30 |
| wallyworld | StevenK: also, merge in trunk so you get the last of the mochi fixes from yerterday | 02:32 |
| wallyworld | there will be a few LPS usages to change | 02:32 |
| wallyworld | StevenK: ah, sorttable.js doesn't have a requires | 02:34 |
| wallyworld | do you want to add an empty one? | 02:34 |
| wallyworld | in your branch? | 02:34 |
| wgrant | StevenK: Could you find some time to review https://code.launchpad.net/~wgrant/launchpad/hardcoded-password/+merge/88966 and https://code.launchpad.net/~wgrant/launchpad/no-passwords/+merge/88971 this afternoon? | 02:50 |
| mwhudson | is sorttable stuff broken on production currently? | 02:54 |
| mwhudson | because it certainly isn't working for me | 02:54 |
| wgrant | It's not meant to be, but it quite possibly is. | 02:54 |
| mwhudson | e.g. try to sort by assignee on https://launchpad.net/lava/+milestone/2011.12 | 02:54 |
| wgrant | Hm | 02:55 |
| wgrant | WFM | 02:55 |
| wgrant | In Firefox | 02:55 |
| mwhudson | hm | 02:55 |
| wgrant | More attractive than the old version, too. | 02:55 |
| * wgrant fires up Chromium. | 02:55 | |
| mwhudson | messed up in both chrome and ff for me | 02:55 |
| mwhudson | well chromium | 02:55 |
| StevenK | wgrant: Does lifeless still have objections? | 02:55 |
| wgrant | StevenK: Doesn't seem to. | 02:55 |
| wgrant | mwhudson: Oh | 02:56 |
| wgrant | mwhudson: It's all off by one column. | 02:56 |
| mwhudson | hah yes | 02:56 |
| wgrant | wallyworld, StevenK: ^^ sorttable regression | 02:56 |
| mwhudson | well | 02:56 |
| mwhudson | it's off by one for the blueprint listing | 02:56 |
| mwhudson | not sure about the bug listing, that seems a bit more random | 02:57 |
| wgrant | Hm, indeex. | 02:57 |
| wgrant | Importance sorts by summary, status by project. | 02:57 |
| wgrant | s/indeex/indeed/ | 02:57 |
| StevenK | wgrant: Do we need to revert prod again? | 02:57 |
| wgrant | Not if we fix this now. | 02:58 |
| mwhudson | there was a change to de-mochi sorttable or something recently? | 02:58 |
| wgrant | Yes | 02:58 |
| mwhudson | [r=deryck][no-qa] Make sorttable a proper YUI module. Also updates to | 02:59 |
| mwhudson | latest version, which fixes sorttable on our site for Chrome users. | 02:59 |
| mwhudson | 14671 | 02:59 |
| wgrant | Yes, the origin of the breakage was reasonably obvious :) | 02:59 |
| wgrant | It's just not clear why it's broken. | 02:59 |
| wgrant | Or how wide it is. | 02:59 |
| StevenK | Hmmm | 03:02 |
| StevenK | Why can't I save MP comments? | 03:02 |
| wgrant | Oh no not again. | 03:03 |
| StevenK | Oh, there we go. Just took *ages* | 03:03 |
| wgrant | It does that sometimes :/ | 03:03 |
| wgrant | I think it's unrelated. | 03:03 |
| StevenK | wgrant: r=me * 2, but you may want to wait until we sort this crap out | 03:03 |
| mwhudson | chrome's developer tools doesn't like launchpad.js very much | 03:04 |
| StevenK | I wonder why that is. :-P | 03:05 |
| StevenK | Who would have thought a 3.3MiB JS file was a good idea. | 03:05 |
| StevenK | wgrant: I fear my lack of JS knowledge won't help debugging sorttable | 03:06 |
| wgrant | It's unlikely to be a very javascripty sort of thing. | 03:06 |
| wallyworld | a brand new version of upstream sorttable was used | 03:07 |
| wallyworld | since the previous one was broken in chrome | 03:07 |
| StevenK | s/\(JS\)\(.*\)\(sortable\)/\3\2/ | 03:07 |
| wgrant | The new one doesn't seem to handle colspan at all. | 03:10 |
| mwhudson | aaah | 03:10 |
| mwhudson | that would explain some things | 03:11 |
| wallyworld | looks like it works on the new bugs listings | 03:12 |
| wallyworld | but those pages perhaps use their own sorting | 03:12 |
| wgrant | They don't use sorttable. | 03:12 |
| mwhudson | my money is on wgrant's observation | 03:12 |
| wallyworld | explains that then | 03:12 |
| wgrant | o_O | 03:12 |
| mwhudson | - colspan = td.getAttribute("colspan"); | 03:12 |
| mwhudson | - if (colspan) { | 03:12 |
| mwhudson | - SORT_COLUMN_INDEX += parseInt(colspan) - 1; | 03:12 |
| mwhudson | - } | 03:12 |
| wgrant | The new one doesn't even respect sortkey | 03:12 |
| wgrant | It's useless. | 03:12 |
| mwhudson | with no corresponding +s | 03:12 |
| wgrant | (they were local patches, AFAIK) | 03:12 |
| mwhudson | ah | 03:13 |
| mwhudson | so um | 03:13 |
| wgrant | timestamp: Mon 2007-03-19 17:14:53 -0300 | 03:13 |
| wgrant | message: Fix for bug 62495: Milestone bug list doesn't sort properly. Make the Javascript sorting code cope with COLSPANs. Based on a patch by BjornT. Also adds a sortkey to ensure that the sorting by bug number works. | 03:13 |
| _mup_ | Bug #62495: Milestone bug list doesn't sort properly <lp-bugs> <Launchpad itself:Fix Released by kiko> < https://launchpad.net/bugs/62495 > | 03:13 |
| mwhudson | rewrite it in YUI? | 03:13 |
| wallyworld | wgrant: so you saying we did local patches to upstream? | 03:14 |
| wgrant | wallyworld: Yes | 03:14 |
| wgrant | This apparently wasn't checked before we upgraded. | 03:15 |
| mwhudson | http://www.kryogenix.org/bugs/sorttable/colspan-rowspan.html | 03:15 |
| wallyworld | we could port those to the current version | 03:15 |
| mwhudson | maybe we can just set fire to the west midlands! | 03:15 |
| wgrant | That may be the best plan for now. | 03:15 |
| wallyworld | mwhudson: we ultimately want to go all yui, but were not planning on a rewrite just now | 03:15 |
| mwhudson | it's only 450 lines, and would be ~200 with yui? but sure | 03:16 |
| mwhudson | i'm certainly not going to fix it :) | 03:16 |
| wallyworld | mwhudson: it's just that we have no bandwidth atm | 03:17 |
| mwhudson | sure | 03:17 |
| wallyworld | we are supposed to be working on disclosure - the sorttable stuff came up with the move to a combo loader, a project meant to be completed at last week's Epic | 03:17 |
| StevenK | wallyworld: sinzui said we should work on stuff from last week so it actually gets finished. | 03:20 |
| wallyworld | StevenK: sure, but not a rewrite in yui, that's all i meant | 03:20 |
| wallyworld | i just was saying we could do the minimum - port the previous fixes | 03:20 |
| wgrant | Dammit Ubuntu, why do you have so many bugs :( | 03:22 |
| * wallyworld has got the sorttable diff from r 3970 and will port across | 03:24 | |
| wgrant | wallyworld: There are two | 03:25 |
| wgrant | At least | 03:25 |
| wgrant | sortkey and colspan | 03:25 |
| wgrant | Diff from the original version. | 03:25 |
| wallyworld | sure | 03:25 |
| wgrant | Hmm | 03:25 |
| wgrant | The diff is 316 lines :) | 03:26 |
| lifeless | StevenK: objections t ? | 04:28 |
| lifeless | *to* | 04:28 |
| lifeless | -> dinner for familty | 05:31 |
| wallyworld | wgrant: quick look at this? https://code.launchpad.net/~wallyworld/launchpad/sorttable-fix/+merge/88982 | 05:42 |
| wallyworld | bah, just saw a mistake, fixing | 05:43 |
| wallyworld | fixed | 05:55 |
| wgrant | wallyworld: It works for sorting by dates, and on milestone pages (which have complex columns)? | 06:03 |
| wallyworld | wgrant: the branch listing has date columns and the first header has colspan = 2. but i could see any milestone pages with data on lp.dev | 06:04 |
| wallyworld | couldn't | 06:05 |
| wgrant | wallyworld: Firefox apparently has some. | 06:05 |
| wallyworld | so i thought | 06:05 |
| wallyworld | i'll see if i can some something | 06:06 |
| wgrant | ha ha hahahhahhah | 06:11 |
| wgrant | Been debugging a test for ages. | 06:12 |
| wgrant | Query count ends up larger with hardcoded-passwords | 06:12 |
| wgrant | Turns out it was authenticating with 'test' as the password before, but that was in fact incorrect. | 06:12 |
| wgrant | So it was inadvertantly making an anonymous request. | 06:12 |
| wallyworld | wgrant: i creaed some sample data and it appears ok sorting blueprints and bugs tables on a milestone page | 06:34 |
| wgrant | wallyworld: With all columns? Great. | 06:36 |
| wallyworld | yep | 06:36 |
| wallyworld | wgrant: if you +1 it could you please lp-land since lp-land is broken on my precise atm | 06:37 |
| wgrant | wallyworld: Will land. | 06:42 |
| wgrant | Seems like it would be about 80% smaller in YUI, though. | 06:43 |
| StevenK | lifeless: Bah. We're the Purple squad | 06:44 |
| wallyworld | wgrant: yes, yui would be better. but no time. thanks for landing | 06:44 |
| wgrant | Actually just going to test it a bit more first. | 06:44 |
| wallyworld | StevenK: i already sent a correction :-) | 06:44 |
| wgrant | But it looks good. | 06:44 |
| wallyworld | yeah, there was a corner case of two due to the new codebase | 06:45 |
| wgrant | Hm | 06:46 |
| StevenK | wallyworld: So lp-land is broken. Why is ec2 land broken? | 06:46 |
| wgrant | No point ec2 landing that | 06:46 |
| wallyworld | StevenK: same issue | 06:46 |
| wallyworld | missing method | 06:46 |
| StevenK | Strange | 06:47 |
| StevenK | wallyworld: Just read your MP for your fix to the ITeam:+edit bug I reported -- the screenshot looks awesome | 06:50 |
| wallyworld | StevenK: thanks. | 06:50 |
| wgrant | wallyworld: I don't think sortkey is working properly. | 06:50 |
| wgrant | eg. modify a few branches on https://code.launchpad.dev/firefox 30s apart | 06:51 |
| wgrant | (just change the description) | 06:51 |
| wgrant | You'll see that "a moment ago" sorts between "33 seconds ago" and "2007-12-06" | 06:51 |
| wallyworld | it will use the sortjey if one is provided | 06:51 |
| wallyworld | sortkey | 06:51 |
| wgrant | <td> | 06:52 |
| wgrant | <span class="sortkey">2012-01-18 08:50:13 SAST</span> | 06:52 |
| wgrant | <span title="2012-01-18 08:50:13 SAST">a moment ago</span> | 06:52 |
| wgrant | </td> | 06:52 |
| wallyworld | hmmm. not sure why it's misinterpeting it then | 06:52 |
| wallyworld | will have to look | 06:52 |
| wallyworld | i tested the sortkey stuff with enum columns eg bug status | 06:53 |
| wallyworld | bah, the whole code structure around guessing column types is different | 06:57 |
| wallyworld | more work needed | 06:57 |
| wgrant | How much more? | 06:58 |
| wgrant | It may be worth landing this anyway. | 06:59 |
| wallyworld | just had a more thorough look. i think it just may be a change to the re used to guess that a column is a date | 07:00 |
| wallyworld | it doesn't like datettimes | 07:01 |
| wallyworld | i think worth landing now, with another landing to fix the dates | 07:01 |
| wgrant | submitted | 07:04 |
| wallyworld | thanks! | 07:04 |
| wallyworld | mwhudson: fix for sorttable is merged into trunk. date columns still need a little work but other than that it's ok i think | 07:16 |
| wallyworld | hopefully will be out of buildbot etc by tomorrow | 07:16 |
| * wgrant is confused about bug #918037 | 07:17 | |
| _mup_ | Bug #918037: launchpad: please enable some shorter URLs for bugs <Launchpad itself:New> < https://launchpad.net/bugs/918037 > | 07:17 |
| lifeless | StevenK: bah, sorry. | 08:37 |
| StevenK | stub: Sorry, channel fail | 08:51 |
| StevenK | stub: If you have a look at the branch linked to bug 909240, you can see that I've rewritten the query that the method uses. | 08:52 |
| _mup_ | Bug #909240: Can't display New queue due to timeouts <qa-ok> <queue-page> <soyuz-core> <timeout> <Launchpad itself:Fix Committed by stevenk> < https://launchpad.net/bugs/909240 > | 08:52 |
| stub | Yay. Loaded a LP page and firefox crashes | 08:53 |
| StevenK | stub: wgrant and I did some investigation and we both think the a new index on BPPH will speed up the query a lot. I have a WIP MP at https://code.launchpad.net/~stevenk/launchpad/db-add-bpph-index/+merge/88824 | 08:53 |
| stub | StevenK: ok. That looks fine. Got an example query handy for me to test? | 08:56 |
| stub | Or have you already done tests on staging and know the new index wins out over the existing index just on binarypackagename? | 09:00 |
| wgrant | stub: I tried on dogfood, and it cut it down to 30ms. | 09:01 |
| wgrant | I don't remember exactly what it was without the index, but it was more than 10x that. | 09:01 |
| * wgrant digs up the query. | 09:01 | |
| stub | Ok. Sounds like we just want to land it and apply live then. | 09:01 |
| stub | MP is WIP though... what still needs to happen? | 09:02 |
| wgrant | http://pastebin.ubuntu.com/807147/ | 09:02 |
| cjwatson | StevenK: I'm failing to comprehend that failure mail about archive-copy-packages-source-series | 09:24 |
| cjwatson | Tests hung, but doesn't seem to be related to my change? | 09:24 |
| StevenK | cjwatson: Let me have a dig. | 09:29 |
| * StevenK nails bigjools to IRC. | 09:29 | |
| StevenK | Stay! | 09:29 |
| bigjools | precise hates me | 09:30 |
| bigjools | usb kernel module crashes which takes out the mouse and keyboard | 09:30 |
| nigelb | StevenK: lol | 09:30 |
| StevenK | cjwatson: Hm, that is strange. | 09:31 |
| === StevenK changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugtasks: 3*10^2 | ||
| StevenK | cjwatson: Nothing is jumping out to my flu-alded brain, sorry. | 09:32 |
| StevenK | stub: MP is WIP because I wanted to talk to you, if you came up with a better index or so | 09:33 |
| StevenK | bigjools: It seems my nail helped. Did I catch any important bits? :-P | 09:34 |
| cjwatson | StevenK: is it worth throwing it against the wall again, or is this unlikely to be transient? | 09:49 |
| wgrant | Where was the hang? | 09:50 |
| cjwatson | successful: lp.testing.tests.test_zope_test_in_subprocess.TestZopeTestInSubProcessLayer:tearDown | 09:51 |
| cjwatson | WARNING: A test appears to be hung. There has been no output for 600 seconds. | 09:51 |
| cjwatson | last real test was lp.translations.utilities.tests.test_superfastimports.TestSuperFastImports.test_query_timeout | 09:52 |
| cjwatson | (which succeeded) | 09:52 |
| StevenK | stub: I shall fiddle with the MP and toss it at db-devel | 09:52 |
| wgrant | Hmm | 09:53 |
| wgrant | I haven't seen that one in a long time. | 09:53 |
| wgrant | Probably over a year. | 09:53 |
| wgrant | Throw it at ec2 again, I say. | 09:53 |
| cjwatson | http://people.canonical.com/~cjwatson/tmp/archive-copy-packages-source-series-r14656.subunit.gz | 09:53 |
| StevenK | cjwatson: Link me the MP again and I'll re-toss it along with my db patch | 09:54 |
| cjwatson | StevenK: https://code.launchpad.net/~cjwatson/launchpad/archive-copy-packages-source-series/+merge/87942 - ta | 09:54 |
| StevenK | Which just got hit with FDT | 09:56 |
| adeuring | good morning | 09:57 |
| Laney | since the dev wiki seems to be joining the blackout, what do I need to do to QA my db change branch which has landed on qastaging? | 09:59 |
| wgrant | Laney: Hm, works for me. | 10:02 |
| Laney | yeah, back now | 10:03 |
| Laney | was down for at least 30 minutes :-) | 10:03 |
| wgrant | But DB change branches don't land on qastaging, but staging itself. For this sort of thing we mostly just check that it applies. | 10:03 |
| wgrant | I'll check once fdt is over. | 10:03 |
| Laney | oh, http://lpqateam.canonical.com/qa-reports/deployment-db-stable.html says qastaging | 10:03 |
| wgrant | It's a lie :( | 10:04 |
| Laney | boo | 10:04 |
| wgrant | 2012-01-18 05:44:34 INFO 2209-02-0 applied just now in 5.5 seconds | 10:06 |
| wgrant | qa-ok | 10:06 |
| wgrant | A little on the slow side, but it'll do. | 10:07 |
| Laney | tidy | 10:07 |
| === matsubara-afk is now known as matsubara | ||
| wgrant | Laney: The dev wiki issue was a firewall misconfiguration that lasted about 15 minutes, I believe. | 11:32 |
| wgrant | Laney: I've scheduled that patch for deployment tomorrow | 11:32 |
| Laney | wgrant: Oh OK, thanks. How will I know when it's done? The bug will be flipped to Fix Released? | 11:32 |
| wgrant | I'll comment and flip the bug back to In Progress. | 11:33 |
| wgrant | Since it requires further landings. | 11:33 |
| Laney | bonus, thanks a lot. | 11:34 |
| Laney | Maybe I'll look into UI for creator and sponsor next ... | 11:34 |
| Laney | but that would probably require figuring out how to get test data into my local instance. | 11:35 |
| wgrant | Filling in sponsor is probably more important than displaying it. | 11:35 |
| wgrant | Since there's not much to display at present :) | 11:35 |
| StevenK | Ursinha: Your patch is now live on production, so if you need help with the code, or anything, give me a prod. | 11:35 |
| Laney | it would be nice to have it on +source | 11:35 |
| wgrant | Laney: Indeed. | 11:35 |
| Ursinha | \o/ | 12:27 |
| Ursinha | thanks StevenK | 12:27 |
| rick_h | morning all | 12:27 |
| wgrant | Morning rick_h. | 12:31 |
| cjwatson | allenap: would it be worth doing a lazr.uri release? It, er, doesn't seem to get changed very often ;-) | 12:56 |
| allenap | cjwatson: Yes, a very good idea. I am waiting for flacoste to appear so he can authorize me on PyPI. | 13:55 |
| deryck | Morning, all. | 14:03 |
| rick_h | party on | 14:03 |
| flacoste | allenap: what package? | 14:04 |
| flacoste | lazr.uri | 14:04 |
| flacoste | on it | 14:04 |
| flacoste | allenap: what's your pypi username? | 14:06 |
| allenap | flacoste: gavinpanella | 14:06 |
| allenap | Thanks! | 14:06 |
| flacoste | allenap: done | 14:07 |
| allenap | flacoste: Right, now to try and remember the runes, thanks. | 14:07 |
| deryck | wallyworld, you around still? | 14:16 |
| deryck | rick_h, wallyworld says in email we need "apache wsgi lib" in dependencies.... he means mod_wsgi? Or something else? | 14:17 |
| rick_h | deryck: right, libapache2-mod-wsgi | 14:18 |
| deryck | rick_h, right, ok, cool. | 14:18 |
| rick_h | it's not currently a dep since LP doesn't use it yet in the default setup | 14:18 |
| deryck | rick_h, I'm about to paste you my notes for remaining work, and if it looks good, we can coordinate on launchpad-dev list. | 14:18 |
| rick_h | deryck: ok, sounds good. I'm working on getting their changes from last night up and running | 14:18 |
| rick_h | deryck: they hit issues getting your branch and ours to combine/work | 14:19 |
| deryck | rick_h, my branch being the multi-yui buildout stuff? | 14:19 |
| rick_h | deryck: right | 14:19 |
| rick_h | deryck: honestly StevenK and I weren't sure what you guys were up to and we never got to merge them before we left | 14:20 |
| rick_h | deryck looks like they got it sorted out last night though, so merging with devel, StevenK, and wallyworld right now to build a super branch with everything together | 14:20 |
| deryck | rick_h, right, that's what I was going to say.... I read wallyworld's email as saying it was sorted out now. | 14:21 |
| rick_h | deryck: yea, just need to see it to believe it at this point lol | 14:21 |
| deryck | rick_h, ok, so here's my notes: http://pastebin.ubuntu.com/808615/ | 14:23 |
| deryck | rick_h, we can discuss on list, but generally, does it look like I've got everything there. anything glaringly missing? | 14:24 |
| rick_h | deryck: looking, sec | 14:24 |
| allenap | cjwatson, flacoste: lazr.uri 1.0.3 is out. | 14:24 |
| cjwatson | allenap: cool. shall I file a Debian bug or have you already done so? | 14:27 |
| rick_h | bah, is there really no way in the pastebin to reply/change a paste without manually copying/pasting? | 14:27 |
| deryck | nope | 14:27 |
| allenap | cjwatson: I didn't realise I had opened a can of worms ;) I haven't filed a bug and I don't really know the form for doing so; I'd be grateful if you could do it. | 14:28 |
| cjwatson | allenap: it's not a can of worms, just the next step - OK, I'll take care of it | 14:28 |
| cjwatson | done | 14:29 |
| allenap | cjwatson: I was joking, but I started this thinking "I know, I'll do a quick review". I'm happy that it's progressing. | 14:29 |
| rick_h | deryck: http://pastebin.ubuntu.com/808625/ | 14:31 |
| deryck | abentley, adeuring -- http://pastebin.ubuntu.com/808615/ | 14:32 |
| bigjools | jelmer: how does dailydeb find upstream tarballs? | 14:39 |
| jelmer | bigjools: by tags in the branch | 14:40 |
| jelmer | bigjools: generally speaking, recipe builds should be native | 14:40 |
| bigjools | jelmer: ah ok, I won't worry then, thanks | 14:41 |
| cjwatson | allenap: hey, *I* started thinking "I know, I wonder what I can do to help port launchpadlib to Python 3" ... | 14:42 |
| cjwatson | still a fair bit left in that stack | 14:42 |
| allenap | Haha :) | 14:42 |
| * bigjools chortles | 14:42 | |
| === abentley changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: abentley | Firefighting: - | Critical bugtasks: 3*10^2 | ||
| jcsackett | sinzui: have a few moments to chat? | 15:05 |
| sinzui | yes | 15:05 |
| abentley | rick_h: Why do you say to test in google chrome, when the bug is Firefox? Google Chrome is not available on Ubuntu AFAIK. | 15:06 |
| rick_h | abentley: sorry, just force of habit. I ran the updated tests in both browsers and copied the last command I ran | 15:07 |
| rick_h | abentley: updated | 15:07 |
| rick_h | deryck: is there anything we can do to help https://answers.launchpad.net/launchpad/+question/184522 by manually touching the data? | 15:11 |
| * deryck looks | 15:11 | |
| rick_h | deryck: he's in #launchpad asking and the book is still in progress, but not finding any way to help him right now | 15:12 |
| deryck | rick_h, I think we need to refer him to ubuntu-sso. sinzui, can you confirm that? (from ^^ question) | 15:12 |
| rick_h | /book/bug/ | 15:12 |
| abentley | rick_h: r=me | 15:12 |
| rick_h | abentley: ty much | 15:12 |
| deryck | rick_h, I'll take over on IRC and handle it. | 15:15 |
| rick_h | deryck: ok, thanks | 15:15 |
| stub | deryck: I'm the person who has to fix the data in these cases. We had one of these at the Epic and wgrant tracked down and filed bugs on why these problems keep happening. | 15:20 |
| deryck | stub, ah, ok. Can I assign you the question then? | 15:21 |
| stub | deryck: Sure | 15:21 |
| deryck | stub, awesome! Thanks! | 15:21 |
| stub | Just email me if you do that in the future as I seem to never see emails from Questions for some reason I haven't been bothered to investigate. | 15:22 |
| deryck | stub, will do. | 15:22 |
| rick_h | deryck: fyi, I've done all the merging/conflict resolution and pushed to my use-convoy branch in case you want to shortcut all that | 15:25 |
| deryck | rick_h, ok, will do, thanks. | 15:30 |
| deryck | rick_h, and your branch is different from StevenK's branch now? | 15:30 |
| rick_h | deryck: yea, it's merged with devel and the js branch from wallyworld, etc | 15:31 |
| deryck | rick_h, oh, ok. I thought StevenK had already done that in his branch. | 15:31 |
| deryck | rick_h, np, though. we just need to let him know. Almost done with my coordination email. | 15:31 |
| === salgado is now known as salgado-brb | ||
| bac | hi sinzui, you doing lp development on precise? | 15:53 |
| sinzui | bac, in a manner of speaking. I am about to put a branch up for review that permits me to run lp and the the test suite. | 15:54 |
| bac | sinzui: what did you do about python-tickcount, which precise only packages for 2.7 | 15:54 |
| bac | sinzui: i'll be happy to review your branch | 15:55 |
| sinzui | bac, this is my hack http://pastebin.ubuntu.com/808705/ | 15:58 |
| gary_poster | sinzui, wow, so LP works with 2.7 with your branch? | 15:59 |
| sinzui | gary_poster, walks, not runs | 16:00 |
| gary_poster | :-) | 16:00 |
| gary_poster | very cool | 16:00 |
| sinzui | gary_poster, bac: some tests do fail | 16:00 |
| gary_poster | good start then | 16:01 |
| === salgado-brb is now known as salgado | ||
| bac | sinzui: your makefile patch does not work for 2.7. it returns 'pythonpython2.6' | 16:16 |
| sinzui | bac: damn. I gave you the non-commited change to support lucid. | 16:17 |
| bac | sinzui: oopsie | 16:17 |
| sinzui | it does not work | 16:17 |
| sinzui | bac: this one includes the anchors to only match the full string | 16:19 |
| bac | sinzui: cool. so you have a diff? | 16:23 |
| sinzui | http://pastebin.ubuntu.com/808739/ | 16:23 |
| sinzui | ^ That is my entire change to make my branch and run tests | 16:24 |
| sinzui | bac: if my hack works for you, maybe you can approve this so that I can send it to ec2 https://code.launchpad.net/~sinzui/launchpad/precise-makefile-python/+merge/89074 | 16:36 |
| allenap | lifeless: Any chance of a testresources release? I'd like FixtureResource and use of super(). | 16:51 |
| bigjools | allenap: you expect lifeless to be awake at 6am in NZ? Oh, wait ... | 16:56 |
| allenap | bigjools: Precisely. | 16:56 |
| bigjools | Pangolin | 16:56 |
| === deryck is now known as deryck[lunch] | ||
| bac | sinzui: done, with one question | 18:05 |
| === deryck[lunch] is now known as deryck | ||
| lifeless | allenap: yes, sure | 19:17 |
| rick_h | so let's just say someone accidentilly blew away their lp-branches directory... | 19:30 |
| rick_h | and they recreated it using a normal bzr branch as they find in the rocketfuel-setup script | 19:30 |
| rick_h | but now making branches takes forever and a day | 19:30 |
| rick_h | what would someone look at? to get things back where a branch wasn't such a big deal? | 19:31 |
| lifeless | you need a shared repository | 19:32 |
| lifeless | lp-branches should be 'bzr init-repository [--no-trees] lp-branches' | 19:33 |
| rick_h | ah, up a level. Ok, was searching branch options | 19:33 |
| lifeless | then bzr branch lp:launchpad lp-branches/devel | 19:36 |
| lifeless | and you're back to the starting point | 19:36 |
| rick_h | rgr, running that now. Thanks lifeless | 19:37 |
| lifeless | the --no-trees thing is largely personal preference - whether you want to run multiple wokring trees, or one that you switch between | 19:37 |
| lifeless | the rf default is with trees | 19:37 |
| rick_h | yea, I still need to spend some time on my bzr setup to find a happy place | 19:38 |
| === mwhudson_ is now known as mwhudson | ||
| abentley | rick_h: If you're starting again, I recommend using bzr-colo instead. Been using it for weeks. | 20:23 |
| abentley | rick_h: It implements the git-style layout where you have one working tree and many branches. | 20:24 |
| allenap | lifeless: Thanks. | 20:25 |
| abentley | rick_h: Also, it can fluidly switch to using pipelines. | 20:28 |
| lifeless | deryck: hey | 20:30 |
| deryck | hi lifeless | 20:31 |
| lifeless | deryck: a thought on pages that were timing out and don't when we reevaluate; might like to still check for warning signs | 20:33 |
| lifeless | deryck: like high query counts (> 30), slow page (multi second rendering) | 20:33 |
| lifeless | deryck: when I'm not ill, I would also like to catch up w.r.t. root-cause-fix-opportunities, but probably next week is best | 20:34 |
| deryck | lifeless, ok, sure. I did a basic assessment like that. but re: the 30 count page, we have many that are more than that, right? in fact most, no? | 20:35 |
| lifeless | deryck: I wouldn't say most | 20:35 |
| lifeless | deryck: many pages have a fixed amount of content and a high query count; they generally don't get better or worse; things with batches on them are where it gets bad rapidly | 20:36 |
| deryck | ok, I'm just going by the query count at the top of the page. I don't find a page with 30 queries or less. | 20:36 |
| lifeless | deryck: aiee :P So, pick a number, 70 then :) | 20:37 |
| deryck | lifeless, also, I'd love to catch up about the root-cause opportunities stuff as you say. | 20:37 |
| lifeless | deryck: the main thing is the number should be less than the rows in a batch | 20:37 |
| deryck | lifeless, ah, I follow now. gotchas. | 20:37 |
| rick_h | abentley: thanks, I'll check out the colo stuff. | 20:50 |
| abentley | rick_h: Cool. Let me know if you have any questions. | 20:51 |
| jcsackett | sinzui: do you know why we have both test_team and test_team_view in browser/tests? they seem to be a random selection of browser tests in each. | 21:03 |
| sinzui | jcsackett, both tests were created in separate places, then apocalypse happened | 21:06 |
| sinzui | jcsackett, They can be merged, and maybe checked for duplication | 21:06 |
| jcsackett | sinzui: hurray! | 21:06 |
| * jcsackett goes to collapse files. | 21:06 | |
| * sinzui did the same for personset a few weeks ago | 21:06 | |
| === abentley changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugtasks: 3*10^2 | ||
| huwshimi | Hello Precise users, how do I resolve the import errors when doing rocketfuel-get? | 23:14 |
| huwshimi | (I'm assuming these are standard issues) | 23:14 |
| wgrant | huwshimi: sinzui was working on that. | 23:16 |
| wgrant | huwshimi: But try hacking Makefile to use python2.7 instead of python2.6 | 23:17 |
| wgrant | Then make clean && make | 23:17 |
| wgrant | lifeless: Around? | 23:18 |
| huwshimi | wgrant: OK thanks. It's definitely a version thing because the packages exist | 23:18 |
| wgrant | huwshimi: Yeah, Precise doesn't really do python2.6 | 23:18 |
| huwshimi | wgrant: Ah I see | 23:19 |
| wgrant | wallyworld_: Worked out the sorttable date sorttkey stuff? | 23:29 |
| wallyworld_ | nope. on my agenda after breakfast | 23:30 |
| wgrant | Great. | 23:30 |
| wgrant | That's a good idea, actually. | 23:30 |
| wallyworld_ | yeah, can't work when hungry | 23:31 |
| wallyworld_ | at least sorting is mostly fixed after next NDT | 23:31 |
| wgrant | Yeah | 23:31 |
| wgrant | Should be done soon. | 23:31 |
| wgrant | lifeless: Am I likely to be slain if I combine three marginally related DB patches into one for deployment efficiency? | 23:33 |
| wgrant | (-AccountPassword, -EmailAddress.account, +Person.account_status) | 23:33 |
| huwshimi | wgrant: The make clean and make worked fine but rocketfuel-get is still failing. Is there another way I can update that might work or something? | 23:49 |
| wgrant | huwshimi: How's it failing? | 23:50 |
| huwshimi | wgrant: Sometimes it fails with "ImportError: No module named bzrlib" | 23:51 |
| wgrant | huwshimi: Hm | 23:51 |
| huwshimi | wgrant: and others it fails with ImportError: No module named tickcount or something like that | 23:51 |
| wgrant | Sounds like it's still running with python2.6 | 23:51 |
| huwshimi | wgrant: I modified the Makefile in devel | 23:51 |
| huwshimi | wgrant: And did the make clean/make there | 23:52 |
| huwshimi | wgrant: Is that what I was supposed to do? | 23:52 |
| wgrant | So, rocketfuel-get basically just: bzr pull -d ~/launchpad/lp-branches/devel; bzr up ~/launchpad/lp-sourcedeps/download-cache | 23:52 |
| wgrant | And then make | 23:53 |
| wallyworld_ | StevenK: we should land your use-convoy branch today. with your latest change, we should use ${buildout:yui-directory} instead of hardcoding to build/js/yui | 23:56 |
| huwshimi | wgrant: Well that all appeared to work | 23:57 |
| huwshimi | wgrant: So now how do I do the equivalent hackery instead of doing rocketfuel-branch? | 23:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!