[00:48] mhall119: can you approve it and we will deal with the look later? [00:48] id like to get it packaged and released [00:48] or can i approve it [01:14] cjohnston: which, the twitter branch? [01:14] ya [01:14] I just merged it [01:14] do you want to throw it up on an ec2 to test before the release? [01:14] bah, another failing test [01:16] from danilos' branch? [01:17] let me get a clean trunk [01:18] nope, still not passing [01:18] yeah, test_calculate_passes_with_multiple_plenary_rooms_if_editing [01:18] danilos: ^^ [01:19] cjohnston: are we deploying on lucid still? [01:19] afaik [01:21] mhall119: https://code.launchpad.net/~mhall119/summit/add-lunch can you mark abandoned please [01:30] mhall119: can you throw together a test fix please [01:32] cjohnston: let me look [02:35] cjohnston: danilos: nigelb: http://91.189.93.80:8000/uds-p/ [02:36] add a hash tag! [02:36] show all the goodness [02:38] mhall119: http://91.189.93.80:8000/uds-p/meeting/584/private-meeting/ not sure whats up with that [02:39] i guess we need if not meeting.private url, else no url [02:39] it wasn't private [02:39] if it was private, import_live_data wouldn't see it [02:40] so it was just called private meeting [02:40] yeah [02:40] see http://summit.ubuntu.com/uds-p/2011-11-01/ [02:41] pl [02:41] ok [02:53] cjohnston: easy fix to the test, nothing was wrong withthe code [02:54] I just pushed the fix to trunk [02:54] ok [02:54] you good then with packaging it up and shipping it out? [02:54] yup [02:54] ask danilos when would be a good day and time to put it live [02:54] then we'll see if IS can get it done then [02:54] he has a deadline of tomorrow night [02:55] works for me [03:01] mhall119: http://pad.ubuntu.com/yNPpIWZRAo [03:02] I think that's all we need [03:03] is that what's in our typical deployment requests? [03:03] I don't remember there being anything else.. I can't find an old email [03:03] I looked through the ltp one, and the only thing im missing is the i18n stuff [03:04] yeah [03:05] specify the exact version number of the production branch that should be deployed [03:06] that? [03:08] does rollback need the whole file or just the #? [03:08] also, add just the number, it'll revert any migrations higher than that number [03:08] s/also, add// [03:09] so like it is [03:09] that looks good now [03:10] i want to know how many lines of code this is [03:10] bzr diff -r 161..162 [03:11] i dont have enough scrollback [03:15] bzr diff -r 161 --diff-options="--normal" |wc -l [03:15] mhall119: we should probably try to fix bug #917674 as its a problem this uds [03:15] Launchpad bug 917674 in summit "Longer room names are blocked by the schedule (affects: 1) (heat: 6)" [Medium,Confirmed] https://launchpad.net/bugs/917674 [03:15] 4300 lines [03:15] this connect [03:15] whatever [03:15] thats it? [03:15] lol [03:17] we only have 12,413 lines of .py code [03:18] and 2006 lines of .html [03:20] so we edited almost 1/3 of the code [03:20] morning *yawn* [03:20] hey nigelb [03:21] yup [03:21] morning nigelb [03:21] ready to deploy summit? [03:21] ready to deploy your participant fix ;-) [03:21] cjohnston: be sure to cc danilos on the RT email when you send it [03:21] lolno. [03:22] I'm reading up on formsets [03:22] mhall119: i forgot, but i have access to add him once its triaged [03:44] ok [03:49] cjohnston: you good for tonight? [07:50] mhall119, cjohnston: the problem is likely with the test stability in test_calculate_passes_with_multiple_plenary_rooms_if_editing [07:51] nigelb, hi :) [08:17] nigelb, did you make any progress with the formsets? If not, I'll need to look into that as well to ensure we can get it done by today [08:23] danilos: hey, sorry, not yet. I'm tryign to see if I can spare some time at work today. [08:23] nigelb, right, do you have a branch I can start off or should I just start from trunk? [08:23] danilos: I don't have anything productive, no [08:24] nigelb, ack, thanks, I'll also keep you posted if I make any progress [08:26] ugh [08:27] who broke summit production [08:27] cjohnston: ^^^ [08:35] nigelb, probably a DB update not done, I'll check with IS [08:36] nigelb, btw, just adding 'participants' to the list of form fields is a minimal "add attendees" functionality as far as I can see, other than it being hard to use (Ctrl+clicking all around), any other reason why that was not considered? [08:37] ah, I see, saving doesn't really work [08:37] yep [08:37] :) [08:37] I fell into the exact same trap [10:58] nigelb: dont know.. can you look into it [10:59] cjohnston, nigelb, heya, do you know where can we take a look at errors from the OOPSes? [10:59] cjohnston, nigelb: I am getting changes reverted, hopefully nothing blows up in that process either [11:00] cjohnston, nigelb: https://bugs.launchpad.net/summit/+bug/921502 [11:00] Launchpad bug 921502 in summit "Problems with latest deployment (affects: 1) (heat: 6)" [Undecided,New] [11:00] http://paste.ubuntu.com/816311/ [11:00] danilos: ^ [11:01] cjohnston, sounds similar [11:02] danilos: there are ~100 errors that have been spent out [11:02] the few ive looked at are pretty much the same as that one [11:02] all that no reverse match [11:02] cjohnston, right, I wonder why is this not failing locally [11:03] cjohnston, it originally 500-ed with the same error which I had a fix for cowboyed in, but then it started failing with an OOPS page [11:06] danilos: i assume you arent having any problems locally? [11:06] cjohnston, not with trunk, no [11:07] try production [11:07] cjohnston, haven't compared production [11:07] just incase its there please [11:07] I have to get the kids ready for school and leave for work in 20 minutes [11:07] im going to help as much as i can till then, but I dont know how much thatll be [11:09] one of the rrors AttributeError: 'NoneType' object has no attribute 'strftime' [11:09] http://paste.ubuntu.com/816320/ [11:10] i just fired up production locally and it works [11:13] danilos: its something specific with the summit page too it looks like... [11:13] .http://summit.ubuntu.com/lcq1-12/2012-02-09/ [11:13] nigelb: ^ [11:15] cjohnston, right, I don't know what even references the missing decorator since I don't see it when grepping, and it might be specific to wsgi setup which dev setup is not using [11:15] cjohnston, and locally it works [11:16] danilos: did they touch the wsgi files after pushing your latest fix? [11:16] cjohnston, nope, not that I know of [11:16] danilos: maybe try that? [11:16] cjohnston, also, I only asked for it to be cowboyed in [11:16] thats fine.. [11:23] cjohnston, that didn't help [11:24] danilos: g2g.. I'll be back as soon as I can [11:24] cjohnston, do you see any of the last OOPSes, I'd like to make sure I am looking at something after the change? [11:25] AttributeError: 'NoneType' object has no attribute 'strftime' [11:26] I forwarded you emails of the only different errors i can find [11:34] cjohnston, thanks [11:37] danilos: I'm curious whats up with the datetime thing [11:37] cjohnston, it just means the value is none [11:37] why tho [11:41] danilos: email [11:43] cjohnston, what worries me most is the fact that "decorators" appears in all the exceptions (except the date one) [11:45] dunno [11:45] actually, this might explain it, there are probably different templates in use on production instance [11:46] shouldn't be [11:50] is summit.schedule.decorators.meetinng normal or is that what you were referring to [11:53] cjohnston, I don't know if it's normal, but it seems as if it should be referring to something else (i.e. summit.schedule.views.meeting) [11:53] agreed [11:57] cjohnston, hum, hum, I wonder if the old base.html is still there and is seen before the newly moved base.html in common/ [11:57] do you have access to the server [11:58] cjohnston, nope, I have to go through IS for this [11:58] gotcha [11:58] try pinging I guess [11:59] says no vanguard tho [12:00] they bzr pull, could that leave an old one [12:08] nope, I've checked that, it's all fine [12:08] so no old templates are around [12:08] and this is obviously not from the old templates, I wonder what else could try to pull "summit" and "meeting" from summit.schedule.decorators [12:08] mhall119, ^ (when you show up) [12:15] danilos: are the imports on common.views correct [12:16] id think we would have local errors if it wasn't [12:17] cjohnston, yeah, also, note that every question requires some time for IS to respond [12:18] cjohnston, I think I'll re-ask for the reversal of the last landing, I want to focus on getting attendees adding working and then worry about deploying it all together [12:19] k [12:59] ok, what happened? [13:00] gah, why are reverse lookups failing? [13:12] mhall119: thoughts? [13:12] danilos: and i have both tried production locally and cant reproduce [13:12] he did already put in one fix [13:14] mhall119, I am not sure why would something try to get at summit.schedule.decorators.*, but it does and then fails [13:14] back-resolving URLs at least [13:14] it's fine to go there for decorators [13:14] but not for decorators.summit and decorators.meeting [13:15] mhall119, fwiw, if you've got time to look into this now, I was talking to ChrisS from IS (so he should be on top of things and might be in the process of reverting everything back) [13:16] there was an error with reverting back too [13:16] hes on lunch now [13:16] mhall119, (I am working on getting private attendees working) [13:17] http://paste.ubuntu.com/816407/ [13:23] cjohnston: danilos: using @summit_required decorator makes django think the view function exists in the decorators module (since it's wrapped by a decorator) [13:24] gotcha [13:24] is that whats causing the issue? [13:26] I don't think so [13:26] or it would cause it on localdev and staging too [13:27] http://summit.ubuntu.com/uds-p/2011-10-31/ works fine [13:27] so it can't be something from the base.html [13:27] somthing in summit.html is the problem [13:28] and also in meeting.html [13:30] ya [13:30] but what [13:36] that I don't know [13:42] oh hell, I bet I know what it is... [13:43] cjohnston: are they rolling it back or what? [13:43] mhall119: there was an error with the roleback [13:43] what is it [13:43] if you can come up with a fix, we wont rollback [13:43] using schedule.views.summit instead of summit.schedule.views.summit [13:45] mhall119: ill get them to change it and see [13:46] I'm making the changes locally [13:46] you want a patch or something they can merge into their production branch [13:49] yup [14:14] mhall119: somethings wrong with the css tho [14:14] danilos: its working [14:18] cjohnston, cool, thanks [14:24] cjohnston: please merge my branch into production and trunk [14:24] yup [14:24] already done [14:32] thanks [15:27] mhall119, cjohnston: btw, what happened with the colors on the wide display? also, if I am asked if we can get the wide display to be the default for Connect coming in 2 weeks, how easy would that be? [15:28] you dont want users to see the daily display? [15:29] danilos: just put /display at the end of the daily view [15:29] danilos: colors are defined in the Track record in the admin [15:29] danilos: the colors for the meetings? the tracks have to have colors defined [15:31] cjohnston, mhall119: I figured /display out (had to set connect.linaro.org to load proper URLs since they have changed), but if somebody (eg. Stephen) wants the old default back, I just wonder what should I say (because we are so close to the actual Connect, and the UI has changed significantly) [15:31] danilos: in order to see your private meetings you have to view the display [15:31] the daily [15:31] sorry [15:32] ^^ [15:32] thanks for the tips about colors [15:32] danilos: im going to start working on the layout issues on the linaro side [15:32] cjohnston, oh, so they don't show in the wide display for a day? [15:32] danilos: no [15:32] ok [15:32] they show as "Private Meeting" with no link or details [15:32] danilos: on the wide all it will say is Private Meeting, but you wont know who or where or what [15:33] and getting that working in render.py will be a nightmare [15:33] besides, the wide view horrible for desktop use anyway [15:34] mhall119, well, imho, it has its uses, I agree it's not perfect for looking at "your own" schedule [15:36] danilos: if they have a serious issue with the new schedule, I'll of course do what we can to help [15:36] but if it's just "omg change!", that's going to be hard to justify [15:36] btw, where did the BP link go? maybe it's just epiphany rendering issue [15:36] danilos: it's not in display anymore, it's on the meeting page [15:36] mhall119, well, if it's "omg change 10 days before Connect!", I'd call it a little bit more founded :) [15:36] display is just that, for display [15:37] danilos: in that case we can roll back to the previous production version until after connect [15:38] mhall119, right, and lose the private meeting stuff :) so, I won't speculate anymore and I'll hope nobody complains [15:38] me too :) [15:38] danilos: honestly if it's a deal breaker we can work something in [15:38] mhall119, btw, it'd be nice if BP links worked in the edit interface, I used to use the "display" interface to subscribe to sessions I care about by loading the blueprints directly from that one page [15:39] danilos: we can add it to the new schedule table [15:39] mhall119, yeah, I am not worried about that too much, just trying to be prepared for potential questions [15:40] mhall119, it would be nice if we can make the hover pop-up there stick and have link to a blueprint and similar [15:41] anyway, back to getting private attendees working: I got it mostly working, I just need to restrict the attendees to those for that particular summit [15:42] danilos: they'll "stick" as long as your mouse is over it [15:42] we can either add the blueprint link in the pop-up, or next to the meeting name in the table [15:43] mhall119: we need to restrict the people in managers and schedulers to attendees.. its way too long [15:43] mhall119, heh, I guess that depends on the font size and browser rendering, since there seems to be some space between it and session name for me and it disappears before I can move the mouse on top of it [15:43] cjohnston: we can just order them by username [15:44] danilos: ok, it's a pretty simple thing, we can introduce a jquery-ui widget in it's place in a future release [15:44] its still a gazillion people to try to pick 20 [15:45] cjohnston: technically it shouldn't be you that has to do it [15:45] already got a complaint [15:47] from who? [15:48] arwen [15:49] about setting managers? [15:51] cjohnston: you should have access to leads in the admin now [15:51] ty === james_w` is now known as james_w [17:58] danilos: https://code.launchpad.net/~chrisjohnston/ubuntu-community-webthemes/linaro-fixes/+merge/90165 [17:58] We need to get those changes into production to unbreak the linaro side [18:00] cjohnston, looking, I'll have the attendee stuff shortly as well [18:00] awesome [18:09] cjohnston, looks good to me as well, nothing beats trying it out though :) [18:09] I'm not entirly sure how to try it, other than just replace ubuntu_website with it [18:19] danilos: im testing it locally [18:19] cjohnston, right, cool [18:21] danilos: everything looks good [18:21] cjohnston, great [18:21] mind merging it and asking IS to update the branch? [18:24] cjohnston, I am hoping to be done with my branch soon, so I'd rather focus on that still, and then get it all merged [18:24] ok [18:24] cjohnston, also, I don't have access to merge it anywhere myself [18:24] they are seperate branches and seperate process [18:24] processes [18:25] cjohnston, ah, right [18:25] your the owner to the team that is the owner of the branch [18:25] cjohnston, sure, I'll get that updated as well [18:25] :-) [18:25] ty [18:25] the private meeting page will thank you [18:25] lol [18:41] cjohnston, nigelb_, mhall119: https://code.launchpad.net/~danilo/summit/private-attendees/+merge/90183 [18:41] unfortunately, I didn't have any time to get the tests done (or even started) [18:43] danilos: ill test it [18:43] cjohnston, thanks, I've tested it as well, but I'll appreciate someone looking it over as well [18:45] ok [18:45] danilos: mind testing my two https://code.launchpad.net/summit/+activereviews [18:45] they are both just cleanup items that since we are going to push a release we might as well [18:47] cjohnston, LP is peculiarly slow for me now, pages loading... [18:47] hrm [18:48] danilos: so the linaro theme is good to go, just needs to be asked of IS [18:49] cjohnston, I also wonder if we need to update the theme or what for the top bar to point to lcq1-12 and not uds-q [18:49] danilos: i was trying to figure out how to do that [18:50] danilos: maybe pull the links out of base.html and put them into a header.html file? [18:51] danilos: are these particpants being marked as required? [18:52] cjohnston, yes [18:52] what did you mean about the displaying? [18:53] dude.. it looks awesome [18:53] mhall119: do you want to test it out? [18:53] ive created a meeting and added people, then gone back and edited the meeting, removed some of the initial people, and added some more people [18:53] cjohnston: if you're happy, I'm happy [18:54] ok [18:54] cjohnston: can we use his code as the basis for moving more stuff out of the admin? [18:55] mhall119: i think so [18:55] cool [19:01] danilos: im going to work on some help text too [19:02] cjohnston, I meant that I don't see on the regular meeting page who the attendees are, even if I am an admin or a participant [19:02] i saw it [19:02] below the pad [19:03] danilos: do you want us to add in the ability to define what etherpad to use for a summit? that way pad.l.o can be used? [19:03] cjohnston, yes, please! [19:04] ok [19:04] give me a bit and ill have a couple more MPs for review [19:04] ministers of parliament? [19:04] cjohnston, ah, ok, just me being blind :) [19:04] knome, nope, Municipality Police (Officers) [19:05] he [19:05] cjohnston, to get https://code.launchpad.net/~chrisjohnston/summit/921663/+merge/90185 to work I had to do one simple change (i.e. add ".count" or the if condition always passed) [19:06] hrm.. ok [19:06] it was workin fine for me [19:08] cjohnston, right, I don't know enough of the django templating to explain it, but without .count it didn't work (it showed all the empty "Lead:" lines on the tracks page), with it, it did (it should also be faster I suppose, though still far from optimal approach for rendering a page) [19:10] danilos: without .count, the variable you're testing is an instance of RelatedModelManager [19:10] as a non-None object, it will resolve to True in a logic test [19:10] mhall119, right, I assume something like that, I wonder why did it work for cjohnston in his testing [19:11] wait, having .all should accomplish the same thing [19:11] you don't need .all if you have .count [19:11] mhall119, I wonder if there's something faster than count() for django ORM (something like .any() in Storm) [19:11] .all returns (IIRC), a QuerySet instance [19:11] nigelb_: could you please smack tarmac [19:12] danilos: .count() in django ORM does the count in the SQL, so it's as fast as we can get [19:12] mhall119, you can be faster, you can do COUNT LIMIT 1, that's what Storm does ;) [19:12] unless you have .all() before .count(), in which case it's already loaded all the results [19:13] but COUNT without GROUP BY will always return just one result [19:13] count(*) ? [19:13] mhall119, no, no, I mean you can LIMIT 1 the results that you are counting [19:13] oh, so count is 0 or 1, I gotcha [19:14] you can try track.lead_set.all.0 [19:14] that doesn't have the count, but should do LIMIT 1 [19:15] mhall119, right, that was just me being curious [19:15] cjohnston, anyway, I get just .all() to work now as well, maybe it's some browser caching on my side, sorry [19:15] danilos: it's not like it matters, since we're going to step through and display all the results anyway [19:16] mhall119, indeed [19:16] in fact, using .all in the if will have django cache the results for the inner for loop [19:16] so only one query [19:16] where as with .count it would be 2 [19:16] mhall119, yep, I was mostly worried that it didn't work, and it started working when I introduced the count, if we are to worry about performance, we shouldn't do a single query for each track :) [19:17] ah, the jfun of django internals [19:17] anyway, let me get the theme updated [19:19] mhall119, cjohnston: if you are fine with the private attendees change, can you perhaps arrange for it to be updated? [19:19] mhall119, cjohnston: btw, what was the problem with it in the morning? [19:20] schedule.views.something instead of summit.schedule.views.something [19:20] danilos: as soon as tarmac comes around it will merge the MP [19:20] I'm working right now on the help text [19:20] then ill go back and fix my track lead thing [19:20] then ill add the etherpad thing [19:20] then ill make someone do a bunch of reviews [19:21] then ill make it all go live [19:24] cjohnston, as mhall119 noted, nothing seems to need to change for the track lead thing [19:25] ok.. so then it can be merged as is? [19:25] i missed that convo [19:25] cjohnston, yes, it can [19:26] ok [19:37] mhall119: anything against renderablemixin? [19:41] cjohnston, I'll have to drop out in a minute or two, I'll come back online from home, but I'd appreciate if you guys can get the stuff merged into production branch and file an RT CCing me as well :) if not, I can do at least the part regarding the RT, but I can't land stuff to production branch [19:41] will do [19:41] :-) [19:42] cjohnston, thanks [19:43] danilos: still here [19:44] mhall119: do we want participants on private meetings to be required, or leave it unrequired so that they can edit it later [19:46] danilos: ^ [20:03] cjohnston: can we put the required flag on the form? [20:04] it currently is required [20:04] cjohnston: I don't have a problem with bringing renderablemixin to summit [20:04] cjohnston: that would seem a reasonable default to me, but why can't we have the checkbox like in the admin? [20:04] im trying to figure out how to make the page show it as required [20:04] no.. [20:04] requiring adding a participant [20:04] not marking a participant as required [20:05] oh, I understand now [20:05] I'd say no [20:05] hrm [20:05] i agree [20:05] i gotta figure out how [20:05] they're not very useful without a participant, but maybe they need to reserve a room for a hour to meet with someone not in LP or Summit [20:06] thats what im thinking [20:06] or if they dont know who will be involved [20:06] i think im gonna need some help mhall119 [20:07] does danilos have time? [20:07] I've got some catching up to do with my actual work [20:09] he is headed home [20:09] if it's not a bid deal for connect, we can fix it for uds-q [20:10] its missing a lable [20:10] label [20:10] for participant [20:10] s [20:11] i can wait for danilos [20:26] danilos: when you get back let me know please.. i requested that the theme be updated too [20:30] cjohnston, I've requested that earlier, lamont tells me it should be done, can you please confirm? [20:31] danilos: doesnt seem to be [20:31] there is now an RT for it [20:32] cjohnston, what in particular did you expect to change? [20:32] http://summit.linaro.org/lcq1-12/create_pm/ [20:32] http://summit.linaro.org/lcq1-12/2012-02-06/ [20:32] both should look nicer [20:32] that all looks fine to me (and it did earlier as well), let me try a different browser [20:33] im on chromium and it looks bad [20:33]