| mandel | morning all! | 09:04 |
|---|---|---|
| === mpt_ is now known as mpt | ||
| gatox | good morning! | 11:18 |
| mandel | gatox, buenas! | 11:35 |
| gatox | mandel, how are you? | 11:35 |
| mandel | gatox, let me reboot due to updates :) | 11:35 |
| gatox | mandel, ok | 11:35 |
| mandel | gatox, here everything ok, but I have a pep8 issue I dont understand | 11:38 |
| gatox | mandel, weird..... pep8 shouldn't fail.... pylint i can understand :P | 11:38 |
| mandel | gatox, can you branch lp:~mandel/ubuntuone-control-panel/auto-update-looping-call | 11:39 |
| gatox | mandel, yes! i'll check | 11:39 |
| mandel | gatox, I don't get what is going on | 11:39 |
| mandel | @ping | 11:47 |
| ubot4` | pong | 11:47 |
| * mandel back in a sec | 11:52 | |
| gatox | mandel, ping | 11:54 |
| mandel | gatox, I'm back | 11:54 |
| gatox | mandel, i get this: ./ubuntuone/controlpanel/gui/qt/main/tests/test_windows.py:1:4: E261 at least two spaces before inline comment | 11:54 |
| gatox | pep8 --repeat . | 11:55 |
| mandel | gatox, do pep8 ./ubuntuone/controlpanel/gui/qt/main/tests/test_windows.py --show-source | 11:55 |
| mandel | gatox, and tell me what is wrong in that line if you can | 11:56 |
| mandel | 'cause I see nothing wrong | 11:56 |
| gatox | ok | 11:57 |
| mandel | gatox, ny idea? | 12:00 |
| gatox | mandel, i think that you are saving the file with some end of line issue or something like that..... i see the pep8 issue (with no sense) you mention...... but i open that file with ninja..... save it without modifying anytihng | 12:00 |
| gatox | and now it doesn't show the issue | 12:01 |
| mandel | gatox, can you push that to a branch and I'll pull from it | 12:03 |
| mandel | gatox, wtf pep8! :P | 12:03 |
| gatox | mandel, ok..... but you should use ninja jejeje | 12:04 |
| mandel | gatox, vim vim vim | 12:05 |
| mandel | gatox, the thing is, I want to see the bloody diff :) | 12:05 |
| gatox | ahhhh | 12:05 |
| nessita | hello everyone! | 12:06 |
| gatox | nessita, hi | 12:07 |
| mandel | nessita, morning! | 12:08 |
| mandel | nessita, question from design, the error dialog with the expandable error detail has already landed, right? | 12:08 |
| gatox | mandel, https://code.launchpad.net/~diegosarmentero/+junk/u1-cp-pep8-issues | 12:08 |
| nessita | hola mandel, gatox | 12:09 |
| nessita | mandel: in control panel, yes | 12:09 |
| nessita | mandel: we released that along with the second release, iirc | 12:09 |
| mandel | nessita, ok, superb! I told them so but I was not 100% sure | 12:10 |
| nessita | mandel: why? | 12:10 |
| nessita | ah | 12:10 |
| nessita | gatox: will start reviews now. Is the fix-user-home and which one else? | 12:10 |
| * gatox checking.... | 12:11 | |
| gatox | nessita, this one has already one approve: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-user-home-tests/+merge/88919 and i have 2 more that i consider they are ready..... but noone review them again..... i was hoping alecu could review them | 12:12 |
| nessita | gatox: which one are those? lp:~diegosarmentero/ubuntuone-windows-installer/network-detect and lp:~diegosarmentero/ubuntu-sso-client/remove-disconnect-signal ? | 12:13 |
| gatox | nessita, that 2 | 12:13 |
| ralsina | good morning! | 12:13 |
| gatox | ralsina, hi | 12:14 |
| mandel | ralsina, morning! | 12:14 |
| gatox | nessita, ahhhh about the network-detect branch.... i just realize there is no test to check if the button has the proper style..... we are not doing that everywhere.... but i should add that check, shouldn't i? | 12:16 |
| mandel | nessita, can I haz a review for https://code.launchpad.net/~mandel/ubuntuone-client/add-virtual-watches/+merge/88726 | 12:16 |
| mandel | ? | 12:16 |
| mandel | nessita, I need one more and nor brian nor alecu wrote theirs as reviews but as comments... | 12:17 |
| nessita | gatox: the try again default style? | 12:17 |
| gatox | nessita, yes | 12:17 |
| nessita | mandel: you mentioned you were gonna ask facundo as well, perhaps? I was waiting on that review (besides alecu's) | 12:17 |
| mandel | nessita, I did ask him, but he told be he was too busy at that time | 12:18 |
| mandel | facundobatista, too busy for https://code.launchpad.net/~mandel/ubuntuone-client/add-virtual-watches/+merge/88726 ? | 12:18 |
| facundobatista | mandel, I'll check it | 12:19 |
| mandel | facundobatista, thx! | 12:20 |
| gatox | nessita, i've added the test for the try again button properties | 12:37 |
| nessita | ack! | 12:41 |
| mandel | nessita, whenever you have time can you take a look at https://code.launchpad.net/~mandel/ubuntuone-control-panel/auto-update-looping-call/+merge/81015 | 12:43 |
| gatox | mandel, did you see the diff? | 12:45 |
| mandel | gatox, empty.. no idea what was going on :( | 12:45 |
| gatox | weird...... how you fix it? | 12:45 |
| mandel | gatox, merged with yours :P | 12:48 |
| gatox | :P | 12:48 |
| mandel | gatox, funny thing is, I used vim to remove a line, and it was working.. | 12:48 |
| gatox | mandel, welcome to the world of non deterministic bugs :P jeje | 12:49 |
| alecu | hello all! | 13:00 |
| mandel | alecu, morning | 13:00 |
| * mandel small problem with the beast, will be back in 10 min | 13:00 | |
| gatox | alecu, hi | 13:05 |
| nessita | hola alecu | 13:05 |
| * mandel back | 13:12 | |
| mandel | I have to buy a new tv remote.. the dog eat it :( | 13:12 |
| mandel | alecu, can you re-review https://code.launchpad.net/~mandel/ubuntuone-client/add-virtual-watches/+merge/88726 | 13:12 |
| nessita | gatox: are client test passing for you, in linux? | 13:13 |
| gatox | nessita, for the u1-sso-client branch? | 13:14 |
| nessita | gatox: no, for the u1client branch | 13:14 |
| nessita | gatox: I'm having stuff like this: http://pastebin.ubuntu.com/816404/ | 13:14 |
| nessita | gatox: I'm running trunk now, to see how the suite behve there | 13:15 |
| gatox | nessita, checking..... but that wasn't happening here | 13:15 |
| gatox | nessita, mmmm everything is ok here..... | 13:22 |
| gatox | PASSED (skips=12, successes=2504) | 13:22 |
| nessita | gatox: trunk or your branch? | 13:22 |
| gatox | nessita, my branch | 13:22 |
| gatox | u1-user-home | 13:22 |
| nessita | gatox: trunk is working fine for me... I will re run the suite in your branch | 13:22 |
| nessita | ah no! | 13:22 |
| gatox | :O | 13:22 |
| nessita | gatox: it just failed the same in trunk | 13:22 |
| gatox | what happend? | 13:22 |
| gatox | fiuuuuuuu | 13:22 |
| * gatox thought nessita was going to hit him | 13:23 | |
| nessita | no no | 13:23 |
| nessita | alecu: ping | 13:23 |
| alecu | nessita, pong | 13:24 |
| nessita | alecu: does this ring any bell to you? http://pastebin.ubuntu.com/816413/ | 13:24 |
| alecu | checking | 13:24 |
| mandel | alecu, in the webclient tests, do both implementations run when I do ./run-tests ? | 13:24 |
| alecu | mandel, no: you need to do ./run-tests and ./run-tests -qt | 13:25 |
| mandel | alecu, ack | 13:25 |
| alecu | nessita, how did those errors happen? | 13:25 |
| nessita | alecu: running make check in u1client trunk | 13:25 |
| alecu | nessita, on P? | 13:26 |
| nessita | alecu: yes sir | 13:26 |
| alecu | nessita, I think I found it :-) | 13:29 |
| mandel | nessita, how is the branch you where working on regarding the execution of a child process form sso? | 13:29 |
| nessita | mandel: is going better than yesterday, where I was completely blocked. You already blocked by this? | 13:30 |
| alecu | nessita, it seems that the tests are "mocking" the pynotify module. But if the pynotify module is not installed the platform dependent code just does not install a notifier. | 13:30 |
| mandel | nessita, no necessary, I can work around it or so I believe :) | 13:31 |
| alecu | nessita, and it also happens that the pynotify module is not installed either if the notify GI is available. | 13:31 |
| nessita | alecu: oh... hum.., | 13:31 |
| alecu | nessita, so: either there's a GI for pynotify now, or the pynotify module is not installed. | 13:31 |
| nessita | alecu: how did you reach that conclusion? | 13:32 |
| alecu | nessita, in any case we should make the notify tests be a bit more smarter, and find out what the real notification module is. | 13:32 |
| nessita | nessita@dali:~$ sudo apt-cache policy python-notify | 13:32 |
| nessita | python-notify: | 13:32 |
| nessita | Installed: 0.1.1-3 | 13:32 |
| nessita | alecu: I have pynotify installed | 13:33 |
| alecu | nessita, what does " from gi.repository import Notify" do? | 13:33 |
| nessita | alecu: brings in the GI notify | 13:33 |
| alecu | nessita, right. And that means that the pynotify module is not installed | 13:34 |
| alecu | nessita, (I mean, by our code) | 13:34 |
| alecu | *imported (not installed) | 13:34 |
| nessita | ah!!!! | 13:34 |
| webm0nk3y | alecu: not sure if this is your area | 13:34 |
| webm0nk3y | alecu: oops wrong person | 13:35 |
| webm0nk3y | ralsina: if u1sdtool --waiting lists the same GetDelta 100s of times, is that you? | 13:35 |
| alecu | webm0nk3y, I've got no area... I'm a full field player! | 13:35 |
| mandel | nessita, alecu when we get the credentials from the user in the proxy dialog, those should be stored in the keyring, is that correct? | 13:35 |
| webm0nk3y | ralsina: or a verterok question | 13:35 |
| ralsina | mandel: yes, keyring | 13:36 |
| alecu | mandel, we should find where they are usually stored by the rest of the apps, and try to get/set them in that same place. | 13:36 |
| ralsina | webm0nk3y: it's desktop but it's transitioning, so we will ask verterok later ;-) | 13:36 |
| alecu | mandel, for instance, on windows it's stored in the cred manager, so we could use that same location | 13:36 |
| verterok | webm0nk3y: is it connected? | 13:37 |
| mandel | alecu, so, on windows we can use the keyring class, on linux.. I think each app does what it feels | 13:37 |
| webm0nk3y | verterok: yes | 13:37 |
| verterok | webm0nk3y: hmm, I think it should kill all the other GetDeltas as soon the first one is started | 13:37 |
| verterok | facundobatista: ^ do you remember what we talked about filtering GetDelta's? | 13:38 |
| alecu | mandel, I saw IE storing the creds in that app. If firefox uses those creds, then we should use them too. | 13:38 |
| alecu | mandel, what I'm saying is that we should do a bit of IRL of those other apps and try to have the same behaviour. | 13:38 |
| facundobatista | verterok, #883252 | 13:38 |
| mandel | alecu, ok, I'll do that after lunch, lets see what I get | 13:38 |
| alecu | mandel, and by "that app" I mean... let me find the exact name... | 13:38 |
| verterok | facundobatista: thanks | 13:39 |
| webm0nk3y | facundobatista: thanks | 13:39 |
| verterok | webm0nk3y: bug #883252 | 13:39 |
| ubot4` | Launchpad bug 883252 in ubuntuone-client "Syncdaemon executes multiple GetDelta commands in parallel on the same volume (affects: 2) (heat: 9)" [High,Confirmed] https://launchpad.net/bugs/883252 | 13:39 |
| mandel | alecu, I might propose a couple of small mp which add in increments the code for this thing, I tried to do a proper pipeline :) | 13:39 |
| verterok | webm0nk3y: so, isn't fixed yet :/ | 13:39 |
| alecu | mandel, "Credential Manager" inside the windows control panel. | 13:39 |
| alecu | mandel, cool! | 13:39 |
| mandel | alecu, we use the Credential Manager in the keyring module, so that we have sorted :) | 13:40 |
| alecu | great | 13:40 |
| mandel | alecu, my worry is ubuntu, since for example, FF, Chrome store them in diff places | 13:41 |
| mandel | alecu, I'm off to lunch and I'll bother you a little more with this :) | 13:41 |
| alecu | mandel, afaict chrome (or chromium) uses the keyring | 13:41 |
| alecu | mandel, we should ask the platform team in any case. | 13:42 |
| mandel | alecu, I will, I've checked and empathy uses the keyring too | 13:42 |
| mandel | ok, lunch and we continue | 13:42 |
| nessita | alecu: sobre lo de notifications, abro bug y los skipeo? | 13:44 |
| alecu | nessita, plus one | 13:44 |
| nessita | gatox: confirmed the test failures are the same in your branch and trunk, so that counts as "passing" for your branch | 13:45 |
| nessita | alecu: thanks for the quick debugging | 13:45 |
| gatox | nessita, good | 13:46 |
| gatox | (for my branch :P) | 13:46 |
| alecu | nessita, thank you for finding this. | 13:46 |
| alecu | nessita, you can assign that bug to me | 13:46 |
| nessita | alecu: ack | 13:46 |
| nessita | alecu: may I ask that you dedicate some time this morning to catch up with reviews? I know mandel and gatox are waiting on a review from you (mine can wait till the afternoon or tomorrow) | 13:47 |
| gatox | alecu, pretty please :P | 13:47 |
| alecu | nessita, I was planning on catching up with reviews today after lunch. Sorry guys! | 13:47 |
| nessita | alecu: as it fits best in your schedule, but perhaps mandel's review will flow faster having him around? | 13:48 |
| dobey | nessita: hey. why did you put ubuntuone-windows-installer in your ppu application? :) | 14:11 |
| nessita | dobey: because I made a mistake :-) | 14:12 |
| nessita | dobey: edited | 14:12 |
| dobey | thanks. :) | 14:12 |
| ralsina | nessita: 1-1? | 14:31 |
| nessita | yes! | 14:31 |
| dobey | nessita: the notification errors were from running tests with the gireactor? | 14:40 |
| nessita | dobey: well, it was run using the same make check as usual, but yes, I have the tweaked twisted installed, and the new devtools | 14:41 |
| dobey | nessita: right, but were you modifying the Makefile to run with -r gi, or not? | 14:42 |
| nessita | dobey: nopes | 14:42 |
| dobey | nessita: so you just intentionally removed python-notify? | 14:43 |
| nessita | dobey: not at all | 14:43 |
| nessita | dobey: I have it installed | 14:43 |
| dobey | nessita: that is very odd then :) | 14:44 |
| nessita | dobey: odd that the Notify module was loaded instead of notify? | 14:44 |
| dobey | nessita: yes. | 14:45 |
| dobey | nessita: especially since it can't load if running with the static bindings already loaded | 14:45 |
| nessita | dobey: give me one sec, I'm in mumble, will pay full attention in some minutes | 14:46 |
| dobey | ok | 14:46 |
| === yofel_ is now known as yofel | ||
| nessita | dobey: CONGRATS http://twistedmatrix.com/trac/ticket/4558 | 14:49 |
| dobey | :) | 14:49 |
| nessita | :-) | 14:50 |
| dobey | more work though. i need to update some other related docs in another branch | 14:50 |
| dobey | but the code is there at least, yeah | 14:50 |
| nessita | dobey: awesome | 14:52 |
| * mandel back | 14:55 | |
| mandel | alecu, if you do the review after lunch I can pay attention as long as I'm not walking the dog :) | 14:55 |
| ralsina | alecu, nessita, dobey, briancurtin, gatox: Did I miss anyone's review requests? Remind me now, or forever hold your peace! | 14:56 |
| * gatox checking.... | 14:57 | |
| gatox | ralsina, no..... i'm still working on a branch that will need your review | 14:57 |
| gatox | ralsina, maybe if you have time, you could review this one: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/remove-disconnect-signal/+merge/89761 | 14:58 |
| gatox | it's small | 14:58 |
| nessita | ralsina: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-stuff-from-mainloop/+merge/89956 | 14:58 |
| nessita | alecu: FYI bug #921574 | 14:59 |
| ubot4` | Launchpad bug 921574 in ubuntuone-client "NotificationTestCase failures (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/921574 | 14:59 |
| nessita | dobey: I'm back | 14:59 |
| ralsina | gatox, nessita: thanks, I will do them ASAP | 14:59 |
| nessita | dobey: so, I see from ubuntuone/platform/linux/notification.py that the gi module is being loaded if 'gi' in sys.modules | 14:59 |
| dobey | nessita: right | 15:00 |
| nessita | so seems like that's True when I run it? want me to print sys.modules? | 15:00 |
| gatox | nessita, ping | 15:00 |
| nessita | gatox: pong | 15:00 |
| alecu | nessita, thanks | 15:00 |
| mandel | me | 15:01 |
| gatox | nessita, first standup..... then i'll tell you | 15:01 |
| gatox | me | 15:01 |
| dobey | nessita: well, i'm not sure how that could be true if you haven't changed anything | 15:01 |
| nessita | me | 15:01 |
| briancurtin | me | 15:01 |
| dobey | me | 15:01 |
| alecu | wait for me! | 15:01 |
| mandel | ralsina, ? | 15:01 |
| ralsina | me | 15:02 |
| mandel | shall I then? | 15:02 |
| gatox | mainerror, go | 15:02 |
| dobey | si | 15:02 |
| mandel | DONE: Long conversation with design regarding the proxy UI, user flow and cases when errors might occur. We should get new bugs filled by them reagrding the UI items. Updated lp:~mandel/ubuntuone-control-panel/auto-update-looping-calls, reviews are welcome. Worked on the auth-dialog for proxy, divided the work in small chucks using pipeline. Noticed that the jenkins instance was remove in canonical stack, sidnei was kind enough to fix it. | 15:02 |
| mandel | TODO: more proxy. Talk with the desktop team, where should we store the creds, keyring? | 15:02 |
| mandel | BLOCKED: no | 15:02 |
| mandel | gatox, please! | 15:02 |
| gatox | DONE: | 15:02 |
| gatox | Fixed some branches. Adding tests. | 15:02 |
| gatox | TODO: | 15:02 |
| gatox | Finish with my remaining branches. Propose fix for the installer script. | 15:02 |
| gatox | BLOCKED: | 15:02 |
| gatox | No | 15:02 |
| gatox | nessita, go | 15:02 |
| mandel | gatox, mainerrr your mum! :P | 15:02 |
| gatox | jeje | 15:03 |
| nessita | DONE: proposed branch for bug #919294, had tweaked twisted uploaded to our PPA, reviews, sync with alecu re SSO, restarted work on gtk-gi | 15:03 |
| nessita | TODO: finish and propose gtk-gi branch, restart work on executing an SSO UI from the SSO main loop, 1-1 with ralsina | 15:03 |
| nessita | BLOCKED: nopes | 15:03 |
| nessita | NEXT: briancurtin | 15:03 |
| ubot4` | Launchpad bug 919294 in ubuntu-sso-client "Be able to spwan a process from the mainloop and grab its exit code (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/919294 | 15:03 |
| briancurtin | DONE: cleaned up a few run-tests.bat scripts to exit more cleanly, cleaned up registry checks (might need to change for jenkins). installed jenkins locally and started reading up on it | 15:03 |
| briancurtin | TOOD: get a windows installer built so i can see how it's done in order to automate it, read/play more with jenkins | 15:03 |
| briancurtin | BLOCKED: none | 15:03 |
| briancurtin | NEXT: dobey | 15:03 |
| dobey | λ DONE: gireactor patch for 11.1, packageset proposal, gwibber keyring usage | 15:03 |
| dobey | λ TODO: gwibber tweaks, music store | 15:03 |
| dobey | λ BLCK: None. | 15:03 |
| dobey | alecu | 15:03 |
| alecu | DONE: finished use-restful branch | 15:03 |
| alecu | TODO: catch up with reviews; cleanup branch for unneeded stuff | 15:03 |
| alecu | BLOCKED: no | 15:03 |
| nessita | NEXT: ralsina? | 15:04 |
| ralsina | DONE: mgmt call, nessita 1-1, chipaca 1-1, video lens call, started bureaucracy to hire davidcalle to work on it, defined video lens deliverables, reviews, canonicaladmin, interviewed mac candidate, etc, etc. TODO: gatox 1-1, more CV screening for mac, other stuff, BLOCKED: no | 15:04 |
| briancurtin | also in my TODO is a makeup 1-1 with ralsina | 15:05 |
| ralsina | briancurtin: yes | 15:05 |
| nessita | any comments anyone? | 15:05 |
| gatox | eom? | 15:05 |
| gatox | nop | 15:05 |
| nessita | eom! | 15:05 |
| mandel | no | 15:05 |
| nessita | gatox: shoot | 15:05 |
| ralsina | Comment: if ears could cramp, mine would hurt | 15:05 |
| ralsina | I have been doing waaaaaaaay too many calls | 15:05 |
| gatox | nessita, now...... about this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/folder-show-garbage/+merge/89094 | 15:05 |
| nessita | dobey: http://pastebin.ubuntu.com/816516/ | 15:06 |
| nessita | gatox: yes | 15:06 |
| * mandel back to code! | 15:06 | |
| gatox | nessita, i'm running into some ipc problems trying to create an udf..... but is not related to this branch..... i think it would be better to create another bug for the udf issues..... because the bug associated to this branch was about ui | 15:06 |
| nessita | gatox: what IPC issues? | 15:07 |
| gatox | nessita, i can create the other bug and take it if you want.... is unicode related | 15:07 |
| nessita | gatox: is the error the one I reported in the MP? | 15:07 |
| dobey | nessita: how? | 15:07 |
| === mpt_ is now known as mpt | ||
| nessita | dobey: go to trunk, run: u1trial tests/platform/linux/test_notification.py | 15:08 |
| nessita | dobey: having nightlies installed and updated | 15:08 |
| gatox | nessita, it doesn't seem to be that one..... because this issue is from u1-cp side..... never reach syncdaemon (in the user with weird username.... it works fine in the other one) | 15:08 |
| nessita | gatox: I tested with a user with a weird username | 15:08 |
| nessita | gatox: have a trace of your error? | 15:09 |
| * gatox checking.... | 15:09 | |
| nessita | gatox: this is the home of the user I used: C:\\Users\\\xe5\x8d\x97\xe6\xb8\xa1\xe6\xb1\x9f \xd7\xa0\xd7\x95\xd7\xa0\xd7\x95 | 15:09 |
| gatox | jjjee nice username | 15:09 |
| nessita | which is: C:\Users\南渡江 נונו | 15:10 |
| nessita | gatox: is my default user now, is the onle one I use in windows | 15:10 |
| gatox | nessita, i'm using both yet | 15:10 |
| gatox | nessita, this is the log i have: http://paste.ubuntu.com/816519/ | 15:11 |
| dobey | nessita: ok, upgrading now | 15:12 |
| gatox | nessita, ahhhhhh it reach syncdaemon | 15:12 |
| gatox | i just saw it | 15:12 |
| gatox | nessita, and yes..... it's the same bug | 15:13 |
| gatox | nessita, so the ipc issue..... maybe is related to syncdaemon answer | 15:13 |
| nessita | gatox: what do you mean by syncdaemon answer? | 15:13 |
| gatox | or the lack of answer | 15:13 |
| nessita | gatox: nopes, look the log in syncdaemon | 15:14 |
| nessita | 2012-01-19 11:00:45,207 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - handle_VM_UDF_CREATE_ERROR: args (<ubuntuone.syncdaemon.interaction_interfaces.SyncdaemonEventListener object at 0x033AFED0>,), kwargs {'path': 'C:\\Users\\\xe5\x8d\x97\xe6\xb8\xa1\xe6\xb1\x9f \xd7\xa0\xd7\x95\xd7\xa0\xd7\x95\\Links', 'error ': "INVALID_PATH: 'ascii' codec can't decode byte 0xe5 in position 0: ordinal not in range(128)"}.\ | 15:14 |
| nessita | gatox: is in the merge proposal, I pasted that on 2012-01-19 | 15:14 |
| nessita | gatox: do you also have that error? | 15:14 |
| gatox | nessita, yes..... i'm looking at the trace in my machine too | 15:14 |
| gatox | nessita, yes | 15:14 |
| nessita | gatox: so, I put in the comment: "Would you please confirm if the problem is in syncdaemon's end or controlpanel's end?" | 15:15 |
| nessita | gatox: do you know if the controlpanel is sending the wrong path, or syncdaemon is not processing it properly? | 15:15 |
| gatox | nessita, yes, i saw it and in my opinion the problem is in syncdaemon | 15:15 |
| nessita | gatox: did you confirm if controlpanel is sending unicode thru IPC? | 15:16 |
| gatox | nessita, i'll check now...... but i think the problem is that the data is not being encoded/decoded from syncdaemoon side | 15:16 |
| nessita | gatox: be careful, because a single layer has to do encode/decode, and that layer is interaction_interfaces. No other layer should do that (and perhaps os_helper on windows, but that's for transforming into unicode) | 15:17 |
| nessita | gatox: we need to ensure some invariants regarding IPC. One invariant is: every call receives unicode, and every call return unicode | 15:18 |
| gatox | nessita, ok..... i'll confirm that control panel is sending the right stuff | 15:18 |
| nessita | gatox: if we're making a IPC call without sending unicode, the problem (at least one of the problems) is the caller | 15:18 |
| nessita | dobey: were you able to reproduce? | 15:19 |
| gatox | nessita, ok....... i'll let you know as soon as i have something.... | 15:19 |
| * gatox lunch now | 15:19 | |
| gatox | brb | 15:19 |
| dobey | still upgrading | 15:20 |
| === gatox is now known as gatox_lunch | ||
| dobey | nessita: hrmm, it does fail for me with that. weird | 15:34 |
| dobey | well, using laptop for mumble is sort of ok | 15:36 |
| dobey | really need working synergy though | 15:37 |
| mandel | ha, I'm back! | 15:39 |
| dobey | damn | 15:40 |
| dobey | grr, netsplit | 15:41 |
| ralsina | LUNCH! | 15:51 |
| mandel | alecu, so, lets say we use that ugly idea of username: password we should not promp for the creds, right? | 15:53 |
| alecu | mandel, what if the creds expire? | 15:55 |
| dobey | get a bucket and fill it with tears? | 15:55 |
| mandel | dobey, that sounds about right... | 15:56 |
| dobey | hehe | 15:56 |
| === bdmurray_ is now known as bdmurray | ||
| mandel | alecu, so, we either tell the current way to work, frack off we know better and have a dialog and store that in the keyring or we work like the rest of the apps (aka do it wrong), or fix gnome 3 | 16:01 |
| mandel | dobey, sounds about right? ^ | 16:01 |
| alecu | mandel, have you tried it IRL? | 16:02 |
| mandel | alecu, what, using the default settings and then changing the creds? | 16:02 |
| mandel | I can easily do it :) | 16:03 |
| dobey | mandel: i think it's safe to assume we'll have to do it ourselves or fix gnome3. | 16:03 |
| alecu | mandel, yes: I mean with a few apps... firefox, chromium, empathy | 16:04 |
| mandel | alecu, changing my settings right now :) | 16:04 |
| === jackyalcine is now known as Guest1073 | ||
| === gatox_lunch is now known as gatox | ||
| mandel | @ping | 16:09 |
| ubot4` | pong | 16:09 |
| mandel | alecu, dobey so, xchat, firefox, are smart and know how to do it while chrome asks for the creds | 16:11 |
| alecu | mandel, so they all know how to parse when you enter "user:pass@host" in the gnome dialog? | 16:11 |
| dobey | mandel: i found this blog post earlier: http://www.gnomeshell.com/2011/04/30/gsettings-api-how-to/ | 16:12 |
| mandel | alecu, not all of them, chrome did know how to use the url, yet I had to provide my username and password again | 16:12 |
| dobey | mandel: the last + line in the patch linked is a comment that says "no authentification support in gnome3" :( | 16:12 |
| duanedesign | Mandel would you have a second to look at an rt ticket for me? | 16:13 |
| dobey | mandel: what about epiphany? (apt-get install epiphany-browser) | 16:13 |
| mandel | duanedesign, shoot! | 16:14 |
| mandel | dobey, installing | 16:14 |
| alecu | mandel, also: if you leave the user:pass out, do they ask you for credentials (xchat, firefox)? where do they store them? | 16:14 |
| * mandel feels like a webdeveloper with several browsers... lame | 16:14 | |
| alecu | mandel, also: where did chrome store the credentials? | 16:15 |
| mandel | alecu, let me look at epiphany and will do that | 16:15 |
| alecu | likely the keyring | 16:15 |
| alecu | sure | 16:15 |
| dobey | mandel: do you have glib-networking installed? | 16:15 |
| dobey | alecu: ^^ | 16:15 |
| dobey | they don't use the keyring | 16:15 |
| dobey | http://git.gnome.org/browse/glib-networking/tree/proxy/gnome/gproxyresolvergnome.c | 16:16 |
| nessita | yey! /me is back | 16:16 |
| duanedesign | mandel: http://ubuntuone.com/1DSHjFhtlKzpfYdDjGh7YB | 16:16 |
| duanedesign | mandel: if you can view the RT system https://support.one.ubuntu.com/Ticket/Display.html?id=10146 | 16:16 |
| duanedesign | mandel: is it a matter of removing that tritcask file? | 16:17 |
| mandel | duanedesign, looking | 16:17 |
| mandel | duanedesign, I'm getting an error when trying to get in the rt system using sso :( | 16:18 |
| dobey | alecu, mandel: it appears gsettings keys are used, but i don't know what sets the keys exactly. | 16:18 |
| mandel | dobey, epiphany-browser works correctly | 16:19 |
| dobey | mandel: what happens if you set it to an authenticated host, but don't have the user:pass in the url? | 16:20 |
| mandel | @ping | 16:22 |
| ubot4` | pong | 16:22 |
| mandel | so I'm still here | 16:22 |
| mandel | duanedesign, what is the exact problem, can you describe it for me | 16:22 |
| mandel | dobey, alecu if I use the domain and do no use the pattern username:password@domain | 16:22 |
| alecu | mandel, yes, what happens? | 16:23 |
| mandel | I get a dialog asking for the creds ( epiphany-browser) which are later stored in the keyring | 16:23 |
| mandel | alecu, dobey ^ | 16:23 |
| nessita | gatox: ping | 16:23 |
| alecu | mandel, nice. what about firefox, empathy? do they use the same keyring place? | 16:23 |
| * mandel looks | 16:23 | |
| duanedesign | mandel: file was not uploading, I renamed the file, and it said syncing for a while in the app, but the | 16:25 |
| duanedesign | file still failed to appear online. | 16:25 |
| mandel | duanedesign, may I see logs? sorry I have some problems with the rt system :( | 16:26 |
| mandel | alecu, chrome does not use the same key, looking at ff | 16:27 |
| gatox | nessita, pong | 16:27 |
| duanedesign | mandel: i PM'd the logs | 16:27 |
| nessita | gatox: in your network-detect branch, in windows-installer | 16:28 |
| gatox | aja? | 16:28 |
| alecu | mandel, can you send a small mail with these results? the name of each keyring key is interesting in each case. | 16:28 |
| nessita | gatox: if I see the diff correctly, you added some methods to SuccesPageTestCase | 16:28 |
| alecu | mandel, so we can later choose where should we store the settings. | 16:28 |
| nessita | gatox: get_pixmap_data and assertEqualPixmaps. Why did you add those there? | 16:28 |
| alecu | (my opinion is: wherever firefox stores them) | 16:29 |
| gatox | nessita, let me check | 16:29 |
| mandel | alecu, if it does store them.. which I don't know yet | 16:29 |
| alecu | mandel, gatox, nessita: I need to go for some errands and lunch: after that it's review evening for me. | 16:30 |
| gatox | nessita, yes..... i added those methods because i needed to check that the image was the proper one.... also, after talking with alecu i created a bug to move those methods to a common place, probably in sso, because we are using that in cp too in different places | 16:30 |
| nessita | alecu: ack | 16:30 |
| gatox | alecu, ack | 16:30 |
| mandel | alecu, ok | 16:31 |
| nessita | gatox: but you added the method in SuccesPageTestCase... and unless I missing something, I don't see that test case using that | 16:31 |
| gatox | nessita, ohhhhh..... probably was removed in some merge..... :S crap | 16:32 |
| nessita | gatox: let me know when is cleared what happened | 16:32 |
| gatox | nessita, sorry about that.... i'll add it again | 16:32 |
| nessita | no problem | 16:32 |
| === alecu is now known as alecu_away | ||
| gatox | nessita, that weird..... i have the changes here..... but i can't push because it says is up to date | 16:35 |
| nessita | gatox: did you commit the changes? | 16:35 |
| mandel | alecu, firefox stores them in firefox thing.. I'm going to try to find what exactly is doing | 16:35 |
| dobey | mandel: interesting | 16:36 |
| === mpt_ is now known as mpt | ||
| nessita | gatox: what does bzr st say? | 16:36 |
| gatox | nessita, yes..... bzr status shows me nothing too | 16:36 |
| nessita | gatox: are those changes in the diff in LP? | 16:36 |
| nessita | gatox: what revno are you in? | 16:36 |
| gatox | nessita, not in LP..... 120 | 16:36 |
| nessita | gatox: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/network-detect/+merge/77049 shows up to revno 120 | 16:37 |
| mandel | the proxy support is a major mess ... | 16:37 |
| dobey | ok, i am going to get some lunch. bbiab | 16:37 |
| gatox | nessita, i know which is the problem | 16:38 |
| nessita | gatox: tell me :) | 16:38 |
| gatox | nessita, the function that use assertEqualPixmap is already in trunk..... probably in some refactor that i miss..... and those methods were defined in BaseTestCase..... so i can't remove them from this branch | 16:39 |
| nessita | gatox: ack | 16:40 |
| gatox | nessita, probably in some of my installer branches that was needed, and i add it in a common place | 16:40 |
| nessita | perhaps | 16:41 |
| nessita | ralsina: help! | 16:41 |
| nessita | briancurtin: hey! may I have borrow your expertise for some minutes? | 16:42 |
| briancurtin | nessita: sure | 16:42 |
| nessita | briancurtin: any idea why calling mkdir fails there: http://pastebin.ubuntu.com/816639/ | 16:42 |
| nessita | briancurtin: am I missing something obvious? | 16:42 |
| gatox | nessita, ok..... i've updated that branch removing the unnecessary functions..... tests in windows and linux ok | 16:43 |
| nessita | gatox: ack | 16:44 |
| nessita | briancurtin: is like mkdir is not in the PATH, right? which is a puzzle to me... since when using the terminal, mkdir is in the PATH | 16:45 |
| briancurtin | nessita: you would need shell=True | 16:45 |
| nessita | briancurtin: would I? would you explain why? (and why is not needed shell=True in Linux) | 16:46 |
| briancurtin | mkdir isn't actually on the path, it's built into the shell itself (like dir) | 16:46 |
| nessita | briancurtin: an on linux it is an "external" executable... | 16:48 |
| briancurtin | i'm not 100% sure on why you don't need it on linux, but on windows things like dir, copy, move and such are commands rather than actual programs | 16:48 |
| briancurtin | ah | 16:48 |
| === teknico_away is now known as teknico_ | ||
| === teknico_ is now known as teknico | ||
| nessita | briancurtin: perhaps you can help me with this... I'm trying to build a multiplatform test suite where I spawn a program and check that the program was successfully ran | 16:52 |
| nessita | briancurtin: so, atm, I was spwaning 'mkdir test-me' and checking that test-me was successfully created | 16:53 |
| nessita | briancurtin: but that will not work on windows using the spawnners I'm using (twisted's in this case) | 16:53 |
| nessita | any advice what program/command to spawn that will not involve that much trouble or platform issues? | 16:54 |
| briancurtin | nessita: i've always just used subprocess.Popen, but the convenience functions like check_output and such are nice. as long as the target is just an executable or a python script, it should work | 16:55 |
| briancurtin | you could always try os.system as well if you don't need all of the stuff subprocess.Popen provides | 16:56 |
| briancurtin | what type of program are you trying to spawn? some executable or another python script? | 16:56 |
| nessita | briancurtin: I can't use subprocess since I need to make the spawnning async, and subprocess.call is blocking, and subprocess.Popen will force me to do some polling to check when the child process has finished | 16:56 |
| nessita | briancurtin: any program, this is a generic spawning function | 16:56 |
| nessita | briancurtin: the spwanner are already built, the problem is running the test suite in windows | 16:57 |
| nessita | briancurtin: the branch is https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-stuff-from-mainloop/+merge/89956, if you can take a look at it, perhaps my issue is clearer | 16:57 |
| briancurtin | nessita: i'll take a look at the branch. off the top of my head the best you could do is polling Popen, but I'll look around | 16:58 |
| nessita | briancurtin: thanks. A couple of key lines in that merge proposal: line 253 has the generic spawnner, which will use twisted/glib or qt depending on some conditions. The specific test that is failing for me in windows is: line 400 (test_program_is_spawned). It fails because mkdir can not be found to be executed. | 17:00 |
| nessita | I will have lunch in the mean time :-) | 17:01 |
| * nessita -> lunch | 17:01 | |
| gatox | nessita, confirmed....... u1-cp is sending unicode | 17:29 |
| gatox | nessita, i'm checking what is happening with u1-client | 17:29 |
| nessita | gatox: awesome | 17:38 |
| * nessita is back | 17:38 | |
| nessita | briancurtin: would you have any conclusions? | 17:39 |
| briancurtin | nessita: would it be possible to use muliprocessing.Pool and asynchronously apply a command to it, something like https://pastebin.canonical.com/58787/ | 17:40 |
| gatox | nessita, so..... i think that the branch is ready for review..... and if you think it's ok.... i'll create the bug for this problem and start working on that (i've been debugging it for a while) | 17:40 |
| ralsina | nessita: sorry, was having lunch! What happened! | 17:41 |
| nessita | ralsina: is ok, I asked for brian's help | 17:41 |
| ralsina | cool :-) | 17:41 |
| gatox | nessita, agree? | 17:41 |
| nessita | briancurtin: I see, and does that code use / integrates to any mainloop to progress? | 17:42 |
| nessita | gatox: ack, when you file the bug please add it as a reply to my comment in your MP | 17:42 |
| gatox | nessita, yes | 17:42 |
| gatox | ralsina, i have a branch for review if you still have some time | 17:43 |
| gatox | ralsina, you appear as one of the reviewers | 17:43 |
| ralsina | gatox: ok, link? I will queue it up | 17:43 |
| gatox | ralsina, https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/folder-show-garbage/+merge/89094 | 17:43 |
| gatox | thanks | 17:43 |
| briancurtin | nessita: ehh, it would still block your main thread on that join, so i guess it wouldn't work (it's really meant for running numerous calculations, not one command). i'll poke around a bit and see if i can make it better or find another way | 17:45 |
| nessita | briancurtin: wait :-). I already have async ways to spawn programs, so that's not really the issue | 17:45 |
| nessita | briancurtin: my question was related to testing my current spawnners | 17:46 |
| nessita | briancurtin: I was looking for a real-life command/program that will work on linux and windows | 17:46 |
| dobey | nessita: python -c "print 'foo'" ? | 17:47 |
| briancurtin | ah, dobey beat me to it | 17:47 |
| ralsina | just calling "python" may or may not work on windows depending on PATH but close enough | 17:48 |
| briancurtin | from the existing program just call sys.executable | 17:48 |
| mandel | dobey, so, by looking at different ups, each of them does wtf the fuck it wants, example of firefox: https://developer.mozilla.org/en/Using_nsILoginManager | 17:48 |
| mandel | dictators are clearly needed sometimes... | 17:49 |
| dobey | mandel: firefox is especially weird | 17:49 |
| mandel | dobey, most of mozilla things are weird.. | 17:50 |
| dobey | yes | 17:50 |
| dobey | ralsina: as briancurtin said, sys.executable can be used, no? :) | 17:51 |
| ralsina | dobey: yes, that should work | 17:51 |
| nessita | briancurtin: so I can use that in the tests, and assert it worked. Depending on shell=True is not an option, since besides being insecure, I can not tweak how my current spawnners do the spawnning | 17:55 |
| nessita | spawn, spawn, spawn, the word is getting weird :-P | 17:55 |
| nessita | briancurtin: I can go slower if you want, I think I'm not explaining myself correctly | 17:55 |
| nessita | briancurtin: have some time to continue with this? | 17:55 |
| nessita | briancurtin: ping? | 17:55 |
| briancurtin | nessita: yeah i do | 17:56 |
| nessita | briancurtin: can you please branch the branch I mention a couple of lines above in windows, an run this command: | 17:56 |
| ralsina | take a look at mimetypes.guess_type | 17:57 |
| nessita | python C:\Python27\Scripts\u1trial -r twisted -t .SpawnProgramTestCase.test_program_is_spawned$ ubuntu_sso\utils\tests\test_runner.py | 17:57 |
| mandel | ok, EOD for me, expect and email from me later on complaining about each bloody app in the ubuntu ecosystem doing wtf it wants regarding the storage of proxy creds | 17:57 |
| briancurtin | nessita: doing right now | 17:58 |
| nessita | briancurtin: and let me know what's the output for you (you would need to properly set PYTHONPATH=. before running that) | 17:58 |
| briancurtin | nessita: https://pastebin.canonical.com/58790/ | 18:00 |
| nessita | gatox: ubuntuone-windows-installer/network-detect apporved | 18:00 |
| gatox | nessita, cool! thanks | 18:00 |
| nessita | briancurtin: great, the same error as me. Can you please edit the file: ubuntu_sso/utils/tests/test_runner.py | 18:01 |
| nessita | briancurtin: and change args = ('mkdir', TEST_ME_DIR) with args = ('notepad',)? | 18:01 |
| nessita | briancurtin: I would expect that to work, but it fails the same. And that mkdir fails I understand, from what you say. But why notepad is also failing? | 18:01 |
| briancurtin | nessita: notepad also fails. i would guess os.environ is not passed along, or is somewhere explicitly blank? | 18:04 |
| nessita | well, that's the thing | 18:05 |
| nessita | briancurtin: I pass environ to the call (see ubuntu_sso/utils/runner.py, line 80) | 18:05 |
| nessita | briancurtin: and I also put a pdb in twisted's source code, and printed PATH | 18:06 |
| nessita | briancurtin: and this is the result: https://pastebin.canonical.com/58791/ | 18:06 |
| nessita | C:\\Windows\\system32 is in path (no idea where notepad is :-P) | 18:07 |
| briancurtin | yeah notepad will work given that PATH. this is really weird... | 18:08 |
| nessita | briancurtin: that's why I pinged our windows expert! | 18:10 |
| briancurtin | nessita: i'll step into it and see if i can find where it's dropping the path or whatever may be happening | 18:12 |
| nessita | briancurtin: awesome, thanks. I will be here doing a review for gatox, do not hesitate to ping me | 18:13 |
| gatox | nessita, i find where everything explode :P common_prefix = os.path.commonprefix([start_list, path_list]) | 18:21 |
| gatox | something in that list is not in commonprefix taste :P | 18:21 |
| nessita | gatox: oh hum, we need to transform to unicode there? | 18:22 |
| gatox | nessita, ahhhhh i know what the problem is..... the comparison is failing because one of the list is str..... and the other one all unicode | 18:22 |
| gatox | i think is something related to that.... i'll check | 18:23 |
| nessita | ack | 18:23 |
| dobey | yay, monitor arm. | 18:35 |
| ralsina | dobey: is that like tennis elbow? | 18:35 |
| ralsina | dobey: or athlete foot? | 18:36 |
| dobey | no | 18:36 |
| dobey | it's more like the cure for it | 18:36 |
| blueyed | Is it possible to restore/get previous versions of a specific file? | 18:39 |
| beuno_ | blueyed, not at the moment, no | 18:39 |
| gatox | nessita, ping | 18:39 |
| === beuno_ is now known as beuno | ||
| blueyed | Too bad.. and I just missed the 30-day period that Dropbox provides (for free) - which would hold the same file. Meh. | 18:40 |
| gatox | nessita, expand_user should be returning unicode, isn't it? I'm asking because in this moment is returning bytes, and when i change it, i found out that config.py was asserting the result of expand_user if it is instance of str...... just want to be sure which one is wrong.... i think config.py | 18:42 |
| nessita | gatox: every single function in os_helper has return bytes | 18:44 |
| gatox | nessita, yes..... ok..... the comment at expand_user method was wrong | 18:44 |
| nessita | looking | 18:44 |
| nessita | gatox: where is expand_user? | 18:46 |
| nessita | is not on ubuntuone/platform/os_helper.py, no? | 18:46 |
| gatox | nessita, ubuntuone/platform/__init__.py | 18:47 |
| gatox | no | 18:47 |
| nessita | I see | 18:47 |
| nessita | the comment was added by you, I'd guess, no? | 18:47 |
| nessita | you should know why is there :-P | 18:47 |
| gatox | nessita, yes.... i think so | 18:48 |
| gatox | nessita, my own comment confuse me | 18:48 |
| gatox | because it wasn't returning unicode | 18:48 |
| nessita | heh | 18:48 |
| ralsina | gatox: never trust your own comments. If the comment is by someone else, there is a chance he knows better. By definition, you don't know more than yourself. | 18:49 |
| gatox | fixed udf stuff :D | 18:51 |
| === mpt_ is now known as mpt | ||
| ralsina | gatox,nessita: +1 for both | 18:58 |
| nessita | gatox: how did you fix it? | 18:58 |
| dobey | nessita: ah of course. i know why were getting the import error issues, and the notify test failures, with the new reactor. | 18:59 |
| gatox | nessita, i'm still testing, to check i didn't miss anything.... but i could create a udf decoding the result of expand_user from get_suggested_udf_path, in order to create the proper lists and compare them | 19:00 |
| gatox | ralsina, cool! thanks | 19:00 |
| * dobey thinks for a minute how to deal with this the best way | 19:00 | |
| nessita | dobey: why?!?! | 19:01 |
| nessita | gatox: makes sense | 19:02 |
| dobey | nessita: because in the reactor, we set the sys.modules[] entries for the other bindings to None, to prevent segfaults :) | 19:02 |
| nessita | I see | 19:02 |
| dobey | nessita: so just checking that x is in sys.modules[] isn't enough now :) | 19:03 |
| dobey | of course, the error from python isn't exactly helpful | 19:03 |
| dobey | nessita: i am fixing it though, so don't worry :) | 19:04 |
| blueyed | I assume there's a wishlist item for "history of items" already, but cannot find it. I'd like to subscribe there. | 19:07 |
| dobey | blueyed: bug #423405 is one it looks like | 19:13 |
| ubot4` | Launchpad bug 423405 in ubuntuone-client "Ubuntu-one team with bzr (affects: 1) (heat: 16)" [Wishlist,Triaged] https://launchpad.net/bugs/423405 | 19:13 |
| blueyed | Thanks, dobey. I am quite suprised that this isn't a feature considered to be more important / already implemented. | 19:16 |
| blueyed | In my case I would like to have an older version of .encfs/.encfs6.xml - which I would not have under version control itself anyway. | 19:16 |
| nessita | gatox: review added to https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/remove-disconnect-signal/+merge/89761 | 19:23 |
| gatox | nessita, ok | 19:24 |
| nessita | gatox: the diff also has some fixes to the import style, which was not matching our current standards | 19:24 |
| gatox | nessita, ok, thanks | 19:25 |
| alecu | gatox, ping | 19:27 |
| gatox | alecu, pong | 19:27 |
| alecu | gatox, why did you change setMinimumHeight to setFixedHeight? | 19:28 |
| dobey | nessita: am currently running make test with new reactor. :) | 19:28 |
| alecu | in the network detect branch, that is... | 19:28 |
| nessita | dobey: was it a "Local" fix or in twisted? | 19:28 |
| gatox | alecu, because we know that is the higher size.... and NetworkDetectionPage was having issues to adjust the size to minimum...... | 19:29 |
| alecu | gatox, that's a value in pixels, right? | 19:29 |
| alecu | gatox, what if the user has enlargened the fonts? | 19:29 |
| alecu | gatox, what if the display has different dpis? | 19:29 |
| gatox | alecu, mmmmmmm you are right..... it should me minimum | 19:30 |
| gatox | and force the networkdetectpage | 19:30 |
| dobey | nessita: local. i haven't fixed all the issues yet, but am running make test to see what all comes up. then i will fix those and run again | 19:31 |
| alecu | gatox, should I add a comment to the MP? | 19:32 |
| gatox | alecu, yes please | 19:32 |
| alecu | gatox, as a rule of thumb, I dislike using absolute pixel values anywhere in the code or the .ui files, so the "setMinimumHeight" or setFixedHeight are in my opinion hiding some other problems. | 19:34 |
| gatox | alecu, the minimum is because the idea is not to resize the wizard everytime the user change from one page to the next...... so we choose as minimum the size in pixels from the bigger page | 19:35 |
| gatox | alecu, in one moment we talk about check all the pages in runtime, take the size of the bigger one and set that..... but that idea was out of scope | 19:36 |
| alecu | gatox, yes, that makes sense. But usually you can create all pages in advance and put them in the wizard container and it will calculate the right size by itself. | 19:37 |
| alecu | gatox, anyway, don't worry about that :-) | 19:37 |
| gatox | alecu, the problem was that the wizard doesn't do that...... it adjust the size per page.... so before everytime you move to the next page, the wizard was resized | 19:39 |
| gatox | alecu, but yes..... fixed wasn't the best solution | 19:40 |
| nessita | alecu: ping re: libsoup and body read | 19:52 |
| alecu | nessita, pong | 19:53 |
| alecu | nessita, good news I hope | 19:53 |
| nessita | alecu: unping then :-P | 19:53 |
| alecu | nessita, :-) | 19:53 |
| nessita | alecu: I'll do some more research before sharing | 19:54 |
| nessita | to see if I can get some good news :-D | 19:54 |
| dobey | heh | 19:55 |
| nessita | briancurtin: do you have some good news to me? :-D /me needs some | 19:57 |
| briancurtin | nessita: sorry, got sidetracked with a 1-1 and then lunch/trying to get mumble to work. im getting back to your problem...so weird | 19:58 |
| nessita | briancurtin: ack, let me know if you find something out | 19:59 |
| gatox | EOD for me..... see you later | 20:01 |
| === gatox is now known as gatox_brb | ||
| dobey | ugh, mocker | 20:10 |
| === gatox_brb is now known as gatox | ||
| alecu | nessita, why does each _spawn_program_* function receives a reply_handler and an error handler? can't you make all those functions return a deferred instead? | 20:24 |
| nessita | alecu: yeah, I could | 20:24 |
| alecu | nessita, that's what spawn program ends up doing, but I don't understand why the indirection makes sense. | 20:24 |
| nessita | I liked better that way, I found them more testable that way... | 20:25 |
| nessita | alecu: I don't feel strong about that... considering that is not the twisted spawner is not working on windows, I would like to burn down that branch | 20:26 |
| alecu | nessita, enoparse | 20:27 |
| nessita | alecu: sorry. From the top: | 20:27 |
| nessita | considering that the twisted spawner is not working on windows (brian is helping me debug that), I would like to burn down that branch, I'm kinda tired of it :-) | 20:27 |
| nessita | alecu: I can change that if you think it will help the reading | 20:28 |
| alecu | nessita, oh, right. Probably the qt4reactor... :-( | 20:28 |
| nessita | alecu: the thing that is not working is that twisted can not execute the process, can't find the file. Let me show you the trace | 20:29 |
| alecu | nessita, I'm not sure if the branch will change much with that change, I was trying to understand the code. | 20:29 |
| nessita | alecu: https://pastebin.canonical.com/58790/ | 20:29 |
| nessita | alecu: even changing the "args" in the test, pointing it to execute ('notepad',), will not work | 20:30 |
| alecu | nessita, what about including the full path to the notepad exe? | 20:30 |
| nessita | alecu: I just fixed the webclient souppy backend! | 20:30 |
| nessita | alecu: let me try that | 20:30 |
| alecu | nessita, soupy: cool! | 20:30 |
| nessita | alecu: https://pastebin.canonical.com/58807/ | 20:31 |
| nessita | alecu: I will leave you adding the test for that :-D | 20:31 |
| nessita | alecu: absolute path for notepad.exe will work | 20:34 |
| alecu | nessita, I was expecting that last paste to be a diff or a file of ours. | 20:34 |
| nessita | alecu: I can easily do that, but perhaps you wanted to run it in isolation | 20:34 |
| nessita | briancurtin: FYI, changing args to be ('C:\\Windows\\system32\\notepad.exe',), makes the spawning works | 20:35 |
| alecu | nessita, no problem, but what was the issue? | 20:35 |
| briancurtin | nessita: for the first param of CreateProcess - "The function will not use the search path." - if it's not in the current directory you need to construct a full path (which subprocess.Popen does for you, i think) | 20:35 |
| briancurtin | (i was just typing that when you sent) | 20:35 |
| briancurtin | i'm looking at how subprocess.Popen handles it, because it works with just "notepad.exe" | 20:35 |
| nessita | briancurtin: but in Linux it will use the content of PATH.... | 20:35 |
| alecu | nessita, http://twistedmatrix.com/documents/current/api/twisted.internet.interfaces.IReactorProcess.spawnProcess.html | 20:36 |
| nessita | alecu: the key part is: | 20:36 |
| nessita | while written < total: | 20:36 |
| nessita | buffer = body.get_chunk(written) | 20:36 |
| nessita | written += buffer.length | 20:36 |
| nessita | response += buffer.get_data() | 20:36 |
| alecu | nessita, "executablethe file name to spawn - the *full path* should be used" | 20:36 |
| nessita | alecu: I'm using a higher level fuction, that should solve that | 20:36 |
| nessita | alecu: I'm using utils.getProcessOutputAndValue | 20:36 |
| nessita | alecu: which, at least in LInux, resolves PATH automaticallty | 20:37 |
| alecu | nessita, http://starship.python.net/crew/mwh/apidocs-2.0.1/twisted.internet.utils.html | 20:37 |
| nessita | alecu: that function accepts an env dict, which I'm passing os.environ | 20:37 |
| alecu | executableThe file name to run and get the output of - the full path should be used | 20:37 |
| alecu | nessita, it says the same regarding full path there ^ | 20:38 |
| briancurtin | it passes the env on but doesn't use it to figure out the path of the exe | 20:38 |
| alecu | nessita, also, it uses the same underlying reactor.spawnProcess function, so it has the same limitations regarding env.... | 20:38 |
| nessita | damned twisted, it resolves it properly on Linux | 20:38 |
| nessita | alecu: well, I would hope that utils will resolve that... but I see | 20:39 |
| alecu | briancurtin, right, it passes the env but does not use it | 20:40 |
| dobey | hmm | 20:42 |
| nessita | briancurtin, alecu: thanks for your time regarding this | 20:42 |
| nessita | alecu: the diff you requested: https://pastebin.canonical.com/58813/ | 20:44 |
| nessita | briancurtin, alecu: thanks for your time... I will think how to fix the tests given this scenario | 20:45 |
| alecu | nessita, great, thank you | 20:45 |
| dobey | libindicate-ERROR **: Unable to get session bus: Operation was cancelled | 20:46 |
| dobey | ugh. | 20:46 |
| briancurtin | nessita: you should be able to call getProcessOutputAndValue("", "notepad.exe",...) -- the command param must be a full path, but passing a non-full path to the args param will work (which is how subprocess.Popen(["notepad"]) works) | 20:46 |
| nessita | briancurtin: ugly! :-) but makes my life easier | 20:47 |
| briancurtin | yeah it's not the best looking code, but it'll work | 20:47 |
| alecu | nessita, how so? don't we have full paths to the .exes in the registry? | 20:47 |
| nessita | alecu: we won't be using twisted spawnner, but qt on windows, and qt or glib in linux | 20:48 |
| alecu | nessita, I'm not sure about that. | 20:49 |
| nessita | alecu: why? | 20:49 |
| alecu | nessita, syncdaemon will use the sso module to get the proxy credentials, and that will try to open the process for the ui, right? | 20:50 |
| nessita | alecu: syncdaemon will call a dbus method | 20:50 |
| nessita | no? | 20:50 |
| alecu | nessita, that seems better. | 20:51 |
| nessita | otherwise we'll get a not nice mix of things, no? | 20:51 |
| alecu | nessita, if the only problem is getting the full paths, then it's not so ugly of a mix :-) | 20:51 |
| nessita | alecu: I meant mix of reactors and mainloops | 20:52 |
| alecu | nessita, if SD executed a binary for the UI, it would use the twisted starter. | 20:52 |
| alecu | nessita, but anyway, I'm getting ahead of myself, because the SD proxy will run in a different process. | 20:53 |
| nessita | alecu: which, if I recall correctly, will use the plain qt mainloop, right? | 20:53 |
| alecu | nessita, right | 20:53 |
| alecu | nessita, so we won't use the twisted spawner. | 20:54 |
| alecu | nessita, btw: I'm taking a look at your libsoup sample, and I think it's fine, but it may explode | 20:55 |
| nessita | alecu: in which case? | 20:55 |
| alecu | nessita, since get_chunk may return None when there's more bytes coming, but they still have not arrived. | 20:55 |
| alecu | nessita, slow network for instance | 20:55 |
| nessita | ah | 20:56 |
| nessita | did not read that | 20:56 |
| alecu | nessita, it looks like we should be listening for a signal named "complete" to know when to fire the deferred. | 20:56 |
| nessita | hum, instead of reading from chunks? | 20:56 |
| alecu | nessita, I think we should be reading the chunks into a StringIO or something like that. | 20:57 |
| alecu | nessita, anyway, this is very useful stuff, and we will need to fix this before we re-enable the libsoup backend. | 20:57 |
| alecu | nessita, thanks for finding it! | 20:57 |
| nessita | alecu: anytime. Will open a bug for you, so you can tackle that after the current branch? | 20:58 |
| gatox | briancurtin, ping | 20:58 |
| alecu | nessita, great, thanks. | 20:58 |
| briancurtin | gatox: pong | 20:58 |
| gatox | briancurtin, hi.... do you have time for a small review? | 20:58 |
| briancurtin | gatox: sure | 20:58 |
| gatox | briancurtin, thanks: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/udf-issue/+merge/90208 | 20:58 |
| alecu | gatox, didn't you EOD an hour ago? :-) | 20:59 |
| gatox | alecu, jejeje yes.... but i wanted to end this :P.... now eod for real :P | 20:59 |
| gatox | alecu, i went to pay some things and now i came back | 20:59 |
| alecu | :-) | 21:00 |
| nessita | alecu: https://bugs.launchpad.net/ubuntu-sso-client/+bug/921822 | 21:01 |
| ubot4` | Launchpad bug 921822 in ubuntu-sso-client "webclient with libsoup backend is not reading the whole body response (affects: 1) (heat: 6)" [High,Triaged] | 21:01 |
| nessita | gatox: a tiny note on that branch: you're doing automatic unicode promotion here: home = os.path.join(self.home_dir, u'雄鳥お人好し ñandú') | 21:02 |
| nessita | gatox: since self.home_dir is bytes (and has to be bytes) | 21:02 |
| gatox | nessita, ah.. ok.... i'll fix that | 21:03 |
| nessita | I don't like automatic unicode promotion in Python, it makes the code works when it shouldn't :-) | 21:03 |
| gatox | nessita, i understand | 21:04 |
| nessita | I think Python 3 fixes that... | 21:04 |
| nessita | not sure though | 21:04 |
| gatox | nessita, done | 21:06 |
| nessita | briancurtin: so, if I understand correctly, you mentioned that d = utils.getProcessOutputAndValue('', 'notepad.exe', env=environ) should work, no? | 21:12 |
| nessita | briancurtin: is not working for me, but perhaps I missed something? | 21:12 |
| briancurtin | nessita: let me try again, i might have had some other debugging code in there | 21:12 |
| nessita | briancurtin: thanks | 21:12 |
| nessita | briancurtin: I think it should be ('notepad.exe',) as second param, but again that does not work for me | 21:13 |
| nessita | win32process.CreateProcess('', 'notepad.exe', None, None, 1, 0, os.environ, '.', win32process.STARTUPINFO()) does not work either | 21:18 |
| dobey | ugh | 21:19 |
| dobey | either this zg test is just really slow, or it's hanging :( | 21:19 |
| nessita | dobey: may be patching something nastly, so likely to be hanging | 21:21 |
| briancurtin | nessita: argh, sorry, i had something leftover in the twisted code to make it work. with None as the first arg, not "", it will work...but twisted won't let you pass None through | 21:23 |
| dobey | nessita: the odd thing is that it only started doing it just now | 21:23 |
| dobey | it was fine earlier | 21:23 |
| nessita | briancurtin: patching twisted code and testing | 21:24 |
| dobey | it's weird | 21:24 |
| dobey | also, i have no idea how this test actually works | 21:24 |
| dobey | it is doing some insane stuff | 21:24 |
| briancurtin | wtf now it's saying access denied | 21:25 |
| nessita | briancurtin: ok, is time for dropping this, I will re think the test and drop the twisted spawnner, since we won't be using it IRL (it was coded to run the suite) | 21:26 |
| nessita | briancurtin: thanks a lot for the help | 21:26 |
| dobey | and now it works | 21:26 |
| briancurtin | nessita: np | 21:26 |
| === gatox is now known as gatox_away | ||
| dobey | hrmm, and this one test fails with unicode under gi, but is ok without gi | 21:29 |
| dobey | weird | 21:29 |
| nessita | ok, I'm eoding now | 21:31 |
| nessita | need some fresh air | 21:31 |
| briancurtin | enjoy | 21:31 |
| dobey | .decode('utf-8') was at least a simple fix | 21:31 |
| nessita | alecu: I'm changing this branch https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-stuff-from-mainloop/+merge/89956 to WIP | 21:32 |
| alecu | nessita, ack | 21:32 |
| nessita | alecu: since I need to improve the tests so they pass on windows | 21:32 |
| nessita | ok, bye all! | 21:35 |
| dobey | yay, i think i got the tests all fixed now | 21:37 |
| === m_conley_away is now known as m_conley | ||
| dobey | yay. a few lint errors away | 22:43 |
| dobey | will fix them a bit later | 22:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!