[09:04] morning all! === mpt_ is now known as mpt [11:18] good morning! [11:35] gatox, buenas! [11:35] mandel, how are you? [11:35] gatox, let me reboot due to updates :) [11:35] mandel, ok [11:38] gatox, here everything ok, but I have a pep8 issue I dont understand [11:38] mandel, weird..... pep8 shouldn't fail.... pylint i can understand :P [11:39] gatox, can you branch lp:~mandel/ubuntuone-control-panel/auto-update-looping-call [11:39] mandel, yes! i'll check [11:39] gatox, I don't get what is going on [11:47] @ping [11:47] pong [11:52] * mandel back in a sec [11:54] mandel, ping [11:54] gatox, I'm back [11:54] mandel, i get this: ./ubuntuone/controlpanel/gui/qt/main/tests/test_windows.py:1:4: E261 at least two spaces before inline comment [11:55] pep8 --repeat . [11:55] gatox, do pep8 ./ubuntuone/controlpanel/gui/qt/main/tests/test_windows.py --show-source [11:56] gatox, and tell me what is wrong in that line if you can [11:56] 'cause I see nothing wrong [11:57] ok [12:00] gatox, ny idea? [12:00] mandel, i think that you are saving the file with some end of line issue or something like that..... i see the pep8 issue (with no sense) you mention...... but i open that file with ninja..... save it without modifying anytihng [12:01] and now it doesn't show the issue [12:03] gatox, can you push that to a branch and I'll pull from it [12:03] gatox, wtf pep8! :P [12:04] mandel, ok..... but you should use ninja jejeje [12:05] gatox, vim vim vim [12:05] gatox, the thing is, I want to see the bloody diff :) [12:05] ahhhh [12:06] hello everyone! [12:07] nessita, hi [12:08] nessita, morning! [12:08] nessita, question from design, the error dialog with the expandable error detail has already landed, right? [12:08] mandel, https://code.launchpad.net/~diegosarmentero/+junk/u1-cp-pep8-issues [12:09] hola mandel, gatox [12:09] mandel: in control panel, yes [12:09] mandel: we released that along with the second release, iirc [12:10] nessita, ok, superb! I told them so but I was not 100% sure [12:10] mandel: why? [12:10] ah [12:10] gatox: will start reviews now. Is the fix-user-home and which one else? [12:11] * gatox checking.... [12:12] nessita, this one has already one approve: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/fix-user-home-tests/+merge/88919 and i have 2 more that i consider they are ready..... but noone review them again..... i was hoping alecu could review them [12:13] gatox: which one are those? lp:~diegosarmentero/ubuntuone-windows-installer/network-detect and lp:~diegosarmentero/ubuntu-sso-client/remove-disconnect-signal ? [12:13] nessita, that 2 [12:13] good morning! [12:14] ralsina, hi [12:14] ralsina, morning! [12:16] nessita, ahhhh about the network-detect branch.... i just realize there is no test to check if the button has the proper style..... we are not doing that everywhere.... but i should add that check, shouldn't i? [12:16] nessita, can I haz a review for https://code.launchpad.net/~mandel/ubuntuone-client/add-virtual-watches/+merge/88726 [12:16] ? [12:17] nessita, I need one more and nor brian nor alecu wrote theirs as reviews but as comments... [12:17] gatox: the try again default style? [12:17] nessita, yes [12:17] mandel: you mentioned you were gonna ask facundo as well, perhaps? I was waiting on that review (besides alecu's) [12:18] nessita, I did ask him, but he told be he was too busy at that time [12:18] facundobatista, too busy for https://code.launchpad.net/~mandel/ubuntuone-client/add-virtual-watches/+merge/88726 ? [12:19] mandel, I'll check it [12:20] facundobatista, thx! [12:37] nessita, i've added the test for the try again button properties [12:41] ack! [12:43] nessita, whenever you have time can you take a look at https://code.launchpad.net/~mandel/ubuntuone-control-panel/auto-update-looping-call/+merge/81015 [12:45] mandel, did you see the diff? [12:45] gatox, empty.. no idea what was going on :( [12:45] weird...... how you fix it? [12:48] gatox, merged with yours :P [12:48] :P [12:48] gatox, funny thing is, I used vim to remove a line, and it was working.. [12:49] mandel, welcome to the world of non deterministic bugs :P jeje [13:00] hello all! [13:00] alecu, morning [13:00] * mandel small problem with the beast, will be back in 10 min [13:05] alecu, hi [13:05] hola alecu [13:12] * mandel back [13:12] I have to buy a new tv remote.. the dog eat it :( [13:12] alecu, can you re-review https://code.launchpad.net/~mandel/ubuntuone-client/add-virtual-watches/+merge/88726 [13:13] gatox: are client test passing for you, in linux? [13:14] nessita, for the u1-sso-client branch? [13:14] gatox: no, for the u1client branch [13:14] gatox: I'm having stuff like this: http://pastebin.ubuntu.com/816404/ [13:15] gatox: I'm running trunk now, to see how the suite behve there [13:15] nessita, checking..... but that wasn't happening here [13:22] nessita, mmmm everything is ok here..... [13:22] PASSED (skips=12, successes=2504) [13:22] gatox: trunk or your branch? [13:22] nessita, my branch [13:22] u1-user-home [13:22] gatox: trunk is working fine for me... I will re run the suite in your branch [13:22] ah no! [13:22] :O [13:22] gatox: it just failed the same in trunk [13:22] what happend? [13:22] fiuuuuuuu [13:23] * gatox thought nessita was going to hit him [13:23] no no [13:23] alecu: ping [13:24] nessita, pong [13:24] alecu: does this ring any bell to you? http://pastebin.ubuntu.com/816413/ [13:24] checking [13:24] alecu, in the webclient tests, do both implementations run when I do ./run-tests ? [13:25] mandel, no: you need to do ./run-tests and ./run-tests -qt [13:25] alecu, ack [13:25] nessita, how did those errors happen? [13:25] alecu: running make check in u1client trunk [13:26] nessita, on P? [13:26] alecu: yes sir [13:29] nessita, I think I found it :-) [13:29] nessita, how is the branch you where working on regarding the execution of a child process form sso? [13:30] mandel: is going better than yesterday, where I was completely blocked. You already blocked by this? [13:30] nessita, it seems that the tests are "mocking" the pynotify module. But if the pynotify module is not installed the platform dependent code just does not install a notifier. [13:31] nessita, no necessary, I can work around it or so I believe :) [13:31] nessita, and it also happens that the pynotify module is not installed either if the notify GI is available. [13:31] alecu: oh... hum.., [13:31] nessita, so: either there's a GI for pynotify now, or the pynotify module is not installed. [13:32] alecu: how did you reach that conclusion? [13:32] nessita, in any case we should make the notify tests be a bit more smarter, and find out what the real notification module is. [13:32] nessita@dali:~$ sudo apt-cache policy python-notify [13:32] python-notify: [13:32] Installed: 0.1.1-3 [13:33] alecu: I have pynotify installed [13:33] nessita, what does " from gi.repository import Notify" do? [13:33] alecu: brings in the GI notify [13:34] nessita, right. And that means that the pynotify module is not installed [13:34] nessita, (I mean, by our code) [13:34] *imported (not installed) [13:34] ah!!!! [13:34] alecu: not sure if this is your area [13:35] alecu: oops wrong person [13:35] ralsina: if u1sdtool --waiting lists the same GetDelta 100s of times, is that you? [13:35] webm0nk3y, I've got no area... I'm a full field player! [13:35] nessita, alecu when we get the credentials from the user in the proxy dialog, those should be stored in the keyring, is that correct? [13:35] ralsina: or a verterok question [13:36] mandel: yes, keyring [13:36] mandel, we should find where they are usually stored by the rest of the apps, and try to get/set them in that same place. [13:36] webm0nk3y: it's desktop but it's transitioning, so we will ask verterok later ;-) [13:36] mandel, for instance, on windows it's stored in the cred manager, so we could use that same location [13:37] webm0nk3y: is it connected? [13:37] alecu, so, on windows we can use the keyring class, on linux.. I think each app does what it feels [13:37] verterok: yes [13:37] webm0nk3y: hmm, I think it should kill all the other GetDeltas as soon the first one is started [13:38] facundobatista: ^ do you remember what we talked about filtering GetDelta's? [13:38] mandel, I saw IE storing the creds in that app. If firefox uses those creds, then we should use them too. [13:38] mandel, what I'm saying is that we should do a bit of IRL of those other apps and try to have the same behaviour. [13:38] verterok, #883252 [13:38] alecu, ok, I'll do that after lunch, lets see what I get [13:38] mandel, and by "that app" I mean... let me find the exact name... [13:39] facundobatista: thanks [13:39] facundobatista: thanks [13:39] webm0nk3y: bug #883252 [13:39] Launchpad bug 883252 in ubuntuone-client "Syncdaemon executes multiple GetDelta commands in parallel on the same volume (affects: 2) (heat: 9)" [High,Confirmed] https://launchpad.net/bugs/883252 [13:39] alecu, I might propose a couple of small mp which add in increments the code for this thing, I tried to do a proper pipeline :) [13:39] webm0nk3y: so, isn't fixed yet :/ [13:39] mandel, "Credential Manager" inside the windows control panel. [13:39] mandel, cool! [13:40] alecu, we use the Credential Manager in the keyring module, so that we have sorted :) [13:40] great [13:41] alecu, my worry is ubuntu, since for example, FF, Chrome store them in diff places [13:41] alecu, I'm off to lunch and I'll bother you a little more with this :) [13:41] mandel, afaict chrome (or chromium) uses the keyring [13:42] mandel, we should ask the platform team in any case. [13:42] alecu, I will, I've checked and empathy uses the keyring too [13:42] ok, lunch and we continue [13:44] alecu: sobre lo de notifications, abro bug y los skipeo? [13:44] nessita, plus one [13:45] gatox: confirmed the test failures are the same in your branch and trunk, so that counts as "passing" for your branch [13:45] alecu: thanks for the quick debugging [13:46] nessita, good [13:46] (for my branch :P) [13:46] nessita, thank you for finding this. [13:46] nessita, you can assign that bug to me [13:46] alecu: ack [13:47] alecu: may I ask that you dedicate some time this morning to catch up with reviews? I know mandel and gatox are waiting on a review from you (mine can wait till the afternoon or tomorrow) [13:47] alecu, pretty please :P [13:47] nessita, I was planning on catching up with reviews today after lunch. Sorry guys! [13:48] alecu: as it fits best in your schedule, but perhaps mandel's review will flow faster having him around? [14:11] nessita: hey. why did you put ubuntuone-windows-installer in your ppu application? :) [14:12] dobey: because I made a mistake :-) [14:12] dobey: edited [14:12] thanks. :) [14:31] nessita: 1-1? [14:31] yes! [14:40] nessita: the notification errors were from running tests with the gireactor? [14:41] dobey: well, it was run using the same make check as usual, but yes, I have the tweaked twisted installed, and the new devtools [14:42] nessita: right, but were you modifying the Makefile to run with -r gi, or not? [14:42] dobey: nopes [14:43] nessita: so you just intentionally removed python-notify? [14:43] dobey: not at all [14:43] dobey: I have it installed [14:44] nessita: that is very odd then :) [14:44] dobey: odd that the Notify module was loaded instead of notify? [14:45] nessita: yes. [14:45] nessita: especially since it can't load if running with the static bindings already loaded [14:46] dobey: give me one sec, I'm in mumble, will pay full attention in some minutes [14:46] ok === yofel_ is now known as yofel [14:49] dobey: CONGRATS http://twistedmatrix.com/trac/ticket/4558 [14:49] :) [14:50] :-) [14:50] more work though. i need to update some other related docs in another branch [14:50] but the code is there at least, yeah [14:52] dobey: awesome [14:55] * mandel back [14:55] alecu, if you do the review after lunch I can pay attention as long as I'm not walking the dog :) [14:56] alecu, nessita, dobey, briancurtin, gatox: Did I miss anyone's review requests? Remind me now, or forever hold your peace! [14:57] * gatox checking.... [14:57] ralsina, no..... i'm still working on a branch that will need your review [14:58] ralsina, maybe if you have time, you could review this one: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/remove-disconnect-signal/+merge/89761 [14:58] it's small [14:58] ralsina: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-stuff-from-mainloop/+merge/89956 [14:59] alecu: FYI bug #921574 [14:59] Launchpad bug 921574 in ubuntuone-client "NotificationTestCase failures (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/921574 [14:59] dobey: I'm back [14:59] gatox, nessita: thanks, I will do them ASAP [14:59] dobey: so, I see from ubuntuone/platform/linux/notification.py that the gi module is being loaded if 'gi' in sys.modules [15:00] nessita: right [15:00] so seems like that's True when I run it? want me to print sys.modules? [15:00] nessita, ping [15:00] gatox: pong [15:00] nessita, thanks [15:01] me [15:01] nessita, first standup..... then i'll tell you [15:01] me [15:01] nessita: well, i'm not sure how that could be true if you haven't changed anything [15:01] me [15:01] me [15:01] me [15:01] wait for me! [15:01] ralsina, ? [15:02] me [15:02] shall I then? [15:02] mainerror, go [15:02] si [15:02] DONE: Long conversation with design regarding the proxy UI, user flow and cases when errors might occur. We should get new bugs filled by them reagrding the UI items. Updated lp:~mandel/ubuntuone-control-panel/auto-update-looping-calls, reviews are welcome. Worked on the auth-dialog for proxy, divided the work in small chucks using pipeline. Noticed that the jenkins instance was remove in canonical stack, sidnei was kind enough to fix it. [15:02] TODO: more proxy. Talk with the desktop team, where should we store the creds, keyring? [15:02] BLOCKED: no [15:02] gatox, please! [15:02] DONE: [15:02] Fixed some branches. Adding tests. [15:02] TODO: [15:02] Finish with my remaining branches. Propose fix for the installer script. [15:02] BLOCKED: [15:02] No [15:02] nessita, go [15:02] gatox, mainerrr your mum! :P [15:03] jeje [15:03] DONE: proposed branch for bug #919294, had tweaked twisted uploaded to our PPA, reviews, sync with alecu re SSO, restarted work on gtk-gi [15:03] TODO: finish and propose gtk-gi branch, restart work on executing an SSO UI from the SSO main loop, 1-1 with ralsina [15:03] BLOCKED: nopes [15:03] NEXT: briancurtin [15:03] Launchpad bug 919294 in ubuntu-sso-client "Be able to spwan a process from the mainloop and grab its exit code (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/919294 [15:03] DONE: cleaned up a few run-tests.bat scripts to exit more cleanly, cleaned up registry checks (might need to change for jenkins). installed jenkins locally and started reading up on it [15:03] TOOD: get a windows installer built so i can see how it's done in order to automate it, read/play more with jenkins [15:03] BLOCKED: none [15:03] NEXT: dobey [15:03] λ DONE: gireactor patch for 11.1, packageset proposal, gwibber keyring usage [15:03] λ TODO: gwibber tweaks, music store [15:03] λ BLCK: None. [15:03] alecu [15:03] DONE: finished use-restful branch [15:03] TODO: catch up with reviews; cleanup branch for unneeded stuff [15:03] BLOCKED: no [15:04] NEXT: ralsina? [15:04] DONE: mgmt call, nessita 1-1, chipaca 1-1, video lens call, started bureaucracy to hire davidcalle to work on it, defined video lens deliverables, reviews, canonicaladmin, interviewed mac candidate, etc, etc. TODO: gatox 1-1, more CV screening for mac, other stuff, BLOCKED: no [15:05] also in my TODO is a makeup 1-1 with ralsina [15:05] briancurtin: yes [15:05] any comments anyone? [15:05] eom? [15:05] nop [15:05] eom! [15:05] no [15:05] gatox: shoot [15:05] Comment: if ears could cramp, mine would hurt [15:05] I have been doing waaaaaaaay too many calls [15:05] nessita, now...... about this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/folder-show-garbage/+merge/89094 [15:06] dobey: http://pastebin.ubuntu.com/816516/ [15:06] gatox: yes [15:06] * mandel back to code! [15:06] nessita, i'm running into some ipc problems trying to create an udf..... but is not related to this branch..... i think it would be better to create another bug for the udf issues..... because the bug associated to this branch was about ui [15:07] gatox: what IPC issues? [15:07] nessita, i can create the other bug and take it if you want.... is unicode related [15:07] gatox: is the error the one I reported in the MP? [15:07] nessita: how? === mpt_ is now known as mpt [15:08] dobey: go to trunk, run: u1trial tests/platform/linux/test_notification.py [15:08] dobey: having nightlies installed and updated [15:08] nessita, it doesn't seem to be that one..... because this issue is from u1-cp side..... never reach syncdaemon (in the user with weird username.... it works fine in the other one) [15:08] gatox: I tested with a user with a weird username [15:09] gatox: have a trace of your error? [15:09] * gatox checking.... [15:09] gatox: this is the home of the user I used: C:\\Users\\\xe5\x8d\x97\xe6\xb8\xa1\xe6\xb1\x9f \xd7\xa0\xd7\x95\xd7\xa0\xd7\x95 [15:09] jjjee nice username [15:10] which is: C:\Users\南渡江 נונו [15:10] gatox: is my default user now, is the onle one I use in windows [15:10] nessita, i'm using both yet [15:11] nessita, this is the log i have: http://paste.ubuntu.com/816519/ [15:12] nessita: ok, upgrading now [15:12] nessita, ahhhhhh it reach syncdaemon [15:12] i just saw it [15:13] nessita, and yes..... it's the same bug [15:13] nessita, so the ipc issue..... maybe is related to syncdaemon answer [15:13] gatox: what do you mean by syncdaemon answer? [15:13] or the lack of answer [15:14] gatox: nopes, look the log in syncdaemon [15:14] 2012-01-19 11:00:45,207 - ubuntuone.SyncDaemon.InteractionInterfaces - DEBUG - handle_VM_UDF_CREATE_ERROR: args (,), kwargs {'path': 'C:\\Users\\\xe5\x8d\x97\xe6\xb8\xa1\xe6\xb1\x9f \xd7\xa0\xd7\x95\xd7\xa0\xd7\x95\\Links', 'error ': "INVALID_PATH: 'ascii' codec can't decode byte 0xe5 in position 0: ordinal not in range(128)"}.\ [15:14] gatox: is in the merge proposal, I pasted that on 2012-01-19 [15:14] gatox: do you also have that error? [15:14] nessita, yes..... i'm looking at the trace in my machine too [15:14] nessita, yes [15:15] gatox: so, I put in the comment: "Would you please confirm if the problem is in syncdaemon's end or controlpanel's end?" [15:15] gatox: do you know if the controlpanel is sending the wrong path, or syncdaemon is not processing it properly? [15:15] nessita, yes, i saw it and in my opinion the problem is in syncdaemon [15:16] gatox: did you confirm if controlpanel is sending unicode thru IPC? [15:16] nessita, i'll check now...... but i think the problem is that the data is not being encoded/decoded from syncdaemoon side [15:17] gatox: be careful, because a single layer has to do encode/decode, and that layer is interaction_interfaces. No other layer should do that (and perhaps os_helper on windows, but that's for transforming into unicode) [15:18] gatox: we need to ensure some invariants regarding IPC. One invariant is: every call receives unicode, and every call return unicode [15:18] nessita, ok..... i'll confirm that control panel is sending the right stuff [15:18] gatox: if we're making a IPC call without sending unicode, the problem (at least one of the problems) is the caller [15:19] dobey: were you able to reproduce? [15:19] nessita, ok....... i'll let you know as soon as i have something.... [15:19] * gatox lunch now [15:19] brb [15:20] still upgrading === gatox is now known as gatox_lunch [15:34] nessita: hrmm, it does fail for me with that. weird [15:36] well, using laptop for mumble is sort of ok [15:37] really need working synergy though [15:39] ha, I'm back! [15:40] damn [15:41] grr, netsplit [15:51] LUNCH! [15:53] alecu, so, lets say we use that ugly idea of username: password we should not promp for the creds, right? [15:55] mandel, what if the creds expire? [15:55] get a bucket and fill it with tears? [15:56] dobey, that sounds about right... [15:56] hehe === bdmurray_ is now known as bdmurray [16:01] alecu, so, we either tell the current way to work, frack off we know better and have a dialog and store that in the keyring or we work like the rest of the apps (aka do it wrong), or fix gnome 3 [16:01] dobey, sounds about right? ^ [16:02] mandel, have you tried it IRL? [16:02] alecu, what, using the default settings and then changing the creds? [16:03] I can easily do it :) [16:03] mandel: i think it's safe to assume we'll have to do it ourselves or fix gnome3. [16:04] mandel, yes: I mean with a few apps... firefox, chromium, empathy [16:04] alecu, changing my settings right now :) === jackyalcine is now known as Guest1073 === gatox_lunch is now known as gatox [16:09] @ping [16:09] pong [16:11] alecu, dobey so, xchat, firefox, are smart and know how to do it while chrome asks for the creds [16:11] mandel, so they all know how to parse when you enter "user:pass@host" in the gnome dialog? [16:12] mandel: i found this blog post earlier: http://www.gnomeshell.com/2011/04/30/gsettings-api-how-to/ [16:12] alecu, not all of them, chrome did know how to use the url, yet I had to provide my username and password again [16:12] mandel: the last + line in the patch linked is a comment that says "no authentification support in gnome3" :( [16:13] Mandel would you have a second to look at an rt ticket for me? [16:13] mandel: what about epiphany? (apt-get install epiphany-browser) [16:14] duanedesign, shoot! [16:14] dobey, installing [16:14] mandel, also: if you leave the user:pass out, do they ask you for credentials (xchat, firefox)? where do they store them? [16:14] * mandel feels like a webdeveloper with several browsers... lame [16:15] mandel, also: where did chrome store the credentials? [16:15] alecu, let me look at epiphany and will do that [16:15] likely the keyring [16:15] sure [16:15] mandel: do you have glib-networking installed? [16:15] alecu: ^^ [16:15] they don't use the keyring [16:16] http://git.gnome.org/browse/glib-networking/tree/proxy/gnome/gproxyresolvergnome.c [16:16] yey! /me is back [16:16] mandel: http://ubuntuone.com/1DSHjFhtlKzpfYdDjGh7YB [16:16] mandel: if you can view the RT system https://support.one.ubuntu.com/Ticket/Display.html?id=10146 [16:17] mandel: is it a matter of removing that tritcask file? [16:17] duanedesign, looking [16:18] duanedesign, I'm getting an error when trying to get in the rt system using sso :( [16:18] alecu, mandel: it appears gsettings keys are used, but i don't know what sets the keys exactly. [16:19] dobey, epiphany-browser works correctly [16:20] mandel: what happens if you set it to an authenticated host, but don't have the user:pass in the url? [16:22] @ping [16:22] pong [16:22] so I'm still here [16:22] duanedesign, what is the exact problem, can you describe it for me [16:22] dobey, alecu if I use the domain and do no use the pattern username:password@domain [16:23] mandel, yes, what happens? [16:23] I get a dialog asking for the creds ( epiphany-browser) which are later stored in the keyring [16:23] alecu, dobey ^ [16:23] gatox: ping [16:23] mandel, nice. what about firefox, empathy? do they use the same keyring place? [16:23] * mandel looks [16:25] mandel: file was not uploading, I renamed the file, and it said syncing for a while in the app, but the [16:25] file still failed to appear online. [16:26] duanedesign, may I see logs? sorry I have some problems with the rt system :( [16:27] alecu, chrome does not use the same key, looking at ff [16:27] nessita, pong [16:27] mandel: i PM'd the logs [16:28] gatox: in your network-detect branch, in windows-installer [16:28] aja? [16:28] mandel, can you send a small mail with these results? the name of each keyring key is interesting in each case. [16:28] gatox: if I see the diff correctly, you added some methods to SuccesPageTestCase [16:28] mandel, so we can later choose where should we store the settings. [16:28] gatox: get_pixmap_data and assertEqualPixmaps. Why did you add those there? [16:29] (my opinion is: wherever firefox stores them) [16:29] nessita, let me check [16:29] alecu, if it does store them.. which I don't know yet [16:30] mandel, gatox, nessita: I need to go for some errands and lunch: after that it's review evening for me. [16:30] nessita, yes..... i added those methods because i needed to check that the image was the proper one.... also, after talking with alecu i created a bug to move those methods to a common place, probably in sso, because we are using that in cp too in different places [16:30] alecu: ack [16:30] alecu, ack [16:31] alecu, ok [16:31] gatox: but you added the method in SuccesPageTestCase... and unless I missing something, I don't see that test case using that [16:32] nessita, ohhhhh..... probably was removed in some merge..... :S crap [16:32] gatox: let me know when is cleared what happened [16:32] nessita, sorry about that.... i'll add it again [16:32] no problem === alecu is now known as alecu_away [16:35] nessita, that weird..... i have the changes here..... but i can't push because it says is up to date [16:35] gatox: did you commit the changes? [16:35]