mhall119 | aquarius: was out to dinner with the family | 01:47 |
---|---|---|
aquarius | mhall119, no problem at all. There's no rush :) | 01:47 |
mhall119 | aquarius: I don't see a difference | 01:58 |
mhall119 | it looks to be zoomed in, that's it | 01:58 |
aquarius | hrm. which phone are you using? | 01:59 |
aquarius | this is why I wanted other people to test it ;) | 01:59 |
aquarius | my Nexus S has Android 4.0 ICS on it... | 01:59 |
mhall119 | droidx | 01:59 |
mhall119 | 854×480 according to wikipedia | 02:00 |
aquarius | which version of android? | 02:00 |
mhall119 | is "old" a version? | 02:00 |
mhall119 | 2.3.3 | 02:01 |
aquarius | gingerbread? that's not old. | 02:01 |
aquarius | indulge me: does http://teamtreehouse.com/ show the icons one above the other on your phone (while showing them in a horizontal line in your desktop browser?) | 02:02 |
mhall119 | yup | 02:03 |
aquarius | but summit is still showing the page header and stuff on your phone? | 02:04 |
mhall119 | yes | 02:04 |
mhall119 | I'd take a screenshot from my phone if I knew how | 02:04 |
mhall119 | there's a gap between meeting name cell and the room name cell | 02:05 |
aquarius | no screenshots for you. you need ics for that. | 02:05 |
aquarius | dammit. | 02:05 |
mhall119 | but only in portrait | 02:05 |
aquarius | ah, I haven't even thought about landscape yet. Look at it in portrait ;-) | 02:05 |
mhall119 | I get the "view details of this session" link in the popup | 02:05 |
aquarius | er! oops. | 02:06 |
aquarius | I forgot to put "only override this stuff in mobile mode" around that bit of js ;) | 02:06 |
aquarius | the bigger question is: why are my styles not working? | 02:07 |
mhall119 | aquarius: http://91.189.93.80:8000/uds-p/ has your branch merged | 02:08 |
aquarius | goldarnit, works fine on my phone | 02:09 |
aquarius | and we know your phone responds to media queries or teamtreehouse wouldn't have done the magic. | 02:09 |
* aquarius researches | 02:11 | |
aquarius | indulge me. Can you edit the daily.html and on line 75 change max-device-width: 480px to max-width: 481px | 02:13 |
aquarius | and then see if that makes a difference? | 02:13 |
mhall119 | ah ha, that looks different | 02:18 |
aquarius | ha haaa. | 02:18 |
aquarius | so you should now have the schedule fill the whole screen, no page header or footer | 02:18 |
mhall119 | the track titles are hard to read though | 02:18 |
mhall119 | yup, it looks very mobile now | 02:18 |
aquarius | hard to read in the sense of "black text on a coloured background"? | 02:19 |
aquarius | (those are "session titles", aren't they? I can't see a track title at all) | 02:19 |
mhall119 | in the details popup I mean | 02:19 |
mhall119 | it uses the track color for the text color | 02:19 |
aquarius | oh, right, yeah | 02:19 |
mhall119 | which is white or a light color | 02:20 |
aquarius | that will need fixing. I haven't fiddled with any colouration at all ;) | 02:20 |
aquarius | next trick, then: max-device-width: 481px if you would | 02:20 |
mhall119 | this is great though | 02:20 |
mhall119 | it's already @media screen and (max-device-width: 481px) | 02:20 |
aquarius | ah! | 02:20 |
aquarius | so you do support max-device-width | 02:21 |
aquarius | it's just that when it says max-device-width:480px it actually means "*less* than 480px". hmph. | 02:21 |
aquarius | if you change it to max-width, does it still work? | 02:21 |
mhall119 | either that or my phone is slightly more than wikipedia says | 02:21 |
aquarius | max-width is better becauase then we can test the "mobile layout"by just making your desktop firefox window smaller ;) | 02:22 |
aquarius | changes pushed | 02:28 |
aquarius | (black background on the track titles in the details div, too) | 02:28 |
mhall119 | updated | 02:31 |
mhall119 | instead of black, how about the same gray used in the popup on the desktop? | 02:31 |
mhall119 | #101010 | 02:31 |
aquarius | pushed | 02:36 |
aquarius | question: do you want a brief tour of what I did, or does it make sense to you already? | 02:36 |
mhall119 | makes sense enough, and I like the results | 02:36 |
mhall119 | did you write the javascript, or is that copied from something? | 02:37 |
aquarius | I wrote it | 02:37 |
aquarius | it makes shameless use of modern browser stuff without checking. ;) | 02:38 |
mhall119 | fast and loose, I like it | 02:38 |
mhall119 | that's how we roll with summit | 02:38 |
aquarius | I could have patched out your show_agenda_details in the code and Done It Differently, but I just monkeypatch it at the end instead because then I'm not sodding about with your code | 02:39 |
aquarius | and it makes the diff simpler :P | 02:39 |
nigelb | lol | 02:40 |
mhall119 | it's all going to be nigelb's fault in the end anyway, so I'm okay with that | 02:40 |
nigelb | We should, at some point rewrite the CSS with something like foundation. | 02:41 |
nigelb | It does mobile layouts beautifully. | 02:41 |
mhall119 | nigelb: good idea, when will it be done? | 02:42 |
nigelb | mhall119: check nigelb.me on your phone. | 02:42 |
nigelb | I'm not klutzing around with css. | 02:42 |
mhall119 | nigelb: works nice on my phone | 02:43 |
aquarius | oh, certainly restructuring the whole thing from the ground up is a good idea; doing mobile-first design is also a good idea. I have assumed that the time to do it properly is not available, otherwise you guys would have done it already. This is a relatively quick patch which, I think, punches above its weight in lines-of-code in terms of how much nicer it makes the experience for mobile users, and it only too | 02:43 |
aquarius | k an hour :0 | 02:43 |
mhall119 | you should totally re-write summit | 02:43 |
nigelb | was that to sil or me? :P | 02:44 |
mhall119 | you | 02:44 |
mhall119 | I'm afraid aquarius might actually do it ;) | 02:44 |
nigelb | lol | 02:44 |
aquarius | I am not doing it. I'm afraid of doing too much to summit in case I end up owning it. I'd be a really bad primary maintainer. :) | 02:45 |
mhall119 | aquarius: if you're happy with you branch, I'd like to approve it so it can land | 02:45 |
aquarius | I'm happy with that branch as it stands, sure | 02:45 |
nigelb | aquarius: With mhall119's new position, he owns summit forever. | 02:45 |
mhall119 | aquarius: it is kind of a curse, you touch it and you own it | 02:45 |
mhall119 | nigelb: nope | 02:45 |
nigelb | Yeah, I owned it for a while. I'm glad cjohnston's owning it now. | 02:45 |
aquarius | mhall119, I know, which is why I won't hack on it too much ;) | 02:45 |
mhall119 | nigelb: punch tarmac for me | 02:46 |
nigelb | punched | 02:46 |
aquarius | next branch will be: fix the preceding two pages (front page with list of conferences and next page with list of tracks/rooms/days) so that they're a bit more mobile friendly | 02:46 |
mhall119 | that'd be nice | 02:46 |
aquarius | then the branch after that is "summit now works offline if you bookmark it" | 02:46 |
mhall119 | SSO has *some* mobile UI work, but it's evidently pretty bad according to the people who did it | 02:46 |
aquarius | and then I'm done, I think, on the "scratch an itch" principle ;) | 02:47 |
aquarius | my particular itch being "make summit work well on my phone at UDS" :P | 02:47 |
nigelb | haha | 02:47 |
aquarius | self-interest. :) | 02:47 |
mhall119 | aquarius: I'll work on the "click the start to attend" feature too | 02:47 |
mhall119 | that'll make it even more useful | 02:48 |
mhall119 | s/start/star/ | 02:48 |
aquarius | that'd be cool, although it's way too small a target on mobiles at the moment | 02:48 |
aquarius | rule of thumb: a clickable thing needs to be 24x24px to be a target on a mobile, and that's a minimum. | 02:48 |
mhall119 | yeah, we can tweak the sizes and padding for mobile as we go | 02:48 |
mhall119 | the images are 24x24 I think, just shrunk to 16x16 | 02:49 |
aquarius | yeah, my goal for this branch was just to prove that making summit look nice on mobiles was easy :P | 02:49 |
aquarius | then we can start thinking about auto-collapsing sessions that are in the past, etc, but that goes beyond "reformat existing summit for mobile" into "design a decent mobile UI for summit", which is a worthy goal but needs more discussion ;) | 02:49 |
aquarius | anyway, it's 3am, so I'm going to bed. Will try and look more on Sunday :) | 02:52 |
aquarius | ttfn, gang | 02:52 |
mhall119 | thanks aq | 02:55 |
mhall119 | nigelb: why isn't tarmac landing https://code.launchpad.net/~sil/summit/mobile-view-for-daily-page/+merge/90555 ? | 03:11 |
nigelb | mhall119: no commit message? | 03:17 |
mhall119 | I always forget to check that | 03:23 |
mhall119 | punch it again please | 03:24 |
cjohnston | interesting scrollback | 03:58 |
mhall119 | cjohnston: we have a mobile-friendly schedule page! | 04:19 |
mhall119 | it's on the staging box now, you can give it a try | 04:19 |
mhall119 | http://91.189.93.80:8000/uds-p/2011-10-31/ | 04:20 |
cjohnston | I saw | 04:20 |
head_victim | I'm not sure who has access but http://www.ubuntu.com/support/community/mailinglists still refers to the sounder list mailing list but this list has been permanently shut down some time ago. If someone with access can please remove the reference that would be appreciated :) | 05:16 |
nigelb | cjohnston: ^ | 06:50 |
cjohnston | head_victim: file a bug against ubuntu-website-content | 11:15 |
head_victim | cjohnston: will do | 11:16 |
head_victim | bug 923030 | 11:20 |
ubot4` | head_victim: Error: Bug #923030 not found. | 11:20 |
cjohnston | head_victim: mark it unprivate | 11:20 |
head_victim | Sorry wasn't paying attention and didn't realise it defaulted to private. Fixed. | 11:21 |
head_victim | bug 923030 | 11:21 |
ubot4` | Launchpad bug 923030 in ubuntu-website-content "Mailing list information page still refers to the sounder list (affects: 1) (heat: 8)" [Undecided,New] https://launchpad.net/bugs/923030 | 11:21 |
cjohnston | np | 11:21 |
cjohnston | :-) | 11:21 |
cjohnston | it doesnt really matter as the people who can fix it all have the access | 11:22 |
head_victim | Seems odd to have bugs marked private for a package that is all about publically available content but I'm sure there's a reason I can't think of :) | 11:22 |
cjohnston | I would suspect its possible that stuff that isnt public yet could be discussed so that when its time, its ready | 11:23 |
cjohnston | but im not positive | 11:23 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!