[00:21] Hi everyone. Software centre takes maybe 15-20 secs to open. is this normal? [00:49] i had unity self compiled in my home dir.. and i've gotten rid of that now and installed the updated precise package [00:50] the default dash lense has changed.. and now shows recent apps, recent files and downloads [00:50] is it still supposed to show mail icon etc ? [01:23] snadge, no, it's not. Nobody used the big icons, so they changed for a home lens. === yofel_ is now known as yofel === agateau_ is now known as agateau === alang is now known as alang|afk === alang|afk is now known as alang [09:14] greyback: can you reapprove https://code.launchpad.net/~aacid/unity-2d/unity-2d_backport_shell_r934/+merge/91425 it was not merged on friday due to a conflict that i've already resolved [09:14] tsdgeos: good morning! [09:14] yep will do [09:15] greyback: morning :-) [10:01] greyback: that one is merged, can i have https://code.launchpad.net/~aacid/unity-2d/unity-2d_tests_for_rtl/+merge/90849 approved now? it was already approved by both Saviq and you [10:02] tsdgeos: go right ahead [10:02] greyback: myself? seems like cheating :D [10:02] tsdgeos: alright I'll do it;) [10:06] :-) [10:23] this new 'winching out' of the launcher, is very confusing when you have two screens. as the training you get to 'move fast enough' to jump the launcher pull out, trains you to hit the left edge of the left most screen tooo hard to get the launcher out ever, and there jumping it never makes sense [10:27] greyback: so now i just merge unity-2d-shell and push it, right? no need for reviewing the merge [10:27] tsdgeos: i mean "merge trunk into unity-2d-shell and push it to unity-2d-shell so it has everything unity-2d trunk has" [10:27] greyback: ↑ [10:28] not merging unity-2d-shell into unity-2d trunk [10:28] tsdgeos: yes, so it picks up changes. [10:29] tsdgeos: one sec, just approving your focus check [10:30] seb128: is FF and TB using non-system libgtk, or gtk2 or something? [10:30] kamstrup, gtk2 [10:30] seb128: I was looking into why saving an attachnment from TB doesn't log to zg, but that explains... [10:30] kamstrup, ;-) [10:31] seb128: should I ask RainCT to backport the gtk patch for logging recent files? [10:31] kamstrup, I guess I need to backport rainct's patches to gtk2? [10:31] seb128: I can also get RainCT to do it I think [10:31] or you can do it you it yourself whatever you find easiest [10:31] kamstrup, if you can get him to either backport them or at least open a bug with the git commits to backport [10:31] seb128: ok [10:32] kamstrup, I can do the backporting but I need to know what to backport and I would appreciate him updating the patches if they don't apply to gtk2 [10:32] kamstrup, they are small enough and are likely to apply though [10:32] kamstrup, i.e ask him to give me patches or url to commits that apply to gtk2 and I will do the packaging work, sounds fair? [10:36] hey [10:37] hi [10:37] seb128: we have RainCT here now as well :-) he's updated on the situation and ready to hack :-) [10:37] hey RainCT [10:37] kamstrup, RainCT: great, thanks [10:37] tsdgeos: done [10:38] nice [10:38] tsdgeos: also looking at your panel-buttons fix. It's not working 100% properly for me. About 10% of time time, the open dash has no panel buttons at all [10:39] greyback: you mean lp:~aacid/unity-2d/unity-2d_panel-newbuttons or the old code? [10:39] tsdgeos: that new one [10:39] weird [10:39] tsdgeos: yeah, I've getting glib assertions when panel buttons don't appear [10:40] greyback: seems you might need to reapprove https://code.launchpad.net/~aacid/unity-2d/unity-2d_test_alt_f1_right_super/+merge/91619 ? [10:41] greyback: tbh i don't know much about that panel-newbuttons code, it is mostly Ugo's i just did a few tweaks Saviq requested after Ugo was moved [10:41] tsdgeos: yep, that I know. [10:41] greyback: do you have a way to repro the problem or seems random? [10:41] tsdgeos: it's a bit random tbh [10:42] I'm suspecting the code that detects if the dash is open. If I remember correctly, it's using wnck to check if the dash is the active app [10:43] you mean the "dashIsVisible" variable ? [10:43] it's my guess [10:43] but I didn't probe much [10:44] let me see, do you get that by running the test or just by playing with super, pressing the bfb, etc? [10:44] just clicking the BFB again & again :) [10:44] ok [10:47] yeah, fairly easy to repro [10:47] let's see what i can get [10:49] bbiab [11:02] morning all [12:31] greyback: there? [12:31] tsdgeos: yep [12:31] something went wrong with my merge [12:32] greyback: https://code.launchpad.net/~aacid/unity-2d/unity-2d-shell_rtl/+merge/90455 [12:32] thinks i remove and add https://code.launchpad.net/~aacid/unity-2d/unity-2d-shell_rtl/+merge/90455 [12:32] err [12:32] thinks i remove and add tests/launcher/autohide_show_tests_common.rb [12:32] any idea if i can fix that? [12:33] tsdgeos: I'm confused, can you explain again please? [12:33] greyback: open that MR [12:33] you'll see [12:33] removed file 'tests/launcher/autohide_show_tests_common.rb' [12:33] and [12:33] added file 'tests/launcher/autohide_show_tests_common.rb' [12:34] which is obviously not what i want [12:34] and probably an artifact of a somewhat broken merge on my side [12:35] wondering if there's a way to fix that [12:35] since otherwise reviewing the diff is kind of hard [12:36] yes that's weird. Nothing obvious comes to mind [12:38] RM tests/shell/input_shaping_tests.rb => tests/shell/input_shaping_common.rb [12:41] the history looks clean enough, bzr must be confused [12:41] greyback: i had a look at that "missing dash buttons" in the panel [12:41] greyback: and it reproduces in current unity-2d wihtout the new buttons patch [12:42] greyback: so i'm not saying it's not a bug, but should be no reason to not merge that new buttons stuff [12:42] tsdgeos: yep, ok [12:48] greyback: want me to open a bug? [12:48] tsdgeos: please do === MacSlow is now known as MacSlow|lunch [12:52] greyback: https://bugs.launchpad.net/unity-2d/+bug/927604 [12:52] Launchpad bug 927604 in unity-2d "[Panel] The dash buttons sometimes do not appear" [Undecided,New] [12:55] tsdgeos: nice, thank you [13:01] seb128: For gtk2, does a patch against gtk+2.0_2.24.8.orig.tar.xz work for you? I was checking out lp:ubuntu/gtk+2.0 but it doesn't look like it'll ever finish downloading :p [13:01] RainCT, yes [13:01] RainCT, or gtk-2-24 git [13:01] kamstrup: i'm reading your blog post about the new unity lens api. do i understand it correctly that with it its possible to return some results and then update them asynchronously ? like for example asynchrounously generating a thumbnail of a file and updating the icon in the result with it when it's ready ? [13:02] RainCT, or apt-get source the package, I just want a diff that applies, no need of a proper merge request, note that's why we use lp:~ubuntu-desktop vcs with the debian dir only ;-) [13:02] okay [13:04] seb128: btw, here's the nautilus patch I mentioned last Friday: https://code.launchpad.net/~rainct/nautilus/nautilus-zg/+merge/91505 . Not ready yet (there's an outstanding question on its compatibility with Unity), but mhr3 wants to know how much you love it :p [13:04] nerochiaro: in theory yes; the frameworks are ready; the question is if Unity2/3d is ready. I haven't tested this, and no one ever did afaik [13:04] RainCT, ok, I will have a look [13:05] nerochiaro: but for thumbnails in particular unity itself can do a lot of that, so mostly not necessary unless you have some very non-standard way you need to do it [13:06] kamstrup: well, i don't think 2d has any of that built in (for thumbs). but 'll have a look tomorrow. worse case can i send out a temporary icon and when i get the new one from the async process i can call invalidate_search and return a result with the new icon, right ? [13:21] seb128: ok, gtk+2 patch attached to the LP bug [13:22] RainCT, thanks [13:49] nerochiaro: probably queue_search_changed(), but yes [13:51] kamstrup: what's the difference between the two ? [13:53] nerochiaro: normally sending the same search string twice will not result in a search-changed signal. Calling invalidate_search() circumvents that check [13:53] nerochiaro: whereas queue_search_changed() will give you a search-changed signal next time you are shown in the queued mode, no matter what [13:54] kamstrup: i'm not sure what you mean by "queued mode" [13:55] so I tried to run checkbox-unity in a Guest session last night, but it kept trying to sudo... [13:55] what's the proper way to run it? [14:00] nerochiaro: the particular value of Unity.SearchType you pass as argument [14:01] greyback: any idea which strings do we have to pull to get the Qt-dnd-xshape thing packaged? [14:07] tsdgeos: I forgot the name of the Qt maintainer. didrocks kknows [14:08] tsdgeos: he's a community guy [14:08] tsdgeos: debfx, but you can ask riddel as well [14:08] didrocks: thanks :) [14:08] yw :) [14:10] kenvandine: ping [14:10] mhall119, pong [14:10] hey, I was wondering if you knew the current state of unity-singlet being uploaded? [14:12] https://launchpad.net/ubuntu/precise/+queue?queue_state=0&queue_text=singlet [14:12] it is still in sourceNEW [14:12] kenvandine: thanks === MacSlow|lunch is now known as MacSlow [14:12] https://wiki.ubuntu.com/ArchiveAdministration#Archive_days [14:12] mhall119, that is the schedule for the archive admins [14:13] you can try to ping whoever is on duty if you like [14:13] ok [14:37] tsdgeos: all the rtl input-shaping tests fail on me. ltr & rtl. Can you check please? [14:38] greyback: -shell? or -shell_rtl? [14:38] tsdgeos: shell-rtl [14:38] ok, sec [14:38] greyback: if run separately too? [14:38] tsdgeos: also a rtl bug, the blurred background of the dash is wrong. Dunno if that's in scope for the MR [14:38] tsdgeos: yep [14:39] greyback: to be honest the scope was getting the tests to pass :D [14:39] fair enough! :) [14:43] greyback: you using MultiMonitor? [14:43] tsdgeos: not for running tests [14:45] they pass here [14:45] do you have the unity-2d-panel running? [14:45] I get identify: improper image header `/tmp/shape20120206-23788-1nscqh7-0.png' @ error/png.c/ReadPNGImage/3242 [14:45] ummm, probably, lemme try again [14:46] greyback: the unity-2d-panel has to be running [14:46] greyback: have you recompiled the new getshape thing? [14:46] greyback: ahhh [14:46] tsdgeos: yep, it's running [14:46] i know [14:47] if you run getshape manually you get some gdk/gtk/something warning, right [14:47] ? [14:47] https://pastebin.canonical.com/59486/ [14:48] yep [14:48] gtk2-engines-pixbuf <-- install this [14:49] the problem is [14:49] that the sut thing [14:49] redirects everything to the file [14:49] even if that is in stderr and the "good" output in stdout [14:49] thus you end up with a "wrong" png [14:49] aha [14:49] because you have that warning there [14:49] I see [14:49] yuk [14:50] doesn't getshape write out to file itself tho? [14:50] not anymore [14:50] since otherwise we could not support the host/target split [14:50] so it writes the image to the output [14:50] you can have it write to file on the target, then copy the file over [14:51] can you? [14:51] yep [14:51] i tried looking how to do that and did not find the command [14:51] https://projects.developer.nokia.com/dav/Testabilitydriver/doc/api/qt_linux/#FileTransfer:copy_from_sut [14:51] i found stuff to list files [14:51] but not to copy [14:51] nice [14:52] then probably we want to go back to the getshape that writes to file and copy it over? [14:52] what you say? [14:52] that would be safer [14:53] okidoki [14:53] well, meaniwhile install that [14:53] so you can run the tests [14:53] *or* you can try bash-fu like "bash -c 'getshape 2&>/dev/null'" [14:54] but personally I prefer the copy file approach [14:54] yep, running [14:54] nuthinking: hey [14:54] how are you? [14:57] tsdgeos: hmm, why is my dconf form-factor settings always reset to "tv" [14:57] greyback: is it? [14:57] tsdgeos: it's not done by a test I think [14:57] there must be a bug when i try to restore in a test? [14:57] no? [14:57] tsdgeos:do you set it? I didn't realise it [14:57] yes, we set to tv in some test [14:58] aha in fullscreen [14:58] ok. [14:58] Symptom of not having safe dconf-reset [14:58] it's on my list :( [14:58] I'll get to it after FF [14:59] tsdgeos: ok thanks, those tests pass now [14:59] goodie :-) [15:00] * greyback hugs grooveshark, 2 old favourite songs played in a row [15:01] greyback: i've pushed the change to use copy_from_sut anyway [15:02] greyback: do you think we could merge the rtl into -shell soon-ish? Anything else you find missing? [15:06] tsdgeos: no I'm pretty happy with it [15:08] nice [15:09] tsdgeos: bzr getting a little confused tho :) https://pastebin.canonical.com/59489/ [15:09] ah sorry [15:09] i repushed to get a nicer history [15:09] repushed == overwrote history [15:10] don't know what this means for your local copy [15:10] ok, I think I can force it, no biggie [15:10] bzr pull --overwrite ? [15:11] yep, thank you [15:12] greyback: launchpad only auto merges stuff to unity-2d but not to unity-2d-shell ? [15:13] didrocks: hi [15:14] didrocks: ^^ tarmac automerges every MR, not just to the trunk, but branch into other branches? [15:15] nuthinking: https://docs.google.com/a/canonical.com/document/d/1ILTJDiDCd25Npt2AmgzF8aOnZZECxTfM0hvsbWT2BxA/edit?hl=en_US, section 2.2, the first image should have "appearance", isn't it? [15:15] not user interface in the breadcrumb [15:15] didrocks: yep [15:16] greyback: no, it's only right now when you target trunk, we can handle other, but w decided with Tim that it's easier that way (as we are not sure that branches merged into other branches should pass make check) [15:16] nuthinking: ok, thanks for confirming! [15:17] greyback: so what do we do with https://code.launchpad.net/~aacid/unity-2d/unity-2d-shell_launcher_dash_focus_loss/+merge/91628 then? Merge it manually? [15:17] nuthinking: all changes are implemented g-c-c side [15:20] nuthinking: who should I hassle for pixel perfect layout? [15:20] didrocks: ok, thanks for clarifying! [15:20] greyback: yw :) [15:21] tsdgeos: yes, I promote you to human-tarmac privileges! :) [15:22] just for shell, if you touch trunk didrocks will be after you :P [15:22] greyback: so basically just merge by hand? I see there are some commits there that say "Committer: Tarmac" like http://bazaar.launchpad.net/~unity-2d-team/unity-2d/unity-2d-shell/revision/951 [15:23] you don't want to try :) [15:23] even *consider* :p [15:26] tsdgeos: now I'm confused again. [15:27] i'm sorry [15:27] i am too :D [15:27] greyback: maybe Saviq runs his own tarmac? [15:27] didrocks: is that ↑ possible? [15:28] tsdgeos: we've couple of commits waiting in queue for hours now. So it's not the usual tarmac working. [15:29] tsdgeos: yeah, seems so [15:29] not my tarmac :) [15:29] my committer is unity merger [15:29] tsdgeos: you can push manually so [15:29] ok [15:29] i will [16:38] mhr3, hey, so one thing i totally wanted in the lenses this cycle but completely forgot about, did we do it anyway by any chance? It was add lens specific default file icons - so music lens has their own one, file lens, app lens and so on [16:41] gord, as in lens would specify what icon to use if one can't be loaded / isn't set? [16:42] mhr3, yeah [16:42] right now we just the default file icon everywhere [16:42] gord, it surely makes sense [16:42] we could just add a key to the .lens file [16:43] i dont think it really needs to be exported on the bus [16:43] mhr3, +1 [16:43] do it! [16:43] mhr3, gord, it would be a huge API win :) [16:44] gord, a bug pls :) [16:44] davidcalle, you mean no api is a huge api win? :) [16:44] mhr3, hehe. Almost. [16:52] greyback: Kaleo has found that in unity-2d-shell Super + Esc does not hide the Launcher immediately and regular unity-2d does, but i have found that the unity-2d-shell behaviour is the same one that unity3d has, so do we consider it a bug or a feature? :D [16:53] tsdgeos: well, we need to figure out if it's reliable, ie. if we did that on purpose [16:54] Kaleo: yes, it's on purpose, once forcing the visibility of the launcher ends (i.e. because the dash was open) we add a one second delay before hiding the launcher [16:54] tsdgeos: hmm, can you check that focus returns to the front application too while you're at it (in shell)? [16:54] greyback: doing what? [16:54] greyback: i mean which key combo [16:54] tsdgeos: super + escape [16:54] greyback: it should, we have a test for that :D [16:55] oh wait, never mind [16:55] and it passes [16:55] or did at least [16:55] mhr3: did you see the email that just came in on canonical-tech? [16:55] yep ok, that's something I remembered from a little while back. Glad it's fixed [16:56] mhall119, nope, let me check [16:56] tsdgeos: I see no point in spending time emulating the broken unity-2d behaviour. Consider it a fix in shell. (but would be good to have the behaviour verified by design) [16:56] mhall119, oh that's good :) [16:57] greyback: okidoki [17:00] tsdgeos: JohnLea tells me in Unity 3D 11.10, the launcher disappears immediately upon dismissing the dash by pressing the super key [17:00] Kaleo: not in the one i have installed [17:01] tsdgeos: from the PPA? [17:01] which tbh is not pure 11.10 but something newer [17:01] mhr3: got a fix for that? [17:01] Kaleo: 5.0.0~+bzr1825ubuntu0+611 no idea where that come from [17:02] tsdgeos: so, in any case, JohnLea says that the launcher should disappear immediately [17:02] ok [17:05] Kaleo: EOD'ing now, i can fix the hiding easily tomorrow, i'm not that confident about the mumble shortcut eatiing thing, but hope it won't be difficult either [17:05] greyback: don't forget to review those MR! ;-) [17:06] gah, just missed him [17:25] mhall119, fix? nope, we never seen such issue, i'd suggest using dee-tool to look at the models and inspect peers in the swarm, but dee-tool isn't available in 11.10 :/ [17:27] mhr3, thar you go https://bugs.launchpad.net/unity/+bug/927745 [17:27] Launchpad bug 927745 in unity "UnityCore and lenses should provide default file icons" [Medium,Confirmed] [17:27] mhr3, is it possible to choose the default activated options in the sources filter? [17:28] ...from a scope. [17:28] davidcalle, i actually wanted it, but no :/ [17:28] Ok [17:29] mhr3, thanks [17:29] davidcalle, shouldn't be too hard if we reaaaaaaly wanted it [17:30] mhr3, nope, it's ok :) [17:30] mhr3, for me at least [17:34] so I just updated my dual-screen monitor rig and have some feedback for the unity team...to whom would I send that? [17:40] utlemming: well this is the right place if you've just general comments to make. More specific bugs I'd encourage you to report on Launchpad [17:42] well, I have a dual-screen setup and after updating Unity I now have two launchers -- one on each screen. The problem is that unless I zoom my mouse across the screen, the unity launcher will hold my mouse hostage for a few seconds. In my opinion, taking my mouse hostage makes for a poor-usabilty experience. [17:43] utlemming: you can change the threshold for how much 'zoom'ing is needed to avoid the capture [17:43] how? [17:44] utlemming: currently in ccsm [17:44] even though jcastro will kick me for suggesting it's use [17:45] hopefull in myUnity sooner rather than later [17:51] mhall119: thank you much, that made it much more usable === mpt_ is now known as mpt === s9iper1 is now known as bil21al === mpt_ is now known as mpt === _salem` is now known as _salem === _salem is now known as salem_ [19:41] mhr3, hey, did some testing and the trunk version of libunity doesn't return 0 results on start up now :) [19:41] mhr3, thanks! [19:41] bschaefer, awesome :) [19:42] mhr3, also mikkel switch HomeLens to uses the LensView so that was automatically fixed, so the branch should really soon [19:42] should be done * [19:43] bschaefer, i think we're still missing how to display the no-results-hint for the homeview [19:43] unless i missed it in there [19:44] mhr3, it is working on the branch I have up now, hmm [19:44] it is? [19:44] because it returns to the GlobalSearchFInished [19:44] hmm [19:44] which checks if == homesview [19:45] mhr3, it doesn't have a no-results actaully [19:45] so the default message gets displayed :) [19:45] which is what the design says [19:46] mhr3, https://launchpadlibrarian.net/91847789/max_dash.png [19:47] bschaefer, so you just hardcoded it into unity? [19:48] well yeah the default message if there is "no-results-hint" found [19:48] mhr3, I actually need to push a new change, instead of using g_strdup_printf it is now using a std::string [19:49] mhr3, but I don't see why you would need to pass the default message through no-results-hint [19:50] bschaefer, my worry was about l10n, but unity-core doesn't have have infrastructure for that, so it's not defined in there... but kinda sucks that now both unity and 2d have to define it [19:51] mhr3, ooo dam [19:51] mhr3, completely slipped my mind about that, hmm [19:53] mhr3, so should libunity handle if the lens doesn't provide a no-results-hint? [19:53] bschaefer, no [19:54] mhr3, how would the default message get past by an arbitrary lens that doesn't come with a no-results-hint? [19:55] mhr3, that is why I had hard coded that in [19:55] bschaefer, maybe the lens wanted to not show anything? :) [19:56] mhr3, dammit, that better not be the case haha! [19:56] we shouldn't care too much really, the default lenses do they should, the other have have the possibility to do it as well, it's up to them [19:56] mhr3, oo also I found something wired with the music lens [19:57] i hope you understood what i meant to say :P [19:57] i'm making it hard for people sometimes :P [19:57] morning [19:57] bschaefer, so what's up with ulm? [19:58] hey thumper [19:58] mhr3, haha, no I get it but I just figured all lenses should have a displayed message from reading the bug report haha [19:58] thumper, morning [19:59] bschaefer, ultimately unity can force it [19:59] mhr3, so since I don't have any music har har; when you type a char then delete it really fast the available for download sometimes sticks around [20:00] hmm does it? [20:00] probably a bug in the scope [20:00] mhr3, should have taken a screen shot...it is kinda hard to do sometimes but when it happens it sticks around [20:00] i see it [20:01] easy to reproduce with the slow response of the web service :) [20:01] mhr3, cool, was just trying it and couldnt get it to do it! [20:01] mhr3, but since the message getting displayed is attached to the same layer and it changed the stack placement it screws things up [20:08] mhr3, though visually it really isn't a problem unless you have no music haha [20:22] bschaefer, ah ,so the msg doesn't hide once the results arrive? [20:22] mhr3, yeah the message gets displayed along with those available downloads [20:25] bschaefer, well ultimately it's a bug in the lens, it should send proper results [20:25] it's not doing that [20:25] mhr3, yeah I started to look at the code then started learning vala haha [20:26] mhr3, but overall I don't think it is the highest priority [20:27] should be fairly simple fix though [20:28] mhr3, when I get some free time I can start digging through it again :), as vala looks fun to learn [20:29] mhr3, unless it is such an easy fix you have already fixed it ;) [20:29] * mhr3 loves vala for the native async paradigms [20:29] bschaefer, if you knew what you're looking for, it could be fixed probably in ~5minutes :) [20:30] mhr3, haha, yeah I was just greping for search string and was trying to find the results to see where it was getting updated [20:30] then I realized I didn't know vala at all so I started doing some smaller tutorials on! [20:31] bschaefer, but it's very much like c# if you know that [20:31] mhr3, I know java, which is close to c# [20:31] right [20:31] bschaefer, but c# and vala are actually nice ;) [20:31] but havn't done java in a few years even though Im tutoring in it right now haha [20:31] mhr3, yeah and lambda expression! [20:31] that was nice to see [20:32] java still doesn't do that? [20:32] mhr3, they might, but im not sure [20:32] but who would care java anyways :P [20:32] care about* [20:32] mhr3, exactly ;) [20:36] mhr3, so Im guessing it is in the musicstore-scope.vala [20:37] most likely [20:37] or the daemon [21:07] bschaefer, figured it out? [21:09] mhr3, got side tracked on pushing some changes to the no results branch. [21:09] mhr3, was looking at preform_search and it just doesn't seem to be getting then where there is nothing in search [21:10] bschaefer, the is_search_empty() return in there will be the culprit :) [21:11] mhr3, ugg that makes so much sense now [21:11] mhr3, I was thinking that since you hit 'q' and then delete the 'q' was getting past to the perform search [21:12] the whole ulm wrapper classes could use some refactoring [21:12] mhr3, so I though the is_search_empty() was never returning true; but I was about to add some print statements [21:13] bschaefer, so basically the problem is that when the search is empty string the previous search doesn't get cancelled [21:13] yeah! [21:13] mhr3, that is what I realized when you said that haha [21:14] bschaefer, :) [21:14] mhr3, so the fix is to basically remove that check [21:14] mhr3, which solves that bug on mine :) [21:14] bschaefer, well we want to keep the behavior that it doesn't display any results when the search is empty [21:16] mhr3, hmm, would it be similar to how the banshee scope uses it? [21:17] not sure what you mean [21:17] mhr3, well I was just looking at how the banshee-scope.vala does the perform_search [21:18] bschaefer, i wouldn't look there, the banshee scope isn't async [21:19] well it's defined as async, but does things synchrounously [21:19] mhr3, because if the is_search_empty() is the problem I almost want to clear the scope [21:19] since it has to stay there, so instead of return clear the scope? (not sure how to do that though) [21:20] mhr3, or maybe use update_search_async [21:20] (no) [21:20] the proper way to do it is to pass the cancellable from search-changed signal to the perform_search method [21:21] and then for the musicstore scope pass it to the collection.search [21:21] instead of the cancellable that's created inside collection.search [21:22] that way it'll magically start to work even with the if is_search_empty() return that's there [21:24] mhr3, so update update_search_async to have another param [21:24] * ejat how to test the HUD .. [21:25] bschaefer, yea, and pass it all the way down to perform_search [21:25] mhr3, ok yeah, then the collections is down in perfom_search [21:26] right [21:28] already install but didnt see the diff [21:38] mhr3, hmm so now I have cancellable in the perform_search, so now Ill have to change the collection.search to accept the new cancellable? [21:39] yep [21:39] you'll see that the scope already uses one, so just replace it with that one then [21:39] mhr3, just found the collection class haha, nice. [21:40] mhr3, yeah, I had to edit the banshee-scope since both of them use the perform_search which as an extra param now [21:41] do variables gets shadowed in vala? or should I just remove this line "private Cancellable? cancellable;" [21:41] mhr3, nevermind Im removing it [21:58] mhr3, hmm now the musicstore doesn't return any results [22:00] you probably forgot something :) [22:00] pastebin the diff? [22:00] mhr3, i just pushed a branch, and Ill commit the changes [22:00] in a second [22:05] mhr3, https://code.launchpad.net/~brandontschaefer/unity-lens-music/cancellable-search [22:07] mhr3, well I have it getting results but it seems to be returning 0 results to unity so the message appears! [22:08] bschaefer, you dont cancel the cancellable yourself, that's what's wrong [22:09] i mean... you shouldn't [22:09] o, so I should remove if != NULL then just pass cancellable on through [22:10] mhr3, worked :) [22:13] mhr3, thanks for spending time and helping me through that! [22:14] bschaefer, np, clean it up and mp it ;) [22:14] mhr3, I also pushed the new changes to the branch. [22:17] mhr3, One more question in musicstore-collection.vala where it sets cancellable = null; seems pointless now [22:17] mhr3, and removing it doens't change anything so im going to remove it. Just wanted to double check with you! [22:18] mhr3, near line 92 [22:18] bschaefer, yep, that's what i mean by cleaning it up :) [22:19] mhr3, haha, ok I think it is all cleaned up! One more push then ill mp it! [22:26] mhr3, https://code.launchpad.net/~brandontschaefer/unity-lens-music/cancellable-search/+merge/91728 [22:28] mhr3, that was fun, now hopefully if there are problems with the lenses I don't have to keep buging you as much ;) [22:28] bschaefer, awesome, will review it tomorrow :) [22:28] mhr3, sweet thanks! Have a good night :). Hope I didn't keep you up to late [22:29] dont worry, you're not the only one :) [22:29] mhr3, haha [22:32] thumper, ping [22:33] hi bschaefer [22:33] thumper, hey, so I wanted to update you on last week and things to go this week [22:33] sure [22:33] thumper, got the alt + f1 bug finished and reviewed and is now in trunk [22:34] yep, saw that [22:34] thumper, also have been looking into the ibus bug which I will be doing this week also [22:34] yep, thanks [22:34] ibus is super important [22:34] thumper, and got jay to help with the finishing touches on the no-results branch so that should be ready for merge with the unfreeze [22:35] we are unfozen [22:35] so we should be good to go [22:35] thumper, yeah! the ibus is my number 1 priority this week! [22:35] thumper, o dam well Ill want to review it some more to make sure it is done then propose it [22:35] thumper, also was going to get jay to help me finish that top panel bug that we put on hold [22:36] cool [22:36] * thumper jumps on a call [22:36] thumper, alright, that was the end also so perfect! Back to work :) [22:37] * thumper waves at bschaefer [23:22] grrr hud pop with alt is too sensative. [23:22] popup === salem_ is now known as _salem [23:54] I have a question about the Unity appmenu [23:55] I want to add the appmenu to an application that is not written in one of the supported toolkits. Thus the menu is not autonmatically extracted from the toolkit. [23:57] I want to write a python script as a bridge between that application and Dbus. I assume I have to add the menu structure as a Dbusmenu. [23:58] I didn't find enough documentation about the appmenu on https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationMenu