briancurtineod as well00:01
=== gatox_tv is now known as gatox
=== gatox is now known as gatox_away
karniEODs, bye bye o/04:08
=== dduffey is now known as dduffey_afk
=== yofel_ is now known as yofel
=== zumbi_ is now known as Guest94149
=== statik is now known as 64MAAQOA7
mandelscarleo, I can give you a hand, but let me reboot first.. some updates need it :(09:25
scarleomandel, ok thanks09:25
mandelscarleo, np09:25
* mandel reboots09:25
mandelscarleo, I'm back!09:33
mandelscarleo, so which os are you running?09:33
scarleoUbuntu 11.1009:33
mandelscarleo, and the probelm is that there are some images that are not syncing, is that correct?09:34
scarleoyes, they never get the green tick in Nautilus09:34
scarleomost sync but I have maybe 5 that doesn't09:35
mandelscarleo, hm.. interesting, are there any app that are using the images?09:35
scarleomandel, nope09:35
mandelscarleo, on linux we wait until you close the file so that we update the correct version..09:35
scarleoand they've been on the pc for quite some time09:35
mandelscarleo, ok, are they in ~/Ubuntu One or in a UDF, for example ~/Images09:36
scarleothay are in ~/Pictures/webbilder and Pictures is the folder I've set to sync09:36
=== gord_ is now known as gord
mandelscarleo, lets first see if it is indeed there, just in case :)09:37
mandelscarleo, run  u1sdtool --list-folders09:37
mandelscarleo, and  u1sdtool --status will also be useful09:38
scarleomandel, http://pastie.org/335356609:39
* mandel looks09:39
mandelscarleo, if you do  u1sdtool --info=PATH where PATH is one of the images, what do you get?09:40
scarleomandel, http://pastie.org/335358409:41
mandelscarleo, and u1sdtool --waiting-content ?09:43
mandelscarleo, I'm trying to find out in what state are those files..09:43
scarleo--waiting-content gives Deprecated, use --waiting. --waiting gives no output09:44
mandelscarleo, hm.. funny, let me see if one of the QA is there, but nothing seems to be bad with those files09:45
scarleomandel, I can see them when I log in to one.ubuntu.com09:45
mandelscarleo, have you check the web ui, are the files there?09:46
mandelscarleo, oh, so they where uploaded yest nautilues gives the wrong icon09:46
scarleomandel, yep09:46
mandelscarleo, I think that is a bug in the nautilus plugin then... :(09:46
mandelscarleo, the developer that takes care of that is based in the USA, do you find filing a bug with all what we have looked at and explain that the files are ok in the web09:47
scarleoalso every time I login to my desktop U1 tells me it is syncing one image but it's already synced09:47
mandelscarleo, I'm sure we will take a look at that asap09:47
scarleook, I will09:47
mandelscarleo, I think there was a bug with the notifications where it had 'memory'09:47
mandelscarleo, AFAIK we are working on that, but we have been looking at porting to other platforms lately and have not had the time, sorry for the PITA09:48
scarleomandel, no problem09:48
mandelscarleo, also, add the logs and set the bug to private, we will make it public if there is nothing that could compromise your account or details about you09:49
mandelscarleo, better safe than sorry09:49
scarleomandel, which log and where is it?09:50
=== zumbi is now known as Guest47393
mandelscarleo, let me check09:50
mandelscarleo, should be here: .cache/ubuntuone/log09:53
ryeah, mornings09:54
scarleomandel, ok, filing a bug report then09:54
mandelscarleo, thx, we really appreciate that!09:54
mandelscarleo, also, if you are here a little longer we can ask rye, he may know :)09:55
mandelrye, do you have back logs?09:55
scarleoyeah I've got time09:55
ryemandel, yes, i have them, looking09:56
mandelrye, thx!09:56
mandelscarleo, I leave you with rye he is great at finding problems like this09:57
scarleomandel, is it the syncdaemon log I should provide from .cache/ubuntuone/log09:57
scarleomandel, ok09:57
scarleoHi rye09:57
* mandel goes back to be a code monkey09:57
ryescarleo, re: already synced images - it is a bug in client display code09:58
ryescarleo, reading further...09:59
ryescarleo, what system are you now on?09:59
scarleoHmmm, the file always telling me it's uploaded every time I log in is in syncdaemon-exceptions.log09:59
scarleorye, Ubuntu 11.1009:59
ryeh, launchpad down?10:00
ryescarleo, the first is bug #807005 - what ubuntuone-client do you have - apt-cache policy ubuntuone-client and see the Installed version10:03
ubot4`Launchpad bug 807005 in ubuntuone-client (Ubuntu Precise) (and 7 other projects) "Filename in notification does not reset. (affects: 9) (dups: 3) (heat: 38)" [Undecided,Fix released] https://launchpad.net/bugs/80700510:03
scarleorye, 2.0.0-0ubuntu2.310:04
ryescarleo, ok, could you please download the script form http://people.canonical.com/~roman.yepishev/us/u1filestatus.py and run it in the terminal10:05
scarleorye, can I paste the syndaemon-exceptions.log ? The file that is noticing is in there but it contains some id's and stuff. Is it safe? It's to a shared folder10:05
ryescarleo, it will show what files are not synced10:05
scarleook, I'll download it10:06
ryescarleo, download and run it as "python u1filestatus.py"10:06
scarleorye, http://pastie.org/335367710:07
ryescarleo, hm, where are the files that are not synced located?10:08
scarleorye, they are synced, I can see them in web UI, they do not get the green tick in Nautilus. The files affected are in ~/Pictures/webbilder10:08
ryescarleo, ok, this looks like the emblem issue, are other files marked as synced?10:09
scarleorye, yes, it's about 5 .png and one .gif that doesnt get the emblem10:10
scarleorye, so emblem issue is known?10:17
ryescarleo, well, this part does not have extensive test coverage, I am booting my virtual machine with oneiric to see how it works now10:23
JamesTaitOh, and good morning, world! Happy Friday! :)10:27
ryemeh, you people changed API for u1sdtool 3 times, the 3rd time breaks my u1filestatus in precise. boo,10:28
ryeoh, i know, i just propose it for merging :)10:28
mandelgatox, morning!11:10
gatoxmandel, buenas11:11
mandelgatox, in a few mins I'll have lots of reviews to be done trying to land a feature today, mind if I bother you with the later?11:11
gatoxmandel, no problem!!11:11
mandelgatox, great, is an good amount of code, but is just lots of branches very small11:12
nessitabuenos días!11:17
gatoxnessita, buenas11:18
nessitahola gatox, how is it going?11:19
nessitawill review now!11:19
gatoxnessita, fine..... finishing with u1-client-network-detect11:19
mandelnessita, good morning, I did a code review for https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/move-ping/+merge/92378 and looks great11:20
mandelnessita, let me run the tests and I'll approave, I completely forgot to do that11:20
nessitamandel: awesome!!!11:22
nessitagatox: oh, a branch of mine yesterday landed and your branch has one conflict (should be easy to fix:11:26
nessitaText conflict in ubuntu_sso/utils/ui.py11:26
nessita1 conflicts encountered.)11:26
gatoxnessita, ok..... fixing that right now11:26
gatoxnessita, fixed11:29
nessitagatox: thanks!11:29
mandelgatox, what is orange and sounds like a parrot?11:40
gatoxmandel, carrot11:40
gatoxi read your twits11:40
mandelgatox, heheh11:40
gatoxmandel, i abstain to do any comment about that REALLY BAD JOKE!11:40
mandelis not THAT bad hehe11:41
nessitagatox: APPROVED11:43
gatoxnessita, just like that?!11:43
nessitaralsina_: hola! would you be around?11:44
mandelnessita, FYI +1 on https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/move-ping/+merge/9237811:46
nessitamandel: thanks11:46
ralsina_nessita: yes, here I am11:59
ralsina_mandel: what's brown and sticky?11:59
mandelralsina_, I should know...11:59
ralsina_mandel: A STICK!11:59
mandelralsina_, and they say my jokes are bad..12:00
ralsina_mandel: it's from a movie. Hollywood says it's funny!12:00
mandelralsina_, he..12:02
=== ralsina_ is now known as ralsina
mandelralsina, che, for you wife in a few days: sqrt(cos(x))*cos(300x)+sqrt(abs(x))-0.7)*(4-x*x)^0.01, sqrt(6-x^2), -sqrt(6-x^2) from -4.5 to 4.512:03
mandelralsina, super super gay..12:03
ralsinaI refuse to figure out how to graoh that ;-)12:04
mandelralsina, is good, trust manuel..12:04
ralsinaOk, got it. :-)12:10
mandelralsina, see, is nice :)12:12
mandelralsina, and geeky, so double points12:12
ralsinamandel: wife is a lawyer. geeky is -.25 points12:12
ralsinaIf I were to give her a poster of Mazinger-Z and Aphrodite-A on the beach, for instance, she would hate it. Can you believe it?12:13
nessitaralsina: hey there! not sure if you saw my messages yesterday evening about a couple of reviews needed12:15
nessitaralsina: one from me and one from gatox12:15
ralsinanessita: I did yours, gatox is taking a bit longer12:15
nessitaralsina: ah, great!12:15
gatoxralsina, we can do the 1-1 whenever you want today12:16
nessitadid you vote in it? (this morning had no vote)12:16
ralsinanessita: in fact, your branch has 2 now, so you can approve it12:16
nessitaralsina: thanks!12:16
ralsinagatox: I am going to take a short break to walk while P updates, let's do it in 30'12:16
* ralsina walks himself12:16
gatoxralsina, roger that12:16
nessitaralsina: and when you have a free slot, I desperately need help with the qt spawner. Somehow, the instance of the QProcess is garbage collected so is not working12:18
nessitaralsina: I've tried holding to that instance adding classes and all, but there is no way12:19
ralsinanessita: point me at the code, I will take a look immediately12:19
nessitaralsina: so, current version (without adding classes) is lp:~nataliabidart/ubuntu-sso-client/execute-ui12:19
nessitaralsina: once you branch that (tested on linux only for now)12:20
nessitaplease remove your U1 token and run this command in the branch:12:20
nessitaUSE_QT_MAINLOOP=True U1_DEBUG=True PATH=bin/:$PATH PYTHONPATH=. bin/ubuntu-sso-login12:20
ralsinanessita: ack12:20
nessitaralsina: once the sso service is running (you will get output in the terminal), you can open the gtk controlpanel and click on "I already have an account". Do not login, just click on "I've forgotten my password" and put this email in the field: a@example.com12:23
nessitawhen you click the default button, you should get this trace in the terminal:12:23
nessitaralsina: bah, a little different since I have some local changes where I put some stuff in classes to try to hold to the objects a little longer (does not work)12:24
ralsinanessita: got it12:25
nessitathe trace?12:25
ralsinanessita: yes12:25
nessitaralsina: awesome!12:25
ralsinanessita: ok, I'll try to see if something comes to mind12:25
nessitaralsina: I'm up for any chanchada to resolve that. Is driving (more) crazy12:25
ralsinanessita: MY SPECIALTY! ;-)12:25
nessitaralsina: ok, I will move to some reviews to put some air in my mind and give you time to "fix" it :-D12:26
ralsinanessita: cool12:26
nessitahola alecu12:27
ralsinanessita: the version of spawn_program I have from bzr will never work because indeed process will be GCd right after start()12:27
nessitaralsina: yes, I can push you what I have now12:28
ralsinanessita: let me try something first12:28
nessitaralsina: I have a couple of classes and hold to the references, but they disappear the same :-/12:28
nessitaI will make some mate for now12:28
ralsinanessita: working proof of concept chanchada: https://pastebin.canonical.com/59923/12:33
ralsinanessita: if you push what you did with classes I can take a look to see if I can do something less nasty12:34
ralsinanessita: I would even rather leak the QProcesses (since SSO dies a little later anyway)12:34
alecuralsina, nessita: what if we have a "processmanager" singleton, that holds a dict of active processes, and has a "remove_process" method attached to process.finished?12:36
ralsinaalecu: same idea, except I am using a list ;-)12:36
ralsinaalecu: why a dict, what would be the key? The qprocess itself?12:37
alecuralsina, right: I'm using something similar for QTCPsockets12:37
alecu(or whatever they are called)12:37
ralsinaThis (GC of some objects) is the area where Qt and Python have some impedance mismatch12:37
alecuralsina, definitely12:38
alecuralsina, well, looking at your code it seems that a set() would do better than either a dict or a list.12:38
ralsinaalecu: and just connect lambda: thing.remove(process)12:39
nessitaralsina: I like your solution, is much less chanchada than I imagined12:39
ralsinanessita: use a set instead of a list, remove remove_process and it's not a chanchada at all12:40
nessitaralsina: will push what I have so you can please explain to me why this last thing I tried is also not wokring12:40
ralsinanessita: happy to12:40
* ralsina orders a "Not bad for an old ex-nerd" t-shirt12:41
nessitaralsina: Pushed up to revision 86512:41
nessitaralsina: yes, I know that the class Runner in qt would be buggy if spwan process is called more than once, but was just trying stuff12:42
ralsinanessita: my guess is that the Runner from __init__ was also being GCd12:43
ralsinanessita: where were you instantiating that from?12:43
nessitaralsina: credentials.py:14812:44
nessitaralsina: I'm holding the ref there12:44
nessitasince _show_ui will not finish until runner.spawn_program finishes12:44
ralsinanessita: problem with my solution: there is no guarantee about the order in which things connected to finished will be called. So probably better to just leak the QProcesses12:47
nessitaralsina: what's the problem with the order? is I call set.remove... order does not matter, no?12:48
ralsinanessita: you are not connecting anything else to finished? In that case: OK!12:48
nessitaralsina: ah, yes, I am. I *now* understand12:48
nessitaI can remove the process from the set in the callback I already connected to finished12:49
ralsinayou can remove it from processes in your call, though12:49
nessitaok, will revert all this classess that add noise12:49
nessitaralsina: thanks!!!12:49
ralsinanessita: maybe it's getting GCd because the calls to finished will only be processed after it reaches the qt mainloop. Perhaps your deferred is triggered before that, and then _show_ui ends, runner gets GCd => crash12:50
ralsinanessita: but it's just a guess12:50
ralsinanessita: you're welcome!12:50
nessitaralsina: well, the deferred is fired when the finished callback is executed12:50
ralsinanessita: it's a bit too complicated for me to guess quickly, I suppose12:51
nessitano problem12:51
nessitaI will use your solution12:51
ralsinanessita: cool. I will be back in 30' then :-)12:52
nessitaIT WORKS12:55
nessitaI CAN'T BELIEVE IT12:55
* nessita cries, a lot12:55
mandelralsina, Why was 6 scared of 7?12:56
ralsinamandel: because seven ate nine12:56
mandelralsina, hehehe12:56
ralsinamandel: what did 0 say to 8?12:56
ralsinamandel: "nice belt!"12:57
mandelnessita, where was the spawn method in sso? I cannot remember..13:05
nessitamandel: ubuntu_sso/utils/runner. The API is about to change wiuth a branch of mine, but is working now!13:05
mandelnessita, ah, runner ok :)13:05
karniMorning #ubuntuone !13:06
nessitahola karni!13:06
karnihola nessita ^_^13:06
mandelnessita, if I have a command line such as --app_name name --domain domain it should be passed as ('--app_name', 'name', '--domain', 'domain') is that correct?13:07
nessitamandel: yes sir13:07
nessitamandel: and the runner will escape those accordingly13:07
mandelnessita, superb! I think we are going to get there on time :)13:07
mandelgatox, nessita, ralsina simple review of the collection of reviews coming today: https://code.launchpad.net/~mandel/ubuntu-sso-client/support-user-name-url/+merge/9246713:33
gatoxmandel, on it13:34
nessitamandel: ack13:34
nessitamandel: I would advice having one alecu's review on each one of this13:34
mandelnessita, ack13:34
nessitamandel: I would also advice one mine, and one alecu's13:34
nessitamandel: you think that may complicate the schedule?13:34
mandelnessita, no, if we do it correctly :)13:35
mandelnessita, we can always work around that, not a big deal13:35
nessitamandel: ok, I will try to be as responsive as possible with this13:35
mandelnessita, ralsina I think I have one more extra hour to finish the connection between the webclient implementations and the dialog (that means using spawn_process and writing tests)13:35
nessitamandel: so, is it ok if gatox keeps working on his huge refactor and me and alecu do the review?13:36
mandelnessita, ralsina I'll do after lunch (going now) and then will have the entire afternoon to fix the code according to the reviews, that gives me 3/4 hours just for this13:36
mandelnessita, certainly, we can keep gatox busy with other stuff, as long as I have the reviewers I'm happy13:36
nessitamandel: ack13:37
mandelnessita, FYI the pipeline is as follows: support-user-name-url13:37
mandel   creds-dialog13:37
mandel   keyring-integration13:37
mandel   creds-dialog-script13:37
mandel   load-creds-retry13:37
mandel*  webclient-use-dialog13:37
nessitamandel: where is support-user-name-url there?13:37
mandelnessita, paste fail, is the first :)13:38
mandelnessita, after follow:13:38
mandelnessita, each of them is small, so it should not burn you brain out, all merges add appropiate tests so they can be merged without screwing up trunk13:39
mandelok, super quick lunch for me so that we land this guy today :)13:39
* mandel lunch13:39
dobeywow. twinview on linux is apparently horribly broken :-/13:54
dobeyhola ralsina14:00
ralsinagotta reboot, brb14:09
dobeyi am running a python script under gdb and it's crashing inside an assembly file in libc; anyone have any clues how to get some deeper debug info about the assembly? :)14:20
gatoxdobey, strace?14:22
dobeyhrmm, maybe14:24
dobeybut probably not14:24
=== dduffey_afk is now known as dduffey
dobeyalecu: can you send me a direct message on twitter real quick to test gwibber with?14:31
nessitacrowd, ralsina says he computer will not boot14:40
nessitahe's fixing14:40
alecudobey, sent.14:44
* mandel back14:44
* alecu is otp14:45
mandelalecu, ping14:47
alecumandel, pong14:48
nessitadobey: is it working? :-)14:48
mandelalecu, got a question in the _on_authenticate method on the libsoup implementation, what does the try mean?14:49
dobeynessita: not quite yet. seems to not be refreshing14:49
nessitaboo :-/14:49
ralsinaAnd back, it was just a 40 minutes fsck14:49
nessitaralsina: yeey! k=just in time for a lovely branch14:50
ralsinanessita: hit me!14:50
nessitaralsina: ^14:51
ralsinanessita: on it!14:51
alecumandel, hhmmmm14:51
alecumandel, looking14:51
mandelalecu, got it: http://developer.gnome.org/libsoup/stable/SoupSession.html#SoupSession-authenticate14:52
mandelalecu, and it means what I want it to mean :)14:52
alecumandel, oh, you mean "retrying", not "try"14:52
mandelalecu, sorry..14:53
alecumandel, as per your question, I was looking for a "try... except"14:53
mandelalecu, jesus.. I'm stupid14:53
mandelalecu, understandable14:53
alecumandel, keep praying, he may fix that.14:53
mandelalecu, so, I'm close to be done with the dialog, I just have an issue with it, the proxy creds are being saved as '%(appname)s porxy creds for %(domain)s' do you think that is correct?14:54
mandelalecu, or should I just go for the domain and ignore the app_name that was used to access sso?14:55
mandelalecu, I'm considering just having the domain since the app name adds nothing useful14:55
nessitamandel: you can use the app_name if you want proxy credentials by app14:55
alecumandel, how do other applications name them?14:55
nessitaif you want them to be "global", we should drop the app_name14:56
alecumandel, chrome at least saves them in the keyring, right?14:56
mandelnessita, alecu I think global seems reasonable14:56
alecumandel, both "global" and "compatible with other apps" is reasonable :-)14:56
mandelalecu, chrome does not, empiphany browser does, but in a very ugly way14:56
ralsinalaunchpad is painfully slow today. I suppose it's to be expected14:57
alecumandel, also: this sounds like something fixable on a bug, so don't worry too much right now.14:57
mandelalecu, nessita yeah, I was going to say exactly the same, we send the feature, add a bug if the creds name is wrong14:57
mandelmakes sense, right?14:57
alecumandel, dobey, ralsina, gatox: stdup?15:01
ralsiname (no notes)15:02
dobeyoh meh15:02
nessitadobey: meh?15:02
nessitaDONE: weekly call, micro sprint with gatox, debugged execute-ui branch, proposed a couple of priori fixes for that, FF talk with dobey and joshua, used some alecu's brian cycle that were excellent15:02
nessitaTODO: Have execuet-ui working (IS ALMOST THERE), propose the branch and have some rest15:02
nessitaBLOCKED: nopes15:02
nessitaNEXT: alecu15:02
alecuDONE: worked on a branch for bug #92920715:02
alecuTODO: reviews as needed, more work on bug above15:02
alecuBLOCKED: no15:02
alecuNEXT: briancurtin15:02
ubot4`Launchpad bug 929207 in ubuntuone-client "Proxy "tunnel" for syncdaemon (affects: 1) (heat: 6)" [High,Confirmed] https://launchpad.net/bugs/92920715:02
dobeyi was hacking15:02
briancurtinDONE: fighting through tests, updated merge proposal, more fighting with tests to be sure i gave roberto the right branches15:02
briancurtinTODO: fight through more tests, try to isolate why this is killing everything, try to come to some determination on bug #82035015:02
briancurtinBLOCKED: none15:02
briancurtinNEXT: mandel15:02
ubot4`Launchpad bug 820350 in ubuntuone-client "WIndows: either set_dir_readwrite and/or set_dir_readonly are not doing what they should (affects: 1) (heat: 7)" [High,In progress] https://launchpad.net/bugs/82035015:02
mandelDONE: Gone through the entire code of the dialog for creds, got to the point where the only last bit necesary is the connection with the webclients15:02
mandelTODO: connect the webclients, propose all the diff parts of the pipeline and fix accordingly.15:02
mandelBLOCKED: no15:03
mandelnext, gatox15:03
gatoxA huge refactoring in SSO, fixed u1-client-network-detect branch15:03
gatoxFinish with more refactoring in SSO, adding signals to the pages to avoid the pages to know about the wizard15:03
gatoxralsina, go15:03
ralsinaDONE: weekly call, thought a lot (hey, it takes time), reviews, misc. TODO: reviews, think a bit more, finish setting up better Windows VM, P VM, BLOCKED: no15:03
nessitabriancurtin: wanna pause what you're working on and move to another branch, until next week where I can put some time in helping you?15:03
nessitabriancurtin: to another bug*, I meant15:03
briancurtinnessita: yeah i can do that15:04
dobeyλ DONE: team call, nightlies fixes, gwibber poking15:04
dobeyλ TODO: finish gwibber pokery, twisted docs, move more code around15:04
dobeyλ BLCK: none.15:04
nessitabriancurtin: I know the frustration feeling and is not nice :-)15:04
nessitabriancurtin: and sometimes syncdaemon tests have some dark corners15:04
nessitaany comments anyone?15:04
alecucomments: nessita, mandel: do you guys need reviews?15:04
mandelalecu, I have noticed that we are using http://developer.qt.nokia.com/doc/qt-4.8/qnetworkaccessmanager.html#authenticationRequired instead of http://developer.qt.nokia.com/doc/qt-4.8/qnetworkaccessmanager.html#proxyAuthenticationRequired in the qt implementation, that looks like a bug, right?15:05
mandelalecu, yes, let me get you one15:05
nessitaalecu: I will before going to lunch. THE LAST BRANCH to complete the spawnning thing!15:05
mandelalecu, https://code.launchpad.net/~mandel/ubuntu-sso-client/support-user-name-url/+merge/9246715:05
nessitaall: in theory, I will not be working on Monday, but due to FF, I will pass by to see how everything is going. Or perhaps I just swap that day to another day, need to change some scheduls15:06
alecumandel, it's not a bug. It's you looking at your belly button!15:06
mandelalecu, why?15:06
mandelalecu, nada, olvidate, soy tonto15:07
mandelalecu, I'm just going to fast..15:07
alecumandel, I think we'll end up using both.15:08
mandelalecu, by what i read very very quickly, you get the first the proxy and from that point on the other15:08
alecumandel, since we may need the first one to authenticate against the destination server, and the second one to authenticate to the local proxy.15:08
alecumandel, right, in the order you just said.15:09
ralsinanessita: not important, don't change it, but I so much prefer if things like failed_to_start = process_error == process.FailedToStart have () arount the right-side of the assignment15:20
nessitaralsina: can change that :-)15:21
nessitaI agree15:21
ralsinanessita: cool, thx15:21
ralsinanessita: +1 anyway15:22
alecumandel, needsfixing15:23
* gatox lunch15:25
nessitagatox: you have 10 minutes for a review?15:25
nessitaooops too late :-D15:25
nessitagatox: go go, have lunch15:25
gatoxnessita, ok..... when i get back15:25
=== gatox is now known as gatox_lunch
nessitaanyone looking forward to do a review?15:36
nessitadobey: you up for one? is been a long time (?)15:36
dobeyis it 5 lines?15:39
nessitadobey: +45/-415:39
nessitayou will like it, it has some gi in it (?)15:40
dobeyby like, you mean hate?15:41
nessitait depends :-P like and hate are too subjective feelings15:41
dobeymy feelings toward gi do not tend toward the 'like' end of the spectrum :)15:43
dobeyespecially at the moment while i'm trying to port gwibber15:43
nessitadobey: well, if you feel inspired, it has some qt and some tiny gi, https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/dont-let-it-go/+merge/9248515:45
nessitaif not, I will seek reviews after lunch15:45
nessitaand now... lunchtime!15:45
dobeynessita: did your spawning code get fixed and land already then?15:46
nessitadobey: is ready to land today, I'm proposing branches "de a poquito" (little by little(15:47
nessitabig one is https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-that-ui/+merge/92496, but I'll IRL test it a bit longer before ping for review15:48
mandelalecu, on it16:00
briancurtinha, i just got an email at my personal mail that i didn't get the Software Engineer (client applications Mac/Windows) position with Canonical16:00
dobeytoo bad for yoU! :)16:04
ralsinabriancurtin: and yet, you will do the job anyway! ;-)16:05
* briancurtin checks bank account to make sure i'm being paid16:06
ralsinabriancurtin: I have been cleaning up the queue :-)16:06
ralsinabriancurtin: you got the Windows/Mac one!16:06
briancurtinhaha yes i remember the two different applications16:06
dobeyman. i am way too tempted to screw with ralsina at the moment :P16:18
ralsinadobey: feel free ;-)16:19
* ralsina is a big teddy bear and doesn't mind16:19
JosssseHello boys and girls. I'm trying to install ubuntuone. After I apt-get the installer, I run it and when I click on the "I already have an account!" link it does nothing. I see no "connect to ubuntu" window. Any ideas?16:24
JosssseI'm using xubuntu 11.10.16:25
ralsinaJosssse: version of ubuntuone-client?16:25
JosssseThe funny this is that i did it simulatniously on my laptop and it worked.16:25
Josssseralsina, 2.0.016:26
ralsinaJosssse: 2.0.0-0ubuntu2.3 ?16:26
ralsinaduanedesign, rye: maybe you can give a hand to Josssse here?16:27
dobeyJosssse: what pops up in ~/.cache/ubuntuone/log/controlpanel.log when you click that link?16:27
nessitadobey: thanks!!!16:29
Jossssedobey, http://paste.ubuntu.com/836736/16:31
nessitaralsina: you coming to the design talk?16:32
ralsinanessita: am there16:32
nessitayou were faster :-)16:32
mandelalecu, code update, no types + extra tests16:33
alecumandel, looking16:33
Jossssedobey, sorry I didn't paste all the info, this is all the ouput http://paste.ubuntu.com/836739/16:35
dobeyJosssse: so when you click "I already have an account" you don't get a window popping up asking for your username/password?16:36
JosssseThe window just blurs a little darker for a second and then back to normal, dobey16:36
dobeyJosssse: if you run seahorse, there is probably an old token already listed in your keyring. if you remove the old token, then open the control panel again, you should be able to log on16:37
alecunessita, I see that the "sleep 3" in run-tests has landed.16:38
Jossssedobey, What is seahorse, I don't think I have, i'm using xubuntu.16:38
nessitaalecu: I added it, it avoids the g_dbus_foo_errir16:38
nessitaalecu: I was having it in my laptop16:38
alecunessita, just pinging to remind you that it does *not* fix the g_dbus... error.16:38
alecunessita, the g_dbus... error is thrown by the first u1trial, so a sleep there does not fix it.16:39
alecunessita, I tried running the first u1trial, without even the xvfb and it fails too.16:39
JosssseOk, I'm installing seahorse.16:39
dobeyJosssse: the keyring manager application. i don't know if it's installed on xubuntu or not, or if they have a similar app16:40
nessitaalecu: you sure it does not fix it? it "did" for me16:40
nessitaalecu: I know, may be coicidence16:40
nessitaalecu: but I never had the error again (nor tarmac did)16:40
alecunessita, just ran the tests on trunk, on my laptop, and it fails before the reaching the "sleep 3"16:40
dobeynessita: sleep wouldn't fix the dbus error16:40
nessitadobey, alecu: ack, remove it then :-)16:41
dobeynessita: the g_dbus error is something completely different, and i have no idea why it's happening, or how to consistently cause it to happen. :-/16:41
dobeyalecu: are you getting it consistently?16:41
Jossssedobey, It works!!! You're awesome. Thank you very much. I had been struggling with this for a couple hours. Thank you.16:41
dobeyJosssse: no problem. sorry it didn't 'just work' for you. :)16:42
alecudobey, yes, it fails every time I run the whole tests on my laptop. It's *slowish* if that helps.16:42
=== gatox_lunch is now known as gatox
alecudobey, but somehow it does not fail when I run each test file independently16:42
alecuor a few together.16:43
JosssseSweet, now it works which is the important thing. Thanks dobey.16:43
dobeyalecu: hrmm; which test command exactly? (the full u1trial command)16:43
alecudobey, it fails if I run: u1trial --reactor=gi --gui -p "ubuntu_sso/qt/tests" -i "test_windows.py" ubuntu_sso16:44
dobeyalecu: ok. can you run "valgrind -o dbus-error.log u1trial -r gi --gui -p ubuntu_sso/qt/tests -i test_windows.py ubuntu_sso" and put the dbus-error.log up somewhere i can see it when it finishes/fails? :)16:46
gatoxnessita, do you still need a review?16:46
mandelnessita, I have a complete implementation of the dialog for sso, it is enough to do ase setup.py install to do an IRL?16:59
nessitamandel: it depends on your code... not sure what you're asking17:05
nessitagatox: yes, I do, finalizing latest IRL tests17:05
gatoxnessita, can you give me the link?17:06
nessitagatox: sure! https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-that-ui/+merge/9249617:06
mandelnessita, I'd like to test end to end the solution, so I have the bin, which is installed by the setup.py and all the required code, so intheory doin setup.py and killing sso so it is restarted is enough, right?17:06
nessitamandel: I would advice running the service by hand from your branch, with this command:17:06
nessitaU1_DEBUG=True PATH=bin/:$PATH PYTHONPATH=. bin/ubuntu-sso-login17:07
nessitamandel: or, if you want to use the Glib mainloop17:07
nessitaUSE_QT_MAINLOOP=True U1_DEBUG=True PATH=bin/:$PATH PYTHONPATH=. bin/ubuntu-sso-login17:07
nessitamandel: also, the bin should not be installed in /usr/bin, but next to the -gtk and -qt binaries (not sure where you put it)17:08
mandelnessita, I'll double check that17:08
nessitaralsina: could trivial review this https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/install-uniqueapp/+register-merge ?17:13
ralsinanessita: sure!17:13
gatoxwrong link again :P17:13
nessitagatox: fix LP! :-P17:13
nessitaralsina: correct link is https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/install-uniqueapp/+merge/9252417:14
ralsinanessita: looking...17:17
mandelralsina, got a few mins for me and QNetwork?17:18
ralsinamandel: sure!17:19
ralsinamandel: can't speak, but can read :-)17:19
mandelralsina, superb, if you branch lp:~mandel/ubuntu-sso-client/webclient-use-dialog/ you will see in ubuntu_sso/utils/webclient/qtnetwork.py  that I connect to two diff signals, proxyAuthenticationRequired and authenticationRequired17:21
mandelralsina, in the tests then seem to never be fired and therefore I never show the ui17:21
ralsinamandel: branching17:21
ralsinamandel: this is just a test failure?17:21
mandelralsina, yes, the test is test_authenticated_proxy_is_used_creds_requested17:22
ralsinamandel: ok, I'll check, and report back in 10'17:23
alecumandel, I'm rushing to the bank, and I'll finish your review after that.17:23
mandelalecu, ok17:23
alecumandel, I can do the rest in your pipeline, if that's fine with you.17:23
alecumandel, just tell me at what point I should stop.17:23
mandelalecu, I'm going to propose all of the branches that I believe are ready, atm I just have an issue with the qtnetwork one17:24
alecumandel, cool17:25
ralsinathe donkey that powers launchpad branch scans needs an extra carrot today :-(17:26
ralsinanessita: golbal approve on install-unique-app17:30
ralsinanessita: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/dont-let-it-go/+merge/92485 seems to have merged before your inal commit...17:32
ralsinaah, forget that, I misread.17:33
nessitaralsina: it did? looking17:36
ralsinanessita: no, it didn; t17:36
nessitaralsina: fuuuiiiiiuuu17:36
ralsinanessita: I got confused by revnos17:36
mandelralsina, nessita, alecu, gatox, briancurtin reviews b y oder: http://paste.ubuntu.com/836809/ please I prefer reviews from alecu and nessita due to the natrue of the work, so if you are busy, ignore me :)17:36
nessitamandel: ack! did you fix what alecu put in the first one?17:38
mandelnessita, yes17:38
mandelnessita, I'm here for comments on those to fix them asap17:38
ralsinamandel: the signals will not be triggered until you enter the event loop again17:39
mandelralsina, what do you mean?17:40
ralsinamandel: if you connect a slot to a signal, and then emit the signal, that doesn't call the slot until the next time you enter the event loop17:40
ralsinamandel: OTOH, I don't understand this code yet ;-)17:41
mandelralsina, there I'm getting the finished signal BEFORE the auth required ones and therefore get an error on the reply :(17:42
ralsinamandel: if all signals are triggered before you enter the loop, then there is no guarantee on what order they will call the slots17:42
ralsinamandel: want to mumble this?17:42
mandelralsina, yes, lets do it since is the last tiny part I have left17:43
ralsinamandel: ok, I'm there already17:44
dobeyalright, i need to get lunch. bbiab kids17:45
nessitaralsina: when you have some slot, of you could review this: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-that-ui/+merge/92496 (gatox, is the right link ;-)), that's the key-branch for detaching UIs from the sso service17:45
nessitaeveryone: I have one extra, final branch, that I'd need reviews on: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/policy-url/+merge/9254117:51
nessitagatox: you may also be interested in that one ^ ;-)17:51
gatoxnessita, ack17:51
mandelralsina, mumble again?17:54
ralsinamandel: I am still there :-)17:54
duanedesigndobey: what was it that was preventing users from subscribing their Purrchased music folder? Was it that file Sync was disabled?17:56
nessitamandel: added needs info to https://code.launchpad.net/~mandel/ubuntu-sso-client/support-user-name-url/+merge/9246718:01
mandelnessita, ok, on it18:01
mandelnessita, that is exactly why I added test_gsettings_auth_over_url to ensure that the gsettings win, atm I'm not sure which one should be the winner to be honest18:02
nessitamandel: can you please check that with alecu?18:02
nessitamandel: I saw the test, but from the code is hard to tell which one will win18:03
mandeldobey, if gsettings has a username and password diff to the one in user:password@domain, do you have any idea which one should win ?18:03
ralsinanessita: +1 on plicy-url18:03
nessitaok, gotta go to run some errands18:03
nessitaralsina: awesome! thanks. Though policy-url depends on run-that-ui, the most important one (read with time and energy :-))18:03
nessitaralsina: ok, please drop me an email with any news18:03
nessitaI need to head out now18:04
ralsinanessita: yes, I know, that was just a code review18:04
duanedesignbeen getting a lot of tickets  from Windows users the last few days with the error 'WARNING - Please don't run the syncdaemon as root.'18:04
nessitaok, see ya laters!18:04
ralsinaduanedesign: interesting18:04
duanedesigni know U1 is not supposed to be run w/ elevated privelages, it just seems weird to be seeing these all the sudden18:05
ralsinaduanedesign: we added "root detection" to syncdaemon on windows in the latest version18:05
ralsinaduanedesign: are those users on XP by chance?18:05
duanedesigni am not 100 percent, but they seem to be on Windows 718:05
ralsinaduanedesign: ok18:05
mandelralsina, http://paste.ubuntu.com/836858/18:06
ralsinaduanedesign: they should not be getting those since the installer is also supposed to run syncdaemon with downgraded provileges18:06
mandelralsina, X-Squid-Error18:06
duanedesignralsina: the logs do not seem to have much but if you would like to see any of them let me know18:07
* alecu is back, after bank and icecream stops.18:16
gatoxmmmmm icecream :D18:16
ralsinaduanedesign: could you mail me one? I will probably not look at it today, but soonish18:19
alecugatox, crema rusa y frutilla al agua18:20
duanedesignralsina: yes18:20
gatoxalecu, i'm trying to stop eating ice-cream....... and you are not helping jejee18:20
mandelalecu, mumble>?18:20
alecumandel, regarding which setting takes precedence: choose any one of those, make a test for it, and make sure we pass it.18:20
mandelalecu, ha, that is what I already did :)18:21
alecumandel, I think it's a corner case in any way.18:21
alecumandel, if we choose to change it, it's only a bug.18:21
alecumandel, great then.18:21
alecumandel, should I join mumble anyway?18:21
mandelalecu, yes, I have a nice discovery we did with ralsina :)18:21
* alecu loves http error codes. 418 most of all18:27
mandelalecu, lp:~mandel/ubuntu-sso-client/webclient-use-dialog currently test_authenticated_proxy_is_used_creds_requested skipped18:27
mandelalecu, you will have to remove it from the skip at the bottom of the test case, like the one with twisted18:28
mandelnessita, typo fixed and alecu and I decided to leave it as it is with the test and later consider it a bug18:29
alecumandel, I got a different error in the proxy test, I think.18:33
alecumandel, http://pastebin.ubuntu.com/836900/18:33
ralsinamandel, alecu, thisfred: http://www.flickr.com/photos/laserbread/6810063291/18:34
mandelnessita, nessita so I managed to get someone else to walk the dog, so I can stay 1:30 mins more and then I have to go :(18:34
ralsinamandel: nessita is not here, she's on errands18:34
mandelalecu, that is the one, if you do a print error you will see18:34
mandelalecu, also, if you look at the exception we are getting a WebClientError and not a UnauthorizedError18:35
alecumandel, probably that's because we are expecting the Unauthorized error code from the destination server, not from the proxy server18:37
alecu(just guessing)18:37
mandelalecu, annoying detail, proxyAuthenticationRequired and authenticationRequired are not fired..18:38
mandelalecu, I'd hope that at least proxyAuthenticationRequired did :(18:38
alecumandel, right... if proxyAuthenticationRequired is not fired, then proxyAuthenticationRequired will never be.18:39
alecu*if proxyAuthenticationRequired is not fired, then authenticationRequired will never be.18:39
mandelalecu, yep, I guessed why you tried to say, remember I drink a lot, most of my conversations are like that ;)18:39
alecumandel, that would explain your dyslexia too!18:40
alecublame ballmer18:40
duanedesigncan anyone help me answer this users question about running U1  as admin on Windows. https://pastebin.canonical.com/59969/18:41
mandelduanedesign, AFAIK we support AD users, I have played with it18:42
mandelduanedesign, that will proably use his home dir as $username.domain, for example I have an mandel.marvel18:43
mandelduanedesign, and although the app will work the installer wont, that is, the installer has to be ran as a normal user because we have a limitation when we use the runas command as a domain user18:44
mandelduanedesign, I think he might be able to run the birtock installer but as soon as he tries to do the wizard it will block18:46
mandelduanedesign, the evil code is in ubuntuone_installer/gui/qt/utils/windows.py18:46
mandelduanedesign, anything with a runas there won't work, you can ask him to try and execute the commands manually.. it might work18:47
mandelalecu, shall we go review by review to land as much as possible?18:47
mandelalecu, can you re-review https://code.launchpad.net/~mandel/ubuntu-sso-client/support-user-name-url/+merge/9246718:48
alecumandel, I'm debugging the qt issue. should I review instead?18:48
mandelalecu, lets review as much as possible, that way we land 75% of the feature and we can leave the rest as a bug :)18:49
mandelalecu, well kind of hehe18:49
mandelalecu, I don't think we will make that qt fix for today..18:49
thisfredralsina: heheh18:49
alecumandel, I think I found the bug :-)18:52
alecumandel, give me one more minute18:52
mandelalecu, oh!!! cojonudo!18:52
alecumandel, I know. That's why I buy oversized calzoncillos.18:52
mandelalecu, I was talking about the fact, not you ;)18:53
alecumandel, here's your 105: QNetworkReply::ProxyAuthenticationRequiredError18:53
alecumandel, it's not squid that's replying that: it's qt's error scheme.18:53
mandelalecu, ralsina this? https://bugreports.qt-project.org/browse/QTBUG-1999018:54
alecumandel, http://doc.qt.nokia.com/4.7-snapshot/qnetworkreply.html#NetworkError-enum18:54
ralsinamandel: ahá!18:54
alecumandel, so: QNetworkReply.error() needs to be checked against that table.18:54
mandelalecu, ralsina so, there is a bug in qt about it.. which means, we do a work around and do a error num check and do the retry the same way I did in the twisted test cases webclient18:55
alecumandel, if you want the HTTP status code: QNetworkReply.attribute(QNetworkRequest.HttpStatusCodeAttribute)18:55
alecumandel, it's not a bug18:55
ralsinamandel: not a bug, just a bit harder18:56
* mandel stops saying 'puto squid' and starts to 'puto qt'18:56
alecuor maybe it is...18:56
mandelalecu, ralsina so those bloody proxyAuthSignals are just there to play with my feelings.. how rude!18:57
alecumandel, they are probably broken... but don't worry about it, we can work around with what you've found.18:58
dobeymandel: whatever is in the keyring is what should win :)18:58
dobeyduanedesign: no sure, i guess a number of things could cause it, including disabled file sync18:58
mandelneed to go 5 min18:59
dobeynessita: why are most of your merge requests ending up in my spam folder?18:59
ralsinadobey: nessita is away18:59
dobeyit's not an urgent matter :P19:00
* mandel back19:11
alecumandel, "autheticated" -> "authenticated"19:16
mandelalecu, I hate being this dyslexic..19:17
mandelI have tos tart using an spellchecker on vim19:17
alecumandel, other than that, I'm running tests to approve.19:17
alecumandel, approved first branch19:23
mandelalecu, sweet, let me pass you the next one19:23
alecumandel, got it here: http://paste.ubuntu.com/836809/19:24
mandelalecu, cool, the next nearly has not code at all, is just the xml and some settings for labels + the tests to ensure they are set19:24
briancurtinmandel  - ":set spell"/":set nospell" works alright for me19:25
mandelbriancurtin, cool, I did not know that foo :)19:26
duanedesignwindows user seeing files getting deleted and has this error in his logs? https://pastebin.canonical.com/59980/19:34
ralsinaduanedesign: new bug!19:35
mandelduanedesign, I've never seen that...19:36
duanedesignralsina: you want me to file a bug?19:36
ralsinaduanedesign: yes please19:36
mandelduanedesign, is that the domain username guy?19:36
ralsinaduanedesign: assign to briancurtin :-)19:36
duanedesignno different one :)19:36
duanedesignsilly question. What is the package for windows bugs?19:37
briancurtinduanedesign: my name on launchpad is brian.curtin if you want to assign to me19:37
mandelduanedesign, that is for the ubuntuone-client19:39
duanedesignok, any special tags you want?19:39
ralsinaduanedesign: tag it as u1-windows, while you are there19:39
mandelduanedesign, anything related to an installation where sd works yet has bugs goes there, or in ase of a doubt add brian and me to the bug and we decide19:39
mandelduanedesign, I like the 'saaaaaaaay what?' tag, but ralsina ones sounds better19:40
mandelralsina, any idea of how to get the QAuthenticator for a QNetworkAccessManage or a QNetworkReply?19:45
alecumandel, in the third branch: this file only changes in an EOL added to the end of it: ubuntu_sso/qt/gui.py19:46
ralsinamandel: let me check the docs19:46
mandelalecu, let me check19:46
mandelalecu, yes, pep819:46
mandelor am I wrong?19:47
ralsinamandel: looks like you cannot19:47
ralsinamandel: so you will have to make it global or something like that19:47
alecumandel, maybe. It looked weird because the file didn't seem to change, but the diff showed an extra line at the bottom.19:48
ralsinamandel: BUT you get it as argument in the authenticationRequired signal19:48
mandelalecu, you mean removed, right?19:48
mandelralsina, yes, true..19:48
alecumandel, removed, yes. You are right, and it's fine.19:49
mandelralsina, exactly, so how am I suppose to emit that signal..19:51
ralsinamandel: right, that is the signal we are not getting19:51
alecumandel, "cancle" -> "cancel"19:52
mandelalecu, soy estupido!19:52
alecuit would be interesting to have a spellchecker for code that understands CamelCase and under_scores19:53
mandelalecu, certainly.. at least for me19:54
alecumandel, if we could add this to meld, it would make my reviews easier too :-)19:54
alecumandel, so, still on branch 3:19:56
alecumandel, ProxyCredsDialog takes a parameter named "domain"19:56
alecumandel, but it's not used yet (I suspect an upcoming branch)19:56
alecumandel, question is: what does that string looks like?19:57
alecumandel, and... will it be translated?19:57
alecumandel, because that's the string that goes into the keyring as name, right?19:57
mandelalecu, look at the line 63 of the lp diff19:57
mandelalecu, would be the name of the proxy host.. so in my case ad.marvel for example19:58
mandelalecu, it will be passed by the webclient so that it lets the user know the host of the proxy he is connecting to and used for the keyring19:58
mandelalecu, _on_save_clicked is where we used it for that19:59
alecumandel, that part looks clear20:00
ralsinamandel: why do you need the QAuthenticator exactly?20:01
alecumandel, it's the way it's stored in the keyring I don't like20:01
alecuralsina, probably to set the user and password after the proxy returns an error.20:01
mandelralsina, ^20:01
ralsinaalecu: you set those in QNetworkProxy20:01
mandelalecu, whats up with it?20:01
ralsinamandel: ^20:01
mandelralsina, yeah,that was my second idea :)20:01
ralsinamandel: good, becuase it's the right one ;-)20:02
mandelalecu, I just have a few more mins.. is 21:00 here :(20:02
alecuralsina, usual sequence: try without password, it fails, try with password. If it fails, ask for newer passwords.20:02
alecumandel, ack20:02
ralsinamandel: and you can get the QNetworkProxy from QNetworkAccessManager.proxy()20:03
alecumandel, so... set_credentials will set the key-type to "Ubuntu SSO credentials", and the token_name to something including the current computer name and the app_name you've passed20:03
ralsinamandel: and the access manager you can get from the reply20:04
alecumandel, so, I think we should refactor ubuntu_sso/keyring/linux.py and windows.py so they allow you to pass some other stuff for all that20:04
mandelalecu, seems reasonable, atm is doing: token-name: @ ironman20:04
mandelkey-type: Ubuntu SSO credentials20:04
mandelalecu, and the name of the key will be the domain20:04
alecumandel, we'll probably need to fix that. Let's open a bug and fix laters.20:06
mandelalecu, +120:06
mandelalecu, would also be nice to get tx-secrets and the windows impl out and create a keyring lib that is async20:06
mandelalecu, pykeyring has lots of bugs..20:06
alecumandel, I'm approving and creating a new bug for that.20:08
alecumandel, I'll keep reviewing, enjoy your weekend!20:08
mandelalecu, I managed to get 10 more mins, just called the date saying I was late a little :P20:08
alecumandel, go away!20:09
mandelalecu, next simply adds a bin to get the creds dialog, is kinda simple20:09
mandelalecu, I'm actually quite proud of how I managed to get the pipeline so well divided.. :)20:09
alecumandel, :-)20:10
alecumandel, perhaps we need somebody else to review all those branches too?20:10
alecumandel, or get permission from ralsina to land'em with just one review ;-)20:10
mandelalecu, yes, nessita said she would take a look, or maybe ralsina or gatox20:10
ralsinamandel: remind me of URLs20:11
alecuralsina, http://paste.ubuntu.com/836809/20:11
* ralsina has been running like a beheaded chicken all day20:11
alecuralsina, I've already approved the first three20:11
ralsinaalecu: ok, I'll try to get those three before I EOD20:11
alecuralsina, like, spurting blood from your neck?20:11
mandelralsina, http://paste.ubuntu.com/836809/20:11
ralsinaalecu: like, mindlessly20:11
briancurtinmandel: do these branches require any deep understanding that i might not have yet, or would i be ok to review?20:12
mandelbriancurtin, I think you are perfectly ok, some of them are simple qt stuff, the last one is the 'hard' one and is not proposed yet :)20:13
briancurtinmandel: i'll take a look20:13
alecumandel, what does this mean? # HACK: At the moment we need to do that until sso is refactored20:14
mandelalecu, you cannot correctly import the ui from qt unless you set that env var because the controls import the wrong main otherwise20:14
mandelalecu, I though HACK was more appropriate, gatox is working on that20:15
alecumandel, great then.20:16
gatoxmandel, i finishing with the test in the last refactor20:16
ralsinathere is nothing in the stdlib that parses user:password???20:16
alecumandel, "Parse sys.arge options" -> "Parse sys.argentinos options"20:16
mandelalecu, hahaha20:16
alecuralsina, you mean "[user[:password]@]hostname" ?20:17
ralsinaalecu: yes20:17
alecuralsina, I didn't look, but probably urlparse may do something useful with that. But it's not really a url, so that code made sense.20:17
ralsinaalecu: ok20:18
ralsinaalecu: and no it doesn't (claims to do  but fails)20:18
mandelralsina, we talk about that, I wanted to have two problems :)20:18
alecumandel, "the domian whose" -> "the domain whose"20:18
dobeyi should try to write some magic test stuff that will pipe string literals and docstrings through aspell20:19
mandelalecu, sorted out both20:19
mandeldobey, that would be really really useful with me20:19
alecumandel, " we are retying" -> " we are retrying"20:19
dobeyi know :)20:19
mandelI should not be allowed to use a keyboard..20:20
alecudobey, and then scattered all around our code we'll have "# aspell: ignore=W0666"20:20
mandelI could sign my code as 'dictated but never read'20:20
dobeyalecu: nope20:20
ralsinaWe should create our fake qt stuff for tests somewhere and share it accross projects20:23
dobeyalecu: i'd make it strip out URLs and validate them separately; and generally be simple and smart, completely unlike pylint20:23
mandelralsina, from FakeQt4.QtGui import QLabel20:25
mandelralsina, is not that as mad as mocker in a way?20:25
dobeygrammar checking would be nice too, but is a lot harder to do20:25
ralsinamandel: nope20:25
ralsinamandel: right now we probably have 12 different fakewidgets somewhere20:25
* dobey goes to make a really big change real quick20:25
ralsinadobey: getting married in Vegas? :-D20:27
dobeythough i would love to have the technology to get from here to vegas, really quickly :)20:28
dobeyi would a) be insanely rich b) on my way to kepler 22-b already20:28
alecumandel, bug #93038520:29
ubot4`Launchpad bug 930385 in ubuntu-sso-client "Proxy credentials in the keyring have wrong attributes (affects: 1) (heat: 6)" [Low,Confirmed] https://launchpad.net/bugs/93038520:29
mandelalecu, thx!20:29
dobeyhmm, i guess i will have to rewrite this code in vala later though. i am sad i wasn't able to get to that this cycle20:30
ralsinadobey: gwibber progress?20:30
mandelalecu, ralsina unfortunately I have to go, no matter how nice you are I've got a date and don't want to miss it.. is not that you meet lots of people working from home ;)20:30
ralsinamandel: go then!20:30
ralsinamandel: say we said hi!20:31
mandelralsina, do we believe that we 'nearly' landed the feature and we just have bugs left?20:31
ralsinamandel: let's reconsider on monday20:31
mandelralsina, I'm sure I can find a bug for each branch left :P20:31
dobeyralsina: yep. i just want to get this code moving done today, as it's fairly simple, and needs to be done by ff. hitting another issue with the keyring gir which i'll be poking at again soon, but i needed to do something else for a bit today, and need to get this done :)20:32
ralsinadobey: cool20:32
alecumandel, go away, have fun.20:35
mandelralsina, alecu I go, but give me the +1!20:35
mandelralsina, alecu I'll say hi :)20:35
ralsinaalecu: since mandel is leaving... I am reviewing https://code.launchpad.net/~mandel/ubuntu-sso-client/keyring-integration/+merge/9253220:35
ralsinaAnd username = str(self.ui.username_entry.text()) is a BAD idea20:36
mandelralsina, why?20:36
ralsinaalecu: that means if I type a unicode character there, it will crash with unicodedecodeerror20:36
mandelralsina, ah.. cure, fixing20:36
mandelralsina, using unicode is enough, right?20:38
ralsinamandel: well, that will get you unicode :-)20:38
ralsinamandel: I don't know what you have to pass to the next consumer20:38
mandelralsina, which is what we want, no?20:38
ralsinamandel: I dn't know. What does keyring take?20:38
ralsinaI am guessing unicode, but I am not sure20:39
mandelralsina, secret = urllib.urlencode(cred)20:39
alecuralsina, yup, that str( is way out of place. Bad hurried review, alecu.20:39
ralsinamandel: then unicode sounds right20:40
mandelalecu, same as the code, I did not think about it..20:40
alecumandel, ralsina: I'm tempted on marking this as a bug and moving the branches forward.20:40
mandelralsina, updated pushed and leaving for good20:40
mandelhave a great weekend!20:40
ralsinamandel: urlencode doesn't take unicode20:40
mandelralsina, then keyring is broken on sso too :)20:41
ralsinaso, it's tricky ;-)20:41
mandelralsina, since we do the same in the gtk and the sso views there.. nice catch!20:41
ralsinabye mandel20:41
* mandel walks away20:41
alecumandel, ralsina: we should discuss better on monday20:41
alecubye mandel20:41
briancurtinhave a good weekend mandel20:42
dobeyralsina: well, i just successfully added a statusnet account with gtk3 gwibber-accounts. and it downloaded the new data; so at least that much is working in my gwibber branch now :)20:46
ralsinadobey: awesome!20:46
* ralsina says ship it! ;-)20:46
ralsinaship it good!20:46
dobeyyeah, i think by tuesday i'll have it shippable for sure20:47
ralsinadobey: excellent news20:48
ralsinaI should send you a Hannibal Smith cigar20:48
alecuralsina loves it when a plan comes together20:49
ralsinatoo bad I don't smoke20:49
alecuwho needs more vices, eh?20:50
alecumandel, even though you are gone, 4th branch approved.20:50
ralsinayeah... I still have.... or maybe .... okWhile the authorities proudly showed off the seizure to local reporters, the sheer size of the find set off alarm among experts and officials from the United States and the United Nations. It was a sign, they said, of just how organized, efficient at manufacturing and brazen Mexico’s traffickers had become even after expanded efforts to dismantle their industry.20:50
ralsinathat was oneweird paste20:51
ralsinasince I am nowherenearany key that may cause that20:51
ralsinastrangely appropiate though!20:51
joshuahooverralsina: fyi...i filed bug #930398 for the windows "please don't run syncdaemon as root" thing20:54
ubot4`Launchpad bug 930398 in ubuntuone-client "SyncDaemon - WARNING - Please don't run the syncdaemon as root (affects: 1) (heat: 6)" [High,Confirmed] https://launchpad.net/bugs/93039820:54
ralsinajoshuahoover: cool thanks20:54
ralsinajoshuahoover: no idea what that is, but weĺlfigureit out20:54
ralsinaI mean, I know what it is, I don't yet know why it happens :-)20:55
joshuahooverralsina: i noted in the bug description that we had a similar error occuring a while back but i'm not sure if it's at all related or not20:56
ralsinajoshuahoover: looking...20:56
dobeygoodbye libsyncdaemon20:57
ralsinawell, that one was fixed. I am leaning more towards our "root detection" being broken on windows20:57
* ralsina wonders who was the amateur who did THAT! (oh right, ralsina did)20:57
ralsinathe fool!20:57
joshuahooverthere was this wise man who recently wrote, "Why oh why do I have this talent to write crappy code that works? If my crappy code didn't work, I would be a better programmer."20:59
alecuralsina, some touchpads use the right upper corner as the middle button... could that be the reason for the paste?21:02
alecu(so it was not really a paste but a "insert X selection")21:03
ralsinaalecu: indeed21:05
ralsinaalecu: I didn't copy that, I just selected it. Bad habit21:05
alecuralsina, it's like pointing with your finger while reading, right? :-)21:05
ralsinajoshuahoover: indeed a wise man21:05
ralsinaalecu: yeah :-)21:05
ralsinajoshuahoover: here he is in the simpsons, according to another guy in twitter: http://t.co/8piVqPoi21:06
gatoxralsina, mandel alecu dobey briancurtin nessita ok.... i finish with the refactor!! i have time for 1 or 2 reviews if someone need something21:12
ralsinagatox: did yo get reviews on your monter branch or is it still missing one?21:12
gatoxralsina, if you didn't review it..... it still miss one :P21:13
gatoxralsina, it was a lot.... but it was necessary :D21:13
ralsinagatox: I'll take a good look later. Now I have to go parenting21:20
gatoxralsina, ok! thanks!21:21
ralsinabye ppl! See you all on monday or so!21:21
gatoxralsina, bye21:22
gatoxok, EOD for me then! see you on monday21:25
* dobey is rapidly losing potential reviewers as .ar falls off the net21:29
briancurtini think nessita was coming back later, so maybe .ar will rise again. i'm also around for another hour+21:32
dobeyhrmm, maybe i won't be able to get this done today :(21:39
dobeysince i actually need to make 3 branches to do it. and update nightlies packaging21:41
alecubye all, this is my official EOW21:52
dobeymeh, gtk3 is really annoying me22:10
=== dduffey is now known as dduffey_afk
dobeylater all22:57
nessitahello again!23:16
nessitaI had an internet outage23:16
nessitaok, no emails, which is great23:22
nessitaI'm off then23:22

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!