[00:01] eod as well === gatox_tv is now known as gatox === gatox is now known as gatox_away [04:08] EODs, bye bye o/ === dduffey is now known as dduffey_afk === yofel_ is now known as yofel === zumbi_ is now known as Guest94149 === statik is now known as 64MAAQOA7 [09:24] morniing! [09:25] scarleo, I can give you a hand, but let me reboot first.. some updates need it :( [09:25] mandel, ok thanks [09:25] scarleo, np [09:25] * mandel reboots [09:33] scarleo, I'm back! [09:33] great! [09:33] scarleo, so which os are you running? [09:33] Ubuntu 11.10 [09:34] scarleo, and the probelm is that there are some images that are not syncing, is that correct? [09:34] yes, they never get the green tick in Nautilus [09:35] most sync but I have maybe 5 that doesn't [09:35] scarleo, hm.. interesting, are there any app that are using the images? [09:35] mandel, nope [09:35] scarleo, on linux we wait until you close the file so that we update the correct version.. [09:35] and they've been on the pc for quite some time [09:36] scarleo, ok, are they in ~/Ubuntu One or in a UDF, for example ~/Images [09:36] thay are in ~/Pictures/webbilder and Pictures is the folder I've set to sync === gord_ is now known as gord [09:37] scarleo, lets first see if it is indeed there, just in case :) [09:37] scarleo, run u1sdtool --list-folders [09:38] scarleo, and u1sdtool --status will also be useful [09:39] mandel, http://pastie.org/3353566 [09:39] * mandel looks [09:40] scarleo, if you do u1sdtool --info=PATH where PATH is one of the images, what do you get? [09:41] mandel, http://pastie.org/3353584 [09:43] scarleo, and u1sdtool --waiting-content ? [09:43] scarleo, I'm trying to find out in what state are those files.. [09:44] --waiting-content gives Deprecated, use --waiting. --waiting gives no output [09:45] scarleo, hm.. funny, let me see if one of the QA is there, but nothing seems to be bad with those files [09:45] mandel, I can see them when I log in to one.ubuntu.com [09:46] scarleo, have you check the web ui, are the files there? [09:46] :) [09:46] yes [09:46] scarleo, oh, so they where uploaded yest nautilues gives the wrong icon [09:46] mandel, yep [09:46] scarleo, I think that is a bug in the nautilus plugin then... :( [09:47] ok [09:47] scarleo, the developer that takes care of that is based in the USA, do you find filing a bug with all what we have looked at and explain that the files are ok in the web [09:47] also every time I login to my desktop U1 tells me it is syncing one image but it's already synced [09:47] scarleo, I'm sure we will take a look at that asap [09:47] ok, I will [09:47] scarleo, I think there was a bug with the notifications where it had 'memory' [09:48] ok [09:48] scarleo, AFAIK we are working on that, but we have been looking at porting to other platforms lately and have not had the time, sorry for the PITA [09:48] mandel, no problem [09:49] scarleo, also, add the logs and set the bug to private, we will make it public if there is nothing that could compromise your account or details about you [09:49] scarleo, better safe than sorry [09:50] mandel, which log and where is it? === zumbi is now known as Guest47393 [09:50] scarleo, let me check [09:51] ok [09:53] scarleo, should be here: .cache/ubuntuone/log [09:54] ah, mornings [09:54] mandel, ok, filing a bug report then [09:54] scarleo, thx, we really appreciate that! [09:55] np [09:55] scarleo, also, if you are here a little longer we can ask rye, he may know :) [09:55] rye, do you have back logs? [09:55] yeah I've got time [09:56] mandel, yes, i have them, looking [09:56] rye, thx! [09:57] scarleo, I leave you with rye he is great at finding problems like this [09:57] mandel, is it the syncdaemon log I should provide from .cache/ubuntuone/log [09:57] mandel, ok [09:57] Hi rye [09:57] * mandel goes back to be a code monkey [09:58] scarleo, re: already synced images - it is a bug in client display code [09:59] scarleo, reading further... [09:59] scarleo, what system are you now on? [09:59] Hmmm, the file always telling me it's uploaded every time I log in is in syncdaemon-exceptions.log [09:59] rye, Ubuntu 11.10 [10:00] h, launchpad down? [10:03] scarleo, the first is bug #807005 - what ubuntuone-client do you have - apt-cache policy ubuntuone-client and see the Installed version [10:03] Launchpad bug 807005 in ubuntuone-client (Ubuntu Precise) (and 7 other projects) "Filename in notification does not reset. (affects: 9) (dups: 3) (heat: 38)" [Undecided,Fix released] https://launchpad.net/bugs/807005 [10:04] rye, 2.0.0-0ubuntu2.3 [10:04] interesting [10:05] scarleo, ok, could you please download the script form http://people.canonical.com/~roman.yepishev/us/u1filestatus.py and run it in the terminal [10:05] rye, can I paste the syndaemon-exceptions.log ? The file that is noticing is in there but it contains some id's and stuff. Is it safe? It's to a shared folder [10:05] scarleo, it will show what files are not synced [10:06] ok, I'll download it [10:06] scarleo, download and run it as "python u1filestatus.py" [10:07] rye, http://pastie.org/3353677 [10:08] scarleo, hm, where are the files that are not synced located? [10:08] rye, they are synced, I can see them in web UI, they do not get the green tick in Nautilus. The files affected are in ~/Pictures/webbilder [10:09] scarleo, ok, this looks like the emblem issue, are other files marked as synced? [10:10] rye, yes, it's about 5 .png and one .gif that doesnt get the emblem [10:17] rye, so emblem issue is known? [10:23] scarleo, well, this part does not have extensive test coverage, I am booting my virtual machine with oneiric to see how it works now [10:27] Oh, and good morning, world! Happy Friday! :) [10:28] meh, you people changed API for u1sdtool 3 times, the 3rd time breaks my u1filestatus in precise. boo, [10:28] oh, i know, i just propose it for merging :) [10:53] hi! [11:10] gatox, morning! [11:11] mandel, buenas [11:11] gatox, in a few mins I'll have lots of reviews to be done trying to land a feature today, mind if I bother you with the later? [11:11] mandel, no problem!! [11:12] gatox, great, is an good amount of code, but is just lots of branches very small [11:17] buenos días! [11:18] nessita, buenas [11:19] hola gatox, how is it going? [11:19] will review now! [11:19] nessita, fine..... finishing with u1-client-network-detect [11:20] nessita, good morning, I did a code review for https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/move-ping/+merge/92378 and looks great [11:20] nessita, let me run the tests and I'll approave, I completely forgot to do that [11:22] mandel: awesome!!! [11:26] gatox: oh, a branch of mine yesterday landed and your branch has one conflict (should be easy to fix: [11:26] Text conflict in ubuntu_sso/utils/ui.py [11:26] 1 conflicts encountered.) [11:26] nessita, ok..... fixing that right now [11:29] nessita, fixed [11:29] gatox: thanks! [11:40] gatox, what is orange and sounds like a parrot? [11:40] mandel, carrot [11:40] i read your twits [11:40] jejeje [11:40] gatox, heheh [11:40] mandel, i abstain to do any comment about that REALLY BAD JOKE! [11:40] jeejej [11:41] is not THAT bad hehe [11:43] gatox: APPROVED [11:43] nessita, just like that?! [11:43] jejeje [11:43] YEAH [11:43] AWESOME! [11:43] :-) [11:44] ralsina_: hola! would you be around? [11:46] nessita, FYI +1 on https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/move-ping/+merge/92378 [11:46] yey! [11:46] mandel: thanks [11:59] nessita: yes, here I am [11:59] mandel: what's brown and sticky? [11:59] ralsina_, I should know... [11:59] mandel: A STICK! [12:00] ralsina_, and they say my jokes are bad.. [12:00] mandel: it's from a movie. Hollywood says it's funny! [12:02] ralsina_, he.. === ralsina_ is now known as ralsina [12:03] ralsina, che, for you wife in a few days: sqrt(cos(x))*cos(300x)+sqrt(abs(x))-0.7)*(4-x*x)^0.01, sqrt(6-x^2), -sqrt(6-x^2) from -4.5 to 4.5 [12:03] ralsina, super super gay.. [12:04] I refuse to figure out how to graoh that ;-) [12:04] graph [12:04] graficar [12:04] blah [12:04] ralsina, is good, trust manuel.. [12:10] Ok, got it. :-) [12:12] ralsina, see, is nice :) [12:12] ralsina, and geeky, so double points [12:12] mandel: wife is a lawyer. geeky is -.25 points [12:13] If I were to give her a poster of Mazinger-Z and Aphrodite-A on the beach, for instance, she would hate it. Can you believe it? [12:13] pufff... [12:15] ralsina: hey there! not sure if you saw my messages yesterday evening about a couple of reviews needed [12:15] ralsina: one from me and one from gatox [12:15] nessita: I did yours, gatox is taking a bit longer [12:15] ralsina: ah, great! [12:16] ralsina, we can do the 1-1 whenever you want today [12:16] did you vote in it? (this morning had no vote) [12:16] nessita: in fact, your branch has 2 now, so you can approve it [12:16] nice [12:16] ralsina: thanks! [12:16] gatox: I am going to take a short break to walk while P updates, let's do it in 30' [12:16] * ralsina walks himself [12:16] ralsina, roger that [12:18] ralsina: and when you have a free slot, I desperately need help with the qt spawner. Somehow, the instance of the QProcess is garbage collected so is not working [12:19] ralsina: I've tried holding to that instance adding classes and all, but there is no way [12:19] nessita: point me at the code, I will take a look immediately [12:19] ralsina: so, current version (without adding classes) is lp:~nataliabidart/ubuntu-sso-client/execute-ui [12:20] ralsina: once you branch that (tested on linux only for now) [12:20] please remove your U1 token and run this command in the branch: [12:20] USE_QT_MAINLOOP=True U1_DEBUG=True PATH=bin/:$PATH PYTHONPATH=. bin/ubuntu-sso-login [12:20] nessita: ack [12:23] ralsina: once the sso service is running (you will get output in the terminal), you can open the gtk controlpanel and click on "I already have an account". Do not login, just click on "I've forgotten my password" and put this email in the field: a@example.com [12:23] when you click the default button, you should get this trace in the terminal: [12:24] http://pastebin.ubuntu.com/836470/ [12:24] ralsina: bah, a little different since I have some local changes where I put some stuff in classes to try to hold to the objects a little longer (does not work) [12:25] nessita: got it [12:25] the trace? [12:25] nessita: yes [12:25] ralsina: awesome! [12:25] nessita: ok, I'll try to see if something comes to mind [12:25] ralsina: I'm up for any chanchada to resolve that. Is driving (more) crazy [12:25] nessita: MY SPECIALTY! ;-) [12:25] hehe [12:26] ralsina: ok, I will move to some reviews to put some air in my mind and give you time to "fix" it :-D [12:26] nessita: cool [12:27] holas! [12:27] hola alecu [12:27] nessita: the version of spawn_program I have from bzr will never work because indeed process will be GCd right after start() [12:28] ralsina: yes, I can push you what I have now [12:28] nessita: let me try something first [12:28] ralsina: I have a couple of classes and hold to the references, but they disappear the same :-/ [12:28] ack! [12:28] I will make some mate for now [12:33] nessita: working proof of concept chanchada: https://pastebin.canonical.com/59923/ [12:34] nessita: if you push what you did with classes I can take a look to see if I can do something less nasty [12:34] nessita: I would even rather leak the QProcesses (since SSO dies a little later anyway) [12:36] ralsina, nessita: what if we have a "processmanager" singleton, that holds a dict of active processes, and has a "remove_process" method attached to process.finished? [12:36] alecu: same idea, except I am using a list ;-) [12:37] alecu: why a dict, what would be the key? The qprocess itself? [12:37] ralsina, right: I'm using something similar for QTCPsockets [12:37] (or whatever they are called) [12:37] This (GC of some objects) is the area where Qt and Python have some impedance mismatch [12:38] ralsina, definitely [12:38] ralsina, well, looking at your code it seems that a set() would do better than either a dict or a list. [12:39] alecu: and just connect lambda: thing.remove(process) [12:39] ralsina: I like your solution, is much less chanchada than I imagined [12:40] nessita: use a set instead of a list, remove remove_process and it's not a chanchada at all [12:40] ralsina: will push what I have so you can please explain to me why this last thing I tried is also not wokring [12:40] nessita: happy to [12:41] * ralsina orders a "Not bad for an old ex-nerd" t-shirt [12:41] ;-) [12:41] ralsina: Pushed up to revision 865 [12:42] ralsina: yes, I know that the class Runner in qt would be buggy if spwan process is called more than once, but was just trying stuff [12:43] nessita: my guess is that the Runner from __init__ was also being GCd [12:43] nessita: where were you instantiating that from? [12:44] ralsina: credentials.py:148 [12:44] ralsina: I'm holding the ref there [12:44] since _show_ui will not finish until runner.spawn_program finishes [12:47] nessita: problem with my solution: there is no guarantee about the order in which things connected to finished will be called. So probably better to just leak the QProcesses [12:48] ralsina: what's the problem with the order? is I call set.remove... order does not matter, no? [12:48] nessita: you are not connecting anything else to finished? In that case: OK! [12:48] ralsina: ah, yes, I am. I *now* understand [12:49] I can remove the process from the set in the callback I already connected to finished [12:49] you can remove it from processes in your call, though [12:49] right [12:49] exactly [12:49] ok, will revert all this classess that add noise [12:49] ralsina: thanks!!! [12:50] nessita: maybe it's getting GCd because the calls to finished will only be processed after it reaches the qt mainloop. Perhaps your deferred is triggered before that, and then _show_ui ends, runner gets GCd => crash [12:50] nessita: but it's just a guess [12:50] nessita: you're welcome! [12:50] ralsina: well, the deferred is fired when the finished callback is executed [12:51] nessita: it's a bit too complicated for me to guess quickly, I suppose [12:51] no problem [12:51] I will use your solution [12:52] nessita: cool. I will be back in 30' then :-) [12:52] ack [12:55] IT WORKS [12:55] I CAN'T BELIEVE IT [12:55] * nessita cries, a lot [12:56] ralsina, Why was 6 scared of 7? [12:56] mandel: because seven ate nine [12:56] ralsina, hehehe [12:56] mandel: what did 0 say to 8? [12:57] what? [12:57] mandel: "nice belt!" [12:57] ouch [13:05] nessita, where was the spawn method in sso? I cannot remember.. [13:05] mandel: ubuntu_sso/utils/runner. The API is about to change wiuth a branch of mine, but is working now! [13:05] nessita, ah, runner ok :) [13:06] Morning #ubuntuone ! [13:06] hola karni! [13:06] hola nessita ^_^ [13:07] nessita, if I have a command line such as --app_name name --domain domain it should be passed as ('--app_name', 'name', '--domain', 'domain') is that correct? [13:07] mandel: yes sir [13:07] mandel: and the runner will escape those accordingly [13:07] nessita, superb! I think we are going to get there on time :) [13:08] :-) [13:33] gatox, nessita, ralsina simple review of the collection of reviews coming today: https://code.launchpad.net/~mandel/ubuntu-sso-client/support-user-name-url/+merge/92467 [13:34] mandel, on it [13:34] mandel: ack [13:34] mandel: I would advice having one alecu's review on each one of this [13:34] nessita, ack [13:34] mandel: I would also advice one mine, and one alecu's [13:34] mandel: you think that may complicate the schedule? [13:35] nessita, no, if we do it correctly :) [13:35] nessita, we can always work around that, not a big deal [13:35] mandel: ok, I will try to be as responsive as possible with this [13:35] nessita, ralsina I think I have one more extra hour to finish the connection between the webclient implementations and the dialog (that means using spawn_process and writing tests) [13:36] mandel: so, is it ok if gatox keeps working on his huge refactor and me and alecu do the review? [13:36] nessita, ralsina I'll do after lunch (going now) and then will have the entire afternoon to fix the code according to the reviews, that gives me 3/4 hours just for this [13:36] nessita, certainly, we can keep gatox busy with other stuff, as long as I have the reviewers I'm happy [13:37] mandel: ack [13:37] nessita, FYI the pipeline is as follows: support-user-name-url [13:37] creds-dialog [13:37] keyring-integration [13:37] creds-dialog-script [13:37] load-creds-retry [13:37] * webclient-use-dialog [13:37] mandel: where is support-user-name-url there? [13:38] nessita, paste fail, is the first :) [13:38] nessita, after follow: [13:39] nessita, each of them is small, so it should not burn you brain out, all merges add appropiate tests so they can be merged without screwing up trunk [13:39] nice [13:39] ok, super quick lunch for me so that we land this guy today :) [13:39] * mandel lunch [13:54] wow. twinview on linux is apparently horribly broken :-/ [13:58] howdy! [14:00] hola ralsina [14:09] gotta reboot, brb [14:19] so [14:20] i am running a python script under gdb and it's crashing inside an assembly file in libc; anyone have any clues how to get some deeper debug info about the assembly? :) [14:22] dobey, strace? [14:24] hrmm, maybe [14:24] but probably not === dduffey_afk is now known as dduffey [14:31] alecu: can you send me a direct message on twitter real quick to test gwibber with? [14:40] crowd, ralsina says he computer will not boot [14:40] he's fixing [14:41] :S [14:44] dobey, sent. [14:44] * mandel back [14:45] * alecu is otp [14:47] alecu, ping [14:48] mandel, pong [14:48] dobey: is it working? :-) [14:49] alecu, got a question in the _on_authenticate method on the libsoup implementation, what does the try mean? [14:49] nessita: not quite yet. seems to not be refreshing [14:49] boo :-/ [14:49] And back, it was just a 40 minutes fsck [14:50] ralsina: yeey! k=just in time for a lovely branch [14:50] nessita: hit me! [14:50] https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/dont-let-it-go/ [14:51] ralsina: ^ [14:51] nessita: on it! [14:51] mandel, hhmmmm [14:51] mandel, looking [14:52] alecu, got it: http://developer.gnome.org/libsoup/stable/SoupSession.html#SoupSession-authenticate [14:52] alecu, and it means what I want it to mean :) [14:52] mandel, oh, you mean "retrying", not "try" [14:53] alecu, sorry.. [14:53] mandel, as per your question, I was looking for a "try... except" [14:53] alecu, jesus.. I'm stupid [14:53] :-) [14:53] alecu, understandable [14:53] mandel, keep praying, he may fix that. [14:54] alecu, so, I'm close to be done with the dialog, I just have an issue with it, the proxy creds are being saved as '%(appname)s porxy creds for %(domain)s' do you think that is correct? [14:55] alecu, or should I just go for the domain and ignore the app_name that was used to access sso? [14:55] alecu, I'm considering just having the domain since the app name adds nothing useful [14:55] mandel: you can use the app_name if you want proxy credentials by app [14:55] mandel, how do other applications name them? [14:56] if you want them to be "global", we should drop the app_name [14:56] mandel, chrome at least saves them in the keyring, right? [14:56] nessita, alecu I think global seems reasonable [14:56] @ping [14:56] pong [14:56] mandel, both "global" and "compatible with other apps" is reasonable :-) [14:56] alecu, chrome does not, empiphany browser does, but in a very ugly way [14:57] launchpad is painfully slow today. I suppose it's to be expected [14:57] mandel, also: this sounds like something fixable on a bug, so don't worry too much right now. [14:57] alecu, nessita yeah, I was going to say exactly the same, we send the feature, add a bug if the creds name is wrong [14:57] great [14:57] makes sense, right? [14:58] right [15:00] me [15:00] me [15:00] me [15:01] mandel, dobey, ralsina, gatox: stdup? [15:01] me [15:01] me [15:02] me (no notes) [15:02] oh meh [15:02] dobey: meh? [15:02] hehe [15:02] DONE: weekly call, micro sprint with gatox, debugged execute-ui branch, proposed a couple of priori fixes for that, FF talk with dobey and joshua, used some alecu's brian cycle that were excellent [15:02] TODO: Have execuet-ui working (IS ALMOST THERE), propose the branch and have some rest [15:02] BLOCKED: nopes [15:02] NEXT: alecu [15:02] DONE: worked on a branch for bug #929207 [15:02] TODO: reviews as needed, more work on bug above [15:02] BLOCKED: no [15:02] NEXT: briancurtin [15:02] Launchpad bug 929207 in ubuntuone-client "Proxy "tunnel" for syncdaemon (affects: 1) (heat: 6)" [High,Confirmed] https://launchpad.net/bugs/929207 [15:02] i was hacking [15:02] DONE: fighting through tests, updated merge proposal, more fighting with tests to be sure i gave roberto the right branches [15:02] TODO: fight through more tests, try to isolate why this is killing everything, try to come to some determination on bug #820350 [15:02] BLOCKED: none [15:02] NEXT: mandel [15:02] Launchpad bug 820350 in ubuntuone-client "WIndows: either set_dir_readwrite and/or set_dir_readonly are not doing what they should (affects: 1) (heat: 7)" [High,In progress] https://launchpad.net/bugs/820350 [15:02] DONE: Gone through the entire code of the dialog for creds, got to the point where the only last bit necesary is the connection with the webclients [15:02] TODO: connect the webclients, propose all the diff parts of the pipeline and fix accordingly. [15:03] BLOCKED: no [15:03] next, gatox [15:03] DONE: [15:03] A huge refactoring in SSO, fixed u1-client-network-detect branch [15:03] TODO: [15:03] Finish with more refactoring in SSO, adding signals to the pages to avoid the pages to know about the wizard [15:03] BLOCKED: [15:03] No [15:03] ralsina, go [15:03] DONE: weekly call, thought a lot (hey, it takes time), reviews, misc. TODO: reviews, think a bit more, finish setting up better Windows VM, P VM, BLOCKED: no [15:03] briancurtin: wanna pause what you're working on and move to another branch, until next week where I can put some time in helping you? [15:03] briancurtin: to another bug*, I meant [15:03] dobey [15:04] nessita: yeah i can do that [15:04] λ DONE: team call, nightlies fixes, gwibber poking [15:04] λ TODO: finish gwibber pokery, twisted docs, move more code around [15:04] λ BLCK: none. [15:04] briancurtin: I know the frustration feeling and is not nice :-) [15:04] briancurtin: and sometimes syncdaemon tests have some dark corners [15:04] any comments anyone? [15:04] comments: nessita, mandel: do you guys need reviews? [15:05] alecu, I have noticed that we are using http://developer.qt.nokia.com/doc/qt-4.8/qnetworkaccessmanager.html#authenticationRequired instead of http://developer.qt.nokia.com/doc/qt-4.8/qnetworkaccessmanager.html#proxyAuthenticationRequired in the qt implementation, that looks like a bug, right? [15:05] alecu, yes, let me get you one [15:05] alecu: I will before going to lunch. THE LAST BRANCH to complete the spawnning thing! [15:05] alecu, https://code.launchpad.net/~mandel/ubuntu-sso-client/support-user-name-url/+merge/92467 [15:06] all: in theory, I will not be working on Monday, but due to FF, I will pass by to see how everything is going. Or perhaps I just swap that day to another day, need to change some scheduls [15:06] mandel, it's not a bug. It's you looking at your belly button! [15:06] alecu, why? [15:07] alecu, nada, olvidate, soy tonto [15:07] alecu, I'm just going to fast.. [15:08] mandel, I think we'll end up using both. [15:08] alecu, by what i read very very quickly, you get the first the proxy and from that point on the other [15:08] mandel, since we may need the first one to authenticate against the destination server, and the second one to authenticate to the local proxy. [15:09] mandel, right, in the order you just said. [15:20] nessita: not important, don't change it, but I so much prefer if things like failed_to_start = process_error == process.FailedToStart have () arount the right-side of the assignment [15:21] ralsina: can change that :-) [15:21] I agree [15:21] nessita: cool, thx [15:22] nessita: +1 anyway [15:22] great! [15:23] mandel, needsfixing [15:25] * gatox lunch [15:25] gatox: you have 10 minutes for a review? [15:25] ooops too late :-D [15:25] gatox: go go, have lunch [15:25] nessita, ok..... when i get back === gatox is now known as gatox_lunch [15:36] anyone looking forward to do a review? [15:36] :-D [15:36] dobey: you up for one? is been a long time (?) [15:39] is it 5 lines? [15:39] dobey: +45/-4 [15:40] you will like it, it has some gi in it (?) [15:41] by like, you mean hate? [15:41] it depends :-P like and hate are too subjective feelings [15:43] my feelings toward gi do not tend toward the 'like' end of the spectrum :) [15:43] hehe [15:43] especially at the moment while i'm trying to port gwibber [15:45] dobey: well, if you feel inspired, it has some qt and some tiny gi, https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/dont-let-it-go/+merge/92485 [15:45] if not, I will seek reviews after lunch [15:45] and now... lunchtime! [15:46] nessita: did your spawning code get fixed and land already then? [15:47] dobey: is ready to land today, I'm proposing branches "de a poquito" (little by little( [15:47] )) [15:48] big one is https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-that-ui/+merge/92496, but I'll IRL test it a bit longer before ping for review [15:48] s [15:48] brb! [16:00] alecu, on it [16:00] ha, i just got an email at my personal mail that i didn't get the Software Engineer (client applications Mac/Windows) position with Canonical [16:00] :( [16:04] too bad for yoU! :) [16:05] briancurtin: and yet, you will do the job anyway! ;-) [16:06] * briancurtin checks bank account to make sure i'm being paid [16:06] briancurtin: I have been cleaning up the queue :-) [16:06] briancurtin: you got the Windows/Mac one! [16:06] haha yes i remember the two different applications [16:07] heh [16:18] man. i am way too tempted to screw with ralsina at the moment :P [16:19] dobey: feel free ;-) [16:19] * ralsina is a big teddy bear and doesn't mind [16:24] hola [16:24] Hello boys and girls. I'm trying to install ubuntuone. After I apt-get the installer, I run it and when I click on the "I already have an account!" link it does nothing. I see no "connect to ubuntu" window. Any ideas? [16:25] I'm using xubuntu 11.10. [16:25] Josssse: version of ubuntuone-client? [16:25] The funny this is that i did it simulatniously on my laptop and it worked. [16:26] ralsina, 2.0.0 [16:26] Josssse: 2.0.0-0ubuntu2.3 ? [16:26] yes. [16:27] duanedesign, rye: maybe you can give a hand to Josssse here? [16:27] Josssse: what pops up in ~/.cache/ubuntuone/log/controlpanel.log when you click that link? [16:29] dobey: thanks!!! [16:31] dobey, http://paste.ubuntu.com/836736/ [16:32] ralsina: you coming to the design talk? [16:32] nessita: am there [16:32] nice! [16:32] you were faster :-) [16:33] alecu, code update, no types + extra tests [16:33] mandel, looking [16:35] dobey, sorry I didn't paste all the info, this is all the ouput http://paste.ubuntu.com/836739/ [16:36] Josssse: so when you click "I already have an account" you don't get a window popping up asking for your username/password? [16:36] Nope. [16:36] The window just blurs a little darker for a second and then back to normal, dobey [16:37] Josssse: if you run seahorse, there is probably an old token already listed in your keyring. if you remove the old token, then open the control panel again, you should be able to log on [16:38] nessita, I see that the "sleep 3" in run-tests has landed. [16:38] dobey, What is seahorse, I don't think I have, i'm using xubuntu. [16:38] alecu: I added it, it avoids the g_dbus_foo_errir [16:38] alecu: I was having it in my laptop [16:38] nessita, just pinging to remind you that it does *not* fix the g_dbus... error. [16:39] nessita, the g_dbus... error is thrown by the first u1trial, so a sleep there does not fix it. [16:39] nessita, I tried running the first u1trial, without even the xvfb and it fails too. [16:39] Ok, I'm installing seahorse. [16:40] Josssse: the keyring manager application. i don't know if it's installed on xubuntu or not, or if they have a similar app [16:40] alecu: you sure it does not fix it? it "did" for me [16:40] alecu: I know, may be coicidence [16:40] alecu: but I never had the error again (nor tarmac did) [16:40] nessita, just ran the tests on trunk, on my laptop, and it fails before the reaching the "sleep 3" [16:40] nessita: sleep wouldn't fix the dbus error [16:41] dobey, alecu: ack, remove it then :-) [16:41] nessita: the g_dbus error is something completely different, and i have no idea why it's happening, or how to consistently cause it to happen. :-/ [16:41] alecu: are you getting it consistently? [16:41] dobey, It works!!! You're awesome. Thank you very much. I had been struggling with this for a couple hours. Thank you. [16:42] Josssse: no problem. sorry it didn't 'just work' for you. :) [16:42] dobey, yes, it fails every time I run the whole tests on my laptop. It's *slowish* if that helps. === gatox_lunch is now known as gatox [16:42] dobey, but somehow it does not fail when I run each test file independently [16:43] or a few together. [16:43] Sweet, now it works which is the important thing. Thanks dobey. [16:43] alecu: hrmm; which test command exactly? (the full u1trial command) [16:44] dobey, it fails if I run: u1trial --reactor=gi --gui -p "ubuntu_sso/qt/tests" -i "test_windows.py" ubuntu_sso [16:46] alecu: ok. can you run "valgrind -o dbus-error.log u1trial -r gi --gui -p ubuntu_sso/qt/tests -i test_windows.py ubuntu_sso" and put the dbus-error.log up somewhere i can see it when it finishes/fails? :) [16:46] nessita, do you still need a review? [16:59] nessita, I have a complete implementation of the dialog for sso, it is enough to do ase setup.py install to do an IRL? [17:05] mandel: it depends on your code... not sure what you're asking [17:05] gatox: yes, I do, finalizing latest IRL tests [17:06] nessita, can you give me the link? [17:06] gatox: sure! https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-that-ui/+merge/92496 [17:06] nessita, I'd like to test end to end the solution, so I have the bin, which is installed by the setup.py and all the required code, so intheory doin setup.py and killing sso so it is restarted is enough, right? [17:06] mandel: I would advice running the service by hand from your branch, with this command: [17:07] U1_DEBUG=True PATH=bin/:$PATH PYTHONPATH=. bin/ubuntu-sso-login [17:07] mandel: or, if you want to use the Glib mainloop [17:07] USE_QT_MAINLOOP=True U1_DEBUG=True PATH=bin/:$PATH PYTHONPATH=. bin/ubuntu-sso-login [17:08] mandel: also, the bin should not be installed in /usr/bin, but next to the -gtk and -qt binaries (not sure where you put it) [17:08] nessita, I'll double check that [17:13] ralsina: could trivial review this https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/install-uniqueapp/+register-merge ? [17:13] nessita: sure! [17:13] wrong link again :P [17:13] gatox: fix LP! :-P [17:13] jejej [17:14] ralsina: correct link is https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/install-uniqueapp/+merge/92524 [17:17] nessita: looking... [17:18] ralsina, got a few mins for me and QNetwork? [17:19] mandel: sure! [17:19] mandel: can't speak, but can read :-) [17:21] ralsina, superb, if you branch lp:~mandel/ubuntu-sso-client/webclient-use-dialog/ you will see in ubuntu_sso/utils/webclient/qtnetwork.py that I connect to two diff signals, proxyAuthenticationRequired and authenticationRequired [17:21] ralsina, in the tests then seem to never be fired and therefore I never show the ui [17:21] mandel: branching [17:21] mandel: this is just a test failure? [17:22] ralsina, yes, the test is test_authenticated_proxy_is_used_creds_requested [17:23] mandel: ok, I'll check, and report back in 10' [17:23] mandel, I'm rushing to the bank, and I'll finish your review after that. [17:23] alecu, ok [17:23] mandel, I can do the rest in your pipeline, if that's fine with you. [17:23] mandel, just tell me at what point I should stop. [17:24] alecu, I'm going to propose all of the branches that I believe are ready, atm I just have an issue with the qtnetwork one [17:25] mandel, cool [17:26] the donkey that powers launchpad branch scans needs an extra carrot today :-( [17:30] nessita: golbal approve on install-unique-app [17:32] nessita: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/dont-let-it-go/+merge/92485 seems to have merged before your inal commit... [17:32] s/inal/final [17:33] ah, forget that, I misread. [17:36] ralsina: it did? looking [17:36] nessita: no, it didn; t [17:36] ralsina: fuuuiiiiiuuu [17:36] nessita: I got confused by revnos [17:36] ralsina, nessita, alecu, gatox, briancurtin reviews b y oder: http://paste.ubuntu.com/836809/ please I prefer reviews from alecu and nessita due to the natrue of the work, so if you are busy, ignore me :) [17:38] mandel: ack! did you fix what alecu put in the first one? [17:38] nessita, yes [17:38] nessita, I'm here for comments on those to fix them asap [17:39] mandel: the signals will not be triggered until you enter the event loop again [17:40] ralsina, what do you mean? [17:40] mandel: if you connect a slot to a signal, and then emit the signal, that doesn't call the slot until the next time you enter the event loop [17:41] mandel: OTOH, I don't understand this code yet ;-) [17:42] ralsina, there I'm getting the finished signal BEFORE the auth required ones and therefore get an error on the reply :( [17:42] mandel: if all signals are triggered before you enter the loop, then there is no guarantee on what order they will call the slots [17:42] mandel: want to mumble this? [17:43] ralsina, yes, lets do it since is the last tiny part I have left [17:44] mandel: ok, I'm there already [17:45] alright, i need to get lunch. bbiab kids [17:45] ralsina: when you have some slot, of you could review this: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-that-ui/+merge/92496 (gatox, is the right link ;-)), that's the key-branch for detaching UIs from the sso service [17:51] everyone: I have one extra, final branch, that I'd need reviews on: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/policy-url/+merge/92541 [17:51] gatox: you may also be interested in that one ^ ;-) [17:51] nessita, ack [17:54] ralsina, mumble again? [17:54] mandel: I am still there :-) [17:56] dobey: what was it that was preventing users from subscribing their Purrchased music folder? Was it that file Sync was disabled? [18:01] mandel: added needs info to https://code.launchpad.net/~mandel/ubuntu-sso-client/support-user-name-url/+merge/92467 [18:01] nessita, ok, on it [18:02] nessita, that is exactly why I added test_gsettings_auth_over_url to ensure that the gsettings win, atm I'm not sure which one should be the winner to be honest [18:02] mandel: can you please check that with alecu? [18:03] mandel: I saw the test, but from the code is hard to tell which one will win [18:03] dobey, if gsettings has a username and password diff to the one in user:password@domain, do you have any idea which one should win ? [18:03] nessita: +1 on plicy-url [18:03] ok, gotta go to run some errands [18:03] ralsina: awesome! thanks. Though policy-url depends on run-that-ui, the most important one (read with time and energy :-)) [18:03] ralsina: ok, please drop me an email with any news [18:04] I need to head out now [18:04] nessita: yes, I know, that was just a code review [18:04] been getting a lot of tickets from Windows users the last few days with the error 'WARNING - Please don't run the syncdaemon as root.' [18:04] ok, see ya laters! [18:04] duanedesign: interesting [18:05] i know U1 is not supposed to be run w/ elevated privelages, it just seems weird to be seeing these all the sudden [18:05] duanedesign: we added "root detection" to syncdaemon on windows in the latest version [18:05] ahh [18:05] duanedesign: are those users on XP by chance? [18:05] i am not 100 percent, but they seem to be on Windows 7 [18:05] duanedesign: ok [18:06] ralsina, http://paste.ubuntu.com/836858/ [18:06] duanedesign: they should not be getting those since the installer is also supposed to run syncdaemon with downgraded provileges [18:06] ralsina, X-Squid-Error [18:07] ralsina: the logs do not seem to have much but if you would like to see any of them let me know [18:16] * alecu is back, after bank and icecream stops. [18:16] mmmmm icecream :D [18:19] duanedesign: could you mail me one? I will probably not look at it today, but soonish [18:20] gatox, crema rusa y frutilla al agua [18:20] ralsina: yes [18:20] alecu, i'm trying to stop eating ice-cream....... and you are not helping jejee [18:20] alecu, mumble>? [18:20] mandel, regarding which setting takes precedence: choose any one of those, make a test for it, and make sure we pass it. [18:21] alecu, ha, that is what I already did :) [18:21] mandel, I think it's a corner case in any way. [18:21] mandel, if we choose to change it, it's only a bug. [18:21] mandel, great then. [18:21] mandel, should I join mumble anyway? [18:21] alecu, yes, I have a nice discovery we did with ralsina :) [18:27] * alecu loves http error codes. 418 most of all [18:27] alecu, lp:~mandel/ubuntu-sso-client/webclient-use-dialog currently test_authenticated_proxy_is_used_creds_requested skipped [18:28] alecu, you will have to remove it from the skip at the bottom of the test case, like the one with twisted [18:29] nessita, typo fixed and alecu and I decided to leave it as it is with the test and later consider it a bug [18:33] mandel, I got a different error in the proxy test, I think. [18:33] mandel, http://pastebin.ubuntu.com/836900/ [18:34] mandel, alecu, thisfred: http://www.flickr.com/photos/laserbread/6810063291/ [18:34] nessita, nessita so I managed to get someone else to walk the dog, so I can stay 1:30 mins more and then I have to go :( [18:34] mandel: nessita is not here, she's on errands [18:34] alecu, that is the one, if you do a print error you will see [18:35] alecu, also, if you look at the exception we are getting a WebClientError and not a UnauthorizedError [18:37] mandel, probably that's because we are expecting the Unauthorized error code from the destination server, not from the proxy server [18:37] (just guessing) [18:38] alecu, annoying detail, proxyAuthenticationRequired and authenticationRequired are not fired.. [18:38] alecu, I'd hope that at least proxyAuthenticationRequired did :( [18:39] mandel, right... if proxyAuthenticationRequired is not fired, then proxyAuthenticationRequired will never be. [18:39] doh [18:39] *if proxyAuthenticationRequired is not fired, then authenticationRequired will never be. [18:39] alecu, yep, I guessed why you tried to say, remember I drink a lot, most of my conversations are like that ;) [18:40] mandel, that would explain your dyslexia too! [18:40] blame ballmer [18:40] hahahaha [18:41] can anyone help me answer this users question about running U1 as admin on Windows. https://pastebin.canonical.com/59969/ [18:42] duanedesign, AFAIK we support AD users, I have played with it [18:43] duanedesign, that will proably use his home dir as $username.domain, for example I have an mandel.marvel [18:44] duanedesign, and although the app will work the installer wont, that is, the installer has to be ran as a normal user because we have a limitation when we use the runas command as a domain user [18:46] duanedesign, I think he might be able to run the birtock installer but as soon as he tries to do the wizard it will block [18:46] duanedesign, the evil code is in ubuntuone_installer/gui/qt/utils/windows.py [18:47] duanedesign, anything with a runas there won't work, you can ask him to try and execute the commands manually.. it might work [18:47] alecu, shall we go review by review to land as much as possible? [18:48] alecu, can you re-review https://code.launchpad.net/~mandel/ubuntu-sso-client/support-user-name-url/+merge/92467 [18:48] mandel, I'm debugging the qt issue. should I review instead? [18:49] alecu, lets review as much as possible, that way we land 75% of the feature and we can leave the rest as a bug :) [18:49] alecu, well kind of hehe [18:49] alecu, I don't think we will make that qt fix for today.. [18:49] ralsina: heheh [18:52] mandel, I think I found the bug :-) [18:52] mandel, give me one more minute [18:52] alecu, oh!!! cojonudo! [18:52] mandel, I know. That's why I buy oversized calzoncillos. [18:53] alecu, I was talking about the fact, not you ;) [18:53] mandel, here's your 105: QNetworkReply::ProxyAuthenticationRequiredError [18:53] mandel, it's not squid that's replying that: it's qt's error scheme. [18:54] alecu, ralsina this? https://bugreports.qt-project.org/browse/QTBUG-19990 [18:54] mandel, http://doc.qt.nokia.com/4.7-snapshot/qnetworkreply.html#NetworkError-enum [18:54] mandel: ahá! [18:54] mandel, so: QNetworkReply.error() needs to be checked against that table. [18:55] alecu, ralsina so, there is a bug in qt about it.. which means, we do a work around and do a error num check and do the retry the same way I did in the twisted test cases webclient [18:55] mandel, if you want the HTTP status code: QNetworkReply.attribute(QNetworkRequest.HttpStatusCodeAttribute) [18:55] mandel, it's not a bug [18:56] mandel: not a bug, just a bit harder [18:56] * mandel stops saying 'puto squid' and starts to 'puto qt' [18:56] or maybe it is... [18:56] :-) [18:57] alecu, ralsina so those bloody proxyAuthSignals are just there to play with my feelings.. how rude! [18:58] mandel, they are probably broken... but don't worry about it, we can work around with what you've found. [18:58] mandel: whatever is in the keyring is what should win :) [18:58] duanedesign: no sure, i guess a number of things could cause it, including disabled file sync [18:59] need to go 5 min [18:59] nessita: why are most of your merge requests ending up in my spam folder? [18:59] dobey: nessita is away [19:00] ok [19:00] it's not an urgent matter :P [19:11] * mandel back [19:16] mandel, "autheticated" -> "authenticated" [19:17] alecu, I hate being this dyslexic.. [19:17] I have tos tart using an spellchecker on vim [19:17] mandel, other than that, I'm running tests to approve. [19:23] mandel, approved first branch [19:23] alecu, sweet, let me pass you the next one [19:24] mandel, got it here: http://paste.ubuntu.com/836809/ [19:24] alecu, cool, the next nearly has not code at all, is just the xml and some settings for labels + the tests to ensure they are set [19:25] mandel - ":set spell"/":set nospell" works alright for me [19:26] briancurtin, cool, I did not know that foo :) [19:34] windows user seeing files getting deleted and has this error in his logs? https://pastebin.canonical.com/59980/ [19:35] duanedesign: new bug! [19:36] duanedesign, I've never seen that... [19:36] ralsina: you want me to file a bug? [19:36] duanedesign: yes please [19:36] duanedesign, is that the domain username guy? [19:36] duanedesign: assign to briancurtin :-) [19:36] no different one :) [19:37] silly question. What is the package for windows bugs? [19:37] duanedesign: my name on launchpad is brian.curtin if you want to assign to me [19:39] duanedesign, that is for the ubuntuone-client [19:39] ok, any special tags you want? [19:39] duanedesign: tag it as u1-windows, while you are there [19:39] duanedesign, anything related to an installation where sd works yet has bugs goes there, or in ase of a doubt add brian and me to the bug and we decide [19:40] duanedesign, I like the 'saaaaaaaay what?' tag, but ralsina ones sounds better [19:45] ralsina, any idea of how to get the QAuthenticator for a QNetworkAccessManage or a QNetworkReply? [19:46] mandel, in the third branch: this file only changes in an EOL added to the end of it: ubuntu_sso/qt/gui.py [19:46] mandel: let me check the docs [19:46] alecu, let me check [19:46] alecu, yes, pep8 [19:47] or am I wrong? [19:47] mandel: looks like you cannot [19:47] mandel: so you will have to make it global or something like that [19:48] mandel, maybe. It looked weird because the file didn't seem to change, but the diff showed an extra line at the bottom. [19:48] mandel: BUT you get it as argument in the authenticationRequired signal [19:48] alecu, you mean removed, right? [19:48] ralsina, yes, true.. [19:49] mandel, removed, yes. You are right, and it's fine. [19:51] ralsina, exactly, so how am I suppose to emit that signal.. [19:51] mandel: right, that is the signal we are not getting [19:52] mandel, "cancle" -> "cancel" [19:52] alecu, soy estupido! [19:53] it would be interesting to have a spellchecker for code that understands CamelCase and under_scores [19:54] alecu, certainly.. at least for me [19:54] mandel, if we could add this to meld, it would make my reviews easier too :-) [19:54] hahaha [19:56] mandel, so, still on branch 3: [19:56] mandel, ProxyCredsDialog takes a parameter named "domain" [19:56] mandel, but it's not used yet (I suspect an upcoming branch) [19:57] mandel, question is: what does that string looks like? [19:57] mandel, and... will it be translated? [19:57] mandel, because that's the string that goes into the keyring as name, right? [19:57] alecu, look at the line 63 of the lp diff [19:58] alecu, would be the name of the proxy host.. so in my case ad.marvel for example [19:58] alecu, it will be passed by the webclient so that it lets the user know the host of the proxy he is connecting to and used for the keyring [19:59] alecu, _on_save_clicked is where we used it for that [20:00] mandel, that part looks clear [20:01] mandel: why do you need the QAuthenticator exactly? [20:01] mandel, it's the way it's stored in the keyring I don't like [20:01] ralsina, probably to set the user and password after the proxy returns an error. [20:01] ralsina, ^ [20:01] alecu: you set those in QNetworkProxy [20:01] alecu, whats up with it? [20:01] mandel: ^ [20:01] ralsina, yeah,that was my second idea :) [20:02] mandel: good, becuase it's the right one ;-) [20:02] alecu, I just have a few more mins.. is 21:00 here :( [20:02] ralsina, usual sequence: try without password, it fails, try with password. If it fails, ask for newer passwords. [20:02] mandel, ack [20:03] mandel: and you can get the QNetworkProxy from QNetworkAccessManager.proxy() [20:03] mandel, so... set_credentials will set the key-type to "Ubuntu SSO credentials", and the token_name to something including the current computer name and the app_name you've passed [20:04] mandel: and the access manager you can get from the reply [20:04] mandel, so, I think we should refactor ubuntu_sso/keyring/linux.py and windows.py so they allow you to pass some other stuff for all that [20:04] alecu, seems reasonable, atm is doing: token-name: 192.168.1.100 @ ironman [20:04] key-type: Ubuntu SSO credentials [20:04] alecu, and the name of the key will be the domain [20:06] mandel, we'll probably need to fix that. Let's open a bug and fix laters. [20:06] alecu, +1 [20:06] alecu, would also be nice to get tx-secrets and the windows impl out and create a keyring lib that is async [20:06] alecu, pykeyring has lots of bugs.. [20:08] mandel, I'm approving and creating a new bug for that. [20:08] mandel, I'll keep reviewing, enjoy your weekend! [20:08] alecu, I managed to get 10 more mins, just called the date saying I was late a little :P [20:09] mandel, go away! [20:09] alecu, next simply adds a bin to get the creds dialog, is kinda simple [20:09] alecu, I'm actually quite proud of how I managed to get the pipeline so well divided.. :) [20:10] mandel, :-) [20:10] mandel, perhaps we need somebody else to review all those branches too? [20:10] mandel, or get permission from ralsina to land'em with just one review ;-) [20:10] alecu, yes, nessita said she would take a look, or maybe ralsina or gatox [20:11] mandel: remind me of URLs [20:11] ralsina, http://paste.ubuntu.com/836809/ [20:11] * ralsina has been running like a beheaded chicken all day [20:11] ralsina, I've already approved the first three [20:11] alecu: ok, I'll try to get those three before I EOD [20:11] ralsina, like, spurting blood from your neck? [20:11] ralsina, http://paste.ubuntu.com/836809/ [20:11] alecu: like, mindlessly [20:12] mandel: do these branches require any deep understanding that i might not have yet, or would i be ok to review? [20:13] briancurtin, I think you are perfectly ok, some of them are simple qt stuff, the last one is the 'hard' one and is not proposed yet :) [20:13] mandel: i'll take a look [20:13] sweet! [20:14] mandel, what does this mean? # HACK: At the moment we need to do that until sso is refactored [20:14] alecu, you cannot correctly import the ui from qt unless you set that env var because the controls import the wrong main otherwise [20:15] ugh-ly [20:15] alecu, I though HACK was more appropriate, gatox is working on that [20:16] mandel, great then. [20:16] mandel, i finishing with the test in the last refactor [20:16] there is nothing in the stdlib that parses user:password??? [20:16] mandel, "Parse sys.arge options" -> "Parse sys.argentinos options" [20:16] alecu, hahaha [20:17] ralsina, you mean "[user[:password]@]hostname" ? [20:17] alecu: yes [20:17] ralsina, I didn't look, but probably urlparse may do something useful with that. But it's not really a url, so that code made sense. [20:18] alecu: ok [20:18] alecu: and no it doesn't (claims to do but fails) [20:18] ralsina, we talk about that, I wanted to have two problems :) [20:18] mandel, "the domian whose" -> "the domain whose" [20:19] i should try to write some magic test stuff that will pipe string literals and docstrings through aspell [20:19] alecu, sorted out both [20:19] dobey, that would be really really useful with me [20:19] mandel, " we are retying" -> " we are retrying" [20:19] i know :) [20:20] I should not be allowed to use a keyboard.. [20:20] dobey, and then scattered all around our code we'll have "# aspell: ignore=W0666" [20:20] I could sign my code as 'dictated but never read' [20:20] alecu: nope [20:23] We should create our fake qt stuff for tests somewhere and share it accross projects [20:23] alecu: i'd make it strip out URLs and validate them separately; and generally be simple and smart, completely unlike pylint [20:25] ralsina, from FakeQt4.QtGui import QLabel [20:25] ralsina, is not that as mad as mocker in a way? [20:25] grammar checking would be nice too, but is a lot harder to do [20:25] mandel: nope [20:25] mandel: right now we probably have 12 different fakewidgets somewhere [20:25] anyway [20:25] * dobey goes to make a really big change real quick [20:27] dobey: getting married in Vegas? :-D [20:27] no [20:28] though i would love to have the technology to get from here to vegas, really quickly :) [20:28] i would a) be insanely rich b) on my way to kepler 22-b already [20:29] mandel, bug #930385 [20:29] Launchpad bug 930385 in ubuntu-sso-client "Proxy credentials in the keyring have wrong attributes (affects: 1) (heat: 6)" [Low,Confirmed] https://launchpad.net/bugs/930385 [20:29] alecu, thx! [20:30] hmm, i guess i will have to rewrite this code in vala later though. i am sad i wasn't able to get to that this cycle [20:30] dobey: gwibber progress? [20:30] alecu, ralsina unfortunately I have to go, no matter how nice you are I've got a date and don't want to miss it.. is not that you meet lots of people working from home ;) [20:30] mandel: go then! [20:31] mandel: say we said hi! [20:31] ralsina, do we believe that we 'nearly' landed the feature and we just have bugs left? [20:31] mandel: let's reconsider on monday [20:31] ralsina, I'm sure I can find a bug for each branch left :P [20:32] ralsina: yep. i just want to get this code moving done today, as it's fairly simple, and needs to be done by ff. hitting another issue with the keyring gir which i'll be poking at again soon, but i needed to do something else for a bit today, and need to get this done :) [20:32] dobey: cool [20:35] mandel, go away, have fun. [20:35] ralsina, alecu I go, but give me the +1! [20:35] ralsina, alecu I'll say hi :) [20:35] alecu: since mandel is leaving... I am reviewing https://code.launchpad.net/~mandel/ubuntu-sso-client/keyring-integration/+merge/92532 [20:36] And username = str(self.ui.username_entry.text()) is a BAD idea [20:36] ralsina, why? [20:36] alecu: that means if I type a unicode character there, it will crash with unicodedecodeerror [20:36] ralsina, ah.. cure, fixing [20:38] ralsina, using unicode is enough, right? [20:38] mandel: well, that will get you unicode :-) [20:38] mandel: I don't know what you have to pass to the next consumer [20:38] ralsina, which is what we want, no? [20:38] mandel: I dn't know. What does keyring take? [20:39] I am guessing unicode, but I am not sure [20:39] ralsina, secret = urllib.urlencode(cred) [20:39] ralsina, yup, that str( is way out of place. Bad hurried review, alecu. [20:40] mandel: then unicode sounds right [20:40] alecu, same as the code, I did not think about it.. [20:40] mandel, ralsina: I'm tempted on marking this as a bug and moving the branches forward. [20:40] ralsina, updated pushed and leaving for good [20:40] have a great weekend! [20:40] mandel: urlencode doesn't take unicode [20:41] ralsina, then keyring is broken on sso too :) [20:41] so, it's tricky ;-) [20:41] ralsina, since we do the same in the gtk and the sso views there.. nice catch! [20:41] adios! [20:41] bye mandel [20:41] * mandel walks away [20:41] mandel, ralsina: we should discuss better on monday [20:41] bye mandel [20:42] have a good weekend mandel [20:46] ralsina: well, i just successfully added a statusnet account with gtk3 gwibber-accounts. and it downloaded the new data; so at least that much is working in my gwibber branch now :) [20:46] dobey: awesome! [20:46] * ralsina says ship it! ;-) [20:46] ship it good! [20:47] yeah, i think by tuesday i'll have it shippable for sure [20:48] dobey: excellent news [20:48] I should send you a Hannibal Smith cigar [20:49] ralsina loves it when a plan comes together [20:49] too bad I don't smoke [20:50] who needs more vices, eh? [20:50] mandel, even though you are gone, 4th branch approved. [20:50] yeah... I still have.... or maybe .... okWhile the authorities proudly showed off the seizure to local reporters, the sheer size of the find set off alarm among experts and officials from the United States and the United Nations. It was a sign, they said, of just how organized, efficient at manufacturing and brazen Mexico’s traffickers had become even after expanded efforts to dismantle their industry. [20:50] ,I [20:50] oops [20:51] that was oneweird paste [20:51] since I am nowherenearany key that may cause that [20:51] strangely appropiate though! [20:54] ralsina: fyi...i filed bug #930398 for the windows "please don't run syncdaemon as root" thing [20:54] Launchpad bug 930398 in ubuntuone-client "SyncDaemon - WARNING - Please don't run the syncdaemon as root (affects: 1) (heat: 6)" [High,Confirmed] https://launchpad.net/bugs/930398 [20:54] joshuahoover: cool thanks [20:54] joshuahoover: no idea what that is, but weĺlfigureit out [20:55] I mean, I know what it is, I don't yet know why it happens :-) [20:55] heh [20:56] ralsina: i noted in the bug description that we had a similar error occuring a while back but i'm not sure if it's at all related or not [20:56] joshuahoover: looking... [20:57] goodbye libsyncdaemon [20:57] well, that one was fixed. I am leaning more towards our "root detection" being broken on windows [20:57] * ralsina wonders who was the amateur who did THAT! (oh right, ralsina did) [20:57] the fool! [20:59] there was this wise man who recently wrote, "Why oh why do I have this talent to write crappy code that works? If my crappy code didn't work, I would be a better programmer." [21:02] ralsina, some touchpads use the right upper corner as the middle button... could that be the reason for the paste? [21:03] (so it was not really a paste but a "insert X selection") [21:05] alecu: indeed [21:05] alecu: I didn't copy that, I just selected it. Bad habit [21:05] ralsina, it's like pointing with your finger while reading, right? :-) [21:05] joshuahoover: indeed a wise man [21:05] alecu: yeah :-) [21:06] joshuahoover: here he is in the simpsons, according to another guy in twitter: http://t.co/8piVqPoi [21:07] ha! [21:12] ralsina, mandel alecu dobey briancurtin nessita ok.... i finish with the refactor!! i have time for 1 or 2 reviews if someone need something [21:12] gatox: did yo get reviews on your monter branch or is it still missing one? [21:13] monster* [21:13] ralsina, if you didn't review it..... it still miss one :P [21:13] ralsina, it was a lot.... but it was necessary :D [21:20] gatox: I'll take a good look later. Now I have to go parenting [21:21] ralsina, ok! thanks! [21:21] bye ppl! See you all on monday or so! [21:22] ralsina, bye [21:25] ok, EOD for me then! see you on monday [21:29] * dobey is rapidly losing potential reviewers as .ar falls off the net [21:32] i think nessita was coming back later, so maybe .ar will rise again. i'm also around for another hour+ [21:35] yeah [21:39] hrmm, maybe i won't be able to get this done today :( [21:41] since i actually need to make 3 branches to do it. and update nightlies packaging [21:52] bye all, this is my official EOW [22:10] meh, gtk3 is really annoying me === dduffey is now known as dduffey_afk [22:57] later all [23:16] hello again! [23:16] I had an internet outage [23:22] ok, no emails, which is great [23:22] I'm off then [23:22] bye!