| === eu is now known as Guest80206 | ||
| Chipaca | if you restart your video lens now, you should find a couple more sources in there | 02:21 |
|---|---|---|
| Chipaca | just sayin' | 02:21 |
| Chipaca | and now, to bed | 02:22 |
| === david is now known as davidcalle | ||
| JamesTait | Happy Friday, everyone! :) | 09:21 |
| mandel | ralsina, ping? | 11:14 |
| ralsina | mandel: pong | 11:14 |
| mandel | ralsina, morning! | 11:14 |
| mandel | ralsina, do you know a widget similart to a GtkArrow? | 11:15 |
| mandel | ralsina, I might hate Qt depending on the answer :) | 11:15 |
| ralsina | mandel: I don't know gtkarrow! | 11:15 |
| ralsina | mandel: the icon theme has arrows, maybe using that in a label? Where do you need an arrow? | 11:16 |
| mandel | ralsina, ah, nice, there is a way to get the arrow from the theme, how do you do that? | 11:16 |
| mandel | ralsina, is to follow the design of the ssl dialog | 11:16 |
| ralsina | mandel: can I see an image? | 11:17 |
| mandel | ralsina, I'll foward the design | 11:17 |
| mandel | ralsina, via mail | 11:17 |
| ralsina | mandel: ack | 11:17 |
| mandel | ralsina, so, the problem is that there is AFAIK a widget like the GtkExpander on Qt, so I need to do my own, which might be a problem later in Windows, but I'll work around it later | 11:18 |
| gatox | good morning! | 11:18 |
| ralsina | mandel: you mean for the thing that expands to show the details of the SSL cert? | 11:19 |
| mandel | ralsina, yes, is there a widget for that already that follows the design? | 11:19 |
| ralsina | mandel: to get icons from the theme: QIcon::fromTheme(…) | 11:19 |
| mandel | ralsina, that I know, I don't know the id of the arrow hehe | 11:19 |
| ralsina | mandel: as soon as I see the design, I will wildly guess ;-) | 11:19 |
| ralsina | mandel: hahaha | 11:19 |
| mandel | ralsina, good enough :) | 11:20 |
| ralsina | mandel: icon names: http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#names | 11:20 |
| ralsina | mandel: so, the idea is that clicking on the arrow next to "Certificate details" will show the details? A QTreeWidgetItem and a lot of detailed styling ismy best guess. Ask for gatox's opinion now that he's up | 11:22 |
| ralsina | mandel: forget it,it would not look right | 11:22 |
| ralsina | mandel: I need to think a bit more | 11:22 |
| mandel | ralsina, the best idea I have is to have the label and when the label is clicked make the text area y the scrollable show | 11:23 |
| mandel | ralsina, but I need to see the exact behaviour we want.. but that can be a bug fix later | 11:23 |
| gatox | back again | 11:24 |
| mandel | ralsina, from that page => Version 0.8, 1 August 2006, Rodney Dawes. | 11:24 |
| mandel | lol | 11:24 |
| ralsina | mandel: I know | 11:24 |
| mandel | gatox, any idea how to implement a GtkExpander in qt? | 11:24 |
| ralsina | I was going to tell you to ask dobey because I knew hewrote it then I saw the time ;-) | 11:25 |
| gatox | mandel, let me see what a gtkexpander is :P | 11:25 |
| gatox | mandel, the window has to be resize, or you only need to expand the content of a widget without the need to resize the windows in ordeer to fit the new content? | 11:27 |
| ralsina | mandel: http://qt-apps.org/content/show.php/QIrExpander?content=115342 but of course we can't use it :-( | 11:27 |
| mandel | gatox, the dialog overall expands.. | 11:27 |
| mandel | ralsina, gatox looks like I'll have to do a custom widget for this.. | 11:28 |
| ralsina | mandel: do a composite | 11:28 |
| gatox | mandel, yes..... but i already did one when we made the db_to_u1 | 11:28 |
| ralsina | mandel: three labels, clicking on the arrow makes the bottom one larger/visible | 11:29 |
| ralsina | mandel: the only "bad" thing is lack of animation but who cares | 11:29 |
| gatox | then we remove it, but i did something like that, with an animatoin to look pretty and everything | 11:29 |
| mandel | ralsina, gnome people? | 11:29 |
| mandel | gatox, got the code around? | 11:29 |
| ralsina | mandel: it's the corner of a dialog noone will see | 11:29 |
| gatox | mandel, it's in the first version of db_to_u1 | 11:30 |
| ralsina | mandel: remember: we *do* have a valid certificate ;-) | 11:30 |
| gatox | maybe not the first, but, something like that | 11:30 |
| mandel | ralsina, the button one should be a scrollable area, since we want to have a max size for the dialog | 11:30 |
| gatox | mandel, let me look for it | 11:30 |
| mandel | gatox, thx! | 11:30 |
| ralsina | ok, a textview or however it's called | 11:30 |
| mandel | ralsina, yeah, that, I uderstood what you meant, I was going to that when I though about it, only ugly part, the arrow :( | 11:32 |
| ralsina | mandel: and I fixed that. I win! ;-) | 11:32 |
| mandel | ralsina, how? there is not an icon with an arrow, is there? | 11:33 |
| ralsina | mandel: there used to be, IIRC, let me see | 11:33 |
| ralsina | mandel: media-playback-start | 11:33 |
| ralsina | HACK! | 11:34 |
| mandel | ralsina, ugly hack! that is going to look terrible! | 11:34 |
| ralsina | mandel: yes, let me find something better | 11:34 |
| gatox | ralsina, mandel SP_ArrowLeft | 11:34 |
| gatox | in QStyle | 11:34 |
| gatox | StandardPixmap | 11:35 |
| ralsina | mandel: QToolButton, check arrowType | 11:35 |
| ralsina | mandel: gatox's is better :-) | 11:35 |
| mandel | yeah for gatox !!!!! | 11:35 |
| gatox | you can use it in a button, like this: QPushButton(self.style().standardIcon(QStyle.SP_ArrowLeft), 'button text') | 11:35 |
| mandel | also, should be pointing right, but we are there :) | 11:35 |
| mandel | SP_ArrowRight | 11:36 |
| ralsina | mandel: better: SP_ArrowForward | 11:36 |
| ralsina | mandel: that works even when the app is changed for RTL languages | 11:36 |
| ralsina | we don't need it but is a good habit :-0 | 11:37 |
| mandel | ok | 11:37 |
| mandel | ralsina, gatox mierda, is not the correct arrow! http://ubuntuone.com/4O1utO8zUfuwYzuXMEXQ3O | 11:41 |
| gatox | mandel, that arrow is going to change depending on the os theme | 11:41 |
| gatox | but is always going to be a right arrow of some kind | 11:42 |
| ralsina | mandel: I think what you need is not an arrow, it's the "expand" icon/decoration? | 11:42 |
| mandel | ralsina, yeah, something like that | 11:42 |
| ralsina | mandel: in a QTreeWidget, is it the right one? | 11:43 |
| ralsina | right as in correct | 11:43 |
| mandel | ralsina, let me check | 11:43 |
| mandel | ralsina, yes that looks very very close | 11:45 |
| mandel | ralsina, I see some pixel diffs but I'm sure that is just me | 11:45 |
| ralsina | because you could use a Qtreewidget with a single row for the arrow and the label, but it's getting complex :-( | 11:45 |
| mandel | ralsina, maybe QStyle::PE_IndicatorArrowRight | 11:46 |
| gatox | mandel, ping | 11:47 |
| mandel | gatox, pong!! | 11:47 |
| gatox | mandel, look at db_to_u1 rev 5 | 11:47 |
| ralsina | mandel: that's not an image, I think | 11:47 |
| mandel | ralsina, its a primitive, but is the one used for the arrows, right? | 11:47 |
| gatox | mandel, central_widget file, ExplorerFrame class, methods show_login, hide_login | 11:47 |
| mandel | gatox, ok | 11:48 |
| gatox | mandel, execute that versoin to see if that is what you want | 11:48 |
| mandel | gatox, I think with that and some work using the primitive it will work | 11:51 |
| gatox | mandel, great | 11:51 |
| * ralsina walks himself | 12:13 | |
| ralsina | will be back in 30' | 12:13 |
| gatox | nessita, hi | 12:16 |
| nessita | hola gatox! | 12:17 |
| nessita | and hello world! | 12:17 |
| gatox | nessita, do you have time for some reviews? | 12:17 |
| alecu | he-llo! | 12:17 |
| gatox | alecu, hi | 12:18 |
| nessita | gatox: yes | 12:18 |
| nessita | gatox: I know I have the style one | 12:18 |
| gatox | nessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/931452 - https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/sso-styling - https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/quota-warning - https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/reconnect-button | 12:18 |
| nessita | on those! | 12:19 |
| gatox | i've recheck the cp ones this morning and resolve a conflict..... | 12:19 |
| nessita | nice | 12:24 |
| nessita | gatox: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/931452/+merge/93003 approved with comment, please address before globally approving | 12:50 |
| gatox | nessita, ok | 12:50 |
| gatox | nessita, sorry.... i'm using that in those methods....... | 12:52 |
| gatox | or you mean only that and not the other asserts? | 12:52 |
| nessita | gatox: let me look at it JIC | 12:53 |
| nessita | gatox: you're not using the helper there | 12:53 |
| nessita | gatox: see diff lines 412 to 420 | 12:53 |
| nessita | gatox: my point is use assert_backend_called instead | 12:54 |
| nessita | oh, and I just got a test failue :-/ | 12:54 |
| nessita | gatox: so I will change my vote to needs fixing until the test is fixes, pasting the error in the MP | 12:54 |
| gatox | nessita, ok..... i'll check the test failure now..... but i don't understand the assert_backend_called part.... i'm seeing the line in that method that call to assert_backend_called....... or am i missing something? | 12:55 |
| nessita | gatox: in the line of the diff 412, what do you see? | 12:55 |
| gatox | nessita, self.assertIn('validate_email_and_ping', self.ui.backend._called) | 12:56 |
| nessita | gatox: that is not assert_backend_called | 12:56 |
| nessita | assert_backend_called is in line 419 | 12:56 |
| gatox | nessita, yes, assert_backend_called is at the end of the method..... that why i ask if you want me to remove the others asserts | 12:56 |
| nessita | gatox: well, they don't test something extra, do they? | 12:57 |
| gatox | nessita, ok | 12:57 |
| nessita | gatox: is an honest question :-) do they? | 12:57 |
| nessita | (perhaps I'm missing something) | 12:57 |
| gatox | nessita, i don't think so | 12:57 |
| nessita | ok, then I think is better to remove that | 12:57 |
| gatox | nessita, ok, remove that.... and the test are ok now | 12:59 |
| nessita | gatox: ack... you ran the whole suite? | 13:00 |
| gatox | nessita, qt part..... i'm in precise and i can't run the whole suite yet | 13:00 |
| nessita | gatox: why? you should be able | 13:01 |
| nessita | gatox: you have nightlies? everything up to date? | 13:01 |
| gatox | nessita, i'm looking at that right now.... i need the gtk3reactor..... | 13:01 |
| nessita | gatox: what does apt-cache policy python-twisted-core says? | 13:03 |
| gatox | nessita, python-twisted-core: | 13:04 |
| gatox | Installed: 11.1.0-1 | 13:04 |
| gatox | Candidate: 11.1.0-1ubuntu1 | 13:04 |
| gatox | Version table: | 13:04 |
| gatox | 11.1.0-1ubuntu1 0 | 13:04 |
| gatox | 500 http://archive.ubuntu.com/ubuntu/ precise/main amd64 Packages | 13:04 |
| gatox | *** 11.1.0-1 0 | 13:04 |
| gatox | 100 /var/lib/dpkg/status | 13:04 |
| gatox | mmmmm | 13:04 |
| gatox | do i need nightlies for that too? | 13:04 |
| nessita | gatox: yes... but the simple fact of having nightlies ppa installed, should give you that | 13:05 |
| nessita | gatox: what does apt-cache policy ubuntu-sso-client says? | 13:05 |
| gatox | nessita, ubuntu-sso-client: | 13:06 |
| gatox | Installed: 3.1+r842-30~oneiric1 | 13:06 |
| gatox | Candidate: 3.1+r842-30~oneiric1 | 13:06 |
| gatox | Version table: | 13:06 |
| gatox | *** 3.1+r842-30~oneiric1 0 | 13:06 |
| gatox | 100 /var/lib/dpkg/status | 13:06 |
| gatox | 2.99.4-0ubuntu1 0 | 13:06 |
| gatox | 500 http://archive.ubuntu.com/ubuntu/ precise/main amd64 Packages | 13:06 |
| gatox | could it be that everything waas reverted in the upgrade? | 13:06 |
| gatox | i KNOW i had nightlies for u1-client | 13:06 |
| nessita | gatox: how did you upgrade? (does not look like you are in P ) | 13:06 |
| nessita | gatox: the package says "oneiric" :-/ | 13:06 |
| gatox | nessita, update-manager -d | 13:06 |
| nessita | gatox: did you add the ppa for precise? | 13:07 |
| gatox | nessita, | 13:07 |
| gatox | gatox@utopia:~$ lsb_release -a | 13:07 |
| gatox | No LSB modules are available. | 13:07 |
| gatox | Distributor ID:Ubuntu | 13:07 |
| gatox | Description:Ubuntu precise (development branch) | 13:07 |
| gatox | Release:12.04 | 13:07 |
| gatox | Codename:precise | 13:07 |
| gatox | gatox@utopia:~$ | 13:07 |
| nessita | gatox: can you please run: sudo apt-add-repository ppa:ubuntuone/nightlies; sudo apt-get update; sudo apt-get dist-upgrade | 13:07 |
| gatox | ok | 13:08 |
| gatox | nessita, but i'm in precise, look at that ^ | 13:08 |
| nessita | gatox: yeah, the but you're not running precise nigthlies apparently | 13:08 |
| gatox | nessita, ok..... running the repo-add, update, upgrade | 13:09 |
| nessita | ack! | 13:09 |
| nessita | gatox: in the controlpanel quota warning branch, you added the constant FREE_ACCOUNT_SIZE and is 5368709120. But the QUOTA_THRESHOLD_ACCOUNTS has: | 13:12 |
| nessita | {'free': 536870912, 'pay': 3221225472} | 13:12 |
| gatox | nessita, reviewing.... | 13:13 |
| nessita | gatox: also, when cutting an if guard in multiple lines, you need to indent the second line like this: | 13:14 |
| nessita | if something_really_long and\ | 13:15 |
| nessita | please_indent_this_part: | 13:15 |
| nessita | gatox: also, any reason to remove the unicode from the RED constant? everything should be an unicode | 13:18 |
| ralsina | Whoa, I am finally on precise for real! I have to reboot, which in my experience will take about 10 minutes because it fscks every time. Sowill be back soonish! | 13:18 |
| mandel | ralsina, lol | 13:19 |
| gatox | nessita, no, reverting.. | 13:19 |
| gatox | nessita, 536870912 is ok | 13:21 |
| gatox | nessita, the FREE_ACCOUNT_SIZE is 5gb and the other one: QUOTA_THRESHOLD_ACCOUNTS is 0.5gb..... to ask if the available space is less than that | 13:22 |
| nessita | gatox: right, but isn't it clearer to use FREE_ACCOUNT_SIZE * 0.1? (ie the 10% of it) | 13:22 |
| nessita | gatox: my proposal is to use instead: | 13:23 |
| nessita | FREE_ACCOUNT_SIZE = (BYTES**3) * 5 # 5 gigs | 13:24 |
| nessita | QUOTA_THRESHOLD_ACCOUNTS = {'free': FREE_ACCOUNT_SIZE * 0.1, # 10% of the free account size | 13:24 |
| nessita | 'pay': (BYTES**3) * 3} # 3 gigs | 13:24 |
| nessita | gatox: so, next time someone reads that, does not have to do all the math we both just did :-D | 13:24 |
| mandel | ok, time for my lunch | 13:24 |
| mandel | bbl | 13:24 |
| gatox | nessita, mmmm maybe i'm wrong, but i don't think so, because that number is not a percentage is a exact number.... yes, it gives you the same result.... but we are inn the same situation as before that we were using percentage....... maybe we could add a comment above the quota_threshold_accounts variable | 13:25 |
| nessita | gatox: for free account, it's the 10% | 13:25 |
| gatox | ok | 13:26 |
| gatox | nessita, done | 13:37 |
| nessita | gatox: yey! and reconnect-button is approved | 13:37 |
| gatox | nessita, great....... still downloading nightlies here....... :S | 13:38 |
| nessita | gatox: JIC, did you saw the other comment I made in the quota warning MP? | 13:38 |
| nessita | did you see* | 13:38 |
| gatox | nessita, the unicode red one? | 13:38 |
| nessita | gatox: that also, but I also added a comment in the MP, in LP | 13:39 |
| nessita | about the indentantion | 13:39 |
| gatox | nessita, yes..... i fix that too as we talk in your home once, aligning the second line where the first word not if or elif start | 13:39 |
| gatox | is that ok? | 13:40 |
| nessita | so the second line has to be aligned with the start of whatever is next to the if, let me give you an example | 13:40 |
| gatox | yes, that's what i did | 13:41 |
| gatox | nessita, ^ | 13:41 |
| nessita | gatox: an example http://pastebin.ubuntu.com/845816/plain/, let me re-check what you did | 13:42 |
| gatox | yes, i did that | 13:42 |
| nessita | gatox: ah, ok. So I suggested another way of putting that logic using variables, but no need to change | 13:46 |
| nessita | having the proper indentantion is enough | 13:46 |
| gatox | nessita, wait! | 13:46 |
| gatox | nessita, ahhhhhhh that! using variables.... i miss that part | 13:46 |
| gatox | i only read about the indentation | 13:46 |
| gatox | nessita, i can change it if you want | 13:47 |
| nessita | gatox: how do you like that better? | 13:50 |
| gatox | nessita, you know i'm from the tribe that doesn't tend to create variables to assign boolean results :P.... but i can change it if you think that will improve the readability | 13:51 |
| gatox | (boolean results to be used in ifs) | 13:51 |
| nessita | hahahaha | 13:52 |
| nessita | gatox: what I don't like if having stuff like: | 13:52 |
| nessita | if a: | 13:52 |
| nessita | return True | 13:52 |
| nessita | else: | 13:52 |
| nessita | return False | 13:52 |
| nessita | I strongly prefer: | 13:52 |
| nessita | return a | 13:52 |
| nessita | this case is a bit more complex but kinda similar | 13:52 |
| gatox | nessita, ahhhhhhh i understand now..... i thought you were just saying to do: var = int_bytes_total > FREE_ACCOUNT_SIZE....... and use var in the if..... i see your point now | 13:53 |
| gatox | i'll change that! | 13:53 |
| nessita | :-) | 13:53 |
| ralsina | Oh thanks apport for showing me 152 crash dialogs for everything that has died in the last 3 days. Sigh | 13:57 |
| gatox | nessita, done (the removal of that lines in sso tests) | 14:18 |
| ralsina | Has anyone been running pylint on P lately? Because I am getting a ton of errors :-/ | 14:19 |
| gatox | ralsina, me too | 14:19 |
| ralsina | gatox: ok, so it's not this screwed up thing | 14:19 |
| gatox | ralsina, i mean, i can run it.... but sometimes crash, and other times show a lot of not real issues | 14:19 |
| ralsina | the old "TypeError: C++ type 'QWidget*' is not supported as type" is back, and now the import QtGui first hack doesn fix it | 14:20 |
| ralsina | which makes it pretty much useless | 14:20 |
| gatox | cof cof pyflakes cof cof | 14:20 |
| dobey | ralsina: in windows-installer i guess? | 14:21 |
| ralsina | gatox: here, have a gargaleta :-) | 14:21 |
| ralsina | dobey: worse, in ussoc | 14:21 |
| gatox | ralsina, jeje | 14:22 |
| dobey | ralsina: that's quite odd, as tarmac certainly runs the lint checks | 14:22 |
| nessita | ralsina: I'm not getting any pylint issue | 14:22 |
| nessita | gatox: you're getting those because you still don't have nightlies in P, no? | 14:22 |
| nessita | ralsina: have nightlies installed? | 14:22 |
| ralsina | oh,Idon't have nightlie either | 14:22 |
| ralsina | getting them | 14:22 |
| nessita | ralsina: ajá! | 14:22 |
| nessita | :-) | 14:23 |
| gatox | nessita, mmmm maybe with that it'll work..... nighlies are still being installed | 14:23 |
| nessita | dobey: missing nightlies on ralsina ;-) | 14:23 |
| gatox | i don't know why i lost the niightlies in the upgrade | 14:23 |
| dobey | heh | 14:23 |
| dobey | gatox: because the PPA gets disabled for upgrade | 14:24 |
| nessita | gatox: a ppa targets an ubuntu release, so I don't think that upgrade-manager -d will change your .sources files | 14:24 |
| gatox | dobey, ahhhh | 14:24 |
| gatox | nessita, everything is working now | 14:24 |
| nessita | gatox: <will & grace "told you so" dance> told you so! told you so! </will & grace "told you so" dance> | 14:25 |
| nessita | :-P | 14:25 |
| gatox | jejejjejeee | 14:25 |
| nessita | gatox: you know what that dance is? | 14:25 |
| gatox | no...... but i imagine you dancing and singing that and it's funny jeje :P | 14:26 |
| === m_conley_away is now known as m_conley | ||
| nessita | gatox: http://www.youtube.com/watch?v=IV4sB7O97ro | 14:27 |
| dobey | nessita: the upgrader does disable PPA sources on upgrade, and don't re-enable them when finished. it doesn't really matter what series is targeted by the PPA itself | 14:27 |
| * gatox watching--- | 14:27 | |
| gatox | dobey, i just re-enabled them again from synaptic | 14:28 |
| nessita | gatox: FYI, I have the whole avis for that series | 14:28 |
| gatox | nessita, jejeje was pretty much close to what i imagine :P | 14:28 |
| dobey | ugh, synaptic | 14:28 |
| gatox | dobey, well..... for some reason i can't find "software sources" | 14:29 |
| dobey | gatox: software-properties-gtk | 14:29 |
| gatox | yep..... that doesn't appear in the search | 14:30 |
| dobey | search? | 14:36 |
| * mandel back | 14:36 | |
| mandel | ralsina, 1-1 after the stand up? | 14:36 |
| ralsina | mandel: no need, I think | 14:36 |
| ralsina | mandel: we talked yesterday. We should re-schedule for before the team call | 14:36 |
| mandel | ralsina, we can do one super fast, got news regarding proxy | 14:36 |
| ralsina | mandel: sure, now or later? | 14:37 |
| mandel | ralsina, after the stand up? | 14:37 |
| dobey | gatox: software-properties-gtk is installed by default… you should be able to run that command from the terminal | 14:37 |
| gatox | dobey, yes, from the terminal is ok.... but for some reason is not appearing in the dash search anymore | 14:37 |
| dobey | gatox: because the .desktop file has NoDisplay=true for some reason | 14:39 |
| gatox | dobey, ahhhhh thanks! mistery solved! | 14:39 |
| dobey | gatox: i guess the way you're supposed to get to it now, is via software-center | 14:40 |
| gatox | dobey, ahhhhh yes, it's there | 14:41 |
| nessita | ralsina: when you have a chance, would you please? https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/center-me/+merge/93582 | 14:46 |
| ralsina | nessita: sure | 14:47 |
| nessita | gatox: you left this in the code: QUOTA_THRESHOLD_ACCOUNTS = {'free': 536870912, 'pay': 3221225472} | 14:48 |
| nessita | (ie we now have 2 QUOTA_THRESHOLD_ACCOUNTS) | 14:48 |
| cjohnston | did anything happen overnight? i lost 35gigs of files? | 14:49 |
| gatox | nessita, grrrrr.... fixiing | 14:49 |
| nessita | gatox: other than that, looks good! | 14:50 |
| nessita | cjohnston: what do you mean you lost 35G of files? | 14:50 |
| gatox | nessita, done | 14:51 |
| cjohnston | yesterday i had ~120 gigs of files, this morning 84gigs of stuff.. | 14:51 |
| nessita | cjohnston: did you remove any UDF, from either the cloud or your computer? | 14:51 |
| nessita | (from any of your devices) | 14:51 |
| cjohnston | udf? | 14:52 |
| nessita | cjohnston: sorry, a syncrhonized "folder" outside your Ubuntu One folder | 14:52 |
| nessita | like Pictures, or Videos, etc | 14:53 |
| cjohnston | no | 14:53 |
| cjohnston | i still have 2.. | 14:53 |
| nessita | cjohnston: do you see everything (every folder, etc) in the web UI? | 14:53 |
| cjohnston | i see the two main folders... | 14:54 |
| cjohnston | webui is reporting it lower also | 14:54 |
| nessita | beuno: ping... does that ^ ring any bell? were there any quota recalculation? | 14:54 |
| ralsina | nessita: about center-me, the code is fine, but isn't it rude for the app to choose it's placement? | 14:54 |
| cjohnston | nessita: i have files that are missing | 14:54 |
| beuno | nessita, nope | 14:54 |
| cjohnston | ie. from my desktop | 14:54 |
| nessita | ralsina: I don't think so... we do it with the gtk control panel | 14:54 |
| ralsina | nessita: ok then | 14:55 |
| cjohnston | a whole bunch of stuff says it was modified 2 hours ago | 14:55 |
| nessita | cjohnston: was/is the desktop a synchtonized folder? | 14:55 |
| cjohnston | its ~/Ubuntu One/Desktop | 14:55 |
| cjohnston | and i just point the desktop to that | 14:55 |
| nessita | cjohnston: and you sure you or someone else did not remove those? | 14:55 |
| nessita | or moved to another location | 14:56 |
| cjohnston | if they broke into my house | 14:56 |
| nessita | cjohnston: do you have the missing files in the trash? | 14:56 |
| nessita | rye or duanedesign: do you guys have some time to do some follow up on some files missing for cjohnston? ^ | 14:57 |
| cjohnston | it seems as though some of them may be | 14:58 |
| ralsina | me | 15:00 |
| gatox | me | 15:00 |
| alecu | me | 15:00 |
| nessita | me | 15:00 |
| briancurtin | me | 15:00 |
| gatox | mandel, dobey ? | 15:00 |
| mandel | me | 15:01 |
| dobey | meh | 15:01 |
| nessita | ralsina: go! | 15:01 |
| ralsina | DONE: team call, design call, nessita call, brian call, diego call, (notice a theme here?), reviews, scraper for Ted Talks, misc, TODO: bug #933758 and random bits and pieces, BLOCKED: no | 15:01 |
| ralsina | gatox: if you please | 15:01 |
| gatox | DONE: | 15:01 |
| gatox | Proposed SSO UI style branch, fixed some other branches. Started working on captcha problem with sso-login-qt | 15:01 |
| gatox | TODO: | 15:01 |
| gatox | Finish with the captcha issue, enjoy looong weekend. | 15:01 |
| gatox | BLOCKED: | 15:01 |
| gatox | No | 15:02 |
| gatox | alecu, go | 15:02 |
| alecu | DONE: tunnel progressing, team meeting, catched up with canonicaladmin | 15:02 |
| alecu | TODO: improve bugs for ffe, send them to joshua | 15:02 |
| alecu | BLOCKED: no | 15:02 |
| alecu | NEXT: nessita | 15:02 |
| nessita | DONE: weekly call, releases, filed FFe, 1-1 with ralsina, started fix for bug #933632 | 15:02 |
| nessita | TODO: lots of reviews, finish bug #933632, have half day off | 15:02 |
| nessita | BLOCKED: nopes | 15:02 |
| nessita | NEXT: briancurtin | 15:02 |
| briancurtin | DONE: lost half of my day trying and failing to setup LXC, corrected the volume signal implementation to provide more info | 15:02 |
| briancurtin | TODO: see if i can get this linux box setup properly to test, otherwise complete it on windows and come back to the setup | 15:02 |
| briancurtin | BLOCKED: none | 15:02 |
| briancurtin | NEXT: mandel | 15:02 |
| mandel | DONE: Found some small issues with the point2point tests on proxy support. Worked on SSL dialog before landing fixes to proxy. | 15:02 |
| mandel | TODO: more SSL dialog work. Move back to proxy. 1-1 ralsina. | 15:02 |
| mandel | BLOCKED: no | 15:02 |
| mandel | dobey, please | 15:02 |
| dobey | λ DONE: team call, twisted gireactor backport for precise, u1client upload depending on new twisted, some pyqt package splitting | 15:02 |
| dobey | λ TODO: finish pyqt splitting, twisted docs, music store call | 15:02 |
| dobey | λ BLCK: none. | 15:02 |
| ralsina | dobey: we are already doing backports for precise? How can that be if it's not even released? :-D | 15:02 |
| dobey | ralsina: backport from trunk, to precise | 15:04 |
| ralsina | dobey: ack | 15:04 |
| mandel | ralsina, 1-1 in 10 mins? | 15:06 |
| ralsina | mandel: sure, ping me whenever | 15:06 |
| mandel | nessita, why do I get complains from pep8 regarding # -*- coding: utf-8 -*- => E261 at least two spaces before inline comment | 15:08 |
| duanedesign | hello cjohnston | 15:08 |
| ralsina | mandel: you have a space before the #? | 15:08 |
| cjohnston | hey duanedesign want to take to PM? | 15:08 |
| duanedesign | cjohnston: you read my mind :) | 15:08 |
| mandel | ralsina, no | 15:08 |
| nessita | mandel: may be misplaced in the file. It has to be first line... is it? wnat to show the code? | 15:08 |
| mandel | nessita, is in the first line.. weird | 15:09 |
| nessita | mandel: show the code! | 15:09 |
| * nessita accepts the challenge | 15:09 | |
| mandel | nessita, one sec, I'll psuh it :) | 15:09 |
| nessita | gatox: /931452/ approved | 15:11 |
| mandel | nessita, in lp:~mandel/ubuntu-sso-client/ssl-dialog file ubuntu_sso/qt/arrow.py | 15:11 |
| nessita | gatox: can you please trivialish review? https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/center-me/+merge/93582 | 15:12 |
| joshuahoover | ralsina: can you be in #ubuntu-release in 50 min (@ 16:00 utc) to discuss space for u1 on the cd? | 15:12 |
| gatox | nessita, yep, on it | 15:12 |
| ralsina | joshuahoover: sure | 15:12 |
| joshuahoover | ralsina: thx | 15:12 |
| nessita | mandel: nessita@dali:~/canonical/ussoc/review_ssl-dialog$ ls ubuntu_sso/qt/arrrow.py | 15:12 |
| nessita | ls: cannot access ubuntu_sso/qt/arrrow.py: No such file or directory | 15:12 |
| joshuahoover | ralsina: as it stands now, it sounds like there won't be room, but you know more about this than i do and can chat about with waaaaay more intelligence :) | 15:13 |
| mandel | nessita, arrow.py not arrrow :) | 15:13 |
| nessita | ls: cannot access ubuntu_sso/qt/arrow.py: No such file or directory | 15:13 |
| nessita | mandel: you did not add the file yet? | 15:13 |
| ralsina | joshuahoover: the right person for knwing about this is dobey :-) | 15:14 |
| mandel | nessita, bzr st returns nothing, so yes | 15:14 |
| gatox | nessita, question?? you are defyning this: size = lambda *a: gui.QtCore.QSize(123456, 654321) but at least in the diff i don't see that this variable is used..... | 15:14 |
| ralsina | joshuahoover: I know much less than he does | 15:14 |
| nessita | gatox: is used from the "live" code, in: | 15:14 |
| nessita | mandel: did you push it? is not in the branch | 15:15 |
| nessita | gatox: 31+ window.size(), app.desktop().availableGeometry()) | 15:15 |
| mandel | nessita, yes, I did a bzr sync-pipeline.. bloody hell let me check | 15:15 |
| gatox | nessita, ahhhhh, it's a fake | 15:15 |
| nessita | yes! :-) | 15:15 |
| dobey | nessita: did you file that bug btw? | 15:15 |
| nessita | dobey: no... was hoping ralsina will defend that. Let me update him | 15:16 |
| gatox | nessita, now you can do the told you dance again, because only the diff didn't give me the proper context | 15:16 |
| gatox | jejeje | 15:16 |
| gatox | nessita, approve | 15:16 |
| nessita | ralsina: hola! so, this morning we had an informal conversation with some of the platform guys, regarding space in the CD | 15:16 |
| mandel | nessita, fixed, can you remove that branch and branch again | 15:17 |
| nessita | ralsina: basically they want a bug report where we justify why we want to use the Qt controlpanel instead of using the same Gtk one | 15:17 |
| ralsina | nessita: it's reasonable | 15:18 |
| nessita | ralsina: I will open the bug and put some things in there, but we certainly we'll need more info in there, that I think you have (and perhaps John as well) | 15:18 |
| ralsina | nessita: cool, I will put the info in it | 15:18 |
| mandel | ralsina, mumble? | 15:20 |
| ralsina | mandel: sure | 15:21 |
| * gatox lunch | 15:22 | |
| === gatox is now known as gatox_lunch | ||
| === gatox_lunch is now known as gatox | ||
| ralsina | nessita: on ussoc, how can I add a test for timeout_func that only runs when we are using Qt? | 15:45 |
| nessita | ralsina: let me give that some thoughts | 15:45 |
| dobey | ralsina: @skipIf('qt' in sys.modules and sys.modules['qt'] is not None) ? | 15:46 |
| ralsina | nessita: it does need tests because it's much less trivial than the glib one | 15:46 |
| ralsina | dobey: it's an idea | 15:46 |
| dobey | i guess @skipIf has a second argument for reason, which would be 'Not running under Qt' | 15:47 |
| dobey | ralsina: you can change the conditional to be more precise for the situation obviously. i was just pseudo-coding that up :) | 15:47 |
| ralsina | dobey: yes, I imagined that ;-) | 15:48 |
| nessita | ralsina, dobey: wait! I'm sure theres a better way :-D | 15:48 |
| nessita | let me find it | 15:48 |
| ralsina | nessita: it's ok, Iam notin a hurry | 15:48 |
| nessita | gatox:quota warning approved | 15:54 |
| gatox | nessita, thanks | 15:54 |
| nessita | ralsina: so, currently there is no way. We have no tests for the main/qt.py module, and eve if you use the decorator that will not work to actual run test | 15:55 |
| nessita | ralsina: since the test will "never" be run | 15:55 |
| nessita | ralsina: no, wait, I'm confused | 15:56 |
| nessita | ralsina: scratch all that | 15:56 |
| * ralsina waits. | 15:56 | |
| * ralsina scratches | 15:56 | |
| nessita | ralsina: there is a way, and a clean one :-) | 15:56 |
| ralsina | neat :-) | 15:56 |
| nessita | in run-tests script, change the line: | 15:56 |
| nessita | u1trial --reactor=gi -p "$DBUS_TESTS_PATH, $QT_TESTS_PATH, $GTK_TESTS_PATH" -i "$WINDOWS_TESTS" "$MODULE" | 15:56 |
| nessita | to also ignore the main/tests/test_qt.py you're adding | 15:56 |
| nessita | and you're set, the new tests will be run by the last line in that script (the one that reads $XVFB_CMDLINE u1trial -p "$GTK_TESTS_PATH" -i "$WINDOWS_TESTS" --reactor=qt4 --gui "$MODULE") | 15:57 |
| ralsina | nessita: ok, will do it after meeting and lunch | 15:58 |
| nessita | ack! | 15:58 |
| dobey | i really hate all the ignore arguments there | 15:58 |
| dobey | i think the skips are cleaner :) | 15:59 |
| dobey | nessita: you will like this: https://code.launchpad.net/~dobey/ubuntuone-installer/qt-foo/+merge/93603 | 16:06 |
| nessita | dobey: looking! | 16:06 |
| nessita | dobey: no tests for that? :-/ | 16:11 |
| dobey | nessita: to test a constant declaration? | 16:12 |
| nessita | dobey: and all the logic around it, spawnning something on some condition, etc | 16:12 |
| dobey | eh | 16:14 |
| ralsina | joshuahoover: I am at ubuntu-release, how does this conersation start? Should I ping someone? | 16:16 |
| joshuahoover | ralsina: good question...maybe ping skaet there | 16:17 |
| dobey | should i be there? | 16:19 |
| ralsina | dobey: I think so, yes | 16:19 |
| ralsina | dobey: come to #ubuntu-meeting please | 16:19 |
| nessita | ralsina: perhpas you should hand the bug # in the meeting? | 16:41 |
| ralsina | nessita: good idea | 16:42 |
| ralsina | argh have to call another mac guy | 16:51 |
| ralsina | nessita: for review: https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix-933758/+merge/93613 | 17:00 |
| * ralsina swears it has no lint! | 17:00 | |
| dobey | i should probably get lunch | 17:02 |
| dobey | bbiab. gonna get some lunch | 17:09 |
| nessita | dobey: the patch I built no longer applies due to more branches landing, but I'm close to have a good now | 17:23 |
| gatox | nessita, ralsina when you have a moment: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/captcha-qt-not-working/+merge/93618 | 17:25 |
| nessita | gatox: that will have to remain for the next week | 17:25 |
| gatox | nessita, i also fix a problem with the terms checkbox.... | 17:25 |
| gatox | the condition wasn't ok | 17:25 |
| nessita | I'm already using my half day off | 17:25 |
| gatox | nessita, ok | 17:26 |
| nessita | gatox: what part was buggy? | 17:26 |
| gatox | nessita, when you modified that you did: if self.terms_checkbox.isVisible():..... and that should be: if not self.terms_checkbox.isVisible():....... and i didn't notice that either when i review it | 17:26 |
| nessita | oh uh | 17:27 |
| rmcbride | davidcalle: any ideas as to why I would not see content in the video lens? | 17:28 |
| davidcalle | rmcbride, no videos in your video folder? | 17:29 |
| rmcbride | davidcalle: I have a few in the folder. wasn't sure if I needed to do something to index them first | 17:29 |
| davidcalle | rmcbride, nope, it should pick everything in there. Is it working with the remote videos (if you do a search) ? | 17:30 |
| rmcbride | davidcalle: actually, it is not working with that either | 17:30 |
| davidcalle | rmcbride, hum. Have you launched it manually or just install log out log in? | 17:31 |
| rmcbride | davidcalle: AFAIK, it installed with my most recent update after which I rebooted | 17:31 |
| davidcalle | rmcbride, what is the terminal output of "/usr/lib/unity-lens-video/unity-lens-video" ? | 17:33 |
| rmcbride | davidcalle: strangely, "no such file or directory" | 17:34 |
| rmcbride | I guess that would explain part of it... lens UI does display though | 17:34 |
| rmcbride | davidcalle: Apparently I assumed from that the lens was actually there. | 17:35 |
| rmcbride | davidcalle: which doesn't appear to be the case. thanks! | 17:36 |
| davidcalle | rmcbride, hum. If the lens is visible, this file should be here... | 17:36 |
| rmcbride | davidcalle: the pakcage was not in fact installed. | 17:36 |
| rmcbride | it is now | 17:36 |
| davidcalle | And the lens was visible... Wow. This is odd. | 17:37 |
| rmcbride | though from your earlier comment I'd guess I need to relog | 17:37 |
| davidcalle | rmcbride, indeed. | 17:37 |
| rmcbride | davidcalle: checking that on another precise box next. That scenario could tend towards user confusion (if it wasn't just a wierdness due to my dev environment) | 17:39 |
| rmcbride | nope. the video lens selection doesn't even appear on the laptop. | 17:39 |
| davidcalle | rmcbride, this shouldn't happen, I mean, if the lens is not installed, it shouldn't appear in the Dash, or maybe you installed it in some other way earlier? | 17:40 |
| ralsina | rmcbride: sounds like you installed it from source. Why did you do that? ;-) | 17:40 |
| rmcbride | ralsina: I'm not certain what happened on the dev box. I don't recall installing it from source | 17:41 |
| rmcbride | davidcalle: it's possible that I did something when I was poking at the ubuntu TV stuff perhaps? | 17:41 |
| rmcbride | in any case the lens functions as expected after relogging | 17:42 |
| davidcalle | rmcbride, oh right! If you have installed some ubuntu TV stuff, you should try to remove the /usr/share/unity/lenses/video folder. | 17:43 |
| davidcalle | Then, reinstall the unity-lens-video package. It will recreate it. | 17:43 |
| rmcbride | davidcalle: OK, thanks! | 17:44 |
| davidcalle | That's my best guess. | 17:45 |
| rmcbride | oh rock and roll. Amazon results. | 17:45 |
| davidcalle | Working? :) | 17:45 |
| rmcbride | it is :) | 17:46 |
| davidcalle | rmcbride, cool | 17:46 |
| rmcbride | Yes. Working quite well. Didn't even need to delete that folder, the package installation and relog changed the filter scope | 17:48 |
| rmcbride | and everythign works identically on the dev machine and the untainted laptop | 17:48 |
| davidcalle | rmcbride, great :) | 17:49 |
| davidcalle | Got to go! Ping me if you have any questions. | 17:49 |
| rmcbride | davidcalle: of course now I have to hook up one of my machiens to the TV :) good stuff! | 17:49 |
| nessita | lunchtime! | 17:50 |
| ralsina | grmbl run-tests from ussoc is not running pep8 even when it's installed. Fixing pep8 sins manually :-/ | 17:56 |
| ralsina | gatox: can I get a review? https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix-933758/+merge/93613 | 18:03 |
| gatox | ralsina, yes, of course | 18:04 |
| ralsina | gatox: thanks! | 18:04 |
| dobey | nessita: it should apply to 2.99.4 though no? | 18:10 |
| gatox | ralsina, +1 | 18:10 |
| nessita | dobey: yes, about to upload now | 18:11 |
| ralsina | gatox: thanks! | 18:11 |
| dobey | nessita: great | 18:11 |
| Chipaca | ok, that's the TED and Encuentro sources added | 18:12 |
| Chipaca | enjoy :) | 18:12 |
| nessita | dobey: uploaded | 18:14 |
| ralsina | nessita: if you have 5' later for smallish review, https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix-933758/+merge/93613 (sorry if I already asked) | 18:20 |
| nessita | ralsina: doing it already, about to ask to fix this if possible: | 18:21 |
| nessita | test_timeout_func_keeps_reference ... Traceback (most recent call last): | 18:21 |
| nessita | File "/home/nessita/canonical/ussoc/review_fix-933758/ubuntu_sso/main/qt.py", line 44, in _callback | 18:21 |
| nessita | TIMERS.remove(timer) | 18:21 |
| nessita | KeyError: <PyQt4.QtCore.QTimer object at 0x312ec20> | 18:21 |
| nessita | [OK] | 18:21 |
| ralsina | nessita: it shouldn't do that | 18:22 |
| nessita | it does here :-/ | 18:22 |
| ralsina | nessita: it's a race condition. I'll take a look | 18:22 |
| nessita | thanks! | 18:22 |
| nessita | ralsina: great news, it works! :-D | 18:23 |
| dobey | i wish we could get rid of all the ignore arguments being passed to u1trial | 18:25 |
| ralsina | dobey: there is only one of those | 18:26 |
| ralsina | dobey: with two modules in it after my branch, though | 18:26 |
| dobey | ralsina: i mean, get rid of using them entirely, in all our projects, and just use @skipIf and such | 18:27 |
| ralsina | dobey: can we skip whole testcases? If yes, then that's doable | 18:27 |
| dobey | ralsina: hrmm. should be able to. we can with foo.SKIP = "BLAH" i think decorator will work too | 18:28 |
| ralsina | dobey: file a wishlist? | 18:28 |
| dobey | perhaps | 18:30 |
| nessita | dobey: we have bigger issues than just skipping I test case... we have import errors if we don't ignore some files | 18:30 |
| nessita | for example, the test_windows.py module | 18:30 |
| dobey | nessita: right, though i think we can fix that too | 18:31 |
| nessita | dobey: with try-excepts? :-/ | 18:31 |
| dobey | i don't know | 18:31 |
| dobey | i know twisted itself doesn't have any such ignores, and they support all kinds of insanity. and tests with missing dependencies just get skipped when they should | 18:32 |
| dobey | they have some extra magic as well i think, which auto-skips certain things when imports fail | 18:32 |
| ralsina | nessita: can you re-run the tests with revno 881? | 18:32 |
| nessita | ralsina: sure | 18:32 |
| ralsina | nessita: not really happy about the fix, but there is a chance that more than one call to the callback is queued, so the second one executes when the timer is already removed from the set | 18:33 |
| nessita | ralsina: all green now, looking at the new diff | 18:47 |
| ralsina | nessita: cool | 18:47 |
| nessita | ralsina: so, since you just said that _callback could be called twice, shouldn't you call callback only when timer is in TIMERS? | 18:48 |
| ralsina | nessita: good idea | 18:50 |
| ralsina | nessita: I'll push that change in 1 sec | 18:52 |
| ralsina | nessita: pushed revno 882 with that fixed and a nicer usageof kw.pop() | 18:57 |
| nessita | ack | 18:58 |
| dobey | i am so not fond of the writing of wasteful tests | 18:59 |
| nessita | dobey: I agree. Let's not write wasteful tests :-) | 19:00 |
| nessita | dobey: can I help not writting hose? | 19:00 |
| dobey | nessita: for my installer branch? i'd rather not write tests for 2 if statements; also, pythono-coverage seems to not be very smart sometimes :( | 19:11 |
| nessita | dobey: yes, I personally thinkg we should not use python-coverage at all (or any coverage tool, they are misleading) | 19:11 |
| nessita | dobey: if you have an if if your code, it means that is important somehow do something on a given condition, no? otherwise the if will not be there. And having a test ensuring that is not a wasteful test, at least not from my POV | 19:12 |
| nessita | ralsina: I'm approving, though please note that docstrings for methods do not use empty line above it (Only for classes' docstring) | 19:27 |
| nessita | @ping | 19:27 |
| mandel | nessita, I see you | 19:30 |
| mandel | nessita, maybe ubot is dead :( | 19:30 |
| nessita | right | 19:31 |
| nessita | mandel: thanks! | 19:31 |
| mandel | nessita, np :) | 19:31 |
| mandel | ralsina, how so you draw a circle in QPainter so that it is tanget to the widgets left side? I know it has to do something with setting the painter view port, right? | 19:31 |
| ralsina | mandel: excuse me while I violently context-switch to your question ;-) | 19:32 |
| mandel | ralsina, sure :) | 19:32 |
| ralsina | mandel: the QPainter should have the widget as context | 19:32 |
| ralsina | mandel: in that case, it's just draing a circle with radius X centered at X,X | 19:32 |
| mandel | ralsina, so, if you tell the QPainter to draw a primitive, it draws in so that is in the center.. | 19:33 |
| ralsina | mandel: OTOH, WTF? ;-) | 19:33 |
| mandel | ralsina, let me show you, one sec | 19:33 |
| mandel | ralsina, http://ubuntuone.com/2Jr1UGiJA5hCwYwojfoNBh | 19:36 |
| ralsina | what's the problem? | 19:37 |
| mandel | ralsina, the little arrow has its center in the certer of its widget but I want it to have the side against the widget so that the C gets aligned with the bullets of the lists | 19:37 |
| mandel | ralsina, I find those 2 pixels off very very very annoying | 19:37 |
| ralsina | mandel: where is the code for that widget? | 19:38 |
| mandel | ralsina, I can push it, give me a min or so | 19:38 |
| ralsina | mandel: is the one in your blog? | 19:38 |
| mandel | ralsina, that would be the little arrow, yes :) | 19:38 |
| mandel | ralsina, but let me push the entire thing | 19:38 |
| mandel | ralsina, lp:~mandel/ubuntu-sso-client/ssl-dialog | 19:39 |
| ralsina | mandel: very easy. before doing the drawPrimitive, do p.translate(whatever, whatever) | 19:40 |
| ralsina | the value(s) of whatever are left as an exercise, but ~ 2 | 19:40 |
| ralsina | mandel: and also, may be platform and style dependent | 19:41 |
| mandel | ralsina, yeah.. that is very annoying | 19:41 |
| mandel | ralsina, I mean, the size of the primitive :( | 19:41 |
| ralsina | mandel: sorry, no magical solutions | 19:43 |
| ralsina | mandel: OTOH, *maybe* the problem you are having is something else,like a padding set in the arrow widget | 19:44 |
| nessita | gatox: ping on PM | 19:44 |
| gatox | nessita, pong | 19:45 |
| nessita | gatox: got my private msg? | 19:45 |
| mandel | ralsina, there are padding issues with the label.. | 19:45 |
| gatox | nessita, ahh in the other server | 19:45 |
| * gatox reading.... | 19:45 | |
| ralsina | mandel: that's more likely, since the painter by default should be drawing at 0,0 | 19:46 |
| nessita | gatox: you don't get all the IRC mesasages in the same IRC client? | 19:46 |
| gatox | nessita, yes..... but sometimes i split them in two windows, because i have several channels , and i like to move with alt+[1-9].... sometimes i just close channels :P | 19:47 |
| nessita | heh | 19:47 |
| nessita | alecu, ralsina: can I have some review for https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/fix-933632/+merge/93641 ? | 19:48 |
| ralsina | nessita: of course | 19:55 |
| mandel | ok, EOD for me, is to later here already.. I'll fix that pixel on monday.. | 19:58 |
| dobey | ugh, i can't raise inside a lambda:? boo. | 20:15 |
| ralsina | dobey: well, yes you can. Just define def _raise(exc): raise exc | 20:17 |
| alecu | nessita, I won't be reviewing it today. I'll add it for monday. | 20:18 |
| nessita | alecu: you work on Monday? | 20:18 |
| alecu | nessita, make that "Tuesday" | 20:18 |
| nessita | alecu: hum, is kinda late (nothing should land on Tuesday) | 20:19 |
| alecu | nessita, oh, you need this to land today? didn't realize that. | 20:19 |
| nessita | alecu: yeah :-/ | 20:19 |
| ralsina | nessita: I will do one review, so maybe, if you are confident, you can land with one | 20:19 |
| nessita | alecu: but I can find someone else to do another review, if you can't | 20:20 |
| ralsina | nessita: ask thisfred. It's early for him. | 20:20 |
| thisfred | sure | 20:21 |
| thisfred | what is the branch? | 20:21 |
| nessita | thisfred: welcome back!!! | 20:21 |
| dobey | meh | 20:21 |
| nessita | thisfred: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/fix-933632/+merge/93641 | 20:21 |
| thisfred | :) | 20:21 |
| nessita | dobey: stand up time? :-/ | 20:21 |
| alecu | dobeeh: go! | 20:22 |
| dobey | i really do not like python and writing tests | 20:22 |
| thisfred | nessita: looks great! | 20:30 |
| nessita | yey! | 20:30 |
| nessita | thisfred: are you on precise? | 20:30 |
| thisfred | yes | 20:30 |
| thisfred | and I ran the tests | 20:30 |
| thisfred | or no wait | 20:31 |
| thisfred | I am running the tests now :) | 20:31 |
| nessita | hehe | 20:31 |
| thisfred | nessita: reviewing two branches at the same time ;) | 20:31 |
| nessita | thisfred: awesome, tests will not run if not in precise with our nightlies | 20:31 |
| nessita | já! been there, done that | 20:31 |
| thisfred | nessita: ./run-tets does nothing? | 20:31 |
| nessita | thisfred: does everything if you are in precise with our nightlies | 20:32 |
| nessita | thisfred:crashes otherwsie | 20:32 |
| thisfred | mmm, I'm pretty sure I have the nightlies | 20:32 |
| thisfred | but it returns immediately, no warnings nothing | 20:32 |
| nessita | no? :-/ | 20:33 |
| nessita | thisfred: can you please paste the output of: | 20:33 |
| nessita | apt-cache policy python-twisted-core | 20:33 |
| dobey | nessita: twisted in precise has that now | 20:34 |
| dobey | nessita: but even if he had the wrong twisted, it should error out | 20:34 |
| thisfred | nessita: http://paste.ubuntu.com/846356/ | 20:34 |
| nessita | dobey: that looks old, no? ^ | 20:34 |
| dobey | no, that's new | 20:34 |
| nessita | it is? | 20:34 |
| nessita | you're right | 20:35 |
| dobey | yes. it's the twisted with the patch | 20:35 |
| dobey | hence the ubuntu1 bit :) | 20:35 |
| nessita | thisfred: any output at all? are you running ./run-tests | 20:35 |
| nessita | dobey: yes, just noticed that | 20:35 |
| thisfred | nessita: I am running exactly that, and no output at all, it just immediately returns | 20:36 |
| dobey | and even still, run-tests has echos | 20:36 |
| dobey | which means something is really broken if no output | 20:36 |
| nessita | right | 20:36 |
| dobey | thisfred: what is $? after it exits? | 20:36 |
| nessita | thisfred: I smell PICNIC, but not sure how to help you confirm it | 20:36 |
| thisfred | dobey: huwha? | 20:38 |
| ralsina | nessita: +1 | 20:38 |
| ralsina | thisfred: sh -x run-tests ? | 20:39 |
| thisfred | dobey: nessita It does fail, because ./run-tests && echo "success" prints nothing | 20:39 |
| ralsina | without the ? of course ;-) | 20:39 |
| dobey | thisfred: ./run-tests; echo $? | 20:39 |
| thisfred | http://pastebin.ubuntu.com/846368/ | 20:40 |
| dobey | hey, my menus are drawing correctly now it seems | 20:40 |
| thisfred | dobey: that just printed $ | 20:40 |
| ralsina | thisfred: are you on Ubuntu? ;-) | 20:41 |
| dobey | thisfred: weird | 20:41 |
| dobey | thisfred: apt-get install xvfb | 20:41 |
| JackyAlcine | I wonder if anyone'd be willing to make a Ubuntu One client in Qt. :P | 20:41 |
| thisfred | ralsina: http://pastebin.ubuntu.com/846368/ fwiw | 20:41 |
| nessita | dobey: is that the issue? :-( | 20:41 |
| dobey | JackyAlcine: what do you mean by client? | 20:41 |
| ralsina | JackyAlcine: amazingly, we are :-) | 20:41 |
| dobey | nessita: looks like it; but no idea why it's acting that way | 20:41 |
| nessita | JackyAlcine: you mean besides the one we already have? | 20:41 |
| JackyAlcine | O.o that's done in Qt? | 20:41 |
| ralsina | thisfred: you are missing xvfb | 20:41 |
| thisfred | kk | 20:42 |
| * JackyAlcine goes to check. | 20:42 | |
| ralsina | JackyAlcine: the one we released on tuesday is! | 20:42 |
| JackyAlcine | It's been a while. | 20:42 |
| dobey | JackyAlcine: ubuntuone-control-panel-qt ? | 20:42 |
| thisfred | should have run builddeps first I guess | 20:42 |
| * JackyAlcine rolls around on the floor. | 20:42 | |
| nessita | JackyAlcine: released yesterday to Ubuntu precise | 20:42 |
| JackyAlcine | Lol, I didn't check it that recently! | 20:42 |
| JackyAlcine | Ah, for precise. | 20:42 |
| JackyAlcine | Well, I'll have to wait then. | 20:42 |
| nessita | JackyAlcine: https://launchpad.net/ubuntu/+archive/primary/+files/ubuntuone-control-panel-qt_2.99.4-0ubuntu1_all.deb | 20:42 |
| ralsina | JackyAlcine: coming eventually someday to Natty and Oneiric. Maybe. | 20:42 |
| JackyAlcine | You think it'd fit with Kubuntu? I've always wanted to use Ubuntu One in Kubutnu. | 20:42 |
| dobey | fit how? | 20:42 |
| dobey | we don't have dolphin integration or anything | 20:43 |
| ralsina | JackyAlcine: Ubuntu One works just fine in Ubuntu, except for no dolphin integration | 20:43 |
| JackyAlcine | Hmm, sounds like someone needs to implement that then. | 20:43 |
| ralsina | JackyAlcine: I meant "in Kubuntu" | 20:43 |
| * JackyAlcine has a new project. | 20:43 | |
| ralsina | JackyAlcine: or live without it. I don't miss it! ;-) | 20:43 |
| JackyAlcine | Well, it'd be nice to have the music I have here on Kubuntu sync'd with U1 and then onto my phone. | 20:44 |
| nessita | JackyAlcine: we haven't explicitely tested it in Kubuntu, though some tweaks are very likely needed, specially in the package dependency bits (control panel depends on ubuntu-sso-client which depends on a freedesktop secrets service, and for now we list explicetly gnome-keyring) | 20:44 |
| JackyAlcine | When I used GNOME 2, I had that convenience | 20:44 |
| bdmurray | On Precise the ubuntuone plugin wasn't enabled in rhythmbox and I don't recall ever disabling it. This is a system that has gone through multiple upgrades. | 20:44 |
| JackyAlcine | g-c-c, you mean? or the KDE's SystemSettings? | 20:44 |
| ralsina | bdmurray: is it installed and disabled, or not installed? | 20:45 |
| bdmurray | ralsina: installed and disabled | 20:45 |
| dobey | bdmurray: yep | 20:45 |
| ralsina | bdmurray: no idea. Maybe dobey knows | 20:45 |
| thisfred | nessita: all tests green | 20:45 |
| nessita | thisfred: YEY | 20:46 |
| dobey | bdmurray: https://bugs.launchpad.net/ubuntu/+source/rhythmbox-ubuntuone/+bug/934235 | 20:46 |
| nessita | oops sso nightlies are not building! /me fixes | 20:46 |
| bdmurray | dobey: thanks | 20:49 |
| nessita | dobey: would you trivialy-please https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/fix-nightlies/+merge/93647 ? | 20:50 |
| dobey | ugh, why did unity start opening windows at +0+0 | 20:50 |
| dobey | nessita: done | 20:53 |
| nessita | thanks! | 20:53 |
| nessita | dobey: does this bug require a FFe? https://bugs.launchpad.net/ubuntuone-client/+bug/851810 | 20:59 |
| nessita | (I think so, but want to confirm) | 20:59 |
| dobey | nessita: it requires adding API? | 21:02 |
| nessita | dobey: a new dbus signal, yes | 21:03 |
| dobey | then yeah, would require a FFE i think | 21:03 |
| elopio | to what package do I assign a bug with the scrollbars and the U1 gtk control panel? | 21:07 |
| dobey | it's already filed | 21:09 |
| dobey | but ubuntuone-control-panel | 21:09 |
| elopio | dobey: really? bug #915190 ? | 21:10 |
| dobey | elopio: i guess so. is that the bug you're seeing? | 21:10 |
| elopio | dobey: yes. Let me dist-upgrade and check again. | 21:11 |
| nessita | elopio: gtk control panel is no more... :-) | 21:13 |
| elopio | nessita: it is going to be on oneiric for a while, isn't it? | 21:14 |
| dobey | elopio: you get the bug on oneiric? | 21:15 |
| nessita | elopio: well, according to the plan, we should backport all the qt apps that we're making work on Linux | 21:15 |
| nessita | elopio: as far as I know, we have no plans to maintaining the gtk panel backwards.... but perhaps I'm wrong? | 21:15 |
| ralsina | no plans | 21:15 |
| ralsina | unless we fail miserably at backporting | 21:15 |
| elopio | dobey: I haven't checked. I was asking to see if I should triage on oneiric. | 21:15 |
| elopio | anyway, I thought the problem was with the overlay, not with the control panel. | 21:16 |
| dobey | elopio: i've only seen reports of it on 12.04 | 21:16 |
| dobey | alecu: it could be an issue with overlsay scrollbar. i'm not sure exactly | 21:16 |
| elopio | nessita, ralsina, so do you want me to mark as won't fix all gtk issues? | 21:17 |
| nessita | elopio: I woulod say not yet, until we definitely resolve the Qt situation | 21:18 |
| nessita | which is, atm, uncertain | 21:18 |
| elopio | ok. I saw you tagging them. I'll do that. | 21:18 |
| elopio | nessita: what was the tag? gtk-ui? | 21:19 |
| nessita | elopio: yes! | 21:19 |
| alecu | dobey, what "could be an issue with overlsay scrollbar" ? | 21:22 |
| ralsina | ok, eod for me! | 21:24 |
| ralsina | I work on monday, so leaveme anything you want worked on! | 21:24 |
| dobey | alecu: the scrollbar bugs in gtk control panel | 21:25 |
| alecu | dobey, you probably didn't mean me at that point, right? | 21:25 |
| dobey | alecu: no | 21:28 |
| dobey | alecu: oh, sorry. ment elopio :) | 21:28 |
| elopio | dobey started drinking too soon. | 21:28 |
| dobey | i wish | 21:28 |
| elopio | or maybe you should :) | 21:28 |
| dobey | indeed | 21:29 |
| alecu | this looks like an EOW for me! | 21:35 |
| alecu | bye guys and gal, see you on tue. | 21:36 |
| briancurtin | enjoy the weekend alecu | 21:36 |
| gatox | EOW for me! | 21:43 |
| nessita | and for me! | 21:43 |
| gatox | briancurtin, are you free for a review? | 21:44 |
| briancurtin | gatox: sure, whats the link? | 21:44 |
| gatox | ahhhh it's a qt thingy.... maybe ralsina better if he is still around | 21:44 |
| gatox | briancurtin, thanks anyway | 21:44 |
| nessita | gatox: send ralsina an email, he may be able to do that later | 21:47 |
| gatox | nessita, ok | 21:47 |
| nessita | I already approved it | 21:47 |
| dobey | nessita: i added some more tests :-/ | 21:47 |
| nessita | dobey: I'm late for my pilates class, will try to review later today (or tom morning) | 21:47 |
| nessita | bye all! | 21:48 |
| dobey | ok | 21:48 |
| === m_conley is now known as m_conley_away | ||
| elopio | dobey: yes, there are still crazy scroll bars. | 22:30 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!